Re: [PATCH v2 01/16] video: amba-clcd: use devm_of_find_backlight

2020-05-18 Thread Linus Walleij
On Sun, May 17, 2020 at 9:01 PM Sam Ravnborg wrote: > Look up backlight device using devm_of_find_backlight(). > This simplifies the code and prevents us from hardcoding > the node name in the driver. > > v2: > - Added Cc: Peter Ujfalusi > > Signed-off-by: Sam Ravnborg > Cc: Russell King > Cc

Re: [PATCH 1/2] drm/shmem: Use cached mappings by default

2020-05-18 Thread Thomas Zimmermann
Hi Am 15.05.20 um 16:10 schrieb Daniel Vetter: > On Fri, May 15, 2020 at 08:58:02AM +0200, Thomas Zimmermann wrote: >> Hi >> >> Am 14.05.20 um 22:36 schrieb Rob Herring: >>> On Thu, May 14, 2020 at 7:40 AM Daniel Vetter wrote: On Wed, May 13, 2020 at 05:03:11PM +0200, Thomas Zimmermann

Re: [PATCH 1/2] drm/shmem: Use cached mappings by default

2020-05-18 Thread Gerd Hoffmann
> > $ git grep drm_gem_shmem_mmap > > > > We also need correct access from userspace, otherwise the gpu is going to > > be sad. > > I've been thinking about this, and I think it means that we can never > have cached mappings anywhere. Even if shmem supports it internally for > most drivers, as so

[PATCH] drm: print the current->comm alongside the pid

2020-05-18 Thread Emil Velikov
From: Emil Velikov The question of "what process is this pid" keeps on popping up, so lets print the process name alongside the pid. Cc: Mauro Rossi Cc: Bob Beckett Cc: Pekka Paalanen Signed-off-by: Emil Velikov --- drivers/gpu/drm/drm_file.c | 7 --- drivers/gpu/drm/drm_ioc32.c | 4

[PATCH] drm/file: wrap excessively long line

2020-05-18 Thread Emil Velikov
From: Emil Velikov Signed-off-by: Emil Velikov --- drivers/gpu/drm/drm_file.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_file.c b/drivers/gpu/drm/drm_file.c index 9b79bfc60ad7..97f7793b693f 100644 --- a/drivers/gpu/drm/drm_file.c +++ b/drivers/gpu/

Re: [PATCH] drm/etnaviv: fix perfmon domain interation

2020-05-18 Thread Christian Gmeiner
Hi Lucas, Am So., 17. Mai 2020 um 14:03 Uhr schrieb Lucas Stach : > > Hi Christian, > > Am Montag, den 11.05.2020, 14:37 +0200 schrieb Christian Gmeiner: > > The GC860 has one GPU device which has a 2d and 3d core. In this case > > we want to expose perfmon information for both cores. > > > > The

Re: [PATCH 1/2] drm/shmem: Use cached mappings by default

2020-05-18 Thread Thomas Zimmermann
Hi Gerd Am 18.05.20 um 10:23 schrieb Gerd Hoffmann: >>> $ git grep drm_gem_shmem_mmap >>> >>> We also need correct access from userspace, otherwise the gpu is going to >>> be sad. >> >> I've been thinking about this, and I think it means that we can never >> have cached mappings anywhere. Even if

Re: [PATCH v2] drm/debugfs: fix plain echo to connector "force" attribute

2020-05-18 Thread Jani Nikula
On Sun, 17 May 2020, Emil Velikov wrote: > On Thu, 17 Aug 2017 at 12:34, Jani Nikula wrote: >> >> On Thu, 17 Aug 2017, Michael Tretter wrote: >> > Using plain echo to set the "force" connector attribute fails with >> > -EINVAL, because echo appends a newline to the output. >> > >> > Replace strc

Re: [PATCH] drm/file: wrap excessively long line

2020-05-18 Thread Jani Nikula
On Mon, 18 May 2020, Emil Velikov wrote: > From: Emil Velikov > > Signed-off-by: Emil Velikov Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/drm_file.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/drm_file.c b/drivers/gpu/drm/drm_file.c > index

Re: [PATCH v12 00/14] In order to readout DP SDPs, refactors the handling of DP SDPs

2020-05-18 Thread Jani Nikula
On Fri, 15 May 2020, "Mun, Gwan-gyeong" wrote: > Hi Ville, > Thank you for notifying me that. I definitely missed the crash. > Sorry for that. > Danial and Jani, I' under debugging the crash case. > If you are availabe please do not merge current version. It has been merged, and that's the oops i

Re: [PATCH 1/2] drm/shmem: Use cached mappings by default

2020-05-18 Thread Gerd Hoffmann
On Mon, May 18, 2020 at 10:50:15AM +0200, Thomas Zimmermann wrote: > Hi Gerd > > Am 18.05.20 um 10:23 schrieb Gerd Hoffmann: > >>> $ git grep drm_gem_shmem_mmap > >>> > >>> We also need correct access from userspace, otherwise the gpu is going to > >>> be sad. > >> > >> I've been thinking about th

Re: [PATCH v10 0/2] Panel rotation patches

2020-05-18 Thread Dmitry Osipenko
12.05.2020 23:59, Sean Paul пишет: > On Thu, Apr 16, 2020 at 7:03 PM Dmitry Osipenko wrote: >> >> 15.04.2020 00:32, dbasehore . пишет: >>> On Tue, Apr 14, 2020 at 2:18 PM Dmitry Osipenko wrote: 14.04.2020 22:32, dbasehore . пишет: > Hi Dmitry, sorry for the late reply. > > O

[PATCH] drm/mm: Fix an error handling path in '__igt_once()'

2020-05-18 Thread Christophe JAILLET
The label of the last gotos must be switched for the error handling code to work as expected. Fixes: 83bc4ec37210 ("drm/mm: Add a search-by-address variant to only inspect a single hole") Signed-off-by: Christophe JAILLET --- drivers/gpu/drm/selftests/test-drm_mm.c | 4 ++-- 1 file changed, 2 i

Re: [PATCH 05/12] gpu/drm: Ingenic: Fix opaque pointer casted to wrong type

2020-05-18 Thread Paul Cercueil
Hi Sam, Le dim. 17 mai 2020 à 8:21, Sam Ravnborg a écrit : On Sat, May 16, 2020 at 11:50:50PM +0200, Paul Cercueil wrote: The opaque pointer passed to the IRQ handler is a pointer to the drm_device, not a pointer to our ingenic_drm structure. It still worked, because our ingenic_drm struct

Re: [PATCH v2 2/2] powerpc/configs: replace deprecated riva/nvidia with nouveau

2020-05-18 Thread Michael Ellerman
Emil Velikov writes: > As mentioned in earlier commit, the riva and nvidia fbdev drivers have > seen no love over the years, are short on features and overall below par > > Users are encouraged to switch to the nouveau drm driver instead. > > v2: Split configs to separate patch, enable nouveau (Ba

Re: [PATCH V3 07/15] arch/kunmap_atomic: Consolidate duplicate code

2020-05-18 Thread Guenter Roeck
On Sun, May 17, 2020 at 08:49:39PM -0700, Ira Weiny wrote: > On Sat, May 16, 2020 at 03:33:06PM -0700, Guenter Roeck wrote: > > On Thu, May 07, 2020 at 07:59:55AM -0700, ira.we...@intel.com wrote: > > > From: Ira Weiny > > > > > > Every single architecture (including !CONFIG_HIGHMEM) calls... > >

Re: [PATCH 02/12] dt-bindings: display: Add ingenic,ipu.yaml

2020-05-18 Thread Paul Cercueil
Hi Sam, Le dim. 17 mai 2020 à 8:17, Sam Ravnborg a écrit : Hi Paul. On Sat, May 16, 2020 at 11:50:47PM +0200, Paul Cercueil wrote: Add documentation of the Device Tree bindings for the Image Processing Unit (IPU) found in most Ingenic SoCs. Signed-off-by: Paul Cercueil For me it fails

Re: [PATCH 04/12] gpu/drm: ingenic: Fix bogus crtc_atomic_check callback

2020-05-18 Thread Paul Cercueil
Hi Sam, Le dim. 17 mai 2020 à 8:17, Sam Ravnborg a écrit : On Sat, May 16, 2020 at 11:50:49PM +0200, Paul Cercueil wrote: The code was comparing the SoC's maximum height with the mode's width, and vice-versa. D'oh. Cc: sta...@vger.kernel.org # v5.6 Fixes: a7c909b7c037 ("gpu/drm: ingenic:

Re:Re: Re:Re: [PATCH v2] drm/arm: fixes pixel clock enabled with wrong format

2020-05-18 Thread Bernard
发件人:Liviu Dudau 发送日期:2020-05-15 22:41:49 收件人:Bernard 抄送人:Brian Starkey ,David Airlie ,Daniel Vetter ,dri-devel@lists.freedesktop.org,linux-ker...@vger.kernel.org,opensource.ker...@vivo.com 主题:Re: Re:Re: [PATCH v2] drm/arm: fixes pixel clock enabled with wrong format>Hi Bernard, > >On Fri, May

Re: [PATCH V3 10/15] arch/kmap: Define kmap_atomic_prot() for all arch's

2020-05-18 Thread Guenter Roeck
Hi, On Thu, May 07, 2020 at 07:59:58AM -0700, ira.we...@intel.com wrote: > From: Ira Weiny > > To support kmap_atomic_prot(), all architectures need to support > protections passed to their kmap_atomic_high() function. Pass > protections into kmap_atomic_high() and change the name to > kmap_ato

[PATCH] Lenovo X13 Yoga OLED panel brightness fix

2020-05-18 Thread Mark Pearson
Hi, Patch to fix an issue controlling the brightness of the OLED panel on the Lenovo X13 Yoga Please let me know any feedback or questions. Mark Pearson - Add another panel that needs the edid quirk to the list so that brightness control works correctly. Fixes iss

Re: [PATCH v2 01/16] video: amba-clcd: use devm_of_find_backlight

2020-05-18 Thread Sam Ravnborg
Hi Linus. On Mon, May 18, 2020 at 10:10:12AM +0200, Linus Walleij wrote: > On Sun, May 17, 2020 at 9:01 PM Sam Ravnborg wrote: > > > Look up backlight device using devm_of_find_backlight(). > > This simplifies the code and prevents us from hardcoding > > the node name in the driver. > > > > v2:

Re: [PATCH v2] drm/debugfs: fix plain echo to connector "force" attribute

2020-05-18 Thread Emil Velikov
On Mon, 18 May 2020 at 10:22, Jani Nikula wrote: > > On Sun, 17 May 2020, Emil Velikov wrote: > > On Thu, 17 Aug 2017 at 12:34, Jani Nikula > > wrote: > >> > >> On Thu, 17 Aug 2017, Michael Tretter wrote: > >> > Using plain echo to set the "force" connector attribute fails with > >> > -EINVAL,

Re: [PATCH 11/12] gpu/drm: Ingenic: Add support for the IPU

2020-05-18 Thread Emil Velikov
Hi Paul, Disclaimer: I don't know much about the hardware :-P On Sun, 17 May 2020 at 00:31, Paul Cercueil wrote: > > Add support for the Image Processing Unit (IPU) found in all Ingenic > SoCs. > Since the IPU is present on all devices supported, does it make sense to have it as separate module?

Re: [PATCH v2 2/2] powerpc/configs: replace deprecated riva/nvidia with nouveau

2020-05-18 Thread Emil Velikov
Hi Benjamin, On Mon, 18 May 2020 at 01:45, Benjamin Herrenschmidt wrote: > > On Sun, 2020-05-17 at 23:05 +0100, Emil Velikov wrote: > > As mentioned in earlier commit, the riva and nvidia fbdev drivers > > have > > seen no love over the years, are short on features and overall below > > par > > >

Re: [PATCH 1/3] drm/arm: Kconfig annotate drivers as COMPILE_TEST

2020-05-18 Thread Liviu Dudau
On Sun, May 17, 2020 at 08:36:53PM +0100, Emil Velikov wrote: > Add the COMPILE_TEST conditional, so that people can at least build test > the drivers. > > Cc: Liviu Dudau Acked-by: Liviu Dudau > Cc: Brian Starkey > Cc: Mali DP Maintainers > Cc: dri-devel@lists.freedesktop.org > Signed-off-b

Re: [PATCH v3 1/4] dma-buf: add support for virtio exported objects

2020-05-18 Thread Sumit Semwal
Hello David, On Fri, 15 May 2020 at 19:33, Daniel Vetter wrote: > > On Fri, May 15, 2020 at 02:07:06PM +0900, David Stevens wrote: > > On Thu, May 14, 2020 at 9:30 PM Daniel Vetter wrote: > > > On Thu, May 14, 2020 at 05:19:40PM +0900, David Stevens wrote: > > > > Sorry for the duplicate reply,

Re: [PATCH v2 2/2] powerpc/configs: replace deprecated riva/nvidia with nouveau

2020-05-18 Thread Emil Velikov
Hi Michael, On Mon, 18 May 2020 at 08:30, Michael Ellerman wrote: > > Emil Velikov writes: > > As mentioned in earlier commit, the riva and nvidia fbdev drivers have > > seen no love over the years, are short on features and overall below par > > > > Users are encouraged to switch to the nouveau

[PATCH] drm/mediatek: Delete not used of_device_get_match_data

2020-05-18 Thread matthias . bgg
From: Matthias Brugger The driver will be loaded by via a platform device. So we will need to get the device_node from the parent device. Depending on this we will set the driver data. As all this is done later already, just delete the call to of_device_get_match_data. Signed-off-by: Matthias Br

[PATCH] drm/etnaviv: Fix a leak in submit_pin_objects()

2020-05-18 Thread Dan Carpenter
If the mapping address is wrong then we have to release the reference to it before returning -EINVAL. Fixes: 00ddc0b2 ("drm/etnaviv: implement softpin") Signed-off-by: Dan Carpenter --- >From static analysis. Untested. drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c | 4 +++- 1 file changed,

Re: [PATCH v2 2/2] powerpc/configs: replace deprecated riva/nvidia with nouveau

2020-05-18 Thread Benjamin Herrenschmidt
On Mon, 2020-05-18 at 12:00 +0100, Emil Velikov wrote: > I believe you reported issues due to different page size for the CPU/GPU. > Have you tried nouveau recently, there has been a handful of patches > on the topic since your report. > > Alternatively, it would make sense you rebase, cleanup and

Re: [PATCH v2 2/2] powerpc/configs: replace deprecated riva/nvidia with nouveau

2020-05-18 Thread Benjamin Herrenschmidt
On Mon, 2020-05-18 at 12:19 +0100, Emil Velikov wrote: > > - attempted out-of-bound attempts to read the vbios So on these things, the actual ROM doesn't contain what you want, but the device-tree has a property "NVDA,BMP" that contains some kind of mini-BIOS (around 2.4KB) which should contain

Re: [PATCH v2 2/2] powerpc/configs: replace deprecated riva/nvidia with nouveau

2020-05-18 Thread Bartlomiej Zolnierkiewicz
On 5/18/20 1:19 PM, Emil Velikov wrote: > Hi Michael, > > On Mon, 18 May 2020 at 08:30, Michael Ellerman wrote: >> >> Emil Velikov writes: >>> As mentioned in earlier commit, the riva and nvidia fbdev drivers have >>> seen no love over the years, are short on features and overall below par >>>

Re: [PATCH v2 2/2] powerpc/configs: replace deprecated riva/nvidia with nouveau

2020-05-18 Thread Emil Velikov
On Mon, 18 May 2020 at 13:48, Bartlomiej Zolnierkiewicz wrote: > > > On 5/18/20 1:19 PM, Emil Velikov wrote: > > Hi Michael, > > > > On Mon, 18 May 2020 at 08:30, Michael Ellerman wrote: > >> > >> Emil Velikov writes: > >>> As mentioned in earlier commit, the riva and nvidia fbdev drivers have >

Re: [PATCH v2 2/2] powerpc/configs: replace deprecated riva/nvidia with nouveau

2020-05-18 Thread Andreas Schwab
On Mai 18 2020, Michael Ellerman wrote: > The old drivers may be crufty but they presumably have been tested by > people and at least somewhat work. I can confirm that the nvidia fbdev driver is working perfectly fine. > I gave it a quick spin on a G5 I have access to and dmesg has a bunch of >

[PATCH 1/2] drm: DPMS is no longer the only mutable connector prop

2020-05-18 Thread Simon Ser
There are a bunch of other writable connector properties now. Signed-off-by: Simon Ser Cc: Daniel Vetter Cc: Ville Syrjala Cc: Pekka Paalanen Cc: Michel Dänzer --- drivers/gpu/drm/drm_connector.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_connec

[PATCH 2/2] drm: add docs for standard CRTC properties

2020-05-18 Thread Simon Ser
This patch adds docs for the ACTIVE and MODE_ID CRTC properties. Signed-off-by: Simon Ser Cc: Daniel Vetter Cc: Ville Syrjala Cc: Pekka Paalanen Cc: Michel Dänzer --- Let me know if you think of other things to add. Should we refer to ALLOW_MODESET in the MODE_ID docs? Documentation/gpu/d

Re: [PATCH 5/6] drm: msm: a6xx: use dev_pm_opp_set_bw to set DDR bandwidth

2020-05-18 Thread Jordan Crouse
On Thu, May 14, 2020 at 04:24:18PM +0530, Sharat Masetty wrote: > This patches replaces the previously used static DDR vote and uses > dev_pm_opp_set_bw() to scale GPU->DDR bandwidth along with scaling > GPU frequency. > > Signed-off-by: Sharat Masetty > --- > drivers/gpu/drm/msm/adreno/a6xx_gmu

Re: [PATCH v6 00/16] drm/i915: Add support for HDCP 1.4 over MST connectors

2020-05-18 Thread Sean Paul
On Fri, May 15, 2020 at 10:48 AM Ramalingam C wrote: > > On 2020-04-29 at 15:54:46 -0400, Sean Paul wrote: > > From: Sean Paul > > > > Changes in v6: > > -Rebased on -tip > > -Disabled HDCP over MST on GEN12 > > -Addressed Lyude's review comments in the QUERY_STREAM_ENCRYPTION_STATUS > > patch >

Re: [PATCH 2/2] drm/msm/a4xx: add a405_registers for a405 device

2020-05-18 Thread Jordan Crouse
On Sat, May 09, 2020 at 08:38:46PM +0800, Shawn Guo wrote: > A405 device has a different set of registers than a4xx_registers. It > has no VMIDMT or XPU registers, and VBIF registers are different. Let's > add a405_registers for a405 device. > > As adreno_is_a405() works only after adreno_gpu_in

Re: [PATCH 2/2] dt-bindings: arm-smmu: Add sc7180 compatible string

2020-05-18 Thread Will Deacon
On Fri, May 15, 2020 at 12:05:39PM -0700, Doug Anderson wrote: > On Fri, May 1, 2020 at 3:30 AM Sharat Masetty wrote: > > > > This patch simply adds a new compatible string for SC7180 platform. > > > > Signed-off-by: Sharat Masetty > > --- > > Documentation/devicetree/bindings/iommu/arm,smmu.yam

Re: [PATCH 1/2] drm/msm/a4xx: add adreno a405 support

2020-05-18 Thread Jordan Crouse
On Sat, May 09, 2020 at 08:38:45PM +0800, Shawn Guo wrote: > It adds support for adreno a405 found on MSM8939. The adreno_is_a430() > check in adreno_submit() needs an extension to cover a405. The > downstream driver suggests it should cover the whole a4xx generation. > That's why it gets changed

Re: [PATCH 1/2] drm/shmem: Use cached mappings by default

2020-05-18 Thread Daniel Vetter
On Mon, May 18, 2020 at 12:11:32PM +0200, Gerd Hoffmann wrote: > On Mon, May 18, 2020 at 10:50:15AM +0200, Thomas Zimmermann wrote: > > Hi Gerd > > > > Am 18.05.20 um 10:23 schrieb Gerd Hoffmann: > > >>> $ git grep drm_gem_shmem_mmap > > >>> > > >>> We also need correct access from userspace, othe

Re: [PATCH 1/4] drm: Include internal header for managed function declarations

2020-05-18 Thread Daniel Vetter
On Sat, May 16, 2020 at 10:23:27PM +0100, Chris Wilson wrote: > drivers/gpu/drm/drm_managed.c:61:6: warning: symbol 'drm_managed_release' was > not declared. Should it be static? > CC drivers/gpu/drm/drm_managed.o > drivers/gpu/drm/drm_managed.c:61:6: warning: no previous prototype for > ‘

Re: [Freedreno] [PATCH v3 1/9] drm/msm: add msm_gem_get_and_pin_iova_range

2020-05-18 Thread Jordan Crouse
On Thu, Apr 23, 2020 at 05:09:13PM -0400, Jonathan Marek wrote: > This function allows pinning iova to a specific page range (for a6xx GMU). Reviewed-by: Jordan Crouse > Signed-off-by: Jonathan Marek > --- > drivers/gpu/drm/msm/msm_drv.h | 6 +- > drivers/gpu/drm/msm/msm_gem.c | 2

Re: [PATCH v3 6/9] drm/msm/a6xx: A640/A650 GMU firmware path

2020-05-18 Thread Jordan Crouse
On Thu, Apr 23, 2020 at 05:09:18PM -0400, Jonathan Marek wrote: > Newer GPUs have different GMU firmware path. > > v3: updated a6xx_gmu_fw_load based on feedback, including gmu_write_bulk, > and removed extra whitespace change I'm not sure if you sent the XML updates to Rob yet, but don't forget

Re: [PATCH v3 9/9] drm/msm/a6xx: update a6xx_hw_init for A640 and A650

2020-05-18 Thread Jordan Crouse
On Thu, Apr 23, 2020 at 05:09:21PM -0400, Jonathan Marek wrote: > Adreno 640 and 650 GPUs need some registers set differently. As before, make sure you send the XML updates up so the database stays current. Reviewed-by: Jordan Crouse > Signed-off-by: Jonathan Marek > --- > drivers/gpu/drm/msm

Re: [PATCH v3 7/9] drm/msm/a6xx: update pdc/rscc GMU registers for A640/A650

2020-05-18 Thread Jordan Crouse
On Thu, Apr 23, 2020 at 05:09:19PM -0400, Jonathan Marek wrote: > Update the gmu_pdc registers for A640 and A650. > > Some of the RSCC registers on A650 are in a separate region. > > Note this also changes the address of these registers: > > RSCC_TCS1_DRV0_STATUS > RSCC_TCS2_DRV0_STATUS > RSCC_T

Re: [PATCH 2/4] drm: Help unconfuse gcc, avoid accidental impossible unsigned comparisons

2020-05-18 Thread Daniel Vetter
On Sat, May 16, 2020 at 10:23:28PM +0100, Chris Wilson wrote: > drivers/gpu/drm/drm_client_modeset.c: In function > ‘drm_client_firmware_config’: > ./include/linux/bits.h:26:28: warning: comparison of unsigned expression < 0 > is always false [-Wtype-limits] >__builtin_constant_p((l) > (h)),

Re: [PATCH 3/4] drm: Describe dp_rev for drm_dp_set_phy_test_pattern

2020-05-18 Thread Daniel Vetter
On Sat, May 16, 2020 at 10:23:29PM +0100, Chris Wilson wrote: > drivers/gpu/drm/drm_dp_helper.c:1598: warning: Function parameter or member > 'dp_rev' not described in 'drm_dp_set_phy_test_pattern' > > Signed-off-by: Chris Wilson Reviewed-by: Daniel Vetter > --- > drivers/gpu/drm/drm_dp_help

Re: [PATCH v5 0/6] drm: Prepare to use a GPIO on ti-sn65dsi86 for Hot Plug Detect

2020-05-18 Thread Doug Anderson
Sam, On Sat, May 9, 2020 at 3:48 PM Doug Anderson wrote: > > Hi, > > On Sat, May 9, 2020 at 1:15 PM Sam Ravnborg wrote: > > > > Hi Douglas. > > > > On Thu, May 07, 2020 at 02:34:54PM -0700, Douglas Anderson wrote: > > > > > > As talked about in commit c2bfc223882d ("drm/bridge: ti-sn65dsi86: > >

Re: [PATCH 2/4] drm: Help unconfuse gcc, avoid accidental impossible unsigned comparisons

2020-05-18 Thread Chris Wilson
Quoting Daniel Vetter (2020-05-18 15:47:44) > On Sat, May 16, 2020 at 10:23:28PM +0100, Chris Wilson wrote: > > drivers/gpu/drm/drm_client_modeset.c: In function > > ‘drm_client_firmware_config’: > > ./include/linux/bits.h:26:28: warning: comparison of unsigned expression < > > 0 is always false

Re: [PATCH v2 02/16] backlight: refactor fb_notifier_callback()

2020-05-18 Thread Daniel Thompson
On Sun, May 17, 2020 at 09:01:25PM +0200, Sam Ravnborg wrote: > Increase readability of fb_notifier_callback() by removing > a few indent levels. > No functional change. > > Signed-off-by: Sam Ravnborg > Cc: Lee Jones > Cc: Daniel Thompson > Cc: Jingoo Han Reviewed-by: Daniel Thompson > --

Re: [PATCH v2 03/16] backlight: add backlight_is_blank()

2020-05-18 Thread Daniel Thompson
On Sun, May 17, 2020 at 09:01:26PM +0200, Sam Ravnborg wrote: > The backlight support has two properties that express the state: > - power > - state > > It is un-documented and easy to get wrong. > Add backlight_is_blank() helper to make it simpler for drivers > to get the check of the state corre

Re: [PATCH 4/4] drm: Match drm_dp_send_clear_payload_id_table definition to declaration

2020-05-18 Thread Daniel Vetter
On Sat, May 16, 2020 at 10:23:30PM +0100, Chris Wilson wrote: > drivers/gpu/drm/drm_dp_mst_topology.c:2898:6: warning: symbol > 'drm_dp_send_clear_payload_id_table' was not declared. Should it be static? Compiler seems a bit confused, because there is a static declaration a bit further up. So sho

Re: [PATCH v2 04/16] backlight: improve backlight_ops documentation

2020-05-18 Thread Daniel Thompson
On Sun, May 17, 2020 at 09:01:27PM +0200, Sam Ravnborg wrote: > Improve the documentation for backlight_ops and > adapt it to kernel-doc style. > > Signed-off-by: Sam Ravnborg > Cc: Lee Jones > Cc: Daniel Thompson > Cc: Jingoo Han Reviewed-by: Daniel Thompson > --- > include/linux/backlig

Re: [PATCH] drm: print the current->comm alongside the pid

2020-05-18 Thread Daniel Vetter
On Mon, May 18, 2020 at 09:33:15AM +0100, Emil Velikov wrote: > From: Emil Velikov > > The question of "what process is this pid" keeps on popping up, so lets > print the process name alongside the pid. > > Cc: Mauro Rossi > Cc: Bob Beckett > Cc: Pekka Paalanen > Signed-off-by: Emil Velikov

Re: [PATCH] drm/mediatek: Delete not used of_device_get_match_data

2020-05-18 Thread Chun-Kuang Hu
Hi, Matthias: 於 2020年5月18日 週一 下午7:23寫道: > > From: Matthias Brugger > > The driver will be loaded by via a platform device. So we > will need to get the device_node from the parent device. > Depending on this we will set the driver data. > As all this is done later already, just delete the call t

Re: [PATCH v2 05/16] backlight: improve backlight_properties documentation

2020-05-18 Thread Daniel Thompson
On Sun, May 17, 2020 at 09:01:28PM +0200, Sam Ravnborg wrote: > Improve the documentation for backlight_properties and > adapt it to kernel-doc style. > > Signed-off-by: Sam Ravnborg > Cc: Lee Jones > Cc: Daniel Thompson > Cc: Jingoo Han Overall looks good but enough nits that I felt compelle

Re: [PATCH v2 06/16] backlight: improve backlight_device documentation

2020-05-18 Thread Daniel Thompson
On Sun, May 17, 2020 at 09:01:29PM +0200, Sam Ravnborg wrote: > Improve the documentation for backlight_device and > adapt it to kernel-doc style. > > Signed-off-by: Sam Ravnborg > Cc: Lee Jones > Cc: Daniel Thompson > Cc: Jingoo Han > --- > include/linux/backlight.h | 81

Re: [PATCH v2 07/16] backlight: document inline functions in backlight.h

2020-05-18 Thread Daniel Thompson
On Sun, May 17, 2020 at 09:01:30PM +0200, Sam Ravnborg wrote: > Add documentation for the inline functions in backlight.h > > Signed-off-by: Sam Ravnborg > Cc: Lee Jones > Cc: Daniel Thompson > Cc: Jingoo Han > --- > include/linux/backlight.h | 16 > 1 file changed, 16 insert

Re: [PATCH v2 08/16] backlight: document enums in backlight.h

2020-05-18 Thread Daniel Thompson
On Sun, May 17, 2020 at 09:01:31PM +0200, Sam Ravnborg wrote: > Add kernel-doc documentation for the backlight enums > > Signed-off-by: Sam Ravnborg > Cc: Lee Jones > Cc: Daniel Thompson > Cc: Jingoo Han Other than the usual comment about the form in the kernel-doc howto: Reviewed-by: Daniel

Re: [PATCH v2 09/16] backlight: remove the unused backlight_bl driver

2020-05-18 Thread Daniel Thompson
On Sun, May 17, 2020 at 09:01:32PM +0200, Sam Ravnborg wrote: > The driver required initialization using struct generic_bl_info. > As there are no more references to this struct there is no users left. > So it is safe to delete the driver. > > Signed-off-by: Sam Ravnborg > Cc: Lee Jones > Cc: Da

Re: [PATCH v2 10/16] backlight: drop extern from prototypes

2020-05-18 Thread Daniel Thompson
On Sun, May 17, 2020 at 09:01:33PM +0200, Sam Ravnborg wrote: > No need to put "extern" in front of prototypes. > While touching the prototypes adjust indent to follow > the kernel style. > > Signed-off-by: Sam Ravnborg > Cc: Lee Jones > Cc: Daniel Thompson > Cc: Jingoo Han Reviewed-by: Danie

Re: [PATCH 2/4] drm: Help unconfuse gcc, avoid accidental impossible unsigned comparisons

2020-05-18 Thread Emil Velikov
On Sat, 16 May 2020 at 22:23, Chris Wilson wrote: > > drivers/gpu/drm/drm_client_modeset.c: In function > ‘drm_client_firmware_config’: > ./include/linux/bits.h:26:28: warning: comparison of unsigned expression < 0 > is always false [-Wtype-limits] >__builtin_constant_p((l) > (h)), (l) > (h)

Re: [Freedreno] [PATCH 5/6] drm: msm: a6xx: use dev_pm_opp_set_bw to set DDR bandwidth

2020-05-18 Thread Rob Clark
On Mon, May 18, 2020 at 7:23 AM Jordan Crouse wrote: > > On Thu, May 14, 2020 at 04:24:18PM +0530, Sharat Masetty wrote: > > This patches replaces the previously used static DDR vote and uses > > dev_pm_opp_set_bw() to scale GPU->DDR bandwidth along with scaling > > GPU frequency. > > > > Signed-o

Re: [PATCH 2/4] drm: Help unconfuse gcc, avoid accidental impossible unsigned comparisons

2020-05-18 Thread Chris Wilson
Quoting Emil Velikov (2020-05-18 17:23:21) > On Sat, 16 May 2020 at 22:23, Chris Wilson wrote: > > > > drivers/gpu/drm/drm_client_modeset.c: In function > > ‘drm_client_firmware_config’: > > ./include/linux/bits.h:26:28: warning: comparison of unsigned expression < > > 0 is always false [-Wtype-

Re: [PATCH v6 00/16] drm/i915: Add support for HDCP 1.4 over MST connectors

2020-05-18 Thread Ramalingam C
On 2020-05-18 at 10:32:09 -0400, Sean Paul wrote: > On Fri, May 15, 2020 at 10:48 AM Ramalingam C wrote: > > > > On 2020-04-29 at 15:54:46 -0400, Sean Paul wrote: > > > From: Sean Paul > > > > > > Changes in v6: > > > -Rebased on -tip > > > -Disabled HDCP over MST on GEN12 > > > -Addressed Lyude'

Re: [PATCH v2 11/16] backlight: add overview and update existing doc

2020-05-18 Thread Daniel Thompson
On Sun, May 17, 2020 at 09:01:34PM +0200, Sam Ravnborg wrote: > Add overview chapter to backlight.c. > Update existing kernel-doc to follow a more consistent > style and drop kernel-doc for deprecated functions. > > Signed-off-by: Sam Ravnborg > Cc: Lee Jones > Cc: Daniel Thompson > Cc: Jingoo

Re: [PATCH v2 12/16] backlight: wire up kernel-doc documentation

2020-05-18 Thread Daniel Thompson
On Sun, May 17, 2020 at 09:01:35PM +0200, Sam Ravnborg wrote: > Include backlight so the documentation is now generated > with make htmldocs and friends. > > Signed-off-by: Sam Ravnborg > Cc: Maarten Lankhorst > Cc: Maxime Ripard > Cc: Thomas Zimmermann > Cc: David Airlie > Cc: Daniel Vetter

Re: [PATCH v2 13/16] backlight: make of_find_backlight static

2020-05-18 Thread Daniel Thompson
On Sun, May 17, 2020 at 09:01:36PM +0200, Sam Ravnborg wrote: > There are no external users of of_find_backlight, > as they have all changed to use the managed version. > Make of_find_backlight static to prevent new external users. > > Signed-off-by: Sam Ravnborg > Cc: Lee Jones > Cc: Daniel Tho

Re: [PATCH v2 14/16] backlight: drop backlight_put()

2020-05-18 Thread Daniel Thompson
On Sun, May 17, 2020 at 09:01:37PM +0200, Sam Ravnborg wrote: > There are no external users of backlight_put(). > Drop it and open code the two users in backlight.c. > > Signed-off-by: Sam Ravnborg > Cc: Lee Jones > Cc: Daniel Thompson > Cc: Jingoo Han Reviewed-by: Daniel Thompson > --- >

Re: [PATCH v2 15/16] backlight: make of_find_backlight_by_node() static

2020-05-18 Thread Daniel Thompson
On Sun, May 17, 2020 at 09:01:38PM +0200, Sam Ravnborg wrote: > There are no external users of of_find_backlight_by_node(). > Make it static so we keep it that way. > > v2: > - drop EXPORT of of_find_backlight_by_node > > Signed-off-by: Sam Ravnborg > Cc: Lee Jones > Cc: Daniel Thompson > Cc

Re: [PATCH v2 16/16] backlight: use backlight_is_blank() in all backlight drivers

2020-05-18 Thread Daniel Thompson
On Sun, May 17, 2020 at 09:01:39PM +0200, Sam Ravnborg wrote: > Replaces the open-coded checks of the state etc., > with the backlight_is_blank() helper. > This increases readability of the code and align > the functionality across the drivers. > > v2: > - Fixed so changelog is readable > > Sig

Re: [PATCH v2 06/16] backlight: improve backlight_device documentation

2020-05-18 Thread Jani Nikula
On Mon, 18 May 2020, Daniel Thompson wrote: > On Sun, May 17, 2020 at 09:01:29PM +0200, Sam Ravnborg wrote: >> Improve the documentation for backlight_device and >> adapt it to kernel-doc style. >> >> Signed-off-by: Sam Ravnborg >> Cc: Lee Jones >> Cc: Daniel Thompson >> Cc: Jingoo Han >> ---

[PATCH][next] drm/i915: fix incorrect return of an error status

2020-05-18 Thread Colin King
From: Colin Ian King Currently when a call to intel_atomic_get_dbuf_state fails the error value being returns is a potentially uninitialized value in variable ret. Fix this by returning the error value of new_dbuf_state. Addresses-Coverity: ("Uninitialized scalar value") Fixes: 3cf43cdc63fb ("d

Re: [PATCH v4 7/7] drm/mediatek: mtk_dsi: Create connector for bridges

2020-05-18 Thread Enric Balletbo Serra
Hi Chun-Kuang, Missatge de Chun-Kuang Hu del dia ds., 16 de maig 2020 a les 12:11: > > Hi, Enric: > > Enric Balletbo i Serra 於 2020年5月15日 週五 > 上午1:35寫道: > > > > Hi again, > > > > On 14/5/20 19:12, Enric Balletbo i Serra wrote: > > > Hi Chun-Kuang, > > > > > > On 14/5/20 18:44, Chun-Kuang Hu wro

Re: [PATCH v4 7/7] drm/mediatek: mtk_dsi: Create connector for bridges

2020-05-18 Thread Sam Ravnborg
Hi Enric/Chun-Kuang. > > > > My point is: when do you attach panel to a connector? > > In this patch, > > > > ret = drm_bridge_attach(&dsi->encoder, &dsi->bridge, NULL, > > DRM_BRIDGE_ATTACH_NO_CONNECTOR); > > > > it would call into mtk_dsi_bridge_attach()

Re: [PATCH v2 06/16] backlight: improve backlight_device documentation

2020-05-18 Thread Daniel Thompson
On Mon, May 18, 2020 at 08:03:21PM +0300, Jani Nikula wrote: > On Mon, 18 May 2020, Daniel Thompson wrote: > > On Sun, May 17, 2020 at 09:01:29PM +0200, Sam Ravnborg wrote: > >> Improve the documentation for backlight_device and > >> adapt it to kernel-doc style. > >> > >> Signed-off-by: Sam Ravn

Re: [PATCH v5 0/6] drm: Prepare to use a GPIO on ti-sn65dsi86 for Hot Plug Detect

2020-05-18 Thread Sam Ravnborg
Hi Douglas. > > Given the previous feedback from Linus W, Stephen, and Laurent I > > expect things are good enough to land now, but it'd be good to get > > confirmation (I removed some of the previous tags just to get > > confirmation). If we can get review tags early next week maybe it'll > > st

Re: [PATCH] drm/bridge: ti-sn65dsi86: Clear old error bits before AUX transfers

2020-05-18 Thread Sam Ravnborg
On Fri, May 08, 2020 at 04:33:29PM -0700, Douglas Anderson wrote: > The AUX channel transfer error bits in the status register are latched > and need to be cleared. Clear them before doing our transfer so we > don't see old bits and get confused. > > Without this patch having a single failure wou

Re: [PATCH] drm/exynos: Remove dev_err() on platform_get_irq() failure

2020-05-18 Thread Joe Perches
On Mon, 2020-05-18 at 22:57 +0530, Tamseel Shams wrote: > platform_get_irq() will call dev_err() itself on failure, > so there is no need for the driver to also do this. > This is detected by coccinelle. trivia: > diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c > b/drivers/gpu/drm/exynos/ex

Re: [PATCH V3 07/15] arch/kunmap_atomic: Consolidate duplicate code

2020-05-18 Thread Ira Weiny
On Sun, May 17, 2020 at 09:29:32PM -0700, Guenter Roeck wrote: > On Sun, May 17, 2020 at 08:49:39PM -0700, Ira Weiny wrote: > > On Sat, May 16, 2020 at 03:33:06PM -0700, Guenter Roeck wrote: > > > On Thu, May 07, 2020 at 07:59:55AM -0700, ira.we...@intel.com wrote: > > > > From: Ira Weiny > > > >

Re: [PATCH v2 15/16] backlight: make of_find_backlight_by_node() static

2020-05-18 Thread Sam Ravnborg
On Mon, May 18, 2020 at 05:56:48PM +0100, Daniel Thompson wrote: > On Sun, May 17, 2020 at 09:01:38PM +0200, Sam Ravnborg wrote: > > There are no external users of of_find_backlight_by_node(). > > Make it static so we keep it that way. > > > > v2: > > - drop EXPORT of of_find_backlight_by_node >

Re: [PATCH v5 0/6] drm: Prepare to use a GPIO on ti-sn65dsi86 for Hot Plug Detect

2020-05-18 Thread Doug Anderson
Sam, On Mon, May 18, 2020 at 10:59 AM Sam Ravnborg wrote: > > Hi Douglas. > > > > Given the previous feedback from Linus W, Stephen, and Laurent I > > > expect things are good enough to land now, but it'd be good to get > > > confirmation (I removed some of the previous tags just to get > > > con

Re: [PATCH V3 10/15] arch/kmap: Define kmap_atomic_prot() for all arch's

2020-05-18 Thread Ira Weiny
On Sun, May 17, 2020 at 10:37:22AM -0700, Guenter Roeck wrote: > Hi, > > On Thu, May 07, 2020 at 07:59:58AM -0700, ira.we...@intel.com wrote: > > From: Ira Weiny > > > > To support kmap_atomic_prot(), all architectures need to support > > protections passed to their kmap_atomic_high() function.

Re: [PATCH v2 1/2] drm/bridge: ti-sn65dsi86: Implement lane reordering + polarity

2020-05-18 Thread Doug Anderson
Sam, On Fri, May 15, 2020 at 2:43 PM Rob Clark wrote: > > On Wed, May 6, 2020 at 2:03 PM Douglas Anderson wrote: > > > > The ti-sn65dsi86 MIPI DSI to eDP bridge chip supports arbitrary > > remapping of eDP lanes and also polarity inversion. Both of these > > features have been described in the

Re: [PATCH] drm/bridge: ti-sn65dsi86: Fix off-by-one error in clock choice

2020-05-18 Thread Doug Anderson
Sam, On Fri, May 15, 2020 at 2:49 PM Rob Clark wrote: > > On Mon, May 4, 2020 at 9:32 PM Douglas Anderson wrote: > > > > If the rate in our table is _equal_ to the rate we want then it's OK > > to pick it. It doesn't need to be greater than the one we want. > > > > Fixes: a095f15c00e2 ("drm/bri

Re: [PATCH v5 0/6] drm: Prepare to use a GPIO on ti-sn65dsi86 for Hot Plug Detect

2020-05-18 Thread Sam Ravnborg
Hi Douglas, On Mon, May 18, 2020 at 11:05:58AM -0700, Doug Anderson wrote: > Sam, > > On Mon, May 18, 2020 at 10:59 AM Sam Ravnborg wrote: > > > > Hi Douglas. > > > > > > Given the previous feedback from Linus W, Stephen, and Laurent I > > > > expect things are good enough to land now, but it'd b

Re: [PATCH 1/2] dt-bindings: n133hse-ea1: Add Innolux N133HSE panel

2020-05-18 Thread Rob Herring
On Sat, May 09, 2020 at 01:18:33PM +0200, s...@48.io wrote: > From: Sean Cross > > The Innolux N133HSE panel is a 13.3" 1920x1080 panel that contains an > integrated backlight, and connects via eDP. > > It is used in the Kosagi Novena. > > Signed-off-by: Sean Cross > Signed-off-by: Richard Mar

Re: [PATCH] drm/bridge: ti-sn65dsi86: Fix off-by-one error in clock choice

2020-05-18 Thread Sam Ravnborg
Hi Douglas. On Mon, May 18, 2020 at 11:23:44AM -0700, Doug Anderson wrote: > Sam, > > On Fri, May 15, 2020 at 2:49 PM Rob Clark wrote: > > > > On Mon, May 4, 2020 at 9:32 PM Douglas Anderson > > wrote: > > > > > > If the rate in our table is _equal_ to the rate we want then it's OK > > > to pi

Re: [PATCH v2 1/2] drm/bridge: ti-sn65dsi86: Implement lane reordering + polarity

2020-05-18 Thread Sam Ravnborg
Hi Douglas. On Mon, May 18, 2020 at 11:22:22AM -0700, Doug Anderson wrote: > Sam, > > On Fri, May 15, 2020 at 2:43 PM Rob Clark wrote: > > > > On Wed, May 6, 2020 at 2:03 PM Douglas Anderson > > wrote: > > > > > > The ti-sn65dsi86 MIPI DSI to eDP bridge chip supports arbitrary > > > remapping

[REPOST PATCH v2] drm/bridge: ti-sn65dsi86: Implement lane reordering + polarity

2020-05-18 Thread Douglas Anderson
The ti-sn65dsi86 MIPI DSI to eDP bridge chip supports arbitrary remapping of eDP lanes and also polarity inversion. Both of these features have been described in the device tree bindings for the device since the beginning but were never implemented in the driver. Implement both of them. Part of t

[PATCH] arch/{mips, sparc, microblaze, powerpc}: Don't enable pagefault/preempt twice

2020-05-18 Thread ira . weiny
From: Ira Weiny The kunmap_atomic clean up failed to remove one set of pagefault/preempt enables when vaddr is not in the fixmap. Fixes: bee2128a09e6 ("arch/kunmap_atomic: consolidate duplicate code") Signed-off-by: Ira Weiny --- arch/microblaze/mm/highmem.c | 5 + arch/mips/mm/highmem.c

Re: [REPOST PATCH v2] drm/bridge: ti-sn65dsi86: Implement lane reordering + polarity

2020-05-18 Thread Sam Ravnborg
Hi Douglas. On Mon, May 18, 2020 at 11:47:17AM -0700, Douglas Anderson wrote: > The ti-sn65dsi86 MIPI DSI to eDP bridge chip supports arbitrary > remapping of eDP lanes and also polarity inversion. Both of these > features have been described in the device tree bindings for the > device since the

Re: [PATCH v2 15/16] backlight: make of_find_backlight_by_node() static

2020-05-18 Thread Daniel Thompson
On Mon, May 18, 2020 at 08:12:27PM +0200, Sam Ravnborg wrote: > On Mon, May 18, 2020 at 05:56:48PM +0100, Daniel Thompson wrote: > > On Sun, May 17, 2020 at 09:01:38PM +0200, Sam Ravnborg wrote: > > > There are no external users of of_find_backlight_by_node(). > > > Make it static so we keep it tha

Re: [PATCH 2/2] dt-bindings: arm-smmu: Add sc7180 compatible string

2020-05-18 Thread Doug Anderson
Hi, On Mon, May 18, 2020 at 7:39 AM Will Deacon wrote: > > On Fri, May 15, 2020 at 12:05:39PM -0700, Doug Anderson wrote: > > On Fri, May 1, 2020 at 3:30 AM Sharat Masetty > > wrote: > > > > > > This patch simply adds a new compatible string for SC7180 platform. > > > > > > Signed-off-by: Shara

Re: [PATCH] drm/i915/gvt: Use ARRAY_SIZE for vgpu_types

2020-05-18 Thread Chris Wilson
Quoting Aishwarya Ramakrishnan (2020-05-18 16:03:36) > Prefer ARRAY_SIZE instead of using sizeof > > Fixes coccicheck warning: Use ARRAY_SIZE > > Signed-off-by: Aishwarya Ramakrishnan Reviewed-by: Chris Wilson -Chris ___ dri-devel mailing list dri-dev

Re: [PATCH AUTOSEL 5.6 33/50] drm/amdgpu: bump version for invalidate L2 before SDMA IBs

2020-05-18 Thread Marek Olšák
Hi Sasha, I disagree with this. Bumping the driver version will have implications on other new features, because it's like an ABI barrier exposing new functionality. Marek On Thu, May 7, 2020 at 10:28 AM Sasha Levin wrote: > From: Marek Olšák > > [ Upstream commit 9017a4897a20658f010bebea8252

Re: [PATCH] Lenovo X13 Yoga OLED panel brightness fix

2020-05-18 Thread Lyude Paul
Yeah, git send-email is kinda :(, but unfortunately the entire kernel uses this workflow. Hopefully freedesktop's gitlab efforts will change this someday... also - in the future, if you don't want comments to appear in the patch when they're applied put them below the ---, e.g. the one before the

  1   2   >