[Bug 207763] New: Noisy Screen in Linux with kernel 5

2020-05-17 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=207763 Bug ID: 207763 Summary: Noisy Screen in Linux with kernel 5 Product: Drivers Version: 2.5 Kernel Version: 5.0.0-23-generic Hardware: x86-64 OS: Linux Tree: Ma

Re: [PATCH] drm/mm: Fix an error handling path in '__igt_once()'

2020-05-17 Thread Chris Wilson
Quoting Christophe JAILLET (2020-05-17 09:50:49) > The label of the last gotos must be switched for the error handling code to > work as expected. > > Fixes: 83bc4ec37210 ("drm/mm: Add a search-by-address variant to only inspect > a single hole") > Signed-off-by: Christophe JAILLET > --- > driv

Re: [PATCH] drm/etnaviv: fix perfmon domain interation

2020-05-17 Thread Lucas Stach
Hi Christian, Am Montag, den 11.05.2020, 14:37 +0200 schrieb Christian Gmeiner: > The GC860 has one GPU device which has a 2d and 3d core. In this case > we want to expose perfmon information for both cores. > > The driver has one array which contains all possible perfmon domains > with some meta

[Bug 206017] Kernel 5.4.x unusable with GUI due to crashes (some hard)

2020-05-17 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=206017 udo (udo...@xs4all.nl) changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Bug 206247] 5.4.x: WARNING: CPU: 1 PID: 561 at drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dcn_calcs.c:1464 dcn_bw_update_from_pplib+0xa5/0x2e0 [amdgpu]

2020-05-17 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=206247 udo (udo...@xs4all.nl) changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [PATCH v1 01/18] drm/omap: display: use devm_of_find_backlight

2020-05-17 Thread Sam Ravnborg
On Fri, May 15, 2020 at 11:24:53AM +0300, Tomi Valkeinen wrote: > On 14/05/2020 22:09, Sam Ravnborg wrote: > > Look up backlight device using devm_of_find_backlight(). > > This simplifies the code and prevents us from hardcoding > > the node name in the driver. > > > > Signed-off-by: Sam Ravnborg

Re: [PATCH v1 02/18] drm/tilcdc: use devm_of_find_backlight

2020-05-17 Thread Sam Ravnborg
On Fri, May 15, 2020 at 11:25:47AM +0300, Tomi Valkeinen wrote: > On 14/05/2020 22:09, Sam Ravnborg wrote: > > Look up backlight device using devm_of_find_backlight(). > > This simplifies the code and prevents us from hardcoding > > the node name in the driver. > > > > Signed-off-by: Sam Ravnborg

[Bug 207763] Noisy Screen in Linux with kernel 5

2020-05-17 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=207763 Alex Deucher (alexdeuc...@gmail.com) changed: What|Removed |Added CC||alexdeuc...@gmail.c

[PATCH v2 02/16] backlight: refactor fb_notifier_callback()

2020-05-17 Thread Sam Ravnborg
Increase readability of fb_notifier_callback() by removing a few indent levels. No functional change. Signed-off-by: Sam Ravnborg Cc: Lee Jones Cc: Daniel Thompson Cc: Jingoo Han --- drivers/video/backlight/backlight.c | 43 +++-- 1 file changed, 22 insertions(+), 21 d

[PATCH v2 08/16] backlight: document enums in backlight.h

2020-05-17 Thread Sam Ravnborg
Add kernel-doc documentation for the backlight enums Signed-off-by: Sam Ravnborg Cc: Lee Jones Cc: Daniel Thompson Cc: Jingoo Han --- include/linux/backlight.h | 84 +++ 1 file changed, 84 insertions(+) diff --git a/include/linux/backlight.h b/include/linu

[PATCH v2 10/16] backlight: drop extern from prototypes

2020-05-17 Thread Sam Ravnborg
No need to put "extern" in front of prototypes. While touching the prototypes adjust indent to follow the kernel style. Signed-off-by: Sam Ravnborg Cc: Lee Jones Cc: Daniel Thompson Cc: Jingoo Han --- include/linux/backlight.h | 35 +++ 1 file changed, 19 inser

[PATCH v2 01/16] video: amba-clcd: use devm_of_find_backlight

2020-05-17 Thread Sam Ravnborg
Look up backlight device using devm_of_find_backlight(). This simplifies the code and prevents us from hardcoding the node name in the driver. v2: - Added Cc: Peter Ujfalusi Signed-off-by: Sam Ravnborg Cc: Russell King Cc: Sam Ravnborg Cc: Bartlomiej Zolnierkiewicz Cc: Peter Ujfalusi Cc: D

[PATCH v2 11/16] backlight: add overview and update existing doc

2020-05-17 Thread Sam Ravnborg
Add overview chapter to backlight.c. Update existing kernel-doc to follow a more consistent style and drop kernel-doc for deprecated functions. Signed-off-by: Sam Ravnborg Cc: Lee Jones Cc: Daniel Thompson Cc: Jingoo Han --- drivers/video/backlight/backlight.c | 131 +++---

[PATCH v2 03/16] backlight: add backlight_is_blank()

2020-05-17 Thread Sam Ravnborg
The backlight support has two properties that express the state: - power - state It is un-documented and easy to get wrong. Add backlight_is_blank() helper to make it simpler for drivers to get the check of the state correct. A lot of drivers also includes checks for fb_blank. This check is redun

[PATCH v2 06/16] backlight: improve backlight_device documentation

2020-05-17 Thread Sam Ravnborg
Improve the documentation for backlight_device and adapt it to kernel-doc style. Signed-off-by: Sam Ravnborg Cc: Lee Jones Cc: Daniel Thompson Cc: Jingoo Han --- include/linux/backlight.h | 81 --- 1 file changed, 58 insertions(+), 23 deletions(-) diff --g

[PATCH v2 04/16] backlight: improve backlight_ops documentation

2020-05-17 Thread Sam Ravnborg
Improve the documentation for backlight_ops and adapt it to kernel-doc style. Signed-off-by: Sam Ravnborg Cc: Lee Jones Cc: Daniel Thompson Cc: Jingoo Han --- include/linux/backlight.h | 60 +++ 1 file changed, 54 insertions(+), 6 deletions(-) diff --git a

[PATCH v2 13/16] backlight: make of_find_backlight static

2020-05-17 Thread Sam Ravnborg
There are no external users of of_find_backlight, as they have all changed to use the managed version. Make of_find_backlight static to prevent new external users. Signed-off-by: Sam Ravnborg Cc: Lee Jones Cc: Daniel Thompson Cc: Jingoo Han --- drivers/video/backlight/backlight.c | 31 +++

[PATCH v2 05/16] backlight: improve backlight_properties documentation

2020-05-17 Thread Sam Ravnborg
Improve the documentation for backlight_properties and adapt it to kernel-doc style. Signed-off-by: Sam Ravnborg Cc: Lee Jones Cc: Daniel Thompson Cc: Jingoo Han --- include/linux/backlight.h | 101 +- 1 file changed, 90 insertions(+), 11 deletions(-) diff

[PATCH v2 07/16] backlight: document inline functions in backlight.h

2020-05-17 Thread Sam Ravnborg
Add documentation for the inline functions in backlight.h Signed-off-by: Sam Ravnborg Cc: Lee Jones Cc: Daniel Thompson Cc: Jingoo Han --- include/linux/backlight.h | 16 1 file changed, 16 insertions(+) diff --git a/include/linux/backlight.h b/include/linux/backlight.h inde

[PATCH v2 0/16] backlight updates

2020-05-17 Thread Sam Ravnborg
v2: - Dropped drm patches that was reviewed and thus applied (Thanks Tomi) - Updated backlight_is_blank() based on Daniel's feedback - Dropped EXPORT_SYMBOL that was no longer relevant - Reordered patches, so patches with no external dependencies comes first - Updated the description

[PATCH v2 09/16] backlight: remove the unused backlight_bl driver

2020-05-17 Thread Sam Ravnborg
The driver required initialization using struct generic_bl_info. As there are no more references to this struct there is no users left. So it is safe to delete the driver. Signed-off-by: Sam Ravnborg Cc: Lee Jones Cc: Daniel Thompson Cc: Jingoo Han --- drivers/video/backlight/Kconfig |

[PATCH v2 16/16] backlight: use backlight_is_blank() in all backlight drivers

2020-05-17 Thread Sam Ravnborg
Replaces the open-coded checks of the state etc., with the backlight_is_blank() helper. This increases readability of the code and align the functionality across the drivers. v2: - Fixed so changelog is readable Signed-off-by: Sam Ravnborg Cc: Lee Jones Cc: Daniel Thompson Cc: Jingoo Han Cc

[PATCH v2 12/16] backlight: wire up kernel-doc documentation

2020-05-17 Thread Sam Ravnborg
Include backlight so the documentation is now generated with make htmldocs and friends. Signed-off-by: Sam Ravnborg Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann Cc: David Airlie Cc: Daniel Vetter Cc: Jonathan Corbet --- Documentation/gpu/backlight.rst | 12 Do

[PATCH v2 15/16] backlight: make of_find_backlight_by_node() static

2020-05-17 Thread Sam Ravnborg
There are no external users of of_find_backlight_by_node(). Make it static so we keep it that way. v2: - drop EXPORT of of_find_backlight_by_node Signed-off-by: Sam Ravnborg Cc: Lee Jones Cc: Daniel Thompson Cc: Jingoo Han --- drivers/video/backlight/backlight.c | 23 +-

[PATCH v2 14/16] backlight: drop backlight_put()

2020-05-17 Thread Sam Ravnborg
There are no external users of backlight_put(). Drop it and open code the two users in backlight.c. Signed-off-by: Sam Ravnborg Cc: Lee Jones Cc: Daniel Thompson Cc: Jingoo Han --- drivers/video/backlight/backlight.c | 7 +-- include/linux/backlight.h | 10 -- 2 files c

[PATCH 1/3] drm/arm: Kconfig annotate drivers as COMPILE_TEST

2020-05-17 Thread Emil Velikov
Add the COMPILE_TEST conditional, so that people can at least build test the drivers. Cc: Liviu Dudau Cc: Brian Starkey Cc: Mali DP Maintainers Cc: dri-devel@lists.freedesktop.org Signed-off-by: Emil Velikov --- Please merge through the ARM tree. Aside: would make sense to have the tree drive

[PATCH 3/3] drm/exynos-vidi: convert platform driver to use dev_groups

2020-05-17 Thread Emil Velikov
Platform drivers now have the option to have the platform core create and remove any needed sysfs attribute files. So take advantage of that and do not register "by hand" a sysfs file. Cc: Inki Dae Cc: Joonyoung Shim Cc: Seung-Woo Kim Cc: Kyungmin Park Cc: dri-devel@lists.freedesktop.org Sign

[PATCH 2/3] drm/malidp: convert platform driver to use dev_groups

2020-05-17 Thread Emil Velikov
Platform drivers now have the option to have the platform core create and remove any needed sysfs attribute files. So take advantage of that and do not register "by hand" a sysfs file. Cc: Liviu Dudau Cc: Brian Starkey Cc: Mali DP Maintainers Cc: dri-devel@lists.freedesktop.org Signed-off-by:

Re: [PATCH v2 15/16] backlight: make of_find_backlight_by_node() static

2020-05-17 Thread kbuild test robot
ase: git://anongit.freedesktop.org/tegra/linux.git drm/tegra/for-next config: arm-randconfig-r011-20200517 (attached as .config) compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/

[Bug 204241] amdgpu fails to resume from suspend

2020-05-17 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=204241 i...@sonce.de changed: What|Removed |Added CC||i...@sonce.de --- Comment #61 from i...@s

Re: [PATCH] drm/rockchip: vop: call vop_cfg_done() under reg_lock

2020-05-17 Thread Emil Velikov
On Wed, 6 May 2020 at 02:32, Sandy Huang wrote: > > Hi Emil Velikov, > > 在 2020/5/5 下午11:16, Emil Velikov 写道: > > From: Emil Velikov > > > > The function vop_cfg_done() is a simple VOP_REG_SET(). As such it should > > be done under a reg_lock. A quick look through the driver shows that all > > ot

Re: [PATCH] drm/gem: Fix a leak in drm_gem_objects_lookup()

2020-05-17 Thread Emil Velikov
On Mon, 23 Mar 2020 at 12:13, Dan Carpenter wrote: > > On Mon, Mar 23, 2020 at 11:13:22AM +, Emil Velikov wrote: > > Hi Dan, > > > > On Fri, 20 Mar 2020 at 13:23, Dan Carpenter > > wrote: > > > > > > If the "handles" allocation or the copy_from_user() fails then we leak > > > "objs". It's s

Re: [PATCH v2] drm/debugfs: fix plain echo to connector "force" attribute

2020-05-17 Thread Emil Velikov
On Thu, 17 Aug 2017 at 12:34, Jani Nikula wrote: > > On Thu, 17 Aug 2017, Michael Tretter wrote: > > Using plain echo to set the "force" connector attribute fails with > > -EINVAL, because echo appends a newline to the output. > > > > Replace strcmp with sysfs_streq to also accept strings that en

Re: [PATCH 0/2] drm: encoder_slave: some updates

2020-05-17 Thread Emil Velikov
On Wed, 13 May 2020 at 10:35, Emil Velikov wrote: > > Hi Wolfram, > > On Wed, 13 May 2020 at 10:10, Wolfram Sang > wrote: > > > > On Mon, Mar 16, 2020 at 05:39:05PM +0100, Wolfram Sang wrote: > > > While converting I2C users to new APIs, I found a refcounting problem in > > > the encoder_slave im

Re: [PATCH v2 15/16] backlight: make of_find_backlight_by_node() static

2020-05-17 Thread kbuild test robot
Hi Sam, I love your patch! Yet something to improve: [auto build test ERROR on tegra-drm/drm/tegra/for-next] [also build test ERROR on pwm/for-next linus/master v5.7-rc5] [cannot apply to backlight/for-backlight-next next-20200515] [if your patch is applied to the wrong git tree, please drop us a

Re: [PATCH resend] drm: Add DRM_MODE_TYPE_USERDEF flag to probed modes matching a video= argument

2020-05-17 Thread Emil Velikov
On Thu, 14 May 2020 at 15:35, Hans de Goede wrote: > > Hi, > > On 5/14/20 11:53 AM, Emil Velikov wrote: > > Hi Hans, > > > > On Thu, 30 Apr 2020 at 15:55, Hans de Goede wrote: > >> > >> Hi, > >> > >> On 4/30/20 4:52 PM, Ville Syrjälä wrote: > >>> On Thu, Apr 30, 2020 at 02:47:00PM +0100, Emil Vel

Re: [PATCH] fbdev: annotate rivafb/nvidiafb as obsolete

2020-05-17 Thread Emil Velikov
On Thu, 14 May 2020 at 14:28, Bartlomiej Zolnierkiewicz wrote: > > diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig > > index 1b2f5f31fb6f..cad3e4bc5e52 100644 > > --- a/drivers/video/fbdev/Kconfig > > +++ b/drivers/video/fbdev/Kconfig > > @@ -868,6 +868,7 @@ config FB_ATMEL

[PATCH v2 2/2] powerpc/configs: replace deprecated riva/nvidia with nouveau

2020-05-17 Thread Emil Velikov
As mentioned in earlier commit, the riva and nvidia fbdev drivers have seen no love over the years, are short on features and overall below par Users are encouraged to switch to the nouveau drm driver instead. v2: Split configs to separate patch, enable nouveau (Bartlomiej) Cc: Antonino Daplas

[PATCH v2 1/2] fbdev: annotate rivafb/nvidiafb as obsolete

2020-05-17 Thread Emil Velikov
Drivers have not seen any love for years. Be that fixes or improvements, or cosmetics like introducing symbolic names, style and code-flow polish. Seemingly the maintainer has also disappeared years ago :-\ Considering nouveau supports all that hardware (modulo nv03) just mark these as obsolete/

Re: [PATCH v2 1/2] fbdev: annotate rivafb/nvidiafb as obsolete

2020-05-17 Thread kbuild test robot
Hi Emil, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on powerpc/next] [also build test WARNING on tegra-drm/drm/tegra/for-next linus/master v5.7-rc5 next-20200515] [if your patch is applied to the wrong git tree, please drop us a note to help improve the syste

Re: [PATCH v2 1/2] fbdev: annotate rivafb/nvidiafb as obsolete

2020-05-17 Thread kbuild test robot
Hi Emil, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on powerpc/next] [also build test WARNING on tegra-drm/drm/tegra/for-next linus/master v5.7-rc5 next-20200515] [if your patch is applied to the wrong git tree, please drop us a note to help improve the syste

[GIT PULL v2] mediatek drm next for 5.8

2020-05-17 Thread Chun-Kuang Hu
Hi, Dave & Daniel: This include dpi pin mode swap, config mipi_tx current and impedance, and some fixup. I drop drm_bridge patches in this version. The following changes since commit 8f3d9f354286745c751374f5f1fcafee6b3f3136: Linux 5.7-rc1 (2020-04-12 12:35:55 -0700) are available in the Git rep

[PATCH] Lenovo X13 Yoga OLED panel brightness fix

2020-05-17 Thread Mark Pearson
Hi, Patch to fix an issue controlling the brightness of the OLED panel on the Lenovo X13 Yoga Please let me know any feedback or questions. Note - apologies if this message has shown up before - I had some mail client issues. Mark Pearson - Add another panel th

Re: [PATCH v2 2/2] powerpc/configs: replace deprecated riva/nvidia with nouveau

2020-05-17 Thread Benjamin Herrenschmidt
On Sun, 2020-05-17 at 23:05 +0100, Emil Velikov wrote: > As mentioned in earlier commit, the riva and nvidia fbdev drivers > have > seen no love over the years, are short on features and overall below > par > > Users are encouraged to switch to the nouveau drm driver instead. > > v2: Split config

Re: [PATCH v5 13/38] drm: lima: fix common struct sg_table related issues

2020-05-17 Thread Qiang Yu
Looks good for me, patch is: Reviewed-by: Qiang Yu Regards, Qiang On Wed, May 13, 2020 at 9:33 PM Marek Szyprowski wrote: > > The Documentation/DMA-API-HOWTO.txt states that the dma_map_sg() function > returns the number of the created entries in the DMA address space. > However the subsequent

Re: [PATCH V3 07/15] arch/kunmap_atomic: Consolidate duplicate code

2020-05-17 Thread Ira Weiny
On Sat, May 16, 2020 at 03:33:06PM -0700, Guenter Roeck wrote: > On Thu, May 07, 2020 at 07:59:55AM -0700, ira.we...@intel.com wrote: > > From: Ira Weiny > > > > Every single architecture (including !CONFIG_HIGHMEM) calls... > > > > pagefault_enable(); > > preempt_enable(); > > > > ...

Re: [PATCH 3/3] drm/exynos-vidi: convert platform driver to use dev_groups

2020-05-17 Thread Inki Dae
Hi Email, 20. 5. 18. 오전 4:36에 Emil Velikov 이(가) 쓴 글: > Platform drivers now have the option to have the platform core create > and remove any needed sysfs attribute files. So take advantage of that > and do not register "by hand" a sysfs file. > > Cc: Inki Dae > Cc: Joonyoung Shim > Cc: Seung-

Re: [PATCH v2] drm/exynos: dsi: Remove bridge node reference in error handling path in probe function

2020-05-17 Thread Inki Dae
20. 5. 16. 오후 7:57에 Christophe JAILLET 이(가) 쓴 글: > 'exynos_dsi_parse_dt()' takes a reference to 'dsi->in_bridge_node'. > This must be released in the error handling path. Picked it up. Thanks, Inki Dae > > In order to do that, add an error handling path and move the > 'exynos_dsi_parse_dt()'

Re: [PATCH] drm/exynos: mixer: Fix enabling of the runtime power management

2020-05-17 Thread Inki Dae
Hi Marek, 20. 5. 14. 오후 7:08에 Marek Szyprowski 이(가) 쓴 글: > Runtime power management is essential for the Exynos Mixer driver > operation. It should be enabled before adding its DRM component, because > in some cases (when deferred probe takes place due to the IOMMU > availability) the DRM driver m

Re: [PATCH v5 27/38] xen: gntdev: fix common struct sg_table related issues

2020-05-17 Thread Jürgen Groß
On 13.05.20 15:32, Marek Szyprowski wrote: The Documentation/DMA-API-HOWTO.txt states that the dma_map_sg() function returns the number of the created entries in the DMA address space. However the subsequent calls to the dma_sync_sg_for_{device,cpu}() and dma_unmap_sg must be called with the orig

[PATCH] drm/etnaviv: convert get_user_pages() --> pin_user_pages()

2020-05-17 Thread John Hubbard
This code was using get_user_pages*(), in a "Case 2" scenario (DMA/RDMA), using the categorization from [1]. That means that it's time to convert the get_user_pages*() + put_page() calls to pin_user_pages*() + unpin_user_pages() calls. There is some helpful background in [2]: basically, this is a

Re: [PATCH] drm/i915: Mark check_shadow_context_ppgtt as maybe unused

2020-05-17 Thread Zhenyu Wang
On 2020.05.15 19:35:45 -0700, Nathan Chancellor wrote: > When CONFIG_DRM_I915_DEBUG_GEM is not set, clang warns: > > drivers/gpu/drm/i915/gvt/scheduler.c:884:1: warning: function > 'check_shadow_context_ppgtt' is not needed and will not be emitted > [-Wunneeded-internal-declaration] > check_shadow