Re: drm/bridge: Synopsys DW-HDMI bridge driver for the Ingenic JZ4780 (was Re: Specialising the Synopsys DW-HDMI bridge driver for the Ingenic JZ4780)

2020-05-15 Thread Neil Armstrong
Hi, On 15/05/2020 00:04, Paul Boddie wrote: > Hello, > > Following up on my last message... > >> On Wednesday 13. May 2020 09.37.49 Neil Armstrong wrote: >>> >>> Can you run the kernel with drm debug enabled ? drm.debug=0x3f for example >>> you'll have all the modes checks & so on >> >> I'll try

Re: [PATCH 2/8] dt-bindings: media: renesas, fcp: Make power-domains mandatory

2020-05-15 Thread Geert Uytterhoeven
On Fri, May 15, 2020 at 3:42 AM Laurent Pinchart wrote: > All DT source files in the kernel tree specifyc the power-domains > property. Make it mandatory. > > Signed-off-by: Laurent Pinchart Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoev

Re: [PATCH 5/8] dt-bindings: media: renesas, fdp1: Make power-domains mandatory

2020-05-15 Thread Geert Uytterhoeven
On Fri, May 15, 2020 at 3:42 AM Laurent Pinchart wrote: > All DT source files in the kernel tree specifyc the power-domains specify (whoops, missed the same typo in PATCH 2/8). > property. Make it mandatory. > > Signed-off-by: Laurent Pinchart Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}

Re: [PATCH 3/8] dt-bindings: media: renesas,fcp: Add resets and iommus properties

2020-05-15 Thread Geert Uytterhoeven
On Fri, May 15, 2020 at 3:45 AM Laurent Pinchart wrote: > The resets and iommus properties are used in DT sources in the kernel > tree. Document them, and make resets mandatory. The iommus property is > optional as not all platforms wire the FCP to a functional IOMMU. > > Signed-off-by: Laurent Pi

Re: [PATCH 6/8] dt-bindings: media: renesas, fdp1: Add resets property

2020-05-15 Thread Geert Uytterhoeven
On Fri, May 15, 2020 at 3:42 AM Laurent Pinchart wrote: > The resets property ise used in DT sources in the kernel tree. Document is > it and make it mandatory. > > Signed-off-by: Laurent Pinchart Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uy

Re: [PATCH 8/8] dt-bindings: media: renesas,vsp1: Add power-domains and resets

2020-05-15 Thread Geert Uytterhoeven
On Fri, May 15, 2020 at 3:43 AM Laurent Pinchart wrote: > The power-domains and resets properties are used in all DT sources in > the kernel but are absent from the bindings. Document them and make them > mandatory. > > Signed-off-by: Laurent Pinchart Reviewed-by: Geert Uytterhoeven Gr{oetje,e

Re: [PATCH 1/8] dt-bindings: media: renesas, fcp: Convert binding to YAML

2020-05-15 Thread Geert Uytterhoeven
Hi Laurent, On Fri, May 15, 2020 at 3:42 AM Laurent Pinchart wrote: > Convert the Renesas R-Car FCP text binding to YAML. > > Signed-off-by: Laurent Pinchart Reviewed-by: Geert Uytterhoeven > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/renesas,fcp.yaml > @@ -0,0 +1,56 @@ > +

Re: [PATCH 4/8] dt-bindings: media: renesas, fdp1: Convert binding to YAML

2020-05-15 Thread Geert Uytterhoeven
Hi Laurent, On Fri, May 15, 2020 at 3:42 AM Laurent Pinchart wrote: > Convert the Renesas R-Car FDP1 text binding to YAML. > > Signed-off-by: Laurent Pinchart Reviewed-by: Geert Uytterhoeven > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/renesas,fdp1.yaml > + renesas,fcp: >

Re: [PATCH 7/8] dt-bindings: media: renesas, vsp1: Convert binding to YAML

2020-05-15 Thread Geert Uytterhoeven
On Fri, May 15, 2020 at 3:42 AM Laurent Pinchart wrote: > Convert the Renesas R-Car VSP1 text binding to YAML. > > Signed-off-by: Laurent Pinchart Reviewed-by: Geert Uytterhoeven > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/renesas,vsp1.yaml > @@ -0,0 +1,83 @@ > +properties

[PATCH v3 06/15] drm/mgag200: Update mode registers after plane registers

2020-05-15 Thread Thomas Zimmermann
Setting the plane registers first and the mode registers afterwards reproduces the sequence used by atomic helpers. Done in preparation of switching to simple KMS helpers. Signed-off-by: Thomas Zimmermann Tested-by: John Donnelly Acked-by: Sam Ravnborg Acked-by: Emil Velikov --- drivers/gpu/d

[PATCH v3 12/15] drm/mgag200: Remove out-commented suspend/resume helpers

2020-05-15 Thread Thomas Zimmermann
The suspend/resume helpers are unused. Also remove associated state from struct mga_device. Signed-off-by: Thomas Zimmermann Tested-by: John Donnelly Acked-by: Sam Ravnborg Acked-by: Emil Velikov --- drivers/gpu/drm/mgag200/mgag200_drv.h | 1 - drivers/gpu/drm/mgag200/mgag200_mode.c | 71 --

[PATCH v3 02/15] drm/mgag200: Clean up mga_set_start_address()

2020-05-15 Thread Thomas Zimmermann
All register names and fields are now named according to the MGA programming manuals. The function doesn't need the CRTC, so callers pass in the device structure directly. The logging now uses device-specific macros. The original implementation busy-waited for the VSYNC flag to go up, to synchroni

[PATCH v3 08/15] drm/mgag200: Set primary plane's format in separate helper function

2020-05-15 Thread Thomas Zimmermann
The primary plane's format registers are now updated in a mgag200_set_format_regs(). v2: * get bpp shift from helper function * replace uint8_t with u8 Signed-off-by: Thomas Zimmermann Tested-by: John Donnelly Acked-by: Sam Ravnborg Acked-by: Emil Velikov --- drivers/gpu/drm/

[PATCH v3 14/15] drm/mgag200: Convert to simple KMS helper

2020-05-15 Thread Thomas Zimmermann
The mgag200 supports a single pipeline with only a primary plane. It can be converted to simple KMS helpers. This also adds support for atomic modesetting. Wayland compositors, which use pageflip ioctls, can now be used with mgag200. v2: * prepare encoder and CRTC in a separate patch

[PATCH v3 07/15] drm/mgag200: Set pitch in a separate helper function

2020-05-15 Thread Thomas Zimmermann
The framebuffer's pitch is now set in mgag200_set_offset(). v2: * move offset and bpp-shift calculation into helper functions * use u8 instead of uint8_t * add MGAREG_CRTCEXT0_OFFSET_MASK Signed-off-by: Thomas Zimmermann Tested-by: John Donnelly Acked-by: Sam Ravnborg A

[PATCH v3 15/15] drm/mgag200: Replace VRAM helpers with SHMEM helpers

2020-05-15 Thread Thomas Zimmermann
The VRAM helpers managed the framebuffer memory for mgag200. This came with several problems, as some MGA device require the scanout address to be located at VRAM offset 0. It's incompatible with the page-flip semantics of DRM's atomic modesettting. With atomic modesetting, old and new framebuffers

[PATCH v3 05/15] drm/mgag200: Split MISC register update into PLL selection, SYNC and I/O

2020-05-15 Thread Thomas Zimmermann
Set different fields in MISC in their rsp location in the code. This patch also fixes a bug in the original code where the mode's SYNC flags were never written into the MISC register. v2: * use u8 instead of uint8_t * define MGAREG_MISC_CLK_SEL_MASK Signed-off-by: Thomas Zimmerman

[PATCH v3 03/15] drm/mgag200: Clean up mga_crtc_do_set_base()

2020-05-15 Thread Thomas Zimmermann
The function now only takes the device structure, and the old and new framebuffers. Signed-off-by: Thomas Zimmermann Tested-by: John Donnelly Acked-by: Sam Ravnborg Acked-by: Emil Velikov --- drivers/gpu/drm/mgag200/mgag200_mode.c | 18 +- 1 file changed, 9 insertions(+), 9 de

[PATCH v3 10/15] drm/mgag200: Move hiprilvl setting into separate functions

2020-05-15 Thread Thomas Zimmermann
The hiprivlvl settings are now updated in mgag200_g200se_set_hiprilvl() and mgag200_g200ev_set_hiprilvl(). v2: * replace uint8_t with u8 Signed-off-by: Thomas Zimmermann Tested-by: John Donnelly Acked-by: Sam Ravnborg Acked-by: Emil Velikov --- drivers/gpu/drm/mgag200/mgag200_mode.c

[PATCH v3 13/15] drm/mgag200: Use simple-display data structures

2020-05-15 Thread Thomas Zimmermann
The MGA CRTC data structure struct mga_crtc contains unused additional fields; so it can removed. The standard DRM CRTC and encoder structures are embedded now in struct drm_simple_display_pipe. Done in preparation of converting mgag200 to simple KMS helpers. v3: * remove now-unused define

[PATCH v3 04/15] drm/mgag200: Move mode-setting code into separate helper function

2020-05-15 Thread Thomas Zimmermann
The mode-setting code is now located in mgag200_set_mode_regs(), sans a few flags that will be moved in a later patch for clarity. v2: * replace uint8_t with u8 Signed-off-by: Thomas Zimmermann Tested-by: John Donnelly Acked-by: Sam Ravnborg Acked-by: Emil Velikov --- drivers/gpu/drm

[PATCH v3 01/15] drm/mgag200: Remove HW cursor

2020-05-15 Thread Thomas Zimmermann
The HW cursor of Matrox G200 cards only supports a 16-color palette format. Univeral planes require at least ARGB or a similar component- based format, so remove the HW cursor. Alternatively, the driver could dither a cursor image from ARGB to 16 colors. But this does not produce pleasent-looking

[PATCH v3 00/15] drm/mgag200: Convert to atomic modesetting

2020-05-15 Thread Thomas Zimmermann
This patchset converts mgag200 to atomic modesetting. It uses simple KMS helpers and SHMEM. I'm posting v3 mostly for reference. These patches will land soon if no one objects. Patch 1 removes cursor support. The HW cursor is not usable with the way universal planes work. Patches 2 to 11 untangle

[PATCH v3 11/15] drm/mgag200: Move register initialization into separate function

2020-05-15 Thread Thomas Zimmermann
Registers are initialized with constants. This is now done in mgag200_init_regs(), mgag200_set_dac_regs() and mgag200_set_pci_regs(). Later patches should move these calls from mode setting to device initialization. v2: * replace uint8_t with u8 Signed-off-by: Thomas Zimmermann Tested-by

[PATCH v3 09/15] drm/mgag200: Move TAGFIFO reset into separate function

2020-05-15 Thread Thomas Zimmermann
The TAGFIFO state is now reset in mgag200_g200er_reset_tagfifo(). v2: * define MGAREG_SEQ1_SCROFF Signed-off-by: Thomas Zimmermann Tested-by: John Donnelly Acked-by: Sam Ravnborg Acked-by: Emil Velikov --- drivers/gpu/drm/mgag200/mgag200_drv.h | 6 drivers/gpu/drm/mgag200/mgag

Re: [PATCH v4 2/4] drm/imx: Add initial support for DCSS on iMX8MQ

2020-05-15 Thread Guido Günther
Hi Laurentiu, On Fri, Mar 06, 2020 at 02:49:26PM +0200, Laurentiu Palcu wrote: > From: Laurentiu Palcu > > This adds initial support for iMX8MQ's Display Controller Subsystem (DCSS). > Some of its capabilities include: > * 4K@60fps; > * HDR10; > * one graphics and 2 video pipelines; > * on-th

Re: [RFC][PATCH 3/4] dma-buf: cma_heap: Extend logic to export CMA regions tagged with "linux,cma-heap"

2020-05-15 Thread Brian Starkey
On Thu, May 14, 2020 at 09:52:35AM -0500, Rob Herring wrote: > On Wed, May 13, 2020 at 5:44 AM Brian Starkey wrote: > > > > Hi Rob, > > > > On Tue, May 12, 2020 at 11:37:14AM -0500, Rob Herring wrote: > > > On Mon, May 04, 2020 at 10:06:28AM +0100, Brian Starkey wrote: > > > > On Fri, May 01, 2020

[PATCH v2 08/38] drm/gma500: Use lockless gem BO free callback

2020-05-15 Thread Emil Velikov
From: Emil Velikov No dev->struct_mutex anywhere to be seen. Cc: Patrik Jakobsson Cc: Daniel Vetter Signed-off-by: Emil Velikov Acked-by: Sam Ravnborg Reviewed-by: Thomas Zimmermann --- drivers/gpu/drm/gma500/psb_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dri

[PATCH v2 02/38] drm/gem: use _unlocked reference in drm_gem_objects_lookup docs

2020-05-15 Thread Emil Velikov
From: Emil Velikov Use the drm_gem_object_put_unlocked in the documentation for drm_gem_objects_lookup. The locked version of the helper should be used solely by people who know exactly what they are doing. Should prevent issues like ones adddressed with the next patch. Signed-off-by: Emil Veli

[PATCH v2 03/38] drm/todo: mention i915 in the struct_mutex section

2020-05-15 Thread Emil Velikov
From: Emil Velikov Signed-off-by: Emil Velikov Acked-by: Sam Ravnborg Reviewed-by: Daniel Vetter --- Documentation/gpu/todo.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst index 658b52f7ffc6..2ce52c5917f8 1006

[PATCH v2 00/38] Fareless gem_free_object

2020-05-15 Thread Emil Velikov
Hi all, Here is v2 of the series, with the requested minor tweaks. - Add new WARNING in the struct_mutex doc (Daniel) - Drop a few more struct_mutex references (Daniel) - Missing space in the drm_object_put doc (Jani) - Keep drm_object_put_unlocked removal as separate patch (Sam, Thomas) Con

[PATCH v2 05/38] drm/doc: add WARNING for drm_device::struct_mutex

2020-05-15 Thread Emil Velikov
From: Emil Velikov The mutex should be used, only by legacy drivers. Add a big warning to deter people from using it. Suggested-by: Daniel Vetter Reviewed-by: Daniel Vetter Signed-off-by: Emil Velikov --- include/drm/drm_device.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include

[PATCH v2 01/38] drm: remove unused drm_gem.h include

2020-05-15 Thread Emil Velikov
From: Emil Velikov Signed-off-by: Emil Velikov Acked-by: Sam Ravnborg Reviewed-by: Thomas Zimmermann --- drivers/gpu/drm/drm_vm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/drm_vm.c b/drivers/gpu/drm/drm_vm.c index 56197ae0b2f9..954baa8a2a8f 100644 --- a/drivers/gpu/dr

[PATCH v2 04/38] drm/doc: drop struct_mutex references

2020-05-15 Thread Emil Velikov
From: Emil Velikov There's little point in providing partial and ancient information about the struct_mutex. Some drivers are using it, new ones should not. As-it this only provides for confusion. Signed-off-by: Emil Velikov Acked-by: Sam Ravnborg Reviewed-by: Daniel Vetter --- Documentatio

[PATCH v2 22/38] drm/mediatek: remove _unlocked suffix in drm_object_put_unlocked

2020-05-15 Thread Emil Velikov
From: Emil Velikov Spelling out _unlocked for each and every driver is a annoying. Especially if we consider how many drivers, do not know (or need to) about the horror stories involving struct_mutex. Just drop the suffix. It makes the API cleaner. Done via the following script: __from=drm_gem

[PATCH v2 12/38] drm/gem: add drm_object_put helper

2020-05-15 Thread Emil Velikov
From: Emil Velikov Spelling out _unlocked for each and every driver is a annoying. Especially if we consider how many drivers, do not know (or need to) about the horror stories involving struct_mutex. Add helper, which will allow us to transition the drivers one by one, dropping the suffix. v2:

[PATCH v2 11/38] drm/gem: add _locked suffix to drm_object_put

2020-05-15 Thread Emil Velikov
From: Emil Velikov Vast majority of DRM (core and drivers) are struct_mutex free. As such we have only a handful of cases where the locked helper should be used. Make that stand out a little bit better. Done via the following script: __from=drm_gem_object_put __to=drm_gem_object_put_locked fo

[PATCH v2 28/38] drm/qxl: remove _unlocked suffix in drm_object_put_unlocked

2020-05-15 Thread Emil Velikov
From: Emil Velikov Spelling out _unlocked for each and every driver is a annoying. Especially if we consider how many drivers, do not know (or need to) about the horror stories involving struct_mutex. Just drop the suffix. It makes the API cleaner. Done via the following script: __from=drm_gem

[PATCH v2 32/38] drm/v3d: remove _unlocked suffix in drm_object_put_unlocked

2020-05-15 Thread Emil Velikov
From: Emil Velikov Spelling out _unlocked for each and every driver is a annoying. Especially if we consider how many drivers, do not know (or need to) about the horror stories involving struct_mutex. Just drop the suffix. It makes the API cleaner. Done via the following script: __from=drm_gem

[PATCH v2 36/38] drm/vkms: remove _unlocked suffix in drm_object_put_unlocked

2020-05-15 Thread Emil Velikov
From: Emil Velikov Spelling out _unlocked for each and every driver is a annoying. Especially if we consider how many drivers, do not know (or need to) about the horror stories involving struct_mutex. Just drop the suffix. It makes the API cleaner. Done via the following script: __from=drm_gem

[PATCH v2 31/38] drm/tegra: remove _unlocked suffix in drm_object_put_unlocked

2020-05-15 Thread Emil Velikov
From: Emil Velikov Spelling out _unlocked for each and every driver is a annoying. Especially if we consider how many drivers, do not know (or need to) about the horror stories involving struct_mutex. Just drop the suffix. It makes the API cleaner. Done via the following script: __from=drm_gem

[PATCH v2 33/38] drm/vc4: remove _unlocked suffix in drm_object_put_unlocked

2020-05-15 Thread Emil Velikov
From: Emil Velikov Spelling out _unlocked for each and every driver is a annoying. Especially if we consider how many drivers, do not know (or need to) about the horror stories involving struct_mutex. Just drop the suffix. It makes the API cleaner. Done via the following script: __from=drm_gem

[PATCH v2 35/38] drm/virtio: remove _unlocked suffix in drm_object_put_unlocked

2020-05-15 Thread Emil Velikov
From: Emil Velikov Spelling out _unlocked for each and every driver is a annoying. Especially if we consider how many drivers, do not know (or need to) about the horror stories involving struct_mutex. Just drop the suffix. It makes the API cleaner. Done via the following script: __from=drm_gem

[PATCH v2 19/38] drm/gma500: remove _unlocked suffix in drm_object_put_unlocked

2020-05-15 Thread Emil Velikov
From: Emil Velikov Spelling out _unlocked for each and every driver is a annoying. Especially if we consider how many drivers, do not know (or need to) about the horror stories involving struct_mutex. Just drop the suffix. It makes the API cleaner. Done via the following script: __from=drm_gem

[PATCH v2 25/38] drm/nouveau: remove _unlocked suffix in drm_object_put_unlocked

2020-05-15 Thread Emil Velikov
From: Emil Velikov Spelling out _unlocked for each and every driver is a annoying. Especially if we consider how many drivers, do not know (or need to) about the horror stories involving struct_mutex. Just drop the suffix. It makes the API cleaner. Done via the following script: __from=drm_gem

[PATCH v2 27/38] drm/panfrost: remove _unlocked suffix in drm_object_put_unlocked

2020-05-15 Thread Emil Velikov
From: Emil Velikov Spelling out _unlocked for each and every driver is a annoying. Especially if we consider how many drivers, do not know (or need to) about the horror stories involving struct_mutex. Just drop the suffix. It makes the API cleaner. Done via the following script: __from=drm_gem

[PATCH v2 37/38] drm/xen: remove _unlocked suffix in drm_object_put_unlocked

2020-05-15 Thread Emil Velikov
From: Emil Velikov Spelling out _unlocked for each and every driver is a annoying. Especially if we consider how many drivers, do not know (or need to) about the horror stories involving struct_mutex. Just drop the suffix. It makes the API cleaner. Done via the following script: __from=drm_gem

[PATCH v2 17/38] drm/etnaviv: remove _unlocked suffix in drm_object_put_unlocked

2020-05-15 Thread Emil Velikov
From: Emil Velikov Spelling out _unlocked for each and every driver is a annoying. Especially if we consider how many drivers, do not know (or need to) about the horror stories involving struct_mutex. Just drop the suffix. It makes the API cleaner. Done via the following script: __from=drm_gem

[PATCH v2 18/38] drm/exynos: remove _unlocked suffix in drm_object_put_unlocked

2020-05-15 Thread Emil Velikov
From: Emil Velikov Spelling out _unlocked for each and every driver is a annoying. Especially if we consider how many drivers, do not know (or need to) about the horror stories involving struct_mutex. Just drop the suffix. It makes the API cleaner. Done via the following script: __from=drm_gem

[PATCH v2 29/38] drm/radeon: remove _unlocked suffix in drm_object_put_unlocked

2020-05-15 Thread Emil Velikov
From: Emil Velikov Spelling out _unlocked for each and every driver is a annoying. Especially if we consider how many drivers, do not know (or need to) about the horror stories involving struct_mutex. Just drop the suffix. It makes the API cleaner. Done via the following script: __from=drm_gem

[PATCH v2 14/38] drm/amd: remove _unlocked suffix in drm_object_put_unlocked

2020-05-15 Thread Emil Velikov
From: Emil Velikov Spelling out _unlocked for each and every driver is a annoying. Especially if we consider how many drivers, do not know (or need to) about the horror stories involving struct_mutex. Just drop the suffix. It makes the API cleaner. Done via the following script: __from=drm_gem

[PATCH v2 21/38] drm/lima: remove _unlocked suffix in drm_object_put_unlocked

2020-05-15 Thread Emil Velikov
From: Emil Velikov Spelling out _unlocked for each and every driver is a annoying. Especially if we consider how many drivers, do not know (or need to) about the horror stories involving struct_mutex. Just drop the suffix. It makes the API cleaner. Done via the following script: __from=drm_gem

[PATCH v2 15/38] drm/arm: remove _unlocked suffix in drm_object_put_unlocked

2020-05-15 Thread Emil Velikov
From: Emil Velikov Spelling out _unlocked for each and every driver is a annoying. Especially if we consider how many drivers, do not know (or need to) about the horror stories involving struct_mutex. Just drop the suffix. It makes the API cleaner. Done via the following script: __from=drm_gem

[PATCH v2 24/38] drm/msm: remove _unlocked suffix in drm_object_put_unlocked

2020-05-15 Thread Emil Velikov
From: Emil Velikov Spelling out _unlocked for each and every driver is a annoying. Especially if we consider how many drivers, do not know (or need to) about the horror stories involving struct_mutex. Just drop the suffix. It makes the API cleaner. Done via the following script: __from=drm_gem

[PATCH v2 06/38] drm/doc: drop struct_mutex reference for drm_gem_object_free

2020-05-15 Thread Emil Velikov
From: Emil Velikov The comment that struct_mutex must be held is misleading. It is only required when .gem_free_object() is used. Since that one is going with the next patches, drop the reference. Signed-off-by: Emil Velikov Acked-by: Sam Ravnborg Reviewed-by: Daniel Vetter --- drivers/gpu/

[PATCH v2 23/38] drm/mgag200: remove _unlocked suffix in drm_object_put_unlocked

2020-05-15 Thread Emil Velikov
From: Emil Velikov Spelling out _unlocked for each and every driver is a annoying. Especially if we consider how many drivers, do not know (or need to) about the horror stories involving struct_mutex. Just drop the suffix. It makes the API cleaner. Done via the following script: __from=drm_gem

[PATCH v2 07/38] drm/amdgpu: use the unlocked drm_gem_object_put

2020-05-15 Thread Emil Velikov
From: Emil Velikov The driver does not hold struct_mutex, thus using the locked version of the helper is incorrect. Cc: Alex Deucher Cc: Christian König Cc: amd-...@lists.freedesktop.org Fixes: a39414716ca0 ("drm/amdgpu: add independent DMA-buf import v9"): Signed-off-by: Emil Velikov Acked-b

[PATCH v2 30/38] drm/rockchip: remove _unlocked suffix in drm_object_put_unlocked

2020-05-15 Thread Emil Velikov
From: Emil Velikov Spelling out _unlocked for each and every driver is a annoying. Especially if we consider how many drivers, do not know (or need to) about the horror stories involving struct_mutex. Just drop the suffix. It makes the API cleaner. Done via the following script: __from=drm_gem

[PATCH v2 26/38] drm/omapdrm: remove _unlocked suffix in drm_object_put_unlocked

2020-05-15 Thread Emil Velikov
From: Emil Velikov Spelling out _unlocked for each and every driver is a annoying. Especially if we consider how many drivers, do not know (or need to) about the horror stories involving struct_mutex. Just drop the suffix. It makes the API cleaner. Done via the following script: __from=drm_gem

[PATCH v2 34/38] drm/vgem: remove _unlocked suffix in drm_object_put_unlocked

2020-05-15 Thread Emil Velikov
From: Emil Velikov Spelling out _unlocked for each and every driver is a annoying. Especially if we consider how many drivers, do not know (or need to) about the horror stories involving struct_mutex. Just drop the suffix. It makes the API cleaner. Done via the following script: __from=drm_gem

[PATCH v2 38/38] drm: remove transient drm_object_put_unlocked()

2020-05-15 Thread Emil Velikov
From: Emil Velikov As of last commit, all the drivers have been updated away from the _unlocked helper. As such we can now remove the transient #define. v2: keep sed and #define removal separate Cc: David Airlie Cc: Daniel Vetter Signed-off-by: Emil Velikov Acked-by: Sam Ravnborg (v1) ---

[PATCH v2 09/38] drm: remove drm_driver::gem_free_object

2020-05-15 Thread Emil Velikov
From: Emil Velikov No drivers set the callback, so remove it all together. Signed-off-by: Emil Velikov Acked-by: Sam Ravnborg Reviewed-by: Thomas Zimmermann --- drivers/gpu/drm/drm_gem.c | 22 +++--- include/drm/drm_drv.h | 8 include/drm/drm_gem.h | 5 +++-

[PATCH v2 13/38] drm: remove _unlocked suffix in drm_object_put_unlocked

2020-05-15 Thread Emil Velikov
From: Emil Velikov Spelling out _unlocked for each and every driver is a annoying. Especially if we consider how many drivers, do not know (or need to) about the horror stories involving struct_mutex. Just drop the suffix. It makes the API cleaner. Done via the following script: __from=drm_gem

[PATCH v2 16/38] drm/armada: remove _unlocked suffix in drm_object_put_unlocked

2020-05-15 Thread Emil Velikov
From: Emil Velikov Spelling out _unlocked for each and every driver is a annoying. Especially if we consider how many drivers, do not know (or need to) about the horror stories involving struct_mutex. Just drop the suffix. It makes the API cleaner. Done via the following script: __from=drm_gem

[PATCH v2 20/38] drm/i915: remove _unlocked suffix in drm_object_put_unlocked

2020-05-15 Thread Emil Velikov
From: Emil Velikov Spelling out _unlocked for each and every driver is a annoying. Especially if we consider how many drivers, do not know (or need to) about the horror stories involving struct_mutex. Just drop the suffix. It makes the API cleaner. Done via the following script: __from=drm_gem

[PATCH v2 10/38] drm/gem: fold drm_gem_object_put_unlocked and __drm_gem_object_put()

2020-05-15 Thread Emil Velikov
From: Emil Velikov With earlier patch we removed the overhead so now we can lift the helper into the header effectively folding it with __drm_object_put. v2: drop struct_mutex references (Daniel) Signed-off-by: Emil Velikov Acked-by: Sam Ravnborg (v1) Reviewed-by: Daniel Vetter --- drivers/

Re: [PATCH] drm/etnaviv: fix perfmon domain interation

2020-05-15 Thread Christian Gmeiner
Am Mo., 11. Mai 2020 um 14:38 Uhr schrieb Christian Gmeiner : > > The GC860 has one GPU device which has a 2d and 3d core. In this case > we want to expose perfmon information for both cores. > > The driver has one array which contains all possible perfmon domains > with some meta data - doms_meta.

Re: [PATCH v5 25/38] drm: virtio: fix common struct sg_table related issues

2020-05-15 Thread Gerd Hoffmann
On Wed, May 13, 2020 at 03:32:32PM +0200, Marek Szyprowski wrote: > The Documentation/DMA-API-HOWTO.txt states that the dma_map_sg() function > returns the number of the created entries in the DMA address space. > However the subsequent calls to the dma_sync_sg_for_{device,cpu}() and > dma_unmap_sg

Re: [PATCH v5 30/38] dmabuf: fix common struct sg_table related issues

2020-05-15 Thread Gerd Hoffmann
> diff --git a/drivers/dma-buf/udmabuf.c b/drivers/dma-buf/udmabuf.c > index acb26c6..89e293b 100644 > --- a/drivers/dma-buf/udmabuf.c > +++ b/drivers/dma-buf/udmabuf.c > @@ -63,10 +63,9 @@ static struct sg_table *get_sg_table(struct device *dev, > struct dma_buf *buf, >

Re: [PATCH v2 28/38] drm/qxl: remove _unlocked suffix in drm_object_put_unlocked

2020-05-15 Thread Gerd Hoffmann
On Fri, May 15, 2020 at 10:51:08AM +0100, Emil Velikov wrote: > From: Emil Velikov > > Spelling out _unlocked for each and every driver is a annoying. > Especially if we consider how many drivers, do not know (or need to) > about the horror stories involving struct_mutex. > > Just drop the suffi

Re: [PATCH 10/11] kernel/power: constify sysrq_key_op

2020-05-15 Thread Emil Velikov
On Thu, 14 May 2020 at 12:21, Rafael J. Wysocki wrote: > > On Wed, May 13, 2020 at 11:46 PM Emil Velikov > wrote: > > > > With earlier commits, the API no longer discards the const-ness of the > > sysrq_key_op. As such we can add the notation. > > > > Cc: Greg Kroah-Hartman > > Cc: Jiri Slaby

Re: [PATCH v2 35/38] drm/virtio: remove _unlocked suffix in drm_object_put_unlocked

2020-05-15 Thread Gerd Hoffmann
On Fri, May 15, 2020 at 10:51:15AM +0100, Emil Velikov wrote: > From: Emil Velikov > > Spelling out _unlocked for each and every driver is a annoying. > Especially if we consider how many drivers, do not know (or need to) > about the horror stories involving struct_mutex. > > Just drop the suffi

Re: [PATCH v2 30/38] drm/rockchip: remove _unlocked suffix in drm_object_put_unlocked

2020-05-15 Thread Heiko Stübner
Am Freitag, 15. Mai 2020, 11:51:10 CEST schrieb Emil Velikov: > From: Emil Velikov > > Spelling out _unlocked for each and every driver is a annoying. > Especially if we consider how many drivers, do not know (or need to) > about the horror stories involving struct_mutex. > > Just drop the suffi

Re: [PATCH] drm/etnaviv: fix perfmon domain interation

2020-05-15 Thread Lucas Stach
Am Freitag, den 15.05.2020, 12:12 +0200 schrieb Paul Cercueil: > Hi Christian, > > Le ven. 15 mai 2020 à 12:09, Christian Gmeiner > a écrit : > > Am Mo., 11. Mai 2020 um 14:38 Uhr schrieb Christian Gmeiner > > : > > > The GC860 has one GPU device which has a 2d and 3d core. In this > > > case

Re: [PATCH] drm/etnaviv: fix perfmon domain interation

2020-05-15 Thread Christian Gmeiner
Hi Paul Am Fr., 15. Mai 2020 um 12:12 Uhr schrieb Paul Cercueil : > > Hi Christian, > > Le ven. 15 mai 2020 à 12:09, Christian Gmeiner > a écrit : > > Am Mo., 11. Mai 2020 um 14:38 Uhr schrieb Christian Gmeiner > > : > >> > >> The GC860 has one GPU device which has a 2d and 3d core. In this > >>

Re: [PATCH] drm/etnaviv: fix perfmon domain interation

2020-05-15 Thread Christian Gmeiner
Am Fr., 15. Mai 2020 um 12:24 Uhr schrieb Lucas Stach : > > Am Freitag, den 15.05.2020, 12:12 +0200 schrieb Paul Cercueil: > > Hi Christian, > > > > Le ven. 15 mai 2020 à 12:09, Christian Gmeiner > > a écrit : > > > Am Mo., 11. Mai 2020 um 14:38 Uhr schrieb Christian Gmeiner > > > : > > > > The G

Re: [PATCH] drm/etnaviv: fix perfmon domain interation

2020-05-15 Thread Lucas Stach
Am Freitag, den 15.05.2020, 12:27 +0200 schrieb Christian Gmeiner: > Am Fr., 15. Mai 2020 um 12:24 Uhr schrieb Lucas Stach > : > > Am Freitag, den 15.05.2020, 12:12 +0200 schrieb Paul Cercueil: > > > Hi Christian, > > > > > > Le ven. 15 mai 2020 à 12:09, Christian Gmeiner > > > a écrit : > > > >

Re: [PATCH 10/11] kernel/power: constify sysrq_key_op

2020-05-15 Thread Greg Kroah-Hartman
On Fri, May 15, 2020 at 11:11:57AM +0100, Emil Velikov wrote: > On Thu, 14 May 2020 at 12:21, Rafael J. Wysocki wrote: > > > > On Wed, May 13, 2020 at 11:46 PM Emil Velikov > > wrote: > > > > > > With earlier commits, the API no longer discards the const-ness of the > > > sysrq_key_op. As such w

Re: [PATCH] drm/etnaviv: fix perfmon domain interation

2020-05-15 Thread Christian Gmeiner
Am Fr., 15. Mai 2020 um 12:33 Uhr schrieb Lucas Stach : > > Am Freitag, den 15.05.2020, 12:27 +0200 schrieb Christian Gmeiner: > > Am Fr., 15. Mai 2020 um 12:24 Uhr schrieb Lucas Stach > > : > > > Am Freitag, den 15.05.2020, 12:12 +0200 schrieb Paul Cercueil: > > > > Hi Christian, > > > > > > > >

Re: [PATCH v4 2/4] drm/imx: Add initial support for DCSS on iMX8MQ

2020-05-15 Thread Laurentiu Palcu
Hi Guido, On Fri, May 15, 2020 at 11:27:19AM +0200, Guido Günther wrote: > Hi Laurentiu, > On Fri, Mar 06, 2020 at 02:49:26PM +0200, Laurentiu Palcu wrote: > > From: Laurentiu Palcu > > > > This adds initial support for iMX8MQ's Display Controller Subsystem (DCSS). > > Some of its capabilities i

Re: [PATCH v4 2/4] drm/imx: Add initial support for DCSS on iMX8MQ

2020-05-15 Thread Guido Günther
Hi Laurentiu, On Fri, May 15, 2020 at 02:10:13PM +0300, Laurentiu Palcu wrote: > Hi Guido, > > On Fri, May 15, 2020 at 11:27:19AM +0200, Guido Günther wrote: > > Hi Laurentiu, > > On Fri, Mar 06, 2020 at 02:49:26PM +0200, Laurentiu Palcu wrote: > > > From: Laurentiu Palcu > > > > > > This adds i

Re: [PATCH v2 31/38] drm/tegra: remove _unlocked suffix in drm_object_put_unlocked

2020-05-15 Thread Thierry Reding
On Fri, May 15, 2020 at 10:51:11AM +0100, Emil Velikov wrote: > From: Emil Velikov > > Spelling out _unlocked for each and every driver is a annoying. > Especially if we consider how many drivers, do not know (or need to) > about the horror stories involving struct_mutex. > > Just drop the suffi

Re: [PATCH v2 11/38] drm/gem: add _locked suffix to drm_object_put

2020-05-15 Thread Thomas Zimmermann
Hi Emil Am 15.05.20 um 11:50 schrieb Emil Velikov: > From: Emil Velikov > > Vast majority of DRM (core and drivers) are struct_mutex free. > > As such we have only a handful of cases where the locked helper should > be used. Make that stand out a little bit better. > > Done via the following s

Re: [PATCH v1 01/18] drm/omap: display: use devm_of_find_backlight

2020-05-15 Thread Tomi Valkeinen
On 14/05/2020 22:09, Sam Ravnborg wrote: Look up backlight device using devm_of_find_backlight(). This simplifies the code and prevents us from hardcoding the node name in the driver. Signed-off-by: Sam Ravnborg Cc: Tomi Valkeinen Cc: Zheng Bin Cc: Kate Stewart Cc: Enrico Weigelt Cc: Alliso

Re: [PATCH v1 02/18] drm/tilcdc: use devm_of_find_backlight

2020-05-15 Thread Tomi Valkeinen
On 14/05/2020 22:09, Sam Ravnborg wrote: Look up backlight device using devm_of_find_backlight(). This simplifies the code and prevents us from hardcoding the node name in the driver. Signed-off-by: Sam Ravnborg Cc: Jyri Sarha Cc: Tomi Valkeinen --- drivers/gpu/drm/tilcdc/tilcdc_panel.c | 1

Re: [PATCH v2 00/38] Fareless gem_free_object

2020-05-15 Thread Thomas Zimmermann
Hi, I have reviewed some of these patches. For the rest of the series you can add Acked-by: Thomas Zimmermann Best regards Thomas Am 15.05.20 um 11:50 schrieb Emil Velikov: > Hi all, > > Here is v2 of the series, with the requested minor tweaks. > > - Add new WARNING in the struct_mutex doc

Re: [PATCH v6 08/16] drm/i915: Don't fully disable HDCP on a port if multiple pipes are using it

2020-05-15 Thread Ramalingam C
On 2020-04-29 at 15:54:54 -0400, Sean Paul wrote: > From: Sean Paul > > This patch is required for HDCP over MST. If a port is being used for > multiple HDCP streams, we don't want to fully disable HDCP on a port if > one of them is disabled. Instead, we just disable the HDCP signalling on > that

Re: [PATCH v2 11/38] drm/gem: add _locked suffix to drm_object_put

2020-05-15 Thread Steven Price
On 15/05/2020 10:50, Emil Velikov wrote: From: Emil Velikov Vast majority of DRM (core and drivers) are struct_mutex free. As such we have only a handful of cases where the locked helper should be used. Make that stand out a little bit better. Done via the following script: __from=drm_gem_ob

Re: [PATCH v2 27/38] drm/panfrost: remove _unlocked suffix in drm_object_put_unlocked

2020-05-15 Thread Steven Price
On 15/05/2020 10:51, Emil Velikov wrote: From: Emil Velikov Spelling out _unlocked for each and every driver is a annoying. Especially if we consider how many drivers, do not know (or need to) about the horror stories involving struct_mutex. Just drop the suffix. It makes the API cleaner. Don

Re: [PATCH v2 13/38] drm: remove _unlocked suffix in drm_object_put_unlocked

2020-05-15 Thread Steven Price
On 15/05/2020 10:50, Emil Velikov wrote: From: Emil Velikov Spelling out _unlocked for each and every driver is a annoying. Especially if we consider how many drivers, do not know (or need to) about the horror stories involving struct_mutex. Just drop the suffix. It makes the API cleaner. Don

Re: [PATCH 01/11] tty/sysrq: alpha: export and use __sysrq_get_key_op()

2020-05-15 Thread Greg Kroah-Hartman
On Wed, May 13, 2020 at 10:43:41PM +0100, Emil Velikov wrote: > Export a pointer to the sysrq_get_key_op(). This way we can cleanly > unregister it, instead of the current solutions of modifuing it inplace. > > Since __sysrq_get_key_op() is no longer used externally, let's make it > a static funct

Re: [PATCH 01/44] drivers/base: Always release devres on device_del

2020-05-15 Thread Greg Kroah-Hartman
On Tue, Apr 28, 2020 at 03:15:12PM +0200, Daniel Vetter wrote: > On Mon, Apr 06, 2020 at 03:55:28PM +0200, Daniel Vetter wrote: > > On Mon, Apr 6, 2020 at 3:38 PM Greg Kroah-Hartman > > wrote: > > > > > > On Mon, Apr 06, 2020 at 02:32:51PM +0200, Daniel Vetter wrote: > > > > On Fri, Apr 3, 2020 at

Re: ✓ Fi.CI.IGT: success for drm/dp_mst: Fix timeout handling of MST down messages

2020-05-15 Thread Imre Deak
On Wed, May 13, 2020 at 02:40:29PM +, Patchwork wrote: > == Series Details == > > Series: drm/dp_mst: Fix timeout handling of MST down messages > URL : https://patchwork.freedesktop.org/series/77216/ > State : success Patch pushed to drm-misc-next, thanks for the review. > > == Summary ==

Re: [PATCH v12 00/14] In order to readout DP SDPs, refactors the handling of DP SDPs

2020-05-15 Thread Ville Syrjälä
On Thu, May 14, 2020 at 02:19:23PM +0300, Jani Nikula wrote: > On Thu, 14 May 2020, Gwan-gyeong Mun wrote: > > In order to readout DP SDPs (Secondary Data Packet: DP HDR Metadata > > Infoframe SDP, DP VSC SDP), it refactors handling DP SDPs codes. > > It adds new compute routines for DP HDR Metada

[RFC PATCH 0/6] drm/bridge: Add mux input selection bridge

2020-05-15 Thread Guido Günther
This bridge driver allows to select the input to a downstream bridge (or panel) via device tree. It can be useful to separate the pixel source selection from the actual bridge processing the pixel data. E.g. NXP's imx8mq has two display controllers. Both can feed the pixel data to the NWL DSI IP c

[RFC PATCH 4/6] drm/bridge/nwl-dsi: Drop mux handling

2020-05-15 Thread Guido Günther
This will be handled via the mux-input-bridge. Signed-off-by: Guido Günther --- drivers/gpu/drm/bridge/Kconfig | 1 - drivers/gpu/drm/bridge/nwl-dsi.c | 61 2 files changed, 62 deletions(-) diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/

[RFC PATCH 2/6] drm/bridge: Add mux-input bridge

2020-05-15 Thread Guido Günther
This bridge allows to select the input source via a mux controller. The input source is determined via DT but it could become rutime selectable in the future. Signed-off-by: Guido Günther --- drivers/gpu/drm/bridge/Kconfig | 9 ++ drivers/gpu/drm/bridge/Makefile| 1 + drivers/gpu/drm

[RFC PATCH 1/6] dt-bindings: display/bridge: Add binding for input mux bridge

2020-05-15 Thread Guido Günther
The bridge allows to select the input source via a mux controller. Signed-off-by: Guido Günther --- .../display/bridge/mux-input-bridge.yaml | 123 ++ 1 file changed, 123 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/bridge/mux-input-bridge.yam

[RFC PATCH 6/6] arm64: dts: imx8mq-librem5-devkit: Enable MIPI DSI panel

2020-05-15 Thread Guido Günther
Enable MIPI LCD panel output by adding nodes for the NWL DSI host controller, the mux-input-bridge, the Rocktech panel and the eLCDIF display controller. Signed-off-by: Guido Günther --- .../dts/freescale/imx8mq-librem5-devkit.dts | 81 +++ 1 file changed, 81 insertions(+) dif

[RFC PATCH 5/6] arm64: dts: imx8mq: Add NWL dsi controller

2020-05-15 Thread Guido Günther
Add a node for the Northwestlogic MIPI DSI IP core, "disabled" by default. Signed-off-by: Guido Günther --- arch/arm64/boot/dts/freescale/imx8mq.dtsi | 31 +++ 1 file changed, 31 insertions(+) diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/free

  1   2   >