[PATCH v2] of_device: removed #include that caused a recursion in included headers

2020-04-17 Thread Hadar Gat
Both of_platform.h and of_device.h were included each other. In of_device.h, removed unneeded #include to of_platform.h and added include to of_platform.h in the files that needs it. Signed-off-by: Hadar Gat --- v2: add include to of_platform.h in more files. (reported due other builds) arch/sp

Re: [RFC 0/6] Regressions for "imply" behavior change

2020-04-17 Thread Nicolas Pitre
On Thu, 16 Apr 2020, Arnd Bergmann wrote: > On Thu, Apr 16, 2020 at 12:17 PM Jani Nikula > wrote: > > > > On Thu, 16 Apr 2020, Arnd Bergmann wrote: > > > On Thu, Apr 16, 2020 at 5:25 AM Saeed Mahameed > > > wrote: > > >> BTW how about adding a new Kconfig option to hide the details of > > >> (

Re: [PATCH trivial 0/6] Fix misspellings of "Analog Devices"

2020-04-17 Thread Ardelean, Alexandru
On Thu, 2020-04-16 at 12:30 +0200, Geert Uytterhoeven wrote: > [External] > > Hi all, > > In several files the company also known as ADI is spelled as "Analog > Device". However, according to https://www.analog.com/, the company > name is spelled "Analog Devices". > > Hence this patch ser

Re: [PATCH v1 2/4] dt-bindings: display: convert atmel lcdc to DT Schema

2020-04-17 Thread Maxime Ripard
On Wed, Apr 15, 2020 at 06:44:27PM +0200, Sam Ravnborg wrote: > Hi Maxime. > > On Tue, Apr 14, 2020 at 10:30:10AM +0200, Maxime Ripard wrote: > > On Sun, Apr 12, 2020 at 08:20:10PM +0200, Sam Ravnborg wrote: > > > Add a new binding file to describe the bindings > > > for the Atmel LCDC IP. > > > Th

[PATCH 1/2] drm: panel: Set connector type for LP120UP1

2020-04-17 Thread Enric Balletbo i Serra
The LP120UP1 is a eDP panel, set the connector type accordingly. Signed-off-by: Enric Balletbo i Serra --- drivers/gpu/drm/panel/panel-simple.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index 3ad828eaefe1..62

[PATCH v3 2/2] drm/tegra: output: rgb: Support LVDS encoder bridge

2020-04-17 Thread Dmitry Osipenko
Newer Tegra device-trees will specify a video output graph that involves LVDS encoder bridge, This patch adds support for the LVDS encoder bridge to the RGB output, allowing us to model display hardware properly. Signed-off-by: Dmitry Osipenko --- drivers/gpu/drm/tegra/drm.h| 2 ++ drivers/

[PATCH] drm/tegra: dc: Omit superfluous error message in tegra_dc_probe()

2020-04-17 Thread Tang Bin
In the function tegra_dc_probe(), when get irq failed, the function platform_get_irq() logs an error message, so remove redundant message here. Signed-off-by: Tang Bin --- drivers/gpu/drm/tegra/dc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/tegra/dc.c

[PATCH 2/2] drm/bridge: ps8640: Let panel to set the connector type

2020-04-17 Thread Enric Balletbo i Serra
The panel connector type should be set by the panel not the bridge, so remove the connector_type assignment. Signed-off-by: Enric Balletbo i Serra --- drivers/gpu/drm/bridge/parade-ps8640.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/parade-ps8640.c b/drivers/gp

Re: [PATCH v12 09/11] backlight: pwm_bl: Use 64-bit division function

2020-04-17 Thread Guru Das Srinagesh
On Thu, Apr 16, 2020 at 10:44:20AM +0100, Lee Jones wrote: > On Wed, 08 Apr 2020, Guru Das Srinagesh wrote: > > > Since the PWM framework is switching struct pwm_state.period's datatype > > to u64, prepare for this transition by using div_u64 to handle a 64-bit > > dividend instead of a straight d

Re: [PATCH v3 2/2] drm/tegra: output: rgb: Support LVDS encoder bridge

2020-04-17 Thread Dmitry Osipenko
16.04.2020 20:41, Laurent Pinchart пишет: ... >> +if (output->bridge) { >> +err = drm_bridge_attach(&output->encoder, output->bridge, >> +NULL, DRM_BRIDGE_ATTACH_NO_CONNECTOR); > > Using DRM_BRIDGE_ATTACH_NO_CONNECTOR is definitely the way to go,

Re: [PATCH 1/2] dt-bindings: Clean-up schema indentation formatting

2020-04-17 Thread Alexandre Belloni
On 15/04/2020 19:55:48-0500, Rob Herring wrote: > Fix various inconsistencies in schema indentation. Most of these are > list indentation which should be 2 spaces more than the start of the > enclosing keyword. This doesn't matter functionally, but affects running > scripts which do transforms on t

[PATCH v2 5/7] drm/mediatek: mtk_dsi: Use simple encoder

2020-04-17 Thread Enric Balletbo i Serra
The mtk_dsi driver uses an empty implementation for its encoder. Replace the code with the generic simple encoder. Signed-off-by: Enric Balletbo i Serra --- Changes in v2: None drivers/gpu/drm/mediatek/mtk_dsi.c | 14 +++--- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git

Re: [PATCH v1 1/4] dt-bindings: display: convert atmel-hlcdc to DT Schema

2020-04-17 Thread Maxime Ripard
On Wed, Apr 15, 2020 at 06:39:56PM +0200, Sam Ravnborg wrote: > Hi Maxime. > > On Tue, Apr 14, 2020 at 10:28:03AM +0200, Maxime Ripard wrote: > > Hi Sam, > > > > On Sun, Apr 12, 2020 at 08:20:09PM +0200, Sam Ravnborg wrote: > > > diff --git > > > a/Documentation/devicetree/bindings/display/atmel/h

Re: [RFC 0/6] Regressions for "imply" behavior change

2020-04-17 Thread Jason Gunthorpe
On Thu, Apr 16, 2020 at 05:58:31PM +0200, Arnd Bergmann wrote: > On Thu, Apr 16, 2020 at 4:52 PM Jason Gunthorpe wrote: > > On Thu, Apr 16, 2020 at 02:38:50PM +0200, Arnd Bergmann wrote: > > > On Thu, Apr 16, 2020 at 12:17 PM Jani Nikula > > > wrote: > > > > Of course, this is all just talk unti

Re: [RFC 0/6] Regressions for "imply" behavior change

2020-04-17 Thread Jason Gunthorpe
On Thu, Apr 16, 2020 at 02:38:50PM +0200, Arnd Bergmann wrote: > On Thu, Apr 16, 2020 at 12:17 PM Jani Nikula > wrote: > > > > On Thu, 16 Apr 2020, Arnd Bergmann wrote: > > > On Thu, Apr 16, 2020 at 5:25 AM Saeed Mahameed > > > wrote: > > >> BTW how about adding a new Kconfig option to hide the

[PATCH] drm/bridge: panel: Return always an error pointer in drm_panel_bridge_add()

2020-04-17 Thread Enric Balletbo i Serra
Since commit 89958b7cd955 ("drm/bridge: panel: Infer connector type from panel by default"), drm_panel_bridge_add() and their variants can return NULL and an error pointer. This is fine but none of the actual users of the API are checking for the NULL value. Instead of change all the users, seems r

Re: [PATCH v2 7/7] drm/mediatek: mtk_dsi: Create connector for bridges

2020-04-17 Thread Enric Balletbo i Serra
Hi Laurent, On 16/4/20 19:36, Laurent Pinchart wrote: > Hi Enric, > > On Thu, Apr 16, 2020 at 08:35:26PM +0300, Laurent Pinchart wrote: >> On Thu, Apr 16, 2020 at 05:57:19PM +0200, Enric Balletbo i Serra wrote: >>> Use the drm_bridge_connector helper to create a connector for pipelines >>> that u

Re: [PATCH v3 1/2] drm/tegra: output: Don't leak OF node on error

2020-04-17 Thread Dmitry Osipenko
16.04.2020 20:27, Laurent Pinchart пишет: > Hi Dmitry, > > Thank you for the patch. > > On Thu, Apr 16, 2020 at 08:24:04PM +0300, Dmitry Osipenko wrote: >> The OF node should be put before returning error in tegra_output_probe(), >> otherwise node's refcount will be leaked. >> >> Signed-off-by: D

Re: [PATCH v10 0/2] Panel rotation patches

2020-04-17 Thread Dmitry Osipenko
15.04.2020 00:32, dbasehore . пишет: > On Tue, Apr 14, 2020 at 2:18 PM Dmitry Osipenko wrote: >> >> 14.04.2020 22:32, dbasehore . пишет: >>> Hi Dmitry, sorry for the late reply. >>> >>> On Sun, Mar 8, 2020 at 12:25 PM Dmitry Osipenko wrote: 06.03.2020 03:21, Derek Basehore пишет: >

Re: [RFC 0/6] Regressions for "imply" behavior change

2020-04-17 Thread Saeed Mahameed
On Thu, 2020-04-16 at 11:52 -0300, Jason Gunthorpe wrote: > On Thu, Apr 16, 2020 at 02:38:50PM +0200, Arnd Bergmann wrote: > > On Thu, Apr 16, 2020 at 12:17 PM Jani Nikula > > wrote: > > > On Thu, 16 Apr 2020, Arnd Bergmann wrote: > > > > On Thu, Apr 16, 2020 at 5:25 AM Saeed Mahameed < > > > > s

[PATCH v2 6/7] drm/mediatek: mtk_dsi: Use the drm_panel_bridge API

2020-04-17 Thread Enric Balletbo i Serra
Replace the manual panel handling code by a drm_panel_bridge. This simplifies the driver and allows all components in the display pipeline to be treated as bridges, paving the way to generic connector handling. Signed-off-by: Enric Balletbo i Serra --- Changes in v2: - Do not set connector_type

Re: [PATCH] staging: android: ion: Skip sync if not mapped

2020-04-17 Thread Ørjan Eide
On Thu, Apr 16, 2020 at 12:49:56PM +0300, Dan Carpenter wrote: > On Tue, Apr 14, 2020 at 04:18:47PM +0200, Ørjan Eide wrote: > > @@ -238,6 +242,10 @@ static void ion_unmap_dma_buf(struct > > dma_buf_attachment *attachment, > > struct sg_table *table, > >

[PATCH v3 1/2] drm/tegra: output: Don't leak OF node on error

2020-04-17 Thread Dmitry Osipenko
The OF node should be put before returning error in tegra_output_probe(), otherwise node's refcount will be leaked. Signed-off-by: Dmitry Osipenko --- drivers/gpu/drm/tegra/output.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/tegra/output.c b/driv

Re: [PATCH v3 2/2] drm/tegra: output: rgb: Support LVDS encoder bridge

2020-04-17 Thread Dmitry Osipenko
17.04.2020 00:39, Laurent Pinchart пишет: > Hi Dmitry, > > On Fri, Apr 17, 2020 at 12:15:33AM +0300, Dmitry Osipenko wrote: >> 16.04.2020 23:50, Laurent Pinchart пишет: >>> On Thu, Apr 16, 2020 at 11:21:40PM +0300, Dmitry Osipenko wrote: 16.04.2020 21:52, Dmitry Osipenko пишет: ... >

[PATCH v2 4/7] drm/mediatek: mtk_dsi: Convert to bridge driver

2020-04-17 Thread Enric Balletbo i Serra
Convert mtk_dsi to a bridge driver with built-in encoder support for compatibility with existing component drivers. Signed-off-by: Enric Balletbo i Serra --- Changes in v2: None drivers/gpu/drm/mediatek/mtk_dsi.c | 106 ++--- 1 file changed, 68 insertions(+), 38 deletio

Re: [PATCH v3 2/2] drm/tegra: output: rgb: Support LVDS encoder bridge

2020-04-17 Thread Dmitry Osipenko
16.04.2020 21:52, Dmitry Osipenko пишет: ... >> May I also recommend switching to the DRM panel bridge helper ? It will >> simplify the code. > > Could you please clarify what is the "DRM panel bridge helper"? > > I think we won't need any additional helpers after switching to the > bridge connec

[PATCH v2 1/7] drm/bridge: ps8640: Get the EDID from eDP control

2020-04-17 Thread Enric Balletbo i Serra
The PS8640 DSI-to-eDP bridge can retrieve the EDID, so implement the .get_edid callback and set the flag to indicate the core to use it. Signed-off-by: Enric Balletbo i Serra --- Changes in v2: None drivers/gpu/drm/bridge/parade-ps8640.c | 12 1 file changed, 12 insertions(+) dif

[PATCH v2 7/7] drm/mediatek: mtk_dsi: Create connector for bridges

2020-04-17 Thread Enric Balletbo i Serra
Use the drm_bridge_connector helper to create a connector for pipelines that use drm_bridge. This allows splitting connector operations across multiple bridges when necessary, instead of having the last bridge in the chain creating the connector and handling all connector operations internally. Si

Re: [PATCH v3 2/2] drm/tegra: output: rgb: Support LVDS encoder bridge

2020-04-17 Thread Dmitry Osipenko
16.04.2020 23:50, Laurent Pinchart пишет: > Hi Dmitry, > > On Thu, Apr 16, 2020 at 11:21:40PM +0300, Dmitry Osipenko wrote: >> 16.04.2020 21:52, Dmitry Osipenko пишет: >> ... May I also recommend switching to the DRM panel bridge helper ? It will simplify the code. >>> >>> Could you plea

[PATCH v2 0/7] Convert mtk-dsi to drm_bridge API and get EDID for ps8640 bridge

2020-04-17 Thread Enric Balletbo i Serra
The PS8640 dsi-to-eDP bridge driver is using the panel bridge API, however, not all the components in the chain have been ported to the drm_bridge API. Actually, when a panel is attached the default panel's mode is used, but in some cases we can't get display up if mode getting from eDP control E

[PATCH] drm/tegra: dc: Use devm_platform_ioremap_resource() to simplify code

2020-04-17 Thread Tang Bin
Use devm_platform_ioremap_resource() instead of platform_get_resource()+ devm_ioremap_resource(). Signed-off-by: Tang Bin --- drivers/gpu/drm/tegra/dc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/tegra/dc.c b/drivers/gpu/drm/tegra/dc.c index d26fb16d6

[PATCH v3 0/2] Support DRM bridges on NVIDIA Tegra

2020-04-17 Thread Dmitry Osipenko
Hello, This small series adds initial support for the DRM bridges to NVIDIA Tegra DRM driver. This is required by newer device-trees where we model the LVDS encoder bridge properly. Changelog: v3: - Following recommendation from Sam Ravnborg, the new bridge attachment model is now being us

Re: [RFC 0/6] Regressions for "imply" behavior change

2020-04-17 Thread Jason Gunthorpe
On Thu, Apr 16, 2020 at 11:12:56AM -0400, Nicolas Pitre wrote: > On Thu, 16 Apr 2020, Arnd Bergmann wrote: > > > On Thu, Apr 16, 2020 at 12:17 PM Jani Nikula > > wrote: > > > > > > On Thu, 16 Apr 2020, Arnd Bergmann wrote: > > > > On Thu, Apr 16, 2020 at 5:25 AM Saeed Mahameed > > > > wrote: >

[PATCH v2 2/7] drm/bridge_connector: Set default status connected for eDP connectors

2020-04-17 Thread Enric Balletbo i Serra
In an eDP application, HPD is not required and on most bridge chips useless. If HPD is not used, we need to set initial status as connected, otherwise the connector created by the drm_bridge_connector API remains in an unknown state. Signed-off-by: Enric Balletbo i Serra --- Changes in v2: None

[PATCH v2 3/7] drm/mediatek: mtk_dsi: Rename bridge to next_bridge

2020-04-17 Thread Enric Balletbo i Serra
This is really a cosmetic change just to make a bit more readable the code after convert the driver to drm_bridge. The bridge variable name will be used by the encoder drm_bridge, and the chained bridge will be named next_bridge. Signed-off-by: Enric Balletbo i Serra --- Changes in v2: None dr

Re: [PATCH v6 1/8] drm: bridge: dw_mipi_dsi: add initial regmap infrastructure

2020-04-17 Thread Adrian Ratiu
On Thu, 16 Apr 2020, Enric Balletbo Serra wrote: Hi Adrian, [snip] >> >> +static void dw_mipi_dsi_get_hw_version(struct dw_mipi_dsi >> *dsi) +{ + regmap_read(dsi->regs, DSI_VERSION, >> &dsi->hw_version); + dsi->hw_version &= VERSION; + if >> (!dsi->hw_version) +

Re: [PULL] topic/phy-compliance

2020-04-17 Thread Thomas Zimmermann
Merged into drm-misc-next Am 08.04.20 um 14:49 schrieb Maarten Lankhorst: > Hey, > > Here's a pull request to pull in the DP PHY Compliance series. > It's based on top of drm/drm-next, and contains all patches for core, amd and > i915. :) > > Cheers, > Maarten > > topic/phy-compliance-2020-04-

Re: RFC: Drm-connector properties managed by another driver / privacy screen support

2020-04-17 Thread Pekka Paalanen
On Wed, 15 Apr 2020 17:40:46 +0200 Hans de Goede wrote: > Hi, > > On 4/15/20 5:28 PM, Jani Nikula wrote: > > On Wed, 15 Apr 2020, Hans de Goede wrote: > >> ii. Currently the "privacy-screen" property added by Rajat's > >> patch-set is an enum with 2 possible values: > >> "Enabled" > >> "Disab

Re: RFC: Drm-connector properties managed by another driver / privacy screen support

2020-04-17 Thread Pekka Paalanen
On Thu, 16 Apr 2020 00:10:06 +0300 Jani Nikula wrote: > On Wed, 15 Apr 2020, Rajat Jain wrote: > > * I think having 2 properties might be a confusing UAPI. Also, we have > > existing properties like link-status that can be changed by both the > > user and the hardware. > > I think the consen

Re: [PATCH trivial 5/6] ALSA: Fix misspellings of "Analog Devices"

2020-04-17 Thread Takashi Iwai
On Thu, 16 Apr 2020 12:30:57 +0200, Geert Uytterhoeven wrote: > > According to https://www.analog.com/, the company name is spelled > "Analog Devices". > > Signed-off-by: Geert Uytterhoeven Applied this patch to sound git tree for-next branch. thanks, Takashi > --- > sound/isa/ad1816a/ad1

Re: [PATCH v6 4/8] drm: imx: Add i.MX 6 MIPI DSI host platform driver

2020-04-17 Thread Adrian Ratiu
Hi Enric & Laurent, On Wed, 15 Apr 2020, Laurent Pinchart wrote: Hi Enric, On Wed, Apr 15, 2020 at 07:26:02PM +0200, Enric Balletbo Serra wrote: Missatge de Adrian Ratiu del dia dt., 14 d’abr. 2020 a les 17:19: > > This adds support for the Synopsis DesignWare MIPI DSI v1.01 > host con

Re: [PATCH 1/1] video: backlight: tosa_lcd: convert to use i2c_new_client_device()

2020-04-17 Thread Lee Jones
On Thu, 26 Mar 2020, Wolfram Sang wrote: > Move away from the deprecated API and return the shiny new ERRPTR where > useful. > > Signed-off-by: Wolfram Sang > --- > drivers/video/backlight/tosa_lcd.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Applied, thanks. -- Lee Jones [李

Re: Multiple regulators for one device [was drm/panfrost: add devfreq regulator support]

2020-04-17 Thread Robin Murphy
On 2020-04-16 2:42 pm, Steven Price wrote: [...] Perhaps a better approach would be for Panfrost to hand over the struct regulator objects it has already got to the OPP framework. I.e. open code dev_pm_opp_set_regulators(), but instead of calling regulator_get_optional() simply populate the reg

[PULL] drm-intel-next

2020-04-17 Thread Joonas Lahtinen
itory at: git://anongit.freedesktop.org/drm/drm-intel tags/drm-intel-next-2020-04-17 for you to fetch changes up to b06ef327e26367b9286a2079b31cde8d2161c0d8: drm/i915: Update DRIVER_DATE to 20200417 (2020-04-17 09:35:00 +0300) --

[PATCH 4/5] backlight: led_bl: fix led -> backlight brightness mapping

2020-04-17 Thread Tomi Valkeinen
The code that maps the LED default brightness to backlight levels has two issues: 1) if the default brightness is the first backlight level (usually 0), the code fails to find it, and 2) when the code fails to find a backlight level, it ends up using max_brightness + 1 as the default brightness. F

[PATCH 1/5] backlight: led_bl: fix cosmetic issues

2020-04-17 Thread Tomi Valkeinen
Fix issues reported by checkpatch. No functional changes. Signed-off-by: Tomi Valkeinen --- drivers/video/backlight/led_bl.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/video/backlight/led_bl.c b/drivers/video/backlight/led_bl.c index 3f66549997c8..

[PATCH 2/5] backlight: led_bl: drop useless NULL initialization

2020-04-17 Thread Tomi Valkeinen
There's no need to set 'levels' to NULL. Signed-off-by: Tomi Valkeinen --- drivers/video/backlight/led_bl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/backlight/led_bl.c b/drivers/video/backlight/led_bl.c index d4e1ce684366..c46ecdfe8b0a 100644 --- a/driver

[PATCH 3/5] backlight: led_bl: add led_access locking

2020-04-17 Thread Tomi Valkeinen
led_bl does not lock 'led_access' when calling led_sysfs_disable and led_sysfs_enable, causing the below WARN. Add the locking. WARNING: CPU: 0 PID: 223 at drivers/leds/led-core.c:353 led_sysfs_disable+0x4c/0x5c Signed-off-by: Tomi Valkeinen --- drivers/video/backlight/led_bl.c | 10 --

[PATCH 5/5] backlight: led_bl: rewrite led_bl_parse_levels()

2020-04-17 Thread Tomi Valkeinen
led_bl_parse_levels() is rather difficult to follow. Rewrite it with a more obvious code flow. Signed-off-by: Tomi Valkeinen --- drivers/video/backlight/led_bl.c | 63 1 file changed, 32 insertions(+), 31 deletions(-) diff --git a/drivers/video/backlight/led_bl.

Re: [PATCH trivial 2/6] dma: Fix misspelling of "Analog Devices"

2020-04-17 Thread Vinod Koul
On 16-04-20, 12:30, Geert Uytterhoeven wrote: > According to https://www.analog.com/, the company name is spelled > "Analog Devices". Applied after updating the subsystem name, thanks -- ~Vinod ___ dri-devel mailing list dri-devel@lists.freedesktop.org

Re: RFC: Drm-connector properties managed by another driver / privacy screen support

2020-04-17 Thread Jani Nikula
On Fri, 17 Apr 2020, Pekka Paalanen wrote: > On Wed, 15 Apr 2020 17:40:46 +0200 > Hans de Goede wrote: > >> Hi, >> >> On 4/15/20 5:28 PM, Jani Nikula wrote: >> > On Wed, 15 Apr 2020, Hans de Goede wrote: >> >> ii. Currently the "privacy-screen" property added by Rajat's >> >> patch-set is an

[PATCH] drm/panel: panel-simple: Set AUO G101EVN010 panel type

2020-04-17 Thread Tomi Valkeinen
The AUO G101EVN010 is a 18-bit LVDS panel, not a parallel panel, as indicated by the current bus_format. Fix the bus_format to MEDIA_BUS_FMT_RGB666_1X7X3_SPWG, and also set the connector_type to LVDS. Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/panel/panel-simple.c | 3 ++- 1 file changed

[PATCH] drm/omap: change default signal polarities and drives

2020-04-17 Thread Tomi Valkeinen
If the given videomode does not specify DISPLAY_FLAG_* for the specific signal property, the driver used a default value. These defaults were never thought through, as the expectation was that all the DISPLAY_FLAGS are always set explicitly. With DRM bridge and panel drivers this is not the case,

[PATCH v10 00/14] In order to readout DP SDPs, refactors the handling of DP SDPs

2020-04-17 Thread Gwan-gyeong Mun
In order to readout DP SDPs (Secondary Data Packet: DP HDR Metadata Infoframe SDP, DP VSC SDP), it refactors handling DP SDPs codes. It adds new compute routines for DP HDR Metadata Infoframe SDP and DP VSC SDP. And new writing routines of DP SDPs (Secondary Data Packet) that uses computed configs

[PATCH v10 07/14] drm/i915: Program DP SDPs with computed configs

2020-04-17 Thread Gwan-gyeong Mun
In order to use computed config for DP SDPs (DP VSC SDP and DP HDR Metadata Infoframe SDP), it replaces intel_dp_vsc_enable() function and intel_dp_hdr_metadata_enable() function to intel_dp_set_infoframes() function. And it removes unused functions. Before: intel_dp_vsc_enable() and intel_dp_hdr

[PATCH v10 11/14] drm/i915: Program DP SDPs on pipe updates

2020-04-17 Thread Gwan-gyeong Mun
Call intel_dp_set_infoframes() function on pipe updates to make sure that we send VSC SDP and HDR Metadata Infoframe SDP (when applicable) on fastsets. Signed-off-by: Gwan-gyeong Mun Reviewed-by: Uma Shankar --- drivers/gpu/drm/i915/display/intel_ddi.c | 1 + 1 file changed, 1 insertion(+) dif

[PATCH v10 14/14] drm/i915/psr: Use new DP VSC SDP compute routine on PSR

2020-04-17 Thread Gwan-gyeong Mun
In order to use a common VSC SDP Colorimetry calculating code on PSR, it uses a new psr vsc sdp compute routine. Because PSR routine has its own scenario and timings of writing a VSC SDP, the current PSR routine needs to have its own drm_dp_vsc_sdp structure member variable on struct i915_psr. In

[PATCH v10 02/14] drm/i915/dp: Read out DP SDPs

2020-04-17 Thread Gwan-gyeong Mun
It adds code to read the DP SDPs from the video DIP and unpack them into the crtc state. It adds routines that read out DP VSC SDP and DP HDR Metadata Infoframe SDP In order to unpack DP VSC SDP, it adds intel_dp_vsc_sdp_unpack() function. It follows DP 1.4a spec. [Table 2-116: VSC SDP Header Byte

[PATCH v10 09/14] drm/i915: Add state readout for DP VSC SDP

2020-04-17 Thread Gwan-gyeong Mun
Added state readout for DP VSC SDP and enabled state validation for DP VSC SDP. v2: Minor style fix v3: Replace a structure name to drm_dp_vsc_sdp from intel_dp_vsc_sdp v4: Use struct drm_device logging macros v10: Skip checking of VSC SDP when a crtc config has psr. Signed-off-by: Gwan-gyeong Mu

[PATCH v10 01/14] video/hdmi: Add Unpack only function for DRM infoframe

2020-04-17 Thread Gwan-gyeong Mun
It adds an unpack only function for DRM infoframe for dynamic range and mastering infoframe readout. It unpacks the information data block contained in the binary buffer into a structured frame of the HDMI Dynamic Range and Mastering (DRM) information frame. In contrast to hdmi_drm_infoframe_unpac

[PATCH v10 12/14] drm/i915: Stop sending DP SDPs on ddi disable

2020-04-17 Thread Gwan-gyeong Mun
Call intel_dp_set_infoframes(false) function on intel_ddi_post_disable_dp() to make sure not to send VSC SDP and HDR Metadata Infoframe SDP. v5: Polish commit message [Uma] Signed-off-by: Gwan-gyeong Mun Reviewed-by: Uma Shankar --- drivers/gpu/drm/i915/display/intel_ddi.c | 2 ++ 1 file chang

[PATCH v10 13/14] drm/i915/dp: Add compute routine for DP PSR VSC SDP

2020-04-17 Thread Gwan-gyeong Mun
In order to use a common VSC SDP Colorimetry calculating code on PSR, it adds a compute routine for PSR VSC SDP. As PSR routine can not use infoframes.vsc of crtc state, it also adds new writing of DP SDPs (Secondary Data Packet) for PSR. PSR routine has its own scenario and timings of writing a VS

[PATCH v10 08/14] drm/i915: Add state readout for DP HDR Metadata Infoframe SDP

2020-04-17 Thread Gwan-gyeong Mun
Added state readout for DP HDR Metadata Infoframe SDP. v9: Rebased v10: Rebased Signed-off-by: Gwan-gyeong Mun Reviewed-by: Uma Shankar --- drivers/gpu/drm/i915/display/intel_ddi.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/g

[PATCH v10 04/14] drm/i915: Include HDMI DRM infoframe in the crtc state dump

2020-04-17 Thread Gwan-gyeong Mun
Dump out the HDMI Dynamic Range and Mastering (DRM) infoframe in the normal crtc state dump. Signed-off-by: Gwan-gyeong Mun Reviewed-by: Uma Shankar --- drivers/gpu/drm/i915/display/intel_display.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_display

[PATCH v10 03/14] drm: Add logging function for DP VSC SDP

2020-04-17 Thread Gwan-gyeong Mun
When receiving video it is very useful to be able to log DP VSC SDP. This greatly simplifies debugging. v2: Minor style fix v3: Move logging functions to drm core [Jani N] v5: Rebased v10: Rebased Signed-off-by: Gwan-gyeong Mun Reviewed-by: Uma Shankar --- drivers/gpu/drm/drm_dp_helper.c | 174

[PATCH v10 05/14] drm/i915: Include DP HDR Metadata Infoframe SDP in the crtc state dump

2020-04-17 Thread Gwan-gyeong Mun
Dump out the DP HDR Metadata Infoframe SDP in the normal crtc state dump. HDMI Dynamic Range and Mastering (DRM) infoframe and DP HDR Metadata Infoframe SDP use the same member variable in infoframes of crtc state. Signed-off-by: Gwan-gyeong Mun Reviewed-by: Uma Shankar --- drivers/gpu/drm/i91

[PATCH v10 06/14] drm/i915: Include DP VSC SDP in the crtc state dump

2020-04-17 Thread Gwan-gyeong Mun
Dump out the DP VSC SDP in the normal crtc state dump v3: Replace a structure name to drm_dp_vsc_sdp from intel_dp_vsc_sdp Use drm core's DP VSC SDP logging function Signed-off-by: Gwan-gyeong Mun Reviewed-by: Uma Shankar --- drivers/gpu/drm/i915/display/intel_display.c | 13 +

[PATCH v10 10/14] drm/i915: Fix enabled infoframe states of lspcon

2020-04-17 Thread Gwan-gyeong Mun
Compared to implementation of DP and HDMI's encoder->infoframes_enabled, the lspcon's implementation returns its active state. (we expect enabled infoframe states of HW.) It leads to pipe state mismatch error when ddi_get_config is called. Because the current implementation of lspcon is not ready

Re: [drm:simple_bridge_attach [simple_bridge]] *ERROR* Fix bridge driver to make connector optional!

2020-04-17 Thread Laurent Pinchart
Hello, On Fri, Apr 17, 2020 at 02:44:22PM +0200, Maxime Ripard wrote: > On Fri, Apr 17, 2020 at 02:18:11PM +0200, H. Nikolaus Schaller wrote: > > Hi Maxime, > > I have started to test v5.7-rc1 and can't fully boot the GTA04 > > device any more. > > > > What I see in the log is: > > > > [ 28.56

Re: [PATCH] drm/panel: panel-simple: Set AUO G101EVN010 panel type

2020-04-17 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Fri, Apr 17, 2020 at 04:00:34PM +0300, Tomi Valkeinen wrote: > (Adding Alex to the thread) > > On 17/04/2020 14:40, Tomi Valkeinen wrote: > > The AUO G101EVN010 is a 18-bit LVDS panel, not a parallel panel, as > > indicated by the current bus_format. > > > >

Re: [PATCH] drm/panel: panel-simple: Set AUO G101EVN010 panel type

2020-04-17 Thread Tomi Valkeinen
(Adding Alex to the thread) On 17/04/2020 14:40, Tomi Valkeinen wrote: The AUO G101EVN010 is a 18-bit LVDS panel, not a parallel panel, as indicated by the current bus_format. Fix the bus_format to MEDIA_BUS_FMT_RGB666_1X7X3_SPWG, and also set the connector_type to LVDS. Signed-off-by: Tomi Va

Re: [PATCH] drm/omap: change default signal polarities and drives

2020-04-17 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Fri, Apr 17, 2020 at 02:41:51PM +0300, Tomi Valkeinen wrote: > If the given videomode does not specify DISPLAY_FLAG_* for the specific > signal property, the driver used a default value. These defaults were > never thought through, as the expectation was that

Re: [PATCH] drm/omap: change default signal polarities and drives

2020-04-17 Thread Laurent Pinchart
Hi Tomi, On Fri, Apr 17, 2020 at 04:34:19PM +0300, Tomi Valkeinen wrote: > On 17/04/2020 16:29, Laurent Pinchart wrote: > > On Fri, Apr 17, 2020 at 02:41:51PM +0300, Tomi Valkeinen wrote: > >> If the given videomode does not specify DISPLAY_FLAG_* for the specific > >> signal property, the driver

Re: [PATCH] drm/omap: change default signal polarities and drives

2020-04-17 Thread Tomi Valkeinen
On 17/04/2020 16:29, Laurent Pinchart wrote: Hi Tomi, Thank you for the patch. On Fri, Apr 17, 2020 at 02:41:51PM +0300, Tomi Valkeinen wrote: If the given videomode does not specify DISPLAY_FLAG_* for the specific signal property, the driver used a default value. These defaults were never tho

Re: [PATCH] drm/amd/powerplay: remove defined but not used variables

2020-04-17 Thread Alex Deucher
On Fri, Apr 17, 2020 at 9:16 AM Jason Yan wrote: > > Fix the following gcc warning: > > drivers/gpu/drm/amd/amdgpu/../powerplay/hwmgr/vega10_powertune.c:710:46: > warning: ‘PSMGCEDCThresholdConfig_vega10’ defined but not used > [-Wunused-const-variable=] > static const struct vega10_didt_config_r

Re: [PATCH -next] drm/amd/dc: remove unused variable 'video_optimized_pixel_rates'

2020-04-17 Thread Alex Deucher
On Fri, Apr 17, 2020 at 9:16 AM YueHaibing wrote: > > drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_clock_source.c:1017:50: > warning: ‘video_optimized_pixel_rates’ defined but not used > [-Wunused-const-variable=] > static const struct pixel_rate_range_table_entry > video_optimized_pixel_r

[PATCH v2 06/17] drm/msm: dsi: Use OPP API to set clk/perf state

2020-04-17 Thread Rajendra Nayak
On SDM845 DSI needs to express a perforamnce state requirement on a power domain depending on the clock rates. Use OPP table from DT to register with OPP framework and use dev_pm_opp_set_rate() to set the clk/perf state. Signed-off-by: Rajendra Nayak Cc: Rob Clark Cc: Sean Paul Cc: dri-devel@li

[PATCH v2 05/17] drm/msm/dpu: Use OPP API to set clk/perf state

2020-04-17 Thread Rajendra Nayak
On some qualcomm platforms DPU needs to express a perforamnce state requirement on a power domain depennding on the clock rates. Use OPP table from DT to register with OPP framework and use dev_pm_opp_set_rate() to set the clk/perf state. Signed-off-by: Rajendra Nayak Cc: Rob Clark Cc: Sean Paul

Re: [PATCH v1 1/5] video: ssd1307fb: Convert driver to use ->probe_new()

2020-04-17 Thread Bartlomiej Zolnierkiewicz
[ added dri-devel ML to Cc: ] On 3/24/20 6:05 PM, Andy Shevchenko wrote: > Use the ->probe_new() callback. > > The driver does not use const struct i2c_device_id * argument, > so convert it to utilise the simplified I²C driver registration. > > Signed-off-by: Andy Shevchenko Patch queued for

Re: [PATCH v1 4/5] video: ssd1307fb: Convert to atomic PWM API

2020-04-17 Thread Bartlomiej Zolnierkiewicz
[ added dri-devel ML to Cc: ] On 3/24/20 6:05 PM, Andy Shevchenko wrote: > Use the atomic API wherever appropriate and get rid of pwm_apply_args() > call (the reference period and polarity are now explicitly set when > calling pwm_apply_state()). > > We also make use of the pwm_set_relative_dut

Re: [PATCH v2 0/6] video: fbdev: controlfb: small cleanup

2020-04-17 Thread Bartlomiej Zolnierkiewicz
On 3/24/20 2:45 PM, Bartlomiej Zolnierkiewicz wrote: > Hi, > > Small cleanup for controlfb driver: > > - fix sparse warnings > - remove not working module support > - add COMPILE_TEST support > - remove redundant function prototypes > > Changes since v1 > (https://lore.kernel.org/lkml/20200116

Re: [PATCH v1 2/5] video: ssd1307fb: Introduce temporary variable to increase readability

2020-04-17 Thread Bartlomiej Zolnierkiewicz
[ added dri-devel ML to Cc: ] On 3/24/20 6:05 PM, Andy Shevchenko wrote: > Introduce temporary variable to increase readability of the code. > > Signed-off-by: Andy Shevchenko Patch queued for v5.8 (w/ few lines over 80 characters fixed), thanks. Best regards, -- Bartlomiej Zolnierkiewicz Sa

Re: [PATCH -next] omapfb/dss: remove unused varible 'venc_config_pal_bdghi'

2020-04-17 Thread Bartlomiej Zolnierkiewicz
On 4/15/20 3:23 PM, YueHaibing wrote: > drivers/video/fbdev/omap2/omapfb/dss/venc.c:212:33: > warning: ‘venc_config_pal_bdghi’ defined but not used > [-Wunused-const-variable=] > static const struct venc_config venc_config_pal_bdghi = { > ^ >

Re: [PATCH v1 5/5] video: ssd1307fb: Remove redundant forward declaration

2020-04-17 Thread Bartlomiej Zolnierkiewicz
[ added dri-devel ML to Cc: ] On 3/24/20 6:05 PM, Andy Shevchenko wrote: > There is no need to have forward declaration of struct ssd1307fb_par. > Drop it for good. > > Signed-off-by: Andy Shevchenko Patch queued for v5.8, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Instit

Re: [PATCH] video: fbdev: imxfb: ensure balanced regulator usage

2020-04-17 Thread Bartlomiej Zolnierkiewicz
On 3/23/20 10:16 PM, Uwe Kleine-König wrote: > The fbdev framework doesn't care to call the .set_power callback only on > changes. So the driver has to care for itself that the regulator doesn't > get disabled more often than enabled. > > This fixes the regulator warning > > unbalanced dis

Re: [PATCH v2 1/6] video: fbdev: controlfb: fix sparse warning about using incorrect type

2020-04-17 Thread Bartlomiej Zolnierkiewicz
On 3/24/20 9:45 PM, Daniel Vetter wrote: > On Tue, Mar 24, 2020 at 02:45:03PM +0100, Bartlomiej Zolnierkiewicz wrote: >> Use in_le32() instead of le32_to_cpup() to fix sparse warning about >> improper type of the argument. >> >> Also add missing inline keyword to control_par_to_var() definition >

Re: [PATCH v1 3/5] video: ssd1307fb: Make use of device properties

2020-04-17 Thread Bartlomiej Zolnierkiewicz
[ added dri-devel ML to Cc: ] On 3/24/20 6:05 PM, Andy Shevchenko wrote: > Device property API allows to gather device resources from different sources, > such as ACPI. Convert the drivers to unleash the power of device property API. > > Signed-off-by: Andy Shevchenko Patch queued for v5.8, t

Re: [PATCH] video: vt8500lcdfb: fix fallthrough warning

2020-04-17 Thread Bartlomiej Zolnierkiewicz
On 4/12/20 10:21 PM, Sam Ravnborg wrote: > Fix following warning: > vt8500lcdfb.c: In function 'vt8500lcd_blank': > vt8500lcdfb.c:229:6: warning: this statement may fall through > [-Wimplicit-fallthrough=] > if (info->fix.visual == FB_VISUAL_PSEUDOCOLOR || > ^ > vt8500lcdfb.c:233:

Re: [PATCH] video: fbdev: aty128fb: remove unused 'sdr_64'

2020-04-17 Thread Bartlomiej Zolnierkiewicz
On 4/17/20 11:23 AM, Jason Yan wrote: > Fix the following gcc warning: > > drivers/video/fbdev/aty/aty128fb.c:337:36: warning: ‘sdr_64’ defined but > not used [-Wunused-const-variable=] > static const struct aty128_meminfo sdr_64 = { > ^~ > > Reported-by:

Re: [PATCH v3] fbdev: s1d13xxxfb: add missed unregister_framebuffer in remove

2020-04-17 Thread Bartlomiej Zolnierkiewicz
On 3/24/20 2:23 PM, Chuhong Yuan wrote: > The driver calls register_framebuffer() in probe but does not call > unregister_framebuffer() in remove. > Rename current remove to __s1d13xxxfb_remove() for error handler. > Then add a new remove to call unregister_framebuffer(). > > Signed-off-by: Chuh

Re: [PATCH v2 RESEND] ARM/fbdev: sa11x0: Switch to use GPIO descriptors

2020-04-17 Thread Bartlomiej Zolnierkiewicz
[ added dri-devel ML to Cc: ] On 4/15/20 6:50 PM, Linus Walleij wrote: > This converts the SA11x0 frame buffer driver to use > GPIO descriptors. Get the GPIO optional and register > a look-up table specifically for the Shannon machine. > > Cc: Russell King > Cc: Bartlomiej Zolnierkiewicz > Si

Re: [PATCH v4] video: fbdev: vesafb: add missed release_region

2020-04-17 Thread Bartlomiej Zolnierkiewicz
On 3/29/20 4:58 PM, Chuhong Yuan wrote: > The driver forgets to free the I/O region in remove and probe > failure. > Add the missed calls to fix it. > > Since the success of request_region() is optional, add the "region" field > in vesafb_par to represent whether request_region() succeeds. > The

Re: [PATCH v4] video: fbdev: arcfb: add missed free_irq and fix the order of request_irq

2020-04-17 Thread Bartlomiej Zolnierkiewicz
On 3/24/20 2:23 PM, Chuhong Yuan wrote: > The driver forgets to free irq in remove which is requested in > probe. > Add the missed call to fix it. > Also, the position of request_irq() in probe should be put before > register_framebuffer(). > > Signed-off-by: Chuhong Yuan Patch queued for v5.8

Re: RFC: Drm-connector properties managed by another driver / privacy screen support

2020-04-17 Thread Daniel Vetter
On Fri, Apr 17, 2020 at 11:02 AM Pekka Paalanen wrote: > > On Wed, 15 Apr 2020 17:40:46 +0200 > Hans de Goede wrote: > > > Hi, > > > > On 4/15/20 5:28 PM, Jani Nikula wrote: > > > On Wed, 15 Apr 2020, Hans de Goede wrote: > > >> ii. Currently the "privacy-screen" property added by Rajat's > > >>

Re: RFC: Drm-connector properties managed by another driver / privacy screen support

2020-04-17 Thread Daniel Vetter
On Fri, Apr 17, 2020 at 1:55 PM Jani Nikula wrote: > > On Fri, 17 Apr 2020, Pekka Paalanen wrote: > > On Wed, 15 Apr 2020 17:40:46 +0200 > > Hans de Goede wrote: > > > >> Hi, > >> > >> On 4/15/20 5:28 PM, Jani Nikula wrote: > >> > On Wed, 15 Apr 2020, Hans de Goede wrote: > >> >> ii. Currently

Re: RFC: Drm-connector properties managed by another driver / privacy screen support

2020-04-17 Thread Benjamin Berg
On Fri, 2020-04-17 at 16:18 +0200, Daniel Vetter wrote: > > I suppose rf-kill is a bit similar. RfKill is actually much more complicated, and I don't really see how it is related. We may be in the situation where we cannot control the hardware state, but RfKill has two entirely separate "block" st

Re: [PATCH 1/5] drm/modes: Indicate CEA-861 CE modes to user-space

2020-04-17 Thread Daniel Vetter
On Thu, Apr 16, 2020 at 03:51:36PM +0200, Yussuf Khalil wrote: > On Tue, 2020-04-14 at 14:41 +0200, Daniel Vetter wrote: > > On Mon, Apr 13, 2020 at 11:40:22PM +0200, Yussuf Khalil wrote: > > > Add a new flag to mark modes that are considered a CE mode > > > according to the > > > CEA-861 specifica

Re: [PATCH 5/5] drm/i915: Replace "Broadcast RGB" with "RGB quantization range" property

2020-04-17 Thread Daniel Vetter
On Thu, Apr 16, 2020 at 03:44:53PM +0200, Yussuf Khalil wrote: > On Wed, 2020-04-15 at 13:13 +0200, Daniel Vetter wrote: > > On Wed, Apr 15, 2020 at 10:33:25AM +0300, Jani Nikula wrote: > > > On Tue, 14 Apr 2020, Yussuf Khalil wrote: > > > > On Tue, 2020-04-14 at 14:34 +0200, Daniel Vetter wrote:

Re: [PATCH] staging: android: ion: Skip sync if not mapped

2020-04-17 Thread Daniel Vetter
On Thu, Apr 16, 2020 at 12:25:08PM +0200, Greg Kroah-Hartman wrote: > On Tue, Apr 14, 2020 at 09:41:31PM -0700, John Stultz wrote: > > On Tue, Apr 14, 2020 at 7:28 AM Greg Kroah-Hartman > > wrote: > > > > > > On Tue, Apr 14, 2020 at 04:18:47PM +0200, Ørjan Eide wrote: > > > > Only sync the sg-list

Re: [PATCH trivial 3/6] drm: Fix misspellings of "Analog Devices"

2020-04-17 Thread Daniel Vetter
On Thu, Apr 16, 2020 at 12:30:55PM +0200, Geert Uytterhoeven wrote: > According to https://www.analog.com/, the company name is spelled > "Analog Devices". > > Signed-off-by: Geert Uytterhoeven Queued for 5.8 in drm-misc-next, thanks for your patch. -Daniel > --- > drivers/gpu/drm/bridge/adv75

  1   2   >