On Wed, Apr 15, 2020 at 8:40 AM Jani Nikula wrote:
>
> On Wed, 08 Apr 2020, Maarten Lankhorst
> wrote:
> > Hey,
> >
> > Here's a pull request to pull in the DP PHY Compliance series.
> > It's based on top of drm/drm-next, and contains all patches for core, amd
> > and i915. :)
>
> Ping, I don't
Hi Mark,
On Tue, 14 Apr 2020 at 20:55, Mark Brown wrote:
>
> On Tue, Apr 14, 2020 at 08:20:23PM +0200, Clément Péron wrote:
> > Hi Liam and Mark,
>
> You might want to flag stuff like this in the subject line, I very
> nearly deleted this without opening it since most of the email I get
> about p
Only sync the sg-list of an Ion dma-buf attachment when the attachment
is actually mapped on the device.
dma-bufs may be synced at any time. It can be reached from user space
via DMA_BUF_IOCTL_SYNC, so there are no guarantees from callers on when
syncs may be attempted, and dma_buf_end_cpu_access(
14.04.2020 22:32, dbasehore . пишет:
> Hi Dmitry, sorry for the late reply.
>
> On Sun, Mar 8, 2020 at 12:25 PM Dmitry Osipenko wrote:
>>
>> 06.03.2020 03:21, Derek Basehore пишет:
>>> This adds the plumbing for reading panel rotation from the devicetree
>>> and sets up adding a panel property fo
On Fri, Mar 27, 2020 at 1:20 AM Gerd Hoffmann wrote:
>
> > > Hmm, yes, I can see loopback virtio being useful for various cases.
> > > Testing being one. A dummy virtio-gpu could be done too, or a more
> > > advanced version which exports the display as vnc.
> > So what's your suggestion on this?
On Tue, Apr 14, 2020 at 09:15:07AM +0100, Chris Wilson wrote:
> The patch does not fix a deadlock. Greg, this patch is not a backport of
> a bugfix, why is it in stable?
> -Chris
Here's the deadlock this supposedly doesn't fix:
INFO: task kswapd0:178 blocked for more than 122 seconds.
Tainte
On Tue, Apr 14, 2020 at 09:13:28AM +0100, Chris Wilson wrote:
> Quoting Sultan Alsawaf (2020-04-07 07:26:22)
> > From: Sultan Alsawaf
> >
> > The following deadlock exists in i915_active_wait() due to a double lock
> > on ref->mutex (call chain listed in order from top to bottom):
> > i915_activ
Dne ponedeljek, 30. marec 2020 ob 00:22:53 CEST je Vasily Khoruzhick
napisal(a):
> Some drivers (e.g. sun4i-drm) need this info to decide whether they
> need to enable dithering. Currently driver reports what panel supports
> and if panel supports 8 we don't get dithering enabled.
>
> Hardcode BP
On Mon, Apr 13, 2020 at 09:53:29AM +0200, Lukas Bulwahn wrote:
> Commit f5a98bfe7b37 ("dt-bindings: display: Convert Allwinner display
> pipeline to schemas") replaced sunxi/sun4i-drm.txt with
> allwinner,sun*.yaml files in Documentation/devicetree/bindings/display/,
> but did not adjust DRM DRIVER
On some processors, the / operate will call the compiler`s div lib,
which is low efficient, We can replace the / operation with shift,
so that we can replace the call of the division library with one
shift assembly instruction.
Signed-off-by: Bernard Zhao
---
drivers/gpu/drm/amd/amdgpu/gmc_v6_0.
Quoting Sandeep Maheswaram (2020-04-01 23:38:52)
> Convert QMP PHY bindings to DT schema format using json-schema.
>
> Signed-off-by: Sandeep Maheswaram
> ---
> .../devicetree/bindings/phy/qcom,qmp-phy.yaml | 332
> +
> .../devicetree/bindings/phy/qcom-qmp-phy.txt
Newer Tegra device-trees will define a video output graph which involves
a bridge. This patch adds support for the DRM bridges to the Tegra's DRM
output.
Signed-off-by: Dmitry Osipenko
---
drivers/gpu/drm/tegra/drm.h| 2 ++
drivers/gpu/drm/tegra/output.c | 25 -
2 fi
On Tue, Apr 14, 2020 at 04:28:10PM +0200, Greg Kroah-Hartman wrote:
> On Tue, Apr 14, 2020 at 04:18:47PM +0200, �rjan Eide wrote:
> > Only sync the sg-list of an Ion dma-buf attachment when the attachment
> > is actually mapped on the device.
> >
> > dma-bufs may be synced at any time. It can be
Hi Sam,
On Sun, Apr 12, 2020 at 08:20:09PM +0200, Sam Ravnborg wrote:
> diff --git a/Documentation/devicetree/bindings/display/atmel/hlcdc-dc.yaml
> b/Documentation/devicetree/bindings/display/atmel/hlcdc-dc.yaml
> new file mode 100644
> index ..7eb6266a25a2
> --- /dev/null
> +++ b/Do
Hi Liam and Mark,
On Tue, 14 Apr 2020 at 15:10, Steven Price wrote:
>
> Hi Clément,
>
> On 13/04/2020 18:28, Clément Péron wrote:
> > Hi Steven,
> >
> > On Mon, 13 Apr 2020 at 18:35, Clément Péron wrote:
> >>
> >> Hi Steven,
> >>
> >> On Mon, 13 Apr 2020 at 17:55, Steven Price wrote:
> >>>
> >>
On Tue, Apr 14, 2020 at 2:18 PM Dmitry Osipenko wrote:
>
> 14.04.2020 22:32, dbasehore . пишет:
> > Hi Dmitry, sorry for the late reply.
> >
> > On Sun, Mar 8, 2020 at 12:25 PM Dmitry Osipenko wrote:
> >>
> >> 06.03.2020 03:21, Derek Basehore пишет:
> >>> This adds the plumbing for reading panel
Hello,
This small series adds initial support for the DRM bridges to NVIDIA Tegra
DRM driver. This is required by newer device-trees where we model the LVDS
encoder bridge properly.
Please note that the first "Support DRM bridges" patch was previously sent
out as a standalone v1 change.
Changelo
On Tue, Apr 14, 2020 at 04:27:41PM +0200, Arnd Bergmann wrote:
> On Tue, Apr 14, 2020 at 3:29 PM Jason Gunthorpe wrote:
> > On Fri, Apr 10, 2020 at 07:04:27PM +, Saeed Mahameed wrote:
> > > On Fri, 2020-04-10 at 14:13 -0300, Jason Gunthorpe wrote:
> > > > On Fri, Apr 10, 2020 at 02:40:42AM +00
Only sync the sg-list of an Ion dma-buf attachment when the attachment
is actually mapped on the device.
dma-bufs may be synced at any time. It can be reached from user space
via DMA_BUF_IOCTL_SYNC, so there are no guarantees from callers on when
syncs may be attempted, and dma_buf_end_cpu_access(
On Sun, Apr 12, 2020 at 08:20:10PM +0200, Sam Ravnborg wrote:
> Add a new binding file to describe the bindings
> for the Atmel LCDC IP.
> This replaces the old txt based binding.
>
> The binding file describes the current binding,
> including properties to specify register values etc.
> The bindin
Hi Dmitry, sorry for the late reply.
On Sun, Mar 8, 2020 at 12:25 PM Dmitry Osipenko wrote:
>
> 06.03.2020 03:21, Derek Basehore пишет:
> > This adds the plumbing for reading panel rotation from the devicetree
> > and sets up adding a panel property for the panel orientation on
> > Mediatek SoCs
On Tue, Apr 14, 2020 at 09:23:56AM +0100, Chris Wilson wrote:
> Quoting Sultan Alsawaf (2020-04-14 07:13:12)
> > Chris,
> >
> > Could you please take a look at this? This really is quite an important fix.
>
> It's crazy. See a266bf420060 for a patch that should be applied to v5.4
> -Chris
What?
Hi Jani:
On 2020/4/14 19:08, Jani Nikula wrote:
On Mon, 13 Apr 2020, Alex Deucher wrote:
On Mon, Apr 13, 2020 at 5:29 AM Tang Bin wrote:
The struct drm_dp_desc contains struct drm_dp_dpcd_ident, and the struct
drm_dp_dpcd_ident contains the array, so zero-initialization requires a
more coupl
On Tue, 2020-04-14 at 17:25 +0200, Arnd Bergmann wrote:
> On Tue, Apr 14, 2020 at 5:23 PM Jason Gunthorpe wrote:
> > On Tue, Apr 14, 2020 at 04:27:41PM +0200, Arnd Bergmann wrote:
> > > On Tue, Apr 14, 2020 at 3:29 PM Jason Gunthorpe
> > > wrote:
> > > > On Fri, Apr 10, 2020 at 07:04:27PM +,
On Fri, Apr 10, 2020 at 07:04:27PM +, Saeed Mahameed wrote:
> On Fri, 2020-04-10 at 14:13 -0300, Jason Gunthorpe wrote:
> > On Fri, Apr 10, 2020 at 02:40:42AM +, Saeed Mahameed wrote:
> >
> > > This assumes that the module using FOO has its own flag
> > > representing
> > > FOO which is no
We rely on the connector that is created by the bridge, and thus, the
Tegra's output connector is not needed in this case because it will be
an unused connector.
Signed-off-by: Dmitry Osipenko
---
drivers/gpu/drm/tegra/rgb.c | 21 -
1 file changed, 16 insertions(+), 5 deletio
On Tue, 14 Apr 2020, Yussuf Khalil wrote:
> On Tue, 2020-04-14 at 14:34 +0200, Daniel Vetter wrote:
>> On Tue, Apr 14, 2020 at 02:21:06PM +0300, Jani Nikula wrote:
>> > On Tue, 14 Apr 2020, Jani Nikula
>> > wrote:
>> > > On Mon, 13 Apr 2020, Simon Ser wrote:
>> > > > On Monday, April 13, 2020 11
On Tue, 14 Apr 2020, James Hilliard wrote:
> On Tue, Apr 14, 2020 at 5:07 AM Jani Nikula
> wrote:
>>
>> On Fri, 10 Apr 2020, James Hilliard wrote:
>> > If a component fails to bind due to -EPROBE_DEFER we should not log an
>> > error as this is not a real failure.
>> >
>> > Fixes:
>> > vc4-drm
Straightforward conversion.
Signed-off-by: Daniel Vetter
Cc: Hans de Goede
---
drivers/gpu/drm/vboxvideo/vbox_drv.c | 19 +--
1 file changed, 5 insertions(+), 14 deletions(-)
diff --git a/drivers/gpu/drm/vboxvideo/vbox_drv.c
b/drivers/gpu/drm/vboxvideo/vbox_drv.c
index 282348e
Hi all,
Here's the next round of devm_drm_dev_alloc. Big changes:
- lots of acks, reviews and some testing tags. Very much appreciated!
- I dropped the core driver patch, and hence also the patches for vgem,
vkms and i915-selftests. That needs more discussions first.
- I started to convert so
Allows us to drop the cleanup code on the floor.
Sam noticed in his review:
> With this change we avoid calling pci_disable_device()
> twise in case vbox_mm_init() fails.
> Once in vbox_hw_fini() and once in the error path.
v2: Include Sam's review remarks
Acked-by: Sam Ravnborg
Signed-off-by:
Doesn't apply to upstream kernels since a rather long time.
Acked-by: Sam Ravnborg
Signed-off-by: Daniel Vetter
Cc: Hans de Goede
---
drivers/gpu/drm/vboxvideo/vbox_ttm.c | 12
1 file changed, 12 deletions(-)
diff --git a/drivers/gpu/drm/vboxvideo/vbox_ttm.c
b/drivers/gpu/drm/vb
Add a new macro helper to combine the usual init sequence in drivers,
consisting of a kzalloc + devm_drm_dev_init + drmm_add_final_kfree
triplet. This allows us to remove the rather unsightly
drmm_add_final_kfree from all currently merged drivers.
The kerneldoc is only added for this new function.
Aside from deleting all the cleanup code we're now also setting a name
for the pool
Acked-by: Sam Ravnborg
Signed-off-by: Daniel Vetter
Cc: Hans de Goede
---
drivers/gpu/drm/vboxvideo/vbox_main.c | 22 --
1 file changed, 8 insertions(+), 14 deletions(-)
diff --git a/driver
We use the baseclass pattern here, so lets to the proper (and more
typesafe) upcasting.
Acked-by: Sam Ravnborg
Acked-by: Thomas Zimmermann
Signed-off-by: Daniel Vetter
Cc: Hans de Goede
---
drivers/gpu/drm/vboxvideo/vbox_drv.c | 1 -
drivers/gpu/drm/vboxvideo/vbox_drv.h | 1 +
drivers/gpu
Already using devm_drm_dev_init, so very simple replacment.
Acked-by: Sam Ravnborg
Signed-off-by: Daniel Vetter
Cc: Paul Cercueil
---
drivers/gpu/drm/ingenic/ingenic-drm.c | 14 --
1 file changed, 4 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/ingenic/ingenic-drm.c
We already have it in v3d_dev->drm.dev with zero additional pointer
chasing. Personally I don't like duplicated pointers like this
because:
- reviewers need to check whether the pointer is for the same or
different objects if there's multiple
- compilers have an easier time too
But also a bit a
Upcasting using a container_of macro is more typesafe, faster and
easier for the compiler to optimize.
Acked-by: Sam Ravnborg
Signed-off-by: Daniel Vetter
Cc: Hans de Goede
---
drivers/gpu/drm/tiny/gm12u320.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drive
Already using devm_drm_dev_init, so very simple replacment.
Acked-by: Noralf Trønnes
Acked-by: Sam Ravnborg
Signed-off-by: Daniel Vetter
Cc: "Noralf Trønnes"
---
drivers/gpu/drm/tiny/repaper.c | 14 --
1 file changed, 4 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/
We already have it in v3d_dev->drm.dev with zero additional pointer
chasing. Personally I don't like duplicated pointers like this
because:
- reviewers need to check whether the pointer is for the same or
different objects if there's multiple
- compilers have an easier time too
To avoid having to
We're mostly there already, just a handful of places that didn't use
the to_udl container_of cast. To make sure no new appear, don't set
->dev_private.
Reviewed-by: Thomas Zimmermann
Acked-by: Sam Ravnborg
Signed-off-by: Daniel Vetter
Cc: Dave Airlie
Cc: Sean Paul
Cc: Emil Velikov
Cc: Thomas
Already using devm_drm_dev_init, so very simple replacment.
Acked-by: Sam Ravnborg
Signed-off-by: Daniel Vetter
Cc: Hans de Goede
---
drivers/gpu/drm/tiny/gm12u320.c | 13 -
1 file changed, 4 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/tiny/gm12u320.c b/drivers/gpu/
And switch the helper over to container_of, which is a bunch faster
than chasing a pointer. Plus allows gcc to see through this maze.
Acked-by: Eric Anholt
Signed-off-by: Daniel Vetter
Cc: Eric Anholt
---
drivers/gpu/drm/v3d/v3d_drv.c | 1 -
drivers/gpu/drm/v3d/v3d_drv.h | 2 +-
2 files change
Also init the fbdev emulation before we register the device, that way
we can rely on the auto-cleanup and simplify the probe error code even
more.
v2: Rebase on top of Thomas' patches to remove the return value from
drm_fbdev_generic_setup()
Signed-off-by: Daniel Vetter
Cc: Noralf Trønnes
Cc: D
Already using devm_drm_dev_init, so very simple replacment.
Aside: There was an oddity in the old code, we allocated priv but in
the error path we've freed priv->dbidev ...
Acked-by: David Lechner
Acked-by: Sam Ravnborg
Signed-off-by: Daniel Vetter
Cc: David Lechner
---
drivers/gpu/drm/tiny/
Already using devm_drm_dev_init, so very simple replacment.
Tested-by: Jyri Sarha
Acked-by: Sam Ravnborg
Signed-off-by: Daniel Vetter
Cc: Jyri Sarha
Cc: Tomi Valkeinen
---
drivers/gpu/drm/tidss/tidss_drv.c | 15 ---
1 file changed, 4 insertions(+), 11 deletions(-)
diff --git a/d
Already using devm_drm_dev_init, so very simple replacment.
Acked-by: Noralf Trønnes
Acked-by: Sam Ravnborg
Signed-off-by: Daniel Vetter
Cc: Kamlesh Gurudasani
---
drivers/gpu/drm/tiny/ili9486.c | 13 -
1 file changed, 4 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/
Already using devm_drm_dev_init, so very simple replacment.
Acked-by: David Lechner
Acked-by: Sam Ravnborg
Signed-off-by: Daniel Vetter
Cc: "Noralf Trønnes"
Cc: Sam Ravnborg
Cc: Daniel Vetter
Cc: Eric Anholt
Cc: David Lechner
---
drivers/gpu/drm/tiny/ili9341.c | 13 -
1 file c
Already using devm_drm_dev_init, so very simple replacment.
Acked-by: Eric Anholt
Acked-by: Sam Ravnborg
Signed-off-by: Daniel Vetter
Cc: Eric Anholt
---
drivers/gpu/drm/tiny/hx8357d.c | 13 -
1 file changed, 4 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/tiny/hx835
Also allows us to simplify the unroll code since the drm_dev_put
disappears.
Acked-by: Eric Anholt
Signed-off-by: Daniel Vetter
Cc: Eric Anholt
---
drivers/gpu/drm/v3d/v3d_drv.c | 31 ++-
1 file changed, 10 insertions(+), 21 deletions(-)
diff --git a/drivers/gpu/dr
Already using devm_drm_dev_init, so very simple replacment.
Acked-by: Noralf Trønnes
Acked-by: Sam Ravnborg
Signed-off-by: Daniel Vetter
Cc: "Noralf Trønnes"
---
drivers/gpu/drm/tiny/mi0283qt.c | 13 -
1 file changed, 4 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/t
Already using devm_drm_dev_init, so very simple replacment.
Acked-by: David Lechner
Acked-by: Sam Ravnborg
Signed-off-by: Daniel Vetter
Cc: David Lechner
---
drivers/gpu/drm/tiny/st7586.c | 13 -
1 file changed, 4 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/tiny/st
Already using devm_drm_dev_init, so very simple replacment.
Acked-by: David Lechner
Acked-by: Sam Ravnborg
Signed-off-by: Daniel Vetter
Cc: David Lechner
---
drivers/gpu/drm/tiny/ili9225.c | 13 -
1 file changed, 4 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/tiny/i
Not used anymore since the switch to suspend/resume helpers.
Tested-by: Jyri Sarha
Acked-by: Sam Ravnborg
Signed-off-by: Daniel Vetter
Cc: Jyri Sarha
Cc: Tomi Valkeinen
---
drivers/gpu/drm/tidss/tidss_drv.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/tidss/tidss_drv.
Komeda uses the component framework, which does open/close a new
devres group around all the bind callbacks. Which means we can use
devm_ functions for managing the drm_device cleanup, with leaking
stuff in case of deferred probes or other reasons to unbind
components, or the component_master.
Als
First it's redundant, fb and crtc are only ever both set or not set.
2nd, the atomic_check code in simple display pipe helpers guarantees
that this never happens. So nice bugfix for arcpgu driver here, since
it was lacking a call to drm_atomic_helper_check_plane_state().
Signed-off-by: Daniel Vett
Upcasting using a container_of macro is more typesafe, faster and
easier for the compiler to optimize.
Tested-by: Jyri Sarha
Acked-by: Sam Ravnborg
Signed-off-by: Daniel Vetter
Cc: Jyri Sarha
Cc: Tomi Valkeinen
---
drivers/gpu/drm/tidss/tidss_crtc.c | 16
drivers/gpu/drm/ti
Also remove the now no longer needed build bug on since that's already
not needed anymore with drmm_add_final_kfree. Conversion to managed
drm_device cleanup is easy, the final drm_dev_put() is already the
last thing in both the bind unbind as in the unbind flow.
Also, this relies on component.c c
Upcasting using a container_of macro is more typesafe, faster and
easier for the compiler to optimize.
Acked-by: Eric Anholt
Acked-by: Sam Ravnborg
Signed-off-by: Daniel Vetter
Cc: Dave Airlie
Cc: Gerd Hoffmann
Cc: Daniel Vetter
Cc: "Noralf Trønnes"
Cc: Sam Ravnborg
Cc: Eric Anholt
Cc: Th
Already using devm_drm_dev_init, so very simple replacment.
Acked-by: Noralf Trønnes
Acked-by: Sam Ravnborg
Signed-off-by: Daniel Vetter
Cc: Dave Airlie
Cc: Gerd Hoffmann
Cc: Daniel Vetter
Cc: Sam Ravnborg
Cc: "Noralf Trønnes"
Cc: Rob Herring
Cc: Thomas Zimmermann
Cc: virtualizat...@list
Upcasting using a container_of macro is more typesafe, faster and
easier for the compiler to optimize.
Signed-off-by: Daniel Vetter
Cc: Russell King
---
drivers/gpu/drm/armada/armada_crtc.c| 4 ++--
drivers/gpu/drm/armada/armada_debugfs.c | 2 +-
drivers/gpu/drm/armada/armada_drm.h | 2
Simple pipe helpers only have an enable and disable hook, no more
mode_set_nofb. Call it from our enable hook to align with that
conversions.
Atomic helpers always call mode_set_nofb and enable together, so
there's no functional change here.
Signed-off-by: Daniel Vetter
Cc: Alexey Brodkin
---
With autocleanup through drm_device management we can delete all the
code. Possible now that there's no confusion against devm_kzalloc'ed
structures anymore.
I inlined arcpgu_setup_mode_config because it's tiny and the newly
needed return value handling would have been more ...
Signed-off-by: Dan
Also need to remove the drm_dev_put from the remove hook.
Acked-by: Gerd Hoffmann
Signed-off-by: Daniel Vetter
Cc: Dave Airlie
Cc: Gerd Hoffmann
Cc: virtualizat...@lists.linux-foundation.org
Cc: spice-de...@lists.freedesktop.org
---
drivers/gpu/drm/qxl/qxl_drv.c | 15 ---
drivers/
Upcasting using a container_of macro is more typesafe, faster and
easier for the compiler to optimize.
Acked-by: Gerd Hoffmann
Signed-off-by: Daniel Vetter
Cc: Dave Airlie
Cc: Gerd Hoffmann
Cc: virtualizat...@lists.linux-foundation.org
Cc: spice-de...@lists.freedesktop.org
---
drivers/gpu/drm
Already using devm_drm_dev_init, so very simple replacment.
v2: Move misplaced double-assignement to next patch (Sam)
Acked-by: Sam Ravnborg
Signed-off-by: Daniel Vetter
Cc: Linus Walleij
---
drivers/gpu/drm/mcde/mcde_drv.c | 15 ---
1 file changed, 4 insertions(+), 11 deletions(-
This is a prep step to convert arc over to the simple kms helpers, for
now we just use this as an embedding container to drop all the various
allocations. Big change is the removal of the various devm_kzalloc,
which have the wrong lifetimes anyway.
Signed-off-by: Daniel Vetter
Cc: Alexey Brodkin
Luckily we're already well set up in the main driver, with
drm_dev_put() being the last thing in both the unload error case and
the pci remove function.
Signed-off-by: Daniel Vetter
---
drivers/gpu/drm/i915/i915_drv.c | 17 -
drivers/gpu/drm/i915/i915_pci.c | 2 --
2 files chang
Really straighforward, only slight issue is that the sim connector is
created after the pipe is set up, so can't use the helpers perfectly
yet. Subsequent patches will fix that.
Aside from lots of deleting code no functional changes in here.
Signed-off-by: Daniel Vetter
Cc: Alexey Brodkin
---
Because it is.
Signed-off-by: Daniel Vetter
Cc: Alexey Brodkin
---
MAINTAINERS | 2 +-
drivers/gpu/drm/Kconfig | 2 --
drivers/gpu/drm/Makefile| 1 -
drivers/gpu/drm/arc/Kconfig
Upcasting using a container_of macro is more typesafe, faster and
easier for the compiler to optimize.
Signed-off-by: Daniel Vetter
Cc: Alexey Brodkin
---
drivers/gpu/drm/arc/arcpgu.h | 2 ++
drivers/gpu/drm/arc/arcpgu_crtc.c | 4 ++--
drivers/gpu/drm/arc/arcpgu_drv.c | 4 +---
3 files ch
Because it is. Huge congrats to everyone who made this kind of
refactoring happen!
Signed-off-by: Daniel Vetter
Cc: Dave Airlie
Cc: Gerd Hoffmann
Cc: virtualizat...@lists.linux-foundation.org
---
MAINTAINERS | 2 +-
drivers/gpu/drm/Kconfig | 2
Leftover from the conversion to the generic fbdev emulation.
Signed-off-by: Daniel Vetter
Cc: Alexey Brodkin
---
drivers/gpu/drm/arc/arcpgu.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/arc/arcpgu.h b/drivers/gpu/drm/arc/arcpgu.h
index 87821c91a00c..ed77dd5dd5cb 100644
--
Removes the last devm_kzalloc, which means we're now prepared to use
drmm_mode_config_cleanup!
Signed-off-by: Daniel Vetter
Cc: Alexey Brodkin
---
drivers/gpu/drm/arc/arcpgu.h | 1 +
drivers/gpu/drm/arc/arcpgu_sim.c | 14 +-
2 files changed, 2 insertions(+), 13 deletions(-)
di
At less than 500 lines total feels like the right thing to do.
Also noticed that the simple wrapper around drm_connector_cleanup can
be dropped.
Signed-off-by: Daniel Vetter
---
drivers/gpu/drm/arc/Makefile | 2 +-
drivers/gpu/drm/arc/arcpgu.h | 39
drivers/gpu/drm/arc
That way we can get rid of this final piece of init code, and use the
simple pipe helpers as intended.
Signed-off-by: Daniel Vetter
Cc: Alexey Brodkin
---
drivers/gpu/drm/arc/arcpgu_drv.c | 51 ++--
1 file changed, 16 insertions(+), 35 deletions(-)
diff --git a/driv
Upcasting using a container_of macro is more typesafe, faster and
easier for the compiler to optimize.
v2: Move misplaced removal of double-assignment to this patch (Sam)
Reviewed-by: Linus Walleij (v1)
Acked-by: Sam Ravnborg
Signed-off-by: Daniel Vetter
Cc: Linus Walleij
---
drivers/gpu/drm
Really not big anymore.
Signed-off-by: Daniel Vetter
---
drivers/gpu/drm/arc/Makefile | 2 +-
drivers/gpu/drm/arc/arcpgu.h | 1 -
drivers/gpu/drm/arc/arcpgu_crtc.c | 166 --
drivers/gpu/drm/arc/arcpgu_drv.c | 147 +-
drivers/gpu/
Entirely not used, just copypasta.
Acked-by: Sam Ravnborg
Signed-off-by: Daniel Vetter
Cc: Paul Cercueil
---
drivers/gpu/drm/ingenic/ingenic-drm.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/ingenic/ingenic-drm.c
b/drivers/gpu/drm/ingenic/ingenic-drm.c
index 2dd1f3020fc
- Need to embedded the drm_device, but for now we keep the usual
pointer chasing.
- No more devm_kzalloc, which fixes a lifetime issues on driver
remove.
- No more drm_dev_put, that's done by devm_ now.
Signed-off-by: Daniel Vetter
Cc: Alexey Brodkin
---
drivers/gpu/drm/arc/arcpgu.h |
Really not worth the function, much less the separate file now that
almost all the code is gone.
Signed-off-by: Daniel Vetter
---
drivers/gpu/drm/arc/Makefile | 2 +-
drivers/gpu/drm/arc/arcpgu.h | 1 -
drivers/gpu/drm/arc/arcpgu_drv.c | 12 +---
drivers/gpu/drm/arc/arcpgu_h
Allows us to remove a bit of cleanup code.
Signed-off-by: Daniel Vetter
Cc: Dave Airlie
Cc: Thomas Zimmermann
Cc: Gerd Hoffmann
Cc: Daniel Vetter
Cc: Emil Velikov
Cc: "Noralf Trønnes"
Cc: Sam Ravnborg
Cc: "Christian König"
Cc: "Y.C. Chen"
---
drivers/gpu/drm/ast/ast_drv.c | 10 +++-
No longer used since the conversion to generic fbdev.
Signed-off-by: Daniel Vetter
Cc: Joel Stanley
Cc: Andrew Jeffery
Cc: linux-asp...@lists.ozlabs.org
Cc: linux-arm-ker...@lists.infradead.org
---
drivers/gpu/drm/aspeed/aspeed_gfx.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/g
On Tue, 14 Apr 2020, Alex Deucher wrote:
> On Tue, Apr 14, 2020 at 9:05 AM Bernard Zhao wrote:
>>
>> On some processors, the / operate will call the compiler`s div lib,
>> which is low efficient, We can replace the / operation with shift,
>> so that we can replace the call of the division library
drm_connector_register does nothing before drm_dev_register(), it
is meant for hotpluggable connectors only. Same for the unregister side.
Signed-off-by: Daniel Vetter
---
drivers/gpu/drm/arc/arcpgu_sim.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/arc/arcpgu_sim.c b/dri
Since aspeed doesn't use devm_kzalloc anymore we can use the managed
mode config cleanup.
Signed-off-by: Daniel Vetter
Cc: Joel Stanley
Cc: Andrew Jeffery
Cc: linux-asp...@lists.ozlabs.org
Cc: linux-arm-ker...@lists.infradead.org
---
drivers/gpu/drm/aspeed/aspeed_gfx_drv.c | 11 ++-
1
As usual, we can drop the drm_dev_put() and need to embed the
drm_device. Since it's so few, also go right ahead and leave
drm_device->dev_private set to NULL, so that we always use the
container_of() upcast, which is faster anyway.
Signed-off-by: Daniel Vetter
Cc: Joel Stanley
Cc: Andrew Jeffer
This is leftovers from the old drm_driver->load callback
upside-down issues. It doesn't do anything for not-hotplugged
connectors since drm_dev_register takes care of that.
Signed-off-by: Daniel Vetter
Cc: Gerd Hoffmann
Cc: virtualizat...@lists.linux-foundation.org
---
drivers/gpu/drm/bochs/boc
This is only needed for hotpluggable connectors set up after
drm_dev_register().
Signed-off-by: Daniel Vetter
Cc: Dave Airlie
Cc: Thomas Zimmermann
Cc: Gerd Hoffmann
Cc: Daniel Vetter
Cc: Sam Ravnborg
Cc: Emil Velikov
---
drivers/gpu/drm/ast/ast_mode.c | 3 ---
1 file changed, 3 deletions(
On Wed, 15 Apr 2020, Daniel Vetter wrote:
> On Wed, Apr 15, 2020 at 8:40 AM Jani Nikula
> wrote:
>>
>> On Wed, 08 Apr 2020, Maarten Lankhorst
>> wrote:
>> > Hey,
>> >
>> > Here's a pull request to pull in the DP PHY Compliance series.
>> > It's based on top of drm/drm-next, and contains all pa
On 11/04/2020 18:57, Martin Blumenstingl wrote:
> The GPU can be one of the big heat sources on a SoC. Allow the
> "#cooling-cells" property to be specified for ARM Mali Utgard GPUs so
> the GPU clock speeds (and voltages) can be reduced to prevent a SoC from
> overheating.
>
> Reviewed-by: Qiang
Hi Daniel
Am 15.04.20 um 09:40 schrieb Daniel Vetter:
> Allows us to remove a bit of cleanup code.
>
> Signed-off-by: Daniel Vetter
> Cc: Dave Airlie
> Cc: Thomas Zimmermann
> Cc: Gerd Hoffmann
> Cc: Daniel Vetter
> Cc: Emil Velikov
> Cc: "Noralf Trønnes"
> Cc: Sam Ravnborg
> Cc: "Christi
Am 15.04.20 um 09:40 schrieb Daniel Vetter:
> This is only needed for hotpluggable connectors set up after
> drm_dev_register().
>
> Signed-off-by: Daniel Vetter
> Cc: Dave Airlie
> Cc: Thomas Zimmermann
> Cc: Gerd Hoffmann
> Cc: Daniel Vetter
> Cc: Sam Ravnborg
> Cc: Emil Velikov
Review
Am 15.04.20 um 09:39 schrieb Daniel Vetter:
> Also init the fbdev emulation before we register the device, that way
> we can rely on the auto-cleanup and simplify the probe error code even
> more.
>
> v2: Rebase on top of Thomas' patches to remove the return value from
> drm_fbdev_generic_setup(
Hi,
On 05/04/2020 13:23, Markus Elfring wrote:
> From: Markus Elfring
> Date: Sun, 5 Apr 2020 13:13:03 +0200
>
> The function “platform_get_irq” can log an error already.
> Thus omit a redundant message for the exception handling in the
> calling function.
>
> This issue was detected by using t
Am 15.04.20 um 09:41 schrieb Jani Nikula:
On Tue, 14 Apr 2020, Alex Deucher wrote:
On Tue, Apr 14, 2020 at 9:05 AM Bernard Zhao wrote:
On some processors, the / operate will call the compiler`s div lib,
which is low efficient, We can replace the / operation with shift,
so that we can replace
Am 15.04.20 um 09:40 schrieb Daniel Vetter:
> Because it is. Huge congrats to everyone who made this kind of
> refactoring happen!
Every other week, I felt an urge to send out this patch. Thank you so
much, Daniel! There are more candidates for tiny/. They are all <20k
LOCs and all we'd have to
Hi
Am 15.04.20 um 09:40 schrieb Daniel Vetter:
> Because it is.
Yes.
OTOH, as much as I appreciate the simplification, I think it should be
in a separate series.
>
> Signed-off-by: Daniel Vetter
> Cc: Alexey Brodkin
Reviewed-by: Thomas Zimmermann
> ---
> MAINTAINERS
On Wed, Apr 15, 2020 at 9:52 AM Thomas Zimmermann wrote:
>
> Hi Daniel
>
> Am 15.04.20 um 09:40 schrieb Daniel Vetter:
> > Allows us to remove a bit of cleanup code.
> >
> > Signed-off-by: Daniel Vetter
> > Cc: Dave Airlie
> > Cc: Thomas Zimmermann
> > Cc: Gerd Hoffmann
> > Cc: Daniel Vetter
On Wed, Apr 15, 2020 at 10:09 AM Daniel Vetter wrote:
>
> On Wed, Apr 15, 2020 at 9:52 AM Thomas Zimmermann wrote:
> >
> > Hi Daniel
> >
> > Am 15.04.20 um 09:40 schrieb Daniel Vetter:
> > > Allows us to remove a bit of cleanup code.
> > >
> > > Signed-off-by: Daniel Vetter
> > > Cc: Dave Airlie
1 - 100 of 261 matches
Mail list logo
