Re: [PATCH] drm/legacy: Fix type for drm_local_map.offset

2020-04-09 Thread Daniel Vetter
On Fri, Apr 03, 2020 at 07:16:28PM +0200, Daniel Vetter wrote: > On Fri, Apr 3, 2020 at 7:14 PM Linus Torvalds > wrote: > > > > On Fri, Apr 3, 2020 at 1:29 AM Daniel Vetter wrote: > > > > > > > Tested-by: Nathan Chancellor # build > > > > > > This works too, missed it when replying to Linus > >

Re: [PATCH] drm: work around dma_addr_t/resource_size_t mixup warning

2020-04-09 Thread Daniel Vetter
The fix got stuck a bit, I just pushed it out, should make it to the next linux-next: commit b2ecb89c27a4fd110187e0afeca70557215f55a1 (drm-misc-next-fixes) Author: Chris Wilson Date: Thu Apr 2 22:59:26 2020 +0100 drm/legacy: Fix type for drm_local_map.offset Cheers, Daniel On Wed, Apr 8,

Re: [RFC v3 4/8] dt-bindings: display: add ingenic-jz4780-hdmi DT Schema

2020-04-09 Thread Sam Ravnborg
Hi Nikolaus. On Sun, Mar 29, 2020 at 07:35:50PM +0200, H. Nikolaus Schaller wrote: > From: Sam Ravnborg > > Add DT bindings for the hdmi driver for the Ingenic JZ4780 SoC. > Based on .txt binding from Zubair Lutfullah Kakakhel > > Signed-off-by: Sam Ravnborg > Signed-off-by: H. Nikolaus Schall

Re: [PATCH] drm: kirin: Revert change to add register connect helper functions

2020-04-09 Thread Daniel Vetter
On Thu, Apr 09, 2020 at 12:43:06AM +, John Stultz wrote: > Daniel noted[1] that commit d606dc9a6323 ("drm: kirin: Add > register connect helper functions in drm init") was unnecessary > and incorrect, as drm_dev_register does register connectors for > us. > > Thus, this patch reverts the chang

Re: [RFC v3 1/8] dt-bindings: display: convert ingenic, lcd.txt to ingenic, lcd.yaml

2020-04-09 Thread Sam Ravnborg
Hi Nikolaus Some comments below that will result in a simplee binding that passes the checks. Thanks for pushing this. Sam On Sun, Mar 29, 2020 at 07:35:47PM +0200, H. Nikolaus Schaller wrote: > and add compatible: jz4780-lcd, including an example how to > configure both lcd controllers

Re: [RFC 0/6] Regressions for "imply" behavior change

2020-04-09 Thread Nicolas Pitre
On Wed, 8 Apr 2020, Arnd Bergmann wrote: > Hi everyone, > > I've just restarted doing randconfig builds on top of mainline Linux and > found a couple of regressions with missing dependency from the recent > change in the "imply" keyword in Kconfig, presumably these two patches: > > 3a9dd3ecb207

[PATCH v2 1/3] drm/amd/amdgpu: add prefix for pr_* prints

2020-04-09 Thread Aurabindo Pillai
amdgpu uses lots of pr_* calls for printing error messages. With this prefix, errors shall be more obvious to the end use regarding its origin, and may help debugging. Prefix format: [xxx.x] amdgpu: ... Signed-off-by: Aurabindo Pillai --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 6 ++ 1 f

Re: [PATCH 02/28] staging: android: ion: use vmap instead of vm_map_ram

2020-04-09 Thread Hillf Danton
On Wed, 8 Apr 2020 13:59:00 +0200 > > vm_map_ram can keep mappings around after the vm_unmap_ram. Using that > with non-PAGE_KERNEL mappings can lead to all kinds of aliasing issues. > > Signed-off-by: Christoph Hellwig > --- > drivers/staging/android/ion/ion_heap.c | 4 ++-- > 1 file chang

RE: [PATCH v2 3/4] drm: ipk: Add extensions for DW MIPI DSI Host driver

2020-04-09 Thread Angelo Ribeiro
Hi Sam, Thanks for your revision Angelo From: Sam Ravnborg Date: Tue, Apr 07, 2020 at 18:51:59 > Hi Angelo. > > One nit below. > > Sam > > On Mon, Apr 06, 2020 at 03:24:13PM +0200, Angelo Ribeiro wrote: > > Add Synopsys DesignWare IPK specific extensions for Synopsys DesignWare > > M

[PATCH v1] drm/tegra: output: Support DRM bridges

2020-04-09 Thread Dmitry Osipenko
Newer Tegra device-trees will define a video output graph which involves a bridge. This patch adds support for the DRM bridges to the Tegra's DRM output. Signed-off-by: Dmitry Osipenko --- drivers/gpu/drm/tegra/drm.h| 2 ++ drivers/gpu/drm/tegra/output.c | 25 - 2 fi

Re: [PATCH v2 1/3] gpu/drm: ingenic: Add trick to support 16bpp on 24-bit panels

2020-04-09 Thread Paul Cercueil
Hi, Any feedback for this patchset? Thanks, -Paul Le mer. 26 févr. 2020 à 1:30, Paul Cercueil a écrit : If the panel interface is 24-bit but our primary plane is 16bpp, configure as if the panel was 18-bit. This tricks permits the display of 16bpp data on a 24-bit panel by wiring each color

Re: [PATCH 0/2] powerpc: Remove support for ppc405/440 Xilinx platforms

2020-04-09 Thread Michael Ellerman
Benjamin Herrenschmidt writes: > On Fri, 2020-04-03 at 15:59 +1100, Michael Ellerman wrote: >> Benjamin Herrenschmidt writes: >> > On Tue, 2020-03-31 at 16:30 +1100, Michael Ellerman wrote: >> > > I have no attachment to 40x, and I'd certainly be happy to have >> > > less >> > > code in the tree,

Re: [PATCH 10/28] mm: only allow page table mappings for built-in zsmalloc

2020-04-09 Thread Randy Dunlap
Hi, On 4/8/20 4:59 AM, Christoph Hellwig wrote: > diff --git a/mm/Kconfig b/mm/Kconfig > index 36949a9425b8..614cc786b519 100644 > --- a/mm/Kconfig > +++ b/mm/Kconfig > @@ -702,7 +702,7 @@ config ZSMALLOC > > config ZSMALLOC_PGTABLE_MAPPING > bool "Use page table mapping to access object

[PATCH 2/7] drm/bridge_connector: Set default status connected for eDP connectors

2020-04-09 Thread Enric Balletbo i Serra
In an eDP application, HPD is not required and on most bridge chips useless. If HPD is not used, we need to set initial status as connected, otherwise the connector created by the drm_bridge_connector API remains in an unknown state. Signed-off-by: Enric Balletbo i Serra --- drivers/gpu/drm/drm

Re: [PATCH 05/35] docs: filesystems: fix renamed references

2020-04-09 Thread David Sterba
On Wed, Apr 08, 2020 at 05:45:57PM +0200, Mauro Carvalho Chehab wrote: > Some filesystem references got broken by a previous patch > series I submitted. Address those. > > Signed-off-by: Mauro Carvalho Chehab For > fs/affs/Kconfig | 2 +- Acked-by: D

[PATCH] drm/amd/amdgpu: add prefix for pr_* prints

2020-04-09 Thread Aurabindo Pillai
amdgpu uses lots of pr_* calls for printing error messages. With this prefix, errors shall be more obvious to the end use regarding its origin, and may help debugging. Prefix format: [xxx.x] amdgpu: ... Signed-off-by: Aurabindo Pillai --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 6 ++ 1 f

[PATCH v12 09/11] backlight: pwm_bl: Use 64-bit division function

2020-04-09 Thread Guru Das Srinagesh
Since the PWM framework is switching struct pwm_state.period's datatype to u64, prepare for this transition by using div_u64 to handle a 64-bit dividend instead of a straight division operation. Cc: Lee Jones Cc: Daniel Thompson Cc: Jingoo Han Cc: Bartlomiej Zolnierkiewicz Cc: linux-...@vger.k

[PATCH 6/7] drm/mediatek: mtk_dsi: Use the drm_panel_bridge API

2020-04-09 Thread Enric Balletbo i Serra
Replace the manual panel handling code by a drm_panel_bridge. This simplifies the driver and allows all components in the display pipeline to be treated as bridges, paving the way to generic connector handling. Signed-off-by: Enric Balletbo i Serra --- drivers/gpu/drm/mediatek/mtk_dsi.c | 178 +

[PATCH 0/7] Convert mtk-dsi to drm_bridge API and get EDID for ps8640 bridge

2020-04-09 Thread Enric Balletbo i Serra
The PS8640 dsi-to-eDP bridge driver is using the panel bridge API, however, not all the components in the chain have been ported to the drm_bridge API. Actually, when a panel is attached the default panel's mode is used, but in some cases we can't get display up if mode getting from eDP control EDI

Re: [PATCH 26/28] arm64: use __vmalloc_node in arch_alloc_vmap_stack

2020-04-09 Thread Mark Rutland
On Wed, Apr 08, 2020 at 01:59:24PM +0200, Christoph Hellwig wrote: > arch_alloc_vmap_stack can use a slightly higher level vmalloc function. > > Signed-off-by: Christoph Hellwig Acked-by: Mark Rutland Mark. > --- > arch/arm64/include/asm/vmap_stack.h | 6 ++ > 1 file changed, 2 insertion

Re: [PATCH 18/28] mm: enforce that vmap can't map pages executable

2020-04-09 Thread Mark Rutland
On Wed, Apr 08, 2020 at 01:59:16PM +0200, Christoph Hellwig wrote: > To help enforcing the W^X protection don't allow remapping existing > pages as executable. > > Based on patch from Peter Zijlstra . > > Signed-off-by: Christoph Hellwig > --- > arch/x86/include/asm/pgtable_types.h | 6 ++ >

[PATCH 3/7] drm/mediatek: mtk_dsi: Rename bridge to next_bridge

2020-04-09 Thread Enric Balletbo i Serra
This is really a cosmetic change just to make a bit more readable the code after convert the driver to drm_bridge. The bridge variable name will be used by the encoder drm_bridge, and the chained bridge will be named next_bridge. Signed-off-by: Enric Balletbo i Serra --- drivers/gpu/drm/mediate

[PATCH 4/7] drm/mediatek: mtk_dsi: Convert to bridge driver

2020-04-09 Thread Enric Balletbo i Serra
Convert mtk_dsi to a bridge driver with built-in encoder support for compatibility with existing component drivers. Signed-off-by: Enric Balletbo i Serra --- drivers/gpu/drm/mediatek/mtk_dsi.c | 106 ++--- 1 file changed, 68 insertions(+), 38 deletions(-) diff --git a/d

[PATCH v2 0/3] drm/amd/amdgpu: Add print format prefix

2020-04-09 Thread Aurabindo Pillai
Changes in v2 * Add dev_fmt format prefix * Removed hardcoded module names in pr_* and dev_* prints Aurabindo Pillai (3): drm/amd/amdgpu: add prefix for pr_* prints drm/amd/amdgpu: add print prefix for dev_* variants drm/amd/amdgpu: remove hardcoded module name in prints drivers/gpu/drm/a

[PATCH 2/2] drm/panel: NT39016: Add support for 50 Hz refresh rate

2020-04-09 Thread Paul Cercueil
By changing the pixel clock and the length of the back porch, it is possible to obtain a perfect 50 Hz refresh rate. Signed-off-by: Paul Cercueil --- drivers/gpu/drm/panel/panel-novatek-nt39016.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/

Re: [PATCH 10/28] mm: only allow page table mappings for built-in zsmalloc

2020-04-09 Thread Matthew Wilcox
On Wed, Apr 08, 2020 at 05:12:03PM +0200, Peter Zijlstra wrote: > On Wed, Apr 08, 2020 at 08:01:00AM -0700, Randy Dunlap wrote: > > Hi, > > > > On 4/8/20 4:59 AM, Christoph Hellwig wrote: > > > diff --git a/mm/Kconfig b/mm/Kconfig > > > index 36949a9425b8..614cc786b519 100644 > > > --- a/mm/Kconfi

Re: [PATCH] drm/amd/amdgpu: add prefix for pr_* prints

2020-04-09 Thread Aurabindo Pillai
Hi Joe, On Wed, Apr 8, 2020 at 11:37 AM Joe Perches wrote: > > All the embedded uses of "amdgpu:" in logging > messages should also be deleted. > > $ git grep -P '(?:dev_|pr_).*"amdgpu:' drivers/gpu/drm/amd/amdgpu/ > drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c: > pr_err("amdgp

[PATCH 1/2] drm/panel: NT39016: Add support for multiple modes

2020-04-09 Thread Paul Cercueil
Add support for multiple drm_display_mode entries. This will allow to add a 50 Hz mode later. Signed-off-by: Paul Cercueil --- drivers/gpu/drm/panel/panel-novatek-nt39016.c | 33 +-- 1 file changed, 23 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-novat

Re: [RFC 0/6] Regressions for "imply" behavior change

2020-04-09 Thread Nicolas Pitre
On Wed, 8 Apr 2020, Arnd Bergmann wrote: > On Wed, Apr 8, 2020 at 10:38 PM Nicolas Pitre wrote: > > On Wed, 8 Apr 2020, Arnd Bergmann wrote: > > > I have created workarounds for the Kconfig files, which now stop using > > > imply and do something else in each case. I don't know whether there was

[PATCH v2 2/3] drm/amd/amdgpu: add print prefix for dev_* variants

2020-04-09 Thread Aurabindo Pillai
Define dev_fmt macro for informative print messages Signed-off-by: Aurabindo Pillai --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h b/drivers/gpu/drm/amd/amdgpu/amdgpu.h index 67d654a89..7a52d37e6 100644 --- a

[PATCH v2 3/3] drm/amd/amdgpu: remove hardcoded module name in prints

2020-04-09 Thread Aurabindo Pillai
Let format prefixes take care of printing the module name through pr_fmt and dev_fmt definitions. Signed-off-by: Aurabindo Pillai --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 6 +++--- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c

Re: [PATCH 09/28] mm: rename CONFIG_PGTABLE_MAPPING to CONFIG_ZSMALLOC_PGTABLE_MAPPING

2020-04-09 Thread Randy Dunlap
On 4/8/20 4:59 AM, Christoph Hellwig wrote: > Rename the Kconfig variable to clarify the scope. > > Signed-off-by: Christoph Hellwig > --- > arch/arm/configs/omap2plus_defconfig | 2 +- > include/linux/zsmalloc.h | 2 +- > mm/Kconfig | 2 +- > mm/zsmalloc.c

Re: [PATCH 03/35] docs: fix broken references to text files

2020-04-09 Thread Alex Shi
在 2020/4/8 下午11:45, Mauro Carvalho Chehab 写道: > .../translations/zh_CN/filesystems/sysfs.txt | 2 +- > .../translations/zh_CN/process/submit-checklist.rst | 2 +- It looks fine for me. ___ dri-devel mailing list dri-devel@lists.freedesktop.o

RE: [PATCH v2 2/4] drm: ipk: Add DRM driver for DesignWare IPK DSI

2020-04-09 Thread Angelo Ribeiro
Hi Daniel, From: Daniel Vetter Date: Tue, Apr 07, 2020 at 09:13:33 > On Mon, Apr 06, 2020 at 03:24:12PM +0200, Angelo Ribeiro wrote: > > Add support for Synopsys DesignWare VPG (Video Pattern Generator) and > > DRM driver for Synopsys DesignWare DSI Host IPK solution. > > > > Cc: Maarten Lankho

[PATCH 7/7] drm/mediatek: mtk_dsi: Create connector for bridges

2020-04-09 Thread Enric Balletbo i Serra
Use the drm_bridge_connector helper to create a connector for pipelines that use drm_bridge. This allows splitting connector operations across multiple bridges when necessary, instead of having the last bridge in the chain creating the connector and handling all connector operations internally. Si

[PATCH 5/7] drm/mediatek: mtk_dsi: Use simple encoder

2020-04-09 Thread Enric Balletbo i Serra
The mtk_dsi driver uses an empty implementation for its encoder. Replace the code with the generic simple encoder. Signed-off-by: Enric Balletbo i Serra --- drivers/gpu/drm/mediatek/mtk_dsi.c | 14 +++--- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/med

[PATCH v12 01/11] drm/i915: Use 64-bit division macro

2020-04-09 Thread Guru Das Srinagesh
Since the PWM framework is switching struct pwm_state.duty_cycle's datatype to u64, prepare for this transition by using DIV_ROUND_UP_ULL to handle a 64-bit dividend. Cc: Jani Nikula Cc: Joonas Lahtinen Cc: David Airlie Cc: Daniel Vetter Cc: Chris Wilson Cc: "Ville Syrjälä" Cc: intel-...@lis

drm/mcde: Checking for a failed platform_get_irq() call in mcde_probe()

2020-04-09 Thread Markus Elfring
Hello, I have taken another look at the implementation of the function “mcde_probe”. A software analysis approach points the following source code out for further development considerations. https://elixir.bootlin.com/linux/v5.6.2/source/drivers/gpu/drm/mcde/mcde_drv.c#L401 https://git.kernel.org/

Re: [PATCH 10/28] mm: only allow page table mappings for built-in zsmalloc

2020-04-09 Thread Randy Dunlap
On 4/8/20 8:15 AM, Matthew Wilcox wrote: > On Wed, Apr 08, 2020 at 05:12:03PM +0200, Peter Zijlstra wrote: >> On Wed, Apr 08, 2020 at 08:01:00AM -0700, Randy Dunlap wrote: >>> Hi, >>> >>> On 4/8/20 4:59 AM, Christoph Hellwig wrote: diff --git a/mm/Kconfig b/mm/Kconfig index 36949a9425b8..

Re: [PATCH/RFC 4/6] dt-bindings: display: rockchip: dw-hdmi: Convert binding to YAML

2020-04-09 Thread Maxime Ripard
On Wed, Apr 08, 2020 at 02:45:52PM +0300, Laurent Pinchart wrote: > Hi Maxime, > > On Tue, Apr 07, 2020 at 09:12:51AM +0200, Maxime Ripard wrote: > > On Mon, Apr 06, 2020 at 08:50:28PM +0300, Laurent Pinchart wrote: > > > On Mon, Apr 06, 2020 at 07:09:15PM +0200, Maxime Ripard wrote: > > > > On Mon

Re: [PATCH 1/2] drm/panel: NT39016: Add support for multiple modes

2020-04-09 Thread Paul Cercueil
Hi Sam, Le mer. 8 avril 2020 à 12:04, Sam Ravnborg a écrit : Hi Paul. On Wed, Apr 08, 2020 at 11:58:29AM +0200, Paul Cercueil wrote: Add support for multiple drm_display_mode entries. This will allow to add a 50 Hz mode later. Signed-off-by: Paul Cercueil Patch looks good. Could we

Re: [RFC 0/6] Regressions for "imply" behavior change

2020-04-09 Thread Jason Gunthorpe
On Wed, Apr 08, 2020 at 10:49:48PM +0200, Arnd Bergmann wrote: > On Wed, Apr 8, 2020 at 10:38 PM Nicolas Pitre wrote: > > On Wed, 8 Apr 2020, Arnd Bergmann wrote: > > > I have created workarounds for the Kconfig files, which now stop using > > > imply and do something else in each case. I don't kn

[PATCH 1/7] drm/bridge: ps8640: Get the EDID from eDP control

2020-04-09 Thread Enric Balletbo i Serra
The PS8640 DSI-to-eDP bridge can retrieve the EDID, so implement the .get_edid callback and set the flag to indicate the core to use it. Signed-off-by: Enric Balletbo i Serra --- drivers/gpu/drm/bridge/parade-ps8640.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/gpu

Re: [PATCH 10/28] mm: only allow page table mappings for built-in zsmalloc

2020-04-09 Thread Randy Dunlap
On 4/8/20 8:36 AM, Christoph Hellwig wrote: > On Wed, Apr 08, 2020 at 08:15:19AM -0700, Matthew Wilcox wrote: > config ZSMALLOC_PGTABLE_MAPPING > bool "Use page table mapping to access object in zsmalloc" > - depends on ZSMALLOC > + depends on ZSMALLOC=y It's a bool so

[PATCH v2] drm: mediatek: fix device passed to cmdq

2020-04-09 Thread Hsin-Yi Wang
drm device is now probed from mmsys. We need to use mmsys device to get gce nodes. Fix following errors: [0.740068] mediatek-drm mediatek-drm.1.auto: error -2 can't parse gce-client-reg property (0) [0.748721] mediatek-drm mediatek-drm.1.auto: error -2 can't parse gce-client-reg property

Re: [RFC 0/6] Regressions for "imply" behavior change

2020-04-09 Thread Saeed Mahameed
On Wed, 2020-04-08 at 16:38 -0400, Nicolas Pitre wrote: > On Wed, 8 Apr 2020, Arnd Bergmann wrote: > > > Hi everyone, > > > > I've just restarted doing randconfig builds on top of mainline > > Linux and > > found a couple of regressions with missing dependency from the > > recent > > change in th

Re: [PATCH 0/2] powerpc: Remove support for ppc405/440 Xilinx platforms

2020-04-09 Thread Christophe Leroy
Le 08/04/2020 à 01:32, Benjamin Herrenschmidt a écrit : On Fri, 2020-04-03 at 15:59 +1100, Michael Ellerman wrote: Benjamin Herrenschmidt writes: On Tue, 2020-03-31 at 16:30 +1100, Michael Ellerman wrote: I have no attachment to 40x, and I'd certainly be happy to have less code in the tree,

Re: [PATCH 03/35] docs: fix broken references to text files

2020-04-09 Thread Marc Zyngier
On Wed, 8 Apr 2020 17:45:55 +0200 Mauro Carvalho Chehab wrote: > Several references got broken due to txt to ReST conversion. > > Several of them can be automatically fixed with: > > scripts/documentation-file-ref-check --fix > > Reviewed-by: Mathieu Poirier # > hwtracing/coresight/Kc

Re: [PATCH 17/28] mm: remove the prot argument from vm_map_ram

2020-04-09 Thread Gao Xiang
On Wed, Apr 08, 2020 at 01:59:15PM +0200, Christoph Hellwig wrote: > This is always GFP_KERNEL - for long term mappings with other properties > vmap should be used. > > Signed-off-by: Christoph Hellwig > --- > drivers/gpu/drm/i915/gem/selftests/mock_dmabuf.c | 2 +- > drivers/media/common/vide

Re: [RFC 0/6] Regressions for "imply" behavior change

2020-04-09 Thread Jani Nikula
On Wed, 08 Apr 2020, Jason Gunthorpe wrote: > On Wed, Apr 08, 2020 at 10:49:48PM +0200, Arnd Bergmann wrote: >> On Wed, Apr 8, 2020 at 10:38 PM Nicolas Pitre wrote: >> > On Wed, 8 Apr 2020, Arnd Bergmann wrote: >> > > I have created workarounds for the Kconfig files, which now stop using >> > > i

Re: [PATCH 19/28] gpu/drm: remove the powerpc hack in drm_legacy_sg_alloc

2020-04-09 Thread Benjamin Herrenschmidt
On Wed, 2020-04-08 at 14:25 +0200, Daniel Vetter wrote: > On Wed, Apr 08, 2020 at 01:59:17PM +0200, Christoph Hellwig wrote: > > If this code was broken for non-coherent caches a crude powerpc hack > > isn't going to help anyone else. Remove the hack as it is the last > > user of __vmalloc passing

Re: [PATCH 0/2] drm: bridge: simple-bridge: Enable usage with DRM bridge connector helper

2020-04-09 Thread Sergei Shtylyov
Hello! On 09.04.2020 3:36, Laurent Pinchart wrote: This small patch series enables usage of the simple-bridge driver with the DRM bridge connector helper (drm_bridge_connector.c). Patch 1/2 starts by simplifying the driver by delegating DDC handling to the next bridge in the chain, and patch 2/

Re: [PATCH 19/28] gpu/drm: remove the powerpc hack in drm_legacy_sg_alloc

2020-04-09 Thread Daniel Vetter
On Thu, Apr 9, 2020 at 10:54 AM Benjamin Herrenschmidt wrote: > > On Wed, 2020-04-08 at 14:25 +0200, Daniel Vetter wrote: > > On Wed, Apr 08, 2020 at 01:59:17PM +0200, Christoph Hellwig wrote: > > > If this code was broken for non-coherent caches a crude powerpc hack > > > isn't going to help anyo

Re: [PATCH v1] staging: fbtft: fb_st7789v: enabled inversion

2020-04-09 Thread Dan Carpenter
On Thu, Apr 09, 2020 at 11:24:05AM +0200, Oliver Graute wrote: > From: Oliver Graute > > Enable inversion mode > > Signed-off-by: Oliver Graute > --- > drivers/staging/fbtft/fb_st7789v.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/drivers/staging/fbtft/fb_st7789v.c > b/drive

Re: [PATCH v1] staging: fbtft: fb_st7789v: enabled inversion

2020-04-09 Thread Dan Carpenter
On Thu, Apr 09, 2020 at 11:24:05AM +0200, Oliver Graute wrote: > From: Oliver Graute > > Enable inversion mode What the heck is an inversion mode and why would you want it? regards, dasn carpenter ___ dri-devel mailing list dri-devel@lists.freedeskto

Re: [PATCH v9 0/5] drm/tidss: New driver for TI Keystone platform Display SubSystem

2020-04-09 Thread Tomi Valkeinen
On 07/04/2020 19:44, Sam Ravnborg wrote: On Tue, Apr 07, 2020 at 04:18:20PM +0300, Tomi Valkeinen wrote: Hi Jyri, On 27/01/2020 18:00, Jyri Sarha wrote: This is intended to be the last patch series. I'll apply these trough drm-misc-next tomorrow. Were these ever merged? See 32a1795f57eecc3

Re: [PATCH v1] staging: fbtft: fb_st7789v: Initialize the Display

2020-04-09 Thread Dan Carpenter
On Thu, Apr 09, 2020 at 11:25:32AM +0200, Oliver Graute wrote: > From: Oliver Graute > > Set Gamma Values and Register Values for the HSD20_IPS > > Signed-off-by: Oliver Graute > --- > drivers/staging/fbtft/fb_st7789v.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > >

[PATCH v11 0/2] drm: bridge: Add NWL MIPI DSI host controller support

2020-04-09 Thread Guido Günther
This adds initial support for the NWL MIPI DSI Host controller found on i.MX8 SoCs. It adds support for the i.MX8MQ but the same IP core can also be found on e.g. i.MX8QXP. I added the necessary hooks to support other imx8 variants but since I only have imx8mq boards to test I omitted the platform

[PATCH v11 1/2] dt-bindings: display/bridge: Add binding for NWL mipi dsi host controller

2020-04-09 Thread Guido Günther
The Northwest Logic MIPI DSI IP core can be found in NXPs i.MX8 SoCs. Signed-off-by: Guido Günther Tested-by: Robert Chiras Reviewed-by: Rob Herring Acked-by: Sam Ravnborg Reviewed-by: Fabio Estevam --- .../bindings/display/bridge/nwl-dsi.yaml | 226 ++ 1 file changed, 2

[PATCH v11 2/2] drm/bridge: Add NWL MIPI DSI host controller support

2020-04-09 Thread Guido Günther
This adds initial support for the NWL MIPI DSI Host controller found on i.MX8 SoCs. It adds support for the i.MX8MQ but the same IP can be found on e.g. the i.MX8QXP. It has been tested on the Librem 5 devkit using mxsfb. Signed-off-by: Guido Günther Co-developed-by: Robert Chiras Signed-off-b

Re: [PATCH v10 1/2] dt-bindings: display/bridge: Add binding for NWL mipi dsi host controller

2020-04-09 Thread Guido Günther
Hi, On Wed, Apr 08, 2020 at 07:32:58PM +0200, Sam Ravnborg wrote: > Hi Guido. > > We discussed this binding briefly on IRC: > > 19:28 port 0 is defined as > 19:28 + Input port node to receive pixel data from the > 19:28 + display controller. Exactly one endpoint must be > 19:

Re: [PATCH v10 2/2] drm/bridge: Add NWL MIPI DSI host controller support

2020-04-09 Thread Guido Günther
Hi Sam, Thanks for having a look! Comments below: On Wed, Apr 08, 2020 at 07:52:52PM +0200, Sam Ravnborg wrote: > Hi Guido. > > On Fri, Mar 20, 2020 at 07:49:10PM +0100, Guido Günther wrote: > > This adds initial support for the NWL MIPI DSI Host controller found on > > i.MX8 SoCs. > > > > It ad

[PATCH 1/3] dma-buf: Prettify typecasts for dma-fence-chain

2020-04-09 Thread Chris Wilson
Inside dma-fence-chain, we use a cmpxchg on an RCU-protected pointer. To avoid the sparse warning for using the RCU pointer directly, we have to cast away the __rcu annotation. However, we don't need to use void* everywhere and can stick to the dma_fence*. Signed-off-by: Chris Wilson Reviewed-by:

[PATCH 3/3] dma-buf: Exercise dma-fence-chain under selftests

2020-04-09 Thread Chris Wilson
A few very simple testcases to exercise the dma-fence-chain API. Signed-off-by: Chris Wilson Reviewed-by: Venkata Sandeep Dhanalakota --- drivers/dma-buf/Makefile | 3 +- drivers/dma-buf/selftests.h | 1 + drivers/dma-buf/st-dma-fence-chain.c | 713 +

[PATCH 2/3] dma-buf: Report signaled links inside dma-fence-chain

2020-04-09 Thread Chris Wilson
Whenever we walk along the dma-fence-chain, we prune signaled links to keep the chain nice and tidy. This leads to situations where we can prune a link and report the earlier fence as the target seqno -- violating our own consistency checks that the seqno is not more advanced than the last element

Re: [PATCH v10 2/2] drm/bridge: Add NWL MIPI DSI host controller support

2020-04-09 Thread Sam Ravnborg
Hi Guido. > > > + > > > +/* i.MX8 NWL quirks */ > > > +/* i.MX8MQ errata E11418 */ > > > +#define E11418_HS_MODE_QUIRK BIT(0) > > > + > > > +#define NWL_DSI_MIPI_FIFO_TIMEOUT msecs_to_jiffies(500) > > Should the defines be moved to the header file? > > I've used this rules: register layout (t

[PATCH v1 1/3] drm/panel: update backlight handling for samsung-s6e3ha2

2020-04-09 Thread Sam Ravnborg
The samsung-s6e3ha2 had a local way to handle backlight. Update the driver to use a devm_ based register function and utilize drm_panel backlight support. The changes results in a simpler driver with the same functionality. Signed-off-by: Sam Ravnborg Cc: Joonas Kylmälä Cc: Andrzej Hajda Cc: T

[PATCH v1 2/3] drm/panel: update backlight handling for samsung-s6e63j0x03

2020-04-09 Thread Sam Ravnborg
The samsung-s6e63j0x03 had a local way to handle backlight. Update the driver to use a devm_ based register function and utilize drm_panel backlight support. The changes results in a simpler driver with the same functionality. Signed-off-by: Sam Ravnborg Cc: Joonas Kylmälä Cc: Andrzej Hajda Cc

[PATCH v1 0/3] drm/panel: update backlight support for samsung panels

2020-04-09 Thread Sam Ravnborg
Update the backlight handling in three samsung panels. - Use devm_ functions to automate cleanup - Utilize backlight support in drm_panel - Introduce a register backlight helper in all panels Using the same pattern in all panels makes it simpler to read the code. With this change the

[PATCH v1 3/3] drm/panel: update backlight handling for samsung-s6e63m0

2020-04-09 Thread Sam Ravnborg
The samsung-s6e63m0 had a local way to handle backlight. Update the driver to use a devm_ based register function and utilize drm_panel backlight support. The changes results in a simpler driver with the same functionality. Signed-off-by: Sam Ravnborg Cc: Paweł Chmiel Cc: Joonas Kylmälä Cc: An

Re: [PATCH] drm/ttm: Remove reference to the mem_glob member

2020-04-09 Thread Christian König
Am 09.04.20 um 00:14 schrieb Maya Rashish: It was removed in: Author: Christian König Date: Wed Sep 25 11:38:50 2019 +0200 drm/ttm: remove pointers to globals Signed-off-by: Maya Rashish Reviewed-by: Christian König I assuming you don't have commit right, so I'm going to push this

Re: [RFC v3 1/8] dt-bindings: display: convert ingenic, lcd.txt to ingenic, lcd.yaml

2020-04-09 Thread Sam Ravnborg
Hi Nikolaus. > >> + > >> +examples: > >> + - | > >> +#include > >> + > >> +panel { > >> + compatible = "sharp,ls020b1dd01d"; > >> + > >> + backlight = <&backlight>; > >> + power-supply = <&vcc>; > >> + > >> + port { > >> +panel_input: endpoint { > >> +

Re: [PATCH] drm/ttm: Schedule out if possibe in bo delayed delete worker

2020-04-09 Thread Christian König
Am 09.04.20 um 03:31 schrieb xinhui pan: The delayed delete list is per device which might be very huge. And in a heavy workload test, the list might always not be empty. That will trigger any RCU stall warnings or softlockups in non-preemptible kernels Lets do schedule out if possible in that ca

Re: [PATCH] drm/ttm: Schedule out if possibe in bo delayed delete worker

2020-04-09 Thread Lucas Stach
Am Donnerstag, den 09.04.2020, 14:35 +0200 schrieb Christian König: > Am 09.04.20 um 03:31 schrieb xinhui pan: > > The delayed delete list is per device which might be very huge. And in > > a heavy workload test, the list might always not be empty. That will > > trigger any RCU stall warnings or so

[PATCH] drm/i915: remove redundant assignment to variable err

2020-04-09 Thread Colin King
From: Colin Ian King The variable err is being initialized with a value that is never read and it is being updated later with a new value. The initialization is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King --- drivers/gpu/drm/i915/gem/selfte

[Bug 207171] New: [regression][bisected] Ryzen PRO 2400G, firefox screen corruption in X

2020-04-09 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=207171 Bug ID: 207171 Summary: [regression][bisected] Ryzen PRO 2400G, firefox screen corruption in X Product: Drivers Version: 2.5 Kernel Version: 5.6.3 Hardware: All

[Bug 207171] [regression][bisected] Ryzen PRO 2400G, firefox screen corruption in X

2020-04-09 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=207171 Florian Ziegler (florian.zieg...@posteo.de) changed: What|Removed |Added Regression|No |Yes -- You

Re: [PATCH] drm/ttm: Schedule out if possibe in bo delayed delete worker

2020-04-09 Thread Christian König
Am 09.04.20 um 15:25 schrieb Lucas Stach: Am Donnerstag, den 09.04.2020, 14:35 +0200 schrieb Christian König: Am 09.04.20 um 03:31 schrieb xinhui pan: The delayed delete list is per device which might be very huge. And in a heavy workload test, the list might always not be empty. That will trig

[Bug 207171] [regression][bisected] Ryzen PRO 2400G, firefox screen corruption in X

2020-04-09 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=207171 Alex Deucher (alexdeuc...@gmail.com) changed: What|Removed |Added CC||alexdeuc...@gmail.c

Re: [PATCH v11 0/2] drm: bridge: Add NWL MIPI DSI host controller support

2020-04-09 Thread Sam Ravnborg
Hi Guido. On Thu, Apr 09, 2020 at 12:42:00PM +0200, Guido Günther wrote: > This adds initial support for the NWL MIPI DSI Host controller found on i.MX8 > SoCs. > > It adds support for the i.MX8MQ but the same IP core can also be found on e.g. > i.MX8QXP. I added the necessary hooks to support ot

Re: [PATCH] drm/ttm: Schedule out if possibe in bo delayed delete worker

2020-04-09 Thread Pan, Xinhui
[AMD Official Use Only - Internal Distribution Only] Why we break out the loops when there are pending bos to be released? And I just checked the process_one_work. Right after the work item callback is called, the workqueue itself will call cond_resched. So I think _

Re: [PATCH] drm/ttm: Schedule out if possibe in bo delayed delete worker

2020-04-09 Thread Pan, Xinhui
I think it doesn't matter if workitem schedule out. Even we did not schedule out, the workqueue itself will schedule out later. So it did not break anything with this patch I think. From: Pan, Xinhui Sent: Thursday, April 9, 2020 10:07:09 PM To: Lucas Stach ; amd-

Re: [PATCH 1/3] drm: pl111: Fix module autoloading

2020-04-09 Thread Sam Ravnborg
Hi Rob. On Wed, Apr 08, 2020 at 07:39:45PM -0600, Rob Herring wrote: > Add a missing MODULE_DEVICE_TABLE entry to fix module autoloading. > > Cc: Eric Anholt > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Rob Herring Change looks straightforward. Acked-by: Sam Ravnborg > --- > drive

Re: [PATCH v1 2/3] drm/panel: update backlight handling for samsung-s6e63j0x03

2020-04-09 Thread Emil Velikov
On Thu, 9 Apr 2020 at 12:53, Sam Ravnborg wrote: > > The samsung-s6e63j0x03 had a local way to handle backlight. > > Update the driver to use a devm_ based register function > and utilize drm_panel backlight support. The changes results > in a simpler driver with the same functionality. > > Signed

Re: [PATCH 2/3] drm: pl111: Simplify vexpress init

2020-04-09 Thread Sam Ravnborg
Hi Rob. On Wed, Apr 08, 2020 at 07:39:46PM -0600, Rob Herring wrote: > The init VExpress variants currently instantiates a 'muxfpga' driver for > the sole purpose of getting a regmap for it. There's no reason to > instantiate a driver and doing so just complicates things. The muxfpga > driver also

Re: [PATCH 19/28] gpu/drm: remove the powerpc hack in drm_legacy_sg_alloc

2020-04-09 Thread Alex Deucher
On Thu, Apr 9, 2020 at 5:41 AM Daniel Vetter wrote: > > On Thu, Apr 9, 2020 at 10:54 AM Benjamin Herrenschmidt > wrote: > > > > On Wed, 2020-04-08 at 14:25 +0200, Daniel Vetter wrote: > > > On Wed, Apr 08, 2020 at 01:59:17PM +0200, Christoph Hellwig wrote: > > > > If this code was broken for non-

Re: [PATCH] drm/ttm: Schedule out if possibe in bo delayed delete worker

2020-04-09 Thread Pan, Xinhui
https://elixir.bootlin.com/linux/latest/source/mm/slab.c#L4026 This is another example of the usage of cond_sched. From: Pan, Xinhui Sent: Thursday, April 9, 2020 10:11:08 PM To: Lucas Stach ; amd-...@lists.freedesktop.org ; Koenig, Christian Cc: dri-devel@list

Re: [PATCH 3/3] drm: pl111: Move VExpress setup into versatile init

2020-04-09 Thread Sam Ravnborg
Hi Rob. On Wed, Apr 08, 2020 at 07:39:47PM -0600, Rob Herring wrote: > Since the VExpress setup in pl111_vexpress.c is now just a single > function call, let's move it into pl111_versatile.c and we can further > simplify pl111_versatile_init() by moving the other pieces for VExpress > into pl111_v

Re: [PATCH v1 2/3] drm/panel: update backlight handling for samsung-s6e63j0x03

2020-04-09 Thread Sam Ravnborg
Hi Emil. Thanks for your feedback! On Thu, Apr 09, 2020 at 03:13:28PM +0100, Emil Velikov wrote: > On Thu, 9 Apr 2020 at 12:53, Sam Ravnborg wrote: > > > > The samsung-s6e63j0x03 had a local way to handle backlight. > > > > Update the driver to use a devm_ based register function > > and utilize

Re: [PATCH 19/28] gpu/drm: remove the powerpc hack in drm_legacy_sg_alloc

2020-04-09 Thread Daniel Vetter
On Thu, Apr 9, 2020 at 4:19 PM Alex Deucher wrote: > > On Thu, Apr 9, 2020 at 5:41 AM Daniel Vetter wrote: > > > > On Thu, Apr 9, 2020 at 10:54 AM Benjamin Herrenschmidt > > wrote: > > > > > > On Wed, 2020-04-08 at 14:25 +0200, Daniel Vetter wrote: > > > > On Wed, Apr 08, 2020 at 01:59:17PM +020

Re: [PATCH] drm/ttm: Schedule out if possibe in bo delayed delete worker

2020-04-09 Thread Christian König
Why we break out the loops when there are pending bos to be released? We do this anyway if we can't acquire the necessary locks. Freeing already deleted BOs is just a very lazy background work. So it did not break anything with this patch I think. Oh, the patch will certainly work. I'm jus

[PATCH 2/2] drm/i915: remove gvt/Makefile

2020-04-09 Thread Masahiro Yamada
Including subdirectory Makefile from the driver main Makefile does not buy us much because this is not real isolation. Having a single Makefile at the top of the module is clearer, and it is what this driver almost does. Move all gvt objects to the i915 main Makefile. Signed-off-by: Masahiro Yam

[PATCH 1/2] drm/i915: remove unneeded ccflags-y from gvt/Makefile

2020-04-09 Thread Masahiro Yamada
When CONFIG_DRM_I915_GVT=y, the same include path is added twice. drivers/gpu/drm/i915/Makefile specifies: subdir-ccflags-y += -I$(srctree)/$(src) drivers/gpu/drm/i915/gvt/Makefile adds the second '-I $(srctree)/$(src)', which is redundant. The include path '-I $(srctree)/$(src)/$(GVT_DIR)/'

[Bug 207171] [regression][bisected] Ryzen PRO 2400G, firefox screen corruption in X

2020-04-09 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=207171 --- Comment #2 from Florian Ziegler (florian.zieg...@posteo.de) --- > Does this patch fix it? Yes, the patch fixes the issue. Thank you. -- You are receiving this mail because: You are watching the assignee of the bug. __

Re: [PATCH 01/28] x86/hyperv: use vmalloc_exec for the hypercall page

2020-04-09 Thread Wei Liu
On Wed, Apr 08, 2020 at 01:58:59PM +0200, Christoph Hellwig wrote: > Use the designated helper for allocating executable kernel memory, and > remove the now unused PAGE_KERNEL_RX define. > > Signed-off-by: Christoph Hellwig Acked-by: Wei Liu ___ dri-d

Re: [PATCH 09/28] mm: rename CONFIG_PGTABLE_MAPPING to CONFIG_ZSMALLOC_PGTABLE_MAPPING

2020-04-09 Thread Minchan Kim
On Wed, Apr 08, 2020 at 01:59:07PM +0200, Christoph Hellwig wrote: > Rename the Kconfig variable to clarify the scope. > > Signed-off-by: Christoph Hellwig Acked-by: Minchan Kim ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.f

Re: [PATCH 1/2] dt-bindings: display: ltk500hd1829: Remove the reg property

2020-04-09 Thread Rob Herring
On Sat, Mar 28, 2020 at 2:30 PM Sam Ravnborg wrote: > > On Sat, Mar 28, 2020 at 03:36:40PM -0300, Fabio Estevam wrote: > > Commit 52120e8c7ae3 ("dt-bindings: display: fix panel warnings") removed > > the dsi unit name, but missed to remove the 'reg' property, which causes > > the following 'make d

Re: [PATCH 10/28] mm: only allow page table mappings for built-in zsmalloc

2020-04-09 Thread Minchan Kim
On Wed, Apr 08, 2020 at 01:59:08PM +0200, Christoph Hellwig wrote: > This allows to unexport map_vm_area and unmap_kernel_range, which are > rather deep internal and should not be available to modules. Even though I don't know how many usecase we have using zsmalloc as module(I heard only once by

Re: [PATCH v2] drm: mediatek: fix device passed to cmdq

2020-04-09 Thread Chun-Kuang Hu
Hi, Hsin-Yi: Hsin-Yi Wang 於 2020年4月9日 週四 下午2:02寫道: > > drm device is now probed from mmsys. We need to use mmsys device to get gce > nodes. Fix following errors: > > [0.740068] mediatek-drm mediatek-drm.1.auto: error -2 can't parse > gce-client-reg property (0) > [0.748721] mediatek-drm

Re: [PATCH v2 01/36] dt-bindings: display: allow port and ports in panel-lvds

2020-04-09 Thread Rob Herring
On Wed, Apr 8, 2020 at 1:51 PM Sam Ravnborg wrote: > > Both port and ports names may be used. > port - for a single port > ports - if there is more than one port in sub-nodes > > Fixes the following warning: > advantech,idk-2121wr.example.dt.yaml: panel-lvds: 'port' is a required > property > > a

  1   2   >