Re: [PATCH] drm/i915: check to see if the FPU is available before using it

2020-04-08 Thread Jason A. Donenfeld
On Sat, Mar 28, 2020 at 1:59 AM Chris Wilson wrote: > > Quoting Jason A. Donenfeld (2020-03-28 00:04:22) > > It's not safe to just grab the FPU willy nilly without first checking to > > see if it's available. This patch adds the usual call to may_use_simd() > > and falls back to boring memcpy if i

[PATCH V5 4/4] backlight: qcom-wled: Add support for WLED5 peripheral that is present on PM8150L PMICs

2020-04-08 Thread Kiran Gunda
From: Subbaraman Narayanamurthy PM8150L WLED supports the following: - Two modulators and each sink can use any of the modulator - Multiple CABC selection options from which one can be selected/enabled - Multiple brightness width selection (12 bits to 15 bits) Signed-off-by: Subbaram

[PATCH V5 0/4] Add support for WLED5

2020-04-08 Thread Kiran Gunda
Currently, WLED driver supports only WLED4 peripherals that is present on pmi8998 and pm660L. This patch series converts the existing WLED4 bindings from .txt to .yaml format and adds the support for WLED5 peripheral that is present on PM8150L. PM8150L WLED supports the following. - Two modul

[PATCH V5 3/4] backlight: qcom-wled: Add WLED5 bindings

2020-04-08 Thread Kiran Gunda
Add WLED5 specific bindings. Signed-off-by: Kiran Gunda Signed-off-by: Subbaraman Narayanamurthy --- .../bindings/leds/backlight/qcom-wled.yaml | 60 -- 1 file changed, 57 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree/bindings/leds/backlight/qc

[PATCH V5 2/4] backlight: qcom-wled: Add callback functions

2020-04-08 Thread Kiran Gunda
Add wled_cabc_config, wled_sync_toggle, wled_ovp_fault_status and wled_ovp_delay and wled_auto_detection_required callback functions to prepare the driver for adding WLED5 support. Signed-off-by: Kiran Gunda Signed-off-by: Subbaraman Narayanamurthy --- drivers/video/backlight/qcom-wled.c | 216

[RESEND] drm: bridge: adv7511: Fix low refresh rate register for ADV7533/5

2020-04-08 Thread Bogdan Togorean
For ADV7533 and ADV7535 low refresh rate is selected using bits [3:2] of 0x4a main register. So depending on ADV model write 0xfb or 0x4a register. Fixes: 9c8af882bf12: ("drm: Add adv7511 encoder driver") Signed-off-by: Bogdan Togorean --- drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 9 +++

[RESEND 1/2] drm: bridge: adv7511: Enable SPDIF DAI

2020-04-08 Thread Bogdan Togorean
ADV7511 support I2S or SPDIF as audio input interfaces. This commit enable support for SPDIF. Signed-off-by: Bogdan Togorean Reviewed-by: Andrzej Hajda --- drivers/gpu/drm/bridge/adv7511/adv7511_audio.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/gpu/drm/bridge/a

[PATCH] drm/i915: Force DPCD backlight mode for HP CML 2020 system

2020-04-08 Thread Kai-Heng Feng
There's another Samsung OLED panel needs to use DPCD aux interface to control backlight. Signed-off-by: Kai-Heng Feng --- drivers/gpu/drm/drm_dp_helper.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c index c6fbe6e6bc9d..d0

Re: [PATCH 03/44] drm/device: Deprecate dev_private harder

2020-04-08 Thread Sam Ravnborg
On Fri, Apr 03, 2020 at 03:57:47PM +0200, Daniel Vetter wrote: > We've had lots of conversions to embeddeding, but didn't stop using > ->dev_private. Which defeats the point of this. > > Signed-off-by: Daniel Vetter Reviewed-by: Sam Ravnborg > --- > include/drm/drm_device.h | 9 ++--- > 1 f

Re: [PATCH 06/44] drm/vboxvideo: drop DRM_MTRR_WC #define

2020-04-08 Thread Sam Ravnborg
On Fri, Apr 03, 2020 at 03:57:50PM +0200, Daniel Vetter wrote: > Doesn't apply to upstream kernels since a rather long time. > > Signed-off-by: Daniel Vetter > Cc: Hans de Goede Acked-by: Sam Ravnborg > --- > drivers/gpu/drm/vboxvideo/vbox_ttm.c | 12 > 1 file changed, 12 deletion

Re: Bad rss-counter state from drm/ttm, drm/vmwgfx: Support huge TTM pagefaults

2020-04-08 Thread Alex Xu (Hello71)
Excerpts from Thomas Hellström (VMware)'s message of April 7, 2020 7:26 am: > On 4/7/20 2:38 AM, Alex Xu (Hello71) wrote: >> Excerpts from Thomas Hellström (VMware)'s message of April 6, 2020 5:04 pm: >>> Hi, >>> >>> On 4/6/20 9:51 PM, Alex Xu (Hello71) wrote: Using 314b658 with amdgpu, starti

Re: [PATCH 08/44] drm/vboxvideo: Stop using drm_device->dev_private

2020-04-08 Thread Sam Ravnborg
On Fri, Apr 03, 2020 at 03:57:52PM +0200, Daniel Vetter wrote: > We use the baseclass pattern here, so lets to the proper (and more > typesafe) upcasting. > > Signed-off-by: Daniel Vetter > Cc: Hans de Goede Acked-by: Sam Ravnborg As for naming discussed in other mail I had gone for to_vbox()

Re: [PATCH 09/44] drm/vboxvidoe: use managed pci functions

2020-04-08 Thread Sam Ravnborg
On Fri, Apr 03, 2020 at 03:57:53PM +0200, Daniel Vetter wrote: > Allows us to drop the cleanup code on the floor. > > Signed-off-by: Daniel Vetter > Cc: Hans de Goede With this change we avoid calling pci_disable_device() twise in case vbox_mm_init() fails. Once in vbox_hw_fini() and once in th

Re: [PATCH] drm/i915: Force DPCD backlight mode for HP Spectre x360 Convertible 13t-aw100

2020-04-08 Thread Jani Nikula
On Tue, 07 Apr 2020, Kai-Heng Feng wrote: >> On Mar 27, 2020, at 19:03, Kai-Heng Feng wrote: >> >> Hi, >> >>> On Mar 23, 2020, at 13:35, Kai-Heng Feng >>> wrote: >>> >>> There's another OLED panel needs to use DPCD aux interface to control >>> backlight. >>> >>> BugLink: https://bugs.launch

Re: [PATCH] drm/i915: Force DPCD backlight mode for HP CML 2020 system

2020-04-08 Thread Jani Nikula
On Tue, 07 Apr 2020, Kai-Heng Feng wrote: > There's another Samsung OLED panel needs to use DPCD aux interface to > control backlight. Acked-by: Jani Nikula > > Signed-off-by: Kai-Heng Feng > --- > drivers/gpu/drm/drm_dp_helper.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/driv

Re: [PATCH 10/44] drm/vboxvideo: Use devm_gen_pool_create

2020-04-08 Thread Sam Ravnborg
On Fri, Apr 03, 2020 at 03:57:54PM +0200, Daniel Vetter wrote: > Aside from deleting all the cleanup code we're now also setting a name > for the pool > > Signed-off-by: Daniel Vetter > Cc: Hans de Goede Nice cleanup. Acked-by: Sam Ravnborg > --- > drivers/gpu/drm/vboxvideo/vbox_main.c | 22

Re: [PATCH 14/44] drm/v3d: Delete v3d_dev->pdev

2020-04-08 Thread Sam Ravnborg
Hi Daniel. On Fri, Apr 03, 2020 at 03:57:58PM +0200, Daniel Vetter wrote: > We already have it in v3d_dev->drm.dev with zero additional pointer > chasing. Personally I don't like duplicated pointers like this > because: > - reviewers need to check whether the pointer is for the same or > different

Re: [PATCH 16/44] drm/udl: don't set drm_device->dev_private

2020-04-08 Thread Sam Ravnborg
On Fri, Apr 03, 2020 at 03:58:00PM +0200, Daniel Vetter wrote: > We're mostly there already, just a handful of places that didn't use > the to_udl container_of cast. To make sure no new appear, don't set > ->dev_private. > > Signed-off-by: Daniel Vetter > Cc: Dave Airlie > Cc: Sean Paul > Cc: E

Re: [PATCH 00/15] amdgpu: remove load and unload callbacks (v3)

2020-04-08 Thread Thomas Zimmermann
Hi Alex Am 07.02.20 um 20:50 schrieb Alex Deucher: > These are deprecated and the drm will soon start warning when drivers still > use them. It was a long and twisty road, but seems to work. Are you going to convert radeon as well? It's the only remaining KMS driver that uses load. Best regards

Re: [PATCH 27/44] drm/tidss: Use devm_drm_dev_alloc

2020-04-08 Thread Sam Ravnborg
On Fri, Apr 03, 2020 at 03:58:11PM +0200, Daniel Vetter wrote: > Already using devm_drm_dev_init, so very simple replacment. > > Signed-off-by: Daniel Vetter > Cc: Jyri Sarha > Cc: Tomi Valkeinen Acked-by: Sam Ravnborg > --- > drivers/gpu/drm/tidss/tidss_drv.c | 15 --- > 1 file c

Re: [PATCH 28/44] drm/tidss: Don't use drm_device->dev_private

2020-04-08 Thread Sam Ravnborg
On Fri, Apr 03, 2020 at 03:58:12PM +0200, Daniel Vetter wrote: > Upcasting using a container_of macro is more typesafe, faster and > easier for the compiler to optimize. > > Signed-off-by: Daniel Vetter > Cc: Jyri Sarha > Cc: Tomi Valkeinen Acked-by: Sam Ravnborg > --- > drivers/gpu/drm/tidss

Re: [PATCH 29/44] drm/tidss: Delete tidss->saved_state

2020-04-08 Thread Sam Ravnborg
On Fri, Apr 03, 2020 at 03:58:13PM +0200, Daniel Vetter wrote: > Not used anymore since the switch to suspend/resume helpers. > > Signed-off-by: Daniel Vetter > Cc: Jyri Sarha > Cc: Tomi Valkeinen Good spot. Acked-by: Sam Ravnborg > --- > drivers/gpu/drm/tidss/tidss_drv.h | 2 -- > 1 file c

Re: [PATCH 00/10] Set up generic fbdev after registering device

2020-04-08 Thread Thomas Zimmermann
Hi Jani Am 07.04.20 um 09:24 schrieb Jani Nikula: > On Tue, 07 Apr 2020, Thomas Zimmermann wrote: >> Hi Sam >> >> Am 06.04.20 um 22:00 schrieb Sam Ravnborg: >>> Hi Thomas. >>> >>> On Mon, Apr 06, 2020 at 03:43:55PM +0200, Thomas Zimmermann wrote: Generic fbdev emulation is a DRM client. If p

Re: [PATCH 32/44] drm/mcde: Use devm_drm_dev_alloc

2020-04-08 Thread Sam Ravnborg
On Fri, Apr 03, 2020 at 03:58:16PM +0200, Daniel Vetter wrote: > Already using devm_drm_dev_init, so very simple replacment. > > Signed-off-by: Daniel Vetter > Cc: Linus Walleij Acked-by: Sam Ravnborg But one comment below. > --- > drivers/gpu/drm/mcde/mcde_drv.c | 16 > 1 f

Re: [PATCH 33/44] drm/mcde: Don't use drm_device->dev_private

2020-04-08 Thread Sam Ravnborg
On Fri, Apr 03, 2020 at 03:58:17PM +0200, Daniel Vetter wrote: > Upcasting using a container_of macro is more typesafe, faster and > easier for the compiler to optimize. > > Signed-off-by: Daniel Vetter > Cc: Linus Walleij Acked-by: Sam Ravnborg > --- > drivers/gpu/drm/mcde/mcde_display.c | 10

Re: [PATCH 34/44] drm/ingenic: Use devm_drm_dev_alloc

2020-04-08 Thread Sam Ravnborg
On Fri, Apr 03, 2020 at 03:58:18PM +0200, Daniel Vetter wrote: > Already using devm_drm_dev_init, so very simple replacment. > > Signed-off-by: Daniel Vetter > Cc: Paul Cercueil Acked-by: Sam Ravnborg > --- > drivers/gpu/drm/ingenic/ingenic-drm.c | 14 -- > 1 file changed, 4 insert

Re: [PATCH 35/44] drm/ingenic: Don't set drm_device->dev_private

2020-04-08 Thread Sam Ravnborg
On Fri, Apr 03, 2020 at 03:58:19PM +0200, Daniel Vetter wrote: > Entirely not used, just copypasta. > > Signed-off-by: Daniel Vetter > Cc: Paul Cercueil Acked-by: Sam Ravnborg > --- > drivers/gpu/drm/ingenic/ingenic-drm.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/dr

Re: [PATCH 39/44] drm/cirrus: Use devm_drm_dev_alloc

2020-04-08 Thread Sam Ravnborg
On Fri, Apr 03, 2020 at 03:58:23PM +0200, Daniel Vetter wrote: > Already using devm_drm_dev_init, so very simple replacment. > > Signed-off-by: Daniel Vetter > Cc: Dave Airlie > Cc: Gerd Hoffmann > Cc: Daniel Vetter > Cc: Sam Ravnborg > Cc: "Noralf Trønnes" > Cc: Rob Herring > Cc: Thomas Zi

Re: [PATCH 40/44] drm/cirrus: Don't use drm_device->dev_private

2020-04-08 Thread Sam Ravnborg
On Fri, Apr 03, 2020 at 03:58:24PM +0200, Daniel Vetter wrote: > Upcasting using a container_of macro is more typesafe, faster and > easier for the compiler to optimize. > > Signed-off-by: Daniel Vetter > Cc: Dave Airlie > Cc: Gerd Hoffmann > Cc: Daniel Vetter > Cc: "Noralf Trønnes" > Cc: Sam

Re: [PATCH 40/44] drm/cirrus: Don't use drm_device->dev_private

2020-04-08 Thread Sam Ravnborg
Hi Thomas. On Mon, Apr 06, 2020 at 01:58:54PM +0200, Thomas Zimmermann wrote: > > > Am 03.04.20 um 15:58 schrieb Daniel Vetter: > > Upcasting using a container_of macro is more typesafe, faster and > > easier for the compiler to optimize. > > > > Signed-off-by: Daniel Vetter > > Cc: Dave Airli

Re: [PATCH 00/44] devm_drm_dev_alloc, no more drmm_add_final_kfree

2020-04-08 Thread Sam Ravnborg
Hi Daniel. Made specific reply to several patches. This bunch: > drm/st7735r: Use devm_drm_dev_alloc > drm/st7586: Use devm_drm_dev_alloc > drm/repaper: Use devm_drm_dev_alloc > drm/mi0283qt: Use devm_drm_dev_alloc > drm/ili9486: Use devm_drm_dev_alloc > drm/ili9341: Use devm_drm_dev_

[PATCH v2 07/10] drm/tilcdc: Set up fbdev after fully registering device

2020-04-08 Thread Thomas Zimmermann
Generic fbdev support is a DRM client. Set it up after fully registering the new DRM device. Signed-off-by: Thomas Zimmermann Acked-by: Jyri Sarha Reviewed-by: Noralf Trønnes Acked-by: Gerd Hoffmann --- drivers/gpu/drm/tilcdc/tilcdc_drv.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-

[PATCH v2 05/10] drm/mediatek: Remove error check from fbdev setup

2020-04-08 Thread Thomas Zimmermann
Remove the error check from the fbdev setup function. The function will print a warning. v2: * fix subject line Signed-off-by: Thomas Zimmermann Reviewed-by: Noralf Trønnes Acked-by: Gerd Hoffmann --- drivers/gpu/drm/mediatek/mtk_drm_drv.c | 4 +--- 1 file changed, 1 insertion(+), 3 d

[PATCH v2 00/10] Set up generic fbdev after registering device

2020-04-08 Thread Thomas Zimmermann
Generic fbdev emulation is a DRM client. If possible, it should behave like userspace clients. Therefore it should not run before the driver registered the new DRM device. If the setup function fails, the driver should not report an error. This is a follow-up patchset to the discussion at [1]. I

[PATCH v2 10/10] drm/fb-helper: Remove return value from drm_fbdev_generic_setup()

2020-04-08 Thread Thomas Zimmermann
Generic fbdev emulation is a DRM client. Drivers should invoke the setup function, but not depend on its success. Hence remove the return value. v2: * warn if fbdev device has not been registered yet * document the new behavior * convert the existing warning to the new dev_

[PATCH v2 04/10] drm/ingenic: Remove error check from fbdev setup

2020-04-08 Thread Thomas Zimmermann
Remove the error check from the fbdev setup function. The function will print a warning. Signed-off-by: Thomas Zimmermann Reviewed-by: Paul Cercueil Reviewed-by: Noralf Trønnes Acked-by: Gerd Hoffmann --- drivers/gpu/drm/ingenic/ingenic-drm.c | 4 +--- 1 file changed, 1 insertion(+), 3 deleti

[PATCH v2 01/10] drm/ast: Set up fbdev after registering device; remove error checks

2020-04-08 Thread Thomas Zimmermann
Generic fbdev support is a DRM client. Set it up after registering the new DRM device. Remove the error checks as the driver's probe function should not depend on a DRM client's state. Signed-off-by: Thomas Zimmermann Reviewed-by: Noralf Trønnes Acked-by: Gerd Hoffmann --- drivers/gpu/drm/ast/

[PATCH v2 03/10] drm/kirin: Set up fbdev after fully registering device

2020-04-08 Thread Thomas Zimmermann
Generic fbdev support is a DRM client. Set it up after fully registering the new DRM device. Signed-off-by: Thomas Zimmermann Reviewed-by: Noralf Trønnes Acked-by: Gerd Hoffmann --- drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[PATCH v2 02/10] drm/hibmc: Remove error check from fbdev setup

2020-04-08 Thread Thomas Zimmermann
Generic fbdev support is a DRM client. Remove the error check as the driver's probe function should not depend on a DRM client's state. Signed-off-by: Thomas Zimmermann Reviewed-by: Noralf Trønnes Acked-by: Gerd Hoffmann --- drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 6 +- 1 file ch

[PATCH v2 06/10] drm/mgag200: Set up fbdev after registering device; remove error checks

2020-04-08 Thread Thomas Zimmermann
Generic fbdev support is a DRM client. Set it up after registering the new DRM device. Remove the error checks as the driver's probe function should not depend on a DRM client's state. Signed-off-by: Thomas Zimmermann Reviewed-by: Noralf Trønnes Acked-by: Gerd Hoffmann --- drivers/gpu/drm/mgag

[PATCH v2 09/10] drm/vboxvideo: Set up fbdev after registering device; remove error checks

2020-04-08 Thread Thomas Zimmermann
Generic fbdev support is a DRM client. Set it up after registering the new DRM device. Remove the error checks as the driver's probe function should not depend on a DRM client's state. Signed-off-by: Thomas Zimmermann Reviewed-by: Noralf Trønnes Acked-by: Gerd Hoffmann --- drivers/gpu/drm/vbox

[PATCH v2 08/10] drm/udl: Remove error check from fbdev setup

2020-04-08 Thread Thomas Zimmermann
Remove the error check from the fbdev setup function. The driver's probe function should not depend on a DRM client's state. Signed-off-by: Thomas Zimmermann Reviewed-by: Noralf Trønnes Acked-by: Gerd Hoffmann --- drivers/gpu/drm/udl/udl_drv.c | 6 +- 1 file changed, 1 insertion(+), 5 dele

etnaviv: command buffer outside valid memory window

2020-04-08 Thread Johannes Pointner
Hello, I'm trying to get etnaviv on an i.MX6Q (2 GB DDR RAM) device running with kernel 5.6.2 but it is failing to setup the GPU with the following error: [0.00] Memory policy: Data cache writealloc [0.00] cma: Reserved 256 MiB at 0x7f40 [0.00] On node 0 totalpages: 52

Re: [PATCH 36/44] drm/komeda: use devm_drm_dev_alloc

2020-04-08 Thread james qian wang (Arm Technology China)
On Fri, Apr 03, 2020 at 09:58:20PM +0800, Daniel Vetter wrote: > Komeda uses the component framework, which does open/close a new > devres group around all the bind callbacks. Which means we can use > devm_ functions for managing the drm_device cleanup, with leaking > stuff in case of deferred prob

Re: [PATCH v2 10/10] drm/fb-helper: Remove return value from drm_fbdev_generic_setup()

2020-04-08 Thread Sam Ravnborg
Hi Thomas. You missed my ack on the first 9 patches: https://lore.kernel.org/dri-devel/20200407101354.ga12...@ravnborg.org/ Not that it matters as others have acked/reviewed them. On Wed, Apr 08, 2020 at 10:26:41AM +0200, Thomas Zimmermann wrote: > Generic fbdev emulation is a DRM client. Drivers

[PATCH v3 1/2] dt-bindings: display: panel: Add binding document for Leadtek LTK050H3146W

2020-04-08 Thread Heiko Stuebner
From: Heiko Stuebner The LTK050H3146W is a 5.0" 720x1280 DSI display. Signed-off-by: Heiko Stuebner --- Sam said he had applied this to drm-misc-next already, but I can't see it so far, so included for completenes. .../display/panel/leadtek,ltk050h3146w.yaml | 51 +++ 1 file

[PATCH v3 2/2] drm/panel: add panel driver for Leadtek LTK050H3146W

2020-04-08 Thread Heiko Stuebner
From: Heiko Stuebner The LTK050H3146W is 5.0" 720x1280 DSI display. There are two variants with essentially the same name, LTK050H3146W and LTK050H3146W-A2. They differ in their init sequence and mode details. changes in v2: - add display variants changes in v3: - fixed indentation and artifact

Re: [PATCH v3 2/2] drm/panel: add panel driver for Leadtek LTK050H3146W

2020-04-08 Thread Sam Ravnborg
Goodmorning Heiko On Wed, Apr 08, 2020 at 10:53:17AM +0200, Heiko Stuebner wrote: > From: Heiko Stuebner > > The LTK050H3146W is 5.0" 720x1280 DSI display. There are two variants > with essentially the same name, LTK050H3146W and LTK050H3146W-A2. > > They differ in their init sequence and mode

Re: [PATCH 36/44] drm/komeda: use devm_drm_dev_alloc

2020-04-08 Thread Daniel Vetter
On Wed, Apr 8, 2020 at 10:41 AM james qian wang (Arm Technology China) wrote: > > On Fri, Apr 03, 2020 at 09:58:20PM +0800, Daniel Vetter wrote: > > Komeda uses the component framework, which does open/close a new > > devres group around all the bind callbacks. Which means we can use > > devm_ fun

Re: [PATCH v2 10/10] drm/fb-helper: Remove return value from drm_fbdev_generic_setup()

2020-04-08 Thread Thomas Zimmermann
Hi Sam Am 08.04.20 um 10:50 schrieb Sam Ravnborg: > Hi Thomas. > > You missed my ack on the first 9 patches: > https://lore.kernel.org/dri-devel/20200407101354.ga12...@ravnborg.org/ > Not that it matters as others have acked/reviewed them. This got lost. I'll add you acks. Thanks for taking anot

Re: [Intel-gfx] [PATCH v2 13/17] drm/i915: Stop using mode->private_flags

2020-04-08 Thread Jani Nikula
On Tue, 07 Apr 2020, Ville Syrjälä wrote: > On Tue, Apr 07, 2020 at 09:38:47AM +0200, Daniel Vetter wrote: >> On Fri, Apr 03, 2020 at 11:40:04PM +0300, Ville Syrjala wrote: >> > From: Ville Syrjälä >> > >> > Replace the use of mode->private_flags with a truly private bitmaks >> > in our own crtc

RE: [PATCH RESEND 1/7] drm/dsc: use rc_model_size from DSC config for PPS

2020-04-08 Thread Kulkarni, Vandita
> -Original Message- > From: Jani Nikula > Sent: Friday, March 27, 2020 6:12 PM > To: intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org > Cc: Nikula, Jani ; Alex Deucher > ; Harry Wentland ; Navare, > Manasi D ; Kulkarni, Vandita > > Subject: [PATCH RESEND 1/7] drm/dsc: use

RE: [PATCH RESEND 2/7] drm/dsc: add helper for calculating rc buffer size from DPCD

2020-04-08 Thread Kulkarni, Vandita
> -Original Message- > From: Jani Nikula > Sent: Friday, March 27, 2020 6:12 PM > To: intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org > Cc: Nikula, Jani ; Alex Deucher > ; Harry Wentland ; Navare, > Manasi D ; Kulkarni, Vandita > > Subject: [PATCH RESEND 2/7] drm/dsc: add

Re: [PATCH v3 1/5] drm: Introduce plane and CRTC scaling filter properties

2020-04-08 Thread Bharadiya,Pankaj
On Tue, Apr 07, 2020 at 08:28:02PM +0300, Ville Syrjälä wrote: > On Tue, Mar 31, 2020 at 12:08:53AM +0530, Pankaj Bharadiya wrote: > > Introduce per-plane and per-CRTC scaling filter properties to allow > > userspace to select the driver's default scaling filter or > > Nearest-neighbor(NN) filter f

RE: [PATCH RESEND 4/7] drm/i915/dsc: configure hardware using specified rc_model_size

2020-04-08 Thread Kulkarni, Vandita
> -Original Message- > From: Jani Nikula > Sent: Friday, March 27, 2020 6:12 PM > To: intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org > Cc: Nikula, Jani ; Navare, Manasi D > ; Kulkarni, Vandita > Subject: [PATCH RESEND 4/7] drm/i915/dsc: configure hardware using > specifi

RE: [PATCH RESEND 6/7] drm/i915/bios: fill in DSC rc_model_size from VBT

2020-04-08 Thread Kulkarni, Vandita
> -Original Message- > From: Jani Nikula > Sent: Friday, March 27, 2020 6:12 PM > To: intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org > Cc: Nikula, Jani ; Navare, Manasi D > ; Kulkarni, Vandita > Subject: [PATCH RESEND 6/7] drm/i915/bios: fill in DSC rc_model_size from >

Re: [PATCH 2/2] drm/panel: NT39016: Add support for 50 Hz refresh rate

2020-04-08 Thread Sam Ravnborg
Hi Paul. On Wed, Apr 08, 2020 at 11:58:30AM +0200, Paul Cercueil wrote: > By changing the pixel clock and the length of the back porch, it is > possible to obtain a perfect 50 Hz refresh rate. > > Signed-off-by: Paul Cercueil Lower case in $subject. Acked-by: Sam Ravnborg > --- > drivers/gp

Re: [PATCH 1/2] drm/panel: NT39016: Add support for multiple modes

2020-04-08 Thread Sam Ravnborg
Hi Paul. On Wed, Apr 08, 2020 at 11:58:29AM +0200, Paul Cercueil wrote: > Add support for multiple drm_display_mode entries. This will allow to > add a 50 Hz mode later. > > Signed-off-by: Paul Cercueil Patch looks good. Could we please use lower case in the $subject? Acked-by: Sam Ravnborg

Re: [PATCH] video: fbdev: mb862xx: remove set but not used variable 'mdr'

2020-04-08 Thread Sam Ravnborg
Hi Jason. On Fri, Apr 03, 2020 at 10:25:53AM +0800, Jason Yan wrote: > Fix the following gcc warning: > > drivers/video/fbdev/mb862xx/mb862xxfb_accel.c:187:6: warning: variable > ‘mdr’ set but not used [-Wunused-but-set-variable] > int mdr; > ^~~ > > Reported-by: Hulk Robot > Signed-off

Re: [PATCH] video: fbdev: matroxfb: remove dead code and set but not used variable

2020-04-08 Thread Sam Ravnborg
Hi Jason. On Fri, Apr 03, 2020 at 10:16:09AM +0800, Jason Yan wrote: > Fix the following gcc warning: > > drivers/video/fbdev/matrox/g450_pll.c:336:15: warning: variable > ‘pixel_vco’ set but not used [-Wunused-but-set-variable] > unsigned int pixel_vco; >^ > > Reported

Re: [PATCH] drm/vram-helpers: Merge code into a single file

2020-04-08 Thread Sam Ravnborg
Hi Thomas. On Tue, Mar 31, 2020 at 10:12:38AM +0200, Thomas Zimmermann wrote: > Most of the documentation was in an otherwise empty file, which was > probably just left from a previous clean-up effort. So move code and > documentation into a single file. > > Signed-off-by: Thomas Zimmermann Ni

Re: [PATCH 1/2] drm/panel: NT39016: Add support for multiple modes

2020-04-08 Thread Sam Ravnborg
On Wed, Apr 08, 2020 at 12:12:26PM +0200, Paul Cercueil wrote: > Hi Sam, > > > Le mer. 8 avril 2020 à 12:04, Sam Ravnborg a écrit : > > Hi Paul. > > > > On Wed, Apr 08, 2020 at 11:58:29AM +0200, Paul Cercueil wrote: > > > Add support for multiple drm_display_mode entries. This will allow > > >

Re: [PATCH/RFC 4/6] dt-bindings: display: rockchip: dw-hdmi: Convert binding to YAML

2020-04-08 Thread Laurent Pinchart
Hi Maxime, On Tue, Apr 07, 2020 at 09:12:51AM +0200, Maxime Ripard wrote: > On Mon, Apr 06, 2020 at 08:50:28PM +0300, Laurent Pinchart wrote: > > On Mon, Apr 06, 2020 at 07:09:15PM +0200, Maxime Ripard wrote: > > > On Mon, Apr 06, 2020 at 02:19:27PM +0300, Laurent Pinchart wrote: > > > > On Mon, A

[PATCH] drm/ttm: Temporarily disable the huge_fault() callback

2020-04-08 Thread VMware
From: "Thomas Hellstrom (VMware)" With amdgpu and CONFIG_TRANSPARENT_HUGEPAGE_ALWAYS=y, there are errors like: BUG: non-zero pgtables_bytes on freeing mm and: BUG: Bad rss-counter state with TTM transparent huge-pages. Until we've figured out what other TTM drivers do differently compared to vmwg

Re: [PATCH] drm/ttm: Temporarily disable the huge_fault() callback

2020-04-08 Thread VMware
Hi, Christian, On 4/8/20 1:53 PM, Thomas Hellström (VMware) wrote: From: "Thomas Hellstrom (VMware)" With amdgpu and CONFIG_TRANSPARENT_HUGEPAGE_ALWAYS=y, there are errors like: BUG: non-zero pgtables_bytes on freeing mm and: BUG: Bad rss-counter state with TTM transparent huge-pages. Until we

Re: [PATCH v2 2/3] gpu/drm: ingenic: Switch emulated fbdev to 16bpp

2020-04-08 Thread Daniel Vetter
On Wed, Feb 26, 2020 at 01:30:40AM -0300, Paul Cercueil wrote: > The fbdev emulation is only ever used on Ingenic SoCs to run old SDL1 > based games at 16bpp (rgb565). Recent applications generally talk to > DRM directly, and can request their favourite pixel format; so we can > make everybody happ

Re: [PATCH v2 3/3] gpu/drm: ingenic: Add option to mmap GEM buffers cached

2020-04-08 Thread Daniel Vetter
On Wed, Feb 26, 2020 at 01:30:41AM -0300, Paul Cercueil wrote: > Ingenic SoCs are most notably used in cheap chinese handheld gaming > consoles. There, the games and applications generally render in software > directly in the emulated framebuffer using SDL1. > > Since the emulated framebuffer is m

Re: [PATCH 02/44] drm: Add devm_drm_dev_alloc macro

2020-04-08 Thread Daniel Vetter
On Wed, Apr 08, 2020 at 08:57:14AM +0200, Sam Ravnborg wrote: > Hi Daniel. > > Finally managed to dive into this.. > > Maybe I need more coffee, it is still morning here. > But alas this patch triggered a few comments. > > Sam > > On Fri, Apr 03, 2020 at 03:57:46PM +0200, Daniel Vetter wr

Re: [PATCH 14/44] drm/v3d: Delete v3d_dev->pdev

2020-04-08 Thread Daniel Vetter
On Wed, Apr 08, 2020 at 09:27:01AM +0200, Sam Ravnborg wrote: > Hi Daniel. > > On Fri, Apr 03, 2020 at 03:57:58PM +0200, Daniel Vetter wrote: > > We already have it in v3d_dev->drm.dev with zero additional pointer > > chasing. Personally I don't like duplicated pointers like this > > because: > >

Re: [PATCH 00/44] devm_drm_dev_alloc, no more drmm_add_final_kfree

2020-04-08 Thread Daniel Vetter
On Wed, Apr 08, 2020 at 10:08:17AM +0200, Sam Ravnborg wrote: > Hi Daniel. > > Made specific reply to several patches. > > This bunch: > > drm/st7735r: Use devm_drm_dev_alloc > > drm/st7586: Use devm_drm_dev_alloc > > drm/repaper: Use devm_drm_dev_alloc > > drm/mi0283qt: Use devm_drm_dev_

Re: [PATCH] drm/ttm: Temporarily disable the huge_fault() callback

2020-04-08 Thread Christian König
Am 08.04.20 um 14:01 schrieb Thomas Hellström (VMware): Hi, Christian, On 4/8/20 1:53 PM, Thomas Hellström (VMware) wrote: From: "Thomas Hellstrom (VMware)" With amdgpu and CONFIG_TRANSPARENT_HUGEPAGE_ALWAYS=y, there are errors like: BUG: non-zero pgtables_bytes on freeing mm and: BUG: Bad rs

Re: [PATCH 17/28] mm: remove the prot argument from vm_map_ram

2020-04-08 Thread Peter Zijlstra
On Wed, Apr 08, 2020 at 01:59:15PM +0200, Christoph Hellwig wrote: > This is always GFP_KERNEL - for long term mappings with other properties > vmap should be used. PAGE_KERNEL != GFP_KERNEL :-) > - return vm_map_ram(mock->pages, mock->npages, 0, PAGE_KERNEL); > + return vm_map_ram(mock-

Re: [PATCH 19/28] gpu/drm: remove the powerpc hack in drm_legacy_sg_alloc

2020-04-08 Thread Daniel Vetter
On Wed, Apr 08, 2020 at 01:59:17PM +0200, Christoph Hellwig wrote: > If this code was broken for non-coherent caches a crude powerpc hack > isn't going to help anyone else. Remove the hack as it is the last > user of __vmalloc passing a page protection flag other than PAGE_KERNEL. Well Ben added

Re: decruft the vmalloc API

2020-04-08 Thread Peter Zijlstra
On Wed, Apr 08, 2020 at 01:58:58PM +0200, Christoph Hellwig wrote: > Hi all, > > Peter noticed that with some dumb luck you can toast the kernel address > space with exported vmalloc symbols. > > I used this as an opportunity to decruft the vmalloc.c API and make it > much more systematic. This

[PULL] topic/phy-compliance

2020-04-08 Thread Maarten Lankhorst
Hey, Here's a pull request to pull in the DP PHY Compliance series. It's based on top of drm/drm-next, and contains all patches for core, amd and i915. :) Cheers, Maarten topic/phy-compliance-2020-04-08: Topic pull request for topic/phy-compliance: - Standardize DP_PHY_TEST_PATTERN name. - Add

Re: [PATCH 0/2] powerpc: Remove support for ppc405/440 Xilinx platforms

2020-04-08 Thread Arnd Bergmann
+On Wed, Apr 8, 2020 at 2:04 PM Michael Ellerman wrote: > Benjamin Herrenschmidt writes: > > On Fri, 2020-04-03 at 15:59 +1100, Michael Ellerman wrote: > >> Benjamin Herrenschmidt writes: > > IBM still put 40x cores inside POWER chips no ? > > Oh yeah that's true. I guess most folks don't know t

Re: [PATCH 02/28] staging: android: ion: use vmap instead of vm_map_ram

2020-04-08 Thread Greg KH
On Wed, Apr 08, 2020 at 01:59:00PM +0200, Christoph Hellwig wrote: > vm_map_ram can keep mappings around after the vm_unmap_ram. Using that > with non-PAGE_KERNEL mappings can lead to all kinds of aliasing issues. > > Signed-off-by: Christoph Hellwig Acked-by: Greg Kroah-Hartman __

Re: [PATCH v3 1/5] drm: Introduce plane and CRTC scaling filter properties

2020-04-08 Thread Ville Syrjälä
On Wed, Apr 08, 2020 at 03:17:27PM +0530, Bharadiya,Pankaj wrote: > On Tue, Apr 07, 2020 at 08:28:02PM +0300, Ville Syrjälä wrote: > > On Tue, Mar 31, 2020 at 12:08:53AM +0530, Pankaj Bharadiya wrote: > > > Introduce per-plane and per-CRTC scaling filter properties to allow > > > userspace to selec

Re: [PATCH 27/28] s390: use __vmalloc_node in alloc_vm_stack

2020-04-08 Thread Christian Borntraeger
On 08.04.20 13:59, Christoph Hellwig wrote: > alloc_vm_stack can use a slightly higher level vmalloc function. > > Signed-off-by: Christoph Hellwig > --- > arch/powerpc/kernel/irq.c | 5 ++--- wrong subject (power vs s390) > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/arc

Re: [PATCH] amdgpu_kms: Remove unnecessary condition check

2020-04-08 Thread Alex Deucher
On Tue, Apr 7, 2020 at 2:30 PM Aurabindo Pillai wrote: > > Execution will only reach here if the asserted condition is true. > Hence there is no need for the additional check. > > Signed-off-by: Aurabindo Pillai Applied. Thanks! Alex > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 10 -

[PATCH 09/21] drm/msm/dpu: Use OPP API to set clk/perf state

2020-04-08 Thread Rajendra Nayak
On some qualcomm platforms DPU needs to express a perforamnce state requirement on a power domain depending on the clock rates. Use OPP table from DT to register with OPP framework and use dev_pm_opp_set_rate() to set the clk/perf state. Signed-off-by: Rajendra Nayak Cc: Rob Clark Cc: Sean Paul

[PATCH 10/21] drm/msm: dsi: Use OPP API to set clk/perf state

2020-04-08 Thread Rajendra Nayak
On SDM845 DSI needs to express a perforamnce state requirement on a power domain depending on the clock rates. Use OPP table from DT to register with OPP framework and use dev_pm_opp_set_rate() to set the clk/perf state. Signed-off-by: Rajendra Nayak Cc: Rob Clark Cc: Sean Paul Cc: dri-devel@li

Re: [PATCH] drm/ttm: Temporarily disable the huge_fault() callback

2020-04-08 Thread VMware
On 4/8/20 2:19 PM, Christian König wrote: Am 08.04.20 um 14:01 schrieb Thomas Hellström (VMware): Hi, Christian, On 4/8/20 1:53 PM, Thomas Hellström (VMware) wrote: From: "Thomas Hellstrom (VMware)" With amdgpu and CONFIG_TRANSPARENT_HUGEPAGE_ALWAYS=y, there are errors like: BUG: non-zero pg

Re: [PATCH 00/15] amdgpu: remove load and unload callbacks (v3)

2020-04-08 Thread Alex Deucher
On Wed, Apr 8, 2020 at 3:38 AM Thomas Zimmermann wrote: > > Hi Alex > > Am 07.02.20 um 20:50 schrieb Alex Deucher: > > These are deprecated and the drm will soon start warning when drivers still > > use them. It was a long and twisty road, but seems to work. > > Are you going to convert radeon as

Re: [PATCH v2] drm/ttm: clean up ttm_trace_dma_map/ttm_trace_dma_unmap (v2)

2020-04-08 Thread Alex Deucher
On Tue, Apr 7, 2020 at 5:50 AM Christian König wrote: > > Am 07.04.20 um 11:12 schrieb Huang Rui: > > ttm_trace_dma_map/ttm_trace_dma_unmap is never used anymore. > > > > v2: remove the file completely > > > > Signed-off-by: Huang Rui > > Reviewed-by: Christian König > Can one of you make sure

Re: [PATCH/RFC 4/6] dt-bindings: display: rockchip: dw-hdmi: Convert binding to YAML

2020-04-08 Thread Laurent Pinchart
Hi Maxime, On Wed, Apr 08, 2020 at 02:25:19PM +0200, Maxime Ripard wrote: > On Wed, Apr 08, 2020 at 02:45:52PM +0300, Laurent Pinchart wrote: > > On Tue, Apr 07, 2020 at 09:12:51AM +0200, Maxime Ripard wrote: > >> On Mon, Apr 06, 2020 at 08:50:28PM +0300, Laurent Pinchart wrote: > >>> On Mon, Apr

Re: [Intel-gfx] [PATCH] drm: avoid spurious EBUSY due to nonblocking atomic modesets

2020-04-08 Thread Ville Syrjälä
On Tue, Feb 25, 2020 at 05:34:00PM +0200, Ville Syrjälä wrote: > On Tue, Feb 25, 2020 at 04:09:26PM +0100, Daniel Vetter wrote: > > On Tue, Feb 25, 2020 at 3:48 PM Ville Syrjälä > > wrote: > > > > > > On Tue, Feb 25, 2020 at 12:50:24PM +0100, Daniel Vetter wrote: > > > > When doing an atomic modes

Re: [PATCH] drm/ttm: Temporarily disable the huge_fault() callback

2020-04-08 Thread Christian König
Am 08.04.20 um 15:49 schrieb Thomas Hellström (VMware): On 4/8/20 2:19 PM, Christian König wrote: Am 08.04.20 um 14:01 schrieb Thomas Hellström (VMware): Hi, Christian, On 4/8/20 1:53 PM, Thomas Hellström (VMware) wrote: From: "Thomas Hellstrom (VMware)" With amdgpu and CONFIG_TRANSPARENT_H

Re: [PATCH 28/28] s390: use __vmalloc_node in stack_alloc

2020-04-08 Thread Christian Borntraeger
On 08.04.20 13:59, Christoph Hellwig wrote: > stack_alloc can use a slightly higher level vmalloc function. > > Signed-off-by: Christoph Hellwig > --- > arch/s390/kernel/setup.c | 9 +++-- > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/arch/s390/kernel/setup.c b/arch/

Re: [PATCH v2] drm/ttm: clean up ttm_trace_dma_map/ttm_trace_dma_unmap (v2)

2020-04-08 Thread Christian König
Am 08.04.20 um 16:00 schrieb Alex Deucher: On Tue, Apr 7, 2020 at 5:50 AM Christian König wrote: Am 07.04.20 um 11:12 schrieb Huang Rui: ttm_trace_dma_map/ttm_trace_dma_unmap is never used anymore. v2: remove the file completely Signed-off-by: Huang Rui Reviewed-by: Christian König Can

[Bug 204611] amdgpu error scheduling IBs when waking from sleep

2020-04-08 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=204611 Vic Luo (viclu...@gmail.com) changed: What|Removed |Added CC||viclu...@gmail.com --- Com

Re: [PATCH 10/28] mm: only allow page table mappings for built-in zsmalloc

2020-04-08 Thread Peter Zijlstra
On Wed, Apr 08, 2020 at 08:01:00AM -0700, Randy Dunlap wrote: > Hi, > > On 4/8/20 4:59 AM, Christoph Hellwig wrote: > > diff --git a/mm/Kconfig b/mm/Kconfig > > index 36949a9425b8..614cc786b519 100644 > > --- a/mm/Kconfig > > +++ b/mm/Kconfig > > @@ -702,7 +702,7 @@ config ZSMALLOC > > > > conf

Re: [Intel-gfx] [PATCH] drm: avoid spurious EBUSY due to nonblocking atomic modesets

2020-04-08 Thread Daniel Vetter
On Wed, Apr 8, 2020 at 4:03 PM Ville Syrjälä wrote: > > On Tue, Feb 25, 2020 at 05:34:00PM +0200, Ville Syrjälä wrote: > > On Tue, Feb 25, 2020 at 04:09:26PM +0100, Daniel Vetter wrote: > > > On Tue, Feb 25, 2020 at 3:48 PM Ville Syrjälä > > > wrote: > > > > > > > > On Tue, Feb 25, 2020 at 12:50:

Re: [PATCH] drm/amd/amdgpu: add prefix for pr_* prints

2020-04-08 Thread Joe Perches
On Wed, 2020-04-08 at 09:37 -0400, Aurabindo Pillai wrote: > amdgpu uses lots of pr_* calls for printing error messages. > With this prefix, errors shall be more obvious to the end > use regarding its origin, and may help debugging. > > Prefix format: > > [xxx.x] amdgpu: ... [] > diff --git a

[PATCH 00/35] Documentation fixes for Kernel 5.8

2020-04-08 Thread Mauro Carvalho Chehab
Hi Jon, I have a large list of patches this time for the Documentation/. So, I'm starting sending them a little earier. Yet, those are meant to be applied after the end of the merge window. They're based on today's linux-next, with has only 49 patches pending to be applied upstream touching Docume

[PATCH 03/35] docs: fix broken references to text files

2020-04-08 Thread Mauro Carvalho Chehab
Several references got broken due to txt to ReST conversion. Several of them can be automatically fixed with: scripts/documentation-file-ref-check --fix Reviewed-by: Mathieu Poirier # hwtracing/coresight/Kconfig Signed-off-by: Mauro Carvalho Chehab --- Documentation/memory-barriers.t

[PATCH 05/35] docs: filesystems: fix renamed references

2020-04-08 Thread Mauro Carvalho Chehab
Some filesystem references got broken by a previous patch series I submitted. Address those. Signed-off-by: Mauro Carvalho Chehab --- Documentation/ABI/stable/sysfs-devices-node | 2 +- Documentation/ABI/testing/procfs-smaps_rollup | 2 +- Documentation/admin-guide/

Re: decruft the vmalloc API

2020-04-08 Thread Russell King - ARM Linux admin
On Wed, Apr 08, 2020 at 01:58:58PM +0200, Christoph Hellwig wrote: > Hi all, > > Peter noticed that with some dumb luck you can toast the kernel address > space with exported vmalloc symbols. > > I used this as an opportunity to decruft the vmalloc.c API and make it > much more systematic. This

[PATCH v4 3/5] drm/i915: Introduce scaling filter related registers and bit fields.

2020-04-08 Thread Pankaj Bharadiya
Introduce scaler registers and bit fields needed to configure the scaling filter in prgrammed mode and configure scaling filter coefficients. changes since v3: * None changes since v2: * Change macro names to CNL_* and use +(set)*8 instead of adding another trip through _PICK_EVEN (Ville). chan

[PATCH v4 2/5] drm/drm-kms.rst: Add plane and CRTC scaling filter property documentation

2020-04-08 Thread Pankaj Bharadiya
Add documentation for newly introduced KMS plane and CRTC scaling filter properties. changes since v3: * None changes since v1: * None changes since RFC: * Add separate documentation for plane and CRTC. Signed-off-by: Pankaj Bharadiya --- Documentation/gpu/drm-kms.rst | 12 1 file

  1   2   >