Re: [PATCH 1/2] drm/ttm: clean up ttm_trace_dma_map/ttm_trace_dma_unmap

2020-04-07 Thread Christian König
Am 07.04.20 um 08:44 schrieb Huang Rui: ttm_trace_dma_map/ttm_trace_dma_unmap is never used anymore. Move the pr_fmt prefix into this header. Signed-off-by: Huang Rui --- include/drm/ttm/ttm_debug.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/drm/ttm/ttm_d

Re: [PATCH 30/44] drm/qxl: Use devm_drm_dev_alloc

2020-04-07 Thread Daniel Vetter
On Mon, Apr 6, 2020 at 7:29 PM Thomas Zimmermann wrote: > > > > Am 03.04.20 um 15:58 schrieb Daniel Vetter: > > Also need to remove the drm_dev_put from the remove hook. > > > > Signed-off-by: Daniel Vetter > > Cc: Dave Airlie > > Cc: Gerd Hoffmann > > Cc: virtualizat...@lists.linux-foundation.

Re: [PATCH 00/10] Set up generic fbdev after registering device

2020-04-07 Thread Gerd Hoffmann
On Mon, Apr 06, 2020 at 03:43:55PM +0200, Thomas Zimmermann wrote: > Generic fbdev emulation is a DRM client. If possible, it should behave > like userspace clients. Therefore it should not run before the driver > registered the new DRM device. If the setup function fails, the driver > should not r

Re: [PATCH 00/10] Set up generic fbdev after registering device

2020-04-07 Thread Jani Nikula
On Tue, 07 Apr 2020, Thomas Zimmermann wrote: > Hi Sam > > Am 06.04.20 um 22:00 schrieb Sam Ravnborg: >> Hi Thomas. >> >> On Mon, Apr 06, 2020 at 03:43:55PM +0200, Thomas Zimmermann wrote: >>> Generic fbdev emulation is a DRM client. If possible, it should behave >>> like userspace clients. There

Re: [PATCH 08/44] drm/vboxvideo: Stop using drm_device->dev_private

2020-04-07 Thread Daniel Vetter
On Mon, Apr 6, 2020 at 7:27 PM Thomas Zimmermann wrote: > > Hi > > Am 03.04.20 um 15:57 schrieb Daniel Vetter: > > We use the baseclass pattern here, so lets to the proper (and more > > typesafe) upcasting. > > > > Signed-off-by: Daniel Vetter > > Cc: Hans de Goede > > --- > > drivers/gpu/drm/v

Re: [PATCH v2 12/17] drm/mcde: Use mode->clock instead of reverse calculating it from the vrefresh

2020-04-07 Thread Daniel Vetter
On Fri, Apr 03, 2020 at 11:40:03PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > htotal*vtotal*vrefresh ~= clock. So just say "clock" when we mean it. Glorious. Reviewed-by: Daniel Vetter > > Cc: Linus Walleij > Cc: Sam Ravnborg > Signed-off-by: Ville Syrjälä > --- > drivers/gpu/

Re: [PATCH v2 13/17] drm/i915: Stop using mode->private_flags

2020-04-07 Thread Daniel Vetter
On Fri, Apr 03, 2020 at 11:40:04PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Replace the use of mode->private_flags with a truly private bitmaks > in our own crtc state. We also need a copy in the crtc itself so the > vblank code can get at it. We already have scanline_offset in there

Re: [PATCH v2 14/17] drm/i915: Replace I915_MODE_FLAG_INHERITED with a boolean

2020-04-07 Thread Daniel Vetter
On Fri, Apr 03, 2020 at 11:40:05PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > There's no reason for I915_MODE_FLAG_INHERITED to exist as a flag > anymore. Just make it a boolean. > > CC: Sam Ravnborg > Cc: Daniel Vetter > Cc: Emil Velikov > Signed-off-by: Ville Syrjälä Reviewed-b

Re: [PATCH v2 15/17] drm/gma500: Stop using mode->private_flags

2020-04-07 Thread Daniel Vetter
On Fri, Apr 03, 2020 at 11:40:06PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > gma500 only uses mode->private_flags to convey the sdvo pixel > multiplier from the encoder .mode_fixup() hook to the encoder > .mode_set() hook. Those always seems get called as a pair so > let's just stuff

Re: [PATCH] drm: plane: Verify that no or all planes have a zpos property

2020-04-07 Thread Daniel Vetter
On Sat, Apr 04, 2020 at 09:12:53PM +0300, Laurent Pinchart wrote: > The zpos property is used by userspace to sort the order of planes. > While the property is not mandatory for drivers to implement, mixing > planes with and without zpos confuses userspace, and shall not be > allowed. Clarify this

Re: Curtaining API / Force blanking displays

2020-04-07 Thread Daniel Vetter
On Sun, Apr 05, 2020 at 11:21:31AM +0300, Pekka Paalanen wrote: > On Fri, 3 Apr 2020 12:56:33 -0700 > Erik Jensen wrote: > > > First off, apologies if the functionality described already exists and I > > just failed to find it, or if this isn't the correct venue for this > > discussion. If so, po

Re: Curtaining API / Force blanking displays

2020-04-07 Thread Daniel Stone
Hi Erik, On Mon, 6 Apr 2020 at 20:01, Erik Jensen wrote: > > Screen scraping like that will have big problems trying to a) > > synchronize to the display updates correctly (was the screen > > updated, did you get old or new frame, and you have to poll rather > > than be notified), and b) synchron

Re: [PATCH v5 19/25] drm: kirin: Add register connect helper functions in drm init

2020-04-07 Thread Daniel Vetter
On Wed, Aug 21, 2019 at 1:06 AM John Stultz wrote: > > From: Xu YiPing > > As part of refactoring the kirin driver to better support > different hardware revisions, this patch adds a flag to the > device specific driver data so that we can conditionally > register the connectors at init. > > Cc:

Re: [PATCH 03/10] drm/kirin: Set up fbdev after fully registering device

2020-04-07 Thread Daniel Vetter
On Mon, Apr 06, 2020 at 03:43:58PM +0200, Thomas Zimmermann wrote: > Generic fbdev support is a DRM client. Set it up after fully registering > the new DRM device. > > Signed-off-by: Thomas Zimmermann > --- > drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c | 4 ++-- > 1 file changed, 2 insertion

Re: [PATCH 1/2] drm/ttm: clean up ttm_trace_dma_map/ttm_trace_dma_unmap

2020-04-07 Thread Huang Rui
On Tue, Apr 07, 2020 at 03:06:01PM +0800, Koenig, Christian wrote: > Am 07.04.20 um 08:44 schrieb Huang Rui: > > ttm_trace_dma_map/ttm_trace_dma_unmap is never used anymore. Move the pr_fmt > > prefix into this header. > > > > Signed-off-by: Huang Rui > > --- > > include/drm/ttm/ttm_debug.h | 4

Re: [PATCH v2 3/3] drm/writeback: wire drm_writeback.h to kernel-doc

2020-04-07 Thread Daniel Vetter
On Mon, Apr 06, 2020 at 09:47:46PM +0200, Sam Ravnborg wrote: > drm_writeback.h included a lot of nice kernel-doc comments. > Wire it up so the header file is included in the kernel-doc > generated documentation. > > Added a few simple comments to the two structs so they > get picked up by kernel-

Re: [PATCH v5 2/5] OPP: refactor dev_pm_opp_of_register_em() and update related drivers

2020-04-07 Thread Lukasz Luba
Hi Daniel, Thank you for your comments. On 4/3/20 5:21 PM, Daniel Lezcano wrote: On 18/03/2020 12:45, Lukasz Luba wrote: The Energy Model framework supports both: CPUs and devfreq devices. Drop the CPU specific interface with cpumask and add struct device. Add also a return value. This new int

Re: [PATCH] drm/sun4i: tcon: Delete an error message in sun4i_tcon_init_irq()

2020-04-07 Thread Maxime Ripard
On Sun, Apr 05, 2020 at 01:53:05PM +0200, Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 5 Apr 2020 13:45:53 +0200 > > The function “platform_get_irq” can log an error already. > Thus omit a redundant message for the exception handling in the > calling function. > > This issue was detec

Re: [PATCH/RFC 4/6] dt-bindings: display: rockchip: dw-hdmi: Convert binding to YAML

2020-04-07 Thread Maxime Ripard
Hi, On Mon, Apr 06, 2020 at 02:39:33AM +0300, Laurent Pinchart wrote: > Convert the Rockchip HDMI TX text binding to YAML. > > Signed-off-by: Laurent Pinchart > --- > .../display/rockchip/dw_hdmi-rockchip.txt | 74 > .../display/rockchip/rockchip,dw-hdmi.yaml| 178 +

Re: [PATCH/RFC 4/6] dt-bindings: display: rockchip: dw-hdmi: Convert binding to YAML

2020-04-07 Thread Maxime Ripard
On Mon, Apr 06, 2020 at 02:19:27PM +0300, Laurent Pinchart wrote: > Hi Maxime, > > On Mon, Apr 06, 2020 at 10:00:32AM +0200, Maxime Ripard wrote: > > On Mon, Apr 06, 2020 at 02:39:33AM +0300, Laurent Pinchart wrote: > > > Convert the Rockchip HDMI TX text binding to YAML. > > > > > > Signed-off-by:

Re: [PATCH v2] drm/bridge: dw-mipi-dsi.c: Add VPG runtime config through debugfs

2020-04-07 Thread Adrian Pop
Hello Angelo, Tested OK on STM32F769i-DISCO, DSI v1.30, on next-20200406. I guess there is no horizontal for BER. Regards, Adrian On Mon, Apr 6, 2020 at 4:49 PM Angelo Ribeiro wrote: > > Add support for the video pattern generator (VPG) BER pattern mode and > configuration in runtime. > > This

Re: [PATCH v5 1/8] dt-bindings: add img, pvrsgx.yaml for Imagination GPUs

2020-04-07 Thread H. Nikolaus Schaller
> Am 29.03.2020 um 19:38 schrieb H. Nikolaus Schaller : > > The Imagination PVR/SGX GPU is part of several SoC from > multiple vendors, e.g. TI OMAP, Ingenic JZ4780, Intel Poulsbo, > Allwinner A83 and others. > > With this binding, we describe how the SGX processor is > interfaced to the SoC (r

Re: [PATCH v5 1/5] PM / EM: add devices to Energy Model

2020-04-07 Thread Lukasz Luba
On 4/6/20 3:58 PM, Daniel Lezcano wrote: Hi Lukasz, On 06/04/2020 15:29, Lukasz Luba wrote: Hi Daniel, Thank you for the review. On 4/3/20 5:05 PM, Daniel Lezcano wrote: Hi Lukasz, On 18/03/2020 12:45, Lukasz Luba wrote: Add support of other devices into the Energy Model framework no

[PATCH v2 0/4] drm: Add support for IPK DSI Host Driver

2020-04-07 Thread Angelo Ribeiro
This patch series adds support for the display subsystem in the Synopsys DesignWare IPK devices. The display pipeline is limited and does not have access to memory, the validation is done using a VPG (Video Pattern Generator), as DPI stimulus for the DW MIPI DSI Host. A Synopsys DesignWare MIPI D

Re: [PATCH] drm: mediatek: fix device passed to cmdq

2020-04-07 Thread Enric Balletbo i Serra
Hi Hsin-Yi Thanks for sending the patch upstream On 6/4/20 7:11, Hsin-Yi Wang wrote: > drm device is now probed from mmsys. We need to use mmsys device to get gce > nodes. Fix following errors: > > [0.740068] mediatek-drm mediatek-drm.1.auto: error -2 can't parse > gce-client-reg property (

Re: [PATCH] drm/i915: Force DPCD backlight mode for HP Spectre x360 Convertible 13t-aw100

2020-04-07 Thread Kai-Heng Feng
> On Mar 27, 2020, at 19:03, Kai-Heng Feng wrote: > > Hi, > >> On Mar 23, 2020, at 13:35, Kai-Heng Feng wrote: >> >> There's another OLED panel needs to use DPCD aux interface to control >> backlight. >> >> BugLink: https://bugs.launchpad.net/bugs/1860303 >> Signed-off-by: Kai-Heng Feng >

Re: [PATCH/RFC 2/6] dt-bindings: display: bridge: renesas,dw-hdmi: Convert binding to YAML

2020-04-07 Thread Maxime Ripard
On Mon, Apr 06, 2020 at 02:32:47PM +0300, Laurent Pinchart wrote: > > > > + > > > > + clock-names: > > > > +items: > > > > + - const: iahb > > > > + - const: isfr > > > > + > > > > + interrupts: true > > > > + > > > > + ports: > > > > +type: object > > > > +description: | >

Re: [PATCH 4/4] dt-bindings: display: bridge: renesas,lvds: Convert binding to YAML

2020-04-07 Thread Maxime Ripard
On Mon, Apr 06, 2020 at 02:23:18AM +0300, Laurent Pinchart wrote: > Convert the Renesas R-Car LVDS encoder text binding to YAML. > > Signed-off-by: Laurent Pinchart Acked-by: Maxime Ripard Maxime signature.asc Description: PGP signature ___ dri-deve

Re: [PATCH v2] drm/bridge: dw-mipi-dsi.c: Add VPG runtime config through debugfs

2020-04-07 Thread Adrian Pop
Tested-by: Adrian Pop Tested OK on STM32F769i-DISCO, DSI v1.30, on next-20200406. On Mon, Apr 6, 2020 at 8:45 PM Adrian Pop wrote: > > Hello Angelo, > > Tested OK on STM32F769i-DISCO, DSI v1.30, on next-20200406. I guess > there is no horizontal for BER. > > Regards, > Adrian > > On Mon, Apr 6,

[PATCH v2] drm/bridge: dw-mipi-dsi.c: Add VPG runtime config through debugfs

2020-04-07 Thread Angelo Ribeiro
Add support for the video pattern generator (VPG) BER pattern mode and configuration in runtime. This enables using the debugfs interface to manipulate the VPG after the pipeline is set. Also, enables the usage of the VPG BER pattern. Changes in v2: - Added VID_MODE_VPG_MODE - Solved incompat

Re: [PATCH v5 1/5] PM / EM: add devices to Energy Model

2020-04-07 Thread Daniel Lezcano
On 06/04/2020 18:07, Lukasz Luba wrote: > > > On 4/6/20 3:58 PM, Daniel Lezcano wrote: >> >> Hi Lukasz, >> >> >> On 06/04/2020 15:29, Lukasz Luba wrote: >>> Hi Daniel, >>> >>> Thank you for the review. >>> >>> On 4/3/20 5:05 PM, Daniel Lezcano wrote: Hi Lukasz, On 18/03/2

Re: [PATCH 3/4] dt-bindings: display: bridge: thc63lvd1024: Convert binding to YAML

2020-04-07 Thread Maxime Ripard
On Mon, Apr 06, 2020 at 02:23:17AM +0300, Laurent Pinchart wrote: > Convert the Thine THC63LVD1024 text binding to YAML. > > Signed-off-by: Laurent Pinchart Acked-by: Maxime Ripard Maxime signature.asc Description: PGP signature ___ dri-devel mailin

Re: [PATCH/RFC 2/6] dt-bindings: display: bridge: renesas,dw-hdmi: Convert binding to YAML

2020-04-07 Thread Maxime Ripard
On Mon, Apr 06, 2020 at 02:28:56PM +0300, Laurent Pinchart wrote: > > > + > > > + clock-names: > > > +items: > > > + - const: iahb > > > + - const: isfr > > > + > > > + interrupts: true > > > + > > > + ports: > > > +type: object > > > +description: | > > > + This devic

Re: [PATCH/RFC 2/6] dt-bindings: display: bridge: renesas,dw-hdmi: Convert binding to YAML

2020-04-07 Thread Maxime Ripard
Hi, On Mon, Apr 06, 2020 at 02:39:31AM +0300, Laurent Pinchart wrote: > diff --git > a/Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.yaml > b/Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.yaml > new file mode 100644 > index ..9a543740c81d > --- /

[PATCH v2 3/4] drm: ipk: Add extensions for DW MIPI DSI Host driver

2020-04-07 Thread Angelo Ribeiro
Add Synopsys DesignWare IPK specific extensions for Synopsys DesignWare MIPI DSI Host driver. Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: David Airlie Cc: Daniel Vetter Cc: Gustavo Pimentel Cc: Joao Pinto Signed-off-by: Angelo Ribeiro --- drivers/gpu/drm/ipk/Kconfig | 9 + driv

Re: [PATCH v5 1/5] PM / EM: add devices to Energy Model

2020-04-07 Thread Daniel Lezcano
Hi Lukasz, On 06/04/2020 15:29, Lukasz Luba wrote: > Hi Daniel, > > Thank you for the review. > > On 4/3/20 5:05 PM, Daniel Lezcano wrote: >> >> Hi Lukasz, >> >> >> On 18/03/2020 12:45, Lukasz Luba wrote: >>> Add support of other devices into the Energy Model framework not only >>> the >>> CPU

Re: [PATCH 04/10] drm/ingenic: Remove error check from fbdev setup

2020-04-07 Thread Paul Cercueil
Hi Thomas, Le lun. 6 avril 2020 à 15:43, Thomas Zimmermann a écrit : Remove the error check from the fbdev setup function. The function will print a warning. Signed-off-by: Thomas Zimmermann Reviewed-by: Paul Cercueil --- drivers/gpu/drm/ingenic/ingenic-drm.c | 4 +--- 1 file changed,

[PATCH v2 1/4] dt-bindings: display: Add IPK DSI subsystem bindings

2020-04-07 Thread Angelo Ribeiro
Add dt-bindings for Synopsys DesignWare MIPI DSI Host and VPG (Video Pattern Generator) support in the IPK display subsystem. The Synopsys DesignWare IPK display video pipeline is composed by a DSI controller (snps,dw-ipk-dsi) and a VPG (snps,dw-ipk-vpg) as DPI stimulus. Typically is used the Rasp

[PATCH v2 4/4] MAINTAINERS: Add IPK MIPI DSI Host driver entry

2020-04-07 Thread Angelo Ribeiro
Creates entry for Synopsys DesignWare IPK MIPI DSI host driver and adds myself as maintainer. Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: David Airlie Cc: Daniel Vetter Cc: Gustavo Pimentel Cc: Joao Pinto Signed-off-by: Angelo Ribeiro --- MAINTAINERS | 8 1 file changed, 8 inserti

Re: [PATCH/RFC 1/6] dt-bindings: display: bridge: Add YAML schema for Synopsys DW-HDMI

2020-04-07 Thread Maxime Ripard
Hi, On Mon, Apr 06, 2020 at 02:39:30AM +0300, Laurent Pinchart wrote: > Add a .yaml schema containing the common properties for the Synopsys > DesignWare HDMI TX controller. This isn't a full device tree binding > specification, but is meant to be referenced by platform-specific > bindings for the

Re: [PATCH 1/4] dt-bindings: display: bridge: Reject additional properties in ports node

2020-04-07 Thread Maxime Ripard
On Mon, Apr 06, 2020 at 02:23:15AM +0300, Laurent Pinchart wrote: > Document the #address-cells and #size-cells properties of the ports node > in the schemas of the bridge DT bindings, and set additionalProperties > to false to reject additional properties. > > Signed-off-by: Laurent Pinchart Ack

Re: [PATCH] video: fbdev: don't print error message on platform_get_irq() failure

2020-04-07 Thread Nicolas Ferre
On 06/04/2020 at 07:34, Tang Bin wrote: The platform_get_irq() can print error message,so remove the redundant dev_err() here. Signed-off-by: Tang Bin Acked-by: Nicolas Ferre --- drivers/video/fbdev/atmel_lcdfb.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/video/fbdev/atme

Re: [PATCH v5 1/5] PM / EM: add devices to Energy Model

2020-04-07 Thread Lukasz Luba
Hi Daniel, Thank you for the review. On 4/3/20 5:05 PM, Daniel Lezcano wrote: Hi Lukasz, On 18/03/2020 12:45, Lukasz Luba wrote: Add support of other devices into the Energy Model framework not only the CPUs. Change the interface to be more unified which can handle other devices as well.

Re: [PATCH v5 4/5] thermal: devfreq_cooling: Refactor code and switch to use Energy Model

2020-04-07 Thread Lukasz Luba
On 4/3/20 6:44 PM, Daniel Lezcano wrote: On 18/03/2020 12:45, Lukasz Luba wrote: The overhauled Energy Model (EM) framework support also devfreq devices. The unified API interface of the EM can be used in the thermal subsystem to not duplicate code. The power table now is taken from EM struct

[PATCH v2 2/4] drm: ipk: Add DRM driver for DesignWare IPK DSI

2020-04-07 Thread Angelo Ribeiro
Add support for Synopsys DesignWare VPG (Video Pattern Generator) and DRM driver for Synopsys DesignWare DSI Host IPK solution. Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: David Airlie Cc: Daniel Vetter Cc: Gustavo Pimentel Cc: Joao Pinto Signed-off-by: Angelo Ribeiro --- drivers/gpu/drm/K

Re: [PATCH 2/4] dt-bindings: display: bridge: Convert simple-bridge bindings to YAML

2020-04-07 Thread Maxime Ripard
On Mon, Apr 06, 2020 at 02:23:16AM +0300, Laurent Pinchart wrote: > The simple-bridge driver supports multiple simple or dumb bridges, > covered by different compatible strings but otherwise identical DT > bindings. Some of those bridges have undocumented bindings, while others > are documented in

RE: [PATCH] drm/bridge: dw-mipi-dsi.c: Add VPG runtime config through debugfs

2020-04-07 Thread Angelo Ribeiro
Hi Adrian, You are right! Thanks for the help, Angelo Ribeiro From: Adrian Pop Date: Sat, Apr 04, 2020 at 11:56:11 > Hello Angelo, > > I get a compile error: error: ‘VID_MODE_VPG_MODE’ undeclared. I am > quite new to the mailing list, maybe I misapplied the patch. > > Regards, > Adrian > >

Re: [PATCH/RFC 4/6] dt-bindings: display: rockchip: dw-hdmi: Convert binding to YAML

2020-04-07 Thread Maxime Ripard
On Mon, Apr 06, 2020 at 08:50:28PM +0300, Laurent Pinchart wrote: > Hi Maxime, > > On Mon, Apr 06, 2020 at 07:09:15PM +0200, Maxime Ripard wrote: > > On Mon, Apr 06, 2020 at 02:19:27PM +0300, Laurent Pinchart wrote: > > > On Mon, Apr 06, 2020 at 10:00:32AM +0200, Maxime Ripard wrote: > > > > On Mon

Re: [PATCH v2 2/4] drm: ipk: Add DRM driver for DesignWare IPK DSI

2020-04-07 Thread Daniel Vetter
On Mon, Apr 06, 2020 at 03:24:12PM +0200, Angelo Ribeiro wrote: > Add support for Synopsys DesignWare VPG (Video Pattern Generator) and > DRM driver for Synopsys DesignWare DSI Host IPK solution. > > Cc: Maarten Lankhorst > Cc: Maxime Ripard > Cc: David Airlie > Cc: Daniel Vetter > Cc: Gustavo

Re: KMS enums and bitfields UAPI

2020-04-07 Thread Daniel Stone
Hi, On Fri, 3 Apr 2020 at 13:24, Pekka Paalanen wrote: > On Fri, 03 Apr 2020 10:15:21 + Simon Ser wrote: > > At the very least, having a clear policy for both kernel public headers and > > user-space would help a lot. Right now it's unclear for both parties what > > to do > > regarding enum

Re: Curtaining API / Force blanking displays

2020-04-07 Thread Pekka Paalanen
On Mon, 6 Apr 2020 12:01:30 -0700 Erik Jensen wrote: > Thanks for the reply! (And thanks Simon for the pointer to ffmpeg.) > > > Screen scraping like that will have big problems trying to a) > > synchronize to the display updates correctly (was the screen > > updated, did you get old or new fram

Bad rss-counter state from drm/ttm, drm/vmwgfx: Support huge TTM pagefaults

2020-04-07 Thread Alex Xu (Hello71)
Using 314b658 with amdgpu, starting sway and firefox causes "BUG: Bad rss-counter state" and "BUG: non-zero pgtables_bytes on freeing mm" to start filling dmesg, and then closing programs causes more BUGs and hangs, and then everything grinds to a halt (can't start more programs, can't even reb

Re: Bad rss-counter state from drm/ttm, drm/vmwgfx: Support huge TTM pagefaults

2020-04-07 Thread Alex Xu (Hello71)
Excerpts from Thomas Hellström (VMware)'s message of April 6, 2020 5:04 pm: > Hi, > > On 4/6/20 9:51 PM, Alex Xu (Hello71) wrote: >> Using 314b658 with amdgpu, starting sway and firefox causes "BUG: Bad >> rss-counter state" and "BUG: non-zero pgtables_bytes on freeing mm" to >> start filling dmes

Re: [PATCH] Make the "Reducing compressed framebufer size" message be DRM_INFO_ONCE()

2020-04-07 Thread Jiri Slaby
On 06. 07. 18, 22:30, Rodrigo Vivi wrote: > On Fri, Jul 06, 2018 at 03:04:24PM -0400, Peter Jones wrote: >> This was sort of annoying me: >> >> random:~$ dmesg | tail -1 >> [523884.039227] [drm] Reducing the compressed framebuffer size. This may >> lead to less power savings than a non-reduced-siz

[PATCH v2] drm/ttm: clean up ttm_trace_dma_map/ttm_trace_dma_unmap (v2)

2020-04-07 Thread Huang Rui
ttm_trace_dma_map/ttm_trace_dma_unmap is never used anymore. v2: remove the file completely Signed-off-by: Huang Rui --- include/drm/ttm/ttm_debug.h | 31 --- 1 file changed, 31 deletions(-) delete mode 100644 include/drm/ttm/ttm_debug.h diff --git a/include/drm/tt

Re: KMS enums and bitfields UAPI

2020-04-07 Thread Daniel Vetter
On Tue, Apr 7, 2020 at 10:19 AM Daniel Stone wrote: > > Hi, > > On Fri, 3 Apr 2020 at 13:24, Pekka Paalanen wrote: > > On Fri, 03 Apr 2020 10:15:21 + Simon Ser wrote: > > > At the very least, having a clear policy for both kernel public headers > > > and > > > user-space would help a lot. R

Re: [PATCH v2] drm/ttm: clean up ttm_trace_dma_map/ttm_trace_dma_unmap (v2)

2020-04-07 Thread Christian König
Am 07.04.20 um 11:12 schrieb Huang Rui: ttm_trace_dma_map/ttm_trace_dma_unmap is never used anymore. v2: remove the file completely Signed-off-by: Huang Rui Reviewed-by: Christian König --- include/drm/ttm/ttm_debug.h | 31 --- 1 file changed, 31 deletions(-

Re: [PATCH 00/10] Set up generic fbdev after registering device

2020-04-07 Thread Sam Ravnborg
Hi Thomas. On Tue, Apr 07, 2020 at 08:28:59AM +0200, Thomas Zimmermann wrote: > Hi Sam > > Am 06.04.20 um 22:00 schrieb Sam Ravnborg: > > Hi Thomas. > > > > On Mon, Apr 06, 2020 at 03:43:55PM +0200, Thomas Zimmermann wrote: > >> Generic fbdev emulation is a DRM client. If possible, it should beh

Re: [PATCH 10/10] drm/fb-helper: Remove return value from drm_fbdev_generic_setup()

2020-04-07 Thread Sam Ravnborg
Hi Thomas. On Mon, Apr 06, 2020 at 03:44:05PM +0200, Thomas Zimmermann wrote: > Generic fbdev emulation is a DRM client. Drivers should invoke the > setup function, but not depend on its success. Hence remove the return > value. > > Signed-off-by: Thomas Zimmermann If this goes in as-is then it

Re: [PATCH 00/10] Set up generic fbdev after registering device

2020-04-07 Thread Noralf Trønnes
Den 06.04.2020 15.43, skrev Thomas Zimmermann: > Generic fbdev emulation is a DRM client. If possible, it should behave > like userspace clients. Therefore it should not run before the driver > registered the new DRM device. If the setup function fails, the driver > should not report an error. >

Re: [PATCH 05/10] drm/mediathek: Remove error check from fbdev setup

2020-04-07 Thread Noralf Trønnes
Den 06.04.2020 15.44, skrev Thomas Zimmermann: > Remove the error check from the fbdev setup function. The function > will print a warning. > > Signed-off-by: Thomas Zimmermann > --- Subject: s/mediathek/mediatek/ ___ dri-devel mailing list dri-deve

Re: Bad rss-counter state from drm/ttm, drm/vmwgfx: Support huge TTM pagefaults

2020-04-07 Thread VMware
On 4/7/20 2:38 AM, Alex Xu (Hello71) wrote: Excerpts from Thomas Hellström (VMware)'s message of April 6, 2020 5:04 pm: Hi, On 4/6/20 9:51 PM, Alex Xu (Hello71) wrote: Using 314b658 with amdgpu, starting sway and firefox causes "BUG: Bad rss-counter state" and "BUG: non-zero pgtables_bytes on

Re: [PATCH v2 1/3] drm/vblank: Add intro to documentation

2020-04-07 Thread Liviu Dudau
Hi Sam, Sorry for jumping in late on this, I have just a small suggestion: On Mon, Apr 06, 2020 at 09:47:44PM +0200, Sam Ravnborg wrote: > Lyude Paul wrote a very good intro to vblank here: > https://lore.kernel.org/dri-devel/faf63d8a9ed23c16af69762f59d0dca6b2bf085f.ca...@redhat.com/T/#mce6480be7

Re: [PATCH v2 2/3] drm: writeback: document callbacks

2020-04-07 Thread Liviu Dudau
On Mon, Apr 06, 2020 at 09:47:45PM +0200, Sam Ravnborg wrote: > Document the callbacks: > drm_connector_helper_funcs.prepare_writeback_job > drm_connector_helper_funcs.cleanup_writeback_job > > The documentation was pulled from the changelong introducing the > callbacks, originally written

Re: [Intel-gfx] [PATCH v5 14/16] drm/mst: Add support for QUERY_STREAM_ENCRYPTION_STATUS MST sideband message

2020-04-07 Thread Jani Nikula
On Thu, 26 Mar 2020, Lyude Paul wrote: > On Thu, 2020-03-05 at 15:12 -0500, Sean Paul wrote: >> From: Sean Paul >> >> Used to query whether an MST stream is encrypted or not. >> >> Signed-off-by: Sean Paul >> >> Link: >> https://patchwork.freedesktop.org/patch/msgid/20200218220242.107265-14-

Re: [PATCH 07/10] drm/tilcdc: Set up fbdev after fully registering device

2020-04-07 Thread Jyri Sarha
On 06/04/2020 16:44, Thomas Zimmermann wrote: > Generic fbdev support is a DRM client. Set it up after fully registering > the new DRM device. > > Signed-off-by: Thomas Zimmermann Acked-by: Jyri Sarha However, this change hardly makes any difference, as the only place where "is_registere"'s va

Re: Curtaining API / Force blanking displays

2020-04-07 Thread Daniel Stone
Hi, On Tue, 7 Apr 2020 at 09:23, Pekka Paalanen wrote: > Maybe I should underline the read/write race: > > You do not get notified when a display server updates the screen, so > you poll. When your poll returns a new FB id, And that's only useful for Wayland systems. On X11, the server can (and

Re: [PATCH 00/10] Set up generic fbdev after registering device

2020-04-07 Thread Thomas Zimmermann
Hi Noralf Am 07.04.20 um 13:02 schrieb Noralf Trønnes: > > > Den 06.04.2020 15.43, skrev Thomas Zimmermann: >> Generic fbdev emulation is a DRM client. If possible, it should behave >> like userspace clients. Therefore it should not run before the driver >> registered the new DRM device. If the

Re: [PATCH 03/10] drm/kirin: Set up fbdev after fully registering device

2020-04-07 Thread Thomas Zimmermann
Hi Am 07.04.20 um 10:04 schrieb Daniel Vetter: > On Mon, Apr 06, 2020 at 03:43:58PM +0200, Thomas Zimmermann wrote: >> Generic fbdev support is a DRM client. Set it up after fully registering >> the new DRM device. >> >> Signed-off-by: Thomas Zimmermann >> --- >> drivers/gpu/drm/hisilicon/kirin/

Re: [PATCH] dma-buf: support 32bit DMA_BUF_SET_NAME ioctl

2020-04-07 Thread Sumit Semwal
Hello, Daniel, your comments here, please? On Mon, 24 Feb 2020 at 09:09, Martin Liu wrote: > > On Tue, Jan 14, 2020 at 09:41:01PM +0800, Martin Liu wrote: > > CC more MLs for winder review. > > > This commit adds SET_NAME ioctl coversion to > > support 32 bit ioctl. > > > > Signed-off-by: Martin

[PATCH] dma-buf: Fix SET_NAME ioctl uapi

2020-04-07 Thread Daniel Vetter
The uapi is the same on 32 and 64 bit, but the number isnt. Everyone who botched this please re-read: https://www.kernel.org/doc/html/v5.4-preprc-cpu/ioctl/botching-up-ioctls.html Also, the type argument for the ioctl macros is for the type the void __user *arg pointer points at, which in this ca

Re: [PATCH v9 0/5] drm/tidss: New driver for TI Keystone platform Display SubSystem

2020-04-07 Thread Tomi Valkeinen
Hi Jyri, On 27/01/2020 18:00, Jyri Sarha wrote: This is intended to be the last patch series. I'll apply these trough drm-misc-next tomorrow. Were these ever merged? Tomi Changes since v8: - "dt-bindings: display: ti,k2g-dss: Add dt-schema yaml binding" - Remove ports-node from the dts

[PATCH 2/3] drm/exynos: gem: Rework scatter-list contiguity check on Prime import

2020-04-07 Thread Marek Szyprowski
Explicitly check if the imported buffer has been mapped as contiguous in the DMA address space, what is required by all Exynos DRM CRTC drivers. While touching this, set buffer flags depending on the availability of the IOMMU. Signed-off-by: Marek Szyprowski --- drivers/gpu/drm/exynos/exynos_drm

[PATCH 0/3] ExynosDRM - rework GEM internals

2020-04-07 Thread Marek Szyprowski
Hi The recent discussion under the 'drm/prime: fix extracting of the DMA addresses from a scatterlist' [1] patch inspired me to take a look again into the Exynos DRM GEM internals. I've made a little cleanup and reworked some parts to make them more error proof for the various corner-cases. [1] h

[PATCH 3/3] drm/exynos: gem: Get rid of the internal 'pages' array

2020-04-07 Thread Marek Szyprowski
Internal pages array and scatter-list for them is not really needed for anything. FBDev emulation can simply rely on the DMA-mapping framework to create a proper kernel mapping for the buffer, while all other buffer use cases don't really need that array at all. Suggested-by: Christian König Sign

[PATCH 1/3] drm/exynos: gem: Remove dead-code

2020-04-07 Thread Marek Szyprowski
The ExynosDRM page fault handler is never used, drm_gem_mmap() always calls exynos_drm_gem_mmap() function, which perform complete mapping for the given virtual address-space area. Signed-off-by: Marek Szyprowski --- drivers/gpu/drm/exynos/exynos_drm_drv.c | 1 - drivers/gpu/drm/exynos/exynos_d

Re: [PATCH] dma-buf: support 32bit DMA_BUF_SET_NAME ioctl

2020-04-07 Thread Daniel Vetter
On Tue, Apr 7, 2020 at 3:26 PM Sumit Semwal wrote: > > Hello, > > Daniel, your comments here, please? Don't :-) I mean rule of thumb you should never need a compat_ioctl for a new ioctl, that's just failure to read https://www.kernel.org/doc/html/v5.4-preprc-cpu/ioctl/botching-up-ioctls.html Sp

Re: [PATCH v2 1/3] drm/vblank: Add intro to documentation

2020-04-07 Thread Alex Deucher
On Mon, Apr 6, 2020 at 3:48 PM Sam Ravnborg wrote: > > Lyude Paul wrote a very good intro to vblank here: > https://lore.kernel.org/dri-devel/faf63d8a9ed23c16af69762f59d0dca6b2bf085f.ca...@redhat.com/T/#mce6480be738160e9d07c5d023e88fd78d7a06d27 > > Add this to the intro chapter in drm_vblank.c so

[Bug 202445] amdgpu/dc: framerate dropping below adaptive sync range causes screen flickering

2020-04-07 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=202445 --- Comment #38 from jaapbuur...@gmail.com --- While I previously also had to same luminance flickering as you were describing on older kernels, kernel 5.5 and unfortunately also 5.6 are showing me flickering between a completely black screeb and

Re: [RESEND 2/2] drm: bridge: adv7511: Extend list of audio sample rates

2020-04-07 Thread Andrzej Hajda
On 24.02.2020 13:01, Bogdan Togorean wrote: > ADV7511 support sample rates up to 192kHz. CTS and N parameters should > be computed accordingly so this commit extend the list up to maximum > supported sample rate. > > Signed-off-by: Bogdan Togorean > --- > drivers/gpu/drm/bridge/adv7511/adv7511_au

[Bug 202445] amdgpu/dc: framerate dropping below adaptive sync range causes screen flickering

2020-04-07 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=202445 --- Comment #39 from jaapbuur...@gmail.com --- To add to my previous comment: My ingame FPS is completely stable, yet my monitor's HZ is jumping all over the place as can be seen from the monitor's OSD. Previously, the luminance issue would only o

Re: [PATCH v2 13/17] drm/i915: Stop using mode->private_flags

2020-04-07 Thread Ville Syrjälä
On Tue, Apr 07, 2020 at 09:38:47AM +0200, Daniel Vetter wrote: > On Fri, Apr 03, 2020 at 11:40:04PM +0300, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Replace the use of mode->private_flags with a truly private bitmaks > > in our own crtc state. We also need a copy in the crtc itself so

Re: [PATCH v2 2/3] drm: writeback: document callbacks

2020-04-07 Thread Sam Ravnborg
On Tue, Apr 07, 2020 at 01:04:31PM +0100, Liviu Dudau wrote: > On Mon, Apr 06, 2020 at 09:47:45PM +0200, Sam Ravnborg wrote: > > Document the callbacks: > > drm_connector_helper_funcs.prepare_writeback_job > > drm_connector_helper_funcs.cleanup_writeback_job > > > > The documentation was p

Re: [PATCH v2 3/3] drm/writeback: wire drm_writeback.h to kernel-doc

2020-04-07 Thread Sam Ravnborg
On Tue, Apr 07, 2020 at 10:08:51AM +0200, Daniel Vetter wrote: > On Mon, Apr 06, 2020 at 09:47:46PM +0200, Sam Ravnborg wrote: > > drm_writeback.h included a lot of nice kernel-doc comments. > > Wire it up so the header file is included in the kernel-doc > > generated documentation. > > > > Added

[PATCH] drm/dp_mst: Zero assigned PBN when releasing VCPI slots

2020-04-07 Thread mikita.lipski
From: Mikita Lipski Zero Port's PBN together with VCPI slots when releasing allocated VCPI slots. That way when disabling the connector it will not cause issues in drm_dp_mst_atomic_check verifying branch bw limit. Signed-off-by: Mikita Lipski --- drivers/gpu/drm/drm_dp_mst_topology.c | 1 + 1

Re: [PATCH v2 1/3] drm/vblank: Add intro to documentation

2020-04-07 Thread Sam Ravnborg
Hi Alex. On Tue, Apr 07, 2020 at 10:42:46AM -0400, Alex Deucher wrote: > On Mon, Apr 6, 2020 at 3:48 PM Sam Ravnborg wrote: > > > > Lyude Paul wrote a very good intro to vblank here: > > https://lore.kernel.org/dri-devel/faf63d8a9ed23c16af69762f59d0dca6b2bf085f.ca...@redhat.com/T/#mce6480be738160

Re: [PATCH v9 0/5] drm/tidss: New driver for TI Keystone platform Display SubSystem

2020-04-07 Thread Sam Ravnborg
On Tue, Apr 07, 2020 at 04:18:20PM +0300, Tomi Valkeinen wrote: > Hi Jyri, > > On 27/01/2020 18:00, Jyri Sarha wrote: > > This is intended to be the last patch series. I'll apply these trough > > drm-misc-next tomorrow. > > Were these ever merged? See 32a1795f57eecc3974901760400618571c9d357f ("d

Re: [PATCH 00/10] Set up generic fbdev after registering device

2020-04-07 Thread Sam Ravnborg
Hi Thomas/Noralf. > > Having DRM core take care of fbdev emulation was an idea Laurent had > > which was the spark that set me off making the generic fbdev emulation. > > > > Maybe it's still too early to make this move, I don't know. > > I think we should wait a bit. As you mentioned, there are

[Bug 206519] [amdgpu] kernel NULL pointer dereference on shutdown when CONFIG_DRM_AMD_DC_HDCP=y

2020-04-07 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=206519 Shlomo (shl...@fastmail.com) changed: What|Removed |Added Status|NEW |RESOLVED Resolutio

Re: [PATCH v3 1/5] drm: Introduce plane and CRTC scaling filter properties

2020-04-07 Thread Ville Syrjälä
On Tue, Mar 31, 2020 at 12:08:53AM +0530, Pankaj Bharadiya wrote: > Introduce per-plane and per-CRTC scaling filter properties to allow > userspace to select the driver's default scaling filter or > Nearest-neighbor(NN) filter for upscaling operations on CRTC and > plane. > > Drivers can set up th

Re: [PATCH v2 3/4] drm/dp_mst: Increase ACT retry timeout to 3s

2020-04-07 Thread Sean Paul
On Mon, Apr 6, 2020 at 6:13 PM Lyude Paul wrote: > > Currently we only poll for an ACT up to 30 times, with a busy-wait delay > of 100µs between each attempt - giving us a timeout of 2900µs. While > this might seem sensible, it would appear that in certain scenarios it > can take dramatically long

Re: [PATCH v2 4/4] drm/dp_mst: Print errors on ACT timeouts

2020-04-07 Thread Sean Paul
On Mon, Apr 6, 2020 at 6:13 PM Lyude Paul wrote: > > Although it's not unexpected for drm_dp_check_act_status() to fail due > to DPCD read failures (as the hub may have just been unplugged > suddenly), timeouts are a bit more worrying as they either mean we need > a longer timeout value, or we are

Re: [Freedreno] [PATCH] drm/msm/mdp5: Fix mdp5_init error path for failed mdp5_kms allocation

2020-04-07 Thread abhinavk
On 2020-04-07 10:07, Roy Spliet wrote: When allocation for mdp5_kms fails, calling mdp5_destroy() leads to undefined behaviour, likely a nullptr exception or use-after-free troubles. Signed-off-by: Roy Spliet Reviewed-by: Abhinav Kumar --- drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c | 3 ++-

Re: [PATCH v2 2/4] drm: ipk: Add DRM driver for DesignWare IPK DSI

2020-04-07 Thread Sam Ravnborg
Hi Angelo. Has it been evaluated if the drm_simple_* stuff can be used? It looks like this is a single plane, single connector thing so a good candidate. Some nits below. Sam On Mon, Apr 06, 2020 at 03:24:12PM +0200, Angelo Ribeiro wrote: > Add support for Synopsys DesignWare VPG (Video

Re: [PATCH v2 3/4] drm: ipk: Add extensions for DW MIPI DSI Host driver

2020-04-07 Thread Sam Ravnborg
Hi Angelo. One nit below. Sam On Mon, Apr 06, 2020 at 03:24:13PM +0200, Angelo Ribeiro wrote: > Add Synopsys DesignWare IPK specific extensions for Synopsys DesignWare > MIPI DSI Host driver. > > Cc: Maarten Lankhorst > Cc: Maxime Ripard > Cc: David Airlie > Cc: Daniel Vetter > Cc:

Re: [PATCH] video: fbdev: don't print error message on platform_get_irq() failure

2020-04-07 Thread Sam Ravnborg
Hi Tang Bin On Mon, Apr 06, 2020 at 01:34:50PM +0800, Tang Bin wrote: > The platform_get_irq() can print error message,so remove the redundant > dev_err() here. > > Signed-off-by: Tang Bin > --- > drivers/video/fbdev/atmel_lcdfb.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers

Re: [PATCH v2 01/17] drm: Nuke mode->hsync

2020-04-07 Thread Sam Ravnborg
On Fri, Apr 03, 2020 at 11:39:52PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Let's just calculate the hsync rate on demand. No point in wasting > space storing it and risking the cached value getting out of sync > with reality. > > v2: Move drm_mode_hsync() next to its only users >

Re: [PATCH v2 06/17] drm: Shrink mode->type to u8

2020-04-07 Thread Sam Ravnborg
On Fri, Apr 03, 2020 at 11:39:57PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > We only have 7 bits defined for mode->type. Shrink the storage to u8. > > Reviewed-by: Emil Velikov > Reviewed-by: Daniel Vetter > Signed-off-by: Ville Syrjälä Reviewed-by: Sam Ravnborg > --- > include/

Re: [PATCH v2 05/17] drm: Shrink {width,height}_mm to u16

2020-04-07 Thread Sam Ravnborg
On Fri, Apr 03, 2020 at 11:39:56PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Instead of supporting ~2000km wide displayes let's limit ourselves > to ~65m. That seems plenty big enough to me. > > Even with EDID_QUIRK_DETAILED_IN_CM EDIDs seem to be limited to > 10*0xfff which fits int

Re: [PATCH v2 07/17] drm: Make mode->flags u32

2020-04-07 Thread Sam Ravnborg
On Fri, Apr 03, 2020 at 11:39:58PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > The mode flags are direclty exposed in the uapi as u32. Use the > same size type to store them internally. > > Reviewed-by: Emil Velikov > Signed-off-by: Ville Syrjälä Reviewed-by: Sam Ravnborg > --- > i

  1   2   >