Re: [PATCH 2/4] drm/hisilicon: Code cleanup for hibmc_drv_vdac

2020-04-03 Thread Thomas Zimmermann
Hi Am 03.04.20 um 04:26 schrieb Xinliang Liu: > Hi Tao, > > On Fri, 6 Mar 2020 at 11:44, Tian Tao wrote: >> >> code cleanup for hibmc_drv_vdac.c, no actual function changes. >> >> Signed-off-by: Tian Tao >> Signed-off-by: Gong junjie >> --- >> drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c

Re: How to handle disconnection of eDP panels due to dynamic display mux switches

2020-04-03 Thread Daniel Vetter
On Fri, Apr 3, 2020 at 8:54 AM Daniel Dadap wrote: > > > On 4/2/20 6:39 AM, Lukas Wunner wrote: > > External email: Use caution opening links or attachments > > > > > > On Fri, Mar 27, 2020 at 04:25:19PM -0500, Daniel Dadap wrote: > >> A number of hybrid GPU notebook computer designs with dual (in

[PATCH v14 2/3] dt-bindings: display: mediatek: convert the document format from txt to yaml

2020-04-03 Thread Jitao Shi
Signed-off-by: Jitao Shi --- .../display/mediatek/mediatek,dpi.txt | 42 .../display/mediatek/mediatek,dpi.yaml| 97 +++ 2 files changed, 97 insertions(+), 42 deletions(-) delete mode 100644 Documentation/devicetree/bindings/display/mediatek/mediatek,dpi

[PATCH v14 3/3] drm/mediatek: set dpi pin mode to gpio low to avoid leakage current

2020-04-03 Thread Jitao Shi
Config dpi pins mode to output and pull low when dpi is disabled. Aovid leakage current from some dpi pins (Hsync Vsync DE ... ). Signed-off-by: Jitao Shi --- drivers/gpu/drm/mediatek/mtk_dpi.c | 31 ++ 1 file changed, 31 insertions(+) diff --git a/drivers/gpu/drm/me

[PATCH v14 1/3] dt-bindings: display: mediatek: control dpi pins mode to avoid leakage

2020-04-03 Thread Jitao Shi
Add property "pinctrl-names" to swap pin mode between gpio and dpi mode. Set the dpi pins to gpio mode and output-low to avoid leakage current when dpi disabled. Signed-off-by: Jitao Shi --- .../devicetree/bindings/display/mediatek/mediatek,dpi.txt | 6 ++ 1 file changed, 6 insertions(+)

[PATCH v14 0/3] mt8183 dpi support pin mode swap

2020-04-03 Thread Jitao Shi
Changes since v13: - move dpi dual edge patches to another series because it will have long time to implement the dual edge change base boris patches. https://patchwork.kernel.org/cover/11354279/ Changes since v12: - fix mediatek,dpi.yaml make_dt_binding_check errors. Change since v11: -

Re: [git pull] drm for 5.7-rc1

2020-04-03 Thread Daniel Vetter
On Thu, Apr 2, 2020 at 10:43 PM Linus Torvalds wrote: > > On Thu, Apr 2, 2020 at 1:33 PM Nathan Chancellor > wrote: > > > > This fixes it but I am not sure if it is proper or not (could be > > problematic if CONFIG_PHYS_ADDR_T_64BIT is set but > > CONFIG_ARCH_DMA_ADDR_T_64BIT is not, not sure if

Re: Aliases for DRI connectors?

2020-04-03 Thread Pekka Paalanen
On Wed, 1 Apr 2020 14:38:37 -0500 Matt Hoosier wrote: > I'm searching for some sort of scheme that will let my DRI master query the > set of available connectors and select the one carrying a prearranged > designation. The problem I'm trying to solve is to allow deploying one > standardized users

Re: [PATCH] drm/legacy: Fix type for drm_local_map.offset

2020-04-03 Thread Daniel Vetter
On Fri, Apr 3, 2020 at 8:54 AM Nathan Chancellor wrote: > > On Thu, Apr 02, 2020 at 10:59:26PM +0100, Chris Wilson wrote: > > drm_local_map.offset is not only used for resource_size_t but also > > dma_addr_t which may be of different sizes. > > > > Reported-by: Nathan Chancellor > > Fixes: 8e4ff9

Re: [PATCH 1/6] dma-buf: add peer2peer flag

2020-04-03 Thread Daniel Vetter
On Wed, Apr 01, 2020 at 04:04:14PM +, Ruhl, Michael J wrote: > >-Original Message- > >From: dri-devel On Behalf Of > >Daniel Vetter > >Sent: Wednesday, April 1, 2020 7:35 AM > >To: Christian König > >Cc: amd-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org > >Subject: Re: [P

[PATCH v2 1/1] lib/vsprintf: Add support for printing V4L2 and DRM fourccs

2020-04-03 Thread Sakari Ailus
Add a printk modifier %ppf (for pixel format) for printing V4L2 and DRM pixel formats denoted by 4ccs. The 4cc encoding is the same for both so the same implementation can be used. Suggested-by: Mauro Carvalho Chehab Signed-off-by: Sakari Ailus --- since v1: - Improve documentation (add -BE suf

Re: [PATCH v4 2/3] drm: Add support for the LogiCVC display controller

2020-04-03 Thread Paul Kocialkowski
Hi Sam, On Sat 04 Jan 20, 20:20, Sam Ravnborg wrote: > Good looking driver. Well structured in a number of relevant files. > A few comments in the following. > Some parts I fail to follow - due to my lack of DRM knowledge. > So all in all - only trivial comments. Thanks for the review and the fri

Re: [PATCH v4.19.y, v4.14.y, v4.9.y] drm/etnaviv: Backport fix for mmu flushing

2020-04-03 Thread Greg KH
On Thu, Apr 02, 2020 at 06:07:55PM +0100, Robert Beckett wrote: > commit 4900dda90af2cb13bc1d4c12ce94b98acc8fe64e upstream > > Due to async need_flush updating via other buffer mapping, checking > gpu->need_flush in 3 places within etnaviv_buffer_queue can cause GPU > hangs. > > This occurs due t

[PATCH v5 0/2] drm: LogiCVC display controller support

2020-04-03 Thread Paul Kocialkowski
This series introduces support for the LogiCVC display controller. The controller is a bit unusual since it is usually loaded as programmable logic on Xilinx FPGAs or Zynq-7000 SoCs. More details are presented on the main commit for the driver. More information about the controller is available on

[PATCH v5 1/2] dt-bindings: display: Document the Xylon LogiCVC display controller

2020-04-03 Thread Paul Kocialkowski
The Xylon LogiCVC is a display controller implemented as programmable logic in Xilinx FPGAs. Signed-off-by: Paul Kocialkowski Acked-by: Rob Herring --- .../display/xylon,logicvc-display.yaml| 313 ++ 1 file changed, 313 insertions(+) create mode 100644 Documentation/de

[PATCH v5 2/2] drm: Add support for the LogiCVC display controller

2020-04-03 Thread Paul Kocialkowski
c = drm->dev_private; + + /* Stride is always fixed to its configuration value. */ + args->pitch = logicvc->config.row_stride * DIV_ROUND_UP(args->bpp, 8); + + return drm_gem_cma_dumb_create_internal(file_priv, drm, args); +} + +static struct drm_dr

Re: [PATCH v2 1/1] lib/vsprintf: Add support for printing V4L2 and DRM fourccs

2020-04-03 Thread Sakari Ailus
Hi Andy, Thanks for the comments. On Fri, Apr 03, 2020 at 12:31:03PM +0300, Andy Shevchenko wrote: > On Fri, Apr 03, 2020 at 12:11:56PM +0300, Sakari Ailus wrote: > > Add a printk modifier %ppf (for pixel format) for printing V4L2 and DRM > > pixel formats denoted by 4ccs. The 4cc encoding is the

Re: Aliases for DRI connectors?

2020-04-03 Thread Pekka Paalanen
On Fri, 3 Apr 2020 10:28:52 +0200 Guillermo Rodriguez wrote: > Hi Pekka, > > El vie., 3 abr. 2020 a las 10:14, Pekka Paalanen > () escribió: > > > > On Wed, 1 Apr 2020 14:38:37 -0500 > > Matt Hoosier wrote: > > > > > I'm searching for some sort of scheme that will let my DRI master query > >

Re: [PATCH 5/5] drm/virtio: only call virtio_gpu_cmd_create_resource for dumb resources

2020-04-03 Thread Gerd Hoffmann
On Wed, Apr 01, 2020 at 03:30:39PM -0700, Gurchetan Singh wrote: > We want to avoid this path for upcoming blob resources. > - } else { > + } else if (params->dumb) { That should be posted as part of the actual blob resource patch series, it doesn't make sense at all standalone. The othe

Re: [PATCH v2 1/1] lib/vsprintf: Add support for printing V4L2 and DRM fourccs

2020-04-03 Thread Sakari Ailus
Hi Andy, On Fri, Apr 03, 2020 at 12:54:41PM +0300, Andy Shevchenko wrote: > On Fri, Apr 03, 2020 at 12:39:16PM +0300, Sakari Ailus wrote: > > On Fri, Apr 03, 2020 at 12:31:03PM +0300, Andy Shevchenko wrote: > > > On Fri, Apr 03, 2020 at 12:11:56PM +0300, Sakari Ailus wrote: > > > > Add a printk mo

KMS enums and bitfields UAPI

2020-04-03 Thread Simon Ser
Hi all, I've been working on a library called libliftoff [1]. This library allows users to set KMS properties on a hardware planes abstraction called layers. Basically, library users create as many layers as they want with the KMS properties they want, and libliftoff will map layers to actual hard

Re: [PATCH v2 1/1] lib/vsprintf: Add support for printing V4L2 and DRM fourccs

2020-04-03 Thread Laurent Pinchart
Hi Sakari, Thank you for the patch. On Fri, Apr 03, 2020 at 12:11:56PM +0300, Sakari Ailus wrote: > Add a printk modifier %ppf (for pixel format) for printing V4L2 and DRM > pixel formats denoted by 4ccs. The 4cc encoding is the same for both so > the same implementation can be used. > > Suggest

Re: [PATCH v2 1/1] lib/vsprintf: Add support for printing V4L2 and DRM fourccs

2020-04-03 Thread Sakari Ailus
Hi Laurent, Thanks for the comments. On Fri, Apr 03, 2020 at 01:24:49PM +0300, Laurent Pinchart wrote: > Hi Sakari, > > Thank you for the patch. > > On Fri, Apr 03, 2020 at 12:11:56PM +0300, Sakari Ailus wrote: > > Add a printk modifier %ppf (for pixel format) for printing V4L2 and DRM > > pixe

Re: [PATCH v5 2/2] drm: Add support for the LogiCVC display controller

2020-04-03 Thread Daniel Vetter
base class structures have already. There's a bunch of these all over. If you want to a nice little function to do the pointer chasing&casting so you can go directly from logicvc_crtc to logicvc_drm. > + > + struct drm_crtc drm_crtc; > + struct drm_pending_vblank_event *event; &g

[PATCH 2/2] drm: delete drm_pci.h

2020-04-03 Thread Daniel Vetter
It's empty! After more than 20 years of OS abstraction layer for pci devices, it's kinda gone now. Signed-off-by: Daniel Vetter --- drivers/gpu/drm/drm_bufs.c | 2 +- drivers/gpu/drm/drm_dma.c| 2 +- drivers/gpu/drm/drm_pci.c| 1 - drivers/gpu/dr

[PATCH 1/2] drm/pci: Move drm_pci_alloc/free under CONFIG_DRM_LEGACY

2020-04-03 Thread Daniel Vetter
All other users have been removed, yay! Signed-off-by: Daniel Vetter --- drivers/gpu/drm/drm_pci.c | 3 +++ include/drm/drm_legacy.h | 15 +++ include/drm/drm_pci.h | 26 -- 3 files changed, 18 insertions(+), 26 deletions(-) diff --git a/drivers/gpu/drm

Re: [PATCH v2 1/1] lib/vsprintf: Add support for printing V4L2 and DRM fourccs

2020-04-03 Thread Mauro Carvalho Chehab
Em Fri, 3 Apr 2020 13:47:02 +0300 Sakari Ailus escreveu: > > > +static noinline_for_stack > > > +char *fourcc_string(char *buf, char *end, const u32 *fourcc, > > > + struct printf_spec spec, const char *fmt) > > > +{ > > > +#define FOURCC_STRING_BE "-BE" > > > + char s[sizeof(*fourcc)

Re: [PATCH v5 2/2] drm: Add support for the LogiCVC display controller

2020-04-03 Thread Daniel Vetter
ent; > +struct logicvc_drm; > + > +struct logicvc_crtc { > + struct logicvc_drm *logicvc; > + > + struct drm_crtc drm_crtc; > + struct drm_pending_vblank_event *event; > +}; > + > +void logicvc_crtc_vblank_handler(struct logicvc_drm *logicvc); > +int l

Re: [PATCH V4 1/4] backlight: qcom-wled: convert the wled bindings to .yaml format

2020-04-03 Thread Daniel Thompson
On Fri, Apr 03, 2020 at 04:45:49PM +0530, kgu...@codeaurora.org wrote: > On 2020-03-31 23:24, Rob Herring wrote: > > On Mon, Mar 23, 2020 at 11:16:55PM +0530, Kiran Gunda wrote: > > > diff --git > > > a/Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml > > > b/Documentation/devicetree

Re: KMS enums and bitfields UAPI

2020-04-03 Thread Pekka Paalanen
On Fri, 03 Apr 2020 10:15:21 + Simon Ser wrote: > Hi all, > > I've been working on a library called libliftoff [1]. This library allows > users > to set KMS properties on a hardware planes abstraction called layers. > Basically, library users create as many layers as they want with the KMS

Re: KMS enums and bitfields UAPI

2020-04-03 Thread Simon Ser
On Friday, April 3, 2020 2:24 PM, Pekka Paalanen wrote: > On Fri, 03 Apr 2020 10:15:21 + > Simon Ser cont...@emersion.fr wrote: > > > Hi all, > > I've been working on a library called libliftoff 1. This library allows > > users > > to set KMS properties on a hardware planes abstraction calle

Re: [PATCH 1/1] lib/vsprintf: Add support for printing V4L2 and DRM fourccs

2020-04-03 Thread Joe Perches
On Fri, 2020-04-03 at 09:37 +0300, Jani Nikula wrote: > On Thu, 02 Apr 2020, Joe Perches wrote: > > On Thu, 2020-04-02 at 11:34 +0300, Jani Nikula wrote: > > > Or could we conceive of a way to make this locally extensible yet safe, > > > letting callers use something like %{foo}, as well as provid

[ANNOUNCE] libdrm 2.4.101

2020-04-03 Thread Timo Aaltonen
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Alex Deucher (2): amdgpu: add new marketing names from 19.30 amdgpu: add new marketing names from 19.50 Chunming Zhou (2): sync up drm.h libdrm: wrap new flexible syncobj query interface v2 Daniel Stone (2): Add drmMo

Re: [PATCH 1/2] drm/pci: Move drm_pci_alloc/free under CONFIG_DRM_LEGACY

2020-04-03 Thread Sam Ravnborg
Hi Daniel On Fri, Apr 03, 2020 at 01:06:09PM +0200, Daniel Vetter wrote: > All other users have been removed, yay! > > Signed-off-by: Daniel Vetter > --- > drivers/gpu/drm/drm_pci.c | 3 +++ > include/drm/drm_legacy.h | 15 +++ > include/drm/drm_pci.h | 26 -

[PATCH 08/44] drm/vboxvideo: Stop using drm_device->dev_private

2020-04-03 Thread Daniel Vetter
We use the baseclass pattern here, so lets to the proper (and more typesafe) upcasting. Signed-off-by: Daniel Vetter Cc: Hans de Goede --- drivers/gpu/drm/vboxvideo/vbox_drv.c | 1 - drivers/gpu/drm/vboxvideo/vbox_drv.h | 1 + drivers/gpu/drm/vboxvideo/vbox_irq.c | 2 +- drivers/gpu/drm/v

[PATCH 07/44] drm/vboxvideo: Use devm_drm_dev_alloc

2020-04-03 Thread Daniel Vetter
Straightforward conversion. Signed-off-by: Daniel Vetter Cc: Hans de Goede --- drivers/gpu/drm/vboxvideo/vbox_drv.c | 19 +-- 1 file changed, 5 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/vboxvideo/vbox_drv.c b/drivers/gpu/drm/vboxvideo/vbox_drv.c index d685ec1

[PATCH 02/44] drm: Add devm_drm_dev_alloc macro

2020-04-03 Thread Daniel Vetter
The kerneldoc is only added for this new function. Existing kerneldoc and examples will be udated at the very end, since once all drivers are converted over to devm_drm_dev_alloc we can unexport a lot of interim functions and make the documentation for driver authors a lot cleaner and less confusin

[PATCH 00/44] devm_drm_dev_alloc, no more drmm_add_final_kfree

2020-04-03 Thread Daniel Vetter
Hi all, Here's the promised follow-up to get rid of the drmm_add_final_kfree calls from drivers. I've also sprinkled in a bunch of cleanups for the drivers I've had to touch anyway. I think with devm_drm_dev_alloc we now have a very neat and clean way to init the drm_device, and all the interim st

[PATCH 01/44] drivers/base: Always release devres on device_del

2020-04-03 Thread Daniel Vetter
In drm we've added nice drm_device (the main gpu driver thing, which also represents the userspace interfaces and has everything else dangling off it) init functions using devres, devm_drm_dev_init and soon devm_drm_dev_alloc (this patch series adds that). A slight trouble is that drm_device itsel

[PATCH 03/44] drm/device: Deprecate dev_private harder

2020-04-03 Thread Daniel Vetter
We've had lots of conversions to embeddeding, but didn't stop using ->dev_private. Which defeats the point of this. Signed-off-by: Daniel Vetter --- include/drm/drm_device.h | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/include/drm/drm_device.h b/include/drm/drm_de

[PATCH 04/44] drm/vgem: Use devm_drm_dev_alloc

2020-04-03 Thread Daniel Vetter
This means we also need to slightly restructure the exit code, so that final cleanup of the drm_device is triggered by unregistering the platform device. Note that devres is both clean up when the driver is unbound (not the case for vgem, we don't bind), and also when unregistering the device (very

[PATCH 05/44] drm/vkms: Use devm_drm_dev_alloc

2020-04-03 Thread Daniel Vetter
This means we also need to slightly restructure the exit code, so that final cleanup of the drm_device is triggered by unregistering the platform device. Note that devres is both clean up when the driver is unbound (not the case for vkms, we don't bind), and also when unregistering the device (very

[PATCH 06/44] drm/vboxvideo: drop DRM_MTRR_WC #define

2020-04-03 Thread Daniel Vetter
Doesn't apply to upstream kernels since a rather long time. Signed-off-by: Daniel Vetter Cc: Hans de Goede --- drivers/gpu/drm/vboxvideo/vbox_ttm.c | 12 1 file changed, 12 deletions(-) diff --git a/drivers/gpu/drm/vboxvideo/vbox_ttm.c b/drivers/gpu/drm/vboxvideo/vbox_ttm.c index

[PATCH 10/44] drm/vboxvideo: Use devm_gen_pool_create

2020-04-03 Thread Daniel Vetter
Aside from deleting all the cleanup code we're now also setting a name for the pool Signed-off-by: Daniel Vetter Cc: Hans de Goede --- drivers/gpu/drm/vboxvideo/vbox_main.c | 22 -- 1 file changed, 8 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/vboxvideo/vbox

[PATCH 09/44] drm/vboxvidoe: use managed pci functions

2020-04-03 Thread Daniel Vetter
Allows us to drop the cleanup code on the floor. Signed-off-by: Daniel Vetter Cc: Hans de Goede --- drivers/gpu/drm/vboxvideo/vbox_drv.c | 6 ++ drivers/gpu/drm/vboxvideo/vbox_main.c | 7 +-- 2 files changed, 3 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/vboxvideo/vbox

[PATCH 11/44] drm/v3d: Don't set drm_device->dev_private

2020-04-03 Thread Daniel Vetter
And switch the helper over to container_of, which is a bunch faster than chasing a pointer. Plus allows gcc to see through this maze. Signed-off-by: Daniel Vetter Cc: Eric Anholt --- drivers/gpu/drm/v3d/v3d_drv.c | 1 - drivers/gpu/drm/v3d/v3d_drv.h | 2 +- 2 files changed, 1 insertion(+), 2 de

[PATCH 28/44] drm/tidss: Don't use drm_device->dev_private

2020-04-03 Thread Daniel Vetter
Upcasting using a container_of macro is more typesafe, faster and easier for the compiler to optimize. Signed-off-by: Daniel Vetter Cc: Jyri Sarha Cc: Tomi Valkeinen --- drivers/gpu/drm/tidss/tidss_crtc.c | 16 drivers/gpu/drm/tidss/tidss_drv.c | 2 -- drivers/gpu/drm/tids

[PATCH 33/44] drm/mcde: Don't use drm_device->dev_private

2020-04-03 Thread Daniel Vetter
Upcasting using a container_of macro is more typesafe, faster and easier for the compiler to optimize. Signed-off-by: Daniel Vetter Cc: Linus Walleij --- drivers/gpu/drm/mcde/mcde_display.c | 10 +- drivers/gpu/drm/mcde/mcde_drm.h | 2 ++ drivers/gpu/drm/mcde/mcde_drv.c | 5 ++

[PATCH 27/44] drm/tidss: Use devm_drm_dev_alloc

2020-04-03 Thread Daniel Vetter
Already using devm_drm_dev_init, so very simple replacment. Signed-off-by: Daniel Vetter Cc: Jyri Sarha Cc: Tomi Valkeinen --- drivers/gpu/drm/tidss/tidss_drv.c | 15 --- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/tidss/tidss_drv.c b/drivers/gpu

[PATCH 22/44] drm/ili9341: Use devm_drm_dev_alloc

2020-04-03 Thread Daniel Vetter
Already using devm_drm_dev_init, so very simple replacment. Signed-off-by: Daniel Vetter Cc: "Noralf Trønnes" Cc: Sam Ravnborg Cc: Daniel Vetter Cc: Eric Anholt Cc: David Lechner --- drivers/gpu/drm/tiny/ili9341.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --g

[PATCH 21/44] drm/ili9486: Use devm_drm_dev_alloc

2020-04-03 Thread Daniel Vetter
Already using devm_drm_dev_init, so very simple replacment. Signed-off-by: Daniel Vetter Cc: Kamlesh Gurudasani --- drivers/gpu/drm/tiny/ili9486.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/tiny/ili9486.c b/drivers/gpu/drm/tiny/ili9486.c in

[PATCH 31/44] drm/qxl: Don't use drm_device->dev_private

2020-04-03 Thread Daniel Vetter
Upcasting using a container_of macro is more typesafe, faster and easier for the compiler to optimize. Signed-off-by: Daniel Vetter Cc: Dave Airlie Cc: Gerd Hoffmann Cc: virtualizat...@lists.linux-foundation.org Cc: spice-de...@lists.freedesktop.org --- drivers/gpu/drm/qxl/qxl_debugfs.c | 7 +

[PATCH 20/44] drm/mi0283qt: Use devm_drm_dev_alloc

2020-04-03 Thread Daniel Vetter
Already using devm_drm_dev_init, so very simple replacment. Signed-off-by: Daniel Vetter Cc: "Noralf Trønnes" --- drivers/gpu/drm/tiny/mi0283qt.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/tiny/mi0283qt.c b/drivers/gpu/drm/tiny/mi0283qt.c i

[PATCH 16/44] drm/udl: don't set drm_device->dev_private

2020-04-03 Thread Daniel Vetter
We're mostly there already, just a handful of places that didn't use the to_udl container_of cast. To make sure no new appear, don't set ->dev_private. Signed-off-by: Daniel Vetter Cc: Dave Airlie Cc: Sean Paul Cc: Emil Velikov Cc: Thomas Zimmermann Cc: Daniel Vetter Cc: Alexios Zavras Cc:

[PATCH 14/44] drm/v3d: Delete v3d_dev->pdev

2020-04-03 Thread Daniel Vetter
We already have it in v3d_dev->drm.dev with zero additional pointer chasing. Personally I don't like duplicated pointers like this because: - reviewers need to check whether the pointer is for the same or different objects if there's multiple - compilers have an easier time too To avoid having to

[PATCH 25/44] drm/gm12u320: Use devm_drm_dev_alloc

2020-04-03 Thread Daniel Vetter
Already using devm_drm_dev_init, so very simple replacment. Signed-off-by: Daniel Vetter Cc: Hans de Goede --- drivers/gpu/drm/tiny/gm12u320.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/tiny/gm12u320.c b/drivers/gpu/drm/tiny/gm12u320.c inde

[PATCH 32/44] drm/mcde: Use devm_drm_dev_alloc

2020-04-03 Thread Daniel Vetter
Already using devm_drm_dev_init, so very simple replacment. Signed-off-by: Daniel Vetter Cc: Linus Walleij --- drivers/gpu/drm/mcde/mcde_drv.c | 16 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/mcde/mcde_drv.c b/drivers/gpu/drm/mcde/mcde_drv.c

[PATCH 26/44] drm/gm12u320: Don't use drm_device->dev_private

2020-04-03 Thread Daniel Vetter
Upcasting using a container_of macro is more typesafe, faster and easier for the compiler to optimize. Signed-off-by: Daniel Vetter Cc: Hans de Goede --- drivers/gpu/drm/tiny/gm12u320.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/tiny/gm12u320

[PATCH 12/44] drm/v3d: Use devm_drm_dev_alloc

2020-04-03 Thread Daniel Vetter
Also allows us to simplify the unroll code since the drm_dev_put disappears. Signed-off-by: Daniel Vetter Cc: Eric Anholt --- drivers/gpu/drm/v3d/v3d_drv.c | 31 ++- 1 file changed, 10 insertions(+), 21 deletions(-) diff --git a/drivers/gpu/drm/v3d/v3d_drv.c b/drive

[PATCH 24/44] drm/hx8357d: Use devm_drm_dev_alloc

2020-04-03 Thread Daniel Vetter
Already using devm_drm_dev_init, so very simple replacment. Signed-off-by: Daniel Vetter Cc: Eric Anholt --- drivers/gpu/drm/tiny/hx8357d.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/tiny/hx8357d.c b/drivers/gpu/drm/tiny/hx8357d.c index af7

[PATCH 17/44] drm/st7735r: Use devm_drm_dev_alloc

2020-04-03 Thread Daniel Vetter
Already using devm_drm_dev_init, so very simple replacment. Aside: There was an oddity in the old code, we allocated priv but in the error path we've freed priv->dbidev ... Signed-off-by: Daniel Vetter Cc: David Lechner --- drivers/gpu/drm/tiny/st7735r.c | 13 - 1 file changed, 4 i

[PATCH 19/44] drm/repaper: Use devm_drm_dev_alloc

2020-04-03 Thread Daniel Vetter
Already using devm_drm_dev_init, so very simple replacment. Signed-off-by: Daniel Vetter Cc: "Noralf Trønnes" --- drivers/gpu/drm/tiny/repaper.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/tiny/repaper.c b/drivers/gpu/drm/tiny/repaper.c in

[PATCH 15/44] drm/udl: Use demv_drm_dev_alloc

2020-04-03 Thread Daniel Vetter
Also init the fbdev emulation before we register the device, that way we can rely on the auto-cleanup and simplify the probe error code even more. Signed-off-by: Daniel Vetter Cc: Dave Airlie Cc: Sean Paul Cc: Thomas Zimmermann Cc: Daniel Vetter Cc: Emil Velikov Cc: Sam Ravnborg Cc: Thomas

[PATCH 34/44] drm/ingenic: Use devm_drm_dev_alloc

2020-04-03 Thread Daniel Vetter
Already using devm_drm_dev_init, so very simple replacment. Signed-off-by: Daniel Vetter Cc: Paul Cercueil --- drivers/gpu/drm/ingenic/ingenic-drm.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/ingenic/ingenic-drm.c b/drivers/gpu/drm/ingen

[PATCH 29/44] drm/tidss: Delete tidss->saved_state

2020-04-03 Thread Daniel Vetter
Not used anymore since the switch to suspend/resume helpers. Signed-off-by: Daniel Vetter Cc: Jyri Sarha Cc: Tomi Valkeinen --- drivers/gpu/drm/tidss/tidss_drv.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/tidss/tidss_drv.h b/drivers/gpu/drm/tidss/tidss_drv.h index b2

[PATCH 23/44] drm/ili9225: Use devm_drm_dev_alloc

2020-04-03 Thread Daniel Vetter
Already using devm_drm_dev_init, so very simple replacment. Signed-off-by: Daniel Vetter Cc: David Lechner --- drivers/gpu/drm/tiny/ili9225.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/tiny/ili9225.c b/drivers/gpu/drm/tiny/ili9225.c index 1

[PATCH 13/44] drm/v3d: Delete v3d_dev->dev

2020-04-03 Thread Daniel Vetter
We already have it in v3d_dev->drm.dev with zero additional pointer chasing. Personally I don't like duplicated pointers like this because: - reviewers need to check whether the pointer is for the same or different objects if there's multiple - compilers have an easier time too But also a bit a

[PATCH 30/44] drm/qxl: Use devm_drm_dev_alloc

2020-04-03 Thread Daniel Vetter
Also need to remove the drm_dev_put from the remove hook. Signed-off-by: Daniel Vetter Cc: Dave Airlie Cc: Gerd Hoffmann Cc: virtualizat...@lists.linux-foundation.org Cc: spice-de...@lists.freedesktop.org --- drivers/gpu/drm/qxl/qxl_drv.c | 15 --- drivers/gpu/drm/qxl/qxl_drv.h |

[PATCH 18/44] drm/st7586: Use devm_drm_dev_alloc

2020-04-03 Thread Daniel Vetter
Already using devm_drm_dev_init, so very simple replacment. Signed-off-by: Daniel Vetter Cc: David Lechner --- drivers/gpu/drm/tiny/st7586.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/tiny/st7586.c b/drivers/gpu/drm/tiny/st7586.c index c329

[PATCH 40/44] drm/cirrus: Don't use drm_device->dev_private

2020-04-03 Thread Daniel Vetter
Upcasting using a container_of macro is more typesafe, faster and easier for the compiler to optimize. Signed-off-by: Daniel Vetter Cc: Dave Airlie Cc: Gerd Hoffmann Cc: Daniel Vetter Cc: "Noralf Trønnes" Cc: Sam Ravnborg Cc: Eric Anholt Cc: Thomas Zimmermann Cc: virtualizat...@lists.linux

[PATCH 42/44] drm/i915/selftest: Create mock_destroy_device

2020-04-03 Thread Daniel Vetter
Just some prep work before we rework the lifetime handling, which requires replacing all the drm_dev_put in selftests by something else. Signed-off-by: Daniel Vetter --- drivers/gpu/drm/i915/gem/selftests/huge_pages.c | 2 +- drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c | 2 +- dr

[PATCH 36/44] drm/komeda: use devm_drm_dev_alloc

2020-04-03 Thread Daniel Vetter
Komeda uses the component framework, which does open/close a new devres group around all the bind callbacks. Which means we can use devm_ functions for managing the drm_device cleanup, with leaking stuff in case of deferred probes or other reasons to unbind components, or the component_master. Als

[PATCH 39/44] drm/cirrus: Use devm_drm_dev_alloc

2020-04-03 Thread Daniel Vetter
Already using devm_drm_dev_init, so very simple replacment. Signed-off-by: Daniel Vetter Cc: Dave Airlie Cc: Gerd Hoffmann Cc: Daniel Vetter Cc: Sam Ravnborg Cc: "Noralf Trønnes" Cc: Rob Herring Cc: Thomas Zimmermann Cc: virtualizat...@lists.linux-foundation.org Cc: Emil Velikov --- driv

[PATCH 35/44] drm/ingenic: Don't set drm_device->dev_private

2020-04-03 Thread Daniel Vetter
Entirely not used, just copypasta. Signed-off-by: Daniel Vetter Cc: Paul Cercueil --- drivers/gpu/drm/ingenic/ingenic-drm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/ingenic/ingenic-drm.c b/drivers/gpu/drm/ingenic/ingenic-drm.c index bb62d8e93985..3386270cb8a3 100644 -

[PATCH 43/44] drm/i915/selftests: align more to real device lifetimes

2020-04-03 Thread Daniel Vetter
The big change is device_add so that device_del can auto-cleanup devres resources. This allows us to use devm_drm_dev_alloc, which removes the last user of drm_dev_init. Signed-off-by: Daniel Vetter --- .../gpu/drm/i915/selftests/mock_gem_device.c | 31 +-- .../gpu/drm/i915/self

[PATCH 37/44] drm/armada: Use devm_drm_dev_alloc

2020-04-03 Thread Daniel Vetter
Also remove the now no longer needed build bug on since that's already not needed anymore with drmm_add_final_kfree. Conversion to managed drm_device cleanup is easy, the final drm_dev_put() is already the last thing in both the bind unbind as in the unbind flow. Also, this relies on component.c c

[PATCH 41/44] drm/i915: Use devm_drm_dev_alloc

2020-04-03 Thread Daniel Vetter
Luckily we're already well set up in the main driver, with drm_dev_put() being the last thing in both the unload error case and the pci remove function. Signed-off-by: Daniel Vetter --- drivers/gpu/drm/i915/i915_drv.c | 17 - drivers/gpu/drm/i915/i915_pci.c | 2 -- 2 files chang

[PATCH 44/44] drm/managed: Cleanup of unused functions and polishing docs

2020-04-03 Thread Daniel Vetter
Following functions are only used internally, not by drivers: - drm_dev_init - devm_drm_dev_init - drmm_add_final_kfree Also, now that we have a very slick and polished way to allocate a drm_device with devm_drm_dev_alloc, update all the docs to reflect the new reality. Mostly this consists of del

[PATCH 38/44] drm/armada: Don't use drm_device->dev_private

2020-04-03 Thread Daniel Vetter
Upcasting using a container_of macro is more typesafe, faster and easier for the compiler to optimize. Signed-off-by: Daniel Vetter Cc: Russell King --- drivers/gpu/drm/armada/armada_crtc.c| 4 ++-- drivers/gpu/drm/armada/armada_debugfs.c | 2 +- drivers/gpu/drm/armada/armada_drm.h | 2

Re: [Mesa-dev] [Intel-gfx] gitlab.fd.o financial situation and impact on services

2020-04-03 Thread Michel Dänzer
On 2020-03-01 6:46 a.m., Marek Olšák wrote: > For Mesa, we could run CI only when Marge pushes, so that it's a strictly > pre-merge CI. Thanks for the suggestion! I implemented something like this for Mesa: https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4432 -- Earthling Michel Dänz

Re: mainline/master bisection: baseline.login on peach-pi

2020-04-03 Thread Guillaume Tucker
Please see the bisection report below about a boot failure. Reports aren't automatically sent to the public while we're trialing new bisection features on kernelci.org but this one looks valid. This bisection was run with exynos_defconfig but the issue can also be reproduced with multi_v7_defconf

Re: [PATCH 01/44] drivers/base: Always release devres on device_del

2020-04-03 Thread Greg Kroah-Hartman
On Fri, Apr 03, 2020 at 03:57:45PM +0200, Daniel Vetter wrote: > In drm we've added nice drm_device (the main gpu driver thing, which > also represents the userspace interfaces and has everything else > dangling off it) init functions using devres, devm_drm_dev_init and > soon devm_drm_dev_alloc (t

Re: [PATCH v2 1/1] lib/vsprintf: Add support for printing V4L2 and DRM fourccs

2020-04-03 Thread Mauro Carvalho Chehab
Em Fri, 3 Apr 2020 14:10:53 +0200 Rasmus Villemoes escreveu: > On 03/04/2020 11.11, Sakari Ailus wrote: > > Add a printk modifier %ppf (for pixel format) for printing V4L2 and DRM > > pixel formats denoted by 4ccs. The 4cc encoding is the same for both so > > the same implementation can be used.

Re: KMS enums and bitfields UAPI

2020-04-03 Thread Adam Jackson
On Fri, 2020-04-03 at 15:24 +0300, Pekka Paalanen wrote: > On Fri, 03 Apr 2020 10:15:21 + Simon Ser wrote: > > > Additionally, I've heard Pekka saying that it would be nice to have > > constants > > for property names in the UAPI headers. Indeed, this would prevent > > hard-to-debug typo iss

[PATCH v3 1/3] dt-bindings: display: panel: Convert feiyang, fy07024di26a30d to DT schema

2020-04-03 Thread Jagan Teki
Convert the feiyang,fy07024di26a30d panel bindings to DT schema. Signed-off-by: Jagan Teki --- Changes for v3: - update the licence, used (GPL-2.0-only OR BSD-2-Clause) since I'm the author for old binding - use panel-common.yaml - mark true for common properties - use maxItems: 1 for reg - up

[PATCH v3 2/3] dt-bindings: display: panel: Convert sitronix, st7701 to DT schema

2020-04-03 Thread Jagan Teki
Convert the sitronix,st7701 panel bindings to DT schema. Signed-off-by: Jagan Teki --- Changes for v3: - update the licence, used (GPL-2.0-only OR BSD-2-Clause) since I'm the author for old binding - use panel-common.yaml - mark true for common properties - use maxItems: 1 for reg - update exa

[PATCH v3 3/3] MAINTAINERS: Update feiyang, st7701 panel bindings converted as YAML

2020-04-03 Thread Jagan Teki
The feiyang,fy07024di26a30d.txt and sitronix,st7701.txt has been converted to YAML schemas, update MAINTAINERS to match them again. Signed-off-by: Jagan Teki --- Changes for v3: - none MAINTAINERS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS

Re: [PATCH 2/2] drm: delete drm_pci.h

2020-04-03 Thread Sam Ravnborg
Hi Daniel. On Fri, Apr 03, 2020 at 01:06:10PM +0200, Daniel Vetter wrote: > It's empty! > > After more than 20 years of OS abstraction layer for pci devices, it's > kinda gone now. > > Signed-off-by: Daniel Vetter Looks good, and survived my build testing. Acked-by: Sam Ravnborg > --- > dri

Re: [PATCH 01/44] drivers/base: Always release devres on device_del

2020-04-03 Thread Daniel Vetter
On Fri, Apr 3, 2020 at 4:17 PM Greg Kroah-Hartman wrote: > > On Fri, Apr 03, 2020 at 03:57:45PM +0200, Daniel Vetter wrote: > > In drm we've added nice drm_device (the main gpu driver thing, which > > also represents the userspace interfaces and has everything else > > dangling off it) init functi

Re: [PATCH 01/44] drivers/base: Always release devres on device_del

2020-04-03 Thread Daniel Vetter
On Fri, Apr 3, 2020 at 4:47 PM Daniel Vetter wrote: > > On Fri, Apr 3, 2020 at 4:17 PM Greg Kroah-Hartman > wrote: > > > > On Fri, Apr 03, 2020 at 03:57:45PM +0200, Daniel Vetter wrote: > > > In drm we've added nice drm_device (the main gpu driver thing, which > > > also represents the userspace

Re: [PATCH 01/44] drivers/base: Always release devres on device_del

2020-04-03 Thread Greg Kroah-Hartman
On Fri, Apr 03, 2020 at 04:51:33PM +0200, Daniel Vetter wrote: > On Fri, Apr 3, 2020 at 4:47 PM Daniel Vetter wrote: > > > > On Fri, Apr 3, 2020 at 4:17 PM Greg Kroah-Hartman > > wrote: > > > > > > On Fri, Apr 03, 2020 at 03:57:45PM +0200, Daniel Vetter wrote: > > > > In drm we've added nice drm_

Re: [PATCH 01/44] drivers/base: Always release devres on device_del

2020-04-03 Thread Greg Kroah-Hartman
On Fri, Apr 03, 2020 at 04:47:04PM +0200, Daniel Vetter wrote: > On Fri, Apr 3, 2020 at 4:17 PM Greg Kroah-Hartman > wrote: > > > > On Fri, Apr 03, 2020 at 03:57:45PM +0200, Daniel Vetter wrote: > > > In drm we've added nice drm_device (the main gpu driver thing, which > > > also represents the us

Re: [PATCH 01/44] drivers/base: Always release devres on device_del

2020-04-03 Thread Daniel Vetter
On Fri, Apr 3, 2020 at 5:06 PM Greg Kroah-Hartman wrote: > > On Fri, Apr 03, 2020 at 04:47:04PM +0200, Daniel Vetter wrote: > > On Fri, Apr 3, 2020 at 4:17 PM Greg Kroah-Hartman > > wrote: > > > > > > On Fri, Apr 03, 2020 at 03:57:45PM +0200, Daniel Vetter wrote: > > > > In drm we've added nice d

Re: [PATCH v3 1/4] drm/mediatek: Move tz_disabled from mtk_hdmi_phy to mtk_hdmi driver

2020-04-03 Thread Chun-Kuang Hu
Chunfeng Yun 於 2020年4月3日 週五 上午10:59寫道: > > On Thu, 2020-04-02 at 20:49 +0800, Chun-Kuang Hu wrote: > > Hi, Matthias: > > > > Matthias Brugger 於 2020年4月1日 週三 下午11:53寫道: > > > > > > > > > > > > On 01/04/2020 04:16, Chunfeng Yun wrote: > > > > On Tue, 2020-03-31 at 23:57 +0800, Chun-Kuang Hu wrote:

Re: [PATCH 01/44] drivers/base: Always release devres on device_del

2020-04-03 Thread Daniel Vetter
On Fri, Apr 3, 2020 at 5:15 PM Daniel Vetter wrote: > > On Fri, Apr 3, 2020 at 5:06 PM Greg Kroah-Hartman > wrote: > > > > On Fri, Apr 03, 2020 at 04:47:04PM +0200, Daniel Vetter wrote: > > > On Fri, Apr 3, 2020 at 4:17 PM Greg Kroah-Hartman > > > wrote: > > > > > > > > On Fri, Apr 03, 2020 at 0

RE: mainline/master bisection: baseline.login on peach-pi

2020-04-03 Thread Deucher, Alexander
[AMD Official Use Only - Internal Distribution Only] > -Original Message- > From: Guillaume Tucker > Sent: Friday, April 3, 2020 10:14 AM > To: Michael J. Ruhl ; Shane Francis > ; Deucher, Alexander > > Cc: kerne...@groups.io; dri-devel@lists.freedesktop.org; linux- > ker...@vger.kernel.

amdgpu dropping load callback triggers WARN_ON in __drm_mode_object_add

2020-04-03 Thread Michel Dänzer
I'm getting the attached WARNING splats since amdgpu dropped its load callback. They're from WARN_ON(!dev->driver->load && dev->registered && !obj_free_cb); in __drm_mode_object_add. I'm not sure how to address this, since obj_free_cb is always NULL here, and I don't think MST connector

Re: amdgpu dropping load callback triggers WARN_ON in __drm_mode_object_add

2020-04-03 Thread Daniel Vetter
On Fri, Apr 3, 2020 at 6:30 PM Michel Dänzer wrote: > > > I'm getting the attached WARNING splats since amdgpu dropped its load > callback. They're from > > WARN_ON(!dev->driver->load && dev->registered && !obj_free_cb); > > in __drm_mode_object_add. > > I'm not sure how to address this, s

Re: amdgpu dropping load callback triggers WARN_ON in __drm_mode_object_add

2020-04-03 Thread Daniel Vetter
5 seconds on irc and I've found the splat ... drm_properties need to be created at driver load time, upfront. You can attach them to hotpluggable drm_connector objects later on, but only before calling drm_connector_register(). The warning exists because i915 had the same bug :-) -Daniel On Fri,

Re: [PATCH v2 1/1] lib/vsprintf: Add support for printing V4L2 and DRM fourccs

2020-04-03 Thread Joe Perches
On Fri, 2020-04-03 at 14:10 +0200, Rasmus Villemoes wrote: > On 03/04/2020 11.11, Sakari Ailus wrote: > > Add a printk modifier %ppf (for pixel format) for printing V4L2 and DRM > > pixel formats denoted by 4ccs. The 4cc encoding is the same for both so > > the same implementation can be used. > >

  1   2   >