Re: [Mesa-dev] Plumbing explicit synchronization through the Linux ecosystem

2020-03-18 Thread Jacob Lifshay
On Tue, Mar 17, 2020 at 11:35 PM Jason Ekstrand wrote: > > On Wed, Mar 18, 2020 at 12:20 AM Jacob Lifshay > wrote: > > > > The main issue with doing everything immediately is that a lot of the > > function calls that games expect to take a very short time (e.g. > > vkQueueSubmit) would instead t

[PATCH] drm/hisilicon: Drop unused #include

2020-03-18 Thread Daniel Vetter
drm_encoder_slave is really not something anyone should be using, the last real user is only nouveau. Signed-off-by: Daniel Vetter Cc: Boris Brezillon Cc: Sam Ravnborg Cc: Daniel Vetter Cc: Tomi Valkeinen Cc: Allison Randal Cc: Thomas Gleixner Cc: Laurent Pinchart --- drivers/gpu/drm/hisi

Re: [PATCH RESEND] drm/lease: fix potential race in fill_object_idr

2020-03-18 Thread Daniel Vetter
On Tue, Mar 17, 2020 at 11:33 PM Qiujun Huang wrote: > > On Wed, Mar 18, 2020 at 1:02 AM Daniel Vetter wrote: > > > > On Mon, Mar 16, 2020 at 03:18:23PM +0800, Qiujun Huang wrote: > > > We should hold idr_mutex for idr_alloc. > > > > > > Signed-off-by: Qiujun Huang > > > > I've not seen the firs

Re: [PATCH] drm/hisilicon: Drop unused #include

2020-03-18 Thread Sam Ravnborg
On Wed, Mar 18, 2020 at 08:31:22AM +0100, Daniel Vetter wrote: > drm_encoder_slave is really not something anyone should be using, > the last real user is only nouveau. > > Signed-off-by: Daniel Vetter > Cc: Boris Brezillon > Cc: Sam Ravnborg > Cc: Daniel Vetter > Cc: Tomi Valkeinen > Cc: All

[PATCH v2] drm/lease: fix WARNING in idr_destroy

2020-03-18 Thread Qiujun Huang
drm_lease_create takes ownership of leases. And leases will be released by drm_master_put. drm_master_put ->drm_master_destroy ->idr_destroy So we needn't call idr_destroy again. Reported-and-tested-by: syzbot+05835159fe322770f...@syzkaller.appspotmail.com Signed-off-by: Qiujun H

Re: WARNING in idr_destroy

2020-03-18 Thread Qiujun Huang
#syz test: https://github.com/hqj/hqjagain_test.git idr_destroy ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [v2] dma-buf: heaps: bugfix for selftest failure

2020-03-18 Thread xiaolong he
Dear Shuah: > > @@ -357,7 +357,7 @@ static int test_alloc_errors(char *heap_name) > > if (heap_fd >= 0) > > close(heap_fd); > > > > - return ret; > > + return !ret; > > This change doesn't make sense. Initializing ret to 0 is a better > way to go. > I don't agree with

Re: [PATCH] dma-buf: heaps: bugfix for selftest failure

2020-03-18 Thread xiaolong he
> > On 3/3/20 10:34 PM, Leon He wrote: > > If the 'name' array in check_vgem() was not initialized to null, the > > value of name[4] may be random. Which will cause strcmp(name, "vgem") > > failed. > > Nit: "to fail" instead of "failed" OK, thanks! > > > > > > Signed-off-by: Leon He > > --- > >

[PATCH v4 3/4] dt-bindings: Add ANX7688 HDMI to DP bridge binding

2020-03-18 Thread Enric Balletbo i Serra
From: Nicolas Boichat Add documentation for DT properties supported by the ANX7688 HDMI-DP converter. Signed-off-by: Nicolas Boichat Signed-off-by: Hsin-Yi Wang Signed-off-by: Enric Balletbo i Serra --- Changes in v4: None Changes in v3: - Adapt the bridge bindings for the multi-function dev

[PATCH v4 4/4] drm/bridge: anx7688: Add ANX7688 bridge driver support

2020-03-18 Thread Enric Balletbo i Serra
From: Nicolas Boichat This driver adds support for the ANX7688 HDMI to DP converter block of the ANX7688 multi-function device. For our use case, the only reason the Linux kernel driver is necessary is to reject resolutions that require more bandwidth than what is available on the DP side. DP ba

Re: WARNING in idr_destroy

2020-03-18 Thread syzbot
Hello, syzbot has tested the proposed patch and the reproducer did not trigger crash: Reported-and-tested-by: syzbot+05835159fe322770f...@syzkaller.appspotmail.com Tested on: commit: b1289238 drm/lease: fix WARNING in idr_destroy git tree: https://github.com/hqj/hqjagain_test.git

Re: [Mesa-dev] Plumbing explicit synchronization through the Linux ecosystem

2020-03-18 Thread Michel Dänzer
On 2020-03-17 6:21 p.m., Lucas Stach wrote: > That's one of the issues with implicit sync that explicit may solve: > a single client taking way too much time to render something can > block the whole pipeline up until the display flip. With explicit > sync the compositor can just decide to use t

Re: [PATCH v1 08/36] dt-bindings: display: convert feiyang,fy07024di26a30d to DT Schema

2020-03-18 Thread Jagan Teki
Hi Sam Ravmborg, I send the series for panels which I worked already [1], would like to send the next version for those. will that work for you? [1] https://patchwork.kernel.org/cover/11315063/ Jagan. ___ dri-devel mailing list dri-devel@lists.freedesk

Re: [PATCH v1 08/36] dt-bindings: display: convert feiyang,fy07024di26a30d to DT Schema

2020-03-18 Thread Sam Ravnborg
Hi Jagan. On Wed, Mar 18, 2020 at 04:16:51PM +0530, Jagan Teki wrote: > Hi Sam Ravmborg, > > I send the series for panels which I worked already [1], would like to > send the next version for those. will that work for you? > > [1] https://patchwork.kernel.org/cover/11315063/ That would be great

Re: [PATCH] drm/hisilicon: Drop unused #include

2020-03-18 Thread Laurent Pinchart
Hi Daniel, On Wed, Mar 18, 2020 at 08:31:22AM +0100, Daniel Vetter wrote: > drm_encoder_slave is really not something anyone should be using, > the last real user is only nouveau. Fully agreed. Reviewed-by: Laurent Pinchart Is there any plan to convert nouveau to drm_bridge ? > Signed-off-by:

[PULL] drm-misc-fixes

2020-03-18 Thread Maarten Lankhorst
drm-misc-fixes-2020-03-18: drm-misc-fixes for v5.6: - Fix AVI frame colorimetry in the dw-hdmi bridge. - Fix compiler warning in komeda by annotating functions as __maybe_unused. - Downgrade bochs pci_request_region failure from error to warning to workaround firmware fb. The following changes si

Re: [PATCH v2] drm/lease: fix WARNING in idr_destroy

2020-03-18 Thread Daniel Vetter
On Wed, Mar 18, 2020 at 03:53:50PM +0800, Qiujun Huang wrote: > drm_lease_create takes ownership of leases. And leases will be released > by drm_master_put. > > drm_master_put > ->drm_master_destroy > ->idr_destroy > > So we needn't call idr_destroy again. > > Reported-and-tested

Re: [PATCH] drm/hisilicon: Drop unused #include

2020-03-18 Thread Laurent Pinchart
On Wed, Mar 18, 2020 at 02:30:24PM +0100, Daniel Vetter wrote: > On Wed, Mar 18, 2020 at 01:09:37PM +0200, Laurent Pinchart wrote: > > Hi Daniel, > > > > On Wed, Mar 18, 2020 at 08:31:22AM +0100, Daniel Vetter wrote: > > > drm_encoder_slave is really not something anyone should be using, > > > the

Re: [PATCH] drm/hisilicon: Drop unused #include

2020-03-18 Thread Daniel Vetter
On Wed, Mar 18, 2020 at 01:09:37PM +0200, Laurent Pinchart wrote: > Hi Daniel, > > On Wed, Mar 18, 2020 at 08:31:22AM +0100, Daniel Vetter wrote: > > drm_encoder_slave is really not something anyone should be using, > > the last real user is only nouveau. > > Fully agreed. > > Reviewed-by: Laure

Re: [PATCH 2/3] drm: Create a drm_connector_helper_funcs hook for Adaptive Sync support

2020-03-18 Thread Harry Wentland
On 2020-03-18 2:35 a.m., Manasi Navare wrote: > This patch adds a hook in drm_connector_helper_funcs to get the > support of the driver for adaptive sync functionality. > > This can be called in the connector probe helper function after > the connector detect() and get_modes() hooks to also > quer

Re: [PATCH 1/9] drm/vblank: Add vblank works

2020-03-18 Thread Daniel Vetter
On Tue, Mar 17, 2020 at 08:40:58PM -0400, Lyude Paul wrote: > From: Ville Syrjälä > > Add some kind of vblank workers. The interface is similar to regular > delayed works, and also allows for re-scheduling. > > Whatever hardware programming we do in the work must be fast > (must at least complet

Re: [PATCH 1/3] drm: drm_vm: Use fallthrough;

2020-03-18 Thread Daniel Vetter
On Tue, Mar 17, 2020 at 03:13:29PM -0700, Joe Perches wrote: > On Tue, 2020-03-17 at 17:48 +0100, Daniel Vetter wrote: > > On Thu, Mar 12, 2020 at 12:17:12PM -0700, Joe Perches wrote: > > > Convert /* fallthrough */ style comments to fallthrough; > > > > > > Convert the various uses of fallthrough

Re: [PATCH v2] drm: Correct a typo in a function comment

2020-03-18 Thread Daniel Vetter
On Tue, Mar 17, 2020 at 06:03:39PM -0300, Igor Matheus Andrade Torrente wrote: > Replace "pionter" with "pointer" in the drm_gem_handle_create description. > > Changes in v2: > - Change subject text > > Signed-off-by: Igor Matheus Andrade Torrente Thanks for your patch, queued for 5.8 in drm-mi

[PULL] drm-misc-fixes

2020-03-18 Thread Maarten Lankhorst
drm-misc-fixes-2020-03-18-1: One more fix for v5.6: - drm/lease: fix WARNING in idr_destroy The following changes since commit 1b79cfd99ff5127e6a143767b51694a527b3ea38: drm: kirin: Revert "Fix for hikey620 display offset problem" (2020-03-04 13:29:05 +) are available in the Git repository

Atomic KMS API lacks the ability to set cursor hot-spot coordinates

2020-03-18 Thread Hans de Goede
Hi All, I'm not sure if $subject was a conscious design decision, or an oversight, but that does not really matter. ATM the Atomic KMS API lacks the ability to set cursor hot-spot coordinates. Mutter (and Weston) have tried to emulate this by shifting the coordinates for where to draw the cursor

Re: Atomic KMS API lacks the ability to set cursor hot-spot coordinates

2020-03-18 Thread Simon Ser
Hi, > 1) Letting the VM-viewer window-system draw the cursor as it normally > would draw it. Why is this important? Can't the VM viewer hide the cursor and use a sub-surface to manually draw the cursor plane configured by the guest? This would also allow the compositor running inside the VM to c

Re: Atomic KMS API lacks the ability to set cursor hot-spot coordinates

2020-03-18 Thread Hans de Goede
Hi, On 3/18/20 3:28 PM, Hans de Goede wrote: Hi All, I'm not sure if $subject was a conscious design decision, or an oversight, but that does not really matter. ATM the Atomic KMS API lacks the ability to set cursor hot-spot coordinates. Mutter (and Weston) have tried to emulate this by shifti

Re: Atomic KMS API lacks the ability to set cursor hot-spot coordinates

2020-03-18 Thread Hans de Goede
Hi, On 3/18/20 3:38 PM, Simon Ser wrote: Hi, 1) Letting the VM-viewer window-system draw the cursor as it normally would draw it. Why is this important? Can't the VM viewer hide the cursor and use a sub-surface to manually draw the cursor plane configured by the guest? Because then moving

[PATCH v9 0/2] drm: bridge: Add NWL MIPI DSI host controller support

2020-03-18 Thread Guido Günther
This adds initial support for the NWL MIPI DSI Host controller found on i.MX8 SoCs. It adds support for the i.MX8MQ but the same IP core can also be found on e.g. i.MX8QXP. I added the necessary hooks to support other imx8 variants but since I only have imx8mq boards to test I omitted the platform

[PATCH v9 1/2] dt-bindings: display/bridge: Add binding for NWL mipi dsi host controller

2020-03-18 Thread Guido Günther
The Northwest Logic MIPI DSI IP core can be found in NXPs i.MX8 SoCs. Signed-off-by: Guido Günther Tested-by: Robert Chiras Reviewed-by: Rob Herring --- .../bindings/display/bridge/nwl-dsi.yaml | 216 ++ 1 file changed, 216 insertions(+) create mode 100644 Documentation/

[PATCH v9 2/2] drm/bridge: Add NWL MIPI DSI host controller support

2020-03-18 Thread Guido Günther
This adds initial support for the NWL MIPI DSI Host controller found on i.MX8 SoCs. It adds support for the i.MX8MQ but the same IP can be found on e.g. the i.MX8QXP. It has been tested on the Librem 5 devkit using mxsfb. Signed-off-by: Guido Günther Co-developed-by: Robert Chiras Signed-off-b

Re: Atomic KMS API lacks the ability to set cursor hot-spot coordinates

2020-03-18 Thread Daniel Vetter
On Wed, Mar 18, 2020 at 3:29 PM Hans de Goede wrote: > > Hi All, > > I'm not sure if $subject was a conscious design decision, or an oversight, > but that does not really matter. > > ATM the Atomic KMS API lacks the ability to set cursor hot-spot > coordinates. Mutter (and Weston) have tried to em

[GIT PULL] Immutable branch between Backlight, Arm, Unicore32 and PWM due for the v5.7 merge window

2020-03-18 Thread Lee Jones
Enjoy! The following changes since commit bb6d3fb354c5ee8d6bde2d576eb7220ea09862b9: Linux 5.6-rc1 (2020-02-09 16:08:48 -0800) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/lee/backlight.git ib-backlight-arm-unicore-pwm-v5.7 for you to fetch changes

Re: Atomic KMS API lacks the ability to set cursor hot-spot coordinates

2020-03-18 Thread Simon Ser
> Hi, > > On 3/18/20 3:38 PM, Simon Ser wrote: > > Hi, > > > >> 1) Letting the VM-viewer window-system draw the cursor as it normally > >> would draw it. > > > > Why is this important? Can't the VM viewer hide the cursor and use a > > sub-surface to manually draw the cursor plane configured by the

Re: [PATCH v2 10/17] drm/vram-helper: make drm_vram_mm_debugfs_init() return 0

2020-03-18 Thread Daniel Vetter
On Tue, Mar 10, 2020 at 04:31:14PM +0300, Wambui Karuga wrote: > Since 987d65d01356 (drm: debugfs: make > drm_debugfs_create_files() never fail), drm_debugfs_create_files() never > fails and should return void. Therefore, remove its use as the > return value of drm_vram_mm_debugfs_init(), and have

[PATCH v11 4/5] arm64: dts: zynqmp: Add DisplayPort subsystem

2020-03-18 Thread Laurent Pinchart
Add a DT node for the DisplayPort subsystem, a hard IP present in the Zynq Ultrascale+ MPSoC. Signed-off-by: Laurent Pinchart --- Changes since v10: - Replace fixed frequency clocks with real clocks - Add resets property to zynqmp-dpsub Changes since v9: - Update to the latest DPDMA DT binding

[PATCH v11 0/5] Xilinx ZynqMP DisplayPort Subsystem DRM/KMS driver

2020-03-18 Thread Laurent Pinchart
Hello, Here's a new version of the Xilinx ZynqMP DisplayPort Subsystem driver, the third version since I took over v8 of the series ([1]) from Hyun. This new version is rebased on top of the DMA engine and PHY driver changes. In particular, it uses the new interleaved cyclic DMA transaction type

[PATCH v11 5/5] arm64: dts: zynqmp: zcu106-revA: Wire up the DisplayPort subsystem

2020-03-18 Thread Laurent Pinchart
Enable the dpsub device and wire it up to the PS-GTR PHY lanes routed to the DisplayPort connector. Signed-off-by: Laurent Pinchart --- .../boot/dts/xilinx/zynqmp-zcu106-revA.dts| 29 +++ 1 file changed, 29 insertions(+) diff --git a/arch/arm64/boot/dts/xilinx/zynqmp-zcu106-

[PATCH v11 3/5] arm64: dts: zynqmp: Add reset controller

2020-03-18 Thread Laurent Pinchart
Add a DT node for the reset controller, handled through the firmware interface. Signed-off-by: Laurent Pinchart --- arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi ind

[PATCH v11 1/5] dt-bindings: display: xlnx: Add ZynqMP DP subsystem bindings

2020-03-18 Thread Laurent Pinchart
From: Hyun Kwon The bindings describe the ZynqMP DP subsystem. They don't support the interface with the programmable logic (FPGA) or audio yet. Signed-off-by: Hyun Kwon Signed-off-by: Laurent Pinchart Reviewed-by: Rob Herring --- Changes since v10: - Update example to new PHY DT bindings wi

Re: [PATCH] MAINTAINERS: Better regex for dma_buf|fence|resv

2020-03-18 Thread Sumit Semwal
Hello Daniel, Thanks for the patch. On Wed, 18 Mar 2020 at 02:26, Daniel Vetter wrote: > > We're getting some random other stuff that we're not really interested > in, so match only word boundaries. Also avoid the capture group while > at it. > > Suggested by Joe Perches. > > Cc: linux-me...@vge

[PATCH] drm: Reject dumb buffers when driver/device doesn't support modesetting

2020-03-18 Thread Ville Syrjala
From: Ville Syrjälä Currently a driver must not provide a .dumb_create() hook in the drm_driver structure if it wants to declare dumb buffers as not supported. So if the same driver wants to support both modeset and non-modeset devices it would require two distinct drm_driver structures in order

Re: [PATCH 1/9] drm: Constify topology id

2020-03-18 Thread Ville Syrjälä
On Fri, Mar 13, 2020 at 04:05:00PM -0400, Alex Deucher wrote: > On Fri, Mar 13, 2020 at 12:21 PM Ville Syrjala > wrote: > > > > From: Ville Syrjälä > > > > Make the topology id const since we don't want to change it. > > > > Signed-off-by: Ville Syrjälä > > Series is: > Reviewed-by: Alex Deuche

Re: [PATCH v2 10/17] drm/vram-helper: make drm_vram_mm_debugfs_init() return 0

2020-03-18 Thread Daniel Vetter
On Wed, Mar 18, 2020 at 5:03 PM Wambui Karuga wrote: > > > > On Wed, 18 Mar 2020, Daniel Vetter wrote: > > > On Tue, Mar 10, 2020 at 04:31:14PM +0300, Wambui Karuga wrote: > >> Since 987d65d01356 (drm: debugfs: make > >> drm_debugfs_create_files() never fail), drm_debugfs_create_files() never > >>

Re: [PATCH v3 7/7] drm: Allow drivers to leave encoder->possible_crtcs==0

2020-03-18 Thread Ville Syrjälä
On Wed, Feb 12, 2020 at 10:08:49AM +0100, Daniel Vetter wrote: > On Wed, Feb 12, 2020 at 10:07:55AM +0100, Daniel Vetter wrote: > > On Tue, Feb 11, 2020 at 07:14:51PM +0200, Ville Syrjälä wrote: > > > On Tue, Feb 11, 2020 at 06:05:45PM +0100, Daniel Vetter wrote: > > > > On Tue, Feb 11, 2020 at 06:

Re: [PATCH 1/3] drm: drm_vm: Use fallthrough;

2020-03-18 Thread Joe Perches
On Wed, 2020-03-18 at 14:49 +0100, Daniel Vetter wrote: > On Tue, Mar 17, 2020 at 03:13:29PM -0700, Joe Perches wrote: > > On Tue, 2020-03-17 at 17:48 +0100, Daniel Vetter wrote: > > > On Thu, Mar 12, 2020 at 12:17:12PM -0700, Joe Perches wrote: > > > > Convert /* fallthrough */ style comments to f

Re: [PATCH] MAINTAINERS: Better regex for dma_buf|fence|resv

2020-03-18 Thread Daniel Vetter
On Wed, Mar 18, 2020 at 09:16:17PM +0530, Sumit Semwal wrote: > Hello Daniel, > > Thanks for the patch. > > On Wed, 18 Mar 2020 at 02:26, Daniel Vetter wrote: > > > > We're getting some random other stuff that we're not really interested > > in, so match only word boundaries. Also avoid the capt

Re: [PATCH v2 00/17] drm: subsytem-wide debugfs functions refactor

2020-03-18 Thread Daniel Vetter
On Tue, Mar 10, 2020 at 03:33:07PM +0100, Greg KH wrote: > On Tue, Mar 10, 2020 at 04:31:04PM +0300, Wambui Karuga wrote: > > This series includes work on various debugfs functions both in drm/core > > and across various drivers in the subsystem. > > Since commit 987d65d01356 (drm: debugfs: make dr

Re: [PATCH v2 10/17] drm/vram-helper: make drm_vram_mm_debugfs_init() return 0

2020-03-18 Thread Greg KH
On Wed, Mar 18, 2020 at 05:31:47PM +0100, Daniel Vetter wrote: > On Wed, Mar 18, 2020 at 5:03 PM Wambui Karuga > wrote: > > > > > > > > On Wed, 18 Mar 2020, Daniel Vetter wrote: > > > > > On Tue, Mar 10, 2020 at 04:31:14PM +0300, Wambui Karuga wrote: > > >> Since 987d65d01356 (drm: debugfs: make

[PATCH v2 1/3] dt-bindings: display: panel: Convert feiyang, fy07024di26a30d to DT schema

2020-03-18 Thread Jagan Teki
Convert the feiyang,fy07024di26a30d panel bindings to DT schema. Signed-off-by: Jagan Teki --- Changes for v2: - fix dt_binding_check .../display/panel/feiyang,fy07024di26a30d.txt | 20 --- .../panel/feiyang,fy07024di26a30d.yaml| 57 +++ 2 files changed, 57 insertio

[PATCH v2 2/3] dt-bindings: display: panel: Convert sitronix, st7701 to DT schema

2020-03-18 Thread Jagan Teki
Convert the sitronix,st7701 panel bindings to DT schema. Signed-off-by: Jagan Teki --- Changes for v2: - fix dt_binding_check .../display/panel/sitronix,st7701.txt | 30 .../display/panel/sitronix,st7701.yaml| 68 +++ 2 files changed, 68 insertions(+),

[PATCH v2 3/3] MAINTAINERS: Update feiyang, st7701 panel bindings converted as YAML

2020-03-18 Thread Jagan Teki
The feiyang,fy07024di26a30d.txt and sitronix,st7701.txt has been converted to YAML schemas, update MAINTAINERS to match them again. Signed-off-by: Jagan Teki --- Changes for v2: - none MAINTAINERS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS

[PATCH] drm: Skip drm_mode_config_validate() for !modeset

2020-03-18 Thread Ville Syrjala
From: Ville Syrjälä drm_mode_config_init() may not have been called when the driver/device doesn't support modeset. That will cause drm_mode_config_validate() to oops. Skip the validation for !modeset. TODO: We may want to consider calling drm_mode_config_init() unconditionally to avoid similar

Re: [PATCH] drm: Skip drm_mode_config_validate() for !modeset

2020-03-18 Thread Chris Wilson
Quoting Ville Syrjala (2020-03-18 18:25:18) > From: Ville Syrjälä > > drm_mode_config_init() may not have been called when the driver/device > doesn't support modeset. That will cause drm_mode_config_validate() > to oops. Skip the validation for !modeset. > > TODO: We may want to consider callin

Re: [PATCH v2 1/3] dt-bindings: display: panel: Convert feiyang, fy07024di26a30d to DT schema

2020-03-18 Thread Sam Ravnborg
Hi Jagan. On Wed, Mar 18, 2020 at 10:40:01PM +0530, Jagan Teki wrote: > Convert the feiyang,fy07024di26a30d panel bindings to DT schema. > > Signed-off-by: Jagan Teki Thanks for the resend. Please fix so the two bindings uses panel-common.yaml. And then only properties specific for this bindi

Re: [PATCH v2 3/3] MAINTAINERS: Update feiyang, st7701 panel bindings converted as YAML

2020-03-18 Thread Sam Ravnborg
On Wed, Mar 18, 2020 at 10:40:03PM +0530, Jagan Teki wrote: > The feiyang,fy07024di26a30d.txt and sitronix,st7701.txt has been > converted to YAML schemas, update MAINTAINERS to match them again. > > Signed-off-by: Jagan Teki The patch is fine. I just dislike we repeat the maintainer info in two

Re: [PATCH v9 01/11] drm/i915: Use 64-bit division macro

2020-03-18 Thread Jani Nikula
On Tue, 17 Mar 2020, Guru Das Srinagesh wrote: > Since the PWM framework is switching struct pwm_state.duty_cycle's > datatype to u64, prepare for this transition by using DIV_ROUND_UP_ULL > to handle a 64-bit dividend. > > Cc: Jani Nikula > Cc: Joonas Lahtinen > Cc: David Airlie > Cc: Daniel V

Re: [PATCH v2 10/17] drm/vram-helper: make drm_vram_mm_debugfs_init() return 0

2020-03-18 Thread Daniel Vetter
On Wed, Mar 18, 2020 at 5:58 PM Greg KH wrote: > > On Wed, Mar 18, 2020 at 05:31:47PM +0100, Daniel Vetter wrote: > > On Wed, Mar 18, 2020 at 5:03 PM Wambui Karuga > > wrote: > > > > > > > > > > > > On Wed, 18 Mar 2020, Daniel Vetter wrote: > > > > > > > On Tue, Mar 10, 2020 at 04:31:14PM +0300,

Re: [PATCH] drm: rework SET_MASTER and DROP_MASTER perm handling

2020-03-18 Thread Daniel Vetter
On Tue, Mar 17, 2020 at 1:26 PM Emil Velikov wrote: > > On Mon, 2 Mar 2020 at 18:29, Emil Velikov wrote: > > > > On Wed, 19 Feb 2020 at 13:27, Emil Velikov wrote: > > > > > > From: Emil Velikov > > > > > > This commit reworks the permission handling of the two ioctls. In > > > particular it enf

Re: [PATCH] drm/i915/dp: Add dpcd link_rate quirk for Apple 15" MBP 2017 (v3)

2020-03-18 Thread Jani Nikula
On Mon, 16 Mar 2020, Mario Kleiner wrote: > This fixes a problem found on the MacBookPro 2017 Retina panel. > > The panel reports 10 bpc color depth in its EDID, and the > firmware chooses link settings at boot which support enough > bandwidth for 10 bpc (324000 kbit/sec = multiplier 0xc), > but t

Re: [PATCH v11 1/5] dt-bindings: display: xlnx: Add ZynqMP DP subsystem bindings

2020-03-18 Thread Sam Ravnborg
On Wed, Mar 18, 2020 at 05:37:24PM +0200, Laurent Pinchart wrote: > From: Hyun Kwon > > The bindings describe the ZynqMP DP subsystem. They don't support the > interface with the programmable logic (FPGA) or audio yet. > > Signed-off-by: Hyun Kwon > Signed-off-by: Laurent Pinchart > Reviewed-b

Re: [PATCH] drm: Skip drm_mode_config_validate() for !modeset

2020-03-18 Thread Ville Syrjälä
On Wed, Mar 18, 2020 at 06:31:16PM +, Chris Wilson wrote: > Quoting Ville Syrjala (2020-03-18 18:25:18) > > From: Ville Syrjälä > > > > drm_mode_config_init() may not have been called when the driver/device > > doesn't support modeset. That will cause drm_mode_config_validate() > > to oops. S

Re: [PATCH] drm/amdgpu: Initialize shadow to false in gfx_v9_0_rlcg_wreg

2020-03-18 Thread Joe Perches
On Tue, 2020-03-17 at 17:25 -0700, Nathan Chancellor wrote: > clang warns: > > drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c:754:6: warning: variable 'shadow' > is used uninitialized whenever 'if' condition is > false [-Wsometimes-uninitialized] > if (offset == grbm_cntl || offset == grbm_idx) >

Re: [PATCH] drm: Reject dumb buffers when driver/device doesn't support modesetting

2020-03-18 Thread Matt Roper
On Wed, Mar 18, 2020 at 05:49:59PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Currently a driver must not provide a .dumb_create() hook in the > drm_driver structure if it wants to declare dumb buffers as not > supported. So if the same driver wants to support both modeset > and non-mo

Re: [PATCH v11 2/5] drm: xlnx: DRM/KMS driver for Xilinx ZynqMP DisplayPort Subsystem

2020-03-18 Thread Sam Ravnborg
Hi Laurent. Some drive by comments, I tired to do a full review but lost the full picture. Sam General comments: - The newly introduced drm_err() and friends could repalce uses of dev_err() & co. in some/most places - The dirver uses the xilinx specific term "layer" where DRM uses plan

Re: [PATCH] drm: Reject dumb buffers when driver/device doesn't support modesetting

2020-03-18 Thread Ville Syrjälä
On Wed, Mar 18, 2020 at 01:31:07PM -0700, Matt Roper wrote: > On Wed, Mar 18, 2020 at 05:49:59PM +0200, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Currently a driver must not provide a .dumb_create() hook in the > > drm_driver structure if it wants to declare dumb buffers as not > > sup

[PATCH AUTOSEL 5.4 41/73] drm/amd/display: update soc bb for nv14

2020-03-18 Thread Sasha Levin
From: Martin Leung [ Upstream commit d5349775c1726ce997b8eb4982cd85a01f1c8b42 ] [why] nv14 previously inherited soc bb from generic dcn 2, did not match watermark values according to memory team [how] add nv14 specific soc bb: copy nv2 generic that it was using from before, but changed num chan

[PATCH AUTOSEL 5.4 42/73] drm/amdgpu: correct ROM_INDEX/DATA offset for VEGA20

2020-03-18 Thread Sasha Levin
From: Hawking Zhang [ Upstream commit f1c2cd3f8fb959123a9beba18c0e8112dcb2e137 ] The ROMC_INDEX/DATA offset was changed to e4/e5 since from smuio_v11 (vega20/arcturus). Signed-off-by: Hawking Zhang Tested-by: Candice Li Reviewed-by: Candice Li Signed-off-by: Alex Deucher Signed-off-by: Sash

[PATCH AUTOSEL 5.4 48/73] drm/exynos: Fix cleanup of IOMMU related objects

2020-03-18 Thread Sasha Levin
From: Marek Szyprowski [ Upstream commit 07dc3678bacc2a75b1900febea7d996a31f178a2 ] Store the IOMMU mapping created by the device core of each Exynos DRM sub-device and restore it when the Exynos DRM driver is unbound. This fixes IOMMU initialization failure for the second time when a deferred p

Re: [PATCH v9 2/2] drm/bridge: Add NWL MIPI DSI host controller support

2020-03-18 Thread Sam Ravnborg
Hi Guido. Impressive and very detailed changelog in intro mail - nice. On Wed, Mar 18, 2020 at 04:09:08PM +0100, Guido Günther wrote: > This adds initial support for the NWL MIPI DSI Host controller found on > i.MX8 SoCs. > > It adds support for the i.MX8MQ but the same IP can be found on > e.g.

Re: [PATCH v9 1/2] dt-bindings: display/bridge: Add binding for NWL mipi dsi host controller

2020-03-18 Thread Sam Ravnborg
On Wed, Mar 18, 2020 at 04:09:07PM +0100, Guido Günther wrote: > The Northwest Logic MIPI DSI IP core can be found in NXPs i.MX8 SoCs. > > Signed-off-by: Guido Günther > Tested-by: Robert Chiras > Reviewed-by: Rob Herring Acked-by: Sam Ravnborg > --- > .../bindings/display/bridge/nwl-dsi.yam

Re: [PATCH v1 07/36] dt-bindings: display: convert ilitek,ili9881c to DT Schema

2020-03-18 Thread Rob Herring
On Sun, 15 Mar 2020 14:43:47 +0100, Sam Ravnborg wrote: > Signed-off-by: Sam Ravnborg > Cc: Maxime Ripard > Cc: Thierry Reding > Cc: Sam Ravnborg > --- > .../display/panel/ilitek,ili9881c.txt | 20 > .../display/panel/ilitek,ili9881c.yaml| 50 +++ > 2 f

Re: Atomic KMS API lacks the ability to set cursor hot-spot coordinates

2020-03-18 Thread Hans de Goede
Hi, On 3/18/20 4:09 PM, Daniel Vetter wrote: On Wed, Mar 18, 2020 at 3:29 PM Hans de Goede wrote: Hi All, I'm not sure if $subject was a conscious design decision, or an oversight, but that does not really matter. ATM the Atomic KMS API lacks the ability to set cursor hot-spot coordinates.

Re: Ack to merge through DRM? WAS [PATCH v6 0/9] Huge page-table entries for TTM

2020-03-18 Thread Andrew Morton
On Mon, 16 Mar 2020 13:32:08 +0100 Thomas Hellström (VMware) wrote: > > ___ > > dri-devel mailing list > > dri-devel@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/dri-devel > > Andrew, would it be possible to have an ack for

Re: [PATCH v11 1/5] dt-bindings: display: xlnx: Add ZynqMP DP subsystem bindings

2020-03-18 Thread Hyun Kwon
Hi Sam, On Wed, 2020-03-18 at 12:26:51 -0700, Sam Ravnborg wrote: > On Wed, Mar 18, 2020 at 05:37:24PM +0200, Laurent Pinchart wrote: > > From: Hyun Kwon > > > > The bindings describe the ZynqMP DP subsystem. They don't support the > > interface with the programmable logic (FPGA) or audio yet. >

Re: [PATCH v11 1/5] dt-bindings: display: xlnx: Add ZynqMP DP subsystem bindings

2020-03-18 Thread Laurent Pinchart
Hi Sam, On Wed, Mar 18, 2020 at 08:26:51PM +0100, Sam Ravnborg wrote: > On Wed, Mar 18, 2020 at 05:37:24PM +0200, Laurent Pinchart wrote: > > From: Hyun Kwon > > > > The bindings describe the ZynqMP DP subsystem. They don't support the > > interface with the programmable logic (FPGA) or audio ye

[pull] amdgpu 5.6 fixes

2020-03-18 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 5.6. The following changes since commit 16b78f052d0129cd2998305480da6c4e3ac220a8: Merge tag 'topic/mst-bw-check-fixes-for-airlied-2020-03-12-2' of git://anongit.freedesktop.org/drm/drm-misc into drm-fixes (2020-03-13 10:38:25 +1000) are available in the Git reposi

[GIT PULL] mediatek drm next for 5.7

2020-03-18 Thread CK Hu
Hi, Dave & Daniel: This include MT8183 DPI support. And I change my email address to "Chun-Kuang Hu ", so I would use it afterward. Regards, CK The following changes since commit bb6d3fb354c5ee8d6bde2d576eb7220ea09862b9: Linux 5.6-rc1 (2020-02-09 16:08:48 -0800) are available in the Git rep

Re: [PATCH v1 03/36] dt-bindings: display: convert samsung,s6e63m0 to DT Schema

2020-03-18 Thread Rob Herring
On Sun, Mar 15, 2020 at 02:43:43PM +0100, Sam Ravnborg wrote: > The binding for this panel is a SPI slave. > Reference spi-slave.yaml > to avoid duplicating all properties. > > Signed-off-by: Sam Ravnborg > Cc: Jonathan Bakker > Cc: Thierry Reding > Cc: Sam Ravnborg > --- > .../display/panel/

Re: [PATCH v1 04/36] dt-bindings: display: convert arm,versatile-tft-panel to DT Schema

2020-03-18 Thread Rob Herring
On Sun, Mar 15, 2020 at 02:43:44PM +0100, Sam Ravnborg wrote: > Signed-off-by: Sam Ravnborg > Cc: Linus Walleij > Cc: Thierry Reding > Cc: Sam Ravnborg > --- > .../display/panel/arm,versatile-tft-panel.txt | 31 --- > .../panel/arm,versatile-tft-panel.yaml| 51 +

Re: [PATCH v1 12/36] dt-bindings: display: convert jdi,lt070me05000 to DT Schema

2020-03-18 Thread Rob Herring
On Sun, Mar 15, 2020 at 02:43:52PM +0100, Sam Ravnborg wrote: > Signed-off-by: Sam Ravnborg > Cc: Vinay Simha BN > Cc: Thierry Reding > Cc: Sam Ravnborg > --- > .../display/panel/jdi,lt070me05000.txt| 31 - > .../display/panel/jdi,lt070me05000.yaml | 69 ++

Re: [PATCH v1 16/36] dt-bindings: display: convert lg,lg4573 to DT Schema

2020-03-18 Thread Rob Herring
On Sun, Mar 15, 2020 at 02:43:56PM +0100, Sam Ravnborg wrote: > Signed-off-by: Sam Ravnborg > Cc: Heiko Schocher > Cc: Thierry Reding > Cc: Sam Ravnborg > --- > .../bindings/display/panel/lg,lg4573.txt | 19 - > .../bindings/display/panel/lg,lg4573.yaml | 41 ++

Re: [PATCH v1 18/36] dt-bindings: display: convert raydium,rm67191 to DT Schema

2020-03-18 Thread Rob Herring
On Sun, Mar 15, 2020 at 02:43:58PM +0100, Sam Ravnborg wrote: > Signed-off-by: Sam Ravnborg > Cc: Robert Chiras > Cc: Thierry Reding > Cc: Sam Ravnborg > --- > .../display/panel/raydium,rm67191.txt | 41 -- > .../display/panel/raydium,rm67191.yaml| 75 ++

Re: [PATCH v1 22/36] dt-bindings: display: convert samsung, ld9040 to DT Schema

2020-03-18 Thread Rob Herring
On Sun, Mar 15, 2020 at 02:44:02PM +0100, Sam Ravnborg wrote: > Signed-off-by: Sam Ravnborg > Cc: Andrzej Hajda > Cc: Thierry Reding > Cc: Sam Ravnborg > --- > .../bindings/display/panel/samsung,ld9040.txt | 66 > .../display/panel/samsung,ld9040.yaml | 100 ++

Re: [PATCH v1 26/36] dt-bindings: display: convert sony, acx565akm to DT Schema

2020-03-18 Thread Rob Herring
On Sun, Mar 15, 2020 at 02:44:06PM +0100, Sam Ravnborg wrote: > Signed-off-by: Sam Ravnborg > Cc: Tomi Valkeinen > Cc: Thierry Reding > Cc: Sam Ravnborg > --- > .../bindings/display/panel/sony,acx565akm.txt | 30 --- > .../display/panel/sony,acx565akm.yaml | 53

Re: [PATCH v1 32/36] dt-bindings: display: convert sharp, ls037v7dw01 to DT Schema

2020-03-18 Thread Rob Herring
On Sun, Mar 15, 2020 at 02:44:12PM +0100, Sam Ravnborg wrote: > Signed-off-by: Sam Ravnborg > Cc: Tony Lindgren > Cc: Thierry Reding > Cc: Sam Ravnborg > --- > .../display/panel/sharp,ls037v7dw01.txt | 43 > .../display/panel/sharp,ls037v7dw01.yaml | 66

Re: [PATCH v1 36/36] dt-bindings: display: convert olimex,lcd-olinuxino to DT Schema

2020-03-18 Thread Rob Herring
On Sun, Mar 15, 2020 at 02:44:16PM +0100, Sam Ravnborg wrote: > Signed-off-by: Sam Ravnborg > Cc: Stefan Mavrodiev > Cc: Thierry Reding > Cc: Sam Ravnborg > --- > .../display/panel/olimex,lcd-olinuxino.txt| 42 --- > .../display/panel/olimex,lcd-olinuxino.yaml | 70 ++

Re: [PATCH][next] drm: amd: fix spelling mistake "shoudn't" -> "shouldn't"

2020-03-18 Thread Alex Deucher
On Tue, Mar 17, 2020 at 7:47 AM Colin King wrote: > > From: Colin Ian King > > There are spelling mistakes in pr_err messages and a comment. Fix these. > > Signed-off-by: Colin Ian King The relevant code was recently dropped so no longer applies. Thanks! Alex > --- > drivers/gpu/drm/amd/amd

Re: [PATCH v2] drm/amdgpu: Remove unnecessary variable shadow in gfx_v9_0_rlcg_wreg

2020-03-18 Thread Alex Deucher
On Wed, Mar 18, 2020 at 5:08 PM Nick Desaulniers wrote: > > On Wed, Mar 18, 2020 at 2:05 PM Nathan Chancellor > wrote: > > > > clang warns: > > > > drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c:754:6: warning: variable 'shadow' > > is used uninitialized whenever 'if' condition is > > false [-Wsometimes-u

Re: [PATCH][next] drm: amd: fix spelling mistake "shoudn't" -> "shouldn't"

2020-03-18 Thread Alex Deucher
On Wed, Mar 18, 2020 at 11:10 PM Alex Deucher wrote: > > On Tue, Mar 17, 2020 at 7:47 AM Colin King wrote: > > > > From: Colin Ian King > > > > There are spelling mistakes in pr_err messages and a comment. Fix these. > > > > Signed-off-by: Colin Ian King > > The relevant code was recently dropp

Re: [PATCH v1 31/36] dt-bindings: display: convert sharp, lq101r1sx01 to DT Schema

2020-03-18 Thread Rob Herring
On Sun, Mar 15, 2020 at 02:44:11PM +0100, Sam Ravnborg wrote: > This bindings describes a panel with a secondary channel. > > A few of the properties are only required for the > main (non-secondary) node. > This is properly described in the binding. > > A few properties are only valid for the mai

Re: [PATCH v1 18/36] dt-bindings: display: convert raydium,rm67191 to DT Schema

2020-03-18 Thread Rob Herring
On Wed, Mar 18, 2020 at 08:58:15PM -0600, Rob Herring wrote: > On Sun, Mar 15, 2020 at 02:43:58PM +0100, Sam Ravnborg wrote: > > Signed-off-by: Sam Ravnborg > > Cc: Robert Chiras > > Cc: Thierry Reding > > Cc: Sam Ravnborg > > --- > > .../display/panel/raydium,rm67191.txt | 41

Re: [PATCH v1 0/36] dt-bindings: display: convert remaning panel bindings to DT Schema

2020-03-18 Thread Rob Herring
On Sun, Mar 15, 2020 at 02:43:40PM +0100, Sam Ravnborg wrote: > Convert remaining(*) panel bindings to DT Schema. > > To prepare for the migration a few preparations > patches was required: > > - te-gpios is now added to panel-common - as this > property is used by a few bindings. > > - The sl

Re: [PATCH v1 0/36] dt-bindings: display: convert remaning panel bindings to DT Schema

2020-03-18 Thread Sam Ravnborg
Hi Rob > I've gone rather quickly thru the series. Other than what I commented > on, the rest look fine generally. There may be a couple with similar > comments. Thanks. Some of this was trivial stuff I should have fixed while converting - great with an extra pair of eyes. I will re-spin and t