Re: [PATCH 03/51] drm: add managed resources tied to drm_device

2020-03-03 Thread Dan Carpenter
Hi Daniel, I love your patch! Perhaps something to improve: url: https://github.com/0day-ci/linux/commits/Daniel-Vetter/drm_device-managed-resources-v4/20200303-071023 base: git://anongit.freedesktop.org/drm/drm-tip drm-tip If you fix the issue, kindly add following tag Reported-by

Re: [PATCH 2/2] [RFC] drm/virtgpu: modify uapi with stride/layer_stride fix

2020-03-03 Thread Gerd Hoffmann
On Fri, Feb 28, 2020 at 01:01:49PM -0800, Chia-I Wu wrote: > On Wed, Oct 2, 2019 at 5:18 PM Gurchetan Singh > wrote: > > > > On Wed, Oct 2, 2019 at 1:49 AM Gerd Hoffmann wrote: > > > > > > On Tue, Oct 01, 2019 at 06:49:35PM -0700, Gurchetan Singh wrote: > > > > This doesn't really break userspace

Re: [PATCH] drm/edid: Distribute switch variables for initialization

2020-03-03 Thread Daniel Vetter
On Tue, Mar 3, 2020 at 5:39 AM Kees Cook wrote: > > On Wed, Feb 19, 2020 at 10:22:29PM -0800, Kees Cook wrote: > > Variables declared in a switch statement before any case statements > > cannot be automatically initialized with compiler instrumentation (as > > they are not part of any execution fl

[PATCH v4 1/4] drm/sun4i: Add alpha property for sun8i UI layer

2020-03-03 Thread Roman Stratiienko
DE2.0 and DE3.0 UI layers supports plane-global alpha channel. Add alpha property to the DRM plane and connect it to the corresponding registers in mixer. Signed-off-by: Roman Stratiienko Reviewed-by: Jernej Skrabec --- v2: Initial commit by mistake v3: - Picked `reviewed-by` line V4: - Changed

[PATCH v4 2/4] drm/sun4i: Add alpha property for sun8i and sun50i VI layer

2020-03-03 Thread Roman Stratiienko
DE3.0 VI layers supports plane-global alpha channel. DE2.0 FCC block have GLOBAL_ALPHA register that can be used as alpha source for blender. Add alpha property to the DRM plane and connect it to the corresponding registers in the mixer. Do not add alpha property for V3s SOC that have DE2.0 and 2

Re: [PATCH 33/33] drm/panel-simple: Fix dotclock for LG ACX467AKM-7

2020-03-03 Thread Jonathan Marek
Another thing: did you verify that the panel still runs at 60hz (and not dropping frames to 30hz)? IIRC that was the behavior with lower clock. On 3/2/20 10:28 PM, Jonathan Marek wrote: On 3/2/20 10:13 PM, Brian Masney wrote: On Mon, Mar 02, 2020 at 03:48:22PM -0500, Jonathan Marek wrote: Hi

Re: [PATCH 28/33] drm/panel-simple: Fix dotclock for Sharp LQ150X1LG11

2020-03-03 Thread Peter Rosin
On 2020-03-02 21:34, Ville Syrjala wrote: > From: Ville Syrjälä > > The currently listed dotclock disagrees with the currently > listed vrefresh rate. Change the dotclock to match the vrefresh. > > Someone tell me which (if either) of the dotclock or vreresh is > correct? TL/DR; I do not care i

[PATCH] vgacon: Fix a UAF in vgacon_invert_region

2020-03-03 Thread Zhang Xiaoxu
When syzkaller tests, there is a UAF: BUG: KASan: use after free in vgacon_invert_region+0x9d/0x110 at addr 8810 Read of size 2 by task syz-executor.1/16489 page:ea004000 count:0 mapcount:-127 mapping: (null) index:0x0 page flags: 0xf() page

Re: [PATCH 24/33] drm/panel-simple: Fix dotclock for Ortustech COM37H3M

2020-03-03 Thread H. Nikolaus Schaller
Hi Ville, > Am 02.03.2020 um 21:34 schrieb Ville Syrjala : > > From: Ville Syrjälä > > The currently listed dotclock disagrees with the currently > listed vrefresh rate. Change the dotclock to match the vrefresh. > > Someone tell me which (if either) of the dotclock or vreresh is > correct? D

.[PATCH v4 0/4] drm/sun4i: Improve alpha processing

2020-03-03 Thread Roman Stratiienko
Patches 1-2 already reviewed and ready to be applied. Patch 4 is RFC and require more testing on real hardware. [PATCH v4 1/4] drm/sun4i: Add alpha property for sun8i UI layer [PATCH v4 2/4] drm/sun4i: Add alpha property for sun8i and sun50i VI [PATCH v4 3/4] drm/sun4i: Add support for premulti/c

Re: [RFC v2 6/8] MIPS: DTS: jz4780: account for Synopsys HDMI driver and LCD controller

2020-03-03 Thread Paul Cercueil
Hi Nikolaus, Le ven., févr. 28, 2020 at 19:19, H. Nikolaus Schaller a écrit : From: Paul Boddie A specialisation of the generic Synopsys HDMI driver is employed for JZ4780 HDMI support. This requires a new driver, plus device tree and configuration modifications. Signed-off-by: Paul Bod

Re: [PATCH 2/4] drm/bridge: dw-hdmi: Fix color space conversion detection

2020-03-03 Thread Jernej Škrabec
Hi Neil! Dne ponedeljek, 02. marec 2020 ob 10:26:09 CET je Neil Armstrong napisal(a): > Hi Jernej, > > On 29/02/2020 17:30, Jernej Skrabec wrote: > > Currently, is_color_space_conversion() compares not only color spaces > > but also formats. For example, function would return true if YCbCr 4:4:4

[PATCH v4 4/4] RFC: drm/sun4i: Process alpha channel of most bottom layer

2020-03-03 Thread Roman Stratiienko
Allwinner display engine blender consists of 3 pipelined blending units. PIPE0->\ BLD0-\ PIPE1->/ BLD1-\ PIPE2->--/ BLD2->OUT PIPE3->/ This pipeline produces incorrect composition if PIPE0 buffer has alpha. Correct solution is to add one more blending step and mi

[PATCH v11 0/5] arm/arm64: mediatek: Fix mt8173 mmsys device probing

2020-03-03 Thread Enric Balletbo i Serra
Dear all, Those patches are intended to solve an old standing issue on some Mediatek devices (mt8173, mt2701 and mt2712 are affected by this issue). Up to now both drivers, clock and drm are probed with the same device tree compatible. But only the first driver gets probed, which in effect breaks

Re: [PATCH 03/33] drm/panel-feixin-k101-im2ba02: Fix dotclock

2020-03-03 Thread Icenowy Zheng
于 2020年3月3日 GMT+08:00 上午4:34:22, Ville Syrjala 写到: >From: Ville Syrjälä > >The currently listed dotclock disagrees with the currently >listed vrefresh rate. Change the dotclock to match the vrefresh. > >Someone tell me which (if either) of the dotclock or vreresh is >correct? dotclock is corr

[PATCH 2/2] arm64: dts: rockchip: Describe PX30 GPU

2020-03-03 Thread Miquel Raynal
PX30 SoCs feature an ARM Bifrost GPU. Signed-off-by: Miquel Raynal --- Hello, this change is just adding basic GPU support, more work is needed on the devfreq/opp side to be sure everything works and is properly described. Hence, this proposal aims at describing the HW block only, not its habili

[PATCH v11 5/5] soc / drm: mediatek: Fix mediatek-drm device probing

2020-03-03 Thread Enric Balletbo i Serra
In the actual implementation the same compatible string "mediatek,-mmsys" is used to bind the clock drivers (drivers/soc/mediatek) as well as to the gpu driver (drivers/gpu/drm/mediatek/mtk_drm_drv.c). This ends with the problem that the only probed driver is the clock driver and there is no displa

[PATCH v11 2/5] dt-bindings: mediatek: Update mmsys binding to reflect it is a system controller

2020-03-03 Thread Enric Balletbo i Serra
The mmsys system controller is not only a pure clock controller, so update the binding documentation to reflect that apart from providing clocks, it also provides routing and miscellaneous control registers. Signed-off-by: Enric Balletbo i Serra Reviewed-by: Matthias Brugger Reviewed-by: CK Hu

Re: [PATCH 1/3] drm/omap: Prepare DSS for probing without legacy platform data

2020-03-03 Thread Tony Lindgren
* Tomi Valkeinen [200302 10:29]: > On 27/02/2020 19:44, Tony Lindgren wrote: > > > > > FWIW, I dropped omapdss-boot-init.c in my patch series updating DSI > > > > code to use common panel infrastructure, so this will conflict. > > > > > > Hey that's great :) Sounds like we can set up an immutabl

Re: [PATCH] drm/bochs: Remove vga write

2020-03-03 Thread Alistair Francis
On Fri, Feb 28, 2020 at 1:57 AM Gerd Hoffmann wrote: > > On Thu, Feb 27, 2020 at 01:04:54PM -0800, Alistair Francis wrote: > > The QEMU model for the Bochs display has no VGA memory section at offset > > 0x400 [1]. By writing to this register Linux can create a write to > > unassigned memory which

[PATCH v11 1/5] drm/mediatek: Omit warning on probe defers

2020-03-03 Thread Enric Balletbo i Serra
From: Matthias Brugger It can happen that the mmsys clock drivers aren't probed before the platform driver gets invoked. The platform driver used to print a warning that the driver failed to get the clocks. Omit this error on the defered probe path. Signed-off-by: Matthias Brugger Reviewed-by:

[PATCH V1 2/2] backlight: qcom-wled: Add support for WLED5 peripheral in PM8150L

2020-03-03 Thread Kiran Gunda
Add support for WLED5 peripheral that is present on PM8150L PMICs. PM8150L WLED supports the following. - Two modulators and each sink can use any of the modulator - Multiple CABC selection options - Multiple brightness width selection (12 bits to 15 bits) Signed-off-by: Kiran Gunda

[PATCH v11 3/5] soc: mediatek: Move mt8173 MMSYS to platform driver

2020-03-03 Thread Enric Balletbo i Serra
From: Matthias Brugger There is no strong reason for this to use CLK_OF_DECLARE instead of being a platform driver. Plus, this driver provides clocks but also a shared register space for the mediatek-drm and the mediatek-mdp driver. So move to drivers/soc/mediatek as a platform driver. Signed-of

[PATCH v4 3/4] drm/sun4i: Add support for premulti/coverage blending mode handling

2020-03-03 Thread Roman Stratiienko
Argument: All information below is author's understanding of underlying processes. This information was obtained from DE2.0-3.0 datasheet analysis and analysis of different DRM driver source code and commit messages. Input buffers could have 2 ways of holding pixel alpha channel value. 1. Coverag

[PATCH v2 2/4] drm/prime: add support for virtio exported objects

2020-03-03 Thread David Stevens
This change exposes dma-buf's get_uuid callback to PRIME drivers. Signed-off-by: David Stevens --- drivers/gpu/drm/drm_prime.c | 27 +++ include/drm/drm_drv.h | 15 +++ 2 files changed, 42 insertions(+) diff --git a/drivers/gpu/drm/drm_prime.c b/drivers

WARNING in idr_destroy

2020-03-03 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:63623fd4 Merge tag 'for-linus' of git://git.kernel.org/pub.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=10e978e3e0 kernel config: https://syzkaller.appspot.com/x/.config?x=5d2e033af114153f das

[PATCH v2 4/4] drm/virtio: Support virtgpu exported resources

2020-03-03 Thread David Stevens
Add support for UUID-based resource sharing mechanism to virtgpu. This implements the new virtgpu commands and hooks them up to dma-buf's get_uuid callback. Signed-off-by: David Stevens --- drivers/gpu/drm/virtio/virtgpu_drv.c | 3 ++ drivers/gpu/drm/virtio/virtgpu_drv.h | 19 driv

Re: [PATCH 2/4] drm/bridge: dw-hdmi: Fix color space conversion detection

2020-03-03 Thread Jernej Škrabec
Dne ponedeljek, 02. marec 2020 ob 10:26:09 CET je Neil Armstrong napisal(a): > Hi Jernej, > > On 29/02/2020 17:30, Jernej Skrabec wrote: > > Currently, is_color_space_conversion() compares not only color spaces > > but also formats. For example, function would return true if YCbCr 4:4:4 > > and YC

[PATCH V1 0/2] Add support for WLED5

2020-03-03 Thread Kiran Gunda
Currently, WLED driver supports only WLED4 peripherals that is present on pmi8998 and pm660L. This patch series converts the existing WLED4 bindings from .txt to .yaml format and adds the support for WLED5 peripheral that is present on PM8150L. PM8150L WLED supports the following. - Two modul

Re: [RFC v2 3/8] drm: ingenic-drm: add MODULE_DEVICE_TABLE

2020-03-03 Thread Paul Cercueil
Hi Nikolaus, Le ven., févr. 28, 2020 at 19:19, H. Nikolaus Schaller a écrit : so that the driver can load by matching the device tree if compiled as module. Signed-off-by: H. Nikolaus Schaller --- drivers/gpu/drm/ingenic/ingenic-drm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/d

[PATCH 2/2 v2] drm/vmwgfx: Remove a few unused functions

2020-03-03 Thread Sebastian Andrzej Siewior
I noticed that there is a prototype for vmw_fifo_ping_host_locked() but no function. Then I looked further and noticed more functions which are not used anymore or functions protoypes which remained after the function was removed. Remove unused function (prototypes). Signed-off-by: Sebastian Andr

Re: [PATCH 33/33] drm/panel-simple: Fix dotclock for LG ACX467AKM-7

2020-03-03 Thread Jonathan Marek
Hi, This is a command mode panel and the the msm/mdp5 driver uses the vrefresh field for the actual refresh rate, while the dotclock field is used for the DSI clocks. The dotclock needed to be a bit higher than necessary otherwise the panel would not work. If you want to get rid of the separ

Re: [RFC v2 6/8] MIPS: DTS: jz4780: account for Synopsys HDMI driver and LCD controller

2020-03-03 Thread H . Nikolaus Schaller
Hi Paul, > Am 02.03.2020 um 20:27 schrieb Paul Cercueil : > > Hi Nikolaus, > > > Le ven., févr. 28, 2020 at 19:19, H. Nikolaus Schaller a > écrit : >> From: Paul Boddie >> A specialisation of the generic Synopsys HDMI driver is employed for JZ4780 >> HDMI support. This requires a new driver,

Re: [RFC v2 3/8] drm: ingenic-drm: add MODULE_DEVICE_TABLE

2020-03-03 Thread H . Nikolaus Schaller
> Am 02.03.2020 um 20:21 schrieb Paul Cercueil : > > Hi Nikolaus, > > > Le ven., févr. 28, 2020 at 19:19, H. Nikolaus Schaller a > écrit : >> so that the driver can load by matching the device tree >> if compiled as module. >> Signed-off-by: H. Nikolaus Schaller >> --- >> drivers/gpu/drm/in

Re: [RFC v2 2/8] dt-bindings: display: add ingenic-jz4780-hdmi DT Schema

2020-03-03 Thread H . Nikolaus Schaller
> Am 02.03.2020 um 20:19 schrieb Paul Cercueil : > > Hi Nikolaus, > > > Le ven., févr. 28, 2020 at 19:19, H. Nikolaus Schaller a > écrit : >> From: Sam Ravnborg >> Add DT bindings for the hdmi driver for the Ingenic JZ4780 SoC. >> Based on .txt binding from Zubair Lutfullah Kakakhel >> Sign

Re: [RFC v2 2/8] dt-bindings: display: add ingenic-jz4780-hdmi DT Schema

2020-03-03 Thread Paul Cercueil
Hi Nikolaus, Le ven., févr. 28, 2020 at 19:19, H. Nikolaus Schaller a écrit : From: Sam Ravnborg Add DT bindings for the hdmi driver for the Ingenic JZ4780 SoC. Based on .txt binding from Zubair Lutfullah Kakakhel Signed-off-by: Sam Ravnborg Cc: Zubair Lutfullah Kakakhel Cc: H. Nikolaus

[PATCH 1/2] dt-bindings: gpu: mali-bifrost: Add Rockchip PX30 compatible

2020-03-03 Thread Miquel Raynal
Rockchip PX30 SoCs feature a Bifrost Mali GPU. Signed-off-by: Miquel Raynal --- Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml b/Documentation/devicetree/bindings/gpu/arm

Re: [virtio-dev] [PATCH v2 4/4] drm/virtio: Support virtgpu exported resources

2020-03-03 Thread David Stevens
> cmd_p->hdr.ctx_id = > > Before this completion of this hypercall, this resource can be > considered context local, while afterward it can be considered > "exported". Maybe I'm misunderstanding render contexts, but exporting a resource doesn't seem related to render contexts. The other resource m

Re: [PATCH 33/33] drm/panel-simple: Fix dotclock for LG ACX467AKM-7

2020-03-03 Thread Jonathan Marek
On 3/2/20 10:13 PM, Brian Masney wrote: On Mon, Mar 02, 2020 at 03:48:22PM -0500, Jonathan Marek wrote: Hi, This is a command mode panel and the the msm/mdp5 driver uses the vrefresh field for the actual refresh rate, while the dotclock field is used for the DSI clocks. The dotclock needed to

[PATCH v11 4/5] soc / drm: mediatek: Move routing control to mmsys device

2020-03-03 Thread Enric Balletbo i Serra
Provide a mtk_mmsys_ddp_connect() and mtk_mmsys_disconnect() functions to replace mtk_ddp_add_comp_to_path() and mtk_ddp_remove_comp_from_path(). Those functions will allow DRM driver and others to control the data path routing. Signed-off-by: Enric Balletbo i Serra Reviewed-by: Matthias Brugger

Re: Etnaviv issues on i.MX8M-Mini

2020-03-03 Thread Schrempf Frieder
On 26.02.20 17:05, Guido Günther wrote: > On Wed, Feb 26, 2020 at 04:54:35PM +0100, Lucas Stach wrote: >> On Mi, 2020-02-26 at 15:31 +, Schrempf Frieder wrote: >>> On 25.02.20 09:13, Frieder Schrempf wrote: Hi Lucas, On 24.02.20 12:08, Lucas Stach wrote: > On Mo, 2020-02-24 a

[PATCH v2 3/4] virtio-gpu: add VIRTIO_GPU_F_RESOURCE_UUID feature

2020-03-03 Thread David Stevens
This feature allows the guest to request a UUID from the host for a particular virtio_gpu resource. The UUID can then be shared with other virtio devices, to allow the other host devices to access the virtio_gpu's corresponding host resource. Signed-off-by: David Stevens --- include/uapi/linux/v

Re: [PATCH 1/4] drm/fourcc: Add modifier definitions for describing Amlogic Video Framebuffer Compression

2020-03-03 Thread Maxime Jourdan
On Fri, Feb 21, 2020 at 10:09 AM Neil Armstrong wrote: > > Amlogic uses a proprietary lossless image compression protocol and format > for their hardware video codec accelerators, either video decoders or > video input encoders. > > It considerably reduces memory bandwidth while writing and readin

Re: [PATCH 16/51] drm/inigenic: Use drmm_add_final_kfree

2020-03-03 Thread Paul Cercueil
Hi Daniel, Le jeu., févr. 27, 2020 at 19:14, Daniel Vetter a écrit : With this we can drop the final kfree from the release function. Signed-off-by: Daniel Vetter Cc: Paul Cercueil Reviewed-by: Paul Cercueil Cheers, -Paul --- drivers/gpu/drm/ingenic/ingenic-drm.c | 5 ++--- 1 file c

Re: [RFC v2 1/8] dt-bindings: display: add ingenic-jz4780-lcd DT Schema

2020-03-03 Thread Paul Cercueil
Hi Nikolaus, Le ven., févr. 28, 2020 at 19:19, H. Nikolaus Schaller a écrit : From: Sam Ravnborg Add DT bindings for the LCD controller on the jz4780 SoC Based on .txt binding from Zubair Lutfullah Kakakhel If you mean Documentation/devicetree/bindings/display/ingenic,lcd.txt then it was

[PATCH v2 1/4] dma-buf: add support for virtio exported objects

2020-03-03 Thread David Stevens
This change adds a new dma-buf operation that allows dma-bufs to be used by virtio drivers to share exported objects. The new operation allows the importing driver to query the exporting driver for the UUID which identifies the underlying exported object. Signed-off-by: David Stevens --- drivers

[PATCH] drm/amd/display: Remove pointless NULL checks in dmub_psr_copy_settings

2020-03-03 Thread Nathan Chancellor
Clang warns: drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dmub_psr.c:147:31: warning: address of 'pipe_ctx->plane_res' will always evaluate to 'true' [-Wpointer-bool-conversion] if (!pipe_ctx || !&pipe_ctx->plane_res || !&pipe_ctx->stream_res) ~ ~~^

Re: [PATCH 03/51] drm: add managed resources tied to drm_device

2020-03-03 Thread Daniel Vetter
On Tue, Mar 03, 2020 at 11:04:06AM +0300, Dan Carpenter wrote: > Hi Daniel, > > I love your patch! Perhaps something to improve: > > url: > https://github.com/0day-ci/linux/commits/Daniel-Vetter/drm_device-managed-resources-v4/20200303-071023 > base: git://anongit.fr

Re: [PATCH 33/33] drm/panel-simple: Fix dotclock for LG ACX467AKM-7

2020-03-03 Thread Brian Masney
On Mon, Mar 02, 2020 at 03:48:22PM -0500, Jonathan Marek wrote: > Hi, > > This is a command mode panel and the the msm/mdp5 driver uses the vrefresh > field for the actual refresh rate, while the dotclock field is used for the > DSI clocks. The dotclock needed to be a bit higher than necessary oth

Re: [PATCH 2/4] drm/bridge: dw-hdmi: Fix color space conversion detection

2020-03-03 Thread Jernej Škrabec
Dne ponedeljek, 02. marec 2020 ob 10:27:48 CET je Laurent Pinchart napisal(a): > Hi Jernej, > > Thank you for the patch. > > On Sat, Feb 29, 2020 at 05:30:41PM +0100, Jernej Skrabec wrote: > > Currently, is_color_space_conversion() compares not only color spaces > > but also formats. For example,

[PATCH V1 1/2] backlight: qcom-wled: convert the wled bindings to .yaml format

2020-03-03 Thread Kiran Gunda
Convert the qcom-wled bindings from .txt to .yaml format. Signed-off-by: Kiran Gunda --- .../bindings/leds/backlight/qcom-wled.txt | 154 - .../bindings/leds/backlight/qcom-wled.yaml | 184 + 2 files changed, 184 insertions(+), 154 deletions(-

Re: [PATCH 31/51] drm/ingenic: Drop explicit drm_mode_config_cleanup call

2020-03-03 Thread Paul Cercueil
Hi Daniel, Le jeu., févr. 27, 2020 at 19:15, Daniel Vetter a écrit : Allows us to drop the drm_driver.release callback. This is made possible by a preceeding patch which added a drmm_ cleanup action to drm_mode_config_init(), hence all we need to do to ensure that drm_mode_config_cleanup() i

Re: [RFC v2 1/8] dt-bindings: display: add ingenic-jz4780-lcd DT Schema

2020-03-03 Thread H. Nikolaus Schaller
Hi Paul, > Am 02.03.2020 um 20:10 schrieb Paul Cercueil : > > Hi Nikolaus, > > > Le ven., févr. 28, 2020 at 19:19, H. Nikolaus Schaller a > écrit : >> From: Sam Ravnborg >> Add DT bindings for the LCD controller on the jz4780 SoC >> Based on .txt binding from Zubair Lutfullah Kakakhel > > I

[PATCH v2 0/4] Support virtio cross-device resources

2020-03-03 Thread David Stevens
This patchset implements the current proposal for virtio cross-device resource sharing [1], with minor changes based on recent comments. It is expected that this will be used to import virtio resources into the virtio-video driver currently under discussion [2]. This patchset adds a new hook to dm

Re: [PATCH 4/4] drm/bridge: dw-hdmi: Add support for RGB limited range

2020-03-03 Thread Jernej Škrabec
Hi Laurent! Dne ponedeljek, 02. marec 2020 ob 10:53:54 CET je Laurent Pinchart napisal(a): > Hi Jernej, > > Thank you for the patch. > > On Sat, Feb 29, 2020 at 05:30:43PM +0100, Jernej Skrabec wrote: > > CEA 861 standard request that RGB quantization range is "limited" for > > s/request/reques

Re: [PATCH] drm/fourcc: Add bayer formats and modifiers

2020-03-03 Thread Pekka Paalanen
On Fri, 28 Feb 2020 17:31:35 +0100 Niklas Söderlund wrote: > Bayer formats are used with cameras and contain green, red and blue > components, with alternating lines of red and green, and blue and green > pixels in different orders. For each block of 2x2 pixels there is one > pixel with a red fil

Re: [PATCH 09/51] drm/cirrus: Use drmm_add_final_kfree

2020-03-03 Thread Daniel Vetter
On Tue, Mar 03, 2020 at 08:49:34AM +0100, Gerd Hoffmann wrote: > > @@ -575,9 +574,12 @@ static int cirrus_pci_probe(struct pci_dev *pdev, > > > > dev = &cirrus->dev; > > ret = drm_dev_init(dev, &cirrus_driver, &pdev->dev); > > - if (ret) > > - goto err_free_cirrus; > > + if

Re: [PATCH] drm/simple-kms: Fix documentation for drm_simple_encoder_init()

2020-03-03 Thread Daniel Vetter
On Tue, Mar 03, 2020 at 08:18:07AM +0100, Thomas Zimmermann wrote: > Brings the documentation of drm_simple_encoder_init() in sync with the > function's signature. > > Signed-off-by: Thomas Zimmermann > Fixes: 63170ac6f2e8 ("drm/simple-kms: Add drm_simple_encoder_{init,create}()") > Cc: Sam Ravnb

Re: [PATCH] drm/simple-kms: Fix documentation for drm_simple_encoder_init()

2020-03-03 Thread Daniel Vetter
On Tue, Mar 03, 2020 at 08:18:07AM +0100, Thomas Zimmermann wrote: > Brings the documentation of drm_simple_encoder_init() in sync with the > function's signature. > > Signed-off-by: Thomas Zimmermann > Fixes: 63170ac6f2e8 ("drm/simple-kms: Add drm_simple_encoder_{init,create}()") > Cc: Sam Ravnb

Re: [PATCH] drm/vblank: Fix documentation of VBLANK timestamp helper

2020-03-03 Thread Daniel Vetter
On Tue, Mar 03, 2020 at 08:31:35AM +0100, Thomas Zimmermann wrote: > Per-CRTC VBLANK information used to be addressed by device and pipe > index. A call drm_crtc_vblank_helper_get_vblank_timestamp_internal() > receives a pointer to the CRTC instead. Fix the documentation. > > Signed-off-by: Thomas

[PATCH] drm: add managed resources tied to drm_device

2020-03-03 Thread Daniel Vetter
We have lots of these. And the cleanup code tends to be of dubious quality. The biggest wrong pattern is that developers use devm_, which ties the release action to the underlying struct device, whereas all the userspace visible stuff attached to a drm_device can long outlive that one (e.g. after a

[PATCH] drm: Cleanups after drmm_add_final_kfree rollout

2020-03-03 Thread Daniel Vetter
A few things: - Update the example driver in the documentation. - We can drop the old kfree in drm_dev_release. - Add a WARN_ON check in drm_dev_register to make sure everyone calls drmm_add_final_kfree and there's no leaks. v2: Restore the full cleanup, I accidentally left some moved code behin

Re: [PATCH 3/5] drm/lima: save task info dump when task fail

2020-03-03 Thread Vasily Khoruzhick
On Fri, Feb 21, 2020 at 6:43 PM Qiang Yu wrote: > > Save all information to start a task which can be exported to user > for debug usage. Dump file data format is specified in lima_dump.h Looks like lima_sched.c is missing #include so kbuild bot complains > Signed-off-by: Qiang Yu > --- > dri

Re: [PATCH v4 0/9] Huge page-table entries for TTM

2020-03-03 Thread Michal Hocko
On Fri 28-02-20 14:08:04, Thomas Hellström (VMware) wrote: > Andrew, Michal > > I'm wondering what's the best way here to get the patches touching mm > reviewed and accepted? I am sorry, but I am busy with other stuff and unlikely to find time to review this series. -- Michal Hocko SUSE Labs ___

Re: [PATCH] drm/simple-kms: Fix documentation for drm_simple_encoder_init()

2020-03-03 Thread Thomas Zimmermann
Hi Am 03.03.20 um 09:33 schrieb Daniel Vetter: > On Tue, Mar 03, 2020 at 08:18:07AM +0100, Thomas Zimmermann wrote: >> Brings the documentation of drm_simple_encoder_init() in sync with the >> function's signature. >> >> Signed-off-by: Thomas Zimmermann >> Fixes: 63170ac6f2e8 ("drm/simple-kms: Ad

Re: [PATCH 1/3] drm/omap: Prepare DSS for probing without legacy platform data

2020-03-03 Thread Tomi Valkeinen
On 24/02/2020 21:12, Tony Lindgren wrote: In order to probe display subsystem (DSS) components with ti-sysc interconnect target module without legacy platform data and using devicetree, we need to update dss probing a bit. In the device tree, we will be defining the data also for the interconnec

Re: [PATCH 1/2] drm/virtio: factor out the sg_table from virtio_gpu_object

2020-03-03 Thread Gerd Hoffmann
Hi, > struct virtio_gpu_object { > struct drm_gem_shmem_object base; > uint32_t hw_res_handle; > - > - struct sg_table *pages; > uint32_t mapped; > - > bool dumb; > bool created; > }; > #define gem_to_virtio_gpu_obj(gobj) \ > container_of((gobj), struct

Re: [PATCH 2/2] drm/virtio: make sure virtio_gpu_cleanup_object(..) only happens on shmem objects

2020-03-03 Thread Gerd Hoffmann
> This function won't be useable for hostmem objects. > @@ -526,7 +526,8 @@ static void virtio_gpu_cmd_unref_cb(struct > virtio_gpu_device *vgdev, > bo = vbuf->resp_cb_data; > vbuf->resp_cb_data = NULL; > > - virtio_gpu_cleanup_object(bo); > + if (bo && virtio_gpu_is_shmem(b

Re: [PATCH 1/4] drm/fourcc: Add modifier definitions for describing Amlogic Video Framebuffer Compression

2020-03-03 Thread Pekka Paalanen
On Fri, 21 Feb 2020 10:08:42 +0100 Neil Armstrong wrote: > Amlogic uses a proprietary lossless image compression protocol and format > for their hardware video codec accelerators, either video decoders or > video input encoders. > > It considerably reduces memory bandwidth while writing and read

[PATCH v6] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges

2020-03-03 Thread Karol Herbst
Fixes state transitions of Nvidia Pascal GPUs from D3cold into higher device states. v2: convert to pci_dev quirk put a proper technical explanation of the issue as a in-code comment v3: disable it only for certain combinations of intel and nvidia hardware v4: simplify quirk by setting flag on

Re: [PATCH 2/4] drm/bridge: dw-hdmi: Fix color space conversion detection

2020-03-03 Thread Neil Armstrong
On 02/03/2020 17:42, Jernej Škrabec wrote: > Dne ponedeljek, 02. marec 2020 ob 10:26:09 CET je Neil Armstrong napisal(a): >> Hi Jernej, >> >> On 29/02/2020 17:30, Jernej Skrabec wrote: >>> Currently, is_color_space_conversion() compares not only color spaces >>> but also formats. For example, funct

[PATCH v5 9/9] drm/vmwgfx: Hook up the helpers to align buffer objects

2020-03-03 Thread VMware
From: Thomas Hellstrom Start using the helpers that align buffer object user-space addresses and buffer object vram addresses to huge page boundaries. This is to improve the chances of allowing huge page-table entries. Cc: Andrew Morton Cc: Michal Hocko Cc: "Matthew Wilcox (Oracle)" Cc: "Kiri

[PATCH v5 4/9] mm: Add vmf_insert_pfn_xxx_prot() for huge page-table entries

2020-03-03 Thread VMware
From: Thomas Hellstrom For graphics drivers needing to modify the page-protection, add huge page-table entries counterparts to vmf_insert_pfn_prot(). Cc: Andrew Morton Cc: Michal Hocko Cc: "Matthew Wilcox (Oracle)" Cc: "Kirill A. Shutemov" Cc: Ralph Campbell Cc: "Jérôme Glisse" Cc: "Christ

[PATCH v5 8/9] drm/vmwgfx: Introduce a huge page aligning TTM range manager

2020-03-03 Thread VMware
From: Thomas Hellstrom Using huge page-table entries requires that the physical address of the start of a buffer object is huge page size aligned. Make a special version of the TTM range manager that accomplishes this, but falls back to a smaller page size alignment (PUD->PMD, PMD->NORMAL) to avo

[PATCH v5 7/9] drm: Add a drm_get_unmapped_area() helper

2020-03-03 Thread VMware
From: Thomas Hellstrom Unaligned virtual addresses makes it unlikely that huge page-table entries can be used. So align virtual buffer object address huge page boundaries to the underlying physical address huge page boundaries taking buffer object sizes into account to determine when it might be

[PATCH v5 0/9] Huge page-table entries for TTM

2020-03-03 Thread VMware
In order to reduce CPU usage [1] and in theory TLB misses this patchset enables huge- and giant page-table entries for TTM and TTM-enabled graphics drivers. Patch 1 and 2 introduce a vma_is_special_huge() function to make the mm code take the same path as DAX when splitting huge- and giant page ta

[PATCH v5 1/9] fs: Constify vma argument to vma_is_dax

2020-03-03 Thread VMware
From: Thomas Hellstrom The function is used by upcoming vma_is_special_huge() with which we want to use a const vma argument. Since for vma_is_dax() the vma argument is only dereferenced for reading, constify it. Cc: Andrew Morton Cc: Michal Hocko Cc: "Matthew Wilcox (Oracle)" Cc: "Kirill A.

[PATCH v5 5/9] drm/ttm, drm/vmwgfx: Support huge TTM pagefaults

2020-03-03 Thread VMware
From: Thomas Hellstrom Support huge (PMD-size and PUD-size) page-table entries by providing a huge_fault() callback. We still support private mappings and write-notify by splitting the huge page-table entries on write-access. Note that for huge page-faults to occur, either the kernel needs to be

[PATCH v5 3/9] mm: Split huge pages on write-notify or COW

2020-03-03 Thread VMware
From: Thomas Hellstrom The functions wp_huge_pmd() and wp_huge_pud() currently relies on the huge_fault() callback to split huge page table entries if needed. However for module users that requires export of the split_huge_xxx() functionality which may be undesired. Instead split pre-existing hug

[PATCH v5 2/9] mm: Introduce vma_is_special_huge

2020-03-03 Thread VMware
From: Thomas Hellstrom For VM_PFNMAP and VM_MIXEDMAP vmas that want to support transhuge pages and -page table entries, introduce vma_is_special_huge() that takes the same codepaths as vma_is_dax(). The use of "special" follows the definition in memory.c, vm_normal_page(): "Special" mappings do

[PATCH v5 6/9] drm/vmwgfx: Support huge page faults

2020-03-03 Thread VMware
From: Thomas Hellstrom With vmwgfx dirty-tracking we need a specialized huge_fault callback. Implement and hook it up. Cc: Andrew Morton Cc: Michal Hocko Cc: "Matthew Wilcox (Oracle)" Cc: "Kirill A. Shutemov" Cc: Ralph Campbell Cc: "Jérôme Glisse" Cc: "Christian König" Cc: Dan Williams S

Re: [PATCH v4 0/9] Huge page-table entries for TTM

2020-03-03 Thread VMware
On 3/1/20 5:04 AM, Andrew Morton wrote: On Fri, 28 Feb 2020 14:08:04 +0100 Thomas Hellström (VMware) wrote: I'm wondering what's the best way here to get the patches touching mm reviewed and accepted? While drm people and VMware internal people have looked at them, I think the huge_fault() fa

Re: [PATCH resend 1/2] drm/i915: panel: Use intel_panel_compute_brightness() from pwm_setup_backlight()

2020-03-03 Thread Hans de Goede
Hi All, On 2/21/20 6:29 PM, Hans de Goede wrote: Use intel_panel_compute_brightness() from pwm_setup_backlight() so that we correctly take i915_modparams.invert_brightness and/or QUIRK_INVERT_BRIGHTNESS into account when setting + getting the initial brightness value. Signed-off-by: Hans de Goe

Re: [PATCH 1/4] drm/fourcc: Add modifier definitions for describing Amlogic Video Framebuffer Compression

2020-03-03 Thread Brian Starkey
Hi, On Tue, Mar 03, 2020 at 12:10:29PM +0200, Pekka Paalanen wrote: > On Fri, 21 Feb 2020 10:08:42 +0100 > Neil Armstrong wrote: > > > Amlogic uses a proprietary lossless image compression protocol and format > > for their hardware video codec accelerators, either video decoders or > > video inp

Re: [PATCH 1/4] drm/fourcc: Add modifier definitions for describing Amlogic Video Framebuffer Compression

2020-03-03 Thread Daniel Vetter
On Tue, Mar 3, 2020 at 11:53 AM Brian Starkey wrote: > > Hi, > > On Tue, Mar 03, 2020 at 12:10:29PM +0200, Pekka Paalanen wrote: > > On Fri, 21 Feb 2020 10:08:42 +0100 > > Neil Armstrong wrote: > > > > > Amlogic uses a proprietary lossless image compression protocol and format > > > for their har

Re: [PATCH v2] drm/etnaviv: rework perfmon query infrastructure

2020-03-03 Thread Lucas Stach
On Fr, 2020-02-28 at 11:37 +0100, Christian Gmeiner wrote: > Report the correct perfmon domains and signals depending > on the supported feature flags. > > Reported-by: Dan Carpenter > Fixes: 9e2c2e273012 ("drm/etnaviv: add infrastructure to query perf counter") > Cc: sta...@vger.kernel.org > Sig

Re: [PATCH 0/5] drm/etnaviv: Ignore MC bit when checking for runtime suspend

2020-03-03 Thread Lucas Stach
On Mo, 2020-03-02 at 20:13 +0100, Guido Günther wrote: > At least GC7000 fails to enter runtime suspend for long periods of time since > the MC becomes busy again even when the FE is idle. The rest of the series > makes detecting similar issues easier to debug in the future by checking > all known

[PATCHv6 0/6] Add AFBC support for Rockchip

2020-03-03 Thread Andrzej Pietrasiewicz
This series adds AFBC support for Rockchip. It is inspired by: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/refs/heads/factory-gru-9017.B-chromeos-4.4/drivers/gpu/drm/rockchip/rockchip_drm_vop.c This is the sixth iteration of the afbc series. Compared to v5 it simplifies the

[PATCHv6 2/6] drm/core: Add drm_afbc_framebuffer and a corresponding helper

2020-03-03 Thread Andrzej Pietrasiewicz
The new struct contains afbc-specific data. The new function can be used by drivers which support afbc to complete the preparation of struct drm_afbc_framebuffer. It must be called after allocating the said struct and calling drm_gem_fb_init_with_funcs(). Signed-off-by: Andrzej Pietrasiewicz ---

[PATCHv6 1/6] drm/core: Allow drivers allocate a subclass of struct drm_framebuffer

2020-03-03 Thread Andrzej Pietrasiewicz
Allow allocating a specialized version of struct drm_framebuffer by moving the actual fb allocation out of drm_gem_fb_create_with_funcs(); the respective functions names are adjusted to reflect that fact. Please note, though, that standard size checks are performed on buffers, so the drm_gem_fb_ini

[PATCHv6 3/6] drm/arm/malidp: Factor-in framebuffer creation

2020-03-03 Thread Andrzej Pietrasiewicz
Consolidating framebuffer creation into one function will make it easier to transition to generic afbc-aware helpers. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/arm/malidp_drv.c | 158 +-- 1 file changed, 67 insertions(+), 91 deletions(-) diff --git a/d

[PATCHv6 4/6] drm/arm/malidp: Allocate an afbc-specific drm_framebuffer

2020-03-03 Thread Andrzej Pietrasiewicz
Prepare for using generic afbc helpers. Use an existing helper which allows allocating a struct drm_framebuffer in the driver. afbc-specific checks should go after drm_gem_fb_init_with_funcs(). Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/arm/malidp_drv.c | 40 +

[PATCHv6 5/6] drm/arm/malidp: Switch to afbc helpers

2020-03-03 Thread Andrzej Pietrasiewicz
Use available afbc helpers. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/arm/malidp_drv.c | 44 +++- 1 file changed, 4 insertions(+), 40 deletions(-) diff --git a/drivers/gpu/drm/arm/malidp_drv.c b/drivers/gpu/drm/arm/malidp_drv.c index c076d0fd5b28..d50b

[PATCHv6 6/6] drm/rockchip: Add support for afbc

2020-03-03 Thread Andrzej Pietrasiewicz
This patch adds support for afbc handling. afbc is a compressed format which reduces the necessary memory bandwidth. Co-developed-by: Mark Yao Signed-off-by: Mark Yao Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/rockchip/rockchip_drm_drv.h | 1 + drivers/gpu/drm/rockchip/rockchip

Re: [PATCH 02/33] drm/panel-arm-versatile: Fix dotclock

2020-03-03 Thread Linus Walleij
On Mon, Mar 2, 2020 at 9:35 PM Ville Syrjala wrote: > From: Ville Syrjälä > > The currently listed dotclocks disagree with the currently > listed vrefresh rates. Change the dotclocks to match the vrefresh. > > Someone tell me which (if either) of the dotclock or vreresh is > correct? I actually

Re: [PATCH] drm/bridge: analogix_dp: Split bind() into probe() and real bind()

2020-03-03 Thread Andrzej Hajda
On 02.03.2020 15:26, Marek Szyprowski wrote: > Analogix_dp driver acquires all its resources in ->bind() callback, what > is a bit against the driver component based approach, where driver > initialization is split into probe(), where all resources are gathered, and > bind(), where objects are crea

Re: [PATCH 21/33] drm/panel-simple: Fix dotclock for Logic PD Type 28

2020-03-03 Thread Adam Ford
On Mon, Mar 2, 2020 at 2:36 PM Ville Syrjala wrote: > > From: Ville Syrjälä > > The currently listed dotclock disagrees with the currently > listed vrefresh rate. Change the dotclock to match the vrefresh. > > Someone tell me which (if either) of the dotclock or vreresh is > correct? > > Cc: Adam

Re: [PATCH 1/4] drm/fourcc: Add modifier definitions for describing Amlogic Video Framebuffer Compression

2020-03-03 Thread Pekka Paalanen
On Tue, 3 Mar 2020 12:37:16 +0100 Daniel Vetter wrote: > On Tue, Mar 3, 2020 at 11:53 AM Brian Starkey wrote: > > > > Hi, > > > > On Tue, Mar 03, 2020 at 12:10:29PM +0200, Pekka Paalanen wrote: > > > On Fri, 21 Feb 2020 10:08:42 +0100 > > > Neil Armstrong wrote: > > > > > > > Amlogic uses a

Re: [PATCH libdrm] modetest: call drmModeCrtcSetGamma() only if add_property_optional returns true

2020-03-03 Thread Ilia Mirkin
Pretty sure the current code is right. If the GAMMA_LUT property can't be set, it tries to set gamma the old-fashioned way. On Tue, Mar 3, 2020 at 8:12 AM Devarsh Thakkar wrote: > > Hi Rohit, > > This makes sense to me as gamma was implemented as optional property. > Reviewed-By: "Devarsh Thakkar

Re: [PATCH v3] drm/dp: Add function to parse EDID descriptors for adaptive sync limits

2020-03-03 Thread Ville Syrjälä
On Mon, Mar 02, 2020 at 04:08:59PM -0800, Manasi Navare wrote: > Adaptive Sync is a VESA feature so add a DRM core helper to parse > the EDID's detailed descritors to obtain the adaptive sync monitor range. > Store this info as part fo drm_display_info so it can be used > across all drivers. > This

  1   2   3   >