Re: [PATCH v4 04/11] drm/bridge: synopsys: dw-hdmi: add bus format negociation

2020-03-02 Thread Neil Armstrong
On 29/02/2020 08:42, Jernej Škrabec wrote: > Hi Neil! > > Dne četrtek, 06. februar 2020 ob 20:18:27 CET je Neil Armstrong napisal(a): >> Add the atomic_get_output_bus_fmts, atomic_get_input_bus_fmts to negociate >> the possible output and input formats for the current mode and monitor, >> and use

Re: [PATCH v4 04/11] drm/bridge: synopsys: dw-hdmi: add bus format negociation

2020-03-02 Thread Neil Armstrong
On 29/02/2020 11:09, Jonas Karlman wrote: > Hi Jernej, > > On 2020-02-29 08:42, Jernej Škrabec wrote: >> Hi Neil! >> >> Dne četrtek, 06. februar 2020 ob 20:18:27 CET je Neil Armstrong napisal(a): >>> Add the atomic_get_output_bus_fmts, atomic_get_input_bus_fmts to negociate >>> the possible output

Re: Reverting https://patchwork.freedesktop.org/patch/336850/

2020-03-02 Thread Thierry Reding
On Fri, Feb 28, 2020 at 05:35:51PM -0800, abhin...@codeaurora.org wrote: > Hi Thierry > > For DP drivers using MSM chipsets, we are using drm_dp_link_configure, > drm_dp_link_power_up and drm_dp_link_power_down functions. Here is the patch > for reference: > > https://patchwork.freedesktop.org/pa

Re: [PATCH 50/51] drm/udl: drop drm_driver.release hook

2020-03-02 Thread Thomas Zimmermann
Hi Daniel Am 28.02.20 um 18:43 schrieb Daniel Vetter: > On Fri, Feb 28, 2020 at 12:46 PM Thomas Zimmermann > wrote: >> >> Hi >> >> Am 28.02.20 um 09:40 schrieb Daniel Vetter: >>> On Fri, Feb 28, 2020 at 8:44 AM Thomas Zimmermann >>> wrote: Hi Daniel Am 27.02.20 um 19:15 sch

[PATCH] drm/stm: repair runtime power management

2020-03-02 Thread Marek Vasut
Add missing pm_runtime_get_sync() into ltdc_crtc_atomic_enable() to match pm_runtime_put_sync() in ltdc_crtc_atomic_disable(), otherwise the LTDC might suspend via runtime PM, disable clock, and then fail to resume later on. The test which triggers it is roughly -- run qt5 application which uses e

[PATCH 0/4] drm/bridge: dw-hdmi: Various updates

2020-03-02 Thread Jernej Skrabec
This series fixes multiple issues I found out. Patch 1 fixes reporting colorimetry in AVI frame. Patch 2 fixes color space conversion detection. At the moment it doesn't change anything, but it would needlessly enable CSC unit when conversion is not needed. Patch 3 sets scan mode to underscan which

[PATCH 2/4] drm/bridge: dw-hdmi: Fix color space conversion detection

2020-03-02 Thread Jernej Skrabec
Currently, is_color_space_conversion() compares not only color spaces but also formats. For example, function would return true if YCbCr 4:4:4 and YCbCr 4:2:2 would be set. Obviously in that case color spaces are the same. Fix that by comparing if both values represent RGB color space. Fixes: b21

[PATCH 1/4] drm/bridge: dw-hdmi: fix AVI frame colorimetry

2020-03-02 Thread Jernej Skrabec
CTA-861-F explicitly states that for RGB colorspace colorimetry should be set to "none". Fix that. Fixes: def23aa7e982 ("drm: bridge: dw-hdmi: Switch to V4L bus format and encodings") Signed-off-by: Jernej Skrabec --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 46 +-- 1 fil

Re: [Mesa-dev] [Intel-gfx] gitlab.fd.o financial situation and impact on services

2020-03-02 Thread Nicolas Dufresne
Le samedi 29 février 2020 à 19:14 +0100, Timur Kristóf a écrit : > On Fri, 2020-02-28 at 10:43 +, Daniel Stone wrote: > > On Fri, 28 Feb 2020 at 10:06, Erik Faye-Lund > > wrote: > > > On Fri, 2020-02-28 at 11:40 +0200, Lionel Landwerlin wrote: > > > > Yeah, changes on vulkan drivers or backend

[PATCH 3/4] drm/bridge: dw-hdmi: do not force "none" scan mode

2020-03-02 Thread Jernej Skrabec
From: Jonas Karlman Setting scan mode to "none" confuses some TVs like LG B8, which randomly change overscan procentage over time. Digital outputs like HDMI and DVI, handled by this controller, don't really need overscan, so we can always set scan mode to underscan. Actually, this is exactly what

Re: [PATCH v4 5/9] drm/ttm, drm/vmwgfx: Support huge TTM pagefaults

2020-03-02 Thread Hillf Danton
On Thu, 20 Feb 2020 13:27:15 +0100 Thomas Hellstrom wrote: > + > +static vm_fault_t ttm_bo_vm_huge_fault(struct vm_fault *vmf, > +enum page_entry_size pe_size) > +{ > + struct vm_area_struct *vma = vmf->vma; > + pgprot_t prot; > + struct ttm_buffer_

[PATCH 4/4] drm/bridge: dw-hdmi: Add support for RGB limited range

2020-03-02 Thread Jernej Skrabec
CEA 861 standard request that RGB quantization range is "limited" for CEA modes. Support that by adding CSC matrix which downscales values. This allows to proper color reproduction on TV and PC monitor at the same time. In future, override property can be added, like "Broadcast RGB" in i915 driver

Re: [Mesa-dev] [Intel-gfx] gitlab.fd.o financial situation and impact on services

2020-03-02 Thread Timur Kristóf
On Sat, 2020-02-29 at 14:46 -0500, Nicolas Dufresne wrote: > > > > 1. I think we should completely disable running the CI on MRs which > > are > > marked WIP. Speaking from personal experience, I usually make a lot > > of > > changes to my MRs before they are merged, so it is a waste of CI > > res

Re: [Mesa-dev] [Intel-gfx] gitlab.fd.o financial situation and impact on services

2020-03-02 Thread Timur Kristóf
On Fri, 2020-02-28 at 10:43 +, Daniel Stone wrote: > On Fri, 28 Feb 2020 at 10:06, Erik Faye-Lund > wrote: > > On Fri, 2020-02-28 at 11:40 +0200, Lionel Landwerlin wrote: > > > Yeah, changes on vulkan drivers or backend compilers should be > > > fairly > > > sandboxed. > > > > > > We also hav

Re: [Mesa-dev] [Intel-gfx] gitlab.fd.o financial situation and impact on services

2020-03-02 Thread Nicolas Dufresne
Le samedi 29 février 2020 à 15:54 -0600, Jason Ekstrand a écrit : > On Sat, Feb 29, 2020 at 3:47 PM Timur Kristóf wrote: > > On Sat, 2020-02-29 at 14:46 -0500, Nicolas Dufresne wrote: > > > > 1. I think we should completely disable running the CI on MRs which > > > > are > > > > marked WIP. Speaki

Re: [Intel-gfx] [Mesa-dev] gitlab.fd.o financial situation and impact on services

2020-03-02 Thread Nicolas Dufresne
Hi Jason, I personally think the suggestion are still a relatively good brainstorm data for those implicated. Of course, those not implicated in the CI scripting itself, I'd say just keep in mind that nothing is black and white and every changes end-up being time consuming. Le dimanche 01 mars 20

Re: [Mesa-dev] [Intel-gfx] gitlab.fd.o financial situation and impact on services

2020-03-02 Thread Nicolas Dufresne
Le dimanche 01 mars 2020 à 15:14 +0100, Michel Dänzer a écrit : > On 2020-02-29 8:46 p.m., Nicolas Dufresne wrote: > > Le samedi 29 février 2020 à 19:14 +0100, Timur Kristóf a écrit : > > > 1. I think we should completely disable running the CI on MRs which are > > > marked WIP. Speaking from perso

Re: [PATCH v4 04/11] drm/bridge: synopsys: dw-hdmi: add bus format negociation

2020-03-02 Thread Jernej Škrabec
Dne sobota, 29. februar 2020 ob 13:15:26 CET je Jonas Karlman napisal(a): > On 2020-02-29 12:07, Jernej Škrabec wrote: > > Dne sobota, 29. februar 2020 ob 11:09:14 CET je Jonas Karlman napisal(a): > >> Hi Jernej, > >> > >> On 2020-02-29 08:42, Jernej Škrabec wrote: > >>> Hi Neil! > >>> > >>> Dne

Re: [RFC v2 5/8] pinctrl: ingenic: add hdmi-ddc pin control group

2020-03-02 Thread Linus Walleij
On Fri, Feb 28, 2020 at 7:19 PM H. Nikolaus Schaller wrote: > From: Paul Boddie > > Signed-off-by: Paul Boddie > Signed-off-by: H. Nikolaus Schaller Patch applied to the pinctrl tree, it should be fine to merge the rest of the patches in another tree since there are no compile-time dependenci

[PATCH] drm: msm: a6x: Disable interrupts before recovery

2020-03-02 Thread Sharat Masetty
This patch disables interrupts in the GPU RBBM hang detect fault handler before going to recovery. Signed-off-by: Sharat Masetty --- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/adreno/a6

Re: [PATCH 50/51] drm/udl: drop drm_driver.release hook

2020-03-02 Thread Daniel Vetter
On Mon, Mar 2, 2020 at 9:14 AM Thomas Zimmermann wrote: > > Hi Daniel > > Am 28.02.20 um 18:43 schrieb Daniel Vetter: > > On Fri, Feb 28, 2020 at 12:46 PM Thomas Zimmermann > > wrote: > >> > >> Hi > >> > >> Am 28.02.20 um 09:40 schrieb Daniel Vetter: > >>> On Fri, Feb 28, 2020 at 8:44 AM Thomas

Re: [PATCH v4 01/11] drm/bridge: dw-hdmi: set mtmdsclock for deep color

2020-03-02 Thread Laurent Pinchart
Hi Neil and Jonas, Thank you for the patch. On Thu, Feb 06, 2020 at 08:18:24PM +0100, Neil Armstrong wrote: > From: Jonas Karlman > > Configure the correct mtmdsclock for deep colors to prepare support > for 10, 12 & 16bit output. > > Signed-off-by: Jonas Karlman > Signed-off-by: Neil Armstro

Re: [PATCH v4 02/11] drm/bridge: dw-hdmi: add max bpc connector property

2020-03-02 Thread Laurent Pinchart
Hi Neil and Jonas, (CC'ing Daniel for a framework question) Thank you for the patch. On Fri, Feb 21, 2020 at 09:50:18AM +0100, Neil Armstrong wrote: > On 17/02/2020 07:38, Jernej Škrabec wrote: > > Dne četrtek, 06. februar 2020 ob 20:18:25 CET je Neil Armstrong napisal(a): > >> From: Jonas Karlm

Re: [PATCH v4 01/11] drm/bridge: dw-hdmi: set mtmdsclock for deep color

2020-03-02 Thread Neil Armstrong
On 02/03/2020 10:05, Laurent Pinchart wrote: > Hi Neil and Jonas, > > Thank you for the patch. > > On Thu, Feb 06, 2020 at 08:18:24PM +0100, Neil Armstrong wrote: >> From: Jonas Karlman >> >> Configure the correct mtmdsclock for deep colors to prepare support >> for 10, 12 & 16bit output. >> >>

Re: [PATCH 03/51] drm: add managed resources tied to drm_device

2020-03-02 Thread Jani Nikula
On Sat, 29 Feb 2020, Daniel Vetter wrote: > On Sat, Feb 29, 2020 at 12:17 PM Sam Ravnborg wrote: >> The header-check infrastructure was dropped again - see: >> fcbb8461fd2376ba3782b5b8bd440c929b8e4980 > > Uh I'm disappoint :-/ To say the least. I thought it was a good *opt-in* feature for whoeve

Re: [PATCH 1/4] drm/bridge: dw-hdmi: fix AVI frame colorimetry

2020-03-02 Thread Laurent Pinchart
Hi Jernej, Thank you for the patch. On Sat, Feb 29, 2020 at 05:30:40PM +0100, Jernej Skrabec wrote: > CTA-861-F explicitly states that for RGB colorspace colorimetry should > be set to "none". Fix that. > > Fixes: def23aa7e982 ("drm: bridge: dw-hdmi: Switch to V4L bus format and > encodings") >

Re: [PATCH 2/4] drm/bridge: dw-hdmi: Fix color space conversion detection

2020-03-02 Thread Neil Armstrong
Hi Jernej, On 29/02/2020 17:30, Jernej Skrabec wrote: > Currently, is_color_space_conversion() compares not only color spaces > but also formats. For example, function would return true if YCbCr 4:4:4 > and YCbCr 4:2:2 would be set. Obviously in that case color spaces are > the same. > > Fix that

Re: [PATCH 3/4] drm/bridge: dw-hdmi: do not force "none" scan mode

2020-03-02 Thread Neil Armstrong
On 29/02/2020 17:30, Jernej Skrabec wrote: > From: Jonas Karlman > > Setting scan mode to "none" confuses some TVs like LG B8, which randomly > change overscan procentage over time. Digital outputs like HDMI and DVI, > handled by this controller, don't really need overscan, so we can always > set

Re: [PATCH 2/4] drm/bridge: dw-hdmi: Fix color space conversion detection

2020-03-02 Thread Laurent Pinchart
Hi Jernej, Thank you for the patch. On Sat, Feb 29, 2020 at 05:30:41PM +0100, Jernej Skrabec wrote: > Currently, is_color_space_conversion() compares not only color spaces > but also formats. For example, function would return true if YCbCr 4:4:4 > and YCbCr 4:2:2 would be set. Obviously in that

Re: [PATCH 03/51] drm: add managed resources tied to drm_device

2020-03-02 Thread Daniel Vetter
On Mon, Mar 02, 2020 at 11:22:34AM +0200, Jani Nikula wrote: > On Sat, 29 Feb 2020, Daniel Vetter wrote: > > On Sat, Feb 29, 2020 at 12:17 PM Sam Ravnborg wrote: > >> > > > + /** > >> > > > + * @managed: > >> > > > + * > >> > > > + * Managed resources linked to the lifetime of

Re: [PATCH 3/4] drm/bridge: dw-hdmi: do not force "none" scan mode

2020-03-02 Thread Laurent Pinchart
Hi Jernej and Jonas, Thank you for the patch. On Sat, Feb 29, 2020 at 05:30:42PM +0100, Jernej Skrabec wrote: > From: Jonas Karlman > > Setting scan mode to "none" confuses some TVs like LG B8, which randomly > change overscan procentage over time. Digital outputs like HDMI and DVI, s/procenta

Re: [PATCH 03/51] drm: add managed resources tied to drm_device

2020-03-02 Thread Daniel Vetter
On Mon, Mar 02, 2020 at 11:22:34AM +0200, Jani Nikula wrote: > On Sat, 29 Feb 2020, Daniel Vetter wrote: > > On Sat, Feb 29, 2020 at 12:17 PM Sam Ravnborg wrote: > >> The header-check infrastructure was dropped again - see: > >> fcbb8461fd2376ba3782b5b8bd440c929b8e4980 > > > > Uh I'm disappoint :

Re: [PATCH 4/4] drm/bridge: dw-hdmi: Add support for RGB limited range

2020-03-02 Thread Laurent Pinchart
Hi Jernej, Thank you for the patch. On Sat, Feb 29, 2020 at 05:30:43PM +0100, Jernej Skrabec wrote: > CEA 861 standard request that RGB quantization range is "limited" for s/request/requests/ > CEA modes. Support that by adding CSC matrix which downscales values. Interesting, that's related to

Re: [PATCH v4 03/11] drm/bridge: dw-hdmi: Plug atomic state hooks to the default implementation

2020-03-02 Thread Laurent Pinchart
Hi Neil, Thank you for the patch. On Thu, Feb 06, 2020 at 08:18:26PM +0100, Neil Armstrong wrote: > Signed-off-by: Neil Armstrong How about adding a commit message ? Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 3 +++ > 1 file changed, 3 insertions(+) >

Re: [PATCH v4 06/11] drm/meson: venc: make drm_display_mode const

2020-03-02 Thread Laurent Pinchart
Hi Neil, Thank you for the patch. On Thu, Feb 06, 2020 at 08:18:29PM +0100, Neil Armstrong wrote: > Before switching to bridge funcs, make sure drm_display_mode is passed > as const to the venc functions. > > Signed-off-by: Neil Armstrong Acked-by: Laurent Pinchart > --- > drivers/gpu/drm/m

Re: [PATCH v4 05/11] drm/bridge: synopsys: dw-hdmi: allow ycbcr420 modes for >= 0x200a

2020-03-02 Thread Laurent Pinchart
Hi Neil, Thank you for the patch. On Thu, Feb 06, 2020 at 08:18:28PM +0100, Neil Armstrong wrote: > Now the DW-HDMI Controller supports the HDMI2.0 modes, enable support > for these modes in the connector if the platform supports them. > We limit these modes to DW-HDMI IP version >= 0x200a which

Re: [PATCH v4 04/11] drm/bridge: synopsys: dw-hdmi: add bus format negociation

2020-03-02 Thread Laurent Pinchart
Hi Neil, Thank you for the patch. On Thu, Feb 06, 2020 at 08:18:27PM +0100, Neil Armstrong wrote: > Add the atomic_get_output_bus_fmts, atomic_get_input_bus_fmts to negociate > the possible output and input formats for the current mode and monitor, > and use the negotiated formats in a basic atom

Re: [PATCH 1/3] drm/omap: Prepare DSS for probing without legacy platform data

2020-03-02 Thread Tomi Valkeinen
On 27/02/2020 19:44, Tony Lindgren wrote: FWIW, I dropped omapdss-boot-init.c in my patch series updating DSI code to use common panel infrastructure, so this will conflict. Hey that's great :) Sounds like we can set up an immutable branch for just this $subject patch against v5.6-rc1 to resol

Re: [Intel-gfx] [PATCH 2/2] RFC drm/i915: Export per-client debug tracing

2020-03-02 Thread Daniel Vetter
On Sun, Mar 01, 2020 at 03:52:48PM +, Chris Wilson wrote: > Rather than put sensitive, and often voluminous, user details into a > global dmesg, report the error and debug messages directly back to the > user via the kernel tracing mechanism. > > Signed-off-by: Chris Wilson > Cc: Steven Roste

[PATCH 0/9] drm: drm_fb_helper cleanup.

2020-03-02 Thread Pankaj Bharadiya
This series addresses below drm_fb_helper tasks from Documentation/gpu/todo.rst. - The max connector argument for drm_fb_helper_init() isn't used anymore and can be removed. - The helper doesn't keep an array of connectors anymore so these can be removed: drm_fb_helper_single_add_all_connecto

[PATCH 3/9] drm/amdgpu: Remove drm_fb_helper_{add, remove}_one_connector calls

2020-03-02 Thread Pankaj Bharadiya
drm_fb_helper_{add,remove}_one_connector() are dummy functions now and serve no purpose. Hence remove their calls. This is the preparatory step for removing the drm_fb_helper_{add,remove}_one_connector() functions from drm_fb_helper.h Signed-off-by: Pankaj Bharadiya --- .../drm/amd/display/amdg

[PATCH 1/9] drm: Remove unused arg from drm_fb_helper_init

2020-03-02 Thread Pankaj Bharadiya
The max connector argument for drm_fb_helper_init() isn't used anymore hence remove it. All the drm_fb_helper_init() calls are modified with below sementic patch. @@ expression E1, E2, E3; @@ - drm_fb_helper_init(E1,E2, E3) + drm_fb_helper_init(E1,E2) Signed-off-by: Pankaj Bharadiya --- driv

[PATCH 8/9] drm/fb-helper: Remove drm_fb_helper add, add_all and remove connector functions

2020-03-02 Thread Pankaj Bharadiya
drm_fb_helper_single_add_all_connectors(), drm_fb_helper_add_one_connector() and drm_fb_helper_remove_one_connector() doesn't keep an array of connectors anymore and are just dummy. Now we have no callers to these functions hence remove them. Signed-off-by: Pankaj Bharadiya --- include/drm/drm_f

[PATCH 7/9] drm/bridge: remove unused variable warning in tc358764_detach

2020-03-02 Thread Pankaj Bharadiya
drm_device pointer is not getting used in tc358764_detach() anymore, hence remove it. This fixes below warning. drivers/gpu/drm/bridge/tc358764.c: In function ‘tc358764_detach’: drivers/gpu/drm/bridge/tc358764.c:386:21: warning: unused variable ‘drm’ [-Wunused-variable] struct drm_device *drm

[PATCH 2/9] drm/radeon: remove radeon_fb_{add, remove}_connector functions

2020-03-02 Thread Pankaj Bharadiya
drm_fb_helper_{add,remove}_one_connector() are dummy functions now and serve no purpose. Hence remove their calls. This is the preparatory step for removing the drm_fb_helper_{add,remove}_one_connector() functions from drm_fb_helper.h Signed-off-by: Pankaj Bharadiya --- drivers/gpu/drm/radeon/r

[PATCH 4/9] drm/i915/display: Remove drm_fb_helper_{add, remove}_one_connector calls

2020-03-02 Thread Pankaj Bharadiya
drm_fb_helper_{add,remove}_one_connector() are dummy functions now and serve no purpose. Hence remove their calls. This is the preparatory step for removing the drm_fb_helper_{add,remove}_one_connector() functions from drm_fb_helper.h Signed-off-by: Pankaj Bharadiya --- drivers/gpu/drm/i915/dis

[PATCH 9/9] drm/todo: Update drm_fb_helper tasks

2020-03-02 Thread Pankaj Bharadiya
Remove completed drm_fb_helper tasks from todo list. Signed-off-by: Pankaj Bharadiya --- Documentation/gpu/todo.rst | 15 --- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst index ccf5e8e34222..98d8782e1440 100644

[PATCH 5/9] drm: Remove drm_fb_helper add, add all and remove connector calls

2020-03-02 Thread Pankaj Bharadiya
drm_fb_helper_{add,remove}_one_connector() and drm_fb_helper_single_add_all_connectors() are dummy functions now and serve no purpose. Hence remove their calls. This is the preparatory step for removing the drm_fb_helper_{add,remove}_one_connector() functions from drm_fb_helper.h This removal is

[PATCH 6/9] drm/nouveau: Fix unused variable warning

2020-03-02 Thread Pankaj Bharadiya
nouveau_drm pointer is not getting used anymore in nv50_mstm_{register,destroy}_connector functions, hence remove it. This fixes below warning. drivers/gpu/drm/nouveau/dispnv50/disp.c: In function ‘nv50_mstm_destroy_connector’: drivers/gpu/drm/nouveau/dispnv50/disp.c:1263:22: warning: unused var

Re: [PATCH 7/9] drm/bridge: remove unused variable warning in tc358764_detach

2020-03-02 Thread Laurent Pinchart
Hi Pankaj, Thank you for the patch. You can squash this with the patch that introduced the issue in the same series. Otherwise we will be left with a compilation breakage in the history, which could be annoying when bisecting issues. On Mon, Mar 02, 2020 at 06:26:47PM +0530, Pankaj Bharadiya wro

Re: [PATCH 8/9] drm/fb-helper: Remove drm_fb_helper add, add_all and remove connector functions

2020-03-02 Thread Laurent Pinchart
Hi Pankaj, Thank you for the patch. On Mon, Mar 02, 2020 at 06:26:48PM +0530, Pankaj Bharadiya wrote: > drm_fb_helper_single_add_all_connectors(), drm_fb_helper_add_one_connector() > and drm_fb_helper_remove_one_connector() doesn't keep an array of s/doesn't/don't/ > connectors anymore and are

Re: [PATCH 9/9] drm/todo: Update drm_fb_helper tasks

2020-03-02 Thread Laurent Pinchart
Hi Pankaj, Thank you for the patch. On Mon, Mar 02, 2020 at 06:26:49PM +0530, Pankaj Bharadiya wrote: > Remove completed drm_fb_helper tasks from todo list. > > Signed-off-by: Pankaj Bharadiya > --- > Documentation/gpu/todo.rst | 15 --- > 1 file changed, 4 insertions(+), 11 deleti

Re: [PATCH 6/9] drm/nouveau: Fix unused variable warning

2020-03-02 Thread Laurent Pinchart
Hi Pankaj, Thank you for the patch. On Mon, Mar 02, 2020 at 06:26:46PM +0530, Pankaj Bharadiya wrote: > nouveau_drm pointer is not getting used anymore in > nv50_mstm_{register,destroy}_connector functions, hence remove it. > > This fixes below warning. > > drivers/gpu/drm/nouveau/dispnv50/disp

Re: [PATCH 1/9] drm: Remove unused arg from drm_fb_helper_init

2020-03-02 Thread Thomas Zimmermann
Hi Am 02.03.20 um 13:56 schrieb Pankaj Bharadiya: > The max connector argument for drm_fb_helper_init() isn't used anymore > hence remove it. > > All the drm_fb_helper_init() calls are modified with below sementic > patch. > > @@ > expression E1, E2, E3; > @@ > - drm_fb_helper_init(E1,E2, E3) >

Re: [PATCH v2 0/2] drm/amd/display: dc_link: cleaning up some code style issues

2020-03-02 Thread Rodrigo Siqueira
Applied! Thanks On 02/28, Melissa Wen wrote: > This patchset solves some coding style issues on dc_link for readability > and cleaning up warnings. Change suggested by checkpatch.pl. > > Changes in v2: > - Apply patches to the right amdgpu repository. > - Remove unnecessary {} added in the previ

Re: [PATCH] drm/amd/display: Fix pageflip event race condition for DCN.

2020-03-02 Thread Kazlauskas, Nicholas
On 2020-03-02 1:17 a.m., Mario Kleiner wrote: Commit '16f17eda8bad ("drm/amd/display: Send vblank and user events at vsartup for DCN")' introduces a new way of pageflip completion handling for DCN, and some trouble. The current implementation introduces a race condition, which can cause pageflip

Re: [PATCH 26/51] drm: Manage drm_mode_config_init with drmm_

2020-03-02 Thread Daniel Vetter
On Sat, Feb 29, 2020 at 12:11:28AM +0100, Daniel Vetter wrote: > On Fri, Feb 28, 2020 at 9:26 PM Sam Ravnborg wrote: > > > @@ -312,7 +305,9 @@ void drm_minor_release(struct drm_minor *minor) > > > * } > > > * drmm_add_final_kfree(drm, priv); > > > * > > > - * dr

Re: [PATCH v2] drm/dp: Add function to parse EDID descriptors for adaptive sync limits

2020-03-02 Thread Kazlauskas, Nicholas
On 2020-02-28 9:38 p.m., Manasi Navare wrote: On Fri, Feb 28, 2020 at 01:18:45PM -0800, Manasi Navare wrote: On Thu, Jan 09, 2020 at 03:08:52PM +0200, Ville Syrjälä wrote: On Tue, Jan 07, 2020 at 04:32:08PM -0800, Manasi Navare wrote: Adaptive Sync is a VESA feature so add a DRM core helper to

[Bug 206725] [REGRESSION] AMDGPU Severe artifact/tearing on 5700xt

2020-03-02 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=206725 Alex Deucher (alexdeuc...@gmail.com) changed: What|Removed |Added CC||alexdeuc...@gmail.c

[PATCH] drm/bridge: analogix_dp: Split bind() into probe() and real bind()

2020-03-02 Thread Marek Szyprowski
Analogix_dp driver acquires all its resources in ->bind() callback, what is a bit against the driver component based approach, where driver initialization is split into probe(), where all resources are gathered, and bind(), where objects are created and compound driver is initialized. Extract resou

[PATCH] drm/exynos: Fix cleanup of IOMMU related objects

2020-03-02 Thread Marek Szyprowski
Store the IOMMU mapping created by device core of each Exynos DRM sub-device and restore it when Exynos DRM driver is unbound. This fixes IOMMU initialization failure for the second time when deferred probe is triggered from the bind() callback of master's compound DRM driver. Signed-off-by: Marek

Re: [PATCH RFT v2 0/3] devfreq fixes for panfrost

2020-03-02 Thread Steven Price
On 22/02/2020 19:42, Martin Blumenstingl wrote: > Hi Steven, > > On Sun, Jan 12, 2020 at 1:16 AM Martin Blumenstingl > wrote: >> [...] >> >> >> Martin Blumenstingl (3): >> drm/panfrost: enable devfreq based the "operating-points-v2" property >> drm/panfrost: call dev_pm_opp_of_remove_table()

Re: [PATCH v2] drm: panfrost: Silence warnings during deferred probe

2020-03-02 Thread Steven Price
On 28/02/2020 09:40, Marek Szyprowski wrote: > Signed-off-by: Marek Szyprowski Reviewed-by: Steven Price ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 1/2] video: fbdev: sh_mobile_lcdcfb: fix sparse warnings about using incorrect types

2020-03-02 Thread Bartlomiej Zolnierkiewicz
On 1/17/20 3:08 PM, Geert Uytterhoeven wrote: > On Thu, Jan 16, 2020 at 3:51 PM Bartlomiej Zolnierkiewicz > wrote: >> Use ->screen_buffer instead of ->screen_base to fix sparse warnings. >> >> [ Please see commit 17a7b0b4d974 ("fb.h: Provide alternate screen_base >> pointer") for details. ] >>

Re: [PATCH 1/2] video: fbdev: w100fb: fix sparse warnings

2020-03-02 Thread Bartlomiej Zolnierkiewicz
On 1/17/20 7:57 PM, Sam Ravnborg wrote: > On Thu, Jan 16, 2020 at 03:53:20PM +0100, Bartlomiej Zolnierkiewicz wrote: >> * Add missing __iomem annotations where needed. >> * Make w100fb_probe() static. >> * Return NULL pointer (instead of using plain integer) in >> w100_get_xtal_tabl(). >> >> Si

Re: [PATCH 2/2] video: fbdev: sh_mobile_lcdcfb: add COMPILE_TEST support

2020-03-02 Thread Bartlomiej Zolnierkiewicz
On 1/17/20 3:08 PM, Geert Uytterhoeven wrote: > On Thu, Jan 16, 2020 at 3:52 PM Bartlomiej Zolnierkiewicz > wrote: >> Add COMPILE_TEST support to sh_mobile_lcdcfb driver for better compile >> testing coverage. >> >> Signed-off-by: Bartlomiej Zolnierkiewicz > > Reviewed-by: Geert Uytterhoeven

Re: [PATCH] video: fbdev: arcfb: add COMPILE_TEST support

2020-03-02 Thread Bartlomiej Zolnierkiewicz
On 1/17/20 7:57 PM, Sam Ravnborg wrote: > On Thu, Jan 16, 2020 at 03:49:07PM +0100, Bartlomiej Zolnierkiewicz wrote: >> Add COMPILE_TEST support to arcfb driver for better compile >> testing coverage. >> >> Signed-off-by: Bartlomiej Zolnierkiewicz > Acked-by: Sam Ravnborg Thanks, patch queued

Re: [PATCH -next] video: fbdev: pxa168fb: remove unnecessary platform_get_irq

2020-03-02 Thread Bartlomiej Zolnierkiewicz
On 1/17/20 4:22 AM, YueHaibing wrote: > commit 640ba2444fa9 ("drivers/video/pxa168fb.c: use devm_ functions") > left behind this, it can be removed. > > Signed-off-by: YueHaibing Patch queued for v5.7, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung El

Re: [PATCH 4/4] video: fbdev: remove set but not used variable 'bytpp'

2020-03-02 Thread Bartlomiej Zolnierkiewicz
On 1/19/20 1:17 PM, yu kuai wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/video/fbdev/aty/radeon_base.c: In function > ‘radeonfb_set_par’: > drivers/video/fbdev/aty/radeon_base.c:1660:32: warning: > variable ‘bytpp’ set but not used [-Wunused-but-set-variable] > > It is nev

Re: [PATCH 1/4] video: fbdev: remove set but not used variable 'hSyncPol'

2020-03-02 Thread Bartlomiej Zolnierkiewicz
On 1/19/20 1:17 PM, yu kuai wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/video/fbdev/aty/radeon_base.c: In function > ‘radeonfb_set_par’: > drivers/video/fbdev/aty/radeon_base.c:1653:6: warning: variable > ‘hSyncPol’ set but not used [-Wunused-but-set-variable] > > It is n

Re: [PATCH 1/2] video: fbdev: wm8505fb: fix sparse warnings about using incorrect types

2020-03-02 Thread Bartlomiej Zolnierkiewicz
On 1/17/20 7:58 PM, Sam Ravnborg wrote: > On Thu, Jan 16, 2020 at 03:56:50PM +0100, Bartlomiej Zolnierkiewicz wrote: >> Use ->screen_buffer instead of ->screen_base to fix sparse warnings. >> >> [ Please see commit 17a7b0b4d974 ("fb.h: Provide alternate screen_base >> pointer") for details. ] >

Re: [PATCH 2/4] video: fbdev: remove set but not used variable 'vSyncPol'

2020-03-02 Thread Bartlomiej Zolnierkiewicz
On 1/19/20 1:17 PM, yu kuai wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/video/fbdev/aty/radeon_base.c: In function > ‘radeonfb_set_par’: > drivers/video/fbdev/aty/radeon_base.c:1653:38: warning: variable > ‘vSyncPol’ set but not used [-Wunused-but-set-variable] > > It is

Re: [PATCH V2] video: remove set but not used variable 'mach64RefFreq'

2020-03-02 Thread Bartlomiej Zolnierkiewicz
On 1/20/20 7:33 AM, yu kuai wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/video/fbdev/aty/mach64_gx.c: In function ‘aty_var_to_pll_8398’: > drivers/video/fbdev/aty/mach64_gx.c:621:36: warning: variable > ‘mach64RefFreq’ set but not used [-Wunused-but-set-variable] > > It is

Re: [PATCH 2/2] video: fbdev: wm8505fb: add COMPILE_TEST support

2020-03-02 Thread Bartlomiej Zolnierkiewicz
On 1/17/20 7:59 PM, Sam Ravnborg wrote: > On Thu, Jan 16, 2020 at 03:58:08PM +0100, Bartlomiej Zolnierkiewicz wrote: >> Add COMPILE_TEST support to wm8505fb driver for better compile >> testing coverage. >> >> Signed-off-by: Bartlomiej Zolnierkiewicz > Acked-by: Sam Ravnborg Thanks, patch queu

Re: [PATCH 2/2] video: fbdev: w100fb: add COMPILE_TEST support

2020-03-02 Thread Bartlomiej Zolnierkiewicz
On 1/17/20 7:57 PM, Sam Ravnborg wrote: > On Thu, Jan 16, 2020 at 03:53:58PM +0100, Bartlomiej Zolnierkiewicz wrote: >> Add COMPILE_TEST support to w100fb driver for better compile >> testing coverage. >> >> Signed-off-by: Bartlomiej Zolnierkiewicz > Acked-by: Sam Ravnborg Thanks, patch queued

Re: [PATCH] matroxfb: add Matrox MGA-G200eW board support

2020-03-02 Thread Bartlomiej Zolnierkiewicz
On 1/25/20 8:55 PM, Rich Felker wrote: > Signed-off-by: Rich Felker Patch queued for v5.7, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics > -- > I've had this lying around a while and figure I should send it > upsteam; it's needed to suppor

Re: [PATCH] video: remove set but not used variable 'ulScaleRight'

2020-03-02 Thread Bartlomiej Zolnierkiewicz
On 1/19/20 1:19 PM, yu kuai wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/video/fbdev/kyro/STG4000OverlayDevice.c: In function > ‘SetOverlayViewPort’: > drivers/video/fbdev/kyro/STG4000OverlayDevice.c:334:19: warning: > variable ‘ulScaleRight’ set but not used [-Wunused-but-

Re: [PATCH] video: fbdev: radeon: Remove dead code

2020-03-02 Thread Bartlomiej Zolnierkiewicz
On 2/18/20 5:15 PM, Souptick Joarder wrote: > This is dead code since 3.15 and can be removed if not > going to be useful further. > > Signed-off-by: Souptick Joarder Patch queued for v5.7, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics >

Re: [PATCH 3/4] video: fbdev: remove set but not used variable 'vSyncPol'

2020-03-02 Thread Bartlomiej Zolnierkiewicz
On 1/19/20 1:17 PM, yu kuai wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/video/fbdev/aty/radeon_base.c: In function > ‘radeonfb_set_par’: > drivers/video/fbdev/aty/radeon_base.c:1653:48: warning: variable > ‘cSync’ set but not used [-Wunused-but-set-variable] > > It is nev

Re: [PATCH] video: Replace zero-length array with flexible-array member

2020-03-02 Thread Bartlomiej Zolnierkiewicz
On 2/21/20 5:00 PM, Gustavo A. R. Silva wrote: > The current codebase makes use of the zero-length array language > extension to the C90 standard, but the preferred mechanism to declare > variable-length types such as these ones is a flexible array member[1][2], > introduced in C99: > > struct f

Re: [PATCH v4 01/11] drm/bridge: dw-hdmi: set mtmdsclock for deep color

2020-03-02 Thread Neil Armstrong
Hi, On 02/03/2020 10:05, Laurent Pinchart wrote: > Hi Neil and Jonas, > > Thank you for the patch. > > On Thu, Feb 06, 2020 at 08:18:24PM +0100, Neil Armstrong wrote: >> From: Jonas Karlman >> >> Configure the correct mtmdsclock for deep colors to prepare support >> for 10, 12 & 16bit output. >

Re: [PATCH v4 02/11] drm/bridge: dw-hdmi: add max bpc connector property

2020-03-02 Thread Neil Armstrong
On 02/03/2020 10:18, Laurent Pinchart wrote: > Hi Neil and Jonas, > > (CC'ing Daniel for a framework question) > > Thank you for the patch. > > On Fri, Feb 21, 2020 at 09:50:18AM +0100, Neil Armstrong wrote: >> On 17/02/2020 07:38, Jernej Škrabec wrote: >>> Dne četrtek, 06. februar 2020 ob 20:18

Re: [PATCH v4 03/11] drm/bridge: dw-hdmi: Plug atomic state hooks to the default implementation

2020-03-02 Thread Neil Armstrong
On 02/03/2020 10:56, Laurent Pinchart wrote: > Hi Neil, > > Thank you for the patch. > > On Thu, Feb 06, 2020 at 08:18:26PM +0100, Neil Armstrong wrote: >> Signed-off-by: Neil Armstrong > > How about adding a commit message ? Done, thanks > > Reviewed-by: Laurent Pinchart > >> --- >> driv

Re: [PATCH v4 04/11] drm/bridge: synopsys: dw-hdmi: add bus format negociation

2020-03-02 Thread Neil Armstrong
On 02/03/2020 11:18, Laurent Pinchart wrote: > Hi Neil, > > Thank you for the patch. > > On Thu, Feb 06, 2020 at 08:18:27PM +0100, Neil Armstrong wrote: >> Add the atomic_get_output_bus_fmts, atomic_get_input_bus_fmts to negociate >> the possible output and input formats for the current mode and

Re: [PATCH v4 05/11] drm/bridge: synopsys: dw-hdmi: allow ycbcr420 modes for >= 0x200a

2020-03-02 Thread Neil Armstrong
On 02/03/2020 11:03, Laurent Pinchart wrote: > Hi Neil, > > Thank you for the patch. > > On Thu, Feb 06, 2020 at 08:18:28PM +0100, Neil Armstrong wrote: >> Now the DW-HDMI Controller supports the HDMI2.0 modes, enable support >> for these modes in the connector if the platform supports them. >> W

Re: [Intel-gfx] [PATCH 0/9] drm: drm_fb_helper cleanup.

2020-03-02 Thread Emil Velikov
On Mon, 2 Mar 2020 at 13:08, Pankaj Bharadiya wrote: > > This series addresses below drm_fb_helper tasks from > Documentation/gpu/todo.rst. > > - The max connector argument for drm_fb_helper_init() isn't used > anymore and can be removed. > > - The helper doesn't keep an array of connectors anym

Re: [PATCH v4 01/11] drm/bridge: dw-hdmi: set mtmdsclock for deep color

2020-03-02 Thread Laurent Pinchart
Hi Neil, On Mon, Mar 02, 2020 at 04:54:17PM +0100, Neil Armstrong wrote: > On 02/03/2020 10:05, Laurent Pinchart wrote: > > On Thu, Feb 06, 2020 at 08:18:24PM +0100, Neil Armstrong wrote: > >> From: Jonas Karlman > >> > >> Configure the correct mtmdsclock for deep colors to prepare support > >>

Re: [Intel-gfx] [PATCH 0/9] drm: drm_fb_helper cleanup.

2020-03-02 Thread Emil Velikov
On Mon, 2 Mar 2020 at 15:58, Emil Velikov wrote: > > On Mon, 2 Mar 2020 at 13:08, Pankaj Bharadiya > wrote: > > > > This series addresses below drm_fb_helper tasks from > > Documentation/gpu/todo.rst. > > > > - The max connector argument for drm_fb_helper_init() isn't used > > anymore and can b

Re: [PATCH 0/4] drm/meson: add support for Amlogic Video FBC

2020-03-02 Thread Kevin Hilman
Neil Armstrong writes: > Amlogic uses a proprietary lossless image compression protocol and format > for their hardware video codec accelerators, either video decoders or > video input encoders. > > It considerably reduces memory bandwidth while writing and reading > frames in memory. > > The und

Re: [PATCH 1/2] dt-bindings: gpu: mali-bifrost: Add Rockchip PX30 compatible

2020-03-02 Thread Heiko Stübner
Am Montag, 2. März 2020, 16:58:07 CET schrieb Miquel Raynal: > Rockchip PX30 SoCs feature a Bifrost Mali GPU. > > Signed-off-by: Miquel Raynal > --- > Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml | 1 + already in mainline ;-) https://git.kernel.org/pub/scm/linux/kernel/git/torva

Re: [PATCH 2/2] arm64: dts: rockchip: Describe PX30 GPU

2020-03-02 Thread Heiko Stübner
Hi Miquel, Am Montag, 2. März 2020, 16:58:08 CET schrieb Miquel Raynal: > PX30 SoCs feature an ARM Bifrost GPU. > > Signed-off-by: Miquel Raynal > --- > > Hello, this change is just adding basic GPU support, more work is > needed on the devfreq/opp side to be sure everything works and is > prop

[PATCH v2 0/7] drm: drm_fb_helper cleanup.

2020-03-02 Thread Pankaj Bharadiya
This series addresses below drm_fb_helper tasks from Documentation/gpu/todo.rst. - The max connector argument for drm_fb_helper_init() isn't used anymore and can be removed. - The helper doesn't keep an array of connectors anymore so these can be removed: drm_fb_helper_single_add_all_connecto

[PATCH v2 1/7] drm: Remove unused arg from drm_fb_helper_init

2020-03-02 Thread Pankaj Bharadiya
The max connector argument for drm_fb_helper_init() isn't used anymore hence remove it. All the drm_fb_helper_init() calls are modified with below sementic patch. @@ expression E1, E2, E3; @@ - drm_fb_helper_init(E1,E2, E3) + drm_fb_helper_init(E1,E2) Signed-off-by: Pankaj Bharadiya --- driv

[PATCH v2 2/7] drm/radeon: remove radeon_fb_{add, remove}_connector functions

2020-03-02 Thread Pankaj Bharadiya
drm_fb_helper_{add,remove}_one_connector() are dummy functions now and serve no purpose. Hence remove their calls. This is the preparatory step for removing the drm_fb_helper_{add,remove}_one_connector() functions from drm_fb_helper.h Signed-off-by: Pankaj Bharadiya --- drivers/gpu/drm/radeon/r

[PATCH v2 3/7] drm/amdgpu: Remove drm_fb_helper_{add, remove}_one_connector calls

2020-03-02 Thread Pankaj Bharadiya
drm_fb_helper_{add,remove}_one_connector() are dummy functions now and serve no purpose. Hence remove their calls. This is the preparatory step for removing the drm_fb_helper_{add,remove}_one_connector() functions from drm_fb_helper.h Signed-off-by: Pankaj Bharadiya --- .../drm/amd/display/amdg

[PATCH v2 4/7] drm/i915/display: Remove drm_fb_helper_{add, remove}_one_connector calls

2020-03-02 Thread Pankaj Bharadiya
drm_fb_helper_{add,remove}_one_connector() are dummy functions now and serve no purpose. Hence remove their calls. This is the preparatory step for removing the drm_fb_helper_{add,remove}_one_connector() functions from drm_fb_helper.h Signed-off-by: Pankaj Bharadiya --- drivers/gpu/drm/i915/dis

[PATCH v2 7/7] drm/todo: Update drm_fb_helper tasks

2020-03-02 Thread Pankaj Bharadiya
Remove completed drm_fb_helper tasks from todo list. Signed-off-by: Pankaj Bharadiya --- Documentation/gpu/todo.rst | 7 --- 1 file changed, 7 deletions(-) diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst index ccf5e8e34222..302180b76c4f 100644 --- a/Documentation/gpu/to

[PATCH v2 5/7] drm: Remove drm_fb_helper add, add all and remove connector calls

2020-03-02 Thread Pankaj Bharadiya
drm_fb_helper_{add,remove}_one_connector() and drm_fb_helper_single_add_all_connectors() are dummy functions now and serve no purpose. Hence remove their calls. This is the preparatory step for removing the drm_fb_helper_{add,remove}_one_connector() functions from drm_fb_helper.h This removal is

[PATCH v2 6/7] drm/fb-helper: Remove drm_fb_helper add, add_all and remove connector functions

2020-03-02 Thread Pankaj Bharadiya
drm_fb_helper_single_add_all_connectors(), drm_fb_helper_add_one_connector() and drm_fb_helper_remove_one_connector() don't keep an array of connectors anymore and are just dummy. Now we have no callers to these functions hence remove them. Signed-off-by: Pankaj Bharadiya --- include/drm/drm_fb_

Re: [PATCH 03/51] drm: add managed resources tied to drm_device

2020-03-02 Thread Sam Ravnborg
Hi Daniel / Jani. > On Mon, Mar 02, 2020 at 11:22:34AM +0200, Jani Nikula wrote: > > On Sat, 29 Feb 2020, Daniel Vetter wrote: > > > On Sat, Feb 29, 2020 at 12:17 PM Sam Ravnborg wrote: > > >> The header-check infrastructure was dropped again - see: > > >> fcbb8461fd2376ba3782b5b8bd440c929b8e498

  1   2   3   >