Re: [PATCH v2] drm/exynos: dsi: propagate error value and silence meaningless warning

2020-02-27 Thread Krzysztof Kozlowski
On Thu, Feb 27, 2020 at 08:06:37AM +0100, Marek Szyprowski wrote: > Properly propagate error value from devm_regulator_bulk_get() and don't > confuse user with meaningless warning about failure in getting regulators > in case of deferred probe. > > Signed-off-by: Marek Szyprowski > --- > v2: reph

Re: [PATCH v5 1/3] drm/shmem: add support for per object caching flags.

2020-02-27 Thread VMware
On 2/27/20 8:53 AM, Gerd Hoffmann wrote: Hi, + if (!shmem->map_cached) + prot = pgprot_writecombine(prot); shmem->vaddr = vmap(shmem->pages, obj->size >> PAGE_SHIFT, - VM_MAP, pgprot_writecombine(PAGE_KERNE

[RFC 6/8] MIPS: DTS: jz4780: account for Synopsys HDMI driver and LCD controller

2020-02-27 Thread H. Nikolaus Schaller
From: Paul Boddie A specialisation of the generic Synopsys HDMI driver is employed for JZ4780 HDMI support. This requires a new driver, plus device tree and configuration modifications. Signed-off-by: Paul Boddie Signed-off-by: H. Nikolaus Schaller --- arch/mips/boot/dts/ingenic/jz4780.dtsi |

Re: [PATCH 3/3] drm/vmwgfx: Correct typo in comment

2020-02-27 Thread coypu
On Wed, Feb 26, 2020 at 04:07:39PM +0100, Thomas Hellström (VMware) wrote: > On 2/23/20 9:40 PM, Maya Rashish wrote: > > Signed-off-by: Maya Rashish > > Signed-off-by: Thomas Klausner > > Co-authored-by: Thomas Klausner > > --- > > drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 2 +- > > 1 file change

[PATCH -next] drm/tidss: Drop pointless static qualifier in dispc_find_csc()

2020-02-27 Thread YueHaibing
There is no need to have the 'const struct dispc_csc_coef *coef' variable static since new value always be assigned before use it. Signed-off-by: YueHaibing --- drivers/gpu/drm/tidss/tidss_dispc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/tidss/tidss_dis

Re: [PATCH] drm/hisilicon: Add new clock/resolution configurations

2020-02-27 Thread Xinliang Liu
Thanks for the patch. Applied to drm-misc-next. On Tue, 31 Dec 2019 at 14:43, Tian Tao wrote: > Add the three new pll config for corresponding resolution 1440x900 and > 1600x900, 640x480 for hibmc > > Signed-off-by: Tian Tao > Signed-off-by: Gong junjie > --- > drivers/gpu/drm/hisilicon/hibmc

Re: [PATCH v3 4/4] drm/panfrost: Register to the Energy Model with devfreq device

2020-02-27 Thread Lukasz Luba
On 2/26/20 1:55 PM, Robin Murphy wrote: On 26/02/2020 10:06 am, Lukasz Luba wrote: [...] @@ -118,6 +120,7 @@ void panfrost_devfreq_fini(struct panfrost_device *pfdev)   { if (pfdev->devfreq.cooling) devfreq_cooling_unregister(pfdev->devfreq.cooling); +   dev_pm_o

[PATCH v6 2/3] drm: bridge: Add support for Cadence MHDP DPI/DP bridge

2020-02-27 Thread Yuti Amonkar
This patch adds new DRM driver for Cadence MHDP DPTX IP used on J721e SoC. MHDP DPTX IP is the component that complies with VESA DisplayPort (DP) and embedded Display Port (eDP) standards. It integrates uCPU running the embedded Firmware(FW) interfaced over APB interface. Basically, it takes a DPI

[PATCH v6 1/3] dt-bindings: drm/bridge: Document Cadence MHDP bridge bindings

2020-02-27 Thread Yuti Amonkar
Document the bindings used for the Cadence MHDP DPI/DP bridge in yaml format. Signed-off-by: Yuti Amonkar Signed-off-by: Swapnil Jakhade Reviewed-by: Rob Herring Reviewed-by: Laurent Pinchart --- .../bindings/display/bridge/cdns,mhdp.yaml| 127 ++ 1 file changed, 127 inser

[RFC 7/8] MIPS: DTS: CI20: add HDMI setup

2020-02-27 Thread H. Nikolaus Schaller
From: Paul Boddie We need to hook up * HDMI power regulator * HDMI connector * DDC pinmux * HDMI and LCD endpoint connections Signed-off-by: Paul Boddie Signed-off-by: H. Nikolaus Schaller --- arch/mips/boot/dts/ingenic/ci20.dts | 64 + 1 file changed, 64 insertion

Re: [PATCH v9 3/4] soc: mediatek: Move mt8173 MMSYS to platform driver

2020-02-27 Thread Randy Dunlap
On 2/26/20 2:54 AM, Enric Balletbo i Serra wrote: > diff --git a/drivers/soc/mediatek/Kconfig b/drivers/soc/mediatek/Kconfig > index 2114b563478c..dcd6481a14d0 100644 > --- a/drivers/soc/mediatek/Kconfig > +++ b/drivers/soc/mediatek/Kconfig > @@ -44,4 +44,11 @@ config MTK_SCPSYS > Say yes h

Re: linux-next: Tree for Feb 26 (gpu/drm/amd/amdgpu/)

2020-02-27 Thread Randy Dunlap
On 2/25/20 8:34 PM, Stephen Rothwell wrote: > Hi all, > > Changes since 20200225: > on i386: ld: drivers/gpu/drm/amd/amdgpu/amdgpu_object.o: in function `amdgpu_bo_release_notify': amdgpu_object.c:(.text+0xe07): undefined reference to `amdgpu_amdkfd_remove_fence_on_pt_pd_bos' Full randconfi

[RFC 2/8] dt-bindings: video: Add jz4780-hdmi binding

2020-02-27 Thread H. Nikolaus Schaller
From: Zubair Lutfullah Kakakhel Add DT bindings for the hdmi driver for the Ingenic JZ4780 SoC. Signed-off-by: Zubair Lutfullah Kakakhel --- .../bindings/display/ingenic-jz4780-hdmi.txt | 41 +++ 1 file changed, 41 insertions(+) create mode 100644 Documentation/devicetree/bi

Re: [PATCH 22/89] clk: bcm: rpi: Discover the firmware clocks

2020-02-27 Thread Maxime Ripard
Hi Florian, On Mon, Feb 24, 2020 at 10:15:32AM -0800, Florian Fainelli wrote: > On 2/24/20 1:06 AM, Maxime Ripard wrote: > > The firmware has an interface to discover the clocks it exposes. > > > > Let's use it to discover, register the clocks in the clocks framework and > > then expose them throu

Re: [PATCH 07/89] clk: bcm: rpi: Allow the driver to be probed by DT

2020-02-27 Thread Maxime Ripard
Hi Nicolas, On Tue, Feb 25, 2020 at 05:00:56PM +0100, Nicolas Saenz Julienne wrote: > On Mon, 2020-02-24 at 10:06 +0100, Maxime Ripard wrote: > > The current firmware clock driver for the RaspberryPi can only be probed by > > manually registering an associated platform_device. > > > > While this w

Re: Etnaviv issues on i.MX8M-Mini

2020-02-27 Thread Schrempf Frieder
On 25.02.20 09:13, Frieder Schrempf wrote: > Hi Lucas, > > On 24.02.20 12:08, Lucas Stach wrote: >> On Mo, 2020-02-24 at 10:53 +, Schrempf Frieder wrote: >>> Hi Lucas, >>> >>> On 24.02.20 11:37, Lucas Stach wrote: Hi Frieder, On Mo, 2020-02-24 at 10:28 +, Schrempf Frieder wr

[RFC 8/8] MIPS: CI20: defconfig: configure for DRM_DW_HDMI_JZ4780

2020-02-27 Thread H. Nikolaus Schaller
Signed-off-by: H. Nikolaus Schaller --- arch/mips/configs/ci20_defconfig | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/mips/configs/ci20_defconfig b/arch/mips/configs/ci20_defconfig index be41df2a81fb..3f733a555cb2 100644 --- a/arch/mips/configs/ci20_defconfig +++ b/arch/mips/config

Re: [PATCH 6/7] drm/sun4i: de2: Don't return de2_fmt_info struct

2020-02-27 Thread Maxime Ripard
On Tue, Feb 25, 2020 at 07:50:03PM +0100, Jernej Škrabec wrote: > Hi! > > Dne torek, 25. februar 2020 ob 09:52:18 CET je Chen-Yu Tsai napisal(a): > > On Tue, Feb 25, 2020 at 4:35 PM Maxime Ripard wrote: > > > Hi, > > > > > > On Mon, Feb 24, 2020 at 06:39:00PM +0100, Jernej Skrabec wrote: > > > > N

[PATCH v9 4/4] drm/mediatek: Fix mediatek-drm device probing

2020-02-27 Thread Enric Balletbo i Serra
In the actual implementation the same compatible string "mediatek,-mmsys" is used to bind the clock drivers (drivers/soc/mediatek) as well as to the gpu driver (drivers/gpu/drm/mediatek/mtk_drm_drv.c). This ends with the problem that the only probed driver is the clock driver and there is no displa

[RFC 4/8] drm: ingenic: add jz4780 Synopsys HDMI driver.

2020-02-27 Thread H. Nikolaus Schaller
From: Paul Boddie A specialisation of the generic Synopsys HDMI driver is employed for JZ4780 HDMI support. This requires a new driver, plus device tree and configuration modifications. Signed-off-by: Paul Boddie Signed-off-by: H. Nikolaus Schaller --- drivers/gpu/drm/ingenic/Kconfig

Re: [PATCH v3 4/4] drm/panfrost: Register to the Energy Model with devfreq device

2020-02-27 Thread Lukasz Luba
Hi Rob, On 2/25/20 8:57 PM, Rob Herring wrote: On Fri, Feb 21, 2020 at 1:48 PM Lukasz Luba wrote: Add device to the Energy Model framework. It will create a dedicated and unified data structures used i.e. in the thermal framework. The power model used in dev_pm_opp subsystem is simplified and

[PATCH v9 2/4] drm/mediatek: Omit warning on probe defers

2020-02-27 Thread Enric Balletbo i Serra
From: Matthias Brugger It can happen that the mmsys clock drivers aren't probed before the platform driver gets invoked. The platform driver used to print a warning that the driver failed to get the clocks. Omit this error on the defered probe path. Signed-off-by: Matthias Brugger Reviewed-by:

[PATCH RFC v4 1/6] dt-bindings: display: add Unisoc's drm master bindings

2020-02-27 Thread Kevin Tang
From: Kevin Tang The Unisoc DRM master device is a virtual device needed to list all DPU devices or other display interface nodes that comprise the graphics subsystem Cc: Orson Zhai Cc: Baolin Wang Cc: Chunyan Zhang Signed-off-by: Kevin Tang --- .../devicetree/bindings/display/sprd/drm.yaml

Re: [PATCH 10/89] clk: bcm: rpi: Remove global pllb_arm clock pointer

2020-02-27 Thread Nicolas Saenz Julienne
On Wed, 2020-02-26 at 15:26 +0100, Maxime Ripard wrote: > Hi Nicolas, > > On Tue, Feb 25, 2020 at 05:13:33PM +0100, Nicolas Saenz Julienne wrote: > > On Mon, 2020-02-24 at 10:06 +0100, Maxime Ripard wrote: > > > The pllb_arm clk_hw pointer in the raspberry_clk structure isn't used > > > anywhere b

[PATCH RFC v4 3/6] dt-bindings: display: add Unisoc's dpu bindings

2020-02-27 Thread Kevin Tang
From: Kevin Tang DPU (Display Processor Unit) is the Display Controller for the Unisoc SoCs which transfers the image data from a video memory buffer to an internal LCD interface. Cc: Orson Zhai Cc: Baolin Wang Cc: Chunyan Zhang Signed-off-by: Kevin Tang --- .../devicetree/bindings/display/

[PATCH RFC v4 0/6] Add Unisoc's drm kms module

2020-02-27 Thread Kevin Tang
ChangeList: v1: 1. only upstream modeset and atomic at first commit. 2. remove some unused code; 3. use alpha and blend_mode properties; 3. add yaml support; 4. remove auto-adaptive panel driver; 5. bugfix v2: 1. add sprd crtc and plane module for KMS, preparing for multi crtc&encoder 2. remove g

Re: [PATCH] drm/hisilicon: Enable the shadowfb for hibmc

2020-02-27 Thread Xinliang Liu
Thanks for the patch. Applied to drm-misc-next. On Sat, 11 Jan 2020 at 11:09, Tian Tao wrote: > set the prefer_shadow as 1,so we use the shadowfb to acceleration. > > Signed-off-by: Tian Tao > Signed-off-by: Gong junjie > --- > drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 2 +- > 1 file

Re: [PATCH] drm/hisilicon: fixed the wrong resolution configurations

2020-02-27 Thread Xinliang Liu
Thanks for the patch. Applied to drm-misc-next. On Fri, 3 Jan 2020 at 11:55, Tian Tao wrote: > The maximum resolution supported by hibmc is 1920 * 1200 instead of > 1920 * 1440, this patch fixed this problem > > Signed-off-by: Tian Tao > Signed-off-by: Gong junjie > --- > drivers/gpu/drm/hisi

[PATCH RFC v4 5/6] dt-bindings: display: add Unisoc's mipi dsi&dphy bindings

2020-02-27 Thread Kevin Tang
From: Kevin Tang Adds MIPI DSI Master and MIPI DSI-PHY (D-PHY) support for Unisoc's display subsystem. Cc: Orson Zhai Cc: Baolin Wang Cc: Chunyan Zhang Signed-off-by: Kevin Tang --- .../devicetree/bindings/display/sprd/dphy.yaml | 75 + .../devicetree/bindings/display/sp

[PATCH] drm/mediatek: Remove debug messages for function calls

2020-02-27 Thread Enric Balletbo i Serra
Equivalent information can be nowadays obtained using function tracer. Signed-off-by: Enric Balletbo i Serra --- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 5 - drivers/gpu/drm/mediatek/mtk_drm_drv.c | 2 -- 2 files changed, 7 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_crtc

Re: [PATCH] drm/bridge: analogix-anx6345: fix set of link bandwidth

2020-02-27 Thread Icenowy Zheng
于 2020年2月26日 GMT+08:00 下午6:58:43, Thomas Zimmermann 写到: >Hi Iceynow, > >Torsten asked me to merge your patch via drm-misc-next. I'd add the >additional cc and fixes tags that Torsten listed. Are you OK with that? I think this fixes a driver (and a board) available in 5.6. Maybe it should enter

[RFC 1/8] dt-bindings: video: Add jz4780-lcd binding

2020-02-27 Thread H. Nikolaus Schaller
From: Zubair Lutfullah Kakakhel Add DT bindings for the LCD controller on the jz4780 SoC Signed-off-by: Zubair Lutfullah Kakakhel --- .../bindings/display/ingenic-jz4780-lcd.txt | 39 +++ 1 file changed, 39 insertions(+) create mode 100644 Documentation/devicetree/bindings/

[PATCH RFC v4 2/6] drm/sprd: add Unisoc's drm kms master

2020-02-27 Thread Kevin Tang
From: Kevin Tang Adds drm support for the Unisoc's display subsystem. This is drm kms driver, this driver provides support for the application framework in Android, Yocto and more. Application framework can access Unisoc's display internel peripherals through libdrm or libkms, it's test ok by m

Re: [PATCH v9 3/4] soc: mediatek: Move mt8173 MMSYS to platform driver

2020-02-27 Thread Randy Dunlap
On 2/26/20 12:29 PM, Ezequiel Garcia wrote: > On Wed, 2020-02-26 at 07:40 -0800, Randy Dunlap wrote: >> On 2/26/20 2:54 AM, Enric Balletbo i Serra wrote: >>> diff --git a/drivers/soc/mediatek/Kconfig b/drivers/soc/mediatek/Kconfig >>> index 2114b563478c..dcd6481a14d0 100644 >>> --- a/drivers/soc/me

Re: [PATCH 10/89] clk: bcm: rpi: Remove global pllb_arm clock pointer

2020-02-27 Thread Maxime Ripard
Hi Nicolas, On Tue, Feb 25, 2020 at 05:13:33PM +0100, Nicolas Saenz Julienne wrote: > On Mon, 2020-02-24 at 10:06 +0100, Maxime Ripard wrote: > > The pllb_arm clk_hw pointer in the raspberry_clk structure isn't used > > anywhere but in the raspberrypi_register_pllb_arm. > > > > Let's remove it, th

[PATCH RFC v4 4/6] drm/sprd: add Unisoc's drm display controller driver

2020-02-27 Thread Kevin Tang
Adds DPU(Display Processor Unit) support for the Unisoc's display subsystem. It's support multi planes, scaler, rotation, PQ(Picture Quality) and more. Cc: Orson Zhai Cc: Baolin Wang Cc: Chunyan Zhang Signed-off-by: Kevin Tang --- drivers/gpu/drm/sprd/Makefile | 5 +- drivers/gpu/drm/

Re: [PATCH v2] drm/hisilicon: Fixed pcie resource conflict between drm and firmware

2020-02-27 Thread Xinliang Liu
Thanks for the patch. Applied to drm-misc-next. On Mon, 24 Feb 2020 at 14:02, Tian Tao wrote: > use the drm_fb_helper_remove_conflicting_pci_framebuffer to remove > the framebuffer initialized by fireware/bootloader to avoid resource > conflict. > > Signed-off-by: Tian Tao > > --- > v2: use

[v1 2/2] msm: disp: dpu1: fix reservations cleanup during modeset

2020-02-27 Thread Krishna Manikandan
Missing return statement will cause the reservations to get released prematurely, thus messing up the allocation for any next successive datapath reservation. Signed-off-by: Krishna Manikandan --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/d

[PATCH v9 1/4] drm/mediatek: Use regmap for register access

2020-02-27 Thread Enric Balletbo i Serra
From: Matthias Brugger The mmsys memory space is shared between the drm and the clk driver. Use regmap to access it. Signed-off-by: Matthias Brugger Reviewed-by: Philipp Zabel Reviewed-by: CK Hu Signed-off-by: Enric Balletbo i Serra --- Changes in v9: None Changes in v8: - Select REGMAP and

[PATCH v6 0/3] drm: Add support for Cadence MHDP DPI/DP bridge and J721E wrapper.

2020-02-27 Thread Yuti Amonkar
This patch series adds new DRM driver for Cadence Display Port. The Cadence Display Port is also referred as MHDP (Mobile High Definition Link, High-Definition Multimedia Interface Display Port) Cadence Display Port complies with VESA DisplayPort (DP) and embedded Display Port (eDP) standards. This

Re: [PATCH v2] drm/hisilicon: Add the mode_valid function

2020-02-27 Thread Xinliang Liu
Thanks for the patch. Applied to drm-misc-next. On Wed, 8 Jan 2020 at 17:41, Tian Tao wrote: > add mode_valid function, we can make sure the resolution is valid. > > Signed-off-by: Tian Tao > Signed-off-by: Gong junjie > Reviewed-by: Thomas Zimmermann > > --- > v2: declare hibmc_crtc_mode

[RFC 0/8] MIPS: CI20: add HDMI out support

2020-02-27 Thread H. Nikolaus Schaller
This patch series adds HDMI output to the jz4780/CI20 board. It is based on taking the old 3.18 vendor kernel and trying to achieve the same with modern DTS setup and new/modified drivers. Unfortunately, in this first RFC, only EDID and creation of /dev/fb0 are working. Also, HDMI hot plugging is

[PATCH v9 3/4] soc: mediatek: Move mt8173 MMSYS to platform driver

2020-02-27 Thread Enric Balletbo i Serra
From: Matthias Brugger There is no strong reason for this to use CLK_OF_DECLARE instead of being a platform driver. Plus, this driver provides clocks but also a shared register space for the mediatek-drm and the mediatek-mdp driver. So move to drivers/soc/mediatek as a platform driver. Signed-of

[PATCH v6 3/3] drm: bridge: cdns-mhdp: add j721e wrapper

2020-02-27 Thread Yuti Amonkar
Add j721e wrapper for mhdp, which sets up the clock and data muxes. Signed-off-by: Yuti Amonkar Signed-off-by: Jyri Sarha Reviewed-by: Tomi Valkeinen --- drivers/gpu/drm/bridge/Kconfig | 12 drivers/gpu/drm/bridge/Makefile | 4 ++ drivers/gpu/drm/bridge/cdns-mhdp-core.

Re: [PATCH v9 3/4] soc: mediatek: Move mt8173 MMSYS to platform driver

2020-02-27 Thread Ezequiel Garcia
On Wed, 2020-02-26 at 07:40 -0800, Randy Dunlap wrote: > On 2/26/20 2:54 AM, Enric Balletbo i Serra wrote: > > diff --git a/drivers/soc/mediatek/Kconfig b/drivers/soc/mediatek/Kconfig > > index 2114b563478c..dcd6481a14d0 100644 > > --- a/drivers/soc/mediatek/Kconfig > > +++ b/drivers/soc/mediatek/K

[PATCH v9 0/4] arm64: mediatek: Fix mt8173 mmsys device probing

2020-02-27 Thread Enric Balletbo i Serra
Dear all, Those patches are intended to solve an old standing issue on some Mediatek devices (mt8173, mt2701 and mt2712). Up to now both drivers, clock and drm are probed with the same device tree compatible. But only the first driver gets probed, which in effect breaks graphics on those devices.

[v1 1/2] msm: disp: dpu1: add DP support for sc7180 target

2020-02-27 Thread Krishna Manikandan
Add the required changes to support Display Port for sc7180 target. Signed-off-by: Krishna Manikandan This patch has dependency on DP driver changes in https://patchwork.kernel.org/patch/11269169/ --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c| 6 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_

[RFC 3/8] drm: ingenic-drm: add MODULE_DEVICE_TABLE

2020-02-27 Thread H. Nikolaus Schaller
so that the driver can load by matching the device tree if compiled as module. Signed-off-by: H. Nikolaus Schaller --- drivers/gpu/drm/ingenic/ingenic-drm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/ingenic/ingenic-drm.c b/drivers/gpu/drm/ingenic/ingenic-drm.c index

[RFC 5/8] pinctrl: ingenic: add hdmi-ddc pin control group

2020-02-27 Thread H. Nikolaus Schaller
From: Paul Boddie Signed-off-by: Paul Boddie Signed-off-by: H. Nikolaus Schaller --- drivers/pinctrl/pinctrl-ingenic.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/pinctrl/pinctrl-ingenic.c b/drivers/pinctrl/pinctrl-ingenic.c index 96f04d121ebd..1599a003c31f 100644 --- a

Re: [PATCH] RFC: dma-buf: Add an API for importing and exporting sync files

2020-02-27 Thread Christian König
Am 26.02.20 um 17:46 schrieb Bas Nieuwenhuizen: On Wed, Feb 26, 2020 at 4:29 PM Jason Ekstrand wrote: On Wed, Feb 26, 2020 at 4:05 AM Daniel Vetter wrote: On Wed, Feb 26, 2020 at 10:16:05AM +0100, Christian König wrote: [SNIP] Just imagine that you access some DMA-buf with a shader and that

RE: [Intel-gfx][PATCH 01/10] drm/i915: Add i915 device based MISSING_CASE macro

2020-02-27 Thread Jani Nikula
On Thu, 27 Feb 2020, "Laxminarayan Bharadiya, Pankaj" wrote: > Hi Chris, > >> -Original Message- >> From: Chris Wilson >> Sent: 25 February 2020 19:32 >> To: David Airlie ; Joonas Lahtinen >> ; Laxminarayan Bharadiya, Pankaj >> ; Vivi, Rodrigo >> ; dan...@ffwll.ch; dri-devel@lists.free

Re: [PATCH] drm/exynos: dsi: fix workaround for the legacy clock name

2020-02-27 Thread Andrzej Hajda
On 20.02.2020 13:30, Marek Szyprowski wrote: > Writing to the built-in strings arrays doesn't work if driver is loaded > as kernel module. This is also considered as a bad pattern. Fix this by > adding a call to clk_get() with legacy clock name. This fixes following > kernel oops if driver is loade

Re: [PATCH] drm/exynos: hdmi: don't leak enable HDMI_EN regulator if probe fails

2020-02-27 Thread Andrzej Hajda
On 20.02.2020 13:57, Marek Szyprowski wrote: > Move enabling and disabling HDMI_EN optional regulator to probe() function > to keep track on the regulator status. This fixes following warning if > probe() fails (for example when I2C DDC adapter cannot be yet gathered > due to the missing driver). T

Re: [PATCH v9 1/4] drm/mediatek: Use regmap for register access

2020-02-27 Thread CK Hu
Hi, Enric: On Thu, 2020-02-27 at 09:45 +0100, Enric Balletbo i Serra wrote: > Hi CK, > > On 27/2/20 2:10, CK Hu wrote: > > Hi, Enric: > > > > On Wed, 2020-02-26 at 11:54 +0100, Enric Balletbo i Serra wrote: > >> From: Matthias Brugger > >> > >> The mmsys memory space is shared between the drm a

Re: [RFC 2/9] mfd: Add driver for Multifunction USB Device

2020-02-27 Thread Lee Jones
I'd really like someone from USB to have a look through this too. I'll do a quick first pass and provide some general comments though. On Sun, 16 Feb 2020, Noralf Trønnes wrote: > A Multifunction USB Device is a device that supports functions like gpio > and display or any other function that can

Re: [PATCH 5/5] drm/amdgpu: implement amdgpu_gem_prime_move_notify v2

2020-02-27 Thread Christian König
Am 26.02.20 um 17:32 schrieb Daniel Vetter: On Tue, Feb 25, 2020 at 6:16 PM Daniel Vetter wrote: On Mon, Feb 24, 2020 at 07:46:59PM +0100, Christian König wrote: Am 23.02.20 um 17:54 schrieb Thomas Hellström (VMware): On 2/23/20 4:45 PM, Christian König wrote: Am 21.02.20 um 18:12 schrieb Da

Re: [PATCH 5/5] drm/amdgpu: implement amdgpu_gem_prime_move_notify v2

2020-02-27 Thread Daniel Vetter
On Thu, Feb 27, 2020 at 10:20 AM Christian König wrote: > Am 26.02.20 um 17:32 schrieb Daniel Vetter: > > On Tue, Feb 25, 2020 at 6:16 PM Daniel Vetter wrote: > >> On Mon, Feb 24, 2020 at 07:46:59PM +0100, Christian König wrote: > >>> Am 23.02.20 um 17:54 schrieb Thomas Hellström (VMware): >

Re: [PATCH][next][V2] drm/tidss: fix spelling mistakes "bufer" and "requsted"

2020-02-27 Thread Jyri Sarha
On 24/02/2020 19:42, Colin King wrote: > From: Colin Ian King > > There are two spelling mistakes in warning and debug messages. > Fix them. > > Signed-off-by: Colin Ian King Reviewed-by: Jyri Sarha Tested-by: Jyri Sarha I'll merge this to drm-misc-next tomorrow. Thank you for the patch, J

Re: [PATCH] drm/tidss: Use drm_for_each_bridge_in_chain()

2020-02-27 Thread Jyri Sarha
On 22/02/2020 13:07, Laurent Pinchart wrote: > Replace the manual encoder->bridge_chain walk with the > drm_for_each_bridge_in_chain() macro. Drivers should not touch the > bridge_chain field directly. > > Signed-off-by: Laurent Pinchart Reviewed-by: Jyri Sarha Tested-by: Jyri Sarha I'll merg

Re: [PATCH -next] drm/tidss: Drop pointless static qualifier in dispc_find_csc()

2020-02-27 Thread Jyri Sarha
On 27/02/2020 08:50, YueHaibing wrote: > There is no need to have the 'const struct dispc_csc_coef *coef' > variable static since new value always be assigned before use it. > > Signed-off-by: YueHaibing Reviewed-by: Jyri Sarha Tested-by: Jyri Sarha I'll merge this to drm-misc-next tomorrow.

[PATCH] drm/tidss: Add prepare_fb to the plane helper funcs

2020-02-27 Thread Jyri Sarha
From: Gowtham Tammana drm_gem_fb_prepare_fb() extracts fence and attaches to plane state. The fence info is needed if implicit fencing is used. Add this as prepare_fb function pointer to plane helper funcs. Signed-off-by: Gowtham Tammana Signed-off-by: Jyri Sarha --- drivers/gpu/drm/tidss/tid

Re: [PATCH] drm/tidss: Add prepare_fb to the plane helper funcs

2020-02-27 Thread Daniel Vetter
On Thu, Feb 27, 2020 at 12:13:07PM +0200, Jyri Sarha wrote: > From: Gowtham Tammana > > drm_gem_fb_prepare_fb() extracts fence and attaches to plane state. > The fence info is needed if implicit fencing is used. Add this as > prepare_fb function pointer to plane helper funcs. > > Signed-off-by:

Re: [PATCH] drm/tidss: Add prepare_fb to the plane helper funcs

2020-02-27 Thread Daniel Vetter
On Thu, Feb 27, 2020 at 11:31:39AM +0100, Daniel Vetter wrote: > On Thu, Feb 27, 2020 at 12:13:07PM +0200, Jyri Sarha wrote: > > From: Gowtham Tammana > > > > drm_gem_fb_prepare_fb() extracts fence and attaches to plane state. > > The fence info is needed if implicit fencing is used. Add this as

Re: [PATCH v5 1/3] drm/shmem: add support for per object caching flags.

2020-02-27 Thread Gerd Hoffmann
Hi, > I think it might be safe for some integrated graphics where the driver > maintainers can guarantee that it's safe on all particular processors used > with that driver, but then IMO it should be moved out to those drivers. > > Other drivers needing write-combine shouldn't really use shmem.

Re: [RFC PATCH 0/8] *** Refactor struct virtgpu_object ***

2020-02-27 Thread Gerd Hoffmann
On Wed, Feb 26, 2020 at 04:25:53PM -0800, Gurchetan Singh wrote: > The main motivation behind this is to have eventually have something like > this: patches 1+2 cherry-picked and pushed to -next. thanks, Gerd ___ dri-devel mailing list dri-devel@lis

[PATCH] drm/etnaviv: request pages from DMA32 zone when needed

2020-02-27 Thread Lucas Stach
Some Vivante GPUs are found in systems that have interconnects restricted to 32 address bits, but may have system memory mapped above the 4GB mark. As this region isn't accessible to the GPU via DMA any GPU memory allocated in the upper part needs to go through SWIOTLB bounce buffering. This kills

Re: [PATCH] drm/tilcdc: remove check for return value of debugfs functions.

2020-02-27 Thread Jyri Sarha
On 18/02/2020 17:55, Wambui Karuga wrote: > Remove the check and error handling of the return value of > drm_debugfs_create_files as it is not needed in tilcdc_debugfs_init. > Also remove local variables that are not used after the changes. > > Signed-off-by: Wambui Karuga Reviewed-by: Jyri Sarh

AW: [PATCH][V2] backlight: sky81452: insure while loop does not allow negative array indexing

2020-02-27 Thread Walter Harms
hi all, i would suggest converting this in to a more common for() loop. Programmers are bad in counting backwards. that kind of bug is common. re, wh Von: kernel-janitors-ow...@vger.kernel.org im Auftrag von Colin King Gesendet: Mittwoch, 26. Februar

Re: [PATCH] drm/bridge: analogix-anx6345: fix set of link bandwidth

2020-02-27 Thread Thomas Zimmermann
Hi Am 26.02.20 um 12:02 schrieb Icenowy Zheng: > > > 于 2020年2月26日 GMT+08:00 下午6:58:43, Thomas Zimmermann 写到: >> Hi Iceynow, >> >> Torsten asked me to merge your patch via drm-misc-next. I'd add the >> additional cc and fixes tags that Torsten listed. Are you OK with that? > > I think this fixe

Re: [PATCH][V2] backlight: sky81452: insure while loop does not allow negative array indexing

2020-02-27 Thread Daniel Thompson
On Wed, Feb 26, 2020 at 07:58:26PM +, Colin King wrote: > From: Colin Ian King > > In the unlikely event that num_entry is zero, the while loop > pre-decrements num_entry to cause negative array indexing into the > array sources. Fix this by iterating only if num_entry >= 0. > > Addresses-Co

Re: [PATCH v3 3/4] dt-bindings: display: imx: add bindings for DCSS

2020-02-27 Thread Philipp Zabel
Hi Laurentiu, On Fri, 2019-12-06 at 11:52 +0200, Laurentiu Palcu wrote: > Add bindings for iMX8MQ Display Controller Subsystem. > > Signed-off-by: Laurentiu Palcu > Reviewed-by: Rob Herring > --- > .../bindings/display/imx/nxp,imx8mq-dcss.yaml | 86 > ++ > 1 file chan

[PATCH v6] drm/tidss: dispc: Fix broken plane positioning code

2020-02-27 Thread Jyri Sarha
The old implementation of placing planes on the CRTC while configuring the planes was naive and relied on the order in which the planes were configured, enabled, and disabled. The situation where a plane's zpos was changed on the fly was completely broken. The usual symptoms of this problem was scr

Re: [PATCH v5 1/3] drm/shmem: add support for per object caching flags.

2020-02-27 Thread VMware
On 2/27/20 11:56 AM, Gerd Hoffmann wrote: Hi, I think it might be safe for some integrated graphics where the driver maintainers can guarantee that it's safe on all particular processors used with that driver, but then IMO it should be moved out to those drivers. Other drivers needing write

Re: [RFC 0/8] MIPS: CI20: add HDMI out support

2020-02-27 Thread Sam Ravnborg
Hi Nikolaus. On Wed, Feb 26, 2020 at 08:12:52PM +0100, H. Nikolaus Schaller wrote: > This patch series adds HDMI output to the jz4780/CI20 board. > > It is based on taking the old 3.18 vendor kernel and trying > to achieve the same with modern DTS setup and new/modified > drivers. > > Unfortunat

Re: [PATCH 02/21] drm: convert the drm_driver.debugfs_init() hook to return void.

2020-02-27 Thread Greg KH
On Thu, Feb 27, 2020 at 03:02:13PM +0300, Wambui Karuga wrote: > As a result of commit 987d65d01356 (drm: debugfs: make > drm_debugfs_create_files() never fail) and changes to various debugfs > functions in drm/core and across various drivers, there is no need for > the drm_driver.debugfs_init() ho

Re: [PATCH 17/21] drm/tilcdc: remove check for return value of debugfs functions.

2020-02-27 Thread Jyri Sarha
On 27/02/2020 14:02, Wambui Karuga wrote: > Since 987d65d01356 (drm: debugfs: make > drm_debugfs_create_files() never fail), drm_debugfs_create_files() never > fails. Therefore, remove the check and error handling of the return > value of drm_debugfs_create_files() as it is not needed in > tilcdc_d

Re: [PATCH 02/21] drm: convert the drm_driver.debugfs_init() hook to return void.

2020-02-27 Thread Greg KH
On Thu, Feb 27, 2020 at 03:29:46PM +0300, Wambui Karuga wrote: > > > On Thu, 27 Feb 2020, Greg KH wrote: > > > On Thu, Feb 27, 2020 at 03:02:13PM +0300, Wambui Karuga wrote: > > > As a result of commit 987d65d01356 (drm: debugfs: make > > > drm_debugfs_create_files() never fail) and changes to v

[v2 1/2] drm/msm/dpu: add DP support for sc7180 target

2020-02-27 Thread Krishna Manikandan
Add the required changes to support Display Port for sc7180 target. Signed-off-by: Krishna Manikandan Changes in v2: - Change in commit message This patch has dependency on the below series https://patchwork.kernel.org/patch/11269169/ --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c

Re: [PATCH v2 6/6] arm64: allwinner: a64: enable LCD-related hardware for Pinebook

2020-02-27 Thread Maxime Ripard
On Wed, Feb 26, 2020 at 12:10:11AM -0800, Vasily Khoruzhick wrote: > From: Icenowy Zheng > > Pinebook has an ANX6345 bridge connected to the RGB666 LCD output and > eDP panel input. The bridge is controlled via I2C that's connected to > R_I2C bus. > > Enable all this hardware in device tree. > > R

[PATCH 04/21] drm/vram-helper: make drm_vram_mm_debugfs_init() return void

2020-02-27 Thread Wambui Karuga
Since 987d65d01356 (drm: debugfs: make drm_debugfs_create_files() never fail), drm_debugfs_create_files() never fails and should return void. Therefore, remove its use as the return value of drm_vram_mm_debugfs_init(), and have the function declared as void instead. Signed-off-by: Wambui Karuga -

[PATCH 08/21] drm/etnaviv: remove check for return value of drm_debugfs function

2020-02-27 Thread Wambui Karuga
Since commit 987d65d01356 (drm: debugfs: make drm_debugfs_create_files() never fail), drm_debugfs_create_file only returns 0, and there is no need to check the return value. This change therefore removes the check and error handling in etnaviv_debugfs_init() and also makes the function return void.

RE: [PATCH libdrm] modetest: call drmModeCrtcSetGamma() only if add_property_optional returns true

2020-02-27 Thread Rohit Visavalia
Gentle reminder. + Ilia Mirkin, +Emil Velikov. Thanks & Regards, Rohit > -Original Message- > From: Rohit Visavalia [mailto:rohit.visava...@xilinx.com] > Sent: Tuesday, February 25, 2020 3:08 PM > To: dri-devel@lists.freedesktop.org > Cc: Hyun Kwon ; Ranganathan Sk ; > Dhaval Rajeshbhai

Re: [PATCH 2/7] docs: dt: fix several broken references due to renames

2020-02-27 Thread Daniel Lezcano
On 22/02/2020 10:00, Mauro Carvalho Chehab wrote: > Several DT references got broken due to txt->yaml conversion. > > Those are auto-fixed by running: > > scripts/documentation-file-ref-check --fix > > Signed-off-by: Mauro Carvalho Chehab [ ... ] > diff --git > a/Documentation/devicetr

[PATCH 19/21] drm/mipi_dbi: make midi_dbi_debugfs_init() return void.

2020-02-27 Thread Wambui Karuga
As midi_dbi_debugfs_init() never fails and does not return anything other than zero, declare its return value as void. Signed-off-by: Wambui Karuga --- drivers/gpu/drm/drm_mipi_dbi.c | 6 +- include/drm/drm_mipi_dbi.h | 2 +- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a

[PATCH 02/21] drm: convert the drm_driver.debugfs_init() hook to return void.

2020-02-27 Thread Wambui Karuga
As a result of commit 987d65d01356 (drm: debugfs: make drm_debugfs_create_files() never fail) and changes to various debugfs functions in drm/core and across various drivers, there is no need for the drm_driver.debugfs_init() hook to have a return value. Therefore, declare it as void. Signed-off-b

[PATCH 21/21] drm/arm: have malidp_debufs_init() return void

2020-02-27 Thread Wambui Karuga
As there's no need for the return value in malidp_debugfs_init() after the conversion of the drm_driver.debugfs_init() hook, (drm: convert the .debugs_init() hook to return void), convert the malidp_debugfs_init() function to return void. Signed-off-by: Wambui Karuga --- drivers/gpu/drm/arm/mali

[PATCH 07/21] drm/arm: make hdlcd_debugfs_init() return void

2020-02-27 Thread Wambui Karuga
Since commit 987d65d01356 (drm: debugfs: make drm_debugfs_create_files() never fail), drm_debugfs_create_files() never fails, and should return void. Therefore, remove its use as a return value in hdlcd_debugfs_init and have the latter function return void. Signed-off-by: Wambui Karuga --- drive

[PATCH 13/21] drm/omapdrm: remove checks for return value of drm_debugfs functions.

2020-02-27 Thread Wambui Karuga
Since 987d65d01356 (drm: debugfs: make drm_debugfs_create_files() never fail), there is no need to ever check the return value for drm_debugfs_create_files(). Therefore remove the checks for the return value and subsequent error handling in omap_debugfs_init(). These changes also enables the chang

[PATCH 05/21] drm/vc4: remove check of return value of drm_debugfs functions

2020-02-27 Thread Wambui Karuga
Since 987d65d01356 (drm: debugfs: make drm_debugfs_create_files() never fail), drm_debugfs_create_files() never fails and should return void. Therefore, remove unnecessary check and error handling for the return value of drm_debugfs_create_files() in vc4_debugfs_init(). This change also allows vc4

[PATCH 17/21] drm/tilcdc: remove check for return value of debugfs functions.

2020-02-27 Thread Wambui Karuga
Since 987d65d01356 (drm: debugfs: make drm_debugfs_create_files() never fail), drm_debugfs_create_files() never fails. Therefore, remove the check and error handling of the return value of drm_debugfs_create_files() as it is not needed in tilcdc_debugfs_init(). Also remove local variables that are

[PATCH 00/21] drm: subsytem-wide debugfs functions refactor

2020-02-27 Thread Wambui Karuga
This series includes work on various debugfs functions both in drm/core and across various drivers in the subsystem. Since commit 987d65d01356 (drm: debugfs: make drm_debugfs_create_files() never fail), drm_debugfs_create_files() does not fail and only returns zero. This series therefore removes th

[PULL] drm-misc-next

2020-02-27 Thread Maxime Ripard
Hi Dave, Daniel, Here's this week drm-misc-next PR. Thank! Maxime drm-misc-next-2020-02-27: drm-misc-next for $kernel-version: UAPI Changes: Cross-subsystem Changes: Core Changes: - bridge: huge rework to get rid of omap_dss custom display drivers Driver Changes: - hisilicon: some fixes

Re: [PATCH 02/21] drm: convert the drm_driver.debugfs_init() hook to return void.

2020-02-27 Thread Wambui Karuga
On Thu, 27 Feb 2020, Greg KH wrote: On Thu, Feb 27, 2020 at 03:02:13PM +0300, Wambui Karuga wrote: As a result of commit 987d65d01356 (drm: debugfs: make drm_debugfs_create_files() never fail) and changes to various debugfs functions in drm/core and across various drivers, there is no need f

[v2 2/2] drm/msm/dpu: fix reservation cleanup during modeset

2020-02-27 Thread Krishna Manikandan
Missing return statement will cause the reservations to get released prematurely, thus messing up the allocation for any next successive datapath reservation. Signed-off-by: Krishna Manikandan Changes in v2: - Change in commit message --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 2

[PATCH 18/21] drm/virtio: make virtio_gpu_debugfs() return void.

2020-02-27 Thread Wambui Karuga
Since 987d65d01356 (drm: debugfs: make drm_debugfs_create_files() never fail), drm_debugfs_create_files() never fails and should return void. Therefore, remove its use as the return value of virtio_gpu_debugfs() and have the latter function return void. Signed-off-by: Wambui Karuga --- drivers/g

[PATCH 11/21] drm/v3d: make v3d_debugfs_init return void

2020-02-27 Thread Wambui Karuga
Since commit 987d65d01356 (drm: debugfs: make drm_debugfs_create_files() never fail), drm_debugfs_create_files() never fails and should return void. Therefore, remove its use as the return value of v3d_debugfs_init and have the function return void instead. Signed-off-by: Wambui Karuga --- drive

[PATCH 01/21] drm/debugfs: remove checks for return value of drm_debugfs functions.

2020-02-27 Thread Wambui Karuga
Since 987d65d01356 (drm: debugfs: make drm_debugfs_create_files() never fail), there is no need to check the return value of drm_debugfs_create_files(). Therefore, remove remove unnecessary checks and error handling statement blocks for its return value. These changes also enable changing drm_debu

[PATCH 12/21] drm/msm: remove checks for return value of drm_debugfs functions.

2020-02-27 Thread Wambui Karuga
Since commit 987d65d01356 (drm: debugfs: make drm_debugfs_create_files() never fail), drm_debugfs_create_files() does not fail, and should return void. This change therefore removes the checks of its return value in drm/msm and subsequent error handling. These changes also enable the changing of v

[PATCH 03/21] drm: convert drm_debugfs functions to return void

2020-02-27 Thread Wambui Karuga
Since 987d65d01356 (drm: debugfs: make drm_debugfs_create_files() never fail), drm_debug_create_files() never fails and should return void. Therefore, drop return value from various drm_debugfs functions that return drm_debug_create_files() and convert the functions to return void. Signed-off-by:

Re: [PATCH 17/21] drm/tilcdc: remove check for return value of debugfs functions.

2020-02-27 Thread Wambui Karuga
On Thu, 27 Feb 2020, Jyri Sarha wrote: On 27/02/2020 14:02, Wambui Karuga wrote: Since 987d65d01356 (drm: debugfs: make drm_debugfs_create_files() never fail), drm_debugfs_create_files() never fails. Therefore, remove the check and error handling of the return value of drm_debugfs_create_fil

  1   2   3   >