Re: [PATCH v5 1/3] drm/shmem: add support for per object caching flags.

2020-02-26 Thread Chia-I Wu
On Wed, Feb 26, 2020 at 10:25 AM Thomas Hellström (VMware) wrote: > > Hi, Gerd, > > While looking at this patchset I came across some stuff that seems > strange but that was merged in a previous patchset. > > (please refer to > https://lists.freedesktop.org/archives/dri-devel/2018-September/190001

[RFC PATCH 0/8] *** Refactor struct virtgpu_object ***

2020-02-26 Thread Gurchetan Singh
The main motivation behind this is to have eventually have something like this: struct virtio_gpu_shmem { ?? ?? struct drm_gem_shmem_object base; ?? ?? uint32_t hw_res_handle; ?? ?? struct sg_table *pages; ?? ?? (...) }; struct virtio_gpu_vram { ?? ?? struct drm_gem_object base; ??// or *drm_gem_

[RFC PATCH 1/8] drm/virtio: make mmap callback consistent with callbacks

2020-02-26 Thread Gurchetan Singh
This is a very, very minor cleanup. Signed-off-by: Gurchetan Singh --- drivers/gpu/drm/virtio/virtgpu_object.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_object.c b/drivers/gpu/drm/virtio/virtgpu_object.c index 3d2a6d489bfc..07de3260118a 1

[RFC PATCH 3/8] drm/virtio: add virtio_gpu_get_handle function

2020-02-26 Thread Gurchetan Singh
Whether the resource is a shmem based resource or a (planned) vram based resource, it will have a resource handle associated with it. Since the hypercall interface works on resource handles, add a function that returns the handle given a GEM object. Signed-off-by: Gurchetan Singh --- drivers/gpu

[RFC PATCH 4/8] drm/virtio: make RESOURCE_UNREF use virtio_gpu_get_handle(..)

2020-02-26 Thread Gurchetan Singh
This hypercall is reusable for both shmem and (planned) vram based virtgpu objects. Signed-off-by: Gurchetan Singh --- drivers/gpu/drm/virtio/virtgpu_drv.h| 2 +- drivers/gpu/drm/virtio/virtgpu_object.c | 2 +- drivers/gpu/drm/virtio/virtgpu_vq.c | 17 +++-- 3 files changed

[RFC PATCH 8/8] drm/virtio: rename virtio_gpu_object to virtio_gpu_shmem

2020-02-26 Thread Gurchetan Singh
This renames struct virtio_gpu_object to struct virtio_gpu_shmem. This will go in line with the planned struct virtio_gpu_vram. Signed-off-by: Gurchetan Singh --- drivers/gpu/drm/virtio/virtgpu_drv.h| 22 ++--- drivers/gpu/drm/virtio/virtgpu_gem.c| 12 +-- drivers/gpu/drm/virtio/virtgp

[RFC PATCH 6/8] drm/virtio: rename virtio_gpu_object_array to virtio_gpu_gem_array

2020-02-26 Thread Gurchetan Singh
The plan is to use this array with VRAM objects too. Signed-off-by: Gurchetan Singh --- drivers/gpu/drm/virtio/virtgpu_drv.h| 36 drivers/gpu/drm/virtio/virtgpu_gem.c| 116 drivers/gpu/drm/virtio/virtgpu_ioctl.c | 32 +++ drivers/gpu/drm/virtio/vi

[RFC PATCH 2/8] drm/virtio: add virtio_gpu_is_shmem helper

2020-02-26 Thread Gurchetan Singh
The plan is use have both shmem and virtual "vram" running side-by-side in virtio-gpu. It looks like we'll eventually use struct drm_gem_object as a base class, and we'll need to convert to shmem and vram objects on the fly. As a first step, add a virtio_gpu_is_shmem helper. Thanks to kraxel for su

[RFC PATCH 7/8] drm/virtio: rename virtio_gpu_object_params to virtio_gpu_create_params

2020-02-26 Thread Gurchetan Singh
Currently, struct virtio_gpu_object refers to the SHMEM based object, which is fair. We want to expand that a bit, so let's expand the creation params too. Signed-off-by: Gurchetan Singh --- drivers/gpu/drm/virtio/virtgpu_drv.h| 10 +- drivers/gpu/drm/virtio/virtgpu_gem.c| 4 ++-

[RFC PATCH 5/8] drm/virtio: make {ATTACH_RESOURCE, DETACH_RESOURCE} use virtio_gpu_get_handle(..)

2020-02-26 Thread Gurchetan Singh
These hypercalls are reusable by both shmem and (planned) vram based virtio_gpu objects. Signed-off-by: Gurchetan Singh --- drivers/gpu/drm/virtio/virtgpu_vq.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_vq.c b/drivers/gpu/drm/virti

[drm-intel:for-linux-next 3/6] drivers/gpu//drm/i915/display/intel_display.c:253:1: error: 'has_transcoder' defined but not used

2020-02-26 Thread kbuild test robot
tree: git://anongit.freedesktop.org/drm-intel for-linux-next head: 7a0a6ee731508b770f3ee198af7b0c87a20ebb80 commit: d54c1a513c487ac6d6b3c4595e93e3625b461cc3 [3/6] drm/i915: Fix broken transcoder err state config: x86_64-randconfig-b003-20200226 (attached as .config) compiler: gcc-7 (Debian

Re: [PATCHv2 00/56] drm/omap: Convert DSI code to use drm_mipi_dsi and drm_panel

2020-02-26 Thread Sebastian Reichel
Hi, On Wed, Feb 26, 2020 at 02:28:23PM +0200, Tomi Valkeinen wrote: > On 25/02/2020 01:20, Sebastian Reichel wrote: > > This updates the existing omapdrm DSI code, so that it uses > > common drm_mipi_dsi API and drm_panel. > > > > The patchset has been tested with Droid 4 using Linux console, X.o

Re: [PATCHv2 43/56] drm/omap: bind components with drm_device argument

2020-02-26 Thread Sebastian Reichel
Hi, On Tue, Feb 25, 2020 at 12:21:13AM +0100, Sebastian Reichel wrote: > This fixes the omapdrm driver to call component_bind_all() > with drm_device as data argument as recommended in the > DRM component helper usage text. > > After this patch DRM functionality can be implemented directly > in t

Re: [PATCH v9 1/4] drm/mediatek: Use regmap for register access

2020-02-26 Thread CK Hu
Hi, Enric: On Wed, 2020-02-26 at 11:54 +0100, Enric Balletbo i Serra wrote: > From: Matthias Brugger > > The mmsys memory space is shared between the drm and the > clk driver. Use regmap to access it. Once there is a mmsys driver and clock control is moved into mmsys driver, I think we should a

Re: [PATCH v9 3/4] soc: mediatek: Move mt8173 MMSYS to platform driver

2020-02-26 Thread CK Hu
Hi, Enric: On Wed, 2020-02-26 at 11:54 +0100, Enric Balletbo i Serra wrote: > From: Matthias Brugger > > There is no strong reason for this to use CLK_OF_DECLARE instead of > being a platform driver. Plus, this driver provides clocks but also > a shared register space for the mediatek-drm and th

Re: [PATCH v9 4/4] drm/mediatek: Fix mediatek-drm device probing

2020-02-26 Thread CK Hu
Hi, Enric: On Wed, 2020-02-26 at 11:54 +0100, Enric Balletbo i Serra wrote: > In the actual implementation the same compatible string > "mediatek,-mmsys" is used to bind the clock drivers > (drivers/soc/mediatek) as well as to the gpu driver > (drivers/gpu/drm/mediatek/mtk_drm_drv.c). This ends wi

Re: [PATCH v9 0/4] arm64: mediatek: Fix mt8173 mmsys device probing

2020-02-26 Thread CK Hu
Hi, Enric: I would like you to modify mmsys binding document. In current document, mmsys is a clock controller, but I think it's a system controller including clock control, routing control, and miscellaneous control in mmsys partition. Regards, CK On Wed, 2020-02-26 at 11:54 +0100, Enric Ballet

[pull] radeon, amdgpu 5.6 fixes

2020-02-26 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 5.6. The following changes since commit 97d9a4e9619a822c5baf6a63e6f5b80fee4d4213: Merge tag 'drm-intel-fixes-2020-02-20' of git://anongit.freedesktop.org/drm/drm-intel into drm-fixes (2020-02-21 12:46:54 +1000) are available in the Git repository at: git://peop

Re: + dma-buf-free-dmabuf-name-in-dma_buf_release.patch added to -mm tree

2020-02-26 Thread Andrew Morton
On Wed, 26 Feb 2020 10:36:26 +0100 Daniel Vetter wrote: > On Wed, Feb 26, 2020 at 5:29 AM Sumit Semwal wrote: > > > > Hello Andrew, > > > > > > On Wed, 26 Feb 2020 at 07:25, Andrew Morton > > wrote: > > > > > > > > > The patch titled > > > Subject: dma-buf: free dmabuf->name in dma_buf_re

[pull] radeon, amdgpu, amdkfd drm-next-5.7

2020-02-26 Thread Alex Deucher
Hi Dave, Daniel, New stuff for 5.7. The following changes since commit 58fe03d6dec908a1bec07eea7e94907af5c07eec: drm/amd/dm/mst: Ignore payload update failures (2020-02-04 23:30:39 -0500) are available in the Git repository at: git://people.freedesktop.org/~agd5f/linux tags/amd-drm-next-5.

[PULL] drm-intel-fixes

2020-02-26 Thread Jani Nikula
Hi Dave & Daniel - Switching gen7 back to aliasing-ppgtt seems to be the main highlight here. BR, Jani. drm-intel-fixes-2020-02-27: drm/i915 fixes for v5.6-rc4: - downgrade gen7 back to aliasing-ppgtt to avoid GPU hangs - shrinker fix - pmu leak and double free fixes - gvt user after free and

Re: [PATCH] drm/mediatek: Remove debug messages for function calls

2020-02-26 Thread CK Hu
Hi, Enric: On Wed, 2020-02-26 at 12:27 +0100, Enric Balletbo i Serra wrote: > Equivalent information can be nowadays obtained using function tracer. > Reviewed-by: CK Hu > Signed-off-by: Enric Balletbo i Serra > --- > > drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 5 - > drivers/gpu/drm/me

RE: [Intel-gfx][PATCH 01/10] drm/i915: Add i915 device based MISSING_CASE macro

2020-02-26 Thread Laxminarayan Bharadiya, Pankaj
Hi Chris, > -Original Message- > From: Chris Wilson > Sent: 25 February 2020 19:32 > To: David Airlie ; Joonas Lahtinen > ; Laxminarayan Bharadiya, Pankaj > ; Vivi, Rodrigo > ; dan...@ffwll.ch; dri-devel@lists.freedesktop.org; > intel-...@lists.freedesktop.org; jani.nik...@linux.intel.com

[PATCH v2] drm/exynos: dsi: propagate error value and silence meaningless warning

2020-02-26 Thread Marek Szyprowski
Properly propagate error value from devm_regulator_bulk_get() and don't confuse user with meaningless warning about failure in getting regulators in case of deferred probe. Signed-off-by: Marek Szyprowski --- v2: rephrased commit message --- drivers/gpu/drm/exynos/exynos_drm_dsi.c | 5 +++-- 1 f

Re: [PATCH v5 1/3] drm/shmem: add support for per object caching flags.

2020-02-26 Thread VMware
On 2/27/20 1:02 AM, Chia-I Wu wrote: On Wed, Feb 26, 2020 at 10:25 AM Thomas Hellström (VMware) wrote: Hi, Gerd, #define to_drm_gem_shmem_obj(obj) \ diff --git a/drivers/gpu/drm/drm_gem_shmem_helper.c b/drivers/gpu/drm/drm_gem_shmem_helper.c index a421a2eed48a..aad9324dcf4f 100644 --- a/

Re: [RFC PATCH 0/8] *** Refactor struct virtgpu_object ***

2020-02-26 Thread Gerd Hoffmann
On Wed, Feb 26, 2020 at 04:25:53PM -0800, Gurchetan Singh wrote: > The main motivation behind this is to have eventually have something like > this: > > struct virtio_gpu_shmem { >     struct drm_gem_shmem_object base; >     uint32_t hw_res_handle; >     struct sg_table *pages; >     (...) > }; >

Re: [PATCH v5 1/3] drm/shmem: add support for per object caching flags.

2020-02-26 Thread Gerd Hoffmann
Hi, > > + if (!shmem->map_cached) > > + prot = pgprot_writecombine(prot); > > shmem->vaddr = vmap(shmem->pages, obj->size >> PAGE_SHIFT, > > - VM_MAP, pgprot_writecombine(PAGE_KERNEL)); > > + VM_M

<    1   2   3