Re: [PATCH v2 2/2] drm/format_helper: Dual licence the file in GPL 2 and MIT

2020-02-17 Thread Gerd Hoffmann
On Sat, Feb 15, 2020 at 07:09:11PM +0100, Emmanuel Vadot wrote: > From: Emmanuel Vadot > > Contributors for this file are : > Gerd Hoffmann > Maxime Ripard > Noralf Trønnes > > Signed-off-by: Emmanuel Vadot > --- > drivers/gpu/drm/drm_format_helper.c | 2 +- > 1 file changed, 1 insertion(+)

Re: [PATCHv4,04/36] drm/gem-fb-helper: Add special version of drm_gem_fb_size_check

2020-02-17 Thread james qian wang (Arm Technology China)
Hi Andrzej: Really a good idea for introducing this custom size check, it's very useful for some Komeda/malidp format, espcially pitch_multiplier, maybe in future we can add it into into the drm_format_info. On Fri, Dec 13, 2019 at 04:58:35PM +0100, Andrzej Pietrasiewicz wrote: > The new vers

[PATCH v2 12/12] MIPS: DTS: CI20: fix interrupt for pcf8563 RTC

2020-02-17 Thread H. Nikolaus Schaller
Interrupts should not be specified by interrupt line but by gpio parent and reference. Fixes: 73f2b940474d ("MIPS: CI20: DTS: Add I2C nodes") Signed-off-by: H. Nikolaus Schaller --- arch/mips/boot/dts/ingenic/ci20.dts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/mi

Re: [PATCH] drm/sun4i: tcon: Support LVDS on the A33

2020-02-17 Thread Maxime Ripard
On Fri, Feb 14, 2020 at 01:24:27PM +0100, Maxime Ripard wrote: > The A33 TCON supports LVDS, so we can toggle the support switch. > > Signed-off-by: Maxime Ripard Sorry, that one was a spurious send-email run ... Maxime signature.asc Description: PGP signature _

Re: [PATCH v2 1/2] drm/client: Dual licence the file in GPL-2 and MIT

2020-02-17 Thread Denis Efremov
15.02.2020 21:09, Emmanuel Vadot пишет: > From: Emmanuel Vadot > > Contributors for this file are : > Chris Wilson > Denis Efremov > Jani Nikula > Maxime Ripard > Noralf Trønnes > Sam Ravnborg > Thomas Zimmermann > > Signed-off-by: Emmanuel Vadot Acked-by: Denis Efremov for my one-l

[PATCH v2 10/12] MIPS: DTS: CI20: add DT node for SW1 as Enter button

2020-02-17 Thread H. Nikolaus Schaller
The SW1 button can be used as a simple one-button keyboard and is connected to PD17. Note: SW1 has a second meaning to change the boot sequence when pressed while powering on. Signed-off-by: H. Nikolaus Schaller --- arch/mips/boot/dts/ingenic/ci20.dts | 12 1 file changed, 12 inser

Re: [PATCH v7 01/13] dt-bindings: arm: move mmsys description to display

2020-02-17 Thread Enric Balletbo i Serra
Hi CK, On 14/2/20 11:01, Matthias Brugger wrote: > > > On 14/02/2020 07:42, CK Hu wrote: >> Hi, Matthias: >> >> On Thu, 2020-02-13 at 21:19 +0100, matthias@kernel.org wrote: >>> From: Matthias Brugger >>> >>> The mmsys block provides registers and clocks for the display >>> subsystem. The b

Re: [PATCH v2 12/12] MIPS: DTS: CI20: fix interrupt for pcf8563 RTC

2020-02-17 Thread Paul Cercueil
Hi Nikolaus, Le ven., févr. 14, 2020 at 17:10, H. Nikolaus Schaller a écrit : Interrupts should not be specified by interrupt line but by gpio parent and reference. Fixes: 73f2b940474d ("MIPS: CI20: DTS: Add I2C nodes") If you add a Fixes tag, you should also add: Cc: sta...@vger.kernel.or

Re: [PATCH 1/1] Support LVDS output on Allwinner A20

2020-02-17 Thread Maxime Ripard
On Thu, Feb 13, 2020 at 08:11:10PM +0200, Andrey Lebedev wrote: > On Thu, Feb 13, 2020 at 10:24:33AM +0100, Maxime Ripard wrote: > > > > do you have a board when you have been able to test it? > > > > > > Yes, I have the hardware (Cubieboard 2) at hand, but I cannot change the > > > any physical co

[PATCH v2 2/2] drm/format_helper: Dual licence the file in GPL 2 and MIT

2020-02-17 Thread Emmanuel Vadot
From: Emmanuel Vadot Contributors for this file are : Gerd Hoffmann Maxime Ripard Noralf Trønnes Signed-off-by: Emmanuel Vadot --- drivers/gpu/drm/drm_format_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_format_helper.c b/drivers/gpu/drm/d

[PATCH v2 05/12] MIPS: DTS: CI20: fix PMU definitions for ACT8600

2020-02-17 Thread H. Nikolaus Schaller
There is a ACT8600 on the CI20 board and the bindings of the ACT8865 driver have changed without updating the CI20 device tree. Therefore the PMU can not be probed successfully and is running in power-on reset state. Fix DT to match the latest act8865-regulator bindings. Fixes: 73f2b940474d ("MIP

[PATCH 2/4] dt-bindings: panel: lvds: Add properties for clock and data polarities

2020-02-17 Thread Maxime Ripard
Some LVDS encoders can support multiple polarities on the data and clock lanes, and similarly some panels require a given polarity on their inputs. Add a property on the panel to configure the encoder properly. Signed-off-by: Maxime Ripard --- Documentation/devicetree/bindings/display/panel/lvds

Re: [PATCH v2 2/2] ARM: sun7i: dts: Add LVDS panel support on A20

2020-02-17 Thread Andrey Lebedev
On Fri, Feb 14, 2020 at 09:53:51AM +0100, Maxime Ripard wrote: > On Fri, Feb 14, 2020 at 10:43:58AM +0200, Andrey Lebedev wrote: > > On Fri, Feb 14, 2020 at 08:52:18AM +0100, Maxime Ripard wrote: > > > > > This will create a spurious warning message for TCON1, since we > > > > > adjusted the driver

Re: [PATCH v2 2/2] ARM: sun7i: dts: Add LVDS panel support on A20

2020-02-17 Thread Maxime Ripard
On Fri, Feb 14, 2020 at 10:43:58AM +0200, Andrey Lebedev wrote: > On Fri, Feb 14, 2020 at 08:52:18AM +0100, Maxime Ripard wrote: > > > > This will create a spurious warning message for TCON1, since we > > > > adjusted the driver to tell it supports LVDS, but there's no LVDS > > > > reset line, so w

[PATCH 2/3] gpu/drm: ingenic: Switch emulated fbdev to 16bpp

2020-02-17 Thread Paul Cercueil
The fbdev emulation is only ever used on Ingenic SoCs to run old SDL1 based games at 16bpp (rgb565). Recent applications generally talk to DRM directly, and can request their favourite pixel format; so we can make everybody happy by switching the emulated fbdev to 16bpp. Signed-off-by: Paul Cercue

Re: [PATCH v3 3/3] ARM: dts: sun7i: Add LVDS panel support on A20

2020-02-17 Thread Maxime Ripard
On Thu, Feb 13, 2020 at 10:18:57PM +0200, Andrey Lebedev wrote: > From: Andrey Lebedev > > Define pins for LVDS channels 0 and 1, configure reset line for tcon0 and > provide sample LVDS panel, connected to tcon0. > > Signed-off-by: Andrey Lebedev > --- > arch/arm/boot/dts/sun7i-a20.dtsi | 28 ++

[PATCH] drm/sun4i: dsi: Avoid hotplug race with DRM driver bind

2020-02-17 Thread Samuel Holland
We need to make sure that the DRM driver is fully registered before allowing the panel to be attached. Otherwise, we may trigger a hotplug event before sun4i_framebuffer_init() sets up drm->mode_config.funcs, causing a NULL pointer dereference. Fixes: 1a2703bd7356 ("drm/sun4i: dsi: Allow binding t

[PATCH v2 08/12] MIPS: DTS: CI20: add DT node for IR sensor

2020-02-17 Thread H. Nikolaus Schaller
From: Alex Smith The infrared sensor on the CI20 board is connected to a GPIO and can be operated by using the gpio-ir-recv driver. Add a DT node for the sensor to allow that driver to be used. Signed-off-by: Alex Smith Signed-off-by: H. Nikolaus Schaller --- arch/mips/boot/dts/ingenic/ci20.d

[PATCH 1/4] drm/connector: Add data polarity flags

2020-02-17 Thread Maxime Ripard
Some LVDS encoders can change the polarity of the data signals being sent. Add a DRM bus flag to reflect this. Signed-off-by: Maxime Ripard --- include/drm/drm_connector.h | 4 1 file changed, 4 insertions(+) diff --git a/include/drm/drm_connector.h b/include/drm/drm_connector.h index 2219

[PATCH] drm/sun4i: tcon: Support LVDS on the A33

2020-02-17 Thread Maxime Ripard
The A33 TCON supports LVDS, so we can toggle the support switch. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/sun4i/sun4i_tcon.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/sun4i/sun4i_tcon.c b/drivers/gpu/drm/sun4i/sun4i_tcon.c index fdf143042f83..14026b4fa7c7 10064

[PATCH 1/2] dt-bindings: display: sun4i-tcon: Add LVDS Dual Link property

2020-02-17 Thread Maxime Ripard
SoCs that have multiple TCONs can use the two set of pins on the first TCON to drive a dual-link display. Add a property to enable the dual link. Signed-off-by: Maxime Ripard --- .../bindings/display/allwinner,sun4i-a10-tcon.yaml | 7 +++ 1 file changed, 7 insertions(+) diff --git

[PATCH] Correct typos in comments

2020-02-17 Thread Maya Rashish
Signed-off-by: Maya Rashish Co-authored-by: Thomas Klausner --- drivers/gpu/drm/amd/include/atombios.h | 20 ++-- drivers/gpu/drm/amd/include/atomfirmware.h | 4 ++-- drivers/gpu/drm/radeon/atombios.h | 8 drivers/gpu/drm/vmwgfx/vmwgfx_kms.c| 2 +-

[PATCH 4/4] drm/sun4i: lvds: Support data and clock polarity flags

2020-02-17 Thread Maxime Ripard
Our LVDS encoder can change the polarity of data and clock signals on the LVDS link. Make sure we don't ignore the matching bus flags. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/sun4i/sun4i_tcon.c | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/drivers

[PATCH v2 03/12] MIPS: CI20: defconfig: configure for supporting modules

2020-02-17 Thread H. Nikolaus Schaller
Not all drivers need to be compiled into the kernel. Support building and loading of kernel modules. Signed-off-by: H. Nikolaus Schaller --- arch/mips/configs/ci20_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/mips/configs/ci20_defconfig b/arch/mips/configs/ci20_defconfig in

Re: [PATCH 3/4] drm/sun4i: dsi: Allow binding the host without a panel

2020-02-17 Thread Samuel Holland
Maxime, On 2/11/20 1:28 AM, Samuel Holland wrote: > Currently, the DSI host blocks binding the display pipeline until the > panel is available. This unnecessarily prevents other display outpus > from working, and adds logspam to dmesg when the panel driver is built > as a module (the component mas

[PATCH 2/2] drm/sun4i: tcon: Support LVDS dual-link

2020-02-17 Thread Maxime Ripard
Some LVDS encoders in the Allwinner SoCs can output on a dual-link. Let's add a DT property to toggle it. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/sun4i/sun4i_tcon.c | 6 ++ drivers/gpu/drm/sun4i/sun4i_tcon.h | 4 2 files changed, 10 insertions(+) diff --git a/drivers/gpu/drm/s

[PATCH 3/4] drm/panel: lvds: Support data and clock polarity flags

2020-02-17 Thread Maxime Ripard
Add device tree properties to the panel-lvds driver to set the bus flags properly. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/panel/panel-lvds.c | 25 ++--- 1 file changed, 22 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-lvds.c b/drivers/gpu/

[PATCH 17/30] drm/vkms: Add missing annotation for vkms_crtc_atomic_flush()

2020-02-17 Thread Jules Irenge
Sparse reports a warning at vkms_crtc_atomic_flush() warning: context imbalance in vkms_crtc_atomic_flush() - unexpected unlock The root cause is the missing annotation at vkms_crtc_atomic_flush() Add the missing __releases(&vkms_output->lock) annotation Signed-off-by: Jules Irenge ---

Re: [PATCH v2 01/12] drm: ingenic-drm: add MODULE_DEVICE_TABLE

2020-02-17 Thread H. Nikolaus Schaller
> Am 14.02.2020 um 20:06 schrieb Paul Cercueil : > > Hi Nikolaus, > > Please rebase this patch on top of drm-misc-next and send it apart - it > should go through the DRM tree. > > > Le ven., févr. 14, 2020 at 17:10, H. Nikolaus Schaller a > écrit : >> Add MODULE_DEVICE_TABLE so that the dr

[PATCH 1/3] gpu/drm: ingenic: Add trick to support 16bpp on 24-bit panels

2020-02-17 Thread Paul Cercueil
If the panel interface is 24-bit but our primary plane is 16bpp, configure as if the panel was 18-bit. This tricks permits the display of 16bpp data on a 24-bit panel by wiring each color component to the MSBs of the 24-bit interface. Signed-off-by: Paul Cercueil --- drivers/gpu/drm/ingenic/inge

Re: [PATCH v2 03/12] MIPS: CI20: defconfig: configure for supporting modules

2020-02-17 Thread Paul Cercueil
Le ven., févr. 14, 2020 at 20:30, H. Nikolaus Schaller a écrit : Hi Paul, Am 14.02.2020 um 20:10 schrieb Paul Cercueil : Hi Nikolaus, Patches 03-12 only touch the same two files - ci20.dts and ci20_defconfig. Unless someone strongly disagrees, I'd suggest to squash all patches th

Re: [PATCH v2 01/12] drm: ingenic-drm: add MODULE_DEVICE_TABLE

2020-02-17 Thread Paul Cercueil
Hi Nikolaus, Please rebase this patch on top of drm-misc-next and send it apart - it should go through the DRM tree. Le ven., févr. 14, 2020 at 17:10, H. Nikolaus Schaller a écrit : Add MODULE_DEVICE_TABLE so that the driver can load by matching the device tree if compiled as module. Sign

[PATCH RESEND] drm/mcde: Fix Sphinx formatting

2020-02-17 Thread Jonathan Neuschäfer
- Format the pipe diagram as a monospace block. - Fix formatting of the list. Without the empty line, the first dash is not parsed as a bullet point. Signed-off-by: Jonathan Neuschäfer --- Previous copy: https://lore.kernel.org/lkml/20191002153827.23026-2-j.neuschae...@gmx.net/ It seems that

[PATCH v2 11/12] MIPS: CI20: defconfig: configure for CONFIG_KEYBOARD_GPIO=m

2020-02-17 Thread H. Nikolaus Schaller
The SW1 button is hooked up to send input events. Signed-off-by: H. Nikolaus Schaller --- arch/mips/configs/ci20_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/mips/configs/ci20_defconfig b/arch/mips/configs/ci20_defconfig index 0458ea4d54e8..0db0088bbc1c 100644 --- a/arch/mi

[PATCH v2 00/12] MIPS: Fixes and improvements for CI20 board (JZ4780)

2020-02-17 Thread H. Nikolaus Schaller
V2: * dropped "net: davicom: dm9000: allow to pass MAC address through mac_addr module parameter" from this series because it goes through the netdev tree (suggested by Andrew Lunn ) * added a "fixes:" for "MIPS: DTS: CI20: fix PMU definitions for ACT8600" and "MIPS: DTS: CI20: fix interrupt

[PATCH v2 07/12] MIPS: DTS: CI20: give eth0_power a defined voltage.

2020-02-17 Thread H. Nikolaus Schaller
This is a 3.3V power switch (DVNET3.3V ). Signed-off-by: H. Nikolaus Schaller --- arch/mips/boot/dts/ingenic/ci20.dts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/mips/boot/dts/ingenic/ci20.dts b/arch/mips/boot/dts/ingenic/ci20.dts index e02a19db7ef1..e1364f941c7d 100644 --- a/arc

[PATCH] drm/sun4i: tcon: Support LVDS on the A33

2020-02-17 Thread Maxime Ripard
The A33 TCON supports LVDS, so we can toggle the support switch. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/sun4i/sun4i_tcon.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/sun4i/sun4i_tcon.c b/drivers/gpu/drm/sun4i/sun4i_tcon.c index fdf143042f83..14026b4fa7c7 10064

[PATCH v2 04/12] MIPS: CI20: defconfig: compile leds-gpio driver into the kernel and configure for LED triggers

2020-02-17 Thread H. Nikolaus Schaller
DTS has been augmented to add some gpio-leds. We need the leds-gpio driver and enable the triggers. Signed-off-by: H. Nikolaus Schaller --- arch/mips/configs/ci20_defconfig | 13 + 1 file changed, 13 insertions(+) diff --git a/arch/mips/configs/ci20_defconfig b/arch/mips/configs/ci2

Re: [PATCH v2 03/12] MIPS: CI20: defconfig: configure for supporting modules

2020-02-17 Thread H. Nikolaus Schaller
Hi Paul, > Am 14.02.2020 um 20:10 schrieb Paul Cercueil : > > Hi Nikolaus, > > Patches 03-12 only touch the same two files - ci20.dts and ci20_defconfig. > > Unless someone strongly disagrees, I'd suggest to squash all patches that > touch each file together (except the ones with a Fixes tag),

Re: [PATCH resend 0/2] dts: keystone-k2g-evm: Display support

2020-02-17 Thread santosh . shilimkar
On 2/14/20 1:22 AM, Jyri Sarha wrote: Resend because the earlier recipient list was wrong. Now that drm/tidss is queued for mainline, lets add display support for k2g-evm. There is no hurry since tidss is out only in v5.7, but it should not harm to have the dts changes in place before that. Jyr

Re: [PATCH 1/2] dt-bindings: display: sun4i-tcon: Add LVDS Dual Link property

2020-02-17 Thread Maxime Ripard
Hi Laurent, On Fri, Feb 14, 2020 at 03:10:25PM +0200, Laurent Pinchart wrote: > Hi Maxime, > > Thank you for the patch. > > On Fri, Feb 14, 2020 at 01:32:43PM +0100, Maxime Ripard wrote: > > SoCs that have multiple TCONs can use the two set of pins on the first TCON > > to drive a dual-link displa

[PATCH v4] drm/i915: Init lspcon after HPD in intel_dp_detect()

2020-02-17 Thread Kai-Heng Feng
On HP 800 G4 DM, if HDMI cable isn't plugged before boot, the HDMI port becomes useless and never responds to cable hotplugging: [3.031904] [drm:lspcon_init [i915]] *ERROR* Failed to probe lspcon [3.031945] [drm:intel_ddi_init [i915]] *ERROR* LSPCON init failed on port D Seems like the lsp

Re: [PATCH 4/4] drm/sun4i: dsi: Remove incorrect use of runtime PM

2020-02-17 Thread Maxime Ripard
On Tue, Feb 11, 2020 at 01:28:58AM -0600, Samuel Holland wrote: > The driver currently uses runtime PM to perform some of the module > initialization and cleanup. This has three problems: > > 1) There is no Kconfig dependency on CONFIG_PM, so if runtime PM is >disabled, the driver will not work

[PATCH v2 0/2] Dual licence some files in GPL-2.0 and MIT

2020-02-17 Thread Emmanuel Vadot
Hello all, We had a discussion a while back with Noralf where he said that he wouldn't mind dual licence his work under GPL-2 and MIT. Those files are a problem with BSDs as we cannot include them. For drm_client.c the main contributors are Noralf Trønnes and Thomas Zimmermann, the other commits a

Re: [PATCH 4/4] drm/sun4i: dsi: Remove incorrect use of runtime PM

2020-02-17 Thread Samuel Holland
Maxime, First, sorry for the tone in my previous message. I wrote it too hastily. > On 2/11/20 2:26 AM, Maxime Ripard wrote: >> On Tue, Feb 11, 2020 at 01:28:58AM -0600, Samuel Holland wrote: >>> 3) The driver relies on being suspended when sun6i_dsi_encoder_enable() >>>is called. The resume

Re: [PATCH v2 03/12] MIPS: CI20: defconfig: configure for supporting modules

2020-02-17 Thread Paul Cercueil
Hi Nikolaus, Patches 03-12 only touch the same two files - ci20.dts and ci20_defconfig. Unless someone strongly disagrees, I'd suggest to squash all patches that touch each file together (except the ones with a Fixes tag), I don't think we really need that much granularity here. -Paul Le

[PATCH v2 06/12] MIPS: CI20: defconfig: configure CONFIG_REGULATOR_ACT8865 for PMU

2020-02-17 Thread H. Nikolaus Schaller
The PMU on the CI20 board is an ACT8600 using the ACT8865 driver. Since it is not compiled, the PMU and the CI20 board is running in power-on reset state of the PMU. Signed-off-by: H. Nikolaus Schaller --- arch/mips/configs/ci20_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/

Re: [PATCH v2 0/2] Dual licence some files in GPL-2.0 and MIT

2020-02-17 Thread Maxime Ripard
On Sat, Feb 15, 2020 at 07:09:09PM +0100, Emmanuel Vadot wrote: > Hello all, > > We had a discussion a while back with Noralf where he said that he wouldn't > mind dual licence his work under GPL-2 and MIT. > Those files are a problem with BSDs as we cannot include them. > For drm_client.c the main

[PATCH v2 02/12] MIPS: DTS: jz4780: add #includes for irq.h and gpio.h

2020-02-17 Thread H. Nikolaus Schaller
The constants from irq.h and gpio.h can be used in the jz4780.dtsi and derived DTS like ci20.dts. Signed-off-by: H. Nikolaus Schaller --- arch/mips/boot/dts/ingenic/jz4780.dtsi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/mips/boot/dts/ingenic/jz4780.dtsi b/arch/mips/boot/dts/inge

Re: [PATCH] drm/i915: Cast remain to unsigned long in eb_relocate_vma

2020-02-17 Thread Nathan Chancellor
On Fri, Feb 14, 2020 at 08:32:19AM +, Chris Wilson wrote: > Quoting Jani Nikula (2020-02-14 06:36:15) > > On Thu, 13 Feb 2020, Nathan Chancellor wrote: > > > A recent commit in clang added -Wtautological-compare to -Wall, which is > > > enabled for i915 after -Wtautological-compare is disabled

[PATCH 3/3] gpu/drm: ingenic: Add option to mmap GEM buffers cached

2020-02-17 Thread Paul Cercueil
Ingenic SoCs are most notably used in cheap chinese handheld gaming consoles. There, the games and applications generally render in software directly in the emulated framebuffer using SDL1. Since the emulated framebuffer is mapped as write-combine by default, these applications start to run really

[PATCH v2 01/12] drm: ingenic-drm: add MODULE_DEVICE_TABLE

2020-02-17 Thread H. Nikolaus Schaller
Add MODULE_DEVICE_TABLE so that the driver can load by matching the device tree if compiled as module. Signed-off-by: H. Nikolaus Schaller --- drivers/gpu/drm/ingenic/ingenic-drm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/ingenic/ingenic-drm.c b/drivers/gpu/drm/inge

[PATCH 16/30] drm/vkms: Add missing annotation for vkms_crtc_atomic_begin()

2020-02-17 Thread Jules Irenge
Sparse reports a warning at vkms_crtc_atomic_begin() warning: context imbalance in vkms_crtc_atomic_begin() - wrong count at exit The root cause is the missing annotation at vkms_crtc_atomic_begin() Add the missing __acquires(&vkms_output->lock) annotation Signed-off-by: Jules Irenge -

[PATCH v2 1/2] drm/client: Dual licence the file in GPL-2 and MIT

2020-02-17 Thread Emmanuel Vadot
From: Emmanuel Vadot Contributors for this file are : Chris Wilson Denis Efremov Jani Nikula Maxime Ripard Noralf Trønnes Sam Ravnborg Thomas Zimmermann Signed-off-by: Emmanuel Vadot --- drivers/gpu/drm/drm_client.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dri

Re: [PATCH v2 2/2] ARM: sun7i: dts: Add LVDS panel support on A20

2020-02-17 Thread Andrey Lebedev
On Fri, Feb 14, 2020 at 08:52:18AM +0100, Maxime Ripard wrote: > > > This will create a spurious warning message for TCON1, since we > > > adjusted the driver to tell it supports LVDS, but there's no LVDS > > > reset line, so we need to make it finer grained. > > > > Yes, I can attribute two of the

[PATCH] dma-buf: Fix a typo in Kconfig

2020-02-17 Thread Christophe JAILLET
A 'h' ismissing in' syncronization' Signed-off-by: Christophe JAILLET --- drivers/dma-buf/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma-buf/Kconfig b/drivers/dma-buf/Kconfig index 0613bb7770f5..e7d820ce0724 100644 --- a/drivers/dma-buf/Kconfig +++ b/driv

Re: [PATCH v4 02/11] drm/bridge: dw-hdmi: add max bpc connector property

2020-02-17 Thread Jernej Škrabec
Hi! Dne četrtek, 06. februar 2020 ob 20:18:25 CET je Neil Armstrong napisal(a): > From: Jonas Karlman > > Add the max_bpc property to the dw-hdmi connector to prepare support > for 10, 12 & 16bit output support. > > Signed-off-by: Jonas Karlman > Signed-off-by: Neil Armstrong > --- > drivers

[PATCH v2 09/12] MIPS: CI20: defconfig: compile gpio-ir driver

2020-02-17 Thread H. Nikolaus Schaller
The CI20 board has a gpio based IR receiver. Signed-off-by: H. Nikolaus Schaller --- arch/mips/configs/ci20_defconfig | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/mips/configs/ci20_defconfig b/arch/mips/configs/ci20_defconfig index 74e5775b8a05..0458ea4d54e8 100644 --- a/arch/mi

[PATCH 0/4] drm/sun4i: Support clock and data polarities on LVDS output

2020-02-17 Thread Maxime Ripard
Hi, The Allwinner LVDS encoder allows to change the polarity of clocks and data lanes, so let's add the needed bus flags to DRM, panel-lvds and our encoder driver. Let me know what you think, Maxime Maxime Ripard (4): drm/connector: Add data polarity flags dt-bindings: panel: lvds: Add prope

Re: [PATCH v2 0/2] Dual licence some files in GPL-2.0 and MIT

2020-02-17 Thread Thomas Zimmermann
Hi Am 15.02.20 um 19:09 schrieb Emmanuel Vadot: > Hello all, > > We had a discussion a while back with Noralf where he said that he wouldn't > mind dual licence his work under GPL-2 and MIT. > Those files are a problem with BSDs as we cannot include them. > For drm_client.c the main contributors

[PATCH v1 3/3] drm/mediatek: move gce event property to mutex device node

2020-02-17 Thread Bibby Hsieh
According mtk hardware design, stream_done0 and stream_done1 are generated by mutex, so we move gce event property to mutex device mode. Signed-off-by: Bibby Hsieh Reviewed-by: CK Hu --- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/

[PATCH v1 1/3] arm64: dts: mt8183: Add gce setting in display node

2020-02-17 Thread Bibby Hsieh
In order to use GCE function, we need add some information into display node (mboxes, mediatek,gce-client-reg, mediatek,gce-events). Signed-off-by: Bibby Hsieh Signed-off-by: Yongqiang Niu --- This patch depends on ptach: [RESEND,v6,02/17] arm64: dts: add display nodes for mt8183 https://patchw

[PATCH v1 2/3] drm/mediatek: make sure previous message done or be aborted before send

2020-02-17 Thread Bibby Hsieh
Mediatek CMDQ driver removed atomic parameter and implementation related to atomic. DRM driver need to make sure previous message done or be aborted before we send next message. If previous message is still waiting for event, it means the setting hasn't been updated into display hardware register,

Re: [PATCH] Correct typos in comments

2020-02-17 Thread Daniel Vetter
On Fri, Feb 14, 2020 at 11:29:38AM +, Maya Rashish wrote: > Signed-off-by: Maya Rashish > Co-authored-by: Thomas Klausner > --- > drivers/gpu/drm/amd/include/atombios.h | 20 ++-- > drivers/gpu/drm/amd/include/atomfirmware.h | 4 ++-- > drivers/gpu/drm/radeon/atombios.h

Re: [PATCH] Correct typos in comments

2020-02-17 Thread Daniel Vetter
On Fri, Feb 14, 2020 at 11:29:38AM +, Maya Rashish wrote: > Signed-off-by: Maya Rashish > Co-authored-by: Thomas Klausner Also, we need a s-o-b from every co-author, because of the dco: https://developercertificate.org/ Thanks, Daniel > --- > drivers/gpu/drm/amd/include/atombios.h |

Re: [PATCH v2 2/2] drm/format_helper: Dual licence the file in GPL 2 and MIT

2020-02-17 Thread Daniel Vetter
On Sat, Feb 15, 2020 at 07:09:11PM +0100, Emmanuel Vadot wrote: > From: Emmanuel Vadot > > Contributors for this file are : > Gerd Hoffmann > Maxime Ripard > Noralf Trønnes > > Signed-off-by: Emmanuel Vadot Patch applied since we have all the acks we need. I think for the first one we still

Re: [PATCH] dma-buf: Fix a typo in Kconfig

2020-02-17 Thread Daniel Vetter
On Sun, Feb 16, 2020 at 12:47:08PM +0100, Christophe JAILLET wrote: > A 'h' ismissing in' syncronization' > > Signed-off-by: Christophe JAILLET Applied, thanks for your patch. -Daniel > --- > drivers/dma-buf/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/driv

Re: [PATCH 2/3] gpu/drm: ingenic: Switch emulated fbdev to 16bpp

2020-02-17 Thread Daniel Vetter
On Sun, Feb 16, 2020 at 12:58:10PM -0300, Paul Cercueil wrote: > The fbdev emulation is only ever used on Ingenic SoCs to run old SDL1 > based games at 16bpp (rgb565). Recent applications generally talk to > DRM directly, and can request their favourite pixel format; so we can > make everybody happ

Re: [RFC 8/9] drm/client: Add drm_client_init_from_id() and drm_client_modeset_set()

2020-02-17 Thread Daniel Vetter
On Sun, Feb 16, 2020 at 06:21:16PM +0100, Noralf Trønnes wrote: > drm_client_init_from_id() provides a way for clients to add a client based > on the minor. drm_client_modeset_set() provides a way to set the modeset > for clients that handles connectors and display mode on their own. > > Signed-of

Re: [RFC 0/9] Regmap over USB for Multifunction USB Device (gpio, display, ...)

2020-02-17 Thread Daniel Vetter
On Sun, Feb 16, 2020 at 06:21:08PM +0100, Noralf Trønnes wrote: > Hi, > > A while back I had the idea to turn a Raspberry Pi Zero into a $5 > USB to HDMI/SDTV/DSI/DPI display adapter. > > Thinking about how to represent the display to the driver I realised > that hardware use registers as API. An

Re: [PATCH v6 02/51] drm/connector: Add helper to get a connector type name

2020-02-17 Thread Daniel Vetter
On Sun, Feb 16, 2020 at 11:02:19PM +0200, Laurent Pinchart wrote: > drm_connector.c contains a map of connector types (DRM_MODE_CONNECTOR_*) > to name strings, but doesn't expose it. This leads to drivers having to > store a similar map. Maybe also a todo if there's many of these? -Daniel > > Ad

[PATCH] drm/edid: temporary workaround to pass HDMI 2.0 compliance HF1-13

2020-02-17 Thread Lee Shawn C
Test case HF1-13 for HDMI 2.0 compliance would ask DUT to downgrade output resolution to 720x480 or 720x576 (lower than 3.4Gbps). And check scrambling feature was disabled as well. But QD980 report it can support low rate scrambling. The vendor specific data block byte[6] was 0x88. If driver enabl

Re: [PATCH v6 04/51] drm/bridge: Add connector-related bridge operations and data

2020-02-17 Thread Daniel Vetter
On Sun, Feb 16, 2020 at 11:02:21PM +0200, Laurent Pinchart wrote: > To support implementation of DRM connectors on top of DRM bridges > instead of by bridges, the drm_bridge needs to expose new operations and > data: > > - Output detection, hot-plug notification, mode retrieval and EDID > retrie

Re: [RFC 0/9] Regmap over USB for Multifunction USB Device (gpio, display, ...)

2020-02-17 Thread Neil Armstrong
Hi, On 16/02/2020 18:21, Noralf Trønnes wrote: > Hi, > > A while back I had the idea to turn a Raspberry Pi Zero into a $5 > USB to HDMI/SDTV/DSI/DPI display adapter. > > Thinking about how to represent the display to the driver I realised > that hardware use registers as API. And Linux does hav

Re: [PATCHv4,04/36] drm/gem-fb-helper: Add special version of drm_gem_fb_size_check

2020-02-17 Thread Andrzej Pietrasiewicz
Hi James, Thank you for the review. Did you intentionally review patches from the v4 series or you simply didn't notice the v5? There are some differences, the most notable one is using proper way of subclassing a drm_framebuffer. The v5 series was sent on 17th December 2019. Andrzej W dniu 17

Re: [PATCHv4,05/36] drm/gem-fb-helper: Add generic afbc size checks

2020-02-17 Thread james qian wang (Arm Technology China)
Hi Andrzej: On Fri, Dec 13, 2019 at 04:58:36PM +0100, Andrzej Pietrasiewicz wrote: > Extend the size-checking special function to handle afbc. > > Signed-off-by: Andrzej Pietrasiewicz > --- > drivers/gpu/drm/drm_fourcc.c | 10 +++- > drivers/gpu/drm/drm_framebuffer.c

Re: [PATCH 1/7] drm/amdgpu: move ttm bo->offset to amdgpu_bo

2020-02-17 Thread Christian König
Am 17.02.20 um 11:18 schrieb Nirmoy Das: GPU address should belong to driver not in memory management. This patch moves ttm bo.offset and gpu_offset calculation to amdgpu driver. Signed-off-by: Nirmoy Das Acked-by: Huang Rui Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/am

Re: [PATCH 3/7] drm/vmwgfx: don't use ttm bo->offset

2020-02-17 Thread Christian König
Am 17.02.20 um 11:18 schrieb Nirmoy Das: Calculate GPU offset within vmwgfx driver itself without depending on bo->offset Signed-off-by: Nirmoy Das --- drivers/gpu/drm/vmwgfx/vmwgfx_bo.c | 4 ++-- drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c| 2 +- drivers/gpu/drm/vmwgfx/vmwgfx_fifo.

Re: [PATCH 3/7] drm/vmwgfx: don't use ttm bo->offset

2020-02-17 Thread Nirmoy
On 2/17/20 12:09 PM, Christian König wrote: Am 17.02.20 um 11:18 schrieb Nirmoy Das: Calculate GPU offset within vmwgfx driver itself without depending on bo->offset Signed-off-by: Nirmoy Das ---   drivers/gpu/drm/vmwgfx/vmwgfx_bo.c | 4 ++--   drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c  

Re: [PATCHv4,04/36] drm/gem-fb-helper: Add special version of drm_gem_fb_size_check

2020-02-17 Thread james qian wang (Arm Technology China)
On Mon, Feb 17, 2020 at 11:55:50AM +0100, Andrzej Pietrasiewicz wrote: > Hi James, > > Thank you for the review. > > Did you intentionally review patches from the v4 series or you simply > didn't notice the v5? There are some differences, the most notable one > is using proper way of subclassing

Re: [RFC 1/9] regmap: Add USB support

2020-02-17 Thread Mark Brown
On Sun, Feb 16, 2020 at 06:21:09PM +0100, Noralf Trønnes wrote: > Add support for regmap over USB for use with the Multifunction USB Device. > Two endpoints IN/OUT are used. Up to 255 regmaps are supported on one USB > interface. The register index width is always 32-bit, but the register > value

Re: [PATCH 4/7] drm/nouveau: don't use ttm bo->offset

2020-02-17 Thread Christian König
Am 17.02.20 um 11:18 schrieb Nirmoy Das: Store ttm bo->offset in struct nouveau_bo instead. Signed-off-by: Nirmoy Das Acked-by: Christian König for this one and patch #5 and #6 in this series. --- drivers/gpu/drm/nouveau/dispnv04/crtc.c | 6 +++--- drivers/gpu/drm/nouveau/dispnv0

Re: [RFC 6/9] regmap: Speed up _regmap_raw_write_impl() for large buffers

2020-02-17 Thread Mark Brown
On Sun, Feb 16, 2020 at 06:21:14PM +0100, Noralf Trønnes wrote: > When writing a 3MB buffer the unwritable check in _regmap_raw_write_impl() > adds a ~20ms overhead on a Raspberry Pi 4. > Amend this by avoiding the check if it's not necessary. This is a generic optimization, why is it mixed in wi

Re: [PATCH 5/7] drm/qxl: don't use ttm bo->offset

2020-02-17 Thread Gerd Hoffmann
On Mon, Feb 17, 2020 at 11:18:39AM +0100, Nirmoy Das wrote: > This patch also removes slot->gpu_offset which is not required as > VRAM and PRIV slot are in separate PCI bar Well, gpu_offset is still in struct qxlslot ... Other than that the patch looks fine, and this is minor enough that I'll hap

Re: [PATCH 6/7] drm/bochs: don't use ttm bo->offset

2020-02-17 Thread Gerd Hoffmann
On Mon, Feb 17, 2020 at 11:18:40AM +0100, Nirmoy Das wrote: > Calculate GPU offset within bochs driver itself without depending on > bo->offset > > Signed-off-by: Nirmoy Das > --- > drivers/gpu/drm/bochs/bochs_kms.c | 3 ++- > drivers/gpu/drm/drm_gem_vram_helper.c | 2 +- > 2 files changed,

Re: [PATCH 6/7] drm/bochs: don't use ttm bo->offset

2020-02-17 Thread Nirmoy
On 2/17/20 1:41 PM, Gerd Hoffmann wrote: On Mon, Feb 17, 2020 at 11:18:40AM +0100, Nirmoy Das wrote: Calculate GPU offset within bochs driver itself without depending on bo->offset Signed-off-by: Nirmoy Das --- drivers/gpu/drm/bochs/bochs_kms.c | 3 ++- drivers/gpu/drm/drm_gem_vram_he

[Bug 206475] amdgpu under load drop signal to monitor until hard reset

2020-02-17 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=206475 Marco (rodomar...@protonmail.com) changed: What|Removed |Added Status|RESOLVED|REOPENED Reso

Re: [RFC 0/9] Regmap over USB for Multifunction USB Device (gpio, display, ...)

2020-02-17 Thread Noralf Trønnes
Den 17.02.2020 11.32, skrev Neil Armstrong: > Hi, > > On 16/02/2020 18:21, Noralf Trønnes wrote: >> Hi, >> >> A while back I had the idea to turn a Raspberry Pi Zero into a $5 >> USB to HDMI/SDTV/DSI/DPI display adapter. >> >> Thinking about how to represent the display to the driver I realised

Re: [PATCH] drm/edid: temporary workaround to pass HDMI 2.0 compliance HF1-13

2020-02-17 Thread Ville Syrjälä
On Tue, Feb 18, 2020 at 01:41:39AM +0800, Lee Shawn C wrote: > Test case HF1-13 for HDMI 2.0 compliance would ask DUT to downgrade > output resolution to 720x480 or 720x576 (lower than 3.4Gbps). > And check scrambling feature was disabled as well. > > But QD980 report it can support low rate scram

Re: [PATCH 7/8] drm/bochs: use drm_gem_vram_offset to get bo offset

2020-02-17 Thread Christian König
Am 17.02.20 um 16:04 schrieb Nirmoy Das: Switch over to GEM VRAM's implementation to retrieve bo->offset Signed-off-by: Nirmoy Das Acked-by: Christian König --- drivers/gpu/drm/bochs/bochs_kms.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bochs/bo

RFC: Unpinned DMA-buf handling

2020-02-17 Thread Christian König
Hi everyone, hopefully the last iteration of those patches. For now I've addressed the issue of unmapping imported BOs from the amdgpu page tables immediately by locking the page tables in place. For HMM handling we are getting the ability to invalidate BOs without locking the VM anyway, so th

[PATCH 1/5] dma-buf: add dynamic DMA-buf handling v14

2020-02-17 Thread Christian König
On the exporter side we add optional explicit pinning callbacks. Which are called when the importer doesn't implement dynamic handling, move notification or need the DMA-buf locked in place for its use case. On the importer side we add an optional move_notify callback. This callback is used by the

[PATCH 5/5] drm/amdgpu: implement amdgpu_gem_prime_move_notify v2

2020-02-17 Thread Christian König
Implement the importer side of unpinned DMA-buf handling. v2: update page tables immediately Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c | 66 - drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 6 ++ 2 files changed, 71 insertions(+), 1 delet

[PATCH 2/5] drm/ttm: remove the backing store if no placement is given

2020-02-17 Thread Christian König
Pipeline removal of the BOs backing store when no placement is given during validation. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c index 229205e499db

[PATCH 3/5] drm/amdgpu: use allowed_domains for exported DMA-bufs

2020-02-17 Thread Christian König
Avoid that we ping/pong the buffers when we stop to pin DMA-buf exports by using the allowed domains for exported buffers. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/

[PATCH 4/5] drm/amdgpu: add amdgpu_dma_buf_pin/unpin v2

2020-02-17 Thread Christian König
This implements the exporter side of unpinned DMA-buf handling. v2: fix minor coding style issues Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c | 53 ++--- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 5 ++ 2 files changed, 51 insertions(+), 7

Re: [PATCH 1/5] dma-buf: add dynamic DMA-buf handling v14

2020-02-17 Thread Christian König
Please ignore this one, I've send out the wrong version without Daniels latest comment nit picks fixed. The interesting one in this series is the last patch. Regards, Christian. Am 17.02.20 um 16:45 schrieb Christian König: On the exporter side we add optional explicit pinning callbacks. Whic

Re: [PATCH 4/8] drm/nouveau: don't use ttm bo->offset

2020-02-17 Thread Alex Deucher
On Mon, Feb 17, 2020 at 10:02 AM Nirmoy Das wrote: > > Store ttm bo->offset in struct nouveau_bo instead. > > Signed-off-by: Nirmoy Das > Christian König Missing Acked or Reviewed prefix for Christian. Alex > --- > drivers/gpu/drm/nouveau/dispnv04/crtc.c | 6 +++--- > drivers/gpu/drm/no

Re: [PATCH 4/8] drm/nouveau: don't use ttm bo->offset

2020-02-17 Thread Nirmoy
On 2/17/20 4:57 PM, Alex Deucher wrote: On Mon, Feb 17, 2020 at 10:02 AM Nirmoy Das wrote: Store ttm bo->offset in struct nouveau_bo instead. Signed-off-by: Nirmoy Das Christian König Missing Acked or Reviewed prefix for Christian. :facepalm: Thanks Alex. Nirmoy Alex --- drivers/

[Bug 206575] New: [amdgpu] [drm] No video signal on resume from suspend, R9 380

2020-02-17 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=206575 Bug ID: 206575 Summary: [amdgpu] [drm] No video signal on resume from suspend, R9 380 Product: Drivers Version: 2.5 Kernel Version: 5.5 Hardware: x86-64

  1   2   >