Re: [PATCH v4 0/7] Add dts for mt8183 GPU (and misc panfrost patches)

2020-02-07 Thread Tomeu Vizoso
On 2/7/20 8:42 AM, Nicolas Boichat wrote: On Fri, Feb 7, 2020 at 2:18 PM Tomeu Vizoso wrote: On 2/7/20 6:26 AM, Nicolas Boichat wrote: Hi! Follow-up on the v3: https://patchwork.kernel.org/cover/11331343/. The main purpose of this series is to upstream the dts change and the binding documen

Re: [PATCH 2/2] drm/virtio: remove the global disable_notify state

2020-02-07 Thread Gerd Hoffmann
On Thu, Feb 06, 2020 at 11:22:14AM -0800, Chia-I Wu wrote: > The global disable_notify state does not scale well when we start > using it in more places and when there are multiple threads. Use > command-level bools to control whether to notify or not. Hmm, I don't like passing around the bool ev

Re: [PATCH] drm/mediatek: Find the cursor plane instead of hard coding it

2020-02-07 Thread CK Hu
Hi, Evan: On Fri, 2020-02-07 at 15:23 +1100, Evan Benn wrote: > The cursor and primary planes were hard coded. > Now search for them for passing to drm_crtc_init_with_planes > Reviewed-by: CK Hu > Signed-off-by: Evan Benn > --- > > drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 18 --

[PATCH 2/6] drm: Add drm_simple_encoder_{init,create}()

2020-02-07 Thread Thomas Zimmermann
The simple-encoder helpers initialize an encoder with an empty implementation. This covers the requirements of most of the existing DRM drivers. A call to drm_simple_encoder_create() allocates and initializes an encoder instance, a call to drm_simple_encoder_init() initializes a pre-allocated insta

[PATCH 6/6] drm/simple-pipe: Use simple encoder

2020-02-07 Thread Thomas Zimmermann
The simple-pipe helpers use an empty implementation for the encoder. Replace the code with the generic simple encoder. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_simple_kms_helper.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/drm_simp

[PATCH 0/6] drm: Provide a simple encoder

2020-02-07 Thread Thomas Zimmermann
Many DRM drivers implement an encoder with an empty implementation. This patchset adds drm_simple_encoder_init() and drm_simple_encoder_create(), which can be used by drivers instead. Except for the destroy callback, the simple encoder's implementation is empty. The patchset also converts 4 encode

[PATCH 4/6] drm/mgag200: Use simple encoder

2020-02-07 Thread Thomas Zimmermann
The mgag200 driver uses an empty implementation for its encoder. Replace the code with the generic simple encoder. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/mgag200/mgag200_drv.h | 7 --- drivers/gpu/drm/mgag200/mgag200_mode.c | 60 +- 2 files changed, 2 inse

[PATCH 3/6] drm/ast: Use simple encoder

2020-02-07 Thread Thomas Zimmermann
The ast driver uses an empty implementation for its encoder. Replace the code with the generic simple encoder. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_drv.h | 6 +- drivers/gpu/drm/ast/ast_mode.c | 25 - 2 files changed, 9 insertions(+), 22 dele

[PATCH 5/6] drm/qxl: Use simple encoder

2020-02-07 Thread Thomas Zimmermann
The qxl driver uses an empty implementation for its encoder. Replace the code with the generic simple encoder. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/qxl/qxl_display.c | 17 ++--- 1 file changed, 2 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/qxl/qxl_dis

[PATCH 1/6] drm: Move initialization of encoder into an internal function

2020-02-07 Thread Thomas Zimmermann
Moving encoder init code into an internal function, so it can be reused. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_encoder.c | 78 +++ 1 file changed, 52 insertions(+), 26 deletions(-) diff --git a/drivers/gpu/drm/drm_encoder.c b/drivers/gpu/drm/dr

[PULL] drm-misc-fixes

2020-02-07 Thread Maarten Lankhorst
drm-misc-fixes-2020-02-07: Fixes for v5.6: - Revert allow_fb_modifiers in sun4i, as it causes a regression for DE2 and DE3. - Fix null pointer deref in drm_dp_mst_process_up_req(). The following changes since commit bdefca2d8dc0f80bbe49e08bf52a717146490706: drm/panfrost: Add the panfrost_gem_map

Re: [PATCH v2 1/3] drm/mediatek: exit earlier if failed to register audio driver

2020-02-07 Thread CK Hu
Hi, Tzung-Bi: On Thu, 2020-02-06 at 11:17 +0800, Tzung-Bi Shih wrote: > Exits earlier if register_audio_driver() returns errors. > Acked-by: CK Hu > Signed-off-by: Tzung-Bi Shih > --- > drivers/gpu/drm/mediatek/mtk_hdmi.c | 11 --- > 1 file changed, 8 insertions(+), 3 deletions(-) >

Re: [PATCH v4 3/3] dt-bindings: panel: Convert orisetech, otm8009a to json-schema

2020-02-07 Thread Philippe CORNU
Hi Benjamin, On 2/6/20 2:33 PM, Benjamin Gaignard wrote: > Convert orisetech,otm8009a to json-schema. > > Signed-off-by: Benjamin Gaignard > --- > .../bindings/display/panel/orisetech,otm8009a.txt | 23 -- > .../bindings/display/panel/orisetech,otm8009a.yaml | 53 > +

Re: [PATCH v4 2/3] dt-bindings: panel: Convert raydium,rm68200 to json-schema

2020-02-07 Thread Philippe CORNU
Hi Benjamin, On 2/6/20 2:33 PM, Benjamin Gaignard wrote: > Convert raydium,rm68200 to json-schema. > > Signed-off-by: Benjamin Gaignard > --- > .../bindings/display/panel/raydium,rm68200.txt | 25 -- > .../bindings/display/panel/raydium,rm68200.yaml| 56 >

Re: [PATCH v4 1/3] dt-bindings: one file of all simple DSI panels

2020-02-07 Thread Philippe CORNU
Hi Benjamin, and many thanks for this serie. Regarding this patch: Reviewed-by: Philippe Cornu Philippe :-) On 2/6/20 2:33 PM, Benjamin Gaignard wrote: > From: Sam Ravnborg > > To complement panel-simple.yaml, create panel-simple-dsi.yaml. > panel-simple-dsi-yaml are for all simple DSP panels

[PULL] drm-misc-next-fixes

2020-02-07 Thread Maarten Lankhorst
drm-misc-next-fixes-2020-02-07: drm-misc-next fixes for v5.6: - Fix build error in drm/edid. - Plug close-after-free race in vgem_gem_create. - Handle CONFIG_DMA_API_DEBUG_SG better in drm/msm. The following changes since commit d7ca2d19c751b6715e9cb899a6b94f47b3499d02: Merge tag 'drm-msm-next-2

Re: [PATCH 2/6] drm: Add drm_simple_encoder_{init,create}()

2020-02-07 Thread Gerd Hoffmann
> +static const struct drm_encoder_funcs drm_simple_encoder_funcs_cleanup = { > + .destroy = drm_encoder_cleanup, > +}; > + > +/** > + * drm_simple_encoder_init - Init a preallocated encoder > + * @dev: drm device > + * @funcs: callbacks for this encoder > + * @encoder_type: user visible type o

Re: [PATCH 2/6] drm: Add drm_simple_encoder_{init,create}()

2020-02-07 Thread Thomas Zimmermann
Hi Gerd Am 07.02.20 um 11:33 schrieb Gerd Hoffmann: >> +static const struct drm_encoder_funcs drm_simple_encoder_funcs_cleanup = { >> +.destroy = drm_encoder_cleanup, >> +}; >> + >> +/** >> + * drm_simple_encoder_init - Init a preallocated encoder >> + * @dev: drm device >> + * @funcs: callbac

Re: [PATCH v4 03/11] drm/bridge: dw-hdmi: Plug atomic state hooks to the default implementation

2020-02-07 Thread Boris Brezillon
On Thu, 6 Feb 2020 20:18:26 +0100 Neil Armstrong wrote: > Signed-off-by: Neil Armstrong Reviewed-by: Boris Brezillon > --- > drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > b/drivers/gpu/drm/

Re: [PATCH v4 04/11] drm/bridge: synopsys: dw-hdmi: add bus format negociation

2020-02-07 Thread Boris Brezillon
On Thu, 6 Feb 2020 20:18:27 +0100 Neil Armstrong wrote: > Add the atomic_get_output_bus_fmts, atomic_get_input_bus_fmts to negociate ^ hooks? > the possible output and input formats for the current mode and monitor, > and use the

Re: [PATCH 1/4] Revert "drm/i915: Don't use VBT for detecting DPCD backlight controls"

2020-02-07 Thread Jani Nikula
On Tue, 04 Feb 2020, Lyude Paul wrote: > This reverts commit d2a4bb6f8bc8cf2d788adf7e59b5b52fe3ac. > > So, turns out that this ended up just breaking things. While many > laptops incorrectly advertise themselves as supporting PWM backlight > controls, they actually will only work with DPCD bac

Re: [PATCHv5 00/34] Add AFBC support for Rockchip

2020-02-07 Thread Andrzej Pietrasiewicz
Hi All again, @malidp and komeda folks: I kindly ask you to have your say. If there is no interest from you (which is ok with me) I will resend the series dropping the komeda and malidp part. Andrzej W dniu 30.01.2020 o 10:08, Andrzej Pietrasiewicz pisze: Hi All, A gentle reminder. Please al

[PATCH v2] drm/bochs: downgrade pci_request_region failure from error to warning

2020-02-07 Thread Gerd Hoffmann
Shutdown of firmware framebuffer has a bunch of problems. Because of this the framebuffer region might still be reserved even after drm_fb_helper_remove_conflicting_pci_framebuffers() returned. Don't consider pci_request_region() failure for the framebuffer region as fatal error to workaround thi

Re: [PATCH v2] drm/bochs: downgrade pci_request_region failure from error to warning

2020-02-07 Thread Thomas Zimmermann
Hi Am 07.02.20 um 12:57 schrieb Gerd Hoffmann: > Shutdown of firmware framebuffer has a bunch of problems. Because > of this the framebuffer region might still be reserved even after > drm_fb_helper_remove_conflicting_pci_framebuffers() returned. Out of curiosity: what's going wrong here? Best

[PATCH] drm/bochs: add drm_driver.release callback.

2020-02-07 Thread Gerd Hoffmann
From: Gurchetan Singh Move bochs_unload call from bochs_remove() to the new bochs_release() callback. Also call drm_dev_unregister() first in bochs_remove(). Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/bochs/bochs_drv.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff

[PATCH] drm/cirrus: add drm_driver.release callback.

2020-02-07 Thread Gerd Hoffmann
Move final cleanups from cirrus_pci_remove() to the new callback. Add drm_atomic_helper_shutdown() call to cirrus_pci_remove(). Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/cirrus/cirrus.c | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/

[PATCH] drm/virtio: add drm_driver.release callback.

2020-02-07 Thread Gerd Hoffmann
Split virtio_gpu_deinit(), move the drm shutdown and release to virtio_gpu_release(). Also free vbufs in case we can't queue them. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/virtio/virtgpu_drv.h | 1 + drivers/gpu/drm/virtio/virtgpu_drv.c | 4 drivers/gpu/drm/virtio/virtgpu_kms.c | 5

[PATCH] drm/qxl: add drm_driver.release callback.

2020-02-07 Thread Gerd Hoffmann
Move final cleanups to qxl_drm_release() callback. Add drm_atomic_helper_shutdown() call to qxl_pci_remove(). Reorder calls in qxl_device_fini(). Cleaning up gem & ttm might trigger qxl commands, so we should do that before releaseing command rings. Signed-off-by: Gerd Hoffmann --- drivers/gpu

Re: [PATCH 2/6] drm: Add drm_simple_encoder_{init,create}()

2020-02-07 Thread Gerd Hoffmann
> > How about using > > > > #define drm_simple_encoder_init(dev, type, name, ...) \ > > drm_encoder_init(dev, drm_simple_encoder_funcs_cleanup, type, name, > > __VA_ARGS__) > > > > instead ? > I guess you want to save a few lines in the implementation of > drm_simple_encoder_init() (?)

Re: [PATCH v2] drm/bochs: downgrade pci_request_region failure from error to warning

2020-02-07 Thread Gerd Hoffmann
On Fri, Feb 07, 2020 at 01:06:00PM +0100, Thomas Zimmermann wrote: > Hi > > Am 07.02.20 um 12:57 schrieb Gerd Hoffmann: > > Shutdown of firmware framebuffer has a bunch of problems. Because > > of this the framebuffer region might still be reserved even after > > drm_fb_helper_remove_conflicting_

[PATCH] drm/bochs: deinit bugfix

2020-02-07 Thread Gerd Hoffmann
Check whenever mode_config was actually properly initialized before trying to clean it up. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/bochs/bochs_kms.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/bochs/bochs_kms.c b/drivers/gpu/drm/bochs/bochs_kms.c index cc93ff

Re: [PATCH] drm/bochs: add drm_driver.release callback.

2020-02-07 Thread Thomas Zimmermann
Am 07.02.20 um 13:13 schrieb Gerd Hoffmann: > From: Gurchetan Singh > > Move bochs_unload call from bochs_remove() to the new bochs_release() > callback. Also call drm_dev_unregister() first in bochs_remove(). > > Signed-off-by: Gerd Hoffmann Acked-by: Thomas Zimmermann > --- > drivers/g

Re: [PATCH] drm/cirrus: add drm_driver.release callback.

2020-02-07 Thread Thomas Zimmermann
Am 07.02.20 um 13:13 schrieb Gerd Hoffmann: > Move final cleanups from cirrus_pci_remove() to the new callback. > Add drm_atomic_helper_shutdown() call to cirrus_pci_remove(). > > Signed-off-by: Gerd Hoffmann Acked-by: Thomas Zimmermann > --- > drivers/gpu/drm/cirrus/cirrus.c | 17 +

Re: [RFC] drm: rework SET_MASTER and DROP_MASTER perm handling

2020-02-07 Thread Daniel Vetter
On Wed, Feb 05, 2020 at 05:48:39PM +, Emil Velikov wrote: > From: Emil Velikov > > This commit reworks the permission handling of the two ioctls. In > particular it enforced the CAP_SYS_ADMIN check only, if: > - we're issuing the ioctl from process other than the one which opened > the node,

Re: [PATCH v4 04/11] drm/bridge: synopsys: dw-hdmi: add bus format negociation

2020-02-07 Thread Neil Armstrong
On 07/02/2020 12:02, Boris Brezillon wrote: > On Thu, 6 Feb 2020 20:18:27 +0100 > Neil Armstrong wrote: > >> Add the atomic_get_output_bus_fmts, atomic_get_input_bus_fmts to negociate > > ^ hooks? > >> the possible output and input

Re: [PATCH 2/6] drm: Add drm_simple_encoder_{init,create}()

2020-02-07 Thread Daniel Vetter
On Fri, Feb 07, 2020 at 09:41:31AM +0100, Thomas Zimmermann wrote: > The simple-encoder helpers initialize an encoder with an empty > implementation. This covers the requirements of most of the existing > DRM drivers. A call to drm_simple_encoder_create() allocates and > initializes an encoder inst

Re: [PATCH 0/5] disable drm_global_mutex for most drivers, take 2

2020-02-07 Thread Thomas Zimmermann
Hi, On patches 2 to 5: Acked-by: Thomas Zimmermann I'm not overly knowledgeable on DRM locking semantics, but the patches appear to be correct in general. Best regards Thomas Am 04.02.20 um 16:01 schrieb Daniel Vetter: > CI didn't like my test-with tag :-/ > > Test-with: 20200128112549.1721

Re: [PATCH v4 06/11] drm/meson: venc: make drm_display_mode const

2020-02-07 Thread Neil Armstrong
On 06/02/2020 20:18, Neil Armstrong wrote: > Before switching to bridge funcs, make sure drm_display_mode is passed > as const to the venc functions. > > Signed-off-by: Neil Armstrong > --- > drivers/gpu/drm/meson/meson_venc.c | 2 +- > drivers/gpu/drm/meson/meson_venc.h | 2 +- > 2 files change

Re: [PATCH v4 05/11] drm/bridge: synopsys: dw-hdmi: allow ycbcr420 modes for >= 0x200a

2020-02-07 Thread Neil Armstrong
On 06/02/2020 20:18, Neil Armstrong wrote: > Now the DW-HDMI Controller supports the HDMI2.0 modes, enable support > for these modes in the connector if the platform supports them. > We limit these modes to DW-HDMI IP version >= 0x200a which > are designed to support HDMI2.0 display modes. > > Sig

Re: [PATCH] drm/bochs: add drm_driver.release callback.

2020-02-07 Thread Daniel Vetter
On Fri, Feb 07, 2020 at 01:13:12PM +0100, Gerd Hoffmann wrote: > From: Gurchetan Singh > > Move bochs_unload call from bochs_remove() to the new bochs_release() > callback. Also call drm_dev_unregister() first in bochs_remove(). > > Signed-off-by: Gerd Hoffmann > --- > drivers/gpu/drm/bochs/b

Re: [PATCH] drm/qxl: add drm_driver.release callback.

2020-02-07 Thread Daniel Vetter
On Fri, Feb 07, 2020 at 01:14:05PM +0100, Gerd Hoffmann wrote: > Move final cleanups to qxl_drm_release() callback. > Add drm_atomic_helper_shutdown() call to qxl_pci_remove(). > > Reorder calls in qxl_device_fini(). Cleaning up gem & ttm > might trigger qxl commands, so we should do that before

Re: [PATCH] drm/bochs: deinit bugfix

2020-02-07 Thread Daniel Vetter
On Fri, Feb 07, 2020 at 01:43:48PM +0100, Gerd Hoffmann wrote: > Check whenever mode_config was actually properly > initialized before trying to clean it up. > > Signed-off-by: Gerd Hoffmann Reviewed-by: Daniel Vetter Really need to get managed drm cleanup going ... -Daniel > --- > drivers/gp

Re: [PATCH] drm/virtio: add drm_driver.release callback.

2020-02-07 Thread Daniel Vetter
On Fri, Feb 07, 2020 at 01:14:20PM +0100, Gerd Hoffmann wrote: > Split virtio_gpu_deinit(), move the drm shutdown and release to > virtio_gpu_release(). Also free vbufs in case we can't queue them. > > Signed-off-by: Gerd Hoffmann > --- > drivers/gpu/drm/virtio/virtgpu_drv.h | 1 + > drivers/gp

Re: [PATCH] drm/qxl: add drm_driver.release callback.

2020-02-07 Thread Thomas Zimmermann
Hi Am 07.02.20 um 13:14 schrieb Gerd Hoffmann: > Move final cleanups to qxl_drm_release() callback. > Add drm_atomic_helper_shutdown() call to qxl_pci_remove(). > > Reorder calls in qxl_device_fini(). Cleaning up gem & ttm > might trigger qxl commands, so we should do that before > releaseing co

[PATCH v2 3/6] drm/exynos: Use drm_encoder_mask()

2020-02-07 Thread Ville Syrjala
From: Ville Syrjälä Replace the hand rolled encoder bitmask thing with drm_encoder_mask() Cc: Inki Dae Cc: Joonyoung Shim Cc: Seung-Woo Kim Cc: Kyungmin Park Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/exynos/exynos_drm_drv.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)

[PATCH v2 4/6] drm/imx: Remove the bogus possible_clones setup

2020-02-07 Thread Ville Syrjala
From: Ville Syrjälä It's not at all clear what cloning options this driver supports. So let's just clear possible_clones instead of setting it to some bogus value. Cc: Philipp Zabel Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/imx/imx-drm-core.c | 2 +- 1 file changed, 1 insertion(+), 1 d

[PATCH v2 6/6] drm: Validate encoder->possible_crtcs

2020-02-07 Thread Ville Syrjala
From: Ville Syrjälä WARN if the encoder possible_crtcs is effectively empty or contains bits for non-existing crtcs. TODO: Or should we perhapst just filter out any bit for a non-exisiting crtc? Cc: Thomas Zimmermann Cc: Daniel Vetter Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/drm_enc

[PATCH v2 2/6] drm/gma500: Sanitize possible_clones

2020-02-07 Thread Ville Syrjala
From: Ville Syrjälä I doubt the DP+DP and SDVO+SDVO cloning works for this driver. i915 at least doesn't do those. Truthfully there could be some very specific circumstances where some of them would do doable, but genereally it's too much pain to deal with so we've chose not to bother. Let's use

[PATCH v2 0/6] drm: Try to fix encoder possible_clones/crtc

2020-02-07 Thread Ville Syrjala
From: Ville Syrjälä Remainder of my possible_clones/crtcs cleanup. All the i915 bits and a few other driver bits got merged already. Ville Syrjälä (6): drm: Include the encoder itself in possible_clones drm/gma500: Sanitize possible_clones drm/exynos: Use drm_encoder_mask() drm/imx: Remo

[PATCH v2 5/6] drm: Validate encoder->possible_clones

2020-02-07 Thread Ville Syrjala
From: Ville Syrjälä Many drivers are populating encoder->possible_clones wrong. Let's persuade them to get it right by adding some loud WARNs. We'll cross check the bits between any two encoders. So either both encoders can clone with the other, or neither can. We'll also complain about effecti

[PATCH v2 1/6] drm: Include the encoder itself in possible_clones

2020-02-07 Thread Ville Syrjala
From: Ville Syrjälä The docs say possible_clones should always include the encoder itself. Since most drivers don't want to deal with the complexities of cloning let's allow them to set possible_clones=0 and instead we'll fix that up in the core. We can't put this special case into drm_encoder_i

Re: [PATCH 2/6] drm: Add drm_simple_encoder_{init,create}()

2020-02-07 Thread Ville Syrjälä
On Fri, Feb 07, 2020 at 02:37:20PM +0100, Daniel Vetter wrote: > On Fri, Feb 07, 2020 at 09:41:31AM +0100, Thomas Zimmermann wrote: > > The simple-encoder helpers initialize an encoder with an empty > > implementation. This covers the requirements of most of the existing > > DRM drivers. A call to

Re: [PATCH 2/6] drm: Add drm_simple_encoder_{init,create}()

2020-02-07 Thread Thomas Zimmermann
Hi Am 07.02.20 um 14:37 schrieb Daniel Vetter: > On Fri, Feb 07, 2020 at 09:41:31AM +0100, Thomas Zimmermann wrote: >> The simple-encoder helpers initialize an encoder with an empty >> implementation. This covers the requirements of most of the existing >> DRM drivers. A call to drm_simple_encoder

[PATCH 2/2] drm/udl: Clear struct drm_connector_funcs.dpms

2020-02-07 Thread Thomas Zimmermann
Atomic modesetting doesn't use struct drm_connector_funcs.dpms and the set function, drm_helper_connector_dpms(), wouldn't support it anyway. So keep the pointer to NULL. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/udl/udl_connector.c | 1 - 1 file changed, 1 deletion(-) diff --git a/d

[PATCH 1/2] drm/bochs: Clear struct drm_connector_funcs.dpms

2020-02-07 Thread Thomas Zimmermann
Atomic modesetting doesn't use struct drm_connector_funcs.dpms and the set function, drm_helper_connector_dpms(), wouldn't support it anyway. So keep the pointer to NULL. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/bochs/bochs_kms.c | 1 - 1 file changed, 1 deletion(-) diff --git a/dri

Re: [PATCH v2 3/6] drm/exynos: Use drm_encoder_mask()

2020-02-07 Thread Thomas Zimmermann
Am 07.02.20 um 14:59 schrieb Ville Syrjala: > From: Ville Syrjälä > > Replace the hand rolled encoder bitmask thing with drm_encoder_mask() > > Cc: Inki Dae > Cc: Joonyoung Shim > Cc: Seung-Woo Kim > Cc: Kyungmin Park > Signed-off-by: Ville Syrjälä Acked-by: Thomas Zimmermann > --- >

Re: [PATCH v2 4/6] drm/imx: Remove the bogus possible_clones setup

2020-02-07 Thread Thomas Zimmermann
Hi Am 07.02.20 um 14:59 schrieb Ville Syrjala: > From: Ville Syrjälä > > It's not at all clear what cloning options this driver supports. > So let's just clear possible_clones instead of setting it to some > bogus value. > > Cc: Philipp Zabel > Signed-off-by: Ville Syrjälä > --- > drivers/gp

Re: [PATCH v2 5/6] drm: Validate encoder->possible_clones

2020-02-07 Thread Thomas Zimmermann
Am 07.02.20 um 14:59 schrieb Ville Syrjala: > From: Ville Syrjälä > > Many drivers are populating encoder->possible_clones wrong. Let's > persuade them to get it right by adding some loud WARNs. > > We'll cross check the bits between any two encoders. So either > both encoders can clone with t

Re: [PATCH v2 1/6] drm: Include the encoder itself in possible_clones

2020-02-07 Thread Thomas Zimmermann
Hi Am 07.02.20 um 14:59 schrieb Ville Syrjala: > From: Ville Syrjälä > > The docs say possible_clones should always include the encoder itself. > Since most drivers don't want to deal with the complexities of cloning > let's allow them to set possible_clones=0 and instead we'll fix that > up in

Re: [PATCH 2/6] drm: Add drm_simple_encoder_{init,create}()

2020-02-07 Thread Noralf Trønnes
Den 07.02.2020 09.41, skrev Thomas Zimmermann: > The simple-encoder helpers initialize an encoder with an empty > implementation. This covers the requirements of most of the existing > DRM drivers. A call to drm_simple_encoder_create() allocates and > initializes an encoder instance, a call to d

Re: [PATCH v2 1/3] fbdev/g364fb: Fix build failure

2020-02-07 Thread Bartlomiej Zolnierkiewicz
On 2/7/20 12:01 AM, Finn Thain wrote: > This patch resolves these compiler errors and warnings -- > > CC drivers/video/fbdev/g364fb.o > drivers/video/fbdev/g364fb.c: In function 'g364fb_cursor': > drivers/video/fbdev/g364fb.c:137:9: error: 'x' undeclared (first use in this > function) >

Re: [PATCH v2 1/6] drm: Include the encoder itself in possible_clones

2020-02-07 Thread Ville Syrjälä
On Fri, Feb 07, 2020 at 03:28:35PM +0100, Thomas Zimmermann wrote: > Hi > > Am 07.02.20 um 14:59 schrieb Ville Syrjala: > > From: Ville Syrjälä > > > > The docs say possible_clones should always include the encoder itself. > > Since most drivers don't want to deal with the complexities of clonin

Re: [PATCH v4 07/11] drm/meson: meson_dw_hdmi: add bridge and switch to drm_bridge_funcs

2020-02-07 Thread Boris Brezillon
On Thu, 6 Feb 2020 20:18:30 +0100 Neil Armstrong wrote: > Switch the dw-hdmi driver to drm_bridge_funcs by implementing a new local > bridge, connecting it to the dw-hdmi bridge, then implement the > atomic_get_input_bus_fmts/atomic_get_output_bus_fmts. > > Signed-off-by: Neil Armstrong > ---

[PATCH] drm/mm: Break long searches in fragmented address spaces

2020-02-07 Thread Chris Wilson
We try hard to select a suitable hole in the drm_mm first time. But if that is unsuccessful, we then have to look at neighbouring nodes, and this requires traversing the rbtree. Walking the rbtree can be slow (much slower than a linear list for deep trees), and if the drm_mm has been purposefully f

Re: [PATCH v4] drm/scheduler: Avoid accessing freed bad job.

2020-02-07 Thread Daniel Vetter
On Thu, Feb 6, 2020 at 3:51 PM Christian König wrote: > > Am 06.02.20 um 15:49 schrieb Alex Deucher: > > On Thu, Feb 6, 2020 at 6:50 AM Christian König > > wrote: > >> Am 06.02.20 um 12:10 schrieb Lucas Stach: > >>> Hi all, > >>> > >>> On Mi, 2020-02-05 at 19:24 +0100, Lucas Stach wrote: > H

Re: [PATCH v4 07/11] drm/meson: meson_dw_hdmi: add bridge and switch to drm_bridge_funcs

2020-02-07 Thread Neil Armstrong
On 07/02/2020 15:57, Boris Brezillon wrote: > On Thu, 6 Feb 2020 20:18:30 +0100 > Neil Armstrong wrote: > >> Switch the dw-hdmi driver to drm_bridge_funcs by implementing a new local >> bridge, connecting it to the dw-hdmi bridge, then implement the >> atomic_get_input_bus_fmts/atomic_get_output

Re: [PATCH 2/6] drm: Add drm_simple_encoder_{init,create}()

2020-02-07 Thread Daniel Vetter
On Fri, Feb 07, 2020 at 03:36:49PM +0100, Noralf Trønnes wrote: > > > Den 07.02.2020 09.41, skrev Thomas Zimmermann: > > The simple-encoder helpers initialize an encoder with an empty > > implementation. This covers the requirements of most of the existing > > DRM drivers. A call to drm_simple_en

Re: [PATCH 2/6] drm: Add drm_simple_encoder_{init,create}()

2020-02-07 Thread Daniel Vetter
On Fri, Feb 07, 2020 at 03:02:00PM +0100, Thomas Zimmermann wrote: > Hi > > Am 07.02.20 um 14:37 schrieb Daniel Vetter: > > On Fri, Feb 07, 2020 at 09:41:31AM +0100, Thomas Zimmermann wrote: > >> The simple-encoder helpers initialize an encoder with an empty > >> implementation. This covers the re

Re: [Intel-gfx] [PATCH v2 1/6] drm: Include the encoder itself in possible_clones

2020-02-07 Thread Daniel Vetter
On Fri, Feb 07, 2020 at 04:50:01PM +0200, Ville Syrjälä wrote: > On Fri, Feb 07, 2020 at 03:28:35PM +0100, Thomas Zimmermann wrote: > > Hi > > > > Am 07.02.20 um 14:59 schrieb Ville Syrjala: > > > From: Ville Syrjälä > > > > > > The docs say possible_clones should always include the encoder itse

Re: [PATCH v2 2/6] drm/gma500: Sanitize possible_clones

2020-02-07 Thread Daniel Vetter
On Fri, Feb 07, 2020 at 03:59:46PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > I doubt the DP+DP and SDVO+SDVO cloning works for this driver. > i915 at least doesn't do those. Truthfully there could be some very > specific circumstances where some of them would do doable, but > genereal

Re: [Intel-gfx] [PATCH v2 4/6] drm/imx: Remove the bogus possible_clones setup

2020-02-07 Thread Daniel Vetter
On Fri, Feb 07, 2020 at 03:20:44PM +0100, Thomas Zimmermann wrote: > Hi > > Am 07.02.20 um 14:59 schrieb Ville Syrjala: > > From: Ville Syrjälä > > > > It's not at all clear what cloning options this driver supports. > > So let's just clear possible_clones instead of setting it to some > > bogus

Re: [Intel-gfx] [PATCH v2 1/6] drm: Include the encoder itself in possible_clones

2020-02-07 Thread Ville Syrjälä
On Fri, Feb 07, 2020 at 05:27:51PM +0100, Daniel Vetter wrote: > On Fri, Feb 07, 2020 at 04:50:01PM +0200, Ville Syrjälä wrote: > > On Fri, Feb 07, 2020 at 03:28:35PM +0100, Thomas Zimmermann wrote: > > > Hi > > > > > > Am 07.02.20 um 14:59 schrieb Ville Syrjala: > > > > From: Ville Syrjälä > > >

Re: [PATCH v2 1/6] drm: Include the encoder itself in possible_clones

2020-02-07 Thread Daniel Vetter
On Fri, Feb 07, 2020 at 03:59:45PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > The docs say possible_clones should always include the encoder itself. > Since most drivers don't want to deal with the complexities of cloning > let's allow them to set possible_clones=0 and instead we'll fi

Re: [PATCH v2 6/6] drm: Validate encoder->possible_crtcs

2020-02-07 Thread Daniel Vetter
On Fri, Feb 07, 2020 at 03:59:50PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > WARN if the encoder possible_crtcs is effectively empty or contains > bits for non-existing crtcs. > > TODO: Or should we perhapst just filter out any bit for a > non-exisiting crtc? > > Cc: Thomas Zimmerma

Re: [Intel-gfx] [PATCH v2 1/6] drm: Include the encoder itself in possible_clones

2020-02-07 Thread Daniel Vetter
On Fri, Feb 07, 2020 at 06:34:47PM +0200, Ville Syrjälä wrote: > On Fri, Feb 07, 2020 at 05:27:51PM +0100, Daniel Vetter wrote: > > On Fri, Feb 07, 2020 at 04:50:01PM +0200, Ville Syrjälä wrote: > > > On Fri, Feb 07, 2020 at 03:28:35PM +0100, Thomas Zimmermann wrote: > > > > Hi > > > > > > > > Am

Re: [PATCH 2/2] drm/udl: Clear struct drm_connector_funcs.dpms

2020-02-07 Thread Daniel Vetter
On Fri, Feb 07, 2020 at 03:16:02PM +0100, Thomas Zimmermann wrote: > Atomic modesetting doesn't use struct drm_connector_funcs.dpms and > the set function, drm_helper_connector_dpms(), wouldn't support it > anyway. So keep the pointer to NULL. > > Signed-off-by: Thomas Zimmermann On both patches

Re: [PATCH v2 6/6] drm: Validate encoder->possible_crtcs

2020-02-07 Thread Ville Syrjälä
On Fri, Feb 07, 2020 at 05:39:26PM +0100, Daniel Vetter wrote: > On Fri, Feb 07, 2020 at 03:59:50PM +0200, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > WARN if the encoder possible_crtcs is effectively empty or contains > > bits for non-existing crtcs. > > > > TODO: Or should we perhapst

[PATCH v2 0/4] Add support for devices in the Energy Model

2020-02-07 Thread lukasz . luba
From: Lukasz Luba Hi all, This patch set introduces support for devices in the Energy Model (EM) framework. It will unify the power model for thermal subsystem and make it simpler. The 1st patch refactors EM framework and adds support for devices. The 2nd patch changes dev_pm_opp_of_register_em(

Re: [PATCH 1/3] fbdev/g364fb: Fix build failure

2020-02-07 Thread Philippe Mathieu-Daudé
On Wed, Feb 5, 2020 at 11:18 PM Finn Thain wrote: > On Wed, 5 Feb 2020, Philippe Mathieu-Daudé wrote: > > On Sun, Feb 2, 2020 at 3:41 AM Finn Thain > > wrote: > > > > > > This patch resolves these compiler errors and warnings -- > > > > > > CC drivers/video/fbdev/g364fb.o > > > drivers/vi

Re: linux-next: Tree for Feb 6 (amdgpu)

2020-02-07 Thread Randy Dunlap
On 2/5/20 8:09 PM, Stephen Rothwell wrote: > Hi all, > > Please do not add any v5.7 material to your linux-next included > branches until after v5.6-rc1 has been released. > > Changes since 20200205: > on i386: ERROR: "dtn_debugfs_init" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined! Full r

[PATCH v4 0/3] dt-bindings: add simple DSI panels

2020-02-07 Thread Benjamin Gaignard
To complement panel-simple.yaml, create panel-simple-dsi.yaml. panel-simple-dsi-yaml are for all simple DSP panels with a single power-supply and optional backlight / enable GPIO / reset GPIO. Some DSI panels like orisetech,otm8009a or raydium,rm68200 are quite similar to simple dsi panel but with

[PATCH v2 2/4] OPP: change parameter to device pointer in dev_pm_opp_of_register_em()

2020-02-07 Thread lukasz . luba
From: Lukasz Luba Drop the CPU specific interface with cpumask and switch to struct device. The Energy Model framework supports both: CPUs and devfreq devices. The new interface provides easy way to create a Energy Model (EM), which then might be used in i.e. thermal subsystem. Signed-off-by: Lu

Re: [Freedreno] [v1] drm/msm/dsi/pll: call vco set rate explicitly

2020-02-07 Thread Jeffrey Hugo
On Thu, Feb 6, 2020 at 2:13 AM Harigovindan P wrote: > > For a given byte clock, if VCO recalc value is exactly same as > vco set rate value, vco_set_rate does not get called assuming > VCO is already set to required value. But Due to GDSC toggle, > VCO values are erased in the HW. To make sure VC

[v1] drm/msm/dsi/pll: call vco set rate explicitly

2020-02-07 Thread Harigovindan P
For a given byte clock, if VCO recalc value is exactly same as vco set rate value, vco_set_rate does not get called assuming VCO is already set to required value. But Due to GDSC toggle, VCO values are erased in the HW. To make sure VCO is programmed correctly, we forcefully call set_rate from vco_

[PATCH v2 0/3] Improve MIPS Magnum support

2020-02-07 Thread Finn Thain
A few minor patches are needed to more easily boot a MIPS Magnum build under QEMU. This series fixes a build failure in the g364fb driver and modifies jazz_defconfig for use with 'qemu-system-mips64el -M magnum'. Note that QEMU's dp8393x implementation has bugs, one of which prevents the Linux jaz

Re: [PATCH] MIPS: c-r4k: Invalidate BMIPS5000 ZSCM prefetch lines

2020-02-07 Thread Florian Fainelli
On 2/6/2020 11:30 AM, Kamal Dasu wrote: > Zephyr secondary cache is 256KB, 128B lines. 32B sectors. A secondary cache > line can contain two instruction cache lines (64B), or four data cache > lines (32B). Hardware prefetch Cache detects stream access, and prefetches > ahead of processor access.

[v1] drm/msm/dsi: save pll state before dsi host is powered off

2020-02-07 Thread Harigovindan P
Save pll state before dsi host is powered off. Without this change some register values gets resetted. Signed-off-by: Harigovindan P --- Changes in v1: - Saving pll state before dsi host is powered off. - Removed calling of save state in msm_dsi_phy_disable since everything

[PATCH v2 1/3] fbdev/g364fb: Fix build failure

2020-02-07 Thread Finn Thain
This patch resolves these compiler errors and warnings -- CC drivers/video/fbdev/g364fb.o drivers/video/fbdev/g364fb.c: In function 'g364fb_cursor': drivers/video/fbdev/g364fb.c:137:9: error: 'x' undeclared (first use in this function) drivers/video/fbdev/g364fb.c:137:9: note: each undecla

[PATCH v4 2/3] dt-bindings: panel: Convert raydium, rm68200 to json-schema

2020-02-07 Thread Benjamin Gaignard
Convert raydium,rm68200 to json-schema. Signed-off-by: Benjamin Gaignard --- .../bindings/display/panel/raydium,rm68200.txt | 25 -- .../bindings/display/panel/raydium,rm68200.yaml| 56 ++ 2 files changed, 56 insertions(+), 25 deletions(-) delete mode 100644

Re: [PATCH v2] drm: shmobile: Reduce include dependencies

2020-02-07 Thread Andy Shevchenko
On Wed, Feb 05, 2020 at 07:33:22PM +0200, Laurent Pinchart wrote: > Hi Andy, > > Thank you for the patch. > > On Wed, Feb 05, 2020 at 11:32:26AM +0200, Andy Shevchenko wrote: > > This file doesn't need everything provided by . > > All it needs are some types, which are provided by . > > > > Note

Re: [PATCH] drm/mediatek: Find the cursor plane instead of hard coding it

2020-02-07 Thread Evan Benn
Apologies for the confusing thread. Please apply the above patch: 'drm/mediatek: Find the cursor plane instead of hard coding it' before Sean Paul's original patch: 'drm/mediatek: Ensure the cursor plane is on top of other overlays' This way authorship is correctly preserved, but we do not introdu

[PATCH v3] drm: shmobile: Reduce include dependencies

2020-02-07 Thread Andy Shevchenko
This file doesn't need everything provided by . All it needs are some types, which are provided by . Drop unneeded completely. Signed-off-by: Andy Shevchenko --- v3: Drop header completely (Laurent) include/linux/platform_data/shmob_drm.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/in

[PATCH] drm/mediatek: Find the cursor plane instead of hard coding it

2020-02-07 Thread Evan Benn
The cursor and primary planes were hard coded. Now search for them for passing to drm_crtc_init_with_planes Signed-off-by: Evan Benn --- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_d

Re: [Freedreno] [v1] drm/msm/dsi: save pll state before dsi host is powered off

2020-02-07 Thread Jeffrey Hugo
On Thu, Feb 6, 2020 at 1:52 AM Harigovindan P wrote: > > Save pll state before dsi host is powered off. Without this change > some register values gets resetted. The phy driver already does this. Why is the current implementation insufficient? > > Signed-off-by: Harigovindan P > --- > > Change

[PATCH] MIPS: c-r4k: Invalidate BMIPS5000 ZSCM prefetch lines

2020-02-07 Thread Kamal Dasu
Zephyr secondary cache is 256KB, 128B lines. 32B sectors. A secondary cache line can contain two instruction cache lines (64B), or four data cache lines (32B). Hardware prefetch Cache detects stream access, and prefetches ahead of processor access. Add support to inavalidate BMIPS5000 cpu zephyr se

[PATCH v4 1/3] dt-bindings: one file of all simple DSI panels

2020-02-07 Thread Benjamin Gaignard
From: Sam Ravnborg To complement panel-simple.yaml, create panel-simple-dsi.yaml. panel-simple-dsi-yaml are for all simple DSP panels with a single power-supply and optional backlight / enable GPIO. Migrate panasonic,vvx10f034n00 over to the new file. The objectives with one file for all the si

[PATCH v4 3/3] dt-bindings: panel: Convert orisetech, otm8009a to json-schema

2020-02-07 Thread Benjamin Gaignard
Convert orisetech,otm8009a to json-schema. Signed-off-by: Benjamin Gaignard --- .../bindings/display/panel/orisetech,otm8009a.txt | 23 -- .../bindings/display/panel/orisetech,otm8009a.yaml | 53 ++ 2 files changed, 53 insertions(+), 23 deletions(-) delete mode 1006

[PATCH v2 4/4] drm/panfrost: Register to the Energy Model with devfreq device

2020-02-07 Thread lukasz . luba
From: Lukasz Luba Add device to the Energy Model framework. It will create a dedicated and unified data structures used i.e. in the thermal framework. The power model used in dev_pm_opp subsystem is simplified and created based on DT 'dynamic-power-coefficient', volatage and frequency. It is simi

Re: [PATCH 1/3] fbdev/g364fb: Fix build failure

2020-02-07 Thread Finn Thain
On Fri, 7 Feb 2020, Philippe Mathieu-Daudé wrote: > On Wed, Feb 5, 2020 at 11:18 PM Finn Thain > wrote: > > On Wed, 5 Feb 2020, Philippe Mathieu-Daudé wrote: > > > On Sun, Feb 2, 2020 at 3:41 AM Finn Thain > > > wrote: > > > > > > > > This patch resolves these compiler errors and warnings --

[PATCH v2 1/4] PM / EM: add devices to Energy Model

2020-02-07 Thread lukasz . luba
From: Lukasz Luba Add support of other devices into the Energy Model framework not only the CPUs. Change the interface to be more unified which can handle other devices as well. Signed-off-by: Lukasz Luba --- Documentation/power/energy-model.rst | 129 + drivers/cpufreq/scmi-cpufreq.c

  1   2   >