Re: [PATCH v2] dt-bindings: display: Convert etnaviv to json-schema

2020-01-29 Thread Benjamin GAIGNARD
On 1/28/20 1:06 PM, Maxime Ripard wrote: > Hi Benjamin, > > On Tue, Jan 28, 2020 at 09:20:13AM +0100, Benjamin Gaignard wrote: >> Convert etnaviv bindings to yaml format. >> >> Signed-off-by: Benjamin Gaignard >> --- >> .../bindings/display/etnaviv/etnaviv-drm.txt | 36 --- >> .

Re: [PATCH v2] dt-bindings: display: Convert etnaviv to json-schema

2020-01-29 Thread Maxime Ripard
Hi Benjamin, On Tue, Jan 28, 2020 at 09:20:13AM +0100, Benjamin Gaignard wrote: > Convert etnaviv bindings to yaml format. > > Signed-off-by: Benjamin Gaignard > --- > .../bindings/display/etnaviv/etnaviv-drm.txt | 36 --- > .../devicetree/bindings/gpu/vivante,gc.yaml| 72

[v4] arm64: dts: sc7180: add display dt nodes

2020-01-29 Thread Harigovindan P
Add display, DSI hardware DT nodes for sc7180. Signed-off-by: Harigovindan P --- Changes in v1: -Added display DT nodes for sc7180 Changes in v2: -Renamed node names -Corrected code alignments -Removed extra new line -Added DISP AHB clock for register acce

[PATCH v3 0/1] Add support for sun4i HDMI audio

2020-01-29 Thread Stefan Mavrodiev
This patch series add support for HDMI audio for sun4i HDMI encored. The code uses some parts from the Allwinners's BSP kernel. In the previous patch series there was additional patch enabling the cyclic DMA transfers. It was accepted, so it's omitted here. The patch is tested on A20 chip. For th

Re: [PATCH] matroxfb: add Matrox MGA-G200eW board support

2020-01-29 Thread Rich Felker
On Mon, Jan 27, 2020 at 08:36:07AM +0100, Thomas Zimmermann wrote: > Hi > > Am 25.01.20 um 20:55 schrieb Rich Felker: > > Signed-off-by: Rich Felker > > -- > > I've had this lying around a while and figure I should send it > > upsteam; it's needed to support the onboard video on my Spectre-free >

[v1] arm64: dts: sc7180: add dsi controller and phy entries for idp dts

2020-01-29 Thread Harigovindan P
Adding dsi controller and phy entries for idp dt. Signed-off-by: Harigovindan P --- arch/arm64/boot/dts/qcom/sc7180-idp.dts | 56 + 1 file changed, 56 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sc7180-idp.dts b/arch/arm64/boot/dts/qcom/sc7180-idp.dts in

Re: [Regression 5.5-rc1] Extremely low GPU performance on NVIDIA Tegra20/30

2020-01-29 Thread Dmitry Osipenko
20.01.2020 05:53, Dmitry Osipenko пишет: > 13.12.2019 18:35, Dmitry Osipenko пишет: >> 13.12.2019 18:10, Thierry Reding пишет: >>> On Fri, Dec 13, 2019 at 12:25:33AM +0300, Dmitry Osipenko wrote: Hello Thierry, Commit [1] introduced a severe GPU performance regression on Tegra20 and

Re: [PATCH v2] dt-bindings: display: Convert etnaviv to json-schema

2020-01-29 Thread Benjamin GAIGNARD
On 1/28/20 8:35 PM, Rob Herring wrote: > On Tue, Jan 28, 2020 at 6:31 AM Benjamin GAIGNARD > wrote: >> >> On 1/28/20 1:06 PM, Maxime Ripard wrote: >>> Hi Benjamin, >>> >>> On Tue, Jan 28, 2020 at 09:20:13AM +0100, Benjamin Gaignard wrote: Convert etnaviv bindings to yaml format. S

Re: [PATCH] drm: shrinker: Add a prefix on purging logs

2020-01-29 Thread Ezequiel Garcia
On Wed, 2020-01-22 at 09:04 +0100, Daniel Vetter wrote: > On Sat, Dec 14, 2019 at 01:20:49PM -0300, Ezequiel Garcia wrote: > > It's not entirely obvious why these messages have > > "info" severity. In any case, add a proper driver prefix > > to give the user a bit of context of where they are comin

[PATCH v3 1/1] drm: sun4i: hdmi: Add support for sun4i HDMI encoder audio

2020-01-29 Thread Stefan Mavrodiev
Add HDMI audio support for the sun4i-hdmi encoder, used on the older Allwinner chips - A10, A20, A31. Most of the code is based on the BSP implementation. In it dditional formats are supported (S20_3LE and S24_LE), however there where some problems with them and only S16_LE is left. Signed-off-by

Re: [PATCH] radeon: insert 10ms sleep in dce5_crtc_load_lut

2020-01-29 Thread Daniel Vetter
On Tue, Jan 28, 2020 at 04:24:19PM -0500, Alex Deucher wrote: > On Tue, Jan 28, 2020 at 4:21 PM Alex Deucher wrote: > > > > On Tue, Jan 28, 2020 at 11:10 AM Daniel Vetter > > wrote: > > > > > > Per at least one tester this is enough magic to recover the regression > > > introduced for some peopl

[PATCH] radeon: completely remove lut leftovers

2020-01-29 Thread Daniel Vetter
This is an oversight from commit 42585395ebc1034a98937702849669f17eadb35f Author: Peter Rosin Date: Thu Jul 13 18:25:36 2017 +0200 drm: radeon: remove dead code and pointless local lut storage v2: Also remove leftover local variable. Cc: Peter Rosin Cc: Alex Deucher Cc: Michel Dänzer

Re: [PATCH] drm: shrinker: Add a prefix on purging logs

2020-01-29 Thread Daniel Vetter
On Tue, Jan 28, 2020 at 04:58:07PM -0300, Ezequiel Garcia wrote: > On Wed, 2020-01-22 at 09:04 +0100, Daniel Vetter wrote: > > On Sat, Dec 14, 2019 at 01:20:49PM -0300, Ezequiel Garcia wrote: > > > It's not entirely obvious why these messages have > > > "info" severity. In any case, add a proper dr

Re: [PATCH] drm/auth: Drop master_create/destroy hooks

2020-01-29 Thread Daniel Vetter
On Mon, Jan 27, 2020 at 01:14:37PM +0100, Thomas Hellström (VMware) wrote: > On 1/27/20 11:02 AM, Daniel Vetter wrote: > > vmwgfx stopped using them. > > > > With the drm device model that we've slowly evolved over the past few > > years master status essentially controls access to display resourc

[PATCH 3/5] drm/client: Rename _force to _locked

2020-01-29 Thread Daniel Vetter
Plus extend the kerneldoc a bit to explain how this should be used. With the previous patch to drop the force restore the main user of this function is not emphasis on the "I hold the internal master lock already" aspect, so rename the function to match. Suggested by Noralf. Cc: Noralf Trønnes S

[PATCH 1/5] drm: Complain if drivers still use the ->load callback

2020-01-29 Thread Daniel Vetter
Kinda time to get this sorted. The locking around this really is not nice. Thomas mentioned in his review that the only drivers left unconverted are radeon and amdgpu. Cc: Harry Wentland Cc: Alex Deucher Reviewed-by: Chris Wilson Reviewed-by: Thomas Zimmermann Signed-off-by: Daniel Vetter --

[PATCH 5/5] drm: Nerv drm_global_mutex BKL for good drivers

2020-01-29 Thread Daniel Vetter
This catches the majority of drivers (unfortunately not if we take users into account, because all the big drivers have at least a lastclose hook). With the prep patches out of the way all drm state is fully protected and either prevents or can deal with the races from dropping the BKL around open

[PATCH 2/5] drm/fbdev-helper: don't force restores

2020-01-29 Thread Daniel Vetter
Instead check for master status, in case we've raced. This is the last exception to the general rule that we restore fbcon only when there's no master active. Compositors are supposed to drop their master status before they switch to a different console back to text mode (or just switch to text mo

[PATCH 0/5] disable drm_global_mutex for most drivers

2020-01-29 Thread Daniel Vetter
Hi all New version without the deadlock in pan_display that Noralf spotted (hopefully that appeases CI a bit, v1 was bad), plus now being co-tested with the right igt series (hopefully). Review (especially but not only on the igt side) very much appreciated. Test-With: 20200128112549.172135-1-da

[PATCH 4/5] drm: Push drm_global_mutex locking in drm_open

2020-01-29 Thread Daniel Vetter
We want to only take the BKL on crap drivers, but to know whether we have a crap driver we first need to look it up. Split this shuffle out from the main BKL-disabling patch, for more clarity. Since the minors are refcounted drm_minor_acquire is purely internal and this does not have a driver visi

Re: [PATCH v4 09/22] drm/nouveau: Convert to CRTC VBLANK callbacks

2020-01-29 Thread Ben Skeggs
On Fri, 24 Jan 2020 at 00:00, Thomas Zimmermann wrote: > > VBLANK callbacks in struct drm_driver are deprecated in favor of > their equivalents in struct drm_crtc_funcs. Convert nouvean over. > > v4: > * add argument names in function declaration > > Signed-off-by: Thomas Zimmermann Revie

Re: [PATCH v4 08/22] drm/nouveau: Convert to struct drm_crtc_helper_funcs.get_scanout_position()

2020-01-29 Thread Ben Skeggs
On Fri, 24 Jan 2020 at 00:00, Thomas Zimmermann wrote: > > The callback struct drm_driver.get_scanout_position() is deprecated in > favor of struct drm_crtc_helper_funcs.get_scanout_position(). Convert > nouveau over. > > v4: > * add argument names in function declaration > > Signed-off-by

Re: [Intel-gfx] [PATCH 1/2] drm/i915/gem: initial conversion to new logging macros using coccinelle

2020-01-29 Thread Jani Nikula
On Tue, 28 Jan 2020, Chris Wilson wrote: > Quoting Jani Nikula (2020-01-28 13:48:10) >> On Tue, 28 Jan 2020, Tvrtko Ursulin wrote: >> >> -DRM_DEBUG( >> >> +drm_dbg(&T->drm, >> > >> > This changes DRM_UT_CORE to DRM_UT_DRIVER so our typical drm.debug=0xe >> > becomes much more spammy. >> >> This

Re: [PATCH] radeon: completely remove lut leftovers

2020-01-29 Thread Michel Dänzer
On 2020-01-29 9:09 a.m., Daniel Vetter wrote: > This is an oversight from > > commit 42585395ebc1034a98937702849669f17eadb35f > Author: Peter Rosin > Date: Thu Jul 13 18:25:36 2017 +0200 > > drm: radeon: remove dead code and pointless local lut storage > > v2: Also remove leftover local v

Re: [PATCH libdrm] meson.build: Don't detect header for linux

2020-01-29 Thread Eric Engestrom
On Friday, 2020-01-10 13:30:41 +0900, Seung-Woo Kim wrote: > The header is not required for Linux and GNU libc > 2.30 starts to warn about Linux specific header > deprecation. Don't detect header for linux. > > Signed-off-by: Seung-Woo Kim > --- > Fix meson.build script instead of code itself

[PATCH v5 05/15] drm/cirrus: Remove sending of vblank event

2020-01-29 Thread Thomas Zimmermann
The atomic helpers automatically send out fake VBLANK events if no vblanking has been initialized. Remove the sending code from the driver. v4: * separate commit from core vblank changes Signed-off-by: Thomas Zimmermann Acked-by: Gerd Hoffmann Reviewed-by: Daniel Vetter --- drivers/gp

[PATCH v5 01/15] drm: Initialize struct drm_crtc_state.no_vblank from device settings

2020-01-29 Thread Thomas Zimmermann
At the end of a commit, atomic helpers can generate a fake VBLANK event automatically. Originally implemented for writeback connectors, the functionality can be used by any driver and/or hardware without proper VBLANK interrupt. The patch updates the documentation to make this behaviour official:

[PATCH v5 09/15] drm/qxl: Remove sending of vblank event

2020-01-29 Thread Thomas Zimmermann
The atomic helpers automatically send out fake VBLANK events if no vblanking has been initialized. Remove the sending code from the driver. v4: * separate commit from core vblank changes Signed-off-by: Thomas Zimmermann Acked-by: Gerd Hoffmann Reviewed-by: Daniel Vetter --- drivers/gp

[PATCH v5 14/15] drm/virtio: Remove sending of vblank event

2020-01-29 Thread Thomas Zimmermann
The atomic helpers automatically send out fake VBLANK events if no vblanking has been initialized. Remove the sending code from the driver. v4: * separate commit from core vblank changes Signed-off-by: Thomas Zimmermann Acked-by: Gerd Hoffmann Reviewed-by: Daniel Vetter --- drivers/gp

[PATCH v5 03/15] drm/ast: Don't set struct drm_crtc_state.no_vblank explictly

2020-01-29 Thread Thomas Zimmermann
As ast does not initialize vblanking, atomic helpers initialize the value of struct drm_crtc_state.no_vblank to be true. No need to set it from within the driver. Signed-off-by: Thomas Zimmermann Acked-by: Gerd Hoffmann Reviewed-by: Daniel Vetter --- drivers/gpu/drm/ast/ast_mode.c | 2 -- 1 fi

[PATCH v5 02/15] drm/arc: Remove sending of vblank event

2020-01-29 Thread Thomas Zimmermann
The atomic helpers automatically send out fake VBLANK events if no vblanking has been initialized. Remove the sending code from the driver. v4: * separate commit from core vblank changes Signed-off-by: Thomas Zimmermann Acked-by: Gerd Hoffmann Reviewed-by: Daniel Vetter --- drivers/gp

[PATCH v5 04/15] drm/bochs: Remove sending of vblank event

2020-01-29 Thread Thomas Zimmermann
The atomic helpers automatically send out fake VBLANK events if no vblanking has been initialized. Remove the sending code from the driver. v4: * separate commit from core vblank changes Signed-off-by: Thomas Zimmermann Acked-by: Gerd Hoffmann Reviewed-by: Daniel Vetter --- drivers/gp

[PATCH v5 11/15] drm/st7586: Remove sending of vblank event

2020-01-29 Thread Thomas Zimmermann
The atomic helpers automatically send out fake VBLANK events if no vblanking has been initialized. Remove the sending code from the driver. v4: * separate commit from core vblank changes Signed-off-by: Thomas Zimmermann Acked-by: Gerd Hoffmann Reviewed-by: Daniel Vetter --- drivers/gp

[PATCH v5 00/15] Use no_vblank property for drivers without VBLANK

2020-01-29 Thread Thomas Zimmermann
Instead of faking VBLANK events by themselves, drivers without VBLANK support can enable drm_crtc_vblank.no_vblank and let DRM do the rest. The patchset makes this official and converts over drivers. The current implementation looks at state of a device wrt vblanking. If vblanking has been initial

[PATCH v5 12/15] drm/udl: Don't set struct drm_crtc_state.no_vblank explictly

2020-01-29 Thread Thomas Zimmermann
As udl does not initialize vblanking, atomic helpers initialize the value of struct drm_crtc_state.no_vblank to be true. No need to set it from within the driver. Signed-off-by: Thomas Zimmermann Acked-by: Gerd Hoffmann Reviewed-by: Daniel Vetter --- drivers/gpu/drm/udl/udl_modeset.c | 11

[PATCH v5 10/15] drm/repaper: Remove sending of vblank event

2020-01-29 Thread Thomas Zimmermann
The atomic helpers automatically send out fake VBLANK events if no vblanking has been initialized. Remove the sending code from the driver. v4: * separate commit from core vblank changes Signed-off-by: Thomas Zimmermann Acked-by: Gerd Hoffmann Reviewed-by: Daniel Vetter --- drivers/gp

[PATCH v5 07/15] drm/ili9225: Remove sending of vblank event

2020-01-29 Thread Thomas Zimmermann
The atomic helpers automatically send out fake VBLANK events if no vblanking has been initialized. Remove the sending code from the driver. v4: * separate commit from core vblank changes Signed-off-by: Thomas Zimmermann Acked-by: Gerd Hoffmann Reviewed-by: Daniel Vetter --- drivers/gp

[PATCH v5 15/15] drm/xen: Explicitly disable automatic sending of vblank event

2020-01-29 Thread Thomas Zimmermann
The atomic helpers automatically send out fake VBLANK events if no vblanking has been initialized. This would apply to xen, but xen has its own vblank logic. To avoid interfering with the atomic helpers, disable automatic vblank events explicitly. v5: * update comment v4: * separat

[PATCH v5 13/15] drm/vboxvideo: Remove sending of vblank event

2020-01-29 Thread Thomas Zimmermann
The atomic helpers automatically send out fake VBLANK events if no vblanking has been initialized. Remove the sending code from the driver. v4: * separate commit from core vblank changes Signed-off-by: Thomas Zimmermann Acked-by: Gerd Hoffmann Reviewed-by: Daniel Vetter --- drivers/gp

[PATCH v5 08/15] drm/mipi-dbi: Remove sending of vblank event

2020-01-29 Thread Thomas Zimmermann
The atomic helpers automatically send out fake VBLANK events if no vblanking has been initialized. Remove the sending code from the driver. v4: * separate commit from core vblank changes Signed-off-by: Thomas Zimmermann Acked-by: Gerd Hoffmann Reviewed-by: Daniel Vetter --- drivers/gp

[PATCH v5 06/15] drm/gm12u320: Remove sending of vblank event

2020-01-29 Thread Thomas Zimmermann
The atomic helpers automatically send out fake VBLANK events if no vblanking has been initialized. Remove the sending code from the driver. v4: * separate commit from core vblank changes Signed-off-by: Thomas Zimmermann Acked-by: Gerd Hoffmann Reviewed-by: Daniel Vetter --- drivers/gp

[PATCH RESEND] drm/ast: Allocate initial CRTC state of the correct size

2020-01-29 Thread Thomas Zimmermann
The ast driver inherits from DRM's CRTC state, but still uses the atomic helper for struct drm_crtc_funcs.reset, drm_atomic_helper_crtc_reset(). The helper only allocates enough memory for the core CRTC state. That results in an out-ouf-bounds access when duplicating the initial CRTC state. Simpli

Re: [Regression 5.5-rc1] Extremely low GPU performance on NVIDIA Tegra20/30

2020-01-29 Thread Thierry Reding
On Mon, Jan 20, 2020 at 05:53:03AM +0300, Dmitry Osipenko wrote: > 13.12.2019 18:35, Dmitry Osipenko пишет: > > 13.12.2019 18:10, Thierry Reding пишет: > >> On Fri, Dec 13, 2019 at 12:25:33AM +0300, Dmitry Osipenko wrote: > >>> Hello Thierry, > >>> > >>> Commit [1] introduced a severe GPU performan

Re: [PATCH RESEND] drm/ast: Allocate initial CRTC state of the correct size

2020-01-29 Thread Daniel Vetter
On Wed, Jan 29, 2020 at 1:31 PM Thomas Zimmermann wrote: > > The ast driver inherits from DRM's CRTC state, but still uses the atomic > helper for struct drm_crtc_funcs.reset, drm_atomic_helper_crtc_reset(). > > The helper only allocates enough memory for the core CRTC state. That > results in an

Re: [v4] arm64: dts: sc7180: add display dt nodes

2020-01-29 Thread harigovi
On 2020-01-29 02:02, Matthias Kaehlcke wrote: Hi, On Tue, Jan 28, 2020 at 06:54:44PM +0530, Harigovindan P wrote: Add display, DSI hardware DT nodes for sc7180. Signed-off-by: Harigovindan P --- Changes in v1: -Added display DT nodes for sc7180 Changes in v2: -Renamed node na

Re: [PATCH v5 15/15] drm/xen: Explicitly disable automatic sending of vblank event

2020-01-29 Thread Oleksandr Andrushchenko
On 1/29/20 2:05 PM, Thomas Zimmermann wrote: > The atomic helpers automatically send out fake VBLANK events if no > vblanking has been initialized. This would apply to xen, but xen has > its own vblank logic. To avoid interfering with the atomic helpers, > disable automatic vblank events explicitly

[PATCH v3] dt-bindings: display: Convert etnaviv to json-schema

2020-01-29 Thread Benjamin Gaignard
Convert etnaviv bindings to yaml format. Move bindings file from display to gpu folder. Signed-off-by: Benjamin Gaignard --- version 3: - describe clock-names as enum to allow all possible mix version 2: - move bindings file from display to gpu folder .../bindings/display/etnaviv/etnaviv-drm.tx

Re: [PATCH 3/5] drm/client: Rename _force to _locked

2020-01-29 Thread Noralf Trønnes
Den 29.01.2020 09.24, skrev Daniel Vetter: > Plus extend the kerneldoc a bit to explain how this should be used. > With the previous patch to drop the force restore the main user of > this function is not emphasis on the "I hold the internal master lock The _not_ confuses me, the emphasis is now

Re: [Intel-gfx] [PATCH 1/2] drm/i915/gem: initial conversion to new logging macros using coccinelle

2020-01-29 Thread Jani Nikula
On Wed, 29 Jan 2020, Jani Nikula wrote: > On Tue, 28 Jan 2020, Chris Wilson wrote: >> Quoting Jani Nikula (2020-01-28 13:48:10) >>> On Tue, 28 Jan 2020, Tvrtko Ursulin wrote: >>> >> -DRM_DEBUG( >>> >> +drm_dbg(&T->drm, >>> > >>> > This changes DRM_UT_CORE to DRM_UT_DRIVER so our typical drm.debu

Re: [PATCH 3/5] drm/client: Rename _force to _locked

2020-01-29 Thread Daniel Vetter
On Wed, Jan 29, 2020 at 2:16 PM Noralf Trønnes wrote: > Den 29.01.2020 09.24, skrev Daniel Vetter: > > Plus extend the kerneldoc a bit to explain how this should be used. > > With the previous patch to drop the force restore the main user of > > this function is not emphasis on the "I hold the int

Re: KASAN: slab-out-of-bounds Write in vgacon_scroll

2020-01-29 Thread Sergey Senozhatsky
On (20/01/28 15:58), Bartlomiej Zolnierkiewicz wrote: [..] > > Help is welcomed as I'm not going to look at it in the foreseeable future > (I'm busy enough with other things). > > > (dri-devel@lists.freedesktop.org or linux-fb...@vger.kernel.org) into CC? > > Added to Cc:, thanks. Hmm. There is

Re: KASAN: slab-out-of-bounds Write in vgacon_scroll

2020-01-29 Thread Sergey Senozhatsky
On (20/01/29 23:15), Sergey Senozhatsky wrote: > Date: Wed, 29 Jan 2020 23:15:17 +0900 > From: Sergey Senozhatsky > To: Bartlomiej Zolnierkiewicz > Cc: Petr Mladek , anon anon <742991625...@gmail.com>, > wangkefeng.w...@huawei.com, sergey.senozhat...@gmail.com, > syzkal...@googlegroups.com, lin

Re: KASAN: slab-out-of-bounds Write in vgacon_scroll

2020-01-29 Thread Sergey Senozhatsky
Cc-ing Dmitry and Tetsuo Original Message-id: CAA=061eow8amjurblsjy5ntdz-1jearleb+z6hjuyzud0zz...@mail.gmail.com On (20/01/29 23:17), Sergey Senozhatsky wrote: > > Hmm. There is something strange about it. I use vga console quite > > often, and scrolling happens all the time, yet I can't get the

Re: [PATCH 5/9] mm, drm/ttm, drm/vmwgfx: Support huge TTM pagefaults

2020-01-29 Thread Christian König
Am 24.01.20 um 10:09 schrieb Thomas Hellström (VMware): From: Thomas Hellstrom Support huge (PMD-size and PUD-size) page-table entries by providing a huge_fault() callback. We still support private mappings and write-notify by splitting the huge page-table entries on write-access. Note that fo

Re: [linux-sunxi] [PATCH v3 1/1] drm: sun4i: hdmi: Add support for sun4i HDMI encoder audio

2020-01-29 Thread Chen-Yu Tsai
On Tue, Jan 28, 2020 at 10:07 PM Stefan Mavrodiev wrote: > > Add HDMI audio support for the sun4i-hdmi encoder, used on > the older Allwinner chips - A10, A20, A31. > > Most of the code is based on the BSP implementation. In it > dditional formats are supported (S20_3LE and S24_LE), however > ther

Re: [PATCH 4/5] drm: Push drm_global_mutex locking in drm_open

2020-01-29 Thread Sam Ravnborg
Hi Daniel. On Wed, Jan 29, 2020 at 09:24:09AM +0100, Daniel Vetter wrote: > We want to only take the BKL on crap drivers, but to know whether The BKL was killed long time ago.. In other words I was confused until I realized that - BKL - drm_global_mutex BKL - drm_global_mutex Was all the same. At

Re: [PATCH 5/5] drm: Nerv drm_global_mutex BKL for good drivers

2020-01-29 Thread Sam Ravnborg
Hi Daniel. In the nit-pick department today - sorry. Subject: [PATCH 5/5] drm: Nerv drm_global_mutex BKL for good drivers I did not understand this subject... - what is "Nerv"? Sam On Wed, Jan 29, 2020 at 09:24:10AM +0100, Daniel Vetter wrote: > This catches the majority of drivers (unf

[PATCH 1/2] ARM: dts: keystone-k2g: Add DSS node

2020-01-29 Thread Jyri Sarha
Add DT node for DSS. K2G has DSS version 6. Keystone family DSS are somewhat different compered to the old OMAP family DSSes and the binding looks different too. Signed-off-by: Jyri Sarha Signed-off-by: Tomi Valkeinen Signed-off-by: Jyri Sarha --- arch/arm/boot/dts/keystone-k2g.dtsi | 22 +

[PATCH 0/2] ARM: dts: keystone-k2g-evm: Display support

2020-01-29 Thread Jyri Sarha
Now that drm/tidss is queued for mainline, lets add display support for k2g-evm. There is no hurry since tidss is out only in v5.7, but it should not harm to have the dts changes in place before that. Jyri Sarha (2): ARM: dts: keystone-k2g: Add DSS node ARM: dts: keystone-k2g-evm: add HDMI vid

[PATCH 2/2] ARM: dts: keystone-k2g-evm: add HDMI video support

2020-01-29 Thread Jyri Sarha
Add DT nodes for HDMI video support for K2G EVM. The HDMI uses SiI9022 DPI as HDMI encoder. The DSS DPI is connected to SiI9022 HDMI encoder's video input and encoder's output goes to HDMI connector. Signed-off-by: Jyri Sarha --- arch/arm/boot/dts/keystone-k2g-evm.dts | 101 +

Re: [PATCH 4/5] drm: Push drm_global_mutex locking in drm_open

2020-01-29 Thread Daniel Vetter
On Wed, Jan 29, 2020 at 05:45:45PM +0100, Sam Ravnborg wrote: > Hi Daniel. > > On Wed, Jan 29, 2020 at 09:24:09AM +0100, Daniel Vetter wrote: > > We want to only take the BKL on crap drivers, but to know whether > The BKL was killed long time ago.. > In other words I was confused until I realized

[PATCH 0/2] Add support for EDT ETM043080DH6-GP

2020-01-29 Thread Marian-Cristian Rotariu
This small patch-set adds support for EDT ETM043080DH6-GP. This is a 480x272 TFT Display with capacitive touchscreen and it is compatible with simple panel driver. We have tested it with our iWave-G22D Generic SODIMM Development Board. Marian-Cristian Rotariu (2): dt-bindings: display: Add bind

[PATCH 1/2] dt-bindings: display: Add bindings for EDT panel

2020-01-29 Thread Marian-Cristian Rotariu
Document the Emerging Display Technology Corp. (EDT) ETM043080DH6-GP display, which is a 480x272 4.3" TFT display with capacitive touchscreen. Signed-off-by: Marian-Cristian Rotariu Reviewed-by: Lad Prabhakar --- Documentation/devicetree/bindings/display/panel/edt,et-series.txt | 3 +++ 1 file

[PATCH 2/2] drm/panel: simple: Add EDT panel support

2020-01-29 Thread Marian-Cristian Rotariu
EDT ET043080DH6-GP is a 4.3" WQVGA 480x272 RGB LCD panel used on the iWave Generic SODIMM Development Platform. Signed-off-by: Marian-Cristian Rotariu Reviewed-by: Lad Prabhakar --- drivers/gpu/drm/panel/panel-simple.c | 33 + 1 file changed, 33 insertions(+) d

Re: [PATCH 5/5] drm: Nerv drm_global_mutex BKL for good drivers

2020-01-29 Thread Daniel Vetter
On Wed, Jan 29, 2020 at 05:47:33PM +0100, Sam Ravnborg wrote: > Hi Daniel. > > In the nit-pick department today - sorry. > > Subject: [PATCH 5/5] drm: Nerv drm_global_mutex BKL for good drivers > I did not understand this subject... - what is "Nerv"? It's a typo, supposed to be nerf: https://ww

Re: [PATCH v3 2/3] drm: bridge: Add support for Cadence MHDP DPI/DP bridge

2020-01-29 Thread Jyri Sarha
On 22/01/2020 12:55, Yuti Amonkar wrote: > This patch adds new DRM driver for Cadence MHDP DPTX IP used on J721e SoC. > MHDP DPTX IP is the component that complies with VESA DisplayPort (DP) and > embedded Display Port (eDP) standards.It integrates uCPU running the > embedded Firmware(FW) interface

Re: [PATCH 5/5] drm: Nerv drm_global_mutex BKL for good drivers

2020-01-29 Thread Chris Wilson
Quoting Daniel Vetter (2020-01-29 08:24:10) > @@ -378,9 +409,10 @@ int drm_open(struct inode *inode, struct file *filp) > if (IS_ERR(minor)) > return PTR_ERR(minor); > > - mutex_unlock(&drm_global_mutex); > - > dev = minor->dev; > + if (drm_dev_needs_gl

Re: [PATCH 1/2] dt-bindings: display: Add bindings for EDT panel

2020-01-29 Thread Sam Ravnborg
Hi Marian-Cristian On Wed, Jan 29, 2020 at 05:01:57PM +, Marian-Cristian Rotariu wrote: > Document the Emerging Display Technology Corp. (EDT) ETM043080DH6-GP > display, which is a 480x272 4.3" TFT display with capacitive touchscreen. > > Signed-off-by: Marian-Cristian Rotariu > > Reviewed-

Re: [PATCH 0/2] Add support for EDT ETM043080DH6-GP

2020-01-29 Thread Sam Ravnborg
Hi Marian-Cristian. On Wed, Jan 29, 2020 at 05:01:56PM +, Marian-Cristian Rotariu wrote: > This small patch-set adds support for EDT ETM043080DH6-GP. This is a > 480x272 TFT Display with capacitive touchscreen and it is compatible with > simple panel driver. > > We have tested it with our iWa

Re: [PATCH 1/2] dt-bindings: display/panel: add bindings for S6E88A0-AMS452EF01

2020-01-29 Thread Sam Ravnborg
Hi Michael. On Sun, Jan 26, 2020 at 07:39:10PM +0100, michael.s...@seznam.cz wrote: > From: Michael Srba > > This patch adds dts bindings for Samsung AMS452EF01 AMOLED panel, which makes > use of their S6E88A0 controller. > > Signed-off-by: Michael Srba New bindings files for panels must be in

Re: [PATCH 2/2] drm/panel: simple: Add EDT panel support

2020-01-29 Thread Sam Ravnborg
Hi Marian-Cristian On Wed, Jan 29, 2020 at 05:01:58PM +, Marian-Cristian Rotariu wrote: > EDT ET043080DH6-GP is a 4.3" WQVGA 480x272 RGB LCD panel used on the iWave > Generic SODIMM Development Platform. > > Signed-off-by: Marian-Cristian Rotariu > > Reviewed-by: Lad Prabhakar > --- > dri

Re: [PATCH 2/2] drm/panel: Add a driver for Samsung s6e88a0-ams452ef01 panel

2020-01-29 Thread Sam Ravnborg
Hi Michael. Thanks for submitting this driver. The main feedback is that there is changes in the code, and you need to base it on top of drm-misc-next. The rest are small nits. Sam On Sun, Jan 26, 2020 at 07:39:11PM +0100, michael.s...@seznam.cz wrote: > From: Michael Srba > > Add a

Re: [PATCH] drm/panel: simple: Add Innolux N133HSE panel support

2020-01-29 Thread Sam Ravnborg
Hi Marek. Thanks for the patch. On Mon, Jan 27, 2020 at 03:20:57AM +0100, Marek Vasut wrote: > From: Sean Cross > > The Innolux N133HSE panel is a 13.3" 1920x1080 panel that contains an > integrated backlight, and connects via eDP. > > It is used in the Kosagi Novena. > > Signed-off-by: Sean

Re: [PATCH v2 2/2] dt-bindings: one file of all simple DSI panels

2020-01-29 Thread Sam Ravnborg
Hi Benjamin. > > > > > > Here's the problem. If it is not required, then panels with multiple > > > supplies will get added here because they didn't care to begin with. > > > Then when someone decides to think about the supplies it will have to > > > be moved. Bindings need to be complete from the

Re: [PATCH v4 1/3] dt-bindings: add vendor prefix for OzzMaker and Waveshare Electronics

2020-01-29 Thread Sam Ravnborg
Hi Kamlesh On Mon, Jan 27, 2020 at 07:55:33PM +0530, Kamlesh Gurudasani wrote: > Add vendor prefix for OzzMaker [1] and Waveshare Electronics [2] > Both are display manufacturers > > [1] https://ozzmaker.com/about/ > [2] https://www.waveshare.com/contact_us > > Signed-off-by: Kamlesh Gurudasani

[Bug 206347] New: amdgpu.dc=1 breaks power management on RX480

2020-01-29 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=206347 Bug ID: 206347 Summary: amdgpu.dc=1 breaks power management on RX480 Product: Drivers Version: 2.5 Kernel Version: 5.4.14 Hardware: x86-64 OS: Linux Tree: Mai

[Bug 206347] amdgpu.dc=1 breaks power management on RX480 and others

2020-01-29 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=206347 Victor Mataré (mat...@fh-aachen.de) changed: What|Removed |Added Summary|amdgpu.dc=1 breaks power|amdgpu.dc=1 breaks p

Re: [PATCH v4 2/3] dt-bindings: add binding for tft displays based on ilitek,ili9486

2020-01-29 Thread Sam Ravnborg
Hi Kamlesh Thanks for the conversion to DT Schema format. On Mon, Jan 27, 2020 at 07:56:14PM +0530, Kamlesh Gurudasani wrote: > This binding is for the tft displays based on ilitek,ili9486. > ozzmaker,piscreen and waveshare,rpi-lcd-35 are such displays > > Signed-off-by: Kamlesh Gurudasani > --

Re: [PATCH v4 3/3] drm/tinydrm: add support for tft displays based on ilitek,ili9486

2020-01-29 Thread Sam Ravnborg
Hi Kamlesh On Mon, Jan 27, 2020 at 07:56:46PM +0530, Kamlesh Gurudasani wrote: > This adds support fot ilitek,ili9486 based displays with shift register > in front of controller. > Ozzmaker,Piscreen and Waveshare,rpi-lcd-35 are such displays. > > Signed-off-by: Kamlesh Gurudasani Driver looks g

Re: [PATCH v1 1/4] drm/tiny/repaper: Make driver OF-independent

2020-01-29 Thread Sam Ravnborg
Hi Andy. On Mon, Jan 27, 2020 at 11:39:39AM +0200, Andy Shevchenko wrote: > On Fri, Jan 24, 2020 at 07:18:12PM +0100, Sam Ravnborg wrote: > > On Fri, Jan 24, 2020 at 07:31:34PM +0200, Andy Shevchenko wrote: > > > On Fri, Jan 24, 2020 at 05:42:33PM +0100, Sam Ravnborg wrote: > > > > On Wed, Jan 22,

[Bug 206349] New: WARNING: dcn20_validate_bandwidth+0x87/0x9e [ amdgpu on 5700 XT ]

2020-01-29 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=206349 Bug ID: 206349 Summary: WARNING: dcn20_validate_bandwidth+0x87/0x9e [ amdgpu on 5700 XT ] Product: Drivers Version: 2.5 Kernel Version: 5.5.0 Hardware: x86-64

[PATCH] drm/mst: Fix possible NULL pointer dereference in drm_dp_mst_process_up_req()

2020-01-29 Thread José Roberto de Souza
According to DP specification, DP_SINK_EVENT_NOTIFY is also a broadcast message but as this function only handles DP_CONNECTION_STATUS_NOTIFY I will only make the static analyzer that caught this issue happy by not calling drm_dp_get_mst_branch_device_by_guid() with a NULL guid, causing drm_dp_mst_

Re: [PATCH v4 4/8] ARM: DTS: omap3: add sgx gpu child node

2020-01-29 Thread Andrew F. Davis
On 12/17/19 1:02 PM, H. Nikolaus Schaller wrote: > and add interrupt > > Tested-by: H. Nikolaus Schaller # OpenPandora 600 MHz. > Signed-off-by: H. Nikolaus Schaller > --- > arch/arm/boot/dts/omap34xx.dtsi | 11 ++- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/arc

[Bug 206347] amdgpu.dc=1 breaks power management on RX480 and others

2020-01-29 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=206347 Alex Deucher (alexdeuc...@gmail.com) changed: What|Removed |Added CC||alexdeuc...@gmail.c

[Bug 206347] amdgpu.dc=1 breaks power management on RX480 and others

2020-01-29 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=206347 --- Comment #2 from Alex Deucher (alexdeuc...@gmail.com) --- dc is enabled by default because it supports a lot more display features and the non-DC code (audio, DP MST, advanced HDMI features, etc.). On most boards it also clocks down fine. --

[Bug 206347] amdgpu.dc=1 breaks power management on RX480 and others

2020-01-29 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=206347 --- Comment #3 from Victor Mataré (mat...@fh-aachen.de) --- Created attachment 287029 --> https://bugzilla.kernel.org/attachment.cgi?id=287029&action=edit dmesg dmesg from a longer session with at least one suspend/resume cycle. Those GPU fault

[Bug 206347] amdgpu.dc=1 breaks power management on RX480 and others

2020-01-29 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=206347 --- Comment #4 from Victor Mataré (mat...@fh-aachen.de) --- Created attachment 287031 --> https://bugzilla.kernel.org/attachment.cgi?id=287031&action=edit Xorg.0.log -- You are receiving this mail because: You are watching the assignee of the

[Bug 206347] amdgpu.dc=1 breaks power management on RX480 and others

2020-01-29 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=206347 --- Comment #5 from Victor Mataré (mat...@fh-aachen.de) --- I'm using a single 60Hz 4K display, connected via DisplayPort. KDE Desktop with OpenGL backend. -- You are receiving this mail because: You are watching the assignee of the bug. ___

[PATCH] vulkan: Add VK_GOOGLE_display_timing extension (x11+display, anv+radv) [v8]

2020-01-29 Thread Keith Packard
This adds support for the VK_GOOGLE_display timing extension, which provides two things: 1) Detailed information about when frames are displayed, including slack time between GPU execution and display frame. 2) Absolute time control over swapchain queue processing. This allows the appli