Re: [PATCH] drm: shrinker: Add a prefix on purging logs

2020-01-22 Thread Daniel Vetter
On Sat, Dec 14, 2019 at 01:20:49PM -0300, Ezequiel Garcia wrote: > It's not entirely obvious why these messages have > "info" severity. In any case, add a proper driver prefix > to give the user a bit of context of where they are coming from. So the i915 one makes some sense, it's for oom. Which s

Re: [PATCH v4] drm/trace: Buffer DRM logs in a ringbuffer accessible via debugfs

2020-01-22 Thread Daniel Vetter
On Mon, Jan 20, 2020 at 01:56:21PM -0500, Steven Rostedt wrote: > On Thu, 16 Jan 2020 07:27:22 +0100 > Daniel Vetter wrote: > > > On Tue, Jan 14, 2020 at 12:21:43PM -0500, Sean Paul wrote: > > > From: Sean Paul > > > > > > This patch uses a ring_buffer to keep a "flight recorder" (name credit

Re: [PATCH v2 4/4] drm/simple-kms: Let DRM core send VBLANK events by default

2020-01-22 Thread Daniel Vetter
On Fri, Jan 17, 2020 at 08:17:10AM +0100, Thomas Zimmermann wrote: > Hi > > Am 17.01.20 um 00:59 schrieb Daniel Vetter: > > On Thu, Jan 16, 2020 at 05:22:34PM +, Emil Velikov wrote: > >> Hi all, > >> > >> On Thu, 16 Jan 2020 at 07:37, Thomas Zimmermann > >> wrote: > >> > diff --git a/dr

Re: [PATCH -next] drm/drm_dp_mst:remove set but not used variable 'origlen'

2020-01-22 Thread Daniel Vetter
On Sat, Jan 18, 2020 at 04:06:28PM +0800, Bo YU wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/gpu/drm/drm_dp_mst_topology.c:3693:16: warning: variable > ‘origlen’ set but not used [-Wunused-but-set-variable] > int replylen, origlen, curreply; > > It looks like never use va

Re: [PATCH v2 4/4] drm/simple-kms: Let DRM core send VBLANK events by default

2020-01-22 Thread Thomas Zimmermann
Hi Am 22.01.20 um 09:11 schrieb Daniel Vetter: > On Fri, Jan 17, 2020 at 08:17:10AM +0100, Thomas Zimmermann wrote: >> Hi >> >> Am 17.01.20 um 00:59 schrieb Daniel Vetter: >>> On Thu, Jan 16, 2020 at 05:22:34PM +, Emil Velikov wrote: Hi all, On Thu, 16 Jan 2020 at 07:37, Thomas

[PATCH -next 03/14] drm/amdgpu: remove unnecessary conversion to bool in navi10_ih.c

2020-01-22 Thread Chen Zhou
Fixes coccicheck warning: ./drivers/gpu/drm/amd/amdgpu/navi10_ih.c:429:40-45: WARNING: conversion to bool not needed here Signed-off-by: Chen Zhou --- drivers/gpu/drm/amd/amdgpu/navi10_ih.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/na

[v1] arm64: dts: sc7180: add display dt nodes

2020-01-22 Thread Harigovindan P
Add display, DSI hardware DT nodes for sc7180. Signed-off-by: Harigovindan P --- arch/arm64/boot/dts/qcom/sc7180.dtsi | 125 +++ 1 file changed, 125 insertions(+) mode change 100644 => 100755 arch/arm64/boot/dts/qcom/sc7180.dtsi diff --git a/arch/arm64/boot/dts/

[PATCH] dt-bindings: convert rockchip-drm.txt to rockchip-drm.yaml

2020-01-22 Thread Dafna Hirschfeld
From: Dafna Hirschfeld convert the binding file rockchip-drm.txt to yaml format. This was tested and verified with: make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml make dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/displa

[PATCH v4 0/3] drm: bridge: adv7511: Add support for ADV7535

2020-01-22 Thread Bogdan Togorean
This patch-set add support for ADV7535 part in ADV7511 driver. ADV7535 and ADV7533 are pin to pin compatible parts but ADV7535 support TMDS clock upto 148.5Mhz and resolutions up to 1080p@60Hz. --- Changes in v4: - get out ADV7533 v1p2 voltage selection of this patch set - removal CONFIG_DRM_I2

[PATCH RFC v2 0/6] Add Unisoc's drm kms module

2020-01-22 Thread Kevin Tang
ChangeList: v1: 1. only upstream modeset and atomic at first commit. 2. remove some unused code; 3. use alpha and blend_mode properties; 3. add yaml support; 4. remove auto-adaptive panel driver; 5. bugfix v2: 1. add sprd crtc and plane module for KMS, preparing for multi crtc&encoder 2. remove g

[PATCH RFC v2 5/6] dt-bindings: display: add Unisoc's mipi dsi&dphy bindings

2020-01-22 Thread Kevin Tang
From: Kevin Tang Adds MIPI DSI Master and MIPI DSI-PHY (D-PHY) support for Unisoc's display subsystem. Cc: Orson Zhai Cc: Baolin Wang Cc: Chunyan Zhang Signed-off-by: Kevin Tang --- .../devicetree/bindings/display/sprd/dphy.yaml | 78 .../devicetree/bindings/display/sp

[PATCH 5/6] drm/i915/opregion: conversion to struct drm_device logging macros.

2020-01-22 Thread Wambui Karuga
This converts various instances of the printk based logging macros in i915/display/intel_opregion.c with the new struct drm_device based logging macros using the following coccinelle script: @rule1@ identifier fn, T; @@ fn(...,struct drm_i915_private *T,...) { <+... ( -DRM_INFO( +drm_info(&T->drm,

[PATCH RFC v2 3/6] dt-bindings: display: add Unisoc's dpu bindings

2020-01-22 Thread Kevin Tang
From: Kevin Tang DPU (Display Processor Unit) is the Display Controller for the Unisoc SoCs which transfers the image data from a video memory buffer to an internal LCD interface. Cc: Orson Zhai Cc: Baolin Wang Cc: Chunyan Zhang Signed-off-by: Kevin Tang --- .../devicetree/bindings/display/

[PATCH -next 11/14] drm/amdgpu: remove unnecessary conversion to bool in amdgpu_device.c

2020-01-22 Thread Chen Zhou
Fixes coccicheck warning: ./drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:2883:68-73: WARNING: conversion to bool not needed here and many more similar messages. Signed-off-by: Chen Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 8 +++- 1 file changed, 3 insertions(+), 5 deleti

[PATCH RFC v2 1/6] dt-bindings: display: add Unisoc's drm master bindings

2020-01-22 Thread Kevin Tang
From: Kevin Tang The Unisoc DRM master device is a virtual device needed to list all DPU devices or other display interface nodes that comprise the graphics subsystem Cc: Orson Zhai Cc: Baolin Wang Cc: Chunyan Zhang Signed-off-by: Kevin Tang --- .../devicetree/bindings/display/sprd/drm.yaml

[PATCH 3/6] drm/i915/power: convert to struct drm_device macros in display/intel_display_power.c

2020-01-22 Thread Wambui Karuga
Converts various instances of the printk based logging macros in i915/display/intel_display_power.c to the struct drm_device based logging macros using the following coccinelle script: @rule1@ identifier fn, T; @@ fn(...,struct drm_i915_private *T,...) { <+... ( -DRM_INFO( +drm_info(&T->drm, ...)

[PATCH v4 1/3] drm: bridge: adv7511: Remove DRM_I2C_ADV7533 Kconfig

2020-01-22 Thread Bogdan Togorean
This commit remove DRM_I2C_ADV7533 resulting a simpler driver and less choices in Kconfig. Signed-off-by: Bogdan Togorean --- drivers/gpu/drm/bridge/adv7511/Kconfig | 11 +- drivers/gpu/drm/bridge/adv7511/Makefile | 3 +- drivers/gpu/drm/bridge/adv7511/adv7511.h | 39

[PATCH V2 3/3] mtd: rawnand: brcmnand: Add support for flash-edu for dma transfers

2020-01-22 Thread Kamal Dasu
Legacy mips soc platforms that have controller v5.0 and 6.0 use flash-edu block for dma transfers. This change adds support for nand dma transfers using the EDU block. Signed-off-by: Kamal Dasu --- drivers/mtd/nand/raw/brcmnand/brcmnand.c | 296 ++- 1 file changed, 290 insert

[PATCH RFC v2 2/6] drm/sprd: add Unisoc's drm kms master

2020-01-22 Thread Kevin Tang
From: Kevin Tang Adds drm support for the Unisoc's display subsystem. This is drm device and gem driver. This driver provides support for the Direct Rendering Infrastructure (DRI) in XFree86 4.1.0 and higher. Cc: Orson Zhai Cc: Baolin Wang Cc: Chunyan Zhang Signed-off-by: Kevin Tang --- dr

[PATCH -next 01/14] drm/amdgpu: remove unnecessary conversion to bool in mmhub_v1_0.c

2020-01-22 Thread Chen Zhou
Fixes coccicheck warning: ./drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c:526:40-45: WARNING: conversion to bool not needed here ./drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c:528:40-45: WARNING: conversion to bool not needed here Signed-off-by: Chen Zhou --- drivers/gpu/drm/amd/amdgpu/mmh

[PATCH -next 04/14] drm/amdgpu: remove unnecessary conversion to bool in gfx_v10_0.c

2020-01-22 Thread Chen Zhou
Fixes coccicheck warning: ./drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c:4259:43-48: WARNING: conversion to bool not needed here and many more similar messages. Signed-off-by: Chen Zhou --- drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 4 ++-- drivers/gpu/drm/amd/amdgpu/mmhub_v2_0.c | 4 ++-- 2

[PATCH RFC v2 4/6] drm/sprd: add Unisoc's drm display controller driver

2020-01-22 Thread Kevin Tang
From: Kevin Tang Adds DPU(Display Processor Unit) support for the Unisoc's display subsystem. It's support multi planes, scaler, rotation and more. Cc: Orson Zhai Cc: Baolin Wang Cc: Chunyan Zhang Signed-off-by: Kevin Tang --- drivers/gpu/drm/sprd/Makefile | 6 +- drivers/gpu/drm/sp

[PATCH v2 4/5] drm/i915/bw: convert to drm_device based logging macros

2020-01-22 Thread Wambui Karuga
This replaces the printk based logging macros with the struct drm_based macros in i915/display/intel_bw.c This transformation was achieved by using the following coccinelle script that matches based on the existence of a struct drm_i915_private device in the functions: @rule1@ identifier fn, T; @@

[PATCH v2] dt-bindings: convert rockchip-drm.txt to rockchip-drm.yaml

2020-01-22 Thread Dafna Hirschfeld
convert the binding file rockchip-drm.txt to yaml format. This was tested and verified with: make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml make dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.y

[PATCH] drm/i915/display: convert to struct drm_device logging macros.

2020-01-22 Thread Wambui Karuga
This patch converts various instances of the printk based logging macros in drm/i915/display/intel_display.c to the new struct drm_device based logging macros. In some instances, this involves extracting the struct drm_i915_private device from various intel types and using it in the macros. Signed

[PATCH 1/6] drm/i915/dsi: conversion to struct drm_device log macros

2020-01-22 Thread Wambui Karuga
This converts the more straightforward instances of the printk based logging macros with the struct drm_device based logging macros. This transformation was achieved using coccinelle and the following script for matching an existing struct drm_i915_private device: @rule1@ identifier fn, T; @@ fn(.

[PATCH v2 2/5] drm/i915/bios: convert to struct drm_device logging macros.

2020-01-22 Thread Wambui Karuga
This replaces the printk based logging macros with the struct drm_device based logging macros. This conversion was achieved using the following coccinelle script that transforms based on the existence of a struct drm_i915_private device: @rule1@ identifier fn, T; @@ fn(struct drm_i915_private *T,.

Re: [PATCH 1/4] PM / EM: and devices to Energy Model

2020-01-22 Thread Quentin Perret
On Monday 20 Jan 2020 at 18:38:41 (+), Lukasz Luba wrote: > I think we could avoid this additional argument 'cpumask'. I have > checked the cpufreq_cpu_get function, which should do be good for this: > > -->8- > static int _get_sharing_cpus(struct device *cpu_de

[PATCH v4 2/3] drm: bridge: adv7511: Add support for ADV7535

2020-01-22 Thread Bogdan Togorean
ADV7535 is a DSI to HDMI bridge chip like ADV7533 but it allows 1080p@60Hz. v1p2 is fixed to 1.8V on ADV7535. Signed-off-by: Bogdan Togorean --- drivers/gpu/drm/bridge/adv7511/Kconfig | 4 ++-- drivers/gpu/drm/bridge/adv7511/adv7511.h | 1 + drivers/gpu/drm/bridge/adv7511/adv7511_drv

Re: [PATCH v2] dt-bindings: convert rockchip-drm.txt to rockchip-drm.yaml

2020-01-22 Thread Johan Jonker
Hi Dafna, You are checking at the wrong platforms. Maintainers incomplete. ">" is missing. Recheck please. Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml: ignoring, error in schema: maintainers: 0 make ARCH=arm CROSS_COMPILE=/usr/bin/arm-linux-gnueabi- menuconfig # change i

[PATCH V2 2/3] arch: mips: brcm: Add 7425 flash-edu support

2020-01-22 Thread Kamal Dasu
Nand controller v5.0 and v6.0 have nand edu blocks that enable dma nand flash transfers. This allows for faster read and write access. Signed-off-by: Kamal Dasu --- arch/mips/boot/dts/brcm/bcm7425.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/mips/boot/dts/brc

[PATCH -next 09/14] drm/amdgpu: remove unnecessary conversion to bool in nv.c

2020-01-22 Thread Chen Zhou
Fixes coccicheck warning: ./drivers/gpu/drm/amd/amdgpu/nv.c:953:40-45: WARNING: conversion to bool not needed here and many more similar messages. Signed-off-by: Chen Zhou --- drivers/gpu/drm/amd/amdgpu/nv.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/dr

[PATCH -next 14/14] drm/amdgpu: remove unnecessary conversion to bool in gfx_v9_0.c

2020-01-22 Thread Chen Zhou
Fixes coccicheck warning: ./drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c:4737:43-48: WARNING: conversion to bool not needed here Signed-off-by: Chen Zhou --- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu

[PATCH V2 1/3] dt: bindings: brcmnand: Add support for flash-edu

2020-01-22 Thread Kamal Dasu
Adding support for EBI DMA unit (EDU). Signed-off-by: Kamal Dasu --- .../devicetree/bindings/mtd/brcm,brcmnand.txt | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/Documentation/devicetree/bindings/mtd/brcm,brcmnand.txt b/Documentation/devicetree/bindings/m

[PATCH -next 08/14] drm/amdgpu: remove unnecessary conversion to bool in soc15.c

2020-01-22 Thread Chen Zhou
Fixes coccicheck warning: ./drivers/gpu/drm/amd/amdgpu/soc15.c:1474:40-45: WARNING: conversion to bool not needed here and many more similar messages. Signed-off-by: Chen Zhou --- drivers/gpu/drm/amd/amdgpu/soc15.c | 28 ++-- 1 file changed, 14 insertions(+), 14

[PATCH 0/6] conversion to struct drm_device logging macros.

2020-01-22 Thread Wambui Karuga
This series continues the ongoing conversion to the new struct drm_device based logging macros for debug in i915. This series was done using the coccinelle script: @rule1@ identifier fn, T; @@ fn(...,struct drm_i915_private *T,...) { <+... ( -DRM_INFO( +drm_info(&T->drm, ...) | -DRM_ERROR( +drm_er

[PATCH -next 05/14] drm/amdgpu: remove unnecessary conversion to bool in sdma_v5_0.c

2020-01-22 Thread Chen Zhou
Fixes coccicheck warning: ./drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c:1528:40-45: WARNING: conversion to bool not needed here ./drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c:1530:40-45: WARNING: conversion to bool not needed here Signed-off-by: Chen Zhou --- drivers/gpu/drm/amd/amdgpu/sdm

[PATCH v4 3/3] dt-bindings: drm: bridge: adv7511: Add ADV7535 support

2020-01-22 Thread Bogdan Togorean
ADV7535 is a part compatible with ADV7533 but it supports 1080p@60hz and v1p2 supply is fixed to 1.8V Signed-off-by: Bogdan Togorean Reviewed-by: Laurent Pinchart --- .../bindings/display/bridge/adi,adv7511.txt | 23 ++- 1 file changed, 12 insertions(+), 11 deletions(-) diff

[PATCH] drm/amd/powerplay: use true, false for bool variable in smu7_hwmgr.c

2020-01-22 Thread Zheng Bin
From: zhengbin Fixes coccicheck warning: drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c:723:2-50: WARNING: Assignment of 0/1 to bool variable drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c:733:3-52: WARNING: Assignment of 0/1 to bool variable drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.

[PATCH v3] dt-bindings: convert rockchip-drm.txt to rockchip-drm.yaml

2020-01-22 Thread Dafna Hirschfeld
convert the binding file rockchip-drm.txt to yaml format. This was tested and verified on ARM and ARM64 with: make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml make dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockch

[PATCH v2 0/5] drm/i915: conversion to new drm logging macros.

2020-01-22 Thread Wambui Karuga
This series continues the conversion to the new struct drm_device based logging macros in various files in drm/i915. These patches were achieved both using coccinelle and manually. v2: rebase patches onto drm-tip to fix merge conflict in v1 series. Wambui Karuga (5): drm/i915/atomic: use struct

Re: [PATCH -next] backlight: qcom-wled: fix unsigned comparison to zero

2020-01-22 Thread Chen Zhou
Hi Bjorn, On 2020/1/22 8:39, Bjorn Andersson wrote: > On Mon 20 Jan 05:01 PST 2020, Chen Zhou wrote: > >> Fixes coccicheck warning: >> ./drivers/video/backlight/qcom-wled.c:1104:5-15: >> WARNING: Unsigned expression compared with zero: string_len > 0 >> >> The unsigned variable string_len is

[PATCH -next 00/14] drm/amdgpu: remove unnecessary conversion to bool

2020-01-22 Thread Chen Zhou
This patch series remove unnecessary conversion to bool in dir drivers/gpu/drm/amd/amdgpu/, which is detected by coccicheck. Chen Zhou (14): drm/amdgpu: remove unnecessary conversion to bool in mmhub_v1_0.c drm/amdgpu: remove unnecessary conversion to bool in vega10_ih.c drm/amdgpu: remove

[PATCH -next 07/14] drm/amdgpu: remove unnecessary conversion to bool in amdgpu_acp.c

2020-01-22 Thread Chen Zhou
Fixes coccicheck warning: ./drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c:530:51-56: WARNING: conversion to bool not needed here Signed-off-by: Chen Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/

[PATCH -next 06/14] drm/amdgpu: remove unnecessary conversion to bool in athub_v1_0.c

2020-01-22 Thread Chen Zhou
Fixes coccicheck warning: ./drivers/gpu/drm/amd/amdgpu/athub_v1_0.c:77:40-45: WARNING: conversion to bool not needed here ./drivers/gpu/drm/amd/amdgpu/athub_v1_0.c:79:40-45: WARNING: conversion to bool not needed here Signed-off-by: Chen Zhou --- drivers/gpu/drm/amd/amdgpu/athub

Re: mmotm 2020-01-21-13-28 uploaded (nouveau)

2020-01-22 Thread Randy Dunlap
On 1/21/20 1:29 PM, a...@linux-foundation.org wrote: > The mm-of-the-moment snapshot 2020-01-21-13-28 has been uploaded to > >http://www.ozlabs.org/~akpm/mmotm/ > > mmotm-readme.txt says > > README for mm-of-the-moment: > > http://www.ozlabs.org/~akpm/mmotm/ > > This is a snapshot of my -m

[PATCH 2/6] drm/i915/ddi: convert to struct drm_device log macros.

2020-01-22 Thread Wambui Karuga
This patch converts various instances of the printk based logging macros into the struct drm_device based macros. This was achieved using the following coccinelle script for matching existing struct drm_i915_private devices: @rule1@ identifier fn, T; @@ fn(...,struct drm_i915_private *T,...) { <+.

[PATCH -next 10/14] drm/amdgpu: remove unnecessary conversion to bool in mmhub_v9_4.c

2020-01-22 Thread Chen Zhou
Fixes coccicheck warning: ./drivers/gpu/drm/amd/amdgpu/mmhub_v9_4.c:628:40-45: WARNING: conversion to bool not needed here ./drivers/gpu/drm/amd/amdgpu/mmhub_v9_4.c:630:40-45: WARNING: conversion to bool not needed here Signed-off-by: Chen Zhou --- drivers/gpu/drm/amd/amdgpu/mmh

[PATCH v2 3/5] drm/i915/audio: convert to struct drm_device logging macros.

2020-01-22 Thread Wambui Karuga
Converts the printk based logging macros in i915/display/intel_audio.c to the struct drm_device based logging macros. This transformation was achieved using the following coccinelle script that matches the existence of the struct drm_i915_private device: @rule1@ identifier fn, T; @@ fn(struct drm

[PATCH 4/6] drm/i915/dp: conversion to struct drm_device logging macros.

2020-01-22 Thread Wambui Karuga
This converts various instances of printk based logging macros in i915/display/intel_dp.c with the new struct drm_device based logging macros using the following coccinelle script: @rule1@ identifier fn, T; @@ fn(...,struct drm_i915_private *T,...) { <+... ( -DRM_INFO( +drm_info(&T->drm, ...) | -D

Re: [PATCH v2] dt-bindings: convert rockchip-drm.txt to rockchip-drm.yaml

2020-01-22 Thread Johan Jonker
Hi, On 1/21/20 4:26 PM, Dafna Hirschfeld wrote: > > > On 21.01.20 16:11, Johan Jonker wrote: >> Hi Dafna, >> >> >>> >>> >>> On 21.01.20 15:03, Rob Herring wrote: On Tue, Jan 21, 2020 at 6:35 AM Dafna Hirschfeld wrote: > > convert the binding file rockchip-drm.txt to yaml forma

[PATCH -next 12/14] drm/amdgpu: remove unnecessary conversion to bool in athub_v2_0.c

2020-01-22 Thread Chen Zhou
Fixes coccicheck warning: ./drivers/gpu/drm/amd/amdgpu/athub_v2_0.c:80:40-45: WARNING: conversion to bool not needed here ./drivers/gpu/drm/amd/amdgpu/athub_v2_0.c:82:40-45: WARNING: conversion to bool not needed here Signed-off-by: Chen Zhou --- drivers/gpu/drm/amd/amdgpu/athub

Re: [PATCH 1/4] PM / EM: and devices to Energy Model

2020-01-22 Thread Dietmar Eggemann
On 20/01/2020 19:38, Lukasz Luba wrote: > > > On 1/20/20 6:27 PM, Dietmar Eggemann wrote: >> On 20/01/2020 16:09, Quentin Perret wrote: >>> Hey Lukasz, >>> >>> On Monday 20 Jan 2020 at 14:52:07 (+), Lukasz Luba wrote: On 1/17/20 10:54 AM, Quentin Perret wrote: [...] >> It's true that w

[PATCH v2 1/5] drm/i915/atomic: use struct drm_device logging macros

2020-01-22 Thread Wambui Karuga
Convert to the new struct drm_based logging macros to replace the printk based macros in i915/display/intel_atomic_plane.c. Signed-off-by: Wambui Karuga --- drivers/gpu/drm/i915/display/intel_atomic_plane.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/

[PATCH -next v2] backlight: qcom-wled: fix unsigned comparison to zero

2020-01-22 Thread Chen Zhou
Fixes coccicheck warning: ./drivers/video/backlight/qcom-wled.c:1104:5-15: WARNING: Unsigned expression compared with zero: string_len > 0 The unsigned variable string_len is assigned a return value from the call to of_property_count_elems_of_size(), which may return negative error code.

Re: [PATCH] drm/imx: parallel-display: Adjust bus_flags and bus_format handling

2020-01-22 Thread Marek Vasut
On 11/14/19 2:50 PM, Stefan Agner wrote: > On 2019-11-14 14:17, Marek Vasut wrote: >> The bus_flags and bus_format handling logic does not seem to cover >> all potential usecases. Specifically, this seems to fail with an >> "edt,etm0700g0edh6" display attached to an 24bit display interface, >> with

Re: [PATCH v2] dt-bindings: convert rockchip-drm.txt to rockchip-drm.yaml

2020-01-22 Thread Johan Jonker
Hi Dafna, > > > On 21.01.20 15:03, Rob Herring wrote: >> On Tue, Jan 21, 2020 at 6:35 AM Dafna Hirschfeld >> wrote: >>> >>> convert the binding file rockchip-drm.txt to yaml format. >>> This was tested and verified with: >>> make dt_binding_check >>> DT_SCHEMA_FILES=Documentation/devicetree/b

[PATCH 6/6] drm/i915/hdcp: conversion to struct drm_device based logging macros

2020-01-22 Thread Wambui Karuga
Converts various instances of the printk based logging macros in i915/display/intel_hdcp.c with the struct drm_device based macros using coccinelle. The script matches based on the existence of an existing struct drm_i915_private device: @rule1@ identifier fn, T; @@ fn(...,struct drm_i915_private

Re: [PATCH 1/4] PM / EM: and devices to Energy Model

2020-01-22 Thread Lukasz Luba
On 1/21/20 10:08 AM, Quentin Perret wrote: On Monday 20 Jan 2020 at 16:20:49 (+), Lukasz Luba wrote: On 1/20/20 3:28 PM, Quentin Perret wrote: Agreed, this looks a bit confusing. It should be trivial to make em_dev_get() (or whatever we end up calling it) work for CPUs too, though. And w

[PATCH v2 5/5] drm/i915/cdclk: use new struct drm_device logging macros

2020-01-22 Thread Wambui Karuga
Converts instances of the printk based debugging macros with the new struct drm_device based logging macros in i915/display/intel_cdclk.c. The conversion is achieved using the following coccinelle script that transforms based on the existence of a struct drm_i915_private device in the function: @r

Re: [PATCH -next] backlight: qcom-wled: fix unsigned comparison to zero

2020-01-22 Thread Bjorn Andersson
On Mon 20 Jan 05:01 PST 2020, Chen Zhou wrote: > Fixes coccicheck warning: > ./drivers/video/backlight/qcom-wled.c:1104:5-15: > WARNING: Unsigned expression compared with zero: string_len > 0 > > The unsigned variable string_len is assigned a return value from the call > to wled_configure,

[PATCH -next 13/14] drm/amdgpu: remove unnecessary conversion to bool in sdma_v4_0.c

2020-01-22 Thread Chen Zhou
Fixes coccicheck warning: ./drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c:2180:40-45: WARNING conversion to bool not needed here and many more similar messages. Signed-off-by: Chen Zhou --- drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) dif

Re: [PATCH 1/2] dmaengine: sun4i: Add support for cyclic requests with dedicated DMA

2020-01-22 Thread Stefan Mavrodiev
On 1/21/20 10:35 AM, Vinod Koul wrote: On 15-01-20, 18:07, Maxime Ripard wrote: On Wed, Jan 15, 2020 at 06:01:37PM +0530, Vinod Koul wrote: On 10-01-20, 16:11, Stefan Mavrodiev wrote: Currently the cyclic transfers can be used only with normal DMAs. They can be used by pcm_dmaengine module,

[PATCH -next 02/14] drm/amdgpu: remove unnecessary conversion to bool in vega10_ih.c

2020-01-22 Thread Chen Zhou
Fixes coccicheck warning: ./drivers/gpu/drm/amd/amdgpu/vega10_ih.c:720:40-45: WARNING: conversion to bool not needed here Signed-off-by: Chen Zhou --- drivers/gpu/drm/amd/amdgpu/vega10_ih.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/ve

Re: [PATCH v2 2/2] drm: sun4i: hdmi: Add support for sun4i HDMI encoder audio

2020-01-22 Thread Stefan Mavrodiev
On 1/21/20 8:29 PM, Maxime Ripard wrote: +Mark On Mon, Jan 20, 2020 at 02:33:26PM +0200, Stefan Mavrodiev wrote: Add HDMI audio support for the sun4i-hdmi encoder, used on the older Allwinner chips - A10, A20, A31. Most of the code is based on the BSP implementation. In it dditional formats

Re: [PATCH v2] dt-bindings: convert rockchip-drm.txt to rockchip-drm.yaml

2020-01-22 Thread Dafna Hirschfeld
On 21.01.20 15:03, Rob Herring wrote: On Tue, Jan 21, 2020 at 6:35 AM Dafna Hirschfeld wrote: convert the binding file rockchip-drm.txt to yaml format. This was tested and verified with: make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.y

Fwd: [PATCH V2 3/3] mtd: rawnand: brcmnand: Add support for flash-edu for dma transfers

2020-01-22 Thread Kamal Dasu
Legacy mips soc platforms that have controller v5.0 and 6.0 use flash-edu block for dma transfers. This change adds support for nand dma transfers using the EDU block. Signed-off-by: Kamal Dasu --- drivers/mtd/nand/raw/brcmnand/brcmnand.c | 296 ++- 1 file changed, 290 insert

Re: [v1] arm64: dts: sc7180: add display dt nodes

2020-01-22 Thread Stephen Boyd
Quoting Harigovindan P (2020-01-21 07:52:08) > diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi > b/arch/arm64/boot/dts/qcom/sc7180.dtsi > old mode 100644 > new mode 100755 > index 8011c5f..963f5c1 > --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi > @@ -115

[PATCH v2] drm/i915/display: conversion to new struct drm_device logging macros.

2020-01-22 Thread Wambui Karuga
This patch converts various instances of the printk based logging macros in drm/i915/display/intel_display.c to the new struct drm_device based logging macros. In some instances, this involves extracting the struct drm_i915_private device from various intel types and using it in the macros. v2: us

Re: [PATCH v2] dt-bindings: convert rockchip-drm.txt to rockchip-drm.yaml

2020-01-22 Thread Dafna Hirschfeld
On 21.01.20 16:11, Johan Jonker wrote: Hi Dafna, On 21.01.20 15:03, Rob Herring wrote: On Tue, Jan 21, 2020 at 6:35 AM Dafna Hirschfeld wrote: convert the binding file rockchip-drm.txt to yaml format. This was tested and verified with: make dt_binding_check DT_SCHEMA_FILES=Documentat

Re: [PATCH v3 1/4] drm: Add drm_crtc_has_vblank()

2020-01-22 Thread Daniel Vetter
On Mon, Jan 20, 2020 at 01:20:48PM +0100, Thomas Zimmermann wrote: > The new interface drm_crtc_has_vblank() return true if vblanking has > been initialized for a certain CRTC, or false otherwise. This function > will be useful for initializing CRTC state. > > Signed-off-by: Thomas Zimmermann > -

Re: [PATCH 2/2] drm/bridge: Add tc358768 driver

2020-01-22 Thread Andrzej Hajda
On 21.01.2020 16:11, Peter Ujfalusi wrote: > Hi Andrzej, > > On 16/01/2020 16.35, Andrzej Hajda wrote: >> On 17.12.2019 11:15, Peter Ujfalusi wrote: >>> Add basic support for the Toshiba TC358768 RGB to DSI bridge. >>> Not all the features of the TC358768 is implemented by the initial driver: >>> M

Re: [PATCH v2 2/2] drm: sun4i: hdmi: Add support for sun4i HDMI encoder audio

2020-01-22 Thread Maxime Ripard
On Tue, Jan 21, 2020 at 06:32:47PM +, Mark Brown wrote: > On Tue, Jan 21, 2020 at 07:29:37PM +0100, Maxime Ripard wrote: > > > > Mark, our issue here is that we have a driver tied to a device that is > > > an HDMI encoder. Obviously, we'll want to register into DRM, which is > > > what we were

Re: [PATCH v3 2/4] drm: Initialize struct drm_crtc_state.no_vblank from device settings

2020-01-22 Thread Daniel Vetter
On Mon, Jan 20, 2020 at 01:20:49PM +0100, Thomas Zimmermann wrote: > At the end of a commit, atomic helpers can generate a VBLANK event > automatically. Originally implemented for writeback connectors, the > functionality can be used by any driver and/or hardware without proper > VBLANK interrupt.

Re: [PATCH v3 1/4] drm: Add drm_crtc_has_vblank()

2020-01-22 Thread Thomas Zimmermann
Hi Am 22.01.20 um 09:31 schrieb Daniel Vetter: > On Mon, Jan 20, 2020 at 01:20:48PM +0100, Thomas Zimmermann wrote: >> The new interface drm_crtc_has_vblank() return true if vblanking has >> been initialized for a certain CRTC, or false otherwise. This function >> will be useful for initializing C

Re: [PATCH v3 1/4] drm: Add drm_crtc_has_vblank()

2020-01-22 Thread Daniel Vetter
On Wed, Jan 22, 2020 at 09:53:42AM +0100, Thomas Zimmermann wrote: > Hi > > Am 22.01.20 um 09:31 schrieb Daniel Vetter: > > On Mon, Jan 20, 2020 at 01:20:48PM +0100, Thomas Zimmermann wrote: > >> The new interface drm_crtc_has_vblank() return true if vblanking has > >> been initialized for a certa

Re: [PATCH 2/2] drm/bridge: Add tc358768 driver

2020-01-22 Thread Peter Ujfalusi
Hi Andrzej, On 22/01/2020 10.46, Andrzej Hajda wrote: +struct tc358768_priv { + struct device *dev; + struct regmap *regmap; + struct gpio_desc *reset_gpio; + struct regulator_bulk_data supplies[ARRAY_SIZE(tc358768_supplies)]; + struct clk *refclk; + +

Re: [PATCH v4] drm/i915: Don't use VBT for detecting DPCD backlight controls

2020-01-22 Thread Jani Nikula
On Fri, 17 Jan 2020, Lyude Paul wrote: > Despite the fact that the VBT appears to have a field for specifying > that a system is equipped with a panel that supports standard VESA > backlight controls over the DP AUX channel, so far every system we've > spotted DPCD backlight control support on doe

Re: [PATCH v3 18/21] drm/bridge: panel: Propage bus format/flags

2020-01-22 Thread Boris Brezillon
Hi Laurent, Sorry for the late reply. On Tue, 3 Dec 2019 12:17:30 +0200 Laurent Pinchart wrote: > Hi Boris, > > Thank you for the patch. > > On Wed, Oct 23, 2019 at 05:45:09PM +0200, Boris Brezillon wrote: > > So that the previous bridge element in the chain knows which input > > format the p

[PATCH libdrm v2] intel: drm_intel_bo_gem_create_from_* on platforms w/o HW tiling

2020-01-22 Thread Imre Deak
Platforms without a HW detiler doesn't support the get_tiling IOCTL. Fix the drm_intel_bo_gem_create_from_* functions assuming the default no-tiling, no-swizzling setting for the GEM buffer in this case. v2: - Add the missing gem handle IOCTL parameter. (Eric) Signed-off-by: Imre Deak Reviewed-b

Re: [PATCH v3 1/4] drm: Add drm_crtc_has_vblank()

2020-01-22 Thread Thomas Zimmermann
Hi Am 22.01.20 um 10:04 schrieb Daniel Vetter: > On Wed, Jan 22, 2020 at 09:53:42AM +0100, Thomas Zimmermann wrote: >> Hi >> >> Am 22.01.20 um 09:31 schrieb Daniel Vetter: >>> On Mon, Jan 20, 2020 at 01:20:48PM +0100, Thomas Zimmermann wrote: The new interface drm_crtc_has_vblank() return tru

[radeon-alex:amd-19.50 2080/2704] include/kcl/kcl_kref.h:7:28: error: redefinition of 'kref_read'

2020-01-22 Thread kbuild test robot
Hi Evan, FYI, the error/warning still remains. tree: git://people.freedesktop.org/~agd5f/linux.git amd-19.50 head: 1f30c089d757f6d88703676d913f06d8a5ef4353 commit: b35c23a557bb753b64082a4aa4057374bcbcca74 [2080/2704] drm/amdkcl: Test whether kref_read() function is available config: i386-all

Re: [PATCH] drm/etnaviv: only reject timeouts with tv_nsec >= 2 seconds

2020-01-22 Thread Guido Günther
Hi, On Tue, Jan 21, 2020 at 08:05:27PM +0100, Arnd Bergmann wrote: > On Tue, Jan 21, 2020 at 5:10 PM Lucas Stach wrote: > > > > Hi Guido, > > > > On Di, 2020-01-21 at 13:55 +0100, Guido Günther wrote: > > > Hi, > > > On Tue, Jan 21, 2020 at 12:45:25PM +0100, Arnd Bergmann wrote: > > > > As Guido G

Re: [PATCH] drm/etnaviv: only reject timeouts with tv_nsec >= 2 seconds

2020-01-22 Thread Russell King - ARM Linux admin
On Wed, Jan 22, 2020 at 11:30:34AM +0100, Guido Günther wrote: > Hi, > On Tue, Jan 21, 2020 at 08:05:27PM +0100, Arnd Bergmann wrote: > > On Tue, Jan 21, 2020 at 5:10 PM Lucas Stach wrote: > > > > > > Hi Guido, > > > > > > On Di, 2020-01-21 at 13:55 +0100, Guido Günther wrote: > > > > Hi, > > > >

Re: [PATCH -next v2] backlight: qcom-wled: fix unsigned comparison to zero

2020-01-22 Thread Daniel Thompson
On Wed, Jan 22, 2020 at 09:32:40AM +0800, Chen Zhou wrote: > Fixes coccicheck warning: > ./drivers/video/backlight/qcom-wled.c:1104:5-15: > WARNING: Unsigned expression compared with zero: string_len > 0 > > The unsigned variable string_len is assigned a return value from the call > to of_pr

[PATCH v1 4/4] drm/tiny/st7735r: No need to set ->owner for spi_register_driver()

2020-01-22 Thread Andy Shevchenko
The spi_register_driver() will set the ->owner member to THIS_MODULE. Signed-off-by: Andy Shevchenko --- drivers/gpu/drm/tiny/st7735r.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/tiny/st7735r.c b/drivers/gpu/drm/tiny/st7735r.c index a844cde6d14a..3cd9b8d9888d 100644 --- a

[PATCH v1 1/4] drm/tiny/repaper: Make driver OF-independent

2020-01-22 Thread Andy Shevchenko
There is one OF call in the driver that limits its area of use. Replace it to generic device_get_match_data() and get rid of OF dependency. While here, cast SPI driver data to certain enumerator type. Signed-off-by: Andy Shevchenko --- drivers/gpu/drm/tiny/repaper.c | 11 ++- 1 file cha

[PATCH v3 1/3] dt-bindings: drm/bridge: Document Cadence MHDP bridge bindings in yaml format

2020-01-22 Thread Yuti Amonkar
Document the bindings used for the Cadence MHDP DPI/DP bridge in yaml format. Signed-off-by: Yuti Amonkar --- .../bindings/display/bridge/cdns,mhdp.yaml | 131 + 1 file changed, 131 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/bridge/cd

[PATCH v1 2/4] drm/tiny/repaper: No need to set ->owner for spi_register_driver()

2020-01-22 Thread Andy Shevchenko
The spi_register_driver() will set the ->owner member to THIS_MODULE. Signed-off-by: Andy Shevchenko --- drivers/gpu/drm/tiny/repaper.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/tiny/repaper.c b/drivers/gpu/drm/tiny/repaper.c index fd9e95ce3201..4a497203923f 100644 --- a

[PATCH v3 0/3] drm: Add support for Cadence MHDP DPI/DP bridge and J721E wrapper.

2020-01-22 Thread Yuti Amonkar
This patch series adds new DRM driver for Cadence Display Port. The Cadence Display Port is also referred as MHDP (Mobile High Definition Link, High-Definition Multimedia Interface Display Port) Cadence Display Port complies with VESA DisplayPort (DP) and embedded Display Port (eDP) standards. This

[PATCH v1 3/4] drm/tiny/st7735r: Make driver OF-independent

2020-01-22 Thread Andy Shevchenko
There is one OF call in the driver that limits its area of use. Replace it to generic device_get_match_data() and get rid of OF dependency. Signed-off-by: Andy Shevchenko --- drivers/gpu/drm/tiny/st7735r.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/tiny

[PATCH v3 3/3] drm/mhdp: add j721e wrapper

2020-01-22 Thread Yuti Amonkar
Add j721e wrapper for mhdp, which sets up the clock and data muxes. Signed-off-by: Yuti Amonkar --- drivers/gpu/drm/bridge/Kconfig | 12 + drivers/gpu/drm/bridge/Makefile | 3 ++ drivers/gpu/drm/bridge/cdns-mhdp-j721e.c | 79 drivers/gpu/d

[PATCH v3 2/3] drm: bridge: Add support for Cadence MHDP DPI/DP bridge

2020-01-22 Thread Yuti Amonkar
This patch adds new DRM driver for Cadence MHDP DPTX IP used on J721e SoC. MHDP DPTX IP is the component that complies with VESA DisplayPort (DP) and embedded Display Port (eDP) standards.It integrates uCPU running the embedded Firmware(FW) interfaced over APB interface. Basically, it takes a DPI s

[PATCH v7 10/12] drm/bridge: panel: Propage bus format/flags

2020-01-22 Thread Boris Brezillon
So that the previous bridge element in the chain knows which input format the panel bridge expects. Signed-off-by: Boris Brezillon --- Changes in v7: * Set atomic state hooks explicitly Changes in v3: * Adjust things to match the new bus-format negotiation approach * Use drm_atomic_helper_bridge

[PATCH v7 06/12] drm/bridge: Add the necessary bits to support bus format negotiation

2020-01-22 Thread Boris Brezillon
drm_bridge_state is extended to describe the input and output bus configurations. These bus configurations are exposed through the drm_bus_cfg struct which encodes the configuration of a physical bus between two components in an output pipeline, usually between two bridges, an encoder and a bridge,

[PATCH v7 00/12] drm: Add support for bus-format negotiation

2020-01-22 Thread Boris Brezillon
Hello, This patch series aims at adding support for runtime bus-format negotiation between all elements of the 'encoder -> bridges -> connector/display' section of the pipeline. In order to support that, we need drm bridges to fully take part in the atomic state validation process, which requires

[PATCH v7 05/12] drm/bridge: Add an ->atomic_check() hook

2020-01-22 Thread Boris Brezillon
So that bridge drivers have a way to check/reject an atomic operation. The drm_atomic_bridge_chain_check() (which is just a wrapper around the ->atomic_check() hook) is called in place of drm_bridge_chain_mode_fixup() (when ->atomic_check() is not implemented, the core falls back on ->mode_fixup(),

[PATCH v7 09/12] dt-bindings: display: bridge: lvds-codec: Add new bus-width prop

2020-01-22 Thread Boris Brezillon
Add the bus-width property to describe the input bus format. Signed-off-by: Boris Brezillon --- Changes in v7: * Rebase on top of lvds-codec changes * Drop the data-mapping property Changes in v3: * New patch --- .../devicetree/bindings/display/bridge/lvds-codec.yaml| 8 1 file cha

[PATCH v7 11/12] drm/panel: simple: Fix the lt089ac29000 bus_format

2020-01-22 Thread Boris Brezillon
The lt089ac29000 panel is an LVDS panel, not a DPI one. Fix the definition to reflect this fact. Signed-off-by: Boris Brezillon Suggested-by: Laurent Pinchart --- Changes in v7: * New patch --- drivers/gpu/drm/panel/panel-simple.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --gi

[PATCH v7 08/12] drm/bridge: lvds-codec: Implement basic bus format negotiation

2020-01-22 Thread Boris Brezillon
Some DPI -> LVDS encoders might support several input bus width. Add a DT property to describe the bus width used on a specific design. Signed-off-by: Boris Brezillon --- Changes in v7: * Fix a use-after-release problem * Get rid of the data-mapping parsing * Use kmalloc instead of kcalloc. Chan

  1   2   >