RE: [PATCH] drm: Inject a cond_resched() into long drm_clflush_sg()

2020-01-17 Thread David Laight
From: David Laight > Sent: 16 January 2020 14:41 > > I'll do some measurements later this afternoon. > > This is an Ivy bridge cpu, so clflush (not clflushopt). > With a cond_resched for every page I get: > (Note these calls are every 10 seconds) For comparison some times booted with the orig

[PATCH 3/4] thermal: devfreq_cooling: Refactor code and switch to use Energy Model

2020-01-17 Thread lukasz . luba
From: Lukasz Luba The overhauled Energy Model (EM) framework support also devfreq devices. The unified API interface of the EM can be used in the thermal subsystem to not duplicate code. The power table now is taken from EM structure and there is no need to maintain calculation for it locally. In

[PATCH 2/4] OPP: change parameter to device pointer in dev_pm_opp_of_register_em()

2020-01-17 Thread lukasz . luba
From: Lukasz Luba Drop the CPU specific interface with cpumask and switch to struct device. The Energy Model framework supports both: CPUs and devfreq devices. The new interface provides easy way to create a Energy Model (EM), which then might be used in i.e. thermal subsystem. Signed-off-by: Lu

[PATCH -next] drm/nv04/disp: remove set but not used variable 'width'

2020-01-17 Thread YueHaibing
drivers/gpu/drm/nouveau/dispnv04/arb.c: In function nv04_calc_arb: drivers/gpu/drm/nouveau/dispnv04/arb.c:56:21: warning: variable width set but not used [-Wunused-but-set-variable] 'width' is never used, so remove it. Reported-by: Hulk Robot Signed-off-by: YueHaibing --- drivers/gpu/drm/nouv

[PATCH 3/4] drm/i915/display: conversion to new logging macros part 3

2020-01-17 Thread Wambui Karuga
This patch continues the conversion of printk based logging macros to the new struct drm_based logging macros in drm/i915/display/intel_display.c. This conversion was done using the following coccinelle script that matches the existence of a straightforward struct drm_i915_private in the functions:

[PATCH] drm/i915: Fix i915_error_state_store error defination

2020-01-17 Thread Zhang Xiaoxu
Since commit 742379c0c4001 ("drm/i915: Start chopping up the GPU error capture"), function 'i915_error_state_store' was defined and used with only one parameter. But if no 'CONFIG_DRM_I915_CAPTURE_ERROR', this function was defined with two parameter. This may lead compile error. This patch fix it

RE: [PATCH] drm: Inject a cond_resched() into long drm_clflush_sg()

2020-01-17 Thread David Laight
From: Chris Wilson > Sent: 16 January 2020 12:29 > > Quoting David Laight (2020-01-16 12:26:45) > > However there is a call from __i915_gem_objet_set_pages() that > > is preceded by a lockdep_assert_held() check - so mustn't sleep. > > That is a mutex; it's allowed to sleep. The might_sleep() he

[PATCH -next] video: fbdev: pxa168fb: remove unnecessary platform_get_irq

2020-01-17 Thread YueHaibing
commit 640ba2444fa9 ("drivers/video/pxa168fb.c: use devm_ functions") left behind this, it can be removed. Signed-off-by: YueHaibing --- drivers/video/fbdev/pxa168fb.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/video/fbdev/pxa168fb.c b/drivers/video/fbdev/pxa168fb.c index 706c

Re: [PATCH 1/2] drm/i915: Add mechanism to submit a context WA on ring submission

2020-01-17 Thread Mika Kuoppala
Mika Kuoppala writes: >Subject: Re: [PATCH 1/2] drm/i915: Add mechanism to submit a context WA >on ring submission I forgot to add RFC into patch subject. This should carry the RFC status as it is v2 on a RFC patch. This patch squashes Chris Wilson's ctx switch optimization and the development

[PATCH 1/4] drm/i915/display: conversion to new logging macros part 1

2020-01-17 Thread Wambui Karuga
This is the first patch that starts the conversion of the printk based logging macros in drm/i915/display/intel_display.c to the new struct drm_device based logging macros. This conversion was done using the following coccinelle script that matches based on the existence of a struct drm_i915_privat

[PATCH 0/4] Add support for devices in the Energy Model

2020-01-17 Thread lukasz . luba
From: Lukasz Luba Hi all, This patch set introduces support for devices in the Energy Model (EM) framework. It will unify the power model for thermal subsystem and make it simpler. The 1st patch refactors EM framework and adds support for devices. The 2nd patch changes dev_pm_opp_of_register_em

[PATCH 4/4] drm/panfrost: Register to the Energy Model with devfreq device

2020-01-17 Thread lukasz . luba
From: Lukasz Luba Let Panfrost devfreq device use the Energy Model (EM). The EM can be used in thermal subsystem (devfreq_cooling) for calculating the used power. Signed-off-by: Lukasz Luba --- drivers/gpu/drm/panfrost/panfrost_devfreq.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/d

Re: [RFC PATCH 4/4] drm/i915/gvt: move public gvt headers out into global include

2020-01-17 Thread Julian Stecklina
Hi Greg, On Thu, 2020-01-16 at 15:23 +0100, Greg KH wrote: > On Thu, Jan 16, 2020 at 03:13:01PM +0100, Julian Stecklina wrote: > > Hi Greg, Christoph, > > > > On Wed, 2020-01-15 at 16:22 +0100, Greg KH wrote: > > > On Thu, Jan 09, 2020 at 07:13:57PM +0200, Julian Stecklina wrote: > > > > Now that

[PATCH] drm/scheduler: fix documentation by replacing rq_list with sched_list

2020-01-17 Thread Nirmoy Das
This also replaces old artifacts with a correct one in drm_sched_entity_init() declaration Signed-off-by: Nirmoy Das Reviewed-by: Christian König --- drivers/gpu/drm/scheduler/sched_entity.c | 2 +- include/drm/gpu_scheduler.h | 10 +- 2 files changed, 6 insertions(+), 6 d

[PATCH 1/2] drm/i915: Add mechanism to submit a context WA on ring submission

2020-01-17 Thread Mika Kuoppala
This patch adds framework to submit an arbitrary batchbuffer on each context switch to clear residual state for render engine on Gen7/7.5 devices. The idea of always emitting the context and vm setup around each request is primary to make reset recovery easy, and not require rewriting the ringbuff

Re: [PATCH v3 2/2] drm/sun4i: Add alpha property for sun8i and sun50i VI layer

2020-01-17 Thread Jernej Škrabec
Hi! Sorry for late reply. Dne petek, 03. januar 2020 ob 22:19:01 CET je roman.stratiie...@globallogic.com napisal(a): > From: Roman Stratiienko > > DE3.0 VI layers supports plane-global alpha channel. > DE2.0 FCC block have GLOBAL_ALPHA register that can be used as alpha source > for blender.

[PATCH 1/2] drm/i915: Add mechanism to submit a context WA on ring submission

2020-01-17 Thread Mika Kuoppala
This patch adds framework to submit an arbitrary batchbuffer on each context switch to clear residual state for render engine on Gen7/7.5 devices. The idea of always emitting the context and vm setup around each request is primary to make reset recovery easy, and not require rewriting the ringbuff

[PATCH 1/4] PM / EM: and devices to Energy Model

2020-01-17 Thread lukasz . luba
From: Lukasz Luba Add support of other devices into the Energy Model framework not only the CPUs. Change the interface to be more unified which can handle other devices as well. Signed-off-by: Lukasz Luba --- Documentation/power/energy-model.rst | 67 +++-- drivers/cpufreq/scmi-cpufreq.c

[PATCH] MAINTAINERS: nouveau mailing list is moderated

2020-01-17 Thread Randy Dunlap
From: Randy Dunlap Mark the nouveau@ mailing list as moderated for non-subscribers. Signed-off-by: Randy Dunlap --- MAINTAINERS |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- linux-next-20200116.orig/MAINTAINERS +++ linux-next-20200116/MAINTAINERS @@ -5315,7 +5315,7 @@ F:

Re: linux-next: Tree for Jan 16 (drivers/gpu/drm/nouveau/nvkm/subdev/ltc/gp10b.c)

2020-01-17 Thread Randy Dunlap
On 1/16/20 1:17 AM, Stephen Rothwell wrote: > Hi all, > > Changes since 20200115: > > New tree: zonefs > > The sound-asoc tree lost its build failure. > > The net-next tree gained a build failure for which I reverted a commit. > > The keys tree still had build failures so I used the version fr

[PATCH 0/4] drm/i915/display: conversion to new logging macros.

2020-01-17 Thread Wambui Karuga
This series converts the printk based logging macros in drm/i915/display/intel_display.c to the new struct drm_device based logging macros. This change was split into four for manageability and due to the size of drm/i915/display/intel_display.c. Wambui Karuga (4): drm/i915/display: conversion t

[PATCH 2/4] drm/i915/display: conversion to new logging macros part 2

2020-01-17 Thread Wambui Karuga
This patch continues the conversion of printk based logging macros to the new struct drm_based logging macros in drm/i915/display/intel_display.c. This conversion was done using the following coccinelle script that matches the existence of a straightforward struct drm_i915_private in the functions:

[PATCH 4/4] drm/i915/display: convert to new logging macros part 4.

2020-01-17 Thread Wambui Karuga
This patch provides the final conversion of most of the printk based logging macros instances in drm/i915/display/intel_display.c to the struct drm_device based logging macros. The struct drm_i915_private device is extracted from various intel types and used in the new logging macros. Signed-off-b

RE: [PATCH] drm: Inject a cond_resched() into long drm_clflush_sg()

2020-01-17 Thread David Laight
> I'll do some measurements later this afternoon. This is an Ivy bridge cpu, so clflush (not clflushopt). With a cond_resched for every page I get: (Note these calls are every 10 seconds) # tracer: function_graph # # CPU DURATION FUNCTION CALLS # | | |

RE: [PATCH] drm: Inject a cond_resched() into long drm_clflush_sg()

2020-01-17 Thread David Laight
From: Chris Wilson > Sent: 16 January 2020 07:40 > Quoting Daniel Vetter (2020-01-16 06:52:42) > > On Wed, Jan 15, 2020 at 08:52:45PM +, Chris Wilson wrote: > > > Since we may try and flush the cachelines associated with large buffers > > > (an 8K framebuffer is about 128MiB, even before we tr

Re: [RFC PATCH 4/4] drm/i915/gvt: move public gvt headers out into global include

2020-01-17 Thread Julian Stecklina
Hi Greg, Christoph, On Wed, 2020-01-15 at 16:22 +0100, Greg KH wrote: > On Thu, Jan 09, 2020 at 07:13:57PM +0200, Julian Stecklina wrote: > > Now that the GVT interface to hypervisors does not depend on i915/GVT > > internals anymore, we can move the headers to the global include/. > > > > This m

[PATCH -next] drm/nouveau: fix build error without CONFIG_IOMMU_API

2020-01-17 Thread Chen Zhou
If CONFIG_IOMMU_API is n, build fails: vers/gpu/drm/nouveau/nvkm/subdev/ltc/gp10b.c:37:9: error: implicit declaration of function dev_iommu_fwspec_get; did you mean iommu_fwspec_free? [-Werror=implicit-function-declaration] spec = dev_iommu_fwspec_get(device->dev); ^~~

[PATCH -next] drm/nouveau/kms/nv50: remove set but not unused variable 'nv_connector'

2020-01-17 Thread YueHaibing
drivers/gpu/drm/nouveau/dispnv50/disp.c: In function nv50_pior_enable: drivers/gpu/drm/nouveau/dispnv50/disp.c:1672:28: warning: variable nv_connector set but not used [-Wunused-but-set-variable] commit ac2d9275f371 ("drm/nouveau/kms/nv50-: Store the bpc we're using in nv50_head_atom") left behin

Re: [PATCH v6 0/6] Add dual-LVDS panel support to EK874

2020-01-17 Thread Geert Uytterhoeven
Hi Laurent, (woops, forgot to press sent) On Wed, Dec 18, 2019 at 12:13 AM Laurent Pinchart wrote: > On Tue, Dec 17, 2019 at 01:45:55PM +, Fabrizio Castro wrote: > > this series adds support for dual-LVDS panel IDK-2121WR > > from Advantech: > > https://buy.advantech.eu/Displays/Embedded-LCD

Re: [PATCH v6 0/6] Add dual-LVDS panel support to EK874

2020-01-17 Thread Sam Ravnborg
Hi Fabrizio/Laurent/Geert. (Thanks Geert, I recall I never replied to this mail). On Fri, Jan 17, 2020 at 09:47:22AM +0100, Geert Uytterhoeven wrote: > Hi Laurent, > > (woops, forgot to press sent) > > On Wed, Dec 18, 2019 at 12:13 AM Laurent Pinchart > wrote: > > On Tue, Dec 17, 2019 at 01:45

Re: [PATCH 1/1] drm/bridge: anx78xx: fix integer type used for storing dp link rate

2020-01-17 Thread Andrzej Hajda
On 09.01.2020 09:48, Tobias Schramm wrote: > commit ff1e8fb68ea0 ("drm/bridge: analogix-anx78xx: Avoid drm_dp_link > helpers") > changed the link training logic to remove use of drm_dp_link helpers. However > the new logic stores the maximum link rate in a u8, overflowing it. > This commit changes

Re: [PATCH] drm/bridge: tfp410: add pclk limits

2020-01-17 Thread Andrzej Hajda
On 13.01.2020 14:45, Tomi Valkeinen wrote: > Add pixel clock limits to the driver as per TFP410 datasheet: min 25MHz, > max 165MHz. > > Signed-off-by: Tomi Valkeinen Reviewed-by: Andrzej Hajda  -- Regards Andrzej > --- > drivers/gpu/drm/bridge/ti-tfp410.c | 10 ++ > 1 file changed, 10

[Bug 206231] New: R9 280X low performance with all games

2020-01-17 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=206231 Bug ID: 206231 Summary: R9 280X low performance with all games Product: Drivers Version: 2.5 Kernel Version: 5.4.0-2-amd64 Hardware: x86-64 OS: Linux Tree: Ma

Re: [RESEND v3 2/2] drm: bridge: adv7511: Add support for ADV7535

2020-01-17 Thread Andrzej Hajda
On 07.01.2020 14:34, Bogdan Togorean wrote: > ADV7535 is a DSI to HDMI bridge chip like ADV7533 but it allows > 1080p@60Hz. v1p2 is fixed to 1.8V on ADV7535 but on ADV7533 can be 1.2V > or 1.8V and is configurable in a register. > > Signed-off-by: Bogdan Togorean > --- > drivers/gpu/drm/bridge/ad

Re: [RESEND v3 2/2] drm: bridge: adv7511: Add support for ADV7535

2020-01-17 Thread Andrzej Hajda
On 17.01.2020 11:27, Andrzej Hajda wrote: > On 07.01.2020 14:34, Bogdan Togorean wrote: >> ADV7535 is a DSI to HDMI bridge chip like ADV7533 but it allows >> 1080p@60Hz. v1p2 is fixed to 1.8V on ADV7535 but on ADV7533 can be 1.2V >> or 1.8V and is configurable in a register. >> >> Signed-off-by: Bo

Re: [PATCH v3 4/5] drm/i915: Don't use VBT for detecting DPCD backlight controls

2020-01-17 Thread Jani Nikula
On Thu, 16 Jan 2020, Lyude Paul wrote: > Despite the fact that the VBT appears to have a field for specifying > that a system is equipped with a panel that supports standard VESA > backlight controls over the DP AUX channel, so far every system we've > spotted DPCD backlight control support on doe

Re: [PATCH v3] drm/panfrost: Add the panfrost_gem_mapping concept

2020-01-17 Thread Steven Price
On 16/01/2020 02:15, Rob Herring wrote: > From: Boris Brezillon > > With the introduction of per-FD address space, the same BO can be mapped > in different address space if the BO is globally visible (GEM_FLINK) > and opened in different context or if the dmabuf is self-imported. The > current im

Re: [PATCH v3 4/5] drm/i915: Don't use VBT for detecting DPCD backlight controls

2020-01-17 Thread Jani Nikula
On Fri, 17 Jan 2020, Jani Nikula wrote: > On Thu, 16 Jan 2020, Lyude Paul wrote: >> Despite the fact that the VBT appears to have a field for specifying >> that a system is equipped with a panel that supports standard VESA >> backlight controls over the DP AUX channel, so far every system we've >

Re: [PATCH] drm/i915: Fix i915_error_state_store error defination

2020-01-17 Thread Andi Shyti
Hi Zhang, On Fri, Jan 17, 2020 at 03:34:36PM +0800, Zhang Xiaoxu wrote: > Since commit 742379c0c4001 ("drm/i915: Start chopping up the GPU error > capture"), function 'i915_error_state_store' was defined and used with > only one parameter. > > But if no 'CONFIG_DRM_I915_CAPTURE_ERROR', this funct

Re: [PATCH] drm/bridge: tfp410: add pclk limits

2020-01-17 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Mon, Jan 13, 2020 at 03:45:28PM +0200, Tomi Valkeinen wrote: > Add pixel clock limits to the driver as per TFP410 datasheet: min 25MHz, > max 165MHz. > > Signed-off-by: Tomi Valkeinen > --- > drivers/gpu/drm/bridge/ti-tfp410.c | 10 ++ > 1 file chan

Re: [PATCH] drm/i915: Fix i915_error_state_store error defination

2020-01-17 Thread Jani Nikula
On Fri, 17 Jan 2020, Andi Shyti wrote: > Hi Zhang, > > On Fri, Jan 17, 2020 at 03:34:36PM +0800, Zhang Xiaoxu wrote: >> Since commit 742379c0c4001 ("drm/i915: Start chopping up the GPU error >> capture"), function 'i915_error_state_store' was defined and used with >> only one parameter. >> >> But

re: drm/amd/display: make PSR static screen entry within 30 ms

2020-01-17 Thread Colin Ian King
Hi, Static analysis with Coverity has detected a division by zero in the following commit: commit 5b5abe9526073ccbf3032d27b5864520829cdd9c Author: Anthony Koo Date: Mon Dec 9 17:26:34 2019 -0500 drm/amd/display: make PSR static screen entry within 30 ms Specifically: unsigned int

Re: [PATCH v2 19/21] drm/vkms: Convert to CRTC VBLANK callbacks

2020-01-17 Thread Thomas Zimmermann
Hi Am 16.01.20 um 00:18 schrieb Rodrigo Siqueira: > Hi, > > Thanks for the patch, I reviewed and tested it. Everything looks fine > for VKMS. > > Reviewed-by: Rodrigo Siqueira > Tested-by: Rodrigo Siqueira Thanks a lot. Best regards Thomas > > On 01/15, Thomas Zimmermann wrote: >> VBLANK c

[PATCH][next] drm/amd/display: fix for-loop with incorrectly sized loop counter

2020-01-17 Thread Colin King
From: Colin Ian King A for-loop is iterating from 0 up to 1000 however the loop variable count is a u8 and hence not large enough. Fix this by making count an int. Also remove the redundant initialization of count since this is never used and add { } on the loop statement make the loop block cle

[Bug 206017] Kernel 5.4.x unusable with GUI due to crashes (some hard)

2020-01-17 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=206017 Paul (paul.e.hi...@outlook.com) changed: What|Removed |Added CC||paul.e.hi...@outlook.com

Re: [PATCH 1/4] drm/mst: Don't do atomic checks over disabled managers

2020-01-17 Thread Mikita Lipski
Thanks for the catch! Makes sense to skip disabled managers there, but I wonder why it didn't cause a crash with amdgpu. Anyways looks good to me. Acked-by: Mikita Lipski On 1/16/20 8:58 PM, José Roberto de Souza wrote: When a main MST port is disconnected drivers should call drm_dp_mst_topol

Re: [PATCH 0/4] drm/i915/display: conversion to new logging macros.

2020-01-17 Thread Jani Nikula
On Thu, 16 Jan 2020, Wambui Karuga wrote: > This series converts the printk based logging macros in > drm/i915/display/intel_display.c to the new struct drm_device based > logging macros. This change was split into four for manageability and > due to the size of drm/i915/display/intel_display.c.

[Bug 206231] R9 280X low performance with all games

2020-01-17 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=206231 Alex Deucher (alexdeuc...@gmail.com) changed: What|Removed |Added CC||alexdeuc...@gmail.c

Re: [PATCH] drm/i915: Fix i915_error_state_store error defination

2020-01-17 Thread Andi Shyti
Hi Jani, > >> Reported-by: Hulk Robot > > > > I've never been a fan of non human accounts, we had this discussion > > already in a different mailing list. Could you please find a > > different way of giving credit to your CI system? > > I don't actually mind for Reported-by credits. The history

Re: [PATCH 1/2] video: fbdev: sh_mobile_lcdcfb: fix sparse warnings about using incorrect types

2020-01-17 Thread Geert Uytterhoeven
On Thu, Jan 16, 2020 at 3:51 PM Bartlomiej Zolnierkiewicz wrote: > Use ->screen_buffer instead of ->screen_base to fix sparse warnings. > > [ Please see commit 17a7b0b4d974 ("fb.h: Provide alternate screen_base > pointer") for details. ] > > Signed-off-by: Bartlomiej Zolnierkiewicz Reviewed-by

Re: [PATCH 2/2] video: fbdev: sh_mobile_lcdcfb: add COMPILE_TEST support

2020-01-17 Thread Geert Uytterhoeven
On Thu, Jan 16, 2020 at 3:52 PM Bartlomiej Zolnierkiewicz wrote: > Add COMPILE_TEST support to sh_mobile_lcdcfb driver for better compile > testing coverage. > > Signed-off-by: Bartlomiej Zolnierkiewicz Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geer

Re: [PATCH] drm/i915: Fix i915_error_state_store error defination

2020-01-17 Thread Jani Nikula
On Fri, 17 Jan 2020, Andi Shyti wrote: > Hi Jani, > >> >> Reported-by: Hulk Robot >> > >> > I've never been a fan of non human accounts, we had this discussion >> > already in a different mailing list. Could you please find a >> > different way of giving credit to your CI system? >> >> I don't a

Re: [PATCH][next] drm/amd/display: fix for-loop with incorrectly sized loop counter

2020-01-17 Thread walter harms
Am 17.01.2020 14:33, schrieb Colin King: > From: Colin Ian King > > A for-loop is iterating from 0 up to 1000 however the loop variable count > is a u8 and hence not large enough. Fix this by making count an int. > Also remove the redundant initialization of count since this is never used > a

[Bug 206231] R9 280X low performance with all games

2020-01-17 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=206231 --- Comment #2 from kentosama (kentos...@whiteninjastudio.com) --- Hello, with the radeonsi driver, the performance is lower than the amdgpu driver. On the same scene in Tomb Raider, the graphics card displays ~ 10fps. I have a lower score with g

[Bug 206231] R9 280X low performance with all games

2020-01-17 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=206231 --- Comment #3 from Alex Deucher (alexdeuc...@gmail.com) --- radeonsi is the mesa OpenGL driver and runs over both radeon and amdgpu. Are you actually using the radeon kernel driver? -- You are receiving this mail because: You are watching the

Re: [PATCH v9 12/18] drm/dp_mst: Add branch bandwidth validation to MST atomic check

2020-01-17 Thread Sean Paul
On Fri, Dec 13, 2019 at 3:09 PM wrote: > > From: Mikita Lipski > Hi Mikita, Unfortunately this patch causes a crash on my i915 device when I unplug my MST hub. The panic is below. [ 38.514014] BUG: kernel NULL pointer dereference, address: 0030 [ 38.521801] #PF: supervisor read

[Bug 206231] R9 280X low performance with all games

2020-01-17 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=206231 --- Comment #4 from Michel Dänzer (mic...@daenzer.net) --- (In reply to Alex Deucher from comment #3) > Are you actually using the radeon kernel driver? "DRM 2.50.0" says yes. :) -- You are receiving this mail because: You are watching the assi

Re: [PATCH v9 12/18] drm/dp_mst: Add branch bandwidth validation to MST atomic check

2020-01-17 Thread Mikita Lipski
On 1/17/20 10:09 AM, Sean Paul wrote: On Fri, Dec 13, 2019 at 3:09 PM wrote: From: Mikita Lipski Hi Mikita, Unfortunately this patch causes a crash on my i915 device when I unplug my MST hub. The panic is below. Hi Sean, I thought this issue was fixed by Wayne Lin in https://patchwo

[Bug 206231] R9 280X low performance with all games

2020-01-17 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=206231 --- Comment #5 from kentosama (kentos...@whiteninjastudio.com) --- (In reply to Alex Deucher from comment #3) > radeonsi is the mesa OpenGL driver and runs over both radeon and amdgpu. > Are you actually using the radeon kernel driver? Yes, i us

[PATCH v3 0/2] drm/modes: Apply video parameters with only reflect option

2020-01-17 Thread Stephan Gerhold
At the moment, video mode parameters like video=540x960,reflect_x, (without rotation set) are not taken into account when applying the mode in drm_client_modeset.c. One of the reasons for this is that the calculation that combines the panel_orientation with cmdline->rotation_reflection does not ha

[PATCH v3 1/2] drm/modes: Make sure to parse valid rotation value from cmdline

2020-01-17 Thread Stephan Gerhold
A rotation value should have exactly one rotation angle. At the moment there is no validation for this when parsing video= parameters from the command line. This causes problems later on when we try to combine the command line rotation with the panel orientation. To make sure that we generate a va

[PATCH v3 2/2] drm/modes: Allow DRM_MODE_ROTATE_0 when applying video mode parameters

2020-01-17 Thread Stephan Gerhold
At the moment, only DRM_MODE_ROTATE_180 is allowed when we try to apply the rotation from the video mode parameters. It is also useful to allow DRM_MODE_ROTATE_0 in case there is only a reflect option in the video mode parameter (e.g. video=540x960,reflect_x). DRM_MODE_ROTATE_0 means "no rotation"

Re: [PATCH v9 12/18] drm/dp_mst: Add branch bandwidth validation to MST atomic check

2020-01-17 Thread Sean Paul
On Fri, Jan 17, 2020 at 10:26 AM Mikita Lipski wrote: > > > > On 1/17/20 10:09 AM, Sean Paul wrote: > > On Fri, Dec 13, 2019 at 3:09 PM wrote: > >> > >> From: Mikita Lipski > >> > > > > Hi Mikita, > > Unfortunately this patch causes a crash on my i915 device when I > > unplug my MST hub. The pan

Re: [PATCH 0/5] Use new logging macros in drm/i915

2020-01-17 Thread Jani Nikula
On Thu, 09 Jan 2020, Wambui Karuga wrote: > This patchset continues the conversion to using the new struct > drm_device based logging macros in drm/i915. Pushed to drm-intel-next-queued, thanks for the patches. BR, Jani. > > Wambui Karuga (5): > drm/i915: conversion to new logging macros in i

Re: [PATCH AUTOSEL 5.4 002/205] drm/panfrost: Add missing check for pfdev->regulator

2020-01-17 Thread Steven Price
On Thu, Jan 16, 2020 at 04:39:37PM +, Sasha Levin wrote: > From: Steven Price > > [ Upstream commit 52282163dfa651849e905886845bcf6850dd83c2 ] This commit is effectively already in 5.4. Confusingly there were two versions of this upstream: 52282163dfa6 ("drm/panfrost: Add missing check for

Re: [PATCH v2] drm/dp_mst: Remove VCPI while disabling topology mgr

2020-01-17 Thread Sean Paul
On Mon, Dec 9, 2019 at 12:56 AM Lin, Wayne wrote: > > > > > -Original Message- > > From: Lyude Paul > > Sent: Saturday, December 7, 2019 3:57 AM > > To: Lin, Wayne ; dri-devel@lists.freedesktop.org; > > amd-...@lists.freedesktop.org > > Cc: Kazlauskas, Nicholas ; Wentland, Harry > > ; Zuo

[Bug 206141] VCE UVD ring test failed -110

2020-01-17 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=206141 --- Comment #7 from Janpieter Sollie (janpieter.sol...@dommel.be) --- Created attachment 286863 --> https://bugzilla.kernel.org/attachment.cgi?id=286863&action=edit dmesg with 2 GPUs OK, so this definitely looks like a HW failure, also tried to

Re: [PATCH AUTOSEL 5.4 002/205] drm/panfrost: Add missing check for pfdev->regulator

2020-01-17 Thread Greg KH
On Fri, Jan 17, 2020 at 04:12:27PM +, Steven Price wrote: > On Thu, Jan 16, 2020 at 04:39:37PM +, Sasha Levin wrote: > > From: Steven Price > > > > [ Upstream commit 52282163dfa651849e905886845bcf6850dd83c2 ] > > This commit is effectively already in 5.4. Confusingly there were two > ver

Re: [Bug 206231] R9 280X low performance with all games

2020-01-17 Thread sylvain . bertrand
Owner and user of tahiti parts on amdgpu with a state of the art gfx stack poping in. I own "rise of the tomb raider" which gnu/linux port is vulkan only, and vulkan is only available with the "amdgpu" kernel module (as far as I know). I have not bought "shadow of the tomb raider", which is vulka

[Bug 206231] R9 280X low performance with all games

2020-01-17 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=206231 --- Comment #6 from Sylvain BERTRAND (sylvain.bertr...@gmail.com) --- Owner and user of tahiti parts on amdgpu with a state of the art gfx stack poping in. I own "rise of the tomb raider" which gnu/linux port is vulkan only, and vulkan is only av

Re: [PATCH v9 1/5] dt-bindings: display: panel: Add boe tv101wum-n16 panel bindings

2020-01-17 Thread Sam Ravnborg
Hi Jitao. Looks good, much better than the individual files. Rob Herring is still listed as maintainer which I questioned in last feedback. With this resolved (kept only if Rob confirms), this is Reviewed-by: Sam Ravnborg On Thu, Jan 16, 2020 at 10:15:07AM +0800, Jitao Shi wrote: > Add document

Re: [PATCH v2] drm/msm: Add syncobj support.

2020-01-17 Thread Jordan Crouse
On Fri, Jan 17, 2020 at 12:04:17AM +0100, Bas Nieuwenhuizen wrote: > This > > 1) Enables core DRM syncobj support. > 2) Adds options to the submission ioctl to wait/signal syncobjs. > > Just like the wait fence fd, this does inline waits. Using the > scheduler would be nice but I believe it is ou

Re: [PATCH v9 1/5] dt-bindings: display: panel: Add boe tv101wum-n16 panel bindings

2020-01-17 Thread Sam Ravnborg
Hi Jitao. On Fri, Jan 17, 2020 at 07:08:17PM +0100, Sam Ravnborg wrote: > Hi Jitao. > > Looks good, much better than the individual files. > Rob Herring is still listed as maintainer which I questioned in last > feedback. > > With this resolved (kept only if Rob confirms), this is > Reviewed-by:

Re: [PATCH v9 0/5] add driver for "boe, tv101wum-nl6", "boe, tv101wum-n53", "auo, kd101n80-45na" and "auo, b101uan08.3" panels

2020-01-17 Thread Sam Ravnborg
Hi Jitao. Thanks for your perseverance on this. With the minor issue on the binding file resolved everything is now fine and patches are all applied to drm-misc-next. Thanks, Sam On Thu, Jan 16, 2020 at 10:15:06AM +0800, Jitao Shi wrote: > Changes since v8: > - merge the panel document

Re: [PATCH v2] drm/msm: Add syncobj support.

2020-01-17 Thread Bas Nieuwenhuizen
On Fri, Jan 17, 2020 at 7:17 PM Jordan Crouse wrote: > > On Fri, Jan 17, 2020 at 12:04:17AM +0100, Bas Nieuwenhuizen wrote: > > This > > > > 1) Enables core DRM syncobj support. > > 2) Adds options to the submission ioctl to wait/signal syncobjs. > > > > Just like the wait fence fd, this does inli

[Bug 206231] R9 280X low performance with all games

2020-01-17 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=206231 --- Comment #7 from kentosama (kentos...@whiteninjastudio.com) --- I noticed something strange. When I do the Tomb Raider benchmark, the GPU usage is 100% and I hear the fans running at full speed after a few seconds. The bench gives a result of

[Bug 206231] R9 280X low performance with all games

2020-01-17 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=206231 --- Comment #8 from kentosama (kentos...@whiteninjastudio.com) --- (In reply to Sylvain BERTRAND from comment #6) > Owner and user of tahiti parts on amdgpu with a state of the art gfx stack > poping in. > > I own "rise of the tomb raider" which

Re: [PATCH v2 0/5] Add support for Pine64 PineTab

2020-01-17 Thread Sam Ravnborg
Hi Icenowy On Thu, Jan 16, 2020 at 11:36:31AM +0800, Icenowy Zheng wrote: > This patchset tries to add support for the PineTab tablet from Pine64. > > As it uses a specific MIPI-DSI panel, the support of the panel should be > introduced first, with its DT binding. > > Then a device tree is added

Re: [PATCH v3 0/2] drm/modes: Apply video parameters with only reflect option

2020-01-17 Thread Maxime Ripard
On Fri, Jan 17, 2020 at 04:34:27PM +0100, Stephan Gerhold wrote: > At the moment, video mode parameters like video=540x960,reflect_x, > (without rotation set) are not taken into account when applying the > mode in drm_client_modeset.c. > > One of the reasons for this is that the calculation that >

Re: [PATCH v2 0/5] Add support for Pine64 PineTab

2020-01-17 Thread Maxime Ripard
On Fri, Jan 17, 2020 at 07:50:12PM +0100, Sam Ravnborg wrote: > Hi Icenowy > > On Thu, Jan 16, 2020 at 11:36:31AM +0800, Icenowy Zheng wrote: > > This patchset tries to add support for the PineTab tablet from Pine64. > > > > As it uses a specific MIPI-DSI panel, the support of the panel should be >

Re: [PATCH] video: fbdev: arcfb: add COMPILE_TEST support

2020-01-17 Thread Sam Ravnborg
On Thu, Jan 16, 2020 at 03:49:07PM +0100, Bartlomiej Zolnierkiewicz wrote: > Add COMPILE_TEST support to arcfb driver for better compile > testing coverage. > > Signed-off-by: Bartlomiej Zolnierkiewicz Acked-by: Sam Ravnborg > --- > drivers/video/fbdev/Kconfig |2 +- > 1 file changed, 1 ins

Re: [PATCH 1/2] video: fbdev: w100fb: fix sparse warnings

2020-01-17 Thread Sam Ravnborg
On Thu, Jan 16, 2020 at 03:53:20PM +0100, Bartlomiej Zolnierkiewicz wrote: > * Add missing __iomem annotations where needed. > * Make w100fb_probe() static. > * Return NULL pointer (instead of using plain integer) in > w100_get_xtal_tabl(). > > Signed-off-by: Bartlomiej Zolnierkiewicz Acked-by:

Re: [PATCH 2/2] video: fbdev: w100fb: add COMPILE_TEST support

2020-01-17 Thread Sam Ravnborg
On Thu, Jan 16, 2020 at 03:53:58PM +0100, Bartlomiej Zolnierkiewicz wrote: > Add COMPILE_TEST support to w100fb driver for better compile > testing coverage. > > Signed-off-by: Bartlomiej Zolnierkiewicz Acked-by: Sam Ravnborg > --- > drivers/video/fbdev/Kconfig |2 +- > 1 file changed, 1 in

Re: [PATCH 1/2] video: fbdev: wm8505fb: fix sparse warnings about using incorrect types

2020-01-17 Thread Sam Ravnborg
On Thu, Jan 16, 2020 at 03:56:50PM +0100, Bartlomiej Zolnierkiewicz wrote: > Use ->screen_buffer instead of ->screen_base to fix sparse warnings. > > [ Please see commit 17a7b0b4d974 ("fb.h: Provide alternate screen_base > pointer") for details. ] > > Signed-off-by: Bartlomiej Zolnierkiewicz A

Re: [PATCH 2/2] video: fbdev: wm8505fb: add COMPILE_TEST support

2020-01-17 Thread Sam Ravnborg
On Thu, Jan 16, 2020 at 03:58:08PM +0100, Bartlomiej Zolnierkiewicz wrote: > Add COMPILE_TEST support to wm8505fb driver for better compile > testing coverage. > > Signed-off-by: Bartlomiej Zolnierkiewicz Acked-by: Sam Ravnborg > --- > drivers/video/fbdev/Kconfig |2 +- > 1 file changed, 1

Re: [PATCH 1/2] video: fbdev: wm8505fb: fix sparse warnings about using incorrect types

2020-01-17 Thread Sam Ravnborg
On Thu, Jan 16, 2020 at 03:54:42PM +0100, Bartlomiej Zolnierkiewicz wrote: > Use ->screen_buffer instead of ->screen_base to fix sparse warnings. > > [ Please see commit 17a7b0b4d974 ("fb.h: Provide alternate screen_base > pointer") for details. ] > > Signed-off-by: Bartlomiej Zolnierkiewicz A

Re: [PATCH 1/6] video: fbdev: controlfb: fix sparse warning about using incorrect type

2020-01-17 Thread Sam Ravnborg
Hi Bartlomiej On Thu, Jan 16, 2020 at 03:08:55PM +0100, Bartlomiej Zolnierkiewicz wrote: > Force le32_to_cpup() argument to be of proper type (const __le32 *). > > Also add missing inline keyword to control_par_to_var() definition > (to match function prototype). > > Signed-off-by: Bartlomiej Zo

Re: [Bug 206231] R9 280X low performance with all games

2020-01-17 Thread sylvain . bertrand
On Fri, Jan 17, 2020 at 06:45:28PM +, bugzilla-dae...@bugzilla.kernel.org wrote: > screenshot : https://i.ibb.co/PrHj3hV/tombraider.jpg This seems to be from "shadow of the tomb raider" which I don't "own". Do you "own" "rise of the tomb raider", the previous tomb raider game (which I "own"

[Bug 206231] R9 280X low performance with all games

2020-01-17 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=206231 --- Comment #9 from Sylvain BERTRAND (sylvain.bertr...@gmail.com) --- On Fri, Jan 17, 2020 at 06:45:28PM +, bugzilla-dae...@bugzilla.kernel.org wrote: > screenshot : https://i.ibb.co/PrHj3hV/tombraider.jpg This seems to be from "shadow of the

[PATCH v3 00/12] drm/i915: Add support for HDCP 1.4 over MST connectors

2020-01-17 Thread Sean Paul
From: Sean Paul Hey all, Here's v3, which addresses all review comments in v2. Sean Sean Paul (12): drm/i915: Fix sha_text population code drm/i915: Clear the repeater bit on HDCP disable drm/i915: WARN if HDCP signalling is enabled upon disable drm/i915: Intercept Aksv writes in the au

[PATCH v3 02/12] drm/i915: Clear the repeater bit on HDCP disable

2020-01-17 Thread Sean Paul
From: Sean Paul On HDCP disable, clear the repeater bit. This ensures if we connect a non-repeater sink after a repeater, the bit is in the state we expect. Fixes: ee5e5e7a5e0f (drm/i915: Add HDCP framework + base implementation) Cc: Chris Wilson Cc: Ramalingam C Cc: Daniel Vetter Cc: Sean Pa

[PATCH v3 07/12] drm/i915: Protect workers against disappearing connectors

2020-01-17 Thread Sean Paul
From: Sean Paul This patch adds some protection against connectors being destroyed before the HDCP workers are finished. For check_work, we do a synchronous cancel after the connector is unregistered which will ensure that it is finished before destruction. In the case of prop_work, we can't do

[PATCH v3 09/12] drm/i915: Support DP MST in enc_to_dig_port() function

2020-01-17 Thread Sean Paul
From: Sean Paul Although DP_MST fake encoders are not subclassed from digital ports, they are associated with them. Support these encoders. Signed-off-by: Sean Paul Link: https://patchwork.freedesktop.org/patch/msgid/20191203173638.94919-9-s...@poorly.run #v1 Link: https://patchwork.freedesk

[PATCH v3 10/12] drm/i915: Use ddi_update_pipe in intel_dp_mst

2020-01-17 Thread Sean Paul
From: Sean Paul In order to act upon content_protection property changes, we'll need to implement the .update_pipe() hook. We can re-use intel_ddi_update_pipe for this Signed-off-by: Sean Paul Link: https://patchwork.freedesktop.org/patch/msgid/20191203173638.94919-10-s...@poorly.run #v1 Link

[PATCH v3 01/12] drm/i915: Fix sha_text population code

2020-01-17 Thread Sean Paul
From: Sean Paul This patch fixes a few bugs: 1- We weren't taking into account sha_leftovers when adding multiple ksvs to sha_text. As such, we were or'ing the end of ksv[j - 1] with the beginning of ksv[j] 2- In the sha_leftovers == 2 and sha_leftovers == 3 case, bstatus was being pla

[PATCH v3 12/12] drm/i915: Add HDCP 1.4 support for MST connectors

2020-01-17 Thread Sean Paul
From: Sean Paul Now that all the groundwork has been laid, we can turn on HDCP 1.4 over MST. Everything except for toggling the HDCP signalling and HDCP 2.2 support is the same as the DP case, so we'll re-use those callbacks Signed-off-by: Sean Paul Link: https://patchwork.freedesktop.org/patc

[PATCH v3 08/12] drm/i915: Don't fully disable HDCP on a port if multiple pipes are using it

2020-01-17 Thread Sean Paul
From: Sean Paul This patch is required for HDCP over MST. If a port is being used for multiple HDCP streams, we don't want to fully disable HDCP on a port if one of them is disabled. Instead, we just disable the HDCP signalling on that particular pipe and exit early. The last pipe to disable HDCP

[PATCH v3 05/12] drm/i915: Use the cpu_transcoder in intel_hdcp to toggle HDCP signalling

2020-01-17 Thread Sean Paul
From: Sean Paul Instead of using intel_dig_port's encoder pipe to determine which transcoder to toggle signalling on, use the cpu_transcoder field already stored in intel_hdmi. This is particularly important for MST. Suggested-by: Ville Syrjälä Reviewed-by: Ramalingam C Signed-off-by: Sean Pa

[PATCH v3 03/12] drm/i915: WARN if HDCP signalling is enabled upon disable

2020-01-17 Thread Sean Paul
From: Sean Paul HDCP signalling should not be left on, WARN if it is Cc: Ville Syrjälä Cc: Daniel Vetter Reviewed-by: Ramalingam C Signed-off-by: Sean Paul Link: https://patchwork.freedesktop.org/patch/msgid/20191212190230.188505-4-s...@poorly.run #v2 Changes in v2: - Added to the set in

Re: [PATCH 3/6] video: fbdev: controlfb: add COMPILE_TEST support

2020-01-17 Thread Sam Ravnborg
Hi Bartlomiej On Thu, Jan 16, 2020 at 03:08:57PM +0100, Bartlomiej Zolnierkiewicz wrote: > Add COMPILE_TEST support to controlfb driver for better compile > testing coverage. This is not a nice patch to add COMPILE_TEST support :-( But I see why you do it. I already spent too much time being side

  1   2   >