[PATCH 0/8] Convert the intel iommu driver to the dma-iommu api

2019-12-23 Thread Tom Murphy
This patchset converts the intel iommu driver to the dma-iommu api. While converting the driver I exposed a bug in the intel i915 driver which causes a huge amount of artifacts on the screen of my laptop. You can see a picture of it here: https://github.com/pippy360/kernelPatches/blob/master/IMG

[RFC PATCH v3 1/7] interconnect: Export of_icc_get_from_provider()

2019-12-23 Thread Artur Świgoń
This patch makes the above function public (for use in exynos-bus devfreq driver). Signed-off-by: Artur Świgoń Reviewed-by: Krzysztof Kozlowski Reviewed-by: Chanwoo Choi --- drivers/interconnect/core.c | 3 ++- include/linux/interconnect-provider.h | 6 ++ 2 files changed, 8 inse

Re: IGNORE -- Patch "drm/mgag200: Flag all G200 SE A machines as broken wrt " has been added to the 5.4-stable tree

2019-12-23 Thread John Donnelly
I discovered I was missing a commit when I merged . This series is fine . > On Dec 19, 2019, at 12:24 PM, John Donnelly > wrote: > > Hi > > I am having difficulties with this patch on : 5.4.2 variant ; The system is > not booting with these patches applied. > > I had verified a pro

[PATCH 1/2] drm/sun4i: backend: Make sure we enforce the clock rate

2019-12-23 Thread Maxime Ripard
The backend needs to run at 300MHz to be functional. This was done so far using assigned-clocks in the device tree, but that is easy to forget, and dosen't provide any other guarantee than the rate is going to be roughly the one requested at probe time. Therefore it's pretty fragile, so let's just

[PATCH v1] phy: Add DisplayPort configuration options

2019-12-23 Thread Yuti Amonkar
Allow DisplayPort PHYs to be configured through the generic functions through a custom structure added to the generic union. The configuration structure is used for reconfiguration of DisplayPort PHYs during link training operation. The parameters added here are the ones defined in the DisplayPort

Re: [PATCH v2] drm/amd/display: Reduce HDMI pixel encoding if max clock is exceeded

2019-12-23 Thread Tom Anderson
Ping. Is there any action required to get this landed? On Tue, Dec 10, 2019 at 10:59:24AM -0800, Tom Anderson wrote: > Friendly ping. > > On Mon, Dec 02, 2019 at 01:47:13PM -0800, Thomas Anderson wrote: > > For high-res (8K) or HFR (4K120) displays, using uncompressed pixel > > formats like YCbC

[PATCH 1/3] dt-bindings: Add vendor prefix for Chrontel, Inc.

2019-12-23 Thread Lubomir Rintel
Chrontel makes encoders for video displays and perhaps other stuff. Their web site is http://www.chrontel.com/. Signed-off-by: Lubomir Rintel --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/vendor-

Re: [PATCH v22 2/2] drm/bridge: Add I2C based driver for ps8640 bridge

2019-12-23 Thread Enric Balletbo i Serra
Hi Nicolas, Many thanks for you review. Just preparing a new version with your comments addressed. On 20/12/19 9:44, Nicolas Boichat wrote: > On Fri, Dec 20, 2019 at 4:17 PM Enric Balletbo i Serra > wrote: >> >> From: Jitao Shi >> >> This patch adds drm_bridge driver for parade DSI to eDP bridg

[PATCH 2/8] iommu/vt-d: Use default dma_direct_* mapping functions for direct mapped devices

2019-12-23 Thread Tom Murphy
We should only assign intel_dma_ops to devices which will actually use the iommu and let the default fall back dma_direct_* functions handle all other devices. This won't change any behaviour but will just use the generic implementations for direct mapped devices rather than intel specific ones. S

Re: [PATCH] drm/amd/display: replace BUG_ON with WARN_ON

2019-12-23 Thread Aditya Pakki
On 12/19/19 10:29 AM, Mikita Lipski wrote: > > > On 12/18/19 11:15 AM, Aditya Pakki wrote: >> In skip_modeset label within dm_update_crtc_state(), the dc stream >> cannot be NULL. Using BUG_ON as an assertion is not required and >> can be removed. The patch replaces the check with a WARN_ON in ca

Re: [PATCH v5 2/4] drm/bridge: Patch atomic hooks to take a drm_bridge_state

2019-12-23 Thread Jernej Škrabec
Hi! Dne četrtek, 19. december 2019 ob 11:11:49 CET je Neil Armstrong napisal(a): > From: Boris Brezillon > > This way the drm_bridge_funcs interface is consistent with the rest of > the subsystem. > > The only driver implementing those hooks (analogix DP) is patched too. > > Signed-off-by: Bor

Re: [PATCH 1/8] iommu/vt-d: clean up 32bit si_domain assignment

2019-12-23 Thread Lu Baolu
Hi, On 12/21/19 11:03 PM, Tom Murphy wrote: @@ -5618,9 +5583,13 @@ static int intel_iommu_add_device(struct device *dev) struct iommu_domain *domain; struct intel_iommu *iommu; struct iommu_group *group; + u64 dma_mask = *dev->dma_mask; u8 bus, devfn;

Re: [PATCH v5 3/4] drm/bridge: Add an ->atomic_check() hook

2019-12-23 Thread Jernej Škrabec
Hi! Dne četrtek, 19. december 2019 ob 11:11:50 CET je Neil Armstrong napisal(a): > From: Boris Brezillon > > So that bridge drivers have a way to check/reject an atomic operation. > The drm_atomic_bridge_chain_check() (which is just a wrapper around > the ->atomic_check() hook) is called in plac

Re: [PATCH v11 00/25] mm/gup: track dma-pinned pages: FOLL_PIN

2019-12-23 Thread Jason Gunthorpe
On Thu, Dec 19, 2019 at 01:13:54PM -0800, John Hubbard wrote: > On 12/19/19 1:07 PM, Jason Gunthorpe wrote: > > On Thu, Dec 19, 2019 at 12:30:31PM -0800, John Hubbard wrote: > > > On 12/19/19 5:26 AM, Leon Romanovsky wrote: > > > > On Mon, Dec 16, 2019 at 02:25:12PM -0800, John Hubbard wrote: > > >

Re: [PATCH RESEND 1/4] dt-bindings: drm/bridge: analogix-anx7688: Add ANX7688 transmitter binding

2019-12-23 Thread Hsin-Yi Wang
On Fri, Dec 20, 2019 at 4:45 AM Rob Herring wrote: > > On Wed, Dec 11, 2019 at 02:19:08PM +0800, Hsin-Yi Wang wrote: > > From: Nicolas Boichat > > > > Add support for analogix,anx7688 > > > > Signed-off-by: Nicolas Boichat > > Signed-off-by: Hsin-Yi Wang > > --- > > Change from RFC to v1: > > -

[RFC PATCH v3 5/7] devfreq: exynos-bus: Add interconnect functionality to exynos-bus

2019-12-23 Thread Artur Świgoń
This patch adds interconnect functionality to the exynos-bus devfreq driver. The SoC topology is a graph (or, more specifically, a tree) and its edges are specified using the 'exynos,interconnect-parent-node' in the DT. Due to unspecified relative probing order, -EPROBE_DEFER may be propagated to

Re: [PATCH RESEND 3/4] dt-bindings: drm/bridge: Add GPIO display mux binding

2019-12-23 Thread Hsin-Yi Wang
On Fri, Dec 20, 2019 at 4:48 AM Rob Herring wrote: > > On Mon, Dec 16, 2019 at 03:16:23PM +0800, Hsin-Yi Wang wrote: > > On Sat, Dec 14, 2019 at 5:29 AM Rob Herring wrote: > > > > > > On Wed, Dec 11, 2019 at 12:19 AM Hsin-Yi Wang wrote: > > > > > > > > From: Nicolas Boichat > > > > > > > > Add

[PATCH] drm/amdgpu: Remove unneeded variable 'ret' in navi10_ih.c

2019-12-23 Thread Ma Feng
Fixes coccicheck warning: drivers/gpu/drm/amd/amdgpu/navi10_ih.c:113:5-8: Unneeded variable: "ret". Return "0" on line 182 Reported-by: Hulk Robot Signed-off-by: Ma Feng --- drivers/gpu/drm/amd/amdgpu/navi10_ih.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gp

[PATCH] dt-bindings: display: Convert Allwinner display pipeline to schemas

2019-12-23 Thread Maxime Ripard
The Allwinner SoCs have a display engine composed of several controllers assembled differently depending on the SoC, the number and type of output they have, and the additional features they provide. A number of those are supported in Linux, with the matching bindings. Now that we have the DT vali

[PATCH 3/3] drm/bridge: chrontel-ch7033: Add a new driver

2019-12-23 Thread Lubomir Rintel
This is a driver for video encoder with VGA and DVI/HDMI outputs. There is no documentation for the chip -- the operation was guessed from what was sniffed on a Dell Wyse 3020 ThinOS terminal, the register names come from the ch7035 driver in Mediatek's GPL code dump. Only bare minimum is impleme

[RFC PATCH v3 3/7] interconnect: Allow inter-provider pairs to be configured

2019-12-23 Thread Artur Świgoń
In the exynos-bus devfreq driver every bus is probed separately and is assigned a separate interconnect provider. However, the interconnect framework does not call the '->set' callback for pairs of nodes which belong to different providers. This patch adds support for a new boolean 'inter_set' fie

[PATCH 5/8] iommu: Add iommu_dma_free_cpu_cached_iovas function

2019-12-23 Thread Tom Murphy
to dma-iommu ops Add a iommu_dma_free_cpu_cached_iovas function to allow drivers which use the dma-iommu ops to free cached cpu iovas. Signed-off-by: Tom Murphy --- drivers/iommu/dma-iommu.c | 9 + include/linux/dma-iommu.h | 3 +++ 2 files changed, 12 insertions(+) diff --git a/driver

[PATCH next] drm/amd/display: make non-global functions static

2019-12-23 Thread Chen Zhou
Fix sparse warning: drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_resource.c:964:5: warning: symbol 'shift_border_left_to_dst' was not declared. Should it be static? drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_resource.c:975:6: warning: symbol 'restore_border_left_from_dst

[PATCH v22 2/2] drm/bridge: Add I2C based driver for ps8640 bridge

2019-12-23 Thread Enric Balletbo i Serra
From: Jitao Shi This patch adds drm_bridge driver for parade DSI to eDP bridge chip. Signed-off-by: Jitao Shi Reviewed-by: Daniel Kurtz Reviewed-by: Enric Balletbo i Serra [uli: followed API changes, removed FW update feature] Signed-off-by: Ulrich Hecht Signed-off-by: Enric Balletbo i Serra

[PATCH] drm/nouveau/bios: fix incorrect kfree in platform_init

2019-12-23 Thread wuxu . wu
priv porinter could be free only when priv != null and priv->rom is null. Signed-off-by: wuxu.wu --- drivers/gpu/drm/nouveau/nvkm/subdev/bios/shadowpci.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/bios/shadowpci.c b/drivers/gpu/drm/

Re: [PATCH v5 4/4] drm/bridge: Add the necessary bits to support bus format negotiation

2019-12-23 Thread Jernej Škrabec
Hi! Dne četrtek, 19. december 2019 ob 11:11:51 CET je Neil Armstrong napisal(a): > From: Boris Brezillon > > drm_bridge_state is extended to describe the input and output bus > configurations. These bus configurations are exposed through the > drm_bus_cfg struct which encodes the configuration o

Re: [PATCH v4 3/5] dt-bindings: display: ti, j721e-dss: Add dt-schema yaml binding

2019-12-23 Thread Maxime Ripard
Hi, On Thu, Dec 19, 2019 at 10:23:17AM +0200, Jyri Sarha wrote: > Add dt-schema yaml bindig for J721E DSS, J721E version TI Keystone > Display SubSystem. > > Version history: > > v2: no change > > v3: - reg-names: "wp" -> "wb" > - Add ports node > - Add includes to dts example > - rein

[PATCH 7/8] iommu/vt-d: Convert intel iommu driver to the iommu ops

2019-12-23 Thread Tom Murphy
Convert the intel iommu driver to the dma-iommu api. Remove the iova handling and reserve region code from the intel iommu driver. Signed-off-by: Tom Murphy --- drivers/iommu/Kconfig | 1 + drivers/iommu/intel-iommu.c | 742 +++- include/linux/intel-iommu.

Re: [PATCH v11 00/25] mm/gup: track dma-pinned pages: FOLL_PIN

2019-12-23 Thread Jason Gunthorpe
On Thu, Dec 19, 2019 at 12:30:31PM -0800, John Hubbard wrote: > On 12/19/19 5:26 AM, Leon Romanovsky wrote: > > On Mon, Dec 16, 2019 at 02:25:12PM -0800, John Hubbard wrote: > > > Hi, > > > > > > This implements an API naming change (put_user_page*() --> > > > unpin_user_page*()), and also impleme

[PATCH v22 1/2] Documentation: bridge: Add documentation for ps8640 DT properties

2019-12-23 Thread Enric Balletbo i Serra
From: Jitao Shi Add documentation for DT properties supported by ps8640 DSI-eDP converter. Signed-off-by: Jitao Shi Acked-by: Rob Herring Reviewed-by: Philipp Zabel Signed-off-by: Ulrich Hecht Signed-off-by: Enric Balletbo i Serra --- I maintained the ack from Rob Herring and the review fro

[PATCH 8/8] DO NOT MERGE: iommu: disable list appending in dma-iommu

2019-12-23 Thread Tom Murphy
ops __finalise_sg Disable combining sg segments in the dma-iommu api. Combining the sg segments exposes a bug in the intel i915 driver which causes visual artifacts and the screen to freeze. This is most likely because of how the i915 handles the returned list. It probably doesn't respect the retu

Re: [RFC v2 05/12] drm/i915/svm: Page table mirroring support

2019-12-23 Thread Jason Gunthorpe
On Wed, Dec 18, 2019 at 02:41:47PM -0800, Niranjana Vishwanathapura wrote: > > > +static u32 i915_svm_build_sg(struct i915_address_space *vm, > > > + struct hmm_range *range, > > > + struct sg_table *st) > > > +{ > > > + struct scatterlist *sg; > > > + u32

RE: [PATCH] drm: of: Fix linking when CONFIG_OF is not set

2019-12-23 Thread Fabrizio Castro
Hi Laurent, > From: Laurent Pinchart > Sent: 19 December 2019 10:37 > To: dri-devel@lists.freedesktop.org > Cc: Fabrizio Castro ; Daniel Vetter > ; Dave Airlie > Subject: [PATCH] drm: of: Fix linking when CONFIG_OF is not set > > The new helper drm_of_lvds_get_dual_link_pixel_order() introduce

[PATCH next] drm: of: fix build error without CONFIG_OF

2019-12-23 Thread Chen Zhou
Without CONFIG_OF, drm_of_lvds_get_dual_link_pixel_order should be static inline, otherwise building fails: drivers/gpu/drm/vc4/vc4_dsi.o: In function `drm_of_lvds_get_dual_link_pixel_order': vc4_dsi.c:(.text+0xa30): multiple definition of `drm_of_lvds_get_dual_link_pixel_order' drivers/gpu/drm/

[PATCH] drm/omap: gem: Fix tearing with BO_TILED

2019-12-23 Thread Tony Lindgren
On my droid4 I noticed bad constant tearing on the LCD with stellarium in landscape mode with xorg-video-omap rotated with xrandr --rotate right. Every second or so update gets squeezed down in size to only the top half of the LCD panel. This issue does not happen with xrandr --rotate normal, or w

Re: Warnings in DRM code when removing/unbinding a driver

2019-12-23 Thread John Garry
On 19/12/2019 09:54, Daniel Vetter wrote: On Wed, Dec 18, 2019 at 7:08 PM John Garry wrote: + So the v5.4 kernel does not have this issue. I have bisected the initial occurrence to: commit 37a48adfba6cf6e87df9ba8b75ab85d514ed86d8 Author: Thomas Zimmermann Date: Fri Sep 6 14:20:53 2019 +0

Re: [PATCH v2 2/2] drm/tegra: Do not implement runtime PM

2019-12-23 Thread Ulf Hansson
On Thu, 12 Dec 2019 at 17:48, Rafael J. Wysocki wrote: > > On Thu, Dec 12, 2019 at 2:32 PM Ulf Hansson wrote: > > > > On Thu, 12 Dec 2019 at 13:33, Thierry Reding > > wrote: > > > > > > On Thu, Dec 12, 2019 at 09:52:22AM +0100, Ulf Hansson wrote: > > > > On Mon, 9 Dec 2019 at 14:03, Thierry Red

[PATCH 6/8] iommu: allow the dma-iommu api to use bounce buffers

2019-12-23 Thread Tom Murphy
Allow the dma-iommu api to use bounce buffers for untrusted devices. This is a copy of the intel bounce buffer code. Signed-off-by: Tom Murphy --- drivers/iommu/dma-iommu.c | 93 --- drivers/iommu/iommu.c | 10 + include/linux/iommu.h | 9 +++- 3

[PATCH 4/8] iommu: Handle freelists when using deferred flushing in iommu drivers

2019-12-23 Thread Tom Murphy
Allow the iommu_unmap_fast to return newly freed page table pages and pass the freelist to queue_iova in the dma-iommu ops path. This is useful for iommu drivers (in this case the intel iommu driver) which need to wait for the ioTLB to be flushed before newly free/unmapped page table pages can be

Re: [PATCH v2 3/3] drm/i915: Add support for integrated privacy screens

2019-12-23 Thread Rajat Jain
HI Jani, On Thu, Dec 5, 2019 at 1:34 AM Rajat Jain wrote: > > On Wed, Nov 20, 2019 at 7:04 AM Jani Nikula > wrote: > > > > On Mon, 04 Nov 2019, Rajat Jain wrote: > > > Certain laptops now come with panels that have integrated privacy > > > screens on them. This patch adds support for such pan

[PATCH 2/2] drm/sun4i: drc: Make sure we enforce the clock rate

2019-12-23 Thread Maxime Ripard
The DRC needs to run at 300MHz to be functional. This was done so far using assigned-clocks in the device tree, but that is easy to forget, and dosen't provide any other guarantee than the rate is going to be roughly the one requested at probe time. Therefore it's pretty fragile, so let's just use

[PATCH] drm/nouveau/bios: fix incorrect kfree in platform_init

2019-12-23 Thread wuxu . wu
priv porinter could be free only when priv != null and priv->rom is null. --- drivers/gpu/drm/nouveau/nvkm/subdev/bios/shadowpci.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/bios/shadowpci.c b/drivers/gpu/drm/nouveau/nvkm/subdev/bios/

Re: [PATCH v5 1/4] drm/bridge: Add a drm_bridge_state object

2019-12-23 Thread Jernej Škrabec
Hi! Dne četrtek, 19. december 2019 ob 11:11:48 CET je Neil Armstrong napisal(a): > From: Boris Brezillon > > One of the last remaining objects to not have its atomic state. > > This is being motivated by our attempt to support runtime bus-format > negotiation between elements of the bridge chai

[PATCH ] drm/radeon: Fix potential buffer overflow in ci_set_mc_special_registers()

2019-12-23 Thread chenmaodong
Hi, The length of table->mc_reg_address is SMU7_DISCRETE_MC_REGISTER_ARRAY_SIZE. In ci_set_mc_special_registers(), the boundary checking here("if (j > SMU7_DISCRETE_MC_REGISTER_ARRAY_SIZE)") allows 'j' equal to SMU7_DISCRETE_MC_REGISTER_ARRAY_SIZE which can easily cause the table->mc_reg_addr

INFO: task hung in fb_release

2019-12-23 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:c6017471 Merge tag 'xfs-5.5-fixes-2' of git://git.kernel.o.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=127d0799e0 kernel config: https://syzkaller.appspot.com/x/.config?x=7f6119e2e3675a73 da

Re: [PATCH RESEND 1/4] dt-bindings: drm/bridge: analogix-anx7688: Add ANX7688 transmitter binding

2019-12-23 Thread Hsin-Yi Wang
On Fri, Dec 20, 2019 at 11:22 AM Laurent Pinchart wrote: > > Hi Hsin-Yi, > > On Fri, Dec 20, 2019 at 11:20:13AM +0800, Hsin-Yi Wang wrote: > > On Fri, Dec 20, 2019 at 4:45 AM Rob Herring wrote: > > > On Wed, Dec 11, 2019 at 02:19:08PM +0800, Hsin-Yi Wang wrote: > > > > From: Nicolas Boichat > > >

Add support for Chrontel CH7033 VGA/DVI Encoder

2019-12-23 Thread Lubomir Rintel
Hi, chained to this message is a driver for CH7033 along with device tree binding docs. Tested to work well on MMP3-based Dell Wyse 3020, some tweaks might be needed for other configurations. There's not datasheet or programming manual available. Thanks, Lubo __

[PATCH 2/3] dt-bindings: display: Add Chrontel CH7033 Video Encoder binding

2019-12-23 Thread Lubomir Rintel
Add binding document for the Chrontel CH7033 VGA/DVI/HDMI Encoder. Signed-off-by: Lubomir Rintel --- .../display/bridge/chrontel,ch7033.yaml | 86 +++ 1 file changed, 86 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/bridge/chrontel,ch7033.yaml

[PATCH 1/8] iommu/vt-d: clean up 32bit si_domain assignment

2019-12-23 Thread Tom Murphy
In the intel iommu driver devices which only support 32bit DMA can't be direct mapped. The implementation of this is weird. Currently we assign it a direct mapped domain and then remove the domain later and replace it with a domain of type IOMMU_DOMAIN_IDENTITY. We should just assign it a domain of

Re: [PATCH v5 1/5] dt-bindings: display: ti,k2g-dss: Add dt-schema yaml binding

2019-12-23 Thread Maxime Ripard
On Fri, Dec 20, 2019 at 05:55:09PM +0200, Jyri Sarha wrote: > Add dt-schema yaml bindig for K2G DSS, an ultra-light version of TI > Keystone Display SubSystem. > > Version history: > > v2: no change > > v3: - Add ports node > - Add includes to dts example > - reindent dts example > > v4: -

Re: [PATCH] drm/i915: Remove tautological compare in eb_relocate_vma

2019-12-23 Thread Nathan Chancellor
On Tue, Dec 03, 2019 at 10:45:22AM -0800, Nick Desaulniers wrote: > On Tue, Dec 3, 2019 at 5:42 AM Chris Wilson wrote: > > > > Quoting Nick Desaulniers (2019-12-02 19:18:20) > > > On Sat, Nov 23, 2019 at 12:05 PM Chris Wilson > > > wrote: > > > > > > > > Quoting Nathan Chancellor (2019-11-23 19:

Re: [PATCH] drm/omap: gem: Fix tearing with BO_TILED

2019-12-23 Thread Tony Lindgren
* Tony Lindgren [191220 16:57]: > Looking around what might affect BO_TILED, I noticed Matthijs had this > change in his earlier pyra tiler patches. The earlier patch "XXX omapdrm: > force tiled buffers to be pinned and page-aligned" has no commit log > though, so I'm not sure what other issues th

[RFC PATCH v3 4/7] arm: dts: exynos: Add interconnect bindings for Exynos4412

2019-12-23 Thread Artur Świgoń
This patch adds the following properties to the Exynos4412 DT: - exynos,interconnect-parent-node: to declare connections between nodes in order to guarantee PM QoS requirements between nodes; - #interconnect-cells: required by the interconnect framework. Note that #interconnect-cells is al

Re: BAD -- Patch "drm/mgag200: Flag all G200 SE A machines as broken wrt " has been added to the 5.4-stable tree

2019-12-23 Thread John Donnelly
Hi I am having difficulties with this patch on : 5.4.2 variant ; The system is not booting with these patches applied. I had verified a prototype of the patch on 5.4.0-rc8 ; I am currently debugging it , but I will be OoO until 1/6/2020 after today . > On Dec 19, 2019, at 5:

Re: [PATCH] fbmem: Adjust indentation in fb_prepare_logo and fb_blank

2019-12-23 Thread Nick Desaulniers
On Tue, Dec 17, 2019 at 7:00 PM Nathan Chancellor wrote: > > Clang warns: > > ../drivers/video/fbdev/core/fbmem.c:665:3: warning: misleading > indentation; statement is not part of the previous 'else' > [-Wmisleading-indentation] > if (fb_logo.depth > 4 && depth > 4) { > ^ > ../dri

Re: [PATCH 1/8] iommu/vt-d: clean up 32bit si_domain assignment

2019-12-23 Thread Arvind Sankar
On Sat, Dec 21, 2019 at 03:03:53PM +, Tom Murphy wrote: > In the intel iommu driver devices which only support 32bit DMA can't be > direct mapped. The implementation of this is weird. Currently we assign > it a direct mapped domain and then remove the domain later and replace > it with a domain

Re: [PATCH v22 2/2] drm/bridge: Add I2C based driver for ps8640 bridge

2019-12-23 Thread Hsin-Yi Wang
On Fri, Dec 20, 2019 at 4:17 PM Enric Balletbo i Serra wrote: > > From: Jitao Shi > > This patch adds drm_bridge driver for parade DSI to eDP bridge chip. > > Signed-off-by: Jitao Shi > Reviewed-by: Daniel Kurtz > Reviewed-by: Enric Balletbo i Serra > [uli: followed API changes, removed FW upd

Re: [PATCH v5 3/5] dt-bindings: display: ti, j721e-dss: Add dt-schema yaml binding

2019-12-23 Thread Maxime Ripard
On Fri, Dec 20, 2019 at 05:55:11PM +0200, Jyri Sarha wrote: > Add dt-schema yaml bindig for J721E DSS, J721E version TI Keystone > Display SubSystem. > > Version history: > > v2: no change > > v3: - reg-names: "wp" -> "wb" > - Add ports node > - Add includes to dts example > - reindent

KASAN: vmalloc-out-of-bounds Read in drm_fb_helper_dirty_work

2019-12-23 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:7e0165b2 Merge branch 'akpm' (patches from Andrew) git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=1619eb1ee0 kernel config: https://syzkaller.appspot.com/x/.config?x=1b59a3066828ac4c dashboard li

Re: [PATCH v5 6/7] drm/mediatek: support CMDQ interface in ddp component

2019-12-23 Thread Hsin-Yi Wang
On Tue, Dec 10, 2019 at 5:05 AM Bibby Hsieh wrote: > > +void mtk_ddp_write(struct cmdq_pkt *cmdq_pkt, unsigned int value, > + struct mtk_ddp_comp *comp, unsigned int offset) > +{ > +#if IS_ENABLED(CONFIG_MTK_CMDQ) Should we use #ifdef like in v4? https://patchwork.kernel.org/patc

[RFC PATCH v3 0/7] PM / devfreq: Simple QoS for exynos-bus using interconnect

2019-12-23 Thread Artur Świgoń
The following patchset adds interconnect[1][2] framework support to the exynos-bus devfreq driver. Extending the devfreq driver with interconnect functionality started as a response to the issue referenced in [3]. The patches can be subdivided into three groups: (a) Tweaking the interconnect frame

Re: [PATCH v3 2/3] dt-bindings: display: panel: Add binding document for Leadtek LTK500HD1829

2019-12-23 Thread Maxime Ripard
On Sun, Dec 22, 2019 at 01:06:33AM +0100, Heiko Stuebner wrote: > From: Heiko Stuebner > > The LTK500HD1829 is a 5.0" 720x1280 DSI display. > > changes in v2: > - fix id (Maxime) > - drop port (Maxime) > > Signed-off-by: Heiko Stuebner Acked-by: Maxime Ripard Thanks! Maxime signature.asc Des

[RFC PATCH v3 7/7] drm: exynos: mixer: Add interconnect support

2019-12-23 Thread Artur Świgoń
From: Marek Szyprowski This patch adds interconnect support to exynos-mixer. The mixer works the same as before when CONFIG_INTERCONNECT is 'n'. Co-developed-by: Artur Świgoń Signed-off-by: Artur Świgoń Signed-off-by: Marek Szyprowski --- drivers/gpu/drm/exynos/exynos_mixer.c | 71 ++

[PATCH v5 1/3] drm/i915: Move the code to populate ACPI device ID into intel_acpi

2019-12-23 Thread Rajat Jain
Move the code that populates the ACPI device ID for devices, into more appripriate intel_acpi.c. This is done in preparation for more users of this code (in next patch). Signed-off-by: Rajat Jain --- v5: same as v4 v4: Same as v3 v3: * Renamed the function to intel_acpi_* * Used forward decla

Re: [PATCH v4 1/8] dt-bindings: add img, pvrsgx.yaml for Imagination GPUs

2019-12-23 Thread H. Nikolaus Schaller
Hi Rob, > Am 18.12.2019 um 22:16 schrieb Rob Herring : > > On Tue, Dec 17, 2019 at 07:01:59PM +0100, H. Nikolaus Schaller wrote: >> The Imagination PVR/SGX GPU is part of several SoC from >> multiple vendors, e.g. TI OMAP, Ingenic JZ4780, Intel Poulsbo >> and others. >> >> With this binding, we

Re: [PATCH v5 2/5] dt-bindings: display: ti, am65x-dss: Add dt-schema yaml binding

2019-12-23 Thread Maxime Ripard
On Fri, Dec 20, 2019 at 05:55:10PM +0200, Jyri Sarha wrote: > Add dt-schema yaml bindig for AM65x DSS, AM65x version TI Keystone > Display SubSystem. > > Version history: > > v2: no change > > v3: - Add ports node > - use allOf in ti,am65x-oldi-io-ctrl to add both $ref and maxItems > - Add

[RFC PATCH v3 2/7] interconnect: Relax requirement in of_icc_get_from_provider()

2019-12-23 Thread Artur Świgoń
This patch relaxes the condition in of_icc_get_from_provider() so that it is no longer required to set #interconnect-cells = <1> in the DT. In case of the devfreq driver for exynos-bus, #interconnect-cells is always zero. Signed-off-by: Artur Świgoń Acked-by: Krzysztof Kozlowski --- drivers/int

[PATCH v22 0/2] drm/bridge: PS8640 MIPI-to-eDP bridge

2019-12-23 Thread Enric Balletbo i Serra
Hi all, This is another version of the driver. Note that the driver changed significally and is a more simply because now is using the panel_bridge helpers. Apart from this, I addressed the comments from Maxime, Laurent and Ezequiel. This bridge is required to have the embedded display working on

[PATCH 3/8] iommu/vt-d: Remove IOVA handling code from non-dma_ops path

2019-12-23 Thread Tom Murphy
Remove all IOVA handling code from the non-dma_ops path in the intel iommu driver. There's no need for the non-dma_ops path to keep track of IOVAs. The whole point of the non-dma_ops path is that it allows the IOVAs to be handled separately. The IOVA handling code removed in this patch is pointles

[PATCH next] drm/amd/display: make some symbols static

2019-12-23 Thread Chen Zhou
Make some structs and functions static to fix build warnings, parts of warnings are as follows: drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_resource.c:744:21: warning: symbol 'dce110_clock_source_create' was not declared. Should it be static? drivers/gpu/drm/amd/amdgpu/../displ

[PATCH] drm/amdgpu: Remove unneeded variable 'ret' in amdgpu_device.c

2019-12-23 Thread Ma Feng
Fixes coccicheck warning: drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:1036:5-8: Unneeded variable: "ret". Return "0" on line 1079 Reported-by: Hulk Robot Signed-off-by: Ma Feng --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a

[PATCH v5 3/3] drm/i915: Add support for integrated privacy screens

2019-12-23 Thread Rajat Jain
Certain laptops now come with panels that have integrated privacy screens on them. This patch adds support for such panels by adding a privacy-screen property to the intel_connector for the panel, that the userspace can then use to control and check the status. Identifying the presence of privacy

[RFC PATCH v3 6/7] arm: dts: exynos: Add interconnects to Exynos4412 mixer

2019-12-23 Thread Artur Świgoń
This patch adds an 'interconnects' property to Exynos4412 DTS in order to declare the interconnect path used by the mixer. Please note that the 'interconnect-names' property is not needed when there is only one path in 'interconnects', in which case calling of_icc_get() with a NULL name simply retu

Re: [PATCH v4 3/5] dt-bindings: display: ti, j721e-dss: Add dt-schema yaml binding

2019-12-23 Thread Maxime Ripard
Hi, On Thu, Dec 19, 2019 at 04:01:58PM +0200, Jyri Sarha wrote: > On 19/12/2019 10:38, Maxime Ripard wrote: > > On Thu, Dec 19, 2019 at 10:23:17AM +0200, Jyri Sarha wrote: > >> Add dt-schema yaml bindig for J721E DSS, J721E version TI Keystone > >> Display SubSystem. > >> > >> Version history: > >

[PATCH for 5.5] phy/rockchip: inno-hdmi: round clock rate down to closest 1000 Hz

2019-12-23 Thread Jonas Karlman
Commit 287422a95fe2 ("drm/rockchip: Round up _before_ giving to the clock framework") changed what rate clk_round_rate() is called with, an additional 999 Hz added to the requsted mode clock. This has caused a regression on RK3328 and presumably also on RK3228 because the inno-hdmi-phy clock requi

Re: [PATCH v5 6/7] drm/mediatek: support CMDQ interface in ddp component

2019-12-23 Thread CK Hu
Hi, Hsin-yi: On Fri, 2019-12-20 at 21:27 +0800, Hsin-Yi Wang wrote: > On Tue, Dec 10, 2019 at 5:05 AM Bibby Hsieh wrote: > > > > > +void mtk_ddp_write(struct cmdq_pkt *cmdq_pkt, unsigned int value, > > + struct mtk_ddp_comp *comp, unsigned int offset) > > +{ > > +#if IS_ENABLED(

SIGBUS on device disappearance (Re: Warnings in DRM code when removing/unbinding a driver)

2019-12-23 Thread Pekka Paalanen
On Thu, 19 Dec 2019 13:42:33 +0100 Daniel Vetter wrote: > On Thu, Dec 19, 2019 at 12:32 PM Gerd Hoffmann wrote: > > > > While being at it: How would a driver cleanup properly cleanup gem > > objects created by userspace on hotunbind? Specifically a gem object > > pinned to vram? > > Two thi

Re: [PATCH v22 2/2] drm/bridge: Add I2C based driver for ps8640 bridge

2019-12-23 Thread Nicolas Boichat
On Mon, Dec 23, 2019 at 3:10 PM Enric Balletbo i Serra wrote: > > Hi Nicolas, > > Many thanks for you review. Just preparing a new version with your comments > addressed. > > On 20/12/19 9:44, Nicolas Boichat wrote: > > On Fri, Dec 20, 2019 at 4:17 PM Enric Balletbo i Serra > > wrote: > >> > >> F

Re: [PATCH v4 04/11] drm/bridge: Make the bridge chain a double-linked list

2019-12-23 Thread Marek Szyprowski
Hi Boris, On 16.12.2019 16:25, Boris Brezillon wrote: > On Mon, 16 Dec 2019 16:02:36 +0100 > Marek Szyprowski wrote: >> Hi Boris, >> >> On 16.12.2019 15:55, Boris Brezillon wrote: >>> On Mon, 16 Dec 2019 14:54:25 +0100 >>> Marek Szyprowski wrote: On 03.12.2019 15:15, Boris Brezillon wrote:

Re: [PATCH] drm/i915: Re-init lspcon after HPD if lspcon probe failed

2019-12-23 Thread Jani Nikula
On Mon, 23 Dec 2019, Kai-Heng Feng wrote: > On HP 800 G4 DM, if HDMI cable isn't plugged before boot, the HDMI port > becomes useless and never responds to cable hotplugging: > [3.031904] [drm:lspcon_init [i915]] *ERROR* Failed to probe lspcon > [3.031945] [drm:intel_ddi_init [i915]] *ERRO

Re: [PATCH 0/8] Convert the intel iommu driver to the dma-iommu api

2019-12-23 Thread Jani Nikula
On Sat, 21 Dec 2019, Tom Murphy wrote: > This patchset converts the intel iommu driver to the dma-iommu api. > > While converting the driver I exposed a bug in the intel i915 driver > which causes a huge amount of artifacts on the screen of my > laptop. You can see a picture of it here: > https://

Re: [PATCH v1 3/8] drm/print: add new logging helper for drm logging

2019-12-23 Thread Jani Nikula
On Sat, 21 Dec 2019, Sam Ravnborg wrote: > Add new helper so logging can use the standard logging > functions without an extra helper function. The main functional change here is that this will no longer print the function names in the debug logs. I am not sure if we want to make that change. BR

Re: [PATCH v1 4/8] drm/print: add kernel-doc for drm_debug_enabled

2019-12-23 Thread Jani Nikula
On Sat, 21 Dec 2019, Sam Ravnborg wrote: > Signed-off-by: Sam Ravnborg > Cc: Jani Nikula > Cc: Sean Paul > Cc: Daniel Vetter > --- > include/drm/drm_print.h | 15 +++ > 1 file changed, 15 insertions(+) > > diff --git a/include/drm/drm_print.h b/include/drm/drm_print.h > index c1d3

Re: [PATCH v1 3/8] drm/print: add new logging helper for drm logging

2019-12-23 Thread Joe Perches
On Mon, 2019-12-23 at 13:16 +0200, Jani Nikula wrote: > On Sat, 21 Dec 2019, Sam Ravnborg wrote: > > Add new helper so logging can use the standard logging > > functions without an extra helper function. > > The main functional change here is that this will no longer print the > function names in

Re: [PATCH v1 6/8] drm/print: add drm_dev_* logging functions

2019-12-23 Thread Jani Nikula
On Sat, 21 Dec 2019, Sam Ravnborg wrote: > Hi Joe. > >> > +#define __drm_dev_cat_printk(dev, cat, type, fmt, ...) >> > \ >> > +({ >> > \ >> > + if (drm_debug_enabled(cat))

Re: [PATCH v1 1/8] drm/print: document logging functions

2019-12-23 Thread Jani Nikula
On Sat, 21 Dec 2019, Sam Ravnborg wrote: > This is the documentation I have missed when I looked for help > how to do proper logging. Hopefully it can help others. > > Signed-off-by: Sam Ravnborg > Cc: Jani Nikula > Cc: Sean Paul > Cc: Daniel Vetter > --- > Documentation/gpu/drm-internals.rst

Re: [PATCH v1 6/8] drm/print: add drm_dev_* logging functions

2019-12-23 Thread Jani Nikula
On Sat, 21 Dec 2019, Sam Ravnborg wrote: > There are a lot of cases where we have a device * but no drm_device *. > Add drm_dev_* variants of the logging functions to cover these cases. So I know there are some valid cases where we only have struct device *, and instead of passing struct drm_devi

Re: [PATCH 0/8] Convert the intel iommu driver to the dma-iommu api

2019-12-23 Thread Robin Murphy
On 2019-12-23 10:37 am, Jani Nikula wrote: On Sat, 21 Dec 2019, Tom Murphy wrote: This patchset converts the intel iommu driver to the dma-iommu api. While converting the driver I exposed a bug in the intel i915 driver which causes a huge amount of artifacts on the screen of my laptop. You can

Re: [PATCH 0/8] Convert the intel iommu driver to the dma-iommu api

2019-12-23 Thread Jani Nikula
On Mon, 23 Dec 2019, Robin Murphy wrote: > On 2019-12-23 10:37 am, Jani Nikula wrote: >> On Sat, 21 Dec 2019, Tom Murphy wrote: >>> This patchset converts the intel iommu driver to the dma-iommu api. >>> >>> While converting the driver I exposed a bug in the intel i915 driver >>> which causes a h

Re: [PATCH v1 1/8] drm/print: document logging functions

2019-12-23 Thread Sam Ravnborg
Hi Jani. > > + * > > + * Each of the debug logging macros use a specific category, and the > > logging > > + * is filtered by the drm.debug module parameter. The &drm_debug_category > > enum > > + * specifies the values for the interface. > > + * > > + * Each drm_dbg_ macro logs to a DRM_UT_ cat

Re: [PATCH v1 3/8] drm/print: add new logging helper for drm logging

2019-12-23 Thread Sam Ravnborg
Hi Jani. On Mon, Dec 23, 2019 at 01:16:01PM +0200, Jani Nikula wrote: > On Sat, 21 Dec 2019, Sam Ravnborg wrote: > > Add new helper so logging can use the standard logging > > functions without an extra helper function. > > The main functional change here is that this will no longer print the >

Re: [PATCH v1 6/8] drm/print: add drm_dev_* logging functions

2019-12-23 Thread Sam Ravnborg
Hi Jani. On Mon, Dec 23, 2019 at 01:29:19PM +0200, Jani Nikula wrote: > On Sat, 21 Dec 2019, Sam Ravnborg wrote: > > There are a lot of cases where we have a device * but no drm_device *. > > Add drm_dev_* variants of the logging functions to cover these cases. > > So I know there are some valid

Re: [PATCH] drm/komeda: Add runtime_pm support

2019-12-23 Thread Mihail Atanassov
On Thursday, 12 December 2019 07:48:13 GMT james qian wang (Arm Technology China) wrote: > - Add pm_runtime_get/put to crtc_enable/disable along with the real > display usage > - Add runtime_get/put to register_show, since register_show() will > access register, need to wakeup HW. > - For the

Re: [PATCH] drm/komeda: Add event handling for EMPTY/FULL

2019-12-23 Thread Mihail Atanassov
Hi James, On Thursday, 12 December 2019 07:27:55 GMT james qian wang (Arm Technology China) wrote: > EMPTY/FULL are HW input/output FIFO condition identifer, which are > useful information for addressing the problem, so expose them. > > Signed-off-by: james qian wang (Arm Technology China) > >

Re: [PULL] drm-intel-fixes

2019-12-23 Thread Chris Wilson
Quoting Joonas Lahtinen (2019-12-19 12:46:35) > Hi Dave & Daniel, > > Another -rc, another CI fire due to regressions elsewhere. > > Our CI needed the following patches to get machines boot with -rc2: > > Revert "devtmpfs: use do_mount() instead of ksys_mount()" > (commit 5e787db

[PATCH v3 3/9] drm/i915/dp: Move vswing/pre-emphasis adjustment calculation

2019-12-23 Thread Animesh Manna
vswing/pre-emphasis adjustment calculation is needed in processing of auto phy compliance request other than link training, so moved the same function in intel_dp.c. No functional change. v1: initial patch. v2: - used "intel_dp" prefix in function name. (Jani) - used array notation instead pointe

[PATCH v3 3/9] drm/i915/dp: Move vswing/pre-emphasis adjustment calculation

2019-12-23 Thread Animesh Manna
vswing/pre-emphasis adjustment calculation is needed in processing of auto phy compliance request other than link training, so moved the same function in intel_dp.c. No functional change. v1: initial patch. v2: - used "intel_dp" prefix in function name. (Jani) - used array notation instead pointe

[PULL] drm-intel-fixes

2019-12-23 Thread Jani Nikula
Hi Dave & Daniel - drm-intel-fixes-2019-12-23: i915 power and frontbuffer tracking fixes No test results on this yet, but I'll let you know later in the week if there are any issues in https://intel-gfx-ci.01.org/tree/drm-intel-fixes/index.html BR, Jani. The following changes since commit 46

Recall: [PATCH v3 3/9] drm/i915/dp: Move vswing/pre-emphasis adjustment calculation

2019-12-23 Thread Manna, Animesh
Manna, Animesh would like to recall the message, "[PATCH v3 3/9] drm/i915/dp: Move vswing/pre-emphasis adjustment calculation". ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH v3 1/9] drm/amd/display: Align macro name as per DP spec

2019-12-23 Thread Animesh Manna
[Why]: Aligh with DP spec wanted to follow same naming convention. [How]: Changed the macro name of the dpcd address used for getting requested test-pattern. Cc: Harry Wentland Cc: Alex Deucher Signed-off-by: Animesh Manna --- drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 2 +- include/d

  1   2   >