RE: [PATCH v4 06/13] drm/bridge: lvds-codec: Add "lvds-decoder" support

Hi Laurent, Thank you for your feedback! > From: Laurent Pinchart > Sent: 13 December 2019 17:11 > Subject: Re: [PATCH v4 06/13] drm/bridge: lvds-codec: Add "lvds-decoder" > support > > Hi Fabrizio, > > On Wed, Nov 13, 2019 at 03:51:25PM +, Fabrizio Castro wrote: > > Add support for trans

[PATCH v6 4/6] drm: rcar-du: lvds: Allow for even and odd pixels swap

DT properties dual-lvds-even-pixels and dual-lvds-odd-pixels can be used to work out if the driver needs to swap even and odd pixels around. This patch makes use of the return value from function drm_of_lvds_get_dual_link_pixel_order to determine if we need to swap odd and even pixels around for t

RE: [PATCH v4 06/13] drm/bridge: lvds-codec: Add "lvds-decoder" support

Hi Geert, Thank you for your feedback! > From: linux-renesas-soc-ow...@vger.kernel.org > On Behalf Of Geert Uytterhoeven > Sent: 17 December 2019 12:21 > Subject: Re: [PATCH v4 06/13] drm/bridge: lvds-codec: Add "lvds-decoder" > support > > Hi Fabrizio, > > On Tue, Dec 17, 2019 at 12:03 PM F

[PATCH v4 5/8] ARM: DTS: omap36xx: add sgx gpu child node

and add interrupt. Tested-by: H. Nikolaus Schaller # GTA04, BeagleBoard XM Signed-off-by: H. Nikolaus Schaller --- arch/arm/boot/dts/omap36xx.dtsi | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/arch/arm/boot/dts/omap36xx.dtsi b/arch/arm/boot/dts/omap36xx.dtsi in

[PATCH v6 1/6] drm: of: Add drm_of_lvds_get_dual_link_pixel_order

An LVDS dual-link connection is made of two links, with even pixels transitting on one link, and odd pixels on the other link. The device tree can be used to fully describe dual-link LVDS connections between encoders and bridges/panels. The sink of an LVDS dual-link connection is made of two ports,

[PATCH v4 0/8] ARM/MIPS: DTS: add child nodes describing the PVRSGX GPU present in some OMAP SoC and JZ4780 (and many more)

* MIPS: DTS: jz4780: removed "img,sgx5" from bindings * YAML bindings: updated according to suggestions by Rob Herring * MIPS: DTS: jz4780: insert-sorted gpu node by register address - suggested by Paul Cercueil PATCH V3 2019-11-24 12:40:33: * reworked YAML format with help by Rob Herring * remov

Re: [PATCH 1/1] drm/sun4i: hdmi: Check for null pointer before cleanup

Hi, On 12/17/19 1:49 PM, Maxime Ripard wrote: On Tue, Dec 17, 2019 at 12:46:03PM +0100, Maxime Ripard wrote: On Tue, Dec 17, 2019 at 08:45:07AM +0200, Stefan Mavrodiev wrote: Hi, On 12/16/19 6:12 PM, Maxime Ripard wrote: Hi, On Mon, Dec 16, 2019 at 04:43:48PM +0200, Stefan Mavrodiev wrote:

[PATCH v6 3/6] drm: rcar-du: lvds: Get dual link configuration from DT

For dual-LVDS configurations, it is now possible to mark the DT port nodes for the sink with boolean properties (like dual-lvds-even-pixels and dual-lvds-odd-pixels) to let drivers know the encoders need to be configured in dual-LVDS mode. Rework the implementation of rcar_lvds_parse_dt_companion

[PATCH v4 1/8] dt-bindings: add img,pvrsgx.yaml for Imagination GPUs

The Imagination PVR/SGX GPU is part of several SoC from multiple vendors, e.g. TI OMAP, Ingenic JZ4780, Intel Poulsbo and others. With this binding, we describe how the SGX processor is interfaced to the SoC (registers, interrupt etc.). In most cases, Clock, Reset and power management is handled

[PATCH 1/1] drm/sun4i: hdmi: Remove duplicate cleanup calls

When the HDMI unbinds drm_connector_cleanup() and drm_encoder_cleanup() are called. This also happens when the connector and the encoder are destroyed. This double call triggers a NULL pointer exception. The patch fixes this by removing the cleanup calls in the unbind function. Signed-off-by: Ste

Re: [RFC v2 06/12] drm/i915/svm: Device memory support

On Fri, Dec 13, 2019 at 01:56:08PM -0800, Niranjana Vishwanathapura wrote: > @@ -169,6 +170,11 @@ static int i915_range_fault(struct svm_notifier *sn, > return ret; > } > > + /* For dgfx, ensure the range is in device local memory only */ > +

[PATCH 1/3] gpu: drm: dead code elimination

this set adds support for removal of gpu drm dead code. patch1: `num` is a data of u8 type and ATOM_MAX_HW_I2C_READ == 255, so there is a impossible condition '(num > 255) => (0-255 > 255)'. Signed-off-by: Pan Zhang --- drivers/gpu/drm/amd/amdgpu/atombios_i2c.c | 5 - 1 file changed, 5 de

Re: [PATCH v3 1/8] dt-bindings: add img, pvrsgx.yaml for Imagination GPUs

Hi Rob, sorry for the delay. I wanted to wait for v5.5-rc1 and it did take longer... > Am 05.12.2019 um 18:01 schrieb Rob Herring : > > On Sun, Nov 24, 2019 at 12:40:21PM +0100, H. Nikolaus Schaller wrote: >> The Imagination PVR/SGX GPU is part of several SoC from >> multiple vendors, e.g. TI OMA

[PATCH] fbmem: Adjust indentation in fb_prepare_logo and fb_blank

Clang warns: ../drivers/video/fbdev/core/fbmem.c:665:3: warning: misleading indentation; statement is not part of the previous 'else' [-Wmisleading-indentation] if (fb_logo.depth > 4 && depth > 4) { ^ ../drivers/video/fbdev/core/fbmem.c:661:2: note: previous statement is here

Re: [PATCH v3 2/3] dt-bindings: display: panel: Add binding document for Xinpeng XPP055C272

Hi, On Tue, Dec 17, 2019 at 03:07:02PM +0100, Heiko Stuebner wrote: > From: Heiko Stuebner > > The XPP055C272 is a 5.5" 720x1280 DSI display. > > changes in v2: > - add size info into binding title (Sam) > - add more required properties (Sam) > > Signed-off-by: Heiko Stuebner > Reviewed-by: Sam

Re: [PATCH v3 2/3] dt-bindings: display: panel: Add binding document for Xinpeng XPP055C272

On Tue, Dec 17, 2019 at 04:08:49PM +0100, Heiko Stübner wrote: > Am Dienstag, 17. Dezember 2019, 15:24:46 CET schrieb Maxime Ripard: > > Hi, > > > > On Tue, Dec 17, 2019 at 03:07:02PM +0100, Heiko Stuebner wrote: > > > From: Heiko Stuebner > > > > > > The XPP055C272 is a 5.5" 720x1280 DSI display.

Re: [PATCH v1 1/1] drm/drm_panel: Fix EXPORT of drm_panel_of_backlight() one more time

On 12/17/19 6:07 AM, Andy Shevchenko wrote: > The initial commit followed by the fix didn't take into consideration the case > > CONFIG_DRM_PANEL=y > CONFIG_BACKLIGHT_CLASS_DEVICE=m > CONFIG_DRM_I915=y > > where symbol devm_of_find_backlight() is not reachable from DRM subsystem. > Quick fix is t

[PATCH v6 6/6] arm64: dts: renesas: Add EK874 board with idk-2121wr display support

The EK874 is advertised as compatible with panel IDK-2121WR from Advantech, however the panel isn't sold alongside the board. A new dts, adding everything that's required to get the panel to to work with the EK874, is the most convenient way to support the EK874 when it's connected to the IDK-2121W

Re: Warnings in DRM code when removing/unbinding a driver

On 16/12/2019 17:23, John Garry wrote: +, - Hi all, xinliang is bouncing. We need to get his new mail address. John Enabling CONFIG_DEBUG_TEST_DRIVER_REMOVE causes many warns on a system with the HIBMC hw: [   27.788806] WARNING: CPU: 24 PID: 1 at drivers/gpu/drm/drm_gem_vram_helpe

[PATCH 2/3] gpu: drm: dead code elimination

this set adds support for removal of gpu drm dead code. patch2: `num_entries` is a data of unsigned type(compilers always treat as unsigned int) and SIZE_MAX == ~0, so there is a impossible condition: '(num_entries > ((~0) - 56) / 72) => (max(0-u32) > 256204778801521549)'. Signed-off-by: Pan Zh

RE: [PATCH v3] drm: rcar-du: lvds: Get mode from state

Hi Laurent, Thank you for your patch! > From: Laurent Pinchart > Sent: 16 December 2019 22:31 > Subject: [PATCH v3] drm: rcar-du: lvds: Get mode from state > > The R-Car LVDS encoder driver implements the bridge .mode_set() > operation for the sole purpose of storing the mode in the LVDS privat

[PATCH v4 7/8] ARM: DTS: omap5: add sgx gpu child node

and add interrupt. Tested-by: H. Nikolaus Schaller # Pyra-Handheld. Signed-off-by: H. Nikolaus Schaller --- arch/arm/boot/dts/omap5.dtsi | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot/dts/omap5.dtsi b/arch/arm/boot/dts/omap5.dtsi index 1f6ad1debc90..3

[PATCH v6 0/6] Add dual-LVDS panel support to EK874

Dear All, this series adds support for dual-LVDS panel IDK-2121WR from Advantech: https://buy.advantech.eu/Displays/Embedded-LCD-Kits-High-Brightness/model-IDK-2121WR-K2FHA2E.htm V6 reworks patch "drm: rcar-du: lvds: Allow for even and odd pixels swap", and rebases the series on top of patch: htt

[PATCH v4 4/8] ARM: DTS: omap3: add sgx gpu child node

and add interrupt Tested-by: H. Nikolaus Schaller # OpenPandora 600 MHz. Signed-off-by: H. Nikolaus Schaller --- arch/arm/boot/dts/omap34xx.dtsi | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/arch/arm/boot/dts/omap34xx.dtsi b/arch/arm/boot/dts/omap34xx.dtsi inde

[PATCH] drm/arm/mali: make malidp_mw_connector_helper_funcs static

The malidp_mw_connector_helper_funcs is not referenced by name outside of the file it is in, so make it static to avoid the following warning: drivers/gpu/drm/arm/malidp_mw.c:59:41: warning: symbol 'malidp_mw_connector_helper_funcs' was not declared. Should it be static? Signed-off-by: Ben Dooks

[PATCH v6 5/6] dt-bindings: display: Add idk-2121wr binding

Add binding for the idk-2121wr LVDS panel from Advantech. Some panel-specific documentation can be found here: https://buy.advantech.eu/Displays/Embedded-LCD-Kits-High-Brightness/model-IDK-2121WR-K2FHA2E.htm Signed-off-by: Fabrizio Castro Reviewed-by: Laurent Pinchart --- v5->v6: * No change

RE: [PATCH v4 06/13] drm/bridge: lvds-codec: Add "lvds-decoder" support

Hi guys, > From: Laurent Pinchart > Sent: 17 December 2019 13:54 > Subject: Re: [PATCH v4 06/13] drm/bridge: lvds-codec: Add "lvds-decoder" > support > > Hello, > > On Tue, Dec 17, 2019 at 01:38:51PM +0100, Geert Uytterhoeven wrote: > > On Tue, Dec 17, 2019 at 1:31 PM Fabrizio Castro wrote: >

[PATCH v4 2/8] ARM: DTS: am33xx: add sgx gpu child node

and add timer and interrupt Tested-by: H. Nikolaus Schaller # BeagleBone Black Signed-off-by: H. Nikolaus Schaller --- arch/arm/boot/dts/am33xx.dtsi | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi index c

[PATCH v4 8/8] MIPS: DTS: jz4780: add sgx gpu node

and add interrupt and clocks. Tested to build for CI20 board and load a (non-working - there is no video driver for jz4780) driver. Suggested-by: Paul Boddie Signed-off-by: H. Nikolaus Schaller --- arch/mips/boot/dts/ingenic/jz4780.dtsi | 11 +++ 1 file changed, 11 insertions(+) diff

Re: [PATCH 09/12] drm/rockchip: lvds: Add PX30 support【请注意，邮件由linux-rockchip-bounces+sandy.huang=rock-chips....@lists.infradead.org代发】

Hi Maxime & Miquel, 在 2019/12/16 下午7:14, Maxime Ripard 写道: On Mon, Dec 16, 2019 at 12:03:12PM +0100, Miquel Raynal wrote: Maxime Ripard wrote on Mon, 16 Dec 2019 11:58:27 +0100: Hi, On Fri, Dec 13, 2019 at 07:10:48PM +0100, Miquel Raynal wrote: +static int px30_lvds_grf_config(struct drm_en

Re: Warnings in DRM code when removing/unbinding a driver

Hi Ezequiel, On Mon, 2019-12-16 at 17:23 +, John Garry wrote: Hi all, Enabling CONFIG_DEBUG_TEST_DRIVER_REMOVE causes many warns on a system with the HIBMC hw: [ 27.788806] WARNING: CPU: 24 PID: 1 at drivers/gpu/drm/drm_gem_vram_helper.c:564 bo_driver_move_notify+0x8c/0x98 A total sho

Re: [RFC v2 05/12] drm/i915/svm: Page table mirroring support

On Fri, Dec 13, 2019 at 01:56:07PM -0800, Niranjana Vishwanathapura wrote: > +static struct i915_svm *vm_get_svm(struct i915_address_space *vm) > +{ > + struct i915_svm *svm = vm->svm; > + > + mutex_lock(&vm->svm_mutex); > + if (svm && !kref_get_unless_zero(&svm->ref)) > + s

[PATCH v4 3/8] ARM: DTS: am3517: add sgx gpu child node

and add interrupt. Signed-off-by: H. Nikolaus Schaller --- arch/arm/boot/dts/am3517.dtsi | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/arch/arm/boot/dts/am3517.dtsi b/arch/arm/boot/dts/am3517.dtsi index 125379ecab2f..6d2ad5e5f1a6 100644 --- a/arch/arm/boot/dts/a

RE: [PATCH v5 4/6] drm: rcar-du: lvds: Allow for even and odd pixels swap

Hi Laurent, Thank you for your feedback! > From: Laurent Pinchart > Sent: 16 December 2019 21:35 > Subject: Re: [PATCH v5 4/6] drm: rcar-du: lvds: Allow for even and odd pixels > swap > > Hi Fabrizio, > > Thank you for the patch. > > On Mon, Dec 16, 2019 at 08:12:32PM +, Fabrizio Castro

[PATCH v4 6/8] ARM: DTS: omap4: add sgx gpu child node

and add interrupt. Since omap4420/30/60 and omap4470 come with different SGX variants we need to introduce a new omap4470.dtsi. If an omap4470 board does not want to use SGX it is no problem to still include omap4460.dtsi. Tested-by: H. Nikolaus Schaller # PandaBoard ES Signed-off-by: H. Nikolau

[PATCH v4 3/3] drm/i915: Add support for integrated privacy screens

Certain laptops now come with panels that have integrated privacy screens on them. This patch adds support for such panels by adding a privacy-screen property to the intel_connector for the panel, that the userspace can then use to control and check the status. Identifying the presence of privacy

Re: [PATCH] drm/nouveau/mmu: Remove unneeded semicolon

With the comment further below addressed, this patch is Reviewed-by: Pierre Moreau On 2019-12-16 — 11:48, zhengbin wrote: > Fixes coccicheck warning: > > drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmm.c:583:2-3: Unneeded semicolon > drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmm.h:307:2-3: Unneeded se

Re: [RFC v2 02/12] drm/i915/svm: Runtime (RT) allocator support

On Fri, Dec 13, 2019 at 01:56:04PM -0800, Niranjana Vishwanathapura wrote: > + ctx = i915_gem_context_lookup(file->driver_priv, args->rsvd1); > + if (!ctx || !rcu_access_pointer(ctx->vm)) > + return -ENOENT; > + > + rcu_read_lock(); > + vm = i915_vm_get(ctx->vm); > +

[PATCH v1 1/1] drm/drm_panel: Fix EXPORT of drm_panel_of_backlight() one more time

The initial commit followed by the fix didn't take into consideration the case CONFIG_DRM_PANEL=y CONFIG_BACKLIGHT_CLASS_DEVICE=m CONFIG_DRM_I915=y where symbol devm_of_find_backlight() is not reachable from DRM subsystem. Quick fix is to avoid drm_panel_of_backlight() from exporting in such case

Re: [PATCH v21 1/2] Documentation: bridge: Add documentation for ps8640 DT properties

On Mon, Dec 16, 2019 at 02:58:33PM +0100, Enric Balletbo i Serra wrote: > From: Jitao Shi > > Add documentation for DT properties supported by > ps8640 DSI-eDP converter. > > Signed-off-by: Jitao Shi > Acked-by: Rob Herring > Reviewed-by: Philipp Zabel > Signed-off-by: Ulrich Hecht > Signed-of

[PATCH 3/3] gpu: drm: dead code elimination

this set adds support for removal of gpu drm dead code. patch3 is similar with patch 1: `num` is a data of u8 type and ATOM_MAX_HW_I2C_READ == 255, so there is a impossible condition '(num > 255) => (0-255 > 255)'. Signed-off-by: Pan Zhang --- drivers/gpu/drm/radeon/atombios_i2c.c | 5 - 1

[PATCH v2] drm/nouveau/mmu: Remove unneeded semicolon

Fixes coccicheck warning: drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmm.c:583:2-3: Unneeded semicolon drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmm.h:307:2-3: Unneeded semicolon Reported-by: Hulk Robot Signed-off-by: zhengbin --- v1->v2: add missing one space after the closing curly bracket driver

[PATCH v6 2/6] drm: rcar-du: lvds: Improve identification of panels

Dual-LVDS panels are mistakenly identified as bridges, this commit replaces the current logic with a call to drm_of_find_panel_or_bridge to sort that out. Signed-off-by: Fabrizio Castro Reviewed-by: Laurent Pinchart --- v5->v6: * No change v4->v5: * Addressed comments from Laurent's review v3

Re: [PATCH] udmabuf: fix dma-buf cpu access

On Tue, Dec 17, 2019 at 03:02:28PM -0800, Gurchetan Singh wrote: > I'm just going to put Chia's review comment here since it sums > the issue rather nicely: > > "(1) Semantically, a dma-buf is in DMA domain. CPU access from the > importer must be surrounded by {begin,end}_cpu_access. This gives

Re: [PATCH 09/12] drm/rockchip: lvds: Add PX30 support

Hi     some mistakes with last mail, so resend this mail. 在 2019/12/18 上午11:17, sandy.huang 写道: Hi Maxime & Miquel, 在 2019/12/16 下午7:14, Maxime Ripard 写道: On Mon, Dec 16, 2019 at 12:03:12PM +0100, Miquel Raynal wrote: Maxime Ripard wrote on Mon, 16 Dec 2019 11:58:27 +0100: Hi, On Fri, Dec

[PATCH] fbcon: Adjust indentation in set_con2fb_map

Clang warns: ../drivers/video/fbdev/core/fbcon.c:915:3: warning: misleading indentation; statement is not part of the previous 'if' [-Wmisleading-indentation] return err; ^ ../drivers/video/fbdev/core/fbcon.c:912:2: note: previous statement is here if (!search_fb_in_map(inf

Re: [PATCH 2/3] dt-bindings: display: panel: Add binding document for Leadtek LTK500HD1829

On Tue, Dec 17, 2019 at 03:09:48PM +0100, Heiko Stuebner wrote: > From: Heiko Stuebner > > The LTK500HD1829 is a 5.0" 720x1280 DSI display. > > Signed-off-by: Heiko Stuebner > --- > .../display/panel/leadtek,ltk500hd1829.yaml | 48 +++ > 1 file changed, 48 insertions(+) > crea

Re: [PATCH 0/9] *** virtgpu cleanups ***

On Tue, Dec 17, 2019 at 04:59:20PM -0800, Gurchetan Singh wrote: > With so many new features on the horizon, perhaps it's > time to do a little "winter cleaning" beforehand. Enjoy! > > drm/virtio: static-ify virtio_gpu_framebuffer_init Doesn't apply cleanly. What kernel is this against? > d

Re: powernv build issue

Hi David. On Mon, Dec 16, 2019 at 07:03:17PM +0100, David Hildenbrand wrote: > Hi, > > the patch "drm/drm_panel: fix EXPORT of drm_panel_of_backlight" in > linux-next breaks the powernv build: > > desktop: ~/git/linux-ppc memtrace $ ./compile.sh > CALLscripts/atomic/check-atomics.sh > CA

Re: [PATCH 2/3] mfd: intel_soc_pmic: Rename pwm_backlight pwm-lookup to pwm_pmic_backlight

On Wed, 18 Dec 2019, Jani Nikula wrote: > On Tue, 17 Dec 2019, Lee Jones wrote: > > Hans was making the case that this was impractical for DRM, due to the > > amount of churn you guys receive, hence the discussion. I'm very > > pleased that this is not the case. > > Heh, well, it is the case, b

Re: [PATCH v2] drm/nouveau/mmu: Remove unneeded semicolon

Reviewed-by: Pierre Moreau On 2019-12-18 — 09:28, zhengbin wrote: > Fixes coccicheck warning: > > drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmm.c:583:2-3: Unneeded semicolon > drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmm.h:307:2-3: Unneeded semicolon > > Reported-by: Hulk Robot > Signed-off-by: z

Re: [PATCH 2/3] gpu: drm: dead code elimination

On 2019-12-18 4:50 a.m., Pan Zhang wrote: > this set adds support for removal of gpu drm dead code. > > patch2: > `num_entries` is a data of unsigned type(compilers always treat as unsigned > int) and SIZE_MAX == ~0, > > so there is a impossible condition: > '(num_entries > ((~0) - 56) / 72) =>

Re: [PATCH 2/3] gpu: drm: dead code elimination

Am 18.12.19 um 04:50 schrieb Pan Zhang: this set adds support for removal of gpu drm dead code. patch2: `num_entries` is a data of unsigned type(compilers always treat as unsigned int) and SIZE_MAX == ~0, so there is a impossible condition: '(num_entries > ((~0) - 56) / 72) => (max(0-u32) > 25

Re: [RFC PATCH v2 08/11] arm: dts: exynos: Add parents and #interconnect-cells to Exynos4412

Hi 2019년 12월 18일 (수) 오후 7:18, Artur Świgoń 님이 작성: > > Hi, > > On Mon, 2019-12-16 at 11:59 +0900, Chanwoo Choi wrote: > > Hi, > > > > On 12/16/19 9:51 AM, Chanwoo Choi wrote: > > > On 9/19/19 11:22 PM, Artur Świgoń wrote: > > > > From: Artur Świgoń > > > > > > > > This patch adds two fields to the

Re: [PATCH v1 1/1] drm/drm_panel: Fix EXPORT of drm_panel_of_backlight() one more time

On Tue, 17 Dec 2019, Sam Ravnborg wrote: > On Tue, Dec 17, 2019 at 08:25:03AM -0800, Randy Dunlap wrote: >> On 12/17/19 6:07 AM, Andy Shevchenko wrote: >> > The initial commit followed by the fix didn't take into consideration the >> > case >> > >> > CONFIG_DRM_PANEL=y >> > CONFIG_BACKLIGHT_CLAS

Re: [RFC PATCH v2 09/11] devfreq: exynos-bus: Add interconnect functionality to exynos-bus

Hi, 2019년 12월 18일 (수) 오후 7:19, Artur Świgoń 님이 작성: > > Hi, > > Thank you for the review. > > On Mon, 2019-12-16 at 09:44 +0900, Chanwoo Choi wrote: > > Hi, > > > > On 9/19/19 11:22 PM, Artur Świgoń wrote: > > > From: Artur Świgoń > > > > > > This patch adds interconnect functionality to the exyno

Re: [PATCH v1 1/1] drm/drm_panel: Fix EXPORT of drm_panel_of_backlight() one more time

Hi Jani. > As I wrote in [1], this allows a configuration that builds and links, > but is silently broken. You won't get backlight support in drm panel > which would be a reasonable expectation with > CONFIG_BACKLIGHT_CLASS_DEVICE=m. Agreed - it needs to be improved. But right now we had to fix t

Re: [RFC PATCH v2 09/11] devfreq: exynos-bus: Add interconnect functionality to exynos-bus

Hi, If possible, I'd like to apply these patches to v5.6-rc1. It is very useful feature to support the QoS for user device using memory bus. 2019년 12월 18일 (수) 오후 7:48, Artur Świgoń 님이 작성: > > On Wed, 2019-12-18 at 19:39 +0900, Chanwoo Choi wrote: > > Hi, > > > > 2019년 12월 18일 (수) 오후 7:19, Artur Ś

Re: [GIT PULL FOR v5.6] R-Car DU & LVDS decoder

Hi, On 18/12/2019 01:44, Laurent Pinchart wrote: > Hi Neil, > > On Tue, Dec 17, 2019 at 02:23:57PM +0100, Neil Armstrong wrote: >> On 17/12/2019 13:43, Daniel Vetter wrote: >>> On Thu, Nov 28, 2019 at 04:45:24AM +0200, Laurent Pinchart wrote: Hi Dave, The following changes since co

Re: [PATCH v3 30/50] drm/omap: hdmi4: Move mode set, enable and disable operations to bridge

On 11/12/2019 00:57, Laurent Pinchart wrote: Move the omap_dss_device .set_timings(), .enable() and .disable() operations to the drm_bridge functions. As the drm_bridge for the HDMI encoder is unconditionally registered and attached, those operations will be called at the appropriate time. The o

Re: [PATCH v3 31/50] drm/omap: hdmi5: Move mode set, enable and disable operations to bridge

On 11/12/2019 00:57, Laurent Pinchart wrote: Move the omap_dss_device .set_timings(), .enable() and .disable() operations to the drm_bridge functions. As the drm_bridge for the HDMI encoder is unconditionally registered and attached, those operations will be called at the appropriate time. The o

Re: [PATCH v3 32/50] drm/omap: hdmi4: Implement drm_bridge .hpd_notify() operation

On 11/12/2019 00:57, Laurent Pinchart wrote: The HDMI4 encoder is transitioning to the drm_bridge API, implement the last missing operation. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/omapdrm/dss/hdmi4.c | 10 ++ 1 file changed, 10 insertions(+) Reviewed-by: Tomi Valkeinen

Re: [PATCH v3 33/50] drm/omap: dss: Remove .set_hdmi_mode() and .set_infoframe() operations

On 11/12/2019 00:57, Laurent Pinchart wrote: The omapdss_hdmi_ops .set_hdmi_mode() and .set_infoframe() operations operations are not used anymore, remove them. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/omapdrm/dss/omapdss.h | 3 --- drivers/gpu/drm/omapdrm/omap_encoder.c | 26 --

Re: [PATCH v4 00/13] Add LCD panel support to iwg20d

Hi, On 13/11/2019 16:51, Fabrizio Castro wrote: > The iW-RainboW-G20D-Qseven RZ/G1M,G1N Qseven Development Platform > comes with a 7" capacitive display kit from Emerging Display > Technologies Corporation (EDT). This series adds all that's > necessary for supporting it. > > Thanks, > Fab > > v3

Re: [PATCH v3 34/50] drm/omap: venc: Register a drm_bridge

On 11/12/2019 00:57, Laurent Pinchart wrote: In order to integrate with a chain of drm_bridge, the internal VENC encoder has to expose the mode valid, fixup and set, the enable and disable and the get modes operations through the drm_bridge API. Register a bridge at initialisation time to do so.

Re: linux-next: build failure after merge of the drm-misc tree

On Tue, Dec 17, 2019 at 9:22 PM Stephen Rothwell wrote: > > Hi Daniel, > > On Tue, 17 Dec 2019 14:19:37 +0100 Daniel Vetter wrote: > > > > On Mon, Dec 16, 2019 at 12:23:31PM +1100, Stephen Rothwell wrote: > > > > > > After merging the drm-misc tree, today's linux-next build (x86_64 > > > allmodco

Re: [GIT PULL FOR v5.6] R-Car DU & LVDS decoder

On 18/12/2019 12:22, Neil Armstrong wrote: > Hi, > > On 18/12/2019 01:44, Laurent Pinchart wrote: >> Hi Neil, >> >> On Tue, Dec 17, 2019 at 02:23:57PM +0100, Neil Armstrong wrote: >>> On 17/12/2019 13:43, Daniel Vetter wrote: On Thu, Nov 28, 2019 at 04:45:24AM +0200, Laurent Pinchart wrote: >

[PATCH v3 6/6] Revert "drm: atmel-hlcdc: enable sys_clk during initalization."

This reverts commit d2c755e66617620b729041c625a6396c81d1231c ("drm: atmel-hlcdc: enable sys_clk during initalization."). With commit "drm: atmel-hlcdc: enable clock before configuring timing engine" there is no need for this patch. Code is also simpler. Cc: Sandeep Sheriker Mallikarjun Signed-off

Re: [RFC PATCH v2 09/11] devfreq: exynos-bus: Add interconnect functionality to exynos-bus

Hi, Thank you for the review. On Mon, 2019-12-16 at 09:44 +0900, Chanwoo Choi wrote: > Hi, > > On 9/19/19 11:22 PM, Artur Świgoń wrote: > > From: Artur Świgoń > > > > This patch adds interconnect functionality to the exynos-bus devfreq > > driver. > > > > The SoC topology is a graph (or, more

Re: [RFC PATCH v2 09/11] devfreq: exynos-bus: Add interconnect functionality to exynos-bus

On Wed, 2019-12-18 at 19:39 +0900, Chanwoo Choi wrote: > Hi, > > 2019년 12월 18일 (수) 오후 7:19, Artur Świgoń 님이 작성: > > > > Hi, > > > > Thank you for the review. > > > > On Mon, 2019-12-16 at 09:44 +0900, Chanwoo Choi wrote: > > > Hi, > > > > > > On 9/19/19 11:22 PM, Artur Świgoń wrote: > > > > Fr

[PATCH v3 1/6] drm: atmel-hlcdc: use double rate for pixel clock only if supported

Doubled system clock should be used as pixel cock source only if this is supported. This is emphasized by the value of atmel_hlcdc_crtc::dc::desc::fixed_clksrc. Fixes: a6eca2abdd42 ("drm: atmel-hlcdc: add config option for clock selection") Signed-off-by: Claudiu Beznea --- drivers/gpu/drm/atmel

[PATCH] drm/bridge: panel: Fix typo in drm_panel_bridge_add docs

Fix the 'manged' typo with 'managed' in the drm_panel_bridge_add kernel-doc documentation. Signed-off-by: Enric Balletbo i Serra --- drivers/gpu/drm/bridge/panel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/panel.c b/drivers/gpu/drm/bridge/panel.c

[PATCH v3 4/6] mfd: atmel-hlcdc: return in case of error

For HLCDC timing engine configurations bit ATMEL_HLCDC_SIP of ATMEL_HLCDC_SR needs to be polled before applying new config. In case of timeout there is no indicator about this, so, return in case of timeout and also print a message about this. Signed-off-by: Claudiu Beznea Acked-for-MFD-by: Lee J

[PATCH] gpu/drm/v3d: Add ARCH_BCM2835 to DRM_V3D Kconfig

On arm64 the config ARCH_BCM doesn't exist so to be able to build for platforms such as the Raspberry Pi 4 we need to add ARCH_BCM2835 similar to what has been done on vc4. Signed-off-by: Peter Robinson --- drivers/gpu/drm/v3d/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -

[PATCH v3 0/6] fixes for atmel-hlcdc

Hi, I have few fixes for atmel-hlcdc driver in this series as well as two reverts. Revert "drm: atmel-hlcdc: enable sys_clk during initalization." is due to the fix in in patch 2/5. Thank you, Claudiu Beznea Changes in v3: - changes dev_err() message in patch 4/6 - collect Acked-by tags Changes

[PATCH v3 2/6] drm: atmel-hlcdc: enable clock before configuring timing engine

Changing pixel clock source without having this clock source enabled will block the timing engine and the next operations after (in this case setting ATMEL_HLCDC_CFG(5) settings in atmel_hlcdc_crtc_mode_set_nofb() will fail). It is recomended (although in datasheet this is not present) to actually

Re: [RFC PATCH v2 08/11] arm: dts: exynos: Add parents and #interconnect-cells to Exynos4412

Hi, On Mon, 2019-12-16 at 11:59 +0900, Chanwoo Choi wrote: > Hi, > > On 12/16/19 9:51 AM, Chanwoo Choi wrote: > > On 9/19/19 11:22 PM, Artur Świgoń wrote: > > > From: Artur Świgoń > > > > > > This patch adds two fields to the Exynos4412 DTS: > > > - parent: to declare connections between node

Re: [PATCH v2 4/6] mfd: atmel-hlcdc: return in case of error

On 16.12.2019 18:24, Lee Jones wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On Fri, 13 Dec 2019, Claudiu Beznea wrote: > >> For HLCDC timing engine configurations bit ATMEL_HLCDC_SIP of >> ATMEL_HLCDC_SR needs to be polled before app

Re: [RFC PATCH v2 08/11] arm: dts: exynos: Add parents and #interconnect-cells to Exynos4412

On Wed, 2019-12-18 at 19:29 +0900, Chanwoo Choi wrote: > Hi > > 2019년 12월 18일 (수) 오후 7:18, Artur Świgoń 님이 작성: > > > > Hi, > > > > On Mon, 2019-12-16 at 11:59 +0900, Chanwoo Choi wrote: > > > Hi, > > > > > > On 12/16/19 9:51 AM, Chanwoo Choi wrote: > > > > On 9/19/19 11:22 PM, Artur Świgoń wrot

[PATCH v3 3/6] mfd: atmel-hlcdc: add struct device member to struct atmel_hlcdc_regmap

Add struct device member to struct atmel_hlcdc_regmap to be able to use dev_*() specific logging functions. Signed-off-by: Claudiu Beznea Acked-for-MFD-by: Lee Jones --- drivers/mfd/atmel-hlcdc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/mfd/atmel-hlcdc.c b/drivers/mfd/atme

Re: [PATCH v4 2/3] dt-bindings: display: panel: Add binding document for Xinpeng XPP055C272

On Tue, Dec 17, 2019 at 11:29:05PM +0100, Heiko Stuebner wrote: > From: Heiko Stuebner > > The XPP055C272 is a 5.5" 720x1280 DSI display. > > changes in v4: > - fix id (Maxime) > - drop port (Maxime) > changes in v2: > - add size info into binding title (Sam) > - add more required properties (Sam)

Re: [PATCH v21 2/2] drm/bridge: Add I2C based driver for ps8640 bridge

Hi Laurent, Many thanks for the quick response and the review. Just preparing a new version to send. On 16/12/19 17:32, Laurent Pinchart wrote: > Hello Enric and Jitao, > > Thank you for the patch. > > On Mon, Dec 16, 2019 at 02:58:34PM +0100, Enric Balletbo i Serra wrote: >> From: Jitao Shi >

[PATCH v3 5/6] drm: atmel-hlcdc: prefer a lower pixel-clock than requested

From: Peter Rosin The intention was to only select a higher pixel-clock rate than the requested, if a slight overclocking would result in a rate significantly closer to the requested rate than if the conservative lower pixel-clock rate is selected. The fixed patch has the logic the other way arou

RE: [PATCH v4 06/13] drm/bridge: lvds-codec: Add "lvds-decoder" support

> From: linux-renesas-soc-ow...@vger.kernel.org > On Behalf Of Laurent Pinchart > Sent: 17 December 2019 23:09 > Subject: Re: [PATCH v4 06/13] drm/bridge: lvds-codec: Add "lvds-decoder" > support > > On Tue, Dec 17, 2019 at 10:06:14PM +, Fabrizio Castro wrote: > > On 17 December 2019 13:54,

Re: [PATCH v3 35/50] drm/omap: Create connector for bridges

On 11/12/2019 00:57, Laurent Pinchart wrote: Use the drm_bridge_connector helper to create a connector for pipelines that use drm_bridge. This allows splitting connector operations across multiple bridges when necessary, instead of having the last bridge in the chain creating the connector and ha

[PATCH v4 2/3] drm/virtio: fix mmap page attributes

virtio-gpu uses cached mappings, set drm_gem_shmem_object.map_cached accordingly. Reported-by: Gurchetan Singh Signed-off-by: Gerd Hoffmann virtio fixup --- drivers/gpu/drm/virtio/virtgpu_object.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/virtio/virtgpu_object.c b/dr

[PATCH v4 0/3] drm/virtio: fix mmap page attributes

v4: back to v2-ish design, but simplified a bit. v3: switch to drm_gem_object_funcs callback. v2: make shmem helper caching configurable. Gerd Hoffmann (3): drm/shmem: add support for per object caching flags. drm/virtio: fix mmap page attributes drm/udl: simplify gem object mapping. inclu

[PATCH v4 3/3] drm/udl: simplify gem object mapping.

With shmem helpers allowing to update pgprot caching flags via drm_gem_shmem_object.map_cached we can just use that and ditch our own implementations of mmap() and vmap(). We also don't need a special case for imported objects, any map requests are handled by the exporter not udl. Signed-off-by:

[PATCH v4 1/3] drm/shmem: add support for per object caching flags.

Add map_cached bool to drm_gem_shmem_object, to request cached mappings on a per-object base. Check the flag before adding writecombine to pgprot bits. Signed-off-by: Gerd Hoffmann --- include/drm/drm_gem_shmem_helper.h | 5 + drivers/gpu/drm/drm_gem_shmem_helper.c | 12 +--- 2

Re: [GIT PULL FOR v5.6] R-Car DU & LVDS decoder

Hi Neil, On Wed, Dec 18, 2019 at 12:55:24PM +0100, Neil Armstrong wrote: > On 18/12/2019 12:22, Neil Armstrong wrote: > > On 18/12/2019 01:44, Laurent Pinchart wrote: > >> On Tue, Dec 17, 2019 at 02:23:57PM +0100, Neil Armstrong wrote: > >>> On 17/12/2019 13:43, Daniel Vetter wrote: > On Thu,

Re: [PATCH] drm/bridge: panel: Fix typo in drm_panel_bridge_add docs

Hi Enric, Thank you for the patch. On Wed, Dec 18, 2019 at 01:12:23PM +0100, Enric Balletbo i Serra wrote: > Fix the 'manged' typo with 'managed' in the drm_panel_bridge_add > kernel-doc documentation. > > Signed-off-by: Enric Balletbo i Serra Reviewed-by: Laurent Pinchart > --- > > driver

Re: [PATCH v3 36/50] drm/omap: Switch the HDMI and VENC outputs to drm_bridge

On 11/12/2019 00:57, Laurent Pinchart wrote: The TPD12S015, OPA362 and analog and HDMI connectors are now supported by DRM bridge drivers, and the omapdrm HDMI and VENC outputs can be handled through the drm_bridge API. Switch the outputs to drm_bridge by making the next bridge mandatory and remo

Re: [PATCH RESEND] drm/msm/adreno: Do not print error on "qcom,gpu-pwrlevels" absence

Hi Rob, On Tue, Dec 10, 2019 at 8:12 PM Fabio Estevam wrote: > > Booting the adreno driver on a imx53 board leads to the following > error message: > > adreno 3000.gpu: [drm:adreno_gpu_init] *ERROR* Could not find the GPU > powerlevels > > As the "qcom,gpu-pwrlevels" property is optional and

Re: [PATCH v3 00/50] drm/omap: Replace custom display drivers with drm_bridge and drm_panel

Hi Tomi, On Wed, Dec 18, 2019 at 09:07:52AM +0200, Tomi Valkeinen wrote: > On 18/12/2019 04:03, Laurent Pinchart wrote: > >> Hopefully we can soon have this series landed so we can start > >> working on top of the new bridge/connector handling. > >> > >> I assume it will be applied direct to drm-m

Re: [Intel-gfx] [PATCH 1/5] drm: Add __drm_atomic_helper_crtc_state_reset() & co.

On Fri, Dec 13, 2019 at 03:38:53PM -0800, Lucas De Marchi wrote: > On Thu, Nov 07, 2019 at 04:24:13PM +0200, Ville Syrjälä wrote: > >From: Ville Syrjälä > > > >Annoyingly __drm_atomic_helper_crtc_reset() does two > >totally separate things: > >a) reset the state to defaults values > >b) assign the

[GIT PULL FOR v5.6] R-Car DU new features

Hi Dave and Daniel, The following changes since commit d1eef1c619749b2a57e514a3fa67d9a516ffa919: Linux 5.5-rc2 (2019-12-15 15:16:08 -0800) are available in the Git repository at: git://linuxtv.org/pinchartl/media.git tags/du-next-20191218 for you to fetch changes up to

Re: [GIT PULL FOR v5.6] R-Car DU new features

git://linuxtv.org/pinchartl/media.git tags/du-next-20191218 > > for you to fetch changes up to c267782c5f0efbd20c560101738e68bb30d4fad5: > > drm: rcar-du: Add r8a77980 support (2019-12-18 02:40:29 +0200) > > --

[PATCH v2 0/9] DP Phy compliance auto test

Driver changes mainly to process the request coming from Test equipment as short pulse hpd interrupt to change link-pattern/v-swing/pre-emphasis Complete auto test suite takes much lesser time than manual run. Overall design: -- Automate test request will come to source device as HDP s

[PATCH v2 1/9] drm/dp: get/set phy compliance pattern

During phy compliance auto test mode source need to read requested test pattern from sink through DPCD. After processing the request source need to set the pattern. So set/get method added in drm layer as it is DP protocol. v2: As per review feedback from Manasi on RFC version, - added dp revision

[PATCH v2 2/9] drm/amd/display: Fix compilation issue.

[Why]: Aligh with DP spec wanted to follow same naming convention. [How]: Changed the macro name of the dpcd address used for getting requested test-pattern. Cc: Harry Wentland Cc: Alex Deucher Signed-off-by: Animesh Manna --- drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 2 +- 1 file ch

  1   2   >