[PATCH] drm/amd/display: fix undefined struct member reference

2019-12-10 Thread Arnd Bergmann
An initialization was added for two optional struct members. One of these is always present in the dcn20_resource file, but the other one depends on CONFIG_DRM_AMD_DC_DSC_SUPPORT and causes a build failure if that is missing: drivers/gpu/drm/amd/amdgpu/../display/dc/dcn20/dcn20_resource.c:926:14:

Re: [PATCH 3/5] mfd: atmel-hlcdc: return in case of error

2019-12-10 Thread Sam Ravnborg
Hi Claudiu. On Tue, Dec 10, 2019 at 03:24:45PM +0200, Claudiu Beznea wrote: > For HLCDC timing engine configurations bit ATMEL_HLCDC_SIP of > ATMEL_HLCDC_SR needs to checked if it is equal with zero before applying > new configuration to timing engine. In case of timeout there is no > indicator ab

[PATCH] drm: tegra: mark PM functions as __maybe_unused

2019-12-10 Thread Arnd Bergmann
Without CONFIG_PM, some functions cause harmless warnings: drivers/gpu/drm/tegra/sor.c:3984:12: error: 'tegra_sor_resume' defined but not used [-Werror=unused-function] static int tegra_sor_resume(struct device *dev) ^~~~ drivers/gpu/drm/tegra/sor.c:3970:12: error: 'tegra

Re: [PATCH] drm/amd/display: include linux/slab.h where needed

2019-12-10 Thread Arnd Bergmann
On Tue, Dec 10, 2019 at 9:30 PM Kazlauskas, Nicholas wrote: > > On 2019-12-10 2:59 p.m., Arnd Bergmann wrote: > > Calling kzalloc() and related functions requires the > > linux/slab.h header to be included: > > > > drivers/gpu/drm/amd/amdgpu/../display/dc/dcn21/dcn21_resource.c: In > > function '

RE: [PATCH] drm/amd/display: fix undefined struct member reference

2019-12-10 Thread Liu, Zhan
> -Original Message- > From: Arnd Bergmann > Sent: 2019/December/10, Tuesday 3:31 PM > To: Wentland, Harry ; Li, Sun peng (Leo) > ; Deucher, Alexander > ; Koenig, Christian > ; Zhou, David(ChunMing) > ; David Airlie ; Daniel Vetter > ; Liu, Zhan > Cc: Arnd Bergmann ; Laktyushkin, Dmytro

Re: [PATCH] drm/amd/display: fix undefined struct member reference

2019-12-10 Thread Kazlauskas, Nicholas
On 2019-12-10 3:54 p.m., Liu, Zhan wrote: -Original Message- From: Arnd Bergmann Sent: 2019/December/10, Tuesday 3:31 PM To: Wentland, Harry ; Li, Sun peng (Leo) ; Deucher, Alexander ; Koenig, Christian ; Zhou, David(ChunMing) ; David Airlie ; Daniel Vetter ; Liu, Zhan Cc: Arnd Bergm

Re: [PATCH v4] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges

2019-12-10 Thread Karol Herbst
On Tue, Dec 10, 2019 at 8:58 PM Dave Airlie wrote: > > On Mon, 9 Dec 2019 at 21:39, Rafael J. Wysocki wrote: > > > > On Mon, Dec 9, 2019 at 12:17 PM Karol Herbst wrote: > > > > > > anybody any other ideas? > > > > Not yet, but I'm trying to collect some more information. > > > > > It seems that

[PATCH AUTOSEL 5.4 127/350] drm/amdgpu: fix amdgpu trace event print string format error

2019-12-10 Thread Sasha Levin
From: Kevin Wang [ Upstream commit 2c2fdb8bca290c439e383cfb6857b0c65e528964 ] the trace event print string format error. (use integer type to handle string) before: amdgpu_test_kev-1556 [002] 138.508781: amdgpu_cs_ioctl: sched_job=8, timeline=gfx_0.0.0, context=177, seqno=1, ring_name=94

[PATCH AUTOSEL 5.4 115/350] drm/amd/powerplay: avoid disabling ECC if RAS is enabled for VEGA20

2019-12-10 Thread Sasha Levin
From: Le Ma [ Upstream commit df9331e561dab0a451cbd6a679ee88a95f306fd6 ] Program THM_BACO_CNTL.SOC_DOMAIN_IDLE=1 will tell VBIOS to disable ECC when BACO exit. This can save BACO exit time by PSP on none-ECC SKU. Drop the setting for ECC supported SKU. Signed-off-by: Le Ma Reviewed-by: Alex De

[PATCH AUTOSEL 5.4 125/350] drm/amd/display: enable hostvm based on roimmu active for dcn2.1

2019-12-10 Thread Sasha Levin
From: Dmytro Laktyushkin [ Upstream commit 48d92e8eda3d9b61978377e7539bfc5958e850cf ] Enabling hostvm when ROIMMU is not active seems to break GPUVM. This fixes the issue by not enabling hostvm if ROIMMU is not activated. Signed-off-by: Dmytro Laktyushkin Acked-by: Bhawanpreet Lakha Reviewed-

[PATCH AUTOSEL 5.4 126/350] drm/amd/display: fix header for RN clk mgr

2019-12-10 Thread Sasha Levin
From: joseph gravenor [ Upstream commit cd83fa1ea9b9431cf1d57ac4179a11bc4393a5b6 ] [why] Should always MP0_BASE for any register definition from MP per-IP header files. I belive the reason the linux version of MP1_BASE works is The 0th element of the 0th table of that is identical to the corris

[PATCH AUTOSEL 5.4 136/350] drm/gma500: fix memory disclosures due to uninitialized bytes

2019-12-10 Thread Sasha Levin
From: Kangjie Lu [ Upstream commit ec3b7b6eb8c90b52f61adff11b6db7a8db34de19 ] "clock" may be copied to "best_clock". Initializing best_clock is not sufficient. The fix initializes clock as well to avoid memory disclosures and informaiton leaks. Signed-off-by: Kangjie Lu Signed-off-by: Daniel V

[PATCH AUTOSEL 5.4 157/350] drm: Don't free jobs in wait_event_interruptible()

2019-12-10 Thread Sasha Levin
From: Steven Price [ Upstream commit 588b9828f0744ca13555c4a35cd0251ac8ad8ad2 ] drm_sched_cleanup_jobs() attempts to free finished jobs, however because it is called as the condition of wait_event_interruptible() it must not sleep. Unfortunately some free callbacks (notably for Panfrost) do slee

[PATCH AUTOSEL 5.4 143/350] drm/nouveau: Resume hotplug interrupts earlier

2019-12-10 Thread Sasha Levin
From: Lyude Paul [ Upstream commit ac0de16a38a9ec7026ca96132e3883c564497068 ] Currently, we enable hotplug detection only after we re-enable the display. However, this is too late if we're planning on sending sideband messages during the resume process - which we'll need to do in order to reprob

[PATCH AUTOSEL 5.4 162/350] drm/amd/display: correctly populate dpp refclk in fpga

2019-12-10 Thread Sasha Levin
From: Anthony Koo [ Upstream commit 952f6c4b5d72d40f93f3deb61239290b357d434e ] [Why] In diags environment we are not programming the DPP DTO correctly. [How] Populate the dpp refclk in dccg so it can be used to correctly program DPP DTO. Signed-off-by: Anthony Koo Reviewed-by: Tony Cheng Ack

[PATCH AUTOSEL 5.4 165/350] drm/tegra: sor: Use correct SOR index on Tegra210

2019-12-10 Thread Sasha Levin
From: Thierry Reding [ Upstream commit 24e64f86da40e68c5f58af08796110f147b12193 ] The device tree bindings for the Tegra210 SOR don't require the controller instance to be defined, since the instance can be derived from the compatible string. The index is never used on Tegra210, so we got away w

[PATCH AUTOSEL 5.4 160/350] drm/amd/display: setting the DIG_MODE to the correct value.

2019-12-10 Thread Sasha Levin
From: Zhan liu [ Upstream commit 967a3b85bac91c55eff740e61bf270c2732f48b2 ] [Why] This patch is for fixing Navi14 HDMI display pink screen issue. [How] Call stream->link->link_enc->funcs->setup twice. This is setting the DIG_MODE to the correct value after having been overridden by the call to

[PATCH AUTOSEL 5.4 146/350] drm/nouveau: Don't grab runtime PM refs for HPD IRQs

2019-12-10 Thread Sasha Levin
From: Lyude Paul [ Upstream commit 09e530657e1c982d3dbc5e4302bf9207950c3d0a ] In order for suspend/resume reprobing to work, we need to be able to perform sideband communications during suspend/resume, along with runtime PM suspend/resume. In order to do so, we also need to make sure that nouvea

[PATCH AUTOSEL 5.4 176/350] gpu: host1x: Allocate gather copy for host1x

2019-12-10 Thread Sasha Levin
From: Thierry Reding [ Upstream commit b78e70c04c149299bd210759d7c7af7c86b89ca8 ] Currently when the gather buffers are copied, they are copied to a buffer that is allocated for the host1x client that wants to execute the command streams in the buffers. However, the gather buffers will be read b

[PATCH AUTOSEL 5.4 216/350] drm: msm: a6xx: fix debug bus register configuration

2019-12-10 Thread Sasha Levin
From: Sharat Masetty [ Upstream commit 7f4009c4bbea4438b50f3b12d1c57da3f5cd8db3 ] Fix the cx debugbus related register configuration, to collect accurate bus data during gpu snapshot. This helps with complete snapshot dump and also complete proper GPU recovery. Fixes: 1707add81551 ("drm/msm/a6x

[PATCH AUTOSEL 5.4 232/350] drm/amdgpu: fix potential double drop fence reference

2019-12-10 Thread Sasha Levin
From: Pan Bian [ Upstream commit 946ab8db6953535a3a88c957db8328beacdfed9d ] The object fence is not set to NULL after its reference is dropped. As a result, its reference may be dropped again if error occurs after that, which may lead to a use after free bug. To avoid the issue, fence is explici

[PATCH AUTOSEL 5.4 007/350] drm: Use EOPNOTSUPP, not ENOTSUPP

2019-12-10 Thread Sasha Levin
From: Daniel Vetter [ Upstream commit c7581a414d28413c1dd6d116d44859b5a52e0950 ] - it's what we recommend in our docs: https://dri.freedesktop.org/docs/drm/gpu/drm-uapi.html#recommended-ioctl-return-values - it's the overwhelmingly used error code for "operation not supported", at least in d

[PATCH AUTOSEL 5.4 230/350] drm/amdgpu: disallow direct upload save restore list from gfx driver

2019-12-10 Thread Sasha Levin
From: Hawking Zhang [ Upstream commit 58f46d4b65021083ef4b4d49c6e2c58e5783f626 ] Direct uploading save/restore list via mmio register writes breaks the security policy. Instead, the driver should pass s&r list to psp. For all the ASICs that use rlc v2_1 headers, the driver actually upload s&r l

[PATCH AUTOSEL 5.4 246/350] drm/amdgpu: Avoid accidental thread reactivation.

2019-12-10 Thread Sasha Levin
From: Andrey Grodzovsky [ Upstream commit a28fda312a9fabdf0e5f5652449d6197c9fb0a90 ] Problem: During GPU reset we call the GPU scheduler to suspend it's thread, those two functions in amdgpu also suspend and resume the sceduler for their needs but this can collide with GPU reset in progress and

[PATCH AUTOSEL 5.4 013/350] drm/amdgpu/sriov: add ring_stop before ring_create in psp v11 code

2019-12-10 Thread Sasha Levin
From: Jack Zhang [ Upstream commit 51c0f58e9f6af3a387d14608033e6796a7ad90ee ] psp v11 code missed ring stop in ring create function(VMR) while psp v3.1 code had the code. This will cause VM destroy1 fail and psp ring create fail. For SIOV-VF, ring_stop should not be deleted in ring_create func

[PATCH AUTOSEL 5.4 231/350] drm/amd/powerplay: fix struct init in renoir_print_clk_levels

2019-12-10 Thread Sasha Levin
From: Raul E Rangel [ Upstream commit d942070575910fdb687b9c8fd5467704b2f77c24 ] drivers/gpu/drm/amd/powerplay/renoir_ppt.c:186:2: error: missing braces around initializer [-Werror=missing-braces] SmuMetrics_t metrics = {0}; ^ Fixes: 8b8031703bd7 ("drm/amd/powerplay: implement sysfs for g

[PATCH AUTOSEL 5.4 008/350] drm/amd/display: verify stream link before link test

2019-12-10 Thread Sasha Levin
From: Jing Zhou [ Upstream commit b131932215c993ea5adf8192d1de2e8d6b23048d ] [Why] DP1.2 LL CTS test failure. [How] The failure is caused by not verify stream link is equal to link, only check stream and link is not null. Signed-off-by: Jing Zhou Reviewed-by: Wenjing Liu Acked-by: Bhawanpree

[PATCH AUTOSEL 5.4 014/350] drm/amdgpu: grab the id mgr lock while accessing passid_mapping

2019-12-10 Thread Sasha Levin
From: Christian König [ Upstream commit 6817bf283b2b851095825ec7f0e9f10398e09125 ] Need to make sure that we actually dropping the right fence. Could be done with RCU as well, but to complicated for a fix. Signed-off-by: Christian König Reviewed-by: Chunming Zhou Signed-off-by: Alex Deucher

[PATCH AUTOSEL 5.4 006/350] drm: exynos: exynos_hdmi: use cec_notifier_conn_(un)register

2019-12-10 Thread Sasha Levin
From: Dariusz Marcinkiewicz [ Upstream commit 71137bfd98973efb7b762ba168df077b87b34311 ] Use the new cec_notifier_conn_(un)register() functions to (un)register the notifier for the HDMI connector, and fill in the cec_connector_info. Changes since v7: - err_runtime_disable -> err_rpm_dis

[PATCH AUTOSEL 5.4 002/350] drm/virtio: switch virtio_gpu_wait_ioctl() to gem helper.

2019-12-10 Thread Sasha Levin
From: Gerd Hoffmann [ Upstream commit 29cf12394c0565d7eb1685bf0c1b4749aa6a8b66 ] Use drm_gem_reservation_object_wait() in virtio_gpu_wait_ioctl(). This also makes the ioctl run lockless. v9: fix return value. v5: handle lookup failure. v2: use reservation_object_test_signaled_rcu for VIRTGPU_WA

[PATCH AUTOSEL 5.4 018/350] drm/amd/display: Handle virtual signal type in disable_link()

2019-12-10 Thread Sasha Levin
From: Martin Tsai [ Upstream commit 616f5b65f1c02d3d6ae370644670d14c57de2fd8 ] [Why] The new implementation changed the behavior to allow process setMode to DAL when DAL returns empty mode query for unplugged display. This will trigger additional disable_link(). When unplug HDMI from MST dock, d

[PATCH AUTOSEL 5.4 015/350] drm/ttm: return -EBUSY on pipelining with no_gpu_wait (v2)

2019-12-10 Thread Sasha Levin
From: Christian König [ Upstream commit 3084cf46cf8110826a42de8c8ef30e8fa48974c2 ] Setting the no_gpu_wait flag means that the allocate BO must be available immediately and we can't wait for any GPU operation to finish. v2: squash in mem leak fix, rebase Signed-off-by: Christian König Acked-b

[PATCH AUTOSEL 5.4 005/350] drm/panel: Add missing drm_panel_init() in panel drivers

2019-12-10 Thread Sasha Levin
From: Laurent Pinchart [ Upstream commit 65abbda8ed7ca48c8807d6b04a77431b438fa659 ] Panels must be initialised with drm_panel_init(). Add the missing function call in the panel-raspberrypi-touchscreen.c and panel-sitronix-st7789v.c drivers. Signed-off-by: Laurent Pinchart Signed-off-by: Sam Ra

[PATCH AUTOSEL 5.4 016/350] drm/amd/display: Rebuild mapped resources after pipe split

2019-12-10 Thread Sasha Levin
From: Mikita Lipski [ Upstream commit 387596ef2859c37d564ce15abddbc9063a132e2c ] [why] The issue is specific for linux, as on timings such as 8K@60 or 4K@144 DSC should be working in combination with ODM Combine in order to ensure that we can run those timings. The validation for those timings w

[PATCH AUTOSEL 5.4 032/350] drm/komeda: Workaround for broken FLIP_COMPLETE timestamps

2019-12-10 Thread Sasha Levin
From: Mihail Atanassov [ Upstream commit f59769c52cd7d158df53487ec2936f5592073340 ] When initially turning a crtc on, drm_reset_vblank_timestamp will set the vblank timestamp to 0 for any driver that doesn't provide a ->get_vblank_timestamp() hook. Unfortunately, the FLIP_COMPLETE event depends

[PATCH AUTOSEL 5.4 003/350] drm: mst: Fix query_payload ack reply struct

2019-12-10 Thread Sasha Levin
From: Sean Paul [ Upstream commit 268de6530aa18fe5773062367fd119f0045f6e88 ] Spec says[1] Allocated_PBN is 16 bits [1]- DisplayPort 1.2 Spec, Section 2.11.9.8, Table 2-98 Fixes: ad7f8a1f9ced ("drm/helper: add Displayport multi-stream helper (v0.6)") Cc: Lyude Paul Cc: Todd Previte Cc: Dave A

[PATCH AUTOSEL 5.4 022/350] drm/meson: vclk: use the correct G12A frac max value

2019-12-10 Thread Sasha Levin
From: Neil Armstrong [ Upstream commit d56276a13c2b9ea287b9fc7cc78bed4c43b286f9 ] When calculating the HDMI PLL settings for a DMT mode PHY frequency, use the correct max fractional PLL value for G12A VPU. With this fix, we can finally setup the 1024x768-60 mode. Fixes: 202b9808f8ed ("drm/meso

[PATCH AUTOSEL 5.4 001/350] drm/vc4/vc4_hdmi: fill in connector info

2019-12-10 Thread Sasha Levin
From: Dariusz Marcinkiewicz [ Upstream commit 66c2dee4ae10a2d841c40b9dd9c7141eb23eee76 ] Fill in the connector info, allowing userspace to associate the CEC device with the drm connector. Tested on a Raspberry Pi 3B. Signed-off-by: Dariusz Marcinkiewicz Signed-off-by: Hans Verkuil Tested-by:

[PATCH AUTOSEL 5.4 009/350] drm/bridge: analogix-anx78xx: silence -EPROBE_DEFER warnings

2019-12-10 Thread Sasha Levin
From: Brian Masney [ Upstream commit 2708e876272d89bbbff811d12834adbeef85f022 ] Silence two warning messages that occur due to -EPROBE_DEFER errors to help cleanup the system boot log. Signed-off-by: Brian Masney Reviewed-by: Linus Walleij Signed-off-by: Andrzej Hajda Link: https://patchwor

[PATCH AUTOSEL 5.4 004/350] drm/mipi-dbi: fix a loop in debugfs code

2019-12-10 Thread Sasha Levin
From: Dan Carpenter [ Upstream commit d72cf01f410aa09868d98b672f3f92328c96b32d ] This code will likely crash if we try to do a zero byte write. The code looks like this: /* strip trailing whitespace */ for (i = count - 1; i > 0; i--) if (isspace(buf[i]))

[PATCH AUTOSEL 5.4 010/350] drm/amd/display: OTC underflow fix

2019-12-10 Thread Sasha Levin
From: Jaehyun Chung [ Upstream commit 785908cf19c9eb4803f6bf9c0a7447dc3661d5c3 ] [Why] Underflow occurs on some display setups(repro'd on 3x4K HDR) on boot, mode set, and hot-plugs with. Underflow occurs because mem clk is not set high after disabling pstate switching. This behaviour occurs beca

[PATCH AUTOSEL 5.4 337/350] drm/amdgpu: fix bad DMA from INTERRUPT_CNTL2

2019-12-10 Thread Sasha Levin
From: Sam Bobroff [ Upstream commit 3d0e3ce52ce3eb4b9de3caf9c38dbb5a4d3e13c3 ] The INTERRUPT_CNTL2 register expects a valid DMA address, but is currently set with a GPU MC address. This can cause problems on systems that detect the resulting DMA read from an invalid address (found on a Power8 g

[PATCH AUTOSEL 5.4 321/350] fbtft: Make sure string is NULL terminated

2019-12-10 Thread Sasha Levin
From: Andy Shevchenko [ Upstream commit 21f585480deb4bcf0d92b08879c35d066dfee030 ] New GCC warns about inappropriate use of strncpy(): drivers/staging/fbtft/fbtft-core.c: In function ‘fbtft_framebuffer_alloc’: drivers/staging/fbtft/fbtft-core.c:665:2: warning: ‘strncpy’ specified bound 16 equa

[PATCH AUTOSEL 5.4 057/350] drm/amd/display: set minimum abm backlight level

2019-12-10 Thread Sasha Levin
From: Anthony Koo [ Upstream commit 2ad0cdf9e2e9e079af34af681863fa638f2ee212 ] [Why] A lot of the time, the backlight characteristic curve maps min backlight to a non-zero value. But there are cases where we want the curve to intersect at 0. In this scenario even if OS never asks to set 0% backl

[PATCH AUTOSEL 5.4 052/350] drm/sun4i: dsi: Fix TCON DRQ set bits

2019-12-10 Thread Sasha Levin
From: Jagan Teki [ Upstream commit 7ac6269968826f9cad61b501bb613cc5cadb7229 ] The LCD timing definitions between Linux DRM vs Allwinner are different, below diagram shows this clear differences. Active Front Sync Back Region

[PATCH AUTOSEL 5.4 108/350] drm/bridge: dw-hdmi: Restore audio when setting a mode

2019-12-10 Thread Sasha Levin
From: Daniel Kurtz [ Upstream commit fadfee3f9d8f114435a8a3e9f83a227600d89de7 ] When setting a new display mode, dw_hdmi_setup() calls dw_hdmi_enable_video_path(), which disables all hdmi clocks, including the audio clock. We should only (re-)enable the audio clock if audio was already enabled

[PATCH AUTOSEL 5.4 053/350] drm/amdkfd: fix a potential NULL pointer dereference (v2)

2019-12-10 Thread Sasha Levin
From: Allen Pais [ Upstream commit 81de29d842ccb776c0f77aa3e2b11b07fff0c0e2 ] alloc_workqueue is not checked for errors and as a result, a potential NULL dereference could occur. v2 (Felix Kuehling): * Fix compile error (kfifo_free instead of fifo_free) * Return proper error code Signed-off-by

[PATCH AUTOSEL 5.4 078/350] drm/drm_vblank: Change EINVAL by the correct errno

2019-12-10 Thread Sasha Levin
From: Rodrigo Siqueira [ Upstream commit aed6105b28b10613f16c0bfe97525fe5a23338df ] For historical reasons, the function drm_wait_vblank_ioctl always return -EINVAL if something gets wrong. This scenario limits the flexibility for the userspace to make detailed verification of any problem and ta

[PATCH AUTOSEL 5.4 100/350] drm/amd/display: Fix dongle_caps containing stale information.

2019-12-10 Thread Sasha Levin
From: David Galiffi [ Upstream commit dd998291dbe92106d8c4a7581c409b356928d711 ] [WHY] During detection: function: get_active_converter_info populates link->dpcd_caps.dongle_caps only when dpcd_rev >= DPCD_REV_11 and DWN_STRM_PORTX_TYPE is DOWN_STREAM_DETAILED_HDMI or DOWN_STREAM_DETAILED_DP_PL

[PATCH AUTOSEL 5.4 096/350] drm/amd/display: wait for set pipe mcp command completion

2019-12-10 Thread Sasha Levin
From: Josip Pavic [ Upstream commit 15caeabc5787c15babad7ee444afe9c26df1c8b3 ] [Why] When the driver sends a pipe set command to the DMCU FW, it does not wait for the command to complete. This can lead to unpredictable behavior if, for example, the driver were to request a pipe disable to the FW

[PATCH AUTOSEL 5.4 069/350] drm/bridge: dw-hdmi: Refuse DDC/CI transfers on the internal I2C controller

2019-12-10 Thread Sasha Levin
From: Matthias Kaehlcke [ Upstream commit bee447e224b2645911c5d06e35dc90d8433fcef6 ] The DDC/CI protocol involves sending a multi-byte request to the display via I2C, which is typically followed by a multi-byte response. The internal I2C controller only allows single byte reads/writes or reads o

[PATCH AUTOSEL 5.4 060/350] drm/amd/display: fix struct init in update_bounding_box

2019-12-10 Thread Sasha Levin
From: Raul E Rangel [ Upstream commit 960b6f4f2d2e96d5f7ffe2854e0040b46cafbd36 ] dcn20_resource.c:2636:9: error: missing braces around initializer [-Werror=missing-braces] struct _vcs_dpi_voltage_scaling_st calculated_states[MAX_CLOCK_LIMIT_STATES] = {0}; ^ Fixes: 7ed4e6352c16f ("d

[PATCH AUTOSEL 5.4 095/350] drm/amd/display: Properly round nominal frequency for SPD

2019-12-10 Thread Sasha Levin
From: Aric Cyr [ Upstream commit c59802313e84bede954235b3a5dd0dd5325f49c5 ] [Why] Some displays rely on the SPD verticle frequency maximum value. Must round the calculated refresh rate to the nearest integer. [How] Round the nominal calculated refresh rate to the nearest whole integer. Signed-

[PATCH AUTOSEL 5.4 055/350] drm/amd/powerplay: A workaround to GPU RESET on APU

2019-12-10 Thread Sasha Levin
From: chen gong [ Upstream commit 068ad870bbd8f4f2c5b2fd4977a4f3330c9988f4 ] Changes to function "smu_suspend" in amdgpu_smu.c is a workaround. We should get real information about if baco is enabled or not, while we always consider APU SMU feature as enabled in current code. I know APU do not

[PATCH AUTOSEL 5.4 098/350] drm/amd/display: add new active dongle to existent w/a

2019-12-10 Thread Sasha Levin
From: Vitaly Prosyak [ Upstream commit 566b4252fe9da9582dde008c5e9c3eb7c136e348 ] [Why & How] Dongle 0x00E04C power down all internal circuits including AUX communication preventing reading DPCD table. Encoder will skip DP RX power down on disable output to keep receiver powered all the time. S

[PATCH AUTOSEL 5.4 073/350] drm/amdkfd: Fix MQD size calculation

2019-12-10 Thread Sasha Levin
From: Oak Zeng [ Upstream commit 40a9592a26608e16f7545a068ea4165e1869f629 ] On device initialization, a chunk of GTT memory is pre-allocated for HIQ and all SDMA queues mqd. The size of this allocation was wrong. The correct sdma engine number should be PCIe-optimized SDMA engine number plus xgm

[PATCH AUTOSEL 5.4 102/350] drm/amd/display: Program DWB watermarks from correct state

2019-12-10 Thread Sasha Levin
From: Julian Parkin [ Upstream commit edb922b022c0c94805c4ffad202b3edff83d76f0 ] [Why] When diags adds a DWB via a stream update, we calculate MMHUBBUB paramaters, but dc->current_state has not yet been updated when the DWB programming happens. This leads to overflow on high bandwidth tests sinc

[PATCH AUTOSEL 5.4 050/350] drm/amd/display: Set number of pipes to 1 if the second pipe was disabled

2019-12-10 Thread Sasha Levin
From: Nikola Cornij [ Upstream commit 2fef0faa1cdc5d41ce3ef83f7b8f7e7ecb02d700 ] [why] Some ODM-related register settings are inconsistently updated by VBIOS, causing the state in DC to be invalid, which would then end up crashing in certain use-cases (such as disable/enable device). [how] Chec

[PATCH AUTOSEL 5.3 001/292] drm/vc4/vc4_hdmi: fill in connector info

2019-12-10 Thread Sasha Levin
From: Dariusz Marcinkiewicz [ Upstream commit 66c2dee4ae10a2d841c40b9dd9c7141eb23eee76 ] Fill in the connector info, allowing userspace to associate the CEC device with the drm connector. Tested on a Raspberry Pi 3B. Signed-off-by: Dariusz Marcinkiewicz Signed-off-by: Hans Verkuil Tested-by:

[PATCH AUTOSEL 5.3 007/292] drm/bridge: analogix-anx78xx: silence -EPROBE_DEFER warnings

2019-12-10 Thread Sasha Levin
From: Brian Masney [ Upstream commit 2708e876272d89bbbff811d12834adbeef85f022 ] Silence two warning messages that occur due to -EPROBE_DEFER errors to help cleanup the system boot log. Signed-off-by: Brian Masney Reviewed-by: Linus Walleij Signed-off-by: Andrzej Hajda Link: https://patchwor

[PATCH AUTOSEL 5.3 002/292] drm: mst: Fix query_payload ack reply struct

2019-12-10 Thread Sasha Levin
From: Sean Paul [ Upstream commit 268de6530aa18fe5773062367fd119f0045f6e88 ] Spec says[1] Allocated_PBN is 16 bits [1]- DisplayPort 1.2 Spec, Section 2.11.9.8, Table 2-98 Fixes: ad7f8a1f9ced ("drm/helper: add Displayport multi-stream helper (v0.6)") Cc: Lyude Paul Cc: Todd Previte Cc: Dave A

[PATCH AUTOSEL 5.3 005/292] drm: exynos: exynos_hdmi: use cec_notifier_conn_(un)register

2019-12-10 Thread Sasha Levin
From: Dariusz Marcinkiewicz [ Upstream commit 71137bfd98973efb7b762ba168df077b87b34311 ] Use the new cec_notifier_conn_(un)register() functions to (un)register the notifier for the HDMI connector, and fill in the cec_connector_info. Changes since v7: - err_runtime_disable -> err_rpm_dis

[PATCH AUTOSEL 5.3 004/292] drm/panel: Add missing drm_panel_init() in panel drivers

2019-12-10 Thread Sasha Levin
From: Laurent Pinchart [ Upstream commit 65abbda8ed7ca48c8807d6b04a77431b438fa659 ] Panels must be initialised with drm_panel_init(). Add the missing function call in the panel-raspberrypi-touchscreen.c and panel-sitronix-st7789v.c drivers. Signed-off-by: Laurent Pinchart Signed-off-by: Sam Ra

[PATCH AUTOSEL 5.3 003/292] drm/mipi-dbi: fix a loop in debugfs code

2019-12-10 Thread Sasha Levin
From: Dan Carpenter [ Upstream commit d72cf01f410aa09868d98b672f3f92328c96b32d ] This code will likely crash if we try to do a zero byte write. The code looks like this: /* strip trailing whitespace */ for (i = count - 1; i > 0; i--) if (isspace(buf[i]))

[PATCH AUTOSEL 5.3 013/292] drm/amd/display: Handle virtual signal type in disable_link()

2019-12-10 Thread Sasha Levin
From: Martin Tsai [ Upstream commit 616f5b65f1c02d3d6ae370644670d14c57de2fd8 ] [Why] The new implementation changed the behavior to allow process setMode to DAL when DAL returns empty mode query for unplugged display. This will trigger additional disable_link(). When unplug HDMI from MST dock, d

[PATCH AUTOSEL 5.3 006/292] drm/amd/display: verify stream link before link test

2019-12-10 Thread Sasha Levin
From: Jing Zhou [ Upstream commit b131932215c993ea5adf8192d1de2e8d6b23048d ] [Why] DP1.2 LL CTS test failure. [How] The failure is caused by not verify stream link is equal to link, only check stream and link is not null. Signed-off-by: Jing Zhou Reviewed-by: Wenjing Liu Acked-by: Bhawanpree

[PATCH AUTOSEL 5.3 010/292] drm/amdgpu/sriov: add ring_stop before ring_create in psp v11 code

2019-12-10 Thread Sasha Levin
From: Jack Zhang [ Upstream commit 51c0f58e9f6af3a387d14608033e6796a7ad90ee ] psp v11 code missed ring stop in ring create function(VMR) while psp v3.1 code had the code. This will cause VM destroy1 fail and psp ring create fail. For SIOV-VF, ring_stop should not be deleted in ring_create func

[PATCH AUTOSEL 5.3 011/292] drm/amdgpu: grab the id mgr lock while accessing passid_mapping

2019-12-10 Thread Sasha Levin
From: Christian König [ Upstream commit 6817bf283b2b851095825ec7f0e9f10398e09125 ] Need to make sure that we actually dropping the right fence. Could be done with RCU as well, but to complicated for a fix. Signed-off-by: Christian König Reviewed-by: Chunming Zhou Signed-off-by: Alex Deucher

Re: [PATCH] drm/drm_panel: fix EXPORT of drm_panel_of_backlight

2019-12-10 Thread Linus Walleij
On Tue, Dec 10, 2019 at 8:48 PM Sam Ravnborg wrote: > Fix link failure for module builds of panels. > The conditional compilation around drm_panel_of_backlight() > was wrong for a module build. > Fix it using IS_ENABLED(). > > Fixes: 152dbdeab1b2 ("drm/panel: add backlight support") > Cc: Sam Rav

[PATCH AUTOSEL 4.19 005/177] drm/amdgpu: grab the id mgr lock while accessing passid_mapping

2019-12-10 Thread Sasha Levin
From: Christian König [ Upstream commit 6817bf283b2b851095825ec7f0e9f10398e09125 ] Need to make sure that we actually dropping the right fence. Could be done with RCU as well, but to complicated for a fix. Signed-off-by: Christian König Reviewed-by: Chunming Zhou Signed-off-by: Alex Deucher

[PATCH AUTOSEL 4.19 003/177] drm/bridge: analogix-anx78xx: silence -EPROBE_DEFER warnings

2019-12-10 Thread Sasha Levin
From: Brian Masney [ Upstream commit 2708e876272d89bbbff811d12834adbeef85f022 ] Silence two warning messages that occur due to -EPROBE_DEFER errors to help cleanup the system boot log. Signed-off-by: Brian Masney Reviewed-by: Linus Walleij Signed-off-by: Andrzej Hajda Link: https://patchwor

[PATCH AUTOSEL 4.19 001/177] drm: mst: Fix query_payload ack reply struct

2019-12-10 Thread Sasha Levin
From: Sean Paul [ Upstream commit 268de6530aa18fe5773062367fd119f0045f6e88 ] Spec says[1] Allocated_PBN is 16 bits [1]- DisplayPort 1.2 Spec, Section 2.11.9.8, Table 2-98 Fixes: ad7f8a1f9ced ("drm/helper: add Displayport multi-stream helper (v0.6)") Cc: Lyude Paul Cc: Todd Previte Cc: Dave A

[PATCH AUTOSEL 4.19 002/177] drm/panel: Add missing drm_panel_init() in panel drivers

2019-12-10 Thread Sasha Levin
From: Laurent Pinchart [ Upstream commit 65abbda8ed7ca48c8807d6b04a77431b438fa659 ] Panels must be initialised with drm_panel_init(). Add the missing function call in the panel-raspberrypi-touchscreen.c and panel-sitronix-st7789v.c drivers. Signed-off-by: Laurent Pinchart Signed-off-by: Sam Ra

[PATCH AUTOSEL 4.19 039/177] drm/drm_vblank: Change EINVAL by the correct errno

2019-12-10 Thread Sasha Levin
From: Rodrigo Siqueira [ Upstream commit aed6105b28b10613f16c0bfe97525fe5a23338df ] For historical reasons, the function drm_wait_vblank_ioctl always return -EINVAL if something gets wrong. This scenario limits the flexibility for the userspace to make detailed verification of any problem and ta

[PATCH AUTOSEL 4.19 055/177] drm/bridge: dw-hdmi: Restore audio when setting a mode

2019-12-10 Thread Sasha Levin
From: Daniel Kurtz [ Upstream commit fadfee3f9d8f114435a8a3e9f83a227600d89de7 ] When setting a new display mode, dw_hdmi_setup() calls dw_hdmi_enable_video_path(), which disables all hdmi clocks, including the audio clock. We should only (re-)enable the audio clock if audio was already enabled

[PATCH AUTOSEL 4.19 033/177] drm/bridge: dw-hdmi: Refuse DDC/CI transfers on the internal I2C controller

2019-12-10 Thread Sasha Levin
From: Matthias Kaehlcke [ Upstream commit bee447e224b2645911c5d06e35dc90d8433fcef6 ] The DDC/CI protocol involves sending a multi-byte request to the display via I2C, which is typically followed by a multi-byte response. The internal I2C controller only allows single byte reads/writes or reads o

[PATCH AUTOSEL 4.19 049/177] drm/amd/display: Fix dongle_caps containing stale information.

2019-12-10 Thread Sasha Levin
From: David Galiffi [ Upstream commit dd998291dbe92106d8c4a7581c409b356928d711 ] [WHY] During detection: function: get_active_converter_info populates link->dpcd_caps.dongle_caps only when dpcd_rev >= DPCD_REV_11 and DWN_STRM_PORTX_TYPE is DOWN_STREAM_DETAILED_HDMI or DOWN_STREAM_DETAILED_DP_PL

[PATCH AUTOSEL 4.19 025/177] drm/amdkfd: fix a potential NULL pointer dereference (v2)

2019-12-10 Thread Sasha Levin
From: Allen Pais [ Upstream commit 81de29d842ccb776c0f77aa3e2b11b07fff0c0e2 ] alloc_workqueue is not checked for errors and as a result, a potential NULL dereference could occur. v2 (Felix Kuehling): * Fix compile error (kfifo_free instead of fifo_free) * Return proper error code Signed-off-by

[PATCH AUTOSEL 4.19 079/177] drm/tegra: sor: Use correct SOR index on Tegra210

2019-12-10 Thread Sasha Levin
From: Thierry Reding [ Upstream commit 24e64f86da40e68c5f58af08796110f147b12193 ] The device tree bindings for the Tegra210 SOR don't require the controller instance to be defined, since the instance can be derived from the compatible string. The index is never used on Tegra210, so we got away w

[PATCH AUTOSEL 4.19 084/177] gpu: host1x: Allocate gather copy for host1x

2019-12-10 Thread Sasha Levin
From: Thierry Reding [ Upstream commit b78e70c04c149299bd210759d7c7af7c86b89ca8 ] Currently when the gather buffers are copied, they are copied to a buffer that is allocated for the host1x client that wants to execute the command streams in the buffers. However, the gather buffers will be read b

[PATCH AUTOSEL 4.19 069/177] drm/gma500: fix memory disclosures due to uninitialized bytes

2019-12-10 Thread Sasha Levin
From: Kangjie Lu [ Upstream commit ec3b7b6eb8c90b52f61adff11b6db7a8db34de19 ] "clock" may be copied to "best_clock". Initializing best_clock is not sufficient. The fix initializes clock as well to avoid memory disclosures and informaiton leaks. Signed-off-by: Kangjie Lu Signed-off-by: Daniel V

Re: [PATCH v1 07/26] drm/panel: remove get_timings

2019-12-10 Thread Linus Walleij
On Wed, Dec 4, 2019 at 9:16 AM Maxime Ripard wrote: > On Tue, Dec 03, 2019 at 04:20:24PM +0100, Linus Walleij wrote: > > On the DSI displays in video mode there is also this EOL area > > which seems to be where the logic is normally just idling for a > > while, that can be adjusted on some hardwa

[PATCH AUTOSEL 4.19 118/177] drm/amdgpu: disallow direct upload save restore list from gfx driver

2019-12-10 Thread Sasha Levin
From: Hawking Zhang [ Upstream commit 58f46d4b65021083ef4b4d49c6e2c58e5783f626 ] Direct uploading save/restore list via mmio register writes breaks the security policy. Instead, the driver should pass s&r list to psp. For all the ASICs that use rlc v2_1 headers, the driver actually upload s&r l

[PATCH AUTOSEL 4.19 119/177] drm/amdgpu: fix potential double drop fence reference

2019-12-10 Thread Sasha Levin
From: Pan Bian [ Upstream commit 946ab8db6953535a3a88c957db8328beacdfed9d ] The object fence is not set to NULL after its reference is dropped. As a result, its reference may be dropped again if error occurs after that, which may lead to a use after free bug. To avoid the issue, fence is explici

[PATCH AUTOSEL 4.19 175/177] drm/amdgpu: fix bad DMA from INTERRUPT_CNTL2

2019-12-10 Thread Sasha Levin
From: Sam Bobroff [ Upstream commit 3d0e3ce52ce3eb4b9de3caf9c38dbb5a4d3e13c3 ] The INTERRUPT_CNTL2 register expects a valid DMA address, but is currently set with a GPU MC address. This can cause problems on systems that detect the resulting DMA read from an invalid address (found on a Power8 g

Re: [PATCH AUTOSEL 5.4 143/350] drm/nouveau: Resume hotplug interrupts earlier

2019-12-10 Thread Lyude Paul
huh? Not sure how this got put in the stable queue, but this probably should be dropped. this was prepatory work for some MST functionality that got added recently, not a fix. On Tue, 2019-12-10 at 16:04 -0500, Sasha Levin wrote: > From: Lyude Paul > > [ Upstream commit ac0de16a38a9ec7026ca96132

[PATCH AUTOSEL 4.19 165/177] fbtft: Make sure string is NULL terminated

2019-12-10 Thread Sasha Levin
From: Andy Shevchenko [ Upstream commit 21f585480deb4bcf0d92b08879c35d066dfee030 ] New GCC warns about inappropriate use of strncpy(): drivers/staging/fbtft/fbtft-core.c: In function ‘fbtft_framebuffer_alloc’: drivers/staging/fbtft/fbtft-core.c:665:2: warning: ‘strncpy’ specified bound 16 equa

Re: [PATCH] drm/amd/display: fix undefined struct member reference

2019-12-10 Thread Arnd Bergmann
On Tue, Dec 10, 2019 at 9:56 PM Kazlauskas, Nicholas wrote: > On 2019-12-10 3:54 p.m., Liu, Zhan wrote: > >> > >> Fixes: c3d03c5a196f ("drm/amd/display: Include num_vmid and num_dsc > >> within NV14's resource caps") > >> Signed-off-by: Arnd Bergmann > > > > Thank you for catching that On my sid

RE: [PATCH] drm/amd/display: fix undefined struct member reference

2019-12-10 Thread Deucher, Alexander
> -Original Message- > From: Kazlauskas, Nicholas > Sent: Tuesday, December 10, 2019 3:56 PM > To: Liu, Zhan ; Arnd Bergmann ; > Wentland, Harry ; Li, Sun peng (Leo) > ; Deucher, Alexander > ; Koenig, Christian > ; Zhou, David(ChunMing) > ; David Airlie ; Daniel Vetter > > Cc: Liu, Charle

Re: [PATCH v5 2/4] Revert "drm/tegra: Move drm_dp_link helpers to Tegra DRM"

2019-12-10 Thread Laurent Pinchart
Hello Allen, Thank you for the patch. On Tue, Dec 10, 2019 at 01:53:40PM +0800, allen wrote: > This reverts commit 9a42c7c647a9ad0f7ebb147a52eda3dcb7c84292. Why ? > Signed-off-by: Allen Chen > --- > drivers/gpu/drm/drm_dp_helper.c | 128 ++ > drivers/gpu/drm/tegra/Makefile | 1 - > dri

Re: [PATCH RFC 2/8] drm/sprd: add Unisoc's drm kms master

2019-12-10 Thread Daniel Vetter
On Tue, Dec 10, 2019 at 04:06:53PM +, Emil Velikov wrote: > Welcome to DRM Kevin, > > On Tue, 10 Dec 2019 at 08:40, Kevin Tang wrote: > > > > From: Kevin Tang > > > > Adds drm support for the Unisoc's display subsystem. > > > > This is drm device and gem driver. This driver provides support

[PATCH AUTOSEL 4.14 002/130] drm/bridge: analogix-anx78xx: silence -EPROBE_DEFER warnings

2019-12-10 Thread Sasha Levin
From: Brian Masney [ Upstream commit 2708e876272d89bbbff811d12834adbeef85f022 ] Silence two warning messages that occur due to -EPROBE_DEFER errors to help cleanup the system boot log. Signed-off-by: Brian Masney Reviewed-by: Linus Walleij Signed-off-by: Andrzej Hajda Link: https://patchwor

[PATCH AUTOSEL 4.14 001/130] drm: mst: Fix query_payload ack reply struct

2019-12-10 Thread Sasha Levin
From: Sean Paul [ Upstream commit 268de6530aa18fe5773062367fd119f0045f6e88 ] Spec says[1] Allocated_PBN is 16 bits [1]- DisplayPort 1.2 Spec, Section 2.11.9.8, Table 2-98 Fixes: ad7f8a1f9ced ("drm/helper: add Displayport multi-stream helper (v0.6)") Cc: Lyude Paul Cc: Todd Previte Cc: Dave A

[PATCH AUTOSEL 4.14 028/130] drm/bridge: dw-hdmi: Refuse DDC/CI transfers on the internal I2C controller

2019-12-10 Thread Sasha Levin
From: Matthias Kaehlcke [ Upstream commit bee447e224b2645911c5d06e35dc90d8433fcef6 ] The DDC/CI protocol involves sending a multi-byte request to the display via I2C, which is typically followed by a multi-byte response. The internal I2C controller only allows single byte reads/writes or reads o

[PATCH AUTOSEL 4.14 044/130] drm/bridge: dw-hdmi: Restore audio when setting a mode

2019-12-10 Thread Sasha Levin
From: Daniel Kurtz [ Upstream commit fadfee3f9d8f114435a8a3e9f83a227600d89de7 ] When setting a new display mode, dw_hdmi_setup() calls dw_hdmi_enable_video_path(), which disables all hdmi clocks, including the audio clock. We should only (re-)enable the audio clock if audio was already enabled

[PATCH AUTOSEL 4.14 054/130] drm/gma500: fix memory disclosures due to uninitialized bytes

2019-12-10 Thread Sasha Levin
From: Kangjie Lu [ Upstream commit ec3b7b6eb8c90b52f61adff11b6db7a8db34de19 ] "clock" may be copied to "best_clock". Initializing best_clock is not sufficient. The fix initializes clock as well to avoid memory disclosures and informaiton leaks. Signed-off-by: Kangjie Lu Signed-off-by: Daniel V

[PATCH AUTOSEL 4.14 090/130] drm/amdgpu: fix potential double drop fence reference

2019-12-10 Thread Sasha Levin
From: Pan Bian [ Upstream commit 946ab8db6953535a3a88c957db8328beacdfed9d ] The object fence is not set to NULL after its reference is dropped. As a result, its reference may be dropped again if error occurs after that, which may lead to a use after free bug. To avoid the issue, fence is explici

[PATCH AUTOSEL 4.14 062/130] gpu: host1x: Allocate gather copy for host1x

2019-12-10 Thread Sasha Levin
From: Thierry Reding [ Upstream commit b78e70c04c149299bd210759d7c7af7c86b89ca8 ] Currently when the gather buffers are copied, they are copied to a buffer that is allocated for the host1x client that wants to execute the command streams in the buffers. However, the gather buffers will be read b

[PATCH AUTOSEL 4.14 120/130] fbtft: Make sure string is NULL terminated

2019-12-10 Thread Sasha Levin
From: Andy Shevchenko [ Upstream commit 21f585480deb4bcf0d92b08879c35d066dfee030 ] New GCC warns about inappropriate use of strncpy(): drivers/staging/fbtft/fbtft-core.c: In function ‘fbtft_framebuffer_alloc’: drivers/staging/fbtft/fbtft-core.c:665:2: warning: ‘strncpy’ specified bound 16 equa

Re: [PATCH 1/8] drm/print: introduce new struct drm_device based logging macros

2019-12-10 Thread Daniel Vetter
On Tue, Dec 10, 2019 at 02:34:33PM +0200, Jani Nikula wrote: > On Tue, 10 Dec 2019, Jani Nikula wrote: > > Add new struct drm_device based logging macros modeled after the core > > kernel device based logging macros. These would be preferred over the > > drm printk and struct device based macros i

<    1   2   3   4   >