Re: [PATCH RESEND 3/4] dt-bindings: drm/bridge: analogix-anx78xx: support bypass GPIO

2019-12-10 Thread Hsin-Yi Wang
On Mon, Dec 9, 2019 at 10:55 PM Laurent Pinchart wrote: > > Hi Hsin-Yi, > > Thank you for the patch. > > On Mon, Dec 09, 2019 at 10:50:15PM +0800, Hsin-Yi Wang wrote: > > Support optional feature: bypass GPIO. > > > > Some SoC (eg. mt8173) have a hardware mux that connects to 2 ports: > > anx7688

[PATCH 1/4] dt-bindings: drm/bridge: analogix-anx7688: Add ANX7688 transmitter binding

2019-12-10 Thread Hsin-Yi Wang
From: Nicolas Boichat From: Nicolas Boichat Add support for analogix,anx7688 Signed-off-by: Nicolas Boichat Signed-off-by: Hsin-Yi Wang --- .../bindings/display/bridge/anx7688.txt | 32 +++ 1 file changed, 32 insertions(+) create mode 100644 Documentation/devicetree/b

[PATCH v5 0/4] IT6505 cover letter

2019-12-10 Thread allen
The IT6505 is a high-performance DisplayPort 1.1a transmitter, fully compliant with DisplayPort 1.1a, HDCP 1.3 specifications. The IT6505 supports color depth of up to 36 bits (12 bits/color) and ensures robust transmission of high-quality uncompressed video content, along with uncompressed and com

[PATCH] drm: msm: mdp4: Adjust indentation in mdp4_dsi_encoder_enable

2019-12-10 Thread Nathan Chancellor
Clang warns: ../drivers/gpu/drm/msm/disp/mdp4/mdp4_dsi_encoder.c:124:3: warning: misleading indentation; statement is not part of the previous 'if' [-Wmisleading-indentation] mdp4_crtc_set_config(encoder->crtc, ^ ../drivers/gpu/drm/msm/disp/mdp4/mdp4_dsi_encoder.c:121:2: note: pr

[PATCH RESEND 0/4] drm: bridge: anx7688 and an optional feature

2019-12-10 Thread Hsin-Yi Wang
[Resend to cc more reviewers] This series is to add anx7688 bridge driver. It is extended from previous work[1]. The first 2 patches are same as previous version, with some modification due to drm core function changes and use regmap abstraction. We add an optional feature bypass-gpios so that d

Re: [resend PATCH v6 12/12] drm/mediatek: Add support for mmsys through a pdev

2019-12-10 Thread Enric Balletbo i Serra
Hi Matthias, Just one nit below and LGTM On 7/12/19 23:47, matthias@kernel.org wrote: > From: Matthias Brugger > > The MMSYS subsystem includes clocks and drm components. > This patch adds an initailization path through a platform device > for the clock part, so that both drivers get probed

[PATCH RESEND 1/4] dt-bindings: drm/bridge: analogix-anx7688: Add ANX7688 transmitter binding

2019-12-10 Thread Hsin-Yi Wang
From: Nicolas Boichat Add support for analogix,anx7688 Signed-off-by: Nicolas Boichat Signed-off-by: Hsin-Yi Wang --- .../bindings/display/bridge/anx7688.txt | 32 +++ 1 file changed, 32 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/bridge/a

[PATCH v5 4/4] drm/bridge: add it6505 driver

2019-12-10 Thread allen
From: Allen Chen This adds support for the iTE IT6505. This device can convert DPI signal to DP output. Signed-off-by: Jitao Shi Signed-off-by: Yilun Lin Signed-off-by: Allen Chen Signed-off-by: Pi-Hsun Shih --- drivers/gpu/drm/bridge/Kconfig |7 + drivers/gpu/drm/bridge/Makefile

BUG: unable to handle kernel paging request in drm_fb_helper_dirty_work

2019-12-10 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:e42617b8 Linux 5.5-rc1 git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=126dc282e0 kernel config: https://syzkaller.appspot.com/x/.config?x=3754e2c78c1adb82 dashboard link: https://syzkaller.appspo

RE: [PATCH v4] video: hyperv: hyperv_fb: Use physical memory for fb on HyperV Gen 1 VMs.

2019-12-10 Thread Michael Kelley
From: Wei Hu Sent: Sunday, December 8, 2019 11:58 PM > > On Hyper-V, Generation 1 VMs can directly use VM's physical memory for > their framebuffers. This can improve the efficiency of framebuffer and > overall performence for VM. The physical memory assigned to framebuffer > must be contiguous.

Re: [resend PATCH v6 08/12] clk: mediatek: mt6779: switch mmsys to platform device probing

2019-12-10 Thread Enric Balletbo i Serra
Hi Matthias, On 7/12/19 23:47, matthias@kernel.org wrote: > From: Matthias Brugger > > Switch probing for the MMSYS to support invocation to a > plain paltform device. The driver will be probed by the DRM subsystem. > > Singed-off-by: Matthias Brugger > --- > drivers/clk/mediatek/clk-mt67

Re: [resend PATCH v6 06/12] clk: mediatek: mt2701: switch mmsys to platform device probing

2019-12-10 Thread Enric Balletbo i Serra
Hi Matthias, On 7/12/19 23:47, matthias@kernel.org wrote: > From: Matthias Brugger > > Switch probing for the MMSYS to support invocation to a plain > paltform device. The driver will be probed by the DRM subsystem. > > Signed-off-by: Matthias Brugger > --- > drivers/clk/mediatek/clk-mt27

RE: [PATCH libdrm v4] modetest: Use floating vrefresh while dumping mode

2019-12-10 Thread Devarsh Thakkar
Hi Eric, Ville, Thanks for the review, please see inline. > -Original Message- > From: Eric Engestrom > Sent: 05 December 2019 05:17 > To: Devarsh Thakkar > Cc: dri-devel@lists.freedesktop.org > Subject: Re: [PATCH libdrm v4] modetest: Use floating vrefresh while dumping > mode > > EXT

[PATCH v5 2/4] Revert "drm/tegra: Move drm_dp_link helpers to Tegra DRM"

2019-12-10 Thread allen
This reverts commit 9a42c7c647a9ad0f7ebb147a52eda3dcb7c84292. Signed-off-by: Allen Chen --- drivers/gpu/drm/drm_dp_helper.c | 128 ++ drivers/gpu/drm/tegra/Makefile | 1 - drivers/gpu/drm/tegra/dp.c | 876 drivers/gpu/drm/tegra/dp.h | 177

Re: [PATCH] drm/vmwgfx: Replace deprecated PTR_RET

2019-12-10 Thread Lukas Bulwahn
On Mon, Dec 9, 2019 at 11:21 AM Julia Lawall wrote: > > > De: "Lukas Bulwahn" > > À: "Thomas Hellstrom" , > > dri-devel@lists.freedesktop.org > > Cc: "David Airlie" , "Daniel Vetter" , > > "Sinclair Yeh" , > > linux-graphics-maintai...@vmware.com, kernel-janit...@vger.kernel.org, > > linux-ker

general protection fault in fbcon_modechanged

2019-12-10 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:e42617b8 Linux 5.5-rc1 git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=15229c2ae0 kernel config: https://syzkaller.appspot.com/x/.config?x=3754e2c78c1adb82 dashboard link: https://syzkaller.appspo

general protection fault in fbcon_fb_blanked

2019-12-10 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:eea2d5da Merge tag 'for-linus' of git://git.armlinux.org.u.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=1785042ae0 kernel config: https://syzkaller.appspot.com/x/.config?x=f07a23020fd7d21a da

[PATCH v3 9/9] drm/udl: Remove udl_fb.c

2019-12-10 Thread Thomas Zimmermann
The remaining code in udl_fb.c is unused. Remove the file entirely. Signed-off-by: Thomas Zimmermann Reviewed-by: Emil Velikov --- drivers/gpu/drm/udl/Makefile | 2 +- drivers/gpu/drm/udl/udl_fb.c | 51 2 files changed, 1 insertion(+), 52 deletions(-) dele

[PATCH v3 1/2] drm/komeda: Update the chip identify

2019-12-10 Thread james qian wang (Arm Technology China)
1. Drop komeda-CORE product id comparison and put it into the d71_identify 2. Update pipeline node DT-binding: (a). Skip the needless pipeline DT node. (b). Return fail if the essential pipeline DT node is missing. With these changes, for chips in same family no need to change the DT. v2: R

[PATCH v3 0/2] drm/komeda: Add new product "D32" support

2019-12-10 Thread james qian wang (Arm Technology China)
Hi All: This series enables new product "D32" support v2: Rebase v3: Address Mihail's review comments. james qian wang (Arm Technology China) (2): drm/komeda: Update the chip identify drm/komeda: Enable new product D32 support .../drm/arm/display/include/malidp_product.h | 3 +- .../arm/

[PATCH v3 2/9] drm/udl: Convert to struct drm_simple_display_pipe

2019-12-10 Thread Thomas Zimmermann
Udl has a single display pipeline with a primary plane; perfect for simple-pipe helpers. Convert it over. The old encoder and CRTC code becomes unused and obsolete. Exported formats for the primary plane are RGB565 and XRGB, with the latter being emulated. The 16-bit format is the default and

[PATCH v3 3/9] drm/udl: Switch to atomic suspend/resume helpers

2019-12-10 Thread Thomas Zimmermann
We can use the generic suspend/resume helpers for atomic modesetting. Switch udl over. Signed-off-by: Thomas Zimmermann Reviewed-by: Emil Velikov --- drivers/gpu/drm/udl/udl_drv.c | 7 ++- drivers/gpu/drm/udl/udl_drv.h | 1 - drivers/gpu/drm/udl/udl_modeset.c | 14 --

[PATCH v3 8/9] drm/udl: Move udl_handle_damage() into udl_modeset.c

2019-12-10 Thread Thomas Zimmermann
The only caller of udl_handle_damage() in the plane-update function in udl_modeset.c. Move udl_handle_damage() there. v2: * remove udl_fb.c in a separate patch Signed-off-by: Thomas Zimmermann Reviewed-by: Daniel Vetter Reviewed-by: Emil Velikov --- drivers/gpu/drm/udl/udl_drv.h |

[PATCH v3 1/9] drm/udl: Init connector before encoder and CRTC

2019-12-10 Thread Thomas Zimmermann
To mimic simple-pipe, we initialize the connector before the rest of the display pipeline. v2: * remove unnecessary calls to drm_connector_{register,unregister}() Signed-off-by: Thomas Zimmermann Reviewed-by: Daniel Vetter Reviewed-by: Emil Velikov --- drivers/gpu/drm/udl/udl_connecto

[PATCH v3 0/9] drm/udl: Convert to simple-pipe helpers and clean up

2019-12-10 Thread Thomas Zimmermann
With only a single display pipeline and primary plane, udl is perfect for simple-pipe helpers. Patches 1 to 4 do the convertion. This enables atomic modesetting for udl devices. Patches 5 to 8 clean up handling of color depth and framebuffers. With universal planes that come with simple pipe, disp

[PATCH v3 6/9] drm/udl: Convert to drm_atomic_helper_dirtyfb()

2019-12-10 Thread Thomas Zimmermann
The infrastruture for atomic modesetting allows us to use the generic code for dirty-FB and damage handling. Switch over udl and remove the driver's implementation. The simple-pipe's update function now picks up the primary plane's damage and updates a minimal region of the screen. Signed-off-by:

[PATCH v3 4/9] drm/udl: Inline DPMS code into CRTC enable and disable functions

2019-12-10 Thread Thomas Zimmermann
DPMS functionality is only used by the CRTC's enable and disable functions. Inline the code. The patch also adds symbolic constants for the blank regsiter and constants; accoding to udlfb, which is a bit more detailed than DRM's udl. v3: * use symbolic constants for blank, according to udl

[PATCH v3 2/2] drm/komeda: Enable new product D32 support

2019-12-10 Thread james qian wang (Arm Technology China)
D32 is simple version of D71, the difference is: - Only has one pipeline - Drop the periph block and merge it to GCU v2: Rebase. v3: Isolate the block counting fix to a new patch Signed-off-by: James Qian Wang (Arm Technology China) --- .../drm/arm/display/include/malidp_product.h | 3 +- ...

[PATCH v3 7/9] drm/udl: Remove struct udl_device.active_fb_16

2019-12-10 Thread Thomas Zimmermann
The udl driver stores the currently active framebuffer to know from where to accept damage updates. With the conversion to plane-state damage handling, this is not necessary any longer. The currently active framebuffer and damaged area are always stored in the plane state. Signed-off-by: Thomas Z

[PATCH v3 5/9] drm/udl: Set preferred color depth to 16 bpp

2019-12-10 Thread Thomas Zimmermann
The current default color depth of 24 bpp is not even supported by the driver. Being the native format for communicating with the adapter, 16 bpp is the correct choice. Signed-off-by: Thomas Zimmermann Reviewed-by: Emil Velikov --- drivers/gpu/drm/udl/udl_drv.c | 2 +- drivers/gpu/drm/udl/u

Re: [PATCH 2/3] mfd: intel_soc_pmic: Rename pwm_backlight pwm-lookup to pwm_pmic_backlight

2019-12-10 Thread Lee Jones
On Tue, 19 Nov 2019, Hans de Goede wrote: > At least Bay Trail (BYT) and Cherry Trail (CHT) devices can use 1 of 2 > different PWM controllers for controlling the LCD's backlight brightness. > > Either the one integrated into the PMIC or the one integrated into the > SoC (the 1st LPSS PWM control

[PATCH] drm/virtio: fix mmap page attributes

2019-12-10 Thread Gerd Hoffmann
virtio-gpu uses cached mappings. shmem helpers use writecombine though. So roll our own mmap function, wrapping drm_gem_shmem_mmap(), to tweak vm_page_prot accordingly. Reported-by: Gurchetan Singh Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/virtio/virtgpu_object.c | 18 +-

Re: [PATCH] drm/virtio: fix mmap page attributes

2019-12-10 Thread Thomas Zimmermann
Hi Am 10.12.19 um 09:57 schrieb Gerd Hoffmann: > virtio-gpu uses cached mappings. shmem helpers use writecombine though. > So roll our own mmap function, wrapping drm_gem_shmem_mmap(), to tweak > vm_page_prot accordingly. > > Reported-by: Gurchetan Singh > Signed-off-by: Gerd Hoffmann > --- >

Re: [PATCH] drm/modes: remove unused variables

2019-12-10 Thread Daniel Vetter
On Thu, Dec 05, 2019 at 10:23:51AM +, Benjamin GAIGNARD wrote: > + Zhao Yakui > > On 12/5/19 10:55 AM, Jani Nikula wrote: > > On Wed, 04 Dec 2019, Benjamin GAIGNARD wrote: > >> On 12/4/19 10:35 AM, Thomas Zimmermann wrote: > >>> Hi > >>> > >>> Am 19.11.19 um 14:47 schrieb Benjamin Gaignard: >

Re: [Intel-gfx] [PATCH 03/11] drm/i915: Disable HDCP signalling on transcoder disable

2019-12-10 Thread Daniel Vetter
On Mon, Dec 09, 2019 at 11:13:36AM -0500, Sean Paul wrote: > On Mon, Dec 9, 2019 at 10:18 AM Ville Syrjälä > wrote: > > > > On Fri, Dec 06, 2019 at 08:55:09AM -0500, Sean Paul wrote: > > > On Thu, Dec 05, 2019 at 09:33:19PM +0200, Ville Syrjälä wrote: > > > > On Tue, Dec 03, 2019 at 12:36:26PM -05

Re: [PATCH] drm: Rename drm_bridge->dev to drm

2019-12-10 Thread Daniel Vetter
On Fri, Dec 06, 2019 at 12:59:04PM +0100, Thomas Zimmermann wrote: > Hi > > Am 06.12.19 um 12:25 schrieb Mihail Atanassov: > > Hallo Thomas, > > > > On Thursday, 5 December 2019 18:20:06 GMT Thomas Zimmermann wrote: > >> Hi > >> > >> Am 05.12.19 um 17:30 schrieb Mihail Atanassov: > >>> The 'dev'

Re: [PATCH] MAINTAINERS: Match on dma_buf|fence|resv anywhere

2019-12-10 Thread Daniel Vetter
On Thu, Dec 05, 2019 at 04:51:11PM +0100, Thierry Reding wrote: > On Wed, Dec 04, 2019 at 10:51:05PM +0100, Daniel Vetter wrote: > > I've spent a bit too much time reviewing all kinds of users all over > > the kernel for this buffer sharing infrastructure. And some of it is > > at least questionabl

Re: [PATCH] drm/modes: Support video parameters with only reflect option

2019-12-10 Thread Maxime Ripard
Hi, On Mon, Dec 09, 2019 at 07:32:54PM +0100, Stephan Gerhold wrote: > At the moment, video mode parameters like video=540x960,reflect_x, > (without rotation set) are silently ignored. > > One of the reasons for this is that the calculation that > combines the panel_orientation with cmdline->rotat

Re: [PATCH v8 08/26] mm/gup: allow FOLL_FORCE for get_user_pages_fast()

2019-12-10 Thread Jan Kara
On Mon 09-12-19 14:53:26, John Hubbard wrote: > Commit 817be129e6f2 ("mm: validate get_user_pages_fast flags") allowed > only FOLL_WRITE and FOLL_LONGTERM to be passed to get_user_pages_fast(). > This, combined with the fact that get_user_pages_fast() falls back to > "slow gup", which *does* accept

Re: [PATCH] drm/atomc: Update docs around locking and commit sequencing

2019-12-10 Thread Daniel Vetter
On Thu, Dec 05, 2019 at 05:02:24PM +0100, Thierry Reding wrote: > On Wed, Dec 04, 2019 at 11:00:11AM +0100, Daniel Vetter wrote: > > Both locking and especially sequencing of nonblocking commits have > > evolved a lot. The details are all there, but I noticed that the big > > picture and connection

Re: [PATCH RFC 2/8] drm/sprd: add Unisoc's drm kms master

2019-12-10 Thread Thomas Zimmermann
Hi Am 10.12.19 um 09:36 schrieb Kevin Tang: > From: Kevin Tang > > Adds drm support for the Unisoc's display subsystem. > > This is drm device and gem driver. This driver provides support for the > Direct Rendering Infrastructure (DRI) in XFree86 4.1.0 and higher. > > Cc: Orson Zhai > Cc: Bao

Re: [PATCH] drm/doc: Drop :c:func: markup

2019-12-10 Thread Daniel Vetter
On Thu, Dec 05, 2019 at 05:05:37PM +0100, Thierry Reding wrote: > On Wed, Dec 04, 2019 at 11:19:33AM +0100, Daniel Vetter wrote: > > Kernel sphinx has learned how to do that in > > > > commit d74b0d31dddeac2b44c715588d53d9a1e5b1158e > > Author: Jonathan Corbet > > Date: Thu Apr 25 07:55:07 2019

Re: [PATCH v8 17/26] media/v4l2-core: set pages dirty upon releasing DMA buffers

2019-12-10 Thread Jan Kara
On Mon 09-12-19 16:56:27, Andrew Morton wrote: > On Mon, 9 Dec 2019 14:53:35 -0800 John Hubbard wrote: > > > After DMA is complete, and the device and CPU caches are synchronized, > > it's still required to mark the CPU pages as dirty, if the data was > > coming from the device. However, this dri

Re: [PATCH] drm/vmwgfx: Call vmw_driver_{load,unload}() before registering device

2019-12-10 Thread Thomas Hellstrom
Hi, On 12/9/19 12:06 PM, Thomas Zimmermann wrote: > The load/unload callbacks in struct drm_driver are deprecated. Remove > them and call functions explicitly. > > Signed-off-by: Thomas Zimmermann > --- > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 44 +++ Hmm, which tree is this diff against? I g

Re: [PATCH RFC 2/8] drm/sprd: add Unisoc's drm kms master

2019-12-10 Thread Daniel Vetter
On Tue, Dec 10, 2019 at 04:36:29PM +0800, Kevin Tang wrote: > From: Kevin Tang > > Adds drm support for the Unisoc's display subsystem. > > This is drm device and gem driver. This driver provides support for the > Direct Rendering Infrastructure (DRI) in XFree86 4.1.0 and higher. > > Cc: Orson

Re: [PATCH] drm/modes: Support video parameters with only reflect option

2019-12-10 Thread Stephan Gerhold
On Tue, Dec 10, 2019 at 11:20:46AM +0100, Maxime Ripard wrote: > Hi, > > On Mon, Dec 09, 2019 at 07:32:54PM +0100, Stephan Gerhold wrote: > > At the moment, video mode parameters like video=540x960,reflect_x, > > (without rotation set) are silently ignored. > > > > One of the reasons for this is t

Re: [PATCH RFC 4/8] drm/sprd: add Unisoc's drm display controller driver

2019-12-10 Thread Thomas Zimmermann
Hi Am 10.12.19 um 09:36 schrieb Kevin Tang: > From: Kevin Tang > > Adds DPU(Display Processor Unit) support for the Unisoc's display subsystem. > It's support multi planes, scaler, rotation, PQ(Picture Quality) and more. > > Cc: Orson Zhai > Cc: Baolin Wang > Cc: Chunyan Zhang > Signed-off-b

Re: [PATCH] drm/vmwgfx: Call vmw_driver_{load,unload}() before registering device

2019-12-10 Thread Thomas Zimmermann
Hi Am 10.12.19 um 11:37 schrieb Thomas Hellstrom: > Hi, > > On 12/9/19 12:06 PM, Thomas Zimmermann wrote: >> The load/unload callbacks in struct drm_driver are deprecated. Remove >> them and call functions explicitly. >> >> Signed-off-by: Thomas Zimmermann >> --- >> drivers/gpu/drm/vmwgfx/vmwgf

Re: [PATCH v1 2/2] drm/komeda: Refactor sysfs node "config_id"

2019-12-10 Thread james qian wang (Arm Technology China)
On Tue, Nov 26, 2019 at 01:08:05PM +0100, Daniel Vetter wrote: > On Tue, Nov 26, 2019 at 10:54:47AM +, james qian wang (Arm Technology > China) wrote: > > From: "James Qian Wang (Arm Technology China)" > > > > Split sysfs config_id bitfiles to multiple separated sysfs files. > > > > Signed-of

Re: [PATCH v3 0/9] drm/meson: add AFBC support

2019-12-10 Thread Neil Armstrong
On 09/12/2019 23:09, Kevin Hilman wrote: > Neil Armstrong writes: > >> This adds support for the ARM Framebuffer Compression decoders found >> in the Amlogic GXM and G12A SoCs. >> >> This patchset is a merge of v2 "drm/meson: add AFBC support" at [3] and v2 >> "drm/meson: implement RDMA for AFBC

Re: [PATCH] drm/edid: fixup EDID 1.3 and 1.4 judge reduced-blanking timings logic

2019-12-10 Thread Jani Nikula
On Tue, 26 Nov 2019, allen wrote: > According to VESA ENHANCED EXTENDED DISPLAY IDENTIFICATION DATA STANDARD > (Defines EDID Structure Version 1, Revision 4) page: 39 > How to determine whether the monitor support RB timing or not? > EDID 1.4 > First: read detailed timing descriptor and make sure

nouveau-fixes 5.5

2019-12-10 Thread Ben Skeggs
The following changes since commit e42617b825f8073569da76dc4510bfa019b1c35a: Linux 5.5-rc1 (2019-12-08 14:57:55 -0800) are available in the Git repository at: git://github.com/skeggsb/linux.git linux-5.5 for you to fetch changes up to 3d1890ef8023e61934e070021b06cc9f417260c0: drm/nouveau

Re: [Linux-stm32] [PATCH v4 0/4] Genericize DW MIPI DSI bridge and add i.MX 6 driver

2019-12-10 Thread Adrian Ratiu
On Mon, 02 Dec 2019, Adrian Ratiu wrote: Having a generic Synopsis DesignWare MIPI-DSI host controller bridge driver is a very good idea, however the current implementation has hardcoded quite a lot of the register layouts used by the two supported SoC vendors, STM and Rockchip, which use IP

Re: [Linux-stm32] [PATCH v4 0/4] Genericize DW MIPI DSI bridge and add i.MX 6 driver

2019-12-10 Thread Adrian Ratiu
On Fri, 06 Dec 2019, Philippe CORNU wrote: Hi Adrian, And sorry for this late reply. Your patches look good and we ("stm guys") understand that v1.01 is very different to v1.30/31. We are doing our best to review & test your patches and we will go back to you asap. Many thanks, Philipp

Re: [PATCH] drm/doc: Drop :c:func: markup

2019-12-10 Thread Thierry Reding
On Tue, Dec 10, 2019 at 11:33:16AM +0100, Daniel Vetter wrote: > On Thu, Dec 05, 2019 at 05:05:37PM +0100, Thierry Reding wrote: > > On Wed, Dec 04, 2019 at 11:19:33AM +0100, Daniel Vetter wrote: > > > Kernel sphinx has learned how to do that in > > > > > > commit d74b0d31dddeac2b44c715588d53d9a1e

Re: [PATCH] drm/vmwgfx: Call vmw_driver_{load,unload}() before registering device

2019-12-10 Thread Thomas Hellstrom
On 12/9/19 12:06 PM, Thomas Zimmermann wrote: > The load/unload callbacks in struct drm_driver are deprecated. Remove > them and call functions explicitly. > > Signed-off-by: Thomas Zimmermann > --- > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 44 + > 1 file changed, 38 ins

[PATCH 1/8] drm/print: introduce new struct drm_device based logging macros

2019-12-10 Thread Jani Nikula
Add new struct drm_device based logging macros modeled after the core kernel device based logging macros. These would be preferred over the drm printk and struct device based macros in drm code, where possible. We have existing drm specific struct device based logging functions, but they are too v

[PATCH 6/8] drm/atomic: convert to drm device based logging

2019-12-10 Thread Jani Nikula
Prefer drm_dbg_atomic(). Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_agpsupport.c | 4 +- drivers/gpu/drm/drm_atomic.c | 187 +-- 2 files changed, 102 insertions(+), 89 deletions(-) diff --git a/drivers/gpu/drm/drm_agpsupport.c b/drivers/gpu/drm/drm_agps

[PATCH 2/8] drm/client: convert to drm device based logging

2019-12-10 Thread Jani Nikula
Prefer drm_dbg_kms() and drm_err() over DRM_DEV_DEBUG_KMS() and DRM_DEV_ERROR(). Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_client.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/drm_client.c b/drivers/gpu/drm/drm_client.c index d9a2e36955

[PATCH 4/8] drm/gem-fb-helper: convert to drm device based logging

2019-12-10 Thread Jani Nikula
Prefer drm_dbg_kms() and drm_err() over all other logging. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_gem_framebuffer_helper.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/drm_gem_framebuffer_helper.c b/drivers/gpu/drm/drm_gem_framebuffer_help

[PATCH 7/8] drm/i915/uc: convert to drm device based logging

2019-12-10 Thread Jani Nikula
Prefer drm_dbg() over DRM_DEV_DEBUG_DRIVER(). Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/gt/uc/intel_guc.c | 2 +- drivers/gpu/drm/i915/gt/uc/intel_huc.c | 2 +- drivers/gpu/drm/i915/gt/uc/intel_uc.c| 12 ++-- drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c | 10 +- 4

[PATCH 3/8] drm/fb-helper: convert to drm device based logging

2019-12-10 Thread Jani Nikula
Prefer drm_dbg_kms(), drm_info(), and drm_err() over all other logging. This is about KMS so switch to the KMS category while at it. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_fb_helper.c | 36 ++--- 1 file changed, 20 insertions(+), 16 deletions(-) diff --gi

[PATCH 8/8] drm/i915/wopcm: convert to drm device based logging

2019-12-10 Thread Jani Nikula
Prefer drm_dbg() over DRM_DEV_DEBUG_DRIVER(). Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_wopcm.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_wopcm.c b/drivers/gpu/drm/i915/intel_wopcm.c index 2bb9f9f9a50a..4e8f2862cf

[PATCH 5/8] drm/mipi-dbi: convert to drm device based logging

2019-12-10 Thread Jani Nikula
Prefer drm device based logging where possible. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_mipi_dbi.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/drm_mipi_dbi.c b/drivers/gpu/drm/drm_mipi_dbi.c index e34058c721be..86d98e7fc30a 10064

Re: [PATCH 1/8] drm/print: introduce new struct drm_device based logging macros

2019-12-10 Thread Jani Nikula
On Tue, 10 Dec 2019, Jani Nikula wrote: > Add new struct drm_device based logging macros modeled after the core > kernel device based logging macros. These would be preferred over the > drm printk and struct device based macros in drm code, where possible. As to cover letter, patches 2-8 using th

[PATCH v2] drm/vmwgfx: Call vmw_driver_{load, unload}() before registering device

2019-12-10 Thread Thomas Zimmermann
The load/unload callbacks in struct drm_driver are deprecated. Remove them and call functions explicitly. v2: * remove accidental whitespace fix Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 42 + 1 file changed, 37 insertions(+),

Re: [PATCH RFC 2/8] drm/sprd: add Unisoc's drm kms master

2019-12-10 Thread Thomas Zimmermann
Hi Am 10.12.19 um 13:38 schrieb tang pengchuan: > Hi > > Thomas Zimmermann mailto:tzimmerm...@suse.de>> 于 > 2019年12月10日周二 下午6:33写道: > > Hi > > Am 10.12.19 um 09:36 schrieb Kevin Tang: > > From: Kevin Tang > > > > > Adds drm support for the

Re: [PATCH v8 23/26] mm/gup: pass flags arg to __gup_device_* functions

2019-12-10 Thread Jan Kara
On Mon 09-12-19 14:53:41, John Hubbard wrote: > A subsequent patch requires access to gup flags, so pass the flags > argument through to the __gup_device_* functions. > > Also placate checkpatch.pl by shortening a nearby line. > > TODO: Christoph Hellwig requested folding this into the patch the

Re: [Nouveau] [PATCH v3 0/9] drm/nouveau: Various fixes for GP10B

2019-12-10 Thread Thierry Reding
On Tue, Dec 10, 2019 at 06:15:30PM +1000, Ben Skeggs wrote: > On Mon, 9 Dec 2019 at 22:00, Thierry Reding wrote: > > > > From: Thierry Reding > > > > Hi Ben, > > > > here's a revised subset of the patches I had sent out a couple of weeks > > ago. I've reworked the BAR2 accesses in the way that yo

Re: [PATCH] drm: Rename drm_bridge->dev to drm

2019-12-10 Thread Mihail Atanassov
On Tuesday, 10 December 2019 10:12:50 GMT Daniel Vetter wrote: > On Fri, Dec 06, 2019 at 12:59:04PM +0100, Thomas Zimmermann wrote: > > Hi > > > > Am 06.12.19 um 12:25 schrieb Mihail Atanassov: > > > Hallo Thomas, > > > > > > On Thursday, 5 December 2019 18:20:06 GMT Thomas Zimmermann wrote: > >

Re: [PATCH v8 24/26] mm/gup: track FOLL_PIN pages

2019-12-10 Thread Jan Kara
On Mon 09-12-19 14:53:42, John Hubbard wrote: > Add tracking of pages that were pinned via FOLL_PIN. > > As mentioned in the FOLL_PIN documentation, callers who effectively set > FOLL_PIN are required to ultimately free such pages via unpin_user_page(). > The effect is similar to FOLL_GET, and may

Re: [PATCH] drm/doc: Drop :c:func: markup

2019-12-10 Thread Jonathan Corbet
On Tue, 10 Dec 2019 11:33:16 +0100 Daniel Vetter wrote: > Jon, any plans to also add the other auto-markup eventually? We have quite > an impressive pile of :c:type: noise in our docs ... It's on the list...but the list is long. As in I'm shopping for a new cloud provider that offers storage op

[PATCH][next] drm/i915/selftests: fix uninitialized variable sum when summing up values

2019-12-10 Thread Colin King
From: Colin Ian King Currently the variable sum is not uninitialized and hence will cause an incorrect result in the summation values. Fix this by initializing sum to the first item in the summation. Addresses-Coverity: ("Uninitialized scalar variable") Fixes: 3c7a44bbbfa7 ("drm/i915/selftests:

[PATCH][next] drm/i915: remove redundant checks for a null fb pointer

2019-12-10 Thread Colin King
From: Colin Ian King A prior check and return when pointer fb is null makes subsequent null checks on fb redundant. Remove the redundant null checks. Addresses-Coverity: ("Logically dead code") Signed-off-by: Colin Ian King --- drivers/gpu/drm/i915/i915_debugfs.c | 4 ++-- 1 file changed, 2 i

[PATCH][next] drm/i915/display: remove duplicated assignment to pointer crtc_state

2019-12-10 Thread Colin King
From: Colin Ian King Pointer crtc_state is being assigned twice, one of these is redundant and can be removed. Addresses-Coverity: ("Evaluation order violation") Signed-off-by: Colin Ian King --- drivers/gpu/drm/i915/display/intel_display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH] drm/bridge: panel: export drm_panel_bridge_connector

2019-12-10 Thread Mihail Atanassov
The function was unexported and was causing link failures for pl111 (and probably the other user tve200) in a module build. Fixes: d383fb5f8add ("drm: get drm_bridge_panel connector via helper") Cc: Sam Ravnborg Cc: Laurent Pinchart Cc: Linux Walleij Signed-off-by: Mihail Atanassov --- driver

Re: [PATCH][next] drm/i915/selftests: fix uninitialized variable sum when summing up values

2019-12-10 Thread Chris Wilson
Quoting Colin King (2019-12-10 14:32:05) > From: Colin Ian King > > Currently the variable sum is not uninitialized and hence will cause an > incorrect result in the summation values. Fix this by initializing > sum to the first item in the summation. > > Addresses-Coverity: ("Uninitialized scal

[PATCH] drm: remove drm_bridge->dev

2019-12-10 Thread Mihail Atanassov
As suggested in [1], the 'dev' field is a bit repetitive, since it 1:1 follows the setting and NULLing of the 'encoder' field. Therefore, use drm_bridge->encoder->dev in place of drm_bridge->dev. [1] https://patchwork.freedesktop.org/patch/343824/ Cc: Daniel Vetter Suggested-by: Thomas Zimmerman

Re: [PATCH v2] drm: add dp helper to initialize remote aux channel.

2019-12-10 Thread Harry Wentland
On 2019-12-06 5:56 p.m., David (Dingchen) Zhang wrote: > [why] > We need to minimally initialize the remote aux channel, e.g. the > crc work struct of remote aux to dump the sink's DPRX CRCs in MST > setup. > > [how] > Add helper that only initializes the crc work struct of the remote > aux, hooke

[drm-tip:drm-tip 5/9] ERROR: "drm_panel_bridge_connector" [drivers/gpu/drm/tve200/tve200_drm.ko] undefined!

2019-12-10 Thread kbuild test robot
tree: git://anongit.freedesktop.org/drm/drm-tip drm-tip head: bbcf5f94e2ae795beec14cba06533ff3a9971cc0 commit: 4bfc7f77430f2a83af4a5151a46d33d200d9 [5/9] Merge remote-tracking branch 'drm-misc/drm-misc-next' into drm-tip config: sparc64-allmodconfig (attached as .config) compiler: sparc64-

Re: [PATCH] drm: remove drm_bridge->dev

2019-12-10 Thread Thomas Zimmermann
Am 10.12.19 um 16:25 schrieb Thomas Zimmermann: > > > Am 10.12.19 um 16:11 schrieb Mihail Atanassov: >> As suggested in [1], the 'dev' field is a bit repetitive, since it 1:1 >> follows the setting and NULLing of the 'encoder' field. Therefore, use >> drm_bridge->encoder->dev in place of drm_br

Re: [PATCH] drm: remove drm_bridge->dev

2019-12-10 Thread Thomas Zimmermann
Am 10.12.19 um 16:11 schrieb Mihail Atanassov: > As suggested in [1], the 'dev' field is a bit repetitive, since it 1:1 > follows the setting and NULLing of the 'encoder' field. Therefore, use > drm_bridge->encoder->dev in place of drm_bridge->dev. > > [1] https://patchwork.freedesktop.org/patch

[PATCH for-5.6 1/2] drm/bridge: dw-hdmi: Follow the standard ALSA memalloc way

2019-12-10 Thread Takashi Iwai
The driver manages actually two different buffers: the internal buffer that is pre-allocated at the probe time and the vmalloc buffer for PCM streams allocated at each stream open time. The problem of the current code is that the PCM core rather expects other way round, i.e. the the vmalloc buffer

[PATCH for-5.6 0/2] drm/bridge: dw-hdmi: PCM API updates

2019-12-10 Thread Takashi Iwai
Hi, this is a patch set for updating ALSA PCM API usages in dw-hdmi driver. I already tried to "fix" the driver some time ago but it was utterly wrong. So this is a combination of the revised patch and another cleanup patch. The first one is to change the buffer allocation mechanism in the driv

[PATCH for-5.6 2/2] drm/bridge: dw-hdmi: Drop superfluous ioctl PCM ops

2019-12-10 Thread Takashi Iwai
PCM core deals the empty ioctl field now as default. Let's kill the redundant lines. Signed-off-by: Takashi Iwai --- drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c b/drivers/gpu/drm/bridg

Re: [PATCH RFC 2/8] drm/sprd: add Unisoc's drm kms master

2019-12-10 Thread Emil Velikov
Welcome to DRM Kevin, On Tue, 10 Dec 2019 at 08:40, Kevin Tang wrote: > > From: Kevin Tang > > Adds drm support for the Unisoc's display subsystem. > > This is drm device and gem driver. This driver provides support for the > Direct Rendering Infrastructure (DRI) in XFree86 4.1.0 and higher. > D

Re: [PATCH] drm/bridge: panel: export drm_panel_bridge_connector

2019-12-10 Thread Laurent Pinchart
Hi Mihail, Thank you for the patch. On Tue, Dec 10, 2019 at 02:48:49PM +, Mihail Atanassov wrote: > The function was unexported and was causing link failures for pl111 (and > probably the other user tve200) in a module build. > > Fixes: d383fb5f8add ("drm: get drm_bridge_panel connector via

Re: [PATCH RFC 4/8] drm/sprd: add Unisoc's drm display controller driver

2019-12-10 Thread Emil Velikov
Hi Kevin, On Tue, 10 Dec 2019 at 08:41, Kevin Tang wrote: > > From: Kevin Tang > > Adds DPU(Display Processor Unit) support for the Unisoc's display subsystem. > It's support multi planes, scaler, rotation, PQ(Picture Quality) and more. > > Cc: Orson Zhai > Cc: Baolin Wang > Cc: Chunyan Zhang

Re: [PATCH] drm/bridge: panel: export drm_panel_bridge_connector

2019-12-10 Thread Mihail Atanassov
On Tuesday, 10 December 2019 16:26:47 GMT Laurent Pinchart wrote: > Hi Mihail, > > Thank you for the patch. > > On Tue, Dec 10, 2019 at 02:48:49PM +, Mihail Atanassov wrote: > > The function was unexported and was causing link failures for pl111 (and > > probably the other user tve200) in a m

[Bug 205827] New: drm:drm_atomic_helper_wait_for_dependencies - drm_kms_helper - flip_done timed out

2019-12-10 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=205827 Bug ID: 205827 Summary: drm:drm_atomic_helper_wait_for_dependencies - drm_kms_helper - flip_done timed out Product: Drivers Version: 2.5 Kernel Version: 5.3.13-vanilla

Re: [PATCH v2] drm/vmwgfx: Call vmw_driver_{load,unload}() before registering device

2019-12-10 Thread Thomas Hellstrom
On 12/10/19 1:43 PM, Thomas Zimmermann wrote: > The load/unload callbacks in struct drm_driver are deprecated. Remove > them and call functions explicitly. > > v2: > * remove accidental whitespace fix > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Thomas Hellstrom I'll take this

Re: [PATCH RFC 0/8] Add Unisoc's drm kms module

2019-12-10 Thread Sam Ravnborg
Hi Kevin. Thanks for this new driver. A few somments triggered alone from the diffstat. > Kevin Tang (8): > dt-bindings: display: add Unisoc's drm master bindings > drm/sprd: add Unisoc's drm kms master > dt-bindings: display: add Unisoc's dpu bindings > drm/sprd: add Unisoc's drm display

[PATCH] drm/drm_panel: fix EXPORT of drm_panel_of_backlight

2019-12-10 Thread Sam Ravnborg
Fix link failure for module builds of panels. The conditional compilation around drm_panel_of_backlight() was wrong for a module build. Fix it using IS_ENABLED(). Fixes: 152dbdeab1b2 ("drm/panel: add backlight support") Cc: Sam Ravnborg Cc: Laurent Pinchart Cc: Thierry Reding Cc: Maarten Lankho

Re: [PATCH v4] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges

2019-12-10 Thread Dave Airlie
On Mon, 9 Dec 2019 at 21:39, Rafael J. Wysocki wrote: > > On Mon, Dec 9, 2019 at 12:17 PM Karol Herbst wrote: > > > > anybody any other ideas? > > Not yet, but I'm trying to collect some more information. > > > It seems that both patches don't really fix > > the issue and I have no idea left on m

[PATCH] drm/amd/display: include linux/slab.h where needed

2019-12-10 Thread Arnd Bergmann
Calling kzalloc() and related functions requires the linux/slab.h header to be included: drivers/gpu/drm/amd/amdgpu/../display/dc/dcn21/dcn21_resource.c: In function 'dcn21_ipp_create': drivers/gpu/drm/amd/amdgpu/../display/dc/dcn21/dcn21_resource.c:679:3: error: implicit declaration of function

[PATCH libdrm] intel: sync i915_pciids.h with kernel

2019-12-10 Thread José Roberto de Souza
It is missing the new EHL/JSL PCI ids added in commit 651cc835d5f6 ("drm/i915: Add new EHL/JSL PCI ids") Cc: James Ausmus Cc: Matt Roper Signed-off-by: José Roberto de Souza --- intel/i915_pciids.h | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/intel/i915_pciids.h b

Re: [PATCH] drm/edid: Add modes from CTA-861-G

2019-12-10 Thread Ville Syrjälä
On Tue, Dec 10, 2019 at 11:13:35AM -0800, Tom Anderson wrote: > On Tue, Dec 03, 2019 at 02:53:12PM +0200, Ville Syrjälä wrote: > > On Mon, Dec 02, 2019 at 03:32:46PM -0800, Tom Anderson wrote: > > > On Mon, Nov 25, 2019 at 01:42:00PM -0500, Bhawanpreet Lakha wrote: > > > > Reviewed-by: Bhawanpreet

Re: [PATCH 2/5] drm: atmel-hlcdc: enable clock before configuring timing engine

2019-12-10 Thread Sam Ravnborg
Hi Claudiu. On Tue, Dec 10, 2019 at 03:24:44PM +0200, Claudiu Beznea wrote: > Changing pixel clock source without having this clock source enabled > will block the timing engine and the next operations after (in this case > setting ATMEL_HLCDC_CFG(5) settings in atmel_hlcdc_crtc_mode_set_nofb() >

Re: [PATCH] drm/amd/display: include linux/slab.h where needed

2019-12-10 Thread Kazlauskas, Nicholas
On 2019-12-10 2:59 p.m., Arnd Bergmann wrote: Calling kzalloc() and related functions requires the linux/slab.h header to be included: drivers/gpu/drm/amd/amdgpu/../display/dc/dcn21/dcn21_resource.c: In function 'dcn21_ipp_create': drivers/gpu/drm/amd/amdgpu/../display/dc/dcn21/dcn21_resource.c

Re: [PATCH 5/5] Revert "drm: atmel-hlcdc: enable sys_clk during initalization."

2019-12-10 Thread Sam Ravnborg
Hi Cladiu On Tue, Dec 10, 2019 at 03:24:47PM +0200, Claudiu Beznea wrote: > This reverts commit d2c755e66617620b729041c625a6396c81d1231c. > ("drm: atmel-hlcdc: enable sys_clk during initalization."). With > commit "drm: atmel-hlcdc: enable clock before configuring timing engine" > there is no need

<    1   2   3   4   >