Re: [PATCH v2 01/25] drm/drm_panel: no error when no callback

2019-12-08 Thread Sam Ravnborg
Hi MichaƂ > > diff --git a/include/drm/drm_panel.h b/include/drm/drm_panel.h > > index ce8da64022b4..d71655b2634c 100644 > > --- a/include/drm/drm_panel.h > > +++ b/include/drm/drm_panel.ha > [...] > > /** > > * @get_modes: > > * > > -* Add modes to the connector that the panel i

Re: [PATCH 2/4] drm/of: add support to find any enabled endpoint

2019-12-08 Thread Sam Ravnborg
Hi Rob. Patch looks good, one small improvement proposal. On Sat, Dec 07, 2019 at 12:35:51PM -0800, Rob Clark wrote: > From: Rob Clark > > To handle the case where there are multiple panel endpoints, only one of > which is enabled/installed, add support for a wildcard endpoint value to > reques

Re: [PATCH 1/4] dt-bindings: display: panel: document panel-id

2019-12-08 Thread Sam Ravnborg
Hi Rob. The panel-id can be used to help in several usecase. With a few nits pointed out below fixed: Reviewed-by: Sam Ravnborg Sam On Sat, Dec 07, 2019 at 12:35:50PM -0800, Rob Clark wrote: > From: Rob Clark > > For devices that have one of several possible panels installed, the > pa

Re: [PATCH 1/4] dt-bindings: display: panel: document panel-id

2019-12-08 Thread Laurent Pinchart
Hi Rob, Thank you for the patch. On Sat, Dec 07, 2019 at 12:35:50PM -0800, Rob Clark wrote: > From: Rob Clark > > For devices that have one of several possible panels installed, the > panel-id property gives firmware a generic way to locate and enable the > panel node corresponding to the insta

Re: [PATCH 1/4] dt-bindings: display: panel: document panel-id

2019-12-08 Thread Rob Clark
On Sun, Dec 8, 2019 at 6:45 AM Laurent Pinchart wrote: > > Hi Rob, > > Thank you for the patch. > > On Sat, Dec 07, 2019 at 12:35:50PM -0800, Rob Clark wrote: > > From: Rob Clark > > > > For devices that have one of several possible panels installed, the > > panel-id property gives firmware a gen

[Bug 201957] amdgpu: ring gfx timeout

2019-12-08 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=201957 --- Comment #23 from shallowa...@gmail.com --- Thanks for the link to the bug. I'm running an ubuntu based system and am using the oibaf ppa. The current version is 20.0. On Wed, Dec 4, 2019 at 1:54 AM wrote: > https://bugzilla.kernel.org/sh

Re: [PATCH 1/4] dt-bindings: display: panel: document panel-id

2019-12-08 Thread Laurent Pinchart
Hi Rob, On Sun, Dec 08, 2019 at 08:50:32AM -0800, Rob Clark wrote: > On Sun, Dec 8, 2019 at 6:45 AM Laurent Pinchart wrote: > > On Sat, Dec 07, 2019 at 12:35:50PM -0800, Rob Clark wrote: > > > From: Rob Clark > > > > > > For devices that have one of several possible panels installed, the > > > pa

Re: [PATCH 1/4] dt-bindings: display: panel: document panel-id

2019-12-08 Thread Rob Clark
On Sun, Dec 8, 2019 at 10:28 AM Laurent Pinchart wrote: > > Hi Rob, > > On Sun, Dec 08, 2019 at 08:50:32AM -0800, Rob Clark wrote: > > On Sun, Dec 8, 2019 at 6:45 AM Laurent Pinchart wrote: > > > On Sat, Dec 07, 2019 at 12:35:50PM -0800, Rob Clark wrote: > > > > From: Rob Clark > > > > > > > > Fo

[Bug 201539] AMDGPU R9 390 automatic fan speed control in Linux 4.19/4.20/5.0

2019-12-08 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=201539 --- Comment #50 from MasterCATZ (masterc...@hotmail.com) --- Thanks for correction, I was unsure if $HWMON knew to go to hwmon1 works until GPU hits 70 deg then something forces "pwm1_enable" to auto and starts ramping the fan speed down until it

Re: [PATCH v2 01/25] drm/drm_panel: no error when no callback

2019-12-08 Thread Laurent Pinchart
Hi Sam, Thank you for the patch. On Sat, Dec 07, 2019 at 03:03:29PM +0100, Sam Ravnborg wrote: > The callbacks in drm_panel_funcs are optional, so do not > return an error just because no callback is assigned. > > v2: > - Document what functions in drm_panel_funcs are optional (Laurent) > - Retu

[Bug 201539] AMDGPU R9 390 automatic fan speed control in Linux 4.19/4.20/5.0

2019-12-08 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=201539 --- Comment #51 from MasterCATZ (masterc...@hotmail.com) --- current temp: 61000 interpolated pwm value for temperature 61000 is: 170 current pwm: 165, requested to set pwm to 170 current pwm: 165, requested to set pwm to 170 temp at last change w

Re: [PATCH v2 02/25] drm/panel: add backlight support

2019-12-08 Thread Laurent Pinchart
Hi Sam, Thank you for the patch. On Sat, Dec 07, 2019 at 03:03:30PM +0100, Sam Ravnborg wrote: > Panels often supports backlight as specified in a device tree. s/supports/support/ > Update the drm_panel infrastructure to support this to > simplify the drivers. > > With this the panel driver ju

[radeon-alex:amd-mainline-dkms-5.2 2080/3212] include/kcl/kcl_kref.h:9:21: warning: passing argument 1 of 'atomic_read' from incompatible pointer type

2019-12-08 Thread kbuild test robot
tree: git://people.freedesktop.org/~agd5f/linux.git amd-mainline-dkms-5.2 head: d269e78d6ce76b6e78f9dad26f336745130b2bfa commit: b35c23a557bb753b64082a4aa4057374bcbcca74 [2080/3212] drm/amdkcl: Test whether kref_read() function is available config: x86_64-randconfig-a002-20191206 (attached as

[radeon-alex:amd-mainline-dkms-5.2 2082/3212] drivers/gpu/drm/ttm/ttm_bo_vm.c:427:2: warning: initialization from incompatible pointer type

2019-12-08 Thread kbuild test robot
tree: git://people.freedesktop.org/~agd5f/linux.git amd-mainline-dkms-5.2 head: d269e78d6ce76b6e78f9dad26f336745130b2bfa commit: 3ba40228e28c15ca2dfec398cd7e5ebebdb5a9c2 [2082/3212] drm/amdkcl: Test whether vmf_insert_*() functions are available config: x86_64-randconfig-a002-20191206 (attache

Re: [PATCH v4 0/7] drm/mediatek: fix cursor issue and apply CMDQ in MTK DRM

2019-12-08 Thread CK Hu
Hi, Bibby: I've tried to apply this series to 5.5-rc1, but there are many conflicts. Please resend this series based on 5.5-rc1. And I've found that if I config CONFIG_MTK_CMDQ=m, the code inside '#ifdef CONFIG_MTK_CMDQ' would not be built. I think you should change this to '#if IS_ENABLED(CONFIG

Re: [resend PATCH v6 03/12] drm/mediatek: Use regmap for register access

2019-12-08 Thread CK Hu
Hi, Matthias: On Sat, 2019-12-07 at 23:47 +0100, matthias@kernel.org wrote: > From: Matthias Brugger > > The mmsys memory space is shared between the drm and the > clk driver. Use regmap to access it. Reviewed-by: CK Hu > > Signed-off-by: Matthias Brugger > Reviewed-by: Philipp Zabel >

Re: [resend PATCH v6 04/12] drm: mediatek: Omit warning on probe defers

2019-12-08 Thread CK Hu
Hi, Matthias: On Sat, 2019-12-07 at 23:47 +0100, matthias@kernel.org wrote: > From: Matthias Brugger > > It can happen that the mmsys clock drivers aren't probed before the > platform driver gets invoked. The platform driver used to print a warning > that the driver failed to get the clocks.

Re: [resend PATCH v6 01/12] dt-bindings: display: mediatek: Add mmsys binding description

2019-12-08 Thread CK Hu
Hi, Matthias: On Sat, 2019-12-07 at 23:47 +0100, matthias@kernel.org wrote: > From: Matthias Brugger > > The MediaTek DRM has a block called mmsys, which sets > the routing and enalbes the different blocks. > This patch adds one line for the mmsys bindings description. > > Signed-off-by: Ma

Re: [resend PATCH v6 12/12] drm/mediatek: Add support for mmsys through a pdev

2019-12-08 Thread CK Hu
Hi, Matthias: On Sat, 2019-12-07 at 23:47 +0100, matthias@kernel.org wrote: > From: Matthias Brugger > > The MMSYS subsystem includes clocks and drm components. > This patch adds an initailization path through a platform device > for the clock part, so that both drivers get probed from the s

RE: [PATCH v2] drm/dp_mst: Remove VCPI while disabling topology mgr

2019-12-08 Thread Lin, Wayne
> -Original Message- > From: Lyude Paul > Sent: Saturday, December 7, 2019 3:57 AM > To: Lin, Wayne ; dri-devel@lists.freedesktop.org; > amd-...@lists.freedesktop.org > Cc: Kazlauskas, Nicholas ; Wentland, Harry > ; Zuo, Jerry ; > sta...@vger.kernel.org > Subject: Re: [PATCH v2] drm/dp_m

Re: [PATCH v2 0/2] Meson VPU: fix CVBS output

2019-12-08 Thread Neil Armstrong
Hi Martin ! On 08/12/2019 18:18, Martin Blumenstingl wrote: > The goal of this series is to fix the CVBS output with the Meson VPU > driver. Prior to this series kmscube reported: > failed to set mode: Invalid argument > > Changes since v1 at [0]: > - add patch to remove duplicate code (to matc

Re: [PATCH v2 0/2] Meson VPU: fix CVBS output

2019-12-08 Thread Neil Armstrong
On 08/12/2019 18:18, Martin Blumenstingl wrote: > The goal of this series is to fix the CVBS output with the Meson VPU > driver. Prior to this series kmscube reported: > failed to set mode: Invalid argument > > Changes since v1 at [0]: > - add patch to remove duplicate code (to match patch #2 ea