Re: [PATCH 2/8] drm/panfrost: Fix a race in panfrost_ioctl_madvise()

2019-12-06 Thread Boris Brezillon
On Fri, 6 Dec 2019 08:53:27 +0100 Boris Brezillon wrote: > On Thu, 5 Dec 2019 17:08:02 -0600 > Rob Herring wrote: > > > On Fri, Nov 29, 2019 at 8:33 AM Boris Brezillon > > wrote: > > > > > > On Fri, 29 Nov 2019 14:24:48 + > > > Steven Price wrote: > > > > > > > On 29/11/2019 13:59,

Re: KASAN: slab-out-of-bounds Read in fbcon_get_font

2019-12-06 Thread Dmitry Vyukov
On Thu, Dec 5, 2019 at 11:13 AM Paolo Bonzini wrote: > > On 04/12/19 22:41, syzbot wrote: > > syzbot has bisected this bug to: > > > > commit 2de50e9674fc4ca3c6174b04477f69eb26b4ee31 > > Author: Russell Currey > > Date: Mon Feb 8 04:08:20 2016 + > > > > powerpc/powernv: Remove support f

Re: KASAN: slab-out-of-bounds Read in fbcon_get_font

2019-12-06 Thread Tetsuo Handa
On 2019/12/05 19:16, Dmitry Vyukov wrote: > On Thu, Dec 5, 2019 at 11:13 AM Paolo Bonzini wrote: >> >> On 04/12/19 22:41, syzbot wrote: >>> syzbot has bisected this bug to: >>> >>> commit 2de50e9674fc4ca3c6174b04477f69eb26b4ee31 >>> Author: Russell Currey >>> Date: Mon Feb 8 04:08:20 2016 +

KASAN: slab-out-of-bounds Read in bit_putcs

2019-12-06 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:282ffdf3 Add linux-next specific files for 20191205 git tree: linux-next console output: https://syzkaller.appspot.com/x/log.txt?x=165627f2e0 kernel config: https://syzkaller.appspot.com/x/.config?x=29372c0243b4b980 dashboard

[PATCH] drm/panfrost: no need to display probe deferred error

2019-12-06 Thread Clément Péron
Panfrost driver is shouting an error if the regulator init return an -EPROBE_DEFFER. This is a not a real error and it doesn't require to be display. Check if the error is not an EPROBE_DEFFER before displaying it. Signed-off-by: Clément Péron --- drivers/gpu/drm/panfrost/panfrost_device.c | 6

Re: [v1,1/2] drm/mediatek: Fixup external display black screen issue

2019-12-06 Thread Hsin-Yi Wang
On Thu, Dec 5, 2019 at 3:13 PM Yongqiang Niu wrote: > > please double confirm is this dump stack log is ruining on MT8173 real > IC or not. > if yes, that may caused ovl hang when disable layer not in blanking, > then cause vblank time out. > i will disable overlay with cmdq in next version. > It

Re: [PATCH v2 1/3] drm/i915: Move the code to populate ACPI device ID into intel_acpi

2019-12-06 Thread Rajat Jain
Hi Jani, Thanks for the review. On Wed, Nov 20, 2019 at 6:41 AM Jani Nikula wrote: > > On Mon, 04 Nov 2019, Rajat Jain wrote: > > Move the code that populates the ACPI device ID for devices, into > > more appripriate intel_acpi.c. This is done in preparation for more > > users of this code (in

[PATCH v3 3/3] drm/i915: Add support for integrated privacy screens

2019-12-06 Thread Rajat Jain
Certain laptops now come with panels that have integrated privacy screens on them. This patch adds support for such panels by adding a privacy-screen property to the intel_connector for the panel, that the userspace can then use to control and check the status. Identifying the presence of privacy

[PATCH v3 2/3] drm/i915: Lookup and attach ACPI device node for connectors

2019-12-06 Thread Rajat Jain
Lookup and attach ACPI nodes for intel connectors. The lookup is done in compliance with ACPI Spec 6.3 https://uefi.org/sites/default/files/resources/ACPI_6_3_final_Jan30.pdf (Ref: Pages 1119 - 1123). This can be useful for any connector specific platform properties. (This will be used for privacy

Re: [PATCH] backlight: pwm_bl: Switch to full GPIO descriptor

2019-12-06 Thread Bartosz Golaszewski
czw., 5 gru 2019 o 09:11 Linus Walleij napisał(a): > > The PWM backlight still supports passing a enable GPIO line as > platform data using the legacy API. > > It turns out that ever board using this mechanism except one > is pass .enable_gpio = -1. So we drop all these cargo-culted -1's > from a

Re: [PATCH v2 3/3] drm/i915: Add support for integrated privacy screens

2019-12-06 Thread Rajat Jain
On Wed, Nov 20, 2019 at 7:04 AM Jani Nikula wrote: > > On Mon, 04 Nov 2019, Rajat Jain wrote: > > Certain laptops now come with panels that have integrated privacy > > screens on them. This patch adds support for such panels by adding > > a privacy-screen property to the intel_connector for the p

Re: KASAN: slab-out-of-bounds Read in fbcon_get_font

2019-12-06 Thread Dmitry Vyukov
On Thu, Dec 5, 2019 at 11:53 AM Paolo Bonzini wrote: > > On 05/12/19 11:31, Dmitry Vyukov wrote: > >> Ah, and because the machine is a KVM guest, kvm_wait appears in a lot of > >> backtrace and I get to share syzkaller's joy every time. :) > > I don't see any mention of "kvm" in the crash report.

Re: [PATCH] drm/modes: remove unused variables

2019-12-06 Thread Benjamin GAIGNARD
+ Zhao Yakui On 12/5/19 10:55 AM, Jani Nikula wrote: > On Wed, 04 Dec 2019, Benjamin GAIGNARD wrote: >> On 12/4/19 10:35 AM, Thomas Zimmermann wrote: >>> Hi >>> >>> Am 19.11.19 um 14:47 schrieb Benjamin Gaignard: When compiling with W=1 few warnings about unused variables show up. This

Re: [PATCH v2 2/3] drm/i915: Lookup and attach ACPI device node for connectors

2019-12-06 Thread Rajat Jain
On Wed, Nov 20, 2019 at 6:51 AM Jani Nikula wrote: > > On Mon, 04 Nov 2019, Rajat Jain wrote: > > Lookup and attach ACPI nodes for intel connectors. The lookup is done > > in compliance with ACPI Spec 6.3 > > https://uefi.org/sites/default/files/resources/ACPI_6_3_final_Jan30.pdf > > (Ref: Pages

[PATCH resend] drm/exynos: gsc: add missed component_del

2019-12-06 Thread Chuhong Yuan
The driver forgets to call component_del in remove to match component_add in probe. Add the missed call to fix it. Signed-off-by: Chuhong Yuan --- drivers/gpu/drm/exynos/exynos_drm_gsc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/exynos/exynos_drm_gsc.c b/drivers/gpu/dr

Re: KASAN: slab-out-of-bounds Read in fbcon_get_font

2019-12-06 Thread Tetsuo Handa
On 2019/12/05 19:22, Paolo Bonzini wrote: > Ah, and because the machine is a KVM guest, kvm_wait appears in a lot of > backtrace and I get to share syzkaller's joy every time. :) > > This bisect result is bogus, though Tetsuo found the bug anyway. > Perhaps you can exclude commits that only touch

[PATCH v3] drm/mediatek: Add ctm property support

2019-12-06 Thread Yongqiang Niu
Add ctm property support Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 10 - drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 61 - drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h | 11 ++ 3 files changed, 80 insertions(+), 2 deletion

[PATCH] drm/qxl: remove unnecessary BUG_ON check for handle

2019-12-06 Thread Aditya Pakki
In qxl_gem_object_create_with_handle(), handle's memory is not allocated on the heap. Checking for failure of handle via BUG_ON is unnecessary. This patch eliminates the check. Signed-off-by: Aditya Pakki --- drivers/gpu/drm/qxl/qxl_gem.c | 1 - 1 file changed, 1 deletion(-) diff --git a/driver

Re: KASAN: slab-out-of-bounds Read in fbcon_get_font

2019-12-06 Thread Dmitry Vyukov
On Thu, Dec 5, 2019 at 11:41 AM Tetsuo Handa wrote: > > On 2019/12/05 19:22, Paolo Bonzini wrote: > > Ah, and because the machine is a KVM guest, kvm_wait appears in a lot of > > backtrace and I get to share syzkaller's joy every time. :) > > > > This bisect result is bogus, though Tetsuo found th

KASAN: global-out-of-bounds Read in bit_putcs

2019-12-06 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:2f13437b Merge tag 'trace-v5.5-2' of git://git.kernel.org/.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=104fcc2ae0 kernel config: https://syzkaller.appspot.com/x/.config?x=608557e57ce07817 da

Re: KASAN: slab-out-of-bounds Read in fbcon_get_font

2019-12-06 Thread Dmitry Vyukov
On Thu, Dec 5, 2019 at 11:22 AM Paolo Bonzini wrote: > > On 05/12/19 11:16, Dmitry Vyukov wrote: > > On Thu, Dec 5, 2019 at 11:13 AM Paolo Bonzini wrote: > >> > >> On 04/12/19 22:41, syzbot wrote: > >>> syzbot has bisected this bug to: > >>> > >>> commit 2de50e9674fc4ca3c6174b04477f69eb26b4ee31 >

[PATCH] pxa168fb: fix release function mismatch in probe failure

2019-12-06 Thread Chuhong Yuan
The driver uses kfree() to release the resource allocated by framebuffer_alloc(), which does not match. Use framebuffer_release() instead to fix it. Fixes: 638772c7553f ("fb: add support of LCD display controller on pxa168/910 (base layer)") Signed-off-by: Chuhong Yuan --- drivers/video/fbdev/p

Re: INFO: task hung in fb_open

2019-12-06 Thread Dmitry Vyukov
On Thu, Dec 5, 2019 at 3:05 PM Daniel Vetter wrote: > > On Thu, Dec 5, 2019 at 2:38 PM syzbot > wrote: > > > > syzbot has bisected this bug to: > > > > commit 979c11ef39cee79d6f556091a357890962be2580 > > Author: Ayan Kumar Halder > > Date: Tue Jul 17 17:13:46 2018 + > > > > drm/sun4i:

[PATCH] drm/dp_mst: add missed nv50_outp_release in nv50_msto_disable

2019-12-06 Thread Chuhong Yuan
nv50_msto_disable() does not call nv50_outp_release() to match nv50_outp_acquire() like other disable(). Add the missed call to fix it. Signed-off-by: Chuhong Yuan --- drivers/gpu/drm/nouveau/dispnv50/disp.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/n

[PATCH v3 1/3] drm/i915: Move the code to populate ACPI device ID into intel_acpi

2019-12-06 Thread Rajat Jain
Move the code that populates the ACPI device ID for devices, into more appripriate intel_acpi.c. This is done in preparation for more users of this code (in next patch). Signed-off-by: Rajat Jain --- v3: * Renamed the function to intel_acpi_* * Used forward declaration for structure instead o

[PATCH v2] video: fbdev: vesafb: add missed release_region

2019-12-06 Thread Chuhong Yuan
The driver forgets to free the requested irq in remove and probe failure. Add the missed calls to fix it. Signed-off-by: Chuhong Yuan --- Changes in v2: - Modify commit message. drivers/video/fbdev/vesafb.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/video/fbdev/vesafb.c b/d

Re: INFO: task hung in fb_open

2019-12-06 Thread syzbot
syzbot has bisected this bug to: commit 979c11ef39cee79d6f556091a357890962be2580 Author: Ayan Kumar Halder Date: Tue Jul 17 17:13:46 2018 + drm/sun4i: Substitute sun4i_backend_format_is_yuv() with format->is_yuv bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=15d2f97ee00

Re: KASAN: slab-out-of-bounds Read in fbcon_get_font

2019-12-06 Thread Dmitry Vyukov
On Thu, Dec 5, 2019 at 11:41 AM Tetsuo Handa wrote: > > On 2019/12/05 19:22, Paolo Bonzini wrote: > > Ah, and because the machine is a KVM guest, kvm_wait appears in a lot of > > backtrace and I get to share syzkaller's joy every time. :) > > > > This bisect result is bogus, though Tetsuo found th

[PATCH -next] drm/tegra: sor: Fix unused function warnings

2019-12-06 Thread YueHaibing
drivers/gpu/drm/tegra/sor.c:3984:12: warning: 'tegra_sor_resume' defined but not used [-Wunused-function] drivers/gpu/drm/tegra/sor.c:3970:12: warning: 'tegra_sor_suspend' defined but not used [-Wunused-function] drivers/gpu/drm/tegra/sor.c:3937:12: warning: 'tegra_sor_runtime_resume' defined bu

Re: [PATCH v6 03/15] drm/bridge: tc358767: Simplify polling in tc_link_training()

2019-12-06 Thread Andrey Smirnov
On Wed, Dec 4, 2019 at 10:27 AM Tomi Valkeinen wrote: > > Hi Andrey, > > On 19/06/2019 08:27, Andrey Smirnov wrote: > > > @@ -748,22 +748,19 @@ static int tc_set_video_mode(struct tc_data *tc, > > > > static int tc_wait_link_training(struct tc_data *tc) > > { > > - u32 timeout = 1000; > >

Re: [PATCH] drm/panel: Add Boe Himax8279d MIPI-DSI LCD panel

2019-12-06 Thread Jerry Han
> > Hi Jerry, > > On Tue, 26 Nov 2019 at 08:14, Jerry Han wrote: > > > > Support Boe Himax8279d 8.0" 1200x1920 TFT LCD panel, it is a MIPI DSI > > panel. > > > > V9: > > - Adjust init code, make the format more concise > > - kill off default_off_cmds (Emil) > > - use mipi_dsi_dcs_set_display_{on,o

[PATCH] drm/panel: Add Boe Himax8279d MIPI-DSI LCD panel

2019-12-06 Thread Jerry Han
Support Boe Himax8279d 8.0" 1200x1920 TFT LCD panel, it is a MIPI DSI panel. V9: - Adjust init code, make the format more concise - kill off default_off_cmds (Emil) - use mipi_dsi_dcs_set_display_{on,off} in their enable/disable callbacks. (Emil) - Adjusting the delay function (Emil) V8: - mo

[PATCH] drm/mgag200: Flag all G200 SE A machines as broken wrt

2019-12-06 Thread Thomas Zimmermann
Several MGA G200 SE machines don't respect the value of the startadd register field. After more feedback on affected machines, neither PCI subvendor ID nor the internal ID seem to hint towards the bug. All affected machines have a PCI ID of 0x0522 (i.e., G200 SE A). It was decided to flag all G200

[PATCH v3 0/2] mm, drm/ttm: Fix pte insertion with customized protection

2019-12-06 Thread VMware
From: Thomas Hellstrom The drm/ttm module is using a modified on-stack copy of the struct vm_area_struct to be able to set a page protection with customized caching. Fix that by adding a vmf_insert_mixed_prot() function similar to the existing vmf_insert_pfn_prot() for use with drm/ttm. I'd like

[PATCH v3 1/2] mm: Add a vmf_insert_mixed_prot() function

2019-12-06 Thread VMware
From: Thomas Hellstrom The TTM module today uses a hack to be able to set a different page protection than struct vm_area_struct::vm_page_prot. To be able to do this properly, add the needed vm functionality as vmf_insert_mixed_prot(). Cc: Andrew Morton Cc: Michal Hocko Cc: "Matthew Wilcox (Or

[PATCH v3 2/2] mm, drm/ttm: Fix vm page protection handling

2019-12-06 Thread VMware
From: Thomas Hellstrom TTM graphics buffer objects may, transparently to user-space, move between IO and system memory. When that happens, all PTEs pointing to the old location are zapped before the move and then faulted in again if needed. When that happens, the page protection caching mode- an

[PATCH] drm/dp_mst: clear time slots for ports invalid

2019-12-06 Thread Wayne Lin
[Why] When change the connection status in a MST topology, mst device which detect the event will send out CONNECTION_STATUS_NOTIFY messgae. e.g. src-mst-mst-sst => src-mst (unplug) mst-sst Currently, under the above case of unplugging device, ports which have been allocated payloads and are no l

[PATCH v2 2/7] drm/udl: Don't track number of identical and sent pixels per line

2019-12-06 Thread Thomas Zimmermann
A call to udl_render_hline() returns the number of identical and sent pixels. None of these values is used. Remove the parameters. Signed-off-by: Thomas Zimmermann Reviewed-by: Emil Velikov Acked-by: Gerd Hoffmann --- drivers/gpu/drm/udl/udl_drv.h | 3 +-- drivers/gpu/drm/udl/udl_fb.c

[PATCH v2 0/7] drm/udl: Prepare damage handler for simple-pipe KMS

2019-12-06 Thread Thomas Zimmermann
Udl's damage-handling code requires clean up before switching the driver to simple-pipe helpers. Patches 1, 2 and 7 remove unused state variables and statistics. Patches 3 to 5 reorganize the damage handler to be more readable. Patch 6 moves dma-buf begin/end calls into the damage handler, so they

[PATCH v2 4/7] drm/udl: Move clip-rectangle code out of udl_handle_damage()

2019-12-06 Thread Thomas Zimmermann
Computing the clip rectable in a separate helper function makes the damage-handler code more readable. Signed-off-by: Thomas Zimmermann Reviewed-by: Emil Velikov Acked-by: Gerd Hoffmann --- drivers/gpu/drm/udl/udl_fb.c | 48 1 file changed, 32 insertions(+)

[PATCH v2 1/7] drm/udl: Remove unused statistics counters

2019-12-06 Thread Thomas Zimmermann
None of the udl driver's statistics counters is used anywhere. Remove them. Signed-off-by: Thomas Zimmermann Reviewed-by: Emil Velikov Acked-by: Gerd Hoffmann --- drivers/gpu/drm/udl/udl_drv.h | 4 drivers/gpu/drm/udl/udl_fb.c | 14 +- 2 files changed, 1 insertion(+), 17 del

[PATCH v2 3/7] drm/udl: Vmap framebuffer after all tests succeeded in damage handling

2019-12-06 Thread Thomas Zimmermann
We now do the fast tests before the potentially expensive vmap operation. Signed-off-by: Thomas Zimmermann Reviewed-by: Emil Velikov Acked-by: Gerd Hoffmann --- drivers/gpu/drm/udl/udl_fb.c | 19 +++ drivers/gpu/drm/udl/udl_transfer.c | 1 - 2 files changed, 7 insertions

[PATCH v2 7/7] drm/udl: Remove field lost_pixels from struct udl_device

2019-12-06 Thread Thomas Zimmermann
The field lost_pixels in struct udl_device was supposed to signal an error during USB transfers of the framebuffer data. The driver would have to schedule a re-transfer at a later point. This code was never implemented. Remove lost_pixels and return regular error codes instead. Signed-off-by: Thom

[PATCH v2 5/7] drm/udl: Move log-cpp code out of udl_damage_handler()

2019-12-06 Thread Thomas Zimmermann
Computing the cpp value's logarithm in a separate helper function makes the damage-handler code more readable. Signed-off-by: Thomas Zimmermann Reviewed-by: Emil Velikov Acked-by: Gerd Hoffmann --- drivers/gpu/drm/udl/udl_fb.c | 17 - 1 file changed, 12 insertions(+), 5 deletio

[PATCH v2 6/7] drm/udl: Begin/end access to imported buffers in damage-handler

2019-12-06 Thread Thomas Zimmermann
The damage-handler code now invokes dma_buf_{begin,end}_access() for imported buffers. These calls were missing from the page-flip and modesetting code paths. The patch also fixes an bug in the orignal where an error code was overwritten by the result of dma_buf_end_cpu_access(). v2: * onl

[PATCH] drm/gma500: Pass GPIO for Intel MID using descriptors

2019-12-06 Thread Linus Walleij
The GMA500 driver is using the legacy GPIO API to fetch three optional display control GPIO lines from the SFI description used by the Medfield platform. Switch this over to use GPIO descriptors and delete the custom platform data. We create three new static locals in the tc35876x bridge code but

[PATCH v3 3/4] dt-bindings: display: imx: add bindings for DCSS

2019-12-06 Thread Laurentiu Palcu
Add bindings for iMX8MQ Display Controller Subsystem. Signed-off-by: Laurentiu Palcu Reviewed-by: Rob Herring --- .../bindings/display/imx/nxp,imx8mq-dcss.yaml | 86 ++ 1 file changed, 86 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/imx/n

[PATCH v3 1/4] drm/imx: compile imx directory by default

2019-12-06 Thread Laurentiu Palcu
Currently the drm/imx/ directory is compiled only if DRM_IMX is set. Adding a new IMX related IP in the same directory would need DRM_IMX to be set, which would bring in also IPUv3 core driver... The current patch would allow adding new IPs in the imx/ directory without needing to set DRM_IMX.

[PATCH v3 0/4] Add support for iMX8MQ Display Controller Subsystem

2019-12-06 Thread Laurentiu Palcu
Hi, This patchset adds initial DCSS support for iMX8MQ chip. Initial support includes only graphics plane support (no video planes), no HDR10 capabilities, no graphics decompression (only linear, tiled and super-tiled buffers allowed). Support for the rest of the features will be added incrementa

Re: [PATCH] drm/panfrost: no need to display probe deferred error

2019-12-06 Thread Steven Price
On 05/12/2019 22:11, Clément Péron wrote: > Panfrost driver is shouting an error if the regulator init > return an -EPROBE_DEFFER. This is a not a real error and > it doesn't require to be display. > > Check if the error is not an EPROBE_DEFFER before displaying it. > > Signed-off-by: Clément Pér

Re: [PATCH] drm/mgag200: Flag all G200 SE A machines as broken wrt

2019-12-06 Thread Gerd Hoffmann
> Several MGA G200 SE machines don't respect the value of the startadd > register field. After more feedback on affected machines, neither PCI > subvendor ID nor the internal ID seem to hint towards the bug. All > affected machines have a PCI ID of 0x0522 (i.e., G200 SE A). It was > decided to flag

Re: [PATCH v3 1/2] drm: call drm_gem_object_funcs.mmap with fake offset

2019-12-06 Thread Gerd Hoffmann
On Thu, Dec 05, 2019 at 11:15:23PM +0100, Daniel Vetter wrote: > On Thu, Nov 28, 2019 at 12:39:30PM +0100, Gerd Hoffmann wrote: > > On Wed, Nov 27, 2019 at 10:25:22AM +0100, Gerd Hoffmann wrote: > > > The fake offset is going to stay, so change the calling convention for > > > drm_gem_object_funcs.

Re: [PATCH] drm/qxl: remove unnecessary BUG_ON check for handle

2019-12-06 Thread Gerd Hoffmann
On Thu, Dec 05, 2019 at 05:42:31PM -0600, Aditya Pakki wrote: > In qxl_gem_object_create_with_handle(), handle's memory is not > allocated on the heap. Checking for failure of handle via BUG_ON > is unnecessary. This patch eliminates the check. The check makes sure the caller doesn't pass in handl

Re: [Intel-gfx] [PATCH v3 1/2] drm: call drm_gem_object_funcs.mmap with fake offset

2019-12-06 Thread Daniel Vetter
On Fri, Dec 6, 2019 at 11:07 AM Gerd Hoffmann wrote: > > On Thu, Dec 05, 2019 at 11:15:23PM +0100, Daniel Vetter wrote: > > On Thu, Nov 28, 2019 at 12:39:30PM +0100, Gerd Hoffmann wrote: > > > On Wed, Nov 27, 2019 at 10:25:22AM +0100, Gerd Hoffmann wrote: > > > > The fake offset is going to stay,

Re: [PATCH v3 1/2] drm: call drm_gem_object_funcs.mmap with fake offset

2019-12-06 Thread Gerd Hoffmann
On Fri, Dec 06, 2019 at 11:07:24AM +0100, Gerd Hoffmann wrote: > On Thu, Dec 05, 2019 at 11:15:23PM +0100, Daniel Vetter wrote: > > Looks like unrelated flukes, this happens occasionally. If you're paranoid > > hit the retest button on patchwork to double-check. > > -Daniel > > Guess you kicked CI

Re: [Linux-stm32] [PATCH v4 0/4] Genericize DW MIPI DSI bridge and add i.MX 6 driver

2019-12-06 Thread Philippe CORNU
Hi Adrian, And sorry for this late reply. Your patches look good and we ("stm guys") understand that v1.01 is very different to v1.30/31. We are doing our best to review & test your patches and we will go back to you asap. Many thanks, Philippe :-) On 12/2/19 8:33 PM, Adrian Ratiu wrote: > Ha

Re: [PATCH v3 2/2] mm, drm/ttm: Fix vm page protection handling

2019-12-06 Thread Michal Hocko
On Fri 06-12-19 09:24:26, Thomas Hellström (VMware) wrote: [...] > @@ -283,11 +282,26 @@ vm_fault_t ttm_bo_vm_fault_reserved(struct vm_fault > *vmf, > pfn = page_to_pfn(page); > } > > + /* > + * Note that the value of @prot at this poi

Re: [Intel-gfx] [PATCH v3 1/2] drm: call drm_gem_object_funcs.mmap with fake offset

2019-12-06 Thread Daniel Vetter
On Fri, Dec 6, 2019 at 11:22 AM Gerd Hoffmann wrote: > > On Fri, Dec 06, 2019 at 11:07:24AM +0100, Gerd Hoffmann wrote: > > On Thu, Dec 05, 2019 at 11:15:23PM +0100, Daniel Vetter wrote: > > > Looks like unrelated flukes, this happens occasionally. If you're paranoid > > > hit the retest button on

[PATCH] drm/Kconfig: add missing 'depends on DRM' for DRM_DP_CEC

2019-12-06 Thread Hans Verkuil
Add a missing 'depends on DRM' for the DRM_DP_CEC config option. Without that enabling DRM_DP_CEC will force CEC_CORE to =y instead of =m if DRM=m as well. Signed-off-by: Hans Verkuil --- diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig index 1168351267fd..e8e478d6da9c 100644 --- a/

Re: [PATCH] drm: Rename drm_bridge->dev to drm

2019-12-06 Thread Mihail Atanassov
Hallo Thomas, On Thursday, 5 December 2019 18:20:06 GMT Thomas Zimmermann wrote: > Hi > > Am 05.12.19 um 17:30 schrieb Mihail Atanassov: > > The 'dev' name causes some confusion with 'struct device' [1][2], so use > > 'drm' instead since this seems to be the prevalent name for 'struct > > drm_dev

[Bug 205661] Upgrade to 5.4 from K5.3.13 fails x2 attempts

2019-12-06 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=205661 Artem S. Tashkinov (a...@gmx.com) changed: What|Removed |Added Status|NEW |RESOLVED

Re: [PATCH] drm: Rename drm_bridge->dev to drm

2019-12-06 Thread Thomas Zimmermann
Hi Am 06.12.19 um 12:25 schrieb Mihail Atanassov: > Hallo Thomas, > > On Thursday, 5 December 2019 18:20:06 GMT Thomas Zimmermann wrote: >> Hi >> >> Am 05.12.19 um 17:30 schrieb Mihail Atanassov: >>> The 'dev' name causes some confusion with 'struct device' [1][2], so use >>> 'drm' instead since

Re: [Intel-gfx] [PATCH v3 1/2] drm: call drm_gem_object_funcs.mmap with fake offset

2019-12-06 Thread Gerd Hoffmann
On Fri, Dec 06, 2019 at 12:10:15PM +0100, Daniel Vetter wrote: > On Fri, Dec 6, 2019 at 11:22 AM Gerd Hoffmann wrote: > > > > > Guess you kicked CI? Just got CI mails, now reporting success, without > > > doing anything. So I'll go push v3 to misc-next. > > > > Oops, spoke too soon. Next mail a

[PATCH v2 2/9] drm/udl: Convert to struct drm_simple_display_pipe

2019-12-06 Thread Thomas Zimmermann
Udl has a single display pipeline with a primary plane; perfect for simple-pipe helpers. Convert it over. The old encoder and CRTC code becomes unused and obsolete. Exported formats for the primary plane are RGB565 and XRGB, with the latter being emulated. The 16-bit format is the default and

[PATCH v2 0/9] drm/udl: Convert to simple-pipe helpers and clean up

2019-12-06 Thread Thomas Zimmermann
With only a single display pipeline and primary plane, udl is perfect for simple-pipe helpers. Patches 1 to 4 do the convertion. This enables atomic modesetting for udl devices. Patches 5 to 8 clean up handling of color depth and framebuffers. With universal planes that come with simple pipe, disp

[PATCH v2 8/9] drm/udl: Move udl_handle_damage() into udl_modeset.c

2019-12-06 Thread Thomas Zimmermann
The only caller of udl_handle_damage() in the plane-update function in udl_modeset.c. Move udl_handle_damage() there. v2: * remove udl_fb.c in a separate patch Signed-off-by: Thomas Zimmermann Reviewed-by: Daniel Vetter Reviewed-by: Emil Velikov --- drivers/gpu/drm/udl/udl_drv.h |

[PATCH v2 4/9] drm/udl: Inline DPMS code into CRTC enable and disable functions

2019-12-06 Thread Thomas Zimmermann
DPMS functionality is only used by the CRTC's enable and disable functions. Inline the code. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/udl/udl_modeset.c | 84 +++ 1 file changed, 30 insertions(+), 54 deletions(-) diff --git a/drivers/gpu/drm/udl/udl_modese

[PATCH v2 3/9] drm/udl: Switch to atomic suspend/resume helpers

2019-12-06 Thread Thomas Zimmermann
We can use the generic suspend/resume helpers for atomic modesetting. Switch udl over. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/udl/udl_drv.c | 7 ++- drivers/gpu/drm/udl/udl_drv.h | 1 - drivers/gpu/drm/udl/udl_modeset.c | 14 -- 3 files changed, 2 insertio

[PATCH v2 5/9] drm/udl: Set preferred color depth to 16 bpp

2019-12-06 Thread Thomas Zimmermann
The current default color depth of 24 bpp is not even supported by the driver. Being the native format for communicating with the adapter, 16 bpp is the correct choice. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/udl/udl_drv.c | 2 +- drivers/gpu/drm/udl/udl_modeset.c | 2 +- 2 file

[PATCH v2 9/9] drm/udl: Remove udl_fb.c

2019-12-06 Thread Thomas Zimmermann
The remaining code in udl_fb.c is unused. Remove the file entirely. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/udl/Makefile | 2 +- drivers/gpu/drm/udl/udl_fb.c | 51 2 files changed, 1 insertion(+), 52 deletions(-) delete mode 100644 drivers/gpu/

[PATCH v2 1/9] drm/udl: Init connector before encoder and CRTC

2019-12-06 Thread Thomas Zimmermann
To mimic simple-pipe, we initialize the connector before the rest of the display pipeline. v2: * remove unnecessary calls to drm_connector_{register,unregister}() Signed-off-by: Thomas Zimmermann Reviewed-by: Daniel Vetter --- drivers/gpu/drm/udl/udl_connector.c | 9 +++-- drivers

[PATCH v2 6/9] drm/udl: Convert to drm_atomic_helper_dirtyfb()

2019-12-06 Thread Thomas Zimmermann
The infrastruture for atomic modesetting allows us to use the generic code for dirty-FB and damage handling. Switch over udl and remove the driver's implementation. The simple-pipe's update function now picks up the primary plane's damage and updates a minimal region of the screen. Signed-off-by:

[PATCH v2 7/9] drm/udl: Remove struct udl_device.active_fb_16

2019-12-06 Thread Thomas Zimmermann
The udl driver stores the currently active framebuffer to know from where to accept damage updates. With the conversion to plane-state damage handling, this is not necessary any longer. The currently active framebuffer and damaged area are always stored in the plane state. Signed-off-by: Thomas Z

Re: [PATCH 04/11] drm/i915: Don't WARN on HDCP toggle if get_hw_state returns false

2019-12-06 Thread Sean Paul
On Thu, Dec 05, 2019 at 09:39:35PM +0200, Ville Syrjälä wrote: > On Tue, Dec 03, 2019 at 12:36:27PM -0500, Sean Paul wrote: > > From: Sean Paul > > > > Now that we can rely on transcoder disable to toggle signalling off, > > it's less of a catastrophe if get_hw_state() returns false. > > > > Onc

[PATCH v2 2/2] drm/atomic: Spell CRTC consistently

2019-12-06 Thread Thierry Reding
From: Thierry Reding CRTC is an abbreviation and should be all caps in prose. Update all kerneldoc comments to use a consistent spelling. v2: remove hunk unrelated to the CRTC spelling fixes Reviewed-by: Thomas Zimmermann Signed-off-by: Thierry Reding --- drivers/gpu/drm/drm_atomic.c

[PATCH v2 1/2] drm: Fix a couple of typos, punctation and whitespace issues

2019-12-06 Thread Thierry Reding
From: Thierry Reding These are just a couple of things that I came across as I was reading through the code and comments. v2: added one more hunk that ended up in the wrong patch Reviewed-by: Thomas Zimmermann Signed-off-by: Thierry Reding --- drivers/gpu/drm/drm_atomic_helper.c | 12 ++-

Re: [Intel-gfx] [PATCH 03/11] drm/i915: Disable HDCP signalling on transcoder disable

2019-12-06 Thread Sean Paul
On Thu, Dec 05, 2019 at 09:33:19PM +0200, Ville Syrjälä wrote: > On Tue, Dec 03, 2019 at 12:36:26PM -0500, Sean Paul wrote: > > From: Sean Paul > > > > Currently we rely on intel_hdcp_disable() to disable HDCP signalling in > > the DDI Function Control register. This patch adds a safety net by al

Re: [PATCH v3 2/2] mm, drm/ttm: Fix vm page protection handling

2019-12-06 Thread Thomas Hellstrom
Hi Michal, On Fri, 2019-12-06 at 11:30 +0100, Michal Hocko wrote: > On Fri 06-12-19 09:24:26, Thomas Hellström (VMware) wrote: > [...] > > @@ -283,11 +282,26 @@ vm_fault_t ttm_bo_vm_fault_reserved(struct > > vm_fault *vmf, > > pfn = page_to_pfn(page); > > } > > >

Re: [PATCH v3 2/2] mm, drm/ttm: Fix vm page protection handling

2019-12-06 Thread Michal Hocko
On Fri 06-12-19 14:16:10, Thomas Hellstrom wrote: > Hi Michal, > > On Fri, 2019-12-06 at 11:30 +0100, Michal Hocko wrote: > > On Fri 06-12-19 09:24:26, Thomas Hellström (VMware) wrote: > > [...] > > > @@ -283,11 +282,26 @@ vm_fault_t ttm_bo_vm_fault_reserved(struct > > > vm_fault *vmf, > > >

[PATCH v3] video: hyperv: hyperv_fb: Use physical memory for fb on HyperV Gen 1 VMs.

2019-12-06 Thread Wei Hu
On Hyper-V, Generation 1 VMs can directly use VM's physical memory for their framebuffers. This can improve the efficiency of framebuffer and overall performence for VM. The physical memory assigned to framebuffer must be contiguous. We use CMA allocator to get contiguouse physicial memory when the

Re: [PATCH] video: ssd1307fb: add the missed regulator_disable

2019-12-06 Thread Michal Vokáč
On 18. 11. 19 12:41, Chuhong Yuan wrote: The driver forgets to disable the regulator in remove like what is done in probe failure. Add the missed call to fix it. Signed-off-by: Chuhong Yuan --- drivers/video/fbdev/ssd1307fb.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/vide

RE: [PATCH v3 3/8] drm: Add bus timings helper

2019-12-06 Thread Fabrizio Castro
Hi Daniel, Thank you for your feedback! > From: Daniel Vetter On Behalf Of Daniel Vetter > Sent: 07 November 2019 19:30 > Subject: Re: [PATCH v3 3/8] drm: Add bus timings helper > > On Thu, Nov 07, 2019 at 09:26:21PM +0200, Laurent Pinchart wrote: > > Hi Fabrizio, > > > > Thank you for the patc

RE: [PATCH v3 1/8] dt-bindings: display: Add bindings for LVDS bus-timings

2019-12-06 Thread Fabrizio Castro
Hi Rob, > From: Rob Herring > Sent: 29 August 2019 15:03 > Subject: Re: [PATCH v3 1/8] dt-bindings: display: Add bindings for LVDS > bus-timings > > On Wed, Aug 28, 2019 at 1:36 PM Fabrizio Castro > wrote: > > > > Dual-LVDS connections need markers in the DT, this patch adds > > some common do

RE: [PATCH v3 1/8] dt-bindings: display: Add bindings for LVDS bus-timings

2019-12-06 Thread Fabrizio Castro
Hi Laurent, Thank you for your feedback! > From: devicetree-ow...@vger.kernel.org On > Behalf Of Laurent Pinchart > Sent: 07 November 2019 18:01 > Subject: Re: [PATCH v3 1/8] dt-bindings: display: Add bindings for LVDS > bus-timings > > Hello Fabrizio, > > On Thu, Aug 29, 2019 at 02:38:06PM

KASAN: use-after-free Read in soft_cursor

2019-12-06 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:b0d4beaa Merge branch 'next.autofs' of git://git.kernel.or.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=11b97e41e0 kernel config: https://syzkaller.appspot.com/x/.config?x=f07a23020fd7d21a da

RE: [PATCH v3 2/8] dt-bindings: display: Add idk-2121wr binding

2019-12-06 Thread Fabrizio Castro
Hi Laurent, Thank you for your feedback! > From: Laurent Pinchart > Sent: 07 November 2019 18:12 > Subject: Re: [PATCH v3 2/8] dt-bindings: display: Add idk-2121wr binding > > Hi Fabrizio, > > Thank you for the patch. > > On Wed, Aug 28, 2019 at 07:36:36PM +0100, Fabrizio Castro wrote: > > Ad

RE: [PATCH v3 3/8] drm: Add bus timings helper

2019-12-06 Thread Fabrizio Castro
Hi Laurent, Thank you for your feedback! > From: linux-kernel-ow...@vger.kernel.org > On Behalf Of Laurent Pinchart > Sent: 07 November 2019 19:26 > Subject: Re: [PATCH v3 3/8] drm: Add bus timings helper > > Hi Fabrizio, > > Thank you for the patch. > > On Wed, Aug 28, 2019 at 07:36:37PM +0

Re: [PATCH 1/2] drm: add dp helper to initialize remote aux channel.

2019-12-06 Thread Harry Wentland
On 2019-12-05 11:55 a.m., David (Dingchen) Zhang wrote: > [why] > We need to minimally initialize the remote aux channel, e.g. the > crc work struct of remote aux to dump the sink's DPRX CRCs in MST > setup. > > [how] > Add helper that only initializes the crc work struct of the remote > aux, hook

Re: [PATCH 1/2] drm: add dp helper to initialize remote aux channel.

2019-12-06 Thread Harry Wentland
On 2019-12-06 10:30 a.m., Harry Wentland wrote: > On 2019-12-05 11:55 a.m., David (Dingchen) Zhang wrote: >> [why] >> We need to minimally initialize the remote aux channel, e.g. the >> crc work struct of remote aux to dump the sink's DPRX CRCs in MST >> setup. >> >> [how] >> Add helper that only i

Re: [PATCH] drm/panfrost: Register devfreq cooling device

2019-12-06 Thread Rob Herring
On Thu, Nov 28, 2019 at 2:54 PM Robin Murphy wrote: > > When we have devfreq, also try to register a basic cooling device in > case GPU workloads manage to hit thermal throttling thresholds. > > Signed-off-by: Robin Murphy > --- > drivers/gpu/drm/panfrost/panfrost_devfreq.c | 32 ++--

Re: [PATCH 0/8] panfrost: Fixes for 5.4

2019-12-06 Thread Rob Herring
On Fri, Nov 29, 2019 at 7:59 AM Boris Brezillon wrote: > > Hello, > > I've recently come to test a 5.4 kernel on a rk3288 platform (T760), > and, as reported by many people on #panfrost, I've hit a page-fault > storm when running various GL apps. > > This series tries to address the problems I cou

Re: [PATCH] drm/panfrost: devfreq: Round frequencies to OPPs

2019-12-06 Thread Rob Herring
On Mon, Nov 18, 2019 at 11:30 AM Steven Price wrote: > > Currently when setting a frequency in panfrost_devfreq_target the > returned frequency is the actual frequency that the clock driver reports > (the return of clk_get_rate()). However, where the provided OPPs don't > precisely match the frequ

Re: [PATCH] drm/mgag200: Flag all G200 SE A machines as broken wrt

2019-12-06 Thread John Donnelly
> On Dec 6, 2019, at 4:04 AM, Gerd Hoffmann wrote: > >> Several MGA G200 SE machines don't respect the value of the startadd >> register field. After more feedback on affected machines, neither PCI >> subvendor ID nor the internal ID seem to hint towards the bug. All >> affected machines have a

Re: [PATCH v2] drm/dp_mst: Remove VCPI while disabling topology mgr

2019-12-06 Thread Lyude Paul
Reviewed-by: Lyude Paul I'll go ahead and push this to drm-misc-next-fixes right now, thanks! On Thu, 2019-12-05 at 17:00 +0800, Wayne Lin wrote: > [Why] > > This patch is trying to address the issue observed when hotplug DP > daisy chain monitors. > > e.g. > src-mstb-mstb-sst -> src (unplug)

Re: [git pull] drm msm-next and fixes

2019-12-06 Thread pr-tracker-bot
The pull request you sent on Fri, 6 Dec 2019 13:31:06 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-next-2019-12-06 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/7ada90eb9c7ae4a8eb066f8e9b4d80122f0363db Thank you! -- Deet-doot-dot, I am a bot. https://kor

Re: [PATCH v2] drm/dp_mst: Remove VCPI while disabling topology mgr

2019-12-06 Thread Lyude Paul
On Fri, 2019-12-06 at 14:24 -0500, Lyude Paul wrote: > Reviewed-by: Lyude Paul > > I'll go ahead and push this to drm-misc-next-fixes right now, thanks! Whoops-meant to say drm-misc-next here, anyway, pushed! > > On Thu, 2019-12-05 at 17:00 +0800, Wayne Lin wrote: > > [Why] > > > > This patch

RE: [PATCH v4] drm: Add support for DP 1.4 Compliance edid corruption test

2019-12-06 Thread Zuo, Jerry
[AMD Official Use Only - Internal Distribution Only] Hi All: I just checked the CI report https://patchwork.freedesktop.org/series/70530/. The failures described in there are not quite related to my patch. Seems it is a false-positive. Does anyone know something about the issue described i

[PATCH v2] drm: add dp helper to initialize remote aux channel.

2019-12-06 Thread David (Dingchen) Zhang
[why] We need to minimally initialize the remote aux channel, e.g. the crc work struct of remote aux to dump the sink's DPRX CRCs in MST setup. [how] Add helper that only initializes the crc work struct of the remote aux, hooke crc work queue to 'drm_dp_aux_crc_work'. Then call this helper in DP M

[PATCH 1/6] drm/msm/dpu: Remove unnecessary NULL checks

2019-12-06 Thread Drew Davenport
dpu_hw_ctl* is checked for NULL when passed as an argument to several functions. It will never be NULL, so remove the checks. Signed-off-by: Drew Davenport --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 10 -- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c | 12 ++-

[PATCH 4/6] drm/msm/dpu: Remove unnecessary NULL check

2019-12-06 Thread Drew Davenport
dpu_encoder_virt.phys_encs[0:num_phys_encs-1] will not be NULL so don't check. Also fix multiline strings that caused checkpatch warning. Signed-off-by: Drew Davenport --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 162 1 file changed, 61 insertions(+), 101 deletions(-)

  1   2   >