RE: [PATCH] drm/edid: fixup EDID 1.3 and 1.4 judge reduced-blanking timings logic

2019-12-03 Thread Jani Nikula
On Tue, 03 Dec 2019, wrote: > Hi Jani Nikula > > > > Thanks for your suggestion and I have replied two comments below. Please read my question again. BR, Jani. > > > > -Original Message- > From: Jani Nikula [mailto:jani.nik...@linux.intel.com] > Sent: Wednesday, November 27, 2019 6:29 P

[PATCH v2] drm/amd/display: Reduce HDMI pixel encoding if max clock is exceeded

2019-12-03 Thread Thomas Anderson
For high-res (8K) or HFR (4K120) displays, using uncompressed pixel formats like YCbCr444 would exceed the bandwidth of HDMI 2.0, so the "interesting" modes would be disabled, leaving only low-res or low framerate modes. This change lowers the pixel encoding to 4:2:2 or 4:2:0 if the max TMDS clock

[PATCH v2] drm/mediatek: add ctm property support

2019-12-03 Thread yongqiang.niu
From: Yongqiang Niu add ctm property support Change-Id: I8111da7b309b1809c6302e7748dd9fd06dc97bde Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 15 ++- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 61 - drivers/gpu/drm/mediatek/

[PATCH v2 2/3] dt-bindings: panel: Document Frida FRD350H54004 LCD panel

2019-12-03 Thread Paul Cercueil
Add bindings documentation for the Frida 3.5" (320x240 pixels) 24-bit TFT LCD panel. v2: Switch documentation from plain text to YAML Signed-off-by: Paul Cercueil --- .../display/panel/frida,frd350h54004.yaml | 31 +++ 1 file changed, 31 insertions(+) create mode 100644 Do

[PATCH v2 1/3] dt-bindings: vendor-prefixes: Add Shenzhen Frida LCD Co., Ltd.

2019-12-03 Thread Paul Cercueil
Add an entry for Shenzhen Frida LCD Co., Ltd. v2: No change Signed-off-by: Paul Cercueil Acked-by: Sam Ravnborg --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentati

Re: [PATCH v1 0/26] drm/panel infrastructure + backlight update

2019-12-03 Thread Jeffrey Hugo
On Mon, Dec 2, 2019 at 1:48 PM Sam Ravnborg wrote: > > Hi Jeffrey. > > > > drivers/gpu/drm/msm/dsi/dsi_manager.c | 2 +- > > > > How come the diff stat in the cover letter here indicates a change to > > this file, yet I cannot find a change to this file in any of the > > patches? W

RE: [PATCH libdrm v3] modetest: Use floating vrefresh while dumping mode

2019-12-03 Thread Devarsh Thakkar
Thanks for the review Ville and Neil, response inline. > -Original Message- > From: Ville Syrjälä > Sent: 02 December 2019 09:43 > To: Neil Armstrong > Cc: Devarsh Thakkar ; Ranganathan Sk > ; vcu-team ; Dhaval Rajeshbhai Shah > ; dri-devel@lists.freedesktop.org; Varunkumar > Allagadapa

[PATCH v2] drm/edid: Add modes from CTA-861-G

2019-12-03 Thread Thomas Anderson
The new modes are needed for exotic displays such as 8K. Verified that modes like 8K60 and 4K120 are properly obtained from a Samsung Q900R. Signed-off-by: Thomas Anderson --- drivers/gpu/drm/drm_edid.c | 287 +++- include/drm/drm_connector.h | 16 +- 2 files ch

[PATCH libdrm v2] modetest: Use floating vrefresh while dumping mode

2019-12-03 Thread Devarsh Thakkar
Add inline function to derive floating value of vertical refresh rate from pixel clock, horizontal total size and vertical total size. Use this function to find suitable mode having vrefresh value which is matching with user provided vrefresh value. If user doesn't provide any vrefresh value in a

Re: [GIT PULL] Please pull hmm changes

2019-12-03 Thread Jason Gunthorpe
On Sat, Nov 30, 2019 at 10:23:31AM -0800, Linus Torvalds wrote: > On Sat, Nov 30, 2019 at 10:03 AM Linus Torvalds > wrote: > > > > I'll try to figure the code out, but my initial reaction was "yeah, > > not in my VM". > > Why is it ok to sometimes do > > WRITE_ONCE(mni->invalidate_seq, cur_s

RE: [PATCH] drm: rcar-du: lvds: Get mode from state

2019-12-03 Thread Fabrizio Castro
Hello Laurent, Thank you for your patch! > From: linux-renesas-soc-ow...@vger.kernel.org > On Behalf Of Laurent Pinchart > Sent: 16 October 2019 00:25 > Subject: [PATCH] drm: rcar-du: lvds: Get mode from state > > The R-Car LVDS encoder driver implements the bridge .mode_set() > operation for

Re: [PATCH] drm/msm/mdp5: enable autocommit

2019-12-03 Thread Brian Masney
Hi Jeffrey, On Wed, Nov 13, 2019 at 06:23:34AM -0500, Brian Masney wrote: > On Tue, Nov 12, 2019 at 08:38:27AM -0700, Jeffrey Hugo wrote: > > On Tue, Nov 12, 2019 at 3:49 AM Brian Masney wrote: > > > > > > Since the introduction of commit 2d99ced787e3 ("drm/msm: async commit > > > support"), comm

Re: [RFC PATCH v2 09/11] devfreq: exynos-bus: Add interconnect functionality to exynos-bus

2019-12-03 Thread Artur Świgoń
Hi Chanwoo, On Wed, 2019-09-25 at 16:03 +0900, Chanwoo Choi wrote: > Hi, > > I need the time to dig the ICC framework > to understand them detailed. After that, I'll review this. Any updates on this topic? Regardless of the purpose of this RFC, I think patches 01-04 are still beneficial to devf

Re: [PATCH] drm/i915: Remove tautological compare in eb_relocate_vma

2019-12-03 Thread Nick Desaulniers
On Sat, Nov 23, 2019 at 12:05 PM Chris Wilson wrote: > > Quoting Nathan Chancellor (2019-11-23 19:53:22) > > -Wtautological-compare was recently added to -Wall in LLVM, which > > exposed an if statement in i915 that is always false: > > > > ../drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:1485:22

Re: [PATCH v1 0/26] drm/panel infrastructure + backlight update

2019-12-03 Thread Jeffrey Hugo
On Mon, Dec 2, 2019 at 12:33 PM Sam Ravnborg wrote: > > This patchset include a couple of different > things - all related to panels. > > - The panel callbacks are optional - so drop error if > callback is not present. > > - Add support for backlight in drm_panel. > This allows us to make much

Re: [PATCH 1/2] pinctrl: baytrail: Add GPIO lookup and pinctrl-map for i915 DSI panel ctrl

2019-12-03 Thread Andy Shevchenko
On Fri, Nov 29, 2019 at 07:58:35PM +0100, Hans de Goede wrote: > On Bay Trail devices the MIPI power on/off sequences for DSI LCD panels > do not control the LCD panel and backlight GPIOs. So far we have been > relying on these GPIOs being configured as output and driven high by > the Video BIOS (G

RE: [PATCH] drm/edid: fixup EDID 1.3 and 1.4 judge reduced-blanking timings logic

2019-12-03 Thread allen.chen
Hi Jani Nikula Thanks for your suggestion and I have replied two comments below. -Original Message- From: Jani Nikula [mailto:jani.nik...@linux.intel.com] Sent: Wednesday, November 27, 2019 6:29 PM To: Allen Chen (陳柏宇) Cc: Jau-Chih Tseng (曾昭智); Maxime Ripard; Allen Chen (陳柏宇); open li

[PATCH v2 3/3] drm/panel: simple: Add support for the Frida FRD350H54004 panel

2019-12-03 Thread Paul Cercueil
The FRD350H54004 is a simple 3.5" 320x240 24-bit TFT panel, found for instance inside the Anbernic RG-350 handheld gaming console. v2: Order alphabetically Signed-off-by: Paul Cercueil --- drivers/gpu/drm/panel/panel-simple.c | 29 1 file changed, 29 insertions(+)

Re: [PATCH v1, 1/2] drm/mediatek: Fixup external display black screen issue

2019-12-03 Thread Yongqiang Niu
On Tue, 2019-12-03 at 13:48 +0800, CK Hu wrote: > Hi, Yongqiang: > > On Wed, 2019-11-27 at 09:17 +0800, yongqiang@mediatek.com wrote: > > From: Yongqiang Niu > > > > Problem: > > overlay hangup when external display hotplut test > > > > Fix: > > disable overlay when crtc disable > > I thin

[PATCH] drm/dp_mst: Fix build on systems with STACKTRACE_SUPPORT=n

2019-12-03 Thread Guenter Roeck
On systems with STACKTRACE_SUPPORT=n, we get: WARNING: unmet direct dependencies detected for STACKTRACE Depends on [n]: STACKTRACE_SUPPORT Selected by [y]: - STACKDEPOT [=y] and build errors such as: m68k-linux-ld: kernel/stacktrace.o: in function `stack_trace_save': (.text+0x11c): undefi

Re: [PATCH] drm/edid: Add modes from CTA-861-G

2019-12-03 Thread Tom Anderson
On Mon, Nov 25, 2019 at 01:42:00PM -0500, Bhawanpreet Lakha wrote: > Reviewed-by: Bhawanpreet Lakha Thank you for the review. +Ville has brought to my attention 978f6b0693c7 which added modes up to 128 which was part of a recent merge, so I didn't seen the changes until now. Ville also pointed o

[PATCH libdrm v3] modetest: Use floating vrefresh while dumping mode

2019-12-03 Thread Devarsh Thakkar
Add function to derive floating value of vertical refresh rate from drm mode using pixel clock, horizontal total size and vertical total size. Use this function to find suitable mode having vrefresh value which is matching with user provided vrefresh value. If user doesn't provide any vrefresh va

Re: [PATCH v1 07/26] drm/panel: remove get_timings

2019-12-03 Thread Laurent Pinchart
Hi Maxime, On Tue, Dec 03, 2019 at 08:46:59AM +0100, Maxime Ripard wrote: > On Mon, Dec 02, 2019 at 08:32:11PM +0100, Sam Ravnborg wrote: > > There was no users - so remove it. > > The callback was implemented in two drivers - deleted. > > > > Signed-off-by: Sam Ravnborg > > Cc: Thierry Reding >

Re: [PATCH v1, 1/2] drm/mediatek: Fixup external display black screen issue

2019-12-03 Thread CK Hu
Hi, Yongqiang: On Tue, 2019-12-03 at 15:43 +0800, Yongqiang Niu wrote: > On Tue, 2019-12-03 at 13:48 +0800, CK Hu wrote: > > Hi, Yongqiang: > > > > On Wed, 2019-11-27 at 09:17 +0800, yongqiang@mediatek.com wrote: > > > From: Yongqiang Niu > > > > > > Problem: > > > overlay hangup when exter

Re: [PATCH v1 0/26] drm/panel infrastructure + backlight update

2019-12-03 Thread Sam Ravnborg
Hi Laurent. > > This patchset include a couple of different > > things - all related to panels. > > > > - The panel callbacks are optional - so drop error if > > callback is not present. > > > > - Add support for backlight in drm_panel. > > This allows us to make much simpler backlight > >

[PATCH v3 0/5] Replace hibmc code with generic implmentation

2019-12-03 Thread Thomas Zimmermann
The patch set replaces code in hibmc with generic implementation. Version 3 of the patchset only adds fixes. I'm reposting the whole thing for possible testers. Patches 1 to 4 replace fbdev emuation, framebuffer and creation of dumb buffers with respective code from DRM helpers. Patch 5 adds an ad

[PATCH v3 1/5] drm/hisilicon/hibmc: Switch to generic fbdev emulation

2019-12-03 Thread Thomas Zimmermann
There's nothing special about hibmc's fbdev emulation that is not provided by the generic implementation. Switch over and remove the driver's code. Signed-off-by: Thomas Zimmermann Reviewed-by: Daniel Vetter Acked-by: Sam Ravnborg --- drivers/gpu/drm/hisilicon/hibmc/Makefile | 2 +- ...

[PATCH v3 4/5] drm/hisilicon/hibmc: Implement hibmc_dumb_create() with generic helpers

2019-12-03 Thread Thomas Zimmermann
The hibmc driver aligns scanlines to 16 bytes. By using the new pitch_align argument of drm_gem_vram_fill_create_dumb(), convert hibmc over. v2: * move changes to VRAM helpers into separate patch Signed-off-by: Thomas Zimmermann Reviewed-by: Daniel Vetter Acked-by: Sam Ravnborg --- ..

[PATCH v3 2/5] drm/hisilicon/hibmc: Replace struct hibmc_framebuffer with generic code

2019-12-03 Thread Thomas Zimmermann
The hibmc driver's struct hibmc_framebuffer stores a DRM framebuffer with an associated GEM object. This functionality is also provided by generic code. Switch hibmc over. Signed-off-by: Thomas Zimmermann Reviewed-by: Daniel Vetter Acked-by: Sam Ravnborg --- .../gpu/drm/hisilicon/hibmc/hibmc_d

[PATCH v3 5/5] drm/hisilicon/hibmc: Export VRAM MM information to debugfs

2019-12-03 Thread Thomas Zimmermann
This change makes information about VRAM consumption available on debugfs. See /sys/kernel/debug/dri/0/vram-mm for an overview of how VRAM is being used. Signed-off-by: Thomas Zimmermann Reviewed-by: Daniel Vetter Acked-by: Sam Ravnborg --- drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c |

[PATCH v3 3/5] drm/vram: Support scanline alignment for dumb buffers

2019-12-03 Thread Thomas Zimmermann
Adding the pitch alignment as an argument to drm_gem_vram_fill_create_dumb() allows to align scanlines to certain offsets. A value of 0 disables scanline pitches. v3: * only do power-of-2 test if pitch_align given; fails otherwise * mgag200: call drm_gem_vram_fill_create_dumb() wit

Re: [PATCH v1 07/26] drm/panel: remove get_timings

2019-12-03 Thread Sam Ravnborg
Hi Maxime. On Tue, Dec 03, 2019 at 08:46:59AM +0100, Maxime Ripard wrote: > Hi, > > On Mon, Dec 02, 2019 at 08:32:11PM +0100, Sam Ravnborg wrote: > > There was no users - so remove it. > > The callback was implemented in two drivers - deleted. > > > > Signed-off-by: Sam Ravnborg > > Cc: Thierry

[PATCH v2] ARM: dts: am335x-evm: Use drm simple-panel instead of tilcdc-panel

2019-12-03 Thread Jyri Sarha
Move to use the new drm panel support in tilcdc together with added "tfc,s9700rtwv43tr-01b"-panel support in drm panel-simple. Signed-off-by: Jyri Sarha Reviewed-by: Laurent Pinchart --- "tfc,s9700rtwv43tr-01b" in panel-simple has been in for some time now so it is about time to get this in too.

Re: [PATCH v2 07/14] video: omapfb: use const pointer for fb_ops

2019-12-03 Thread Jani Nikula
On Fri, 29 Nov 2019, Jani Nikula wrote: > Use const for fb_ops to let us make the info->fbops pointer const in the > future. > > Cc: linux-fb...@vger.kernel.org > Cc: linux-o...@vger.kernel.org > Reviewed-by: Daniel Vetter > Signed-off-by: Jani Nikula Pushed up to and including this patch to dr

Re: [PATCH 8/9] drm/tegra: dpaux: Add missing runtime PM references

2019-12-03 Thread Daniel Vetter
On Mon, Dec 02, 2019 at 03:58:33PM +0100, Thierry Reding wrote: > On Fri, Nov 29, 2019 at 09:20:25PM +0100, Daniel Vetter wrote: > > On Fri, Nov 29, 2019 at 11:44:12AM +0100, Thierry Reding wrote: > > > On Fri, Nov 29, 2019 at 10:23:19AM +0100, Daniel Vetter wrote: > > > > On Thu, Nov 28, 2019 at 0

Re: [PATCH] drm/dp_mst: Fix build on systems with STACKTRACE_SUPPORT=n

2019-12-03 Thread Daniel Vetter
On Mon, Dec 02, 2019 at 01:49:47PM -0500, Lyude Paul wrote: > Reviewed-by: Lyude Paul > > I'll go ahead and push this to drm-misc-next, thanks! drm-misc-next-fixes since it's in the merge window. drm-misc-next is for 5.6 already. -Daniel > > On Mon, 2019-12-02 at 16:20 +0100, Geert Uytterhoeve

Re: [PATCH] drm: remove no longer used .master_{create,destroy} callbacks

2019-12-03 Thread Daniel Vetter
On Mon, Dec 02, 2019 at 05:28:53PM +, Emil Velikov wrote: > From: Emil Velikov > > Up-to recently the only driver which required these was vmwgfx. > > With commit 9c84aeba67cc ("drm/vmwgfx: Kill unneeded legacy security > features") the driver no longer sets them, so we can drop the unused >

Re: [PATCH v2 2/2] drm/komeda: Enable new product D32 support

2019-12-03 Thread Mihail Atanassov
On Tuesday, 3 December 2019 06:46:06 GMT james qian wang (Arm Technology China) wrote: > On Mon, Dec 02, 2019 at 11:07:52AM +, Mihail Atanassov wrote: > > On Thursday, 21 November 2019 08:17:45 GMT james qian wang (Arm Technology > > China) wrote: > > > D32 is simple version of D71, the diffe

[PATCH 01/12] drm/pci: Only build drm_pci.c if CONFIG_PCI is set

2019-12-03 Thread Thomas Zimmermann
Non-PCI systems should not build PCI helpers. Set up source code, header file and Makefile accordingly. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/Makefile | 3 ++- drivers/gpu/drm/drm_internal.h | 22 ++ drivers/gpu/drm/drm_pci.c | 13 - inc

[PATCH 03/12] drm/ast: Don't include

2019-12-03 Thread Thomas Zimmermann
Including is unnecessary in most cases. Replace these instances. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_drv.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/ast/ast_drv.c b/drivers/gpu/drm/ast/ast_drv.c index 9da26750a22d..30aa73a5d9b7 100644 --- a/driv

[PATCH 11/12] drm/tdfx: Don't include

2019-12-03 Thread Thomas Zimmermann
Including is unnecessary in most cases. Replace these instances. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/tdfx/tdfx_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/tdfx/tdfx_drv.c b/drivers/gpu/drm/tdfx/tdfx_drv.c index c243af156ee7..ab699bf

[PATCH 02/12] drm/pci: Hide legacy PCI functions from non-legacy code

2019-12-03 Thread Thomas Zimmermann
Declarations of drm_legacy_pci_{init,exit}() are being moved to drm_legacy.h. CONFIG_DRM_LEGACY protects the implementation. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_pci.c | 4 include/drm/drm_legacy.h | 29 - include/drm/drm_pci.h | 15

[PATCH 08/12] drm/radeon: Don't include

2019-12-03 Thread Thomas Zimmermann
Including is unnecessary in most cases. Replace these instances. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/radeon/atom.h | 1 + drivers/gpu/drm/radeon/atombios_encoders.c | 2 +- drivers/gpu/drm/radeon/btc_dpm.c| 3 +-- drivers/gpu/drm/radeon/ci

[PATCH 05/12] drm/mga: Don't include

2019-12-03 Thread Thomas Zimmermann
Including is unnecessary in most cases. Replace these instances. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/mga/mga_drv.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/mga/mga_drv.h b/drivers/gpu/drm/mga/mga_drv.h index d5deecb93975..66df51607896

[PATCH 10/12] drm/sis: Don't include

2019-12-03 Thread Thomas Zimmermann
Including is unnecessary in most cases. Replace these instances. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/sis/sis_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/sis/sis_drv.c b/drivers/gpu/drm/sis/sis_drv.c index ee3801201ecc..2c54b33abb54

[PATCH 12/12] drm/via: Don't include

2019-12-03 Thread Thomas Zimmermann
Including is unnecessary in most cases. Replace these instances. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/via/via_dmablit.c | 2 +- drivers/gpu/drm/via/via_drv.c | 2 +- drivers/gpu/drm/via/via_map.c | 3 ++- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/dri

[PATCH 06/12] drm/mgag200: Don't include

2019-12-03 Thread Thomas Zimmermann
Including is unnecessary in most cases. Replace these instances. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/mgag200/mgag200_cursor.c | 2 +- drivers/gpu/drm/mgag200/mgag200_i2c.c| 3 +-- drivers/gpu/drm/mgag200/mgag200_main.c | 3 ++- drivers/gpu/drm/mgag200/mgag200_mode.c | 2

Re: [PATCH v3 14/21] drm/bridge: Add the necessary bits to support bus format negotiation

2019-12-03 Thread Laurent Pinchart
Hi Boris, Thank you for the patch. On Wed, Oct 23, 2019 at 05:45:05PM +0200, Boris Brezillon wrote: > drm_bridge_state is extended to describe the input and output bus > configuration. This bus configuration is exposed through the s/configuration/configurations/ s/This bus configuration is/These

[PATCH 04/12] drm/i810: Don't include

2019-12-03 Thread Thomas Zimmermann
Including is unnecessary in most cases. Replace these instances. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/i810/i810_dma.c | 2 +- drivers/gpu/drm/i810/i810_drv.c | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i810/i810_dma.c b/drivers/gpu/drm

[PATCH 00/12] Clean up drm_pci.{c,h}

2019-12-03 Thread Thomas Zimmermann
This patchset cleans up drm_pci.{c,h}. Patch 1 removes drm_pci.c from non-PCI builds. Declarations of legacy functions are hidden in drm_legacy.h and their implementation is protected by CONFIG_PCI in patch 2. The rest of the patches replace unnecessary include statements for drm_pci.h. Most of the

[PATCH 09/12] drm/savage: Don't include

2019-12-03 Thread Thomas Zimmermann
Including is unnecessary in most cases. Replace these instances. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/savage/savage_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/savage/savage_drv.c b/drivers/gpu/drm/savage/savage_drv.c index 2966fcfd

[PATCH 07/12] drm/r128: Don't include

2019-12-03 Thread Thomas Zimmermann
Including is unnecessary in most cases. Replace these instances. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/r128/r128_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/r128/r128_drv.c b/drivers/gpu/drm/r128/r128_drv.c index fd74f744604f..b7a5f16

Re: [PATCH v3 12/21] drm/bridge: Add an ->atomic_check() hook

2019-12-03 Thread Boris Brezillon
On Mon, 2 Dec 2019 19:03:36 +0200 Laurent Pinchart wrote: > > + /** > > +* @atomic_check: > > +* > > +* This method is responsible for checking bridge state correctness. > > +* It can also check the state of the surrounding components in chain > > +* to make sure the whole p

Re: [PATCH v3 16/21] drm/bridge: lvds-encoder: Implement basic bus format negotiation

2019-12-03 Thread Laurent Pinchart
Hi Boris, Thank you for the patch. On Wed, Oct 23, 2019 at 05:45:07PM +0200, Boris Brezillon wrote: > Some LVDS encoder might support several input/output bus formats. Add s/encoder/encoders/ > a way to describe the one used on a specific design by adding optional s/the one/the format/ > 'dat

Re: [PATCH v3 12/21] drm/bridge: Add an ->atomic_check() hook

2019-12-03 Thread Laurent Pinchart
Hi Boris, On Tue, Dec 03, 2019 at 11:11:51AM +0100, Boris Brezillon wrote: > On Mon, 2 Dec 2019 19:03:36 +0200 Laurent Pinchart wrote: > > > > + /** > > > + * @atomic_check: > > > + * > > > + * This method is responsible for checking bridge state correctness. > > > + * It can also check the s

Re: [PATCH v3 18/21] drm/bridge: panel: Propage bus format/flags

2019-12-03 Thread Laurent Pinchart
Hi Boris, Thank you for the patch. On Wed, Oct 23, 2019 at 05:45:09PM +0200, Boris Brezillon wrote: > So that the previous bridge element in the chain knows which input > format the panel bridge expects. > > Signed-off-by: Boris Brezillon > --- > Changes in v3: > * Adjust things to match the ne

[PATCH v2 1/2] mm: Add and export vmf_insert_mixed_prot()

2019-12-03 Thread VMware
From: Thomas Hellstrom The TTM module today uses a hack to be able to set a different page protection than struct vm_area_struct::vm_page_prot. To be able to do this properly, add and export vmf_insert_mixed_prot(). Cc: Andrew Morton Cc: Michal Hocko Cc: "Matthew Wilcox (Oracle)" Cc: "Kirill

[PATCH v2 2/2] drm/ttm: Fix vm page protection handling

2019-12-03 Thread VMware
From: Thomas Hellstrom TTM graphics buffer objects may, transparently to user-space, move between IO and system memory. When that happens, all PTEs pointing to the old location are zapped before the move and then faulted in again if needed. When that happens, the page protection caching mode- an

[PATCH v2 0/2] mm, drm/ttm: Fix pte insertion with customized protection

2019-12-03 Thread VMware
From: Thomas Hellstrom The drm/ttm module is using a modified on-stack copy of the struct vm_area_struct to be able to set a page protection with customized caching. Fix that by adding a vmf_insert_mixed_prot() function similar to the existing vmf_insert_pfn_prot() for use with drm/ttm. I'd like

Re: [PATCH 02/12] drm/pci: Hide legacy PCI functions from non-legacy code

2019-12-03 Thread Emil Velikov
Hi Thomas, On Tue, 3 Dec 2019 at 10:04, Thomas Zimmermann wrote: > > Declarations of drm_legacy_pci_{init,exit}() are being moved to > drm_legacy.h. CONFIG_DRM_LEGACY protects the implementation. > > Signed-off-by: Thomas Zimmermann > --- > drivers/gpu/drm/drm_pci.c | 4 > include/drm/drm

Re: [PATCH 02/12] drm/pci: Hide legacy PCI functions from non-legacy code

2019-12-03 Thread Emil Velikov
On Tue, 3 Dec 2019 at 11:06, Emil Velikov wrote: > > Hi Thomas, > > On Tue, 3 Dec 2019 at 10:04, Thomas Zimmermann wrote: > > > > Declarations of drm_legacy_pci_{init,exit}() are being moved to > > drm_legacy.h. CONFIG_DRM_LEGACY protects the implementation. > > > > Signed-off-by: Thomas Zimmerma

Re: [PATCH 00/12] Clean up drm_pci.{c,h}

2019-12-03 Thread Emil Velikov
On Tue, 3 Dec 2019 at 10:04, Thomas Zimmermann wrote: > > This patchset cleans up drm_pci.{c,h}. Patch 1 removes drm_pci.c from > non-PCI builds. Declarations of legacy functions are hidden in drm_legacy.h > and their implementation is protected by CONFIG_PCI in patch 2. The rest > of the patches

Re: [PATCH 02/12] drm/pci: Hide legacy PCI functions from non-legacy code

2019-12-03 Thread Thomas Zimmermann
Hi Emil Am 03.12.19 um 12:09 schrieb Emil Velikov: > On Tue, 3 Dec 2019 at 11:06, Emil Velikov wrote: >> >> Hi Thomas, >> >> On Tue, 3 Dec 2019 at 10:04, Thomas Zimmermann wrote: >>> >>> Declarations of drm_legacy_pci_{init,exit}() are being moved to >>> drm_legacy.h. CONFIG_DRM_LEGACY protects

Re: [PATCH 7/7] drm/udl: Move udl_handle_damage() into udl_modeset.c

2019-12-03 Thread Thomas Zimmermann
Hi Am 02.12.19 um 10:27 schrieb Emil Velikov: > On Tue, 26 Nov 2019 at 13:47, Thomas Zimmermann wrote: >> >> The only caller of udl_handle_damage() in the plane-update function >> in udl_modeset.c. Move udl_handle_damage() there, make it static, and >> remove several left-over macros. >> > Person

Re: [PATCH 00/12] Clean up drm_pci.{c,h}

2019-12-03 Thread Sam Ravnborg
Hi Thomas. > The rest > of the patches replace unnecessary include statements for drm_pci.h. Most > of the source files only require . I guess I am to blame here. When migrating away from drmP.h I used as preferred way when there were pci related build errors and when it worked I moved on. Sorry

[PATCH] backlight: corgi: Convert to use GPIO descriptors

2019-12-03 Thread Linus Walleij
The code in the Corgi backlight driver can be considerably simplified by moving to GPIO descriptors and lookup tables from the board files instead of passing GPIO numbers using the old API. Make sure to encode inversion semantics for the Akita and Spitz platforms inside the GPIO lookup table and d

Re: [PATCH v3 17/21] dt-bindings: display: bridge: lvds-transmitter: Add new props

2019-12-03 Thread Boris Brezillon
On Mon, 2 Dec 2019 19:11:40 +0200 Laurent Pinchart wrote: > Hi Boris, > > Thank you for the patch. > > On Wed, Oct 23, 2019 at 05:45:08PM +0200, Boris Brezillon wrote: > > Add the data-mapping property to describe the output bus format and > > the bus-width property to describe the input bus fo

Re: [PATCH 3/5] drm/i915: Fix DPCD register order in intel_dp_aux_enable_backlight()

2019-12-03 Thread Jani Nikula
On Fri, 22 Nov 2019, Lyude Paul wrote: > For eDP panels, it appears it's expected that so long as the panel is in > DPCD control mode that the brightness value is never set to 0. Instead, > if the desired effect is to set the panel's backlight to 0 we're > expected to simply turn off the backlight

Re: [PATCH 2/5] drm/i915: Assume 100% brightness when not in DPCD control mode

2019-12-03 Thread Jani Nikula
On Fri, 22 Nov 2019, Lyude Paul wrote: > Currently we always determine the initial panel brightness level by > simply reading the value from DP_EDP_BACKLIGHT_BRIGHTNESS_MSB/LSB. This > seems wrong though, because if the panel is not currently in DPCD > control mode there's not really any reason wh

Re: [PATCH 4/5] drm/i915: Auto detect DPCD backlight support by default

2019-12-03 Thread Jani Nikula
On Fri, 22 Nov 2019, Lyude Paul wrote: > Turns out we actually already have some companies, such as Lenovo, > shipping machines with AMOLED screens that don't allow controlling the > backlight through the usual PWM interface and only allow controlling it > through the standard EDP DPCD interface.

Re: [PATCH 5/5] drm/i915: Force DPCD backlight mode on X1 Extreme 2nd Gen 4K AMOLED panel

2019-12-03 Thread Jani Nikula
On Fri, 22 Nov 2019, Lyude Paul wrote: > Annoyingly, the VBT on the ThinkPad X1 Extreme 2nd Gen indicates that > the system uses plain PWM based backlight controls, when in reality the > only backlight controls that work are the standard VESA eDP DPCD > backlight controls. > > Honestly, this makes

Re: [PATCH v3 19/21] drm/panel: simple: Add support for Toshiba LTA089AC29000 panel

2019-12-03 Thread Boris Brezillon
On Mon, 2 Dec 2019 19:17:24 +0200 Laurent Pinchart wrote: > Hi Boris, > > Thank you for the patch. > > On Wed, Oct 23, 2019 at 05:45:10PM +0200, Boris Brezillon wrote: > > Add a new entry for the Toshiba LTA089AC29000 panel. > > > > Signed-off-by: Boris Brezillon > > --- > > Changes in v3: >

Re: [EXT] [PATCH v8 2/2] drm/bridge: Add NWL MIPI DSI host controller support

2019-12-03 Thread Robert Chiras
Hi Guido, Since your last revision sent, I've done more tests here and found a few more improvements that could be added to this driver. See inline. On Lu, 2019-12-02 at 20:35 +0100, Guido Günther wrote: > Caution: EXT Email > > This adds initial support for the NWL MIPI DSI Host controller foun

[PATCH v1 13/15] phy: cadence-torrent: Use regmap to read and write DPTX PHY registers

2019-12-03 Thread Yuti Amonkar
From: Swapnil Jakhade Use regmap to read and write DPTX specific PHY registers. Signed-off-by: Swapnil Jakhade --- drivers/phy/cadence/phy-cadence-torrent.c | 169 +- 1 file changed, 99 insertions(+), 70 deletions(-) diff --git a/drivers/phy/cadence/phy-cadence-tor

[PATCH v1 1/3] dt-bindings: drm/bridge: Document Cadence MHDP bridge bindings in yaml format

2019-12-03 Thread Yuti Amonkar
Document the bindings used for the Cadence MHDP DPI/DP bridge in yaml format. Signed-off-by: Yuti Amonkar --- .../bindings/display/bridge/cdns,mhdp.yaml | 101 + 1 file changed, 101 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/bridge/cd

[PATCH v1 00/15] PHY: Update Cadence Torrent PHY driver with reconfiguration

2019-12-03 Thread Yuti Amonkar
This patch series applies to the Cadence SD0801 PHY driver. Cadence SD0801 PHY driver is Torrent PHY driver for Display Port.Torrent PHY is a multiprotocol PHY supporting PHY configurations including Display Port,USB and PCIe. This patch series first adds display port configuration then updates

[PATCH v1 07/15] phy: cadence-torrent: Refactor code for reusability

2019-12-03 Thread Yuti Amonkar
From: Swapnil Jakhade Add a separate function to set different power state values. Use uniform polling timeout value. Also check return values of functions for proper error handling. Signed-off-by: Swapnil Jakhade --- drivers/phy/cadence/phy-cadence-torrent.c | 230 ++--

[PATCH v1 2/3] drm: bridge: Add support for Cadence MHDP DPI/DP bridge

2019-12-03 Thread Yuti Amonkar
This patch adds new DRM driver for Cadence MHDP DPTX IP used on J721e SoC. MHDP DPTX IP is the component that complies with VESA DisplayPort (DP) and embedded Display Port (eDP) standards.It integrates CPP (uCPU) running the embedded Firmware(FW) interfaced over APB interface. Basically, it takes a

[PATCH v1 3/3] drm/mhdp: add j721e wrapper

2019-12-03 Thread Yuti Amonkar
Add j721e wrapper for mhdp, which sets up the clock and data muxes. Signed-off-by: Yuti Amonkar --- drivers/gpu/drm/bridge/Kconfig | 10 drivers/gpu/drm/bridge/Makefile | 3 ++ drivers/gpu/drm/bridge/cdns-mhdp-j721e.c | 79 drivers/gpu/dr

[PATCH v1 14/15] dt-bindings: phy: phy-cadence-torrent: Add platform dependent compatible string

2019-12-03 Thread Yuti Amonkar
Add a new compatible string used for TI SoCs using Torrent PHY. Signed-off-by: Yuti Amonkar --- Documentation/devicetree/bindings/phy/phy-cadence-torrent.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/phy/phy-cadence-torrent.yaml b/

[PATCH v1 04/15] phy: cadence-torrent: Adopt Torrent nomenclature

2019-12-03 Thread Yuti Amonkar
From: Swapnil Jakhade - Change private data struct cdns_dp_phy to cdns_torrent_phy - Change module description and registration accordingly - Generic torrent functions have prefix cdns_torrent_phy_* - Functions specific to Torrent phy for DisplayPort are prefixed as cdns_torrent_dp_* Signed-of

[PATCH v1 02/15] dt-bindings:phy: Convert Cadence MHDP PHY bindings to YAML.

2019-12-03 Thread Yuti Amonkar
- Convert the MHDP PHY devicetree bindings to yaml schemas. - Rename DP PHY to have generic Torrent PHY nomrnclature. - Rename compatible string from "cdns,dp-phy" to "cdns,torrent-phy". Signed-off-by: Yuti Amonkar --- .../devicetree/bindings/phy/phy-cadence-dp.txt | 30 - .../bi

[PATCH v1 06/15] phy: cadence-torrent: Add wrapper for DPTX register access

2019-12-03 Thread Yuti Amonkar
From: Swapnil Jakhade Add wrapper functions to read, write DisplayPort specific PHY registers to improve code readability. Signed-off-by: Swapnil Jakhade --- drivers/phy/cadence/phy-cadence-torrent.c | 71 ++- 1 file changed, 50 insertions(+), 21 deletions(-) diff

[PATCH v1 11/15] phy: cadence-torrent: Implement PHY configure APIs

2019-12-03 Thread Yuti Amonkar
From: Swapnil Jakhade Add support for PHY configuration APIs. These will mainly reconfigure link rate, number of lanes, voltage swing and pre-emphasis values. Signed-off-by: Swapnil Jakhade --- drivers/phy/cadence/phy-cadence-torrent.c | 424 ++ 1 file changed, 424

[PATCH v1 09/15] phy: cadence-torrent: Add 19.2 MHz reference clock support

2019-12-03 Thread Yuti Amonkar
From: Swapnil Jakhade Add configuration functions for 19.2 MHz refclock support. Add register configurations for SSC support. Signed-off-by: Swapnil Jakhade --- drivers/phy/cadence/phy-cadence-torrent.c | 456 -- 1 file changed, 440 insertions(+), 16 deletions(-) d

[PATCH v1 01/15] phy: Add DisplayPort configuration options

2019-12-03 Thread Yuti Amonkar
Add generic DP API for configuring DisplayPort PHYs. The parameters that will be configured are link rate, number of lanes, voltage swing and pre-emphasis. Signed-off-by: Yuti Amonkar --- include/linux/phy/phy-dp.h | 95 ++ include/linux/phy/phy.h|

[PATCH v1 05/15] phy: cadence-torrent: Add wrapper for PHY register access

2019-12-03 Thread Yuti Amonkar
From: Swapnil Jakhade Add a wrapper function to write Torrent PHY registers to improve code readability. Signed-off-by: Swapnil Jakhade --- drivers/phy/cadence/phy-cadence-torrent.c | 142 -- 1 file changed, 77 insertions(+), 65 deletions(-) diff --git a/drivers/ph

[PATCH v1 12/15] phy: cadence-torrent: Use regmap to read and write Torrent PHY registers

2019-12-03 Thread Yuti Amonkar
Use regmap for accessing Torrent PHY registers. Modify register offsets as defined in Torrent PHY user guide. Abstract address calculation using regmap APIs. Signed-off-by: Yuti Amonkar --- drivers/phy/cadence/phy-cadence-torrent.c | 1020 ++--- 1 file changed, 650 insert

[PATCH v1 03/15] phy: cadence-dp: Rename to phy-cadence-torrent

2019-12-03 Thread Yuti Amonkar
Rename Cadence DP PHY driver from phy-cadence-dp to phy-cadence-torrent to make it more generic for future use. Modifiy Makefile and Kconfig accordingly. Also, change driver compatible from "cdns,dp-phy" to "cdns,torrent-phy". Signed-off-by: Yuti Amonkar --- drivers/phy/cadence/Kconfig

[PATCH v1 10/15] phy: cadence-torrent: Add PHY lane reset support

2019-12-03 Thread Yuti Amonkar
From: Swapnil Jakhade Add reset support for PHY lane group. Signed-off-by: Swapnil Jakhade --- drivers/phy/cadence/phy-cadence-torrent.c | 27 +++ 1 file changed, 27 insertions(+) diff --git a/drivers/phy/cadence/phy-cadence-torrent.c b/drivers/phy/cadence/phy-cadence

[PATCH v1 0/3] drm: Add support for Cadence MHDP DPI/DP bridge and J721E wrapper.

2019-12-03 Thread Yuti Amonkar
This patch series adds new DRM driver for Cadence Display Port. The Cadence Display Port is also referred as MHDP (Mobile High Definition Link, High-Definition Multimedia Interface Display Port) Cadence Display Port complies with VESA DisplayPort (DP) and embedded Display Port (eDP) standards

[PATCH v1 15/15] phy: cadence-torrent: Add platform dependent initialization structure

2019-12-03 Thread Yuti Amonkar
Add platform dependent initialization data for Torrent PHY used in TI's J721E SoC. Signed-off-by: Yuti Amonkar --- drivers/phy/cadence/phy-cadence-torrent.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/phy/cadence/phy-cadence-torrent.c b/drivers/phy/cadence/phy-cadence-t

[PATCH v1 08/15] dt-bindings: phy: phy-cadence-torrent: Add clock bindings

2019-12-03 Thread Yuti Amonkar
Add Torrent PHY reference clock bindings. Signed-off-by: Yuti Amonkar --- .../devicetree/bindings/phy/phy-cadence-torrent.yaml | 12 1 file changed, 12 insertions(+) diff --git a/Documentation/devicetree/bindings/phy/phy-cadence-torrent.yaml b/Documentation/devicetree/bind

Re: [PATCH] drm/edid: Add modes from CTA-861-G

2019-12-03 Thread Ville Syrjälä
On Mon, Dec 02, 2019 at 03:32:46PM -0800, Tom Anderson wrote: > On Mon, Nov 25, 2019 at 01:42:00PM -0500, Bhawanpreet Lakha wrote: > > Reviewed-by: Bhawanpreet Lakha > > Thank you for the review. +Ville has brought to my attention 978f6b0693c7 > which > added modes up to 128 which was part of a

Re: [PATCH 00/12] Clean up drm_pci.{c,h}

2019-12-03 Thread Thomas Zimmermann
Am 03.12.19 um 13:13 schrieb Sam Ravnborg: > Hi Thomas. > >> The rest >> of the patches replace unnecessary include statements for drm_pci.h. Most >> of the source files only require . > > I guess I am to blame here. When migrating away from drmP.h I used > as preferred way when there were pci r

Re: [PATCH libdrm v3] modetest: Use floating vrefresh while dumping mode

2019-12-03 Thread Ville Syrjälä
On Tue, Dec 03, 2019 at 06:49:31AM +, Devarsh Thakkar wrote: > Thanks for the review Ville and Neil, response inline. > > > -Original Message- > > From: Ville Syrjälä > > Sent: 02 December 2019 09:43 > > To: Neil Armstrong > > Cc: Devarsh Thakkar ; Ranganathan Sk > > ; vcu-team ; Dha

[PATCH] drm/tilcdc: Switch to using GPIO descriptors

2019-12-03 Thread Linus Walleij
The TI LCDC picks a GPIO line from the device tree to use for DPMS power on/off. We can switch this to use a GPIO descriptor pretty easily. Make sure to request the GPIO "as is" so that the DPMS state that we start (boot) in is preserved. Cc: Jyri Sarha Cc: Tomi Valkeinen Cc: David Lechner Sign

[PATCH 5/8] drm/vmwgfx: Support huge page faults

2019-12-03 Thread VMware
From: Thomas Hellstrom With vmwgfx dirty-tracking we need a specialized huge_fault callback. Implement and hook it up. Cc: Andrew Morton Cc: Michal Hocko Cc: "Matthew Wilcox (Oracle)" Cc: "Kirill A. Shutemov" Cc: Ralph Campbell Cc: "Jérôme Glisse" Cc: "Christian König" Signed-off-by: Thom

[PATCH 7/8] drm/ttm: Introduce a huge page aligning TTM range manager.

2019-12-03 Thread VMware
From: Thomas Hellstrom Using huge page-table entries require that the start of a buffer object is huge page size aligned. So introduce a ttm_bo_man_get_node_huge() function that attempts to accomplish this for allocations that are larger than the huge page size, and provide a new range-manager in

[PATCH 1/8] mm: Introduce vma_is_special_huge

2019-12-03 Thread VMware
From: Thomas Hellstrom For VM_PFNMAP and VM_MIXEDMAP vmas that want to support transhuge pages and -page table entries, introduce vma_is_special_huge() that takes the same codepaths as vma_is_dax(). The use of "special" follows the definition in memory.c, vm_normal_page(): "Special" mappings do

  1   2   3   >