Re: [PATCH] drm/bridge: analogix-anx6345: Avoid duplicate -supply suffix

2019-12-02 Thread Mark Brown
On Sat, Nov 30, 2019 at 04:09:58PM +0100, Torsten Duwe wrote: > of_get_regulator() will unconditionally add "-supply" to form the > property name. This is documented in commit 69511a452e6dc ("map consumer > regulator based on device tree"). Sorry, I meant to also say: Reviewed-by: Mark Brown s

Re: [PATCH v2 14/14] auxdisplay: constify fb ops

2019-12-02 Thread robin
On 2019-11-29 11:29, Jani Nikula wrote: Now that the fbops member of struct fb_info is const, we can start making the ops const as well. Cc: Miguel Ojeda Sandonis Cc: Robin van der Gracht Signed-off-by: Jani Nikula --- drivers/auxdisplay/cfag12864bfb.c | 2 +- drivers/auxdisplay/ht16k33.c

[PATCH v1] drm/mediatek: add ctm property support

2019-12-02 Thread yongqiang.niu
From: Yongqiang Niu add ctm property support Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 7 +++- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 59 - drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h | 9 + 3 files changed, 72 inser

Re: [PATCH v1] drm/mediatek: add ctm property support

2019-12-02 Thread CK Hu
Hi, Yongqiang: On Mon, 2019-12-02 at 15:31 +0800, yongqiang@mediatek.com wrote: > From: Yongqiang Niu > > add ctm property support > > Signed-off-by: Yongqiang Niu > --- > drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 7 +++- > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 59 > +++

Re: [PATCH v2 14/14] auxdisplay: constify fb ops

2019-12-02 Thread robin
On 2019-11-29 21:59, Miguel Ojeda wrote: On Fri, Nov 29, 2019 at 9:30 PM Daniel Vetter wrote: Well we do have very small lcd display drivers in drm, and before that in fbdev. And you have a fbdev framebuffer driver in there, which looks a bit misplaced ... Afaiui you also have some even ti

Re: [PATCH v1] drm/mediatek: add ctm property support

2019-12-02 Thread CK Hu
Hi, Yongqiang: On Mon, 2019-12-02 at 16:24 +0800, CK Hu wrote: > Hi, Yongqiang: > > On Mon, 2019-12-02 at 15:31 +0800, yongqiang@mediatek.com wrote: > > From: Yongqiang Niu > > > > add ctm property support > > > > Signed-off-by: Yongqiang Niu > > --- > > drivers/gpu/drm/mediatek/mtk_drm_

Re: [PATCH 3/3] drm/todo: Add entry for fb funcs related cleanups

2019-12-02 Thread Thomas Zimmermann
(cc: SPARC64 maintainer) (cc: RISC-V maintainers) Hi Daniel Am 29.11.19 um 20:05 schrieb Daniel Vetter: > On Fri, Nov 29, 2019 at 07:57:39PM +0100, Daniel Vetter wrote: >> On Fri, Nov 29, 2019 at 10:34:10AM +0100, Thomas Zimmermann wrote: >>> Hi >>> >>> Am 27.11.19 um 19:00 schrieb Daniel Vetter:

Re: [PATCH v2 11/14] HID: picoLCD: constify fb ops

2019-12-02 Thread Bruno Prémont
Hi Jani, On Fri, 29 Nov 2019 12:29:41 Jani Nikula wrote: > Now that the fbops member of struct fb_info is const, we can start > making the ops const as well. > > v2: fix typo (Christophe de Dinechin) Fine with me. I don't think going through drm-misc would trigger any conflict, but adding

Re: [01/30] drm: Introduce drm_bridge_init()

2019-12-02 Thread Daniel Vetter
On Mon, Dec 02, 2019 at 05:55:06AM +, james qian wang (Arm Technology China) wrote: > On Tue, Nov 26, 2019 at 01:15:59PM +, Mihail Atanassov wrote: > > A simple convenience function to initialize the struct drm_bridge. > > > > Signed-off-by: Mihail Atanassov > > --- > > drivers/gpu/drm/

Re: [PATCH 6/8] drm/panfrost: Make sure imported/exported BOs are never purged

2019-12-02 Thread Daniel Vetter
On Fri, Nov 29, 2019 at 10:09:24PM +0100, Boris Brezillon wrote: > On Fri, 29 Nov 2019 21:12:13 +0100 > Daniel Vetter wrote: > > > On Fri, Nov 29, 2019 at 02:59:06PM +0100, Boris Brezillon wrote: > > > We don't want imported/exported BOs to be purges, as those are shared > > > with other processe

Re: [PATCH v2 5/5] MAINTAINERS: add entry for tidss

2019-12-02 Thread Daniel Vetter
On Sun, Dec 01, 2019 at 03:50:21PM +0200, Jyri Sarha wrote: > Add entry for tidss DRM driver. > > Signed-off-by: Jyri Sarha > --- > MAINTAINERS | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 741e3f433f6e..dd7855e59bd1 100644 > --- a/MAINTA

Re: [PATCH 7/8] drm/panfrost: Add the panfrost_gem_mapping concept

2019-12-02 Thread Daniel Vetter
On Fri, Nov 29, 2019 at 10:36:29PM +0100, Boris Brezillon wrote: > On Fri, 29 Nov 2019 21:14:59 +0100 > Daniel Vetter wrote: > > > On Fri, Nov 29, 2019 at 02:59:07PM +0100, Boris Brezillon wrote: > > > With the introduction of per-FD address space, the same BO can be mapped > > > in different add

Re: [PATCH 7/8] drm/panfrost: Add the panfrost_gem_mapping concept

2019-12-02 Thread Boris Brezillon
On Mon, 2 Dec 2019 09:55:32 +0100 Daniel Vetter wrote: > On Fri, Nov 29, 2019 at 10:36:29PM +0100, Boris Brezillon wrote: > > On Fri, 29 Nov 2019 21:14:59 +0100 > > Daniel Vetter wrote: > > > > > On Fri, Nov 29, 2019 at 02:59:07PM +0100, Boris Brezillon wrote: > > > > With the introduction

Re: [PATCH 7/7] drm/udl: Move udl_handle_damage() into udl_modeset.c

2019-12-02 Thread Emil Velikov
On Tue, 26 Nov 2019 at 13:47, Thomas Zimmermann wrote: > > The only caller of udl_handle_damage() in the plane-update function > in udl_modeset.c. Move udl_handle_damage() there, make it static, and > remove several left-over macros. > Personally I would have left the mechanic code motion from the

Re: [PATCH v4 12/13] [HACK] drm/bridge: lvds-codec: Enforce device specific compatible strings

2019-12-02 Thread Laurent Pinchart
Hi Fabrizio, On Mon, Nov 25, 2019 at 11:17:25AM +, Fabrizio Castro wrote: > On 22 November 2019 08:17 Geert Uytterhoeven wrote: > > On Thu, Nov 21, 2019 at 5:00 PM Fabrizio Castro wrote: > >> On 19 November 2019 21:52 Laurent Pinchart wrote: > >>> On Tue, Nov 19, 2019 at 11:17:34AM +, Fabr

Re: [PATCH 7/8] drm/panfrost: Add the panfrost_gem_mapping concept

2019-12-02 Thread Daniel Vetter
On Mon, Dec 2, 2019 at 10:13 AM Boris Brezillon wrote: > > On Mon, 2 Dec 2019 09:55:32 +0100 > Daniel Vetter wrote: > > > On Fri, Nov 29, 2019 at 10:36:29PM +0100, Boris Brezillon wrote: > > > On Fri, 29 Nov 2019 21:14:59 +0100 > > > Daniel Vetter wrote: > > > > > > > On Fri, Nov 29, 2019 at 02:

Re: [PATCH 6/8] drm/panfrost: Make sure imported/exported BOs are never purged

2019-12-02 Thread Boris Brezillon
On Mon, 2 Dec 2019 09:52:43 +0100 Daniel Vetter wrote: > On Fri, Nov 29, 2019 at 10:09:24PM +0100, Boris Brezillon wrote: > > On Fri, 29 Nov 2019 21:12:13 +0100 > > Daniel Vetter wrote: > > > > > On Fri, Nov 29, 2019 at 02:59:06PM +0100, Boris Brezillon wrote: > > > > We don't want imported

Re: [PATCH v1 4/6] drm/mediatek: update cursors by using async atomic update

2019-12-02 Thread CK Hu
Hi, Bibby: On Thu, 2019-11-28 at 10:42 +0800, Bibby Hsieh wrote: > Support to async updates of cursors by using the new atomic > interface for that. > > Signed-off-by: Bibby Hsieh > --- > drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 35 + > drivers/gpu/drm/mediatek/mtk_drm_crtc.h

[PATCH] backlight: ams369fg06: Drop GPIO include

2019-12-02 Thread Linus Walleij
The driver includes yet fails to use symbols from any the header so drop the include. Signed-off-by: Linus Walleij --- drivers/video/backlight/ams369fg06.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/video/backlight/ams369fg06.c b/drivers/video/backlight/ams369fg06.c index 94ccb

[PATCH] backlight: bd6107: Convert to use GPIO descriptor

2019-12-02 Thread Linus Walleij
The Rohm BD6107 driver can pass a fixed GPIO line using the old GPIO API using platform data. As there are no in-tree users of this platform data since 2013, we can convert this to use a GPIO descriptor and require any out-of-tree consumers to pass the GPIO using a machine descriptor table instead.

Re: [PATCH] backlight: bd6107: Convert to use GPIO descriptor

2019-12-02 Thread Laurent Pinchart
Hi Linus, Thank you for the patch. On Mon, Dec 02, 2019 at 11:30:28AM +0100, Linus Walleij wrote: > The Rohm BD6107 driver can pass a fixed GPIO line using the old > GPIO API using platform data. As there are no in-tree users of this > platform data since 2013, we can convert this to use a GPIO d

[PATCH] drm: panel-orientation-quirks: Add quirk for Teclast X89 tablet

2019-12-02 Thread Hans de Goede
The Teclast X89 uses an upside-down mounted eDP panel, add a panel-orientation quirk for this. Signed-off-by: Hans de Goede --- drivers/gpu/drm/drm_panel_orientation_quirks.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/driv

Re: [PATCH] backlight: bd6107: Convert to use GPIO descriptor

2019-12-02 Thread Linus Walleij
On Mon, Dec 2, 2019 at 11:42 AM Laurent Pinchart wrote: > On Mon, Dec 02, 2019 at 11:30:28AM +0100, Linus Walleij wrote: > > The Rohm BD6107 driver can pass a fixed GPIO line using the old > > GPIO API using platform data. As there are no in-tree users of this > > platform data since 2013, we can

Re: [PATCH v2 2/2] drm/komeda: Enable new product D32 support

2019-12-02 Thread Mihail Atanassov
On Thursday, 21 November 2019 08:17:45 GMT james qian wang (Arm Technology China) wrote: > D32 is simple version of D71, the difference is: > - Only has one pipeline > - Drop the periph block and merge it to GCU > > v2: Rebase. > > Signed-off-by: James Qian Wang (Arm Technology China) > > ---

Re: [PATCH v2 1/2] drm/komeda: Update the chip identify

2019-12-02 Thread Mihail Atanassov
On Thursday, 21 November 2019 08:17:39 GMT james qian wang (Arm Technology China) wrote: > 1. Drop komeda-CORE product id comparison and put it into the d71_identify > 2. Update pipeline node DT-binding: >(a). Skip the needless pipeline DT node. >(b). Return fail if the essential pipeline

[PATCH v3 3/7] drm/ast: Clean up arguments of register functions

2019-12-02 Thread Thomas Zimmermann
In preparation of an update of the primary-plane code, this patch changes the arguments of several register-setting functions. No functional changes are made. The function ast_set_dac_reg() has no effect and therefore gets removed entirely. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/as

[PATCH v3 4/7] drm/ast: Add plane atomic_check() functions

2019-12-02 Thread Thomas Zimmermann
Introducing atomic_check() for priamry and cursor plane. The functions validate the plane state and will later set format information for the CRTC's atomic_flush(). Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_mode.c | 47 +++--- 1 file changed, 43 ins

[PATCH v3 5/7] drm/ast: Introduce struct ast_crtc_state

2019-12-02 Thread Thomas Zimmermann
AST-specific CRTC state can be placed in the new struct ast_crtc_state. The atomci check functions of the CRTC and the primary plane will store the VBIOS mode info and the framebuffer format here. The CRTC will consume these during atomic_flush(). Signed-off-by: Thomas Zimmermann --- drivers/gpu

[PATCH v3 2/7] drm/ast: Enable and disable screen in primary-plane functions

2019-12-02 Thread Thomas Zimmermann
Enabling and disabling the screen used to be done in the register initialization and the DPMS function. None of these places is related to the screen's output. Now the primary plane's update and disable functions handle screen display state. The primary plane can now be switched off without displa

[PATCH v3 7/7] drm/ast: Store primary-plane format in struct ast_crtc_state

2019-12-02 Thread Thomas Zimmermann
Reading the primary plane's framebuffer from the CRTC's atomic_flush() function is fragile as the plane state or framebuffer can be NULL. Instead, we let the plane's atomic_check() store the framebuffer format in the CRTC state. The CRTC always receives the framebuffer format that is currently prog

[PATCH v3 1/7] drm/ast: Move modesetting code to CRTC's atomic_flush()

2019-12-02 Thread Thomas Zimmermann
When enabling the CRTC after waking up from a power-saving mode, the primary plane's framebuffer might be NULL, which leads to a stack trace as shown below. [ 632.624608] BUG: kernel NULL pointer dereference, address: 0048 [ 632.624631] #PF: supervisor read access in kernel mode

[PATCH v3 0/7] drm/ast: Fix modesetting's framebuffer usage

2019-12-02 Thread Thomas Zimmermann
(was: drm/ast: Fix potential NULL-pointer read during atomic mode setting) The CRTC's modesetting code in ast requires the format of the primary plane's framebuffer. There's currently a segmentation fault if the framebuffer is set to NULL. This happens when disabling the display during suspend. P

[PATCH v3 6/7] drm/ast: Store VBIOS mode info in struct ast_crtc_state

2019-12-02 Thread Thomas Zimmermann
After looking up VBIOS mode information in CRTC's atomic_check(), we can reuse it in atomic_flush(). No need for a second look-up. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_drv.h | 2 ++ drivers/gpu/drm/ast/ast_mode.c | 58 ++ 2 files changed,

Re: [PATCH 2/2] drm/i915/vlv_dsi: Control panel and backlight enable GPIOs on BYT

2019-12-02 Thread Linus Walleij
Hi Hans, thank you for your patch! On Fri, Nov 29, 2019 at 7:58 PM Hans de Goede wrote: > - /* GPIO Desc for CRC based Panel control */ > + /* GPIO Desc for panel and backlight control */ > struct gpio_desc *gpio_panel; > + struct gpio_desc *gpio_backlight; I think wh

Re: [PATCH 1/2] pinctrl: baytrail: Add GPIO lookup and pinctrl-map for i915 DSI panel ctrl

2019-12-02 Thread Linus Walleij
Hi Hans! Thanks for your patch! On Fri, Nov 29, 2019 at 7:58 PM Hans de Goede wrote: > On Bay Trail devices the MIPI power on/off sequences for DSI LCD panels > do not control the LCD panel and backlight GPIOs. So far we have been > relying on these GPIOs being configured as output and driven h

Re: [PATCH 2/2] drm/i915/vlv_dsi: Control panel and backlight enable GPIOs on BYT

2019-12-02 Thread Jani Nikula
On Mon, 02 Dec 2019, Linus Walleij wrote: > Hi Hans, > > thank you for your patch! > > On Fri, Nov 29, 2019 at 7:58 PM Hans de Goede wrote: > >> - /* GPIO Desc for CRC based Panel control */ >> + /* GPIO Desc for panel and backlight control */ >> struct gpio_desc *gpio_panel;

Re: [PATCH] backlight: ams369fg06: Drop GPIO include

2019-12-02 Thread Daniel Thompson
On Mon, Dec 02, 2019 at 11:30:05AM +0100, Linus Walleij wrote: > The driver includes yet fails to use symbols > from any the header so drop the include. > > Signed-off-by: Linus Walleij Reviewed-by: Daniel Thompson > --- > drivers/video/backlight/ams369fg06.c | 1 - > 1 file changed, 1 delet

[Bug 205661] Upgrade to 5.4 from K5.3.13 fails x2 attempts

2019-12-02 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=205661 --- Comment #3 from Jani Nikula (jani.nik...@intel.com) --- I'm just trying to say that when the driver is not part of the Linux kernel source, you are highly unlikely to receive help here, beyond telling you exactly this. -- You are receiving t

Re: [PATCH] backlight: bd6107: Convert to use GPIO descriptor

2019-12-02 Thread Daniel Thompson
On Mon, Dec 02, 2019 at 11:30:28AM +0100, Linus Walleij wrote: > The Rohm BD6107 driver can pass a fixed GPIO line using the old > GPIO API using platform data. As there are no in-tree users of this > platform data since 2013, we can convert this to use a GPIO descriptor > and require any out-of-tr

Re: [PATCH] drm/omap: fix dma_addr refcounting

2019-12-02 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Thu, Nov 14, 2019 at 10:03:43AM +0200, Tomi Valkeinen wrote: > cec4fa7511ef7a73eb635834e9d85b25a5b47a98 ("drm/omap: use refcount API to > track the number of users of dma_addr") changed omap_gem.c to use > refcounting API to track dma_addr uses. However, the

Re: [PATCH 8/8] drm/panfrost: Make sure the shrinker does not reclaim referenced BOs

2019-12-02 Thread Robin Murphy
On 29/11/2019 1:59 pm, Boris Brezillon wrote: Userspace might tag a BO purgeable while it's still referenced by GPU jobs. We need to make sure the shrinker does not purge such BOs until all jobs referencing it are finished. Nit: for extra robustness, perhaps it's worth using the refcount_t API

Re: [PATCH v2 5/5] MAINTAINERS: add entry for tidss

2019-12-02 Thread Jyri Sarha
On 02/12/2019 10:57, Daniel Vetter wrote: > On Sun, Dec 01, 2019 at 03:50:21PM +0200, Jyri Sarha wrote: >> Add entry for tidss DRM driver. >> >> Signed-off-by: Jyri Sarha >> --- >> MAINTAINERS | 10 ++ >> 1 file changed, 10 insertions(+) >> >> diff --git a/MAINTAINERS b/MAINTAINERS >> ind

Re: [PATCH 1/3] ARM: dts: am437x-gp/epos-evm: fix panel compatible

2019-12-02 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Thu, Nov 14, 2019 at 11:39:48AM +0200, Tomi Valkeinen wrote: > The LCD panel on AM4 GP EVMs and ePOS boards seems to be > osd070t1718-19ts. The current dts files say osd057T0559-34ts. Possibly > the panel has changed since the early EVMs, or there has been a m

Re: [PATCH 2/3] ARM: dts: am437x-gp/epos-evm: drop unused panel timings

2019-12-02 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Thu, Nov 14, 2019 at 11:39:49AM +0200, Tomi Valkeinen wrote: > panel-simple now handled panel osd070t1718-19ts, and we no longer need > the panel timings in the DT file. So remove them. Should you in that case drop the panel-dpi compatible string too, as the

Re: [PATCH 3/3] drm/panel: simple: fix osd070t1718_19ts sync drive edge

2019-12-02 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Thu, Nov 14, 2019 at 11:39:50AM +0200, Tomi Valkeinen wrote: > The panel datasheet says that the panel samples at falling edge, but > does not say anything about h/v sync signals. Testing shows that if the > sync signals are driven on falling edge, the picture

Re: [PATCH 0/3] drm/omap: fix am4 evm lcd

2019-12-02 Thread Laurent Pinchart
Hi Tomi, On Thu, Nov 14, 2019 at 11:39:47AM +0200, Tomi Valkeinen wrote: > Hi Tony, Thierry, Laurent, > > After the recent change of moving from omapdrm specific panel-dpi driver > to the DRM simple panel, AM4 EVM/ePOS's panel is not working quite > right. This series has fixes for it, but I'm no

Re: [PATCH 0/3] drm/omap: fix am4 evm lcd

2019-12-02 Thread Adam Ford
On Mon, Dec 2, 2019 at 7:13 AM Laurent Pinchart wrote: > > Hi Tomi, > > On Thu, Nov 14, 2019 at 11:39:47AM +0200, Tomi Valkeinen wrote: > > Hi Tony, Thierry, Laurent, > > > > After the recent change of moving from omapdrm specific panel-dpi driver > > to the DRM simple panel, AM4 EVM/ePOS's panel

Re: [PATCH 8/8] drm/panfrost: Make sure the shrinker does not reclaim referenced BOs

2019-12-02 Thread Boris Brezillon
On Mon, 2 Dec 2019 12:50:20 + Robin Murphy wrote: > On 29/11/2019 1:59 pm, Boris Brezillon wrote: > > Userspace might tag a BO purgeable while it's still referenced by GPU > > jobs. We need to make sure the shrinker does not purge such BOs until > > all jobs referencing it are finished. >

[PATCH] drm/mcde: Fix vertical resolution bugs

2019-12-02 Thread Linus Walleij
In video mode the VACT (video active) and VSA (vertical sync active) got swapped. Fix it up. The result was compared to a register dump from the Golden (Samsung GT-I8190). Cc: Stephan Gerhold Signed-off-by: Linus Walleij --- drivers/gpu/drm/mcde/mcde_dsi.c | 6 +++--- 1 file changed, 3 inserti

[DPU PATCH v3 1/5] dt-bindings: msm/dp: add bindings of DP/DP-PLL driver for Snapdragon 845

2019-12-02 Thread Chandan Uddaraju
Add bindings for Snapdragon 845 DisplayPort and display-port PLL driver. Changes in V2: Provide details about sel-gpio Signed-off-by: Chandan Uddaraju --- .../devicetree/bindings/display/msm/dp.txt | 249 + .../devicetree/bindings/display/msm/dpu.txt| 16 +-

[DPU PATCH v3 2/5] drm: add constant N value in helper file

2019-12-02 Thread Chandan Uddaraju
The constant N value (0x8000) is used by multiple DP drivers. Define this value in header file and use this in the existing i915 display driver. Signed-off-by: Chandan Uddaraju --- drivers/gpu/drm/i915/display/intel_display.c | 2 +- include/drm/drm_dp_helper.h | 1 + 2 files ch

[DPU PATCH v3 0/5] List of patches for DP drivers on SnapDragon

2019-12-02 Thread Chandan Uddaraju
These patches are to enable DisplayPort driver on SanpDragon. These patches have dependency on clock driver changes that provide DP clock support. Changes in V2: Core Dp driver: -- Update copyright markings on all relevant files. -- Change pr_err() to DRM_ERROR() -- Use APIs dire

[DPU PATCH v3 5/5] drm/msm/dpu: add display port support in DPU

2019-12-02 Thread Chandan Uddaraju
From: Jeykumar Sankaran Add display port support in DPU by creating hooks for DP encoder enumeration and encoder mode initialization. This change is based on the SDM845 Display port driver changes[1]. changes in v2: - rebase on [2] (Sean Paul) - remove unwanted error checks and

[DPU PATCH v3 4/5] drm/msm/dp: add support for DP PLL driver

2019-12-02 Thread Chandan Uddaraju
Add the needed DP PLL specific files to support display port interface on msm targets. The DP driver calls the DP PLL driver registration. The DP driver sets the link and pixel clock sources. Changes in v2: -- Update copyright markings on all relevant files. -- Use DRM_DEBUG_DP for debug msgs. S

Re: [DPU PATCH v3 2/5] drm: add constant N value in helper file

2019-12-02 Thread Jani Nikula
On Mon, 02 Dec 2019, Chandan Uddaraju wrote: > The constant N value (0x8000) is used by multiple DP > drivers. Define this value in header file and use this > in the existing i915 display driver. > > Signed-off-by: Chandan Uddaraju Reviewed-by: Jani Nikula and ack for merging via drm-misc or w

Re: [PATCH] dt-bindings: display: Convert a bunch of panels to DT schema

2019-12-02 Thread Rob Herring
On Sat, Nov 30, 2019 at 1:43 PM Sam Ravnborg wrote: > > Hi Rob. > > Thanks for doing this boring, trivial and tiresome task. It was somewhat scripted at least... > On Tue, Nov 19, 2019 at 05:13:09PM -0600, Rob Herring wrote: > > Convert all the 'simple' panels which either use the single > > 'po

[Bug 204609] amdgpu: powerplay failed send message

2019-12-02 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=204609 Jon (j...@moozaad.co.uk) changed: What|Removed |Added CC||j...@moozaad.co.uk --- Comment

Re: [PATCH] drm/bridge: analogix-anx78xx: Fix drm_dp_link helper removal

2019-12-02 Thread Thierry Reding
On Sat, Nov 30, 2019 at 03:51:55PM +0100, Torsten Duwe wrote: > drm_dp_link_rate_to_bw_code and ...bw_code_to_link_rate simply divide by > and multiply with 27000, respectively. Avoid an overflow in the u8 dpcd[0] > and the multiply+divide alltogether. This was supposed to be a 1:1 conversion of w

Re: [PATCH 8/9] drm/tegra: dpaux: Add missing runtime PM references

2019-12-02 Thread Thierry Reding
On Fri, Nov 29, 2019 at 09:20:25PM +0100, Daniel Vetter wrote: > On Fri, Nov 29, 2019 at 11:44:12AM +0100, Thierry Reding wrote: > > On Fri, Nov 29, 2019 at 10:23:19AM +0100, Daniel Vetter wrote: > > > On Thu, Nov 28, 2019 at 04:37:40PM +0100, Thierry Reding wrote: > > > > From: Thierry Reding > >

Re: [PATCH 1/9] drm/tegra: hub: Remove bogus connection mutex check

2019-12-02 Thread Thierry Reding
On Fri, Nov 29, 2019 at 08:03:09PM +0100, Daniel Vetter wrote: > On Fri, Nov 29, 2019 at 11:12:55AM +0100, Thierry Reding wrote: > > On Fri, Nov 29, 2019 at 10:06:43AM +0100, Daniel Vetter wrote: > > > On Thu, Nov 28, 2019 at 04:37:33PM +0100, Thierry Reding wrote: > > > > From: Thierry Reding > >

Re: [PATCH v1 14/16] drm/panel: call prepare/enable only once

2019-12-02 Thread Laurent Pinchart
Hi Sean, On Mon, Aug 05, 2019 at 01:01:20PM -0400, Sean Paul wrote: > On Sun, Aug 04, 2019 at 10:16:35PM +0200, Sam Ravnborg wrote: > > Many panel drivers duplicate logic to prevent prepare to be called > > for a panel that is already prepared. > > Likewise for enable. > > > > Implement this logi

Re: [PATCH] drm/dp_mst: Fix build on systems with STACKTRACE_SUPPORT=n

2019-12-02 Thread Geert Uytterhoeven
On Mon, Dec 2, 2019 at 2:41 PM Guenter Roeck wrote: > On systems with STACKTRACE_SUPPORT=n, we get: > > WARNING: unmet direct dependencies detected for STACKTRACE > Depends on [n]: STACKTRACE_SUPPORT > Selected by [y]: > - STACKDEPOT [=y] > > and build errors such as: > > m68k-linux-ld: kern

Re: [PATCH v1 14/16] drm/panel: call prepare/enable only once

2019-12-02 Thread Laurent Pinchart
Hi Sam, On Mon, Aug 05, 2019 at 06:51:17PM +0200, Sam Ravnborg wrote: > > On Sun, Aug 04, 2019 at 10:16:35PM +0200, Sam Ravnborg wrote: > > > Many panel drivers duplicate logic to prevent prepare to be called > > > for a panel that is already prepared. > > > Likewise for enable. > > > > > > Imple

Re: [PATCH v2 13/50] drm/bridge: panel: Implement bridge connector operations

2019-12-02 Thread Laurent Pinchart
Hi Sam, On Wed, Oct 09, 2019 at 09:24:47PM +0200, Sam Ravnborg wrote: > On Thu, Oct 03, 2019 at 08:56:15AM +0300, Tomi Valkeinen wrote: > > On 20/08/2019 13:37, Sam Ravnborg wrote: > > > > > > @@ -123,6 +123,18 @@ static void panel_bridge_post_disable(struct > > > > drm_bridge *bridge) > > > >

[Bug 64721] Radeon HD6450 fails on all distro's out of box.

2019-12-02 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=64721 Konstantin Ryabitsev (mri...@kernel.org) changed: What|Removed |Added Status|NEW |RESOLVED

Re: [PATCH 09/60] drm/bridge: Add connector-related bridge operations and data

2019-12-02 Thread Laurent Pinchart
Hi Andrzej, On Thu, Aug 29, 2019 at 06:48:42PM +0200, Andrzej Hajda wrote: > On 26.08.2019 18:27, Laurent Pinchart wrote: > > On Thu, Aug 22, 2019 at 02:17:16PM +0200, Andrzej Hajda wrote: > >> On 20.08.2019 00:45, Laurent Pinchart wrote: > >>> On Mon, Aug 19, 2019 at 10:38:35AM +0200, Andrzej Haj

[PATCH] drm/amd/display: remove redundant assignment to variable v_total

2019-12-02 Thread Colin King
From: Colin Ian King The variable v_total is being initialized with a value that is never read and it is being updated later with a new value. The initialization is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King --- drivers/gpu/drm/amd/display

Re: [PATCH 2/2] drm/i915/vlv_dsi: Control panel and backlight enable GPIOs on BYT

2019-12-02 Thread Hans de Goede
HI, On 02-12-2019 12:53, Jani Nikula wrote: On Mon, 02 Dec 2019, Linus Walleij wrote: Hi Hans, thank you for your patch! On Fri, Nov 29, 2019 at 7:58 PM Hans de Goede wrote: - /* GPIO Desc for CRC based Panel control */ + /* GPIO Desc for panel and backlight control */

Re: [PATCH RFC 10/19] drm/bridge: Add a drm_bridge_state object

2019-12-02 Thread Laurent Pinchart
Hi Boris, On Thu, Aug 22, 2019 at 11:00:56AM +0200, Boris Brezillon wrote: > On Wed, 21 Aug 2019 23:14:56 +0300 Laurent Pinchart wrote: > > > > +int > > > +drm_atomic_add_encoder_bridges(struct drm_atomic_state *state, > > > +struct drm_encoder *encoder) > > > +{ > > > + s

RE: [PATCH] drm/dp_mst: Correct the bug in drm_dp_update_payload_part1()

2019-12-02 Thread Liu, Zhan
> -Original Message- > From: amd-gfx On Behalf Of > Wayne Lin > Sent: 2019/December/01, Sunday 10:59 PM > To: dri-devel@lists.freedesktop.org; amd-...@lists.freedesktop.org > Cc: Zuo, Jerry ; Wentland, Harry > ; Kazlauskas, Nicholas > ; Lin, Wayne > Subject: [PATCH] drm/dp_mst: Correct

Re: [DPU PATCH v3 0/5] List of patches for DP drivers on SnapDragon

2019-12-02 Thread Rob Clark
On Mon, Dec 2, 2019 at 5:47 AM Chandan Uddaraju wrote: > > These patches are to enable DisplayPort driver on SanpDragon. > > These patches have dependency on clock driver changes that > provide DP clock support. This looks like just a functional/runtime dependency? Ie. it would only be the corre

Re: [PATCH v3 09/21] drm/bridge: Add a drm_bridge_state object

2019-12-02 Thread Laurent Pinchart
Hi Boris, Thank you for the patch. On Wed, Oct 23, 2019 at 05:45:00PM +0200, Boris Brezillon wrote: > One of the last remaining objects to not have its atomic state. > > This is being motivated by our attempt to support runtime bus-format > negotiation between elements of the bridge chain. > Thi

Re: [DPU PATCH v3 3/5] drm/msm/dp: add displayPort driver support

2019-12-02 Thread Rob Clark
On Mon, Dec 2, 2019 at 5:48 AM Chandan Uddaraju wrote: > > Add the needed displayPort files to enable DP driver > on msm target. > > "dp_display" module is the main module that calls into > other sub-modules. "dp_drm" file represents the interface > between DRM framework and DP driver. > > changes

Re: [PATCH v3 10/21] drm/bridge: Clarify the atomic enable/disable hooks semantics

2019-12-02 Thread Laurent Pinchart
Hi Boris, Thank you for the patch. On Wed, Oct 23, 2019 at 05:45:01PM +0200, Boris Brezillon wrote: > The [pre_]enable/[post_]disable hooks are passed the old atomic state. > Update the doc and rename the arguments to make it clear. > > Signed-off-by: Boris Brezillon > --- > Changes in v3: > *

Re: [PATCH v3 11/21] drm/bridge: Patch atomic hooks to take a drm_bridge_state

2019-12-02 Thread Laurent Pinchart
Hi Boris, Thank you for the patch. On Wed, Oct 23, 2019 at 05:45:02PM +0200, Boris Brezillon wrote: > This way the drm_bridge_funcs interface is consistent with the rest of > the subsystem. > > The only driver implementing those hooks (analogix DP) is patched too. > > Signed-off-by: Boris Brezi

Re: [PATCH v3 12/21] drm/bridge: Add an ->atomic_check() hook

2019-12-02 Thread Laurent Pinchart
Hi Boris, Thank you for the patch. On Wed, Oct 23, 2019 at 05:45:03PM +0200, Boris Brezillon wrote: > So that bridge drivers have a way to check/reject an atomic operation. > The drm_atomic_bridge_chain_check() (which is just a wrapper around > the ->atomic_check() hook) is called in place of > d

Re: [PATCH v3 13/21] drm/bridge: Add the drm_bridge_chain_get_prev_bridge() helper

2019-12-02 Thread Laurent Pinchart
Hi Boris, Thank you for the patch. On Wed, Oct 23, 2019 at 05:45:04PM +0200, Boris Brezillon wrote: > Will be useful for bridge drivers that want to do bus format > negotiation with their neighbours. A general comment, I think the body of the commit message should be readable on its own, without

Re: [PATCH v3 17/21] dt-bindings: display: bridge: lvds-transmitter: Add new props

2019-12-02 Thread Laurent Pinchart
Hi Boris, Thank you for the patch. On Wed, Oct 23, 2019 at 05:45:08PM +0200, Boris Brezillon wrote: > Add the data-mapping property to describe the output bus format and > the bus-width property to describe the input bus format. > > Signed-off-by: Boris Brezillon > --- > Changes in v3: > * New

Re: [PATCH libdrm v3] modetest: Use floating vrefresh while dumping mode

2019-12-02 Thread Ville Syrjälä
On Mon, Dec 02, 2019 at 03:27:51AM -0800, Devarsh Thakkar wrote: > Add function to derive floating value of vertical > refresh rate from drm mode using pixel clock, > horizontal total size and vertical total size. > > Use this function to find suitable mode having vrefresh > value which is matchin

Re: [PATCH v3 19/21] drm/panel: simple: Add support for Toshiba LTA089AC29000 panel

2019-12-02 Thread Laurent Pinchart
Hi Boris, Thank you for the patch. On Wed, Oct 23, 2019 at 05:45:10PM +0200, Boris Brezillon wrote: > Add a new entry for the Toshiba LTA089AC29000 panel. > > Signed-off-by: Boris Brezillon > --- > Changes in v3: > * None > --- > drivers/gpu/drm/panel/panel-simple.c | 36 ++

Re: [PATCH v3 20/21] dt-bindings: display: panel: Add the LTA089AC29000 variant

2019-12-02 Thread Laurent Pinchart
Hi Boris, Thank you for the patch. On Wed, Oct 23, 2019 at 05:45:11PM +0200, Boris Brezillon wrote: > The LTA089AC29000 and LT089AC29000 are not exactly the same. Let's add > a new compatible for the LTA variant. What is the difference ? :-) > Signed-off-by: Boris Brezillon > --- > .../bindin

Re: [PATCH] drm/stm: ltdc: move pinctrl to encoder mode set

2019-12-02 Thread Philippe CORNU
Dear Yannick, Thank you for your patch, Acked-by: Philippe Cornu Philippe :-) On 11/27/19 11:23 AM, Yannick Fertre wrote: > From: Yannick Fertré > > The pin control must be set to default as soon as possible to > establish a good video link between tv & bridge hdmi > (encoder mode set is call

Re: [PATCH 5/5] drm: drop DRM_AUTH from PRIME_TO/FROM_HANDLE ioctls

2019-12-02 Thread Emil Velikov
On Wed, 27 Nov 2019 at 18:37, Daniel Vetter wrote: > > On Wed, Nov 27, 2019 at 06:32:56PM +, Emil Velikov wrote: > > On Wed, 27 Nov 2019 at 18:04, Daniel Vetter wrote: > > > > > > On Wed, Nov 27, 2019 at 04:27:29PM +, Emil Velikov wrote: > > > > On Wed, 27 Nov 2019 at 07:41, Boris Brezill

Re: [PATCH libdrm v3] modetest: Use floating vrefresh while dumping mode

2019-12-02 Thread Neil Armstrong
On 02/12/2019 18:12, Ville Syrjälä wrote: > On Mon, Dec 02, 2019 at 03:27:51AM -0800, Devarsh Thakkar wrote: >> Add function to derive floating value of vertical >> refresh rate from drm mode using pixel clock, >> horizontal total size and vertical total size. >> >> Use this function to find suitab

Re: [PATCH] rnndb: Add GBIF registers for a6xx GPU

2019-12-02 Thread Rob Clark
On Thu, Nov 28, 2019 at 11:41 PM Sharat Masetty wrote: > > Add GBIF register definitions required to implement a618 > GPU revision > > Signed-off-by: Sharat Masetty thanks, I've pushed the xml to envytools BR, -R > --- > rnndb/adreno/a6xx.xml | 26 ++ > 1 file changed,

Re: [PATCH] drm/mcde: Fix vertical resolution bugs

2019-12-02 Thread kbuild test robot
Hi Linus, I love your patch! Yet something to improve: [auto build test ERROR on drm-exynos/exynos-drm-next] [also build test ERROR on v5.4 next-20191202] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '-

[PATCH] drm: remove no longer used .master_{create, destroy} callbacks

2019-12-02 Thread Emil Velikov
From: Emil Velikov Up-to recently the only driver which required these was vmwgfx. With commit 9c84aeba67cc ("drm/vmwgfx: Kill unneeded legacy security features") the driver no longer sets them, so we can drop the unused infra. Cc: Thomas Hellstrom Cc: Daniel Vetter Signed-off-by: Emil Veliko

Re: [PATCH libdrm v3] modetest: Use floating vrefresh while dumping mode

2019-12-02 Thread Ville Syrjälä
On Mon, Dec 02, 2019 at 06:22:56PM +0100, Neil Armstrong wrote: > On 02/12/2019 18:12, Ville Syrjälä wrote: > > On Mon, Dec 02, 2019 at 03:27:51AM -0800, Devarsh Thakkar wrote: > >> Add function to derive floating value of vertical > >> refresh rate from drm mode using pixel clock, > >> horizontal

Re: [PATCH] drm/mcde: Fix vertical resolution bugs

2019-12-02 Thread kbuild test robot
Hi Linus, I love your patch! Yet something to improve: [auto build test ERROR on drm-exynos/exynos-drm-next] [also build test ERROR on v5.4 next-20191202] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '-

Re: [PATCH] drm/dp_mst: Fix build on systems with STACKTRACE_SUPPORT=n

2019-12-02 Thread Lyude Paul
Reviewed-by: Lyude Paul I'll go ahead and push this to drm-misc-next, thanks! On Mon, 2019-12-02 at 16:20 +0100, Geert Uytterhoeven wrote: > On Mon, Dec 2, 2019 at 2:41 PM Guenter Roeck wrote: > > On systems with STACKTRACE_SUPPORT=n, we get: > > > > WARNING: unmet direct dependencies detected

[PATCH] ARM: dts: am335x-evm: Use drm simple-panel instead of tilcdc-panel

2019-12-02 Thread Jyri Sarha
Move to use the new drm panel support in tilcdc together with added "tfc,s9700rtwv43tr-01b"-panel support in drm panel-simple. Signed-off-by: Jyri Sarha Reviewed-by: Tomi Valkeinen --- "tfc,s9700rtwv43tr-01b" in panel-simple has been in for some time now so it is about time to get this in too.

Re: [DPU PATCH v3 3/5] drm/msm/dp: add displayPort driver support

2019-12-02 Thread Rob Clark
On Mon, Dec 2, 2019 at 5:48 AM Chandan Uddaraju wrote: > > Add the needed displayPort files to enable DP driver > on msm target. > > "dp_display" module is the main module that calls into > other sub-modules. "dp_drm" file represents the interface > between DRM framework and DP driver. > > changes

[RESEND 1/2] drm: Add support for DP 1.4 Compliance edid corruption test 4.2.2.6

2019-12-02 Thread Jerry (Fangzhi) Zuo
DP 1.4 edid corruption test requires source DUT to write calculated CRC, not the corrupted CRC from reference sink. Return the calculated CRC back, and initiate the required sequence. -v2: Have separate routine for returning real CRC -v3: Rewrite checksum computation routine to avoid duplicated

[RESEND 2/2] drm/amd/display: Hook up drm interface for DP 1.4 edid corruption test

2019-12-02 Thread Jerry (Fangzhi) Zuo
-v3: Rename to avoid confusion Signed-off-by: Jerry (Fangzhi) Zuo Reviewed-by: Harry Wentland --- .../drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 35 +- 1 file changed, 7 insertions(+), 28 deletions(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helper

[RESEND 0/2] Changes for DP 1.4 Compliance test 4.2.2.6

2019-12-02 Thread Jerry (Fangzhi) Zuo
Unlike DP 1.2 Compliance test 4.2.2.6, DP 1.4 requires to calculate real CRC value of the last edid data block, and write it back. Current edid CRC calculate routine adds the last CRC byte, and check if non-zero or not. Need to return the actual CRC value when corruption is detected. [For CI] Res

Re: [PATCH RFC v4 02/16] cgroup: Introduce cgroup for drm subsystem

2019-12-02 Thread Tejun Heo
On Fri, Nov 29, 2019 at 01:00:36AM -0500, Kenny Ho wrote: > On Tue, Oct 1, 2019 at 10:31 AM Michal Koutný wrote: > > On Thu, Aug 29, 2019 at 02:05:19AM -0400, Kenny Ho wrote: > > > +struct cgroup_subsys drm_cgrp_subsys = { > > > + .css_alloc = drmcg_css_alloc, > > > + .css_free

RE: [PATCH v4] drm/scheduler: Avoid accessing freed bad job.

2019-12-02 Thread Deng, Emily
[AMD Official Use Only - Internal Distribution Only] Hi Andrey, Seems this patch is still not in amd-staging-drm-next? Best wishes Emily Deng >-Original Message- >From: Deng, Emily >Sent: Tuesday, November 26, 2019 4:41 PM >To: Grodzovsky, Andrey >Cc: dri-devel@lists.freedesktop.o

[PATCH v1 0/26] drm/panel infrastructure + backlight update

2019-12-02 Thread Sam Ravnborg
This patchset include a couple of different things - all related to panels. - The panel callbacks are optional - so drop error if callback is not present. - Add support for backlight in drm_panel. This allows us to make much simpler backlight support to most panels. The patchset include

[PATCH v1 03/26] drm/panel: simple: use drm_panel backlight support

2019-12-02 Thread Sam Ravnborg
Use drm_panel infrastructure for backlight. Replace direct calls with drm_panel_*() calls to utilize the drm_panel support. Signed-off-by: Sam Ravnborg cc: Laurent Pinchart Cc: Thierry Reding Cc: Sam Ravnborg --- drivers/gpu/drm/panel/panel-simple.c | 50 ++-- 1 file c

[PATCH v1 04/26] drm: get drm_bridge_panel connector via helper

2019-12-02 Thread Sam Ravnborg
The drm_connector created by drm_panel_bridge was accessed via drm_panel.connector. Avoid the detour around drm_panel by providing a simple get method. This avoids direct access to the connector field in drm_panel in the two users. Update pl111 and tve200 to use the new helper. Signed-off-by: Sam

  1   2   >