[PATCH 1/1] drm/mediatek: fine tune the dsi panel's power sequence

2019-11-06 Thread Jitao Shi
Add the drm_panel_prepare_power and drm_panel_unprepare_power control. Turn on panel power(drm_panel_prepare_power) and control before dsi enable. And then dsi enable, send dcs cmd in drm_panel_prepare, last turn on backlight. Signed-off-by: Jitao Shi --- drivers/gpu/drm/mediatek/mtk_dsi.c | 19

[PATCH 0/1] fine tune the dsi panel's power sequence

2019-11-06 Thread Jitao Shi
This patch is based on v5.4-rc6 and these patches: https://patchwork.kernel.org/patch/11229375/ Jitao Shi (1): drm/mediatek: fine tune the dsi panel's power sequence drivers/gpu/drm/mediatek/mtk_dsi.c | 19 +-- 1 file changed, 17 insertions(+), 2 deletions(-) -- 2.21.0

[PATCH 1/1] drm/panel: boe-tv101wum-n16 seperate the panel power control

2019-11-06 Thread Jitao Shi
Seperate the panel power control from prepare/unprepare. Signed-off-by: Jitao Shi --- .../gpu/drm/panel/panel-boe-tv101wum-nl6.c| 69 +-- 1 file changed, 49 insertions(+), 20 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c b/drivers/gpu/drm/panel/pa

[PATCH 0/1] boe-tv101wum-n16 seperate the panel power control

2019-11-06 Thread Jitao Shi
This patch is based on v5.4-rc6 and these patches: https://patchwork.kernel.org/patch/11229375/ https://patchwork.kernel.org/patch/11229609/ https://patchwork.kernel.org/patch/11186565/ https://patchwork.kernel.org/patch/11186569/ https://patchwork.kernel.org/patch/11186571/ https://patchwork.kerne

Re: [PATCH 1/2] drm/fb-helper: Remove drm_fb_helper_defio_init() and update docs

2019-11-06 Thread Thomas Zimmermann
Hi Am 05.11.19 um 10:30 schrieb Daniel Vetter: > On Mon, Nov 04, 2019 at 07:48:35PM +0100, Thomas Zimmermann wrote: >> Hi Daniel >> >> Am 04.11.19 um 10:55 schrieb Daniel Vetter: >>> On Mon, Oct 28, 2019 at 09:13:47AM +0100, Thomas Zimmermann wrote: Hi Am 25.10.19 um 20:54 schrieb D

Re: [PATCH 3/3] drm/udl: Switch to SHMEM

2019-11-06 Thread Thomas Zimmermann
Hi Am 05.11.19 um 12:05 schrieb Gerd Hoffmann: > On Mon, Oct 28, 2019 at 09:45:49AM +0100, Thomas Zimmermann wrote: >> Udl's GEM code and the generic SHMEM are almost identical. Replace >> the former with SHMEM. The dmabuf support in udl is being removed >> in favor of the generic GEM PRIME functi

Re: [PATCH 6/9] drm/ast: Add primary plane

2019-11-06 Thread Thomas Zimmermann
Hi Am 05.11.19 um 10:51 schrieb Gerd Hoffmann: >> +static const struct drm_plane_funcs ast_primary_plane_funcs = { >> +.update_plane = drm_atomic_helper_update_plane, >> +.disable_plane = drm_atomic_helper_disable_plane, >> +.destroy = drm_plane_cleanup, >> +.reset = drm_atomic_hel

Re: [PATCH 9/9] drm/ast: Enable atomic modesetting

2019-11-06 Thread Thomas Zimmermann
Hi Am 05.11.19 um 11:31 schrieb Daniel Vetter: > On Tue, Nov 05, 2019 at 10:57:11AM +0100, Gerd Hoffmann wrote: >> On Mon, Oct 28, 2019 at 04:49:28PM +0100, Thomas Zimmermann wrote: >>> This commit sets the remaining atomic-modesetting helpers and the flag >>> DRIVER_ATOMIC. Legacy cursor function

Re: [PATCH 8/9] drm/ast: Add cursor plane

2019-11-06 Thread Thomas Zimmermann
Hi Am 05.11.19 um 10:55 schrieb Daniel Vetter: > On Mon, Oct 28, 2019 at 04:49:27PM +0100, Thomas Zimmermann wrote: >> The cursor plane uses an internal format of ARGB. To userspace, we >> announce ARGB and do the transformation internally. >> >> Signed-off-by: Thomas Zimmermann > > Hm,

[Bug 111481] AMD Navi GPU frequent freezes on both Manjaro/Ubuntu with kernel 5.3 and mesa 19.2 -git/llvm9

2019-11-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111481 --- Comment #210 from Lazy --- To clarify, first: it's an Asus reference (blower-style) 5700XT I can't use the overclock utilities without a crash coming within the hour on Windows 10 or any of my Linux installs, no fan profiles, no manual contr

Re: [PATCH] drm/i915/gvt: fix dropping obj reference twice

2019-11-06 Thread Zhenyu Wang
On 2019.11.06 15:31:07 +0800, Pan Bian wrote: > The reference count of obj will be decremented twice if error occurs > in dma_buf_fd(). Additionally, attempting to read the reference count of > obj after dropping reference may lead to a use after free bug. Here, we > drop obj's reference until it i

Re: [PATCH 8/9] drm/ast: Add cursor plane

2019-11-06 Thread Daniel Vetter
On Wed, Nov 6, 2019 at 9:31 AM Thomas Zimmermann wrote: > > Hi > > Am 05.11.19 um 10:55 schrieb Daniel Vetter: > > On Mon, Oct 28, 2019 at 04:49:27PM +0100, Thomas Zimmermann wrote: > >> The cursor plane uses an internal format of ARGB. To userspace, we > >> announce ARGB and do the transf

Re: [PATCH v2 7/7] drm/mediatek: Support 180 degree rotation

2019-11-06 Thread CK Hu
Hi, Sean: On Tue, 2019-11-05 at 16:10 -0500, Sean Paul wrote: > From: Sean Paul > > Now that we support both reflections, we can expose 180 degree rotation > and rely on the simplify routine to convert that into REFLECT_X | > REFLECT_Y > Patch 1 ~ 6 of this series looks good to me. For this on

[PATCH 5/8] drm/client: Return I/O memory flag from drm_client_buffer_vmap()

2019-11-06 Thread Thomas Zimmermann
With this patch, drm_client_buffer_vmap() forwards the io_mem parameter from the vmap implementation to its caller. By default, is_iomem is assumed to be false. This matches the return type and the old behaviour. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_client.c| 15 +

[PATCH 4/8] drm/gem: Return I/O-memory flag from drm_gem_vram()

2019-11-06 Thread Thomas Zimmermann
With this patch, drm_gem_vmap() forwards the io_mem parameter from the vmap implementation to its caller. By default, is_iomem is assumed to be false. This matches the return type and the old behaviour. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_client.c | 2 +- drivers/gpu/drm/d

[PATCH 2/8] drm/qxl: Tell caller if kmap() returned I/O memory

2019-11-06 Thread Thomas Zimmermann
Returning a flag from kmap() whether mapped pages refer to system or I/O memory. This prepares for a respective change to vmap(). Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/qxl/qxl_display.c | 6 +++--- drivers/gpu/drm/qxl/qxl_draw.c| 4 ++-- drivers/gpu/drm/qxl/qxl_drv.h | 2 +

[PATCH 7/8] drm/fb-helper: Select between fb_{sys, cfb}_read() and _write()

2019-11-06 Thread Thomas Zimmermann
Generic fbdev emulation used to access framebuffers as if they were located in system memory. Depending on the whether the framebuffer is in I/O or system memory, the fbdev emulation now calls the correct functions for accessing each. This change allows to support generic fbdev emulation on system

[RFC][PATCH 0/8] Support I/O memory in generic fbdev emulation

2019-11-06 Thread Thomas Zimmermann
We recently had a discussion if/how fbdev emulation could support framebuffers in I/O memory on all platform. [1] I typed up a patchset that passes information about the memory area from memory manager to client (e.g., fbdev emulation). The client can take this into consideration when accessing th

[PATCH 1/8] drm/vram-helper: Tell caller if vmap() returned I/O memory

2019-11-06 Thread Thomas Zimmermann
Returning a flag from kmap() whether mapped pages refer to system or I/O memory. This prepares for a respective change to vmap(). Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_mode.c | 6 +++--- drivers/gpu/drm/drm_gem_vram_helper.c| 8 +--- drivers/gpu/drm/mgag2

[PATCH 3/8] drm: Add is_iomem return parameter to struct drm_gem_object_funcs.vmap

2019-11-06 Thread Thomas Zimmermann
The vmap operation can return system or I/O memory, which the caller may have to treat differently. The parameter is_iomem returns 'true' if the returned pointer refers to I/O memory, or 'false' otherwise. In many cases, such as CMA ans SHMEM, the returned value is 'false'. For TTM-based drivers,

[PATCH 8/8] drm/fb-helper: Handle I/O memory correctly when flushing shadow fb

2019-11-06 Thread Thomas Zimmermann
The fbdev console's framebuffer can be located in I/O memory, such as video RAM. When flushing the shadow fb, we test for this case and use I/O-based memcpy() instead. The shadow fb is always in system memory. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_fb_helper.c | 6 +- 1 fil

[PATCH 6/8] fbdev: Export default read and write operations as fb_cfb_{read, write}()

2019-11-06 Thread Thomas Zimmermann
Read and write operations on the fbdev framebuffer can now be called by in-kernel users. This is required by DRM's fbdev helpers. Signed-off-by: Thomas Zimmermann --- drivers/video/fbdev/core/fbmem.c | 53 include/linux/fb.h | 5 +++ 2 files change

[Bug 201539] AMDGPU R9 390 automatic fan speed control in Linux 4.19/4.20/5.0

2019-11-06 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=201539 --- Comment #26 from MasterCATZ (masterc...@hotmail.com) --- around 12 hrs later lost fan control again -- You are receiving this mail because: You are watching the assignee of the bug. ___ dri-devel m

Re: [PATCH] drm/amdgpu: fix potential double drop fence reference

2019-11-06 Thread Koenig, Christian
Am 06.11.19 um 10:14 schrieb Pan Bian: > The object fence is not set to NULL after its reference is dropped. As a > result, its reference may be dropped again if error occurs after that, > which may lead to a use after free bug. To avoid the issue, fence is > explicitly set to NULL after dropping i

[Bug 111481] AMD Navi GPU frequent freezes on both Manjaro/Ubuntu with kernel 5.3 and mesa 19.2 -git/llvm9

2019-11-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111481 --- Comment #211 from Marco Liedtke --- Hi folks, i am new to bugreporting, but due to having a new system and this bug, i want to contribute something to this situation. I have almost the same behavior as stated in comment 1. My Xorg freezes

Re: [PATCH 8/9] drm/ast: Add cursor plane

2019-11-06 Thread Thomas Zimmermann
Hi Am 06.11.19 um 10:05 schrieb Daniel Vetter: > On Wed, Nov 6, 2019 at 9:31 AM Thomas Zimmermann wrote: >> >> Hi >> >> Am 05.11.19 um 10:55 schrieb Daniel Vetter: >>> On Mon, Oct 28, 2019 at 04:49:27PM +0100, Thomas Zimmermann wrote: The cursor plane uses an internal format of ARGB. To

[Bug 109955] amdgpu [RX Vega 64] system freeze while gaming

2019-11-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109955 --- Comment #127 from har...@gmx.de --- (In reply to Rodney A Morris from comment #126) > If you want someone to apply your changes in bug report no. 110777 to the > kernel for testing, I can so but will not be to it until this weekend. ... tha

[PATCH 2/2] drm/gma500: Add page flip support on psb/cdv

2019-11-06 Thread Paul Kocialkowski
Legacy (non-atomic) page flip support is added to the driver by using the mode_set_base CRTC function, that allows configuring a new framebuffer for display. Since the function requires the primary plane's fb to be set already, this is done prior to calling the function in the page flip helper and

[PATCH 0/2] drm/gma500: Add page flip support on psb/cdv

2019-11-06 Thread Paul Kocialkowski
This series brings-in the required bits to implement page flip support on poulsbo and cedartrail. Page flip support is required to run weston with the GMA500 driver. This is only legacy page flip support, not a conversion of the driver to atomic DRM. Paul Kocialkowski (2): drm/gma500: Add missi

[PATCH 1/2] drm/gma500: Add missing call to allow enabling vblank on psb/cdv

2019-11-06 Thread Paul Kocialkowski
This adds a missing call to drm_crtc_vblank_on to the common DPMS helper (used by poulsbo and cedartrail), which is called in the CRTC enable path. With that call, it becomes possible to enable vblank when needed. It is already balanced by a drm_crtc_vblank_off call in the helper. Other platforms

Re: [PATCH] drm/bridge: ti-tfp410: switch to using fwnode_gpiod_get_index()

2019-11-06 Thread Daniel Vetter
On Tue, Nov 05, 2019 at 09:53:23PM +0200, Laurent Pinchart wrote: > Hi Daniel, > > On Tue, Nov 05, 2019 at 04:41:41PM +0100, Daniel Vetter wrote: > > On Tue, Nov 5, 2019 at 4:29 PM Linus Walleij wrote: > > > On Tue, Nov 5, 2019 at 1:40 AM Dmitry Torokhov wrote: > > > > On Mon, Oct 14, 2019 at 11:4

Re: Proposal to report GPU private memory allocations with sysfs nodes [plain text version]

2019-11-06 Thread Daniel Vetter
On Tue, Nov 05, 2019 at 11:45:28AM -0800, Yiwei Zhang wrote: > Hi Daniel, > > > - The labels are currently free-form, baking them back into your structure > > would mean we'd need to do lots of hot add/remove of sysfs directory > > trees. Which sounds like a real bad idea :-/ > Given the free fo

Re: [PATCH] drm/amdgpu: fix double reference dropping

2019-11-06 Thread Koenig, Christian
Am 06.11.19 um 10:53 schrieb Pan Bian: > After dropping the reference of object fence in the loop, it should be > set to NULL to protecting dropping its reference again outside the loop. NAK, the actual bug is that we shouldn't drop the fence outside the loop in the first place. Just move the dm

Re: [PATCH 1/1] drm/panel: boe-tv101wum-n16 seperate the panel power control

2019-11-06 Thread Daniel Vetter
On Wed, Nov 06, 2019 at 04:17:52PM +0800, Jitao Shi wrote: > Seperate the panel power control from prepare/unprepare. > > Signed-off-by: Jitao Shi Your patch series is all kinds of split up. Can you pls resend, with the entire thing all in one go? Thanks, Daniel > --- > .../gpu/drm/panel/pane

Re: [GIT PULL FOR v5.5 - 2nd try] R-Car DU CMM support

2019-11-06 Thread Laurent Pinchart
Hi Dave, (CC'ing Jacopo) On Wed, Nov 06, 2019 at 01:40:13PM +1000, Dave Airlie wrote: > On Wed, 6 Nov 2019 at 05:56, Dave Airlie wrote: > > On Wed, 6 Nov 2019 at 05:49, Laurent Pinchart wrote: > > > > > > Hi Dave, > > > > > > Has this pull request fallen through the cracks ? > > > > It fell down

Re: [GIT PULL FOR v5.5 - 2nd try] R-Car DU CMM support

2019-11-06 Thread Laurent Pinchart
This time with Jacopo correctly CC'ed. On Wed, Nov 06, 2019 at 12:00:59PM +0200, Laurent Pinchart wrote: > Hi Dave, > > (CC'ing Jacopo) > > On Wed, Nov 06, 2019 at 01:40:13PM +1000, Dave Airlie wrote: > > On Wed, 6 Nov 2019 at 05:56, Dave Airlie wrote: > > > On Wed, 6 Nov 2019 at 05:49, Laurent

Re: [RFC][PATCH 0/8] Support I/O memory in generic fbdev emulation

2019-11-06 Thread Daniel Vetter
On Wed, Nov 06, 2019 at 10:31:13AM +0100, Thomas Zimmermann wrote: > We recently had a discussion if/how fbdev emulation could support > framebuffers in I/O memory on all platform. [1] > > I typed up a patchset that passes information about the memory area > from memory manager to client (e.g., fb

[PATCH 3/3] drm/prime: Use anon_drm_getfile() for an internal drm struct file

2019-11-06 Thread Chris Wilson
Currently the drm_prime mmap fallback uses a mock struct file to provide the file pointer into the backend mmap routine. Now that we can create fully fledged anonymous struct file around the drm device, put it to use. Signed-off-by: Chris Wilson --- drivers/gpu/drm/drm_prime.c | 26 -

[PATCH 2/3] drm/i915/selftests: Wrap vm_mmap() around GEM objects

2019-11-06 Thread Chris Wilson
Provide a utility function to create a vma corresponding to an mmap() of our device. And use it to exercise the equivalent of userspace performing a GTT mmap of our objects. Signed-off-by: Chris Wilson Cc: Abdiel Janulgue --- drivers/gpu/drm/i915/Makefile | 1 + .../drm/i915/ge

[PATCH 1/3] drm: Expose a method for creating anonymous struct file around drm_minor

2019-11-06 Thread Chris Wilson
Sometimes we need to create a struct file to wrap a drm_device, as it the user were to have opened /dev/dri/card0 but to do so anonymously (i.e. for internal use). Provide a utility method to create a struct file with the drm_device->driver.fops, that wrap the drm_device. Signed-off-by: Chris Wils

Re: [Intel-gfx] [PATCH 1/3] drm: Expose a method for creating anonymous struct file around drm_minor

2019-11-06 Thread Daniel Vetter
On Wed, Nov 06, 2019 at 10:07:14AM +, Chris Wilson wrote: > Sometimes we need to create a struct file to wrap a drm_device, as it > the user were to have opened /dev/dri/card0 but to do so anonymously > (i.e. for internal use). Provide a utility method to create a struct > file with the drm_dev

Re: [PATCH 3/3] drm/prime: Use anon_drm_getfile() for an internal drm struct file

2019-11-06 Thread Daniel Vetter
On Wed, Nov 06, 2019 at 10:07:16AM +, Chris Wilson wrote: > Currently the drm_prime mmap fallback uses a mock struct file to provide > the file pointer into the backend mmap routine. Now that we can create > fully fledged anonymous struct file around the drm device, put it to > use. > > Signed

[Bug 109955] amdgpu [RX Vega 64] system freeze while gaming

2019-11-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109955 --- Comment #128 from har...@gmx.de --- Created attachment 145901 --> https://bugs.freedesktop.org/attachment.cgi?id=145901&action=edit proposed fix for crashes, caused by frequent mclk level 0/1 switches At least one of the causes for crashes

Re: [Intel-gfx] [PATCH] drm/i915: Don't select BROKEN

2019-11-06 Thread Joonas Lahtinen
Quoting Chris Wilson (2019-11-05 23:13:36) > Quoting Daniel Vetter (2019-11-05 20:58:25) > > On Tue, Nov 5, 2019 at 9:38 PM Chris Wilson > > wrote: > > > > > > Quoting Daniel Vetter (2019-11-05 19:38:29) > > > > It's broken. > > > > > > > > Reported-by: Stephen Rothwell > > > > References: > >

Re: [PATCH 3/3] drm/ttm: remove ttm_bo_wait_unreserved

2019-11-06 Thread Daniel Vetter
On Mon, Nov 04, 2019 at 06:38:01PM +0100, Daniel Vetter wrote: > With nouveau fixed all ttm-using drives have the correct nesting of > mmap_sem vs dma_resv, and we can just lock the buffer. > > Assuming I didn't screw up anything with my audit of course. > > v2: > - Dont forget wu_mutex (Christia

Re: [Intel-gfx] [PATCH 1/3] drm: Expose a method for creating anonymous struct file around drm_minor

2019-11-06 Thread Chris Wilson
Quoting Daniel Vetter (2019-11-06 10:19:50) > On Wed, Nov 06, 2019 at 10:07:14AM +, Chris Wilson wrote: > > Sometimes we need to create a struct file to wrap a drm_device, as it > > the user were to have opened /dev/dri/card0 but to do so anonymously > > (i.e. for internal use). Provide a utili

Re: [PATCHv2 1/4] drm/arm: Factor out generic afbc helpers

2019-11-06 Thread Liviu Dudau
Hi Andrzej, On Tue, Nov 05, 2019 at 11:26:36PM +, Daniel Stone wrote: > Hi Andrzej, > Thanks for taking this on! It's looking better than v1 for sure. A few > things below: > > On Mon, 2019-11-04 at 23:12 +0100, Andrzej Pietrasiewicz wrote: > > +bool drm_afbc_check_offset(struct drm_device *d

Re: [Intel-gfx] [PATCH 1/3] drm: Expose a method for creating anonymous struct file around drm_minor

2019-11-06 Thread Chris Wilson
Quoting Chris Wilson (2019-11-06 10:26:48) > Quoting Daniel Vetter (2019-11-06 10:19:50) > > On Wed, Nov 06, 2019 at 10:07:14AM +, Chris Wilson wrote: > > > Sometimes we need to create a struct file to wrap a drm_device, as it > > > the user were to have opened /dev/dri/card0 but to do so anony

Re: [GIT PULL FOR v5.5 - 2nd try] R-Car DU CMM support

2019-11-06 Thread Jacopo Mondi
Hi Laurent, Dave, On Wed, Nov 06, 2019 at 12:02:05PM +0200, Laurent Pinchart wrote: > This time with Jacopo correctly CC'ed. > > On Wed, Nov 06, 2019 at 12:00:59PM +0200, Laurent Pinchart wrote: > > Hi Dave, > > > > (CC'ing Jacopo) > > > > On Wed, Nov 06, 2019 at 01:40:13PM +1000, Dave Airlie wrot

Re: [PATCH 3/3] drm/prime: Use anon_drm_getfile() for an internal drm struct file

2019-11-06 Thread Chris Wilson
Quoting Daniel Vetter (2019-11-06 10:21:57) > On Wed, Nov 06, 2019 at 10:07:16AM +, Chris Wilson wrote: > > Currently the drm_prime mmap fallback uses a mock struct file to provide > > the file pointer into the backend mmap routine. Now that we can create > > fully fledged anonymous struct file

[PATCH v2 2/4] drm/udl: Allocate GEM object via struct drm_driver.gem_create_object

2019-11-06 Thread Thomas Zimmermann
In preparation of a switch to SHMEM, udl now allocates its GEM objects via struct drm_driver.gem_create_object. No functional changes are made. For SHMEM GEM objects, udl will require the use of a special mmap function, which we set though the create-object function. Signed-off-by: Thomas Zimmerm

[PATCH v2 3/4] drm/udl: Switch to SHMEM

2019-11-06 Thread Thomas Zimmermann
Udl's GEM code and the generic SHMEM are almost identical. Replace the former with SHMEM. The dmabuf support in udl is being replaced with generic GEM PRIME functions. The main difference is in the caching flags for mmap pages. By default, SHMEM always sets (uncached) write combining. In udl's mem

[PATCH v2 4/4] drm/udl: Remove struct udl_gem_object and functions

2019-11-06 Thread Thomas Zimmermann
Simply removes all the obsolete GEM code from udl. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/udl/Makefile | 2 +- drivers/gpu/drm/udl/udl_dmabuf.c | 254 --- drivers/gpu/drm/udl/udl_drv.h| 29 drivers/gpu/drm/udl/udl_g

[PATCH v2 1/4] drm/udl: Remove flags field from struct udl_gem_object

2019-11-06 Thread Thomas Zimmermann
The flags field in struct udl_gem controls mapping parameters: cached access for local buffers, write-combined access for imported buffers. We can drop the field and distinguish both cases by testing whether struct drm_gem_object.import_attach is NULL. Signed-off-by: Thomas Zimmermann Acked-by:

[PATCH v2 0/4] drm/udl: Convert to SHMEM

2019-11-06 Thread Thomas Zimmermann
Udl's GEM implementation is mostly SHMEM and we should attempt to replace it with the latter. Patches #1 and #2 update udl to simplify the conversion. In patch #3 the udl code is being replaced by SHMEM. The GEM object's mmap() and free_object() functions are wrappers around their SHMEM counterpar

Re: [PATCH V9 3/6] mdev: introduce device specific ops

2019-11-06 Thread Cornelia Huck
On Wed, 6 Nov 2019 15:05:45 +0800 Jason Wang wrote: > Currently, except for the create and remove, the rest of > mdev_parent_ops is designed for vfio-mdev driver only and may not help > for kernel mdev driver. With the help of class id, this patch > introduces device specific callbacks inside md

Re: [PATCH V9 4/6] mdev: introduce virtio device and its device ops

2019-11-06 Thread Cornelia Huck
On Wed, 6 Nov 2019 15:05:46 +0800 Jason Wang wrote: > This patch implements basic support for mdev driver that supports > virtio transport for kernel virtio driver. > > Signed-off-by: Jason Wang > --- > MAINTAINERS | 1 + > drivers/vfio/mdev/mdev_core.c| 21 + >

Re: [PATCH V9 5/6] virtio: introduce a mdev based transport

2019-11-06 Thread Cornelia Huck
On Wed, 6 Nov 2019 15:05:47 +0800 Jason Wang wrote: > This patch introduces a new mdev transport for virtio. This is used to > use kernel virtio driver to drive the mediated device that is capable > of populating virtqueue directly. > > A new virtio-mdev driver will be registered to the mdev bu

Re: [PATCHv2 2/4] drm/malidp: use afbc helpers

2019-11-06 Thread Liviu Dudau
Hi Andrzej, On Mon, Nov 04, 2019 at 11:12:26PM +0100, Andrzej Pietrasiewicz wrote: > There are afbc helpers available. > > Signed-off-by: Andrzej Pietrasiewicz > --- > drivers/gpu/drm/arm/malidp_drv.c | 66 ++-- > 1 file changed, 12 insertions(+), 54 deletions(-) >

Re: [PATCH] drm/bridge: tc358767: fix max_tu_symbol value

2019-11-06 Thread Tomi Valkeinen
On 10/10/2019 12:25, Tomi Valkeinen wrote: Hi Andrzej, On 10/10/2019 12:19, Andrzej Hajda wrote: On 24.09.2019 15:17, Tomi Valkeinen wrote: max_tu_symbol was programmed to TU_SIZE_RECOMMENDED - 1, which is not what the spec says. The spec says: roundup ((input active video bandwidth in bytes/

Re: [Intel-gfx] [PATCH] drm/fbdev: Fallback to non tiled mode if all tiles not present

2019-11-06 Thread Daniel Stone
Hi, On Wed, 6 Nov 2019 at 02:47, Dave Airlie wrote: > Otherwise I think this seems fine, though it does beg the question in > my mind of what happens if I get 2 8K monitors, and plug the first > tile of one in, and the second tile of the other in. Honestly in that case I think 'you get to litera

[Bug 205093] [amdgpu] resume of IP block failed -110 (GPU crash into black screen)

2019-11-06 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=205093 Marcin P (kat.zygf...@gmail.com) changed: What|Removed |Added Kernel Version|5.2.13 |5.3.6 -- You are rece

Re: [PATCH v2 4/4] drm/udl: Remove struct udl_gem_object and functions

2019-11-06 Thread Noralf Trønnes
Den 06.11.2019 11.47, skrev Thomas Zimmermann: > Simply removes all the obsolete GEM code from udl. No functional > changes. > > Signed-off-by: Thomas Zimmermann > --- > drivers/gpu/drm/udl/Makefile | 2 +- > drivers/gpu/drm/udl/udl_dmabuf.c | 254 --- > drive

[PATCH] drm: msm: a6xx: fix debug bus register configuration

2019-11-06 Thread Sharat Masetty
Fix the cx debugbus related register configuration, to collect accurate bus data during gpu snapshot. This helps with complete snapshot dump and also complete proper GPU recovery. Signed-off-by: Sharat Masetty --- drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c | 24 1 file

Re: [PATCH v2 4/4] drm/udl: Remove struct udl_gem_object and functions

2019-11-06 Thread Thomas Zimmermann
Hi Am 06.11.19 um 12:48 schrieb Noralf Trønnes: > > > Den 06.11.2019 11.47, skrev Thomas Zimmermann: >> Simply removes all the obsolete GEM code from udl. No functional >> changes. >> >> Signed-off-by: Thomas Zimmermann >> --- >> drivers/gpu/drm/udl/Makefile | 2 +- >> drivers/gpu/drm/ud

Re: [PATCHv2 1/4] drm/arm: Factor out generic afbc helpers

2019-11-06 Thread Andrzej Pietrasiewicz
Hi Daniel, Thank you for review, W dniu 05.11.2019 o 10:22, Daniel Vetter pisze: On Mon, Nov 04, 2019 at 11:12:25PM +0100, Andrzej Pietrasiewicz wrote: These are useful for other users of afbc, e.g. rockchip. + +bool drm_afbc_check_fb_size_ret(u32 pitch, int bpp, +

[PATCH v2 1/2] drm/todo: Convert drivers to generic fbdev emulation

2019-11-06 Thread Thomas Zimmermann
This replaces the original TODO item for drm_fb_helper_fbdev_setup() and _teardown(), which are deprecated. v2: * remove driver-specific comments * list some basic requirements * keep a TODO item on drm_fb_helper_init() Signed-off-by: Thomas Zimmermann --- Documentation/

[PATCH v2 2/2] drm/fb-helper: Remove drm_fb_helper_fbdev_{setup, teardown}()

2019-11-06 Thread Thomas Zimmermann
Both functions are unused and can be removed. Drivers should use drm_fbdev_generic_setup() instead. Signed-off-by: Thomas Zimmermann Reviewed-by: Noralf Trønnes --- drivers/gpu/drm/drm_fb_helper.c | 109 +--- include/drm/drm_fb_helper.h | 25 2 files ch

[PATCH v2 0/2] Remove drm_fb_helper_fbdev_{setup,teardown}()

2019-11-06 Thread Thomas Zimmermann
Both functions are unused. Update TODO item and remove them. v2: * reword the whole TODO item * keep a TODO item on drm_fb_helper_init() Thomas Zimmermann (2): drm/todo: Convert drivers to generic fbdev emulation drm/fb-helper: Remove drm_fb_helper_fbdev_{setup,teardown}() D

Re: [PATCH v2] drm/amdgpu: fix double reference dropping

2019-11-06 Thread Koenig, Christian
Am 06.11.19 um 12:35 schrieb Pan Bian: > The reference to object fence is dropped at the end of the loop. > However, it is dropped again outside the loop. The reference can be > dropped immediately after calling dma_fence_wait() in the loop and > thus the dropping operation outside the loop can be

Re: [GIT PULL FOR v5.5 - 2nd try] R-Car DU CMM support

2019-11-06 Thread Laurent Pinchart
Hello, On Wed, Nov 06, 2019 at 11:46:28AM +0100, Jacopo Mondi wrote: > On Wed, Nov 06, 2019 at 12:02:05PM +0200, Laurent Pinchart wrote: > > On Wed, Nov 06, 2019 at 12:00:59PM +0200, Laurent Pinchart wrote: > > > On Wed, Nov 06, 2019 at 01:40:13PM +1000, Dave Airlie wrote: > > > > On Wed, 6 Nov 20

Re: [PATCH v2 3/4] drm/udl: Switch to SHMEM

2019-11-06 Thread Gerd Hoffmann
On Wed, Nov 06, 2019 at 11:47:21AM +0100, Thomas Zimmermann wrote: > Udl's GEM code and the generic SHMEM are almost identical. Replace > the former with SHMEM. The dmabuf support in udl is being replaced > with generic GEM PRIME functions. > > The main difference is in the caching flags for mmap

Re: [PATCH v2 4/4] drm/udl: Remove struct udl_gem_object and functions

2019-11-06 Thread Gerd Hoffmann
On Wed, Nov 06, 2019 at 11:47:22AM +0100, Thomas Zimmermann wrote: > Simply removes all the obsolete GEM code from udl. No functional > changes. > > Signed-off-by: Thomas Zimmermann Acked-by: Gerd Hoffmann > --- > drivers/gpu/drm/udl/Makefile | 2 +- > drivers/gpu/drm/udl/udl_dmabuf.c |

Re: [GIT PULL FOR v5.5 - 2nd try] R-Car DU CMM support

2019-11-06 Thread Laurent Pinchart
Hi Jacopo, On Wed, Nov 06, 2019 at 02:52:25PM +0200, Laurent Pinchart wrote: > On Wed, Nov 06, 2019 at 11:46:28AM +0100, Jacopo Mondi wrote: > > On Wed, Nov 06, 2019 at 12:02:05PM +0200, Laurent Pinchart wrote: > > > On Wed, Nov 06, 2019 at 12:00:59PM +0200, Laurent Pinchart wrote: > > > > On Wed,

Re: [PATCH 2/3] drm/rockchip: add ability to handle external dphys in mipi-dsi

2019-11-06 Thread Laurent Pinchart
Hi Heiko, Thank you for the patch. On Wed, Nov 06, 2019 at 12:26:49PM +0100, Heiko Stuebner wrote: > While the common case is that the dsi controller uses an internal dphy, > accessed through the phy registers inside the dsi controller, there is > also the possibility to use a separate dphy from

Re: [PATCH 3/3] drm/prime: Use anon_drm_getfile() for an internal drm struct file

2019-11-06 Thread Daniel Vetter
On Wed, Nov 6, 2019 at 11:45 AM Chris Wilson wrote: > > Quoting Daniel Vetter (2019-11-06 10:21:57) > > On Wed, Nov 06, 2019 at 10:07:16AM +, Chris Wilson wrote: > > > Currently the drm_prime mmap fallback uses a mock struct file to provide > > > the file pointer into the backend mmap routine.

Re: [Intel-gfx] [PATCH 1/3] drm: Expose a method for creating anonymous struct file around drm_minor

2019-11-06 Thread Daniel Vetter
On Wed, Nov 6, 2019 at 11:43 AM Chris Wilson wrote: > > Quoting Chris Wilson (2019-11-06 10:26:48) > > Quoting Daniel Vetter (2019-11-06 10:19:50) > > > On Wed, Nov 06, 2019 at 10:07:14AM +, Chris Wilson wrote: > > > > Sometimes we need to create a struct file to wrap a drm_device, as it > > >

Re: [PATCH V9 5/6] virtio: introduce a mdev based transport

2019-11-06 Thread Jason Wang
On 2019/11/6 下午7:00, Cornelia Huck wrote: On Wed, 6 Nov 2019 15:05:47 +0800 Jason Wang wrote: This patch introduces a new mdev transport for virtio. This is used to use kernel virtio driver to drive the mediated device that is capable of populating virtqueue directly. A new virtio-mdev driv

Re: [PATCH 3/3] drm/prime: Use anon_drm_getfile() for an internal drm struct file

2019-11-06 Thread Chris Wilson
Quoting Daniel Vetter (2019-11-06 13:06:26) > On Wed, Nov 6, 2019 at 11:45 AM Chris Wilson wrote: > > > > Quoting Daniel Vetter (2019-11-06 10:21:57) > > > On Wed, Nov 06, 2019 at 10:07:16AM +, Chris Wilson wrote: > > > > Currently the drm_prime mmap fallback uses a mock struct file to provide

Re: [PATCH 9/9] drm/ast: Enable atomic modesetting

2019-11-06 Thread Thomas Zimmermann
Hi Am 05.11.19 um 10:57 schrieb Gerd Hoffmann: > On Mon, Oct 28, 2019 at 04:49:28PM +0100, Thomas Zimmermann wrote: >> This commit sets the remaining atomic-modesetting helpers and the flag >> DRIVER_ATOMIC. Legacy cursor functions are removed in favor of the cursor >> plane. For power management,

[PATCH V10 0/6] mdev based hardware virtio offloading support

2019-11-06 Thread Jason Wang
Hi all: There are hardwares that can do virtio datapath offloading while having its own control path. This path tries to implement a mdev based unified API to support using kernel virtio driver to drive those devices. This is done by introducing a new mdev transport for virtio (virtio_mdev) and re

[PATCH V10 1/6] mdev: class id support

2019-11-06 Thread Jason Wang
Mdev bus only supports vfio driver right now, so it doesn't implement match method. But in the future, we may add drivers other than vfio, the first driver could be virtio-mdev. This means we need to add device class id support in bus match method to pair the mdev device and mdev driver correctly.

[PATCH V10 2/6] modpost: add support for mdev class id

2019-11-06 Thread Jason Wang
Add support to parse mdev class id table. Reviewed-by: Parav Pandit Reviewed-by: Cornelia Huck Signed-off-by: Jason Wang --- drivers/vfio/mdev/vfio_mdev.c | 2 ++ scripts/mod/devicetable-offsets.c | 3 +++ scripts/mod/file2alias.c | 11 +++ 3 files changed, 16 insertions

[PATCH V10 4/6] mdev: introduce virtio device and its device ops

2019-11-06 Thread Jason Wang
This patch implements basic support for mdev driver that supports virtio transport for kernel virtio driver. Reviewed-by: Cornelia Huck Signed-off-by: Jason Wang --- MAINTAINERS | 1 + drivers/vfio/mdev/mdev_core.c| 21 + drivers/vfio/mdev/mdev_private.h | 2 +

[PATCH V10 3/6] mdev: introduce device specific ops

2019-11-06 Thread Jason Wang
Currently, except for the create and remove, the rest of mdev_parent_ops is designed for vfio-mdev driver only and may not help for kernel mdev driver. With the help of class id, this patch introduces device specific callbacks inside mdev_device structure. This allows different set of callback to b

[PATCH V10 5/6] virtio: introduce a mdev based transport

2019-11-06 Thread Jason Wang
This patch introduces a new mdev transport for virtio. This is used to use kernel virtio driver to drive the mediated device that is capable of populating virtqueue directly. A new virtio-mdev driver will be registered to the mdev bus, when a new virtio-mdev device is probed, it will register the

[PATCH V10 6/6] docs: sample driver to demonstrate how to implement virtio-mdev framework

2019-11-06 Thread Jason Wang
This sample driver creates mdev device that simulate virtio net device over virtio mdev transport. The device is implemented through vringh and workqueue. A device specific dma ops is to make sure HVA is used directly as the IOVA. This should be sufficient for kernel virtio driver to work. Only 'v

[Bug 111481] AMD Navi GPU frequent freezes on both Manjaro/Ubuntu with kernel 5.3 and mesa 19.2 -git/llvm9

2019-11-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111481 --- Comment #212 from wychuchol --- (In reply to Marco Liedtke from comment #211) > > I have already set AMD_DEBUG=nodam in /etc/environment and in ~/.profile. > Last time i played World of Tanks via Wine and DXVK the same freeze occured, > aga

Re: [PATCH v15 1/5] dma-buf: Add dma-buf heaps framework

2019-11-06 Thread Andrew F. Davis
On 11/5/19 11:22 PM, John Stultz wrote: > From: "Andrew F. Davis" > > This framework allows a unified userspace interface for dma-buf > exporters, allowing userland to allocate specific types of memory > for use in dma-buf sharing. > > Each heap is given its own device node, which a user can all

Re: [PATCH v6 8/9] drm: Add macro to export functions only when CONFIG_DRM_DEBUG_SELFTEST is enabled

2019-11-06 Thread Chris Wilson
Quoting Alexandru-Cosmin Gheorghe (2018-10-29 17:14:43) > If we want to be able to write drmselftests for non-static core > functions that are not intended to be used by drivers we need this > functions to be exported. > > This adds a macro that is tied of CONFIG_DRM_DEBUG_SELFTEST, and uses > tha

[PATCH v2 2/4] drm/i915/selftests: Replace mock_file hackery with drm's true fake

2019-11-06 Thread Chris Wilson
As drm now exports a method to create an anonymous struct file around a drm_device for internal use, make use of it to avoid our horrible hacks. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/Kconfig.debug| 2 + .../gpu/drm/i915/gem/selftests/huge_pages.c | 2 +- .../drm/i9

[PATCH v2 1/4] drm: Expose a method for creating anonymous struct file around drm_minor

2019-11-06 Thread Chris Wilson
Sometimes we need to create a struct file to wrap a drm_device, as it the user were to have opened /dev/dri/card0 but to do so anonymously (i.e. for internal use). Provide a utility method to create a struct file with the drm_device->driver.fops, that wrap the drm_device. v2: Restrict usage to sel

[PATCH v2 4/4] drm/i915/selftests: Verify mmap_gtt revocation on unbinding

2019-11-06 Thread Chris Wilson
Whenever, we unbind (or change fence registers) on an object, we must revoke any and all mmap_gtt using the previous bindings. Those user PTEs point at the GGTT which know points into a new object, the wrong object. Ergo, those PTEs must be cleared so that any user access provokes a new page fault.

[PATCH v2 3/4] drm/i915/selftests: Wrap vm_mmap() around GEM objects

2019-11-06 Thread Chris Wilson
Provide a utility function to create a vma corresponding to an mmap() of our device. And use it to exercise the equivalent of userspace performing a GTT mmap of our objects. Signed-off-by: Chris Wilson Cc: Abdiel Janulgue --- drivers/gpu/drm/i915/Makefile | 1 + .../drm/i915/ge

Re: [PATCH V10 0/6] mdev based hardware virtio offloading support

2019-11-06 Thread Cornelia Huck
On Wed, 6 Nov 2019 21:35:25 +0800 Jason Wang wrote: > Hi all: > > There are hardwares that can do virtio datapath offloading while > having its own control path. This path tries to implement a mdev based > unified API to support using kernel virtio driver to drive those > devices. This is done

Re: [PATCH v2 1/2] drm/todo: Convert drivers to generic fbdev emulation

2019-11-06 Thread Noralf Trønnes
Den 06.11.2019 13.47, skrev Thomas Zimmermann: > This replaces the original TODO item for drm_fb_helper_fbdev_setup() > and _teardown(), which are deprecated. > > v2: > * remove driver-specific comments > * list some basic requirements > * keep a TODO item on drm_fb_helper_init

Re: [PATCH v2 1/4] drm: Expose a method for creating anonymous struct file around drm_minor

2019-11-06 Thread Daniel Vetter
On Wed, Nov 06, 2019 at 01:57:36PM +, Chris Wilson wrote: > Sometimes we need to create a struct file to wrap a drm_device, as it > the user were to have opened /dev/dri/card0 but to do so anonymously > (i.e. for internal use). Provide a utility method to create a struct > file with the drm_dev

[PATCH v3 1/5] drm: Move EXPORT_SYMBOL_FOR_TESTS_ONLY under a separate Kconfig

2019-11-06 Thread Chris Wilson
Currently, we only export symbols for drm-selftests which are either compiled as modules or into the main drm builtin. However, if we want to export symbols from drm.ko for the drivers' selftests, we require a means of controlling that export separately. So we add a new Kconfig to determine whether

[PATCH v3 2/5] drm: Expose a method for creating anonymous struct file around drm_minor

2019-11-06 Thread Chris Wilson
Sometimes we need to create a struct file to wrap a drm_device, as it the user were to have opened /dev/dri/card0 but to do so anonymously (i.e. for internal use). Provide a utility method to create a struct file with the drm_device->driver.fops, that wrap the drm_device. v2: Restrict usage to sel

[PATCH v3 3/5] drm/i915/selftests: Replace mock_file hackery with drm's true fake

2019-11-06 Thread Chris Wilson
As drm now exports a method to create an anonymous struct file around a drm_device for internal use, make use of it to avoid our horrible hacks. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/Kconfig.debug| 2 + .../gpu/drm/i915/gem/selftests/huge_pages.c | 2 +- .../drm/i9

  1   2   3   >