Re: Overlay support in the i.MX7 display

2019-11-04 Thread Pekka Paalanen
On Sun, 03 Nov 2019 19:15:49 +0100 Stefan Agner wrote: > Hi Laurent, > > On 2019-11-01 09:43, Laurent Pinchart wrote: > > Hello, > > > > I'm looking at the available options to support overlays in the display > > pipeline of the i.MX7. The LCDIF itself unfortunaltey doesn't support > > overlays

Re: [PATCH v14 0/5] DMA-BUF Heaps (destaging ION)

2019-11-04 Thread Pekka Paalanen
On Fri, 1 Nov 2019 21:42:33 + John Stultz wrote: > This again? I know! > > Apologies to all who hoped I'd stop bothering them with this > patch set, but I ran afoul of the DRM tree rules by not > getting the userland patches properly reviewed prior to the > patches landing (I mistakenly was

Re: [PATCH 1/4] drm: bridge: dw_mipi_dsi: access registers via a regmap

2019-11-04 Thread Neil Armstrong
On 31/10/2019 15:26, Adrian Ratiu wrote: > Convert the common bridge code and the two rockchip & stm drivers > which currently use it to the regmap API in anticipation for further > changes to make it more generic and add older DSI host controller > support as found on i.mx6 based devices. > > No

Re: [PATCH V6 2/8] backlight: qcom-wled: restructure the qcom-wled bindings

2019-11-04 Thread Pavel Machek
Hi! > If you're going to apply them, you need to send out an immutable > branch for me to pull from. Aha, its backlight, not LED. I really should not be taking those. Sorry for the noise, I dropped them from my tree. Best regards,

Re: [PATCH 2/4] dt-bindings: display: bridge: Repurpose lvds-encoder

2019-11-04 Thread Neil Armstrong
Hi, On 30/10/2019 14:43, Fabrizio Castro wrote: > In an effort to repurpose lvds-encoder.c to also serve the > function of LVDS decoders, we ended up defining a new "generic" > compatible string, therefore adapt the dt-bindings to fit the > new purpose. You should convert it to dt-schemas in thi

Re: [PATCH 1/4] drm/bridge: Repurpose lvds-encoder.c

2019-11-04 Thread Neil Armstrong
Hi, On 30/10/2019 14:43, Fabrizio Castro wrote: > lvds-encoder.c implementation is also suitable for LVDS decoders, > not just LVDS encoders. > Instead of creating a new driver for addressing support for > transparent LVDS decoders, repurpose lvds-encoder.c for the greater > good. > > Signed-off-

Re: [Intel-gfx] [PATCH] drm/fbdev: Fallback to non tiled mode if all tiles not present

2019-11-04 Thread Daniel Vetter
On Thu, Oct 31, 2019 at 02:48:39PM -0700, Manasi Navare wrote: > In case of tiled displays, if we hotplug just one connector, > fbcon currently just selects the preferred mode and if it is > tiled mode then that becomes a problem if rest of the tiles are > not present. > So in the fbdev driver on h

Re: [RFC][PATCH 2/2] dma-buf: heaps: Allow system & cma heaps to be configured as a modules

2019-11-04 Thread Brian Starkey
Hi John, On Fri, Oct 25, 2019 at 11:48:34PM +, John Stultz wrote: > Allow loading system and cma heap as a module instead of just as > a statically built in heap. > > Since there isn't a good mechanism for dmabuf lifetime tracking > it isn't safe to allow the heap drivers to be unloaded, so t

Re: [PATCH v2] fbdev: c2p: Fix link failure on non-inlining

2019-11-04 Thread Daniel Vetter
On Mon, Nov 04, 2019 at 08:43:07AM +0100, Geert Uytterhoeven wrote: > Hi Bartlomiej, Andrew, > > On Fri, Sep 27, 2019 at 11:47 AM Geert Uytterhoeven > wrote: > > When the compiler decides not to inline the Chunky-to-Planar core > > functions, the build fails with: > > > > c2p_planar.c:(.text+

Re: [PATCH 1/2] drm/fb-helper: Remove drm_fb_helper_defio_init() and update docs

2019-11-04 Thread Daniel Vetter
On Mon, Oct 28, 2019 at 09:13:47AM +0100, Thomas Zimmermann wrote: > Hi > > Am 25.10.19 um 20:54 schrieb Daniel Vetter: > > On Fri, Oct 25, 2019 at 7:26 PM Thomas Zimmermann > > wrote: > >> > >> Hi > >> > >> Am 25.10.19 um 17:46 schrieb Noralf Trønnes: > >>> > >>> > >>> Den 25.10.2019 11.27, skr

Re: [RFC][PATCH 0/2] Allow DMA BUF heaps to be loaded as modules

2019-11-04 Thread Daniel Vetter
On Fri, Oct 25, 2019 at 11:48:32PM +, John Stultz wrote: > Now that the DMA BUF heaps core code has been queued, I wanted > to send out some of the pending changes that I've been working > on. > > For use with Android and their GKI effort, it is desired that > DMA BUF heaps are able to be load

Re: [PATCH v14 1/5] dma-buf: Add dma-buf heaps framework

2019-11-04 Thread Brian Starkey
Hi John, On Fri, Nov 01, 2019 at 09:42:34PM +, John Stultz wrote: > From: "Andrew F. Davis" > > This framework allows a unified userspace interface for dma-buf > exporters, allowing userland to allocate specific types of memory > for use in dma-buf sharing. > > Each heap is given its own de

Re: [RFC][PATCH 2/2] dma-buf: heaps: Allow system & cma heaps to be configured as a modules

2019-11-04 Thread Daniel Vetter
On Fri, Oct 25, 2019 at 11:48:34PM +, John Stultz wrote: > Allow loading system and cma heap as a module instead of just as > a statically built in heap. > > Since there isn't a good mechanism for dmabuf lifetime tracking > it isn't safe to allow the heap drivers to be unloaded, so these > dri

Re: [PATCH v3] drm/tegra: Do not use ->load() and ->unload() callbacks

2019-11-04 Thread Daniel Vetter
On Mon, Oct 28, 2019 at 01:16:10PM +0100, Thierry Reding wrote: > From: Thierry Reding > > The ->load() and ->unload() drivers are midlayers and should be avoided > in modern drivers. Fix this by moving the code into the driver ->probe() > and ->remove() implementations, respectively. > > v2: ki

Re: Proposal to report GPU private memory allocations with sysfs nodes

2019-11-04 Thread Daniel Vetter
On Mon, Oct 28, 2019 at 11:07:28AM -0400, Sean Paul wrote: > On Mon, Oct 28, 2019 at 10:56 AM Jordan Crouse wrote: > > > > On Mon, Oct 28, 2019 at 08:47:58AM -0600, Jordan Crouse wrote: > > > On Wed, Oct 23, 2019 at 11:00:58AM -0700, Yiwei Zhang wrote: > > > > Hi folks, > > > > > > > > This is Yiw

Re: drm/amd/display: Add HDCP module - static analysis bug report

2019-11-04 Thread Daniel Vetter
On Wed, Oct 9, 2019 at 10:58 PM Daniel Vetter wrote: > On Wed, Oct 9, 2019 at 10:46 PM Lakha, Bhawanpreet > wrote: > > > > I misunderstood and was talking about the ksv validation specifically > > (usage of drm_hdcp_check_ksvs_revoked()). > > Hm for that specifically I think you want to do both,

Re: [PATCH 1/2] drm/atomic: fix self-refresh helpers crtc state dereference

2019-11-04 Thread Maarten Lankhorst
Op 01-11-2019 om 21:06 schreef Sean Paul: > On Fri, Nov 1, 2019 at 2:09 PM Rob Clark wrote: >> From: Rob Clark >> >> drm_self_refresh_helper_update_avg_times() was incorrectly accessing the >> new incoming state after drm_atomic_helper_commit_hw_done(). But this >> state might have already been

Re: [PATCH 1/4] drm: bridge: dw_mipi_dsi: access registers via a regmap

2019-11-04 Thread Adrian Ratiu
On Mon, 04 Nov 2019, Neil Armstrong wrote: On 31/10/2019 15:26, Adrian Ratiu wrote: Convert the common bridge code and the two rockchip & stm drivers which currently use it to the regmap API in anticipation for further changes to make it more generic and add older DSI host controller support

Re: [PATCH v2] drm/sched: Fix passing zero to 'PTR_ERR' warning

2019-11-04 Thread Christian König
Reviewed-by: Christian König Am 04.11.19 um 04:37 schrieb Deng, Emily: Reviewed-by: Emily Deng -Original Message- From: amd-gfx On Behalf Of Andrey Grodzovsky Sent: Wednesday, October 30, 2019 2:08 AM To: dan.carpen...@oracle.com Cc: Grodzovsky, Andrey ; amd- g...@lists.freedesktop.

[PATCH V7 1/6] mdev: class id support

2019-11-04 Thread Jason Wang
Mdev bus only supports vfio driver right now, so it doesn't implement match method. But in the future, we may add drivers other than vfio, the first driver could be virtio-mdev. This means we need to add device class id support in bus match method to pair the mdev device and mdev driver correctly.

[PATCH V7 2/6] modpost: add support for mdev class id

2019-11-04 Thread Jason Wang
Add support to parse mdev class id table. Reviewed-by: Parav Pandit Signed-off-by: Jason Wang --- drivers/vfio/mdev/vfio_mdev.c | 2 ++ scripts/mod/devicetable-offsets.c | 3 +++ scripts/mod/file2alias.c | 11 +++ 3 files changed, 16 insertions(+) diff --git a/drivers/vf

[PATCH V7 6/6] docs: sample driver to demonstrate how to implement virtio-mdev framework

2019-11-04 Thread Jason Wang
This sample driver creates mdev device that simulate virtio net device over virtio mdev transport. The device is implemented through vringh and workqueue. A device specific dma ops is to make sure HVA is used directly as the IOVA. This should be sufficient for kernel virtio driver to work. Only 'v

[Bug 111482] Sapphire Pulse RX 5700 XT power consumption

2019-11-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111482 --- Comment #31 from Shmerl --- I can confirm, that at 2560x1440 / 144 Hz, after suspend / resume, setting "high" in /sys/class/drm/card0/device/power_dpm_force_performance_level stops flickering that starts after resume, and then setting "low"

Re: Overlay support in the i.MX7 display

2019-11-04 Thread Laurent Pinchart
Hello, On Mon, Nov 04, 2019 at 10:09:47AM +0200, Pekka Paalanen wrote: > On Sun, 03 Nov 2019 19:15:49 +0100 Stefan Agner wrote: > > On 2019-11-01 09:43, Laurent Pinchart wrote: > > > Hello, > > > > > > I'm looking at the available options to support overlays in the display > > > pipeline of the i

[Bug 111240] ASUS TUF Gaming laptops gets throttled down when the RX560X GPU is being used

2019-11-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111240 --- Comment #8 from Jacek Konieczny --- Looks like it is not amdgpu bug, but a faulty cooling algorithm implemented in BIOS/hardware (reportedly the same happens on Windows before dedicated ASUS software is installed). I was able to make things

[Bug 109628] WARNING at dcn10_hw_sequencer.c:868 dcn10_verify_allow_pstate_change_high()

2019-11-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109628 Jiri Slaby changed: What|Removed |Added CC||b...@atomicbee.cz --- Comment #31 from Jir

[Bug 111487] AMD vega - display off/on -> solid green display

2019-11-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111487 Jiri Slaby changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Bug 110580] [CI][BAT] igt@.* - skip - Chamelium ports not enabled

2019-11-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110580 Arek Hiler changed: What|Removed |Added QA Contact|intel-gfx-bugs@lists.freede | |sktop.org

[Bug 111229] Unable to unbind GPU from amdgpu

2019-11-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111229 --- Comment #12 from Andrew B --- Fedora 31, 5.3.1 kernel, 5700XT - still seeing problems with unbinding from the AMDGPU driver. I have video=efifb:off in my kernel parameters to keep the efifb from ever using the card. After stopping X and

[Bug 111229] Unable to unbind GPU from amdgpu

2019-11-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111229 --- Comment #13 from Andrew B --- My comment above should have reference 5.3.7 as the kernel version. -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailing li

[Bug 205393] [amdgpu powerplay] vega10: custom pp_table, AVFS accidentally reenabled after display powersave

2019-11-04 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=205393 har...@gmx.de changed: What|Removed |Added Attachment #285757|0 |1 is obsolete|

Re: [PATCH v2 1/2] drm: Add support for DP 1.4 Compliance edid corruption test 4.2.2.6

2019-11-04 Thread Jani Nikula
On Fri, 01 Nov 2019, "Jerry (Fangzhi) Zuo" wrote: > DP 1.4 edid corruption test requires source DUT to write calculated > CRC, not the corrupted CRC from reference sink. > > Return the calculated CRC back, and initiate the required sequence. > > -v2: Have separate routine for returning real CRC >

[Bug 205393] [amdgpu powerplay] vega10: custom pp_table, AVFS accidentally reenabled after display powersave

2019-11-04 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=205393 har...@gmx.de changed: What|Removed |Added CC||alexdeuc...@gmail.com Kernel Version|

Re: [PATCH v2 1/5] drm/dsi: clean up DSI data type definitions

2019-11-04 Thread Jani Nikula
Hi all, I'd really appreciate some (non-Intel) acks or reviews on this series. Don't feel comfortable merging it otherwise. It should be fairly straightforward stuff as long as you have some DSI specs handy. BR, Jani. On Mon, 28 Oct 2019, Jani Nikula wrote: > Rename picture parameter set (it's

Re: [PATCH v2] drm/doc: Adding VKMS module description and use to "Testing and Validation"

2019-11-04 Thread Rodrigo Siqueira
Hi Gabriela, Thank you very much for working on improving our documentation. For me the patch looks good, I just have some nitpick. First, it is recommended to use an imperative mood in the subject line. Try something like this: Add VKMS module description under "Testing and Validation" sectio

Re: [Intel-gfx] [PATCH v2 1/5] drm/dsi: clean up DSI data type definitions

2019-11-04 Thread Thierry Reding
On Mon, Oct 28, 2019 at 05:00:43PM +0200, Jani Nikula wrote: > Rename picture parameter set (it's a long packet, not a long write) and > compression mode (it's not a DCS command) enumerations according to the > DSI specification. Order the types according to the spec. Use tabs > instead of spaces f

Re: drm/amd/display: Add HDCP module - static analysis bug report

2019-11-04 Thread Harry Wentland
On 2019-11-04 5:53 a.m., Daniel Vetter wrote: > On Wed, Oct 9, 2019 at 10:58 PM Daniel Vetter wrote: >> On Wed, Oct 9, 2019 at 10:46 PM Lakha, Bhawanpreet >> wrote: >>> >>> I misunderstood and was talking about the ksv validation specifically >>> (usage of drm_hdcp_check_ksvs_revoked()). >> >> Hm

Re: [PATCH v2 2/5] drm/dsi: add missing DSI data types

2019-11-04 Thread Thierry Reding
On Mon, Oct 28, 2019 at 05:00:44PM +0200, Jani Nikula wrote: > Add execute queue and compressed pixel stream packet data types for > completeness. > > Cc: Vandita Kulkarni > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/drm_mipi_dsi.c | 2 ++ > include/video/mipi_display.h | 2 ++ > 2 fi

Re: [Intel-gfx] [PATCH v2 3/5] drm/dsi: add missing DSI DCS commands

2019-11-04 Thread Thierry Reding
On Mon, Oct 28, 2019 at 05:00:45PM +0200, Jani Nikula wrote: > Update from the DCS specification. > > Cc: Vandita Kulkarni > Signed-off-by: Jani Nikula > --- > include/video/mipi_display.h | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/include/video/mipi_display.h b/inclu

[PATCH] drm/mcde: Drop double-assignment of mcde

2019-11-04 Thread Linus Walleij
It's enough to assign the member once. Cc: Markus Elfring Reported-by: Markus Elfring Signed-off-by: Linus Walleij --- drivers/gpu/drm/mcde/mcde_drv.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/mcde/mcde_drv.c b/drivers/gpu/drm/mcde/mcde_drv.c index 9a09eba53182..31ab3c

Re: [PATCH 1/4] drm: bridge: dw_mipi_dsi: access registers via a regmap

2019-11-04 Thread Neil Armstrong
Hi Adrian, On 04/11/2019 13:03, Adrian Ratiu wrote: > On Mon, 04 Nov 2019, Neil Armstrong wrote: >> On 31/10/2019 15:26, Adrian Ratiu wrote: >> >> OK for the dw-mipi-dsi changes, but why should the dw_mipi_dsi-stm be >> changed aswell ? >> AFAIK these are independent. > > I don't understand how

Re: [PATCH 1/4] drm/bridge: Repurpose lvds-encoder.c

2019-11-04 Thread Neil Armstrong
Hi, On 04/11/2019 11:42, Fabrizio Castro wrote: > Hi Neil, > > Thank you for your feedback! > >> From: Neil Armstrong >> Sent: 04 November 2019 09:18 >> Subject: Re: [PATCH 1/4] drm/bridge: Repurpose lvds-encoder.c >> >> Hi, >> >> On 30/10/2019 14:43, Fabrizio Castro wrote: >>> lvds-encoder.c i

Re: [PATCH v2 VKMS 0/2] drm/vkms: Changing some words in 'blend' function documentation

2019-11-04 Thread Rodrigo Siqueira
Hi Gabriela, In the case of this series and the patch "drm/vkms: Fix typo in function documentation", I recommend you to use a single patch. In general, If your changes produce a lot of deltas, you need to split them into individual patches that modify things in logical stages. In these patches, y

Re: drm/amd/display: Add HDCP module - static analysis bug report

2019-11-04 Thread Lakha, Bhawanpreet
Hi Daniel, I have the patches prepared but they needed some testing before I send them (code needed a slight refactor to use the drm_hdcp.h), I should be able to send the patches this week. Thanks, Bhawan On 2019-11-04 10:23 a.m., Wentland, Harry wrote: > On 2019-11-04 5:53 a.m., Daniel Vett

[Bug 111763] ring_gfx hangs/freezes on Navi gpus

2019-11-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111763 --- Comment #20 from wychuchol --- Barely started PC, opened palemoon, curse move only hang and then dozens of graphical artifacts on screen like square patches of glitches. Nov 3 13:15:10 pop-os kernel: [ 133.998883] [drm:amdgpu_dm_commit_p

[Bug 111763] ring_gfx hangs/freezes on Navi gpus

2019-11-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111763 --- Comment #21 from Marko Popovic --- (In reply to wychuchol from comment #20) > Barely started PC, opened palemoon, curse move only hang and then dozens of > graphical artifacts on screen like square patches of glitches. > > Nov 3 13:15:10

[Bug 111481] AMD Navi GPU frequent freezes on both Manjaro/Ubuntu with kernel 5.3 and mesa 19.2 -git/llvm9

2019-11-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111481 --- Comment #197 from wychuchol --- Despite the 'fix' I posted in comment 193 AER PCI bus errors still happen, and autonomous resets happen as well. I think it's less frequent though. Still it's difficult to say for sure or put in a precise valu

[PATCH VKMS v3] drm/vkms: Fix typo and preposion in function documentation

2019-11-04 Thread Gabriela Bittencourt
Fix typo in word 'blend' and in the word 'destination' and change preposition 'at' to 'of' in function 'blend' documentation. And change the task introduction word 'Todo' for the word all in uppercase - 'TODO'. With the TODO word all in uppercase (as it's the standard) it's easier to find the tasks

[Bug 111481] AMD Navi GPU frequent freezes on both Manjaro/Ubuntu with kernel 5.3 and mesa 19.2 -git/llvm9

2019-11-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111481 --- Comment #198 from Shmerl --- (In reply to wychuchol from comment #197) > Despite the 'fix' I posted in comment 193 AER PCI bus errors still happen, > and autonomous resets happen as well. I think it's less frequent though. > Still it's diffi

[PATCH VKMS v3] drm/doc: Add VKMS module description and use to "Testing and Validation"

2019-11-04 Thread Gabriela Bittencourt
Add a description on VKMS module and the cases in which it should be used. There's a brief explanation on how to set it and use it in a VM, along with an example of running an igt-test. Changes since V3: Rodrigo: - Change the log message to imperative - Fix some bad spelling/writing - Add a bl

[Bug 111482] Sapphire Pulse RX 5700 XT power consumption

2019-11-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111482 --- Comment #32 from Dieter Nützel --- (In reply to Shmerl from comment #31) > I can confirm, that at 2560x1440 / 144 Hz, after suspend / resume, setting > "high" in /sys/class/drm/card0/device/power_dpm_force_performance_level > stops flickerin

Re: [PATCH v2 01/18] mm/gup: pass flags arg to __gup_device_* functions

2019-11-04 Thread Jerome Glisse
On Sun, Nov 03, 2019 at 01:17:56PM -0800, John Hubbard wrote: > A subsequent patch requires access to gup flags, so > pass the flags argument through to the __gup_device_* > functions. > > Also placate checkpatch.pl by shortening a nearby line. > > Reviewed-by: Ira Weiny > Cc: Kirill A. Shutemov

[Bug 111482] Sapphire Pulse RX 5700 XT power consumption

2019-11-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111482 --- Comment #33 from Shmerl --- (In reply to Dieter Nützel from comment #32) > > Hello 'Shmerl', > > can you (and the other) please recheck with 'auto', too? > I think we have the 'same' problem with Polaris, too. Can you clarify please, what

Re: [PATCH v2 02/18] mm/gup: factor out duplicate code from four routines

2019-11-04 Thread Jerome Glisse
On Sun, Nov 03, 2019 at 01:17:57PM -0800, John Hubbard wrote: > There are four locations in gup.c that have a fair amount of code > duplication. This means that changing one requires making the same > changes in four places, not to mention reading the same code four > times, and wondering if there

Re: [PATCH v2 03/18] goldish_pipe: rename local pin_user_pages() routine

2019-11-04 Thread Jerome Glisse
On Sun, Nov 03, 2019 at 01:17:58PM -0800, John Hubbard wrote: > 1. Avoid naming conflicts: rename local static function from > "pin_user_pages()" to "pin_goldfish_pages()". > > An upcoming patch will introduce a global pin_user_pages() > function. > > Reviewed-by: Ira Weiny > Signed-off-by: John

Re: drm/amd/display: Add HDCP module - static analysis bug report

2019-11-04 Thread Daniel Vetter
On Mon, Nov 04, 2019 at 03:23:09PM +, Harry Wentland wrote: > On 2019-11-04 5:53 a.m., Daniel Vetter wrote: > > On Wed, Oct 9, 2019 at 10:58 PM Daniel Vetter wrote: > >> On Wed, Oct 9, 2019 at 10:46 PM Lakha, Bhawanpreet > >> wrote: > >>> > >>> I misunderstood and was talking about the ksv va

FOSDEM Graphics Devroom: call for speakers.

2019-11-04 Thread Luc Verhaegen
Hi, At FOSDEM on saturday the 1st of february 2020, there will be another graphics DevRoom. URL: https://fosdem.org/2020/ The focus of this DevRoom is: * Graphics drivers: from display to media to 3d drivers, both in bootloaders, kernel or userspace. Be it part of DRM, KMS, V4L, (direct)FB, Xo

Re: [Intel-gfx] [PATCH 2/2] drm/todo: Add entry to remove load/unload hooks

2019-11-04 Thread Daniel Vetter
On Thu, Oct 24, 2019 at 12:35:52PM +0200, Thierry Reding wrote: > On Wed, Oct 23, 2019 at 04:49:53PM +0200, Daniel Vetter wrote: > > They're midlayer, broken, and because of the old gunk, we can't fix > > them. For examples see the various checks in drm_mode_object.c against > > dev->registered, wh

Re: [PATCH v14 1/5] dma-buf: Add dma-buf heaps framework

2019-11-04 Thread Dave Airlie
On Mon, 4 Nov 2019 at 20:24, Brian Starkey wrote: > > Hi John, > > On Fri, Nov 01, 2019 at 09:42:34PM +, John Stultz wrote: > > From: "Andrew F. Davis" > > > > This framework allows a unified userspace interface for dma-buf > > exporters, allowing userland to allocate specific types of memory

Re: [PATCH] drm/scdc: Fix typo in bit definition of SCDC_STATUS_FLAGS

2019-11-04 Thread Patrik Jakobsson
On Tue, Oct 22, 2019 at 5:53 PM Patrik Jakobsson wrote: > > On Tue, Oct 22, 2019 at 11:51 AM Jani Nikula > wrote: > > > > On Tue, 22 Oct 2019, Thierry Reding wrote: > > > On Tue, Oct 22, 2019 at 11:16:51AM +0300, Jani Nikula wrote: > > >> On Wed, 16 Oct 2019, Patrik Jakobsson > > >> wrote: > >

Re: drm/amd/display: Add HDCP module - static analysis bug report

2019-11-04 Thread Alex Deucher
On Mon, Nov 4, 2019 at 11:55 AM Daniel Vetter wrote: > > On Mon, Nov 04, 2019 at 03:23:09PM +, Harry Wentland wrote: > > On 2019-11-04 5:53 a.m., Daniel Vetter wrote: > > > On Wed, Oct 9, 2019 at 10:58 PM Daniel Vetter wrote: > > >> On Wed, Oct 9, 2019 at 10:46 PM Lakha, Bhawanpreet > > >> w

Re: drm/amd/display: Add HDCP module - static analysis bug report

2019-11-04 Thread Daniel Vetter
On Mon, Nov 04, 2019 at 12:05:40PM -0500, Alex Deucher wrote: > On Mon, Nov 4, 2019 at 11:55 AM Daniel Vetter wrote: > > > > On Mon, Nov 04, 2019 at 03:23:09PM +, Harry Wentland wrote: > > > On 2019-11-04 5:53 a.m., Daniel Vetter wrote: > > > > On Wed, Oct 9, 2019 at 10:58 PM Daniel Vetter wr

Re: [PATCH v2 2/3] drm: Measure Self Refresh Entry/Exit times to avoid thrashing

2019-11-04 Thread Enric Balletbo Serra
Missatge de Enric Balletbo Serra del dia dc., 30 d’oct. 2019 a les 17:59: > > Hi Sean, > > Since 5.4-rc1 my Samsung Chromebook Plus (kevin) doesn't > suspend/resume correctly, at least once every ten suspend/resume > cycles the display doesn't turn on, and when this happens the kernel > log messag

Re: [PATCH v2 05/18] mm/gup: introduce pin_user_pages*() and FOLL_PIN

2019-11-04 Thread Jerome Glisse
On Sun, Nov 03, 2019 at 01:18:00PM -0800, John Hubbard wrote: > Introduce pin_user_pages*() variations of get_user_pages*() calls, > and also pin_longterm_pages*() variations. > > These variants all set FOLL_PIN, which is also introduced, and > thoroughly documented. > > The pin_longterm*() varia

[PATCH 3/3] drm/ttm: remove ttm_bo_wait_unreserved

2019-11-04 Thread Daniel Vetter
With nouveau fixed all ttm-using drives have the correct nesting of mmap_sem vs dma_resv, and we can just lock the buffer. Assuming I didn't screw up anything with my audit of course. v2: - Dont forget wu_mutex (Christian König) - Keep the mmap_sem-less wait optimization (Thomas) - Use _lock_inte

[PATCH 2/3] drm/nouveau: slowpath for pushbuf ioctl

2019-11-04 Thread Daniel Vetter
We can't copy_*_user while holding reservations, that will (soon even for nouveau) lead to deadlocks. And it breaks the cross-driver contract around dma_resv. Fix this by adding a slowpath for when we need relocations, and by pushing the writeback of the new presumed offsets to the very end. Asid

[PATCH 1/3] dma_resv: prime lockdep annotations

2019-11-04 Thread Daniel Vetter
Full audit of everyone: - i915, radeon, amdgpu should be clean per their maintainers. - vram helpers should be fine, they don't do command submission, so really no business holding struct_mutex while doing copy_*_user. But I haven't checked them all. - panfrost seems to dma_resv_lock only in

[PATCH 1/2 v2] drm/atomic: fix self-refresh helpers crtc state dereference

2019-11-04 Thread Rob Clark
From: Rob Clark drm_self_refresh_helper_update_avg_times() was incorrectly accessing the new incoming state after drm_atomic_helper_commit_hw_done(). But this state might have already been superceeded by an !nonblock atomic update resulting in dereferencing an already free'd crtc_state. TODO I

Re: [PATCH] drm/vkms: Update VKMS documentation

2019-11-04 Thread Daniel Vetter
On Fri, Nov 01, 2019 at 07:37:35PM -0300, Gabriela Bittencourt wrote: > Small changes in the driver documentation, clarifing the description. > > Signed-off-by: Gabriela Bittencourt lgtm, applied. -Daniel > > --- > > Tested using: make htmldocs > --- > drivers/gpu/drm/vkms/vkms_drv.c | 8 +++

[PATCH 2/2 v2] drm/atomic: clear new_state pointers at hw_done

2019-11-04 Thread Rob Clark
From: Rob Clark The new state should not be accessed after this point. Clear the pointers to make that explicit. Signed-off-by: Rob Clark --- drivers/gpu/drm/drm_atomic_helper.c | 30 + 1 file changed, 30 insertions(+) diff --git a/drivers/gpu/drm/drm_atomic_helpe

Re: [PATCH v2 08/18] mm/process_vm_access: set FOLL_PIN via pin_user_pages_remote()

2019-11-04 Thread Jerome Glisse
On Sun, Nov 03, 2019 at 01:18:03PM -0800, John Hubbard wrote: > Convert process_vm_access to use the new pin_user_pages_remote() > call, which sets FOLL_PIN. Setting FOLL_PIN is now required for > code that requires tracking of pinned pages. > > Also, release the pages via put_user_page*(). > > A

Re: [PATCH v2] drm: sun4i: Add support for suspending the display driver

2019-11-04 Thread Daniel Vetter
On Tue, Oct 29, 2019 at 12:28:46PM +0100, Ondrej Jirman wrote: > Shut down the display engine during suspend. > > Signed-off-by: Ondrej Jirman > --- > Changes in v2: > - spaces -> tabs > > drivers/gpu/drm/sun4i/sun4i_drv.c | 22 ++ > 1 file changed, 22 insertions(+) > > dif

Re: [PATCH v14 1/5] dma-buf: Add dma-buf heaps framework

2019-11-04 Thread Brian Starkey
Hi Dave, On Tue, Nov 05, 2019 at 02:58:17AM +1000, Dave Airlie wrote: > On Mon, 4 Nov 2019 at 20:24, Brian Starkey wrote: > > > > Hi John, > > > > On Fri, Nov 01, 2019 at 09:42:34PM +, John Stultz wrote: > > > From: "Andrew F. Davis" > > > > > > This framework allows a unified userspace inte

Re: [PATCH v2 09/18] drm/via: set FOLL_PIN via pin_user_pages_fast()

2019-11-04 Thread Jerome Glisse
On Sun, Nov 03, 2019 at 01:18:04PM -0800, John Hubbard wrote: > Convert drm/via to use the new pin_user_pages_fast() call, which sets > FOLL_PIN. Setting FOLL_PIN is now required for code that requires > tracking of pinned pages, and therefore for any code that calls > put_user_page(). > > Reviewe

Re: [PATCH 1/3] dma_resv: prime lockdep annotations

2019-11-04 Thread Daniel Vetter
On Mon, Nov 04, 2019 at 06:37:59PM +0100, Daniel Vetter wrote: > Full audit of everyone: > > - i915, radeon, amdgpu should be clean per their maintainers. > > - vram helpers should be fine, they don't do command submission, so > really no business holding struct_mutex while doing copy_*_user. B

[Bug 205335] [amdgpu] suspend / screen black after thaw

2019-11-04 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=205335 Arne Woerner (arne_woer...@yahoo.com) changed: What|Removed |Added Status|NEW |RESOLVED

Re: [PATCH] drm/doc: Update IGT documentation

2019-11-04 Thread Daniel Vetter
On Tue, Oct 29, 2019 at 10:12:11PM -0300, Leandro Ribeiro wrote: > The IGT documentation in this page is telling us to build it using > make. According to commit 67993c1 ("automake: Point builders at > meson") from the IGT project, this is deprecated and IGT should be > built with meson. Instead of

Re: [PATCH 09/19] drm/via: set FOLL_PIN via pin_user_pages_fast()

2019-11-04 Thread Daniel Vetter
On Thu, Oct 31, 2019 at 04:36:28PM -0700, Ira Weiny wrote: > On Wed, Oct 30, 2019 at 03:49:20PM -0700, John Hubbard wrote: > > Convert drm/via to use the new pin_user_pages_fast() call, which sets > > FOLL_PIN. Setting FOLL_PIN is now required for code that requires > > tracking of pinned pages, an

Re: [Intel-gfx] [PATCH] drm/fbdev: Fallback to non tiled mode if all tiles not present

2019-11-04 Thread Daniel Vetter
On Mon, Nov 04, 2019 at 07:48:26PM +1000, David Airlie wrote: > On Mon, Nov 4, 2019 at 7:18 PM Daniel Vetter wrote: > > > > On Thu, Oct 31, 2019 at 02:48:39PM -0700, Manasi Navare wrote: > > > In case of tiled displays, if we hotplug just one connector, > > > fbcon currently just selects the prefe

Re: [PATCH] drm/doc: Adding VKMS module description and use to "Testing and Validation"

2019-11-04 Thread Daniel Vetter
On Fri, Nov 01, 2019 at 01:27:06AM -0300, Gabriela Bittencourt wrote: > Add a description on VKMS module and the cases in which it should be used. > There's a brief explanation on how to set it and use it in a VM, along with > an example of running an igt-test. > > Signed-off-by: Gabriela Bittenco

Re: Overlay support in the i.MX7 display

2019-11-04 Thread Daniel Vetter
On Mon, Nov 04, 2019 at 02:58:29PM +0200, Laurent Pinchart wrote: > Hello, > > On Mon, Nov 04, 2019 at 10:09:47AM +0200, Pekka Paalanen wrote: > > On Sun, 03 Nov 2019 19:15:49 +0100 Stefan Agner wrote: > > > On 2019-11-01 09:43, Laurent Pinchart wrote: > > > > Hello, > > > > > > > > I'm looking a

Re: [PATCH v14 1/5] dma-buf: Add dma-buf heaps framework

2019-11-04 Thread Daniel Vetter
On Mon, Nov 04, 2019 at 05:43:51PM +, Brian Starkey wrote: > Hi Dave, > > On Tue, Nov 05, 2019 at 02:58:17AM +1000, Dave Airlie wrote: > > On Mon, 4 Nov 2019 at 20:24, Brian Starkey wrote: > > > > > > Hi John, > > > > > > On Fri, Nov 01, 2019 at 09:42:34PM +, John Stultz wrote: > > > > Fr

Re: [PATCH v14 1/5] dma-buf: Add dma-buf heaps framework

2019-11-04 Thread John Stultz
On Sun, Nov 3, 2019 at 8:02 AM wrote: > > +static long dma_heap_ioctl_get_features(struct file *file, void *data) > > +{ > > + struct dma_heap_get_features_data *heap_features = data; > > + > > + /* nothing should be passed in */ > > + if (heap_features->features) > > + ret

Re: [PATCH 2/2] drm/atomic: clear new_state pointers at hw_done

2019-11-04 Thread Ville Syrjälä
On Fri, Nov 01, 2019 at 03:14:09PM -0700, Rob Clark wrote: > On Fri, Nov 1, 2019 at 2:44 PM Ville Syrjälä > wrote: > > > > On Fri, Nov 01, 2019 at 12:49:02PM -0700, Rob Clark wrote: > > > On Fri, Nov 1, 2019 at 12:25 PM Ville Syrjälä > > > wrote: > > > > > > > > On Fri, Nov 01, 2019 at 11:07:13AM

Re: [PATCH v14 1/5] dma-buf: Add dma-buf heaps framework

2019-11-04 Thread John Stultz
On Mon, Nov 4, 2019 at 2:24 AM Brian Starkey wrote: > On Fri, Nov 01, 2019 at 09:42:34PM +, John Stultz wrote: > > From: "Andrew F. Davis" > > > > Additionally should the interface grow in the future, we have a > > DMA_HEAP_IOC_GET_FEATURES ioctl which can return future feature > > flags. > >

Re: [PATCH 1/2] drm/fb-helper: Remove drm_fb_helper_defio_init() and update docs

2019-11-04 Thread Thomas Zimmermann
Hi Daniel Am 04.11.19 um 10:55 schrieb Daniel Vetter: > On Mon, Oct 28, 2019 at 09:13:47AM +0100, Thomas Zimmermann wrote: >> Hi >> >> Am 25.10.19 um 20:54 schrieb Daniel Vetter: >>> On Fri, Oct 25, 2019 at 7:26 PM Thomas Zimmermann >>> wrote: Hi Am 25.10.19 um 17:46 schrieb

Re: [PATCH v2 12/18] mm/gup: track FOLL_PIN pages

2019-11-04 Thread Jerome Glisse
On Sun, Nov 03, 2019 at 01:18:07PM -0800, John Hubbard wrote: > Add tracking of pages that were pinned via FOLL_PIN. > > As mentioned in the FOLL_PIN documentation, callers who effectively set > FOLL_PIN are required to ultimately free such pages via put_user_page(). > The effect is similar to FOL

Re: [RFC][PATCH 0/2] Allow DMA BUF heaps to be loaded as modules

2019-11-04 Thread John Stultz
On Mon, Nov 4, 2019 at 1:58 AM Daniel Vetter wrote: > On Fri, Oct 25, 2019 at 11:48:32PM +, John Stultz wrote: > > Now that the DMA BUF heaps core code has been queued, I wanted > > to send out some of the pending changes that I've been working > > on. > > > > For use with Android and their GK

Re: [RFC][PATCH 2/2] dma-buf: heaps: Allow system & cma heaps to be configured as a modules

2019-11-04 Thread John Stultz
On Mon, Nov 4, 2019 at 2:24 AM Daniel Vetter wrote: > On Fri, Oct 25, 2019 at 11:48:34PM +, John Stultz wrote: > > Allow loading system and cma heap as a module instead of just as > > a statically built in heap. > > > > Since there isn't a good mechanism for dmabuf lifetime tracking > > it isn

Re: [PATCH 2/2] drm/atomic: clear new_state pointers at hw_done

2019-11-04 Thread Rob Clark
On Mon, Nov 4, 2019 at 10:42 AM Ville Syrjälä wrote: > > On Fri, Nov 01, 2019 at 03:14:09PM -0700, Rob Clark wrote: > > On Fri, Nov 1, 2019 at 2:44 PM Ville Syrjälä > > wrote: > > > > > > On Fri, Nov 01, 2019 at 12:49:02PM -0700, Rob Clark wrote: > > > > On Fri, Nov 1, 2019 at 12:25 PM Ville Syrj

Re: [PATCH v2 05/18] mm/gup: introduce pin_user_pages*() and FOLL_PIN

2019-11-04 Thread Jerome Glisse
On Mon, Nov 04, 2019 at 11:04:38AM -0800, John Hubbard wrote: > On 11/4/19 9:33 AM, Jerome Glisse wrote: > ... > > > > Few nitpick belows, nonetheless: > > > > Reviewed-by: Jérôme Glisse > > [...] > >> + > >> +CASE 3: ODP > >> +--- > >> +(Mellanox/Infiniband On Demand Paging: the hardwar

Re: [PATCH v14 0/5] DMA-BUF Heaps (destaging ION)

2019-11-04 Thread John Stultz
On Mon, Nov 4, 2019 at 12:18 AM Pekka Paalanen wrote: > On Fri, 1 Nov 2019 21:42:33 + > John Stultz wrote: > > > This again? I know! > > > > Apologies to all who hoped I'd stop bothering them with this > > patch set, but I ran afoul of the DRM tree rules by not > > getting the userland patch

Re: [PATCH v14 2/5] dma-buf: heaps: Add heap helpers

2019-11-04 Thread John Stultz
On Sun, Nov 3, 2019 at 8:13 AM wrote: > On Fri, Nov 01, 2019 at 09:42:35PM +, John Stultz wrote: > > Add generic helper dmabuf ops for dma heaps, so we can reduce > > the amount of duplicative code for the exported dmabufs. > > > > This code is an evolution of the Android ION implementation, s

Re: [PATCH v5 03/12] clk: mediatek: mt8173: switch mmsys to platform device probing

2019-11-04 Thread Matthias Brugger
On 31/10/2019 05:17, Hsin-Yi Wang wrote: > On Fri, Nov 16, 2018 at 12:54 PM wrote: >> >> From: Matthias Brugger >> >> Switch probing for the MMSYS to support invocation to a >> plain paltform device. The driver will be probed by the DRM subsystem. >> >> Signed-off-by: Matthias Brugger >> --- >

Re: [PATCH v2 05/18] mm/gup: introduce pin_user_pages*() and FOLL_PIN

2019-11-04 Thread John Hubbard
On 11/4/19 9:33 AM, Jerome Glisse wrote: ... > > Few nitpick belows, nonetheless: > > Reviewed-by: Jérôme Glisse > [...] >> + >> +CASE 3: ODP >> +--- >> +(Mellanox/Infiniband On Demand Paging: the hardware supports >> +replayable page faulting). There are GUP references to pages serving

Re: [PATCH v7 0/9] backlight: gpio: simplify the driver

2019-11-04 Thread Bartosz Golaszewski
pt., 1 lis 2019 o 16:39 Jacopo Mondi napisał(a): > > Hello, > as promised... > > On Fri, Nov 01, 2019 at 08:58:03AM +, Lee Jones wrote: > > On Thu, 24 Oct 2019, Jacopo Mondi wrote: > > > > > Hello, > > > > > > On Thu, Oct 24, 2019 at 07:47:26AM +0100, Lee Jones wrote: > > > > On Wed, 23 Oct

[PATCH 6/7] drm/amdgpu: remove always false comparison in 'amdgpu_atombios_i2c_process_i2c_ch'

2019-11-04 Thread yu kuai
Fixes gcc '-Wtype-limits' warning: drivers/gpu/drm/amd/amdgpu/atombios_i2c.c: In function ‘amdgpu_atombios_i2c_process_i2c_ch’: drivers/gpu/drm/amd/amdgpu/atombios_i2c.c:79:11: warning: comparison is always false due to limited range of data type [-Wtype-limits] 'num' is 'u8', so it will never be

[PATCH 0/7] fix various gcc warnings

2019-11-04 Thread yu kuai
This patch set fixes various gcc warnings. yu kuai (7): drm/amdgpu: remove 4 set but not used variable in amdgpu_atombios_get_connector_info_from_object_table drm/amdgpu: add function parameter description in 'amdgpu_device_set_cg_state' drm/amdgpu: add function parameter descriptio

[PATCH 1/7] drm/amdgpu: remove 4 set but not used variable in amdgpu_atombios_get_connector_info_from_object_table

2019-11-04 Thread yu kuai
Fixes gcc '-Wunused-but-set-variable' warning: drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c: In function 'amdgpu_atombios_get_connector_info_from_object_table': drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:376:26: warning: variable 'grph_obj_num' set but not used [-Wunused-but-set-variable] driver

RE: [PATCH 2/4] dt-bindings: display: bridge: Repurpose lvds-encoder

2019-11-04 Thread Fabrizio Castro
Hi Neil, Thank you for your feedback! > From: Neil Armstrong > Sent: 04 November 2019 09:17 > Subject: Re: [PATCH 2/4] dt-bindings: display: bridge: Repurpose lvds-encoder > > Hi, > > > On 30/10/2019 14:43, Fabrizio Castro wrote: > > In an effort to repurpose lvds-encoder.c to also serve the

  1   2   >