Re: [PATCH 5/6] drm/mediatek: Convert to use CMA helpers

2019-10-24 Thread CK Hu
Hi, Rob: On Wed, 2019-10-23 at 17:56 -0500, Rob Herring wrote: > On Wed, Oct 23, 2019 at 4:06 PM CK Hu wrote: > > > > Hi, Rob: > > > > On Wed, 2019-10-23 at 12:42 -0500, Rob Herring wrote: > > > On Tue, Oct 22, 2019 at 12:07 PM Matthias Brugger > > > wrote: > > > > > > > > Hi Rob, > > > > > > >

Re: [PATCH v7 0/9] backlight: gpio: simplify the driver

2019-10-24 Thread Jacopo Mondi
Hello, On Thu, Oct 24, 2019 at 07:47:26AM +0100, Lee Jones wrote: > On Wed, 23 Oct 2019, Daniel Thompson wrote: > > > On Tue, Oct 22, 2019 at 11:29:54AM +0200, Bartosz Golaszewski wrote: > > > wt., 22 paź 2019 o 10:36 Bartosz Golaszewski napisał(a): > > > > > > > > From: Bartosz Golaszewski > >

Re: [PATCH] Cleanup: replace prefered with preferred

2019-10-24 Thread Mark Salyzyn
On 10/23/19 4:56 AM, Jarkko Sakkinen wrote: On Tue, Oct 22, 2019 at 02:41:45PM -0700, Mark Salyzyn wrote: Replace all occurrences of prefered with preferred to make future checkpatch.pl's happy. A few places the incorrect spelling is matched with the correct spelling to preserve existing user s

Proposal to report GPU private memory allocations with sysfs nodes

2019-10-24 Thread Yiwei Zhang
Hi folks, This is Yiwei from the Android Platform Graphics team. On the downstream Android, vendors used to report GPU private memory allocations with debugfs nodes in their own formats. However, debugfs nodes are getting deprecated in the next Android release, so we are taking the chance to unify

[PATCH v2] drm/gpu: Add comment for memory barrier

2019-10-24 Thread Bhanusree
-Add comment for memory barrier -Issue found using checkpatch.pl Signed-off-by: Bhanusree --- v2:modified memory barrier comments appropriately drivers/gpu/drm/drm_cache.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_cache.c b/drivers/gpu/drm/drm_

Re: [PATCH v2 1/4] backlight: pwm_bl: fix cie1913 comments and constant

2019-10-24 Thread Rasmus Villemoes
On 14/10/2019 09.27, Lee Jones wrote: > Applied, thanks. I'm not seeing the series in next-20191023, should it be there? Rasmus ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH] dc.c:use kzalloc without test

2019-10-24 Thread zhongshiqi
dc.c:583:null check is needed after using kzalloc function Signed-off-by: zhongshiqi --- drivers/gpu/drm/amd/display/dc/core/dc.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c index 5d1aded..4b8819c 10

Re: [PATCH 00/36] ARM: samsung platform cleanup

2019-10-24 Thread Lihua Yao
Hi Arnd, Krzysztof, On 23/10/2019 9:39 PM, Arnd Bergmann wrote: > On Wed, Oct 23, 2019 at 3:11 PM Krzysztof Kozlowski wrote: >> On Thu, Oct 10, 2019 at 10:28:02PM +0200, Arnd Bergmann wrote: >>> The contents are available for testing in >>> >>> git://kernel.org:/pub/scm/linux/kernel/git/arnd/play

Re: [PATCH hmm 00/15] Consolidate the mmu notifier interval_tree and locking

2019-10-24 Thread Jason Gunthorpe
On Wed, Oct 23, 2019 at 12:52:23PM -0400, Jerome Glisse wrote: > > Going another step further what hinders us to put the lock into the mmu > > range notifier itself and have _lock()/_unlock() helpers? > > > > I mean having the lock in the driver only makes sense when the driver would > > be us

RE: [PATCH 1/5] drm/dsi: clean up DSI data type definitions

2019-10-24 Thread Kulkarni, Vandita
Looks good to me. Reviewed-by: Vandita Kulkarni > -Original Message- > From: Jani Nikula > Sent: Tuesday, October 22, 2019 3:40 PM > To: dri-devel@lists.freedesktop.org > Cc: intel-...@lists.freedesktop.org; Nikula, Jani ; > Kulkarni, Vandita > Subject: [PATCH 1/5] drm/dsi: clean up DSI

Re: [PATCH v10 5/6] arm64: dts: allwinner: a64: Add MIPI DSI pipeline

2019-10-24 Thread Jagan Teki
On Thu, Oct 17, 2019 at 3:22 PM Maxime Ripard wrote: > > On Wed, Oct 16, 2019 at 02:19:44PM +0530, Jagan Teki wrote: > > On Wed, Oct 16, 2019 at 1:33 PM Maxime Ripard wrote: > > > > > > On Mon, Oct 14, 2019 at 05:37:50PM +0530, Jagan Teki wrote: > > > > On Mon, Oct 7, 2019 at 4:27 PM Maxime Ripar

Re: [RFC,3/3] drm/komeda: Allow non-component drm_bridge only endpoints

2019-10-24 Thread Mihail Atanassov
Hi Russell, On Tuesday, 22 October 2019 15:53:29 BST Russell King - ARM Linux admin wrote: > On Tue, Oct 22, 2019 at 03:42:07PM +0100, Russell King - ARM Linux admin > wrote: > > On Tue, Oct 22, 2019 at 10:50:42AM +0200, Daniel Vetter wrote: > > > On Tue, Oct 22, 2019 at 10:48 AM Russell King - A

[PATCH v2 1/4] drm/vram-helpers: Add helpers for prepare_fb() and cleanup_fb()

2019-10-24 Thread Thomas Zimmermann
The new helpers pin and unpin a framebuffer's GEM VRAM objects during plane updates. This should be sufficient for most drivers' implementation of prepare_fb() and cleanup_fb(). v2: * provide helpers for struct drm_simple_display_pipe_funcs * rename plane-helper funcs Signed-off-b

[PATCH v2 3/4] drm/hisilicon/hibmc: Use GEM VRAM's prepare_fb() and cleanup_fb() helpers

2019-10-24 Thread Thomas Zimmermann
This patch implements prepare_fb() and cleanup_fb() in hibmc with the GEM VRAM helpers. In the current code, pinning the BO is performed by hibmc_plane_atomic_update(), where the operation does not belong. This patch also fixes a bug where the pinned BO was never unpinned. Pinning multiple BOs wou

[PATCH v2 4/4] drm/vboxvideo: Replace prepare_fb()/cleanup_fb() with GEM VRAM helpers

2019-10-24 Thread Thomas Zimmermann
GEM VRAM provides an implementation for prepare_fb() and cleanup_fb() of struct drm_plane_helper_funcs. Switch over vboxvideo. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/vboxvideo/vbox_mode.c | 61 ++- 1 file changed, 4 insertions(+), 57 deletions(-) diff --git

[PATCH v2 2/4] drm/bochs: Replace prepare_fb()/cleanup_fb() with GEM VRAM helpers

2019-10-24 Thread Thomas Zimmermann
GEM VRAM provides an implementation for prepare_fb() and cleanup_fb() of struct drm_simple_display_pipe_funcs. Switch over bochs. v2: * use helpers for struct drm_simple_display_pipe_funcs Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/bochs/bochs_kms.c | 26 ++

[Bug 111481] AMD Navi GPU frequent freezes on both Manjaro/Ubuntu with kernel 5.3 and mesa 19.2 -git/llvm9

2019-10-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111481 --- Comment #150 from Stijn Tintel --- (In reply to Jaap Buurman from comment #142) > How can I set both AMD_DEBUG=nongg and AMD_DEBUG=nodma in the > /etc/environment file? Do they need to be on two separate lines, or will the > second line simp

[PATCH v2 0/4] drm/vram: Provide helpers for prepare_fb() and cleanup_fb()

2019-10-24 Thread Thomas Zimmermann
The implementation of the plane's call-back functions prepare_fb() and cleanup_fb() for GEM VRAM helpers are sharable among drivers. Patch #3 also fixes two bugs that have been present in hibmc since it was first added. The primary plane's atomic_update() is not responsible for pinning BOs. And it

Re: [PATCH 2/2] drm/etnaviv: reinstate MMUv1 command buffer window check

2019-10-24 Thread Guido Günther
Hi Lucas, On Wed, Oct 16, 2019 at 04:27:16PM +0200, Lucas Stach wrote: > The switch to per-process address spaces erroneously dropped the check > which validated that the command buffer is mapped through the linear > apperture as required by the hardware. This turned a system > misconfiguration wit

[PATCH v2 1/2] drm/nouveau: Move the declaration of struct nouveau_conn_atom up a bit

2019-10-24 Thread Hans de Goede
Place the declaration of struct nouveau_conn_atom above that of struct nouveau_connector. This commit makes no changes to the moved block what so ever, it just moves it up a bit. This is a preparation patch to fix some issues with connector handling on pre nv50 displays (which do not use atomic mo

[PATCH v2 2/2] drm/nouveau: Fix drm-core using atomic code-paths on pre-nv50 hardware

2019-10-24 Thread Hans de Goede
We do not support atomic modesetting on pre-nv50 hardware, but until now our connector code was setting drm_connector->state on pre-nv50 hardware. This causes the core to enter atomic modesetting paths in at least: 1. drm_connector_get_encoder(), returning connector->state->best_encoder which is

Re: [PATCH] drm/prime: Fix mmap fake offset for drm_gem_object_funcs.mmap

2019-10-24 Thread Gerd Hoffmann
On Wed, Oct 23, 2019 at 05:22:26PM -0500, Rob Herring wrote: > Commit c40069cb7bd6 ("drm: add mmap() to drm_gem_object_funcs") > introduced a GEM object mmap() hook which is expected to subtract the > fake offset from vm_pgoff. Long-term it is probably a good idea to just remove the fake offset ha

Re: [PATCH 2/3] drm/nouveau: slowpath for pushbuf ioctl

2019-10-24 Thread Daniel Vetter
On Mon, Oct 21, 2019 at 4:50 PM Daniel Vetter wrote: > > We can't copy_*_user while holding reservations, that will (soon even > for nouveau) lead to deadlocks. And it breaks the cross-driver > contract around dma_resv. > > Fix this by adding a slowpath for when we need relocations, and by > pushi

[Bug 109955] amdgpu [RX Vega 64] system freeze while gaming

2019-10-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109955 --- Comment #122 from har...@gmx.de --- In my experience, this issue is related to mclk switching and it affects the lowest mclk level only. So you guy's can save a lot of power, if you, insteed of switching to highest gfxlevel or to disable vsy

[Bug 109955] amdgpu [RX Vega 64] system freeze while gaming

2019-10-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109955 --- Comment #123 from har...@gmx.de --- ... i forgot the link to a related thread: https://bugs.freedesktop.org/show_bug.cgi?id=110777 -- You are receiving this mail because: You are the assignee for the bug.__

[Bug 109887] [Vega10][powerplay] P7 gets reset to max_vddc (1.2V/1.25V) after applying any custom settings via pp_od_clk_voltage and/or pp_table

2019-10-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109887 --- Comment #15 from Stefan Springer --- The patch Pelle van Gils proposed here works flawlessly for me: https://bugzilla.kernel.org/show_bug.cgi?id=205277 -- You are receiving this mail because: You are the assignee for the bug.__

Re: [PATCH] drm/ttm: use the parent resv for ghost objects v2

2019-10-24 Thread Christian König
Ping? Am 18.10.19 um 13:58 schrieb Christian König: This way the TTM is destroyed with the correct dma_resv object locked and we can even pipeline imported BO evictions. v2: Limit this to only cases when the parent object uses a separate reservation object as well. This fixes another OOM p

Re: [PATCH v7 1/4] drm: Add a new helper drm_color_ctm_s31_32_to_qm_n()

2019-10-24 Thread Mihail Atanassov
Hi James, You already have my r-b on the patch, so for posterity: no further important comments from my side. On Wednesday, 23 October 2019 07:42:55 BST james qian wang (Arm Technology China) wrote: > Add a new helper function drm_color_ctm_s31_32_to_qm_n() for driver to > convert S31.32 sign-ma

Re: [Intel-gfx] [PATCH] drm/dp: Add function to parse EDID descriptors for adaptive sync limits

2019-10-24 Thread Thierry Reding
On Wed, Oct 23, 2019 at 05:00:41PM -0700, Manasi Navare wrote: > Adaptive Sync is a VESA feature so add a DRM core helper to parse > the EDID's detailed descritors to obtain the adaptive sync monitor range. > Store this info as part fo drm_display_info so it can be used > across all drivers. > This

Re: [Intel-gfx] [PATCH 2/2] drm/todo: Add entry to remove load/unload hooks

2019-10-24 Thread Thierry Reding
On Wed, Oct 23, 2019 at 04:49:53PM +0200, Daniel Vetter wrote: > They're midlayer, broken, and because of the old gunk, we can't fix > them. For examples see the various checks in drm_mode_object.c against > dev->registered, which cannot be enforced if the driver still uses the > load hook. > > Un

Re: [Intel-gfx] [PATCH 1/2] drm/property: Enforce more lifetime rules

2019-10-24 Thread Thierry Reding
On Wed, Oct 23, 2019 at 04:49:52PM +0200, Daniel Vetter wrote: > Properties can't be attached after registering, userspace would get > confused (no one bothers to reprobe really). > > - Add kerneldoc > - Enforce this with some checks. This needs a somewhat ugly check > since connectors can be ad

Re: [Intel-gfx] [PATCH 1/2] drm/property: Enforce more lifetime rules

2019-10-24 Thread Thierry Reding
On Thu, Oct 24, 2019 at 12:40:55PM +0200, Thierry Reding wrote: > On Wed, Oct 23, 2019 at 04:49:52PM +0200, Daniel Vetter wrote: > > Properties can't be attached after registering, userspace would get > > confused (no one bothers to reprobe really). > > > > - Add kerneldoc > > - Enforce this with

[PATCH][next] drm/v3d: fix double free of bin

2019-10-24 Thread Colin King
From: Colin Ian King Two different fixes have addressed the same memory leak of bin and this now causes a double free of bin. While the individual memory leak fixes are fine, both fixes together are problematic. Addresses-Coverity: ("Double free") Fixes: 29cd13cfd762 ("drm/v3d: Fix memory leak

Re: [PATCH] drm/ttm: use the parent resv for ghost objects v2

2019-10-24 Thread Zhou, David(ChunMing)
On 2019/10/24 下午6:25, Christian König wrote: > Ping? > > Am 18.10.19 um 13:58 schrieb Christian König: >> This way the TTM is destroyed with the correct dma_resv object >> locked and we can even pipeline imported BO evictions. >> >> v2: Limit this to only cases when the parent object uses a separa

Re: [PATCH] drm/ttm: use the parent resv for ghost objects v2

2019-10-24 Thread Christian König
Am 24.10.19 um 12:51 schrieb Zhou, David(ChunMing): On 2019/10/24 下午6:25, Christian König wrote: Ping? Am 18.10.19 um 13:58 schrieb Christian König: This way the TTM is destroyed with the correct dma_resv object locked and we can even pipeline imported BO evictions. v2: Limit this to only cas

[Bug 205277] [amd powerplay] vega10: soc voltage for power state 7 is not changed by overdrive.

2019-10-24 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=205277 har...@gmx.de changed: What|Removed |Added CC||har...@gmx.de --- Comment #3 from har...@

[PATCH] drm/ttm: use the parent resv for ghost objects v3

2019-10-24 Thread Christian König
This way the TTM is destroyed with the correct dma_resv object locked and we can even pipeline imported BO evictions. v2: Limit this to only cases when the parent object uses a separate reservation object as well. This fixes another OOM problem. v3: fix init and try_lock on the wrong object S

Re: [PATCH] drm: Add support for integrated privacy screens

2019-10-24 Thread Thierry Reding
On Tue, Oct 22, 2019 at 05:12:06PM -0700, Rajat Jain wrote: > Certain laptops now come with panels that have integrated privacy > screens on them. This patch adds support for such panels by adding > a privacy-screen property to the drm_connector for the panel, that > the userspace can then use to c

Re: [PATCH v3 00/21] drm: Add support for bus-format negotiation

2019-10-24 Thread Neil Armstrong
hi Boris, On 23/10/2019 17:44, Boris Brezillon wrote: > This patch series aims at adding support for runtime bus-format > negotiation between all elements of the > 'encoder -> bridges -> connector/display' section of the pipeline. > > In order to support that, we need drm bridges to fully take pa

Re: [Intel-gfx] [PATCH] drm/dp: Add function to parse EDID descriptors for adaptive sync limits

2019-10-24 Thread Ville Syrjälä
On Thu, Oct 24, 2019 at 12:31:06PM +0200, Thierry Reding wrote: > On Wed, Oct 23, 2019 at 05:00:41PM -0700, Manasi Navare wrote: > > Adaptive Sync is a VESA feature so add a DRM core helper to parse > > the EDID's detailed descritors to obtain the adaptive sync monitor range. > > Store this info as

[PATCH 1/3 v4] drm/panel: Add generic DSI panel YAML bindings

2019-10-24 Thread Linus Walleij
This adds a starting point for processing and defining generic bindings used by DSI panels. We just define one single bool property to force the panel into video mode for now. Cc: devicet...@vger.kernel.org Suggested-by: Rob Herring Signed-off-by: Linus Walleij --- ChangeLog v3->v4: - Rename int

[PATCH 2/3 v4] drm/panel: Add DT bindings for Sony ACX424AKP

2019-10-24 Thread Linus Walleij
This adds device tree bindings for the Sony ACX424AKP panel. Let's use YAML. Cc: devicet...@vger.kernel.org Signed-off-by: Linus Walleij --- ChangeLog v3->v4: - Adjust to adjusted DSI bindings. ChangeLog v2->v3: - Put the example inside a dsi-controller so we have a complete example that verifi

[PATCH 3/3 v4] drm/panel: Add driver for Sony ACX424AKP panel

2019-10-24 Thread Linus Walleij
The Sony ACX424AKP is a command/videomode DSI panel for mobile devices. It is used on the ST-Ericsson HREF520 reference design. We support video mode by default, but it is possible to switch the panel into command mode by using the bool property "dsi-command-mode". Signed-off-by: Linus Walleij --

Re: [Intel-gfx] [PATCH 1/2] drm/property: Enforce more lifetime rules

2019-10-24 Thread Daniel Vetter
On Thu, Oct 24, 2019 at 12:43 PM Thierry Reding wrote: > > On Thu, Oct 24, 2019 at 12:40:55PM +0200, Thierry Reding wrote: > > On Wed, Oct 23, 2019 at 04:49:52PM +0200, Daniel Vetter wrote: > > > Properties can't be attached after registering, userspace would get > > > confused (no one bothers to

Re: [PATCH] drm/syncobj: extend syncobj query ability v3

2019-10-24 Thread Daniel Vetter
On Wed, Oct 23, 2019 at 10:22 PM Sean Paul wrote: > > On Tue, Jul 30, 2019 at 9:22 AM Chunming Zhou wrote: > > > > > > 在 2019/7/30 21:17, Koenig, Christian 写道: > > > Am 30.07.19 um 15:02 schrieb Chunming Zhou: > > >> user space needs a flexiable query ability. > > >> So that umd can get last sign

Re: [PATCH v1 1/3] gpu: host1x: Remove implicit IOMMU backing on client's registration

2019-10-24 Thread Thierry Reding
On Sun, Jun 23, 2019 at 08:37:41PM +0300, Dmitry Osipenko wrote: > On ARM32 we don't want any of the clients device to be backed by the > implicit domain, simply because we can't afford such a waste on older > Tegra SoCs that have very few domains available in total. The recent IOMMU > support addi

Re: [PATCH] drm/simple-kms: Standardize arguments for callbacks

2019-10-24 Thread Daniel Vetter
On Wed, Oct 23, 2019 at 05:40:32PM +0200, Linus Walleij wrote: > On Wed, Oct 23, 2019 at 12:13 PM Daniel Vetter wrote: > > > Passing the wrong type feels icky, everywhere else we use the pipe as > > the first parameter. Spotted while discussing patches with Thomas > > Zimmermann. > > > > v2: Make

Re: [PATCH v1 2/3] drm/tegra: Fix 2d and 3d clients detaching from IOMMU domain

2019-10-24 Thread Thierry Reding
On Sun, Jun 23, 2019 at 08:37:42PM +0300, Dmitry Osipenko wrote: > This should should fire up on the DRM's driver module re-loader because > there won't be enough available domains on older Tegra SoCs. > > Cc: stable > Fixes: 0c407de5ed1a ("drm/tegra: Refactor IOMMU attach/detach") > Signed-off-b

Re: [Intel-gfx] [PATCH 1/3] drm: Introduce scaling filter mode property

2019-10-24 Thread Daniel Vetter
On Wed, Oct 23, 2019 at 03:44:17PM +0300, Jani Nikula wrote: > On Tue, 22 Oct 2019, Daniel Vetter wrote: > > On Tue, Oct 22, 2019 at 03:29:44PM +0530, Shashank Sharma wrote: > >> This patch adds a scaling filter mode porperty > >> to allow: > >> - A driver/HW to showcase it's scaling filter capabi

Re: [PATCH 1/2] drm/property: Enforce more lifetime rules

2019-10-24 Thread Jani Nikula
On Wed, 23 Oct 2019, Daniel Vetter wrote: > Properties can't be attached after registering, userspace would get > confused (no one bothers to reprobe really). > > - Add kerneldoc > - Enforce this with some checks. This needs a somewhat ugly check > since connectors can be added later on, but we

Re: [PATCH v7 0/9] backlight: gpio: simplify the driver

2019-10-24 Thread Lee Jones
On Thu, 24 Oct 2019, Jacopo Mondi wrote: > On Thu, Oct 24, 2019 at 07:47:26AM +0100, Lee Jones wrote: > > On Wed, 23 Oct 2019, Daniel Thompson wrote: [...] > > > > Jacopo is travelling until November 1st and won't be able to test this > > > > again before this date. Do you think you can pick it u

Re: [Intel-gfx] [PATCH 1/3] drm: Introduce scaling filter mode property

2019-10-24 Thread Jani Nikula
On Thu, 24 Oct 2019, Daniel Vetter wrote: > On Wed, Oct 23, 2019 at 03:44:17PM +0300, Jani Nikula wrote: >> On Tue, 22 Oct 2019, Daniel Vetter wrote: >> > On Tue, Oct 22, 2019 at 03:29:44PM +0530, Shashank Sharma wrote: >> >> This patch adds a scaling filter mode porperty >> >> to allow: >> >> -

Re: [Outreachy][PATCH] drm/mediatek: remove cast to pointers passed to kfree

2019-10-24 Thread Daniel Vetter
On Wed, Oct 23, 2019 at 02:11:07PM +0300, Wambui Karuga wrote: > Remove unnecessary casts to pointer types passed to kfree. > Issue detected by coccinelle: > @@ > type t1; > expression *e; > @@ > > -kfree((t1 *)e); > +kfree(e); > > Signed-off-by: Wambui Karuga Applied to drm-misc-next, thanks f

Re: [Intel-gfx] [PATCH 1/3] drm: Introduce scaling filter mode property

2019-10-24 Thread Daniel Vetter
On Thu, Oct 24, 2019 at 03:12:07PM +0300, Jani Nikula wrote: > On Thu, 24 Oct 2019, Daniel Vetter wrote: > > On Wed, Oct 23, 2019 at 03:44:17PM +0300, Jani Nikula wrote: > >> On Tue, 22 Oct 2019, Daniel Vetter wrote: > >> > On Tue, Oct 22, 2019 at 03:29:44PM +0530, Shashank Sharma wrote: > >> >>

Re: [Intel-gfx] [PATCH 1/3] drm: Introduce scaling filter mode property

2019-10-24 Thread Jani Nikula
On Thu, 24 Oct 2019, Daniel Vetter wrote: > On Thu, Oct 24, 2019 at 03:12:07PM +0300, Jani Nikula wrote: >> On Thu, 24 Oct 2019, Daniel Vetter wrote: >> > On Wed, Oct 23, 2019 at 03:44:17PM +0300, Jani Nikula wrote: >> >> On Tue, 22 Oct 2019, Daniel Vetter wrote: >> >> > On Tue, Oct 22, 2019 at

Re: [PATCH] Cleanup: replace prefered with preferred

2019-10-24 Thread Jani Nikula
On Wed, 23 Oct 2019, Mark Salyzyn wrote: > I will split this between pure and inert documentation/comments for now, > with a followup later for the code portion which understandably is more > controversial. Please split by driver/subsystem too, and it'll be all around much easier for everyone.

[Bug 205277] [amd powerplay] vega10: soc voltage for power state 7 is not changed by overdrive.

2019-10-24 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=205277 stefansp...@gmail.com changed: What|Removed |Added CC||stefansp...@gmail.com --- Comment

Re: [PATCH] drm/prime: Fix mmap fake offset for drm_gem_object_funcs.mmap

2019-10-24 Thread Daniel Vetter
On Thu, Oct 24, 2019 at 11:02:40AM +0200, Gerd Hoffmann wrote: > On Wed, Oct 23, 2019 at 05:22:26PM -0500, Rob Herring wrote: > > Commit c40069cb7bd6 ("drm: add mmap() to drm_gem_object_funcs") > > introduced a GEM object mmap() hook which is expected to subtract the > > fake offset from vm_pgoff.

Re: [PATCH v2] drm/gpu: Add comment for memory barrier

2019-10-24 Thread Daniel Vetter
On Thu, Oct 24, 2019 at 09:58:33AM +0530, Bhanusree wrote: > -Add comment for memory barrier > -Issue found using checkpatch.pl > > Signed-off-by: Bhanusree > --- > > v2:modified memory barrier comments appropriately Applied, thanks. -Daniel > > drivers/gpu/drm/drm_cache.c | 4 ++-- > 1 file

Re: [PATCH v2 0/4] drm/vram: Provide helpers for prepare_fb() and cleanup_fb()

2019-10-24 Thread Daniel Vetter
On Thu, Oct 24, 2019 at 10:14:00AM +0200, Thomas Zimmermann wrote: > The implementation of the plane's call-back functions prepare_fb() and > cleanup_fb() for GEM VRAM helpers are sharable among drivers. > > Patch #3 also fixes two bugs that have been present in hibmc since it was > first added. T

Re: [PATCH][next] drm/v3d: fix double free of bin

2019-10-24 Thread Daniel Vetter
On Thu, Oct 24, 2019 at 11:48:01AM +0100, Colin King wrote: > From: Colin Ian King > > Two different fixes have addressed the same memory leak of bin and > this now causes a double free of bin. While the individual memory > leak fixes are fine, both fixes together are problematic. > > Addresses

Re: [PATCH] drm/ttm: use the parent resv for ghost objects v3

2019-10-24 Thread Daniel Vetter
On Thu, Oct 24, 2019 at 01:16:32PM +0200, Christian König wrote: > This way the TTM is destroyed with the correct dma_resv object > locked and we can even pipeline imported BO evictions. > > v2: Limit this to only cases when the parent object uses a separate > reservation object as well. This

Re: [PATCH][next] drm/v3d: fix double free of bin

2019-10-24 Thread Colin Ian King
On 24/10/2019 13:38, Daniel Vetter wrote: > On Thu, Oct 24, 2019 at 11:48:01AM +0100, Colin King wrote: >> From: Colin Ian King >> >> Two different fixes have addressed the same memory leak of bin and >> this now causes a double free of bin. While the individual memory >> leak fixes are fine, bot

Re: [PATCH][next] drm/v3d: fix double free of bin

2019-10-24 Thread Daniel Vetter
On Thu, Oct 24, 2019 at 2:43 PM Colin Ian King wrote: > > On 24/10/2019 13:38, Daniel Vetter wrote: > > On Thu, Oct 24, 2019 at 11:48:01AM +0100, Colin King wrote: > >> From: Colin Ian King > >> > >> Two different fixes have addressed the same memory leak of bin and > >> this now causes a double

Re: [PATCH v10 5/6] arm64: dts: allwinner: a64: Add MIPI DSI pipeline

2019-10-24 Thread Jagan Teki
On Thu, Oct 17, 2019 at 3:22 PM Maxime Ripard wrote: > > On Wed, Oct 16, 2019 at 02:19:44PM +0530, Jagan Teki wrote: > > On Wed, Oct 16, 2019 at 1:33 PM Maxime Ripard wrote: > > > > > > On Mon, Oct 14, 2019 at 05:37:50PM +0530, Jagan Teki wrote: > > > > On Mon, Oct 7, 2019 at 4:27 PM Maxime Ripar

Re: [PATCH] drm/syncobj: extend syncobj query ability v3

2019-10-24 Thread Chunming Zhou
在 2019/10/24 4:21, Sean Paul 写道: > On Tue, Jul 30, 2019 at 9:22 AM Chunming Zhou wrote: >> >> 在 2019/7/30 21:17, Koenig, Christian 写道: >>> Am 30.07.19 um 15:02 schrieb Chunming Zhou: user space needs a flexiable query ability. So that umd can get last signaled or submitted point. v

Re: [PATCH v3 00/21] drm: Add support for bus-format negotiation

2019-10-24 Thread Boris Brezillon
On Thu, 24 Oct 2019 13:27:16 +0200 Neil Armstrong wrote: > hi Boris, > > On 23/10/2019 17:44, Boris Brezillon wrote: > > This patch series aims at adding support for runtime bus-format > > negotiation between all elements of the > > 'encoder -> bridges -> connector/display' section of the pipeli

[Bug 111481] AMD Navi GPU frequent freezes on both Manjaro/Ubuntu with kernel 5.3 and mesa 19.2 -git/llvm9

2019-10-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111481 L.S.S. changed: What|Removed |Added CC||ragnaros39...@yandex.com --- Comment #151 from

[Bug 111762] RX 5700 XT Navi - amdgpu.ppfeaturemask=0xffffffff causes stuttering and does not unlock clock/voltage/power controls

2019-10-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111762 L.S.S. changed: What|Removed |Added CC||ragnaros39...@yandex.com --- Comment #5 from L

Re: [PATCH v1 1/3] gpu: host1x: Remove implicit IOMMU backing on client's registration

2019-10-24 Thread Thierry Reding
On Thu, Oct 24, 2019 at 04:35:13PM +0300, Dmitry Osipenko wrote: > 24.10.2019 14:50, Thierry Reding пишет: > > On Sun, Jun 23, 2019 at 08:37:41PM +0300, Dmitry Osipenko wrote: > >> On ARM32 we don't want any of the clients device to be backed by the > >> implicit domain, simply because we can't aff

Re: [PATCH v1 2/3] drm/tegra: Fix 2d and 3d clients detaching from IOMMU domain

2019-10-24 Thread Thierry Reding
On Thu, Oct 24, 2019 at 04:28:41PM +0300, Dmitry Osipenko wrote: > 24.10.2019 14:58, Thierry Reding пишет: > > On Sun, Jun 23, 2019 at 08:37:42PM +0300, Dmitry Osipenko wrote: > >> This should should fire up on the DRM's driver module re-loader because > >> there won't be enough available domains o

Re: [Intel-gfx] [PATCH] drm/dp: Add function to parse EDID descriptors for adaptive sync limits

2019-10-24 Thread Thierry Reding
On Thu, Oct 24, 2019 at 02:34:00PM +0300, Ville Syrjälä wrote: > On Thu, Oct 24, 2019 at 12:31:06PM +0200, Thierry Reding wrote: > > On Wed, Oct 23, 2019 at 05:00:41PM -0700, Manasi Navare wrote: > > > Adaptive Sync is a VESA feature so add a DRM core helper to parse > > > the EDID's detailed descr

[Bug 205277] [amd powerplay] vega10: soc voltage for power state 7 is not changed by overdrive.

2019-10-24 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=205277 Pelle van Gils (pe...@vangils.xyz) changed: What|Removed |Added Attachment #285585|0 |1 is obsolete

Re: [PATCH v2 0/4] drm/vram: Provide helpers for prepare_fb() and cleanup_fb()

2019-10-24 Thread Thomas Zimmermann
Hi Am 24.10.19 um 14:37 schrieb Daniel Vetter: > On Thu, Oct 24, 2019 at 10:14:00AM +0200, Thomas Zimmermann wrote: >> The implementation of the plane's call-back functions prepare_fb() and >> cleanup_fb() for GEM VRAM helpers are sharable among drivers. >> >> Patch #3 also fixes two bugs that hav

Re: [Intel-gfx] [PATCH] drm/dp: Add function to parse EDID descriptors for adaptive sync limits

2019-10-24 Thread Ville Syrjälä
On Thu, Oct 24, 2019 at 03:54:41PM +0200, Thierry Reding wrote: > On Thu, Oct 24, 2019 at 02:34:00PM +0300, Ville Syrjälä wrote: > > On Thu, Oct 24, 2019 at 12:31:06PM +0200, Thierry Reding wrote: > > > On Wed, Oct 23, 2019 at 05:00:41PM -0700, Manasi Navare wrote: > > > > Adaptive Sync is a VESA f

[Bug 111481] AMD Navi GPU frequent freezes on both Manjaro/Ubuntu with kernel 5.3 and mesa 19.2 -git/llvm9

2019-10-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111481 --- Comment #152 from L.S.S. --- UPDATE: I just got another freeze on 5.3.6 kernel. The same GCVM_L2_PROTECTION_FAULT error followed by a ring sdma0 timeout. So it seems AMD_DEBUG="nodma nongg" doesn't really work for me. -- You are receiving

Question regarding "reserved-memory"

2019-10-24 Thread Ayan Halder
Hi Folks, I have a question regarding "reserved-memory". I am using an Arm Juno platform which has a chunk of ram in its fpga. I intend to make this memory as reserved so that it can be shared between various devices for passing framebuffer. My dts looks like the following:- / { //

Re: [PATCH] drm/prime: Fix mmap fake offset for drm_gem_object_funcs.mmap

2019-10-24 Thread Rob Herring
On Thu, Oct 24, 2019 at 7:32 AM Daniel Vetter wrote: > > On Thu, Oct 24, 2019 at 11:02:40AM +0200, Gerd Hoffmann wrote: > > On Wed, Oct 23, 2019 at 05:22:26PM -0500, Rob Herring wrote: > > > Commit c40069cb7bd6 ("drm: add mmap() to drm_gem_object_funcs") > > > introduced a GEM object mmap() hook w

Re: [Intel-gfx] [PATCH] drm/dp: Add function to parse EDID descriptors for adaptive sync limits

2019-10-24 Thread Thierry Reding
On Thu, Oct 24, 2019 at 05:20:32PM +0300, Ville Syrjälä wrote: > On Thu, Oct 24, 2019 at 03:54:41PM +0200, Thierry Reding wrote: > > On Thu, Oct 24, 2019 at 02:34:00PM +0300, Ville Syrjälä wrote: > > > On Thu, Oct 24, 2019 at 12:31:06PM +0200, Thierry Reding wrote: > > > > On Wed, Oct 23, 2019 at 0

[PATCH 1/5] drm/udl: Clear BO vmapping pointer after unmapping BO memory

2019-10-24 Thread Thomas Zimmermann
Unmapping the BO memory with udl_gem_vunmap() creates a dangling pointer in struct udl_gem_object.vmapping. This can crash udl_handle_damage(), which check the pointer's value for NULL. Clear the pointer to NULL and let udl_handle_damage() re-establish the mapping if necessary. Signed-off-by: Thom

[PATCH 0/5] drm/udl: Convert to generic fbdev emulation

2019-10-24 Thread Thomas Zimmermann
This patchset replaces udl's fbdev code with the generic implementation. The first patch fixes a bug that didn't trigger yet because the current fbdev never unmaps the BO. Patches 2 to 3 add missing interfaces to the udl driver. Patch 4 sets mapping flags. In the final patch, we remove a lot of co

[PATCH 3/5] drm/udl: Add GEM object functions for free(), vmap(), and vunmap()

2019-10-24 Thread Thomas Zimmermann
Implementing vmap() and vunmap() of struct drm_gem_object_funcs is required by generic fbdev emulation. Supporting free() is easy as well. More udl-specific interfaces can probably be replaced by GEM object functions in later patches. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/udl/udl_

[PATCH 4/5] drm/udl: Map BO memory pages in unencrypted mode

2019-10-24 Thread Thomas Zimmermann
The udl driver's fbdev code maps pages in unencrypted mode. To switch over to generic fbdev emulation, we set this flag in the BO mapping code. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/udl/udl_gem.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/d

[PATCH 2/5] drm/udl: Set drm_driver.gem_prime_mmap

2019-10-24 Thread Thomas Zimmermann
This interface is required by the mmap support of generic fbdev emulation. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/udl/udl_drv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/udl/udl_drv.c b/drivers/gpu/drm/udl/udl_drv.c index 8426669433e4..15ad7a338f9d 100644

[PATCH 5/5] drm/udl: Replace fbdev code with generic emulation

2019-10-24 Thread Thomas Zimmermann
Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/udl/udl_drv.c | 3 + drivers/gpu/drm/udl/udl_drv.h | 4 - drivers/gpu/drm/udl/udl_fb.c | 263 +- drivers/gpu/drm/udl/udl_main.c| 2 - drivers/gpu/drm/udl/udl_modeset.c | 3 +- 5 files changed

Re: Question regarding "reserved-memory"

2019-10-24 Thread Rob Herring
On Thu, Oct 24, 2019 at 9:22 AM Ayan Halder wrote: > > > Hi Folks, > > I have a question regarding "reserved-memory". I am using an Arm Juno > platform which has a chunk of ram in its fpga. I intend to make this > memory as reserved so that it can be shared between various devices > for passing fr

[Bug 205277] [amd powerplay] vega10: soc voltage for power state 7 is not changed by overdrive.

2019-10-24 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=205277 --- Comment #5 from har...@gmx.de --- In the (now obsolete) proposed code, the variable 'i' will become 8, when the for-loop is done. The following if-statement will access something outside the array memory. Something like this may work without

Re: [PATCH] drm/prime: Fix mmap fake offset for drm_gem_object_funcs.mmap

2019-10-24 Thread Daniel Vetter
On Thu, Oct 24, 2019 at 4:39 PM Rob Herring wrote: > > On Thu, Oct 24, 2019 at 7:32 AM Daniel Vetter wrote: > > > > On Thu, Oct 24, 2019 at 11:02:40AM +0200, Gerd Hoffmann wrote: > > > On Wed, Oct 23, 2019 at 05:22:26PM -0500, Rob Herring wrote: > > > > Commit c40069cb7bd6 ("drm: add mmap() to dr

Re: [PATCH] drm/dp: Add function to parse EDID descriptors for adaptive sync limits

2019-10-24 Thread Harry Wentland
On 2019-10-23 8:00 p.m., Manasi Navare wrote: > Adaptive Sync is a VESA feature so add a DRM core helper to parse > the EDID's detailed descritors to obtain the adaptive sync monitor range. > Store this info as part fo drm_display_info so it can be used > across all drivers. > This part of the code

[PATCH] drm/tegra: Do not use ->load() and ->unload() callbacks

2019-10-24 Thread Thierry Reding
From: Thierry Reding The ->load() and ->unload() drivers are midlayers and should be avoided in modern drivers. Fix this by moving the code into the driver ->probe() and ->remove() implementations, respectively. Signed-off-by: Thierry Reding --- drivers/gpu/drm/tegra/drm.c | 386 ++

Re: Question regarding "reserved-memory"

2019-10-24 Thread Ayan Halder
On Thu, Oct 24, 2019 at 09:51:04AM -0500, Rob Herring wrote: > On Thu, Oct 24, 2019 at 9:22 AM Ayan Halder wrote: Hi Bob, Thanks for your quick response. > > > > > > Hi Folks, > > > > I have a question regarding "reserved-memory". I am using an Arm Juno > > platform which has a chunk of ram in it

[PULL] drm-misc-next

2019-10-24 Thread Sean Paul
Hi Dave & Daniel, Here's the pull for last week and this week. As you know we had some trouble with the OMAP_BO* additions last week, those have since been reverted. Speaking of UAPI, we have a new DRM_SYNCOBJ_QUERY_FLAGS_LAST_SUBMITTED flag from AMD to get the last signaled timeline value from t

Re: [PATCH v1 2/3] drm/tegra: Fix 2d and 3d clients detaching from IOMMU domain

2019-10-24 Thread Thierry Reding
On Thu, Oct 24, 2019 at 06:47:23PM +0300, Dmitry Osipenko wrote: > 24.10.2019 16:50, Thierry Reding пишет: > > On Thu, Oct 24, 2019 at 04:28:41PM +0300, Dmitry Osipenko wrote: > >> 24.10.2019 14:58, Thierry Reding пишет: > >>> On Sun, Jun 23, 2019 at 08:37:42PM +0300, Dmitry Osipenko wrote: >

Re: [PATCH trivial] drm: Spelling s/connet/connect/

2019-10-24 Thread Daniel Vetter
On Thu, Oct 24, 2019 at 05:17:37PM +0200, Geert Uytterhoeven wrote: > Fix misspellings of "connector" and "connection" > > Signed-off-by: Geert Uytterhoeven Thanks, applied to drm-misc-next. -Daniel > --- > drivers/gpu/drm/gma500/mdfld_dsi_output.c | 2 +- > include/uapi/drm/exynos_drm.h

[Bug 205277] [amd powerplay] vega10: soc voltage for power state 7 is not changed by overdrive.

2019-10-24 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=205277 --- Comment #6 from Pelle van Gils (pe...@vangils.xyz) --- Created attachment 285633 --> https://bugzilla.kernel.org/attachment.cgi?id=285633&action=edit proposed patch v2 -- You are receiving this mail because: You are watching the assignee o

Re: [PATCH] drm/tegra: Do not use ->load() and ->unload() callbacks

2019-10-24 Thread Daniel Vetter
On Thu, Oct 24, 2019 at 05:10:30PM +0200, Thierry Reding wrote: > From: Thierry Reding > > The ->load() and ->unload() drivers are midlayers and should be avoided > in modern drivers. Fix this by moving the code into the driver ->probe() > and ->remove() implementations, respectively. > > Signed

[Bug 205277] [amd powerplay] vega10: soc voltage for power state 7 is not changed by overdrive.

2019-10-24 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=205277 --- Comment #7 from Pelle van Gils (pe...@vangils.xyz) --- (In reply to haro41 from comment #3) > Did you debug this issue? I think the problem could be outside this code. > > I would outcomment the if-statement following for-loop in your propos

[Bug 205277] [amd powerplay] vega10: soc voltage for power state 7 is not changed by overdrive.

2019-10-24 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=205277 Pelle van Gils (pe...@vangils.xyz) changed: What|Removed |Added Kernel Version|5.4.0-rc3 |5.4.0-rc4 -- You ar

[Bug 111481] AMD Navi GPU frequent freezes on both Manjaro/Ubuntu with kernel 5.3 and mesa 19.2 -git/llvm9

2019-10-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111481 --- Comment #153 from Marko Popovic --- (In reply to L.S.S. from comment #152) > UPDATE: I just got another freeze on 5.3.6 kernel. The same > GCVM_L2_PROTECTION_FAULT error followed by a ring sdma0 timeout. > > So it seems AMD_DEBUG="nodma non

[RESEND PATCH v4] drm: Don't free jobs in wait_event_interruptible()

2019-10-24 Thread Steven Price
drm_sched_cleanup_jobs() attempts to free finished jobs, however because it is called as the condition of wait_event_interruptible() it must not sleep. Unfortuantly some free callbacks (notibly for Panfrost) do sleep. Instead let's rename drm_sched_cleanup_jobs() to drm_sched_get_cleanup_job() and

  1   2   >