Re: [PATCH v3 0/8] drm/omap: OMAP_BO flags

2019-10-09 Thread Tomi Valkeinen
On 08/10/2019 19:08, Jean-Jacques Hiblot wrote: On 07/10/2019 14:16, Tomi Valkeinen wrote: On 07/10/2019 14:25, Jean-Jacques Hiblot wrote: A first version of this work had been sent by Tomi Valkeinen in may 2017 (https://www.spinics.net/lists/dri-devel/msg140663.html). This series adds a few

[PATCH 3/3] drm/amd/display: Remove set but not used variables 'regval', 'speakers'

2019-10-09 Thread zhengbin
Fixes gcc '-Wunused-but-set-variable' warning: drivers/gpu/drm/amd/display/dc/dce/dce_stream_encoder.c: In function dce110_update_generic_info_packet: drivers/gpu/drm/amd/display/dc/dce/dce_stream_encoder.c:68:11: warning: variable regval set but not used [-Wunused-but-set-variable] drivers/gpu/

[PATCH 0/3] drm/amd/display/dc/dce: remove some not used variables

2019-10-09 Thread zhengbin
zhengbin (3): drm/amd/display: Remove set but not used variables 'bl_pwm_cntl','pwm_period_cntl' drm/amd/display: Remove set but not used variable 'value0' drm/amd/display: Remove set but not used variables 'regval','speakers' drivers/gpu/drm/amd/display/dc/dce/dce_abm.c| 8

XDC 2019 feedback and comments

2019-10-09 Thread Samuel Iglesias Gonsálvez
Hi all, Once more huge thanks to the entire team from Collabora, for their great work organizing XDC 2019! As usual we're looking for feedback on both XDC itself, and the CFP process and program selection. Both about what was great and should be kept for next year's edition, and where there's roo

Re: [PATCHv2 7/7] drm/omap: hdmi4: fix use of uninitialized var

2019-10-09 Thread Tony Lindgren
* Tomi Valkeinen [190930 10:38]: > If use_mclk is false, mclk_mode is written to a register without > initialization. This doesn't cause any ill effects as the written value > is not used when use_mclk is false. > > To fix this, write use_mclk only when use_mclk is true. Hey nice catch. Based on

[PATCH 2/3] drm/amd/display: Remove set but not used variable 'value0'

2019-10-09 Thread zhengbin
Fixes gcc '-Wunused-but-set-variable' warning: drivers/gpu/drm/amd/display/dc/dce/dce_link_encoder.c: In function dce110_link_encoder_update_mst_stream_allocation_table: drivers/gpu/drm/amd/display/dc/dce/dce_link_encoder.c:1229:11: warning: variable value0 set but not used [-Wunused-but-set-var

Re: XDC 2019 feedback and comments

2019-10-09 Thread Samuel Iglesias Gonsálvez
On Tue, 2019-10-08 at 17:27 +0200, Samuel Iglesias Gonsálvez wrote: > Hi all, > > Once more huge thanks to the entire team from Collabora, > for their great work organizing XDC 2019! > > As usual we're looking for feedback on both XDC itself, and the CFP > process and program selection. Both abou

Re: [PATCH v1 1/2] drm_dp_cec: drop use of drmP.h

2019-10-09 Thread Hans Verkuil
On 10/7/19 7:12 PM, Sam Ravnborg wrote: > drmP.h is deprecated and will be deleted. > Replace use with proper header. > > Divide header includes in blocks while touching these. > > Build tested with various archtectures and configs. Acked-by: Hans Verkuil Regards, Hans > > Signed-of

[PATCH 1/3] drm/amd/display: Remove set but not used variables 'bl_pwm_cntl', 'pwm_period_cntl'

2019-10-09 Thread zhengbin
Fixes gcc '-Wunused-but-set-variable' warning: drivers/gpu/drm/amd/display/dc/dce/dce_abm.c: In function calculate_16_bit_backlight_from_pwm: drivers/gpu/drm/amd/display/dc/dce/dce_abm.c:83:11: warning: variable bl_pwm_cntl set but not used [-Wunused-but-set-variable] drivers/gpu/drm/amd/display

Re: [PATCHv2 7/7] drm/omap: hdmi4: fix use of uninitialized var

2019-10-09 Thread Tony Lindgren
* Tomi Valkeinen [191008 14:17]: > On 08/10/2019 17:13, Tony Lindgren wrote: > > * Tomi Valkeinen [190930 10:38]: > > > If use_mclk is false, mclk_mode is written to a register without > > > initialization. This doesn't cause any ill effects as the written value > > > is not used when use_mclk is

[PATCH 1/5] drm/nouveau/gr/gf100-: make undeclared symbols static

2019-10-09 Thread Ben Dooks
The following functions are not declared outside of the file they are in, so make them static to avoid these warnings: drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c:745:1: warning: symbol 'gf100_gr_fecs_start_ctxsw' was not declared. Should it be static? drivers/gpu/drm/nouveau/nvkm/engine/gr/gf

Re: [PATCH] drm/komeda: Set output color depth for output

2019-10-09 Thread Lowry Li (Arm Technology China)
Hi Mihail, On Tue, Oct 08, 2019 at 11:18:56AM +, Mihail Atanassov wrote: > On Tuesday, 8 October 2019 11:28:24 BST Lowry Li (Arm Technology China) wrote: > > Hi Brian, > > On Tue, Oct 08, 2019 at 09:36:09AM +, Brian Starkey wrote: > > > Hi Lowry, > > > > > > On Tue, Oct 08, 2019 at 09:17:5

Re: [pull] ttm drm-fixes-5.4

2019-10-09 Thread Arkadiusz Hiler
On Tue, Oct 08, 2019 at 09:13:41AM -0400, Alex Deucher wrote: > On Tue, Oct 8, 2019 at 4:04 AM Koenig, Christian > wrote: > > > > My git version should be relative new, but I'm usually using thunderbird > > to send pull requests not git itself since I want to edit the message > > before sending. >

Re: [PATCH RESEND] gpu: drm: bridge: analogix-anx78xx: convert to i2c_new_dummy_device

2019-10-09 Thread Laurent Pinchart
Hi Wolfram, Thank you for the patch. On Tue, Oct 08, 2019 at 10:31:45PM +0200, Wolfram Sang wrote: > Move from the deprecated i2c_new_dummy() to i2c_new_dummy_device(). We > now get an ERRPTR which we use in error handling. > > Signed-off-by: Wolfram Sang Reviewed-by: Laurent Pinchart > ---

[PATCH v2] drm/i915: customize DPCD brightness control for specific panel

2019-10-09 Thread Lee Shawn C
This panel (manufacturer is SDC, product ID is 0x4141) used manufacturer defined DPCD register to control brightness that not defined in eDP spec so far. This change follow panel vendor's instruction to support brightness adjustment. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=97883 V2

Re: [PATCH RESEND] gpu: drm: bridge: sii9234: convert to devm_i2c_new_dummy_device

2019-10-09 Thread Laurent Pinchart
Hi Wolfram, Thank you for the patch. On Tue, Oct 08, 2019 at 10:33:22PM +0200, Wolfram Sang wrote: > Move from the deprecated i2c_new_dummy() to devm_i2c_new_dummy_device(). > We now get an ERRPTR which we use in error handling and we can skip > removal of the created devices. > > Signed-off-by:

[PATCH v10 0/6] Add a generic driver for LED-based backlight

2019-10-09 Thread Jean-Jacques Hiblot
This series aims to add a led-backlight driver, similar to pwm-backlight, but using a LED class device underneath. A few years ago (2015), Tomi Valkeinen posted a series implementing a backlight driver on top of a LED device: https://patchwork.kernel.org/patch/7293991/ https://patchwork.kernel.org

[PATCH v10 1/6] leds: populate the device's of_node

2019-10-09 Thread Jean-Jacques Hiblot
If initialization data is available and its fwnode is actually a of_node, store this information in the led device's structure. This will allow the device to use or provide OF-based API such (devm_xxx). Signed-off-by: Jean-Jacques Hiblot --- drivers/leds/led-class.c | 4 +++- 1 file changed, 3 i

[PATCH v10 2/6] leds: Add of_led_get() and led_put()

2019-10-09 Thread Jean-Jacques Hiblot
From: Tomi Valkeinen This patch adds basic support for a kernel driver to get a LED device. This will be used by the led-backlight driver. Only OF version is implemented for now, and the behavior is similar to PWM's of_pwm_get() and pwm_put(). Signed-off-by: Tomi Valkeinen Signed-off-by: Jean-

[PATCH v10 3/6] leds: Add managed API to get a LED from a device driver

2019-10-09 Thread Jean-Jacques Hiblot
If the LED is acquired by a consumer device with devm_led_get(), it is automatically released when the device is detached. Signed-off-by: Jean-Jacques Hiblot Acked-by: Pavel Machek --- drivers/leds/led-class.c | 49 include/linux/leds.h | 2 ++ 2 fi

[PATCH v10 4/6] dts-bindings: leds: Document the naming requirement for LED properties

2019-10-09 Thread Jean-Jacques Hiblot
LED properties must be named "leds" in the same way that PWM, clocks or PHY properties are names respectively "pwms", "clocks" and "phys". Cc: devicet...@vger.kernel.org Signed-off-by: Jean-Jacques Hiblot --- .../devicetree/bindings/leds/common.txt | 20 --- 1 file changed,

[PATCH v10 5/6] dt-bindings: backlight: Add led-backlight binding

2019-10-09 Thread Jean-Jacques Hiblot
Add DT binding for led-backlight. Cc: devicet...@vger.kernel.org Signed-off-by: Jean-Jacques Hiblot --- .../leds/backlight/led-backlight.yaml | 55 +++ 1 file changed, 55 insertions(+) create mode 100644 Documentation/devicetree/bindings/leds/backlight/led-backlight.ya

[PATCH v10 6/6] backlight: add led-backlight driver

2019-10-09 Thread Jean-Jacques Hiblot
From: Tomi Valkeinen This patch adds a led-backlight driver (led_bl), which is similar to pwm_bl except the driver uses a LED class driver to adjust the brightness in the HW. Multiple LEDs can be used for a single backlight. Signed-off-by: Tomi Valkeinen Signed-off-by: Jean-Jacques Hiblot Acke

Re: drm/komeda: Use devm_platform_ioremap_resource() in komeda_dev_create()

2019-10-09 Thread james qian wang (Arm Technology China)
On Sat, Sep 21, 2019 at 07:50:46PM +0200, Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 21 Sep 2019 19:43:51 +0200 > > Simplify this function implementation by using a known wrapper function. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elf

RE: [PATCH] drm/i915: customize DPCD brightness control for specific panel

2019-10-09 Thread Lee, Shawn C
On Tue, 08 Oct 2019, Jani Nikula wrote: >On Mon, 07 Oct 2019, Adam Jackson wrote: >> On Mon, 2019-10-07 at 12:08 +0300, Jani Nikula wrote: >> >>> The problem with the EDID quirks is that exposing the quirks sticks out >>> like a sore thumb. Thus far all of it has been contained in drm_edid.c >>>

Re: [PATCH v5, 17/32] drm/mediatek: add component DITHER

2019-10-09 Thread CK Hu
Hi, Yongqiang: On Thu, 2019-08-29 at 22:50 +0800, yongqiang@mediatek.com wrote: > From: Yongqiang Niu > > This patch add component DITHER > Applied to mediatek-drm-next-5.5 [1], thanks. [1] https://github.com/ckhu-mediatek/linux.git-tags/commits/mediatek-drm-next-5.5 Regards, CK > Signe

[Bug 111933] driconf-0.9.1-r2 - assert iter or allowNone

2019-10-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111933 Michel Dänzer changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Bug 111932] driconf: TypeError: cannot concatenate 'str' and 'int' objects

2019-10-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111932 Michel Dänzer changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [PATCH v5, 15/32] drm/mediatek: add commponent OVL_2L0

2019-10-09 Thread CK Hu
Hi, Yongqiang: On Thu, 2019-08-29 at 22:50 +0800, yongqiang@mediatek.com wrote: > From: Yongqiang Niu > > This patch add commponent OVL_2L0 > Applied to mediatek-drm-next-5.5 [1], thanks. [1] https://github.com/ckhu-mediatek/linux.git-tags/commits/mediatek-drm-next-5.5 Regards, CK > Sig

Re: [PATCH v5, 14/32] drm/mediatek: add ddp component CCORR

2019-10-09 Thread CK Hu
Hi, Yongqiang: On Thu, 2019-08-29 at 22:50 +0800, yongqiang@mediatek.com wrote: > From: Yongqiang Niu > > This patch add ddp component CCORR > Applied to mediatek-drm-next-5.5 [1], thanks. [1] https://github.com/ckhu-mediatek/linux.git-tags/commits/mediatek-drm-next-5.5 Regards, CK > Si

Re: [PATCH v5, 16/32] drm/mediatek: add component OVL_2L1

2019-10-09 Thread CK Hu
Hi, Yongqiang: On Thu, 2019-08-29 at 22:50 +0800, yongqiang@mediatek.com wrote: > From: Yongqiang Niu > > This patch add component OVL_2L1 > Applied to mediatek-drm-next-5.5 [1], thanks. [1] https://github.com/ckhu-mediatek/linux.git-tags/commits/mediatek-drm-next-5.5 Regards, CK > Sign

Re: [PATCH v5, 18/32] drm/mediatek: add gmc_bits for ovl private data

2019-10-09 Thread CK Hu
Hi, Yongqiang: On Thu, 2019-08-29 at 22:50 +0800, yongqiang@mediatek.com wrote: > From: Yongqiang Niu > > This patch add gmc_bits for ovl private data > GMC register was set RDMA ultra and pre-ultra threshold. > 10bit GMC register define is different with other SOC, gmc_thrshd_l not > used.

Re: [PATCH v5, 19/32] drm/medaitek: add layer_nr for ovl private data

2019-10-09 Thread CK Hu
Hi, Yongqiang: On Thu, 2019-08-29 at 22:50 +0800, yongqiang@mediatek.com wrote: > From: Yongqiang Niu > > This patch add layer_nr for ovl private data > ovl_2l almost same with with ovl hardware, except the > layer number for ovl_2l is 2 and ovl is 4. > this patch is a preparation for ovl-2l

Re: [PATCH v5, 20/32] drm/mediatek: add function to background color input select for ovl/ovl_2l direct link

2019-10-09 Thread CK Hu
Hi, Yongqiang: On Thu, 2019-08-29 at 22:50 +0800, yongqiang@mediatek.com wrote: > From: Yongqiang Niu > > This patch add function to background color input select for ovl/ovl_2l > direct link > for ovl/ovl_2l direct link usecase, we need set background color > input select for these hardwar

Re: [PATCH v5, 21/32] drm/mediatek: add background color input select function for ovl/ovl_2l

2019-10-09 Thread CK Hu
Hi, Yongqiang: On Thu, 2019-08-29 at 22:50 +0800, yongqiang@mediatek.com wrote: > From: Yongqiang Niu > > This patch add background color input select function for ovl/ovl_2l > > ovl include 4 DRAM layer and 1 background color layer > ovl_2l include 4 DRAM layer and 1 background color layer

[PATCH v2 0/2] Add initial support for slimport anx7625

2019-10-09 Thread Xin Ji
Hi all, The following series add initial support for the Slimport ANX7625 transmitter, a ultra-low power Full-HD 4K MIPI to DP transmitter designed for portable device. This is the initial version, any mistakes, please let me know, I will fix it in the next series. Thanks, Xin Xin Ji (2): dt

[PATCH v2 1/2] dt-bindings: drm/bridge: anx7625: MIPI to DP transmitter binding

2019-10-09 Thread Xin Ji
The ANX7625 is an ultra-low power 4K Mobile HD Transmitter designed for portable device. It converts MIPI to DisplayPort 1.3 4K. You can add support to your board with binding. Example: anx_bridge: anx7625@58 { compatible = "analogix,anx7625"; reg = <0x58>;

Re: [PATCH v5, 23/32] drm/mediatek: distinguish ovl and ovl_2l by layer_nr

2019-10-09 Thread CK Hu
Hi, Yongqiang: On Thu, 2019-08-29 at 22:50 +0800, yongqiang@mediatek.com wrote: > From: Yongqiang Niu > > distinguish ovl and ovl_2l by layer_nr when get comp > id > Applied to mediatek-drm-next-5.5 [1], thanks. [1] https://github.com/ckhu-mediatek/linux.git-tags/commits/mediatek-drm-next

[PATCH v2 2/2] drm/bridge: anx7625: Add anx7625 MIPI DSI/DPI to DP bridge driver

2019-10-09 Thread Xin Ji
The ANX7625 is an ultra-low power 4K Mobile HD Transmitter designed for portable device. It converts MIPI DSI/DPI to DisplayPort 1.3 4K. The ANX7625 can support both USB Type-C PD feature and MIPI DSI/DPI to DP feature. This driver only enabled MIPI DSI/DPI to DP feature. Signed-off-by: Xin Ji -

Re: [PATCH v5, 22/32] drm/mediatek: add ovl0/ovl_2l0 usecase

2019-10-09 Thread CK Hu
Hi, Yongqiang: On Thu, 2019-08-29 at 22:50 +0800, yongqiang@mediatek.com wrote: > From: Yongqiang Niu > > This patch add ovl0/ovl_2l0 usecase > in ovl->ovl_2l0 direct link usecase: > 1. the crtc support layer number will 4+2 > 2. ovl_2l0 background color input select ovl0 when crtc init > an

Re: [PATCH v5, 07/32] drm/mediatek: add mutex mod into ddp private data

2019-10-09 Thread CK Hu
Hi, Yongqiang: On Thu, 2019-08-29 at 22:50 +0800, yongqiang@mediatek.com wrote: > From: Yongqiang Niu > > except mutex mod, mutex mod reg,mutex sof reg, > and mutex sof id will be ddp private data > Applied to mediatek-drm-next-5.5 [1], thanks. [1] https://github.com/ckhu-mediatek/linux.g

Re: [PATCH v5, 08/32] drm/mediatek: add mutex mod register offset into ddp private data

2019-10-09 Thread CK Hu
Hi, Yongqiang: On Thu, 2019-08-29 at 22:50 +0800, yongqiang@mediatek.com wrote: > From: Yongqiang Niu > > mutex mod register offset will be private data of ddp. > Applied to mediatek-drm-next-5.5 [1], thanks. [1] https://github.com/ckhu-mediatek/linux.git-tags/commits/mediatek-drm-next-5.

Re: [PATCH v5, 09/32] drm/mediatek: add mutex sof into ddp private data

2019-10-09 Thread CK Hu
Hi, Yongqiang: On Thu, 2019-08-29 at 22:50 +0800, yongqiang@mediatek.com wrote: > From: Yongqiang Niu > > mutex sof will be ddp private data > Applied to mediatek-drm-next-5.5 [1], thanks. [1] https://github.com/ckhu-mediatek/linux.git-tags/commits/mediatek-drm-next-5.5 Regards, CK > Si

Re: [PATCH v5, 10/32] drm/mediatek: add mutex sof register offset into ddp private data

2019-10-09 Thread CK Hu
Hi, Yongqiang: On Thu, 2019-08-29 at 22:50 +0800, yongqiang@mediatek.com wrote: > From: Yongqiang Niu > > mutex sof register offset will be private data of ddp > Applied to mediatek-drm-next-5.5 [1], thanks. [1] https://github.com/ckhu-mediatek/linux.git-tags/commits/mediatek-drm-next-5.5

[PATCH 2/2] drm/fb-helper: include drm_crtc_helper_internal.h for drm_fb_helper_modinit

2019-10-09 Thread Ben Dooks
Include drm_crtc_helper_internal.h for drm_fb_helper_modinit definition to fix the following warning: drivers/gpu/drm/drm_fb_helper.c:2410:12: warning: symbol 'drm_fb_helper_modinit' was not declared. Should it be static? Signed-off-by: Ben Dooks --- drivers/gpu/drm/drm_fb_helper.c | 1 + 1 fi

[PATCH][next] drm/i915: remove redundant variable err

2019-10-09 Thread Colin King
From: Colin Ian King An earlier commit removed any error assignments to err and we are now left with a zero assignment to err and a check that is always false. Clean this up by removing the redundant variable err and the error check. Addresses-Coverity: ("'Constant' variable guard") Signed-off-b

Re: [PATCH] drm/panfrost: Handle resetting on timeout better

2019-10-09 Thread Steven Price
On 07/10/2019 17:14, Tomeu Vizoso wrote: > On 10/7/19 6:09 AM, Neil Armstrong wrote: >> Hi Steven, >> >> On 07/10/2019 14:50, Steven Price wrote: >>> Panfrost uses multiple schedulers (one for each slot, so 2 in reality), >>> and on a timeout has to stop all the schedulers to safely perform a >>> r

[PATCH v2 2/2] drm/panfrost: Remove commented out call to panfrost_core_dump

2019-10-09 Thread Steven Price
panfrost_core_dump() has never existed in mainline, so remove it and add a TODO entry that core dump support is currently lacking. Signed-off-by: Steven Price --- v2: * New patch drivers/gpu/drm/panfrost/TODO | 2 ++ drivers/gpu/drm/panfrost/panfrost_job.c | 2 -- 2 files changed, 2

[PATCH v2 1/2] drm/panfrost: Handle resetting on timeout better

2019-10-09 Thread Steven Price
Panfrost uses multiple schedulers (one for each slot, so 2 in reality), and on a timeout has to stop all the schedulers to safely perform a reset. However more than one scheduler can trigger a timeout at the same time. This race condition results in jobs being freed while they are still in use. Wh

Re: [PATCH v5, 00/32] add drm support for MT8183

2019-10-09 Thread CK Hu
Hi, Yongqiang: To make process more smoothly, I've applied some stable patches of this series in mediatek-drm-next-5.5 [1]. The applied patches include dt-bindings, CCORR, DITHER, OVL, Mutex related patches. The non-applied patches include mmsys related patches. Please based on the applied patches

Re: [PATCH][next] drm/i915: remove redundant variable err

2019-10-09 Thread Chris Wilson
Quoting Colin King (2019-10-09 10:39:35) > From: Colin Ian King > > An earlier commit removed any error assignments to err and we > are now left with a zero assignment to err and a check that is > always false. Clean this up by removing the redundant variable > err and the error check. Oh, we ad

Re: [PATCH][next] drm/i915: remove redundant variable err

2019-10-09 Thread Jani Nikula
On Wed, 09 Oct 2019, Colin King wrote: > From: Colin Ian King > > An earlier commit removed any error assignments to err and we > are now left with a zero assignment to err and a check that is > always false. Clean this up by removing the redundant variable > err and the error check. > > Addresse

[PATCH][next] drm/i915/selftests: fix null pointer dereference on pointer data

2019-10-09 Thread Colin King
From: Colin Ian King In the case where data fails to be allocated the error exit path is via label 'out' where data is dereferenced in a for-loop. Fix this by exiting via the label 'out_file' instead to avoid the null pointer dereference. Addresses-Coverity: ("Dereference after null check") Fix

Re: [PATCH v5, 24/32] drm/mediatek: add clock property check before get it

2019-10-09 Thread CK Hu
Hi, Yongqiang: On Thu, 2019-08-29 at 22:50 +0800, yongqiang@mediatek.com wrote: > From: Yongqiang Niu > > This patch add clock property check before get it > I've rewrite this patch and applied to mediatek-drm-next-5.5 [1] with the title "drm/mediatek: add no_clk into ddp private data", th

Re: [PATCH][next] drm/i915/selftests: fix null pointer dereference on pointer data

2019-10-09 Thread Chris Wilson
Quoting Colin King (2019-10-09 11:00:24) > From: Colin Ian King > > In the case where data fails to be allocated the error exit path is > via label 'out' where data is dereferenced in a for-loop. Fix this > by exiting via the label 'out_file' instead to avoid the null pointer > dereference. > >

[Bug 204885] ryzen 2500U cause graphics glitch in all browsers with kernel version 5.2.x+

2019-10-09 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=204885 no2stable (pro...@outlook.com) changed: What|Removed |Added Status|NEW |RESOLVED Res

[Bug 107877] deepin-desktop: xdg-email: no method available for opening 'mailto:'

2019-10-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107877 --- Comment #32 from Michael D. Dahle --- If you need any technical help in the Linksys extender setup, you can navigate to https://linksyssmartwifi.site/linksys-extender-setup/ to get the best assistance. -- You are receiving this mail becaus

Re: [PATCH RFC v4 14/16] drm, cgroup: Introduce lgpu as DRM cgroup resource

2019-10-09 Thread Daniel Vetter
On Tue, Oct 08, 2019 at 06:53:18PM +, Kuehling, Felix wrote: > On 2019-08-29 2:05 a.m., Kenny Ho wrote: > > drm.lgpu > > A read-write nested-keyed file which exists on all cgroups. > > Each entry is keyed by the DRM device's major:minor. > > > > lgpu stands for logica

Re: [PATCH v3 1/8] drm/omap: use refcount API to track the number of users of dma_addr

2019-10-09 Thread Tomi Valkeinen
Hi JJ, On 07/10/2019 14:25, Jean-Jacques Hiblot wrote: This would give us a WARN_ON() if the pin/unpin calls are unbalanced. Proposed-by: Laurent Pinchart Signed-off-by: Jean-Jacques Hiblot Reviewed-by: Tomi Valkeinen --- This doesn't compile, but it gets fixed in some later patch in the s

Re: [PATCH v2] drm/vkms: Fix an undefined reference error in vkms_composer_worker

2019-10-09 Thread Daniel Vetter
On Mon, Sep 23, 2019 at 09:24:43AM +0800, zhong jiang wrote: > I hit the following error when compile the kernel. > > drivers/gpu/drm/vkms/vkms_composer.o: In function `vkms_composer_worker': > vkms_composer.c:(.text+0x5e4): undefined reference to `crc32_le' > make: *** [vmlinux] Error 1 > > Sign

[Bug 111921] GPU crash on VegaM (amdgpu: The CS has been rejected)

2019-10-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111921 --- Comment #5 from Rémi Verschelde --- (In reply to Andrey Grodzovsky from comment #4) > What happens if you disable GPU reset by loading the kernel with > amdgpu.gpu_recovery=0 ? Good point, I forgot to mention that I added `amdgpu.dc=0 amdgp

[Bug 111921] GPU crash on VegaM (amdgpu: The CS has been rejected)

2019-10-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111921 --- Comment #6 from Rémi Verschelde --- Created attachment 145681 --> https://bugs.freedesktop.org/attachment.cgi?id=145681&action=edit dmesg output after GPU crash with "amdgpu: The CS has been rejected" The terminal output matching this cra

[Bug 111921] GPU crash on VegaM (amdgpu: The CS has been rejected)

2019-10-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111921 --- Comment #7 from Rémi Verschelde --- Created attachment 145682 --> https://bugs.freedesktop.org/attachment.cgi?id=145682&action=edit dmesg output running kernel 5.1.20 and resuming from screensaver, no bug -- You are receiving this mail b

[Bug 111921] GPU crash on VegaM (amdgpu: The CS has been rejected)

2019-10-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111921 --- Comment #8 from Rémi Verschelde --- (In reply to Andrey Grodzovsky from comment #2) > Hey, I noticed a lot of 'amdgpu :01:00.0: GPU pci config reset' there. These actually happen every time I change the focus between an application runn

Re: [1/3] drm/tinydrm/Kconfig: Remove menuconfig DRM_TINYDRM

2019-10-09 Thread Daniel Vetter
On Tue, Oct 01, 2019 at 04:07:38PM +0200, Noralf Trønnes wrote: > Hi drm-misc maintainers, > > I have just applied a patch to drm-misc-next that as it turns out should > have been applied to -fixes for this -rc cycle. > > Should I cherry pick it to drm-misc-next-fixes? Yup, cherry pick and refer

Re: [PATCH] drm/meson: fix max mode_config height/width

2019-10-09 Thread Daniel Vetter
On Tue, Sep 24, 2019 at 10:28:48AM -0700, Jeykumar Sankaran wrote: > Reviving this thread from the context of the below conversion: > > https://lore.kernel.org/linux-arm-msm/db26145b-3f64-a334-f698-76f972332...@baylibre.com/T/#u > > On 2018-10-05 01:19, Neil Armstrong wrote: > > On 05/10/2018 09:

Re: [PATCH v10 1/6] leds: populate the device's of_node

2019-10-09 Thread Tomi Valkeinen
Hi JJ, On 09/10/2019 11:51, Jean-Jacques Hiblot wrote: If initialization data is available and its fwnode is actually a of_node, store this information in the led device's structure. This will allow the device to use or provide OF-based API such (devm_xxx). Signed-off-by: Jean-Jacques Hiblot -

Re: [PATCH v2 2/2] drm/bridge: anx7625: Add anx7625 MIPI DSI/DPI to DP bridge driver

2019-10-09 Thread Dan Carpenter
Are you sure you sent the correct patch? This has many of the same style issues I mentioned in the previous email. The error handling in edid_read() is wrong. probe() will still crash if allocating the work queue fails. On Wed, Oct 09, 2019 at 09:28:02AM +, Xin Ji wrote: > The ANX7625 is an

Re: [PATCH v2 1/2] dt-bindings: drm/bridge: anx7625: MIPI to DP transmitter binding

2019-10-09 Thread Laurent Pinchart
Hi Xin Ji, Thank you for the patch. On Wed, Oct 09, 2019 at 09:27:07AM +, Xin Ji wrote: > The ANX7625 is an ultra-low power 4K Mobile HD Transmitter designed > for portable device. It converts MIPI to DisplayPort 1.3 4K. > > You can add support to your board with binding. > > Example: >

Re: [PATCH v2] drm/edid: Select DMT timing if EDID's display feature not support GTF

2019-10-09 Thread Ville Syrjälä
On Mon, Oct 07, 2019 at 09:51:27PM +0800, Lee Shawn C wrote: > Refer to EDID 1.3 spec, display FEATURE (byte 18h) bit #0 said > "If this bit is set to 1, the display supports timings based on the > GTF standard using default GTF parameter values". > > And EDID 1.4 spec shows "If bit 0 is set to 0,

Re: [1/3] drm/tinydrm/Kconfig: Remove menuconfig DRM_TINYDRM

2019-10-09 Thread Noralf Trønnes
Den 09.10.2019 12.45, skrev Daniel Vetter: > On Tue, Oct 01, 2019 at 04:07:38PM +0200, Noralf Trønnes wrote: >> Hi drm-misc maintainers, >> >> I have just applied a patch to drm-misc-next that as it turns out should >> have been applied to -fixes for this -rc cycle. >> >> Should I cherry pick it

[tip: locking/core] locking/lockdep: Remove unused @nested argument from lock_release()

2019-10-09 Thread tip-bot2 for Qian Cai
The following commit has been merged into the locking/core branch of tip: Commit-ID: 5facae4f3549b5cf7c0e10ec312a65ffd43b5726 Gitweb: https://git.kernel.org/tip/5facae4f3549b5cf7c0e10ec312a65ffd43b5726 Author:Qian Cai AuthorDate:Thu, 19 Sep 2019 12:09:40 -04:00 Committer:

Re: [PATCH v2 2/2] drm/bridge: anx7625: Add anx7625 MIPI DSI/DPI to DP bridge driver

2019-10-09 Thread Dan Carpenter
On Wed, Oct 09, 2019 at 02:30:32PM +0300, Dan Carpenter wrote: > > + platform = kzalloc(sizeof(*platform), GFP_KERNEL); > > + if (!platform) { > > + DRM_DEV_ERROR(dev, "failed to allocate driver data\n"); > > + ret = -ENOMEM; > > + goto exit; > > return -ENOMEM; >

Re: [PATCH 2/4] drm/ttm: use the parent resv for ghost objects v2

2019-10-09 Thread Christian König
Am 08.10.19 um 11:25 schrieb Daniel Vetter: On Thu, Aug 29, 2019 at 04:29:15PM +0200, Christian König wrote: This way we can even pipeline imported BO evictions. v2: Limit this to only cases when the parent object uses a separate reservation object as well. This fixes another OOM problem.

[PATCH] drm/nouveau/falcon: make unexported objects static

2019-10-09 Thread Ben Dooks
Make the msgqueue_0148cdec_acr_func and msgqueue_0148cdec_func static to avoid the following sparse warnings: drivers/gpu/drm/nouveau/nvkm/falcon/msgqueue_0148cdec.c:230:1: warning: symbol 'msgqueue_0148cdec_acr_func' was not declared. Should it be static? drivers/gpu/drm/nouveau/nvkm/falcon/msgq

Re: [PATCH 1/3] dma-buf: add dma_resv_ctx for deadlock handling

2019-10-09 Thread Christian König
Am 08.10.19 um 17:16 schrieb Daniel Vetter: On Wed, Sep 18, 2019 at 07:55:23PM +0200, Christian König wrote: The ww_mutex framework allows for detecting deadlocks when multiple threads try to acquire the same set of locks in different order. The problem is that handling those deadlocks was the

[PATCH] drm/rockchip: include rockchip_drm_drv.h

2019-10-09 Thread Ben Dooks
Include rockchip_drm_drv.h for definition of vop_platform_driver to avoid the following sparse warning: drivers/gpu/drm/rockchip/rockchip_vop_reg.c:982:24: warning: symbol 'vop_platform_driver' was not declared. Should it be static? Signed-off-by: Ben Dooks --- Cc: Sandy Huang Cc: "Heiko Stübn

Re: [1/3] drm/tinydrm/Kconfig: Remove menuconfig DRM_TINYDRM

2019-10-09 Thread Maxime Ripard
On Wed, Oct 09, 2019 at 02:48:20PM +0200, Noralf Trønnes wrote: > Den 09.10.2019 12.45, skrev Daniel Vetter: > > On Tue, Oct 01, 2019 at 04:07:38PM +0200, Noralf Trønnes wrote: > >> Hi drm-misc maintainers, > >> > >> I have just applied a patch to drm-misc-next that as it turns out should > >> have

Re: [PATCH 2/4] drm/ttm: use the parent resv for ghost objects v2

2019-10-09 Thread Daniel Vetter
On Wed, Oct 09, 2019 at 03:10:09PM +0200, Christian König wrote: > Am 08.10.19 um 11:25 schrieb Daniel Vetter: > > On Thu, Aug 29, 2019 at 04:29:15PM +0200, Christian König wrote: > > > This way we can even pipeline imported BO evictions. > > > > > > v2: Limit this to only cases when the parent ob

[Bug 111921] GPU crash on VegaM (amdgpu: The CS has been rejected)

2019-10-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111921 --- Comment #9 from Andrey Grodzovsky --- (In reply to Rémi Verschelde from comment #8) > (In reply to Andrey Grodzovsky from comment #2) > > Hey, I noticed a lot of 'amdgpu :01:00.0: GPU pci config reset' there. > > These actually happen e

Re: [PATCH 1/3] dma-buf: add dma_resv_ctx for deadlock handling

2019-10-09 Thread Daniel Vetter
On Wed, Oct 09, 2019 at 03:21:06PM +0200, Christian König wrote: > Am 08.10.19 um 17:16 schrieb Daniel Vetter: > > On Wed, Sep 18, 2019 at 07:55:23PM +0200, Christian König wrote: > > > The ww_mutex framework allows for detecting deadlocks when multiple > > > threads try to acquire the same set of

Re: [PATCH v3 00/11] drm: rework mmap() workflow

2019-10-09 Thread Daniel Vetter
On Thu, Sep 19, 2019 at 12:02:12PM +0200, Gerd Hoffmann wrote: > Add mmap callback to struct drm_gem_object_funcs, which is supposed to > handle the vma setup. It will be used by both normal fops->mmap (via > drm_gem_mmap_obj()) and prime mmap (via drm_gem_prime_mmap()). > > For starters the shme

Re: [PATCH v2 1/3] drm: Add some new format DRM_FORMAT_NVXX_10

2019-10-09 Thread Daniel Vetter
On Thu, Sep 26, 2019 at 04:24:47PM +0800, Sandy Huang wrote: > These new format is supported by some rockchip socs: > > DRM_FORMAT_NV12_10/DRM_FORMAT_NV21_10 > DRM_FORMAT_NV16_10/DRM_FORMAT_NV61_10 > DRM_FORMAT_NV24_10/DRM_FORMAT_NV42_10 > > Signed-off-by: Sandy Huang > --- > drivers/gpu/drm/dr

[Bug 111921] GPU crash on VegaM (amdgpu: The CS has been rejected)

2019-10-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111921 --- Comment #10 from Rémi Verschelde --- (In reply to Andrey Grodzovsky from comment #9) > > So i guess the problem only happens when you run in DRI PRIME mode when > different apps render of off different GPUs ? Probably, but that's the only

Re: [PATCH 1/6] drm/gem: refine drm_gem_objects_lookup

2019-10-09 Thread Daniel Vetter
On Fri, Sep 27, 2019 at 08:09:52AM +0800, Qiang Yu wrote: > On Thu, Sep 26, 2019 at 11:01 PM Rob Herring wrote: > > > > On Thu, Sep 26, 2019 at 9:12 AM Qiang Yu wrote: > > > > > > Do not use user space bo handles directly and left the user > > > to kernel copy work to drivers calling this functio

Re: [PATCH 5/6] drm/amdgpu/dm/mst: Report possible_crtcs incorrectly, for now

2019-10-09 Thread Daniel Vetter
On Fri, Sep 27, 2019 at 11:27:41AM -0400, Sean Paul wrote: > On Thu, Sep 26, 2019 at 06:51:07PM -0400, Lyude Paul wrote: > > This commit is seperate from the previous one to make it easier to > > revert in the future. Basically, there's multiple userspace applications > > that interpret possible_cr

Re: [PATCH v2 1/6] drm/gem: refine drm_gem_objects_lookup

2019-10-09 Thread Daniel Vetter
On Fri, Sep 27, 2019 at 09:46:11PM +0800, Qiang Yu wrote: > drm_gem_objects_lookup does not use user space bo handles > directly and left the user to kernel copy work to a new > interface drm_gem_objects_lookup_user. > > This is for driver like lima which does not pass gem bo > handles continously

[PULL] drm-misc-next

2019-10-09 Thread Sean Paul
Hi Dave and Daniel, Apologies for missing last week, but this was not something I wanted to do from XDC :-) Lots happening in this pull, the highlights are Thomas' work on gem vram objects, Lyude starting to push the big MST series, Gerd's ttm and virtio refactors, and komeda improvements. One n

Re: [PATCH RFC v4 14/16] drm, cgroup: Introduce lgpu as DRM cgroup resource

2019-10-09 Thread Kenny Ho
Hi Daniel, Can you elaborate what you mean in more details? The goal of lgpu is to provide the ability to subdivide a GPU device and give those slices to different users as needed. I don't think there is anything controversial or vendor specific here as requests for this are well documented. Th

Re: [PATCH 2/3] drm/komeda: Add drm_ctm_to_coeffs()

2019-10-09 Thread Daniel Vetter
On Mon, Sep 30, 2019 at 07:56:13AM -0400, Ilia Mirkin wrote: > On Mon, Sep 30, 2019 at 7:05 AM Brian Starkey wrote: > > > > Hi James, > > > > On Mon, Sep 30, 2019 at 04:54:41AM +, james qian wang (Arm Technology > > China) wrote: > > > This function is used to convert drm_color_ctm S31.32 sig

[PATCH v6] drm: two planes with the same zpos have undefined ordering

2019-10-09 Thread Simon Ser
Currently the property docs don't specify whether it's okay for two planes to have the same zpos value and what user-space should expect in this case. The unspoken, legacy rule used in the past was to make user-space figure out the zpos from object IDs. However some drivers break this rule, that's

Re: [PATCH RFC v4 14/16] drm, cgroup: Introduce lgpu as DRM cgroup resource

2019-10-09 Thread Daniel Vetter
On Wed, Oct 09, 2019 at 11:08:45AM -0400, Kenny Ho wrote: > Hi Daniel, > > Can you elaborate what you mean in more details? The goal of lgpu is > to provide the ability to subdivide a GPU device and give those slices > to different users as needed. I don't think there is anything > controversial

Re: kernel warning related to i915 code

2019-10-09 Thread Daniel Vetter
On Sun, Sep 29, 2019 at 10:09:43PM +0900, Norbert Preining wrote: > Dear all, > > (please Cc) Adding intel-gfx. -Daniel > > linux 5.3.1 > Debian/sid > Lenovo X260 > [2.472152] i915 :00:02.0: vgaarb: deactivate vga console > [2.473035] [drm] Supports vblank timestamp caching Rev 2 (2

Re: [PATCH RFC v4 14/16] drm, cgroup: Introduce lgpu as DRM cgroup resource

2019-10-09 Thread Kuehling, Felix
On 2019-10-09 6:31, Daniel Vetter wrote: > On Tue, Oct 08, 2019 at 06:53:18PM +, Kuehling, Felix wrote: >> >> The description sounds reasonable to me and maps well to the CU masking >> feature in our GPUs. >> >> It would also allow us to do more coarse-grained masking for example to >> guarante

Re: [PATCH RFC v4 14/16] drm, cgroup: Introduce lgpu as DRM cgroup resource

2019-10-09 Thread Daniel Vetter
On Wed, Oct 09, 2019 at 03:25:22PM +, Kuehling, Felix wrote: > On 2019-10-09 6:31, Daniel Vetter wrote: > > On Tue, Oct 08, 2019 at 06:53:18PM +, Kuehling, Felix wrote: > >> > >> The description sounds reasonable to me and maps well to the CU masking > >> feature in our GPUs. > >> > >> It w

[PATCH 0/8] drm/print: cleanup and new drm_device based logging

2019-10-09 Thread Jani Nikula
For starters some fairly benign cleanup, and a proposal for new struct drm_device based drm logging macros analoguous to core kernel struct device based macros. BR, Jani. Jani Nikula (8): drm/i915: use drm_debug_enabled() to check for debug categories drm/nouveau: use drm_debug_enabled() to

[PATCH 8/8] drm/print: introduce new struct drm_device based logging macros

2019-10-09 Thread Jani Nikula
Add new struct drm_device based logging macros modeled after the core kernel device based logging macros. These would be preferred over the drm printk and struct device based macros in drm code, where possible. We have existing drm specific struct device based logging functions, but they are too v

[PATCH 7/8] drm/print: group logging functions by prink or device based

2019-10-09 Thread Jani Nikula
In preparation for adding struct drm_device based logging, group the existing functions by prink or struct device based logging. No functional changes. Signed-off-by: Jani Nikula --- include/drm/drm_print.h | 135 ++-- 1 file changed, 74 insertions(+), 61 dele

[PATCH 1/8] drm/i915: use drm_debug_enabled() to check for debug categories

2019-10-09 Thread Jani Nikula
Allow better abstraction of the drm_debug global variable in the future. No functional changes. Reviewed-by: Eric Engestrom Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display.c | 4 ++-- drivers/gpu/drm/i915/display/intel_dp.c | 2 +- drivers/gpu/drm/i915/i915_drv.c

[PATCH 5/8] drm/print: underscore prefix functions that should be private to print

2019-10-09 Thread Jani Nikula
We don't want people calling the functions directly. No functional changes. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_print.c | 8 include/drm/drm_print.h | 22 +++--- 2 files changed, 15 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/drm_prin

  1   2   >