Re: liboutput: thoughts about shared library on top of DRM/KMS

2019-10-08 Thread Pekka Paalanen
On Mon, 07 Oct 2019 14:16:32 -0400 "Keith Packard" wrote: > Daniel Stone writes: > > > I think there would be a load of value in starting with simple helpers > > which can be used independently of any larger scheme, tackling that > > list above. > > Yeah, a helper library that didn't enforce

[PATCH 1/4] drm/omap: Remove set but not used variable 'plane'

2019-10-08 Thread zhengbin
Fixes gcc '-Wunused-but-set-variable' warning: drivers/gpu/drm/omapdrm/omap_fb.c: In function omap_framebuffer_update_scanout: drivers/gpu/drm/omapdrm/omap_fb.c:130:16: warning: variable plane set but not used [-Wunused-but-set-variable] It is not used since commit 2ecceeb53b19 ("drm/omap: Move

[PATCH 2/4] drm/omap: Remove set but not used variable 'tclk_trail'

2019-10-08 Thread zhengbin
Fixes gcc '-Wunused-but-set-variable' warning: drivers/gpu/drm/omapdrm/dss/dsi.c: In function dsi_proto_timings: drivers/gpu/drm/omapdrm/dss/dsi.c:3562:46: warning: variable tclk_trail set but not used [-Wunused-but-set-variable] It is not used since commit 9960aa7cb58c ("drm/omap: move omapdss

linux-5.4-rc2/drivers/video/fbdev/amifb.c:1875: bad expression ?

2019-10-08 Thread David Binderman
Hello there, linux-5.4-rc2/drivers/video/fbdev/amifb.c:1875:41: error: Expression '(*(lspr+delta)<<16)|(*lspr++)' depends on order of evaluation of side effects [unknownEvaluationOrder] Source code is datawords = (*(lspr + delta) << 16) | (*lspr++); Maybe better code: datawords = (*(lspr

Re: [PATCH v10 1/5] dma-buf: Add dma-buf heaps framework

2019-10-08 Thread Randy Dunlap
On 10/7/19 2:18 PM, John Stultz wrote: > diff --git a/drivers/dma-buf/Kconfig b/drivers/dma-buf/Kconfig > index a23b6752d11a..6e9c7c4d7447 100644 > --- a/drivers/dma-buf/Kconfig > +++ b/drivers/dma-buf/Kconfig > @@ -44,4 +44,13 @@ config DMABUF_SELFTESTS > default n > depends on DMA_SHA

Re: [PATCH 5/5] drm/panel: tpo-td043mtea1: Fix SPI alias

2019-10-08 Thread H. Nikolaus Schaller
> Am 07.10.2019 um 19:08 schrieb Laurent Pinchart > : > > The panel-tpo-td043mtea1 driver incorrectly includes the OF vendor > prefix in its SPI alias. Fix it, and move the manual alias to an SPI > module device table. > > Fixes: dc2e1e5b2799 ("drm/panel: Add driver for the Toppoly TD043MTEA1 p

[PATCH v20 0/2] PS8640 MIPI-to-eDP bridge

2019-10-08 Thread Ulrich Hecht
Hi! This revision fixes a minor issue that keeps the driver from probing on the Elm platform. Thanks to Matthias Brugger for testing. This driver seems to have fallen by the wayside because, while otherwise fine, it has a firmware update feature that requires a blob that is not in the linux-firmw

[PATCH v20 1/2] Documentation: bridge: Add documentation for ps8640 DT properties

2019-10-08 Thread Ulrich Hecht
From: Jitao Shi Add documentation for DT properties supported by ps8640 DSI-eDP converter. Signed-off-by: Jitao Shi Acked-by: Rob Herring Reviewed-by: Philipp Zabel Signed-off-by: Ulrich Hecht --- Changes since v15: - No change. Changes since v14: - change mode-sel-gpios as optional. .

Re: [linux-sunxi] [PATCH 3/3] Revert "drm/sun4i: dsi: Rework a bit the hblk calculation"

2019-10-08 Thread Ondřej Jirman
HI Icenowy, On Sun, Oct 06, 2019 at 11:12:43PM +0800, Icenowy Zheng wrote: > 在 2019-10-06日的 22:44 +0800,Icenowy Zheng写道: > > 在 2019-10-03四的 09:53 +0530,Jagan Teki写道: > > > Hi Wens, > > > > > > On Tue, Oct 1, 2019 at 1:34 PM Icenowy Zheng > > > wrote: > > > > This reverts commit 62e7511a4f4dcf07f

Re: [Letux-kernel] [PATCH 4/5] drm/panel: tpo-td028ttec1: Fix SPI alias

2019-10-08 Thread H. Nikolaus Schaller
> Am 07.10.2019 um 19:58 schrieb Andreas Kemnade : > > On Mon, 7 Oct 2019 20:08:00 +0300 > Laurent Pinchart wrote: > >> The panel-tpo-td028ttec1 driver incorrectly includes the OF vendor >> prefix in its SPI alias. Fix it. >> >> Fixes: 415b8dd08711 ("drm/panel: Add driver for the Toppoly TD02

[PATCH 0/4] drm/omap: Remove some set but not used variables

2019-10-08 Thread zhengbin
zhengbin (4): drm/omap: Remove set but not used variable 'plane' drm/omap: Remove set but not used variable 'tclk_trail' drm/omap: Remove set but not used variable 'err' in hdmi5_audio_config drm/omap: Remove set but not used variable 'err' in hdmi4_audio_config drivers/gpu/drm/omapdrm/ds

Re: [Letux-kernel] [PATCH 4/5] drm/panel: tpo-td028ttec1: Fix SPI alias

2019-10-08 Thread Andreas Kemnade
On Mon, 7 Oct 2019 20:08:00 +0300 Laurent Pinchart wrote: > The panel-tpo-td028ttec1 driver incorrectly includes the OF vendor > prefix in its SPI alias. Fix it. > > Fixes: 415b8dd08711 ("drm/panel: Add driver for the Toppoly TD028TTEC1 panel") > Reported-by: H. Nikolaus Schaller > Signed-off-

[PATCH 4/4] drm/omap: Remove set but not used variable 'err' in hdmi4_audio_config

2019-10-08 Thread zhengbin
Fixes gcc '-Wunused-but-set-variable' warning: drivers/gpu/drm/omapdrm/dss/hdmi4_core.c: In function hdmi4_audio_config: drivers/gpu/drm/omapdrm/dss/hdmi4_core.c:689:6: warning: variable err set but not used [-Wunused-but-set-variable] It is not used since commit f5bab2229190 ("OMAPDSS: HDMI: Ad

[PATCH v20 2/2] drm/bridge: Add I2C based driver for ps8640 bridge

2019-10-08 Thread Ulrich Hecht
From: Jitao Shi This patch adds drm_bridge driver for parade DSI to eDP bridge chip. Signed-off-by: Jitao Shi Reviewed-by: Daniel Kurtz Reviewed-by: Enric Balletbo i Serra [uli: followed API changes, removed FW update feature] Signed-off-by: Ulrich Hecht --- Changes since v19: - fixed retu

[PATCH 3/4] drm/omap: Remove set but not used variable 'err' in hdmi5_audio_config

2019-10-08 Thread zhengbin
Fixes gcc '-Wunused-but-set-variable' warning: drivers/gpu/drm/omapdrm/dss/hdmi5_core.c: In function hdmi5_audio_config: drivers/gpu/drm/omapdrm/dss/hdmi5_core.c:812:6: warning: variable err set but not used [-Wunused-but-set-variable] It is not used since commit f5bab2229190 ("OMAPDSS: HDMI: Ad

Re: [PATCH] drm: panels: fix spi aliases of former omap panels

2019-10-08 Thread Andreas Kemnade
On Mon, 7 Oct 2019 19:04:46 +0200 Sebastian Reichel wrote: > Hi, > > On Mon, Oct 07, 2019 at 06:41:30PM +0200, Andreas Kemnade wrote: > > When the panels were moved from omap/displays/ to panel/ > > omapdss prefix was stripped, which cause spi modalias > > to not contain the vendor-prefix anymor

Re: [PATCH v1 2/2] drm: delete drmP.h + drm_os_linux.h

2019-10-08 Thread Jani Nikula
On Mon, 07 Oct 2019, Sam Ravnborg wrote: > There is finally no more users left in the kernel of drmP.h > and drm_os_linux.h (drmP.h was the only user left). > Delete the header files and delete the corresponding todo entry. > > When we started this quest there was more than 700 users of drmP.h. >

Re: [PATCH] drm/panfrost: Handle resetting on timeout better

2019-10-08 Thread Neil Armstrong
On 07/10/2019 14:50, Steven Price wrote: > Panfrost uses multiple schedulers (one for each slot, so 2 in reality), > and on a timeout has to stop all the schedulers to safely perform a > reset. However more than one scheduler can trigger a timeout at the same > time. This race condition results in

Re: liboutput: thoughts about shared library on top of DRM/KMS

2019-10-08 Thread Neil Armstrong
Hi, On 05/10/2019 18:09, Keith Packard wrote: > > During XDC this year, we heard a few presentations and had a lot of > hallway talk about sharing code for driving DRM/KMS for display. > > I think the general consensus is that there is enough shared > functionality between all of the various DRM

Re: linux-next: build failure after merge of the drm-misc tree

2019-10-08 Thread Hans Verkuil
On 10/8/19 1:30 AM, Stephen Rothwell wrote: > Hi all, > > After merging the drm-misc tree, today's linux-next build (x86_64 > allmodconfig) failed like this: > > > Caused by commit > > 10d8f308ba3e ("cec: add cec_adapter to cec_notifier_cec_adap_unregister()") > > interacting with commit >

[Bug 204241] amdgpu fails to resume from suspend

2019-10-08 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=204241 --- Comment #18 from Michel Dänzer (mic...@daenzer.net) --- (In reply to Alex Deucher from comment #17) > I'm not sure I understand why the patch helps. You are just changing the > order of two memory allocations. The order shouldn't matter. My

[Bug 111921] GPU crash on VegaM (amdgpu: The CS has been rejected)

2019-10-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111921 Bug ID: 111921 Summary: GPU crash on VegaM (amdgpu: The CS has been rejected) Product: DRI Version: unspecified Hardware: x86-64 (AMD64) OS: Linux (All) Status: NE

[Bug 111921] GPU crash on VegaM (amdgpu: The CS has been rejected)

2019-10-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111921 --- Comment #1 from Rémi Verschelde --- Pasting relevant part of `dmesg` log: ``` [ 7813.339782] [drm] PCIE GART of 256M enabled (table at 0x00F4). [ 7813.454656] [drm] UVD and UVD ENC initialized successfully. [ 7813.565585] [drm] V

Re: [PATCH v2 3/4] drm/meson: Enable DRM InfoFrame support on GXL, GXM and G12A

2019-10-08 Thread Neil Armstrong
Hi Jonas, On 07/10/2019 21:21, Jonas Karlman wrote: > This patch enables Dynamic Range and Mastering InfoFrame on GXL, GXM and G12A. > > Cc: Neil Armstrong > Signed-off-by: Jonas Karlman > Reviewed-by: Neil Armstrong > --- > drivers/gpu/drm/meson/meson_dw_hdmi.c | 5 + > 1 file changed,

Re: [pull] ttm drm-fixes-5.4

2019-10-08 Thread Koenig, Christian
My git version should be relative new, but I'm usually using thunderbird to send pull requests not git itself since I want to edit the message before sending. How would I do this in a way patchwork likes it with git? Thanks, Christian. Am 07.10.19 um 21:58 schrieb Dave Airlie: > For some reaso

Re: [PATCH][next] drm/komeda: remove redundant assignment to pointer disable_done

2019-10-08 Thread james qian wang (Arm Technology China)
On Mon, Oct 07, 2019 at 04:25:05PM +0300, Dan Carpenter wrote: > On Fri, Oct 04, 2019 at 10:53:44PM +0100, Colin Ian King wrote: > > On 04/10/2019 20:27, Liviu Dudau wrote: > > > On Fri, Oct 04, 2019 at 05:21:56PM +0100, Colin King wrote: > > >> From: Colin Ian King > > >> > > >> The pointer disab

Re: [PATCH] drm/edid: Add 6 bpc quirk for SDC panel in Lenovo G50

2019-10-08 Thread Kai-Heng Feng
> On Jun 6, 2019, at 16:04, Kai-Heng Feng wrote: > > Hi, > > at 11:30, Kai-Heng Feng wrote: > >> Another panel that needs 6BPC quirk. > > Please include this patch if possible. Another gentle ping. > > Kai-Heng > >> >> BugLink: https://bugs.launchpad.net/bugs/1819968 >> Cc: # v4.8+ >

Re: DRM_MODE_CONNECTOR_PANEL? [Was: drm/panel: Add and fill drm_panel type field]

2019-10-08 Thread Daniel Vetter
On Fri, Sep 27, 2019 at 05:28:03PM +0300, Tomi Valkeinen wrote: > On 27/09/2019 15:44, Daniel Stone wrote: > > Hi Linus, > > > > On Fri, 27 Sep 2019 at 13:37, Linus Walleij > > wrote: > > > Also the ILI9322 can actually set up gamma correction which is > > > very nice for professional applicatio

Re: [PATCH 1/4] dma-buf: change DMA-buf locking convention

2019-10-08 Thread Daniel Vetter
On Thu, Aug 29, 2019 at 04:29:14PM +0200, Christian König wrote: > This patch is a stripped down version of the locking changes > necessary to support dynamic DMA-buf handling. > > For compatibility we cache the DMA-buf mapping as soon as > exporter/importer disagree on the dynamic handling. Nee

Re: [PATCH 1/4] dma-buf: change DMA-buf locking convention

2019-10-08 Thread Daniel Vetter
On Wed, Oct 02, 2019 at 08:37:50AM +, Koenig, Christian wrote: > Hi Daniel, > > once more a ping on this. Any more comments or can we get it comitted? Sorry got a bit smashed past weeks, but should be resurrected now back from xdc. -Daniel > > Thanks, > Christian. > > Am 24.09.19 um 11:50 s

[PATCH] drm/komeda: Set output color depth for output

2019-10-08 Thread Lowry Li (Arm Technology China)
Set color_depth according to connector->bpc. Signed-off-by: Lowry Li (Arm Technology China) --- .../arm/display/komeda/d71/d71_component.c| 1 + .../gpu/drm/arm/display/komeda/komeda_crtc.c | 20 +++ .../gpu/drm/arm/display/komeda/komeda_kms.h | 2 ++ .../drm/arm/display

Re: [PATCH] drm/i915: customize DPCD brightness control for specific panel

2019-10-08 Thread Jani Nikula
On Mon, 07 Oct 2019, Adam Jackson wrote: > On Mon, 2019-10-07 at 12:08 +0300, Jani Nikula wrote: > >> The problem with the EDID quirks is that exposing the quirks sticks out >> like a sore thumb. Thus far all of it has been contained in drm_edid.c >> and they affect how the EDID gets parsed, for a

Re: [PATCH] drm/komeda: Adds output-color format/depth support

2019-10-08 Thread Lowry Li (Arm Technology China)
On Mon, Sep 30, 2019 at 10:36:27AM +, Brian Starkey wrote: > On Fri, Sep 27, 2019 at 02:22:24AM +, james qian wang (Arm Technology > China) wrote: > > On Wed, Sep 25, 2019 at 09:48:11AM +, Brian Starkey wrote: > > > Hi James, > > > > > > On Tue, Sep 24, 2019 at 02:13:27AM +, james

Re: [PATCH 2/4] drm/ttm: use the parent resv for ghost objects v2

2019-10-08 Thread Daniel Vetter
On Thu, Aug 29, 2019 at 04:29:15PM +0200, Christian König wrote: > This way we can even pipeline imported BO evictions. > > v2: Limit this to only cases when the parent object uses a separate > reservation object as well. This fixes another OOM problem. > > Signed-off-by: Christian König Si

Re: [PATCH 3/5] backlight: pwm_bl: drop use of int_pow()

2019-10-08 Thread Daniel Thompson
On Mon, Oct 07, 2019 at 08:43:31PM +0200, Rasmus Villemoes wrote: > On 07/10/2019 17.28, Daniel Thompson wrote: > > On Thu, Sep 19, 2019 at 04:06:18PM +0200, Rasmus Villemoes wrote: > > > > It feels like there is some rationale missing in the description here. > > > > What is the benefit of repla

Re: liboutput: thoughts about shared library on top of DRM/KMS

2019-10-08 Thread Daniel Stone
Hi, On Mon, 7 Oct 2019 at 19:16, Keith Packard wrote: > Daniel Stone writes: > > I think there would be a load of value in starting with simple helpers > > which can be used independently of any larger scheme, tackling that > > list above. > > Yeah, a helper library that didn't enforce at tonne

Re: liboutput: thoughts about shared library on top of DRM/KMS

2019-10-08 Thread Heinrich Fink
On Mon, 7 Oct 2019 at 20:16, Keith Packard wrote: > > Daniel Stone writes: > > > I think there would be a load of value in starting with simple helpers > > which can be used independently of any larger scheme, tackling that > > list above. > > Yeah, a helper library that didn't enforce at tonne o

Re: [PATCH] drm/komeda: Set output color depth for output

2019-10-08 Thread Mihail Atanassov
Hi Lowry, On Tuesday, 8 October 2019 10:17:52 BST Lowry Li (Arm Technology China) wrote: > Set color_depth according to connector->bpc. > > Signed-off-by: Lowry Li (Arm Technology China) > --- > .../arm/display/komeda/d71/d71_component.c| 1 + > .../gpu/drm/arm/display/komeda/komeda_crtc.c

Re: [PATCH] drm/komeda: Set output color depth for output

2019-10-08 Thread Brian Starkey
Hi Lowry, On Tue, Oct 08, 2019 at 09:17:52AM +, Lowry Li (Arm Technology China) wrote: > Set color_depth according to connector->bpc. > > Signed-off-by: Lowry Li (Arm Technology China) > --- > .../arm/display/komeda/d71/d71_component.c| 1 + > .../gpu/drm/arm/display/komeda/komeda_crtc

[Bug 204241] amdgpu fails to resume from suspend

2019-10-08 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=204241 --- Comment #19 from m...@cschwarz.com --- Just had the first (but different kind of) crash since applying the patch on top of 5.3.2, but didn't have kdump configured: The system woke, everything seemed to work for about 30s, then the screen went

Re: [PATCH v2 00/21] drm/dp: Various helper improvements and cleanups

2019-10-08 Thread Daniel Vetter
On Wed, Oct 02, 2019 at 06:14:19PM +0200, Thierry Reding wrote: > On Mon, Sep 23, 2019 at 04:52:02PM +0200, Thierry Reding wrote: > > On Mon, Sep 23, 2019 at 04:52:50PM +0300, Jani Nikula wrote: > > > On Fri, 20 Sep 2019, Thierry Reding wrote: > > > > On Mon, Sep 02, 2019 at 01:31:00PM +0200, Thie

Re: [PATCH v2 03/27] drm/dp_mst: Destroy MSTBs asynchronously

2019-10-08 Thread Daniel Vetter
On Fri, Sep 27, 2019 at 09:31:07AM -0400, Sean Paul wrote: > On Wed, Sep 25, 2019 at 04:08:22PM -0400, Lyude Paul wrote: > > On Wed, 2019-09-25 at 14:16 -0400, Sean Paul wrote: > > > On Tue, Sep 03, 2019 at 04:45:41PM -0400, Lyude Paul wrote: > > > > When reprobing an MST topology during resume, we

Re: [PATCH] drm: damage_helper: Fix race checking plane->state->fb

2019-10-08 Thread Daniel Vetter
On Thu, Sep 19, 2019 at 11:04:01AM -0400, Sean Paul wrote: > On Thu, Sep 05, 2019 at 12:41:27PM +0200, Daniel Vetter wrote: > > On Wed, Sep 4, 2019 at 10:29 PM Sean Paul wrote: > > > > > > From: Sean Paul > > > > > > Since the dirtyfb ioctl doesn't give us any hints as to which plane is > > > sca

Re: [PATCH] drm: atomic helper: fix W=1 warnings

2019-10-08 Thread Daniel Vetter
On Thu, Oct 03, 2019 at 05:37:15PM +0200, Benjamin Gaignard wrote: > Le jeu. 3 oct. 2019 à 17:05, Ville Syrjälä > a écrit : > > > > On Thu, Oct 03, 2019 at 04:46:54PM +0200, Benjamin Gaignard wrote: > > > Le jeu. 3 oct. 2019 à 16:27, Ville Syrjälä > > > a écrit : > > > > > > > > On Mon, Sep 09, 2

Re: [v4] drm: two planes with the same zpos have undefined ordering

2019-10-08 Thread Daniel Vetter
On Mon, Sep 30, 2019 at 10:07:07AM +0300, Pekka Paalanen wrote: > On Sun, 29 Sep 2019 20:30:44 + > Simon Ser wrote: > > > Hi, > > > > > On Mon, Sep 23, 2019 at 12:39:20PM +, Simon Ser wrote: > > > > Currently the property docs don't specify whether it's okay for two > > > > planes to

Re: [PATCH v2 1/3] drm/fb-helper: Synchronize dirty worker with vblank

2019-10-08 Thread Daniel Vetter
On Fri, Sep 27, 2019 at 10:41:43AM +0200, Thomas Zimmermann wrote: > Hi > > Am 17.09.19 um 15:06 schrieb Daniel Vetter: > > On Thu, Sep 12, 2019 at 08:42:28AM +0200, Thomas Zimmermann wrote: > > > Before updating the display from the console's shadow buffer, the dirty > > > worker now waits for vb

Re: [PATCH 3/5] backlight: pwm_bl: drop use of int_pow()

2019-10-08 Thread Rasmus Villemoes
On 08/10/2019 11.31, Daniel Thompson wrote: > On Mon, Oct 07, 2019 at 08:43:31PM +0200, Rasmus Villemoes wrote: >> On 07/10/2019 17.28, Daniel Thompson wrote: >>> On Thu, Sep 19, 2019 at 04:06:18PM +0200, Rasmus Villemoes wrote: >>> >>> It feels like there is some rationale missing in the descripti

Re: [RFC PATCH] drm/virtio: Export resource handles via DMA-buf API

2019-10-08 Thread Daniel Vetter
On Sat, Oct 05, 2019 at 02:41:54PM +0900, Tomasz Figa wrote: > Hi Daniel, Gerd, > > On Tue, Sep 17, 2019 at 10:23 PM Daniel Vetter wrote: > > > > On Thu, Sep 12, 2019 at 06:41:21PM +0900, Tomasz Figa wrote: > > > This patch is an early RFC to judge the direction we are following in > > > our virt

Re: [PATCH] drm/komeda: Set output color depth for output

2019-10-08 Thread Lowry Li (Arm Technology China)
Hi Mihail, On Tue, Oct 08, 2019 at 09:35:15AM +, Mihail Atanassov wrote: > Hi Lowry, > > On Tuesday, 8 October 2019 10:17:52 BST Lowry Li (Arm Technology China) wrote: > > Set color_depth according to connector->bpc. > > > > Signed-off-by: Lowry Li (Arm Technology China) > > --- > > .../arm

[PATCH v3] drm/bridge: dw-hdmi: Restore audio when setting a mode

2019-10-08 Thread Cheng-Yi Chiang
From: Daniel Kurtz When setting a new display mode, dw_hdmi_setup() calls dw_hdmi_enable_video_path(), which disables all hdmi clocks, including the audio clock. We should only (re-)enable the audio clock if audio was already enabled when setting the new mode. Without this patch, on RK3288, the

[Bug 205049] garbled graphics

2019-10-08 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=205049 --- Comment #5 from le...@onet.pl --- Ok, this is what I've tried: holding shift to force the boot menu to show up, then pressing e to edit the options for kernel version 5.2.17, then appending amdgpu.ppfeaturemask=0x3fff, and finally pressing

Re: [PATCH] drm/komeda: Set output color depth for output

2019-10-08 Thread Lowry Li (Arm Technology China)
Hi Brian, On Tue, Oct 08, 2019 at 09:36:09AM +, Brian Starkey wrote: > Hi Lowry, > > On Tue, Oct 08, 2019 at 09:17:52AM +, Lowry Li (Arm Technology China) > wrote: > > Set color_depth according to connector->bpc. > > > > Signed-off-by: Lowry Li (Arm Technology China) > > --- > > .../ar

Re: [PATCH 3/5] backlight: pwm_bl: drop use of int_pow()

2019-10-08 Thread Daniel Thompson
On Tue, Oct 08, 2019 at 12:02:07PM +0200, Rasmus Villemoes wrote: > On 08/10/2019 11.31, Daniel Thompson wrote: > > On Mon, Oct 07, 2019 at 08:43:31PM +0200, Rasmus Villemoes wrote: > >> On 07/10/2019 17.28, Daniel Thompson wrote: > >>> On Thu, Sep 19, 2019 at 04:06:18PM +0200, Rasmus Villemoes wro

Re: [RFC PATCH] drm/virtio: Export resource handles via DMA-buf API

2019-10-08 Thread Tomasz Figa
On Tue, Oct 8, 2019 at 7:03 PM Daniel Vetter wrote: > > On Sat, Oct 05, 2019 at 02:41:54PM +0900, Tomasz Figa wrote: > > Hi Daniel, Gerd, > > > > On Tue, Sep 17, 2019 at 10:23 PM Daniel Vetter wrote: > > > > > > On Thu, Sep 12, 2019 at 06:41:21PM +0900, Tomasz Figa wrote: > > > > This patch is an

[PATCH 1/3] drm/nouveau/kms/nv50-: make base917c_format static

2019-10-08 Thread Ben Dooks
The base917c_format isn't exported, so make it static to avoid the following warning: drivers/gpu/drm/nouveau/dispnv50/base917c.c:26:1: warning: symbol 'base917c_format' was not declared. Should it be static? Signed-off-by: Ben Dooks --- drivers/gpu/drm/nouveau/dispnv50/base917c.c | 2 +- 1 fi

[PATCH 3/3] drm/nouveau/kms/nv50-: include n50_display.h for nv50_display_create

2019-10-08 Thread Ben Dooks
Include n50_display.h for the definition of nv50_display_create to fix the warning (and remove the now non-exported definitions in the n50_display.h to allow the code to build): drivers/gpu/drm/nouveau/dispnv50/disp.c:2297:1: warning: symbol 'nv50_display_create' was not declared. Should it be st

[PATCH 2/3] drm/nouveau/kms/nv50-: make unexported items static

2019-10-08 Thread Ben Dooks
Make functions that are not used directly outside the file they are in static to avoid the following warnings: drivers/gpu/drm/nouveau/dispnv50/headc57d.c:73:1: warning: symbol 'headc57d_olut_clr' was not declared. Should it be static? drivers/gpu/drm/nouveau/dispnv50/headc57d.c:85:1: warning: sy

Re: [PATCH] drm/komeda: Set output color depth for output

2019-10-08 Thread Mihail Atanassov
On Tuesday, 8 October 2019 11:28:24 BST Lowry Li (Arm Technology China) wrote: > Hi Brian, > On Tue, Oct 08, 2019 at 09:36:09AM +, Brian Starkey wrote: > > Hi Lowry, > > > > On Tue, Oct 08, 2019 at 09:17:52AM +, Lowry Li (Arm Technology China) > > wrote: > > > Set color_depth according to

Re: [PATCH v2 1/3] drm: Add some new format DRM_FORMAT_NVXX_10

2019-10-08 Thread Ville Syrjälä
On Tue, Oct 08, 2019 at 10:40:20AM +0800, sandy.huang wrote: > Hi ville syrjala, > > 在 2019/9/30 下午6:48, Ville Syrjälä 写道: > > On Thu, Sep 26, 2019 at 04:24:47PM +0800, Sandy Huang wrote: > >> These new format is supported by some rockchip socs: > >> > >> DRM_FORMAT_NV12_10/DRM_FORMAT_NV21_10 > >>

[PATCH 4/5] drm/nouveau/disp/gv100: make undeclared symbols static

2019-10-08 Thread Ben Dooks
The two objects gv100_disp_wndw and gv100_disp_wndw_mthd are not declared or used outside the file, so make them static to avoid the following warnings: drivers/gpu/drm/nouveau/nvkm/engine/disp/wndwgv100.c:120:1: warning: symbol 'gv100_disp_wndw_mthd' was not declared. Should it be static? driver

[PATCH 5/5] drm/nouveau/disp/gv100: make gv100_disp_wimm static

2019-10-08 Thread Ben Dooks
The gv100_disp_wimm is not declared, so make it static to avoid the following warning: drivers/gpu/drm/nouveau/nvkm/engine/disp/wimmgv100.c:39:1: warning: symbol 'gv100_disp_wimm' was not declared. Should it be static? Signed-off-by: Ben Dooks --- drivers/gpu/drm/nouveau/nvkm/engine/disp/wimmg

[PATCH 2/5] drm/nouveau/fifo/tu102: make tu102_fifo_runlist static

2019-10-08 Thread Ben Dooks
The tu102_fifo_runlist is not exorted, so make it static to avoid the following warning: drivers/gpu/drm/nouveau/nvkm/engine/fifo/tu102.c:47:1: warning: symbol 'tu102_fifo_runlist' was not declared. Should it be static? Signed-off-by: Ben Dooks --- drivers/gpu/drm/nouveau/nvkm/engine/fifo/tu10

[PATCH 3/5] drm/nouveau/fifo/gv100: make gv100_fifo_runlist static

2019-10-08 Thread Ben Dooks
Do not export gv100_fifo_runlist as it isn't not used to remove the following morning: drivers/gpu/drm/nouveau/nvkm/engine/fifo/gv100.c:56:1: warning: symbol 'gv100_fifo_runlist' was not declared. Should it be static? Signed-off-by: Ben Dooks --- drivers/gpu/drm/nouveau/nvkm/engine/fifo/gv100.

Re: [v4] drm: two planes with the same zpos have undefined ordering

2019-10-08 Thread Pekka Paalanen
On Tue, 8 Oct 2019 11:59:04 +0200 Daniel Vetter wrote: > On Mon, Sep 30, 2019 at 10:07:07AM +0300, Pekka Paalanen wrote: > > On Sun, 29 Sep 2019 20:30:44 + > > Simon Ser wrote: > > > > > Hi, > > > > > > > On Mon, Sep 23, 2019 at 12:39:20PM +, Simon Ser wrote: > > > > > Currentl

Re: [PATCH v2 1/3] drm: Add some new format DRM_FORMAT_NVXX_10

2019-10-08 Thread sandy.huang
在 2019/10/8 下午7:33, Ville Syrjälä 写道: On Tue, Oct 08, 2019 at 10:40:20AM +0800, sandy.huang wrote: Hi ville syrjala, 在 2019/9/30 下午6:48, Ville Syrjälä 写道: On Thu, Sep 26, 2019 at 04:24:47PM +0800, Sandy Huang wrote: These new format is supported by some rockchip socs: DRM_FORMAT_NV12_10/DRM

[Bug 205049] garbled graphics

2019-10-08 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=205049 Lukáš Krejčí (lskre...@gmail.com) changed: What|Removed |Added CC||lskre...@gmail.com --

[Bug 205049] garbled graphics

2019-10-08 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=205049 --- Comment #7 from Lukáš Krejčí (lskre...@gmail.com) --- Ok, because of the automatic line wrapping, I'll make the example shorter: change this: linux /vmlinuz-3.17.4-301.fc21.x86_64 ro initrd /initramfs-3.17.4-301.fc21.x86_64.img to this: li

[Bug 111913] AMD Navi10 GPU powerplay issues when using two DisplayPort connectors

2019-10-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111913 --- Comment #6 from Stefan Rehm --- Yes, both monitors run at 60 Hz. -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailing list dri-devel@lists.freedesktop.or

[PATCH v2 2/4] backlight: pwm_bl: eliminate a 64/32 division

2019-10-08 Thread Rasmus Villemoes
lightness*1000 is nowhere near overflowing 32 bits, so we can just use an ordinary 32/32 division, which is much cheaper than the 64/32 done via do_div(). Reviewed-by: Daniel Thompson Signed-off-by: Rasmus Villemoes --- drivers/video/backlight/pwm_bl.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH v2 0/4] backlight: pwm_bl: optimizations and small fix for cie1913

2019-10-08 Thread Rasmus Villemoes
These patches optimize the cie1913() implementation by using fewer 64 bit divisions and multiplications. It also contains a minor fix for the linear constant used. v2: - Drop patch 5. - Fix thinko in patch 4, otherwise no code change. - Better changelog in patch 3. - Add Daniel's Reviewed-By to th

[PATCH v2 1/4] backlight: pwm_bl: fix cie1913 comments and constant

2019-10-08 Thread Rasmus Villemoes
The "break-even" point for the two formulas is L==8, which is also what the code actually implements. [Incidentally, at that point one has Y=0.008856, not 0.08856]. Moreover, all the sources I can find say the linear factor is 903.3 rather than 902.3, which makes sense since then the formulas agre

[PATCH v2 3/4] backlight: pwm_bl: drop use of int_pow()

2019-10-08 Thread Rasmus Villemoes
For a fixed small exponent of 3, it is more efficient to simply use two explicit multiplications rather than calling the int_pow() library function: Aside from the function call overhead, its implementation using repeated squaring means it ends up doing four 64x64 multiplications. Reviewed-by: Dan

[PATCH v2 4/4] backlight: pwm_bl: switch to power-of-2 base for fixed-point math

2019-10-08 Thread Rasmus Villemoes
Using a power-of-2 instead of power-of-10 base makes the computations much cheaper. 2^16 is safe; retval never becomes more than 2^48 + 2^32/2. On a 32 bit platform, the very expensive 64/32 division at the end of cie1931() instead becomes essentially free (a shift by 32 is just a register rename).

[Bug 204885] ryzen 2500U cause graphics glitch in all browsers with kernel version 5.2.x+

2019-10-08 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=204885 Pierre-Eric Pelloux-Prayer (pierre-eric.pelloux-pra...@amd.com) changed: What|Removed |Added CC|

Re: [PATCH 1/3] dt-bindings: arm: samsung: Force clkoutN names to be unique in PMU

2019-10-08 Thread Rob Herring
On Fri, Oct 4, 2019 at 10:14 AM Krzysztof Kozlowski wrote: > > The clkoutN names of clocks must be unique because they represent > unique inputs of clock multiplexer. > > Signed-off-by: Krzysztof Kozlowski > --- > Documentation/devicetree/bindings/arm/samsung/pmu.yaml | 6 -- > 1 file change

[PATCH v2] drm: atomic helper: fix W=1 warnings

2019-10-08 Thread Benjamin Gaignard
Few for_each macro set variables that are never used later which led to generate unused-but-set-variable warnings. Add (void)(foo) inside the macros to remove these warnings Signed-off-by: Benjamin Gaignard --- include/drm/drm_atomic.h | 17 ++--- 1 file changed, 14 insertions(+), 3

Re: [PATCH] dt-bindings: display: Convert stm32 display bindings to json-schema

2019-10-08 Thread Rob Herring
On Wed, Oct 2, 2019 at 10:17 AM Benjamin Gaignard wrote: > > Convert the STM32 display binding to DT schema format using json-schema. > Split the original bindings in two yaml files: > - one for display controller (ltdc) > - one for DSI controller > > Signed-off-by: Benjamin Gaignard > --- > ...

Re: [PATCH 1/3] dt-bindings: arm: samsung: Force clkoutN names to be unique in PMU

2019-10-08 Thread Krzysztof Kozlowski
On Tue, Oct 08, 2019 at 07:38:14AM -0500, Rob Herring wrote: > On Fri, Oct 4, 2019 at 10:14 AM Krzysztof Kozlowski wrote: > > > > The clkoutN names of clocks must be unique because they represent > > unique inputs of clock multiplexer. > > > > Signed-off-by: Krzysztof Kozlowski > > --- > > Docum

Re: [PATCH v9 4/5] dt-bindings: backlight: Add led-backlight binding

2019-10-08 Thread Jean-Jacques Hiblot
Hi Rob, On 07/10/2019 18:15, Rob Herring wrote: Please send DT bindings to DT list or it's never in my queue. IOW, send patches to the lists that get_maintainers.pl tells you to. On Mon, Oct 7, 2019 at 7:45 AM Jean-Jacques Hiblot wrote: Add DT binding for led-backlight. Signed-off-by: Jean-J

[PATCH] drm: Fix comment doc for format_modifiers

2019-10-08 Thread Andrzej Pietrasiewicz
The parameter passes an array of uint64_t rather than an array of structs, but the first words of the comment suggest that it passes an array of structs - if the reader stops reading at the word "struct". If the commit is read beyond that point the reader will likely confuse "drm_formatmodifiers"

[Bug 205049] garbled graphics

2019-10-08 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=205049 --- Comment #8 from le...@onet.pl --- I added the amdgpu.ppfeaturemask=0xfffx text directly after the 'ro' as shown, and the fix doesn't seem to have any effect, at least not for 5.2.17-200. -- You are receiving this mail because: You are wa

Re: [pull] ttm drm-fixes-5.4

2019-10-08 Thread Alex Deucher
On Tue, Oct 8, 2019 at 4:04 AM Koenig, Christian wrote: > > My git version should be relative new, but I'm usually using thunderbird > to send pull requests not git itself since I want to edit the message > before sending. > > How would I do this in a way patchwork likes it with git? FWIW, I usua

Re: [PATCH v9 4/5] dt-bindings: backlight: Add led-backlight binding

2019-10-08 Thread Jean-Jacques Hiblot
Rob, On 08/10/2019 14:51, Jean-Jacques Hiblot wrote: Hi Rob, On 07/10/2019 18:15, Rob Herring wrote: Please send DT bindings to DT list or it's never in my queue. IOW, send patches to the lists that get_maintainers.pl tells you to. On Mon, Oct 7, 2019 at 7:45 AM Jean-Jacques Hiblot wrote:

Re: [PATCH] drm/amdgpu/display: make various arrays static, makes object smaller

2019-10-08 Thread Harry Wentland
On 2019-10-07 5:58 p.m., Colin King wrote: > From: Colin Ian King > > Don't populate the arrays on the stack but instead make them > static. Makes the object code smaller by 158 bytes. > > Before: >text data bss dec hex filename > 32468 2072 0 34540

[Bug 111913] AMD Navi10 GPU powerplay issues when using two DisplayPort connectors

2019-10-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111913 --- Comment #7 from Timur Kristóf --- (In reply to Andrew Sheldon from comment #5) > Are both monitors 60hz? I've seen this occur with 2x60hz setups, but not > with other combinations of refresh rates. It seems to be similar to issues > with 75h

Re: [PATCH] drm/amdgpu/display: make various arrays static, makes object smaller

2019-10-08 Thread Joe Perches
On Tue, 2019-10-08 at 13:56 +, Harry Wentland wrote: [] > > diff --git a/drivers/gpu/drm/amd/display/dc/bios/bios_parser.c > > b/drivers/gpu/drm/amd/display/dc/bios/bios_parser.c > [] > > @@ -2745,7 +2745,7 @@ static enum bp_result bios_get_board_layout_info( > > struct bios_parser *bp; >

Re: [PATCH] drm: damage_helper: Fix race checking plane->state->fb

2019-10-08 Thread Sean Paul
On Tue, Oct 08, 2019 at 11:50:33AM +0200, Daniel Vetter wrote: > On Thu, Sep 19, 2019 at 11:04:01AM -0400, Sean Paul wrote: > > On Thu, Sep 05, 2019 at 12:41:27PM +0200, Daniel Vetter wrote: > > > On Wed, Sep 4, 2019 at 10:29 PM Sean Paul wrote: > > > > > > > > From: Sean Paul > > > > > > > > Sin

Re: [PATCH 1/3] dt-bindings: arm: samsung: Force clkoutN names to be unique in PMU

2019-10-08 Thread Rob Herring
On Tue, Oct 8, 2019 at 7:50 AM Krzysztof Kozlowski wrote: > > On Tue, Oct 08, 2019 at 07:38:14AM -0500, Rob Herring wrote: > > On Fri, Oct 4, 2019 at 10:14 AM Krzysztof Kozlowski wrote: > > > > > > The clkoutN names of clocks must be unique because they represent > > > unique inputs of clock mult

Re: [PATCHv2 7/7] drm/omap: hdmi4: fix use of uninitialized var

2019-10-08 Thread Tomi Valkeinen
On 08/10/2019 17:13, Tony Lindgren wrote: * Tomi Valkeinen [190930 10:38]: If use_mclk is false, mclk_mode is written to a register without initialization. This doesn't cause any ill effects as the written value is not used when use_mclk is false. To fix this, write use_mclk only when use_mclk

Re: [PATCH 1/3] dt-bindings: arm: samsung: Force clkoutN names to be unique in PMU

2019-10-08 Thread Rob Herring
On Tue, Oct 8, 2019 at 9:05 AM Rob Herring wrote: > > On Tue, Oct 8, 2019 at 7:50 AM Krzysztof Kozlowski wrote: > > > > On Tue, Oct 08, 2019 at 07:38:14AM -0500, Rob Herring wrote: > > > On Fri, Oct 4, 2019 at 10:14 AM Krzysztof Kozlowski > > > wrote: > > > > > > > > The clkoutN names of clocks

Re: [PATCH] drm/amdgpu/display: make various arrays static, makes object smaller

2019-10-08 Thread Harry Wentland
On 2019-10-08 10:00 a.m., Joe Perches wrote: > On Tue, 2019-10-08 at 13:56 +, Harry Wentland wrote: > [] >>> diff --git a/drivers/gpu/drm/amd/display/dc/bios/bios_parser.c >>> b/drivers/gpu/drm/amd/display/dc/bios/bios_parser.c >> [] >>> @@ -2745,7 +2745,7 @@ static enum bp_result bios_get_boa

Re: [PATCH 1/3] dt-bindings: arm: samsung: Force clkoutN names to be unique in PMU

2019-10-08 Thread Krzysztof Kozlowski
On Tue, Oct 08, 2019 at 09:17:16AM -0500, Rob Herring wrote: > On Tue, Oct 8, 2019 at 9:05 AM Rob Herring wrote: > > > > On Tue, Oct 8, 2019 at 7:50 AM Krzysztof Kozlowski wrote: > > > > > > On Tue, Oct 08, 2019 at 07:38:14AM -0500, Rob Herring wrote: > > > > On Fri, Oct 4, 2019 at 10:14 AM Krzys

Re: liboutput: thoughts about shared library on top of DRM/KMS

2019-10-08 Thread Alex Deucher
On Tue, Oct 8, 2019 at 5:32 AM Daniel Stone wrote: > > Hi, > > On Mon, 7 Oct 2019 at 19:16, Keith Packard wrote: > > Daniel Stone writes: > > > I think there would be a load of value in starting with simple helpers > > > which can be used independently of any larger scheme, tackling that > > > l

Re: [PATCH 1/3] dt-bindings: arm: samsung: Force clkoutN names to be unique in PMU

2019-10-08 Thread Rob Herring
On Tue, Oct 8, 2019 at 9:29 AM Krzysztof Kozlowski wrote: > > On Tue, Oct 08, 2019 at 09:17:16AM -0500, Rob Herring wrote: > > On Tue, Oct 8, 2019 at 9:05 AM Rob Herring wrote: > > > > > > On Tue, Oct 8, 2019 at 7:50 AM Krzysztof Kozlowski > > > wrote: > > > > > > > > On Tue, Oct 08, 2019 at 07

Re: liboutput: thoughts about shared library on top of DRM/KMS

2019-10-08 Thread Daniel Vetter
On Tue, Oct 8, 2019 at 4:36 PM Alex Deucher wrote: > > On Tue, Oct 8, 2019 at 5:32 AM Daniel Stone wrote: > > > > Hi, > > > > On Mon, 7 Oct 2019 at 19:16, Keith Packard wrote: > > > Daniel Stone writes: > > > > I think there would be a load of value in starting with simple helpers > > > > which

Re: [PATCH v9 4/5] dt-bindings: backlight: Add led-backlight binding

2019-10-08 Thread Rob Herring
On Tue, Oct 8, 2019 at 7:51 AM Jean-Jacques Hiblot wrote: > > Hi Rob, > > On 07/10/2019 18:15, Rob Herring wrote: > > Please send DT bindings to DT list or it's never in my queue. IOW, > > send patches to the lists that get_maintainers.pl tells you to. > > > > On Mon, Oct 7, 2019 at 7:45 AM Jean-J

Re: [PATCH v8 1/4] drm/panel: Add helper for reading DT rotation

2019-10-08 Thread Sean Paul
On Mon, Oct 07, 2019 at 03:12:00PM -0700, dbasehore . wrote: > On Mon, Oct 7, 2019 at 9:38 AM Sean Paul wrote: > > > > On Wed, Sep 25, 2019 at 03:58:30PM -0700, Derek Basehore wrote: > > > This adds a helper function for reading the rotation (panel > > > orientation) from the device tree. > > > >

Re: [PATCH v9 4/5] dt-bindings: backlight: Add led-backlight binding

2019-10-08 Thread Rob Herring
On Tue, Oct 8, 2019 at 8:30 AM Jean-Jacques Hiblot wrote: > > Rob, > > On 08/10/2019 14:51, Jean-Jacques Hiblot wrote: > > Hi Rob, > > > > On 07/10/2019 18:15, Rob Herring wrote: > >> Please send DT bindings to DT list or it's never in my queue. IOW, > >> send patches to the lists that get_maintai

Re: [PATCH] drm/komeda: Adds zorder support

2019-10-08 Thread Daniel Vetter
On Mon, May 20, 2019 at 5:33 AM Lowry Li (Arm Technology China) wrote: > > - Creates the zpos property. > - Implement komeda_crtc_normalize_zpos to replace > drm_atomic_normalize_zpos, reasons as the following: > > 1. The drm_atomic_normalize_zpos allows to configure same zpos for > different plan

Re: [v8,2/4] drm/panel: set display info in panel attach

2019-10-08 Thread Sean Paul
/snip > > > > > diff --git a/include/drm/drm_panel.h b/include/drm/drm_panel.h > > > > > index d16158deacdc..f3587a54b8ac 100644 > > > > > --- a/include/drm/drm_panel.h > > > > > +++ b/include/drm/drm_panel.h > > > > > @@ -141,6 +141,56 @@ struct drm_panel { > > > > >*/ > > > > > con

  1   2   >