Re: [PATCH] dt-bindings: display: renesas: Add r8a774b1 support

2019-10-04 Thread Laurent Pinchart
Hi Biju, Thank you for the patch. On Mon, Sep 30, 2019 at 10:28:51AM +0100, Biju Das wrote: > Document RZ/G2N (R8A774B1) SoC bindings. > > Signed-off-by: Biju Das I really like how your RZ patches are simple, they're painless to review, it's all very pleasurable :-) Reviewed-by: Laurent Pinch

Re: [PATCH] drm/bridge: sii902x: Variable status in sii902x_connector_detect() could be uninitialized if regmap_read() fails

2019-10-04 Thread Laurent Pinchart
Hi Yizhuo, Thank you for the patch. On Sun, Sep 29, 2019 at 09:45:02PM -0700, Yizhuo wrote: > In function sii902x_connector_detect(), variable "status" could be > initialized if regmap_read() fails. However, "status" is used to I assume you meant "could be uninitialized" ? > decide the return v

Re: [PATCH 0/4] Add RZ/G2N DU support

2019-10-04 Thread Laurent Pinchart
Hi Biju, Thank you for the patches; On Mon, Sep 30, 2019 at 10:15:01AM +0100, Biju Das wrote: > This patch series aims to add binding/driver support for > R8A774B1(a.k.a RZ/G2N) DU (which is very similar to the R8A77965 DU); > it has one RGB output, one LVDS output and one HDMI output. > > Biju

Re: [PATCHv2 2/7] drm/omap: avoid copy in mgr_fld_read/write

2019-10-04 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Mon, Sep 30, 2019 at 01:38:35PM +0300, Tomi Valkeinen wrote: > Avoid unnecessary copy in mgr_fld_read/write by taking a pointer to the > reg_resc and using that. > > Signed-off-by: Tomi Valkeinen Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/omap

Re: [PATCHv2 7/7] drm/omap: hdmi4: fix use of uninitialized var

2019-10-04 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Mon, Sep 30, 2019 at 01:38:40PM +0300, Tomi Valkeinen wrote: > If use_mclk is false, mclk_mode is written to a register without > initialization. This doesn't cause any ill effects as the written value > is not used when use_mclk is false. > > To fix this, wr

Re: [PATCH v1 2/2] drm/panel: simple: add display timings for logic technologies displays

2019-10-04 Thread Philippe Schenker
On Thu, 2019-10-03 at 10:59 -0500, Rob Herring wrote: > On Wed, Oct 2, 2019 at 5:27 AM Philippe Schenker > wrote: > > On Tue, 2019-10-01 at 17:05 -0500, Rob Herring wrote: > > > On Fri, Sep 20, 2019 at 09:54:11AM +0200, Marcel Ziswiler wrote: > > > > From: Marcel Ziswiler > > > > > > > > Add dis

Re: [PATCH 09/11] lib/interval-tree: convert interval_tree to half closed intervals

2019-10-04 Thread Koenig, Christian
Am 04.10.19 um 08:57 schrieb Christian König: > Am 03.10.19 um 22:18 schrieb Davidlohr Bueso: >> The generic tree tree really wants [a, b) intervals, not fully closed. >> As such convert it to use the new interval_tree_gen.h. Most of the >> conversions are straightforward, with the exception of per

Re: [PATCH][next] drm/amdgpu: fix uninitialized variable pasid_mapping_needed

2019-10-04 Thread Koenig, Christian
Am 03.10.19 um 23:52 schrieb Colin King: > From: Colin Ian King > > The boolean variable pasid_mapping_needed is not initialized and > there are code paths that do not assign it any value before it is > is read later. Fix this by initializing pasid_mapping_needed to > false. > > Addresses-Coverit

Re: [PATCH][next] drm/amdgpu: remove redundant variable r and redundant return statement

2019-10-04 Thread Koenig, Christian
Am 03.10.19 um 23:40 schrieb Colin King: > From: Colin Ian King > > There is a return statement that is not reachable and a variable that > is not used. Remove them. > > Addresses-Coverity: ("Structurally dead code") > Fixes: de7b45babd9b ("drm/amdgpu: cleanup creating BOs at fixed location > (v

Re: [PATCH 6/6] [RESEND] drm/amdgpu: work around llvm bug #42576

2019-10-04 Thread Nathan Chancellor
On Wed, Oct 02, 2019 at 09:51:37AM -0700, 'Nick Desaulniers' via Clang Built Linux wrote: > > Apparently this bug is still present in both the released clang-9 > > and the current development version of clang-10. > > I was hoping we would not need a workaround in clang-9+, but > > it seems that we

Re: [PATCH 6/6] [RESEND] drm/amdgpu: work around llvm bug #42576

2019-10-04 Thread Nick Desaulniers
> Apparently this bug is still present in both the released clang-9 > and the current development version of clang-10. > I was hoping we would not need a workaround in clang-9+, but > it seems that we do. I think I'd rather: 1. mark AMDGPU BROKEN if CC_IS_CLANG. There are numerous other issues bui

[PATCH 03/11] drm/amdgpu: convert amdgpu_vm_it to half closed intervals

2019-10-04 Thread Davidlohr Bueso
The amdgpu_vm interval tree really wants [a, b) intervals, not fully closed ones. As such convert it to use the new interval_tree_gen.h, and also rename the 'last' endpoint in the node to 'end', which is both a more suitable name for the half closed interval and also reduces the chances of missing

RE: [PATCH] dt-bindings: display: renesas: Add r8a774b1 support

2019-10-04 Thread Biju Das
Hi Laurent, Thanks for the feedback. > Subject: Re: [PATCH] dt-bindings: display: renesas: Add r8a774b1 support > > Hi Biju, > > Thank you for the patch. > > On Mon, Sep 30, 2019 at 10:28:51AM +0100, Biju Das wrote: > > Document RZ/G2N (R8A774B1) SoC bindings. > > > > Signed-off-by: Biju Das

Re: [Spice-devel] Xorg indefinitely hangs in kernelspace

2019-10-04 Thread Hillf Danton
On Thu, 3 Oct 2019 09:45:55 +0300 Jaak Ristioja wrote: > On 30.09.19 16:29, Frediano Ziglio wrote: > > Why didn't you update bug at > > https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1813620? > > I know it can seem tedious but would help tracking it. > > I suppose the lack on centralized

Re: [PATCH 6/6] [RESEND] drm/amdgpu: work around llvm bug #42576

2019-10-04 Thread Nick Desaulniers
On Wed, Oct 2, 2019 at 10:07 AM Nathan Chancellor wrote: > > On Wed, Oct 02, 2019 at 09:51:37AM -0700, 'Nick Desaulniers' via Clang Built > Linux wrote: > > > Apparently this bug is still present in both the released clang-9 > > > and the current development version of clang-10. > > > I was hopin

[PATCH v3] drm/amd/display: fix struct init in update_bounding_box

2019-10-04 Thread Raul E Rangel
dcn20_resource.c:2636:9: error: missing braces around initializer [-Werror=missing-braces] struct _vcs_dpi_voltage_scaling_st calculated_states[MAX_CLOCK_LIMIT_STATES] = {0}; ^ Fixes: 7ed4e6352c16f ("drm/amd/display: Add DCN2 HW Sequencer and Resource") Signed-off-by: Raul E Rangel

Re: [PATCH v4 7/7] backlight: gpio: pull gpio_backlight_initial_power_state() into probe

2019-10-04 Thread Bartosz Golaszewski
śr., 2 paź 2019 o 16:40 Daniel Thompson napisał(a): > > On Wed, Oct 02, 2019 at 01:46:17PM +0200, Bartosz Golaszewski wrote: > > śr., 2 paź 2019 o 12:33 Daniel Thompson > > napisał(a): > > > > > > On Tue, Oct 01, 2019 at 02:58:37PM +0200, Bartosz Golaszewski wrote: > > > > From: Bartosz Golaszew

[PATCH] dt-bindings: display: Convert stm32 display bindings to json-schema

2019-10-04 Thread Benjamin Gaignard
Convert the STM32 display binding to DT schema format using json-schema. Split the original bindings in two yaml files: - one for display controller (ltdc) - one for DSI controller Signed-off-by: Benjamin Gaignard --- .../devicetree/bindings/display/st,stm32-dsi.yaml | 130 +++

Re: [PATCH 4/6] drm/amd/display: fix dcn21 Makefile for clang

2019-10-04 Thread Nick Desaulniers
On Wed, Oct 2, 2019 at 5:03 AM Arnd Bergmann wrote: > > Just like all the other variants, this one passes invalid > compile-time options with clang after the new code got > merged: > > clang: error: unknown argument: '-mpreferred-stack-boundary=4' > scripts/Makefile.build:265: recipe for target >

Re: [PATCH 4/6] drm/amd/display: fix dcn21 Makefile for clang

2019-10-04 Thread Nick Desaulniers
On Wed, Oct 2, 2019 at 2:24 PM Alex Deucher wrote: > > On Wed, Oct 2, 2019 at 5:19 PM Nick Desaulniers > wrote: > > > > Alex, do you know why the AMDGPU driver uses a different stack > > alignment (16B) than the rest of the x86 kernel? (see > > arch/x86/Makefile which uses 8B stack alignment).

[Bug 111900] clutterrerddd

2019-10-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111900 Andre Klapper changed: What|Removed |Added Resolution|--- |INVALID Status|ASSIGNED

[Bug 111902] too much trees

2019-10-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111902 Andre Klapper changed: What|Removed |Added Resolution|--- |INVALID Status|ASSIGNED

[git pull] drm fixes for 5.4-rc2

2019-10-04 Thread Dave Airlie
Hey Linus, Been offline for 3 days, got back and had some fixes queued up, nothing too major, the i915 dp-mst fix is important, and amdgpu has a bulk move speedup fix and some regressions, but nothing too insane for an rc2 pull. The intel fixes are also 2 weeks worth, they missed the boat last wee

[PATCH] drm: sti: fix spelling mistake: rejec -> rejection

2019-10-04 Thread Colin King
From: Colin Ian King In other places of the driver the string hdmi_rejection_pll is used instead of the truncated hdmi_rejec_pll, so use this string instead to be consistent. Signed-off-by: Colin Ian King --- drivers/gpu/drm/sti/sti_hdmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [Intel-gfx] [PATCH 2/5] dma-fence: Serialise signal enabling (dma_fence_enable_sw_signaling)

2019-10-04 Thread Tvrtko Ursulin
On 03/10/2019 22:00, Chris Wilson wrote: Make dma_fence_enable_sw_signaling() behave like its dma_fence_add_callback() and dma_fence_default_wait() counterparts and perform the test to enable signaling under the fence->lock, along with the action to do so. This ensure that should an implementati

Re: [Intel-gfx] [PATCH 3/5] drm/mm: Use helpers for drm_mm_node booleans

2019-10-04 Thread Tvrtko Ursulin
On 03/10/2019 22:00, Chris Wilson wrote: In preparation for rearranging the booleans into a flags field, ensure all the current users are using the inline helpers and not directly accessing the members. Signed-off-by: Chris Wilson --- drivers/gpu/drm/drm_mm.c | 19 ++

Re: [Intel-gfx] [PATCH 4/5] drm/mm: Convert drm_mm_node booleans to bitops

2019-10-04 Thread Tvrtko Ursulin
On 03/10/2019 22:00, Chris Wilson wrote: A straightforward conversion of assignment and checking of the boolean state flags (allocated, scanned) into non-atomic bitops. The caller remains responsible for all locking around the drm_mm and its nodes. Signed-off-by: Chris Wilson --- drivers/gpu

Re: [PATCH v7 7/9] drm: tegra: use cec_notifier_conn_(un)register

2019-10-04 Thread Hans Verkuil
Hi Thierry, Just a reminder: this patch hasn't been merged yet for v5.5. Thanks! Hans On 8/28/19 1:54 PM, Thierry Reding wrote: > On Wed, Aug 28, 2019 at 12:06:34PM +0200, Hans Verkuil wrote: >> On 8/28/19 11:38 AM, Thierry Reding wrote: >>> On Wed, Aug 28, 2019 at 10:09:30AM +0200, Han

Re: [Intel-gfx] [PATCH 5/5] drm/mm: Use clear_bit_unlock() for releasing the drm_mm_node()

2019-10-04 Thread Tvrtko Ursulin
On 03/10/2019 22:01, Chris Wilson wrote: A few callers need to serialise the destruction of their drm_mm_node and ensure it is removed from the drm_mm before freeing. However, to be completely sure that any access from another thread is complete before we free the struct, we require the RELEASE

Re: [PATCH] backlight: pwm_bl: Add missing curly branches in else branch

2019-10-04 Thread Daniel Thompson
On Thu, Oct 03, 2019 at 02:35:02PM -0700, Matthias Kaehlcke wrote: > Add curly braces to an 'else' branch in pwm_backlight_update_status() > to match the corresponding 'if' branch. > > Signed-off-by: Matthias Kaehlcke Reviewed-by: Daniel Thompson > --- > > drivers/video/backlight/pwm_bl.c |

Re: [Intel-gfx] [PATCH 1/5] drm/i915/execlists: Skip redundant resubmission

2019-10-04 Thread Tvrtko Ursulin
On 03/10/2019 22:00, Chris Wilson wrote: If we unwind the active requests, and on resubmission discover that we intend to preempt the active context with itself, simply skip the ELSP submission. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/gt/intel_lrc.c | 17 - 1 fi

[PATCH] dma-fence: Serialise signal enabling (dma_fence_enable_sw_signaling)

2019-10-04 Thread Chris Wilson
Make dma_fence_enable_sw_signaling() behave like its dma_fence_add_callback() and dma_fence_default_wait() counterparts and perform the test to enable signaling under the fence->lock, along with the action to do so. This ensure that should an implementation be trying to flush the cb_list (by signal

Re: Should regulator core support parsing OF based fwnode?

2019-10-04 Thread Jean-Jacques Hiblot
On 03/10/2019 22:27, Jacek Anaszewski wrote: On 10/3/19 9:41 PM, Mark Brown wrote: On Thu, Oct 03, 2019 at 09:21:06PM +0200, Jacek Anaszewski wrote: On 10/3/19 8:35 PM, Mark Brown wrote: On Thu, Oct 03, 2019 at 07:43:17PM +0200, Jacek Anaszewski wrote: On 10/3/19 2:47 PM, Jean-Jacques Hiblot

[PATCH] drm/amdgpu: fix memory leak

2019-10-04 Thread Nirmoy Das
In amdgpu_bo_list_ioctl when idr_alloc fails don't return without freeing bo list entry. Fixes: 964d0fbf6301d ("drm/amdgpu: Allow to create BO lists in CS ioctl v3") Signed-off-by: Nirmoy Das --- drivers/gpu/drm/amd/amdgpu/amdgpu_bo_list.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: imx6: hdmi black screen issue after resume

2019-10-04 Thread Pintu Agarwal
Hi, On Sun, Sep 29, 2019 at 10:24 PM Pintu Agarwal wrote: > > > > > On Mon, Sep 23, 2019 at 1:28 PM Pintu Agarwal wrote: > > > > > > Dear Philipp, > > > > > > I have a iMX6dl custom board with custom Linux Kernel 4.8. > > > I have both LCD and HDMI connected to the board. > > > And we are using

Re: [Intel-gfx] [PATCH] dma-fence: Serialise signal enabling (dma_fence_enable_sw_signaling)

2019-10-04 Thread Tvrtko Ursulin
On 04/10/2019 11:11, Chris Wilson wrote: Make dma_fence_enable_sw_signaling() behave like its dma_fence_add_callback() and dma_fence_default_wait() counterparts and perform the test to enable signaling under the fence->lock, along with the action to do so. This ensure that should an implementati

[PATCH] drm/i810: Prevent underflow in ioctl

2019-10-04 Thread Dan Carpenter
The "used" variables here come from the user in the ioctl and it can be negative. It could result in an out of bounds write. Signed-off-by: Dan Carpenter --- drivers/gpu/drm/i810/i810_dma.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i810/i810_dma.c b

Re: [PATCH] drm/drm_edid: correct VIC and HDMI_VIC under HDMI 2.0

2019-10-04 Thread Lin, Wayne
From: Ville Syrjälä Sent: Thursday, October 3, 2019 21:29 To: Lin, Wayne Cc: dri-devel@lists.freedesktop.org ; amd-...@lists.freedesktop.org ; Li, Sun peng (Leo) ; Kazlauskas, Nicholas Subject: Re: [PATCH] drm/drm_edid: correct VIC and HDMI_VIC under HDMI 2.0

Re: [PATCH] drm/amdgpu: fix memory leak

2019-10-04 Thread Koenig, Christian
First of all please send mails regarding amdgpu to the amd-gfx mailing list and not lkml/dri-devel. Am 04.10.19 um 12:17 schrieb Nirmoy Das: > In amdgpu_bo_list_ioctl when idr_alloc fails > don't return without freeing bo list entry. > > Fixes: 964d0fbf6301d ("drm/amdgpu: Allow to create BO lists

Re: [PATCH] drm: atomic helper: fix W=1 warnings

2019-10-04 Thread Benjamin Gaignard
Le jeu. 3 oct. 2019 à 17:46, Ville Syrjälä a écrit : > > On Thu, Oct 03, 2019 at 05:37:15PM +0200, Benjamin Gaignard wrote: > > Le jeu. 3 oct. 2019 à 17:05, Ville Syrjälä > > a écrit : > > > > > > On Thu, Oct 03, 2019 at 04:46:54PM +0200, Benjamin Gaignard wrote: > > > > Le jeu. 3 oct. 2019 à 16:

Re: [PATCH] drm/amdgpu: fix memory leak

2019-10-04 Thread Nirmoy
On 10/4/19 12:44 PM, Koenig, Christian wrote: > First of all please send mails regarding amdgpu to the amd-gfx mailing > list and not lkml/dri-devel. Okay. > Am 04.10.19 um 12:17 schrieb Nirmoy Das: >> In amdgpu_bo_list_ioctl when idr_alloc fails >> don't return without freeing bo list entry. >> >

Re: [PATCH 02/11] lib/interval-tree: add an equivalent tree with [a,b) intervals

2019-10-04 Thread Michel Lespinasse
On Thu, Oct 03, 2019 at 01:18:49PM -0700, Davidlohr Bueso wrote: > +/* \ > + * Iterate over intervals intersecting [start;end) \ > + *

[PATCH] cec: add cec_adapter to cec_notifier_cec_adap_unregister()

2019-10-04 Thread Hans Verkuil
It is possible for one HDMI connector to have multiple CEC adapters. The typical real-world scenario is that where one adapter is used when the device is in standby, and one that's better/smarter when the device is powered up. The cec-notifier changes were made with that in mind, but I missed that

Re: [Intel-gfx] [PATCH 5/5] drm/mm: Use clear_bit_unlock() for releasing the drm_mm_node()

2019-10-04 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-10-04 10:15:20) > > On 03/10/2019 22:01, Chris Wilson wrote: > > A few callers need to serialise the destruction of their drm_mm_node and > > ensure it is removed from the drm_mm before freeing. However, to be > > completely sure that any access from another thread is

Re: [PATCH] drm/amdgpu: fix memory leak

2019-10-04 Thread Koenig, Christian
Am 04.10.19 um 13:00 schrieb Das, Nirmoy: > On 10/4/19 12:44 PM, Koenig, Christian wrote: >> First of all please send mails regarding amdgpu to the amd-gfx mailing >> list and not lkml/dri-devel. > Okay. >> Am 04.10.19 um 12:17 schrieb Nirmoy Das: >>> In amdgpu_bo_list_ioctl when idr_alloc fails >>

[PATCH 1/2] drm: bridge: adv7511: Enable SPDIF DAI

2019-10-04 Thread Bogdan Togorean
ADV7511 support I2S or SPDIF as audio input interfaces. This commit enable support for SPDIF. Signed-off-by: Bogdan Togorean --- drivers/gpu/drm/bridge/adv7511/adv7511_audio.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_audio.c b/dri

Re: [Intel-gfx] [PATCH 5/5] drm/mm: Use clear_bit_unlock() for releasing the drm_mm_node()

2019-10-04 Thread Chris Wilson
Quoting Chris Wilson (2019-10-04 12:07:10) > Quoting Tvrtko Ursulin (2019-10-04 10:15:20) > > > > On 03/10/2019 22:01, Chris Wilson wrote: > > > A few callers need to serialise the destruction of their drm_mm_node and > > > ensure it is removed from the drm_mm before freeing. However, to be > > >

[Bug 111729] RX480 : random NULL pointer dereference on resume from suspend

2019-10-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111729 --- Comment #6 from p...@phi-gamma.net --- I agree with SET that bisecting would not be feasible due to the rarity of the bug. For reference, the affected box just now crashed after a week of no issue with suspending and resuming approx. twice a

[PATCH 2/2] drm: bridge: adv7511: Extend list of audio sample rates

2019-10-04 Thread Bogdan Togorean
ADV7511 support sample rates up to 192kHz. CTS and N parameters should be computed accordingly so this commit extend the list up to maximum supported sample rate. Signed-off-by: Bogdan Togorean --- drivers/gpu/drm/bridge/adv7511/adv7511_audio.c | 12 1 file changed, 12 insertions(+)

Re: [PATCH] drm/amdgpu: fix memory leak

2019-10-04 Thread Nirmoy
On 10/4/19 1:13 PM, Koenig, Christian wrote: > >>> NAK, that is a double free. The bo list entries are freed by >>> amdgpu_bo_list_put(). >> Thanks, didn't realize that. > Wait a second, what entries are you talking about? > > The entries in the list object are freed when amdgpu_bo_list_put() is >

[Bug 204885] ryzen 2500U cause graphics glitch in all browsers with kernel version 5.2.x+

2019-10-04 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=204885 no2stable (pro...@outlook.com) changed: What|Removed |Added Component|Video(DRI - non Intel) |Other Hard

Re: [PATCH] drm/amdgpu: fix memory leak

2019-10-04 Thread Koenig, Christian
Am 04.10.19 um 13:26 schrieb Das, Nirmoy: > On 10/4/19 1:13 PM, Koenig, Christian wrote: NAK, that is a double free. The bo list entries are freed by amdgpu_bo_list_put(). >>> Thanks, didn't realize that. >> Wait a second, what entries are you talking about? >> >> The entries in the list

Re: [PATCH] drm/amdgpu: fix memory leak

2019-10-04 Thread Nirmoy
On 10/4/19 1:30 PM, Koenig, Christian wrote: > Am 04.10.19 um 13:26 schrieb Das, Nirmoy: >> On 10/4/19 1:13 PM, Koenig, Christian wrote: > NAK, that is a double free. The bo list entries are freed by > amdgpu_bo_list_put(). Thanks, didn't realize that. >>> Wait a second, what entries

Re: Should regulator core support parsing OF based fwnode? (was: Re: [PATCH v8 2/5] leds: Add of_led_get() and led_put())

2019-10-04 Thread Mark Brown
On Thu, Oct 03, 2019 at 10:27:26PM +0200, Jacek Anaszewski wrote: > On 10/3/19 9:41 PM, Mark Brown wrote: > > Why would we want to do that? We'd continue to support only DT systems, > > just with code that's less obviously DT only and would need to put > > checks in. I'm not seeing an upside her

Re: [PATCH V6 5/8] backlight: qcom-wled: Restructure the driver for WLED3

2019-10-04 Thread kgunda
On 2019-10-01 20:47, Dan Murphy wrote: Kiran On 9/30/19 1:39 AM, Kiran Gunda wrote: Restructure the driver to add the support for new WLED peripherals. Signed-off-by: Kiran Gunda Acked-by: Daniel Thompson --- drivers/video/backlight/qcom-wled.c | 395 ++--

Re: [PATCH 05/11] IB/hfi1: convert __mmu_int_rb to half closed intervals

2019-10-04 Thread Michel Lespinasse
On Thu, Oct 03, 2019 at 01:18:52PM -0700, Davidlohr Bueso wrote: > diff --git a/drivers/infiniband/hw/hfi1/mmu_rb.c > b/drivers/infiniband/hw/hfi1/mmu_rb.c > index 14d2a90964c3..fb6382b2d44e 100644 > --- a/drivers/infiniband/hw/hfi1/mmu_rb.c > +++ b/drivers/infiniband/hw/hfi1/mmu_rb.c > @@ -47,7 +

Re: [Intel-gfx] [PATCH 5/5] drm/mm: Use clear_bit_unlock() for releasing the drm_mm_node()

2019-10-04 Thread Tvrtko Ursulin
On 04/10/2019 12:17, Chris Wilson wrote: Quoting Chris Wilson (2019-10-04 12:07:10) Quoting Tvrtko Ursulin (2019-10-04 10:15:20) On 03/10/2019 22:01, Chris Wilson wrote: A few callers need to serialise the destruction of their drm_mm_node and ensure it is removed from the drm_mm before freei

Re: [PATCH 07/11] vhost: convert vhost_umem_interval_tree to half closed intervals

2019-10-04 Thread Michel Lespinasse
On Thu, Oct 03, 2019 at 01:18:54PM -0700, Davidlohr Bueso wrote: > @@ -1320,15 +1320,14 @@ static bool iotlb_access_ok(struct vhost_virtqueue > *vq, > { > const struct vhost_umem_node *node; > struct vhost_umem *umem = vq->iotlb; > - u64 s = 0, size, orig_addr = addr, last = addr

[PATCH] drm/drm_syncobj: Dead code removal

2019-10-04 Thread Zbigniew Kempczyński
Remove dead code, likely overseened during review process. Signed-off-by: Zbigniew Kempczyński Cc: Chunming Zhou Cc: Daniel Vetter Cc: Jason Ekstrand --- drivers/gpu/drm/drm_syncobj.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/gpu/drm/drm_syncobj.c b/drivers/gpu/drm/drm_sy

Re: [PATCH] drm/drm_syncobj: Dead code removal

2019-10-04 Thread Chris Wilson
Quoting Zbigniew Kempczyński (2019-10-04 13:16:52) > Remove dead code, likely overseened during review process. Hint: It's not dead. -Chris ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-deve

Re: [PATCH] drm/drm_syncobj: Dead code removal

2019-10-04 Thread Lionel Landwerlin
On 04/10/2019 15:16, Zbigniew Kempczyński wrote: Remove dead code, likely overseened during review process. Signed-off-by: Zbigniew Kempczyński Cc: Chunming Zhou Cc: Daniel Vetter Cc: Jason Ekstrand --- drivers/gpu/drm/drm_syncobj.c | 4 1 file changed, 4 deletions(-) diff --git a/d

Re: [PATCH] drm: atomic helper: fix W=1 warnings

2019-10-04 Thread Ville Syrjälä
On Fri, Oct 04, 2019 at 12:48:02PM +0200, Benjamin Gaignard wrote: > Le jeu. 3 oct. 2019 à 17:46, Ville Syrjälä > a écrit : > > > > On Thu, Oct 03, 2019 at 05:37:15PM +0200, Benjamin Gaignard wrote: > > > Le jeu. 3 oct. 2019 à 17:05, Ville Syrjälä > > > a écrit : > > > > > > > > On Thu, Oct 03, 2

Re: [PATCH] drm/amdgpu: Fix build error when !CONFIG_PERF_EVENTS

2019-10-04 Thread Alex Deucher
On Thu, Oct 3, 2019 at 10:13 PM Huacai Chen wrote: > > In previous release amdgpu_pmu.o is only built when CONFIG_PERF_EVENTS > is selected. But after commit 64f55e629237e4752db1 ("drm/amdgpu: Add RAS > EEPROM table.") it is duplicated in amdgpu-y. This change causes a build > error when !CONFIG_P

Re: [PATCH] drm: atomic helper: fix W=1 warnings

2019-10-04 Thread Benjamin GAIGNARD
On 10/4/19 2:27 PM, Ville Syrjälä wrote: > On Fri, Oct 04, 2019 at 12:48:02PM +0200, Benjamin Gaignard wrote: >> Le jeu. 3 oct. 2019 à 17:46, Ville Syrjälä >> a écrit : >>> On Thu, Oct 03, 2019 at 05:37:15PM +0200, Benjamin Gaignard wrote: Le jeu. 3 oct. 2019 à 17:05, Ville Syrjälä a é

Re: [PATCH 03/11] drm/amdgpu: convert amdgpu_vm_it to half closed intervals

2019-10-04 Thread Christian König
Hi Michel, Am 04.10.19 um 13:36 schrieb Michel Lespinasse: On Fri, Oct 04, 2019 at 06:54:54AM +, Koenig, Christian wrote: Am 03.10.19 um 22:18 schrieb Davidlohr Bueso: The amdgpu_vm interval tree really wants [a, b) intervals, NAK, we explicitly do need an [a, b[ interval here. Hi Christ

[Bug 110674] Crashes / Resets From AMDGPU / Radeon VII

2019-10-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110674 --- Comment #155 from ReddestDream --- So, I've done some tests with 5.4-rc1 and it seems like I'm getting similar results to line...@xcpp.org and sehell...@gmail.com. I'm using GNOME with Wayland (which works fine with only 1 display). Sometime

Re: [PATCH -next 00/11] lib/interval-tree: move to half closed intervals

2019-10-04 Thread Michel Lespinasse
On Thu, Oct 03, 2019 at 01:32:50PM -0700, Matthew Wilcox wrote: > On Thu, Oct 03, 2019 at 01:18:47PM -0700, Davidlohr Bueso wrote: > > It has been discussed[1,2] that almost all users of interval trees would > > better > > be served if the intervals were actually not [a,b], but instead [a, b). Thi

Re: [PATCH v3] drm/amd/display: fix struct init in update_bounding_box

2019-10-04 Thread Alex Deucher
On Thu, Oct 3, 2019 at 4:35 PM Raul E Rangel wrote: > > dcn20_resource.c:2636:9: error: missing braces around initializer > [-Werror=missing-braces] > struct _vcs_dpi_voltage_scaling_st > calculated_states[MAX_CLOCK_LIMIT_STATES] = {0}; > ^ > > Fixes: 7ed4e6352c16f ("drm/amd/display:

Re: [PATCH] drm/amd/display: Make some functions static

2019-10-04 Thread Alex Deucher
On Fri, Oct 4, 2019 at 8:25 AM zhengbin wrote: > > Fix sparse warnings: > > drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_hdcp.c:32:6: > warning: symbol 'lp_write_i2c' was not declared. Should it be static? > drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_hdcp.c:42:6: > wa

Re: [PATCH][next] drm/amdgpu: fix uninitialized variable pasid_mapping_needed

2019-10-04 Thread Alex Deucher
On Fri, Oct 4, 2019 at 3:28 AM Koenig, Christian wrote: > > Am 03.10.19 um 23:52 schrieb Colin King: > > From: Colin Ian King > > > > The boolean variable pasid_mapping_needed is not initialized and > > there are code paths that do not assign it any value before it is > > is read later. Fix this

Re: [PATCH] cec: add cec_adapter to cec_notifier_cec_adap_unregister()

2019-10-04 Thread Ville Syrjälä
On Fri, Oct 04, 2019 at 01:04:24PM +0200, Hans Verkuil wrote: > It is possible for one HDMI connector to have multiple CEC adapters. The > typical real-world scenario is that where one adapter is used when the device > is in standby, and one that's better/smarter when the device is powered up. > >

Re: [PATCH][next] drm/amdgpu: remove redundant variable r and redundant return statement

2019-10-04 Thread Alex Deucher
On Fri, Oct 4, 2019 at 3:29 AM Koenig, Christian wrote: > > Am 03.10.19 um 23:40 schrieb Colin King: > > From: Colin Ian King > > > > There is a return statement that is not reachable and a variable that > > is not used. Remove them. > > > > Addresses-Coverity: ("Structurally dead code") > > Fix

Re: [PATCH] drm: atomic helper: fix W=1 warnings

2019-10-04 Thread Ville Syrjälä
On Fri, Oct 04, 2019 at 12:36:56PM +, Benjamin GAIGNARD wrote: > > On 10/4/19 2:27 PM, Ville Syrjälä wrote: > > On Fri, Oct 04, 2019 at 12:48:02PM +0200, Benjamin Gaignard wrote: > >> Le jeu. 3 oct. 2019 à 17:46, Ville Syrjälä > >> a écrit : > >>> On Thu, Oct 03, 2019 at 05:37:15PM +0200, Ben

Re: [PATCH -next 00/11] lib/interval-tree: move to half closed intervals

2019-10-04 Thread Michel Lespinasse
Hi Jason, On Thu, Oct 3, 2019 at 5:26 PM Jason Gunthorpe wrote: > Hurm, this is not entirely accurate. Most users do actually want > overlapping and multiple ranges. I just studied this extensively: (Just curious, are you the person we discussed this with after the Maple Tree talk at LPC 2019 ?)

Re: Should regulator core support parsing OF based fwnode?

2019-10-04 Thread Jean-Jacques Hiblot
On 04/10/2019 13:39, Mark Brown wrote: On Thu, Oct 03, 2019 at 10:27:26PM +0200, Jacek Anaszewski wrote: On 10/3/19 9:41 PM, Mark Brown wrote: Why would we want to do that? We'd continue to support only DT systems, just with code that's less obviously DT only and would need to put checks in.

[Bug 111729] RX480 : random NULL pointer dereference on resume from suspend

2019-10-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111729 --- Comment #7 from m...@cschwarz.com --- I began bisecting yesterday and discovered another bug that happens on suspend, which makes it hard to determine the good/bad status of a build with regards to _this_ bug in a timely manner. Hence abortin

[Bug 111244] amdgpu kernel 5.2 blank display after resume from suspend

2019-10-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111244 --- Comment #33 from Andrey Grodzovsky --- OOO today -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.

[Bug 111244] amdgpu kernel 5.2 blank display after resume from suspend

2019-10-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111244 --- Comment #32 from mib...@gmx.at --- Cannot reproduce it anymore as of 5.4rc1, seems like it's fixed for me! -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel ma

Re: general protection fault in veth_get_stats64

2019-10-04 Thread Willem de Bruijn
On Wed, Oct 2, 2019 at 5:45 PM syzbot wrote: > > Hello, > > syzbot found the following crash on: > > HEAD commit:a32db7e1 Add linux-next specific files for 20191002 > git tree: linux-next > console output: https://syzkaller.appspot.com/x/log.txt?x=175ab7cd60 > kernel config: https:/

[PATCH] drm/i915: customize DPCD brightness control for specific panel

2019-10-04 Thread Lee Shawn C
This panel (manufacturer is SDC, product ID is 0x4141) used manufacturer defined DPCD register to control brightness that not defined in eDP spec so far. This change follow panel vendor's instruction to support brightness adjustment. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=97883 Cc

Re: [PATCH 1/2] drm: bridge: adv7511: Enable SPDIF DAI

2019-10-04 Thread kbuild test robot
Hi Bogdan, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [cannot apply to v5.4-rc1 next-20191004] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base'

Re: [PATCH] drm/i810: Prevent underflow in ioctl

2019-10-04 Thread Chris Wilson
Quoting Dan Carpenter (2019-10-04 11:22:51) > The "used" variables here come from the user in the ioctl and it can be > negative. It could result in an out of bounds write. > > Signed-off-by: Dan Carpenter > --- > drivers/gpu/drm/i810/i810_dma.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 de

[PATCH v3] drm/fourcc: Add Arm 16x16 block modifier

2019-10-04 Thread Ayan Halder
From: Raymond Smith Add the DRM_FORMAT_MOD_ARM_16X16_BLOCK_U_INTERLEAVED modifier to denote the 16x16 block u-interleaved format used in Arm Utgard and Midgard GPUs. Changes from v1:- 1. Reserved the upper four bits (out of the 56 bits assigned to each vendor) to denote the category of Arm speci

[Outreachy][VKMS] Apply to VKMS

2019-10-04 Thread Lorrany dos santos
Hi guys, I'm Lorrany Azevedo, and I'm participating in the application phase for the outreachy internships. I'm interested in making a contribution to VKMS, and I would like to ask for tips on how I can do this, I'm new to the community and I never made any contribution to the FOSS. _

[PATCH 2/4] drm/edid: Extract drm_mode_cea_vic()

2019-10-04 Thread Ville Syrjala
From: Ville Syrjälä Extract the logic to compute the final CEA VIC to a small helper. We'll reorder it a bit to make future modifications more straightforward. No function changes. Cc: Wayne Lin Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/drm_edid.c | 53 +

[PATCH 4/4] drm/edid: Prep for HDMI VIC aspect ratio (WIP)

2019-10-04 Thread Ville Syrjala
From: Ville Syrjälä I think this should provide most of necessary logic for adding aspecr ratios to the HDMI 4k modes. Cc: Wayne Lin Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/drm_edid.c | 37 +++-- 1 file changed, 31 insertions(+), 6 deletions(-) diff -

[PATCH 1/4] drm/edid: Make drm_get_cea_aspect_ratio() static

2019-10-04 Thread Ville Syrjala
From: Ville Syrjälä drm_get_cea_aspect_ratio() is not used outside drm_edid.c. Make it static. Cc: Wayne Lin Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/drm_edid.c | 10 +- include/drm/drm_edid.h | 1 - 2 files changed, 1 insertion(+), 10 deletions(-) diff --git a/drivers/g

[PATCH 3/4] drm/edid: Fix HDMI VIC handling

2019-10-04 Thread Ville Syrjala
From: Ville Syrjälä Extract drm_mode_hdmi_vic() to correctly calculate the final HDMI VIC for us. Currently this is being done a bit differently between the AVI and HDMI infoframes. Let's get both to agree on this. We need to allow the case where a mode is both 3D and has a HDMI VIC. Currently w

Re: [PATCH] drm/drm_edid: correct VIC and HDMI_VIC under HDMI 2.0

2019-10-04 Thread Ville Syrjälä
On Fri, Oct 04, 2019 at 10:41:20AM +, Lin, Wayne wrote: > > > > From: Ville Syrjälä > Sent: Thursday, October 3, 2019 21:29 > To: Lin, Wayne > Cc: dri-devel@lists.freedesktop.org ; > amd-...@lists.freedesktop.org ; Li, Sun peng > (Leo) ; Kazlauskas, Nichol

Re: [PATCH v3] drm/fourcc: Add Arm 16x16 block modifier

2019-10-04 Thread Ayan Halder
On Fri, Oct 04, 2019 at 02:12:38PM +, Ayan Halder wrote: > From: Raymond Smith > > Add the DRM_FORMAT_MOD_ARM_16X16_BLOCK_U_INTERLEAVED modifier to > denote the 16x16 block u-interleaved format used in Arm Utgard and > Midgard GPUs. > > Changes from v1:- > 1. Reserved the upper four bits (ou

[RFC PATCH 3/3] drm/komeda: Allow non-component drm_bridge only endpoints

2019-10-04 Thread Mihail Atanassov
To support transmitters other than the tda998x, we need to allow non-component framework bridges to be attached to a dummy drm_encoder in our driver. For the existing supported encoder (tda998x), keep the behaviour as-is, since there's no way to unbind if a drm_bridge module goes away under our fe

[PATCH 1/3] drm/komeda: Consolidate struct komeda_drv allocations

2019-10-04 Thread Mihail Atanassov
struct komeda_drv has two pointer members only, and both it and its members get allocated separately. Since both members' types are in scope, there's not a lot to gain by keeping the indirection around. To avoid double-free issues, provide a barebones ->release() hook for the driver. Signed-off-b

[PATCH 0/3] drm/komeda: Support for drm_bridge endpoints

2019-10-04 Thread Mihail Atanassov
Greetings, This series attempts to add support for endpoints (in the DT sense) whose drivers only have a drm_bridge interface, unlike the tda998x, which uses the component framework and provides all of drm_encoder, drm_bridge, drm_connector. 1 & 2 should be fairly non-contentious, and I believe a

[PATCH 2/3] drm/komeda: Memory manage struct komeda_drv in probe/remove

2019-10-04 Thread Mihail Atanassov
Some fields of komeda_drv members will be useful very early in probe code, so make sure an instance is available. Signed-off-by: Mihail Atanassov --- .../gpu/drm/arm/display/komeda/komeda_drv.c | 30 +++ 1 file changed, 17 insertions(+), 13 deletions(-) diff --git a/drivers/gp

Re: [PATCH v7 4/5] dt-bindings: backlight: Add led-backlight binding

2019-10-04 Thread Lee Jones
On Wed, 18 Sep 2019, Jean-Jacques Hiblot wrote: > Add DT binding for led-backlight. > > Signed-off-by: Jean-Jacques Hiblot > Reviewed-by: Daniel Thompson > --- > .../bindings/leds/backlight/led-backlight.txt | 28 +++ > 1 file changed, 28 insertions(+) > create mode 100644 >

Re: [PATCH v7 5/5] backlight: add led-backlight driver

2019-10-04 Thread Lee Jones
On Wed, 18 Sep 2019, Jean-Jacques Hiblot wrote: > From: Tomi Valkeinen > > This patch adds a led-backlight driver (led_bl), which is similar to > pwm_bl except the driver uses a LED class driver to adjust the > brightness in the HW. Multiple LEDs can be used for a single backlight. > > Signed-o

Re: Should regulator core support parsing OF based fwnode?

2019-10-04 Thread Mark Brown
On Fri, Oct 04, 2019 at 03:33:13PM +0200, Jean-Jacques Hiblot wrote: > On 04/10/2019 13:39, Mark Brown wrote: > > Consumers should just be able to request a regulator without having to > > worry about how that's being provided - they should have no knowledge at > > all of firmware bindings or plat

[PATCH] drm/panfrost: Remove NULL check for regulator

2019-10-04 Thread Steven Price
devm_regulator_get() is used to populate pfdev->regulator which ensures that this cannot be NULL (a dummy regulator will be returned if necessary). So remove the check in panfrost_devfreq_target(). Signed-off-by: Steven Price --- This looks like it was accidentally reintroduced by the merge from

[PATCH TRIVIAL v2] gpu: Fix Kconfig indentation

2019-10-04 Thread Krzysztof Kozlowski
Adjust indentation from spaces to tab (+optional two spaces) as in coding style with command like: $ sed -e 's/^/\t/' -i */Kconfig Signed-off-by: Krzysztof Kozlowski --- Changes since v1: 1. Fix also DRM_AMD_DC_HDCP (new arrival since v1). --- drivers/gpu/drm/Kconfig

Re: drm_sched with panfrost crash on T820

2019-10-04 Thread Grodzovsky, Andrey
On 10/3/19 4:34 AM, Neil Armstrong wrote: > Hi Andrey, > > Le 02/10/2019 à 16:40, Grodzovsky, Andrey a écrit : >> On 9/30/19 10:52 AM, Hillf Danton wrote: >>> On Mon, 30 Sep 2019 11:17:45 +0200 Neil Armstrong wrote: Did a new run from 5.3: [ 35.971972] Call trace: [ 35.9743

  1   2   >