RK3288 DRM source for plane mirror..

2019-09-13 Thread Securecoded
Dear all, i'm jerry park and first driver porting with rk3288. it is really hard time for me.. now i need plane mirror function, but my SDK could't do it. i fount your patch project https://lists.freedesktop.org/archives/dri-devel/2019-January/202816.html but i can't  download your source file

image size is wrong in EDID, how to use EDID quirks

2019-09-13 Thread zhangn1...@outlook.com
Dear developers I have a Samsung 40’ HDMI TV, which has wrong EDID. The actaul size of this TV is 40’ (88cm*49cm), but in EDID the size is 49’ (106*63cm) Thus makes image size is larger than screen, both in console and desktop. In order to correct, use edid firmware is a chioce. But I want to

Re: [PATCH v2 2/2] drm/bridge: add it6505 driver

2019-09-13 Thread Guenter Roeck
Hi, On Tue, Sep 03, 2019 at 06:51:54PM +0800, allen wrote: > From: Allen Chen > > This adds support for the iTE IT6505. > This device can convert DPI signal to DP output. > > Signed-off-by: Jitao Shi > Signed-off-by: Yilun Lin > Signed-off-by: Allen Chen I tried to provide feedback on this

[PATCH] drm/ttm: fix memory leak in ttm_bo_mem_space

2019-09-13 Thread Christian König
Fix accidential removed line in commit 726b7d4170e5 "drm/ttm: return -EBUSY on pipelining with no_gpu_wait". Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c index 2899

[PATCH] drm/amd/display: rename variable eanble -> enable

2019-09-13 Thread Colin King
From: Colin Ian King There is a spelling mistake in the variable name eanble, rename it to enable. Signed-off-by: Colin Ian King --- drivers/gpu/drm/amd/display/dc/dce/dce_mem_input.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/dce

Re: [RFC PATCH] drm/virtio: Export resource handles via DMA-buf API

2019-09-13 Thread Gerd Hoffmann
Hi, > > > To seamlessly enable buffer sharing with drivers using such frameworks, > > > make the virtio-gpu driver expose the resource handle as the DMA address > > > of the buffer returned from the DMA-buf mapping operation. Arguably, the > > > resource handle is a kind of DMA address already,

Re: HDCP Content Type Interface

2019-09-13 Thread Daniel Vetter
On Thu, Sep 12, 2019 at 9:21 PM Harry Wentland wrote: > > > > On 2019-09-12 10:57 a.m., Jani Nikula wrote: > > On Thu, 12 Sep 2019, Harry Wentland wrote: > >> On 2019-09-12 3:47 a.m., Ramalingam C wrote: > >>> On 2019-09-09 at 15:54:50 +, Lakha, Bhawanpreet wrote: > Hi all, > >

Re: [PATCH] drm: rcar-du: Add r8a77980 support

2019-09-13 Thread Simon Horman
On Thu, Sep 12, 2019 at 01:00:41PM +0300, Sergei Shtylyov wrote: > Hello! > > On 11.09.2019 22:25, Kieran Bingham wrote: > > > Add direct support for the r8a77980 (V3H). > > > > The V3H shares a common, compatible configuration with the r8a77970 > > (V3M) so that device info structure is reused.

Re: [PATCH] Revert "drm/bridge: adv7511: Attach to DSI host at probe time"

2019-09-13 Thread Andrzej Hajda
On 29.08.2019 20:08, Rob Clark wrote: > From: Rob Clark > > This reverts commit 83f35bc3a852f1c3892c7474998c5cec707c7ba3. > > This commit the wrong direction, we should really be changing panel > framework to attach dsi host after probe, rather than introducing > the same probe-order problem that

Re: [PATCH] drm: rcar-du: Add r8a77980 support

2019-09-13 Thread Geert Uytterhoeven
On Fri, Sep 13, 2019 at 10:21 AM Simon Horman wrote: > On Thu, Sep 12, 2019 at 01:00:41PM +0300, Sergei Shtylyov wrote: > > On 11.09.2019 22:25, Kieran Bingham wrote: > > > Add direct support for the r8a77980 (V3H). > > > The V3H shares a common, compatible configuration with the r8a77970 > > > (V

Re: [RFC PATCH] drm/virtio: Export resource handles via DMA-buf API

2019-09-13 Thread Tomasz Figa
On Fri, Sep 13, 2019 at 5:07 PM Gerd Hoffmann wrote: > > Hi, > > > > > To seamlessly enable buffer sharing with drivers using such frameworks, > > > > make the virtio-gpu driver expose the resource handle as the DMA address > > > > of the buffer returned from the DMA-buf mapping operation. Argu

Re: [PATCH v3] drm: bridge/dw_hdmi: add audio sample channel status setting

2019-09-13 Thread Neil Armstrong
On 13/09/2019 08:37, Jonas Karlman wrote: > On 2019-09-11 19:02, Cheng-yi Chiang wrote: >> On Thu, Sep 12, 2019 at 12:54 AM Jernej Škrabec >> wrote: >>> Dne sreda, 11. september 2019 ob 18:23:59 CEST je Neil Armstrong napisal(a): On 11/09/2019 10:26, Cheng-Yi Chiang wrote: > From: Yakir

Re: [RFC][PATCH] drm: kirin: Fix dsi probe/attach logic

2019-09-13 Thread Andrzej Hajda
On 12.09.2019 16:18, Matt Redfearn wrote: > > On 12/09/2019 14:21, Andrzej Hajda wrote: >> On 12.09.2019 04:38, John Stultz wrote: >>> On Wed, Sep 4, 2019 at 3:26 AM Andrzej Hajda wrote: On 03.09.2019 18:18, John Stultz wrote: > On Mon, Sep 2, 2019 at 6:22 AM Andrzej Hajda wrote: >>

Re: [PATCH v2 2/2] drm/etnaviv: print MMU exception cause

2019-09-13 Thread Lucas Stach
On Fr, 2019-09-13 at 07:50 +0200, Christian Gmeiner wrote: > Might be useful when debugging MMU exceptions. > > Changes in V2: > - Use a static array of string for error message as suggested >by Lucas Stach. Please move those changelogs below the 3 dashes, so they don't end up in the commit

Re: [PATCH] drm: rcar-du: Add r8a77980 support

2019-09-13 Thread Simon Horman
On Fri, Sep 13, 2019 at 10:30:45AM +0200, Geert Uytterhoeven wrote: > On Fri, Sep 13, 2019 at 10:21 AM Simon Horman wrote: > > On Thu, Sep 12, 2019 at 01:00:41PM +0300, Sergei Shtylyov wrote: > > > On 11.09.2019 22:25, Kieran Bingham wrote: > > > > Add direct support for the r8a77980 (V3H). > > >

Re: [PATCH] drm: rcar-du: Add r8a77980 support

2019-09-13 Thread Laurent Pinchart
Hello, On Fri, Sep 13, 2019 at 10:21:29AM +0200, Simon Horman wrote: > On Thu, Sep 12, 2019 at 01:00:41PM +0300, Sergei Shtylyov wrote: > > On 11.09.2019 22:25, Kieran Bingham wrote: > > > > > Add direct support for the r8a77980 (V3H). > > > > > > The V3H shares a common, compatible configuratio

Re: [PATCH] drm/panfrost: Prevent race when handling page fault

2019-09-13 Thread Steven Price
On 07/09/2019 20:36, Daniel Vetter wrote: > On Fri, Sep 6, 2019 at 2:42 PM Steven Price wrote: >> >> On 06/09/2019 12:10, Rob Herring wrote: >>> On Thu, Sep 5, 2019 at 1:11 PM Steven Price wrote: When handling a GPU page fault addr_to_drm_mm_node() is used to translate the GPU addr

Re: [PATCH v2] dt-bindings: gpu: Convert Samsung Image Rotator to dt-schema

2019-09-13 Thread Marek Szyprowski
Hi Krzysztof, On 9/13/19 8:29 AM, Krzysztof Kozlowski wrote: > On Thu, Sep 12, 2019 at 06:15:38PM +0200, Maciej Falkowski wrote: >> Convert Samsung Image Rotator to newer dt-schema format. >> >> Signed-off-by: Maciej Falkowski >> Signed-off-by: Marek Szyprowski > Just to make it clear, Marek's s

Re: [PATCH v2] dt-bindings: gpu: Convert Samsung Image Rotator to dt-schema

2019-09-13 Thread Krzysztof Kozlowski
On Fri, 13 Sep 2019 at 11:15, Marek Szyprowski wrote: > > Hi Krzysztof, > > On 9/13/19 8:29 AM, Krzysztof Kozlowski wrote: > > On Thu, Sep 12, 2019 at 06:15:38PM +0200, Maciej Falkowski wrote: > >> Convert Samsung Image Rotator to newer dt-schema format. > >> > >> Signed-off-by: Maciej Falkowski

Re: [PATCH v5 2/2] drm/bridge: Add NWL MIPI DSI host controller support

2019-09-13 Thread Andrzej Hajda
On 09.09.2019 04:25, Guido Günther wrote: > This adds initial support for the NWL MIPI DSI Host controller found on > i.MX8 SoCs. > > It adds support for the i.MX8MQ but the same IP can be found on > e.g. the i.MX8QXP. > > It has been tested on the Librem 5 devkit using mxsfb. > > Signed-off-by: Gu

[RFC PATCH 1/7] mm: Add write-protect and clean utilities for address space ranges

2019-09-13 Thread VMware
From: Thomas Hellstrom Add two utilities to a) write-protect and b) clean all ptes pointing into a range of an address space. The utilities are intended to aid in tracking dirty pages (either driver-allocated system memory or pci device memory). The write-protect utility should be used in conjunc

[RFC PATCH 7/7] drm/vmwgfx: Add surface dirty-tracking callbacks

2019-09-13 Thread VMware
From: Thomas Hellstrom Add the callbacks necessary to implement emulated coherent memory for surfaces. Add a flag to the gb_surface_create ioctl to indicate that surface memory should be coherent. Also bump the drm minor version to signal the availability of coherent surfaces. Cc: Andrew Morton

[RFC PATCH 2/7] drm/ttm: Allow the driver to provide the ttm struct vm_operations_struct

2019-09-13 Thread VMware
From: Thomas Hellstrom Add a pointer to the struct vm_operations_struct in the bo_device, and assign that pointer to the default value currently used. The driver can then optionally modify that pointer and the new value can be used for each new vma created. Cc: Andrew Morton Cc: Matthew Wilcox

[RFC PATCH 3/7] drm/ttm: TTM fault handler helpers

2019-09-13 Thread VMware
From: Thomas Hellstrom With the vmwgfx dirty tracking, the default TTM fault handler is not completely sufficient (vmwgfx need to modify the vma->vm_flags member, and also needs to restrict the number of prefaults). We also want to replicate the new ttm_bo_vm_reserve() functionality So start tu

[RFC PATCH 4/7] drm/vmwgfx: Implement an infrastructure for write-coherent resources

2019-09-13 Thread VMware
From: Thomas Hellstrom This infrastructure will, for coherent resources, make sure that from the user-space point of view, data written by the CPU is immediately automatically available to the GPU at resource validation time. Cc: Andrew Morton Cc: Matthew Wilcox Cc: Will Deacon Cc: Peter Zijl

[RFC PATCH 0/7] Emulated coherent graphics memory take 2

2019-09-13 Thread VMware
From: Thomas Hellström Graphics APIs like OpenGL 4.4 and Vulkan require the graphics driver to provide coherent graphics memory, meaning that the GPU sees any content written to the coherent memory on the next GPU operation that touches that memory, and the CPU sees any content written by the GPU

[RFC PATCH 6/7] drm/vmwgfx: Implement an infrastructure for read-coherent resources

2019-09-13 Thread VMware
From: Thomas Hellstrom Similar to write-coherent resources, make sure that from the user-space point of view, GPU rendered contents is automatically available for reading by the CPU. Cc: Andrew Morton Cc: Matthew Wilcox Cc: Will Deacon Cc: Peter Zijlstra Cc: Rik van Riel Cc: Minchan Kim Cc

Re: [PATCH v5 0/5] Add HDMI jack support on RK3288

2019-09-13 Thread Neil Armstrong
Hi, On 09/09/2019 15:53, Mark Brown wrote: > On Mon, Sep 09, 2019 at 09:37:14AM +0200, Neil Armstrong wrote: > >> I'd like some review from ASoC people and other drm bridge reviewers, >> Jernej, Jonas & Andrzej. > >> Jonas could have some comments on the overall patchset. > > The ASoC bits look

[RFC PATCH 5/7] drm/vmwgfx: Use an RBtree instead of linked list for MOB resources

2019-09-13 Thread VMware
From: Thomas Hellstrom With emulated coherent memory we need to be able to quickly look up a resource from the MOB offset. Instead of traversing a linked list with O(n) worst case, use an RBtree with O(log n) worst case complexity. Cc: Andrew Morton Cc: Matthew Wilcox Cc: Will Deacon Cc: Pete

Re: [PATCH v2] dt-bindings: gpu: Convert Samsung Image Rotator to dt-schema

2019-09-13 Thread Krzysztof Kozlowski
On Fri, 13 Sep 2019 at 11:29, Krzysztof Kozlowski wrote: > > On Fri, 13 Sep 2019 at 11:15, Marek Szyprowski > wrote: > > > > Hi Krzysztof, > > > > On 9/13/19 8:29 AM, Krzysztof Kozlowski wrote: > > > On Thu, Sep 12, 2019 at 06:15:38PM +0200, Maciej Falkowski wrote: > > >> Convert Samsung Image R

[PATCH] dt-bindings: gpu: Convert Samsung Image Scaler to dt-schema

2019-09-13 Thread Maciej Falkowski
Convert Samsung Image Scaler to newer dt-schema format. Signed-off-by: Maciej Falkowski Signed-off-by: Marek Szyprowski --- .../bindings/gpu/samsung-scaler.txt | 27 - .../bindings/gpu/samsung-scaler.yaml | 57 +++ 2 files changed, 57 insertions(+), 27

Re: [Intel-gfx] [PATCH v3 00/37] Introduce memory region concept (including device local memory)

2019-09-13 Thread Dave Airlie
On Thu, 12 Sep 2019 at 23:33, Joonas Lahtinen wrote: > > Quoting Dave Airlie (2019-08-13 22:20:52) > > On Sat, 10 Aug 2019 at 08:26, Matthew Auld wrote: > > > > > > In preparation for upcoming devices with device local memory, introduce > > > the > > > concept of different memory regions, and a

[Bug 111682] use-after-free in amdgpu_vm_update_directories

2019-09-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111682 Bug ID: 111682 Summary: use-after-free in amdgpu_vm_update_directories Product: DRI Version: XOrg git Hardware: Other OS: All Status: NEW Severity: not s

Re: [PATCH] drm/ttm: Restore ttm prefaulting

2019-09-13 Thread Koenig, Christian
Am 12.09.19 um 20:38 schrieb Thomas Hellström (VMware): > From: Thomas Hellstrom > > Commit 4daa4fba3a38 ("gpu: drm: ttm: Adding new return type vm_fault_t") > broke TTM prefaulting. Since vmf_insert_mixed() typically always returns > VM_FAULT_NOPAGE, prefaulting stops after the second PTE. > > Re

Re: [RFC PATCH] drm/virtio: Export resource handles via DMA-buf API

2019-09-13 Thread Gerd Hoffmann
Hi, > > No. DMA master address space in virtual machines is pretty much the > > same it is on physical machines. So, on x86 without iommu, identical > > to (guest) physical address space. You can't re-define it like that. > > That's not true. Even on x86 without iommu the DMA address space c

Re: [PATCH] drm/ttm: Restore ttm prefaulting

2019-09-13 Thread VMware
On 9/13/19 12:53 PM, Koenig, Christian wrote: Am 12.09.19 um 20:38 schrieb Thomas Hellström (VMware): From: Thomas Hellstrom Commit 4daa4fba3a38 ("gpu: drm: ttm: Adding new return type vm_fault_t") broke TTM prefaulting. Since vmf_insert_mixed() typically always returns VM_FAULT_NOPAGE, prefau

Re: [RFC PATCH 1/7] mm: Add write-protect and clean utilities for address space ranges

2019-09-13 Thread VMware
On 9/13/19 11:32 AM, Thomas Hellström (VMware) wrote: From: Thomas Hellstrom Add two utilities to a) write-protect and b) clean all ptes pointing into a range of an address space. The utilities are intended to aid in tracking dirty pages (either driver-allocated system memory or pci device memo

Re: [PATCH] drm/ttm: Restore ttm prefaulting

2019-09-13 Thread Koenig, Christian
Am 13.09.19 um 13:07 schrieb Thomas Hellström (VMware): > On 9/13/19 12:53 PM, Koenig, Christian wrote: >> Am 12.09.19 um 20:38 schrieb Thomas Hellström (VMware): >>> From: Thomas Hellstrom >>> >>> Commit 4daa4fba3a38 ("gpu: drm: ttm: Adding new return type >>> vm_fault_t") >>> broke TTM prefault

[PATCH 1/2] drm/panfrost: Allow passing extra information about BOs used by a job

2019-09-13 Thread Boris Brezillon
The READ/WRITE flags are particularly useful if we want to avoid serialization of jobs that read from the same BO but never write to it. The NO_IMPLICIT_FENCE might be useful when the user knows the BO is shared but jobs are using different portions of the buffer. Signed-off-by: Boris Brezillon -

[PATCH 2/2] drm/panfrost: Extend the bo_wait() ioctl

2019-09-13 Thread Boris Brezillon
So we can choose to wait for all BO users, or just for writers. Signed-off-by: Boris Brezillon --- drivers/gpu/drm/panfrost/panfrost_drv.c | 8 ++-- include/uapi/drm/panfrost_drm.h | 4 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/panfrost/panf

[PATCH 2/9] drm/print: add drm_debug_enabled()

2019-09-13 Thread Jani Nikula
Add helper to check if a drm debug category is enabled. Convert drm core to use it. No functional changes. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_atomic_uapi.c | 2 +- drivers/gpu/drm/drm_dp_mst_topology.c | 6 +++--- drivers/gpu/drm/drm_edid.c| 2 +- drivers/gpu/drm/

[PATCH 7/9] drm/nouveau: use drm_debug_enabled() to check for debug categories

2019-09-13 Thread Jani Nikula
Allow better abstraction of the drm_debug global variable in the future. No functional changes. Cc: Ben Skeggs Cc: nouv...@lists.freedesktop.org Signed-off-by: Jani Nikula --- drivers/gpu/drm/nouveau/dispnv50/disp.h | 4 ++-- drivers/gpu/drm/nouveau/nouveau_drv.h | 4 ++-- 2 files changed, 4

[PATCH 8/9] drm/amdgpu: use drm_debug_enabled() to check for debug categories

2019-09-13 Thread Jani Nikula
Allow better abstraction of the drm_debug global variable in the future. No functional changes. Cc: Alex Deucher Cc: Christian König Cc: David (ChunMing) Zhou Cc: amd-...@lists.freedesktop.org Signed-off-by: Jani Nikula --- drivers/gpu/drm/amd/amdgpu/smu_v11_0_i2c.c | 4 ++-- 1 file changed,

[PATCH 5/9] drm/i915: use drm_debug_enabled() to check for debug categories

2019-09-13 Thread Jani Nikula
Allow better abstraction of the drm_debug global variable in the future. No functional changes. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display.c | 4 ++-- drivers/gpu/drm/i915/display/intel_dp.c | 2 +- drivers/gpu/drm/i915/i915_drv.c | 2 +- drivers/

[PATCH 3/9] drm/etnaviv: use drm_debug_enabled() to check for debug categories

2019-09-13 Thread Jani Nikula
Allow better abstraction of the drm_debug global variable in the future. No functional changes. Cc: Lucas Stach Cc: Russell King Cc: Christian Gmeiner Cc: etna...@lists.freedesktop.org Signed-off-by: Jani Nikula --- drivers/gpu/drm/etnaviv/etnaviv_buffer.c | 8 1 file changed, 4 inse

[PATCH 4/9] drm/i2c/sil164: use drm_debug_enabled() to check for debug categories

2019-09-13 Thread Jani Nikula
Allow better abstraction of the drm_debug global variable in the future. No functional changes. Cc: Francisco Jerez Signed-off-by: Jani Nikula --- drivers/gpu/drm/i2c/sil164_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i2c/sil164_drv.c b/drivers/gpu/

[PATCH 0/9] drm/print: add and use drm_debug_enabled()

2019-09-13 Thread Jani Nikula
Hi all, just a little refactoring around drm_debug access to abstract it better. There shouldn't be any functional changes. I'd appreciate acks for merging the lot via drm-misc. If there are any objections to that, we'll need to postpone the last patch until everything has been merged and converte

[PATCH 1/9] drm/print: move drm_debug variable to drm_print.[ch]

2019-09-13 Thread Jani Nikula
Move drm_debug variable declaration and definition to where they are relevant and needed. No functional changes. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_drv.c | 17 - drivers/gpu/drm/drm_print.c | 19 +++ include/drm/drm_drv.h | 2 -- include/d

[PATCH 6/9] drm/msm: use drm_debug_enabled() to check for debug categories

2019-09-13 Thread Jani Nikula
Allow better abstraction of the drm_debug global variable in the future. No functional changes. Cc: Rob Clark Cc: Sean Paul Cc: linux-arm-...@vger.kernel.org Cc: freedr...@lists.freedesktop.org Signed-off-by: Jani Nikula --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h | 4 ++-- 1 file changed, 2 i

[PATCH 9/9] drm/print: rename drm_debug to __drm_debug to discourage use

2019-09-13 Thread Jani Nikula
drm_debug_enabled() is the way to check. __drm_debug is now reserved for drm print code only. No functional changes. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_print.c | 8 include/drm/drm_print.h | 5 +++-- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/driv

Re: [PATCH 1/2] drm/connector: Share with non-atomic drivers the function to get the single encoder

2019-09-13 Thread Ville Syrjälä
On Thu, Sep 12, 2019 at 12:51:31PM -0700, José Roberto de Souza wrote: > This 3 non-atomic drivers all have the same function getting the > only encoder available in the connector, also atomic drivers have > this fallback. So moving it a common place and sharing between atomic > and non-atomic driv

Re: [PATCH 0/2] drm/panfrost: Tidy up the devfreq implementation

2019-09-13 Thread Tomeu Vizoso
On 9/12/19 12:28 PM, Steven Price wrote: The devfreq implementation in panfrost is unnecessarily open coded. It also tracks utilisation metrics per slot which isn't very useful. Let's tidy it up! This should be picked up along with Mark's change[1] to fix regulator_get_optional() misuse. This al

Re: [PATCH] drm/bridge: Fix references to drm_bridge_funcs in documentation

2019-09-13 Thread Andrzej Hajda
On 22.08.2019 01:55, Laurent Pinchart wrote: > The documentation for most of the bridge atomic operations incorrectly > reference the non-atomic version when stating the operations are > optional. Fix them, and make sure that all references to bridge > operations are correctly marked with @. > > Si

[Bug 111669] Navi GPU hang in Minecraft

2019-09-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111669 --- Comment #2 from Pierre-Eric Pelloux-Prayer --- The kernel patch from https://bugs.freedesktop.org/show_bug.cgi?id=111481#c33 seems to prevent the hang here. Could you try it as well and report the results? -- You are receiving this mail

Re: [PATCH 1/2] drm/connector: Share with non-atomic drivers the function to get the single encoder

2019-09-13 Thread Laurent Pinchart
Hi José, Thank you for the patch. On Thu, Sep 12, 2019 at 12:51:31PM -0700, José Roberto de Souza wrote: > This 3 non-atomic drivers all have the same function getting the > only encoder available in the connector, also atomic drivers have > this fallback. So moving it a common place and sharing

[PATCH 4/8] drm/ttm: factor out ttm_bo_mmap_vma_setup

2019-09-13 Thread Gerd Hoffmann
Factor out ttm vma setup to a new function. Reduces code duplication a bit and allows to implement &drm_gem_object_funcs.mmap in gem ttm helpers. Signed-off-by: Gerd Hoffmann --- include/drm/ttm/ttm_bo_api.h| 8 ++ drivers/gpu/drm/ttm/ttm_bo_vm.c | 47 ++---

dri-devel@lists.freedesktop.org

2019-09-13 Thread Gerd Hoffmann
Switch gem shmem helper to the new mmap() workflow, from &gem_driver.fops.mmap to &drm_gem_object_funcs.mmap. Signed-off-by: Gerd Hoffmann --- include/drm/drm_gem_shmem_helper.h | 6 ++ drivers/gpu/drm/drm_gem_shmem_helper.c | 26 - drivers/gpu/drm/panfrost/pan

[PATCH 0/8] drm: rework mmap() workflow

2019-09-13 Thread Gerd Hoffmann
Add mmap callback to drm_object Gerd Hoffmann (8): drm: add mmap() to drm_gem_object_funcs drm/shmem: switch shmem helper to &drm_gem_object_funcs.mmap drm/shmem: drop DEFINE_DRM_GEM_SHMEM_FOPS drm/ttm: factor out ttm_bo_mmap_vma_setup drm/ttm: add drm_gem_ttm_mmap() drm/vram: switch v

[PATCH 7/8] drm/vram: drop verify_access

2019-09-13 Thread Gerd Hoffmann
Not needed any more. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/drm_gem_vram_helper.c | 22 -- 1 file changed, 22 deletions(-) diff --git a/drivers/gpu/drm/drm_gem_vram_helper.c b/drivers/gpu/drm/drm_gem_vram_helper.c index e100b97ea6e3..42ee80414273 100644 --- a/driv

[PATCH 1/8] drm: add mmap() to drm_gem_object_funcs

2019-09-13 Thread Gerd Hoffmann
drm_gem_object_funcs->vm_ops alone can't handle everything which needs to be done for mmap(), tweaking vm_flags for example. So add a new mmap() callback to drm_gem_object_funcs where this code can go to. Note that the vm_ops field is not used in case the mmap callback is presnt, it is expected t

[PATCH 5/8] drm/ttm: add drm_gem_ttm_mmap()

2019-09-13 Thread Gerd Hoffmann
Add helper function to mmap ttm bo's using &drm_gem_object_funcs.mmap(). Note that with this code path access verification is done by drm_gem_mmap() (which calls drm_vma_node_is_allowed(()). The &ttm_bo_driver.verify_access() callback is is not used. Signed-off-by: Gerd Hoffmann --- include/drm

dri-devel@lists.freedesktop.org

2019-09-13 Thread Gerd Hoffmann
Wire up the new drm_gem_ttm_mmap() helper function, use generic drm_gem_mmap for &fops.mmap and delete dead drm_vram_mm_file_operations_mmap(). Signed-off-by: Gerd Hoffmann --- include/drm/drm_gem_vram_helper.h | 9 +-- drivers/gpu/drm/drm_gem_vram_helper.c | 34 +---

[PATCH 8/8] drm/vram: drop DRM_VRAM_MM_FILE_OPERATIONS

2019-09-13 Thread Gerd Hoffmann
Not needed any more because we don't have vram specific fops any more. DEFINE_DRM_GEM_FOPS() can be used instead. Signed-off-by: Gerd Hoffmann --- include/drm/drm_gem_vram_helper.h | 18 include/drm/drm_vram_mm_helper.h | 82 +++ drivers/gpu/drm/ast

[PATCH 3/8] drm/shmem: drop DEFINE_DRM_GEM_SHMEM_FOPS

2019-09-13 Thread Gerd Hoffmann
DEFINE_DRM_GEM_SHMEM_FOPS is identical to DEFINE_DRM_GEM_FOPS now, drop it. Signed-off-by: Gerd Hoffmann --- include/drm/drm_gem_shmem_helper.h | 26 - drivers/gpu/drm/cirrus/cirrus.c | 2 +- drivers/gpu/drm/panfrost/panfrost_drv.c | 2 +- drivers/gpu/drm/t

Re: [PATCH 0/8] drm: rework mmap() workflow

2019-09-13 Thread Gerd Hoffmann
On Fri, Sep 13, 2019 at 02:29:00PM +0200, Gerd Hoffmann wrote: > Add mmap callback to drm_object Oops, hit sent to early. This should have been this: Add mmap callback to struct drm_gem_object_funcs, which is supposed to handle the vma setup. It will be used by both normal fops->mmap (via drm_g

Re: [PATCH 4/8] drm/ttm: factor out ttm_bo_mmap_vma_setup

2019-09-13 Thread Thomas Zimmermann
Hi Am 13.09.19 um 14:29 schrieb Gerd Hoffmann: > Factor out ttm vma setup to a new function. Reduces > code duplication a bit and allows to implement > &drm_gem_object_funcs.mmap in gem ttm helpers. > > Signed-off-by: Gerd Hoffmann > --- > include/drm/ttm/ttm_bo_api.h| 8 ++ > drivers

Re: [PATCH 5/8] drm/ttm: add drm_gem_ttm_mmap()

2019-09-13 Thread Thomas Zimmermann
Hi Am 13.09.19 um 14:29 schrieb Gerd Hoffmann: > Add helper function to mmap ttm bo's using &drm_gem_object_funcs.mmap(). > > Note that with this code path access verification is done by > drm_gem_mmap() (which calls drm_vma_node_is_allowed(()). > The &ttm_bo_driver.verify_access() callback is is

Re: [PATCH 4/8] drm/ttm: factor out ttm_bo_mmap_vma_setup

2019-09-13 Thread Thomas Zimmermann
Hi Am 13.09.19 um 14:29 schrieb Gerd Hoffmann: > Factor out ttm vma setup to a new function. Reduces > code duplication a bit and allows to implement > &drm_gem_object_funcs.mmap in gem ttm helpers. > > Signed-off-by: Gerd Hoffmann > --- > include/drm/ttm/ttm_bo_api.h| 8 ++ > drivers

Re: [PATCH 2/9] drm/print: add drm_debug_enabled()

2019-09-13 Thread Eric Engestrom
On Friday, 2019-09-13 14:51:39 +0300, Jani Nikula wrote: > Add helper to check if a drm debug category is enabled. Convert drm core > to use it. No functional changes. > > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/drm_atomic_uapi.c | 2 +- > drivers/gpu/drm/drm_dp_mst_topology.c | 6

dri-devel@lists.freedesktop.org

2019-09-13 Thread Thomas Zimmermann
Hi Am 13.09.19 um 14:29 schrieb Gerd Hoffmann: > Wire up the new drm_gem_ttm_mmap() helper function, > use generic drm_gem_mmap for &fops.mmap and > delete dead drm_vram_mm_file_operations_mmap(). > > Signed-off-by: Gerd Hoffmann Reviewed-by: Thomas Zimmermann > --- > include/drm/drm_gem_vra

Re: [PATCH 7/8] drm/vram: drop verify_access

2019-09-13 Thread Thomas Zimmermann
Hi Am 13.09.19 um 14:29 schrieb Gerd Hoffmann: > Not needed any more. > > Signed-off-by: Gerd Hoffmann Reviewed-by: Thomas Zimmermann > --- > drivers/gpu/drm/drm_gem_vram_helper.c | 22 -- > 1 file changed, 22 deletions(-) > > diff --git a/drivers/gpu/drm/drm_gem_vram_he

[PATCH 4.19 092/190] drm/nouveau: Dont WARN_ON VCPI allocation failures

2019-09-13 Thread Greg Kroah-Hartman
[ Upstream commit b513a18cf1d705bd04efd91c417e79e4938be093 ] This is much louder then we want. VCPI allocation failures are quite normal, since they will happen if any part of the modesetting process is interrupted by removing the DP MST topology in question. So just print a debugging message on V

[PATCH 4.19 125/190] PCI: Reset Lenovo ThinkPad P50 nvgpu at boot if necessary

2019-09-13 Thread Greg Kroah-Hartman
[ Upstream commit e0547c81bfcfad01cbbfa93a5e66bb98ab932f80 ] On ThinkPad P50 SKUs with an Nvidia Quadro M1000M instead of the M2000M variant, the BIOS does not always reset the secondary Nvidia GPU during reboot if the laptop is configured in Hybrid Graphics mode. The reason is unknown, but the f

Re: [PATCH 8/8] drm/vram: drop DRM_VRAM_MM_FILE_OPERATIONS

2019-09-13 Thread Thomas Zimmermann
Am 13.09.19 um 14:29 schrieb Gerd Hoffmann: > Not needed any more because we don't have vram specific fops > any more. DEFINE_DRM_GEM_FOPS() can be used instead. > > Signed-off-by: Gerd Hoffmann > --- > include/drm/drm_gem_vram_helper.h | 18 > include/drm/drm_vram_mm_helper.

Re: [PATCH 4.19 092/190] drm/nouveau: Dont WARN_ON VCPI allocation failures

2019-09-13 Thread Ilia Mirkin
Hi Greg, This feels like it's missing a From: line. commit b513a18cf1d705bd04efd91c417e79e4938be093 Author: Lyude Paul Date: Mon Jan 28 16:03:50 2019 -0500 drm/nouveau: Don't WARN_ON VCPI allocation failures Is this an artifact of your notification-of-patches process and I never noticed

Re: [PATCH 1/2] drm/panfrost: Allow passing extra information about BOs used by a job

2019-09-13 Thread Steven Price
On 13/09/2019 12:17, Boris Brezillon wrote: > The READ/WRITE flags are particularly useful if we want to avoid > serialization of jobs that read from the same BO but never write to it. > The NO_IMPLICIT_FENCE might be useful when the user knows the BO is > shared but jobs are using different portio

Re: [PATCH 2/2] drm/panfrost: Extend the bo_wait() ioctl

2019-09-13 Thread Steven Price
On 13/09/2019 12:17, Boris Brezillon wrote: > So we can choose to wait for all BO users, or just for writers. > > Signed-off-by: Boris Brezillon Looks good to me: Reviewed-by: Steven Price Although I don't know if the term "writers" should be in the API or if "exclusive" is the preferred term

[Bug 111669] Navi GPU hang in Minecraft

2019-09-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111669 --- Comment #3 from Doug Ty --- Thanks for the response. Still hanging, unfortunately. While the patch allows me to replay the first apitrace just fine now, I'm still hanging in the same spot ingame. Same messages in journalctl I've captured a

Running SPICE on ppc64le

2019-09-13 Thread Niccolò Belli
Hi, Is there any reason why Spice is not available on ppc64le? I've read there are still some issues with big endian, but what's wrong with little endian? I would really love to be able to use QXL and especially USB redirection on my Raptor Blackbird (Power 9). Bests, Niccolo'

dri-devel@lists.freedesktop.org

2019-09-13 Thread Steven Price
On 13/09/2019 13:29, Gerd Hoffmann wrote: > Switch gem shmem helper to the new mmap() workflow, > from &gem_driver.fops.mmap to &drm_gem_object_funcs.mmap. > > Signed-off-by: Gerd Hoffmann > --- > include/drm/drm_gem_shmem_helper.h | 6 ++ > drivers/gpu/drm/drm_gem_shmem_helper.c | 26

Re: [PATCH v4 1/2] dt-bindings: backlight: lm3630a: add enable_gpios

2019-09-13 Thread Dan Murphy
Andreas On 9/12/19 4:32 PM, Andreas Kemnade wrote: add enable-gpios to describe HWEN pin Signed-off-by: Andreas Kemnade Acked-by: Daniel Thompson Reviewed-by: Dan Murphy --- changes in v2: added example changes in v3: added Acked-by changes in v4: moved enable-gpios to the right positio

Re: [PATCH 3/9] drm/etnaviv: use drm_debug_enabled() to check for debug categories

2019-09-13 Thread Lucas Stach
On Fr, 2019-09-13 at 14:51 +0300, Jani Nikula wrote: > Allow better abstraction of the drm_debug global variable in the > future. No functional changes. > > Cc: Lucas Stach > Cc: Russell King > Cc: Christian Gmeiner > Cc: etna...@lists.freedesktop.org > Signed-off-by: Jani Nikula Acked-by: Lu

Re: [RFC PATCH 3/7] drm/ttm: TTM fault handler helpers

2019-09-13 Thread VMware
On 9/13/19 3:40 PM, Hillf Danton wrote: On Fri, 13 Sep 2019 11:32:09 +0200 err = ttm_mem_io_lock(man, true); - if (unlikely(err != 0)) { - ret = VM_FAULT_NOPAGE; - goto out_unlock; - } + if (unlikely(err != 0)) + return VM_FAULT

Re: [PATCH 1/2] dt-bindings: display: Add xylon logicvc bindings documentation

2019-09-13 Thread Rob Herring
On Tue, Sep 10, 2019 at 05:34:08PM +0200, Paul Kocialkowski wrote: > The Xylon LogiCVC is a display controller implemented as programmable > logic in Xilinx FPGAs. > > Signed-off-by: Paul Kocialkowski > --- > .../bindings/display/xylon,logicvc.txt| 188 ++ > 1 file change

Re: [PATCH 4.19 092/190] drm/nouveau: Dont WARN_ON VCPI allocation failures

2019-09-13 Thread Sasha Levin
On Fri, Sep 13, 2019 at 09:33:36AM -0400, Ilia Mirkin wrote: Hi Greg, This feels like it's missing a From: line. commit b513a18cf1d705bd04efd91c417e79e4938be093 Author: Lyude Paul Date: Mon Jan 28 16:03:50 2019 -0500 drm/nouveau: Don't WARN_ON VCPI allocation failures Is this an artifac

Re: [PATCH 4.19 092/190] drm/nouveau: Dont WARN_ON VCPI allocation failures

2019-09-13 Thread Ilia Mirkin
On Fri, Sep 13, 2019 at 10:46 AM Sasha Levin wrote: > > On Fri, Sep 13, 2019 at 09:33:36AM -0400, Ilia Mirkin wrote: > >Hi Greg, > > > >This feels like it's missing a From: line. > > > >commit b513a18cf1d705bd04efd91c417e79e4938be093 > >Author: Lyude Paul > >Date: Mon Jan 28 16:03:50 2019 -0500

blocking ops in drm_sched_cleanup_jobs()

2019-09-13 Thread Steven Price
Hi, I hit the below splat randomly with panfrost. From what I can tell this is a more general issue which would affect other drivers. 8<- [58604.913130] [ cut here ] [58604.918590] WARNING: CPU: 1 PID: 1758 at kernel/sched/core.c:6556 __might_sleep+0x74/0x98 [5860

Re: [PATCH 4.19 092/190] drm/nouveau: Dont WARN_ON VCPI allocation failures

2019-09-13 Thread Greg Kroah-Hartman
On Fri, Sep 13, 2019 at 10:46:27AM -0400, Sasha Levin wrote: > On Fri, Sep 13, 2019 at 09:33:36AM -0400, Ilia Mirkin wrote: > > Hi Greg, > > > > This feels like it's missing a From: line. > > > > commit b513a18cf1d705bd04efd91c417e79e4938be093 > > Author: Lyude Paul > > Date: Mon Jan 28 16:03:

Re: [PATCH 4.19 092/190] drm/nouveau: Dont WARN_ON VCPI allocation failures

2019-09-13 Thread Sasha Levin
On Fri, Sep 13, 2019 at 03:54:56PM +0100, Greg Kroah-Hartman wrote: On Fri, Sep 13, 2019 at 10:46:27AM -0400, Sasha Levin wrote: On Fri, Sep 13, 2019 at 09:33:36AM -0400, Ilia Mirkin wrote: > Hi Greg, > > This feels like it's missing a From: line. > > commit b513a18cf1d705bd04efd91c417e79e4938be

Re: [PATCH 4.19 092/190] drm/nouveau: Dont WARN_ON VCPI allocation failures

2019-09-13 Thread Ilia Mirkin
On Fri, Sep 13, 2019 at 11:01 AM Sasha Levin wrote: > > On Fri, Sep 13, 2019 at 03:54:56PM +0100, Greg Kroah-Hartman wrote: > >On Fri, Sep 13, 2019 at 10:46:27AM -0400, Sasha Levin wrote: > >> On Fri, Sep 13, 2019 at 09:33:36AM -0400, Ilia Mirkin wrote: > >> > Hi Greg, > >> > > >> > This feels lik

Re: [PATCH 4.19 092/190] drm/nouveau: Dont WARN_ON VCPI allocation failures

2019-09-13 Thread Greg Kroah-Hartman
On Fri, Sep 13, 2019 at 11:01:11AM -0400, Sasha Levin wrote: > On Fri, Sep 13, 2019 at 03:54:56PM +0100, Greg Kroah-Hartman wrote: > > On Fri, Sep 13, 2019 at 10:46:27AM -0400, Sasha Levin wrote: > > > On Fri, Sep 13, 2019 at 09:33:36AM -0400, Ilia Mirkin wrote: > > > > Hi Greg, > > > > > > > > Thi

Re: [RFC PATCH 3/7] drm/ttm: TTM fault handler helpers

2019-09-13 Thread Matthew Wilcox
On Fri, Sep 13, 2019 at 11:32:09AM +0200, Thomas Hellström (VMware) wrote: > +vm_fault_t ttm_bo_vm_fault_reserved(struct vm_fault *vmf, > + pgprot_t prot, > + pgoff_t num_prefault) > +{ > + struct vm_area_struct *vma = vmf->vma; >

Re: [PATCH 4.19 092/190] drm/nouveau: Dont WARN_ON VCPI allocation failures

2019-09-13 Thread Sasha Levin
On Fri, Sep 13, 2019 at 04:10:51PM +0100, Greg Kroah-Hartman wrote: On Fri, Sep 13, 2019 at 11:01:11AM -0400, Sasha Levin wrote: On Fri, Sep 13, 2019 at 03:54:56PM +0100, Greg Kroah-Hartman wrote: > On Fri, Sep 13, 2019 at 10:46:27AM -0400, Sasha Levin wrote: > > On Fri, Sep 13, 2019 at 09:33:36

Re: [PATCH 4.19 092/190] drm/nouveau: Dont WARN_ON VCPI allocation failures

2019-09-13 Thread Sasha Levin
On Fri, Sep 13, 2019 at 11:09:22AM -0400, Ilia Mirkin wrote: On Fri, Sep 13, 2019 at 11:01 AM Sasha Levin wrote: On Fri, Sep 13, 2019 at 03:54:56PM +0100, Greg Kroah-Hartman wrote: >On Fri, Sep 13, 2019 at 10:46:27AM -0400, Sasha Levin wrote: >> On Fri, Sep 13, 2019 at 09:33:36AM -0400, Ilia M

[Bug 111669] Navi GPU hang in Minecraft

2019-09-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111669 --- Comment #4 from Pierre-Eric Pelloux-Prayer --- Thanks for the test and new trace. I can reproduce the hang and it seems to go away with AMD_DEBUG=nodma. Another workaround is to use the following kernel parameter amdgpu.vm_update_mode=3 (

Re: [PATCH 1/2] dt-bindings: display: Add xylon logicvc bindings documentation

2019-09-13 Thread Paul Kocialkowski
Hi Rob and thanks for the review! On Fri 13 Sep 19, 15:35, Rob Herring wrote: > On Tue, Sep 10, 2019 at 05:34:08PM +0200, Paul Kocialkowski wrote: > > The Xylon LogiCVC is a display controller implemented as programmable > > logic in Xilinx FPGAs. > > > > Signed-off-by: Paul Kocialkowski > > ---

[PATCH v2] drm/panfrost: Prevent race when handling page fault

2019-09-13 Thread Steven Price
When handling a GPU page fault addr_to_drm_mm_node() is used to translate the GPU address to a buffer object. However it is possible for the buffer object to be freed after the function has returned resulting in a use-after-free of the BO. Change addr_to_drm_mm_node to return the panfrost_gem_obje

Re: [RFC PATCH 3/7] drm/ttm: TTM fault handler helpers

2019-09-13 Thread VMware
On 9/13/19 5:18 PM, Matthew Wilcox wrote: On Fri, Sep 13, 2019 at 11:32:09AM +0200, Thomas Hellström (VMware) wrote: +vm_fault_t ttm_bo_vm_fault_reserved(struct vm_fault *vmf, + pgprot_t prot, + pgoff_t num_prefault) +{ +

Re: [RFC PATCH 3/7] drm/ttm: TTM fault handler helpers

2019-09-13 Thread VMware
On 9/13/19 3:40 PM, Hillf Danton wrote: On Fri, 13 Sep 2019 11:32:09 +0200 err = ttm_mem_io_lock(man, true); - if (unlikely(err != 0)) { - ret = VM_FAULT_NOPAGE; - goto out_unlock; - } + if (unlikely(err != 0)) + return VM_FAULT

Re: image size is wrong in EDID, how to use EDID quirks

2019-09-13 Thread Adam Jackson
On Fri, 2019-09-13 at 04:21 +, zhangn1...@outlook.com wrote: > Dear developers > > I have a Samsung 40’ HDMI TV, which has wrong EDID. > > The actaul size of this TV is 40’ (88cm*49cm), but in EDID the size > is 49’ (106*63cm) > > Thus makes image size is larger than screen, both in conso

  1   2   >