Re: linux-next: Tree for Sep 4 (amd/display/)

2019-09-06 Thread Randy Dunlap
On 9/5/19 6:17 AM, Harry Wentland wrote: > > > On 2019-09-04 4:58 p.m., Randy Dunlap wrote: >> On 9/4/19 6:34 AM, Stephen Rothwell wrote: >>> Hi all, >>> >>> News: this will be the last linux-next I will release until Sept 30. >>> >>> Changes since 20190903: >>> >> >> on x86_64: >> >> In file inc

Re: drm/amdgpu: remove the redundant null check

2019-09-06 Thread zhong jiang
On 2019/9/5 16:38, Markus Elfring wrote: >>> Were any source code analysis tools involved for finding >>> these update candidates? >> With the help of Coccinelle. You can find out some example in >> scripts/coccinelle/. > Thanks for such background information. > Was the script “ifnullfree.cocci”

Re: Xorg indefinitely hangs in kernelspace

2019-09-06 Thread Hillf Danton
On Tue, 6 Aug 2019 21:00:10 +0300 From: Jaak Ristioja > Hello! > > I'm writing to report a crash in the QXL / DRM code in the Linux kernel. > I originally filed the issue on LaunchPad and more details can be found > there, although I doubt whether these details are useful. > > https://bugs.

Re: drm/amdgpu: remove the redundant null check

2019-09-06 Thread Markus Elfring
>> Were any source code analysis tools involved for finding >> these update candidates? > With the help of Coccinelle. You can find out some example in > scripts/coccinelle/. Thanks for such background information. Was the script “ifnullfree.cocci” applied here? Will it be helpful to add attribu

Re: [v2] drm/amdgpu: Remove two redundant null pointer checks

2019-09-06 Thread Markus Elfring
> The functions "debugfs_remove" and "kfree" tolerate the passing > of null pointers. Hence it is unnecessary to check such arguments > around the calls. Thus remove the extra condition check at two places. Will a tag like “Generated-by: scripts/coccinelle/free/ifnullfree.cocci” be relevant here?

[PATCH] drm/amd/display: Move static keyword to the front of declaration

2019-09-06 Thread Krzysztof Wilczynski
Move the static keyword to the front of declaration of DC_BUILD_ID, and resolve the following compiler warning that can be seen when building with warnings enabled (W=1): drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:75:1: warning: ‘static’ is not at beginning of declaration [-Wold-style-de

[PULL] drm-misc-next-fixes

2019-09-06 Thread Maxime Ripard
Hi Daniel, Dave, Here is a drm-misc-next-fixes PR with a significant number of fixes for panfrost. Maxime drm-misc-next-fixes-2019-09-06: - A significant number of panfrost fixes for runtime_pm, MMU and GEM support - A fix for DCS transfers on mcde The following changes since commit 578d2342ec

[PATCH] drm/komeda: SW workaround for D71 doesn't flush shadow registers

2019-09-06 Thread Lowry Li (Arm Technology China)
This is a SW workaround for shadow un-flushed when together with the DOU Timing-disable. D71 HW doesn't update shadow registers when display output is turned off. So when we disable all pipeline components together with display output disabling by one flush or one operation, the disable operation

[git pull] drm fixes for 5.3-rc8 (or final)

2019-09-06 Thread Dave Airlie
Hey Linus, Live from my friend's couch in Barcelona. Latest round of drm fixes, the command line parser regression fixes look a bit larger because they come with selftests included for the bugs they fix. Otherwise a single nouveau, single ingenic and single vmwgfx fix. Dave. drm-fixes-2019-09-06

[PATCH] drm/modes: Make the whitelist more const

2019-09-06 Thread Maxime Ripard
The commit 3764137906a5 ("drm/modes: Introduce a whitelist for the named modes") introduced a whitelist in the named modes lookup code in order to be a bit more robust. However, even though the char pointers were made const, the data they were pointing were not. Let's fix that. Fixes: 3764137906a

Re: [PATCH] drm/modes: Make the whitelist more const

2019-09-06 Thread Jani Nikula
On Fri, 06 Sep 2019, Maxime Ripard wrote: > The commit 3764137906a5 ("drm/modes: Introduce a whitelist for the named > modes") introduced a whitelist in the named modes lookup code in order to > be a bit more robust. > > However, even though the char pointers were made const, the data they were >

Re: [PATCH v2 0/3] ast, mgag200: Map console BO while it's being displayed

2019-09-06 Thread Thomas Zimmermann
Hi Am 05.09.19 um 11:29 schrieb Gerd Hoffmann: > On Thu, Sep 05, 2019 at 10:19:40AM +0200, Thomas Zimmermann wrote: >> Hi >> >> Am 05.09.19 um 09:56 schrieb Daniel Vetter: >>> On Thu, Sep 5, 2019 at 9:01 AM Gerd Hoffmann wrote: Hi, > - imo we should fix this by using the io_m

[PATCH v6 2/3] drm: Introduce epoch counter to drm_connector

2019-09-06 Thread Stanislav Lisovskiy
This counter will be used by drm_helper_probe_detect caller to determine if anything had changed(including edid, connection status and etc). Hardware specific driver detect hooks are responsible for updating this counter when some change is detected to notify the drm part, which can trigger for exa

[PATCH v6 0/3] Send a hotplug when edid changes

2019-09-06 Thread Stanislav Lisovskiy
This series introduce to drm a way to determine if something else except connection_status had changed during probing, which can be used by other drivers as well. Another i915 specific part uses this approach to determine if edid had changed without changing the connection status and send a hotplug

[PATCH v6 3/3] drm/i915: Send hotplug event if edid had changed

2019-09-06 Thread Stanislav Lisovskiy
Added epoch counter checking to intel_encoder_hotplug in order to be able process all the connector changes, besides connection status. Also now any change in connector would result in epoch counter change, so no multiple checks are needed. v2: Renamed change counter to epoch counter. Fixed type n

[PATCH v6 1/3] drm: Add helper to compare edids.

2019-09-06 Thread Stanislav Lisovskiy
Many drivers would benefit from using drm helper to compare edid, rather than bothering with own implementation. v2: Added documentation for this function. Signed-off-by: Stanislav Lisovskiy --- drivers/gpu/drm/drm_edid.c | 33 + include/drm/drm_edid.h | 9 +

[PATCH v3 2/3] drm/vram: Add infrastructure for move_notify()

2019-09-06 Thread Thomas Zimmermann
This patch prepares VRAM helpers for lazy unmapping of buffer objects. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_vram_mm_helper.c | 12 include/drm/drm_vram_mm_helper.h | 4 2 files changed, 16 insertions(+) diff --git a/drivers/gpu/drm/drm_vram_mm_helper.c

[PATCH v3 3/3] drm/vram: Implement lazy unmapping for GEM VRAM buffers

2019-09-06 Thread Thomas Zimmermann
Frequent mapping and unmapping a buffer object adds overhead for modifying the page table and creates debug output. Unmapping a buffer is only required when the memory manager evicts the buffer from its current location. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_gem_vram_helper.c

[PATCH v3 1/3] drm/vram: Add kmap ref-counting to GEM VRAM objects

2019-09-06 Thread Thomas Zimmermann
The kmap and kunmap operations of GEM VRAM buffers can now be called in interleaving pairs. The first call to drm_gem_vram_kmap() maps the buffer's memory to kernel address space and the final call to drm_gem_vram_kunmap() unmaps the memory. Intermediate calls to these functions increment or decrem

[PATCH v3 0/3] Implement lazy unmapping for GEM VRAM buffers

2019-09-06 Thread Thomas Zimmermann
(was: ast, mgag200: Map console BO while it's being displayed) Generic fbdev emulation maps and unmaps the console BO for updating it's content from the shadow buffer. If this involves an actual mapping operation (instead of reusing an existing mapping), lots of debug messages may be printed, such

Re: [PATCH v3 1/3] drm/vram: Add kmap ref-counting to GEM VRAM objects

2019-09-06 Thread Daniel Vetter
On Fri, Sep 06, 2019 at 10:52:12AM +0200, Thomas Zimmermann wrote: > The kmap and kunmap operations of GEM VRAM buffers can now be called > in interleaving pairs. The first call to drm_gem_vram_kmap() maps the > buffer's memory to kernel address space and the final call to > drm_gem_vram_kunmap() u

Re: [PATCH RFC v4 01/16] drm: Add drm_minor_for_each

2019-09-06 Thread Daniel Vetter
On Thu, Sep 05, 2019 at 05:26:08PM -0400, Kenny Ho wrote: > On Thu, Sep 5, 2019 at 4:32 PM Daniel Vetter wrote: > > > *snip* > > drm_dev_unregister gets called on hotunplug, so your cgroup-internal > > tracking won't get out of sync any more than the drm_minor list gets > > out of sync with drm_de

Re: [PATCH 0/8] drm/ttm: remove embedded vma_manager from ttm_bo_device

2019-09-06 Thread Daniel Vetter
On Thu, Sep 05, 2019 at 09:05:01AM +0200, Gerd Hoffmann wrote: > > > Gerd Hoffmann (8): > drm/ttm: turn ttm_bo_device.vma_manager into a pointer > drm/nouveau: switch to gem vma offset manager > drm/vram: switch to gem vma offset manager > drm/radeon: switch to gem vma offset manager >

[PATCH] drm/stm: ltdc: add pinctrl for DPI encoder mode

2019-09-06 Thread Yannick Fertré
The implementation of functions encoder_enable and encoder_disable make possible to control the pinctrl according to the encoder type. The pinctrl must be activated only if the encoder type is DPI. This helps to move the DPI-related pinctrl configuration from all the panel or bridge to the LTDC dt

Re: [PATCH v3 2/3] drm/vram: Add infrastructure for move_notify()

2019-09-06 Thread Daniel Vetter
On Fri, Sep 06, 2019 at 10:52:13AM +0200, Thomas Zimmermann wrote: > This patch prepares VRAM helpers for lazy unmapping of buffer objects. > > Signed-off-by: Thomas Zimmermann > --- > drivers/gpu/drm/drm_vram_mm_helper.c | 12 > include/drm/drm_vram_mm_helper.h | 4 > 2 f

Re: [PATCH v3 3/3] drm/vram: Implement lazy unmapping for GEM VRAM buffers

2019-09-06 Thread Gerd Hoffmann
> +void drm_gem_vram_bo_driver_move_notify(struct ttm_buffer_object *bo, > + bool evict, > + struct ttm_mem_reg *new_mem) > +{ [ ... ] > + if (!kmap->virtual) > + return; > + ttm_bo_kunmap(kmap); > + kma

Re: [PATCH] drm/panfrost: Fix regulator_get_optional() misuse

2019-09-06 Thread Steven Price
(+CC Rob - I'm not sure why he was dropped) On 05/09/2019 17:34, Mark Brown wrote: > On Thu, Sep 05, 2019 at 02:02:38PM +0100, Steven Price wrote: >> On 05/09/2019 13:40, Mark Brown wrote: > >>> Is that safe? You can't rely on being able to change voltages even if >>> there's a physical regulato

[PATCH 2/2] drm/etnaviv: print MMU exception cause

2019-09-06 Thread Christian Gmeiner
Might be useful when debugging MMU exceptions. Signed-off-by: Christian Gmeiner --- drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c b/drivers/gpu/drm/etnaviv/etnaviv_gpu.c index d47d1a8e0

Re: [PATCH 1/2] drm/etnaviv: update hardware headers from rnndb

2019-09-06 Thread Lucas Stach
On Fr, 2019-09-06 at 12:03 +0200, Christian Gmeiner wrote: > Update the state HI and common header from rnndb commit > a04283591a8a (rnndb: update MMU exception causes). > > Signed-off-by: Christian Gmeiner > --- > drivers/gpu/drm/etnaviv/state.xml.h | 37 +- > drivers/gpu/drm/etnaviv/stat

Re: [PATCH v3 2/3] drm/vram: Add infrastructure for move_notify()

2019-09-06 Thread Thomas Zimmermann
Hi Am 06.09.19 um 11:28 schrieb Daniel Vetter: > On Fri, Sep 06, 2019 at 10:52:13AM +0200, Thomas Zimmermann wrote: >> This patch prepares VRAM helpers for lazy unmapping of buffer objects. >> >> Signed-off-by: Thomas Zimmermann >> --- >> drivers/gpu/drm/drm_vram_mm_helper.c | 12 >>

Re: [PATCH 1/2] drm/etnaviv: update hardware headers from rnndb

2019-09-06 Thread Christian Gmeiner
Am Fr., 6. Sept. 2019 um 12:11 Uhr schrieb Lucas Stach : > > On Fr, 2019-09-06 at 12:03 +0200, Christian Gmeiner wrote: > > Update the state HI and common header from rnndb commit > > a04283591a8a (rnndb: update MMU exception causes). > > > > Signed-off-by: Christian Gmeiner > > --- > > drivers/g

[Bug 204181] NULL pointer dereference regression in amdgpu

2019-09-06 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=204181 jamespharve...@gmail.com changed: What|Removed |Added CC||jamespharve...@gmail.com --- C

Re: [PATCH v3 3/3] drm/vram: Implement lazy unmapping for GEM VRAM buffers

2019-09-06 Thread Thomas Zimmermann
Hi Am 06.09.19 um 11:39 schrieb Gerd Hoffmann: >> +void drm_gem_vram_bo_driver_move_notify(struct ttm_buffer_object *bo, >> +bool evict, >> +struct ttm_mem_reg *new_mem) >> +{ > [ ... ] >> +if (!kmap->virtual) >> +

[Bug 204181] NULL pointer dereference regression in amdgpu

2019-09-06 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=204181 --- Comment #48 from jamespharve...@gmail.com --- Vega 64. -- You are receiving this mail because: You are watching the assignee of the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org h

Re: [PATCH 1/2] drm/etnaviv: update hardware headers from rnndb

2019-09-06 Thread Lucas Stach
On Fr, 2019-09-06 at 12:35 +0200, Christian Gmeiner wrote: > Am Fr., 6. Sept. 2019 um 12:11 Uhr schrieb Lucas Stach > : > > On Fr, 2019-09-06 at 12:03 +0200, Christian Gmeiner wrote: > > > Update the state HI and common header from rnndb commit > > > a04283591a8a (rnndb: update MMU exception cause

Re: [PATCH] drm/panfrost: Fix regulator_get_optional() misuse

2019-09-06 Thread Mark Brown
On Fri, Sep 06, 2019 at 11:00:53AM +0100, Steven Price wrote: > On 05/09/2019 17:34, Mark Brown wrote: > > that information, I'd recommend eliminating individual OPPs if some are > > supported or just never doing any regulator configuration if none can be > > set. > The problem on the Hikey960 is

Re: [PATCH 2/2] drm/etnaviv: print MMU exception cause

2019-09-06 Thread Lucas Stach
On Fr, 2019-09-06 at 12:03 +0200, Christian Gmeiner wrote: > Might be useful when debugging MMU exceptions. > > Signed-off-by: Christian Gmeiner > --- > drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 26 > ++ > 1 file changed, 26 insertions(+) > > diff --git a/drivers/gpu/drm/e

Re: [PATCH V4] drm: Add LTTPR defines for DP 1.4a

2019-09-06 Thread Ville Syrjälä
On Thu, Sep 05, 2019 at 07:51:59PM +, Siqueira, Rodrigo wrote: > Hi Ville, > > First of all, thank you very much for the review. > > I added some comments below. > > On 09/05, Wentland, Harry wrote: > > On 2019-09-05 1:29 p.m., Ville Syrjälä wrote: > > > On Wed, Sep 04, 2019 at 07:02:18PM +0

Re: [PATCH] drm/panfrost: Prevent race when handling page fault

2019-09-06 Thread Rob Herring
On Thu, Sep 5, 2019 at 1:11 PM Steven Price wrote: > > When handling a GPU page fault addr_to_drm_mm_node() is used to > translate the GPU address to a buffer object. However it is possible for > the buffer object to be freed after the function has returned resulting > in a use-after-free of the B

Re: [PATCH v3 3/3] drm/vram: Implement lazy unmapping for GEM VRAM buffers

2019-09-06 Thread Gerd Hoffmann
On Fri, Sep 06, 2019 at 12:37:47PM +0200, Thomas Zimmermann wrote: > Hi > > Am 06.09.19 um 11:39 schrieb Gerd Hoffmann: > >> +void drm_gem_vram_bo_driver_move_notify(struct ttm_buffer_object *bo, > >> + bool evict, > >> + struct ttm

Re: [PATCH v2] drm/connector: Allow max possible encoders to attach to a connector

2019-09-06 Thread Ville Syrjälä
On Thu, Sep 05, 2019 at 02:09:27PM -0700, José Roberto de Souza wrote: > From: Dhinakaran Pandiyan > > Currently we restrict the number of encoders that can be linked to > a connector to 3, increase it to match the maximum number of encoders > that can be initialized(32). > > To more effiently d

RE: [PATCH v4 3/7] drm: Add DisplayPort colorspace property

2019-09-06 Thread Shankar, Uma
>-Original Message- >From: Ilia Mirkin >Sent: Tuesday, September 3, 2019 6:12 PM >To: Mun, Gwan-gyeong >Cc: Intel Graphics Development ; Shankar, Uma >; dri-devel >Subject: Re: [PATCH v4 3/7] drm: Add DisplayPort colorspace property > >So how would this work with a DP++ connector? Shou

Re: [PATCH v4 3/7] drm: Add DisplayPort colorspace property

2019-09-06 Thread Ville Syrjälä
On Fri, Sep 06, 2019 at 11:31:55AM +, Shankar, Uma wrote: > > > >-Original Message- > >From: Ilia Mirkin > >Sent: Tuesday, September 3, 2019 6:12 PM > >To: Mun, Gwan-gyeong > >Cc: Intel Graphics Development ; Shankar, > >Uma > >; dri-devel > >Subject: Re: [PATCH v4 3/7] drm: Add D

[Bug 110659] pageflipping seems to cause jittering on mouse input when running Hitman 2 in Wine/DXVK with amdgpu.dc=1

2019-09-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110659 --- Comment #68 from tempel.jul...@gmail.com --- I did it, but it stopped after hitting the two breakpoints the first time without me having moved the mouse at all. I suppose this isn't enough? Would it be possible to provide me with a short hint

[Bug 110659] pageflipping seems to cause jittering on mouse input when running Hitman 2 in Wine/DXVK with amdgpu.dc=1

2019-09-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110659 --- Comment #69 from tempel.jul...@gmail.com --- Created attachment 145278 --> https://bugs.freedesktop.org/attachment.cgi?id=145278&action=edit 1st gdb log -- You are receiving this mail because: You are the assignee for the bug.

Re: [PATCH v4 05/17] drm: add mmap() to drm_gem_object_funcs

2019-09-06 Thread Gerd Hoffmann
Hi, > I think if we do an mmap callback, it should replace all the mmap handling > (except the drm_gem_object_get) that drm_gem_mmap_obj does. So maybe > something like the below: [ snip ] > Since I remember quite a few discussions where the default vma flag > wrangling we're doing is seriousl

[PATCH v4 4/4] drm/vram: Implement lazy unmapping for GEM VRAM buffers

2019-09-06 Thread Thomas Zimmermann
Frequent mapping and unmapping a buffer object adds overhead for modifying the page table and creates debug output. Unmapping a buffer is only required when the memory manager evicts the buffer from its current location. v4: * WARN_ON if buffer is still mapped during BO cleanup Signed-off

[PATCH v4 1/4] drm/vram: Add kmap ref-counting to GEM VRAM objects

2019-09-06 Thread Thomas Zimmermann
The kmap and kunmap operations of GEM VRAM buffers can now be called in interleaving pairs. The first call to drm_gem_vram_kmap() maps the buffer's memory to kernel address space and the final call to drm_gem_vram_kunmap() unmaps the memory. Intermediate calls to these functions increment or decrem

[PATCH v4 2/4] drm/vram: Acquire lock only once per call to vmap()/vunmap()

2019-09-06 Thread Thomas Zimmermann
The implementation of vmap() is a combined pin() and kmap(). As both functions share the same lock, we can make vmap() slightly faster by acquiring the lock only once for both operations. Same for the inverse, vunmap(). Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_gem_vram_helper.c |

[PATCH v4 3/4] drm/vram: Add infrastructure for move_notify()

2019-09-06 Thread Thomas Zimmermann
This patch prepares VRAM helpers for lazy unmapping of buffer objects. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_vram_mm_helper.c | 12 include/drm/drm_vram_mm_helper.h | 4 2 files changed, 16 insertions(+) diff --git a/drivers/gpu/drm/drm_vram_mm_helper.c

[PATCH v4 0/4] Implement lazy unmapping for GEM VRAM buffers

2019-09-06 Thread Thomas Zimmermann
Generic fbdev emulation maps and unmaps the console BO for updating it's content from the shadow buffer. If this involves an actual mapping operation (instead of reusing an existing mapping), lots of debug messages may be printed, such as x86/PAT: Overlap at 0xd000-0xd100 x86/PAT: rese

Re: [PATCH] drm/panfrost: Prevent race when handling page fault

2019-09-06 Thread Steven Price
On 06/09/2019 12:10, Rob Herring wrote: > On Thu, Sep 5, 2019 at 1:11 PM Steven Price wrote: >> >> When handling a GPU page fault addr_to_drm_mm_node() is used to >> translate the GPU address to a buffer object. However it is possible for >> the buffer object to be freed after the function has ret

Re: [PATCH v3 2/3] drm/vram: Add infrastructure for move_notify()

2019-09-06 Thread Daniel Vetter
On Fri, Sep 6, 2019 at 12:24 PM Thomas Zimmermann wrote: > > Hi > > Am 06.09.19 um 11:28 schrieb Daniel Vetter: > > On Fri, Sep 06, 2019 at 10:52:13AM +0200, Thomas Zimmermann wrote: > >> This patch prepares VRAM helpers for lazy unmapping of buffer objects. > >> > >> Signed-off-by: Thomas Zimmerm

Re: [PATCH v4 05/17] drm: add mmap() to drm_gem_object_funcs

2019-09-06 Thread Daniel Vetter
On Fri, Sep 6, 2019 at 2:13 PM Gerd Hoffmann wrote: > > Hi, > > > I think if we do an mmap callback, it should replace all the mmap handling > > (except the drm_gem_object_get) that drm_gem_mmap_obj does. So maybe > > something like the below: > > [ snip ] > > > Since I remember quite a few disc

Re: [PATCH v4 3/7] drm: Add DisplayPort colorspace property

2019-09-06 Thread Ilia Mirkin
On Fri, Sep 6, 2019 at 7:43 AM Ville Syrjälä wrote: > > On Fri, Sep 06, 2019 at 11:31:55AM +, Shankar, Uma wrote: > > > > > > >-Original Message- > > >From: Ilia Mirkin > > >Sent: Tuesday, September 3, 2019 6:12 PM > > >To: Mun, Gwan-gyeong > > >Cc: Intel Graphics Development ; Shank

[PATCH v4 0/9 drm: rcar-du: Add Color Management Module (CMM)

2019-09-06 Thread Jacopo Mondi
Hello, new iteration of CMM support, with quite a few changes compared to v3: References: A reference to the v1 cover letter, with some background on the CMM is available here: https://lkml.org/lkml/2019/6/6/583 v2: https://lore.kernel.org/linux-renesas-soc/20190706140746.29132-10-jacopo+rene...@j

[PATCH v3] drm: rcar-du: kms: Expand comment in vsps parsing routine

2019-09-06 Thread Jacopo Mondi
Expand comment in the 'vsps' parsing routine to specify the LIF channel index defaults to 0 in case the second cell of the property is not specified to remain compatible with older DT bindings. Reviewed-by: Laurent Pinchart Signed-off-by: Jacopo Mondi --- This trivial change is a leftover from a

[PATCH v4 6/9] drm: rcar-du: crtc: Enable and disable CMMs

2019-09-06 Thread Jacopo Mondi
Enable/disable the CMM associated with a CRTC at CRTC start and stop time and enable the CMM unit through the Display Extensional Functions register at group setup time. Reviewed-by: Ulrich Hecht Reviewed-by: Laurent Pinchart Signed-off-by: Jacopo Mondi --- drivers/gpu/drm/rcar-du/rcar_du_crtc

[PATCH v4 8/9] drm: rcar-du: kms: Update CMM in atomic commit tail

2019-09-06 Thread Jacopo Mondi
Update CMM settings at in the atomic commit tail helper method. The CMM is updated with new gamma values provided to the driver in the GAMMA_LUT blob property. When resuming from system suspend, the DU driver is responsible for reprogramming and enabling the CMM unit if it was in use at the time t

[PATCH v4 0/9 drm: rcar-du: Add Color Management Module (CMM)

2019-09-06 Thread Jacopo Mondi
[ Ugh, sorry for the double sending, but I forgot --cc-cover to git-send email and the series has not been delivered to the mailing lists. Sorry about that. ] Hello, new iteration of CMM support, with quite a few changes compared to v3: References: A reference to the v1 cover letter, with som

[PATCH v4 9/9] arm64: dts: renesas: Add CMM units to Gen3 SoCs

2019-09-06 Thread Jacopo Mondi
Add CMM units to Renesas R-Car Gen3 SoC that support it, and reference them from the Display Unit they are connected to. Sort the 'vsps' and 'renesas,cmm' entries in the DU unit consistently in all the involved DTS. Signed-off-by: Jacopo Mondi --- arch/arm64/boot/dts/renesas/r8a7795.dtsi | 40

[PATCH v4 5/9] drm: rcar-du: kms: Initialize CMM instances

2019-09-06 Thread Jacopo Mondi
Implement device tree parsing to collect the available CMM instances described by the 'renesas,cmms' property. Associate CMMs with CRTCs and store a mask of active CMMs in the DU group for later enablement. Enforce the probe and suspend/resume ordering of DU and CMM by creating a stateless device

[PATCH v4 4/9] drm: rcar-du: Claim CMM support for Gen3 SoCs

2019-09-06 Thread Jacopo Mondi
Add CMM to the list of supported features for Gen3 SoCs that provide it: - R8A7795 - R8A7796 - R8A77965 - R8A7799x Leave R8A77970 out as V3M and V3H are the only Gen3 SoCs that do not support CMM. Reviewed-by: Ulrich Hecht Reviewed-by: Laurent Pinchart Signed-off-by: Jacopo Mondi --- drivers/

[PATCH v4 7/9] drm: rcar-du: crtc: Register GAMMA_LUT properties

2019-09-06 Thread Jacopo Mondi
Enable the GAMMA_LUT KMS property using the framework helpers to register the property and set the associated gamma table maximum size. Reviewed-by: Ulrich Hecht Reviewed-by: Laurent Pinchart Signed-off-by: Jacopo Mondi --- drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 4 1 file changed, 4 ins

[PATCH v4 3/9] drm: rcar-du: Add support for CMM

2019-09-06 Thread Jacopo Mondi
Add a driver for the R-Car Display Unit Color Correction Module. In most of Gen3 SoCs, each DU output channel is provided with a CMM unit to perform image enhancement and color correction. Add support for CMM through a driver that supports configuration of the 1-dimensional LUT table. More advanc

[PATCH v4 1/9] dt-bindings: display: renesas,cmm: Add R-Car CMM documentation

2019-09-06 Thread Jacopo Mondi
Add device tree bindings documentation for the Renesas R-Car Display Unit Color Management Module. CMM is the image enhancement module available on each R-Car DU video channel on R-Car Gen2 and Gen3 SoCs (V3H and V3M excluded). Signed-off-by: Jacopo Mondi --- .../bindings/display/renesas,cmm.ya

[PATCH v4 2/9] dt-bindings: display, renesas,du: Document cmms property

2019-09-06 Thread Jacopo Mondi
Document the newly added 'cmms' property which accepts a list of phandle and channel index pairs that point to the CMM units available for each Display Unit output video channel. Signed-off-by: Jacopo Mondi Reviewed-by: Laurent Pinchart --- Documentation/devicetree/bindings/display/renesas,du.t

[Bug 110659] pageflipping seems to cause jittering on mouse input when running Hitman 2 in Wine/DXVK with amdgpu.dc=1

2019-09-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110659 --- Comment #70 from Michel Dänzer --- (In reply to tempel.julian from comment #68) > I did it, but it stopped after hitting the two breakpoints the first time > without me having moved the mouse at all. I suppose this isn't enough? Would > it b

Re: [PATCH 2/2] drm/etnaviv: print MMU exception cause

2019-09-06 Thread Christian Gmeiner
Am Fr., 6. Sept. 2019 um 12:55 Uhr schrieb Lucas Stach : > > On Fr, 2019-09-06 at 12:03 +0200, Christian Gmeiner wrote: > > Might be useful when debugging MMU exceptions. > > > > Signed-off-by: Christian Gmeiner > > --- > > drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 26 > > ++

Re: [PATCH v3 2/3] drm/vram: Add infrastructure for move_notify()

2019-09-06 Thread Thomas Zimmermann
Hi Am 06.09.19 um 15:05 schrieb Daniel Vetter: > On Fri, Sep 6, 2019 at 12:24 PM Thomas Zimmermann wrote: >> >> Hi >> >> Am 06.09.19 um 11:28 schrieb Daniel Vetter: >>> On Fri, Sep 06, 2019 at 10:52:13AM +0200, Thomas Zimmermann wrote: This patch prepares VRAM helpers for lazy unmapping of b

Re: [v4 2/2] drm/arm/mali-dp: Add display QoS interface configuration for Mali DP500

2019-09-06 Thread Liviu Dudau
Hi Wen, On Thu, Aug 22, 2019 at 10:11:35AM +0800, Wen He wrote: > Configure the display Quality of service (QoS) levels priority if the > optional property node "arm,malidp-aqros-value" is defined in DTS file. > > QoS signaling using AQROS and AWQOS AXI interface signals, the AQROS is > driven fr

Re: [PATCH] drm: Use EOPNOTSUPP, not ENOTSUPP

2019-09-06 Thread Daniel Vetter
On Wed, Sep 04, 2019 at 10:05:09PM +0200, Daniel Vetter wrote: > On Wed, Sep 4, 2019 at 9:58 PM Souza, Jose wrote: > > > > On Wed, 2019-09-04 at 16:39 +0200, Daniel Vetter wrote: > > > - it's what we recommend in our docs: > > > > > > https://dri.freedesktop.org/docs/drm/gpu/drm-uapi.html#recommen

Re: [PATCH v3] drm: rcar-du: kms: Expand comment in vsps parsing routine

2019-09-06 Thread Laurent Pinchart
Hi Jacopo, On Fri, Sep 06, 2019 at 03:50:12PM +0200, Jacopo Mondi wrote: > Expand comment in the 'vsps' parsing routine to specify the LIF > channel index defaults to 0 in case the second cell of the property > is not specified to remain compatible with older DT bindings. > > Reviewed-by: Laurent

[PATCH] drm/blend: Define the direction of Z position values

2019-09-06 Thread Daniel Vetter
We forgot that. Proof is the one igt testcase we have: https://gitlab.freedesktop.org/drm/igt-gpu-tools/blob/master/tests/kms_atomic.c#L280 While at it also document that we have immutable zpos properties in some cases. Reported-by: Pekka Paalanen Cc: Pekka Paalanen Reviewed-by: Pekka Paalane

Re: [PATCH] drm/panfrost: Fix regulator_get_optional() misuse

2019-09-06 Thread Steven Price
On 06/09/2019 11:55, Mark Brown wrote: [...] >>> However you're probably better off hiding all this stuff with the >>> generic OPP code rather than open coding it - this already has much >>> better handling for this, it supports voltage ranges rather than single >>> voltages and optional regulators

[Bug 110659] pageflipping seems to cause jittering on mouse input when running Hitman 2 in Wine/DXVK with amdgpu.dc=1

2019-09-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110659 --- Comment #71 from tempel.jul...@gmail.com --- Hope this helps: -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailing list dri-devel@lists.freedesktop.org ht

[Bug 110659] pageflipping seems to cause jittering on mouse input when running Hitman 2 in Wine/DXVK with amdgpu.dc=1

2019-09-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110659 --- Comment #72 from tempel.jul...@gmail.com --- Created attachment 145280 --> https://bugs.freedesktop.org/attachment.cgi?id=145280&action=edit 2nd gdb backtrace log, now with debug symbols -- You are receiving this mail because: You are the

[PATCH] fbdev/sa1100fb: Remove even more dead code

2019-09-06 Thread Arnd Bergmann
This function lost its only call site as part of earlier dead code removal, so remove it as well: drivers/video/fbdev/sa1100fb.c:975:21: error: unused function 'sa1100fb_min_dma_period' [-Werror,-Wunused-function] Fixes: 390e5de11284 ("fbdev/sa1100fb: Remove dead code") Signed-off-by: Arnd Bergm

Re: [PATCH] drm/blend: Define the direction of Z position values

2019-09-06 Thread Daniel Vetter
On Fri, Sep 6, 2019 at 4:45 PM Daniel Vetter wrote: > > We forgot that. > > Proof is the one igt testcase we have: > > https://gitlab.freedesktop.org/drm/igt-gpu-tools/blob/master/tests/kms_atomic.c#L280 > > While at it also document that we have immutable zpos properties in > some cases. > > Repo

Re: [PATCH RFC v4 00/16] new cgroup controller for gpu/drm subsystem

2019-09-06 Thread Tejun Heo
Hello, Daniel. On Tue, Sep 03, 2019 at 09:48:22PM +0200, Daniel Vetter wrote: > I think system memory separate from vram makes sense. For one, vram is > like 10x+ faster than system memory, so we definitely want to have > good control on that. But maybe we only want one vram bucket overall > for t

Re: [PATCH] drm/panfrost: Fix regulator_get_optional() misuse

2019-09-06 Thread Steven Price
On 04/09/2019 13:30, Mark Brown wrote: > The panfrost driver requests a supply using regulator_get_optional() > but both the name of the supply and the usage pattern suggest that it is > being used for the main power for the device and is not at all optional > for the device for function, there is

Re: [PATCH] drm/blend: Define the direction of Z position values

2019-09-06 Thread Daniel Stone
On Fri, 6 Sep 2019 at 16:19, Daniel Vetter wrote: > On Fri, Sep 6, 2019 at 4:45 PM Daniel Vetter wrote: > > We forgot that. > > > > Proof is the one igt testcase we have: > > > > https://gitlab.freedesktop.org/drm/igt-gpu-tools/blob/master/tests/kms_atomic.c#L280 > > > > While at it also document

Re: [PATCH RFC v4 01/16] drm: Add drm_minor_for_each

2019-09-06 Thread Tejun Heo
Hello, On Wed, Sep 04, 2019 at 10:54:34AM +0200, Daniel Vetter wrote: > Anyway, I don't think reusing the drm_minor registration makes sense, > since we want to be on the drm_device, not on the minor. Which is a bit > awkward for cgroups, which wants to identify devices using major.minor > pairs.

[PATCH] staging: fbtft: make several arrays static const, makes object smaller

2019-09-06 Thread Colin King
From: Colin Ian King Don't populate the arrays on the stack but instead make them static const. Makes the object code smaller by 1329 bytes. Before: textdata bss dec hex filename 55811488 6471331bdd drivers/staging/fbtft/fb_hx8340bn.o 54441264

Re: [PATCH RFC v4 00/16] new cgroup controller for gpu/drm subsystem

2019-09-06 Thread Daniel Vetter
On Fri, Sep 6, 2019 at 5:23 PM Tejun Heo wrote: > > Hello, Daniel. > > On Tue, Sep 03, 2019 at 09:48:22PM +0200, Daniel Vetter wrote: > > I think system memory separate from vram makes sense. For one, vram is > > like 10x+ faster than system memory, so we definitely want to have > > good control o

Re: [PATCH RFC v4 01/16] drm: Add drm_minor_for_each

2019-09-06 Thread Daniel Vetter
On Fri, Sep 6, 2019 at 5:29 PM Tejun Heo wrote: > > Hello, > > On Wed, Sep 04, 2019 at 10:54:34AM +0200, Daniel Vetter wrote: > > Anyway, I don't think reusing the drm_minor registration makes sense, > > since we want to be on the drm_device, not on the minor. Which is a bit > > awkward for cgroup

Re: [PATCH RFC v4 01/16] drm: Add drm_minor_for_each

2019-09-06 Thread Tejun Heo
Hello, Daniel. On Fri, Sep 06, 2019 at 05:36:02PM +0200, Daniel Vetter wrote: > Block devices are a great example I think. How do you handle the > partitions on that? For drm we also have a main minor interface, and cgroup IO controllers only distribute hardware IO capacity and are blind to parti

Re: [PATCH RFC v4 00/16] new cgroup controller for gpu/drm subsystem

2019-09-06 Thread Tejun Heo
Hello, Daniel. On Fri, Sep 06, 2019 at 05:34:16PM +0200, Daniel Vetter wrote: > > Hmm... what'd be the fundamental difference from slab or socket memory > > which are handled through memcg? Is system memory used by GPUs have > > further global restrictions in addition to the amount of physical >

Re: [git pull] drm fixes for 5.3-rc8 (or final)

2019-09-06 Thread pr-tracker-bot
The pull request you sent on Fri, 6 Sep 2019 17:18:34 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2019-09-06 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/08d433d8121598f7c2a45f3461c534746b1ed05b Thank you! -- Deet-doot-dot, I am a bot. https://ko

[pull] drm/msm: msm-next for 5.4

2019-09-06 Thread Rob Clark
Hi Dave, This time around: + move msm8998 (snapdragon 835) display support + dpu fixes/cleanup + better async commit support for cursor updates (for dpu for now, I'll add mdp5 and possibly mdp4 once the movers deliver boxes full of my older hardware, so for v5.5) The following change

Re: [PATCH] drm/modes: Make the whitelist more const

2019-09-06 Thread Maxime Ripard
On Fri, Sep 06, 2019 at 10:56:10AM +0300, Jani Nikula wrote: > On Fri, 06 Sep 2019, Maxime Ripard wrote: > > The commit 3764137906a5 ("drm/modes: Introduce a whitelist for the named > > modes") introduced a whitelist in the named modes lookup code in order to > > be a bit more robust. > > > > Howe

[Bug 111236] VA-API radeonsi SIGSEGV __memmove_avx_unaligned

2019-09-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111236 --- Comment #9 from Julien Isorce --- Hi Michel, nice catch! Instead of using totem which has other issues can you try: gst-launch-1.0 filesrc location=test.mp4 ! qtdemux ! h264parse ! vaapih264dec ! vaapipostproc ! videoconvert ! ximagesink

[Bug 110659] pageflipping seems to cause jittering on mouse input when running Hitman 2 in Wine/DXVK with amdgpu.dc=1

2019-09-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110659 --- Comment #73 from Michel Dänzer --- Looks like some client repeatedly calls XForceScreenSaver (probably to prevent the monitors from blanking), which results in the DPMS property getting re-set over and over. Nicholas, maybe the kernel could

[Bug 110659] pageflipping seems to cause jittering on mouse input when running Hitman 2 in Wine/DXVK with amdgpu.dc=1

2019-09-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110659 --- Comment #74 from Nicholas Kazlauskas --- (In reply to Michel Dänzer from comment #73) > Looks like some client repeatedly calls XForceScreenSaver (probably to > prevent the monitors from blanking), which results in the DPMS property > gettin

[Bug 111021] [kernel >=5.2.x][amdgpu][CIK] BUG: KASAN: null-ptr-deref in amdgpu_ib_schedule+0x82/0x790 [amdgpu]

2019-09-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111021 erhar...@mailbox.org changed: What|Removed |Added Summary|[kernel 5.2.1][amdgpu][CIK] |[kernel |BUG: K

[PATCH] omapdrm/dss: Use PTR_ERR_OR_ZERO() in four functions

2019-09-06 Thread Markus Elfring
From: Markus Elfring Date: Fri, 6 Sep 2019 18:40:48 +0200 Simplify these function implementations by using a known function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/gpu/drm/omapdrm/dss/hdmi4.c | 6 +- drivers/gpu/drm/omapdrm

[Bug 111021] [kernel >=5.2.x][amdgpu][CIK] BUG: KASAN: null-ptr-deref in amdgpu_ib_schedule+0x82/0x790 [amdgpu]

2019-09-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111021 erhar...@mailbox.org changed: What|Removed |Added Attachment #144932|0 |1 is obsolete|

[Bug 111021] [kernel >=5.2.x][amdgpu][CIK] BUG: KASAN: null-ptr-deref in amdgpu_ib_schedule+0x82/0x790 [amdgpu]

2019-09-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111021 erhar...@mailbox.org changed: What|Removed |Added Attachment #144933|0 |1 is obsolete|

[Bug 111236] VA-API radeonsi SIGSEGV __memmove_avx_unaligned

2019-09-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111236 --- Comment #10 from Michel Dänzer --- (In reply to Julien Isorce from comment #9) > gst-launch-1.0 filesrc location=test.mp4 ! qtdemux ! h264parse ! > vaapih264dec ! vaapipostproc ! videoconvert ! ximagesink > > (with and without vaapipostpro

possible deadlock in __mmu_notifier_invalidate_range_end

2019-09-06 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:6d028043 Add linux-next specific files for 20190830 git tree: linux-next console output: https://syzkaller.appspot.com/x/log.txt?x=16cbf22a60 kernel config: https://syzkaller.appspot.com/x/.config?x=82a6bec43ab0cb69 dashboard

  1   2   >