Re: [PATCH v2 3/4] drm/via: make via_drv.h self-contained

2019-07-22 Thread Emil Velikov
On Sat, 20 Jul 2019 at 09:45, Sam Ravnborg wrote: > > Added include of header file to make this header file > self-contained. > > Signed-off-by: Sam Ravnborg > Cc: Kevin Brace > Cc: Thomas Hellstrom > Cc: "Gustavo A. R. Silva" > Cc: Mike Marshall > Cc: Ira Weiny > Cc: Daniel Vetter > Cc: Em

[Bug 111193] DRM/admin component is not displaying.

2019-07-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=93 Rakesh changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

Re: [PATCH v2 4/4] drm/via: drop use of drmP.h

2019-07-22 Thread Emil Velikov
On Sat, 20 Jul 2019 at 09:46, Sam Ravnborg wrote: > > Drop use of the deprecated drmP.h header. > While touching the files divide include files in blocks > and sort the files alphabetically. > > v2: > - Replace all uses of DRM_WAIT_ON() with VIA_WAIT_ON() > and thus avoiding to pull in drm_os_li

[Bug 111193] DRM/admin component is not displaying.

2019-07-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=93 Andre Klapper changed: What|Removed |Added Group||spam Component|DRM/amdkfd

Re: [PATCH v2 1/4] drm/via: drop use of DRM(READ|WRITE) macros

2019-07-22 Thread Emil Velikov
On Mon, 22 Jul 2019 at 17:17, Sam Ravnborg wrote: > > Hi Emil. > > On Mon, Jul 22, 2019 at 04:38:39PM +0100, Emil Velikov wrote: > > On Sat, 20 Jul 2019 at 09:46, Sam Ravnborg wrote: > > > > > > The DRM_READ, DRM_WRITE macros comes from the deprecated drm_os_linux.h > > > header file. Remove thei

Re: [PATCH 4/5] drm/panfrost: Add support for GPU heap allocations

2019-07-22 Thread Rob Herring
On Mon, Jul 22, 2019 at 8:15 AM Alyssa Rosenzweig wrote: > > > #define PANFROST_BO_NOEXEC 1 > > +#define PANFROST_BO_HEAP 2 > > Bikeshedding, but I don't like this name. There are, I think, multiple > GPU-mapped buffers (at least in Panfrost -- I don't know how the blob > manages memory) th

Re: [PATCH v18 07/15] fs/namespace: untag user pointers in copy_mount_options

2019-07-22 Thread Kees Cook
+Eric Biederman too, who might be able to Ack this... On Mon, Jul 15, 2019 at 06:00:04PM +0200, Andrey Konovalov wrote: > On Mon, Jun 24, 2019 at 7:50 PM Catalin Marinas > wrote: > > > > On Mon, Jun 24, 2019 at 04:32:52PM +0200, Andrey Konovalov wrote: > > > This patch is a part of a series that

[Bug 111077] link_shader and deserialize_glsl_program suddenly consume huge amount of RAM

2019-07-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111077 --- Comment #12 from Matt Turner --- (In reply to rol...@rptd.ch from comment #11) > ../src/amd/common/ac_nir_to_llvm.c > ../src/amd/common/ac_nir_to_llvm.c: In function ‘ac_llvm_finalize_module’: > ../src/amd/common/ac_nir_to_llvm.c:6614:2: err

[PATCH] drm: use correct dev node location in comment

2019-07-22 Thread Emil Velikov
From: Emil Velikov Current comment mentions /dev/drm which hasn't been a thing even before the code was merged into the kernel ;-) Signed-off-by: Emil Velikov --- drivers/gpu/drm/drm_file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_file.c b/drivers

Re: [PATCH] drm/amdkfd/kfd_mqd_manager_v10: Fix missing break in switch statement

2019-07-22 Thread Gustavo A. R. Silva
On 7/22/19 10:58 AM, Deucher, Alexander wrote: > We need to add a /*fall through */ comment then. > It might be better to remove the call to pr_debug() in KFD_MQD_TYPE_CP: case KFD_MQD_TYPE_CP: case KFD_MQD_TYPE_COMPUTE: pr_debug("%s@%i\n", __func__, __LINE__);

[PATCH] i2c: replace i2c_new_secondary_device with an ERR_PTR variant

2019-07-22 Thread Wolfram Sang
In the general move to have i2c_new_*_device functions which return ERR_PTR instead of NULL, this patch converts i2c_new_secondary_device(). There are only few users, so this patch converts the I2C core and all users in one go. The function gets renamed to i2c_new_ancillary_device() so out-of-tree

[PATCH] gpu: drm: bridge: sii9234: convert to devm_i2c_new_dummy_device

2019-07-22 Thread Wolfram Sang
Move from i2c_new_dummy() to devm_i2c_new_dummy_device(). So, we now get an ERRPTR which we use in error handling and we can skip removal of the created devices. Signed-off-by: Wolfram Sang --- Only build tested. Part of a tree-wide move to deprecate i2c_new_dummy(). drivers/gpu/drm/bridge/sii

[PATCH 1/1] gpu: drm: bridge: analogix-anx78xx: convert to i2c_new_dummy_device

2019-07-22 Thread Wolfram Sang
Move from i2c_new_dummy() to i2c_new_dummy_device(), so we now get an ERRPTR which we use in error handling. Signed-off-by: Wolfram Sang --- Generated with coccinelle. Build tested by me and buildbot. Not tested on HW. drivers/gpu/drm/bridge/analogix-anx78xx.c | 6 +++--- 1 file changed, 3 ins

Re: [PATCH] drm: use correct dev node location in comment

2019-07-22 Thread Sean Paul
On Mon, Jul 22, 2019 at 05:56:48PM +0100, Emil Velikov wrote: > From: Emil Velikov > > Current comment mentions /dev/drm which hasn't been a thing even before > the code was merged into the kernel ;-) > > Signed-off-by: Emil Velikov > --- > drivers/gpu/drm/drm_file.c | 2 +- > 1 file changed,

Re: [PATCH v3 1/6] dt-bindings: soc: qcom: add On Chip MEMory (OCMEM) bindings

2019-07-22 Thread Rob Herring
On Tue, Jun 25, 2019 at 10:21:43PM -0400, Brian Masney wrote: > Add device tree bindings for the On Chip Memory (OCMEM) that is present > on some Qualcomm Snapdragon SoCs. > > Signed-off-by: Brian Masney > --- > Changes since v2: > - Add *-sram node and gmu-sram to example. > > Changes since v1:

Re: [PATCH v3 2/6] dt-bindings: display: msm: gmu: add optional ocmem property

2019-07-22 Thread Rob Herring
On Tue, Jun 25, 2019 at 10:21:44PM -0400, Brian Masney wrote: > Some A3xx and A4xx Adreno GPUs do not have GMEM inside the GPU core and > must use the On Chip MEMory (OCMEM) in order to be functional. Add the > optional ocmem property to the Adreno Graphics Management Unit bindings. > > Signed-off

Re: [v3 1/4] dt-bindngs: display: panel: Add BOE tv101wum-n16 panel bindings

2019-07-22 Thread Rob Herring
On Wed, 26 Jun 2019 10:53:57 +0800, Jitao Shi wrote: > Add documentation for boe tv101wum-n16 panel. > > Signed-off-by: Jitao Shi > --- > .../display/panel/boe,tv101wum-nl6.txt| 34 +++ > 1 file changed, 34 insertions(+) > create mode 100644 > Documentation/devicetree/b

Re: [v3 3/4] dt-bindings: display: panel: add auo kd101n80-45na panel bindings

2019-07-22 Thread Rob Herring
On Wed, 26 Jun 2019 10:53:59 +0800, Jitao Shi wrote: > Add documentation for auo kd101n80-45na panel. > > Signed-off-by: Jitao Shi > Reviewed-by: Sam Ravnborg > --- > .../display/panel/auo,kd101n80-45na.txt | 34 +++ > 1 file changed, 34 insertions(+) > create mode 100644

[PATCH 2/3] drm/vmwgfx: add local DRM_AUTH check for PRIME TO/FROM HANDLE

2019-07-22 Thread Emil Velikov
From: Emil Velikov Realistically no drivers, but vmwgfx care about the DRM_AUTH flag here. Follow-up work in this driver will properly isolate primary clients from different master realms, thus we'll no longer need to parse _any_ ioctl flags. Until that work lands, add a local workaround. Cc:

[PATCH 3/3] drm: drop DRM_AUTH from PRIME_TO/FROM_HANDLE ioctls

2019-07-22 Thread Emil Velikov
From: Emil Velikov As mentioned by Christian, for drivers which support only primary nodes this changes the returned error from -EACCES into -EOPNOTSUPP/-ENOSYS. For others, this check in particular will be a noop. So let's remove it as suggested by Christian. Cc: Alex Deucher Cc: Christian Kö

[PATCH 1/3] drm/vmwgfx: check master authentication in surface_ref ioctls

2019-07-22 Thread Emil Velikov
From: Emil Velikov With later commit we'll rework DRM core authentication handling. Namely unauthenticated master will be allowed with, DRM_AUTH ioctls. Since vmwgfx does additional master locking and DRM_AUTH handling, this will not matter almost all cases. The only exception being using the l

Re: [PATCH] drm/amdkfd/kfd_mqd_manager_v10: Fix missing break in switch statement

2019-07-22 Thread Liu, Shaoyun
That sounds good to me . Regards shaoyun.liu On 2019-07-22 12:13 p.m., Gustavo A. R. Silva wrote: > > On 7/22/19 10:58 AM, Deucher, Alexander wrote: >> We need to add a /*fall through */ comment then. >> > It might be better to remove the call to pr_debug() in KFD_MQD_TYPE_CP: > > case KFD

[PATCH] drm/amdkfd/kfd_mqd_manager_v10: Avoid fall-through warning

2019-07-22 Thread Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, this patch silences the following warning: drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_mqd_manager_v10.c: In function ‘mqd_manager_init_v10’: ./include/linux/dynamic_debug.h:122:52: warning: this statement may fall through [-Wimplicit-fallthrough=]

Re: [PATCH 05/10] dt-bindings: display: Add max-res property for mxsfb

2019-07-22 Thread Rob Herring
On Wed, Jun 26, 2019 at 04:32:13PM +0300, Robert Chiras wrote: > Add new optional property 'max-res', to limit the maximum supported > resolution by the MXSFB_DRM driver. Bindings are for h/w description, not driver config. > > Signed-off-by: Robert Chiras > --- > Documentation/devicetree/bind

Re: [PATCH 0/6] drm/tinydrm: Move mipi_dbi

2019-07-22 Thread Eric Anholt
Noralf Trønnes writes: > This series ticks off the last tinydrm todo entry and moves out mipi_dbi > to be a core helper. > > It splits struct mipi_dbi into an interface part and a display pipeline > part (upload framebuffer over SPI). I also took the opportunity to > rename the ambiguous 'mipi' v

Re: [PATCH v9 04/18] kunit: test: add kunit_stream a std::stream like logger

2019-07-22 Thread Brendan Higgins
On Thu, Jul 18, 2019 at 5:08 PM Brendan Higgins wrote: > > On Thu, Jul 18, 2019 at 12:22:33PM -0700, Brendan Higgins wrote: > > On Thu, Jul 18, 2019 at 10:50 AM Stephen Boyd wrote: > > > > > > Quoting Brendan Higgins (2019-07-16 11:52:01) > > > > On Tue, Jul 16, 2019 at 10:50 AM Stephen Boyd wro

[PATCH] drm/i915: Mark expected switch fall-throughs

2019-07-22 Thread Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. This patch fixes the following warnings: drivers/gpu/drm/i915/gem/i915_gem_mman.c: In function ‘i915_gem_fault’: drivers/gpu/drm/i915/gem/i915_gem_mman.c:342:6: warning: this statement may

Re: [PATCH] drm/amdkfd/kfd_mqd_manager_v10: Avoid fall-through warning

2019-07-22 Thread Liu, Shaoyun
Reviewed-by:  shaoyunl On 2019-07-22 1:47 p.m., Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, this patch silences > the following warning: > > drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_mqd_manager_v10.c: In function > ‘mqd_manager_init_v10’: > ./include/linux/dyn

[PATCH v2] drm/bridge: dw-hdmi: Refuse DDC/CI transfers on the internal I2C controller

2019-07-22 Thread Matthias Kaehlcke
The DDC/CI protocol involves sending a multi-byte request to the display via I2C, which is typically followed by a multi-byte response. The internal I2C controller only allows single byte reads/writes or reads of 8 sequential bytes, hence DDC/CI is not supported when the internal I2C controller is

Re: drm/msm/dpu: Correct dpu encoder spinlock initialization

2019-07-22 Thread Sean Paul
On Mon, Jun 24, 2019 at 11:57:12AM +0530, Shubhashree Dhar wrote: > dpu encoder spinlock should be initialized during dpu encoder > init instead of dpu encoder setup which is part of commit. > There are chances that vblank control uses the uninitialized > spinlock if not initialized during encoder

Re: [Freedreno] [PATCH] drm/msm: correct NULL pointer dereference in context_init

2019-07-22 Thread Sean Paul
On Fri, Jun 28, 2019 at 05:57:26AM -0700, Rob Clark wrote: > On Wed, Jun 26, 2019 at 7:05 PM Brian Masney wrote: > > > > Correct attempted NULL pointer dereference in context_init() when > > running without an IOMMU. > > > > Signed-off-by: Brian Masney > > Fixes: 295b22ae596c ("drm/msm: Pass the

Re: [PATCH] drm/i915: Mark expected switch fall-throughs

2019-07-22 Thread Kees Cook
On Mon, Jul 22, 2019 at 01:12:44PM -0500, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch > cases where we are expecting to fall through. > > This patch fixes the following warnings: > > drivers/gpu/drm/i915/gem/i915_gem_mman.c: In function ‘i915_gem_fa

[PATCH 3/4] drm: panel-lvds: Spout an error if of_get_display_timing() gives an error

2019-07-22 Thread Douglas Anderson
In the patch ("video: of: display_timing: Don't yell if no timing node is present") we'll stop spouting an error directly in of_get_display_timing() if no node is present. Presumably panel-lvds should take charge of spouting its own error now. NOTE: we'll print two errors if the node was present

[PATCH 0/4] video: of: display_timing: Adjust err printing of of_get_display_timing()

2019-07-22 Thread Douglas Anderson
As reported by Sam Ravnborg [1], after commit b8a2948fa2b3 ("drm/panel: simple: Add ability to override typical timing") we now see a pointless error message printed on every boot for many systems. Let's fix that by adjusting who is responsible for printing error messages when of_get_display_timing

[PATCH 4/4] video: amba-clcd: Spout an error if of_get_display_timing() gives an error

2019-07-22 Thread Douglas Anderson
In the patch ("video: of: display_timing: Don't yell if no timing node is present") we'll stop spouting an error directly in of_get_display_timing() if no node is present. Presumably amba-clcd should take charge of spouting its own error now. NOTE: we'll print two errors if the node was present b

[PATCH 1/4] video: of: display_timing: Add of_node_put() in of_get_display_timing()

2019-07-22 Thread Douglas Anderson
>From code inspection it can be seen that of_get_display_timing() is lacking an of_node_put(). Add it. Fixes: ffa3fd21de8a ("videomode: implement public of_get_display_timing()") Signed-off-by: Douglas Anderson --- drivers/video/of_display_timing.c | 7 ++- 1 file changed, 6 insertions(+),

[PATCH 2/4] video: of: display_timing: Don't yell if no timing node is present

2019-07-22 Thread Douglas Anderson
There may be cases (like in panel-simple.c) where we have a sane fallback if no timings are specified in the device tree. Let's get rid of the unconditional pr_err(). We can add error messages in individual drivers if it makes sense. NOTE: we'll still print errors if the node is present but ther

Re: [PATCH] drm/panel: simple: Doxygenize 'struct panel_desc'; rename a few functions

2019-07-22 Thread Doug Anderson
Hi, On Sun, Jul 21, 2019 at 2:38 AM Sam Ravnborg wrote: > > Hi Doug. > > On Wed, Jul 17, 2019 at 07:33:17PM +0200, Sam Ravnborg wrote: > > Hi Doug. > > > > On Fri, Jul 12, 2019 at 09:33:33AM -0700, Douglas Anderson wrote: > > > This attempts to address outstanding review feedback from commit > >

Re: [PATCH v2 1/4] drm/via: drop use of DRM(READ|WRITE) macros

2019-07-22 Thread Sam Ravnborg
Hi Email. > > > IMHO a far better idea is to expand these macros as static inline > > > functions. > > > The extra bonus here is that the pseudo-magical VIA_BASE will also > > > disappear. > > > > > > Since all the VIA_READ8 are used for masking, one might as well drop > > > them in favour of vi

Re: [PATCH] drm: fix out-of-bounds access with short VSDB blocks

2019-07-22 Thread Sean Paul
On Mon, Jul 22, 2019 at 02:38:34PM +, Simon Ser wrote: > From: Simon Ser > > The VSDB parsing code contains a few len >= N checks, accessing db[N] on > success. However if len == N, db[N] is out-of-bounds. > > This commit changes the checks to test for len > N. I'm not familiar with this at

Re: [PATCH v2 0/7] Add anx6345 DP/eDP bridge for Olimex Teres-I

2019-07-22 Thread Vasily Khoruzhick
On Mon, Jul 22, 2019 at 8:04 AM Torsten Duwe wrote: > > ANX6345 LVTTL->eDP video bridge, driver with device tree bindings. > > Changes from v2: > > * use SPDX-IDs throughout > > * removed the panel output again, as it was not what Maxime had in mind. > At least the Teres-I does very well without

Re: [PATCH v3 5/7] drm/bridge: Add Analogix anx6345 support

2019-07-22 Thread Vasily Khoruzhick
On Mon, Jul 22, 2019 at 8:11 AM Torsten Duwe wrote: > > From: Icenowy Zheng > > The ANX6345 is an ultra-low power DisplayPower/eDP transmitter designed > for portable devices. This driver adds initial support for RGB to eDP > mode, without HPD and interrupts. > > This is a configuration usually s

Re: [PATCH v3 6/7] dt-bindings: Add ANX6345 DP/eDP transmitter binding

2019-07-22 Thread Vasily Khoruzhick
On Mon, Jul 22, 2019 at 8:12 AM Torsten Duwe wrote: > > The anx6345 is an ultra-low power DisplayPort/eDP transmitter designed > for portable devices. > > Add a binding document for it. I believe you'll have to convert it to yaml format. > > Signed-off-by: Icenowy Zheng > Signed-off-by: Vasily

Re: [PATCH 1/3] drivers/gpu/drm/via: convert put_page() to put_user_page*()

2019-07-22 Thread John Hubbard
On 7/22/19 2:33 AM, Christoph Hellwig wrote: > On Sun, Jul 21, 2019 at 09:30:10PM -0700, john.hubb...@gmail.com wrote: >> for (i = 0; i < vsg->num_pages; ++i) { >> if (NULL != (page = vsg->pages[i])) { >> if (!PageReserved(page) && (DMA

Re: [PATCH 0/6] drm/tinydrm: Move mipi_dbi

2019-07-22 Thread Noralf Trønnes
Den 22.07.2019 20.06, skrev Eric Anholt: > Noralf Trønnes writes: > >> This series ticks off the last tinydrm todo entry and moves out mipi_dbi >> to be a core helper. >> >> It splits struct mipi_dbi into an interface part and a display pipeline >> part (upload framebuffer over SPI). I also too

Re: [PATCH 3/3] gup: new put_user_page_dirty*() helpers

2019-07-22 Thread John Hubbard
On 7/21/19 9:30 PM, john.hubb...@gmail.com wrote: > From: John Hubbard > > While converting call sites to use put_user_page*() [1], quite a few > places ended up needing a single-page routine to put and dirty a > page. > > Provide put_user_page_dirty() and put_user_page_dirty_lock(), > and use t

Re: [PATCH 1/3] drivers/gpu/drm/via: convert put_page() to put_user_page*()

2019-07-22 Thread Matthew Wilcox
On Mon, Jul 22, 2019 at 11:53:54AM -0700, John Hubbard wrote: > On 7/22/19 2:33 AM, Christoph Hellwig wrote: > > On Sun, Jul 21, 2019 at 09:30:10PM -0700, john.hubb...@gmail.com wrote: > >>for (i = 0; i < vsg->num_pages; ++i) { > >>if (NULL != (page = vsg->pages[i]))

Re: [PATCH] drm/amdkfd: Fix missing break in switch statement

2019-07-22 Thread Alex Deucher
On Sun, Jul 21, 2019 at 6:12 PM Gustavo A. R. Silva wrote: > > Add missing break statement in order to prevent the code from falling > through to case CHIP_NAVI10. > > This bug was found thanks to the ongoing efforts to enable > -Wimplicit-fallthrough. > > Fixes: 14328aa58ce5 ("drm/amdkfd: Add nav

Re: [PATCH 1/3] drivers/gpu/drm/via: convert put_page() to put_user_page*()

2019-07-22 Thread John Hubbard
On 7/22/19 12:07 PM, Matthew Wilcox wrote: > On Mon, Jul 22, 2019 at 11:53:54AM -0700, John Hubbard wrote: >> On 7/22/19 2:33 AM, Christoph Hellwig wrote: >>> On Sun, Jul 21, 2019 at 09:30:10PM -0700, john.hubb...@gmail.com wrote: for (i = 0; i < vsg->num_pages; ++i) {

Re: [v3 1/4] dt-bindngs: display: panel: Add BOE tv101wum-n16 panel bindings

2019-07-22 Thread Uwe Kleine-König
$Subject ~= s/bindngs/bindings/ Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de/ | ___ dri-devel mailing list dri-devel@lists.freedes

Re: [PATCH] drm/amdgpu/gfx10: Fix missing break in switch statement

2019-07-22 Thread Alex Deucher
On Sun, Jul 21, 2019 at 6:39 PM Gustavo A. R. Silva wrote: > > Add missing break statement in order to prevent the code from falling > through to case AMDGPU_IRQ_STATE_ENABLE. > > This bug was found thanks to the ongoing efforts to enable > -Wimplicit-fallthrough. > > Fixes: a644d85a5cd4 ("drm/amd

Re: [PATCH 3/3] drm: drop DRM_AUTH from PRIME_TO/FROM_HANDLE ioctls

2019-07-22 Thread Koenig, Christian
Am 22.07.19 um 19:40 schrieb Emil Velikov: > From: Emil Velikov > > As mentioned by Christian, for drivers which support only primary nodes > this changes the returned error from -EACCES into -EOPNOTSUPP/-ENOSYS. > > For others, this check in particular will be a noop. So let's remove it > as sugg

Re: [PATCH] drm/amdkfd/kfd_mqd_manager_v10: Avoid fall-through warning

2019-07-22 Thread Alex Deucher
Applied. Thanks! Alex On Mon, Jul 22, 2019 at 2:14 PM Liu, Shaoyun wrote: > > Reviewed-by: shaoyunl > > On 2019-07-22 1:47 p.m., Gustavo A. R. Silva wrote: > > In preparation to enabling -Wimplicit-fallthrough, this patch silences > > the following warning: > > > > drivers/gpu/drm/amd/amdgpu/

[PATCH] drm: silence variable 'conn' set but not used

2019-07-22 Thread Qian Cai
The "struct drm_connector" iteration cursor from "for_each_new_connector_in_state" is never used in atomic_remove_fb() which generates a compilation warning, drivers/gpu/drm/drm_framebuffer.c: In function 'atomic_remove_fb': drivers/gpu/drm/drm_framebuffer.c:838:24: warning: variable 'conn' set bu

Re: [PATCH] drm/amdgpu/gfx10: Fix missing break in switch statement

2019-07-22 Thread Gustavo A. R. Silva
On 7/22/19 2:12 PM, Alex Deucher wrote: > On Sun, Jul 21, 2019 at 6:39 PM Gustavo A. R. Silva > wrote: >> >> Add missing break statement in order to prevent the code from falling >> through to case AMDGPU_IRQ_STATE_ENABLE. >> >> This bug was found thanks to the ongoing efforts to enable >> -Wimp

Re: [PATCH] drm/msm: stop abusing dma_map/unmap for cache

2019-07-22 Thread Sean Paul
On Sun, Jun 30, 2019 at 05:47:22AM -0700, Rob Clark wrote: > From: Rob Clark > > Recently splats like this started showing up: > >WARNING: CPU: 4 PID: 251 at drivers/iommu/dma-iommu.c:451 > __iommu_dma_unmap+0xb8/0xc0 >Modules linked in: ath10k_snoc ath10k_core fuse msm ath mac80211 uvc

[PATCH] drm/bridge: Improve the help text for DRM_ANALOGIX_ANX78XX

2019-07-22 Thread Fabio Estevam
Improve the help text for DRM_ANALOGIX_ANX78XX by adding the missing "power" word. After this change the help text matches with the ANX7814 product description from the Analogix website: https://www.analogix.com/en/products/convertersbridges/anx7814 Signed-off-by: Fabio Estevam --- drivers/gpu

Re: Need 5.3-rc1 in drm-misc-next

2019-07-22 Thread Maxime Ripard
Hi! On Mon, Jul 22, 2019 at 01:20:35PM +0200, Noralf Trønnes wrote: > Hi drm-misc maintainers, > > I have this series: > > drm/tinydrm: Remove tinydrm.ko > https://patchwork.freedesktop.org/series/63811/ > > That depends on this -rc1 commit: > > e6f3f7e4dc76 ("spi: Add spi_is_bpw_supported()") > >

Re: [PATCH] drm/amdkfd: Fix missing break in switch statement

2019-07-22 Thread Alex Deucher
On Mon, Jul 22, 2019 at 3:19 PM Gustavo A. R. Silva wrote: > > > > On 7/22/19 2:10 PM, Alex Deucher wrote: > > On Sun, Jul 21, 2019 at 6:12 PM Gustavo A. R. Silva > > wrote: > >> > >> Add missing break statement in order to prevent the code from falling > >> through to case CHIP_NAVI10. > >> > >>

Re: [PATCH] drm/amdkfd: Fix missing break in switch statement

2019-07-22 Thread Gustavo A. R. Silva
On 7/22/19 2:45 PM, Alex Deucher wrote: >> >> By the way, Alex, I'm planning to add these fixes to my tree. I want >> to send a pull-request to Linus for v5.3-rc2 this afternoon. We want >> to have the -Wimplicit-fallthrough option globally enabled in v5.3, >> and these are some of the last fall

Re: [PATCH v2 10/11] drm/tinydrm/mipi-dbi: Add mipi_dbi_init_with_formats()

2019-07-22 Thread David Lechner
On 7/19/19 10:59 AM, Noralf Trønnes wrote: The MIPI DBI standard support more pixel formats than what this helper supports. Add an init function that lets the driver use different format(s). This avoids open coding mipi_dbi_init() in st7586. st7586 sets preferred_depth but this is not necessary

Re: Need 5.3-rc1 in drm-misc-next

2019-07-22 Thread Noralf Trønnes
Den 22.07.2019 21.44, skrev Maxime Ripard: > Hi! > > On Mon, Jul 22, 2019 at 01:20:35PM +0200, Noralf Trønnes wrote: >> Hi drm-misc maintainers, >> >> I have this series: >> >> drm/tinydrm: Remove tinydrm.ko >> https://patchwork.freedesktop.org/series/63811/ >> >> That depends on this -rc1 commi

Re: [PATCH v9 04/18] kunit: test: add kunit_stream a std::stream like logger

2019-07-22 Thread Stephen Boyd
Quoting Brendan Higgins (2019-07-18 17:08:34) > On Thu, Jul 18, 2019 at 12:22:33PM -0700, Brendan Higgins wrote: > > I started poking around with your suggestion while we are waiting. A > couple early observations: > > 1) It is actually easier to do than I previously thought and will probably >

Re: [PATCH] drm/amdkfd: Fix missing break in switch statement

2019-07-22 Thread Gustavo A. R. Silva
On 7/22/19 2:10 PM, Alex Deucher wrote: > On Sun, Jul 21, 2019 at 6:12 PM Gustavo A. R. Silva > wrote: >> >> Add missing break statement in order to prevent the code from falling >> through to case CHIP_NAVI10. >> >> This bug was found thanks to the ongoing efforts to enable >> -Wimplicit-fallth

Re: [PATCH] drm: silence variable 'conn' set but not used

2019-07-22 Thread Sean Paul
On Mon, Jul 22, 2019 at 03:14:46PM -0400, Qian Cai wrote: > The "struct drm_connector" iteration cursor from > "for_each_new_connector_in_state" is never used in atomic_remove_fb() > which generates a compilation warning, > > drivers/gpu/drm/drm_framebuffer.c: In function 'atomic_remove_fb': > dri

Re: [PATCH] drm/bridge: Improve the help text for DRM_ANALOGIX_ANX78XX

2019-07-22 Thread Sean Paul
On Mon, Jul 22, 2019 at 04:40:49PM -0300, Fabio Estevam wrote: > Improve the help text for DRM_ANALOGIX_ANX78XX by adding the missing > "power" word. > > After this change the help text matches with the ANX7814 > product description from the Analogix website: > > https://www.analogix.com/en/produ

Re: [PATCH v2] drm/bridge: dw-hdmi: Refuse DDC/CI transfers on the internal I2C controller

2019-07-22 Thread Doug Anderson
Hi, On Mon, Jul 22, 2019 at 11:19 AM Matthias Kaehlcke wrote: > > The DDC/CI protocol involves sending a multi-byte request to the > display via I2C, which is typically followed by a multi-byte > response. The internal I2C controller only allows single byte > reads/writes or reads of 8 sequential

[Bug 105251] [Vega10] GPU lockup on boot: VMC page fault

2019-07-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105251 --- Comment #74 from deltasquared --- (In reply to Juan A. Suarez from comment #73) > It could be good if people could report here if this improved with this MR. I can utilise the mesa-git package in the arch user repository to compile from lat

Re: [PATCH v2 2/9] drm/tinydrm: Rename variable mipi -> dbi

2019-07-22 Thread David Lechner
On 7/22/19 5:43 AM, Noralf Trønnes wrote: struct mipi_dbi is going to be split into an interface part and a display pipeline part. The interface part can be used by drivers that need to initialize the controller, but that won't upload the framebuffer over this interface. tinydrm uses the variabl

Re: [PATCH v2 3/9] drm/tinydrm: Rename remaining variable mipi -> dbidev

2019-07-22 Thread David Lechner
On 7/22/19 5:43 AM, Noralf Trønnes wrote: struct mipi_dbi is going to be split into an interface part and a display pipeline part. The interface part can be used by drivers that need to initialize the controller, but that won't upload the framebuffer over this interface. tinydrm uses the variabl

Re: [PATCH v2] drm/bridge: dw-hdmi: Refuse DDC/CI transfers on the internal I2C controller

2019-07-22 Thread Sean Paul
On Mon, Jul 22, 2019 at 11:19:45AM -0700, Matthias Kaehlcke wrote: > The DDC/CI protocol involves sending a multi-byte request to the > display via I2C, which is typically followed by a multi-byte > response. The internal I2C controller only allows single byte > reads/writes or reads of 8 sequentia

Re: [PATCH v2 4/9] drm/tinydrm: Split struct mipi_dbi in two

2019-07-22 Thread David Lechner
On 7/22/19 5:43 AM, Noralf Trønnes wrote: Split struct mipi_dbi into an interface part and a display pipeline part. The interface part can be used by drivers that need to initialize the controller, but that won't upload the framebuffer over this interface. MIPI DBI supports 3 interface types: -

Re: [PATCH] Enable backlight when trigger is activated

2019-07-22 Thread Jacek Anaszewski
Hi Pavel, On 7/22/19 9:50 AM, Pavel Machek wrote: > Hi! > >>> Configuring backlight trigger from dts results in backlight off during >>> boot. Machine looks dead upon boot, which is not good. >>> >>> Fix that by enabling LED on trigger activation. > >>> +++ b/drivers/leds/trigger/ledtrig-backlig

[Bug 110671] Regression: DP outputs out of sync on dual-DP tiled 5k screen

2019-07-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110671 --- Comment #9 from Denys --- Broken in 5.3-rc1 Workaround to revert 5fc0cbfad4564856ee0f323d3f88a7cff19cc3f1 is still working. -- You are receiving this mail because: You are the assignee for the bug._

Re: [PATCH v2 8/9] drm/tinydrm: Move mipi-dbi

2019-07-22 Thread David Lechner
On 7/22/19 5:43 AM, Noralf Trønnes wrote: This moves mipi-dbi to be a core helper with the name drm_mipi_dbi. Fixup include's in drivers. Move the docs entry and delete tinydrm.rst. Delete the last tinydrm todo entry. v2: Make DRM_MIPI_DBI tristate to enable it being built as a module. Cc: Eri

Re: [PATCH v2 9/9] MAINTAINERS: Remove tinydrm entry

2019-07-22 Thread David Lechner
On 7/22/19 5:43 AM, Noralf Trønnes wrote: tinydrm is just a collection of tiny drivers now. Add T: drm-misc entry for tinydrm drivers that lacks it. Cc: David Lechner Reviewed-by: Sam Ravnborg Signed-off-by: Noralf Trønnes --- Acked-by: David Lechner _

[PATCH] video: fbdev: pvr2fb: remove unnecessary comparison of unsigned integer with < 0

2019-07-22 Thread Gustavo A. R. Silva
There is no need to compare *var->xoffset* or *var->yoffset* with < 0 because such variables are of type unsigned, making it impossible to hold a negative value. Fix this by removing such comparisons. Addresses-Coverity-ID: 1451964 ("Unsigned compared against 0") Signed-off-by: Gustavo A. R. Silv

[PATCH v3 2/4] drm/via: copy DRM_WAIT_ON as VIA_WAIT_ON and use it

2019-07-22 Thread Sam Ravnborg
VIA_WAIT_ON() is a direct copy of DRM_WAIT_ON() from drm_os_linux.h. The copy is made so we can avoid the dependency on the legacy header. A more involved approach had been to introduce wait_event_* but for this legacy driver the simpler and more safe approach with a copy of the macro was selected.

[PATCH v3 1/4] drm/via: drop use of DRM(READ|WRITE) macros

2019-07-22 Thread Sam Ravnborg
The DRM_READ, DRM_WRITE macros comes from the deprecated drm_os_linux.h header file. Remove their use to remove this dependency. Replace the use of the macros with static inline variants. v3: - Use static inline functions, rather than macros (Emil) - Use dedicated mask variants for byte access (E

[PATCH v3 3/4] drm/via: make via_drv.h self-contained

2019-07-22 Thread Sam Ravnborg
Added include of header files to make via_drv.h self-contained. v3: - Reworded changelog a little - to reflect that more than one header files are added Signed-off-by: Sam Ravnborg Reviewed-by: Emil Velikov Cc: Kevin Brace Cc: Thomas Hellstrom Cc: "Gustavo A. R. Silva" Cc: Mike Marshall C

Re: [PATCH v2 5/9] drm/tinydrm/mipi-dbi: Remove CMA helper dependency

2019-07-22 Thread David Lechner
On 7/22/19 5:43 AM, Noralf Trønnes wrote: mipi-dbi depends on the CMA helper through it's use of drm_fb_cma_get_gem_obj(). This is an unnecessary dependency to drag in for drivers that only want to use the MIPI DBI interface part. Avoid this by open coding the function. Signed-off-by: Noralf Trø

[no subject]

2019-07-22 Thread Sam Ravnborg
The first three patches prepare for the removal of drmP.h. The last patch remove use of drmP.h and replace with necessary include files to fix build. Build tested with various configs and various architectures. I had preferred that the via driver was replaced by the openchrome driver, but until w

[PATCH v3 4/4] drm/via: drop use of drmP.h

2019-07-22 Thread Sam Ravnborg
Drop use of the deprecated drmP.h header. While touching the files divide include files in blocks and sort the files alphabetically. v2: - Replace all uses of DRM_WAIT_ON() with VIA_WAIT_ON() and thus avoiding to pull in drm_os_linux.h v3: - DRM_WAIT_ON replacement moved to earlier patch (Emil)

Re: [PATCH v2 6/9] drm/tinydrm/Kconfig: drivers: Select BACKLIGHT_CLASS_DEVICE

2019-07-22 Thread David Lechner
On 7/22/19 5:43 AM, Noralf Trønnes wrote: The mipi_dbi helper is missing a dependency on DRM_KMS_HELPER and putting that in revealed this problem: drivers/video/fbdev/Kconfig:12:error: recursive dependency detected! drivers/video/fbdev/Kconfig:12: symbol FB is selected by DRM_KMS_FB_HELPER drive

Re: [PATCH v2 7/9] drm/tinydrm/mipi-dbi: Select DRM_KMS_HELPER

2019-07-22 Thread David Lechner
On 7/22/19 5:43 AM, Noralf Trønnes wrote: mipi-dbi uses several KMS helper functions but that build dependency is not expressed. Select DRM_KMS_HELPER to fix that. Reported-by: kbuild test robot Signed-off-by: Noralf Trønnes --- Reviewed-by: David Lechner

[PATCH v3 0/4] drm/via: drop use of deprecated headers drmP.h and drm_os_linux.h

2019-07-22 Thread Sam Ravnborg
Added subject On Mon, Jul 22, 2019 at 10:35:41PM +0200, Sam Ravnborg wrote: > The first three patches prepare for the removal of drmP.h. > The last patch remove use of drmP.h and replace with necessary > include files to fix build. > > Build tested with various configs and various architectures.

Re: [PATCH v2] drm/bridge: dw-hdmi: Refuse DDC/CI transfers on the internal I2C controller

2019-07-22 Thread Matthias Kaehlcke
On Mon, Jul 22, 2019 at 01:12:40PM -0700, Doug Anderson wrote: > Hi, > > On Mon, Jul 22, 2019 at 11:19 AM Matthias Kaehlcke wrote: > > > > The DDC/CI protocol involves sending a multi-byte request to the > > display via I2C, which is typically followed by a multi-byte > > response. The internal I

[Bug 105251] [Vega10] GPU lockup on boot: VMC page fault

2019-07-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105251 --- Comment #75 from deltasquared --- After compiling mesa-git on commit 0661c357c60 from the AUR pkgbuild, I can now confirm my system seems to have become impervious to the above "vega_crasher" program. Output from said program after resizing

Re: [PATCH v2] drm/bridge: dw-hdmi: Refuse DDC/CI transfers on the internal I2C controller

2019-07-22 Thread Doug Anderson
Hi, On Mon, Jul 22, 2019 at 1:24 PM Sean Paul wrote: > > On Mon, Jul 22, 2019 at 11:19:45AM -0700, Matthias Kaehlcke wrote: > > The DDC/CI protocol involves sending a multi-byte request to the > > display via I2C, which is typically followed by a multi-byte > > response. The internal I2C controll

[Bug 105251] [Vega10] GPU lockup on boot: VMC page fault

2019-07-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105251 --- Comment #76 from deltasquared --- (In reply to deltasquared from comment #75) > L CALLBACK: type = 0x8251, severity = 0x826b, message = LLVM diagnostic GL_CALLBACK rather on that first line. terminal copypaste fail. -- You are receiving

Re: [PATCH v2] drm/bridge: dw-hdmi: Refuse DDC/CI transfers on the internal I2C controller

2019-07-22 Thread Matthias Kaehlcke
On Mon, Jul 22, 2019 at 04:24:26PM -0400, Sean Paul wrote: > On Mon, Jul 22, 2019 at 11:19:45AM -0700, Matthias Kaehlcke wrote: > > The DDC/CI protocol involves sending a multi-byte request to the > > display via I2C, which is typically followed by a multi-byte > > response. The internal I2C contro

[Bug 105251] [Vega10] GPU lockup on boot: VMC page fault

2019-07-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105251 --- Comment #77 from deltasquared --- Created attachment 144845 --> https://bugs.freedesktop.org/attachment.cgi?id=144845&action=edit vega_crasher after patch, black central output, on ryzen 2200G with vega 8 graphics Screenshot time (1/2). I

Re: [PATCH] Enable backlight when trigger is activated

2019-07-22 Thread Pavel Machek
Hi! > >> This looks fishy. > >> > >> Maybe you should use a default-state = "keep" instead? (and you'll have > >> to support it in the LED driver). > >> > >> That'll give you proper "don't touch the LED if it was turned on" behavior, > >> which is what you seem to want. > > > > Actually no, that'

[Bug 105251] [Vega10] GPU lockup on boot: VMC page fault

2019-07-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105251 --- Comment #78 from deltasquared --- Created attachment 144846 --> https://bugs.freedesktop.org/attachment.cgi?id=144846&action=edit vega_crasher after patch, colour shaded central output, on ryzen 2200G with vega 8 graphics Screenshot 2/2 o

[PATCH] drm/i915: Fix up broken merge

2019-07-22 Thread Daniel Vetter
Maxime didn't really compile-test this :-/ We need to re-apply commit e4fa8457b2197118538a1400b75c898f9faaf164 Author: Daniel Vetter Date: Fri Jun 14 22:35:25 2019 +0200 drm/prime: Align gem_prime_export with obj_funcs.export plus make sure i915_gem_dma_buf.c doesn't get zombie-resurrect

Re: [PATCH v4 0/4] Add a generic driver for LED-based backlight

2019-07-22 Thread Jacek Anaszewski
On 7/22/19 9:06 AM, Lee Jones wrote: > On Thu, 18 Jul 2019, Jacek Anaszewski wrote: > >> On 7/17/19 4:15 PM, Jean-Jacques Hiblot wrote: >>> This series aims to add a led-backlight driver, similar to pwm-backlight, >>> but using a LED class device underneath. >>> >>> A few years ago (2015), Tomi Va

Re: [Intel-gfx] [PATCH] drm/i915: Fix up broken merge

2019-07-22 Thread Chris Wilson
Quoting Daniel Vetter (2019-07-22 22:21:01) > Maxime didn't really compile-test this :-/ > > We need to re-apply > > commit e4fa8457b2197118538a1400b75c898f9faaf164 > Author: Daniel Vetter > Date: Fri Jun 14 22:35:25 2019 +0200 > > drm/prime: Align gem_prime_export with obj_funcs.export >

[PATCH] drm/i915: Fix up broken merge

2019-07-22 Thread Daniel Vetter
Maxime didn't really compile-test this :-/ We need to re-apply commit e4fa8457b2197118538a1400b75c898f9faaf164 Author: Daniel Vetter Date: Fri Jun 14 22:35:25 2019 +0200 drm/prime: Align gem_prime_export with obj_funcs.export plus make sure i915_gem_dma_buf.c doesn't get zombie-resurrect

Re: [PATCH] drm/i915: Fix up broken merge

2019-07-22 Thread Chris Wilson
Quoting Daniel Vetter (2019-07-22 22:37:59) > Maxime didn't really compile-test this :-/ > > We need to re-apply > > commit e4fa8457b2197118538a1400b75c898f9faaf164 > Author: Daniel Vetter > Date: Fri Jun 14 22:35:25 2019 +0200 > > drm/prime: Align gem_prime_export with obj_funcs.export >

Re: [PATCH] drm/i915: Fix up broken merge

2019-07-22 Thread Daniel Vetter
On Mon, Jul 22, 2019 at 11:41 PM Chris Wilson wrote: > > Quoting Daniel Vetter (2019-07-22 22:37:59) > > Maxime didn't really compile-test this :-/ > > > > We need to re-apply > > > > commit e4fa8457b2197118538a1400b75c898f9faaf164 > > Author: Daniel Vetter > > Date: Fri Jun 14 22:35:25 2019 +0

<    1   2   3   >