Re: [PATCH v4 0/4] Add a generic driver for LED-based backlight

2019-07-22 Thread Lee Jones
On Thu, 18 Jul 2019, Jacek Anaszewski wrote: > On 7/17/19 4:15 PM, Jean-Jacques Hiblot wrote: > > This series aims to add a led-backlight driver, similar to pwm-backlight, > > but using a LED class device underneath. > > > > A few years ago (2015), Tomi Valkeinen posted a series implementing a >

[PATCH] drm: panel-orientation-quirks: Add D330 HD version

2019-07-22 Thread David Santamaría Rogado
This adds the HD version of Lenovo Ideapad D330. Also edit the FHD version comment to distinguish. This should work despite the dmi data is the same because the resolution checks. Signed-off-by: David Santamaría Rogado --- drivers/gpu/drm/drm_panel_orientation_quirks.c | 9 - 1 file chan

[RFC] Staging: fbtft: Typo in

2019-07-22 Thread Christophe JAILLET
Hi, looking at the code in 'drivers/staging/fbtft/fb_pcd8544.c', there seems to be some typos. At the end of the file, we can find: FBTFT_REGISTER_DRIVER(DRVNAME, "philips,pdc8544", &display); ... MODULE_ALIAS("spi:pdc8544"); It is likely that the 2 pdc8544 should be pcd8544. (d and c switc

[Bug 105251] [Vega10] GPU lockup on boot: VMC page fault

2019-07-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105251 --- Comment #72 from Pierre-Eric Pelloux-Prayer --- This MR https://gitlab.freedesktop.org/mesa/mesa/merge_requests/1265 should improve the situation. It has been merged last week. An incorrect program (like "vega_crasher") should hit an asser

[Bug 111122] 2500U: Graphics corruption on kernel 5.2

2019-07-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=22 r...@sdf-eu.org changed: What|Removed |Added CC||r...@sdf-eu.org --- Comment #5 from r.

Re: [PATCH] Enable backlight when trigger is activated

2019-07-22 Thread Pavel Machek
Hi! > > Configuring backlight trigger from dts results in backlight off during > > boot. Machine looks dead upon boot, which is not good. > > > > Fix that by enabling LED on trigger activation. > > +++ b/drivers/leds/trigger/ledtrig-backlight.c > > @@ -114,6 +114,8 @@ static int bl_trig_activate

Re: [PATCH] video: fbdev: nvidia: Remove extra return

2019-07-22 Thread Souptick Joarder
On Wed, Jul 10, 2019 at 11:28 PM Souptick Joarder wrote: > > Minor cleanup to remove extra return statement. > Any comment on this patch ? > Signed-off-by: Souptick Joarder > --- > drivers/video/fbdev/nvidia/nv_backlight.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/video

Re: [PATCH] video: fbdev: nvidia: Remove dead code

2019-07-22 Thread Souptick Joarder
On Wed, Jul 10, 2019 at 11:41 PM Souptick Joarder wrote: > > This is dead code since 3.15. If there is no plan to use it > further, this can be removed forever. Any comment on this patch ? > > Signed-off-by: Souptick Joarder > --- > drivers/video/fbdev/nvidia/nv_setup.c | 24 --

[Bug 105251] [Vega10] GPU lockup on boot: VMC page fault

2019-07-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105251 --- Comment #73 from Juan A. Suarez --- (In reply to Pierre-Eric Pelloux-Prayer from comment #72) > This MR https://gitlab.freedesktop.org/mesa/mesa/merge_requests/1265 should > improve the situation. It has been merged last week. > > An incorr

Re: [PATCH] drm/syncobj: return meaningful value to user space

2019-07-22 Thread Lionel Landwerlin
On 18/07/2019 14:13, Chunming Zhou wrote: if WAIT_FOR_SUBMIT isn't set and in the meanwhile no underlying fence on syncobj, then return non-block error code to user sapce. Signed-off-by: Chunming Zhou --- drivers/gpu/drm/drm_syncobj.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-

[PATCH v2] drm/tegra: sor: Enable HDA interrupts at plugin

2019-07-22 Thread Viswanath L
HDMI plugout calls runtime suspend, which clears interrupt registers and causes audio functionality to break on subsequent plugin; setting interrupt registers in sor_audio_prepare() solves the issue Signed-off-by: Viswanath L --- drivers/gpu/drm/tegra/sor.c | 18 +- 1 file change

Re: [EXT] Re: [v2 1/3] drm/arm/mali-dp: Add display QoS interface configuration for Mali DP500

2019-07-22 Thread Liviu Dudau
On Mon, Jul 22, 2019 at 02:12:08AM +, Wen He wrote: > > > > -Original Message- > > From: Liviu Dudau > > Sent: 2019年7月19日 19:46 > > To: Wen He > > Cc: dri-devel@lists.freedesktop.org; linux-ker...@vger.kernel.org; > > brian.star...@arm.com; airl...@linux.ie; dan...@ffwll.ch; Leo Li

Re: [PATCH 1/3] drivers/gpu/drm/via: convert put_page() to put_user_page*()

2019-07-22 Thread Christoph Hellwig
On Sun, Jul 21, 2019 at 09:30:10PM -0700, john.hubb...@gmail.com wrote: > for (i = 0; i < vsg->num_pages; ++i) { > if (NULL != (page = vsg->pages[i])) { > if (!PageReserved(page) && (DMA_FROM_DEVICE == > vsg->direction)) > -

Re: [PATCH 2/3] net/xdp: convert put_page() to put_user_page*()

2019-07-22 Thread Christoph Hellwig
> diff --git a/net/xdp/xdp_umem.c b/net/xdp/xdp_umem.c > index 83de74ca729a..9cbbb96c2a32 100644 > --- a/net/xdp/xdp_umem.c > +++ b/net/xdp/xdp_umem.c > @@ -171,8 +171,7 @@ static void xdp_umem_unpin_pages(struct xdp_umem *umem) > for (i = 0; i < umem->npgs; i++) { > struct page

[Bug 111182] Fade-to-white after KMS is set on RV635

2019-07-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=82 Bug ID: 82 Summary: Fade-to-white after KMS is set on RV635 Product: DRI Version: unspecified Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Se

[Bug 110258] Lenovo V110-15AST AMD A9-9410 AMD R5 Stoney hangs after waking after suspend. 5.0-5.1rc2

2019-07-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110258 Paul Gover changed: What|Removed |Added Hardware|Other |x86-64 (AMD64) --- Comment #9 from Paul Go

Re: [PATCH 3/5] drm/panfrost: Add a no execute flag for BO allocations

2019-07-22 Thread Robin Murphy
On 19/07/2019 23:07, Rob Herring wrote: On Fri, Jul 19, 2019 at 4:39 AM Steven Price wrote: On 18/07/2019 18:03, Rob Herring wrote: On Thu, Jul 18, 2019 at 9:03 AM Steven Price wrote: On 17/07/2019 19:33, Rob Herring wrote: Executable buffers have an alignment restriction that they can't

[Bug 110258] Lenovo V110-15AST AMD A9-9410 AMD R5 Stoney hangs after waking after suspend. 5.0 onwards

2019-07-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110258 Paul Gover changed: What|Removed |Added Summary|Lenovo V110-15AST AMD |Lenovo V110-15AST AMD |A

Re: [PATCH] drm/syncobj: return meaningful value to user space

2019-07-22 Thread zhoucm1
On 2019年07月22日 16:46, Lionel Landwerlin wrote: On 18/07/2019 14:13, Chunming Zhou wrote: if WAIT_FOR_SUBMIT isn't set and in the meanwhile no underlying fence on syncobj, then return non-block error code to user sapce. Signed-off-by: Chunming Zhou ---   drivers/gpu/drm/drm_syncobj.c | 4 ++-

Re: [PATCH v6 11/22] clk: sunxi-ng: a64: Add minimum rate for PLL_MIPI

2019-07-22 Thread Jagan Teki
Hi Maxime, On Sat, Jul 20, 2019 at 3:02 PM Maxime Ripard wrote: > > On Sat, Jul 20, 2019 at 12:46:27PM +0530, Jagan Teki wrote: > > On Sat, Jul 20, 2019 at 12:28 PM Maxime Ripard > > wrote: > > > > > > On Thu, Jul 11, 2019 at 07:43:16PM +0200, Michael Nazzareno Trimarchi > > > wrote: > > > > >

Re: [PATCH v6 11/22] clk: sunxi-ng: a64: Add minimum rate for PLL_MIPI

2019-07-22 Thread Michael Nazzareno Trimarchi
Hi Jagan On Mon, Jul 22, 2019 at 12:21 PM Jagan Teki wrote: > > Hi Maxime, > > On Sat, Jul 20, 2019 at 3:02 PM Maxime Ripard > wrote: > > > > On Sat, Jul 20, 2019 at 12:46:27PM +0530, Jagan Teki wrote: > > > On Sat, Jul 20, 2019 at 12:28 PM Maxime Ripard > > > wrote: > > > > > > > > On Thu, Ju

[Bug 111182] Fade-to-white after KMS is set on RV635

2019-07-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=82 --- Comment #1 from Chris Cunningham --- Created attachment 144838 --> https://bugs.freedesktop.org/attachment.cgi?id=144838&action=edit Fedora 30 livecd dmesg showing the same thing Just checked a Fedora LiveCD, which did the same thing (whi

Re: [PATCH v6 11/22] clk: sunxi-ng: a64: Add minimum rate for PLL_MIPI

2019-07-22 Thread Jagan Teki
On Mon, Jul 22, 2019 at 3:55 PM Michael Nazzareno Trimarchi wrote: > > Hi Jagan > > On Mon, Jul 22, 2019 at 12:21 PM Jagan Teki > wrote: > > > > Hi Maxime, > > > > On Sat, Jul 20, 2019 at 3:02 PM Maxime Ripard > > wrote: > > > > > > On Sat, Jul 20, 2019 at 12:46:27PM +0530, Jagan Teki wrote: >

[PATCH v2 3/9] drm/tinydrm: Rename remaining variable mipi -> dbidev

2019-07-22 Thread Noralf Trønnes
struct mipi_dbi is going to be split into an interface part and a display pipeline part. The interface part can be used by drivers that need to initialize the controller, but that won't upload the framebuffer over this interface. tinydrm uses the variable name 'mipi' but this is not a good name si

[PATCH v2 2/9] drm/tinydrm: Rename variable mipi -> dbi

2019-07-22 Thread Noralf Trønnes
struct mipi_dbi is going to be split into an interface part and a display pipeline part. The interface part can be used by drivers that need to initialize the controller, but that won't upload the framebuffer over this interface. tinydrm uses the variable name 'mipi' but this is not a good name si

[PATCH v2 5/9] drm/tinydrm/mipi-dbi: Remove CMA helper dependency

2019-07-22 Thread Noralf Trønnes
mipi-dbi depends on the CMA helper through it's use of drm_fb_cma_get_gem_obj(). This is an unnecessary dependency to drag in for drivers that only want to use the MIPI DBI interface part. Avoid this by open coding the function. Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/tinydrm/mipi-dbi.

[PATCH v2 9/9] MAINTAINERS: Remove tinydrm entry

2019-07-22 Thread Noralf Trønnes
tinydrm is just a collection of tiny drivers now. Add T: drm-misc entry for tinydrm drivers that lacks it. Cc: David Lechner Reviewed-by: Sam Ravnborg Signed-off-by: Noralf Trønnes --- MAINTAINERS | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/MAINTAINERS b/M

[PATCH v2 7/9] drm/tinydrm/mipi-dbi: Select DRM_KMS_HELPER

2019-07-22 Thread Noralf Trønnes
mipi-dbi uses several KMS helper functions but that build dependency is not expressed. Select DRM_KMS_HELPER to fix that. Reported-by: kbuild test robot Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/tinydrm/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/tinydrm/

[PATCH v2 6/9] drm/tinydrm/Kconfig: drivers: Select BACKLIGHT_CLASS_DEVICE

2019-07-22 Thread Noralf Trønnes
The mipi_dbi helper is missing a dependency on DRM_KMS_HELPER and putting that in revealed this problem: drivers/video/fbdev/Kconfig:12:error: recursive dependency detected! drivers/video/fbdev/Kconfig:12: symbol FB is selected by DRM_KMS_FB_HELPER drivers/gpu/drm/Kconfig:75: symbol DRM_KMS_FB

[PATCH v2 1/9] drm/tinydrm/mipi-dbi: Move cmdlock mutex init

2019-07-22 Thread Noralf Trønnes
cmdlock protects command execution so put it in mipi_dbi_spi_init() where it conceptually belongs. This is prep work for the splitting of struct mipi_dbi. Reviewed-by: Sam Ravnborg Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/tinydrm/mipi-dbi.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH v2 0/9] drm/tinydrm: Move mipi_dbi

2019-07-22 Thread Noralf Trønnes
This series ticks off the last tinydrm todo entry and moves out mipi_dbi to be a core helper. It splits struct mipi_dbi into an interface part and a display pipeline part (upload framebuffer over SPI). I also took the opportunity to rename the ambiguous 'mipi' variable name to 'dbi'. This lines up

[PATCH v2 8/9] drm/tinydrm: Move mipi-dbi

2019-07-22 Thread Noralf Trønnes
This moves mipi-dbi to be a core helper with the name drm_mipi_dbi. Fixup include's in drivers. Move the docs entry and delete tinydrm.rst. Delete the last tinydrm todo entry. v2: Make DRM_MIPI_DBI tristate to enable it being built as a module. Cc: Eric Anholt Cc: David Lechner Reviewed-by: Sa

[PATCH v2 4/9] drm/tinydrm: Split struct mipi_dbi in two

2019-07-22 Thread Noralf Trønnes
Split struct mipi_dbi into an interface part and a display pipeline part. The interface part can be used by drivers that need to initialize the controller, but that won't upload the framebuffer over this interface. MIPI DBI supports 3 interface types: - A. Motorola 6800 type parallel bus - B. Inte

Re: [PATCH] drm/komeda: Adds error event print functionality

2019-07-22 Thread james qian wang (Arm Technology China)
On Fri, Jul 19, 2019 at 11:40:11AM +, Liviu Dudau wrote: > On Fri, Jul 19, 2019 at 09:09:30AM +, Lowry Li (Arm Technology China) > wrote: > > Hi Liviu, > > > > On Thu, Jul 18, 2019 at 01:17:37PM +, Liviu Dudau wrote: > > > On Thu, Jun 27, 2019 at 04:10:36AM +0100, Lowry Li (Arm Techno

Need 5.3-rc1 in drm-misc-next

2019-07-22 Thread Noralf Trønnes
Hi drm-misc maintainers, I have this series: drm/tinydrm: Remove tinydrm.ko https://patchwork.freedesktop.org/series/63811/ That depends on this -rc1 commit: e6f3f7e4dc76 ("spi: Add spi_is_bpw_supported()") I would would be nice if it would show up in drm-misc-next soon. Noralf. _

RE: [PATCH v3 10/10] [HACK] arm64: dts: renesas: ebisu: Enable LVDS dual-link operation

2019-07-22 Thread Fabrizio Castro
Hello Jacopo, > From: linux-renesas-soc-ow...@vger.kernel.org > On Behalf Of Laurent Pinchart > Sent: 28 May 2019 15:13 > Subject: [PATCH v3 10/10] [HACK] arm64: dts: renesas: ebisu: Enable LVDS > dual-link operation > > Enable and connect the second LVDS encoder to the second LVDS input of >

Re: [PATCH 03/14] docs: fix broken doc references due to renames

2019-07-22 Thread Wolfram Sang
On Tue, Jul 16, 2019 at 09:10:42AM -0300, Mauro Carvalho Chehab wrote: > Some files got renamed but probably due to some merge conflicts, > a few references still point to the old locations. > > Signed-off-by: Mauro Carvalho Chehab Acked-by: Wolfram Sang # I2C part signature.asc Description:

Re: [PATCH 3/5] drm/panfrost: Add a no execute flag for BO allocations

2019-07-22 Thread Robin Murphy
On 22/07/2019 11:07, Steven Price wrote: On 22/07/2019 10:50, Robin Murphy wrote: On 19/07/2019 23:07, Rob Herring wrote: On Fri, Jul 19, 2019 at 4:39 AM Steven Price wrote: On 18/07/2019 18:03, Rob Herring wrote: On Thu, Jul 18, 2019 at 9:03 AM Steven Price wrote: On 17/07/2019 19:33, R

[Bug 111122] 2500U: Graphics corruption on kernel 5.2

2019-07-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=22 --- Comment #6 from Nicholas Kazlauskas --- (In reply to Brian Schott from comment #3) > I think that I'm seeing something related with my 2700u Inspiron 7375. > > If I have compositing enabled in XFWM4, the system will immediately stop > respo

[PATCH] drm/syncobj: fix leaking dma_fence in drm_syncobj_query_ioctl

2019-07-22 Thread Christian König
We need to check the context number instead if the previous sequence to detect an error and if an error is detected we need to drop the reference to the current fence or otherwise would leak it. Signed-off-by: Christian König --- drivers/gpu/drm/drm_syncobj.c | 10 +- 1 file changed, 5 i

Re: [PATCH] drm/syncobj: fix leaking dma_fence in drm_syncobj_query_ioctl

2019-07-22 Thread Lionel Landwerlin
On 22/07/2019 15:59, Christian König wrote: We need to check the context number instead if the previous sequence to detect an error and if an error is detected we need to drop the reference to the current fence or otherwise would leak it. Signed-off-by: Christian König Fixes: 27b575a9aa2f ("d

Re: [PATCH] drm/syncobj: fix leaking dma_fence in drm_syncobj_query_ioctl

2019-07-22 Thread Christian König
Am 22.07.19 um 15:16 schrieb Lionel Landwerlin: On 22/07/2019 15:59, Christian König wrote: We need to check the context number instead if the previous sequence to detect an error and if an error is detected we need to drop the reference to the current fence or otherwise would leak it. Signed

Re: [PATCH 3/5] drm/panfrost: Add a no execute flag for BO allocations

2019-07-22 Thread Robin Murphy
On 22/07/2019 13:19, Steven Price wrote: [...] Indeed, that case was just occurring to me too! How about: u64 next_seg = ALIGN(*start, PFN_4G); if (next_seg - *start <= PFN_16M) *start = next_seg + 1; *end = min(*end, ALIGN(*start, PFN_4G) - 1); So alwa

Re: [PATCH] drm/syncobj: fix leaking dma_fence in drm_syncobj_query_ioctl

2019-07-22 Thread Lionel Landwerlin
On 22/07/2019 16:21, Christian König wrote: Am 22.07.19 um 15:16 schrieb Lionel Landwerlin: On 22/07/2019 15:59, Christian König wrote: We need to check the context number instead if the previous sequence to detect an error and if an error is detected we need to drop the reference to the curr

Re: [PATCH] fbdev: Ditch fb_edid_add_monspecs

2019-07-22 Thread Bartlomiej Zolnierkiewicz
On 7/21/19 10:38 PM, Linus Torvalds wrote: > On Sun, Jul 21, 2019 at 1:20 PM Daniel Vetter wrote: >> >> It's dead code ever since > > Lovely. Ack. Good catch indeed. Thanks Daniel, I'll queue it for v5.4 later. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung E

[PATCH 1/2] drm/radeon: Add HD-audio component notifier support

2019-07-22 Thread Takashi Iwai
This patch adds the support for the notification of HD-audio hotplug via the already existing drm_audio_component framework to radeon driver. This allows us more reliable hotplug notification and ELD transfer without accessing HD-audio bus; it's more efficient, and more importantly, it works witho

[PATCH] drm: fix out-of-bounds access with short VSDB blocks

2019-07-22 Thread Simon Ser
From: Simon Ser The VSDB parsing code contains a few len >= N checks, accessing db[N] on success. However if len == N, db[N] is out-of-bounds. This commit changes the checks to test for len > N. Signed-off-by: Simon Ser --- drivers/gpu/drm/drm_edid.c | 24 1 file chan

[PATCH 2/2] drm/nouveau: Add HD-audio component notifier support

2019-07-22 Thread Takashi Iwai
This patch adds the support for the notification of HD-audio hotplug via the already existing drm_audio_component framework. This allows us more reliable hotplug notification and ELD transfer without accessing HD-audio bus; it's more efficient, and more importantly, it works without waking up the

[PATCH 0/2] Audio component support for radeon and nouveau

2019-07-22 Thread Takashi Iwai
Hi, this is a patchset to add the support for HDMI/DP audio notification via drm_audio_component framework on radeon and nouveau drivers. The notification mechanism works for long time on i915, and now AMDGPU patch is floating around. This fills the rest gap, the support for remaining radeon and

Re: [PATCH] drm: fix out-of-bounds access with short VSDB blocks

2019-07-22 Thread Ser, Simon
On Mon, 2019-07-22 at 14:38 +, Simon Ser wrote: > From: Simon Ser > > The VSDB parsing code contains a few len >= N checks, accessing db[N] on > success. However if len == N, db[N] is out-of-bounds. > > This commit changes the checks to test for len > N. > > Signed-off-by: Simon Ser Bleh,

Re: [PATCH 1/2] drm/radeon: Add HD-audio component notifier support

2019-07-22 Thread Koenig, Christian
Am 22.07.19 um 16:38 schrieb Takashi Iwai: > This patch adds the support for the notification of HD-audio hotplug > via the already existing drm_audio_component framework to radeon > driver. This allows us more reliable hotplug notification and ELD > transfer without accessing HD-audio bus; it's m

Re: [PATCH 1/2] drm/radeon: Add HD-audio component notifier support

2019-07-22 Thread Takashi Iwai
On Mon, 22 Jul 2019 16:44:06 +0200, Koenig, Christian wrote: > > Am 22.07.19 um 16:38 schrieb Takashi Iwai: > > This patch adds the support for the notification of HD-audio hotplug > > via the already existing drm_audio_component framework to radeon > > driver. This allows us more reliable hotplu

Re: [PATCH 2/2] drm/nouveau: Add HD-audio component notifier support

2019-07-22 Thread Ilia Mirkin
On Mon, Jul 22, 2019 at 10:38 AM Takashi Iwai wrote: > +static void > +nv50_audio_component_init(struct nouveau_drm *drm) > +{ > + if (!component_add(drm->dev->dev, &nv50_audio_component_bind_ops)) > + drm->audio.component_registered = true; > +} Pardon my ignorance on this to

[PATCH v2 1/7] sh: ecovec24: add additional properties to the backlight device

2019-07-22 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Add a GPIO lookup entry and a device property for GPIO backlight to the board file. Tie them to the platform device which is now registered using platform_device_register_full() because of the properties. These changes are inactive now but will be used once the gpio back

[PATCH v2 4/7] backlight: gpio: remove unused fields from platform data

2019-07-22 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Remove the platform data fields that nobody uses. Signed-off-by: Bartosz Golaszewski --- include/linux/platform_data/gpio_backlight.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/include/linux/platform_data/gpio_backlight.h b/include/linux/platform_data/gpio

[PATCH v2 5/7] backlight: gpio: remove dev from struct gpio_backlight

2019-07-22 Thread Bartosz Golaszewski
From: Bartosz Golaszewski This field is unused. Remove it. Signed-off-by: Bartosz Golaszewski --- drivers/video/backlight/gpio_backlight.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/video/backlight/gpio_backlight.c b/drivers/video/backlight/gpio_backlight.c index 01262186f

[PATCH v2 6/7] backlight: gpio: remove def_value from struct gpio_backlight

2019-07-22 Thread Bartosz Golaszewski
From: Bartosz Golaszewski This field is unused outside of probe(). There's no need to store it. We can make it into a local variable. Signed-off-by: Bartosz Golaszewski --- drivers/video/backlight/gpio_backlight.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/dri

[PATCH v2 3/7] sh: ecovec24: don't set unused fields in platform data

2019-07-22 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Platform data fields other than fbdev are no longer used by the backlight driver. Remove them. Signed-off-by: Bartosz Golaszewski --- arch/sh/boards/mach-ecovec24/setup.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/arch/sh/boards/mach-ecovec24/setup.c b/arc

[PATCH v2 2/7] backlight: gpio: simplify the platform data handling

2019-07-22 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Now that the last user of platform data (sh ecovec24) defines a proper GPIO lookup and sets the 'default-on' device property, we can drop the platform_data-specific GPIO handling and unify a big chunk of code. The only field used from the platform data is now the fbdev

[PATCH v2 0/7] backlight: gpio: simplify the driver

2019-07-22 Thread Bartosz Golaszewski
From: Bartosz Golaszewski While working on my other series related to gpio-backlight[1] I noticed that we could simplify the driver if we made the only user of platform data use GPIO lookups and device properties. This series tries to do that. The first patch adds all necessary data structures t

dri-devel@lists.freedesktop.org

2019-07-22 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Instead of dereferencing pdev each time, use a helper variable for the associated device pointer. Signed-off-by: Bartosz Golaszewski --- drivers/video/backlight/gpio_backlight.c | 22 -- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git

[PATCH v2 0/7] Add anx6345 DP/eDP bridge for Olimex Teres-I

2019-07-22 Thread Torsten Duwe
ANX6345 LVTTL->eDP video bridge, driver with device tree bindings. Changes from v2: * use SPDX-IDs throughout * removed the panel output again, as it was not what Maxime had in mind. At least the Teres-I does very well without. No connector spec, no "quirks"[1], just plain EDID at work. *

Re: [PATCH 1/2] drm/radeon: Add HD-audio component notifier support

2019-07-22 Thread Koenig, Christian
Am 22.07.19 um 16:53 schrieb Takashi Iwai: > On Mon, 22 Jul 2019 16:44:06 +0200, > Koenig, Christian wrote: >> Am 22.07.19 um 16:38 schrieb Takashi Iwai: >>> This patch adds the support for the notification of HD-audio hotplug >>> via the already existing drm_audio_component framework to radeon >>>

Re: [PATCH 2/2] drm/nouveau: Add HD-audio component notifier support

2019-07-22 Thread Takashi Iwai
On Mon, 22 Jul 2019 17:00:15 +0200, Ilia Mirkin wrote: > > On Mon, Jul 22, 2019 at 10:38 AM Takashi Iwai wrote: > > +static void > > +nv50_audio_component_init(struct nouveau_drm *drm) > > +{ > > + if (!component_add(drm->dev->dev, &nv50_audio_component_bind_ops)) > > + drm->a

[PATCH v3 3/7] drm/bridge: extract some Analogix I2C DP common code

2019-07-22 Thread Torsten Duwe
From: Icenowy Zheng Some code can be shared within different DP bridges by Analogix. Extract them to analogix_dp. Signed-off-by: Icenowy Zheng Signed-off-by: Vasily Khoruzhick Signed-off-by: Torsten Duwe Reviewed-by: Andrzej Hajda --- drivers/gpu/drm/bridge/analogix/Makefile | 2

[PATCH v3 2/7] drm/bridge: split some definitions of ANX78xx to dedicated headers

2019-07-22 Thread Torsten Duwe
From: Icenowy Zheng Some definitions currently in analogix-anx78xx.h are not restricted to the ANX78xx series, but also applicable to other DisplayPort transmitters by Analogix. Split out them to dedicated headers, and make analogix-anx78xx.h include them. Signed-off-by: Icenowy Zheng Signed-o

[PATCH v3 1/7] drm/bridge: move ANA78xx driver to analogix subdirectory

2019-07-22 Thread Torsten Duwe
From: Icenowy Zheng As ANA78xx chips are designed and produced by Analogix Semiconductor, Inc, move their driver codes into analogix subdirectory. Signed-off-by: Icenowy Zheng Signed-off-by: Vasily Khoruzhick Reviewed-by: Laurent Pinchart Signed-off-by: Torsten Duwe Reviewed-by: Andrzej Hajd

[PATCH v3 4/7] drm/bridge: Prepare Analogix anx6345 support

2019-07-22 Thread Torsten Duwe
Add bit definitions required for the anx6345 and add a sanity check in anx_dp_aux_transfer. Signed-off-by: Icenowy Zheng Signed-off-by: Vasily Khoruzhick Signed-off-by: Torsten Duwe Reviewed-by: Andrzej Hajda --- drivers/gpu/drm/bridge/analogix/analogix-i2c-dptx.c | 2 +- drivers/gpu/drm/

[PATCH v3 5/7] drm/bridge: Add Analogix anx6345 support

2019-07-22 Thread Torsten Duwe
From: Icenowy Zheng The ANX6345 is an ultra-low power DisplayPower/eDP transmitter designed for portable devices. This driver adds initial support for RGB to eDP mode, without HPD and interrupts. This is a configuration usually seen in eDP applications. Signed-off-by: Icenowy Zheng Signed-off-

[PATCH v3 6/7] dt-bindings: Add ANX6345 DP/eDP transmitter binding

2019-07-22 Thread Torsten Duwe
The anx6345 is an ultra-low power DisplayPort/eDP transmitter designed for portable devices. Add a binding document for it. Signed-off-by: Icenowy Zheng Signed-off-by: Vasily Khoruzhick Reviewed-by: Rob Herring Signed-off-by: Torsten Duwe Reviewed-by: Laurent Pinchart --- .../devicetree/bin

[PATCH v3 7/7] arm64: dts: allwinner: a64: enable ANX6345 bridge on Teres-I

2019-07-22 Thread Torsten Duwe
Teres-I has an anx6345 bridge connected to the RGB666 LCD output, and the I2C controlling signals are connected to I2C0 bus. Enable it in the device tree, and the display engine, video mixer and tcon0 as well. Signed-off-by: Icenowy Zheng Signed-off-by: Torsten Duwe --- .../boot/dts/allwinner/

Re: [PATCH] drm/amdkfd/kfd_mqd_manager_v10: Fix missing break in switch statement

2019-07-22 Thread Liu, Shaoyun
This one properly in purpose , The mqd init for CP and  COMPUTE will have the same  routine . Regard sshaoyun.liu On 2019-07-21 6:59 p.m., Gustavo A. R. Silva wrote: > Add missing break statement in order to prevent the code from falling > through to case KFD_MQD_TYPE_COMPUTE. > > This bug was

Re: [PATCH v2 2/7] backlight: gpio: simplify the platform data handling

2019-07-22 Thread Daniel Thompson
On Mon, Jul 22, 2019 at 05:02:57PM +0200, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Now that the last user of platform data (sh ecovec24) defines a proper > GPIO lookup and sets the 'default-on' device property, we can drop the > platform_data-specific GPIO handling and unify a b

Re: [PATCH v2 4/7] backlight: gpio: remove unused fields from platform data

2019-07-22 Thread Daniel Thompson
On Mon, Jul 22, 2019 at 05:02:59PM +0200, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Remove the platform data fields that nobody uses. > > Signed-off-by: Bartosz Golaszewski Reviewed-by: Daniel Thompson > --- > include/linux/platform_data/gpio_backlight.h | 3 --- > 1 file c

Re: [PATCH v2 5/7] backlight: gpio: remove dev from struct gpio_backlight

2019-07-22 Thread Daniel Thompson
On Mon, Jul 22, 2019 at 05:03:00PM +0200, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > This field is unused. Remove it. > > Signed-off-by: Bartosz Golaszewski Reviewed-by: Daniel Thompson > --- > drivers/video/backlight/gpio_backlight.c | 4 > 1 file changed, 4 deletions

Re: [PATCH 1/2] drm/radeon: Add HD-audio component notifier support

2019-07-22 Thread Takashi Iwai
On Mon, 22 Jul 2019 17:07:09 +0200, Koenig, Christian wrote: > > Am 22.07.19 um 16:53 schrieb Takashi Iwai: > > On Mon, 22 Jul 2019 16:44:06 +0200, > > Koenig, Christian wrote: > >> Am 22.07.19 um 16:38 schrieb Takashi Iwai: > >>> This patch adds the support for the notification of HD-audio hotplu

Re: [PATCH v2 6/7] backlight: gpio: remove def_value from struct gpio_backlight

2019-07-22 Thread Daniel Thompson
On Mon, Jul 22, 2019 at 05:03:01PM +0200, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > This field is unused outside of probe(). There's no need to store it. > We can make it into a local variable. > > Signed-off-by: Bartosz Golaszewski Reviewed-by: Daniel Thompson > --- > driv

dri-devel@lists.freedesktop.org

2019-07-22 Thread Daniel Thompson
On Mon, Jul 22, 2019 at 05:03:02PM +0200, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Instead of dereferencing pdev each time, use a helper variable for > the associated device pointer. > > Signed-off-by: Bartosz Golaszewski Reviewed-by: Daniel Thompson > --- > drivers/video

Re: [PATCH 1/2] drm/radeon: Add HD-audio component notifier support

2019-07-22 Thread Alex Deucher
On Mon, Jul 22, 2019 at 11:21 AM Takashi Iwai wrote: > > On Mon, 22 Jul 2019 17:07:09 +0200, > Koenig, Christian wrote: > > > > Am 22.07.19 um 16:53 schrieb Takashi Iwai: > > > On Mon, 22 Jul 2019 16:44:06 +0200, > > > Koenig, Christian wrote: > > >> Am 22.07.19 um 16:38 schrieb Takashi Iwai: > >

Re: [PATCH 1/2] drm/radeon: Add HD-audio component notifier support

2019-07-22 Thread Koenig, Christian
Am 22.07.19 um 17:21 schrieb Takashi Iwai: > On Mon, 22 Jul 2019 17:07:09 +0200, > Koenig, Christian wrote: >> Am 22.07.19 um 16:53 schrieb Takashi Iwai: >>> On Mon, 22 Jul 2019 16:44:06 +0200, >>> Koenig, Christian wrote: Am 22.07.19 um 16:38 schrieb Takashi Iwai: [SNIP] >> The hardware

Re: [PATCH v2 1/4] drm/via: drop use of DRM(READ|WRITE) macros

2019-07-22 Thread Emil Velikov
On Sat, 20 Jul 2019 at 09:46, Sam Ravnborg wrote: > > The DRM_READ, DRM_WRITE macros comes from the deprecated drm_os_linux.h > header file. Remove their use to remove this dependency. > > Replace the use of the macros with open coded variants. > > Signed-off-by: Sam Ravnborg > Cc: Kevin Brace >

Re: [PATCH v2 2/4] drm/via: add VIA_WAIT_ON()

2019-07-22 Thread Emil Velikov
On Sat, 20 Jul 2019 at 09:46, Sam Ravnborg wrote: > > VIA_WAIT_ON() is a direct copy of DRM_WAIT_ON() from > drm_os_linux.h. > The copy is made so we can avoid the dependency on the legacy header. > A more involved approach had been to introduce wait_event_* but for this > legacy driver the simple

Re: [PATCH 1/2] drm/radeon: Add HD-audio component notifier support

2019-07-22 Thread Takashi Iwai
On Mon, 22 Jul 2019 17:35:09 +0200, Alex Deucher wrote: > > On Mon, Jul 22, 2019 at 11:21 AM Takashi Iwai wrote: > > > > On Mon, 22 Jul 2019 17:07:09 +0200, > > Koenig, Christian wrote: > > > > > > Am 22.07.19 um 16:53 schrieb Takashi Iwai: > > > > On Mon, 22 Jul 2019 16:44:06 +0200, > > > > Koen

Re: [PATCH] drm/amdkfd/kfd_mqd_manager_v10: Fix missing break in switch statement

2019-07-22 Thread Deucher, Alexander
We need to add a /*fall through */ comment then. Alex From: Liu, Shaoyun Sent: Monday, July 22, 2019 11:14 AM To: Gustavo A. R. Silva ; Cox, Philip ; Oded Gabbay ; Deucher, Alexander ; Koenig, Christian ; Zhou, David(ChunMing) ; David Airlie ; Daniel Vetter C

Re: [PATCH 1/2] drm/radeon: Add HD-audio component notifier support

2019-07-22 Thread Takashi Iwai
On Mon, 22 Jul 2019 17:38:36 +0200, Koenig, Christian wrote: > > Am 22.07.19 um 17:21 schrieb Takashi Iwai: > > On Mon, 22 Jul 2019 17:07:09 +0200, > > Koenig, Christian wrote: > >> Am 22.07.19 um 16:53 schrieb Takashi Iwai: > >>> On Mon, 22 Jul 2019 16:44:06 +0200, > >>> Koenig, Christian wrote:

Re: [PATCH v2 2/7] backlight: gpio: simplify the platform data handling

2019-07-22 Thread Andy Shevchenko
On Mon, Jul 22, 2019 at 05:02:57PM +0200, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Now that the last user of platform data (sh ecovec24) defines a proper > GPIO lookup and sets the 'default-on' device property, we can drop the > platform_data-specific GPIO handling and unify a b

[PATCH v2 2/3] dt-bindings: display: sii902x: Change audio mclk binding

2019-07-22 Thread Olivier Moysan
As stated in SiL9022/24 datasheet, master clock is not required for I2S. Make mclk property optional in DT bindings. Fixes: 3f18021f43a3 ("dt-bindings: display: sii902x: Add HDMI audio bindings") Signed-off-by: Olivier Moysan Reviewed-by: Jyri Sarha Acked-by: Andrzej Hajda --- Documentation/d

[PATCH v2 3/3] drm/bridge: sii902x: make audio mclk optional

2019-07-22 Thread Olivier Moysan
The master clock on i2s bus is not mandatory, as sii902X internal PLL can be used instead. Make use of mclk optional. Signed-off-by: Olivier Moysan Reviewed-by: Jyri Sarha Acked-by: Andrzej Hajda --- drivers/gpu/drm/bridge/sii902x.c | 19 ++- 1 file changed, 10 insertions(+), 9

[PATCH v2 0/3] drm/bridge: sii902x: fix audio mclk management

2019-07-22 Thread Olivier Moysan
Fix audio master clock use for Silab sii902x HDMI transceiver. Make audio master clock optional, as this clock is not mandatory. Changes in v2: - Rely on clk framework to manage undefined mclk case. - Use devm_clk_get_optional instead of devm_clk_get. Olivier Moysan (3): drm/bridge: sii902x: fi

[PATCH v2 1/3] drm/bridge: sii902x: fix missing reference to mclk clock

2019-07-22 Thread Olivier Moysan
Add devm_clk_get call to retrieve reference to master clock. Fixes: ff5781634c41 ("drm/bridge: sii902x: Implement HDMI audio support") Signed-off-by: Olivier Moysan Reviewed-by: Jyri Sarha Acked-by: Andrzej Hajda audio.i2s_fifo_sequence[i] |= audio_fifo_id[i] | i2s_lane_

[PATCH libdrm 2/2] modetest: Add a new "-r" option to set a default mode

2019-07-22 Thread Ezequiel Garcia
This option finds the first connected connector and then sets its preferred mode on it. Set this option to be set when no mode or plane is set explicitily. This allows to quickly test, in cases where one just needs something displayed. Signed-off-by: Ezequiel Garcia --- tests/modetest/modetest.

dri-devel@lists.freedesktop.org

2019-07-22 Thread Andy Shevchenko
On Mon, Jul 22, 2019 at 05:03:02PM +0200, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Instead of dereferencing pdev each time, use a helper variable for > the associated device pointer. > static int gpio_backlight_probe(struct platform_device *pdev) > { > - struct gpio_backl

[PATCH libdrm 1/2] modetest: Fix segmentation fault

2019-07-22 Thread Ezequiel Garcia
When a mode is set with just a connector "-s foo", we get a nasty segmentation fault. Fix it. Signed-off-by: Ezequiel Garcia --- tests/modetest/modetest.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/modetest/modetest.c b/tests/modetest/modetest.c index e66be6607e00..5e628127a130

Re: [PATCH v2 0/7] backlight: gpio: simplify the driver

2019-07-22 Thread Andy Shevchenko
On Mon, Jul 22, 2019 at 05:02:55PM +0200, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > While working on my other series related to gpio-backlight[1] I noticed > that we could simplify the driver if we made the only user of platform > data use GPIO lookups and device properties. This

Re: [PATCH 1/2] drm/radeon: Add HD-audio component notifier support

2019-07-22 Thread Alex Deucher
On Mon, Jul 22, 2019 at 11:47 AM Takashi Iwai wrote: > > On Mon, 22 Jul 2019 17:35:09 +0200, > Alex Deucher wrote: > > > > On Mon, Jul 22, 2019 at 11:21 AM Takashi Iwai wrote: > > > > > > On Mon, 22 Jul 2019 17:07:09 +0200, > > > Koenig, Christian wrote: > > > > > > > > Am 22.07.19 um 16:53 schri

[Bug 111193] DRM/admin component is not displaying.

2019-07-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=93 Rakesh changed: What|Removed |Added Summary|DRM/admin component is not |DRM/admin component is not |

Re: [PATCH v2 1/4] drm/via: drop use of DRM(READ|WRITE) macros

2019-07-22 Thread Sam Ravnborg
Hi Emil. On Mon, Jul 22, 2019 at 04:38:39PM +0100, Emil Velikov wrote: > On Sat, 20 Jul 2019 at 09:46, Sam Ravnborg wrote: > > > > The DRM_READ, DRM_WRITE macros comes from the deprecated drm_os_linux.h > > header file. Remove their use to remove this dependency. > > > > Replace the use of the ma

Re: [PATCH] drm/komeda: Adds error event print functionality

2019-07-22 Thread Liviu Dudau
On Mon, Jul 22, 2019 at 11:15:12AM +, james qian wang (Arm Technology China) wrote: > On Fri, Jul 19, 2019 at 11:40:11AM +, Liviu Dudau wrote: > > On Fri, Jul 19, 2019 at 09:09:30AM +, Lowry Li (Arm Technology China) > > wrote: > > > Hi Liviu, > > > > > > On Thu, Jul 18, 2019 at 01:1

Re: [PATCH v2 2/4] drm/via: add VIA_WAIT_ON()

2019-07-22 Thread Sam Ravnborg
Hi Email. On Mon, Jul 22, 2019 at 04:46:08PM +0100, Emil Velikov wrote: > On Sat, 20 Jul 2019 at 09:46, Sam Ravnborg wrote: > > > > VIA_WAIT_ON() is a direct copy of DRM_WAIT_ON() from > > drm_os_linux.h. > > The copy is made so we can avoid the dependency on the legacy header. > > A more involved

Re: [PATCH 3/5] drm/panfrost: Add a no execute flag for BO allocations

2019-07-22 Thread Rob Herring
On Mon, Jul 22, 2019 at 7:25 AM Robin Murphy wrote: > > On 22/07/2019 13:19, Steven Price wrote: > [...] > > Indeed, that case was just occurring to me too! How about: > > > > u64 next_seg = ALIGN(*start, PFN_4G); > > > > if (next_seg - *start <= PFN_16M) > > *start = nex

  1   2   3   >