Re: [Intel-gfx] [RFC][PATCH 0/2] drm: PATH prop for all connectors?

2019-07-11 Thread Daniel Vetter
On Wed, Jul 10, 2019 at 06:43:53PM -0400, Lyude Paul wrote: > (adding sunpeng...@amd.com to the thread here, since this is relevant to the > DP > aux device work) > > I mentioned this in IRC, but figured I should mention it on the ML as well so > it > can be discussed further. Honestly: I don't

[PATCH v3] drm/agp: Remove unused function drm_agp_bind_pages

2019-07-11 Thread Maya Rashish
Reviewed-by: Sam Ravnborg Signed-off-by: Maya Rashish --- drivers/gpu/drm/drm_agpsupport.c | 43 include/drm/drm_agpsupport.h | 14 - 2 files changed, 57 deletions(-) diff --git a/drivers/gpu/drm/drm_agpsupport.c b/drivers/gpu/drm/drm_agp

Re: BUG: Staging: fbtft: Switch to the gpio descriptor interface

2019-07-11 Thread Nishad Kamdar
On Wed, Jul 10, 2019 at 04:31:09PM +0800, Phil Reid wrote: > G'day Nishad, > > I'm just wondering if the commit > c440eee1a7a1d0f "Staging: fbtft: Switch to the gpio descriptor interface" > was tested on anything. > > I've had to apply the following patch to get my display functioning again. > >

BUG: Staging: fbtft: Switch to the gpio descriptor interface

2019-07-11 Thread Phil Reid
G'day Nishad, I'm just wondering if the commit c440eee1a7a1d0f "Staging: fbtft: Switch to the gpio descriptor interface" was tested on anything. I've had to apply the following patch to get my display functioning again. in particular the devm_gpiod_get_index using dev->driver->name for the gpio

[PATCH 1/2] drm/ttm: use the same attributes when freeing d_page->vaddr

2019-07-11 Thread Fuqian Huang
In function __ttm_dma_alloc_page(), d_page->addr is allocated by dma_alloc_attrs() but freed with use dma_free_coherent() in __ttm_dma_free_page(). Use the correct dma_free_attrs() to free d_page->vaddr. Signed-off-by: Fuqian Huang --- drivers/gpu/drm/ttm/ttm_page_alloc_dma.c | 6 +- 1 file

Re: [PATCH v1] drm/modes: Skip invalid cmdline mode

2019-07-11 Thread Dmitry Osipenko
10.07.2019 17:05, Maxime Ripard пишет: > On Wed, Jul 10, 2019 at 04:29:19PM +0300, Dmitry Osipenko wrote: >> This works: >> >> diff --git a/drivers/gpu/drm/drm_client_modeset.c >> b/drivers/gpu/drm/drm_client_modeset.c >> index 56d36779d213..e5a2f9c8f404 100644 >> --- a/drivers/gpu/drm/drm_client_

Re: BUG: Staging: fbtft: Switch to the gpio descriptor interface

2019-07-11 Thread Phil Reid
On 10/07/2019 17:05, Nicolas Saenz Julienne wrote: On Wed, 2019-07-10 at 16:31 +0800, Phil Reid wrote: G'day Nishad, I'm just wondering if the commit c440eee1a7a1d0f "Staging: fbtft: Switch to the gpio descriptor interface" was tested on anything. I've had to apply the following patch to get m

Re: [PATCH 1/2] regmap: Add DSI bus support

2019-07-11 Thread Jeffrey Hugo
On Fri, Jul 5, 2019 at 7:06 PM Mark Brown wrote: > > On Wed, Jul 03, 2019 at 02:45:12PM -0700, Jeffrey Hugo wrote: > > Add basic support with a simple implementation that utilizes the generic > > read/write commands to allow device registers to be configured. > > This looks good to me but I really

Re: BUG: Staging: fbtft: Switch to the gpio descriptor interface

2019-07-11 Thread Nicolas Saenz Julienne
On Wed, 2019-07-10 at 16:31 +0800, Phil Reid wrote: > G'day Nishad, > > I'm just wondering if the commit > c440eee1a7a1d0f "Staging: fbtft: Switch to the gpio descriptor interface" > was tested on anything. > > I've had to apply the following patch to get my display functioning again. > > in par

Re: BUG: Staging: fbtft: Switch to the gpio descriptor interface

2019-07-11 Thread Nicolas Saenz Julienne
On Wed, 2019-07-10 at 17:27 +0800, Phil Reid wrote: > On 10/07/2019 17:05, Nicolas Saenz Julienne wrote: > > On Wed, 2019-07-10 at 16:31 +0800, Phil Reid wrote: > > > G'day Nishad, > > > > > > I'm just wondering if the commit > > > c440eee1a7a1d0f "Staging: fbtft: Switch to the gpio descriptor int

Re: [Intel-gfx] [RFC][PATCH 0/2] drm: PATH prop for all connectors?

2019-07-11 Thread Pekka Paalanen
On Wed, 10 Jul 2019 18:43:53 -0400 Lyude Paul wrote: > (adding sunpeng...@amd.com to the thread here, since this is relevant to the > DP > aux device work) > > I mentioned this in IRC, but figured I should mention it on the ML as well so > it > can be discussed further. Honestly: I don't like

Re: [PATCH 09/60] drm/bridge: Add connector-related bridge operations and data

2019-07-11 Thread Daniel Vetter
On Wed, Jul 10, 2019 at 02:12:14PM +0200, Andrzej Hajda wrote: > Hi Laurent, > > > I like the approach, current practice when almost every bridge should > optionally implement connector, or alternatively downstream bridge or > panel is very painful. Yeah I think this looks mostly reasonable. Som

Re: [PATCH 00/60] drm/omap: Replace custom display drivers with drm_bridge and drm_panel

2019-07-11 Thread Daniel Vetter
On Sun, Jul 07, 2019 at 09:07:52PM +0300, Laurent Pinchart wrote: > Hello, > > This patch series (nearly, see [1]) completes the rework of the omapdrm > driver to move to drm_bridge and drm_panel. > > What a journey. This work was started more than a year ago, and this > last piece is perhaps the

Re: [PATCH V3 1/5] drm/vkms: Avoid assigning 0 for possible_crtc

2019-07-11 Thread Daniel Vetter
On Tue, Jun 25, 2019 at 10:36:18PM -0300, Rodrigo Siqueira wrote: > When vkms invoke drm_universal_plane_init(), it sets 0 for > possible_crtcs parameter which means that planes can't be attached to > any CRTC. It currently works due to some safeguard in the drm_crtc file; > however, it is possible

Re: [PATCH V3 2/5] drm/vkms: Rename vkms_crc.c into vkms_composer.c

2019-07-11 Thread Daniel Vetter
On Tue, Jun 25, 2019 at 10:37:05PM -0300, Rodrigo Siqueira wrote: > As a preparation work for introducing writeback to vkms, this patch > renames the file vkms_crc.c into vkms_composer.c. Accordingly, it also > adjusts the functions and data structures to match the changes. > > No functional chang

Re: [PATCH V3 3/5] drm/vkms: Decouple crc operations from composer

2019-07-11 Thread Daniel Vetter
On Tue, Jun 25, 2019 at 10:37:58PM -0300, Rodrigo Siqueira wrote: > In the vkms_composer.c, some of the functions related to CRC and compose > have interdependence between each other. This patch reworks some > functions inside vkms_composer to make crc and composer computation > decoupled. > > Thi

Re: [PATCH V3 4/5] drm/vkms: Compute CRC without change input data

2019-07-11 Thread Daniel Vetter
On Tue, Jun 25, 2019 at 10:38:31PM -0300, Rodrigo Siqueira wrote: > The compute_crc() function is responsible for calculating the > framebuffer CRC value; due to the XRGB format, this function has to > ignore the alpha channel during the CRC computation. Therefore, > compute_crc() set zero to the a

Re: [PATCH V3 3/5] drm/vkms: Decouple crc operations from composer

2019-07-11 Thread Simon Ser
On Thursday, July 11, 2019 11:19 AM, Daniel Vetter wrote: > Aside: This all kinda doesn't go in the right direction for > high-performance composing, so I guess I need to get started with typing > up what that should look like. Some related logs from IRC: 2019-07-10 19:42:49 danvet ickle, i

Re: [PATCH V3 4/5] drm/vkms: Compute CRC without change input data

2019-07-11 Thread Simon Ser
On Thursday, July 11, 2019 11:21 AM, Daniel Vetter wrote: > On Tue, Jun 25, 2019 at 10:38:31PM -0300, Rodrigo Siqueira wrote: > > > The compute_crc() function is responsible for calculating the > > framebuffer CRC value; due to the XRGB format, this function has to > > ignore the alpha channel du

Re: [PATCH V3 5/5] drm/vkms: Add support for writeback

2019-07-11 Thread Daniel Vetter
On Tue, Jun 25, 2019 at 10:39:03PM -0300, Rodrigo Siqueira wrote: > This patch implements the necessary functions to add writeback support > for vkms. This feature is useful for testing compositors if you don't > have hardware with writeback support. > > Change in V3 (Daniel): > - If writeback is

Re: [PATCH V3 4/5] drm/vkms: Compute CRC without change input data

2019-07-11 Thread Daniel Vetter
On Thu, Jul 11, 2019 at 10:28 AM Simon Ser wrote: > > On Thursday, July 11, 2019 11:21 AM, Daniel Vetter wrote: > > > On Tue, Jun 25, 2019 at 10:38:31PM -0300, Rodrigo Siqueira wrote: > > > > > The compute_crc() function is responsible for calculating the > > > framebuffer CRC value; due to the X

Re: [PATCH v1] drm/modes: Skip invalid cmdline mode

2019-07-11 Thread Maxime Ripard
On Wed, Jul 10, 2019 at 06:05:18PM +0300, Dmitry Osipenko wrote: > 10.07.2019 17:05, Maxime Ripard пишет: > > On Wed, Jul 10, 2019 at 04:29:19PM +0300, Dmitry Osipenko wrote: > >> This works: > >> > >> diff --git a/drivers/gpu/drm/drm_client_modeset.c > >> b/drivers/gpu/drm/drm_client_modeset.c >

Re: [PATCH] drm/bridge: sii902x: add audio graph card support

2019-07-11 Thread Philippe CORNU
Hi Daniel, On 7/10/19 5:27 PM, Daniel Vetter wrote: > On Fri, Jul 05, 2019 at 12:41:03PM +, Philippe CORNU wrote: >> Hi Olivier, >> and many thanks for your patch. >> Good to have the audio graph card support, looks ok. >> Reviewed-by: Philippe Cornu > > Since you have drm-misc commit right

[Bug 109206] Kernel 4.20 amdgpu fails to load firmware on Ryzen 2500U

2019-07-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109206 --- Comment #53 from Ondrej Lang --- According to the linux kernel 5.2 changelog (https://cdn.kernel.org/pub/linux/kernel/v5.x/ChangeLog-5.2), the fix for the DMCU firmware issue on raven1 platform is included in that release. I went ahead and

Re: [PATCH] drm/bridge: sii902x: add audio graph card support

2019-07-11 Thread Daniel Vetter
On Thu, Jul 11, 2019 at 09:27:30AM +, Philippe CORNU wrote: > Hi Daniel, > > > On 7/10/19 5:27 PM, Daniel Vetter wrote: > > On Fri, Jul 05, 2019 at 12:41:03PM +, Philippe CORNU wrote: > >> Hi Olivier, > >> and many thanks for your patch. > >> Good to have the audio graph card support, loo

[PATCH v2 1/5] drm/edid: Add CTA-861-G modes with VIC < 128

2019-07-11 Thread Ville Syrjala
From: Ville Syrjälä Fill out our list of cea modes with the new stuff from CTA-861-G. We only do the modes with VIC < 128 here. Adding the higher numbered VICs will need some slight code refactoring first. Cc: Hans Verkuil Cc: Shashank Sharma Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/

[PATCH v2 0/5] drm/edid: Add new modes from CTA-861-G

2019-07-11 Thread Ville Syrjala
From: Ville Syrjälä Reposting a series from 1-2 years ago. I did toss in one extra patch at the end to boost our confidence a bit bit. Cc: Hans Verkuil Cc: Shashank Sharma Ville Syrjälä (5): drm/edid: Add CTA-861-G modes with VIC < 128 drm/edid: Abstract away cea_edid_modes[] drm/edid:

[PATCH v2 3/5] drm/edid: Add CTA-861-G modes with VIC >= 193

2019-07-11 Thread Ville Syrjala
From: Ville Syrjälä Add a second table to the cea modes with VIC >= 193. Cc: Hans Verkuil Cc: Shashank Sharma Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/drm_edid.c | 151 - 1 file changed, 149 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/d

[PATCH v2 2/5] drm/edid: Abstract away cea_edid_modes[]

2019-07-11 Thread Ville Syrjala
From: Ville Syrjälä We're going to need two cea mode tables (on for VICs < 128, another one for VICs >= 193). To that end replace the direct edid_cea_modes[] lookups with a function call. And we'll rename the array to edid_cea_modes_0[] to indicathe how it's to be indexed. Cc: Hans Verkuil Cc:

[PATCH v2 4/5] drm/edid: Throw away the dummy VIC 0 cea mode

2019-07-11 Thread Ville Syrjala
From: Ville Syrjälä Now that the cea mode handling is not 100% tied to the single array the dummy VIC 0 mode is pretty much pointles. Throw it out. Cc: Hans Verkuil Cc: Shashank Sharma Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/drm_edid.c | 14 +- 1 file changed, 5 insertio

[PATCH v2 5/5] drm/edid: Make sure the CEA mode arrays have the correct amount of modes

2019-07-11 Thread Ville Syrjala
From: Ville Syrjälä We depend on a specific relationship between the VIC number and the index in the CEA mode arrays. Assert that the arrays have the excpected size to make sure we've not accidentally left holes in them. Cc: Hans Verkuil Cc: Shashank Sharma Signed-off-by: Ville Syrjälä --- d

Re: [PATCH] drm/bridge: sii902x: add audio graph card support

2019-07-11 Thread Andrzej Hajda
On 11.07.2019 11:27, Philippe CORNU wrote: > Hi Daniel, > > > On 7/10/19 5:27 PM, Daniel Vetter wrote: >> On Fri, Jul 05, 2019 at 12:41:03PM +, Philippe CORNU wrote: >>> Hi Olivier, >>> and many thanks for your patch. >>> Good to have the audio graph card support, looks ok. >>> Reviewed-by: Phi

Re: [PATCH] drm/bridge: sii902x: add audio graph card support

2019-07-11 Thread Jyri Sarha
On 03/07/2019 11:04, Olivier Moysan wrote: > Implement get_dai_id callback of audio HDMI codec > to support ASoC audio graph card. > HDMI audio output has to be connected to sii902x port 3. > get_dai_id callback maps this port to ASoC DAI index 0. > > Signed-off-by: Olivier Moysan I have not use

[PATCH v4 01/23] drm: Include ddc adapter pointer in struct drm_connector

2019-07-11 Thread Andrzej Pietrasiewicz
Add generic code which creates symbolic links in sysfs, pointing to ddc interface used by a particular video output. For example: ls -l /sys/class/drm/card0-HDMI-A-1/ddc lrwxrwxrwx 1 root root 0 Jun 24 10:42 /sys/class/drm/card0-HDMI-A-1/ddc \ -> ../../../../soc/1388.i2c/i2c-2 This ma

[PATCH v4 00/23] Associate ddc adapters with connectors

2019-07-11 Thread Andrzej Pietrasiewicz
It is difficult for a user to know which of the i2c adapters is for which drm connector. This series addresses this problem. The idea is to have a symbolic link in connector's sysfs directory, e.g.: ls -l /sys/class/drm/card0-HDMI-A-1/ddc lrwxrwxrwx 1 root root 0 Jun 24 10:42 /sys/class/drm/card0

[PATCH v4 02/23] drm/exynos: Provide ddc symlink in connector's sysfs

2019-07-11 Thread Andrzej Pietrasiewicz
Switch to using the ddc provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/exynos/exynos_hdmi.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c in

[PATCH v4 03/23] drm: rockchip: Provide ddc symlink in rk3066_hdmi sysfs directory

2019-07-11 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/rockchip/rk3066_hdmi.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/rockchip/rk3066_hdmi.c b/drivers/gpu/drm/rockchip/rk3066_h

[PATCH v4 06/23] drm/sun4i: hdmi: Provide ddc symlink in sun4i hdmi connector sysfs directory

2019-07-11 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/sun4i/sun4i_hdmi.h | 1 - drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c | 14 +++--- 2 files changed, 7 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/sun4i/sun4i_hd

[PATCH v4 05/23] drm/msm/hdmi: Provide ddc symlink in hdmi connector sysfs directory

2019-07-11 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/msm/hdmi/hdmi_connector.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_connector.c b/drivers/gpu/drm/msm/hdmi/hdmi_connector.c index 07b4cb877d82.

[PATCH v4 04/23] drm: rockchip: Provide ddc symlink in inno_hdmi sysfs directory

2019-07-11 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/rockchip/inno_hdmi.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/rockchip/inno_hdmi.c b/drivers/gpu/drm/rockchip/inno_hdmi.c

[PATCH v4 07/23] drm/mediatek: Provide ddc symlink in hdmi connector sysfs directory

2019-07-11 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/mediatek/mtk_hdmi.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c index 5d6a9f

[PATCH v4 08/23] drm/tegra: Provide ddc symlink in output connector sysfs directory

2019-07-11 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/tegra/drm.h| 1 - drivers/gpu/drm/tegra/output.c | 12 ++-- drivers/gpu/drm/tegra/sor.c| 6 +++--- 3 files changed, 9 insertions(+), 10 deletions(-) diff --git a/dri

[PATCH v4 09/23] drm/imx: imx-ldb: Provide ddc symlink in connector's sysfs

2019-07-11 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/imx/imx-ldb.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/imx/imx-ldb.c b/drivers/gpu/drm/imx/imx-ldb.c index 383733302280..44fdb2

[PATCH v4 10/23] drm/imx: imx-tve: Provide ddc symlink in connector's sysfs

2019-07-11 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/imx/imx-tve.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/imx/imx-tve.c b/drivers/gpu/drm/imx/imx-tve.c index e725af8a0025..b8bee4e1f169

[PATCH v4 13/23] drm: zte: Provide ddc symlink in vga connector sysfs directory

2019-07-11 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/zte/zx_vga.c | 25 + 1 file changed, 9 insertions(+), 16 deletions(-) diff --git a/drivers/gpu/drm/zte/zx_vga.c b/drivers/gpu/drm/zte/zx_vga.c index 1634a08707

[PATCH v4 11/23] drm/vc4: Provide ddc symlink in connector sysfs directory

2019-07-11 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/vc4/vc4_hdmi.c | 21 - 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c index ee7d4e7b

[PATCH v4 15/23] drm: sti: Provide ddc symlink in hdmi connector sysfs directory

2019-07-11 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/sti/sti_hdmi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/sti/sti_hdmi.c b/drivers/gpu/drm/sti/sti_hdmi.c index f03d617edc4c..90f8db63c095 100644 --- a/drivers

[PATCH v4 12/23] drm: zte: Provide ddc symlink in hdmi connector sysfs directory

2019-07-11 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/zte/zx_hdmi.c | 25 + 1 file changed, 9 insertions(+), 16 deletions(-) diff --git a/drivers/gpu/drm/zte/zx_hdmi.c b/drivers/gpu/drm/zte/zx_hdmi.c index bfe918b

[PATCH v4 16/23] drm/mgag200: Provide ddc symlink in connector sysfs directory

2019-07-11 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/mgag200/mgag200_mode.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/mgag200/mgag200_mode.c b/drivers/gpu/drm/mgag200/mgag200_mode.c ind

[PATCH v4 17/23] drm/ast: Provide ddc symlink in connector sysfs directory

2019-07-11 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/ast/ast_mode.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/ast/ast_mode.c b/drivers/gpu/drm/ast/ast_mode.c index ffccbef962a4..1ca9bc4a

[PATCH v4 14/23] drm/tilcdc: Provide ddc symlink in connector sysfs directory

2019-07-11 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/tilcdc/tilcdc_tfp410.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c b/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c index 62d014c20988..c373edb9

[PATCH v4 18/23] drm/bridge: dumb-vga-dac: Provide ddc symlink in connector sysfs directory

2019-07-11 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/bridge/dumb-vga-dac.c | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/bridge/dumb-vga-dac.c b/drivers/gpu/drm/bridge/dumb-vga-

[PATCH v4 20/23] drm/bridge: ti-tfp410: Provide ddc symlink in connector sysfs directory

2019-07-11 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/bridge/ti-tfp410.c | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/bridge/ti-tfp410.c b/drivers/gpu/drm/bridge/ti-tfp410.c ind

[PATCH v4 21/23] drm/amdgpu: Provide ddc symlink in connector sysfs directory

2019-07-11 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- .../gpu/drm/amd/amdgpu/amdgpu_connectors.c| 56 --- 1 file changed, 36 insertions(+), 20 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c b/drivers/gpu/dr

[PATCH v4 19/23] drm/bridge: dw-hdmi: Provide ddc symlink in connector sysfs directory

2019-07-11 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 40 +++ 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bri

[PATCH v4 23/23] drm/i915: Provide ddc symlink in hdmi connector sysfs directory

2019-07-11 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/i915/display/intel_hdmi.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.

[PATCH v4 22/23] drm/radeon: Provide ddc symlink in connector sysfs directory

2019-07-11 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/radeon/radeon_connectors.c | 80 ++ 1 file changed, 52 insertions(+), 28 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_connectors.c b/drivers/gpu/drm/ra

Re: [PATCH 00/60] drm/omap: Replace custom display drivers with drm_bridge and drm_panel

2019-07-11 Thread Sebastian Reichel
Hi, On Thu, Jul 11, 2019 at 09:37:26AM +0200, Daniel Vetter wrote: > > [1] The only notable exception is the omapdrm-specific DSI panel driver > > that implements a large number of custom operations. This should be > > addressed separately. > > DSI tends to be fairly custom in all drivers, I thin

Re: [PATCH v4 23/23] drm/i915: Provide ddc symlink in hdmi connector sysfs directory

2019-07-11 Thread Ville Syrjälä
On Thu, Jul 11, 2019 at 01:26:50PM +0200, Andrzej Pietrasiewicz wrote: > Use the ddc pointer provided by the generic connector. We already have a symlink via intel_hdmi_create_i2c_symlink(). I guess we should remove that in favor of the generic one. Oleg? > > Signed-off-by: Andrzej Pietrasiewicz

Re: [PATCH v4 01/23] drm: Include ddc adapter pointer in struct drm_connector

2019-07-11 Thread Ville Syrjälä
On Thu, Jul 11, 2019 at 01:26:28PM +0200, Andrzej Pietrasiewicz wrote: > Add generic code which creates symbolic links in sysfs, pointing to ddc > interface used by a particular video output. For example: > > ls -l /sys/class/drm/card0-HDMI-A-1/ddc > lrwxrwxrwx 1 root root 0 Jun 24 10:42 /sys/clas

Re: [PATCH v6 11/22] clk: sunxi-ng: a64: Add minimum rate for PLL_MIPI

2019-07-11 Thread Maxime Ripard
On Fri, Jul 05, 2019 at 07:52:27PM +0200, Michael Nazzareno Trimarchi wrote: > On Wed, Jul 3, 2019 at 1:49 PM Maxime Ripard > wrote: > > > > On Tue, Jun 25, 2019 at 09:00:36PM +0530, Jagan Teki wrote: > > > On Tue, Jun 25, 2019 at 8:19 PM Maxime Ripard > > > wrote: > > > > > > > > On Thu, Jun 2

Re: [PATCH 09/60] drm/bridge: Add connector-related bridge operations and data

2019-07-11 Thread Andrzej Hajda
On 11.07.2019 09:35, Daniel Vetter wrote: > On Wed, Jul 10, 2019 at 02:12:14PM +0200, Andrzej Hajda wrote: >> Hi Laurent, >> >> >> I like the approach, current practice when almost every bridge should >> optionally implement connector, or alternatively downstream bridge or >> panel is very painful.

Re: [PATCH v9 1/6] drm: Add Content protection type property

2019-07-11 Thread Ramalingam C
On 2019-07-10 at 11:16:24 +0300, Pekka Paalanen wrote: > On Tue, 9 Jul 2019 18:17:59 +0530 > Ramalingam C wrote: > > > On 2019-07-09 at 17:31:10 +0300, Pekka Paalanen wrote: > > > On Mon, 8 Jul 2019 16:51:11 +0530 > > > Ramalingam C wrote: > > > > > > > This patch adds a DRM ENUM property to

[Bug 110783] Mesa 19.1 rc crashing MPV with VAAPI

2019-07-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110783 --- Comment #22 from AngryPenguin --- I can confirm. 19.1.2 fixed my issue on OpenMandirva. Thanks -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailing list

Re: [PATCH 1/2] regmap: Add DSI bus support

2019-07-11 Thread Andrzej Hajda
On 06.07.2019 03:06, Mark Brown wrote: > On Wed, Jul 03, 2019 at 02:45:12PM -0700, Jeffrey Hugo wrote: >> Add basic support with a simple implementation that utilizes the generic >> read/write commands to allow device registers to be configured. > This looks good to me but I really don't know anyth

Re: [PATCH 09/60] drm/bridge: Add connector-related bridge operations and data

2019-07-11 Thread Daniel Vetter
On Thu, Jul 11, 2019 at 02:41:01PM +0200, Andrzej Hajda wrote: > On 11.07.2019 09:35, Daniel Vetter wrote: > > On Wed, Jul 10, 2019 at 02:12:14PM +0200, Andrzej Hajda wrote: > >> Hi Laurent, > >> > >> > >> I like the approach, current practice when almost every bridge should > >> optionally impleme

Re: [PATCH v4 23/23] drm/i915: Provide ddc symlink in hdmi connector sysfs directory

2019-07-11 Thread Daniel Vetter
On Thu, Jul 11, 2019 at 02:59:26PM +0300, Ville Syrjälä wrote: > On Thu, Jul 11, 2019 at 01:26:50PM +0200, Andrzej Pietrasiewicz wrote: > > Use the ddc pointer provided by the generic connector. > > We already have a symlink via intel_hdmi_create_i2c_symlink(). I guess > we should remove that in f

[PATCH] drm/omap: Add 'alpha' and 'pixel blend mode' plane properties

2019-07-11 Thread Jean-Jacques Hiblot
Add the following properties for planes: * alpha * pixel blend mode. Only "Pre-multiplied" and "Coverage" are supported Signed-off-by: Jean-Jacques Hiblot --- drivers/gpu/drm/omapdrm/omap_plane.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/omapdrm/

Re: [PATCH 1/2] regmap: Add DSI bus support

2019-07-11 Thread Rob Clark
On Thu, Jul 11, 2019 at 6:11 AM Andrzej Hajda wrote: > > On 06.07.2019 03:06, Mark Brown wrote: > > On Wed, Jul 03, 2019 at 02:45:12PM -0700, Jeffrey Hugo wrote: > >> Add basic support with a simple implementation that utilizes the generic > >> read/write commands to allow device registers to be c

Re: [Intel-gfx] [PATCH v9 1/6] drm: Add Content protection type property

2019-07-11 Thread Sean Paul
On Mon, Jul 08, 2019 at 04:51:11PM +0530, Ramalingam C wrote: > This patch adds a DRM ENUM property to the selected connectors. > This property is used for mentioning the protected content's type > from userspace to kernel HDCP authentication. > > Type of the stream is decided by the protected con

Re: [PATCH 1/2] regmap: Add DSI bus support

2019-07-11 Thread Mark Brown
On Wed, Jul 10, 2019 at 12:08:34PM -0600, Jeffrey Hugo wrote: > On Fri, Jul 5, 2019 at 7:06 PM Mark Brown wrote: > The addresses for these spec defined messages are 8-bit wide, so 256 > valid "destinations". However, the payload is variable. Most of the > defined operations take an 8-bit payloa

Re: [PATCH v2 5/5] drm/edid: Make sure the CEA mode arrays have the correct amount of modes

2019-07-11 Thread Ville Syrjälä
On Thu, Jul 11, 2019 at 01:32:34PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > We depend on a specific relationship between the VIC number and the > index in the CEA mode arrays. Assert that the arrays have the excpected > size to make sure we've not accidentally left holes in them. >

Re: [PATCH 1/2] regmap: Add DSI bus support

2019-07-11 Thread Mark Brown
On Thu, Jul 11, 2019 at 03:11:56PM +0200, Andrzej Hajda wrote: > 1. DSI protocol defines actually more than 30 types of transactions[1], > but this patchset implements only few of them (dsi generic write/read > family). Is it possible to implement multiple types of transactions in > regmap? You c

Re: [PATCH 00/10] Improvements and fixes for mxsfb DRM driver

2019-07-11 Thread Guido Günther
Hi Robert, On Wed, Jun 26, 2019 at 04:32:08PM +0300, Robert Chiras wrote: > This patch-set improves the use of eLCDIF block on iMX 8 SoCs (like 8MQ, 8MM > and 8QXP). Following, are the new features added and fixes from this > patch-set: > > 1. Add support for drm_bridge > On 8MQ and 8MM, the LCDIF

Re: [PATCH 09/60] drm/bridge: Add connector-related bridge operations and data

2019-07-11 Thread Andrzej Hajda
On 11.07.2019 15:18, Daniel Vetter wrote: > On Thu, Jul 11, 2019 at 02:41:01PM +0200, Andrzej Hajda wrote: >> On 11.07.2019 09:35, Daniel Vetter wrote: >>> On Wed, Jul 10, 2019 at 02:12:14PM +0200, Andrzej Hajda wrote: Hi Laurent, I like the approach, current practice when almos

Re: [Intel-gfx] [PATCH v9 3/6] drm: uevent for connector status change

2019-07-11 Thread Sean Paul
On Mon, Jul 08, 2019 at 04:51:13PM +0530, Ramalingam C wrote: > DRM API for generating uevent for a status changes of connector's > property. > > This uevent will have following details related to the status change: > > HOTPLUG=1, CONNECTOR= and PROPERTY= > > Need ACK from this uevent from use

Re: [PATCH 1/5] drm/fb-helper: Include prototype for drm_fb_helper_modinit()

2019-07-11 Thread Sean Paul
On Wed, Jul 10, 2019 at 03:51:39PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Sparse complains: > drivers/gpu/drm/drm_fb_helper.c:2409:12: warning: symbol > 'drm_fb_helper_modinit' was not declared. Should it be static? > > Include the header with the correct prototype. > > Signed-o

Re: [PATCH 2/5] drm/dsc: Fix bogus cpu_to_be16() usage

2019-07-11 Thread Sean Paul
On Wed, Jul 10, 2019 at 03:51:40PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > __be16 = cpu_to_be16(__be16) is nonsense. Do it right. > > ../drivers/gpu/drm/drm_dsc.c:218:53: warning: incorrect type in assignment > (different base types) > ../drivers/gpu/drm/drm_dsc.c:218:53:expec

Re: [PATCH 3/5] drm: Include prototype for drm_need_swiotlb()

2019-07-11 Thread Sean Paul
On Wed, Jul 10, 2019 at 03:51:41PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Sparse is not happy: > ../drivers/gpu/drm/drm_memory.c:159:6: warning: symbol 'drm_need_swiotlb' was > not declared. Should it be static? > > Include the correct header for drm_need_swiotlb() prototype. >

Re: [PATCH 4/5] drm/syncobj: Include the prototype for drm_timeout_abs_to_jiffies()

2019-07-11 Thread Sean Paul
On Wed, Jul 10, 2019 at 03:51:42PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Sparse complains: > ../drivers/gpu/drm/drm_syncobj.c:942:13: warning: symbol > 'drm_timeout_abs_to_jiffies' was not declared. Should it be static? > > Include the correct header with the prototype. > > Sig

Re: [PATCH 5/5] drm: Fix return type of crc .poll()

2019-07-11 Thread Sean Paul
On Wed, Jul 10, 2019 at 03:51:43PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Sparse compains: > ../drivers/gpu/drm/drm_debugfs_crc.c:350:17: warning: incorrect type in > initializer (different base types) > ../drivers/gpu/drm/drm_debugfs_crc.c:350:17:expected restricted __poll_t

Re: [PATCH 09/60] drm/bridge: Add connector-related bridge operations and data

2019-07-11 Thread Daniel Vetter
On Thu, Jul 11, 2019 at 05:12:26PM +0200, Andrzej Hajda wrote: > On 11.07.2019 15:18, Daniel Vetter wrote: > > On Thu, Jul 11, 2019 at 02:41:01PM +0200, Andrzej Hajda wrote: > >> On 11.07.2019 09:35, Daniel Vetter wrote: > >>> On Wed, Jul 10, 2019 at 02:12:14PM +0200, Andrzej Hajda wrote: > Hi

Re: [PATCH v1] drm/modes: Skip invalid cmdline mode

2019-07-11 Thread Dmitry Osipenko
11.07.2019 12:03, Maxime Ripard пишет: > On Wed, Jul 10, 2019 at 06:05:18PM +0300, Dmitry Osipenko wrote: >> 10.07.2019 17:05, Maxime Ripard пишет: >>> On Wed, Jul 10, 2019 at 04:29:19PM +0300, Dmitry Osipenko wrote: This works: diff --git a/drivers/gpu/drm/drm_client_modeset.c

Re: [PATCH 4/5] drm/syncobj: Include the prototype for drm_timeout_abs_to_jiffies()

2019-07-11 Thread Sam Ravnborg
On Thu, Jul 11, 2019 at 11:39:15AM -0400, Sean Paul wrote: > On Wed, Jul 10, 2019 at 03:51:42PM +0300, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Sparse complains: > > ../drivers/gpu/drm/drm_syncobj.c:942:13: warning: symbol > > 'drm_timeout_abs_to_jiffies' was not declared. Should it

[Bug 111111] Corrupted output with vaapi 10 bit -> 8 bit transcoding on AMD RAVEN

2019-07-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=11 Bug ID: 11 Summary: Corrupted output with vaapi 10 bit -> 8 bit transcoding on AMD RAVEN Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux

Re: [PATCH] drm/bridge: ti-sn65dsi86: use dev name for debugfs

2019-07-11 Thread Bjorn Andersson
On Sat 06 Jul 13:31 PDT 2019, Rob Clark wrote: > From: Rob Clark > > This should be more future-proof if we ever encounter a device with two > of these bridges. > > Suggested-by: Laurent Pinchart > Signed-off-by: Rob Clark Reviewed-by: Bjorn Andersson > --- > drivers/gpu/drm/bridge/ti-sn6

Re: [PATCH] drm/msm/phy/dsi_phy: silence -EPROBE_DEFER warnings

2019-07-11 Thread Bjorn Andersson
On Sat 06 Jul 04:11 PDT 2019, Brian Masney wrote: > The following errors show up when booting the Nexus 5: > > msm_dsi_phy fd922a00.dsi-phy: [drm:dsi_phy_driver_probe] *ERROR* > dsi_phy_regulator_init: failed to init regulator, ret=-517 > msm_dsi_phy fd922a00.dsi-phy: [drm:dsi_phy_driver_probe]

Re: [PATCH] drm/bridge: ti-sn65dsi86: use dev name for debugfs

2019-07-11 Thread Laurent Pinchart
Hi Rob, Thank you for the patch. On Sat, Jul 06, 2019 at 01:31:02PM -0700, Rob Clark wrote: > From: Rob Clark > > This should be more future-proof if we ever encounter a device with two > of these bridges. > > Suggested-by: Laurent Pinchart > Signed-off-by: Rob Clark > --- > drivers/gpu/drm

Re: [PATCH v4 16/23] drm/mgag200: Provide ddc symlink in connector sysfs directory

2019-07-11 Thread Thomas Zimmermann
Acked-by: Thomas Zimmermann Am 11.07.19 um 13:26 schrieb Andrzej Pietrasiewicz: > Use the ddc pointer provided by the generic connector. > > Signed-off-by: Andrzej Pietrasiewicz > --- > drivers/gpu/drm/mgag200/mgag200_mode.c | 9 + > 1 file changed, 5 insertions(+), 4 deletions(-) > >

Re: [PATCH v4 17/23] drm/ast: Provide ddc symlink in connector sysfs directory

2019-07-11 Thread Thomas Zimmermann
Acked-by: Thomas Zimmermann Am 11.07.19 um 13:26 schrieb Andrzej Pietrasiewicz: > Use the ddc pointer provided by the generic connector. > > Signed-off-by: Andrzej Pietrasiewicz > --- > drivers/gpu/drm/ast/ast_mode.c | 9 + > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --

Re: [PATCH] drm/bridge: ti-sn65dsi86: use dev name for debugfs

2019-07-11 Thread Rob Clark
On Thu, Jul 11, 2019 at 9:49 AM Laurent Pinchart wrote: > > Hi Rob, > > Thank you for the patch. > > On Sat, Jul 06, 2019 at 01:31:02PM -0700, Rob Clark wrote: > > From: Rob Clark > > > > This should be more future-proof if we ever encounter a device with two > > of these bridges. > > > > Suggest

Re: [PATCH v6 11/22] clk: sunxi-ng: a64: Add minimum rate for PLL_MIPI

2019-07-11 Thread Michael Nazzareno Trimarchi
Hi Maxime On Thu, Jul 11, 2019 at 2:23 PM Maxime Ripard wrote: > > On Fri, Jul 05, 2019 at 07:52:27PM +0200, Michael Nazzareno Trimarchi wrote: > > On Wed, Jul 3, 2019 at 1:49 PM Maxime Ripard > > wrote: > > > > > > On Tue, Jun 25, 2019 at 09:00:36PM +0530, Jagan Teki wrote: > > > > On Tue, Jun

[Bug 110783] Mesa 19.1 rc crashing MPV with VAAPI

2019-07-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110783 AngryPenguin changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [PATCH 1/3] drm/msm: don't open-code governor name

2019-07-11 Thread Jordan Crouse
On Sun, Jun 30, 2019 at 06:14:41AM -0700, Rob Clark wrote: > From: Rob Clark Reviewed-by: Jordan Crouse > Signed-off-by: Rob Clark > --- > drivers/gpu/drm/msm/msm_gpu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/msm/msm_gpu.c b/drivers/gpu/drm/ms

[RFC] Expanding drm_mode_modeinfo flags

2019-07-11 Thread Jeykumar Sankaran
Hello All, drm_mode_modeinfo::flags is a 32 bit field currently used to describe the properties of a connector mode. I see the least order 22 bits are already in use. Posting this RFC to discuss on any potential plans to expand the bit range support of this field for growi

[RFC PATCH] drm: add mode flags in uapi for seamless mode switch

2019-07-11 Thread Jeykumar Sankaran
Add drm mode flag values to expose mode capabilities to perform dynamic seamless mode switch. This change also exposes the backing panel type associated with a mode for panels which can dynamically switch between video and command display modes. Signed-off-by: Jeykumar Sankaran --- include/uapi/

Re: [Freedreno] [PATCH 2/3] drm/msm/dpu: remove dpu_mdss:hwversion

2019-07-11 Thread Jordan Crouse
On Sun, Jun 30, 2019 at 06:14:42AM -0700, Rob Clark wrote: > From: Rob Clark > > Unused and the extra rpm get/put interferes with handover from > bootloader (ie. happens before we have a chance to check if > things are already enabled). Yay for not turning on the hardware before we need to. Rev

Re: [PATCH v5 2/7] drm/panel: simple: Add ability to override typical timing

2019-07-11 Thread Sean Paul
On Wed, Jul 10, 2019 at 6:56 PM Doug Anderson wrote: > > Hi, > > On Mon, Jul 8, 2019 at 10:56 AM Sam Ravnborg wrote: > > > > On Mon, Jul 01, 2019 at 09:39:06AM -0700, Doug Anderson wrote: > > > Hi, > > > > > > On Sun, Jun 30, 2019 at 1:55 PM Sam Ravnborg wrote: > > > > > > > > Hi Douglas. > > >

Re: [PATCH v5 0/7] drm/panel: simple: Add mode support to devicetree

2019-07-11 Thread Sam Ravnborg
Hi Dough. > > So Thierry was able to look at the patches yesterday it seems and has Acked > > all the relevant ones. As a drm-misc-contributor I could also apply them > > myself, but now don't want to preempt any additional comments you might > > have ;-) . So I guess my question would be if you s

Re: [PATCH v6 11/22] clk: sunxi-ng: a64: Add minimum rate for PLL_MIPI

2019-07-11 Thread Michael Nazzareno Trimarchi
Hi On Thu, Jul 11, 2019 at 7:43 PM Michael Nazzareno Trimarchi wrote: > > Hi Maxime > > On Thu, Jul 11, 2019 at 2:23 PM Maxime Ripard > wrote: > > > > On Fri, Jul 05, 2019 at 07:52:27PM +0200, Michael Nazzareno Trimarchi wrote: > > > On Wed, Jul 3, 2019 at 1:49 PM Maxime Ripard > > > wrote: >

  1   2   >