Re: [PATCH] drm/msm/mdp5: Use drm_device for creating gem address space

2019-07-04 Thread Jeffrey Hugo
On Wed, Jul 3, 2019 at 6:25 AM Rob Clark wrote: > > On Tue, Jul 2, 2019 at 9:08 PM Bjorn Andersson > wrote: > > > > On Mon 01 Jul 10:39 PDT 2019, Jeffrey Hugo wrote: > > > > > Creating the msm gem address space requires a reference to the dev where > > > the iommu is located. The driver currentl

Re: [RFC PATCH] mesa: Export BOs in RW mode

2019-07-04 Thread Steven Price
On 03/07/2019 16:59, Rob Herring wrote: > On Wed, Jul 3, 2019 at 8:13 AM Steven Price wrote: >> >> On 03/07/2019 14:56, Boris Brezillon wrote: >>> On Wed, 3 Jul 2019 07:45:32 -0600 >>> Rob Herring wrote: >>> On Wed, Jul 3, 2019 at 7:34 AM Boris Brezillon wrote: > > Exported BOs

[PATCH 1/8] drm/omap: use refcount API to track the number of users of dma_addr

2019-07-04 Thread Jean-Jacques Hiblot
This would give us a WARN_ON() if the pin/unpin calls are unbalanced. Signed-off-by: Jean-Jacques Hiblot --- drivers/gpu/drm/omapdrm/omap_gem.c | 41 +++--- 1 file changed, 20 insertions(+), 21 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/omap_gem.c b/drivers/gpu/dr

Re: [RFC PATCH] mesa: Export BOs in RW mode

2019-07-04 Thread Steven Price
On 03/07/2019 14:56, Boris Brezillon wrote: > On Wed, 3 Jul 2019 07:45:32 -0600 > Rob Herring wrote: > >> On Wed, Jul 3, 2019 at 7:34 AM Boris Brezillon >> wrote: >>> >>> Exported BOs might be imported back, then mmap()-ed to be written >>> too. Most drivers handle that by mmap()-ing the GEM han

[PATCH 1/2] staging: android: ion: Remove file ion_carveout_heap.c

2019-07-04 Thread Nishka Dasgupta
Remove file ion_carveout_heap.c as its functions and definitions are not used anywhere. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/android/ion/Kconfig | 9 -- drivers/staging/android/ion/Makefile | 1 - .../staging/android/ion/ion_carve

[PATCH v2 0/8] drm/omap: OMAP_BO flags

2019-07-04 Thread Jean-Jacques Hiblot
Hi, The first version of this work had been sent by Tomi Valkeinen in may 2017 (https://www.spinics.net/lists/dri-devel/msg140663.html). This series adds a few new OMAP_BO flags to help the userspace manage situations where it needs to use lots of buffers, and would currently run out of TILER sp

[PATCH 4/8] drm/omap: cleanup OMAP_BO flags

2019-07-04 Thread Jean-Jacques Hiblot
From: Tomi Valkeinen Reorder OMAP_BO flags and improve the comments. Signed-off-by: Tomi Valkeinen --- include/uapi/drm/omap_drm.h | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/include/uapi/drm/omap_drm.h b/include/uapi/drm/omap_drm.h index 1fccffef9e27.

Re: [RFC] mm/hmm: pass mmu_notifier_range to sync_cpu_device_pagetables

2019-07-04 Thread Jason Gunthorpe
On Wed, Jul 03, 2019 at 02:27:22AM +, Kuehling, Felix wrote: > On 2019-07-02 6:59 p.m., Jason Gunthorpe wrote: > > On Wed, Jul 03, 2019 at 12:49:12AM +0200, Christoph Hellwig wrote: > >> On Tue, Jul 02, 2019 at 07:53:23PM +, Jason Gunthorpe wrote: > I'm sending this out now since we ar

Re: [PATCH 1/1] drm/amdgpu: adopt to hmm_range_register API change

2019-07-04 Thread Jason Gunthorpe
On Wed, Jul 03, 2019 at 01:55:08AM +, Kuehling, Felix wrote: > From: Philip Yang > > In order to pass mirror instead of mm to hmm_range_register, we need > pass bo instead of ttm to amdgpu_ttm_tt_get_user_pages because mirror > is part of amdgpu_mn structure, which is accessible from bo. > >

[PATCH 3/7] drm/amd/powerplay: Use proper enums in smu_adjust_power_state_dynamic

2019-07-04 Thread Nathan Chancellor
clang warns: drivers/gpu/drm/amd/amdgpu/../powerplay/amdgpu_smu.c:1374:30: warning: implicit conversion from enumeration type 'enum pp_clock_type' to different enumeration type 'enum smu_clk_type' [-Wenum-conversion] smu_force_clk_levels(smu, PP_SCLK, 1 << sclk_mask);

[PATCH 2/2] staging: android: ion: Remove file ion_chunk_heap.c

2019-07-04 Thread Nishka Dasgupta
Remove file ion_chunk_heap.c as its functions and definitions are not used anywhere else. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/android/ion/Kconfig | 9 -- drivers/staging/android/ion/Makefile | 1 - drivers/staging/android/ion/ion_c

[PATCH v2 07/35] drm/amdgpu: Use kmemdup rather than duplicating its implementation

2019-07-04 Thread Fuqian Huang
kmemdup is introduced to duplicate a region of memory in a neat way. Rather than kmalloc/kzalloc + memcpy, which the programmer needs to write the size twice (sometimes lead to mistakes), kmemdup improves readability, leads to smaller code and also reduce the chances of mistakes. Suggestion to use

[PATCH 3/8] drm/omap: accept NULL for dma_addr in omap_gem_pin

2019-07-04 Thread Jean-Jacques Hiblot
From: Tomi Valkeinen Allow NULL to be passed in 'dma_addr' for omap_gem_pin(), in case the caller does not need the dma_addr. Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/omap_gem.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/o

[PATCH 1/7] drm/amdgpu/mes10.1: Fix header guard

2019-07-04 Thread Nathan Chancellor
clang warns: In file included from drivers/gpu/drm/amd/amdgpu/nv.c:53: drivers/gpu/drm/amd/amdgpu/../amdgpu/mes_v10_1.h:24:9: warning: '__MES_V10_1_H__' is used as a header guard here, followed by #define of a different macro [-Wheader-guard] #ifndef __MES_V10_1_H__ ^~~

[PATCH 6/7] drm/amd/powerplay: Use proper enums in vega20_print_clk_levels

2019-07-04 Thread Nathan Chancellor
clang warns: drivers/gpu/drm/amd/amdgpu/../powerplay/vega20_ppt.c:995:39: warning: implicit conversion from enumeration type 'PPCLK_e' to different enumeration type 'enum smu_clk_type' [-Wenum-conversion] ret = smu_get_current_clk_freq(smu, PPCLK_SOCCLK, &now);

[PATCH 5/7] drm/amd/display: Use proper enum conversion functions

2019-07-04 Thread Nathan Chancellor
clang warns: drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_pp_smu.c:336:8: warning: implicit conversion from enumeration type 'enum smu_clk_type' to different enumeration type 'enum amd_pp_clock_type' [-Wenum-conversion] dc_to_smu_clock_type(clk_

Re: [PATCH 22/22] mm: remove the legacy hmm_pfn_* APIs

2019-07-04 Thread Jason Gunthorpe
On Wed, Jul 03, 2019 at 08:03:08PM +0200, Christoph Hellwig wrote: > On Wed, Jul 03, 2019 at 03:01:25PM -0300, Jason Gunthorpe wrote: > > Christoph, I guess you didn't mean to send this branch to the mailing > > list? > > > > In any event some of these, like this one, look obvious and I could > >

Re: [PATCH 18/22] mm: return valid info from hmm_range_unregister

2019-07-04 Thread Ralph Campbell
On 6/30/19 11:20 PM, Christoph Hellwig wrote: Checking range->valid is trivial and has no meaningful cost, but nicely simplifies the fastpath in typical callers. Also remove the hmm_vma_range_done function, which now is a trivial wrapper around hmm_range_unregister. Signed-off-by: Christoph He

[PATCH 5/8] drm/omap: remove OMAP_BO_TILED define

2019-07-04 Thread Jean-Jacques Hiblot
From: Tomi Valkeinen OMAP_BO_TILED does not make sense, as OMAP_BO_TILED_* values are not bitmasks but normal values. As we already have OMAP_BO_TILED_MASK for the mask, we can remove OMAP_BO_TILED and use OMAP_BO_TILED_MASK instead. Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/om

Re: Why is Thunderbolt 3 limited to 2.5 GT/s on Linux?

2019-07-04 Thread Timur Kristóf
> > Okay, so I booted my system with amdgpu.benchmark=3 > > You can find the full dmesg log here: https://pastebin.com/zN9FYGw4 > > > > The result is between 1-5 Gbit / sec depending on the transfer size > > (the higher the better), which corresponds to neither the 8 Gbit / > > sec > > that the k

[PATCH v5 4/4] drm/mtk: add panel orientation property

2019-07-04 Thread Derek Basehore
This inits the panel orientation property for the mediatek dsi driver if the panel orientation (connector.display_info.panel_orientation) is not DRM_MODE_PANEL_ORIENTATION_UNKNOWN. Signed-off-by: Derek Basehore --- drivers/gpu/drm/mediatek/mtk_dsi.c | 8 1 file changed, 8 insertions(+)

[PATCH 2/7] drm/amd/powerplay: Use memset to initialize metrics structs

2019-07-04 Thread Nathan Chancellor
clang warns: drivers/gpu/drm/amd/amdgpu/../powerplay/navi10_ppt.c:601:33: warning: suggest braces around initialization of subobject [-Wmissing-braces] static SmuMetrics_t metrics = {0}; ^ {} drivers/gpu/drm/amd/

[PATCH 06/30] drm/amdgpu: Use kmemdup rather than duplicating its implementation

2019-07-04 Thread Fuqian Huang
kmemdup is introduced to duplicate a region of memory in a neat way. Rather than kmalloc/kzalloc + memset, which the programmer needs to write the size twice (sometimes lead to mistakes), kmemdup improves readability, leads to smaller code and also reduce the chances of mistakes. Suggestion to use

[PATCH 2/8] drm/omap: add omap_gem_unpin_locked()

2019-07-04 Thread Jean-Jacques Hiblot
From: Tomi Valkeinen Add omap_gem_unpin_locked() which is a version of omap_gem_unpin() that expects the caller to hold the omap_obj lock. Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/omap_gem.c | 25 ++--- 1 file changed, 18 insertions(+), 7 deletions(-) diff

[PATCH 7/7] drm/amd/powerplay: Zero initialize current_rpm in vega20_get_fan_speed_percent

2019-07-04 Thread Nathan Chancellor
clang warns (trimmed for brevity): drivers/gpu/drm/amd/amdgpu/../powerplay/vega20_ppt.c:3023:8: warning: variable 'current_rpm' is used uninitialized whenever '?:' condition is false [-Wsometimes-uninitialized] ret = smu_get_current_rpm(smu, ¤t_rpm); ^

Re: [RFC PATCH] mesa: Export BOs in RW mode

2019-07-04 Thread Steven Price
On 03/07/2019 15:33, Boris Brezillon wrote: > On Wed, 3 Jul 2019 15:13:25 +0100 > Steven Price wrote: > >> On 03/07/2019 14:56, Boris Brezillon wrote: >>> On Wed, 3 Jul 2019 07:45:32 -0600 >>> Rob Herring wrote: >>> On Wed, Jul 3, 2019 at 7:34 AM Boris Brezillon wrote: >

[PATCH 8/8] drm/omap: add OMAP_BO flags to affect buffer allocation

2019-07-04 Thread Jean-Jacques Hiblot
From: Tomi Valkeinen On SoCs with DMM/TILER, we have two ways to allocate buffers: normal dma_alloc or via DMM (which basically functions as an IOMMU). DMM can map 128MB at a time, and we only map the DMM buffers when they are used (i.e. not at alloc time). If DMM is present, omapdrm always uses

[PATCH v5 2/4] drm/panel: set display info in panel attach

2019-07-04 Thread Derek Basehore
Devicetree systems can set panel orientation via a panel binding, but there's no way, as is, to propagate this setting to the connector, where the property need to be added. To address this, this patch sets orientation, as well as other fixed values for the panel, in the drm_panel_attach function.

Re: [PATCH 1/2] staging: android: ion: Remove file ion_carveout_heap.c

2019-07-04 Thread Nishka Dasgupta
On 03/07/19 2:07 PM, Greg KH wrote: On Wed, Jul 03, 2019 at 01:48:41PM +0530, Nishka Dasgupta wrote: Remove file ion_carveout_heap.c as its functions and definitions are not used anywhere. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/android/ion/Kconfig

[PATCH 4/7] drm/amd/powerplay: Zero initialize freq in smu_v11_0_get_current_clk_freq

2019-07-04 Thread Nathan Chancellor
clang warns (trimmed for brevity): drivers/gpu/drm/amd/amdgpu/../powerplay/smu_v11_0.c:1098:10: warning: variable 'freq' is used uninitialized whenever '?:' condition is false [-Wsometimes-uninitialized] ret = smu_get_current_clk_freq_by_table(smu, clk_id, &freq);

Re: [PATCH 1/1] drm/amdgpu: adopt to hmm_range_register API change

2019-07-04 Thread Jason Gunthorpe
On Wed, Jul 03, 2019 at 05:09:16PM -0400, Alex Deucher wrote: > On Wed, Jul 3, 2019 at 5:03 PM Kuehling, Felix wrote: > > > > On 2019-07-03 10:10 a.m., Jason Gunthorpe wrote: > > > On Wed, Jul 03, 2019 at 01:55:08AM +, Kuehling, Felix wrote: > > >> From: Philip Yang > > >> > > >> In order to

[Patch v2 03/10] drm/omapdrm: using dev_get_drvdata directly

2019-07-04 Thread Fuqian Huang
Several drivers cast a struct device pointer to a struct platform_device pointer only to then call platform_get_drvdata(). To improve readability, these constructs can be simplified by using dev_get_drvdata() directly. Signed-off-by: Fuqian Huang --- Changes in v2: - Make the commit message mor

Re: [PATCH 1/5] mm: return valid info from hmm_range_unregister

2019-07-04 Thread Jason Gunthorpe
On Wed, Jul 03, 2019 at 11:44:58AM -0700, Christoph Hellwig wrote: > Checking range->valid is trivial and has no meaningful cost, but > nicely simplifies the fastpath in typical callers. It should not be the typical caller.. > hmm_vma_range_done function, which now is a trivial wrapper around >

Re: [PATCH 20/22] mm: move hmm_vma_fault to nouveau

2019-07-04 Thread Jason Gunthorpe
On Mon, Jul 01, 2019 at 08:20:18AM +0200, Christoph Hellwig wrote: > hmm_vma_fault is marked as a legacy API to get rid of, but quite suites > the current nouvea flow. Move it to the only user in preparation for > fixing a locking bug involving caller and callee. > > Signed-off-by: Christoph Hell

[PATCH 0/7] amdgpu clang warning fixes on next-20190703

2019-07-04 Thread Nathan Chancellor
Hi all, I don't do threaded patches very often so if I have messed something up, please forgive me :) This series fixes all of the clang warnings that I saw added in next-20190703. The full list is visible in the gist linked below and each full individual warning can be seen in the GitHub link in

Re: [PATCH 20/22] mm: move hmm_vma_fault to nouveau

2019-07-04 Thread Jason Gunthorpe
On Wed, Jul 03, 2019 at 08:05:25PM +0200, Christoph Hellwig wrote: > On Wed, Jul 03, 2019 at 03:03:56PM -0300, Jason Gunthorpe wrote: > > I was thinking about doing exactly this too, but amdgpu started using > > this already obsolete API in their latest driver :( > > > > So, we now need to get bot

Re: [PATCH 4/5] nouveau: unlock mmap_sem on all errors from nouveau_range_fault

2019-07-04 Thread Ralph Campbell
On 7/3/19 11:45 AM, Christoph Hellwig wrote: Currently nouveau_svm_fault expects nouveau_range_fault to never unlock mmap_sem, but the latter unlocks it for a random selection of error codes. Fix this up by always unlocking mmap_sem for non-zero return values in nouveau_range_fault, and only unl

Re: [RFC PATCH] mesa: Export BOs in RW mode

2019-07-04 Thread Alyssa Rosenzweig
> Since the same discussion is happening with etnaviv: Why exactly does mesa > need to mmap imported buffers? The golden question! Seemingly, (one of the) reasons is that the state tracker does colourspace conversion in software if the winsys wants a format that the driver doesn't advertise. Unre

Re: [PATCH 22/22] mm: remove the legacy hmm_pfn_* APIs

2019-07-04 Thread Jason Gunthorpe
On Mon, Jul 01, 2019 at 08:20:20AM +0200, Christoph Hellwig wrote: > Switch the one remaining user in nouveau over to its replacement, > and remove all the wrappers. > > Signed-off-by: Christoph Hellwig > drivers/gpu/drm/nouveau/nouveau_dmem.c | 2 +- > include/linux/hmm.h|

Re: [PATCH 1/5] mm: return valid info from hmm_range_unregister

2019-07-04 Thread Jason Gunthorpe
On Wed, Jul 03, 2019 at 10:28:57PM +0200, Christoph Hellwig wrote: > On Wed, Jul 03, 2019 at 07:00:50PM +, Jason Gunthorpe wrote: > > I don't think the API should be encouraging some shortcut here.. > > > > We can't do the above pattern because the old hmm_vma API didn't allow > > it, which is

Re: [PATCH 5/5] mm: remove the legacy hmm_pfn_* APIs

2019-07-04 Thread Ralph Campbell
On 7/3/19 11:45 AM, Christoph Hellwig wrote: Switch the one remaining user in nouveau over to its replacement, and remove all the wrappers. Signed-off-by: Christoph Hellwig Reviewed-by: Jason Gunthorpe Reviewed-by: Ralph Campbell --- drivers/gpu/drm/nouveau/nouveau_dmem.c | 2 +- inc

[PATCH v2 08/35] drm/i915: Use kmemdup rather than duplicating its implementation

2019-07-04 Thread Fuqian Huang
kmemdup is introduced to duplicate a region of memory in a neat way. Rather than kmalloc/kzalloc + memcpy, which the programmer needs to write the size twice (sometimes lead to mistakes), kmemdup improves readability, leads to smaller code and also reduce the chances of mistakes. Suggestion to use

Re: [PATCH 19/22] mm: always return EBUSY for invalid ranges in hmm_range_{fault,snapshot}

2019-07-04 Thread Ralph Campbell
On 6/30/19 11:20 PM, Christoph Hellwig wrote: We should not have two different error codes for the same condition. In addition this really complicates the code due to the special handling of EAGAIN that drops the mmap_sem due to the FAULT_FLAG_ALLOW_RETRY logic in the core vm. Signed-off-by: C

[PATCH 1/1] Drop unused return value to build_power_updown_phy

2019-07-04 Thread Maya Rashish
--- drivers/gpu/drm/drm_dp_mst_topology.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b/drivers/gpu/drm/drm_dp_mst_topology.c index 0984b9a34d55..514ef4eb3f42 100644 --- a/drivers/gpu/drm/drm_dp_mst_topology.c +++ b/drivers/gpu/

Re: [PATCH 1/1] drm/amdgpu: adopt to hmm_range_register API change

2019-07-04 Thread Jason Gunthorpe
On Thu, Jul 04, 2019 at 09:11:33AM +1000, Dave Airlie wrote: > On Thu, 4 Jul 2019 at 07:32, Stephen Rothwell wrote: > > > > Hi Alex, > > > > On Wed, 3 Jul 2019 17:09:16 -0400 Alex Deucher > > wrote: > > > > > > Go ahead and respin your patch as per the suggestion above. then I > > > can apply i

[PATCH 6/8] drm/omap: cleanup OMAP_BO_SCANOUT use

2019-07-04 Thread Jean-Jacques Hiblot
From: Tomi Valkeinen omap_gem_new() has a comment about OMAP_BO_SCANOUT which does not make sense. Also, for the TILER case, we drop OMAP_BO_SCANOUT flag for some reason. It's not clear what the original purpose of OMAP_BO_SCANOUT is, but presuming it means "scanout buffer, something that can be

Re: linux-next: Tree for Jul 3 (amdgpu)

2019-07-04 Thread Randy Dunlap
On 7/3/19 4:49 AM, Stephen Rothwell wrote: > Hi all, > > Changes since 20190702: > on i386 or x86_64: ERROR: "dm_ip_block" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined! or ld: drivers/gpu/drm/amd/amdgpu/nv.o: in function `nv_set_ip_blocks': nv.c:(.text+0x1660): undefined reference to `dm_i

[PATCH] drm/client: remove the exporting of drm_client_close

2019-07-04 Thread Denis Efremov
The function drm_client_close is declared as static and marked as EXPORT_SYMBOL. It's a bit confusing for an internal function to be exported. The area of visibility for such function is its .c file and all other modules. Other *.c files of the same module can't use it, despite all other modules ca

[PATCH 1/2] regmap: Add DSI bus support

2019-07-04 Thread Jeffrey Hugo
Add basic support with a simple implementation that utilizes the generic read/write commands to allow device registers to be configured. Signed-off-by: Jeffrey Hugo --- drivers/base/regmap/Kconfig | 6 +++- drivers/base/regmap/Makefile | 1 + drivers/base/regmap/regmap-dsi.c | 62

[Patch v2 04/10] drm/panfrost: using dev_get_drvdata directly

2019-07-04 Thread Fuqian Huang
Several drivers cast a struct device pointer to a struct platform_device pointer only to then call platform_get_drvdata(). To improve readability, these constructs can be simplified by using dev_get_drvdata() directly. Signed-off-by: Fuqian Huang --- Changes in v2: - Make the commit message mor

[PATCH 7/8] drm/omap: add omap_gem_validate_flags()

2019-07-04 Thread Jean-Jacques Hiblot
From: Tomi Valkeinen Add a helper function omap_gem_validate_flags() which validates the omap_bo flags passed from the userspace. Also drop the dev_err() message, as the userspace can cause that at will. Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/omap_gem.c | 40 +++

Re: [PATCH 20/22] mm: move hmm_vma_fault to nouveau

2019-07-04 Thread Ralph Campbell
On 6/30/19 11:20 PM, Christoph Hellwig wrote: hmm_vma_fault is marked as a legacy API to get rid of, but quite suites the current nouvea flow. Move it to the only user in preparation for I didn't quite parse the phrase "quite suites the current nouvea flow." s/nouvea/nouveau/ fixing a locki

Re: [PATCH 1/5] drm/client: Support unmapping of DRM client buffers

2019-07-04 Thread Thomas Zimmermann
Hi Am 03.07.19 um 16:07 schrieb Noralf Trønnes: > > > Den 03.07.2019 10.32, skrev Thomas Zimmermann: >> DRM clients, such as the fbdev emulation, have their buffer objects >> mapped by default. Mapping a buffer implicitly prevents its relocation. >> Hence, the buffer may permanently consume vide

Re: [PATCH v1 04/33] drm/tve200: drop use of drmP.h

2019-07-04 Thread Linus Walleij
On Sun, Jun 30, 2019 at 8:19 AM Sam Ravnborg wrote: > Drop use of the deprecated header drmP.h. > > Fix so header file became self-contained, > and then fixed fallout in the other files. > > Signed-off-by: Sam Ravnborg > Cc: Linus Walleij > Cc: David Airlie > Cc: Daniel Vetter Reviewed-by: L

Re: [PATCH 0/5] Unmappable DRM client buffers for fbdev emulation

2019-07-04 Thread Thomas Zimmermann
Hi Am 03.07.19 um 21:27 schrieb Noralf Trønnes: > > > Den 03.07.2019 10.32, skrev Thomas Zimmermann: >> DRM client buffers are permanently mapped throughout their lifetime. This >> prevents us from using generic framebuffer emulation for devices with >> small dedicated video memory, such as ast

Re: [PATCH -next] drm/bridge: sii902x: Make sii902x_audio_digital_mute static

2019-07-04 Thread Andrzej Hajda
On 14.06.2019 17:36, YueHaibing wrote: > Fix sparse warning: > > drivers/gpu/drm/bridge/sii902x.c:665:5: warning: > symbol 'sii902x_audio_digital_mute' was not declared. Should it be static? > > Reported-by: Hulk Robot > Signed-off-by: YueHaibing > --- > drivers/gpu/drm/bridge/sii902x.c | 3 ++-

[Bug 105190] gem_quiescent_gpu assertion fails on distribution kernels

2019-07-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105190 --- Comment #10 from emersion --- Alternatively, it's possible to use a vanilla kernel: https://fedoraproject.org/wiki/Kernel_Vanilla_Repositories -- You are receiving this mail because: You are the assignee for the bug.___

Re: [PATCH 1/3] drm/bridge: sii902x: fix missing reference to mclk clock

2019-07-04 Thread Jyri Sarha
On 02/07/2019 18:47, Olivier Moysan wrote: > Add devm_clk_get call to retrieve reference to master clock. > > Fixes: ff5781634c41 ("drm/bridge: sii902x: Implement HDMI audio support") > > Signed-off-by: Olivier Moysan Reviewed-by: Jyri Sarha I wonder how that line was dropped and how the code

[Bug 111058] how to solve server problem

2019-07-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111058 Bug ID: 111058 Summary: how to solve server problem Product: DRI Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priori

[Bug 111058] how to solve server problem

2019-07-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111058 Shri ram jee changed: What|Removed |Added Alias||shri, ram, jee URL|

Re: [PATCH 1/2] iommu: add support for drivers that manage iommu explicitly

2019-07-04 Thread Joerg Roedel
Hi Rob, On Tue, Jul 02, 2019 at 01:26:18PM -0700, Rob Clark wrote: > 1) In some cases the bootloader takes the iommu out of bypass and >enables the display. This is in particular a problem on the aarch64 >laptops that exist these days, and modern snapdragon android devices. >(Older de

Re: [PATCH 2/3] dt-bindings: display: sii902x: Change audio mclk binding

2019-07-04 Thread Jyri Sarha
On 02/07/2019 18:47, Olivier Moysan wrote: > As stated in SiL9022/24 datasheet, master clock is not required for I2S. > Make mclk property optional in DT bindings. > > Fixes: 3f18021f43a3 ("dt-bindings: display: sii902x: Add HDMI audio bindings") > > Signed-off-by: Olivier Moysan Looking the sp

Re: Why is Thunderbolt 3 limited to 2.5 GT/s on Linux?

2019-07-04 Thread Michel Dänzer
On 2019-07-03 1:04 p.m., Timur Kristóf wrote: > >>> There may be other factors, yes. I can't offer a good explanation >>> on >>> what exactly is happening, but it's pretty clear that amdgpu can't >>> take >>> full advantage of the TB3 link, so it seemed like a good idea to >>> start >>> investigat

Re: [PATCH 3/3] drm/bridge: sii902x: make audio mclk optional

2019-07-04 Thread Jyri Sarha
On 02/07/2019 18:47, Olivier Moysan wrote: > The master clock on i2s bus is not mandatory, > as sii902X internal PLL can be used instead. > Make use of mclk optional. > > Fixes: ff5781634c41 ("drm/bridge: sii902x: Implement HDMI audio support") > > Signed-off-by: Olivier Moysan Reviewed-by: Jyr

Re: [PATCH] drm/doc: Document kapi doc expectations

2019-07-04 Thread Daniel Vetter
On Tue, Jun 25, 2019 at 10:36:44PM +0200, Daniel Vetter wrote: > We've had this already for anything new. With my drm_prime.c cleanup I > also think documentations for everything already existing is complete, > and we can bake this in as a requirements subsystem wide. > > Acked-by: Jani Nikula >

[PATCH 00/11] Platform drivers, provide a way to add sysfs groups easily

2019-07-04 Thread Greg Kroah-Hartman
If a platform driver wants to add a sysfs group, it has to do so in a racy way, adding it after the driver is bound. To resolve this issue, have the platform driver core do this for the driver, making the individual drivers logic smaller and simpler, and solving the race at the same time. All of

[PATCH 10/11] input: keyboard: gpio_keys: convert platform driver to use dev_groups

2019-07-04 Thread Greg Kroah-Hartman
Platform drivers now have the option to have the platform core create and remove any needed sysfs attribute files. So take advantage of that and do not register "by hand" a bunch of sysfs files. Cc: Bartlomiej Zolnierkiewicz Cc: dri-devel@lists.freedesktop.org Cc: linux-fb...@vger.kernel.org Sig

[PATCH 09/11] video: fbdev: sm501fb: convert platform driver to use dev_groups

2019-07-04 Thread Greg Kroah-Hartman
Platform drivers now have the option to have the platform core create and remove any needed sysfs attribute files. So take advantage of that and do not register "by hand" a bunch of sysfs files. Cc: Bartlomiej Zolnierkiewicz Cc: dri-devel@lists.freedesktop.org Cc: linux-fb...@vger.kernel.org Sig

[PATCH 08/11] video: fbdev: w100fb: convert platform driver to use dev_groups

2019-07-04 Thread Greg Kroah-Hartman
Platform drivers now have the option to have the platform core create and remove any needed sysfs attribute files. So take advantage of that and do not register "by hand" a bunch of sysfs files. Cc: Tony Prisk Cc: Bartlomiej Zolnierkiewicz Cc: linux-arm-ker...@lists.infradead.org Cc: dri-devel@

[PATCH] drm/vkms: prime import support

2019-07-04 Thread Oleg Vasilev
Bring dmabuf sharing through implementing prime_import_sg_table callback. This will help to validate userspace conformance in prime configurations without using any actual hardware (e.g. in the cloud). Cc: Rodrigo Siqueira Cc: Haneen Mohammed Cc: Daniel Vetter Signed-off-by: Oleg Vasilev ---

Re: [PATCH v5 08/12] dt-bindings: mediatek: Change the binding for mmsys clocks

2019-07-04 Thread Matthias Brugger
Hi CK-Hu, On 01/07/2019 05:55, CK Hu wrote: > Hi, Matthias: > > On Fri, 2018-11-30 at 16:59 +0800, Matthias Brugger wrote: >> >> On 30/11/2018 07:43, Stephen Boyd wrote: >>> Quoting Matthias Brugger (2018-11-21 09:09:52) On 21/11/2018 17:46, Stephen Boyd wrote: > Quoting Rob He

Re: [Mesa-dev] [RFC PATCH] mesa: Export BOs in RW mode

2019-07-04 Thread Daniel Vetter
On Thu, Jul 4, 2019 at 11:26 AM Steven Price wrote: > > On 03/07/2019 17:18, Daniel Vetter wrote: > > On Wed, Jul 3, 2019 at 6:11 PM Steven Price wrote: > [...] > >> In theory the exporter should do whatever is required to ensure that the > >> CPU is synchronised when a user space mapping exists.

[Bug 111060] Dying Light does start but doesnt render properly.

2019-07-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111060 Bug ID: 111060 Summary: Dying Light does start but doesnt render properly. Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity: norma

[Bug 111060] Dying Light does start but doesnt render properly.

2019-07-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111060 --- Comment #1 from Haxk20 --- Ohhh and when using Proton the game works perfectly fine without any issue just with much lower FPS. -- You are receiving this mail because: You are the assignee for the bug.__

Re: [PATCH 0/5] Unmappable DRM client buffers for fbdev emulation

2019-07-04 Thread Noralf Trønnes
Den 04.07.2019 09.43, skrev Thomas Zimmermann: > Hi > > Am 03.07.19 um 21:27 schrieb Noralf Trønnes: >> >> >> Den 03.07.2019 10.32, skrev Thomas Zimmermann: >>> DRM client buffers are permanently mapped throughout their lifetime. This >>> prevents us from using generic framebuffer emulation for

Re: [PATCH v1] drm/etnaviv: drop use of drmP.h

2019-07-04 Thread Lucas Stach
Hi Sam. Am Sonntag, den 30.06.2019, 07:21 +0200 schrieb Sam Ravnborg: > Drop use of the deprecated drmP.h header file. > Fix fallout in all .c files. > > The etnaviv_drv.h header file was made self-contained, > and missing includes was then added to the .c files that needed them. > In a few cases

Re: [PATCH] drm/etnaviv: Use devm_platform_ioremap_resource()

2019-07-04 Thread Lucas Stach
Am Mittwoch, den 05.06.2019, 14:57 -0300 schrieb Fabio Estevam: > Use devm_platform_ioremap_resource() to simplify the code a bit. > > Signed-off-by: Fabio Estevam Thanks, applied. Regards, Lucas > --- >  drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 4 +--- >  1 file changed, 1 insertion(+), 3 delet

[PATCH -next] drm/i915: fix possible memory leak in intel_hdcp_auth_downstream()

2019-07-04 Thread Wei Yongjun
'ksv_fifo' is malloced in intel_hdcp_auth_downstream() and should be freed before leaving from the error handling cases, otherwise it will cause memory leak. Signed-off-by: Wei Yongjun --- drivers/gpu/drm/i915/display/intel_hdcp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --g

[PATCH] drm/etnaviv: clean up includes

2019-07-04 Thread Lucas Stach
Drop unused includes, move more includes from the generic etnaviv_drv.h to the units where they are actually used, sort includes. Signed-off-by: Lucas Stach --- drivers/gpu/drm/etnaviv/etnaviv_drv.c| 1 + drivers/gpu/drm/etnaviv/etnaviv_drv.h| 8 drivers/gpu/drm/etnaviv/

[GIT PULL] drm/imx: fix stale vblank timestamp after a modeset

2019-07-04 Thread Philipp Zabel
Hi Dave, Daniel, please consider merging these imx-drm fixes for v5.2. regards Philipp The following changes since commit 4b972a01a7da614b4796475f933094751a295a2f: Linux 5.2-rc6 (2019-06-22 16:01:36 -0700) are available in the git repository at: git://git.pengutronix.de/git/pza/linux.git

Re: [PATCH v7 04/11] drm: revocation check at drm subsystem

2019-07-04 Thread Pekka Paalanen
On Tue, 7 May 2019 21:57:38 +0530 Ramalingam C wrote: > On every hdcp revocation check request SRM is read from fw file > /lib/firmware/display_hdcp_srm.bin > > SRM table is parsed and stored at drm_hdcp.c, with functions exported > for the services for revocation check from drivers (which > im

Re: [PATCH] drm: allow render capable master with DRM_AUTH ioctls

2019-07-04 Thread Michel Dänzer
On 2019-07-03 7:10 p.m., Emil Velikov wrote: > From: Emil Velikov > > There are cases (in mesa and applications) where one would open the > primary node without properly authenticating the client. > > Sometimes we don't check if the authentication succeeds, but there's > also cases we simply for

Re: [PATCH] drm/komeda: Adds VRR support

2019-07-04 Thread james qian wang (Arm Technology China)
On Wed, Jul 03, 2019 at 12:01:49PM +0200, Daniel Vetter wrote: > On Wed, Jul 03, 2019 at 07:26:16AM +, Lowry Li (Arm Technology China) > wrote: > > Adds a new drm property "vrr" and "vrr_enable" and implemented > > the set/get functions, through which userspace could set vfp > > data to komeda

[Bug 111061] Most shaders in no mans sky fail to compile.

2019-07-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111061 --- Comment #1 from Haxk20 --- mesa from git and LLVM from git too. Tried with nir enabled and it still fails. -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel m

[Bug 111061] Most shaders in no mans sky fail to compile.

2019-07-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111061 Bug ID: 111061 Summary: Most shaders in no mans sky fail to compile. Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity: normal

Re: [PATCH v6 07/18] drm/virtio: add virtio_gpu_object_array & helpers

2019-07-04 Thread Gerd Hoffmann
> > + for (i = 0; i < nents; i++) { > > + objs->nents = i; > This line can be moved into the if-block just below. > > + objs->objs[i] = drm_gem_object_lookup(drm_file, handles[i]); > > + if (!objs->objs[i]) { > > + virtio_gpu_arr

Re: [PATCH v7 09/11] drm: uevent for connector status change

2019-07-04 Thread Pekka Paalanen
On Tue, 7 May 2019 21:57:43 +0530 Ramalingam C wrote: > DRM API for generating uevent for a status changes of connector's > property. > > This uevent will have following details related to the status change: > > HOTPLUG=1, CONNECTOR= and PROPERTY= > > Need ACK from this uevent from userspac

Re: [PATCH v7 07/11] drm: Add Content protection type property

2019-07-04 Thread Pekka Paalanen
On Tue, 7 May 2019 21:57:41 +0530 Ramalingam C wrote: > This patch adds a DRM ENUM property to the selected connectors. > This property is used for mentioning the protected content's type > from userspace to kernel HDCP authentication. > > Type of the stream is decided by the protected content

Re: [PATCH 0/5] Unmappable DRM client buffers for fbdev emulation

2019-07-04 Thread Thomas Zimmermann
Hi Am 04.07.19 um 12:18 schrieb Noralf Trønnes: > > > Den 04.07.2019 09.43, skrev Thomas Zimmermann: >> Hi >> >> Am 03.07.19 um 21:27 schrieb Noralf Trønnes: >>> >>> >>> Den 03.07.2019 10.32, skrev Thomas Zimmermann: DRM client buffers are permanently mapped throughout their lifetime. This

Re: [PATCH v6 06/18] drm/virtio: remove ttm calls from in virtio_gpu_object_{reserve,unreserve}

2019-07-04 Thread Gerd Hoffmann
Hi, > > - r = ttm_bo_reserve(&bo->tbo, true, false, NULL); > > + r = reservation_object_lock_interruptible(bo->gem_base.resv, NULL); > Can you elaborate a bit about how TTM keeps the BOs alive in, for > example, virtio_gpu_transfer_from_host_ioctl? In that function, only > three TTM

Re: [PATCH v7 10/11] drm/hdcp: update content protection property with uevent

2019-07-04 Thread Pekka Paalanen
On Tue, 7 May 2019 21:57:44 +0530 Ramalingam C wrote: > drm function is defined and exported to update a connector's > content protection property state and to generate a uevent along > with it. > > Need ACK for the uevent from userspace consumer. > > v2: > Update only when state is differen

Re: [PATCH v6 07/18] drm/virtio: add virtio_gpu_object_array & helpers

2019-07-04 Thread Gerd Hoffmann
> > > +int virtio_gpu_array_lock_resv(struct virtio_gpu_object_array *objs) > > > +{ > > > + return drm_gem_lock_reservations(objs->objs, objs->nents, > > > +&objs->ticket); > Unlike in other drivers where an "object array" is only needed in > execbuffe

Re: [PATCH v6 08/18] drm/virtio: rework virtio_gpu_execbuffer_ioctl fencing

2019-07-04 Thread Gerd Hoffmann
Hi, > > if (fence) > > virtio_gpu_fence_emit(vgdev, hdr, fence); > > + if (vbuf->objs) { > > + virtio_gpu_array_add_fence(vbuf->objs, &fence->f); > > + virtio_gpu_array_unlock_resv(vbuf->objs); > > + } > This is with the spinlock he

Re: [PATCH v6 14/18] drm/virtio: rework virtio_gpu_transfer_from_host_ioctl fencing

2019-07-04 Thread Gerd Hoffmann
On Wed, Jul 03, 2019 at 01:05:12PM -0700, Chia-I Wu wrote: > On Tue, Jul 2, 2019 at 7:19 AM Gerd Hoffmann wrote: > > > > Switch to the virtio_gpu_array_* helper workflow. > (just repeating my question on patch 6) > > Does this fix the obj refcount issue? When was the issue introduced? obj refco

Re: [PATCH v6 15/18] drm/virtio: rework virtio_gpu_transfer_to_host_ioctl fencing

2019-07-04 Thread Gerd Hoffmann
Hi, > > convert_to_hw_box(&box, &args->box); > > if (!vgdev->has_virgl_3d) { > > virtio_gpu_cmd_transfer_to_host_2d > > - (vgdev, qobj, offset, > > + (vgdev, gem_to_virtio_gpu_obj(objs->objs[0]), > > offset, > >

Re: [PATCH v6 16/18] drm/virtio: rework virtio_gpu_cmd_context_{attach,detach}_resource

2019-07-04 Thread Gerd Hoffmann
On Tue, Jul 02, 2019 at 05:08:46PM -0700, Gurchetan Singh wrote: > On Tue, Jul 2, 2019 at 7:19 AM Gerd Hoffmann wrote: > > > Switch to the virtio_gpu_array_* helper workflow. > > > > Signed-off-by: Gerd Hoffmann > > --- > > drivers/gpu/drm/virtio/virtgpu_drv.h | 4 ++-- > > drivers/gpu/drm/vir

Re: [PATCH 1/3] drm/bridge: ti-sn65dsi86: add link to datasheet

2019-07-04 Thread Andrzej Hajda
On 02.07.2019 17:44, Rob Clark wrote: > From: Rob Clark > > The bridge has pretty good docs, lets add a link to make them easier to > find. > > Signed-off-by: Rob Clark Reviewed-by: Andrzej Hajda  -- Regards Andrzej > --- > drivers/gpu/drm/bridge/ti-sn65dsi86.c | 1 + > 1 file changed, 1 i

Re: [PATCH 2/3] drm/bridge: ti-sn65dsi86: add debugfs

2019-07-04 Thread Andrzej Hajda
On 02.07.2019 17:44, Rob Clark wrote: > From: Rob Clark > > Add a debugfs file to show status registers. > > Signed-off-by: Rob Clark > --- > drivers/gpu/drm/bridge/ti-sn65dsi86.c | 42 +++ > 1 file changed, 42 insertions(+) > > diff --git a/drivers/gpu/drm/bridge/ti-sn65

Re: [PATCH 1/3] drm/bridge: ti-sn65dsi86: add link to datasheet

2019-07-04 Thread Laurent Pinchart
Hi Rob, Thank you for the patch. On Tue, Jul 02, 2019 at 08:44:16AM -0700, Rob Clark wrote: > From: Rob Clark > > The bridge has pretty good docs, lets add a link to make them easier to > find. > > Signed-off-by: Rob Clark > --- > drivers/gpu/drm/bridge/ti-sn65dsi86.c | 1 + > 1 file changed

Re: [PATCH 3/3] drm/bridge: ti-sn65dsi86: correct dsi mode_flags

2019-07-04 Thread Andrzej Hajda
On 02.07.2019 19:23, Jeffrey Hugo wrote: > On Tue, Jul 2, 2019 at 11:12 AM Rob Clark wrote: >> On Tue, Jul 2, 2019 at 10:09 AM Jeffrey Hugo >> wrote: >>> On Tue, Jul 2, 2019 at 9:46 AM Rob Clark wrote: - dsi->mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_SYNC_PULSE | >

  1   2   >