Re: [PATCH v2 02/18] drm/vram: use embedded gem object

2019-06-28 Thread Thomas Zimmermann
Hi Am 21.06.19 um 13:57 schrieb Gerd Hoffmann: > Drop drm_gem_object from drm_gem_vram_object, use the > ttm_buffer_object.base instead. > > Signed-off-by: Gerd Hoffmann > --- > include/drm/drm_gem_vram_helper.h | 3 +-- > drivers/gpu/drm/ast/ast_main.c | 2 +- > driver

Re: [PATCH 2/2] dma-buf: cleanup shared fence removal

2019-06-28 Thread Daniel Vetter
On Fri, Jun 28, 2019 at 8:32 AM Koenig, Christian wrote: > Am 27.06.19 um 21:57 schrieb Daniel Vetter: > > [SNIP] > >> Again, the reason to remove the fence from one reservation object is > >> simply that it is faster to remove it from one object than to attach a > >> new fence to all other object

Re: [PATCH v2 09/18] drm/vram: drop drm_gem_vram_driver_gem_prime_mmap

2019-06-28 Thread Thomas Zimmermann
Acked-by: Thomas Zimmermann Am 21.06.19 um 13:57 schrieb Gerd Hoffmann: > The wrapper doesn't do anything any more, drop it. > > Signed-off-by: Gerd Hoffmann > --- > include/drm/drm_gem_vram_helper.h | 4 +--- > drivers/gpu/drm/drm_gem_vram_helper.c | 17 - > 2 files chang

Re: [PATCH] MAINTAINERS: add Sam Ravnborg for drm/atmel_hlcdc

2019-06-28 Thread Nicolas.Ferre
On 28/06/2019 at 08:12, Boris Brezillon wrote: > On Thu, 27 Jun 2019 23:16:43 +0200 > Sam Ravnborg wrote: > >> I have agreed with Boris Brezillon that we will share the >> maintainer role for the drm/atmel_hlcdc driver. >> Nicolas Ferre from Microchip has donated a few boards that >> allows me to

Re: [PATCH v2 02/18] drm/vram: use embedded gem object

2019-06-28 Thread Daniel Vetter
On Fri, Jun 28, 2019 at 9:30 AM Thomas Zimmermann wrote: > > Hi > > Am 21.06.19 um 13:57 schrieb Gerd Hoffmann: > > Drop drm_gem_object from drm_gem_vram_object, use the > > ttm_buffer_object.base instead. > > > > Signed-off-by: Gerd Hoffmann > > --- > > include/drm/drm_gem_vram_helper.h

Re: [PATCH v2 4/4] backlight: pwm_bl: Set scale type for brightness curves specified in the DT

2019-06-28 Thread Daniel Thompson
On Wed, Jun 26, 2019 at 04:56:18PM +0200, Pavel Machek wrote: > On Mon 2019-06-24 13:31:13, Matthias Kaehlcke wrote: > > Check if a brightness curve specified in the device tree is linear or > > not and set the corresponding property accordingly. This makes the > > scale type available to userspace

Re: [PATCH v5 17/18] kernel/sysctl-test: Add null pointer test for sysctl.c:proc_dointvec()

2019-06-28 Thread Brendan Higgins
On Wed, Jun 26, 2019 at 11:10 PM Luis Chamberlain wrote: > > On Wed, Jun 26, 2019 at 09:07:43PM -0700, Iurii Zaikin wrote: > > On Tue, Jun 25, 2019 at 7:17 PM Luis Chamberlain wrote: > > > > +static void sysctl_test_dointvec_table_maxlen_unset(struct kunit *test) > > > > +{ > > > > + struct c

Re: [bug report] drm/ttm: add transparent huge page support for DMA allocations v2

2019-06-28 Thread Koenig, Christian
Am 28.06.19 um 09:39 schrieb Christoph Hellwig: > On Thu, Jun 27, 2019 at 05:30:00PM +, Koenig, Christian wrote: >> Am 27.06.19 um 19:15 schrieb Christoph Hellwig: >>> On Thu, Jun 27, 2019 at 05:12:47PM +, Koenig, Christian wrote: the whole TTM page allocation code is not really workin

Re: [PATCH v5 01/18] kunit: test: add KUnit test runner core

2019-06-28 Thread Brendan Higgins
On Thu, Jun 27, 2019 at 11:16 AM Stephen Boyd wrote: > > Quoting Brendan Higgins (2019-06-26 16:00:40) > > On Tue, Jun 25, 2019 at 8:41 PM Stephen Boyd wrote: > > > > > scenario like below, but where it is a problem. There could be three > > > CPUs, or even one CPU and three threads if you want t

Re: [PATCH v2 4/4] backlight: pwm_bl: Set scale type for brightness curves specified in the DT

2019-06-28 Thread Pavel Machek
On Fri 2019-06-28 08:55:16, Daniel Thompson wrote: > On Wed, Jun 26, 2019 at 04:56:18PM +0200, Pavel Machek wrote: > > On Mon 2019-06-24 13:31:13, Matthias Kaehlcke wrote: > > > Check if a brightness curve specified in the device tree is linear or > > > not and set the corresponding property accord

[PATCH v2 0/3] Send a hotplug when edid changes

2019-06-28 Thread Stanislav Lisovskiy
This series introduce to drm a way to determine if something else except connection_status had changed during probing, which can be used by other drivers as well. Another i915 specific part uses this approach to determine if edid had changed without changing the connection status and send a hotplug

[PATCH v2 1/3] drm: Add helper to compare edids.

2019-06-28 Thread Stanislav Lisovskiy
Many drivers would benefit from using drm helper to compare edid, rather than bothering with own implementation. v2: Added documentation for this function. Signed-off-by: Stanislav Lisovskiy --- drivers/gpu/drm/drm_edid.c | 33 + include/drm/drm_edid.h | 9 +

[PATCH v2 3/3] drm/i915: Send hotplug event if edid had changed.

2019-06-28 Thread Stanislav Lisovskiy
Added edid checking to dp and hdmi edid setting functions, which are called from detect hooks. The result currently is propagated to calling layer using drm_connector->change_counter(proposed by Daniel Vetter). drm_helper_hpd_irq_event and intel_encoder_hotplug are currently both responsible for ch

[PATCH v2 2/3] drm: Introduce change counter to drm_connector

2019-06-28 Thread Stanislav Lisovskiy
This counter will be used by drm_helper_probe_detect caller to determine if something else had changed except connection status, like for example edid. Hardware specific drivers are responsible for updating this counter when some change is detected to notify the drm part, which can trigger for exam

[PATCH v2 07/27] gpu: drm: remove memset after zalloc

2019-06-28 Thread Fuqian Huang
zalloc has already zeroed the memory. so memset is unneeded. Signed-off-by: Fuqian Huang --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_irq.c | 2 -- drivers/gpu/drm/amd/powerplay/hwmgr/process_pptables_v1_0.c | 2 -- drivers/gpu/drm/amd/powerplay/smumgr/ci_smumgr.c| 2 --

Re: [PATCH v2 2/4] backlight: Expose brightness curve type through sysfs

2019-06-28 Thread Daniel Thompson
On Wed, Jun 26, 2019 at 04:56:11PM +0200, Pavel Machek wrote: > Hi! > > > Export the type of the brightness curve via the new sysfs attribute > > 'scale'. The value of the attribute may be a simple string like > > 'linear' or 'non-linear', or a composite string similar to > > 'compatible' strings

Re: [PATCH 2/2] dma-buf: cleanup shared fence removal

2019-06-28 Thread Christian König
Am 28.06.19 um 09:30 schrieb Daniel Vetter: On Fri, Jun 28, 2019 at 8:32 AM Koenig, Christian wrote: Am 27.06.19 um 21:57 schrieb Daniel Vetter: [SNIP] Again, the reason to remove the fence from one reservation object is simply that it is faster to remove it from one object than to attach a n

[PATCH v3 01/18] drm/ttm: add gem base object

2019-06-28 Thread Gerd Hoffmann
Add drm_gem_object struct to ttm_buffer_object, so ttm objects are a gdm object superclass. Add a function to check whenever a given bo actually uses the embedded drm_gem_object, for the transition period. Signed-off-by: Gerd Hoffmann Reviewed-by: Christian König --- include/drm/ttm/ttm_bo_api

[PATCH v3 04/18] drm/radeon: use embedded gem object

2019-06-28 Thread Gerd Hoffmann
Drop drm_gem_object from radeon_bo, use the ttm_buffer_object.base instead. Build tested only. Signed-off-by: Gerd Hoffmann Reviewed-by: Christian König --- drivers/gpu/drm/radeon/radeon.h | 3 +-- drivers/gpu/drm/radeon/radeon_cs.c | 2 +- drivers/gpu/drm/radeon/radeon_display.

[PATCH v3 13/18] drm/vmwgfx: switch driver from bo->resv to bo->base.resv

2019-06-28 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/vmwgfx/vmwgfx_blit.c | 4 ++-- drivers/gpu/drm/vmwgfx/vmwgfx_bo.c | 8 drivers/gpu/drm/vmwgfx/vmwgfx_cotable.c | 4 ++-- drivers/gpu/drm/vmwgfx/vmwgfx_resource.c | 6 +++--- 4 files changed, 11 insertions(+), 11 deletions(-) di

[PATCH v3 17/18] drm/virtio: switch driver from bo->resv to bo->base.resv

2019-06-28 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann Acked-by: Christian König --- drivers/gpu/drm/virtio/virtgpu_ioctl.c | 4 ++-- drivers/gpu/drm/virtio/virtgpu_plane.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_ioctl.c b/drivers/gpu/drm/virtio/virtgpu_ioctl

[PATCH v3 00/18] drm/ttm: make ttm bo a gem bo subclass

2019-06-28 Thread Gerd Hoffmann
v3: - comment updates - rebased on daniels resv series (https://patchwork.freedesktop.org/series/62735/) v2: - build fixes. - also drop ttm_buffer_object->resv Gerd Hoffmann (18): drm/ttm: add gem base object drm/vram: use embedded gem object drm/qxl: use embedded gem object drm/rad

[PATCH v3 06/18] drm/nouveau: use embedded gem object

2019-06-28 Thread Gerd Hoffmann
Drop drm_gem_object from nouveau_bo, use the ttm_buffer_object.base instead. Build tested only. Signed-off-by: Gerd Hoffmann Acked-by: Christian König --- drivers/gpu/drm/nouveau/nouveau_bo.h | 5 - drivers/gpu/drm/nouveau/nouveau_gem.h | 2 +- drivers/gpu/drm/nouveau/nouveau_ab

[PATCH v3 16/18] drm/qxl: switch driver from bo->resv to bo->base.resv

2019-06-28 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann Acked-by: Christian König --- drivers/gpu/drm/qxl/qxl_debugfs.c | 2 +- drivers/gpu/drm/qxl/qxl_release.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/qxl/qxl_debugfs.c b/drivers/gpu/drm/qxl/qxl_debugfs.c index 013b93898

[PATCH v3 09/18] drm/vram: drop drm_gem_vram_driver_gem_prime_mmap

2019-06-28 Thread Gerd Hoffmann
The wrapper doesn't do anything any more, drop it. Signed-off-by: Gerd Hoffmann Reviewed-by: Christian König Acked-by: Thomas Zimmermann --- include/drm/drm_gem_vram_helper.h | 4 +--- drivers/gpu/drm/drm_gem_vram_helper.c | 17 - 2 files changed, 1 insertion(+), 20 deleti

[PATCH v3 03/18] drm/qxl: use embedded gem object

2019-06-28 Thread Gerd Hoffmann
Drop drm_gem_object from qxl_bo, use the ttm_buffer_object.base instead. Signed-off-by: Gerd Hoffmann Acked-by: Christian König --- drivers/gpu/drm/qxl/qxl_drv.h | 6 +++--- drivers/gpu/drm/qxl/qxl_object.h | 4 ++-- drivers/gpu/drm/qxl/qxl_cmd.c | 4 ++-- drivers/gpu/drm/qxl/qxl_de

[PATCH v3 11/18] drm/ttm: switch ttm core from bo->resv to bo->base.resv

2019-06-28 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann Reviewed-by: Christian König --- include/drm/ttm/ttm_bo_driver.h| 12 ++-- drivers/gpu/drm/ttm/ttm_bo.c | 96 +- drivers/gpu/drm/ttm/ttm_bo_util.c | 16 ++--- drivers/gpu/drm/ttm/ttm_bo_vm.c| 6 +- drivers/gpu/d

[PATCH v3 14/18] drm/amdgpu: switch driver from bo->resv to bo->base.resv

2019-06-28 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann Reviewed-by: Christian König --- .../gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 6 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c| 6 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c | 2 +- drivers/gp

[PATCH v3 15/18] drm/nouveau: switch driver from bo->resv to bo->base.resv

2019-06-28 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann Reviewed-by: Christian König --- drivers/gpu/drm/nouveau/dispnv50/wndw.c | 2 +- drivers/gpu/drm/nouveau/nouveau_bo.c| 5 ++--- drivers/gpu/drm/nouveau/nouveau_fence.c | 2 +- drivers/gpu/drm/nouveau/nouveau_gem.c | 2 +- 4 files changed, 5 insertions(+), 6 del

[PATCH v3 12/18] drm/radeon: switch driver from bo->resv to bo->base.resv

2019-06-28 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann Reviewed-by: Christian König --- drivers/gpu/drm/radeon/radeon_benchmark.c | 4 ++-- drivers/gpu/drm/radeon/radeon_cs.c| 2 +- drivers/gpu/drm/radeon/radeon_display.c | 2 +- drivers/gpu/drm/radeon/radeon_gem.c | 6 +++--- drivers/gpu/drm/radeon/radeo

[PATCH v3 10/18] drm/ttm: set both resv and base.resv pointers

2019-06-28 Thread Gerd Hoffmann
Initialize both ttm_buffer_object->resv and ttm_buffer_object->base.resv pointers. This allows to move users from the former to the latter. When all users are moved we can drop ttm_buffer_object->resv. Signed-off-by: Gerd Hoffmann Reviewed-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo.c

[PATCH v3 02/18] drm/vram: use embedded gem object

2019-06-28 Thread Gerd Hoffmann
Drop drm_gem_object from drm_gem_vram_object, use the ttm_buffer_object.base instead. Signed-off-by: Gerd Hoffmann Reviewed-by: Christian König Acked-by: Thomas Zimmermann --- include/drm/drm_gem_vram_helper.h | 3 +-- drivers/gpu/drm/ast/ast_main.c | 2 +- drivers/gpu

[PATCH v3 05/18] drm/amdgpu: use embedded gem object

2019-06-28 Thread Gerd Hoffmann
Drop drm_gem_object from amdgpu_bo, use the ttm_buffer_object.base instead. Build tested only. Signed-off-by: Gerd Hoffmann Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_gem.h | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_object.h | 1 - drivers/gpu/drm/amd/amdgpu/amdgp

[PATCH v3 07/18] drm/ttm: use gem reservation object

2019-06-28 Thread Gerd Hoffmann
Drop ttm_resv from ttm_buffer_object, use the gem reservation object (base._resv) instead. Signed-off-by: Gerd Hoffmann Reviewed-by: Christian König --- include/drm/ttm/ttm_bo_api.h | 1 - drivers/gpu/drm/ttm/ttm_bo.c | 40 ++- drivers/gpu/drm/ttm/ttm_bo_u

[PATCH v3 18/18] drm/ttm: drop ttm_buffer_object->resv

2019-06-28 Thread Gerd Hoffmann
All users moved to ttm_buffer_object->base.resv Signed-off-by: Gerd Hoffmann Reviewed-by: Christian König --- include/drm/ttm/ttm_bo_api.h | 1 - drivers/gpu/drm/ttm/ttm_bo.c | 2 -- 2 files changed, 3 deletions(-) diff --git a/include/drm/ttm/ttm_bo_api.h b/include/drm/ttm/ttm_bo_api.h index

[PATCH v3 08/18] drm/ttm: use gem vma_node

2019-06-28 Thread Gerd Hoffmann
Drop vma_node from ttm_buffer_object, use the gem struct (base.vma_node) instead. Signed-off-by: Gerd Hoffmann Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.h | 2 +- drivers/gpu/drm/qxl/qxl_object.h | 2 +- drivers/gpu/drm/radeon/radeon_object.h | 2 +-

Re: [PATCH 2/2] dma-buf: cleanup shared fence removal

2019-06-28 Thread Daniel Vetter
On Fri, Jun 28, 2019 at 10:40 AM Christian König wrote: > > Am 28.06.19 um 09:30 schrieb Daniel Vetter: > > On Fri, Jun 28, 2019 at 8:32 AM Koenig, Christian > > wrote: > >> Am 27.06.19 um 21:57 schrieb Daniel Vetter: > >>> [SNIP] > Again, the reason to remove the fence from one reservation

[Bug 110822] [Bisected]Booting with kernel version 5.1.0 or higher on RX 580 hangs

2019-06-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110822 --- Comment #21 from Gobinda Joy --- The latest drm-next (drm-next-5.3-2019-06-27) kernel still have this bug. -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel m

[PATCH RFT 3/4] sh: ecovec24: don't set unused fields in platform data

2019-06-28 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Platform data fields other than fbdev are no longer used by the backlight driver. Remove them. Signed-off-by: Bartosz Golaszewski --- arch/sh/boards/mach-ecovec24/setup.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/arch/sh/boards/mach-ecovec24/setup.c b/arc

[PATCH RFT 0/4] backlight: gpio: simplify the driver

2019-06-28 Thread Bartosz Golaszewski
From: Bartosz Golaszewski While working on my other series related to gpio-backlight[1] I noticed that we could simplify the driver if we made the only user of platform data use GPIO lookups and device properties. This series tries to do that. The first patch sets up all the required structures

[PATCH RFT 2/4] backlight: gpio: simplify the platform data handling

2019-06-28 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Now that the last user of platform data (sh ecovec24) defines a proper GPIO lookup and sets the 'default-on' device property, we can drop the platform_data-specific GPIO handling and unify a big chunk of code. The only field used from the platform data is now the fbdev

[PATCH RFT 4/4] backlight: gpio: remove unused fields from platform data

2019-06-28 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Remove the platform data fields that nobody uses. Signed-off-by: Bartosz Golaszewski --- include/linux/platform_data/gpio_backlight.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/include/linux/platform_data/gpio_backlight.h b/include/linux/platform_data/gpio

[PATCH RFT 1/4] sh: ecovec24: add additional properties to the backlight device

2019-06-28 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Add a GPIO lookup entry and a device property for GPIO backlight to the board file. Tie them to the platform device which is now registered using platform_device_register_full() because of the properties. These changes are inactive now but will be used once the gpio back

Re: [PATCH 0/1] drm: panel-orientation-quirks: Add extra quirk table entry GPD MicroPC

2019-06-28 Thread Hans de Goede
Hi all, On 24-06-19 17:40, Hans de Goede wrote: Hi All, Good news I have a contact inside GPD now and from now on their BIOS-es will have proper sys_vendor and product_name DMI strings. This means that we no longer need to do BIOS date matches and add a new BIOS date to drm_panel_orientation_qu

Re: [PATCH v4 02/12] drm/virtio: switch virtio_gpu_wait_ioctl() to gem helper.

2019-06-28 Thread Gerd Hoffmann
On Wed, Jun 26, 2019 at 04:55:20PM -0700, Chia-I Wu wrote: > On Wed, Jun 19, 2019 at 11:07 PM Gerd Hoffmann wrote: > > > > Use drm_gem_reservation_object_wait() in virtio_gpu_wait_ioctl(). > > This also makes the ioctl run lockless. > The userspace has a BO cache to avoid freeing BOs immediately b

Re: [PATCH RFT 0/4] backlight: gpio: simplify the driver

2019-06-28 Thread Linus Walleij
On Fri, Jun 28, 2019 at 11:03 AM Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > While working on my other series related to gpio-backlight[1] I noticed > that we could simplify the driver if we made the only user of platform > data use GPIO lookups and device properties. This series

Re: [PATCH 2/2] dma-buf: cleanup shared fence removal

2019-06-28 Thread Koenig, Christian
Am 28.06.19 um 11:41 schrieb Daniel Vetter: > On Fri, Jun 28, 2019 at 10:40 AM Christian König > wrote: >> Am 28.06.19 um 09:30 schrieb Daniel Vetter: >>> On Fri, Jun 28, 2019 at 8:32 AM Koenig, Christian >>> wrote: Am 27.06.19 um 21:57 schrieb Daniel Vetter: > [SNIP] >>> Well yeah you h

Re: [PATCH 1/3] video: fbdev: s3c-fb: return -ENOMEM on framebuffer_alloc() failure

2019-06-28 Thread Bartlomiej Zolnierkiewicz
On 6/18/19 8:13 AM, Jingoo Han wrote: > On 6/14/19, 11:47 PM, Bartlomiej Zolnierkiewicz wrote: >> >> Fix error code from -ENOENT to -ENOMEM. >> >> Cc: Jingoo Han > Acked-by: Jingoo Han Thanks, I queued the patch for v5.3. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland

Re: [PATCH 2/3] video: fbdev: intelfb: return -ENOMEM on framebuffer_alloc() failure

2019-06-28 Thread Bartlomiej Zolnierkiewicz
On 6/14/19 4:48 PM, Bartlomiej Zolnierkiewicz wrote: > Fix error code from -ENODEV to -ENOMEM. > > Cc: Maik Broemme > Signed-off-by: Bartlomiej Zolnierkiewicz I queued the patch for v5.3. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics

Re: [PATCH 3/3] video: fbdev: don't print error message on framebuffer_alloc() failure

2019-06-28 Thread Bartlomiej Zolnierkiewicz
On 6/14/19 4:51 PM, Bartlomiej Zolnierkiewicz wrote: > framebuffer_alloc() can fail only on kzalloc() memory allocation > failure and since kzalloc() will print error message in such case > we can omit printing extra error message in drivers (which BTW is > what the majority of framebuffer_alloc(

Re: [PATCH v4 08/12] drm/virtio: rework virtio_gpu_execbuffer_ioctl fencing

2019-06-28 Thread Gerd Hoffmann
Hi, > > --- a/drivers/gpu/drm/virtio/virtgpu_drv.h > > +++ b/drivers/gpu/drm/virtio/virtgpu_drv.h > > @@ -120,9 +120,9 @@ struct virtio_gpu_vbuffer { > > > > char *resp_buf; > > int resp_size; > > - > > virtio_gpu_resp_cb resp_cb; > > > > + struct virtio_gpu_object_

[PATCH] drm/armada: fix debugfs link error

2019-06-28 Thread Arnd Bergmann
Debugfs can be disabled at compile time, causing a link error with the newly restructured code: drivers/gpu/drm/armada/armada_crtc.o: In function `armada_drm_crtc_late_register': armada_crtc.c:(.text+0x974): undefined reference to `armada_drm_crtc_debugfs_init' Make the code into the debugfs in

Re: [PATCH] video: fbdev: s3c-fb: fix sparse warnings about using incorrect types

2019-06-28 Thread Bartlomiej Zolnierkiewicz
On 6/28/19 7:50 AM, Jingoo Han wrote: > On 6/27/19, 9:58 PM, Bartlomiej Zolnierkiewicz wrote: >> >> Use ->screen_buffer instead of ->screen_base to fix sparse warnings. >> >> [ Please see commit 17a7b0b4d974 ("fb.h: Provide alternate screen_base >> pointer") for details. ] >> >> Reported-by: kb

Re: [PATCH v2 7/7] arm64: dts: allwinner: a64: enable ANX6345 bridge on Teres-I

2019-06-28 Thread Andrzej Hajda
Hi Maxime, It seems I have missed your response. On 12.06.2019 17:20, Maxime Ripard wrote: >> I am not sure if I understand whole discussion here, but I also do not >> understand whole edp-connector thing. > The context is this one: > https://patchwork.freedesktop.org/patch/257352/?series=51182&r

[PATCH] drm: connector: remove bogus NULL check

2019-06-28 Thread Arnd Bergmann
mode->name is a character array in a structure, checking it's address is pointless and causes a warning with some compilers: drivers/gpu/drm/drm_connector.c:144:15: error: address of array 'mode->name' will always evaluate to 'true' [-Werror,-Wpointer-bool-conversion]

Re: [PATCH] drm: connector: remove bogus NULL check

2019-06-28 Thread Boris Brezillon
On Fri, 28 Jun 2019 12:39:05 +0200 Arnd Bergmann wrote: > mode->name is a character array in a structure, checking it's > address is pointless and causes a warning with some compilers: > > drivers/gpu/drm/drm_connector.c:144:15: error: address of array 'mode->name' > will always evaluate to 'tr

Re: [PATCH v4 11/12] drm/virtio: switch from ttm to gem shmem helpers

2019-06-28 Thread Gerd Hoffmann
> > static inline struct virtio_gpu_object* > > virtio_gpu_object_ref(struct virtio_gpu_object *bo) > The last users of these two helpers are removed with this patch. We > can remove them. patch 12/12 does that. > > + bo = gem_to_virtio_gpu_obj(&shmem_obj->base); > > + bo->base.ba

Re: [PATCH] drm: connector: remove bogus NULL check

2019-06-28 Thread Ramalingam C
On 2019-06-28 at 12:39:05 +0200, Arnd Bergmann wrote: > mode->name is a character array in a structure, checking it's > address is pointless and causes a warning with some compilers: > > drivers/gpu/drm/drm_connector.c:144:15: error: address of array 'mode->name' > will always evaluate to 'true'

Re: [PATCH v2 1/3] drm: Add helper to compare edids.

2019-06-28 Thread Ramalingam C
On 2019-06-28 at 11:24:52 +0300, Stanislav Lisovskiy wrote: > Many drivers would benefit from using > drm helper to compare edid, rather > than bothering with own implementation. > > v2: Added documentation for this function. > > Signed-off-by: Stanislav Lisovskiy > --- > drivers/gpu/drm/drm_ed

Re: [PATCH v2 2/3] drm: Introduce change counter to drm_connector

2019-06-28 Thread Ramalingam C
On 2019-06-28 at 11:24:53 +0300, Stanislav Lisovskiy wrote: > This counter will be used by drm_helper_probe_detect caller to determine > if something else had changed except connection status, > like for example edid. Hardware specific drivers are responsible > for updating this counter when some c

Re: [PATCH v2 3/3] drm/i915: Send hotplug event if edid had changed.

2019-06-28 Thread Ramalingam C
On 2019-06-28 at 11:24:54 +0300, Stanislav Lisovskiy wrote: > Added edid checking to dp and hdmi edid setting functions, which > are called from detect hooks. The result currently is propagated > to calling layer using drm_connector->change_counter(proposed by Daniel > Vetter). > drm_helper_hpd_ir

Re: [PATCH libdrm] etnaviv: Use hash table to track BO indexes

2019-06-28 Thread Wladimir J. van der Laan
> Maybe you want to look at > https://gitlab.freedesktop.org/mesa/mesa/merge_requests/1190 > > I updated this patch against mesa master, apparently the libdrm-etnaviv > bits were folded into mesa now. Thanks! > >>stream->pipe = pipe; > >>stream->reset_notify = reset_notify; > >>strea

[Bug 110702] segfault in radeonsi HEVC hardware decoding with yuv420p10le

2019-06-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110702 --- Comment #14 from asavah --- Is there any reason the fix isn't merged yet? -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailing list dri-devel@lists.freed

Re: [PATCH v2 3/3] drm/i915: Send hotplug event if edid had changed.

2019-06-28 Thread Lisovskiy, Stanislav
On Fri, 2019-06-28 at 09:54 +0530, Ramalingam C wrote: > On 2019-06-28 at 11:24:54 +0300, Stanislav Lisovskiy wrote: > > Added edid checking to dp and hdmi edid setting functions, which > > are called from detect hooks. The result currently is propagated > > to calling layer using drm_connector->ch

[Bug 111017] hai

2019-06-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111017 Andre Klapper changed: What|Removed |Added Group||spam Status|NEW

Re: [PATCH v2 3/3] drm/i915: Send hotplug event if edid had changed.

2019-06-28 Thread Ramalingam C
On 2019-06-28 at 17:06:09 +0530, Lisovskiy, Stanislav wrote: > On Fri, 2019-06-28 at 09:54 +0530, Ramalingam C wrote: > > On 2019-06-28 at 11:24:54 +0300, Stanislav Lisovskiy wrote: > > > Added edid checking to dp and hdmi edid setting functions, which > > > are called from detect hooks. The result

Re: [PATCH 0/1] drm: panel-orientation-quirks: Add extra quirk table entry GPD MicroPC

2019-06-28 Thread Maxime Ripard
On Fri, Jun 28, 2019 at 12:04:30PM +0200, Hans de Goede wrote: > Hi all, > > On 24-06-19 17:40, Hans de Goede wrote: > > Hi All, > > > > Good news I have a contact inside GPD now and from now on their BIOS-es > > will have proper sys_vendor and product_name DMI strings. This means that > > we no lo

[PATCH v4 0/2] handle vblank when disabling ctc with interrupt disabled

2019-06-28 Thread Robert Beckett
Add warning when about to send stale vblank. Revert change that stops vblank info being updated if interrupts already disabled. This fixes a stale vblank timestamp issue seen on drm/imx. Changes since v2: Split up the patch in to smaller pieces. Add warning when about to send bogus vblank event.

[PATCH v4 2/2] Revert "drm/vblank: Do not update vblank count if interrupts are already disabled."

2019-06-28 Thread Robert Beckett
If interrupts are already disabled, then the timestamp for the vblank does not get updated, causing a stale timestamp to be reported to userland while disabling crtcs. This reverts commit 68036b08b91bc491ccc308f902616a570a49227c. Signed-off-by: Robert Beckett --- drivers/gpu/drm/drm_vblank.c |

[PATCH v4 1/2] drm/vblank: warn on sending stale event

2019-06-28 Thread Robert Beckett
Warn when about to send stale vblank info and add advice to documentation on how to avoid. Signed-off-by: Robert Beckett --- drivers/gpu/drm/drm_vblank.c | 17 + 1 file changed, 17 insertions(+) diff --git a/drivers/gpu/drm/drm_vblank.c b/drivers/gpu/drm/drm_vblank.c index 603ab

Re: [PATCH v4 1/2] drm/vblank: warn on sending stale event

2019-06-28 Thread Robert Beckett
Nak - I forgot the requested doc changes. Ill re-send On Fri, 2019-06-28 at 13:05 +0100, Robert Beckett wrote: > Warn when about to send stale vblank info and add advice to > documentation on how to avoid. > > Signed-off-by: Robert Beckett > --- > drivers/gpu/drm/drm_vblank.c | 17 +

[PATCH 8/9] drm: fix a reference for a renamed file: fb/modedb.rst

2019-06-28 Thread Mauro Carvalho Chehab
Due to two patches being applied about the same time, the reference for modedb.rst file got wrong: Documentation/fb/modedb.txt is now Documentation/fb/modedb.rst. Fixes: 1bf4e09227c3 ("drm/modes: Allow to specify rotation and reflection on the commandline") Fixes: ab42b818954c ("docs: fb

[PATCH 5/9] docs: fix some broken references due to txt->rst renames

2019-06-28 Thread Mauro Carvalho Chehab
There are three left-overs from the recent file renames, probably due to some other conflicting patch. Fix them. Signed-off-by: Mauro Carvalho Chehab Acked-by: Wolfram Sang Acked-by: Daniel Vetter --- Documentation/devicetree/bindings/arm/idle-states.txt | 2 +- drivers/gpu/drm/i915/intel_run

[PATCH 0/9] Some doc fixes

2019-06-28 Thread Mauro Carvalho Chehab
This patch series is against linux-next (next-20190627). I doubt those would apply cleanly against docs next tree. So, please apply it via the subsystem trees. Otherwise, they could be pushed by the end of the merge window or for -rc1 via a docs tree. Most, if not all were I already sent. Mauro

[PATCH 7/9] docs: gpu: add msm-crash-dump.rst to the index.rst file

2019-06-28 Thread Mauro Carvalho Chehab
This file is currently orphaned. Signed-off-by: Mauro Carvalho Chehab --- Documentation/gpu/drivers.rst| 1 + Documentation/gpu/msm-crash-dump.rst | 2 -- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/Documentation/gpu/drivers.rst b/Documentation/gpu/drivers.rst index 4bf

Re: [PATCH v4 2/2] Revert "drm/vblank: Do not update vblank count if interrupts are already disabled."

2019-06-28 Thread Ville Syrjälä
On Fri, Jun 28, 2019 at 01:05:32PM +0100, Robert Beckett wrote: > If interrupts are already disabled, then the timestamp for the vblank > does not get updated, causing a stale timestamp to be reported to > userland while disabling crtcs. > > This reverts commit 68036b08b91bc491ccc308f902616a570a49

[PATCH v5 07/12] drm/virtio: add virtio_gpu_object_array & helpers

2019-06-28 Thread Gerd Hoffmann
Some helper functions to manage an array of gem objects. v5: some small optimizations (Chia-I Wu). v4: make them virtio-private instead of generic helpers. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/virtio/virtgpu_drv.h | 10 +++ drivers/gpu/drm/virtio/virtgpu_gem.c | 45 +

[PATCH v5 11/12] drm/virtio: switch from ttm to gem shmem helpers

2019-06-28 Thread Gerd Hoffmann
virtio-gpu basically needs a sg_table for the bo, to tell the host where the backing pages for the object are. So the gem shmem helpers are a perfect fit. Some drm_gem_object_funcs need thin wrappers to update the host state, but otherwise the helpers handle everything just fine. Once the fencin

[PATCH v5 05/12] drm/virtio: drop no_wait argument from virtio_gpu_object_reserve

2019-06-28 Thread Gerd Hoffmann
All callers pass no_wait = false. Signed-off-by: Gerd Hoffmann Reviewed-by: Daniel Vetter --- drivers/gpu/drm/virtio/virtgpu_drv.h | 5 ++--- drivers/gpu/drm/virtio/virtgpu_gem.c | 4 ++-- drivers/gpu/drm/virtio/virtgpu_ioctl.c | 4 ++-- 3 files changed, 6 insertions(+), 7 deletions(-) dif

[PATCH v5 03/12] drm/virtio: simplify cursor updates

2019-06-28 Thread Gerd Hoffmann
No need to do the reservation dance, we can just wait on the fence directly. Signed-off-by: Gerd Hoffmann Reviewed-by: Daniel Vetter --- drivers/gpu/drm/virtio/virtgpu_plane.c | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_plane

[PATCH v5 00/12] drm/virtio: switch from ttm to gem shmem helpers.

2019-06-28 Thread Gerd Hoffmann
ttm increasingly gets into the way while hacking on virtio-gpu memory management. It also overkill for what virtio-gpu needs. Lets get rid of it. v5: - fence bugfixes. - minor optimizations. v4: - make gem array helpers private to virtio. - misc minor fixes. v3: - add gem array helpers. -

[PATCH v5 10/12] drm/virtio: drop virtio_gpu_object_list_validate/virtio_gpu_unref_list

2019-06-28 Thread Gerd Hoffmann
No users left. Signed-off-by: Gerd Hoffmann Acked-by: Daniel Vetter --- drivers/gpu/drm/virtio/virtgpu_drv.h | 3 -- drivers/gpu/drm/virtio/virtgpu_ioctl.c | 39 -- 2 files changed, 42 deletions(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_drv.h b/drivers/gpu/drm/

[PATCH v5 12/12] drm/virtio: remove virtio_gpu_alloc_object

2019-06-28 Thread Gerd Hoffmann
Thin wrapper around virtio_gpu_object_create(), but calling that directly works equally well. Signed-off-by: Gerd Hoffmann Acked-by: Daniel Vetter --- drivers/gpu/drm/virtio/virtgpu_drv.h | 4 drivers/gpu/drm/virtio/virtgpu_gem.c | 23 --- drivers/gpu/drm/virtio/vi

[PATCH v5 08/12] drm/virtio: rework virtio_gpu_execbuffer_ioctl fencing

2019-06-28 Thread Gerd Hoffmann
Use gem reservation helpers and direct reservation_object_* calls instead of ttm. v5: fix fencing (Chia-I Wu). v3: Also attach the array of gem objects to the virtio command buffer, so we can drop the object references in the completion callback. Needed because ttm fence helpers grab a reference

[PATCH v5 02/12] drm/virtio: switch virtio_gpu_wait_ioctl() to gem helper.

2019-06-28 Thread Gerd Hoffmann
Use drm_gem_reservation_object_wait() in virtio_gpu_wait_ioctl(). This also makes the ioctl run lockless. v5: handle lookup failure. v2: use reservation_object_test_signaled_rcu for VIRTGPU_WAIT_NOWAIT. Signed-off-by: Gerd Hoffmann Reviewed-by: Daniel Vetter --- drivers/gpu/drm/virtio/virtgpu_

[PATCH v5 01/12] drm/virtio: pass gem reservation object to ttm init

2019-06-28 Thread Gerd Hoffmann
With this gem and ttm will use the same reservation object, so mixing and matching ttm / gem reservation helpers should work fine. Signed-off-by: Gerd Hoffmann Reviewed-by: Daniel Vetter --- drivers/gpu/drm/virtio/virtgpu_object.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --

[PATCH v5 06/12] drm/virtio: remove ttm calls from in virtio_gpu_object_{reserve, unreserve}

2019-06-28 Thread Gerd Hoffmann
Call reservation_object_* directly instead of using ttm_bo_{reserve,unreserve}. v4: check for EINTR only. v3: check for EINTR too. Signed-off-by: Gerd Hoffmann Reviewed-by: Daniel Vetter --- drivers/gpu/drm/virtio/virtgpu_drv.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff

[PATCH v5 04/12] drm/virtio: remove virtio_gpu_object_wait

2019-06-28 Thread Gerd Hoffmann
No users left. Signed-off-by: Gerd Hoffmann Reviewed-by: Daniel Vetter --- drivers/gpu/drm/virtio/virtgpu_drv.h| 1 - drivers/gpu/drm/virtio/virtgpu_object.c | 13 - 2 files changed, 14 deletions(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_drv.h b/drivers/gpu/drm/virtio/vi

[PATCH v5 09/12] drm/virtio: rework virtio_gpu_object_create fencing

2019-06-28 Thread Gerd Hoffmann
Use gem reservation helpers and direct reservation_object_* calls instead of ttm. v5: fix fencing (Chia-I Wu). v3: Due to using the gem reservation object it is initialized and ready for use before calling ttm_bo_init, so we can also drop the tricky fence logic which checks whenever the command is

[PATCH] drm/selftests: reduce stack usage

2019-06-28 Thread Arnd Bergmann
Putting a large drm_connector object on the stack can lead to warnings in some configuration, such as: drivers/gpu/drm/selftests/test-drm_cmdline_parser.c:18:12: error: stack frame size of 1040 bytes in function 'drm_cmdline_test_res' [-Werror,-Wframe-larger-than=] static int drm_cmdline_test_re

[PATCH 11/43] docs: console.txt: convert docs to ReST and rename to *.rst

2019-06-28 Thread Mauro Carvalho Chehab
Convert this small file to ReST in preparation for adding it to the driver-api book. While this is not part of the driver-api book, mark it as :orphan:, in order to avoid build warnings. Signed-off-by: Mauro Carvalho Chehab Acked-by: Greg Kroah-Hartman --- .../console/{console.txt => console.r

[PATCH 34/43] docs: ioctl: convert to ReST

2019-06-28 Thread Mauro Carvalho Chehab
Rename the iio documentation files to ReST, add an index for them and adjust in order to produce a nice html output via the Sphinx build system. The cdrom.txt and hdio.txt have their own particular syntax. In order to speedup the conversion, I used a small ancillary perl script: my $d;

[PATCH 04/43] docs: locking: convert docs to ReST and rename to *.rst

2019-06-28 Thread Mauro Carvalho Chehab
Convert the locking documents to ReST and add them to the kernel development book where it belongs. Most of the stuff here is just to make Sphinx to properly parse the text file, as they're already in good shape, not requiring massive changes in order to be parsed. The conversion is actually: -

[PATCH 0/4] Convert VRAM helpers to GEM object functions

2019-06-28 Thread Thomas Zimmermann
The PRIME callback functions in struct drm_driver are deprecated in favor of their counterparts in struct drm_gem_object_funcs. This patch set introduces GEM object functions for VRAM helpers and converts over the free and PRIME functions. Drivers affected by this change, namely bochs and hibmc, a

[PATCH 4/4] drm/vram: Remove driver callback functions for PRIME

2019-06-28 Thread Thomas Zimmermann
PRIME functionality is now provided by GEM object functions. The driver callback functions are obsolete. Signed-off-by: Thomas Zimmermann --- Documentation/gpu/todo.rst| 4 +- drivers/gpu/drm/drm_gem_vram_helper.c | 118 -- include/drm/drm_gem_vram_helper.h

[PATCH 3/4] drm/hibmc: Leave struct drm_driver.gem_free_object_unlocked to NULL

2019-06-28 Thread Thomas Zimmermann
The GEM object's free function is now called through struct drm_gem_object_funcs.free. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c b/drivers/gpu/drm/hisi

[PATCH 2/4] drm/bochs: Remove PRIME helpers from driver structure

2019-06-28 Thread Thomas Zimmermann
VRAM PRIME helpers are now called through GEM object functions. The driver callback functions are obsolete. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/bochs/bochs_drv.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/bochs/bochs_drv.c b/drivers/gpu/drm/bochs/bochs_d

[PATCH 1/4] drm/vram: Set GEM object functions for PRIME

2019-06-28 Thread Thomas Zimmermann
PRIME functionality is now provided via the callback functions in struct drm_gem_object_funcs. The driver-structure functions are obsolete. As a side effect of this patch, VRAM-based drivers get basic PRIME support automatically without having to set any flags or additional fields. Signed-off-by:

[PATCH 37/39] docs: adds some directories to the main documentation index

2019-06-28 Thread Mauro Carvalho Chehab
The contents of those directories were orphaned at the documentation body. While those directories could likely be moved to be inside some guide, I'm opting to just adding their indexes to the main one, removing the :orphan: and adding the SPDX header. For the drivers, the rationale is that the d

[PATCH 28/39] docs: admin-guide: add a series of orphaned documents

2019-06-28 Thread Mauro Carvalho Chehab
There are lots of documents that belong to the admin-guide but are on random places (most under Documentation root dir). Move them to the admin guide. Signed-off-by: Mauro Carvalho Chehab --- Documentation/ABI/stable/sysfs-devices-node | 2 +- Documentation/ABI/testing/procfs-diskstats

  1   2   >