Re: [PATCH v3 07/10] drm: rcar-du: Provide for_each_group helper

2019-06-18 Thread Ulrich Hecht
> On June 17, 2019 at 11:09 PM Laurent Pinchart > wrote: > > > From: Kieran Bingham > > Refactoring of the group control code will soon require more iteration > over the available groups. Simplify this process by introducing a group > iteration helper. > > Signed-off-by: Kieran Bingham >

Re: [PATCH 39/59] drm/zte: Drop drm_gem_prime_export/import

2019-06-18 Thread Shawn Guo
On Fri, Jun 14, 2019 at 10:35:55PM +0200, Daniel Vetter wrote: > They're the default. > > Aside: Would be really nice to switch the others over to > drm_gem_object_funcs. > > Signed-off-by: Daniel Vetter > Cc: Shawn Guo Acked-by: Shawn Guo > --- > drivers/gpu/drm/zte/zx_drm_drv.c | 2 -- >

Re: [Intel-gfx] [PATCH 48/59] drm/vgem: Ditch attach trickery in the fence ioctl

2019-06-18 Thread Daniel Vetter
On Tue, Jun 18, 2019 at 2:31 PM Chris Wilson wrote: > Quoting Daniel Vetter (2019-06-14 21:36:04) > > It looks like this was done purely to get a consistent place to look > > up the reservation object pointer. With the drm_prime.c helper code > > now also setting gem_object->resv for imported obje

[PATCH v2] drm: return -EFAULT if copy_to_user() fails

2019-06-18 Thread Dan Carpenter
The copy_from_user() function returns the number of bytes remaining to be copied but we want to return a negative error code. Otherwise the callers treat it as a successful copy. Signed-off-by: Dan Carpenter --- v2: The first version was missing a chunk drivers/gpu/drm/drm_bufs.c | 5 - d

Re: [PATCH] drm: rcar-du: Replace drm_driver GEM ops with GEM object functions

2019-06-18 Thread Daniel Vetter
On Tue, Jun 18, 2019 at 3:13 PM Laurent Pinchart wrote: > > The recommended way to specify GEM object functions is to provide a > drm_gem_object_funcs structure instance and set the GEM object to point > to it. The drm_cma_gem_create_object_default_funcs() function provided > by the GEM CMA helpe

Re: [PATCH] drm: rcar-du: Replace drm_driver GEM ops with GEM object functions

2019-06-18 Thread Laurent Pinchart
Hi Daniel, On Tue, Jun 18, 2019 at 03:21:55PM +0200, Daniel Vetter wrote: > On Tue, Jun 18, 2019 at 3:13 PM Laurent Pinchart > wrote: > > > > The recommended way to specify GEM object functions is to provide a > > drm_gem_object_funcs structure instance and set the GEM object to point > > to it.

Re: [PATCH 1/4] drm/vmwgfx: Assign eviction priorities to resources

2019-06-18 Thread Daniel Vetter
On Tue, Jun 18, 2019 at 03:08:01PM +0200, Thomas Hellstrom wrote: > On 6/18/19 2:19 PM, Daniel Vetter wrote: > > On Tue, Jun 18, 2019 at 11:54:08AM +0100, Emil Velikov wrote: > > > Hi Thomas, > > > > > > On 2019/06/18, Thomas Hellström (VMware) wrote: > > > > From: Thomas Hellstrom > > > > > > >

Re: [PATCH 1/4] drm/vmwgfx: Assign eviction priorities to resources

2019-06-18 Thread Thomas Hellstrom
On 6/18/19 12:54 PM, Emil Velikov wrote: Hi Thomas, On 2019/06/18, Thomas Hellström (VMware) wrote: From: Thomas Hellstrom TTM provides a means to assign eviction priorities to buffer object. This means that all buffer objects with a lower priority will be evicted first on memory pressure. Us

[PATCH v2 0/2] Add DSI panel driver for Raydium RM67191

2019-06-18 Thread Robert Chiras
This patch-set contains the DRM panel driver and dt-bindings documentation for the DSI driven panel: Raydium RM67191. Changes since v1: - Fixed 'reset-gpio' to 'reset-gpios' property naming - Changed the state of the reset gpio to active low and fixed how it is handled in driver - Fixed copyrigh

[PATCH v2 1/2] dt-bindings: display: panel: Add support for Raydium RM67191 panel

2019-06-18 Thread Robert Chiras
Add dt-bindings documentation for Raydium RM67191 DSI panel. Signed-off-by: Robert Chiras --- .../bindings/display/panel/raydium,rm67191.txt | 43 ++ 1 file changed, 43 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/raydium,rm67191.txt

[PATCH v2 2/2] drm/panel: Add support for Raydium RM67191 panel driver

2019-06-18 Thread Robert Chiras
This patch adds Raydium RM67191 TFT LCD panel driver (MIPI-DSI protocol). Signed-off-by: Robert Chiras --- drivers/gpu/drm/panel/Kconfig | 9 + drivers/gpu/drm/panel/Makefile| 1 + drivers/gpu/drm/panel/panel-raydium-rm67191.c | 709 ++

[PATCH] docs: fix some broken references due to txt->rst renames

2019-06-18 Thread Mauro Carvalho Chehab
There are three left-overs from the recent file renames, probably due to some other conflicting patch. Fix them. Signed-off-by: Mauro Carvalho Chehab --- This patch is against today's next-20190617 branch. Not sure if it will apply cleanly at -docs tree. If not, Please let me know for me to sp

Re: [RFC/WIP] drm/rockchip: Support CRTC gamma LUT

2019-06-18 Thread Ezequiel Garcia
On Thu, 2019-06-13 at 15:36 -0400, Ilia Mirkin wrote: > Note that userspace may provide any size of gamma lut. Have a look at > i915/intel_color.c:intel_color_check which filters out only the > allowed sizes. Consider having a special allowance for 256-sized LUTs > since that's what most legacy use

Re: [PATCH v3 08/10] drm: rcar-du: Create a group state object

2019-06-18 Thread Ulrich Hecht
> On June 17, 2019 at 11:09 PM Laurent Pinchart > wrote: > > > From: Kieran Bingham > > Create a new private state object for the DU groups, and move the > initialisation of a group object to a new function rcar_du_group_init(). > > Signed-off-by: Kieran Bingham > Signed-off-by: Laurent P

Re: [RFC/WIP] drm/rockchip: Support CRTC gamma LUT

2019-06-18 Thread Ezequiel Garcia
On Fri, 2019-06-14 at 13:05 -0700, Doug Anderson wrote: > Hi, > > On Thu, Jun 13, 2019 at 12:23 PM Ezequiel Garcia > wrote: > > @@ -1744,6 +1793,41 @@ int rockchip_drm_wait_vact_end(struct drm_crtc > > *crtc, unsigned int mstimeout) > > } > > EXPORT_SYMBOL(rockchip_drm_wait_vact_end); > > >

Re: [PATCH] docs: fix some broken references due to txt->rst renames

2019-06-18 Thread Wolfram Sang
On Tue, Jun 18, 2019 at 10:33:58AM -0300, Mauro Carvalho Chehab wrote: > There are three left-overs from the recent file renames, > probably due to some other conflicting patch. > > Fix them. > > Signed-off-by: Mauro Carvalho Chehab Thanks! Acked-by: Wolfram Sang signature.asc Description:

Re: [PATCH v3 01/10] media: vsp1: drm: Split vsp1_du_setup_lif()

2019-06-18 Thread Laurent Pinchart
Hi Ulrich, On Tue, Jun 18, 2019 at 02:32:13PM +0200, Ulrich Hecht wrote: > > On June 17, 2019 at 11:09 PM Laurent Pinchart > > wrote: > > > > From: Kieran Bingham > > > > Break vsp1_du_setup_lif() into components more suited to the DRM Atomic > > API. The existing vsp1_du_setup_lif() API call

Re: [PATCH v3 09/10] drm: rcar-du: Perform group setup from the atomic tail handler

2019-06-18 Thread Ulrich Hecht
> On June 17, 2019 at 11:09 PM Laurent Pinchart > wrote: > > > From: Kieran Bingham > > Create rcar_du_group_atomic_check() and rcar_du_group_atomic_setup() > functions to track and apply group state through the DRM atomic state. > The use_count field is moved from the rcar_du_group structu

Re: [PATCH] drm: rcar-du: Replace drm_driver GEM ops with GEM object functions

2019-06-18 Thread Noralf Trønnes
Den 18.06.2019 15.13, skrev Laurent Pinchart: > The recommended way to specify GEM object functions is to provide a > drm_gem_object_funcs structure instance and set the GEM object to point > to it. The drm_cma_gem_create_object_default_funcs() function provided > by the GEM CMA helper does so wh

Re: [PATCH] drm: rcar-du: Replace drm_driver GEM ops with GEM object functions

2019-06-18 Thread Daniel Vetter
On Tue, Jun 18, 2019 at 04:26:51PM +0300, Laurent Pinchart wrote: > Hi Daniel, > > On Tue, Jun 18, 2019 at 03:21:55PM +0200, Daniel Vetter wrote: > > On Tue, Jun 18, 2019 at 3:13 PM Laurent Pinchart > > wrote: > > > > > > The recommended way to specify GEM object functions is to provide a > > >

Re: [PATCH] docs: fix some broken references due to txt->rst renames

2019-06-18 Thread Daniel Vetter
On Tue, Jun 18, 2019 at 10:33:58AM -0300, Mauro Carvalho Chehab wrote: > There are three left-overs from the recent file renames, > probably due to some other conflicting patch. > > Fix them. > > Signed-off-by: Mauro Carvalho Chehab > --- > > This patch is against today's next-20190617 branch.

[PATCH v2 06/12] drm/virtio: remove ttm calls from in virtio_gpu_object_{reserve,unreserve}

2019-06-18 Thread Gerd Hoffmann
Call reservation_object_* directly instead of using ttm_bo_{reserve,unreserve}. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/virtio/virtgpu_drv.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_drv.h b/drivers/gpu/drm/virtio/virtgpu_drv

[PATCH v2 02/12] drm/virtio: switch virtio_gpu_wait_ioctl() to gem helper.

2019-06-18 Thread Gerd Hoffmann
Use drm_gem_reservation_object_wait() in virtio_gpu_wait_ioctl(). This also makes the ioctl run lockless. Signed-off-by: Gerd Hoffmann Reviewed-by: Daniel Vetter --- drivers/gpu/drm/virtio/virtgpu_ioctl.c | 24 ++-- 1 file changed, 10 insertions(+), 14 deletions(-) diff --g

[PATCH v2 07/12] drm/virtio: rework virtio_gpu_execbuffer_ioctl fencing

2019-06-18 Thread Gerd Hoffmann
Use gem reservation helpers and direct reservation_object_* calls instead of ttm. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/virtio/virtgpu_ioctl.c | 36 -- 1 file changed, 17 insertions(+), 19 deletions(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_ioctl.c b/dri

[PATCH v2 12/12] drm/virtio: remove virtio_gpu_alloc_object

2019-06-18 Thread Gerd Hoffmann
Thin wrapper around virtio_gpu_object_create(), but calling that directly works equally well. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/virtio/virtgpu_drv.h | 4 drivers/gpu/drm/virtio/virtgpu_gem.c | 23 --- drivers/gpu/drm/virtio/virtgpu_ioctl.c | 6 +++---

[PATCH v2 01/12] drm/virtio: pass gem reservation object to ttm init

2019-06-18 Thread Gerd Hoffmann
With this gem and ttm will use the same reservation object, so mixing and matching ttm / gem reservation helpers should work fine. Signed-off-by: Gerd Hoffmann Reviewed-by: Daniel Vetter --- drivers/gpu/drm/virtio/virtgpu_object.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --

[PATCH v2 05/12] drm/virtio: drop no_wait argument from virtio_gpu_object_reserve

2019-06-18 Thread Gerd Hoffmann
All callers pass no_wait = false. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/virtio/virtgpu_drv.h | 5 ++--- drivers/gpu/drm/virtio/virtgpu_gem.c | 4 ++-- drivers/gpu/drm/virtio/virtgpu_ioctl.c | 4 ++-- 3 files changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/vi

[PATCH v2 03/12] drm/virtio: simplify cursor updates

2019-06-18 Thread Gerd Hoffmann
No need to do the reservation dance, we can just wait on the fence directly. Signed-off-by: Gerd Hoffmann Reviewed-by: Daniel Vetter --- drivers/gpu/drm/virtio/virtgpu_plane.c | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_plane

[PATCH v2 04/12] drm/virtio: remove virtio_gpu_object_wait

2019-06-18 Thread Gerd Hoffmann
No users left. Signed-off-by: Gerd Hoffmann Reviewed-by: Daniel Vetter --- drivers/gpu/drm/virtio/virtgpu_drv.h| 1 - drivers/gpu/drm/virtio/virtgpu_object.c | 13 - 2 files changed, 14 deletions(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_drv.h b/drivers/gpu/drm/virtio/vi

[PATCH v2 00/12] drm/virtio: switch from ttm to gem shmem helpers.

2019-06-18 Thread Gerd Hoffmann
ttm increasingly gets into the way while hacking on virtio-gpu memory management. It also overkill for what virtio-gpu needs. Lets get rid of it. cheers, Gerd Gerd Hoffmann (12): drm/virtio: pass gem reservation object to ttm init drm/virtio: switch virtio_gpu_wait_ioctl() to gem helper.

[PATCH v2 09/12] drm/virtio: drop virtio_gpu_object_list_validate/virtio_gpu_unref_list

2019-06-18 Thread Gerd Hoffmann
No users left. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/virtio/virtgpu_drv.h | 3 -- drivers/gpu/drm/virtio/virtgpu_ioctl.c | 39 -- 2 files changed, 42 deletions(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_drv.h b/drivers/gpu/drm/virtio/virtgpu_drv.h inde

[PATCH v2 08/12] drm/virtio: rework virtio_gpu_object_create fencing

2019-06-18 Thread Gerd Hoffmann
Use gem reservation helpers and direct reservation_object_* calls instead of ttm. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/virtio/virtgpu_object.c | 28 +++-- 1 file changed, 8 insertions(+), 20 deletions(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_object.c b/dri

[PATCH v2 11/12] drm/virtio: rework virtio_gpu_object_create fencing even more.

2019-06-18 Thread Gerd Hoffmann
Now with ttm initialization being out of the way we can simplify virtio_gpu_object_create fencing even more. No need to check whenever the command is still running after ttm_bo_init() returned. We have a fully initialized gem bo before we kick off the resource creation command, so we can simply a

[PATCH v2 10/12] drm/virtio: switch from ttm to gem shmem helpers

2019-06-18 Thread Gerd Hoffmann
virtio-gpu basically needs a sg_table for the bo, to tell the host where the backing pages for the object are. So the gem shmem helpers are a perfect fit. Some drm_gem_object_funcs need thin wrappers to update the host state, but otherwise the helpers handle everything just fine. Once the fencin

[PATCH] drm/todo: Update drm_gem_object_funcs todo even more

2019-06-18 Thread Daniel Vetter
I rushed merging this a bit too much, and Noralf pointed out that we're a lot better already and have made great progress. Let's try again. Fixes: 42dbbb4b54a3 ("drm/todo: Add new debugfs todo") Cc: Greg Kroah-Hartman Cc: Daniel Vetter Cc: David Airlie Cc: Daniel Vetter Cc: Maarten Lankhorst

Re: [PATCH v2 02/12] drm/virtio: switch virtio_gpu_wait_ioctl() to gem helper.

2019-06-18 Thread Daniel Vetter
On Tue, Jun 18, 2019 at 03:58:10PM +0200, Gerd Hoffmann wrote: > Use drm_gem_reservation_object_wait() in virtio_gpu_wait_ioctl(). > This also makes the ioctl run lockless. > > Signed-off-by: Gerd Hoffmann > Reviewed-by: Daniel Vetter Nit: Missing the v2 changelog here. -Daniel > --- > driver

Re: [PATCH v2 06/12] drm/virtio: remove ttm calls from in virtio_gpu_object_{reserve,unreserve}

2019-06-18 Thread Daniel Vetter
On Tue, Jun 18, 2019 at 03:58:14PM +0200, Gerd Hoffmann wrote: > Call reservation_object_* directly instead > of using ttm_bo_{reserve,unreserve}. > > Signed-off-by: Gerd Hoffmann > --- > drivers/gpu/drm/virtio/virtgpu_drv.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff -

Re: [PATCH v3 10/10] drm: rcar-du: Centralise routing configuration in commit tail handler

2019-06-18 Thread Ulrich Hecht
Thank you for your patch. > On June 17, 2019 at 11:09 PM Laurent Pinchart > wrote: > > > Routing configuration for the DU is complex. Depending on the SoC > generation various routing options are available: > > - The VSP to DU routing is not available on Gen1, is configurable on > Gen2 and

Re: [PATCH 1/4] drm/vmwgfx: Assign eviction priorities to resources

2019-06-18 Thread Thomas Hellstrom
On 6/18/19 3:27 PM, Daniel Vetter wrote: On Tue, Jun 18, 2019 at 03:08:01PM +0200, Thomas Hellstrom wrote: On 6/18/19 2:19 PM, Daniel Vetter wrote: On Tue, Jun 18, 2019 at 11:54:08AM +0100, Emil Velikov wrote: Hi Thomas, On 2019/06/18, Thomas Hellström (VMware) wrote: From: Thomas Hellstrom

Re: [PATCH] drm/todo: Update drm_gem_object_funcs todo even more

2019-06-18 Thread Noralf Trønnes
Den 18.06.2019 16.02, skrev Daniel Vetter: > I rushed merging this a bit too much, and Noralf pointed out that > we're a lot better already and have made great progress. > > Let's try again. > > Fixes: 42dbbb4b54a3 ("drm/todo: Add new debugfs todo") > Cc: Greg Kroah-Hartman > Cc: Daniel Vetter

Re: [PATCH v2 07/12] drm/virtio: rework virtio_gpu_execbuffer_ioctl fencing

2019-06-18 Thread Daniel Vetter
On Tue, Jun 18, 2019 at 03:58:15PM +0200, Gerd Hoffmann wrote: > Use gem reservation helpers and direct reservation_object_* calls > instead of ttm. > > Signed-off-by: Gerd Hoffmann > --- > drivers/gpu/drm/virtio/virtgpu_ioctl.c | 36 -- > 1 file changed, 17 insertions(+)

Re: [PATCH v2 2/2] arm: dts: add ARM Mali GPU node for Odroid XU3

2019-06-18 Thread Rob Herring
On Tue, Jun 18, 2019 at 3:27 AM Krzysztof Kozlowski wrote: > > On Sat, 15 Jun 2019 at 01:57, Joseph Kogut wrote: > > > > Add device tree node for mali gpu on Odroid XU3 SoCs. > > > > Signed-off-by: Joseph Kogut > > --- > > > > Changes v1 -> v2: > > - Use interrupt name ordering from binding doc

Re: [PATCH v2 07/12] drm/virtio: rework virtio_gpu_execbuffer_ioctl fencing

2019-06-18 Thread Daniel Vetter
On Tue, Jun 18, 2019 at 04:16:04PM +0200, Daniel Vetter wrote: > On Tue, Jun 18, 2019 at 03:58:15PM +0200, Gerd Hoffmann wrote: > > Use gem reservation helpers and direct reservation_object_* calls > > instead of ttm. > > > > Signed-off-by: Gerd Hoffmann > > --- > > drivers/gpu/drm/virtio/virtgp

Re: [PATCH v2 08/12] drm/virtio: rework virtio_gpu_object_create fencing

2019-06-18 Thread Daniel Vetter
On Tue, Jun 18, 2019 at 03:58:16PM +0200, Gerd Hoffmann wrote: > Use gem reservation helpers and direct reservation_object_* calls > instead of ttm. > > Signed-off-by: Gerd Hoffmann > --- > drivers/gpu/drm/virtio/virtgpu_object.c | 28 +++-- > 1 file changed, 8 insertions(+),

Re: [PATCH 1/4] drm/vmwgfx: Assign eviction priorities to resources

2019-06-18 Thread Daniel Vetter
On Tue, Jun 18, 2019 at 04:14:27PM +0200, Thomas Hellstrom wrote: > On 6/18/19 3:27 PM, Daniel Vetter wrote: > > On Tue, Jun 18, 2019 at 03:08:01PM +0200, Thomas Hellstrom wrote: > > > On 6/18/19 2:19 PM, Daniel Vetter wrote: > > > > On Tue, Jun 18, 2019 at 11:54:08AM +0100, Emil Velikov wrote: > >

Re: [PATCH v3 10/10] drm: rcar-du: Centralise routing configuration in commit tail handler

2019-06-18 Thread Laurent Pinchart
Hi Ulrich, On Tue, Jun 18, 2019 at 04:12:01PM +0200, Ulrich Hecht wrote: > > On June 17, 2019 at 11:09 PM Laurent Pinchart wrote: > > > > Routing configuration for the DU is complex. Depending on the SoC > > generation various routing options are available: > > > > - The VSP to DU routing is not

[Bug 110944] [Bisected] Blender 2.8 crashes when closing certain windows

2019-06-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110944 Bug ID: 110944 Summary: [Bisected] Blender 2.8 crashes when closing certain windows Product: Mesa Version: 19.1 Hardware: x86-64 (AMD64) OS: Linux (All)

Re: [linux-sunxi] Re: [PATCH v10 01/11] drm/sun4i: dsi: Fix TCON DRQ set bits

2019-06-18 Thread Chen-Yu Tsai
On Tue, Jun 18, 2019 at 8:11 PM Jagan Teki wrote: > > On Tue, Jun 18, 2019 at 5:13 PM Chen-Yu Tsai wrote: > > > > On Tue, Jun 18, 2019 at 6:51 PM Jagan Teki > > wrote: > > > > > > On Fri, Jun 14, 2019 at 8:15 PM Maxime Ripard > > > wrote: > > > > > > > > On Fri, Jun 14, 2019 at 12:03:13PM +05

Re: [PATCH v2 2/2] arm: dts: add ARM Mali GPU node for Odroid XU3

2019-06-18 Thread Krzysztof Kozlowski
On Tue, 18 Jun 2019 at 16:18, Rob Herring wrote: > > On Tue, Jun 18, 2019 at 3:27 AM Krzysztof Kozlowski wrote: > > > > On Sat, 15 Jun 2019 at 01:57, Joseph Kogut wrote: > > > > > > Add device tree node for mali gpu on Odroid XU3 SoCs. > > > > > > Signed-off-by: Joseph Kogut > > > --- > > > > >

[Bug 110944] [Bisected] Blender 2.8 crashes when closing certain windows

2019-06-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110944 --- Comment #1 from Pierre-Eric Pelloux-Prayer --- Can you test the commit from https://gitlab.freedesktop.org/mesa/mesa/merge_requests/1071? I think it should fix this issue. -- You are receiving this mail because: You are the assignee for t

[Bug 110944] [Bisected] Blender 2.8 crashes when closing certain windows

2019-06-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110944 --- Comment #2 from Sebastian Parborg --- Yes that patch seems to solve the issue! -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailing list dri-devel@lists.

Re: [PATCH 1/2] drm: debugfs: make drm_debugfs_remove_files() a void function

2019-06-18 Thread Greg Kroah-Hartman
On Tue, Jun 18, 2019 at 02:17:11PM +0200, Daniel Vetter wrote: > On Tue, Jun 18, 2019 at 02:01:35PM +0200, Greg Kroah-Hartman wrote: > > On Fri, Jun 14, 2019 at 05:37:58PM +0200, Daniel Vetter wrote: > > > On Fri, Jun 14, 2019 at 5:20 PM Greg Kroah-Hartman > > > wrote: > > > > > > > > On Fri, Jun

[PATCH 1/3] dt-bindings: display: renesas: Add r8a774a1 support

2019-06-18 Thread Fabrizio Castro
Document RZ/G2M (R8A774A1) SoC bindings. Signed-off-by: Fabrizio Castro --- Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.txt | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.txt b/Docume

[PATCH 0/3] Add HDMI support to HiHope RZ/G2M

2019-06-18 Thread Fabrizio Castro
Dear All, this series adds HDMI support to the HiHope RZ/G2M board. Thanks, Fab Fabrizio Castro (3): dt-bindings: display: renesas: Add r8a774a1 support arm64: dts: renesas: r8a774a1: Add HDMI encoder instance arm64: dts: renesas: hihope-common: Add HDMI support .../bindings/display/brid

drm connectors, tegra, and the web they weave (was Re: [PATCH 58/59] drm/todo: Add new debugfs todo)

2019-06-18 Thread Greg Kroah-Hartman
On Fri, Jun 14, 2019 at 10:36:14PM +0200, Daniel Vetter wrote: > Greg is busy already, but maybe he won't do everything ... > > Cc: Greg Kroah-Hartman > Signed-off-by: Daniel Vetter > --- > Documentation/gpu/todo.rst | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/gpu

Re: [PATCH 1/4] mm: Check if mmu notifier callbacks are allowed to fail

2019-06-18 Thread Daniel Vetter
On Tue, May 21, 2019 at 11:44:11AM -0400, Jerome Glisse wrote: > On Mon, May 20, 2019 at 11:39:42PM +0200, Daniel Vetter wrote: > > Just a bit of paranoia, since if we start pushing this deep into > > callchains it's hard to spot all places where an mmu notifier > > implementation might fail when i

Re: drm connectors, tegra, and the web they weave (was Re: [PATCH 58/59] drm/todo: Add new debugfs todo)

2019-06-18 Thread Greg Kroah-Hartman
On Tue, Jun 18, 2019 at 05:19:38PM +0200, Greg Kroah-Hartman wrote: > On Fri, Jun 14, 2019 at 10:36:14PM +0200, Daniel Vetter wrote: > > Greg is busy already, but maybe he won't do everything ... > > > > Cc: Greg Kroah-Hartman > > Signed-off-by: Daniel Vetter > > --- > > Documentation/gpu/todo.

Re: [PATCH] drm: return -EFAULT if copy_one_buf() fails

2019-06-18 Thread Dan Carpenter
Ah crap. I need to fix copy_one_buf32() as well. I will sent a v2. regards, dan carpenter ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2] drm/panfrost: Make sure a BO is only unmapped when appropriate

2019-06-18 Thread Rob Herring
On Tue, Jun 18, 2019 at 2:13 AM Boris Brezillon wrote: > > mmu_ops->unmap() will fail when called on a BO that has not been > previously mapped, and the error path in panfrost_ioctl_create_bo() > can call drm_gem_object_put_unlocked() (which in turn calls > panfrost_mmu_unmap()) on a BO that has n

Re: [PATCH v4 0/4] drm/panfrost: Expose perf counters to userspace

2019-06-18 Thread Rob Herring
On Tue, Jun 18, 2019 at 2:16 AM Boris Brezillon wrote: > > Hello, > > This a new version of the panfrost perfcnt series, this time exposing > this functionality through 2 ioctls instead of the debugfs approach > used in v2. > > I also went for Emil's suggestion to expose those ioctls only when > t

Re: drm connectors, tegra, and the web they weave (was Re: [PATCH 58/59] drm/todo: Add new debugfs todo)

2019-06-18 Thread Jon Hunter
On 18/06/2019 16:19, Greg Kroah-Hartman wrote: > On Fri, Jun 14, 2019 at 10:36:14PM +0200, Daniel Vetter wrote: >> Greg is busy already, but maybe he won't do everything ... >> >> Cc: Greg Kroah-Hartman >> Signed-off-by: Daniel Vetter >> --- >> Documentation/gpu/todo.rst | 3 +++ >> 1 file chan

[PATCH] drm/imx: correct order of crtc disable

2019-06-18 Thread Robert Beckett
Notify drm core before sending pending events during crtc disable. This fixes the first event after disable having an old stale timestamp by having drm_crtc_vblank_off update the timestamp to now. This was seen while debugging weston log message: Warning: computed repaint delay is insane: -8212 ms

Re: [PATCH] drm: rcar-du: Replace drm_driver GEM ops with GEM object functions

2019-06-18 Thread Laurent Pinchart
Hi Noralf, On Tue, Jun 18, 2019 at 03:56:19PM +0200, Noralf Trønnes wrote: > Den 18.06.2019 15.13, skrev Laurent Pinchart: > > The recommended way to specify GEM object functions is to provide a > > drm_gem_object_funcs structure instance and set the GEM object to point > > to it. The drm_cma_gem_

Re: [PATCH 1/3] dt-bindings: display: renesas: Add r8a774a1 support

2019-06-18 Thread Laurent Pinchart
Hi Fabrizio, Thank you for the patch. On Tue, Jun 18, 2019 at 04:18:37PM +0100, Fabrizio Castro wrote: > Document RZ/G2M (R8A774A1) SoC bindings. > > Signed-off-by: Fabrizio Castro Reviewed-by: Laurent Pinchart I don't have pending changes for this file for this kernel release. As your serie

Re: [PATCH] drm/rcar-du: Fix error check when retrieving crtc state

2019-06-18 Thread Sean Paul
On Tue, Jun 18, 2019 at 10:26:52AM +0300, Laurent Pinchart wrote: > Hi Sean, > > Thank you for the patch. > > On Mon, Jun 17, 2019 at 02:15:42PM -0400, Sean Paul wrote: > > From: Sean Paul > > > > drm_atomic_get_crtc_state() returns an error pointer when it fails, so > > the null check is doing

Re: [RFC/WIP] drm/rockchip: Support CRTC gamma LUT

2019-06-18 Thread Ilia Mirkin
On Tue, Jun 18, 2019 at 9:36 AM Ezequiel Garcia wrote: > > On Thu, 2019-06-13 at 15:36 -0400, Ilia Mirkin wrote: > > Note that userspace may provide any size of gamma lut. Have a look at > > i915/intel_color.c:intel_color_check which filters out only the > > allowed sizes. Consider having a specia

Re: [PATCH v2] drm: return -EFAULT if copy_to_user() fails

2019-06-18 Thread Sean Paul
On Tue, Jun 18, 2019 at 04:18:43PM +0300, Dan Carpenter wrote: > The copy_from_user() function returns the number of bytes remaining > to be copied but we want to return a negative error code. Otherwise > the callers treat it as a successful copy. > > Signed-off-by: Dan Carpenter Thanks Dan, I'

Re: [PATCH v3 00/10] drm: rcar-du: Rework CRTC and groups for atomic commits

2019-06-18 Thread Kieran Bingham
Hi Laurent, On 17/06/2019 22:09, Laurent Pinchart wrote: > Hello everybody, > > This patch series refactors atomic commit tail handling in the R-Car DU > driver to simplify the code flow, and open the door to further > optimisations. It takes over Kieran's "[PATCH v2 0/6] drm: rcar-du: > Rework C

Re: [PATCH] drm: rcar-du: Replace drm_driver GEM ops with GEM object functions

2019-06-18 Thread Noralf Trønnes
Den 18.06.2019 18.35, skrev Laurent Pinchart: > Hi Noralf, > > On Tue, Jun 18, 2019 at 03:56:19PM +0200, Noralf Trønnes wrote: >> Den 18.06.2019 15.13, skrev Laurent Pinchart: >>> The recommended way to specify GEM object functions is to provide a >>> drm_gem_object_funcs structure instance and

Re: [PATCH] drm/bridge/synopsys: dw-hdmi: Handle audio for more clock rates

2019-06-18 Thread Jernej Škrabec
Hi! Dne torek, 18. junij 2019 ob 01:55:58 CEST je Douglas Anderson napisal(a): > Let's add some better support for HDMI audio to dw_hdmi. > Specifically: > > 1. For 44.1 kHz audio the old code made the assumption that an N of > 6272 was right most of the time. That wasn't true and the new table

Re: drm connectors, tegra, and the web they weave (was Re: [PATCH 58/59] drm/todo: Add new debugfs todo)

2019-06-18 Thread Daniel Vetter
On Tue, Jun 18, 2019 at 5:25 PM Greg Kroah-Hartman wrote: > On Tue, Jun 18, 2019 at 05:19:38PM +0200, Greg Kroah-Hartman wrote: > > On Fri, Jun 14, 2019 at 10:36:14PM +0200, Daniel Vetter wrote: > > > Greg is busy already, but maybe he won't do everything ... > > > > > > Cc: Greg Kroah-Hartman >

[Bug 201539] AMDGPU R9 390 automatic fan speed control in Linux 4.19/4.20/5.0

2019-06-18 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=201539 Sean Birkholz (supas...@hotmail.com) changed: What|Removed |Added CC||supas...@hotmail.co

Re: [PATCH v5 07/12] drm/modes: Allow to specify rotation and reflection on the commandline

2019-06-18 Thread Noralf Trønnes
Den 17.06.2019 16.51, skrev Maxime Ripard: > Rotations and reflections setup are needed in some scenarios to initialise > properly the initial framebuffer. Some drivers already had a bunch of > quirks to deal with this, such as either a private kernel command line > parameter (omapdss) or on the

Re: drm connectors, tegra, and the web they weave (was Re: [PATCH 58/59] drm/todo: Add new debugfs todo)

2019-06-18 Thread Greg Kroah-Hartman
On Tue, Jun 18, 2019 at 07:32:20PM +0200, Daniel Vetter wrote: > On Tue, Jun 18, 2019 at 5:25 PM Greg Kroah-Hartman > wrote: > > On Tue, Jun 18, 2019 at 05:19:38PM +0200, Greg Kroah-Hartman wrote: > > > On Fri, Jun 14, 2019 at 10:36:14PM +0200, Daniel Vetter wrote: > > > > Greg is busy already, bu

Re: [PATCH] drm/todo: Update drm_gem_object_funcs todo even more

2019-06-18 Thread Eric Engestrom
On Tuesday, 2019-06-18 16:02:41 +0200, Daniel Vetter wrote: > I rushed merging this a bit too much, and Noralf pointed out that > we're a lot better already and have made great progress. > > Let's try again. > > Fixes: 42dbbb4b54a3 ("drm/todo: Add new debugfs todo") > Cc: Greg Kroah-Hartman > Cc

Re: [RFC/WIP] drm/rockchip: Support CRTC gamma LUT

2019-06-18 Thread Ezequiel Garcia
On Tue, 2019-06-18 at 02:15 -0300, Ezequiel Garcia wrote: > On Mon, 2019-06-17 at 12:06 +0200, Jacopo Mondi wrote: > > Hi Ezequiel, > >one small question, as I'm working on supporting gamma LUT for > > rcar-du as well, and there's one point not totally clear to me > > > > > > On Thu, Jun 13,

[PATCH 1/3] drm/lima: Mark 64-bit number as ULL to silence Smatch warning

2019-06-18 Thread Krzysztof Kozlowski
Mark long numbers with ULL to silence the Smatch warning: drivers/gpu/drm/lima/lima_device.c:314:32: warning: constant 0x1 is so big it is long long Signed-off-by: Krzysztof Kozlowski --- drivers/gpu/drm/lima/lima_vm.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[PATCH 3/3] drm/panfrost: Reduce the amount of logs on deferred probe

2019-06-18 Thread Krzysztof Kozlowski
There is no point to print deferred probe (and its failures to get resources) as an error. In case of multiple probe tries this would pollute the dmesg. Signed-off-by: Krzysztof Kozlowski --- drivers/gpu/drm/panfrost/panfrost_device.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) di

[PATCH 2/3] drm/lima: Reduce the amount of logs on deferred probe

2019-06-18 Thread Krzysztof Kozlowski
There is no point to print deferred probe (and its failures to get resources) as an error. For example getting a regulator causes three unneeded error messages: lima 1300.gpu: failed to get regulator: -517 lima 1300.gpu: regulator init fail -517 lima 1300.gpu: Fatal error

[RFT 04/10] ARM: dts: exynos: Add GPU/Mali 400 node to Exynos3250

2019-06-18 Thread Krzysztof Kozlowski
Add nodes for GPU (Mali 400) to Exynos3250. This is still limited and not tested: 1. No dynamic voltage and frequency scaling, 2. Not sure what to do with CLK_G3D clock responsible for gating entire IP block (it is now being disabled as unused). Signed-off-by: Krzysztof Kozlowski --- arch/ar

[RFT 01/10] dt-bindings: gpu: mali: Add Samsung compatibles for Midgard and Utgard

2019-06-18 Thread Krzysztof Kozlowski
Add vendor compatibles for specific implementation of Mali Utgard (Exynos3250, Exynos4-family) and Midgard (Exynos5433, Exynos7). Signed-off-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt | 1 + Documentation/devicetree/bindings/gpu/arm,mali-utgard.txt |

[RFT 00/10] ARM/arm64: dts: exynos: Add support for Mali

2019-06-18 Thread Krzysztof Kozlowski
Hi, Inspired by patch from Joseph Kogut [1], let's add support for Mali GPUs to most of other boards. However it was tested only on Odroid U3 (Exynos4412) and not fully because requirement of special Mesa drivers with Lima support. Even without tests it brings full description of hardware and re

[RFT 03/10] ARM: dts: exynos: Fix language typo and indentation

2019-06-18 Thread Krzysztof Kozlowski
Correct language typo and wrong indentation. Signed-off-by: Krzysztof Kozlowski --- arch/arm/boot/dts/exynos4210.dtsi | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot/dts/exynos4210.dtsi b/arch/arm/boot/dts/exynos4210.dtsi index b491c345b2e8..ea0e043cd2b

[RFT 02/10] clk: samsung: Add bus clock for GPU/G3D on Exynos4412

2019-06-18 Thread Krzysztof Kozlowski
Add ID and gate for bus clock for GPU (Mali 400) on Exynos4412. Signed-off-by: Krzysztof Kozlowski --- drivers/clk/samsung/clk-exynos4.c | 1 + include/dt-bindings/clock/exynos4.h | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/clk/samsung/clk-exynos4.c b/drivers/clk/samsung/clk

[RFT 06/10] arm64: dts: exynos: Add GPU/Mali T760 node to Exynos5433

2019-06-18 Thread Krzysztof Kozlowski
Add nodes for GPU (Mali T760) to Exynos5433. Missing element is the cooling device. Not tested on HW. Signed-off-by: Krzysztof Kozlowski --- .../dts/exynos/exynos5433-tm2-common.dtsi | 5 ++ arch/arm64/boot/dts/exynos/exynos5433.dtsi| 51 +++ 2 files changed, 56 insert

[RFT 07/10] arm64: dts: exynos: Add GPU/Mali T760 node to Exynos7

2019-06-18 Thread Krzysztof Kozlowski
Add nodes for GPU (Mali T760) to Exynos7. Current support for Exynos7 misses a lot, including proper clocks, power domains, frequency and voltage scaling and cooling. However this still can provide basic GPU description. Not tested on HW. Signed-off-by: Krzysztof Kozlowski --- arch/arm64/boot

[RFT 05/10] ARM: dts: exynos: Add GPU/Mali 400 node to Exynos4

2019-06-18 Thread Krzysztof Kozlowski
Add nodes for GPU (Mali 400) to Exynos4210 and Exynos4412. Describe the GPU as much as possible however still few elements are missing: 1. Exynos4210 bus clock is not described in hardware manual therefore the IP gate clock was provided, 2. Exynos4412: Not sure what to do with CLK_G3D clock res

[RFT 10/10] arm64: defconfig: Enable Panfrost driver

2019-06-18 Thread Krzysztof Kozlowski
Enable support for Mali GPU with Panfrost driver, e.g. for Exynos5433 and Exynos7 (having Mali T760). Signed-off-by: Krzysztof Kozlowski --- arch/arm64/configs/defconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfi

[RFT 08/10] ARM: multi_v7_defconfig: Enable Panfrost and LIMA drivers

2019-06-18 Thread Krzysztof Kozlowski
Enable support for Mali GPU with Panfrost and LIMA drivers. Most of Exynos chipsets come with Mali GPUs: 1. Mali 400 (Exynos3250, Exynos4210, Exynos4412), 2. Mali T7xx (Exynos542x). As Mali GPU is quite popular among ARM vendors, other platforms will benefit as well. Signed-off-by: Krzysztof Koz

[RFT 09/10] ARM: exynos_defconfig: Enable Panfrost and LIMA drivers

2019-06-18 Thread Krzysztof Kozlowski
Enable support for Mali GPU with Panfrost and LIMA drivers. Most of Exynos chipsets come with Mali GPUs: 1. Mali 400 (Exynos3250, Exynos4210, Exynos4412), 2. Mali T7xx (Exynos542x). Signed-off-by: Krzysztof Kozlowski --- arch/arm/configs/exynos_defconfig | 3 ++- 1 file changed, 2 insertions(+)

Re: [PATCH v2 2/2] arm: dts: add ARM Mali GPU node for Odroid XU3

2019-06-18 Thread Krzysztof Kozlowski
On Tue, 18 Jun 2019 at 19:42, Joseph Kogut wrote: > > > > > > > > + reg = <0x1180 0x5000>; > > > > > + interrupts = , > > > > > + , > > > > > + ; > > > > > + interrupt-names = "job", "mmu", "gpu"; > > > > > +

Re: [PATCH v2] drm/edid: parse CEA blocks embedded in DisplayID

2019-06-18 Thread Dave Airlie
On Fri, 14 Jun 2019 at 03:52, Andres Rodriguez wrote: > > DisplayID blocks allow embedding of CEA blocks. The payloads are > identical to traditional top level CEA extension blocks, but the header > is slightly different. > > This change allows the CEA parser to find a CEA block inside a DisplayID

Re: [PATCH 15/25] device-dax: use the dev_pagemap internal refcount

2019-06-18 Thread Dan Williams
On Mon, Jun 17, 2019 at 5:28 AM Christoph Hellwig wrote: > > The functionality is identical to the one currently open coded in > device-dax. > > Signed-off-by: Christoph Hellwig > --- > drivers/dax/dax-private.h | 4 > drivers/dax/device.c | 43 ---

Re: dev_pagemap related cleanups v2

2019-06-18 Thread Dan Williams
On Mon, Jun 17, 2019 at 5:27 AM Christoph Hellwig wrote: > > Hi Dan, Jérôme and Jason, > > below is a series that cleans up the dev_pagemap interface so that > it is more easily usable, which removes the need to wrap it in hmm > and thus allowing to kill a lot of code > > Note: this series is on t

Re: [PATCH] drm: Permit video-buffers writecombine mapping for MIPS

2019-06-18 Thread Sean Paul
On Mon, Jun 17, 2019 at 04:47:30PM +0300, Serge Semin wrote: > Hello folks, > > Any updates of this patch status? It has been here for about two months. > Sorry for the mixup, looks like this one just fell through the cracks. I've applied it to drm-misc-next with the attached Ack and Review. Se

[PATCH 0/5] drm/msm: mdp5+dpu interconnect support

2019-06-18 Thread Rob Clark
From: Rob Clark Most of this is a resend of things that have already been posted to list. I've rebased the DPU patches, which was somewhat conflicty due to other changes and refactoring in the DPU code. Abhinav Kumar (1): drm/msm/dpu: add icc voting in dpu_mdss_init Georgi Djakov (1): drm/

[PATCH 3/5] dt-bindings: msm/disp: Introduce interconnect bindings for MDSS on SDM845

2019-06-18 Thread Rob Clark
From: Jayant Shekhar Add interconnect properties such as interconnect provider specifier , the edge source and destination ports which are required by the interconnect API to configure interconnect path for MDSS. Changes in v2: - None Changes in v3: - Remove common property defi

[PATCH 2/5] drm/msm/dpu: Integrate interconnect API in MDSS

2019-06-18 Thread Rob Clark
From: Jayant Shekhar The interconnect framework is designed to provide a standard kernel interface to control the settings of the interconnects on a SoC. The interconnect API uses a consumer/provider-based model, where the providers are the interconnect buses and the consumers could be various d

[PATCH 4/5] drm/msm/dpu: add icc voting in dpu_mdss_init

2019-06-18 Thread Rob Clark
From: Abhinav Kumar dpu_mdss_destroy() can get called not just from msm_drm_uninit() but also from msm_drm_bind() in case of any failures. dpu_mdss_destroy() removes the icc voting by calling icc_put. This could accidentally remove the voting done by pm_runtime_enable. To make the voting balanc

[PATCH 1/5] drm/msm/dpu: clean up references of DPU custom bus scaling

2019-06-18 Thread Rob Clark
From: Jayant Shekhar Since the upstream interconnect bus framework has landed upstream, the existing references of custom bus scaling needs to be cleaned up. Changes in v2: - Fixed build error due to partial clean up Changes in v3: - Condense multiple lines into a single line (S

<    1   2   3   >