Re: [PATCH v3 hmm 11/12] mm/hmm: Remove confusing comment and logic from hmm_release

2019-06-18 Thread Jason Gunthorpe
On Sat, Jun 15, 2019 at 07:21:06AM -0700, Christoph Hellwig wrote: > On Thu, Jun 13, 2019 at 09:44:49PM -0300, Jason Gunthorpe wrote: > > From: Jason Gunthorpe > > > > hmm_release() is called exactly once per hmm. ops->release() cannot > > accidentally trigger any action that would recurse back o

Re: [PATCH v3 2/7] lib/hexdump.c: Relax rowsize checks in hex_dump_to_buffer

2019-06-18 Thread Alastair D'Silva
On Mon, 2019-06-17 at 15:47 -0700, Randy Dunlap wrote: > Hi, > Just a comment style nit below... > > On 6/16/19 7:04 PM, Alastair D'Silva wrote: > > From: Alastair D'Silva > > > > This patch removes the hardcoded row limits and allows for > > other lengths. These lengths must still be a multiple

Re: [PATCH v17 03/15] arm64: Introduce prctl() options to control the tagged user addresses ABI

2019-06-18 Thread Szabolcs Nagy
On 17/06/2019 14:56, Catalin Marinas wrote: > On Wed, Jun 12, 2019 at 01:43:20PM +0200, Andrey Konovalov wrote: >> From: Catalin Marinas >> >> It is not desirable to relax the ABI to allow tagged user addresses into >> the kernel indiscriminately. This patch introduces a prctl() interface >> for e

Re: [PATCH 16/25] PCI/P2PDMA: use the dev_pagemap internal refcount

2019-06-18 Thread Logan Gunthorpe
On 2019-06-17 6:27 a.m., Christoph Hellwig wrote: > The functionality is identical to the one currently open coded in > p2pdma.c. > > Signed-off-by: Christoph Hellwig Reviewed-by: Logan Gunthorpe I also did a quick test with the full patch-set to ensure that the setup and tear down paths for

Re: [PATCH libdrm v2 4/4] meson.build: Fix meson script on FreeBSD

2019-06-18 Thread Niclas Zeising
On 2019-06-17 11:14, Eric Engestrom wrote: On Sunday, 2019-06-16 14:23:43 +0100, Emil Velikov wrote: From: Niclas Zeising FreeBSD requires sys/types.h for sys/sysctl.h, add it as part of the includes when checking for headers. Instead of splitting out the check for sys/sysctl.h from the other

[PATCH] drm/amd/powerplay: Delete a redundant memory setting in vega20_set_default_od8_setttings()

2019-06-18 Thread Markus Elfring
From: Markus Elfring Date: Mon, 17 Jun 2019 14:24:14 +0200 The memory was set to zero already by a call of the function “kzalloc”. Thus remove an extra call of the function “memset” for this purpose. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- d

Re: [PATCH v2 2/2] arm: dts: add ARM Mali GPU node for Odroid XU3

2019-06-18 Thread Joseph Kogut
Hi Krzysztof, Thanks for the review. On Sun, Jun 16, 2019 at 1:59 AM Krzysztof Kozlowski wrote: > > On Fri, Jun 14, 2019 at 04:57:19PM -0700, Joseph Kogut wrote: > > Add device tree node for mali gpu on Odroid XU3 SoCs. > > > > Signed-off-by: Joseph Kogut > > --- > > > > Changes v1 -> v2: > > -

Re: [PATCH v17 03/15] arm64: Introduce prctl() options to control the tagged user addresses ABI

2019-06-18 Thread Catalin Marinas
On Mon, Jun 17, 2019 at 09:57:36AM -0700, Evgenii Stepanov wrote: > On Mon, Jun 17, 2019 at 6:56 AM Catalin Marinas > wrote: > > On Wed, Jun 12, 2019 at 01:43:20PM +0200, Andrey Konovalov wrote: > > > From: Catalin Marinas > > > > > > It is not desirable to relax the ABI to allow tagged user add

Re: [PATCH v3 hmm 10/12] mm/hmm: Do not use list*_rcu() for hmm->ranges

2019-06-18 Thread Jason Gunthorpe
On Sat, Jun 15, 2019 at 07:18:26AM -0700, Christoph Hellwig wrote: > On Thu, Jun 13, 2019 at 09:44:48PM -0300, Jason Gunthorpe wrote: > > range->hmm = hmm; > > kref_get(&hmm->kref); > > - list_add_rcu(&range->list, &hmm->ranges); > > + list_add(&range->list, &hmm->ranges); > > > >

Re: [PATCH 08/25] memremap: move dev_pagemap callbacks into a separate structure

2019-06-18 Thread Logan Gunthorpe
On 2019-06-17 6:27 a.m., Christoph Hellwig wrote: > diff --git a/drivers/pci/p2pdma.c b/drivers/pci/p2pdma.c > index a98126ad9c3a..e083567d26ef 100644 > --- a/drivers/pci/p2pdma.c > +++ b/drivers/pci/p2pdma.c > @@ -100,7 +100,7 @@ static void pci_p2pdma_percpu_cleanup(struct percpu_ref > *ref) >

Re: [PATCH v3 hmm 04/12] mm/hmm: Simplify hmm_get_or_create and make it reliable

2019-06-18 Thread Jason Gunthorpe
On Sat, Jun 15, 2019 at 07:12:11AM -0700, Christoph Hellwig wrote: > > + spin_lock(&mm->page_table_lock); > > + if (mm->hmm) { > > + if (kref_get_unless_zero(&mm->hmm->kref)) { > > + spin_unlock(&mm->page_table_lock); > > + return mm->hmm; > > +

Re: [linux-sunxi] Re: [PATCH v2 5/9] drm/sun4i: tcon_top: Register clock gates in probe

2019-06-18 Thread Jagan Teki
On Mon, Jun 17, 2019 at 6:31 PM Chen-Yu Tsai wrote: > > On Mon, Jun 17, 2019 at 7:45 PM Maxime Ripard > wrote: > > > > On Fri, Jun 14, 2019 at 10:13:20PM +0530, Jagan Teki wrote: > > > TCON TOP have clock gates for TV0, TV1, dsi and right > > > now these are register during bind call. > > > > >

Re: [PATCH v17 03/15] arm64: Introduce prctl() options to control the tagged user addresses ABI

2019-06-18 Thread Catalin Marinas
On Wed, Jun 12, 2019 at 01:43:20PM +0200, Andrey Konovalov wrote: > From: Catalin Marinas > > It is not desirable to relax the ABI to allow tagged user addresses into > the kernel indiscriminately. This patch introduces a prctl() interface > for enabling or disabling the tagged ABI with a global

Re: [PATCH v17 03/15] arm64: Introduce prctl() options to control the tagged user addresses ABI

2019-06-18 Thread Evgenii Stepanov
On Mon, Jun 17, 2019 at 10:18 AM Catalin Marinas wrote: > > On Mon, Jun 17, 2019 at 09:57:36AM -0700, Evgenii Stepanov wrote: > > On Mon, Jun 17, 2019 at 6:56 AM Catalin Marinas > > wrote: > > > On Wed, Jun 12, 2019 at 01:43:20PM +0200, Andrey Konovalov wrote: > > > > From: Catalin Marinas > >

Re: [PATCH v17 03/15] arm64: Introduce prctl() options to control the tagged user addresses ABI

2019-06-18 Thread Evgenii Stepanov
On Mon, Jun 17, 2019 at 6:56 AM Catalin Marinas wrote: > > On Wed, Jun 12, 2019 at 01:43:20PM +0200, Andrey Konovalov wrote: > > From: Catalin Marinas > > > > It is not desirable to relax the ABI to allow tagged user addresses into > > the kernel indiscriminately. This patch introduces a prctl()

Re: [PATCH v3 2/7] lib/hexdump.c: Relax rowsize checks in hex_dump_to_buffer

2019-06-18 Thread Randy Dunlap
Hi, Just a comment style nit below... On 6/16/19 7:04 PM, Alastair D'Silva wrote: > From: Alastair D'Silva > > This patch removes the hardcoded row limits and allows for > other lengths. These lengths must still be a multiple of > groupsize. > > This allows structs that are not 16/32 bytes to d

[PATCH] drm/amd/display: Delete a redundant memory setting in amdgpu_dm_irq_register_interrupt()

2019-06-18 Thread Markus Elfring
From: Markus Elfring Date: Mon, 17 Jun 2019 13:56:39 +0200 The memory was set to zero already by a call of the function “kzalloc”. Thus remove an extra call of the function “memset” for this purpose. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- d

[PATCH] drm/amd/display: Add missing newline at end of file

2019-06-18 Thread Geert Uytterhoeven
"git diff" says: \ No newline at end of file after modifying the file. Signed-off-by: Geert Uytterhoeven --- drivers/gpu/drm/amd/display/modules/power/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/modules/power/Makefile b/drivers/

arm32 build failure after abe882a39a9c ("drm/amd/display: fix issue with eDP not detected on driver load")

2019-06-18 Thread Nathan Chancellor
Hi all, After commit abe882a39a9c ("drm/amd/display: fix issue with eDP not detected on driver load") in -next, arm32 allyesconfig builds start failing at link time: arm-linux-gnueabi-ld: drivers/gpu/drm/amd/display/dc/core/dc_link.o: in function `dc_link_detect': dc_link.c:(.text+0x260c): undefi

Re: [linux-sunxi] [PATCH v2 5/9] drm/sun4i: tcon_top: Register clock gates in probe

2019-06-18 Thread Chen-Yu Tsai
On Mon, Jun 17, 2019 at 6:30 PM Jagan Teki wrote: > > On Sun, Jun 16, 2019 at 11:01 AM Chen-Yu Tsai wrote: > > > > On Sat, Jun 15, 2019 at 12:44 AM Jagan Teki > > wrote: > > > > > > TCON TOP have clock gates for TV0, TV1, dsi and right > > > now these are register during bind call. > > > > > >

Re: [EXT] Re: [PATCH 2/2] drm/panel: Add support for Raydium RM67191 panel driver

2019-06-18 Thread Robert Chiras
Hi Sam, Thank you for your suggestions. See my reply inline. On Vi, 2019-06-14 at 17:10 +0200, Sam Ravnborg wrote: > Hi Robert. > > On top of the feedback from Fabio here is a bit more. > > > > > + > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#

Re: [PATCH 1/2] dt-bindings: gpu: add Exynos Mali vendor specifics

2019-06-18 Thread Krzysztof Kozlowski
On Tue, 18 Jun 2019 at 00:06, Rob Herring wrote: > > On Sun, Jun 16, 2019 at 2:16 AM Krzysztof Kozlowski wrote: > > > > On Fri, Jun 14, 2019 at 01:31:43PM -0700, Joseph Kogut wrote: > > > Document vendor specific compatible string for Mali gpus on Exynos SoCs. > > > > > > Signed-off-by: Joseph Ko

Re: [linux-sunxi] Re: [PATCH v2 5/9] drm/sun4i: tcon_top: Register clock gates in probe

2019-06-18 Thread Chen-Yu Tsai
On Tue, Jun 18, 2019 at 3:12 PM Jagan Teki wrote: > > On Mon, Jun 17, 2019 at 6:31 PM Chen-Yu Tsai wrote: > > > > On Mon, Jun 17, 2019 at 7:45 PM Maxime Ripard > > wrote: > > > > > > On Fri, Jun 14, 2019 at 10:13:20PM +0530, Jagan Teki wrote: > > > > TCON TOP have clock gates for TV0, TV1, dsi

[git pull] vmwgfx-fixes-5.2

2019-06-18 Thread VMware
Dave, Daniel, A couple of fixes for vmwgfx. Two fixes for a DMA sg-list debug warning message. These are not cc'd stable since there is no evidence of actual breakage. On fix for the high-bandwidth backdoor port which is cc'd stable due to upcoming hardware, on which the code would otherwise break

Re: [PATCH] drm/rcar-du: Fix error check when retrieving crtc state

2019-06-18 Thread Laurent Pinchart
Hi Sean, Thank you for the patch. On Mon, Jun 17, 2019 at 02:15:42PM -0400, Sean Paul wrote: > From: Sean Paul > > drm_atomic_get_crtc_state() returns an error pointer when it fails, so > the null check is doing nothing here. > > Credit to 0-day/Dan Carpenter for reporting this. > > Fixes: 6f

Re: [PATCH 26/59] drm/rcar-du: Drop drm_gem_prime_export/import

2019-06-18 Thread Laurent Pinchart
Hi Daniel, Thank you for the patch. On Fri, Jun 14, 2019 at 10:35:42PM +0200, Daniel Vetter wrote: > They're the default. > > Aside: Would be really nice to switch the others over to > drm_gem_object_funcs. > > Signed-off-by: Daniel Vetter > Cc: Laurent Pinchart > Cc: Kieran Bingham > Cc: li

Re: [PATCH 28/59] drm/shmob: Drop drm_gem_prime_export/import

2019-06-18 Thread Laurent Pinchart
Hi Daniel, Thank you for the patch. On Fri, Jun 14, 2019 at 10:35:44PM +0200, Daniel Vetter wrote: > They're the default. > > Aside: Would be really nice to switch the others over to > drm_gem_object_funcs. > > Signed-off-by: Daniel Vetter > Cc: Laurent Pinchart > Cc: Kieran Bingham > Cc: li

Re: [PATCH 3/4] drm/virtio: simplify cursor updates

2019-06-18 Thread Gerd Hoffmann
> Even nicer would be to add the fence using > drm_atomic_set_fence_for_plane() in the prepare_fb hook. Assuming this > isn't necessary for correctness (but then I kinda have questions about > races and stuff). I'll have a look. Maybe this way I can drop struct virtio_gpu_framebuffer (where the f

Re: [linux-sunxi] [PATCH v2 5/9] drm/sun4i: tcon_top: Register clock gates in probe

2019-06-18 Thread Jagan Teki
On Tue, Jun 18, 2019 at 12:49 PM Chen-Yu Tsai wrote: > > On Mon, Jun 17, 2019 at 6:30 PM Jagan Teki wrote: > > > > On Sun, Jun 16, 2019 at 11:01 AM Chen-Yu Tsai wrote: > > > > > > On Sat, Jun 15, 2019 at 12:44 AM Jagan Teki > > > wrote: > > > > > > > > TCON TOP have clock gates for TV0, TV1, d

Re: [linux-sunxi] Re: [PATCH v2 5/9] drm/sun4i: tcon_top: Register clock gates in probe

2019-06-18 Thread Jagan Teki
On Tue, Jun 18, 2019 at 12:53 PM Chen-Yu Tsai wrote: > > On Tue, Jun 18, 2019 at 3:12 PM Jagan Teki wrote: > > > > On Mon, Jun 17, 2019 at 6:31 PM Chen-Yu Tsai wrote: > > > > > > On Mon, Jun 17, 2019 at 7:45 PM Maxime Ripard > > > wrote: > > > > > > > > On Fri, Jun 14, 2019 at 10:13:20PM +0530

Re: [linux-sunxi] [PATCH v2 5/9] drm/sun4i: tcon_top: Register clock gates in probe

2019-06-18 Thread Chen-Yu Tsai
On Tue, Jun 18, 2019 at 3:45 PM Jagan Teki wrote: > > On Tue, Jun 18, 2019 at 12:49 PM Chen-Yu Tsai wrote: > > > > On Mon, Jun 17, 2019 at 6:30 PM Jagan Teki > > wrote: > > > > > > On Sun, Jun 16, 2019 at 11:01 AM Chen-Yu Tsai wrote: > > > > > > > > On Sat, Jun 15, 2019 at 12:44 AM Jagan Teki

Re: [PATCH V2 4/5] drm/vkms: Use index instead of 0 in possible crtc

2019-06-18 Thread Simon Ser
Interestingly, even with the previous code, possible_crtcs=1 was exposed to userspace [1]. I think this is because of a safeguard in drm_crtc_init_with_planes (drm_crtc.c:284) which sets the primary and cursor plane's possible_crtcs to the first CRTC if zero. If we want to warn on possible_crtcs=0

Re: [PATCH 40/59] drm/vram-helper: Drop drm_gem_prime_export/import

2019-06-18 Thread Daniel Vetter
On Tue, Jun 18, 2019 at 6:49 AM Gerd Hoffmann wrote: > > Hi, > > > > While most callbacks are pretty straight forward (just hook the same > > > callbacks into the drm_gem_object_funcs. struct) the mmap bits are a > > > bit more obscure. > > > > > > First, there seem to be two ways to mmap a gem

[PATCH 2/2] drm/komeda: Enable dual-link support

2019-06-18 Thread james qian wang (Arm Technology China)
Komeda HW can support dual-link which splits display frame to two halves (left/link0, right/link1) and output them by two output links. Due to the halved pixel rate of each link, the pxlclk of dual-link can be reduced two times compare with single-link. For enabling dual-link: - The DT need to con

[PATCH 0/2] drm/komeda: Enable dual-link support

2019-06-18 Thread james qian wang (Arm Technology China)
Komeda HW can support dual-link which splits display frame to two halves (left/link0, right/link1) and output them by two output links. Due to the halved pixel rate of each link, the pxlclk of dual-link can be reduced two times compare with single-link. For enabling dual-link: - The DT need to con

[PATCH 1/2] drm/komeda: Use drm_display_mode "crtc_" prefixed hardware timings

2019-06-18 Thread james qian wang (Arm Technology China)
struct drm_display_mode contains two copies of timings. - plain timings. - hardware timings, the ones with "crtc_" prefix. According to the definition, update komeda to use the hardware timing. Signed-off-by: James Qian Wang (Arm Technology China) --- .../arm/display/komeda/d71/d71_component.c

[PATCH v2] drm/panfrost: Make sure a BO is only unmapped when appropriate

2019-06-18 Thread Boris Brezillon
mmu_ops->unmap() will fail when called on a BO that has not been previously mapped, and the error path in panfrost_ioctl_create_bo() can call drm_gem_object_put_unlocked() (which in turn calls panfrost_mmu_unmap()) on a BO that has not been mapped yet. Keep track of the mapped/unmapped state to av

[PATCH v4 3/4] drm/panfrost: Add an helper to check the GPU generation

2019-06-18 Thread Boris Brezillon
All models with an ID >= 0x1000 are Bifrost GPUs for now (might change with new gens). Suggested-by: Alyssa Rosenzweig Signed-off-by: Boris Brezillon Reviewed-by: Alyssa Rosenzweig --- Changes in v4: - Add Alyssa's R-b Changes in v3: * New patch --- drivers/gpu/drm/panfrost/panfrost_device.h

[PATCH v4 4/4] drm/panfrost: Expose performance counters through unstable ioctls

2019-06-18 Thread Boris Brezillon
Expose performance counters through 2 driver specific ioctls: one to enable/disable the perfcnt block, and one to dump the counter values. There are discussions to expose global performance monitors (those counters that can't be retrieved on a per-job basis) in a consistent way, but this is likely

[PATCH v4 2/4] drm/panfrost: Add a module parameter to expose unstable ioctls

2019-06-18 Thread Boris Brezillon
We plan to expose performance counters through 2 driver specific ioctls until there's a solution to expose them in a generic way. In order to be able to deprecate those ioctls when this new infrastructure is in place we add an unsafe module parameter that will keep those ioctls hidden unless it's s

[PATCH v4 0/4] drm/panfrost: Expose perf counters to userspace

2019-06-18 Thread Boris Brezillon
Hello, This a new version of the panfrost perfcnt series, this time exposing this functionality through 2 ioctls instead of the debugfs approach used in v2. I also went for Emil's suggestion to expose those ioctls only when the unstable_iocts unsafe param is set to true. This way, I hope we'll be

[PATCH v4 1/4] drm/panfrost: Move gpu_{write, read}() macros to panfrost_regs.h

2019-06-18 Thread Boris Brezillon
So they can be used from other files. Signed-off-by: Boris Brezillon Reviewed-by: Alyssa Rosenzweig --- Changes in v4: - Add Alyssa's R-b Changes in v3: - None Changes in v2: - None --- drivers/gpu/drm/panfrost/panfrost_gpu.c | 3 --- drivers/gpu/drm/panfrost/panfrost_regs.h | 3 +++ 2 files

Re: [PATCH 2/3] drm/vkms: stop generating CRCs on buffer overflow

2019-06-18 Thread Daniel Vetter
On Mon, Jun 17, 2019 at 10:53:46PM -0300, Rodrigo Siqueira wrote: > Hi Oleg, > > First of all, thank you for your patchset. > > On 06/13, Daniel Vetter wrote: > > On Thu, Jun 13, 2019 at 03:18:01PM +0300, Oleg Vasilev wrote: > > > Because interrupts are generated artifitially, kernel bug may lead

Re: [PATCH 01/10] drm/vkms: Fix crc worker races

2019-06-18 Thread Daniel Vetter
On Mon, Jun 17, 2019 at 11:39:31PM -0300, Rodrigo Siqueira wrote: > On 06/12, Daniel Vetter wrote: > > On Wed, Jun 12, 2019 at 10:33:11AM -0300, Rodrigo Siqueira wrote: > > > On Thu, Jun 6, 2019 at 7:28 PM Daniel Vetter > > > wrote: > > > > > > > > The issue we have is that the crc worker might f

Re: [PATCH 00/10] drm/vkms: rework crc worker

2019-06-18 Thread Daniel Vetter
On Mon, Jun 17, 2019 at 11:49:04PM -0300, Rodrigo Siqueira wrote: > On 06/12, Daniel Vetter wrote: > > On Wed, Jun 12, 2019 at 10:28:41AM -0300, Rodrigo Siqueira wrote: > > > Hi Daniel, > > > > > > First of all, thank you very much for your patchset. > > > > > > I tried to make a detailed review

Re: [RFC PATCH 2/2] soc: ti: Add Support for the TI Page-based Address Translator (PAT)

2019-06-18 Thread Tero Kristo
On 07/06/2019 22:35, Andrew F. Davis wrote: This patch adds a driver for the Page-based Address Translator (PAT) present on various TI SoCs. A PAT device performs address translation using tables stored in an internal SRAM. Each PAT supports a set number of pages, each occupying a programmable 4K

Re: [PULL] topic/remove-fbcon-notifiers for v5.3

2019-06-18 Thread Maarten Lankhorst
Op 14-06-2019 om 11:25 schreef Maarten Lankhorst: > Hi all, > > As discussed with Daniel V, I'm just doing the paperwork here as drm-misc > maintainer. > > This is the topic pull request for the fbdev notifier removal. > > Bar, please make a final check and pull into your fbdev tree. > > Lee, plea

[PATCH 2/2] drm/prime: Update docs

2019-06-18 Thread Daniel Vetter
Yes this is a bit a big patch, but since it's essentially a complete rewrite of all the prime docs I didn't see how to better split it up. Changes: - Consistently point to drm_gem_object_funcs as the preferred hooks, where applicable. - Document all the hooks in &drm_driver that lacked kerneldo

[PATCH 1/2] drm/prime: Shuffle functions.

2019-06-18 Thread Daniel Vetter
Reorder all the functions in drm_prime.[hc] into three groups: core, export helpers, import helpers. Not other changes beyond moving the functions and their unchanged kerneldoc around in here. Cc: Sam Ravnborg Cc: Eric Anholt Cc: Emil Velikov Signed-off-by: Daniel Vetter --- drivers/gpu/drm/

[Bug 109754] util_blitter_generate_mipmap: Assertion `!util_format_has_stencil(desc)' failed

2019-06-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109754 Pierre-Eric Pelloux-Prayer changed: What|Removed |Added Status|NEW |RESOLVED Resolutio

Re: [PATCH V2 1/5] drm/vkms: Move functions from vkms_crc to vkms_composer

2019-06-18 Thread Daniel Vetter
On Mon, Jun 17, 2019 at 11:42:33PM -0300, Rodrigo Siqueira wrote: > The vkms_crc file has functions related to compose operations which are > not directly associated with CRC. This patch, move those function for a > new file named vkms_composer. > > Signed-off-by: Rodrigo Siqueira I guess my sug

Re: [PATCH v2 2/2] arm: dts: add ARM Mali GPU node for Odroid XU3

2019-06-18 Thread Krzysztof Kozlowski
On Sat, 15 Jun 2019 at 01:57, Joseph Kogut wrote: > > Add device tree node for mali gpu on Odroid XU3 SoCs. > > Signed-off-by: Joseph Kogut > --- > > Changes v1 -> v2: > - Use interrupt name ordering from binding doc > - Specify a single clock for GPU node > - Add gpu opp table > - Fix warnings f

Re: [PATCH V2 4/5] drm/vkms: Use index instead of 0 in possible crtc

2019-06-18 Thread Daniel Vetter
On Mon, Jun 17, 2019 at 11:45:29PM -0300, Rodrigo Siqueira wrote: > When vkms calls drm_universal_plane_init(), it sets 0 for the > possible_crtcs parameter which works well for a single encoder and > connector; however, this approach is not flexible and does not fit well > for vkms. This commit ad

Re: [PATCH V2 5/5] drm/vkms: Add support for writeback

2019-06-18 Thread Daniel Vetter
On Mon, Jun 17, 2019 at 11:45:55PM -0300, Rodrigo Siqueira wrote: > This patch implements the necessary functions to add writeback support > for vkms. This feature is useful for testing compositors if you don't > have hardware with writeback support. > > Change in V2: > - Rework signal completion

Re: [PATCH 20/59] drm/meson: Drop drm_gem_prime_export/import

2019-06-18 Thread Neil Armstrong
On 14/06/2019 22:35, Daniel Vetter wrote: > They're the default. > > Aside: Would be really nice to switch the others over to > drm_gem_object_funcs. Yep, adding this to my infinite TODO list > > Signed-off-by: Daniel Vetter > Cc: Neil Armstrong > Cc: Kevin Hilman > Cc: linux-amlo...@lists.i

Re: [PATCH 30/59] drm/stm: Drop drm_gem_prime_export/import

2019-06-18 Thread Philippe CORNU
Hi Daniel, Acked-by: Philippe Cornu We will have a look to simplify this part of the code. Thank you for your patch. Philippe :-) On 6/14/19 10:35 PM, Daniel Vetter wrote: > They're the default. > > Aside: Would be really nice to switch the others over to > drm_gem_object_funcs. > > Signed-

Re: [PATCH 1/3] drm/stm: drv: fix suspend/resume

2019-06-18 Thread Philippe CORNU
Hi Yannick, Thank you for your patch. Acked-by: Philippe Cornu Philippe :-) On 6/17/19 9:18 AM, Yannick Fertré wrote: > Without this fix, the system can not go in "suspend" mode > due to an error in drv_suspend function. > > Fixes: 35ab6cf ("drm/stm: support runtime power management") > > Si

Re: [PULL] topic/remove-fbcon-notifiers for v5.3

2019-06-18 Thread Lee Jones
On Tue, 18 Jun 2019, Maarten Lankhorst wrote: > Op 14-06-2019 om 11:25 schreef Maarten Lankhorst: > > Hi all, > > > > As discussed with Daniel V, I'm just doing the paperwork here as drm-misc > > maintainer. > > > > This is the topic pull request for the fbdev notifier removal. > > > > Bar, pleas

Re: [PULL] topic/remove-fbcon-notifiers for v5.3

2019-06-18 Thread Daniel Vetter
On Tue, Jun 18, 2019 at 11:03:47AM +0100, Lee Jones wrote: > On Tue, 18 Jun 2019, Maarten Lankhorst wrote: > > > Op 14-06-2019 om 11:25 schreef Maarten Lankhorst: > > > Hi all, > > > > > > As discussed with Daniel V, I'm just doing the paperwork here as drm-misc > > > maintainer. > > > > > > This

Re: [linux-sunxi] [PATCH v2 5/9] drm/sun4i: tcon_top: Register clock gates in probe

2019-06-18 Thread Jagan Teki
On Tue, Jun 18, 2019 at 1:23 PM Chen-Yu Tsai wrote: > > On Tue, Jun 18, 2019 at 3:45 PM Jagan Teki wrote: > > > > On Tue, Jun 18, 2019 at 12:49 PM Chen-Yu Tsai wrote: > > > > > > On Mon, Jun 17, 2019 at 6:30 PM Jagan Teki > > > wrote: > > > > > > > > On Sun, Jun 16, 2019 at 11:01 AM Chen-Yu Ts

Re: [PATCH v3 07/10] drm: rcar-du: Provide for_each_group helper

2019-06-18 Thread Kieran Bingham
Hi Laurent, On 17/06/2019 22:09, Laurent Pinchart wrote: > From: Kieran Bingham > > Refactoring of the group control code will soon require more iteration > over the available groups. Simplify this process by introducing a group > iteration helper. > > Signed-off-by: Kieran Bingham > Signed-of

Re: [Intel-gfx] [PATCH 00/59] prime doc polish and ... a few cleanups

2019-06-18 Thread Emil Velikov
On 2019/06/17, Emil Velikov wrote: > Hi Daniel, > > On Fri, 14 Jun 2019 at 21:36, Daniel Vetter wrote: > > > > Hi all, > > > > So I figured let's get going and polish the docs for the last part of drm > > core/helpers that hasn't yet seen some neat polish last few years. With > > the goal to make

Re: [PATCH v10 01/11] drm/sun4i: dsi: Fix TCON DRQ set bits

2019-06-18 Thread Jagan Teki
On Fri, Jun 14, 2019 at 8:15 PM Maxime Ripard wrote: > > On Fri, Jun 14, 2019 at 12:03:13PM +0530, Jagan Teki wrote: > > On Thu, Jun 13, 2019 at 6:56 PM Maxime Ripard > > wrote: > > > > > > On Wed, Jun 05, 2019 at 01:17:11PM +0530, Jagan Teki wrote: > > > > On Tue, Jun 4, 2019 at 3:30 PM Maxime

Re: [linux-sunxi] [PATCH v2 5/9] drm/sun4i: tcon_top: Register clock gates in probe

2019-06-18 Thread Chen-Yu Tsai
On Tue, Jun 18, 2019 at 6:34 PM Jagan Teki wrote: > > On Tue, Jun 18, 2019 at 1:23 PM Chen-Yu Tsai wrote: > > > > On Tue, Jun 18, 2019 at 3:45 PM Jagan Teki > > wrote: > > > > > > On Tue, Jun 18, 2019 at 12:49 PM Chen-Yu Tsai wrote: > > > > > > > > On Mon, Jun 17, 2019 at 6:30 PM Jagan Teki

Re: [PATCH 1/4] drm/vmwgfx: Assign eviction priorities to resources

2019-06-18 Thread Emil Velikov
Hi Thomas, On 2019/06/18, Thomas Hellström (VMware) wrote: > From: Thomas Hellstrom > > TTM provides a means to assign eviction priorities to buffer object. This > means that all buffer objects with a lower priority will be evicted first > on memory pressure. > Use this to make sure surfaces and

Re: [PATCH v10 02/11] drm/sun4i: dsi: Update start value in video start delay

2019-06-18 Thread Jagan Teki
On Fri, Jun 14, 2019 at 7:58 PM Maxime Ripard wrote: > > On Thu, Jun 13, 2019 at 01:34:04PM +0530, Jagan Teki wrote: > > On Fri, May 31, 2019 at 12:23 AM Maxime Ripard > > wrote: > > > > > > On Fri, May 24, 2019 at 03:55:42PM +0530, Jagan Teki wrote: > > > > On Fri, May 24, 2019 at 2:07 AM Maxime

[Bug 110831] [AMD TAHITI XT][amd-staging-drm-next][bisected] broken since 5.2-rc1 rebase

2019-06-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110831 --- Comment #5 from Sylvain BERTRAND --- Did update the amd-staging-drm-next branch earlier today. The hanging boot is gone. Did a quick check: your patch was already applied. So it probably did fix it. -- You are receiving this mail because:

Re: [PATCH V2 4/5] drm/vkms: Use index instead of 0 in possible crtc

2019-06-18 Thread Daniel Vetter
On Tue, Jun 18, 2019 at 07:56:23AM +, Simon Ser wrote: > Interestingly, even with the previous code, possible_crtcs=1 was > exposed to userspace [1]. I think this is because of a safeguard in > drm_crtc_init_with_planes (drm_crtc.c:284) which sets the primary and > cursor plane's possible_crtcs

Re: [PULL] topic/remove-fbcon-notifiers for v5.3

2019-06-18 Thread Bartlomiej Zolnierkiewicz
Hi, On 6/18/19 11:20 AM, Maarten Lankhorst wrote: > Op 14-06-2019 om 11:25 schreef Maarten Lankhorst: >> Hi all, >> >> As discussed with Daniel V, I'm just doing the paperwork here as drm-misc >> maintainer. >> >> This is the topic pull request for the fbdev notifier removal. >> >> Bar, please m

Re: [PULL] topic/remove-fbcon-notifiers for v5.3

2019-06-18 Thread Lee Jones
On Tue, 18 Jun 2019, Daniel Vetter wrote: > On Tue, Jun 18, 2019 at 11:03:47AM +0100, Lee Jones wrote: > > On Tue, 18 Jun 2019, Maarten Lankhorst wrote: > > > > > Op 14-06-2019 om 11:25 schreef Maarten Lankhorst: > > > > Hi all, > > > > > > > > As discussed with Daniel V, I'm just doing the paper

Re: [linux-sunxi] Re: [PATCH v10 01/11] drm/sun4i: dsi: Fix TCON DRQ set bits

2019-06-18 Thread Chen-Yu Tsai
On Tue, Jun 18, 2019 at 6:51 PM Jagan Teki wrote: > > On Fri, Jun 14, 2019 at 8:15 PM Maxime Ripard > wrote: > > > > On Fri, Jun 14, 2019 at 12:03:13PM +0530, Jagan Teki wrote: > > > On Thu, Jun 13, 2019 at 6:56 PM Maxime Ripard > > > wrote: > > > > > > > > On Wed, Jun 05, 2019 at 01:17:11PM +

Re: [PULL] topic/remove-fbcon-notifiers for v5.3

2019-06-18 Thread Maarten Lankhorst
Op 18-06-2019 om 13:17 schreef Bartlomiej Zolnierkiewicz: > Hi, > > On 6/18/19 11:20 AM, Maarten Lankhorst wrote: >> Op 14-06-2019 om 11:25 schreef Maarten Lankhorst: >>> Hi all, >>> >>> As discussed with Daniel V, I'm just doing the paperwork here as drm-misc >>> maintainer. >>> >>> This is the t

Re: [PATCH 1/7] video: add HDMI state notifier support

2019-06-18 Thread Cheng-yi Chiang
On Tue, Jun 11, 2019 at 8:35 PM Daniel Vetter wrote: > > On Tue, Jun 11, 2019 at 08:10:38PM +0800, Cheng-yi Chiang wrote: > > On Tue, Jun 4, 2019 at 3:24 PM Daniel Vetter wrote: > > > > > > On Tue, Jun 04, 2019 at 10:32:50AM +0800, Cheng-yi Chiang wrote: > > > > On Mon, Jun 3, 2019 at 4:09 PM Dan

[PATCH 5/6] drm/amdgpu: add independent DMA-buf export v6

2019-06-18 Thread Christian König
The caching of SGT's is actually quite harmful and should probably removed altogether when all drivers are audited. Start by providing a separate DMA-buf export implementation in amdgpu. This is also a prerequisite of unpinned DMA-buf handling. v2: fix unintended recursion, remove debugging lefto

Re: [PATCH 1/7] video: add HDMI state notifier support

2019-06-18 Thread Cheng-yi Chiang
On Tue, Jun 11, 2019 at 9:11 PM Hans Verkuil wrote: > > On 6/11/19 2:10 PM, Cheng-yi Chiang wrote: > > On Tue, Jun 4, 2019 at 3:24 PM Daniel Vetter wrote: > >> > >> On Tue, Jun 04, 2019 at 10:32:50AM +0800, Cheng-yi Chiang wrote: > >>> On Mon, Jun 3, 2019 at 4:09 PM Daniel Vetter wrote: > >

[PATCH 6/6] drm/amdgpu: add independent DMA-buf import v6

2019-06-18 Thread Christian König
Instead of relying on the DRM functions just implement our own import functions. This prepares support for taking care of unpinned DMA-buf. v2: enable for all exporters, not just amdgpu, fix invalidation handling, lock reservation object while setting callback v3: change to new dma_buf attach

[PATCH 1/6] dma-buf: add dynamic DMA-buf handling v10

2019-06-18 Thread Christian König
On the exporter side we add optional explicit pinning callbacks. If those callbacks are implemented the framework no longer caches sg tables and the map/unmap callbacks are always called with the lock of the reservation object held. On the importer side we add an optional invalidate callback. This

[PATCH v2] drm/mcde: Fix uninitialized variable

2019-06-18 Thread Linus Walleij
We need to handle the case when of_drm_find_bridge() returns NULL. Reported-by: Dan Carpenter Cc: Dan Carpenter Signed-off-by: Linus Walleij --- ChangeLog v1->v2: - Account for both NULL and error pointers by two clauses. --- drivers/gpu/drm/mcde/mcde_drv.c | 6 +- 1 file changed, 5 insert

[PATCH 4/6] drm/amdgpu: use allowed_domains for exported DMA-bufs

2019-06-18 Thread Christian König
Avoid that we ping/pong the buffers when we stop to pin DMA-buf exports by using the allowed domains for exported buffers. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/

[PATCH 2/6] drm/ttm: remove the backing store if no placement is given

2019-06-18 Thread Christian König
Pipeline removal of the BOs backing store when no placement is given during validation. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c index c7de667d482a

[PATCH 3/6] drm/ttm: use the parent resv for ghost objects v2

2019-06-18 Thread Christian König
This way we can even pipeline imported BO evictions. v2: Limit this to only cases when the parent object uses a separate reservation object as well. This fixes another OOM problem. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo_util.c | 20 +++- 1 file changed

Re: [PATCH 1/2] drm: debugfs: make drm_debugfs_remove_files() a void function

2019-06-18 Thread Greg Kroah-Hartman
On Fri, Jun 14, 2019 at 05:37:58PM +0200, Daniel Vetter wrote: > On Fri, Jun 14, 2019 at 5:20 PM Greg Kroah-Hartman > wrote: > > > > On Fri, Jun 14, 2019 at 04:59:08PM +0200, Daniel Vetter wrote: > > > On Fri, Jun 14, 2019 at 11:51:09AM +0200, Greg Kroah-Hartman wrote: > > > > The function can not

Re: [linux-sunxi] Re: [PATCH v10 01/11] drm/sun4i: dsi: Fix TCON DRQ set bits

2019-06-18 Thread Jagan Teki
On Tue, Jun 18, 2019 at 5:13 PM Chen-Yu Tsai wrote: > > On Tue, Jun 18, 2019 at 6:51 PM Jagan Teki wrote: > > > > On Fri, Jun 14, 2019 at 8:15 PM Maxime Ripard > > wrote: > > > > > > On Fri, Jun 14, 2019 at 12:03:13PM +0530, Jagan Teki wrote: > > > > On Thu, Jun 13, 2019 at 6:56 PM Maxime Ripar

Re: [PATCH 1/7] video: add HDMI state notifier support

2019-06-18 Thread Daniel Vetter
On Tue, Jun 18, 2019 at 07:48:06PM +0800, Cheng-yi Chiang wrote: > On Tue, Jun 11, 2019 at 8:35 PM Daniel Vetter wrote: > > > > On Tue, Jun 11, 2019 at 08:10:38PM +0800, Cheng-yi Chiang wrote: > > > On Tue, Jun 4, 2019 at 3:24 PM Daniel Vetter wrote: > > > > > > > > On Tue, Jun 04, 2019 at 10:32:

Re: [PATCH 1/2] drm: debugfs: make drm_debugfs_remove_files() a void function

2019-06-18 Thread Daniel Vetter
On Tue, Jun 18, 2019 at 02:01:35PM +0200, Greg Kroah-Hartman wrote: > On Fri, Jun 14, 2019 at 05:37:58PM +0200, Daniel Vetter wrote: > > On Fri, Jun 14, 2019 at 5:20 PM Greg Kroah-Hartman > > wrote: > > > > > > On Fri, Jun 14, 2019 at 04:59:08PM +0200, Daniel Vetter wrote: > > > > On Fri, Jun 14,

Re: [PATCH 1/4] drm/vmwgfx: Assign eviction priorities to resources

2019-06-18 Thread Daniel Vetter
On Tue, Jun 18, 2019 at 11:54:08AM +0100, Emil Velikov wrote: > Hi Thomas, > > On 2019/06/18, Thomas Hellström (VMware) wrote: > > From: Thomas Hellstrom > > > > TTM provides a means to assign eviction priorities to buffer object. This > > means that all buffer objects with a lower priority will

Re: [PATCH v2] drm/mcde: Fix uninitialized variable

2019-06-18 Thread Dan Carpenter
Thanks! regards, dan carpenter ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 48/59] drm/vgem: Ditch attach trickery in the fence ioctl

2019-06-18 Thread Chris Wilson
Quoting Daniel Vetter (2019-06-14 21:36:04) > It looks like this was done purely to get a consistent place to look > up the reservation object pointer. With the drm_prime.c helper code > now also setting gem_object->resv for imported objects we can just use > that pointer directly, instead of first

Re: [PATCH v3 02/10] media: vsp1: drm: Don't configure hardware when the pipeline is disabled

2019-06-18 Thread Kieran Bingham
Hi Laurent, On 17/06/2019 22:09, Laurent Pinchart wrote: > The vsp1_du_atomic_flush() function calls vsp1_du_pipeline_configure() > to configure the hardware pipeline. The function is currently guaranteed > to be called with the pipeline enabled, but this will change by future > rework of the DU d

Re: [PATCH v3 01/10] media: vsp1: drm: Split vsp1_du_setup_lif()

2019-06-18 Thread Ulrich Hecht
Thank you for your patch. > On June 17, 2019 at 11:09 PM Laurent Pinchart > wrote: > > > From: Kieran Bingham > > Break vsp1_du_setup_lif() into components more suited to the DRM Atomic > API. The existing vsp1_du_setup_lif() API call is maintained as it is > still used from the DU. > > Sig

Re: [PATCH v3 02/10] media: vsp1: drm: Don't configure hardware when the pipeline is disabled

2019-06-18 Thread Ulrich Hecht
> On June 17, 2019 at 11:09 PM Laurent Pinchart > wrote: > > > The vsp1_du_atomic_flush() function calls vsp1_du_pipeline_configure() > to configure the hardware pipeline. The function is currently guaranteed > to be called with the pipeline enabled, but this will change by future > rework of

Re: [PATCH v3 03/10] drm: rcar-du: Convert to the new VSP atomic API

2019-06-18 Thread Ulrich Hecht
> On June 17, 2019 at 11:09 PM Laurent Pinchart > wrote: > > > From: Kieran Bingham > > The configuration API between the VSP and the DU has been updated to > provide finer grain control over modesetting, and enablement. > > Split rcar_du_vsp_enable() into rcar_du_vsp_modeset() and > rcar_

Re: [PATCH v3 04/10] media: vsp1: drm: Remove vsp1_du_setup_lif()

2019-06-18 Thread Ulrich Hecht
> On June 17, 2019 at 11:09 PM Laurent Pinchart > wrote: > > > From: Kieran Bingham > > The vsp1_du_setup_lif() function is deprecated, and the users have been > removed. Remove the implementation and the associated configuration > structure. > > Signed-off-by: Kieran Bingham > Signed-off

[Bug 110831] [AMD TAHITI XT][amd-staging-drm-next][bisected] broken since 5.2-rc1 rebase

2019-06-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110831 Sylvain BERTRAND changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

Re: [PATCH] backlight: gpio-backlight: Set power state instead of brightness at probe

2019-06-18 Thread Paul Kocialkowski
Hi, On Fri, 2019-05-17 at 17:05 +0200, Paul Kocialkowski wrote: > On a trivial gpio-backlight setup with a panel using the backlight but > no boot software to enable it beforehand, we fall in a case where the > backlight is disabled (not just blanked) and thus remains disabled when > the panel get

[PATCH] drm: return -EFAULT if copy_one_buf() fails

2019-06-18 Thread Dan Carpenter
The copy_to_user() function returns the number of bytes remaining to be copied, but we want to return -EFAULT. This function is called from __drm_legacy_infobufs() which expects negative error codes. Fixes: 5c7640ab6258 ("switch compat_drm_infobufs() to drm_ioctl_kernel()") Signed-off-by: Dan Car

Re: [PATCH v3 05/10] drm: rcar-du: Handle CRTC standby from commit tail handler

2019-06-18 Thread Ulrich Hecht
> On June 17, 2019 at 11:09 PM Laurent Pinchart > wrote: > > > From: Kieran Bingham > > Manage the power state, and initial configuration of the CRTC from the > commit tail handler. CRTCs which need to be activated are taken out of > standby, and any deactivated CRTCs are put into standby.

Re: [PATCH 1/4] drm/vmwgfx: Assign eviction priorities to resources

2019-06-18 Thread Thomas Hellstrom
On 6/18/19 2:19 PM, Daniel Vetter wrote: On Tue, Jun 18, 2019 at 11:54:08AM +0100, Emil Velikov wrote: Hi Thomas, On 2019/06/18, Thomas Hellström (VMware) wrote: From: Thomas Hellstrom TTM provides a means to assign eviction priorities to buffer object. This means that all buffer objects wit

Re: [PATCH v3 06/10] drm: rcar-du: Handle CRTC configuration from commit tail handler

2019-06-18 Thread Ulrich Hecht
> On June 17, 2019 at 11:09 PM Laurent Pinchart > wrote: > > > From: Kieran Bingham > > The CRTC mode setting and routing configuration are performed at the > earliest of atomic enable and atomic begin, to ensure that a valid > configuration is applied to the hardware before the CRTC gets e

[PATCH] drm: rcar-du: Replace drm_driver GEM ops with GEM object functions

2019-06-18 Thread Laurent Pinchart
The recommended way to specify GEM object functions is to provide a drm_gem_object_funcs structure instance and set the GEM object to point to it. The drm_cma_gem_create_object_default_funcs() function provided by the GEM CMA helper does so when creating the GEM object, simplifying the driver imple

  1   2   3   >