[Bug 110928] wx5100 gpu crash!!!!

2019-06-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110928 --- Comment #2 from baopeng --- Created attachment 144568 --> https://bugs.freedesktop.org/attachment.cgi?id=144568&action=edit situation_1_dmesg situation 1 dmesg -- You are receiving this mail because: You are the assignee for the bug.___

[PATCH v3 6/7] lib/hexdump.c: Allow multiple groups to be separated by spaces

2019-06-17 Thread Alastair D'Silva
From: Alastair D'Silva Similar to the previous patch, this patch separates groups by 2 spaces for the hex fields, and 1 space for the ASCII field. eg. buf:: 454d414e 43415053 4e495f45 00584544 NAMESPAC E_INDEX. buf:0010: 0002 Sign

Re: [EXTERNAL] Re: [PATCH 1/1] drm/bochs: Fix connector leak during driver unload

2019-06-17 Thread Sam Bobroff
On Tue, May 21, 2019 at 10:10:29AM +0200, Gerd Hoffmann wrote: > Hi, > > The bug is in the driver, so ... > > > Bisecting the issue for commits to drivers/gpu/drm/bochs/ points to: > > 6579c39594ae ("drm/bochs: atomic: switch planes to atomic, wire up > > helpers.") > > ... but the issue also

Re: [PATCH v3 3/7] lib/hexdump.c: Optionally suppress lines of repeated bytes

2019-06-17 Thread Alastair D'Silva
On Mon, 2019-06-17 at 12:04 +1000, Alastair D'Silva wrote: > From: Alastair D'Silva > > Some buffers may only be partially filled with useful data, while the > rest > is padded (typically with 0x00 or 0xff). > > This patch introduces a flag to allow the supression of lines of > repeated > bytes,

[PATCH v3 2/7] lib/hexdump.c: Relax rowsize checks in hex_dump_to_buffer

2019-06-17 Thread Alastair D'Silva
From: Alastair D'Silva This patch removes the hardcoded row limits and allows for other lengths. These lengths must still be a multiple of groupsize. This allows structs that are not 16/32 bytes to display on a single line. This patch also expands the self-tests to test row sizes up to 64 bytes

[PATCH v3 7/7] lib/hexdump.c: Optionally retain byte ordering

2019-06-17 Thread Alastair D'Silva
From: Alastair D'Silva The behaviour of hexdump groups is to print the data out as if it was a native-endian number. This patch tweaks the documentation to make this clear, and also adds the HEXDUMP_RETAIN_BYTE_ORDER flag to allow groups of multiple bytes to be printed without affecting the orde

[PATCH v3 3/7] lib/hexdump.c: Optionally suppress lines of repeated bytes

2019-06-17 Thread Alastair D'Silva
From: Alastair D'Silva Some buffers may only be partially filled with useful data, while the rest is padded (typically with 0x00 or 0xff). This patch introduces a flag to allow the supression of lines of repeated bytes, which are replaced with '** Skipped %u bytes of value 0x%x **' An inline wr

[PATCH v3 1/7] lib/hexdump.c: Fix selftests

2019-06-17 Thread Alastair D'Silva
From: Alastair D'Silva The overflow tests did not account for the situation where no overflow occurs and len < rowsize. This patch renames the cryptic variables and accounts for the above case. The selftests now pass. Signed-off-by: Alastair D'Silva --- lib/test_hexdump.c | 47 ++

Re: [PATCH libdrm v2 3/4] meson: normal shell will do

2019-06-17 Thread Niclas Zeising
On 2019-06-16 15:23, Emil Velikov wrote: As tweaked with previous patch - bash is not required. Any shell will do Signed-off-by: Emil Velikov Reviewed-by: Niclas Zeising --- amdgpu/meson.build| 2 +- etnaviv/meson.build | 2 +- exynos/meson.build| 2 +- freedreno/meson.bui

Re: [RFC v2 01/11] OPP: Don't overwrite rounded clk rate

2019-06-17 Thread Viresh Kumar
On 14-06-19, 10:57, Viresh Kumar wrote: > Hmm, so this patch won't break anything and I am inclined to apply it again :) > > Does anyone see any other issues with it, which I might be missing ? I have updated the commit log a bit more to clarify on things, please let me know if it looks okay.

Re: [PATCH libdrm v2 4/4] meson.build: Fix meson script on FreeBSD

2019-06-17 Thread Niclas Zeising
On 2019-06-16 15:23, Emil Velikov wrote: From: Niclas Zeising FreeBSD requires sys/types.h for sys/sysctl.h, add it as part of the includes when checking for headers. Instead of splitting out the check for sys/sysctl.h from the other header checks, just add sys/types.h to all header checks. v2

[PATCH v3 4/7] lib/hexdump.c: Replace ascii bool in hex_dump_to_buffer with flags

2019-06-17 Thread Alastair D'Silva
From: Alastair D'Silva In order to support additional features in hex_dump_to_buffer, replace the ascii bool parameter with flags. Signed-off-by: Alastair D'Silva --- drivers/gpu/drm/i915/intel_engine_cs.c| 2 +- drivers/isdn/hardware/mISDN/mISDNisar.c | 6 -- drive

[PATCH v3 0/7] Hexdump Enhancements

2019-06-17 Thread Alastair D'Silva
From: Alastair D'Silva Apologies for the large CC list, it's a heads up for those responsible for subsystems where a prototype change in generic code causes a change in those subsystems. This series enhances hexdump. These improve the readability of the dumped data in certain situations (eg. wi

Re: [PATCH 6/6] drm/msm/gpu: add ocmem init/cleanup functions

2019-06-17 Thread Bjorn Andersson
On Sun 16 Jun 17:18 PDT 2019, Brian Masney wrote: > Hi Bjorn, > > On Sun, Jun 16, 2019 at 11:06:33AM -0700, Bjorn Andersson wrote: > > > diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.c > > > b/drivers/gpu/drm/msm/adreno/adreno_gpu.c > > > index 6f7f4114afcf..e0a9409c8a32 100644 > > > --- a/

[PATCH v3 5/7] lib/hexdump.c: Allow multiple groups to be separated by lines '|'

2019-06-17 Thread Alastair D'Silva
From: Alastair D'Silva With the wider display format, it can become hard to identify how many bytes into the line you are looking at. The patch adds new flags to hex_dump_to_buffer() and print_hex_dump() to print vertical lines to separate every N groups of bytes. eg. buf:: 454d414e 434

[PATCH 1/3] drm/stm: drv: fix suspend/resume

2019-06-17 Thread Yannick Fertré
Without this fix, the system can not go in "suspend" mode due to an error in drv_suspend function. Fixes: 35ab6cf ("drm/stm: support runtime power management") Signed-off-by: Yannick Fertré --- drivers/gpu/drm/stm/drv.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff

Re: [PATCH] i915: gvt: no need to check return value of debugfs_create functions

2019-06-17 Thread Zhenyu Wang
On 2019.06.13 15:34:19 +0200, Greg Kroah-Hartman wrote: > When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic should > never do something different based on this. Looks fine to me. We'd follow this idiom. Reviewed-by

Re: [PATCH v3 4/7] lib/hexdump.c: Replace ascii bool in hex_dump_to_buffer with flags

2019-06-17 Thread Jani Nikula
On Mon, 17 Jun 2019, "Alastair D'Silva" wrote: > From: Alastair D'Silva > > In order to support additional features in hex_dump_to_buffer, replace > the ascii bool parameter with flags. > > Signed-off-by: Alastair D'Silva > --- > drivers/gpu/drm/i915/intel_engine_cs.c| 2 +- > driv

Re: [PATCH] staging: fbtft: Fix checkpatch ERROR: space prohibited before that close parenthesis ')'

2019-06-17 Thread Geert Uytterhoeven
Hi Shobhit, Thanks for your patch! On Fri, Jun 14, 2019 at 4:34 AM Shobhit Kukreti wrote: > Cleaned up code to resolve the checkpatch error > ERROR: space prohibited before that close parenthesis ')' > from the file: > > fbtft/fbtft-bus.c IMHO that is a bogus checkpatch error... > Signed-off-

Re: use exact allocation for dma coherent memory

2019-06-17 Thread Dan Carpenter
I once wrote a Smatch check based on a commit message that said we can't pass dma_alloc_coherent() pointers to virt_to_phys(). But then I never felt like I understood the rules enough to actually report the warnings as bugs. drivers/platform/x86/dcdbas.c:108 smi_data_buf_realloc() error: 'buf' ca

Re: [PATCH 40/59] drm/vram-helper: Drop drm_gem_prime_export/import

2019-06-17 Thread Gerd Hoffmann
Hi, > Aside: Would be really nice to switch the others over to > drm_gem_object_funcs. While most callbacks are pretty straight forward (just hook the same callbacks into the drm_gem_object_funcs. struct) the mmap bits are a bit more obscure. First, there seem to be two ways to mmap a gem buff

[PATCH v5 00/18] kunit: introduce KUnit, the Linux kernel unit testing framework

2019-06-17 Thread Brendan Higgins
## TL;DR A not so quick follow-up to Stephen's suggestions on PATCH v4. Nothing that really changes any functionality or usage with the minor exception of a couple public functions that Stephen asked me to rename. Nevertheless, a good deal of clean up and fixes. See changes below. As for our curr

[PATCH v5 01/18] kunit: test: add KUnit test runner core

2019-06-17 Thread Brendan Higgins
Add core facilities for defining unit tests; this provides a common way to define test cases, functions that execute code which is under test and determine whether the code under test behaves as expected; this also provides a way to group together related test cases in test suites (here we call the

[PATCH v5 04/18] kunit: test: add kunit_stream a std::stream like logger

2019-06-17 Thread Brendan Higgins
A lot of the expectation and assertion infrastructure prints out fairly complicated test failure messages, so add a C++ style log library for for logging test results. Signed-off-by: Brendan Higgins Reviewed-by: Greg Kroah-Hartman Reviewed-by: Logan Gunthorpe --- Changes Since Last Revision: -

[PATCH v5 06/18] kbuild: enable building KUnit

2019-06-17 Thread Brendan Higgins
KUnit is a new unit testing framework for the kernel and when used is built into the kernel as a part of it. Add KUnit to the root Kconfig and Makefile to allow it to be actually built. Signed-off-by: Brendan Higgins Reviewed-by: Greg Kroah-Hartman Reviewed-by: Logan Gunthorpe --- Kconfig | 2

[PATCH v5 07/18] kunit: test: add initial tests

2019-06-17 Thread Brendan Higgins
Add a test for string stream along with a simpler example. Signed-off-by: Brendan Higgins Reviewed-by: Greg Kroah-Hartman Reviewed-by: Logan Gunthorpe --- kunit/Kconfig | 21 + kunit/Makefile | 4 ++ kunit/example-test.c | 88

[PATCH v5 05/18] kunit: test: add the concept of expectations

2019-06-17 Thread Brendan Higgins
Add support for expectations, which allow properties to be specified and then verified in tests. Signed-off-by: Brendan Higgins Reviewed-by: Greg Kroah-Hartman Reviewed-by: Logan Gunthorpe --- Changes Since Last Revision: - Added typechecking to expectations that compare two things of arbit

[PATCH v5 03/18] kunit: test: add string_stream a std::stream like string builder

2019-06-17 Thread Brendan Higgins
A number of test features need to do pretty complicated string printing where it may not be possible to rely on a single preallocated string with parameters. So provide a library for constructing the string as you go similar to C++'s std::string. Signed-off-by: Brendan Higgins Reviewed-by: Greg

[PATCH v5 02/18] kunit: test: add test resource management API

2019-06-17 Thread Brendan Higgins
Create a common API for test managed resources like memory and test objects. A lot of times a test will want to set up infrastructure to be used in test cases; this could be anything from just wanting to allocate some memory to setting up a driver stack; this defines facilities for creating "test r

[PATCH v5 13/18] kunit: tool: add Python wrappers for running KUnit tests

2019-06-17 Thread Brendan Higgins
From: Felix Guo The ultimate goal is to create minimal isolated test binaries; in the meantime we are using UML to provide the infrastructure to run tests, so define an abstract way to configure and run tests that allow us to change the context in which tests are built without affecting the user.

[PATCH v5 11/18] kunit: test: add the concept of assertions

2019-06-17 Thread Brendan Higgins
Add support for assertions which are like expectations except the test terminates if the assertion is not satisfied. The idea with assertions is that you use them to state all the preconditions for your test. Logically speaking, these are the premises of the test case, so if a premise isn't true,

[PATCH v5 14/18] kunit: defconfig: add defconfigs for building KUnit tests

2019-06-17 Thread Brendan Higgins
Add defconfig for UML and a fragment that can be used to configure other architectures for building KUnit tests. Add option to kunit_tool to use a defconfig to create the kunitconfig. Signed-off-by: Brendan Higgins Reviewed-by: Greg Kroah-Hartman Reviewed-by: Logan Gunthorpe --- arch/um/config

[PATCH v5 09/18] kunit: test: add support for test abort

2019-06-17 Thread Brendan Higgins
Add support for aborting/bailing out of test cases, which is needed for implementing assertions. An assertion is like an expectation, but bails out of the test case early if the assertion is not met. The idea with assertions is that you use them to state all the preconditions for your test. Logica

[PATCH v5 12/18] kunit: test: add tests for KUnit managed resources

2019-06-17 Thread Brendan Higgins
From: Avinash Kondareddy Add unit tests for KUnit managed resources. KUnit managed resources (struct kunit_resource) are resources that are automatically cleaned up at the end of a KUnit test, similar to the concept of devm_* managed resources. Signed-off-by: Avinash Kondareddy Signed-off-by: B

[PATCH v5 15/18] Documentation: kunit: add documentation for KUnit

2019-06-17 Thread Brendan Higgins
Add documentation for KUnit, the Linux kernel unit testing framework. - Add intro and usage guide for KUnit - Add API reference Signed-off-by: Felix Guo Signed-off-by: Brendan Higgins Reviewed-by: Greg Kroah-Hartman Reviewed-by: Logan Gunthorpe --- Documentation/dev-tools/index.rst

[PATCH v5 08/18] objtool: add kunit_try_catch_throw to the noreturn list

2019-06-17 Thread Brendan Higgins
Fix the following warning seen on GCC 7.3: kunit/test-test.o: warning: objtool: kunit_test_unsuccessful_try() falls through to next function kunit_test_catch() kunit_try_catch_throw is a function added in the following patch in this series; it allows KUnit, a unit testing framework for the kern

[PATCH v5 17/18] kernel/sysctl-test: Add null pointer test for sysctl.c:proc_dointvec()

2019-06-17 Thread Brendan Higgins
From: Iurii Zaikin KUnit tests for initialized data behavior of proc_dointvec that is explicitly checked in the code. Includes basic parsing tests including int min/max overflow. Signed-off-by: Iurii Zaikin Signed-off-by: Brendan Higgins Reviewed-by: Greg Kroah-Hartman Reviewed-by: Logan Gunt

[PATCH v5 18/18] MAINTAINERS: add proc sysctl KUnit test to PROC SYSCTL section

2019-06-17 Thread Brendan Higgins
Add entry for the new proc sysctl KUnit test to the PROC SYSCTL section. Signed-off-by: Brendan Higgins Reviewed-by: Greg Kroah-Hartman Reviewed-by: Logan Gunthorpe --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index f3fb3fc30853e..05cd8ffd33c8f

[PATCH v5 10/18] kunit: test: add tests for kunit test abort

2019-06-17 Thread Brendan Higgins
Add KUnit tests for the KUnit test abort mechanism (see preceding commit). Add tests both for general try catch mechanism as well as non-architecture specific mechanism. Signed-off-by: Brendan Higgins Reviewed-by: Greg Kroah-Hartman Reviewed-by: Logan Gunthorpe --- kunit/Makefile| 3 +-

[PATCH v5 16/18] MAINTAINERS: add entry for KUnit the unit testing framework

2019-06-17 Thread Brendan Higgins
Add myself as maintainer of KUnit, the Linux kernel's unit testing framework. Signed-off-by: Brendan Higgins Reviewed-by: Greg Kroah-Hartman Reviewed-by: Logan Gunthorpe --- MAINTAINERS | 11 +++ 1 file changed, 11 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 57f496cff99

[PATCH libdrm] intel/i915_pciids: Add missing device ID for ICL

2019-06-17 Thread Mika Kahola
We are missing PCI device ID for SKU ICLLP U GT 1.5F (0x8A54) as per BSPec. BSpec: 19092 Signed-off-by: Mika Kahola --- intel/i915_pciids.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/intel/i915_pciids.h b/intel/i915_pciids.h index c7cdbfc4..0adce335 100644 --- a/intel

Re: use exact allocation for dma coherent memory

2019-06-17 Thread Christoph Hellwig
> drivers/infiniband/hw/cxgb4/qp.c >129 static int alloc_host_sq(struct c4iw_rdev *rdev, struct t4_sq *sq) >130 { >131 sq->queue = dma_alloc_coherent(&(rdev->lldi.pdev->dev), > sq->memsize, >132 &(sq->dma_addr), GFP_KERNEL); >1

Re: [PATCH 59/59] drm/doc: Document kapi doc expectations

2019-06-17 Thread Jani Nikula
On Fri, 14 Jun 2019, Daniel Vetter wrote: > We've had this already for anything new. With my drm_prime.c cleanup I > also think documentations for everything already existing is complete, > and we can bake this in as a requirements subsystem wide. > > Signed-off-by: Daniel Vetter > Cc: Laurent Pi

[Bug 110914] Heavy corruption on R300 with modesetting and GLAMOR

2019-06-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110914 --- Comment #4 from Michel Dänzer --- Does xf86-video-ati with glamor give the same corruption? -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailing list dri

[Bug 104437] RX480 + SME = amdgpu init failed + null dereference

2019-06-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104437 --- Comment #2 from Michel Dänzer --- (In reply to Nick Sarnie from comment #1) > > Same issue [...] The symptoms are clearly different, therefore please file your own report. -- You are receiving this mail because: You are the assignee for

Re: [PATCH libdrm v2 4/4] meson.build: Fix meson script on FreeBSD

2019-06-17 Thread Eric Engestrom
On Sunday, 2019-06-16 14:23:43 +0100, Emil Velikov wrote: > From: Niclas Zeising > > FreeBSD requires sys/types.h for sys/sysctl.h, add it as part of the > includes when checking for headers. > Instead of splitting out the check for sys/sysctl.h from the other > header checks, just add sys/types.

[Bug 110897] HyperZ is broken for r300 (bad z for some micro and macrotiles?)

2019-06-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110897 Michel Dänzer changed: What|Removed |Added CC|mic...@daenzer.net | --- Comment #66 from Michel Dänzer --

Re: [PATCH v4 02/12] drm/client: Restrict the plane_state scope

2019-06-17 Thread Jani Nikula
On Fri, 14 Jun 2019, Maxime Ripard wrote: > Hi Jani, > > On Fri, Jun 14, 2019 at 03:28:59PM +0300, Jani Nikula wrote: >> On Fri, 14 Jun 2019, Maxime Ripard wrote: >> > The drm_client_modeset_commit_atomic function uses two times the >> > plane_state variable in inner blocks of code, but the varia

Re: [PATCH 3/6] drm/gem: use new ww_mutex_(un)lock_for_each macros

2019-06-17 Thread Christian König
Am 15.06.19 um 15:56 schrieb Daniel Vetter: On Fri, Jun 14, 2019 at 10:30 PM Daniel Vetter wrote: On Fri, Jun 14, 2019 at 08:51:11PM +0200, Christian König wrote: Am 14.06.19 um 20:24 schrieb Daniel Vetter: On Fri, Jun 14, 2019 at 8:10 PM Christian König wrote: [SNIP] WW_MUTEX_LOCK_BEGIN()

Re: [PATCH 09/59] drm/prime: Align gem_prime_export with obj_funcs.export

2019-06-17 Thread Koenig, Christian
Am 14.06.19 um 22:35 schrieb Daniel Vetter: > The idea is that gem_prime_export is deprecated in favor of > obj_funcs.export. That's much easier to do if both have matching > function signatures. > > Signed-off-by: Daniel Vetter > Cc: Russell King > Cc: Maarten Lankhorst > Cc: Maxime Ripard > C

[Bug 203905] amdgpu:actual_brightness has unreal/wrong value

2019-06-17 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=203905 --- Comment #1 from Michel Dänzer (mic...@daenzer.net) --- Please attach the output of dmesg. -- You are receiving this mail because: You are watching the assignee of the bug. ___ dri-devel mailing lis

Re: [PATCH 09/59] drm/prime: Align gem_prime_export with obj_funcs.export

2019-06-17 Thread Thierry Reding
On Fri, Jun 14, 2019 at 10:35:25PM +0200, Daniel Vetter wrote: > The idea is that gem_prime_export is deprecated in favor of > obj_funcs.export. That's much easier to do if both have matching > function signatures. > > Signed-off-by: Daniel Vetter > Cc: Russell King > Cc: Maarten Lankhorst > Cc

Re: [PATCH v2 06/28] drivers: Add generic helper to match by of_node

2019-06-17 Thread Suzuki K Poulose
Hi On 14/06/2019 21:31, Wolfram Sang wrote: + +int device_match_of_node(struct device *dev, const void *np) +{ + return dev->of_node == np; +} +EXPORT_SYMBOL_GPL(device_match_of_node); Is it an option to 'static inline' this simple function in the header, saving the EXPORT? No. This i

Re: [RFC/WIP] drm/rockchip: Support CRTC gamma LUT

2019-06-17 Thread Jacopo Mondi
Hi Ezequiel, one small question, as I'm working on supporting gamma LUT for rcar-du as well, and there's one point not totally clear to me On Thu, Jun 13, 2019 at 04:22:44PM -0300, Ezequiel Garcia wrote: > Add CRTC gamma LUT configuration on RK3288 and RK3399. > > Signed-off-by: Ezequiel Garci

Re: [PATCH v2 06/28] drivers: Add generic helper to match by of_node

2019-06-17 Thread Wolfram Sang
> > Is it an option to 'static inline' this simple function in the header, > > saving the EXPORT? > > > > No. OK, thanks for the explanation! signature.asc Description: PGP signature

[Bug 110928] wx5100 gpu crash

2019-06-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110928 Andre Klapper changed: What|Removed |Added Summary|wx5100 gpu crash|wx5100 gpu crash -- You are receiving

Re: [PATCH v2 2/2] drm/komeda: Adds komeda_kms_drop_master

2019-06-17 Thread Lowry Li (Arm Technology China)
Hi Daniel, On Fri, Jun 14, 2019 at 04:53:08PM +0800, james qian wang (Arm Technology China) wrote: > On Fri, Jun 14, 2019 at 09:01:11AM +0200, Daniel Vetter wrote: > > On Fri, Jun 14, 2019 at 05:46:04AM +, james qian wang (Arm Technology > > China) wrote: > > > On Thu, Jun 13, 2019 at 04:30:0

[Bug 110674] Crashes / Resets From AMDGPU / Radeon VII

2019-06-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110674 --- Comment #41 from Tom B --- Created attachment 144569 --> https://bugs.freedesktop.org/attachment.cgi?id=144569&action=edit 5.1.9 full dmesg Interestingly I just reinstalled 5.1.9 and I'm not seeing the same immediate crash. It may be anot

[Bug 102646] Screen flickering under amdgpu-experimental [buggy auto power profile]

2019-06-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102646 --- Comment #95 from tempel.jul...@gmail.com --- This is probably what some people want, but it forces VRAM into highest state with amdgpu.dc=1, while it has no effect with amdgpu.dc=0 (still flickers). -- You are receiving this mail because: Y

[Bug 110914] Heavy corruption on R300 with modesetting and GLAMOR

2019-06-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110914 --- Comment #5 from Rui Salvaterra --- (In reply to Michel Dänzer from comment #4) > Does xf86-video-ati with glamor give the same corruption? Good question. I have no idea, but I will try and see if it also happens. -- You are receiving this

Re: [linux-sunxi] [PATCH v2 5/9] drm/sun4i: tcon_top: Register clock gates in probe

2019-06-17 Thread Jagan Teki
On Sun, Jun 16, 2019 at 11:01 AM Chen-Yu Tsai wrote: > > On Sat, Jun 15, 2019 at 12:44 AM Jagan Teki > wrote: > > > > TCON TOP have clock gates for TV0, TV1, dsi and right > > now these are register during bind call. > > > > Of which, dsi clock gate would required during DPHY probe > > but same

[Bug 203905] amdgpu:actual_brightness has unreal/wrong value

2019-06-17 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=203905 --- Comment #2 from Bjoern Franke (b...@nord-west.org) --- Created attachment 283299 --> https://bugzilla.kernel.org/attachment.cgi?id=283299&action=edit dmesg -- You are receiving this mail because: You are watching the assignee of the bug. _

[PATCH 1/4] drm/virtio: pass gem reservation object to ttm init

2019-06-17 Thread Gerd Hoffmann
With this gem and ttm will use the same reservation object, so mixing and matching ttm / gem reservation helpers should work fine. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/virtio/virtgpu_object.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/virtio

[PATCH 4/4] drm/virtio: remove virtio_gpu_object_wait

2019-06-17 Thread Gerd Hoffmann
No users left. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/virtio/virtgpu_drv.h| 1 - drivers/gpu/drm/virtio/virtgpu_object.c | 13 - 2 files changed, 14 deletions(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_drv.h b/drivers/gpu/drm/virtio/virtgpu_drv.h index 9e2d3062b0

[PATCH 2/4] drm/virtio: switch virtio_gpu_wait_ioctl() to gem helper.

2019-06-17 Thread Gerd Hoffmann
Use drm_gem_reservation_object_wait() in virtio_gpu_wait_ioctl(). Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/virtio/virtgpu_ioctl.c | 18 -- 1 file changed, 4 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_ioctl.c b/drivers/gpu/drm/virtio/virtg

[PATCH 0/4] drm/virtio: try remove ttm

2019-06-17 Thread Gerd Hoffmann
ttm increasingly gets into the way while hacking on virtio-gpu memory management. So maybe we are better off without, using gem helpers instead? Trying remove the dependency on ttm reservations looks like a good first first step to me. This patch series is a (small) start on that. At the point

[PATCH 3/4] drm/virtio: simplify cursor updates

2019-06-17 Thread Gerd Hoffmann
No need to do the reservation dance, we can just wait on the fence directly. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/virtio/virtgpu_plane.c | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_plane.c b/drivers/gpu/drm/virtio

[PATCH 3/6] drm/ttm: use the parent resv for ghost objects v2

2019-06-17 Thread Christian König
This way we can even pipeline imported BO evictions. v2: Limit this to only cases when the parent object uses a separate reservation object as well. This fixes another OOM problem. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo_util.c | 20 +++- 1 file changed

[PATCH 4/6] drm/amdgpu: use allowed_domains for exported DMA-bufs

2019-06-17 Thread Christian König
Avoid that we ping/pong the buffers when we stop to pin DMA-buf exports by using the allowed domains for exported buffers. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/

[PATCH 1/6] dma-buf: add dynamic DMA-buf handling v10

2019-06-17 Thread Christian König
On the exporter side we add optional explicit pinning callbacks. If those callbacks are implemented the framework no longer caches sg tables and the map/unmap callbacks are always called with the lock of the reservation object held. On the importer side we add an optional invalidate callback. This

[PATCH 2/6] drm/ttm: remove the backing store if no placement is given

2019-06-17 Thread Christian König
Pipeline removal of the BOs backing store when no placement is given during validation. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c index c7de667d482a

[PATCH 5/6] drm/amdgpu: add independent DMA-buf export v6

2019-06-17 Thread Christian König
The caching of SGT's is actually quite harmful and should probably removed altogether when all drivers are audited. Start by providing a separate DMA-buf export implementation in amdgpu. This is also a prerequisite of unpinned DMA-buf handling. v2: fix unintended recursion, remove debugging lefto

[PATCH 6/6] drm/amdgpu: add independent DMA-buf import v6

2019-06-17 Thread Christian König
Instead of relying on the DRM functions just implement our own import functions. This prepares support for taking care of unpinned DMA-buf. v2: enable for all exporters, not just amdgpu, fix invalidation handling, lock reservation object while setting callback v3: change to new dma_buf attach

[Bug 110883] [Regression linux 5.2-rc4][bisected] hang on boot

2019-06-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110883 Sibren Vasse changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [PATCH v2 5/9] drm/sun4i: tcon_top: Register clock gates in probe

2019-06-17 Thread Maxime Ripard
On Fri, Jun 14, 2019 at 10:13:20PM +0530, Jagan Teki wrote: > TCON TOP have clock gates for TV0, TV1, dsi and right > now these are register during bind call. > > Of which, dsi clock gate would required during DPHY probe > but same can miss to get since tcon top is not bound at > that time. > > To

[PATCH] drm/amd/display: include missing linux/delay.h

2019-06-17 Thread Arnd Bergmann
Some randconfig builds fail to compile the dcn10 code because of a missing declaration: drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c: In function 'dcn10_apply_ctx_for_surface': drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c:2378:3: error: implicit decl

[PATCH] video: fbdev: pvr2fb: fix compile-testing as module

2019-06-17 Thread Arnd Bergmann
Building an allmodconfig kernel now produces a harmless warning: drivers/video/fbdev/pvr2fb.c:726:12: error: unused function 'pvr2_get_param_val' [-Werror,-Wunused-function] Shut this up the same way as we do for other unused functions in the same file, using the __maybe_unused attribute. Fixes

[PATCH] drm/komeda: fix size_t format string

2019-06-17 Thread Arnd Bergmann
The debug output uses the wrong format string for printing a size_t: In file included from include/drm/drm_mm.h:49, from include/drm/drm_vma_manager.h:26, from include/drm/drm_gem.h:40, from drivers/gpu/drm/arm/display/komeda/komeda_framebuffer.c:

Re: [RESEND FOR CI] i915: no need to check return value of debugfs_create functions

2019-06-17 Thread Jani Nikula
On Thu, 13 Jun 2019, Jani Nikula wrote: > From: Greg Kroah-Hartman > > When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic should > never do something different based on this. > > Cc: Jani Nikula > Cc: Joonas Lahtin

[PATCH] drm/komeda: fix 32-bit komeda_crtc_update_clock_ratio

2019-06-17 Thread Arnd Bergmann
clang points out a bug in the clock calculation on 32-bit, that leads to the clock_ratio always being zero: drivers/gpu/drm/arm/display/komeda/komeda_crtc.c:31:36: error: shift count >= width of type [-Werror,-Wshift-count-overflow] aclk = komeda_calc_aclk(kcrtc_st) << 32; Move the shift

[PATCH] drm/amdgpu: fix error handling in df_v3_6_pmc_start

2019-06-17 Thread Arnd Bergmann
When df_v3_6_pmc_get_ctrl_settings() fails for some reason, we store uninitialized data in a register, as gcc points out: drivers/gpu/drm/amd/amdgpu/df_v3_6.c: In function 'df_v3_6_pmc_start': drivers/gpu/drm/amd/amdgpu/amdgpu.h:1012:29: error: 'lo_val' may be used uninitialized in this function

Re: [linux-sunxi] Re: [PATCH v2 5/9] drm/sun4i: tcon_top: Register clock gates in probe

2019-06-17 Thread Chen-Yu Tsai
On Mon, Jun 17, 2019 at 7:45 PM Maxime Ripard wrote: > > On Fri, Jun 14, 2019 at 10:13:20PM +0530, Jagan Teki wrote: > > TCON TOP have clock gates for TV0, TV1, dsi and right > > now these are register during bind call. > > > > Of which, dsi clock gate would required during DPHY probe > > but same

[PATCH] video: fbdev: pvr2fb: fix link error for pvr2fb_pci_exit

2019-06-17 Thread Arnd Bergmann
When the driver is built-in for PCI, we reference the exit function after discarding it: `pvr2fb_pci_exit' referenced in section `.ref.data' of drivers/video/fbdev/pvr2fb.o: defined in discarded section `.exit.text' of drivers/video/fbdev/pvr2fb.o Just remove the __exit annotation as the easies

Re: [PATCH 12/16] staging/comedi: mark as broken

2019-06-17 Thread Ian Abbott
On 14/06/2019 16:34, Christoph Hellwig wrote: On Fri, Jun 14, 2019 at 05:30:32PM +0200, Greg KH wrote: On Fri, Jun 14, 2019 at 04:48:57PM +0200, Christoph Hellwig wrote: On Fri, Jun 14, 2019 at 04:02:39PM +0200, Greg KH wrote: Perhaps a hint as to how we can fix this up? This is the first tim

Re: [PATCH] drm/komeda: fix size_t format string

2019-06-17 Thread Liviu Dudau
Hi Arnd, On Mon, Jun 17, 2019 at 02:49:18PM +0200, Arnd Bergmann wrote: > The debug output uses the wrong format string for printing a size_t: > > In file included from include/drm/drm_mm.h:49, > from include/drm/drm_vma_manager.h:26, > from include/drm/drm_gem.h

Re: [PATCH] drm/komeda: fix 32-bit komeda_crtc_update_clock_ratio

2019-06-17 Thread Liviu Dudau
On Mon, Jun 17, 2019 at 02:51:04PM +0200, Arnd Bergmann wrote: > clang points out a bug in the clock calculation on 32-bit, that leads > to the clock_ratio always being zero: > > drivers/gpu/drm/arm/display/komeda/komeda_crtc.c:31:36: error: shift count >= > width of type [-Werror,-Wshift-count-o

Re: [PATCH libdrm v2 4/4] meson.build: Fix meson script on FreeBSD

2019-06-17 Thread Eric Engestrom
On Monday, 2019-06-17 11:20:43 +0200, Niclas Zeising wrote: > On 2019-06-17 11:14, Eric Engestrom wrote: > > On Sunday, 2019-06-16 14:23:43 +0100, Emil Velikov wrote: > > > From: Niclas Zeising > > > > > > FreeBSD requires sys/types.h for sys/sysctl.h, add it as part of the > > > includes when ch

Re: [PATCH 07/59] drm/arm/komeda: Remove DRIVER_HAVE_IRQ

2019-06-17 Thread Daniel Vetter
On Mon, Jun 17, 2019 at 06:26:08AM +, james qian wang (Arm Technology China) wrote: > On Fri, Jun 14, 2019 at 10:35:23PM +0200, Daniel Vetter wrote: > > Read the docs, komeda is not an old enough driver for this :-) > > > > Signed-off-by: Daniel Vetter > > Cc: "James (Qian) Wang" > > Cc: Li

Re: [PATCH] drm: Permit video-buffers writecombine mapping for MIPS

2019-06-17 Thread Serge Semin
Hello folks, Any updates of this patch status? It has been here for about two months. Regards, -Sergey On Tue, Apr 23, 2019 at 03:31:22PM +0300, Serge Semin wrote: > Since commit 4b050ba7a66c ("MIPS: pgtable.h: Implement the > pgprot_writecombine function for MIPS") and commit c4687b15a848 ("MIP

[Bug 110702] segfault in radeonsi HEVC hardware decoding with yuv420p10le

2019-06-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110702 --- Comment #6 from Pierre-Eric Pelloux-Prayer --- I can't reproduce it here, but maybe my test file (from https://github.com/mpv-player/mpv/issues/4736#issuecomment-333505294) isn't good to trigger the bug. Does the issue occur with the file

[Bug 102646] Screen flickering under amdgpu-experimental [buggy auto power profile]

2019-06-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102646 --- Comment #96 from magist3r --- (In reply to tempel.julian from comment #95) > but it forces VRAM into highest state with amdgpu.dc=1 Yes, and this is what the kernel code does to prevent flickering. My patch is only about doing the same thing

[Bug 109693] Hang of the graphics driver and assertion on si_upload_vertex_buffer_descriptors

2019-06-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109693 Pierre-Eric Pelloux-Prayer changed: What|Removed |Added Status|NEW |RESOLVED Resolutio

Re: [PATCH 40/59] drm/vram-helper: Drop drm_gem_prime_export/import

2019-06-17 Thread Daniel Vetter
On Mon, Jun 17, 2019 at 10:24:38AM +0200, Gerd Hoffmann wrote: > Hi, > > > Aside: Would be really nice to switch the others over to > > drm_gem_object_funcs. > > While most callbacks are pretty straight forward (just hook the same > callbacks into the drm_gem_object_funcs. struct) the mmap bits

Re: [PATCH 01/59] drm/todo: Improve drm_gem_object funcs todo

2019-06-17 Thread Daniel Vetter
On Fri, Jun 14, 2019 at 03:53:31PM -0700, Eric Anholt wrote: > Daniel Vetter writes: > > > We're kinda going in the wrong direction. Spotted while typing better > > gem/prime docs. > > > > Cc: Thomas Zimmermann > > Cc: Gerd Hoffmann > > Cc: Rob Herring > > Cc: Noralf Trønnes > > Signed-off-by

Re: [PATCH 22/59] drm/mxsfb: Drop drm_gem_prime_export/import

2019-06-17 Thread Stefan Agner
On 14.06.2019 22:35, Daniel Vetter wrote: > They're the default. > > Aside: Would be really nice to switch the others over to > drm_gem_object_funcs. Acked-by: Stefan Agner -- Stefan > > Signed-off-by: Daniel Vetter > Cc: Marek Vasut > Cc: Stefan Agner > Cc: Shawn Guo > Cc: Sascha Hauer

Re: [PATCH 15/59] drm/fsl-dcu: Drop drm_gem_prime_export/import

2019-06-17 Thread Stefan Agner
On 14.06.2019 22:35, Daniel Vetter wrote: > They're the default. > > Aside: Would be really nice to switch the others over to > drm_gem_object_funcs. Acked-by: Stefan Agner -- Stefan > > Signed-off-by: Daniel Vetter > Cc: Stefan Agner > Cc: Alison Wang > --- > drivers/gpu/drm/fsl-dcu/fsl_

Re: [PATCH 1/4] drm/virtio: pass gem reservation object to ttm init

2019-06-17 Thread Daniel Vetter
On Mon, Jun 17, 2019 at 01:14:03PM +0200, Gerd Hoffmann wrote: > With this gem and ttm will use the same reservation object, > so mixing and matching ttm / gem reservation helpers should > work fine. > > Signed-off-by: Gerd Hoffmann While doing my prime doc+cleanup series I wondered whether we s

Re: [PATCH 1/4] drm/virtio: pass gem reservation object to ttm init

2019-06-17 Thread Daniel Vetter
On Mon, Jun 17, 2019 at 04:08:25PM +0200, Daniel Vetter wrote: > On Mon, Jun 17, 2019 at 01:14:03PM +0200, Gerd Hoffmann wrote: > > With this gem and ttm will use the same reservation object, > > so mixing and matching ttm / gem reservation helpers should > > work fine. > > > > Signed-off-by: Gerd

[Bug 110783] Mesa 19.1 rc crashing MPV with VAAPI

2019-06-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110783 Matt Turner changed: What|Removed |Added URL||https://gitlab.freedesktop.

Re: [PATCH 2/4] drm/virtio: switch virtio_gpu_wait_ioctl() to gem helper.

2019-06-17 Thread Daniel Vetter
On Mon, Jun 17, 2019 at 01:14:04PM +0200, Gerd Hoffmann wrote: > Use drm_gem_reservation_object_wait() in virtio_gpu_wait_ioctl(). Would be good to mention here that with this the wait becomes lockless, we don't call ttm_bo_reserve/unreserve anymore. > Signed-off-by: Gerd Hoffmann > --- > drive

  1   2   3   >