[PATCH v3 06/18] kbuild: enable building KUnit

2019-05-13 Thread Brendan Higgins
Add KUnit to root Kconfig and Makefile allowing it to actually be built. Signed-off-by: Brendan Higgins Reviewed-by: Greg Kroah-Hartman Reviewed-by: Logan Gunthorpe --- Changes Since Last Revision: - Masahiro reported a number of issues here on the previous revision; however, all of the cha

[PATCH v3 02/18] kunit: test: add test resource management API

2019-05-13 Thread Brendan Higgins
Create a common API for test managed resources like memory and test objects. A lot of times a test will want to set up infrastructure to be used in test cases; this could be anything from just wanting to allocate some memory to setting up a driver stack; this defines facilities for creating "test r

[PATCH v3 01/18] kunit: test: add KUnit test runner core

2019-05-13 Thread Brendan Higgins
Add core facilities for defining unit tests; this provides a common way to define test cases, functions that execute code which is under test and determine whether the code under test behaves as expected; this also provides a way to group together related test cases in test suites (here we call the

[PATCH v3 03/18] kunit: test: add string_stream a std::stream like string builder

2019-05-13 Thread Brendan Higgins
A number of test features need to do pretty complicated string printing where it may not be possible to rely on a single preallocated string with parameters. So provide a library for constructing the string as you go similar to C++'s std::string. Signed-off-by: Brendan Higgins Reviewed-by: Greg

[PATCH v3 05/18] kunit: test: add the concept of expectations

2019-05-13 Thread Brendan Higgins
Add support for expectations, which allow properties to be specified and then verified in tests. Signed-off-by: Brendan Higgins Reviewed-by: Greg Kroah-Hartman Reviewed-by: Logan Gunthorpe --- Changes Since Last Revision: - Added EXPECT macros for pointer comparison to address issue pointed

[PATCH v3 07/18] kunit: test: add initial tests

2019-05-13 Thread Brendan Higgins
Add a test for string stream along with a simpler example. Signed-off-by: Brendan Higgins Reviewed-by: Greg Kroah-Hartman Reviewed-by: Logan Gunthorpe --- Changes Since Last Revision: - Added more Kconfig help text for KUNIT_TEST and KUNIT_EXAMPLE_TEST as per Shuah's comments. --- kunit/Kc

[PATCH v3 09/18] kunit: test: add support for test abort

2019-05-13 Thread Brendan Higgins
Add support for aborting/bailing out of test cases, which is needed for implementing assertions. An assertion is like an expectation, but bails out of the test case early if the assertion is not met. The idea with assertions is that you use them to state all the preconditions for your test. Logica

[PATCH v3 13/18] kunit: tool: add Python wrappers for running KUnit tests

2019-05-13 Thread Brendan Higgins
From: Felix Guo The ultimate goal is to create minimal isolated test binaries; in the meantime we are using UML to provide the infrastructure to run tests, so define an abstract way to configure and run tests that allow us to change the context in which tests are built without affecting the user.

[PATCH v3 12/18] kunit: test: add tests for KUnit managed resources

2019-05-13 Thread Brendan Higgins
From: Avinash Kondareddy Add unit tests for KUnit managed resources. KUnit managed resources (struct kunit_resource) are resources that are automatically cleaned up at the end of a KUnit test, similar to the concept of devm_* managed resources. Signed-off-by: Avinash Kondareddy Signed-off-by: B

[PATCH v3 08/18] objtool: add kunit_try_catch_throw to the noreturn list

2019-05-13 Thread Brendan Higgins
This fixes the following warning seen on GCC 7.3: kunit/test-test.o: warning: objtool: kunit_test_unsuccessful_try() falls through to next function kunit_test_catch() Reported-by: kbuild test robot To: Josh Poimboeuf To: Peter Zijlstra Signed-off-by: Brendan Higgins Link: https://www.spinic

[PATCH v3 10/18] kunit: test: add tests for kunit test abort

2019-05-13 Thread Brendan Higgins
Add KUnit tests for the KUnit test abort mechanism (see preceding commit). Add tests both for general try catch mechanism as well as non-architecture specific mechanism. Signed-off-by: Brendan Higgins Reviewed-by: Greg Kroah-Hartman Reviewed-by: Logan Gunthorpe --- kunit/Makefile| 3 +-

[PATCH v3 11/18] kunit: test: add the concept of assertions

2019-05-13 Thread Brendan Higgins
Add support for assertions which are like expectations except the test terminates if the assertion is not satisfied. The idea with assertions is that you use them to state all the preconditions for your test. Logically speaking, these are the premises of the test case, so if a premise isn't true,

[PATCH v3 17/18] kernel/sysctl-test: Add null pointer test for sysctl.c:proc_dointvec()

2019-05-13 Thread Brendan Higgins
From: Iurii Zaikin KUnit tests for initialized data behavior of proc_dointvec that is explicitly checked in the code. Includes basic parsing tests including int min/max overflow. Signed-off-by: Iurii Zaikin Signed-off-by: Brendan Higgins Reviewed-by: Greg Kroah-Hartman Reviewed-by: Logan Gunt

[PATCH v3 18/18] MAINTAINERS: add proc sysctl KUnit test to PROC SYSCTL section

2019-05-13 Thread Brendan Higgins
Add entry for the new proc sysctl KUnit test to the PROC SYSCTL section. Signed-off-by: Brendan Higgins Reviewed-by: Greg Kroah-Hartman Reviewed-by: Logan Gunthorpe --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 8a91887c8d541..2e539647589fd

[PATCH v3 16/18] MAINTAINERS: add entry for KUnit the unit testing framework

2019-05-13 Thread Brendan Higgins
Add myself as maintainer of KUnit, the Linux kernel's unit testing framework. Signed-off-by: Brendan Higgins Reviewed-by: Greg Kroah-Hartman Reviewed-by: Logan Gunthorpe --- Changes Since Last Revision: - Added linux-kselftest@ as a mailing list entry for KUnit as requested by Shuah. --- M

[PATCH v3 15/18] Documentation: kunit: add documentation for KUnit

2019-05-13 Thread Brendan Higgins
Add documentation for KUnit, the Linux kernel unit testing framework. - Add intro and usage guide for KUnit - Add API reference Signed-off-by: Felix Guo Signed-off-by: Brendan Higgins Reviewed-by: Greg Kroah-Hartman Reviewed-by: Logan Gunthorpe --- Changes Since Last Revision: - Addressed ref

[PATCH v3 14/18] kunit: defconfig: add defconfigs for building KUnit tests

2019-05-13 Thread Brendan Higgins
Add defconfig for UML and a fragment that can be used to configure other architectures for building KUnit tests. Add option to kunit_tool to use a defconfig to create the kunitconfig. Signed-off-by: Brendan Higgins Reviewed-by: Greg Kroah-Hartman Reviewed-by: Logan Gunthorpe --- arch/um/config

[Bug 110674] Crashes / Resets From AMDGPU / Radeon VII

2019-05-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110674 Bug ID: 110674 Summary: Crashes / Resets From AMDGPU / Radeon VII Product: DRI Version: unspecified Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW

[Bug 110674] Crashes / Resets From AMDGPU / Radeon VII

2019-05-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110674 Chris Hodapp changed: What|Removed |Added Attachment #144254|0 |1 is obsolete|

[Bug 110674] Crashes / Resets From AMDGPU / Radeon VII

2019-05-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110674 --- Comment #3 from Chris Hodapp --- Created attachment 144257 --> https://bugs.freedesktop.org/attachment.cgi?id=144257&action=edit display-manager.service.log -- You are receiving this mail because: You are the assignee for the bug.___

[Bug 110674] Crashes / Resets From AMDGPU / Radeon VII

2019-05-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110674 --- Comment #2 from Chris Hodapp --- Created attachment 144256 --> https://bugs.freedesktop.org/attachment.cgi?id=144256&action=edit dmesg.color.log -- You are receiving this mail because: You are the assignee for the bug.___

Re: [PATCH v2 00/17] kunit: introduce KUnit, the Linux kernel unit testing framework

2019-05-13 Thread Brendan Higgins
On Mon, May 13, 2019 at 04:44:51PM +0200, Daniel Vetter wrote: > On Sat, May 11, 2019 at 01:33:44PM -0400, Theodore Ts'o wrote: > > On Fri, May 10, 2019 at 02:12:40PM -0700, Frank Rowand wrote: > > > However, the reply is incorrect. Kselftest in-kernel tests (which > > > is the context here) can b

Re: [PATCH v7 09/11] drm: uevent for connector status change

2019-05-13 Thread Ser, Simon
On Mon, 2019-05-13 at 17:04 +0200, Daniel Vetter wrote: > On Mon, May 13, 2019 at 10:11:01AM +, Ser, Simon wrote: > > On Mon, 2019-05-13 at 11:34 +0200, Daniel Vetter wrote: > > > On Mon, May 13, 2019 at 11:02 AM Paul Kocialkowski > > > wrote: > > > > Hi, > > > > > > > > On Fri, 2019-05-10 at

Re: [PATCH v2 00/17] kunit: introduce KUnit, the Linux kernel unit testing framework

2019-05-13 Thread Brendan Higgins
On Sat, May 11, 2019 at 08:17:47AM +0200, Knut Omang wrote: > On Fri, 2019-05-10 at 15:18 -0700, Frank Rowand wrote: > > On 5/10/19 1:54 PM, Brendan Higgins wrote: > > > On Fri, May 10, 2019 at 5:13 AM Knut Omang wrote: > > >> On Fri, 2019-05-10 at 03:23 -0700, Brendan Higgins wrote: > > On F

Re: [PATCH] drm/nouveau: fix duplication of nv50_head_atom struct

2019-05-13 Thread Ben Skeggs
On Sun, 12 May 2019 at 04:23, Peteris Rudzusiks wrote: > > nv50_head_atomic_duplicate_state() makes a copy of nv50_head_atom > struct. This patch adds copying of struct member named "or", which > previously was left uninitialized in the duplicated structure. > > Due to this bug, incorrect nhsync a

Re: [PATCH v3 08/18] objtool: add kunit_try_catch_throw to the noreturn list

2019-05-13 Thread Peter Zijlstra
On Mon, May 13, 2019 at 10:42:42PM -0700, Brendan Higgins wrote: > This fixes the following warning seen on GCC 7.3: > kunit/test-test.o: warning: objtool: kunit_test_unsuccessful_try() falls > through to next function kunit_test_catch() > What is that file and function; no kernel tree near me

<    1   2