On Thu, May 02, 2019 at 04:24:29PM -0400, Sean Paul wrote:
> From: Sean Paul
>
> There are no structured comments in the file, so it generates this
> warning on compilation:
>
> include/drm/drm_atomic_state_helper.h:1: warning: no structured comments found
>
> Fixes: 9ef8a9dc4b21 ("drm: Extract
On Thu, May 02, 2019 at 04:24:30PM -0400, Sean Paul wrote:
> From: Sean Paul
>
> These functions were missing documentation.
>
> Fixes the warning:
> ../include/drm/drm_modeset_helper_vtables.h:1000: warning: Function parameter
> or member 'prepare_writeback_job' not described in
> 'drm_connec
https://bugs.freedesktop.org/show_bug.cgi?id=108893
--- Comment #8 from Michel Dänzer ---
(In reply to andrew.m.mcmahon from comment #6)
> I can't replicate any performance issues with Gothic 2 Gold on my setup.
>
> [...]
>
> I've recorded a video with SimpleScreenRecorder of the game running @
On Thu, May 02, 2019 at 03:49:47PM -0400, Sean Paul wrote:
> From: Sean Paul
>
> This patch adds a new drm helper library to help drivers implement
> self refresh. Drivers choosing to use it will register crtcs and
> will receive callbacks when it's time to enter or exit self refresh
> mode.
>
>
On Thu, May 02, 2019 at 03:49:45PM -0400, Sean Paul wrote:
> From: Sean Paul
>
> This patch adds atomic variants for all of
> pre_enable/enable/disable/post_disable bridge functions. These will be
> called from the appropriate atomic helper functions. If the bridge
> driver doesn't implement the
On Thu, May 02, 2019 at 03:49:43PM -0400, Sean Paul wrote:
> From: Sean Paul
>
> This patch adds atomic_enable and atomic_disable callbacks to the
> encoder helpers. This will allow encoders to make informed decisions in
> their start-up/shutdown based on the committed state.
>
> Aside from the
amdkfd is now being upstreamed together with the amdgpu driver. Therefore,
update the maintainer entry for the driver with the name of the amdgpu
driver maintainer.
Signed-off-by: Oded Gabbay
---
MAINTAINERS | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/MAINTAINERS b/MA
Hi Dave, Alex.
I'm sending this to let you know I'm officialy leaving the role of amdkfd
maintainer. The driver is now being upstreamed by Alex and is an
integral part of amdgpu so I feel it is more correct to specify Alex as
the maintainer, especially for people who want to ask questions or send
https://bugs.freedesktop.org/show_bug.cgi?id=110596
Bug ID: 110596
Summary: inbox is going to blank page
Product: DRI
Version: unspecified
Hardware: All
OS: Linux (All)
Status: NEW
Severity: blocker
https://bugs.freedesktop.org/show_bug.cgi?id=110596
chandan changed:
What|Removed |Added
Resolution|--- |FIXED
Status|NEW
https://bugs.freedesktop.org/show_bug.cgi?id=110596
chandan changed:
What|Removed |Added
Priority|medium |high
--
You are receiving this mail because:
https://bugs.freedesktop.org/show_bug.cgi?id=110596
chandan changed:
What|Removed |Added
Status|RESOLVED|CLOSED
--
You are receiving this mail becaus
On 21/04/2019 01:14, Laurent Pinchart wrote:
> Hi Tomi,
>
> Thank you for the patch.
>
> On Tue, Mar 26, 2019 at 12:31:40PM +0200, Tomi Valkeinen wrote:
>> tc_main_link_enable() checks if videomode has been set, and fails if
>> there's no videomode. As tc_main_link_enable() no longer depends on t
Since the OOM interrupt directly deals with the binner bo, it doesn't
make sense to try and handle it without a binner buffer registered.
Signed-off-by: Paul Kocialkowski
---
drivers/gpu/drm/vc4/vc4_irq.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/vc4/vc4_irq.c b/driv
Check that we have a V3D device registered before attempting to
allocate a binner buffer object.
Signed-off-by: Paul Kocialkowski
---
drivers/gpu/drm/vc4/vc4_v3d.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/vc4/vc4_v3d.c b/drivers/gpu/drm/vc4/vc4_v3d.c
index 7c490106e
Changes since v7:
* Moved the used bool to vc4_v3d_bin_bo_get in order to check it locked and
avoid a possible race condition;
Changes since v6:
* Removed vc4_v3d_bin_bo_put from error paths;
* Added WARN_ON_ONCE when no bin BO at refcount release.
Changes since v5:
* Fix more locking mistakes;
The binner BO is not required until the V3D is in use, so avoid
allocating it at probe and do it on the first non-dumb BO allocation.
Keep track of which clients are using the V3D and liberate the buffer
when there is none left, using a kref. Protect the logic with a
mutex to avoid race conditions
In preparation for wrapping the binner bo allocation helper with
put/get helpers, pass the vc4 dev directly and drop the vc4 prefix.
Signed-off-by: Paul Kocialkowski
---
drivers/gpu/drm/vc4/vc4_v3d.c | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/
On Thu, May 02, 2019 at 03:49:44PM -0400, Sean Paul wrote:
> From: Sean Paul
>
> This patch adds a helper to tease out the currently connected crtc for
> an encoder, along with its state. This follows the same pattern as the
> drm_atomic_crtc_*_for_* macros in the atomic helpers. Since the
> rela
On Thu, May 02, 2019 at 03:49:46PM -0400, Sean Paul wrote:
> From: Sean Paul
>
> Everyone who implements connector_helper_funcs->atomic_check reaches
> into the connector state to get the atomic state. Instead of continuing
> this pattern, change the callback signature to just give atomic state
>
On 21/04/2019 01:13, Laurent Pinchart wrote:
> Hi Tomi,
>
> Thank you for the patch.
>
> On Tue, Mar 26, 2019 at 12:31:39PM +0200, Tomi Valkeinen wrote:
>> The current link training code does unnecessary retry-loops, and does
>> extra writes to the registers. It is easier to follow the flow and
>
Hi Daniel, hi Dave,
things are still slow in etnaviv land, so we don't have anything major
to destage. Just a couple of non-critical fixes that I want to land in
5.2.
Regards,
Lucas
The following changes since commit 9e98c678c2d6ae3a17cb2de55d17f69dddaa231b:
Linux 5.1-rc1 (2019-03-17 14:22:26
On Fri, May 03, 2019 at 09:54:35AM +1000, Dave Airlie wrote:
> On Thu, 2 May 2019 at 20:45, Liviu Dudau wrote:
> >
> > Hi DRM maintainers,
> >
> > This is the 2nd pull request for the malidp-next. The new patches add
> > additional support for Arm Mali D71 so that it can now be enabled
> > correct
On 21/04/2019 00:25, Laurent Pinchart wrote:
> Hi Tomi,
>
> Thank you for the patch.
>
> On Tue, Mar 26, 2019 at 12:31:31PM +0200, Tomi Valkeinen wrote:
>> The driver currently sets the video stream registers in
>> tc_main_link_setup. One should be able to establish the DP link without
>> any vid
On Fri, May 3, 2019 at 11:11 AM Liviu Dudau wrote:
>
> On Fri, May 03, 2019 at 09:54:35AM +1000, Dave Airlie wrote:
> > On Thu, 2 May 2019 at 20:45, Liviu Dudau wrote:
> > >
> > > Hi DRM maintainers,
> > >
> > > This is the 2nd pull request for the malidp-next. The new patches add
> > > additiona
On 21/04/2019 00:29, Laurent Pinchart wrote:
> Hi Tomi,
>
> Thank you for the patch.
>
> On Tue, Mar 26, 2019 at 12:31:32PM +0200, Tomi Valkeinen wrote:
>> It is nicer to have enable/disable functions instead of set(bool enable)
>> style function.
>
> When the two functions have nothing in commo
On Fri, May 03, 2019 at 11:15:23AM +0200, Daniel Vetter wrote:
> On Fri, May 3, 2019 at 11:11 AM Liviu Dudau wrote:
> >
> > On Fri, May 03, 2019 at 09:54:35AM +1000, Dave Airlie wrote:
> > > On Thu, 2 May 2019 at 20:45, Liviu Dudau wrote:
> > > >
> > > > Hi DRM maintainers,
> > > >
> > > > This i
On 21/04/2019 00:39, Laurent Pinchart wrote:
> Hi Tomi,
>
> Thank you for the patch.
>
> On Mon, Apr 15, 2019 at 02:39:21PM +0300, Tomi Valkeinen wrote:
>> On 15/04/2019 11:36, Andrzej Hajda wrote:
>>
+static int tc_main_link_disable(struct tc_data *tc)
+{
+ int ret;
+
+
On Fri, May 03, 2019 at 11:15:23AM +0200, Daniel Vetter wrote:
> On Fri, May 3, 2019 at 11:11 AM Liviu Dudau wrote:
> >
> > On Fri, May 03, 2019 at 09:54:35AM +1000, Dave Airlie wrote:
> > > On Thu, 2 May 2019 at 20:45, Liviu Dudau wrote:
> > > >
> > > > Hi DRM maintainers,
> > > >
> > > > This i
On Fri, May 03, 2019 at 09:54:35AM +1000, Dave Airlie wrote:
> On Thu, 2 May 2019 at 20:45, Liviu Dudau wrote:
> >
> > Hi DRM maintainers,
> >
> > This is the 2nd pull request for the malidp-next. The new patches add
> > additional support for Arm Mali D71 so that it can now be enabled
> > correct
Hi Christian,
would you review the whole patch set? Daniel mentioned that he'd prefer
to leave the review to memory-mgmt developers.
Best regards
Thomas
Am 30.04.19 um 11:35 schrieb Koenig, Christian:
> Am 30.04.19 um 11:23 schrieb Sam Ravnborg:
>> [CAUTION: External Email]
>>
>> Hi Thomas.
>>
>
Hi,
On Wed, Apr 17, 2019 at 03:50:19PM +0200, Lucas Stach wrote:
> This reworks the MMU handling to make it possible to have multiple
> MMU contexts, not one per GPU. This commit doesn't actually do anything
> with those contexts, aside from giving one of them to each GPU.
>
> The code changes are
https://bugzilla.kernel.org/show_bug.cgi?id=201273
--- Comment #51 from Marco (rodomar...@protonmail.com) ---
(In reply to Alex Deucher from comment #49)
> Can you still log in remotely via ssh and get an updated dmesg? If it's a
> blank screen, can you try another display connector on the board?
https://bugzilla.kernel.org/show_bug.cgi?id=201273
--- Comment #52 from Marco (rodomar...@protonmail.com) ---
(In reply to Marco from comment #51)
> (In reply to Alex Deucher from comment #49)
> > Can you still log in remotely via ssh and get an updated dmesg? If it's a
> > blank screen, can you
On Thu, 2 May 2019 at 23:19, Rob Clark wrote:
>
> On Thu, May 2, 2019 at 2:57 PM Dan Willemsen wrote:
> >
> > On Thu, May 2, 2019 at 1:52 PM John Stultz wrote:
> > >
> > > We need solutions for the xgettext and the python-mako usage.
> >
> > Android doesn't support translations at this level, s
On 21/04/2019 01:06, Laurent Pinchart wrote:
> Hi Tomi,
>
> Thank you for the patch.
>
> On Tue, Mar 26, 2019 at 12:31:38PM +0200, Tomi Valkeinen wrote:
>> The driver has a loop after ending link training, where it reads the
>> DPCD link status and prints an error if that status is not ok.
>>
>>
https://bugs.freedesktop.org/show_bug.cgi?id=109345
--- Comment #27 from Christian Zigotzky ---
Hi All,
Allan tested the first test kernel today. He wrote:
Hi Christian
The kernel boots but to SI card.
Cheers
ace
--
That means, this step has been marked as bad.
git bisect bad
Output:
On 21/04/2019 00:44, Laurent Pinchart wrote:
> Hi Tomi,
>
> Thank you for the patch.
>
> On Tue, Mar 26, 2019 at 12:31:37PM +0200, Tomi Valkeinen wrote:
>> At the end of the link training, two steps have to be taken: 1)
>> tc358767's LT mode is disabled by a write to DP0_SRCCTRL, and 2) Remove
>>
Hi Lucas,
On Wed, Apr 17, 2019 at 03:50:15PM +0200, Lucas Stach wrote:
>
> Hi all,
>
> v1 cover letter:
>
> the following patches finally implement one of the longstanding TODO
> items in the etnaviv driver: per-process address spaces. They are only
> enabled for MMUv2, as switching the MMU cont
https://bugs.freedesktop.org/show_bug.cgi?id=110598
Martin Peres changed:
What|Removed |Added
Depends on||110597
Referenced Bugs:
https://bugs.f
https://bugs.freedesktop.org/show_bug.cgi?id=110597
Martin Peres changed:
What|Removed |Added
Blocks||110598
Referenced Bugs:
https://bugs.f
https://bugs.freedesktop.org/show_bug.cgi?id=110597
Bug ID: 110597
Summary: [IGT runner] allow attachments to results.json
Product: DRI
Version: DRI git
Hardware: Other
OS: All
Status: NEW
Severity: normal
https://bugs.freedesktop.org/show_bug.cgi?id=110598
Bug ID: 110598
Summary: [IGT runner] allow tests to attach test-specific
results
Product: DRI
Version: DRI git
Hardware: Other
OS: All
Status:
On 23/04/2019 17:56, Laurent Pinchart wrote:
>> During initial driver development I had one eDP display that reports 0 in
>> Bit 0
>> (ANSI 8B/10B) of DPCD reg 0x0006 (MAIN_LINK_CHANNEL_CODING).
>> Also it does not react on setting Bit 0 (SET_ANSI 8B10B) in 0x0108
>> (MAIN_LINK_CHANNEL_CODING_SET
On Monday, 2019-04-29 18:10:52 +0900, Seung-Woo Kim wrote:
> In drmModeGetPropertyPtr(), from upper error path, it calls free
> but with just next error path, it does not call. Fix the possible
> memory leak.
>
> Signed-off-by: Seung-Woo Kim
Reviewed-by: Eric Engestrom
and pushed, thanks!
> --
On Sat, Apr 13, 2019 at 10:24 PM megous via linux-sunxi
wrote:
>
> From: Ondrej Jirman
>
> Orange Pi 3 has two regulators that power the Realtek RTL8211E. According
> to the phy datasheet, both regulators need to be enabled at the same time,
> but we can only specify a single phy-supply in the DT
On Fri, May 3, 2019 at 12:15 PM Thomas Zimmermann wrote:
>
> Hi Christian,
>
> would you review the whole patch set? Daniel mentioned that he'd prefer
> to leave the review to memory-mgmt developers.
I think Noralf Tronnes or Gerd Hoffmann would also make good reviewers
for this, fairly close to
Am 30.04.19 um 19:31 schrieb Russell King - ARM Linux admin:
On Tue, Apr 30, 2019 at 01:10:02PM +0200, Christian König wrote:
Add a structure for the parameters of dma_buf_attach, this makes it much easier
to add new parameters later on.
I don't understand this reasoning. What are the "new par
Am 03.05.19 um 14:01 schrieb Daniel Vetter:
> [CAUTION: External Email]
>
> On Fri, May 3, 2019 at 12:15 PM Thomas Zimmermann wrote:
>> Hi Christian,
>>
>> would you review the whole patch set? Daniel mentioned that he'd prefer
>> to leave the review to memory-mgmt developers.
> I think Noralf Tro
On Fri, May 03, 2019 at 02:05:47PM +0200, Christian König wrote:
> Am 30.04.19 um 19:31 schrieb Russell King - ARM Linux admin:
> > On Tue, Apr 30, 2019 at 01:10:02PM +0200, Christian König wrote:
> > > Add a structure for the parameters of dma_buf_attach, this makes it much
> > > easier
> > > to
Am 03.05.19 um 14:09 schrieb Daniel Vetter:
> [CAUTION: External Email]
>
> On Fri, May 03, 2019 at 02:05:47PM +0200, Christian König wrote:
>> Am 30.04.19 um 19:31 schrieb Russell King - ARM Linux admin:
>>> On Tue, Apr 30, 2019 at 01:10:02PM +0200, Christian König wrote:
Add a structure for
On Fri, May 03, 2019 at 10:29:48AM +0100, Liviu Dudau wrote:
> On Fri, May 03, 2019 at 11:15:23AM +0200, Daniel Vetter wrote:
> > On Fri, May 3, 2019 at 11:11 AM Liviu Dudau wrote:
> > >
> > > On Fri, May 03, 2019 at 09:54:35AM +1000, Dave Airlie wrote:
> > > > On Thu, 2 May 2019 at 20:45, Liviu D
We need to check whether drm_atomic_get_crtc_state() returns an error
pointer before dereferencing "crtc_st".
Fixes: 7d31b9e7a550 ("drm/komeda: Add komeda_plane/plane_helper_funcs")
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/arm/display/komeda/komeda_plane.c | 2 +-
1 file changed, 1 inser
cc: nor...@tronnes.org
Am 03.05.19 um 14:07 schrieb Koenig, Christian:
> Am 03.05.19 um 14:01 schrieb Daniel Vetter:
>> [CAUTION: External Email]
>>
>> On Fri, May 3, 2019 at 12:15 PM Thomas Zimmermann
>> wrote:
>>> Hi Christian,
>>>
>>> would you review the whole patch set? Daniel mentioned tha
https://bugs.freedesktop.org/show_bug.cgi?id=109124
Sylvain BERTRAND changed:
What|Removed |Added
Resolution|NOTABUG |NOTOURBUG
--- Comment #5 from Sylvai
We need to reset DPCD voltage-swing & pre-emphasis before starting the
link training, as otherwise tc358767 will use the previous values as
minimums.
Signed-off-by: Tomi Valkeinen
Reviewed-by: Andrzej Hajda
---
drivers/gpu/drm/bridge/tc358767.c | 7 +++
1 file changed, 7 insertions(+)
diff
Hi,
tc358767 bridge was originally implemented for eDP use with an embedded
panel. I've been working to add DP and HPD support, and this series is
the result. I did have a lot of issues with link training, but with
these, it's been working reliably with my devices.
Changes in v2
* Drop "implement
DP always uses ANSI 8B10B encoding. Some monitors (old?) may not have
the ANSI 8B10B bit set in DPCD, even if it should always be set.
The tc358767 driver currently respects that flag, and turns the encoding
off if the monitor does not have the bit set, which then results in the
monitor not workin
swing and preemp fields are not used. Remove them.
Signed-off-by: Tomi Valkeinen
Reviewed-by: Andrzej Hajda
Reviewed-by: Laurent Pinchart
---
drivers/gpu/drm/bridge/tc358767.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/bridge/tc358767.c
b/drivers/gpu/drm/bridge/tc358
Minor cleanups:
- Use bool for boolean fields
- Use DP_MAX_DOWNSPREAD_0_5 instead of BIT(0)
- debug print down-spread and scrambler status
Signed-off-by: Tomi Valkeinen
Reviewed-by: Andrzej Hajda
Reviewed-by: Laurent Pinchart
---
drivers/gpu/drm/bridge/tc358767.c | 13 -
1 file cha
The driver currently sets the video stream registers in
tc_main_link_setup. One should be able to establish the DP link without
any video stream, so a more logical place is to configure the stream in
the tc_main_link_stream. So move them there.
Signed-off-by: Tomi Valkeinen
Reviewed-by: Andrzej H
The driver sets up AUX link at probe time, but, for some reason, also
sets the main link's number of lanes using tc->link.base.num_lanes. This
is not needed nor correct, as the number of lanes has not been decided
yet. The number of lanes will be set later during main link setup.
Modify aux_link_s
tc_aux_get_status() does not report AUX_TIMEOUT correctly, as it only
checks the AUX_TIMEOUT if aux is still busy. Fix this by always checking
for AUX_TIMEOUT.
Signed-off-by: Tomi Valkeinen
Reviewed-by: Andrzej Hajda
---
drivers/gpu/drm/bridge/tc358767.c | 11 +++
1 file changed, 7 inse
The driver has a loop after ending link training, where it reads the
DPCD link status and prints an error if that status is not ok.
The loop is unnecessary, as far as I can understand from DP specs, so
let's remove it. We can also print the more specific errors to help
debugging.
Signed-off-by: T
Currently the code writes 0 to DP0CTL in tc_stream_disable(), which
disables the whole DP link instead of just the video stream. We always
disable the link and the stream together from tc_bridge_disable(), so
this doesn't cause any issues.
Nevertheless, fix this by only clearing VID_EN in tc_strea
Currently we have tc_main_link_setup(), which configures and enabled the
link, but we have no counter-part for disabling the link.
Add tc_main_link_disable, and rename tc_main_link_setup to
tc_main_link_enable.
Signed-off-by: Tomi Valkeinen
---
drivers/gpu/drm/bridge/tc358767.c | 27 +++
tc_main_link_enable() checks if videomode has been set, and fails if
there's no videomode. As tc_main_link_enable() no longer depends on the
videomode, we can drop the check.
Also, while tc_stream_enable() does depend on the videomode, we can
expect that a mode has been set before drm_bridge_funcs
drm_connector_helper_funcs.best_encoder is only needed when the
connector can have more than one encoder, and that is never the case
here.
So remove tc_connector_best_encoder.
Signed-off-by: Tomi Valkeinen
Reviewed-by: Andrzej Hajda
Reviewed-by: Laurent Pinchart
---
drivers/gpu/drm/bridge/tc3
At the end of the link training, two steps have to be taken: 1)
tc358767's LT mode is disabled by a write to DP0_SRCCTRL, and 2) Remove
LT flag in DPCD 0x102.
Toshiba's documentation tells to first write the DPCD, then modify
DP0_SRCCTRL. In my testing this often causes issues, and the link
discon
Link training will sometimes fail if the DP link is enabled when
tc_main_link_enable() is called. The driver makes sure the DP link is
disabled when the DP output is disabled, and we never enable the DP
without first disabling it, so this should never happen.
However, as the HW behavior seems to b
We set up the PXL PLL inside tc_main_link_setup. This is unnecessary,
and makes tc_main_link_setup depend on the video-mode, which should not
be the case. As PXL PLL is used only for the video stream (and only when
using the HW test pattern), let's move the PXL PLL setup into
tc_stream_enable.
Als
https://bugs.freedesktop.org/show_bug.cgi?id=110214
--- Comment #87 from komqin...@zoho.eu ---
I have the same bug with xterm and shift+paging.
Another similar bug.
xfce4-terminal leaves a large black area at the bottom when it renders 'dmesg'
or 'cat /etc/passwd'.
AMD Ryzen 3 2200G.
Arch Linux.
It is nicer to have enable/disable functions instead of set(bool enable)
style function.
Split tc_main_link_stream into tc_stream_enable and tc_stream_disable.
Signed-off-by: Tomi Valkeinen
---
drivers/gpu/drm/bridge/tc358767.c | 81 +--
1 file changed, 45 insertions
Add support for interrupt and hotplug handling. Both are optional.
Signed-off-by: Tomi Valkeinen
---
drivers/gpu/drm/bridge/tc358767.c | 166 ++
1 file changed, 148 insertions(+), 18 deletions(-)
diff --git a/drivers/gpu/drm/bridge/tc358767.c
b/drivers/gpu/drm/bridg
The current link training code does unnecessary retry-loops, and does
extra writes to the registers. It is easier to follow the flow and
ensure it's similar to Toshiba's documentation if we deal with LT inside
tc_main_link_enable() function.
This patch adds tc_wait_link_training() which handles wa
Add GPIO and interrupt related registers for HPD work. Mark INTSTS_G and
GPIOI as volatile.
Signed-off-by: Tomi Valkeinen
Reviewed-by: Andrzej Hajda
---
drivers/gpu/drm/bridge/tc358767.c | 8
1 file changed, 8 insertions(+)
diff --git a/drivers/gpu/drm/bridge/tc358767.c
b/drivers/gpu
On Fri, May 03, 2019 at 09:51:30AM +0200, Daniel Vetter wrote:
> On Thu, May 02, 2019 at 03:49:43PM -0400, Sean Paul wrote:
> > From: Sean Paul
> >
> > This patch adds atomic_enable and atomic_disable callbacks to the
> > encoder helpers. This will allow encoders to make informed decisions in
> >
For some reason the driver has a msleep(100) after writing to
DP_PHY_CTRL. Toshiba's documentation doesn't suggest any delay is
needed, and I have not seen any issues with the sleep removed.
Drop it, as msleep(100) is a rather big one.
Signed-off-by: Tomi Valkeinen
Reviewed-by: Andrzej Hajda
Re
We have tc_connector_mode_valid() to filter out videomdoes that the
tc358767 cannot support. As it is a bridge limitation, change the code
to use drm_bridge_funcs's mode_valid instead.
Signed-off-by: Tomi Valkeinen
Reviewed-by: Andrzej Hajda
Reviewed-by: Laurent Pinchart
---
drivers/gpu/drm/br
Am 30.04.19 um 16:16 schrieb Daniel Vetter:
[SNIP]
/**
- * amdgpu_gem_map_attach - &dma_buf_ops.attach implementation
- * @dma_buf: Shared DMA buffer
+ * amdgpu_gem_pin_dma_buf - &dma_buf_ops.pin_dma_buf implementation
+ *
+ * @dma_buf: DMA-buf to pin in memory
+ *
+ * Pin the BO which is back
In tc_bridge_mode_set callback, we store the pointer to the given
drm_display_mode, and use the mode later. Storing a pointer in such a
way looks very suspicious to me, and I have observed odd issues where
the timings were apparently (at least mostly) zero.
Do a copy of the drm_display_mode instea
Add DT property for defining the pin used for HPD.
Signed-off-by: Tomi Valkeinen
Cc: devicet...@vger.kernel.org
Cc: Rob Herring
Reviewed-by: Rob Herring
---
.../devicetree/bindings/display/bridge/toshiba,tc358767.txt | 1 +
1 file changed, 1 insertion(+)
diff --git
a/Documentation/devic
https://bugs.freedesktop.org/show_bug.cgi?id=110599
Bug ID: 110599
Summary: [IGT runner] Per-test external watchdog
Product: DRI
Version: DRI git
Hardware: Other
OS: All
Status: NEW
Severity: normal
On Fri, May 03, 2019 at 10:18:51AM +0200, Daniel Vetter wrote:
> On Thu, May 02, 2019 at 03:49:44PM -0400, Sean Paul wrote:
> > From: Sean Paul
> >
> > This patch adds a helper to tease out the currently connected crtc for
> > an encoder, along with its state. This follows the same pattern as the
https://bugs.freedesktop.org/show_bug.cgi?id=110600
Bug ID: 110600
Summary: [IGT runner] be more consistent with checks on
display/outputs
Product: DRI
Version: DRI git
Hardware: Other
OS: All
St
Hi Tomi,
On Fri, May 03, 2019 at 02:43:51PM +0300, Tomi Valkeinen wrote:
> On 23/04/2019 17:56, Laurent Pinchart wrote:
>
> >> During initial driver development I had one eDP display that reports 0 in
> >> Bit 0
> >> (ANSI 8B/10B) of DPCD reg 0x0006 (MAIN_LINK_CHANNEL_CODING).
> >> Also it does
Hi Tomi,
On Fri, May 03, 2019 at 12:20:49PM +0300, Tomi Valkeinen wrote:
> On 21/04/2019 00:29, Laurent Pinchart wrote:
> > On Tue, Mar 26, 2019 at 12:31:32PM +0200, Tomi Valkeinen wrote:
> >> It is nicer to have enable/disable functions instead of set(bool enable)
> >> style function.
> >
> > Wh
Hi Tomi,
On Fri, May 03, 2019 at 11:10:54AM +0300, Tomi Valkeinen wrote:
> On 21/04/2019 01:14, Laurent Pinchart wrote:
> > On Tue, Mar 26, 2019 at 12:31:40PM +0200, Tomi Valkeinen wrote:
> >> tc_main_link_enable() checks if videomode has been set, and fails if
> >> there's no videomode. As tc_mai
On 03/05/2019 15:55, Laurent Pinchart wrote:
- if (state) {
- ret = tc_set_video_mode(tc, tc->mode);
- if (ret)
- goto err;
+ ret = tc_set_video_mode(tc, tc->mode);
+ if (ret)
+ goto err;
>>>
>>> Let's return
On 03/05/2019 15:48, Laurent Pinchart wrote:
> Hi Tomi,
>
> On Fri, May 03, 2019 at 02:43:51PM +0300, Tomi Valkeinen wrote:
>> On 23/04/2019 17:56, Laurent Pinchart wrote:
>>
During initial driver development I had one eDP display that reports 0 in
Bit 0
(ANSI 8B/10B) of DPCD reg 0
Am 03.05.19 um 14:27 schrieb Thomas Zimmermann:
> cc: nor...@tronnes.org
Actually cc him
> Am 03.05.19 um 14:07 schrieb Koenig, Christian:
>> Am 03.05.19 um 14:01 schrieb Daniel Vetter:
>>> [CAUTION: External Email]
>>>
>>> On Fri, May 3, 2019 at 12:15 PM Thomas Zimmermann
>>> wrote:
Hi Ch
On Thu, May 02, 2019 at 02:01:45PM +0200, Lucas Stach wrote:
> Hi Daniel,
>
> Am Donnerstag, den 02.05.2019, 11:33 +0100 schrieb Daniel Thompson:
> > On 29/04/2019 16:29, Lucas Stach wrote:
> > > This way the backlight can be referenced through its device node and
> > > enabling/disabling can be m
On Fri, May 3, 2019 at 2:47 PM Sean Paul wrote:
> On Fri, May 03, 2019 at 10:18:51AM +0200, Daniel Vetter wrote:
> > On Thu, May 02, 2019 at 03:49:44PM -0400, Sean Paul wrote:
> > > From: Sean Paul
> > >
> > > This patch adds a helper to tease out the currently connected crtc for
> > > an encoder
On Fri, May 3, 2019 at 2:34 PM Sean Paul wrote:
>
> On Fri, May 03, 2019 at 09:51:30AM +0200, Daniel Vetter wrote:
> > On Thu, May 02, 2019 at 03:49:43PM -0400, Sean Paul wrote:
> > > From: Sean Paul
> > >
> > > This patch adds atomic_enable and atomic_disable callbacks to the
> > > encoder helpe
On 5/1/19 5:01 PM, Brendan Higgins wrote:
From: Avinash Kondareddy
Tests how tests interact with test managed resources in their lifetime.
Signed-off-by: Avinash Kondareddy
Signed-off-by: Brendan Higgins
---
I think this change log could use more details. It is vague on what it
does.
than
On Mon, 29 Apr 2019 at 23:10, Chia-I Wu wrote:
>
> It was changed to GFP_ATOMIC in commit ec2f0577c (add & use
> virtio_gpu_queue_fenced_ctrl_buffer) because the allocation happened
> with a spinlock held. That was no longer true after commit
> 9fdd90c0f (add virtio_gpu_alloc_fence()).
>
> Signed
On 5/1/19 5:01 PM, Brendan Higgins wrote:
Add myself as maintainer of KUnit, the Linux kernel's unit testing
framework.
Signed-off-by: Brendan Higgins
---
MAINTAINERS | 10 ++
1 file changed, 10 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 5c38f21aee787..c78ae95c56b80
On Fri, May 03, 2019 at 03:25:25PM +0300, Dan Carpenter wrote:
> We need to check whether drm_atomic_get_crtc_state() returns an error
> pointer before dereferencing "crtc_st".
>
> Fixes: 7d31b9e7a550 ("drm/komeda: Add komeda_plane/plane_helper_funcs")
> Signed-off-by: Dan Carpenter
Acked-by: Li
On 03.05.19 16:31, Emil Velikov wrote:
On Mon, 29 Apr 2019 at 23:10, Chia-I Wu wrote:
It was changed to GFP_ATOMIC in commit ec2f0577c (add & use
virtio_gpu_queue_fenced_ctrl_buffer) because the allocation happened
with a spinlock held. That was no longer true after commit
9fdd90c0f (add virt
Hi Chia-I,
On Mon, 29 Apr 2019 at 23:08, Chia-I Wu wrote:
>
> This is motivated by having meaningful ftrace events, but it also
> fixes use cases where dma_fence_is_later is called, such as in
> sync_file_merge.
>
> In other drivers, fence creation and cmdbuf submission normally
> happen atomical
1 - 100 of 133 matches
Mail list logo
