Re: [PATCH v5 1/2] drm/bridge: sil_sii8620: make remote control optional.

2019-04-16 Thread Life is hard, and then you die
Hi Andrzej, On Mon, Apr 15, 2019 at 10:58:09AM +0200, Andrzej Hajda wrote: > On 15.04.2019 10:12, Ronald Tschalär wrote: > > commit d6abe6df706c (drm/bridge: sil_sii8620: do not have a dependency > > of RC_CORE) changed the driver to select both RC_CORE and INPUT. > > However, this causes probl

[PATCH v2 1/2] drm/ttm: Reset ttm_mem_global when initialized

2019-04-16 Thread Brian Yip
Certain attributes such as num_zones and kobj in the ttm_mem_global structure were never reset after calling ttm_mem_global_release(). Consequently, when multiple GPU drivers are loaded, and the first one fails to load its firmware, the second driver will attempt to load its own firmware. Initializ

Re: [PATCH] video: fbdev: atmel_lcdfb: add COMPILE_TEST support

2019-04-16 Thread Alexandre Belloni
On 12/04/2019 13:29:11+0200, Bartlomiej Zolnierkiewicz wrote: > Add COMPILE_TEST support to atmel_lcdfb driver for better compile > testing coverage. > > Signed-off-by: Bartlomiej Zolnierkiewicz Acked-by: Alexandre Belloni > --- > drivers/video/fbdev/Kconfig |2 +- > 1 file changed, 1 inse

Re: [PATCH 1/2] include: linux: Regularise the use of FIELD_SIZEOF macro

2019-04-16 Thread Shyam Saini
Hi, On Mon, Apr 15, 2019 at 11:13 AM Alexei Starovoitov wrote: > > On Sun, Apr 14, 2019 at 2:15 AM Shyam Saini > wrote: > > > > Currently, there are 3 different macros, namely sizeof_field, SIZEOF_FIELD > > and FIELD_SIZEOF which are used to calculate the size of a member of > > structure, so to

Re: [PATCH 3/4] lib/hexdump.c: Replace ascii bool in hex_dump_to_buffer with flags

2019-04-16 Thread Petr Mladek
On Sat 2019-04-13 09:31:27, Alastair D'Silva wrote: > > -Original Message- > > From: Petr Mladek > > Sent: Saturday, 13 April 2019 12:12 AM > > To: Alastair D'Silva > > Cc: alast...@d-silva.org; Jani Nikula ; > Joonas > > Lahtinen ; Rodrigo Vivi > > ; David Airlie ; Daniel Vetter > > ; Ka

RE: [PATCH 3/4] lib/hexdump.c: Replace ascii bool in hex_dump_to_buffer with flags

2019-04-16 Thread Alastair D'Silva
> -Original Message- > From: Petr Mladek > Sent: Monday, 15 April 2019 7:24 PM > To: Alastair D'Silva > Cc: 'Alastair D'Silva' ; 'Jani Nikula' > ; 'Joonas Lahtinen' > ; 'Rodrigo Vivi' ; > 'David Airlie' ; 'Daniel Vetter' ; 'Karsten > Keil' ; 'Jassi Brar' ; 'Tom > Lendacky' ; 'David S. Mil

[PATCH v3 3/3] backlight: lm3630a: add firmware node support

2019-04-16 Thread Brian Masney
Add fwnode support to the lm3630a driver and allow configuring the initial and maximum LED brightness on both LED banks independently. The two outputs can be controlled by bank A and B independently or bank A can control both outputs. If the platform data was not configured, then the driver defaul

RE: [PATCH 3/4] lib/hexdump.c: Replace ascii bool in hex_dump_to_buffer with flags

2019-04-16 Thread David Laight
From: Alastair D'Silva > Sent: 15 April 2019 11:07 ... > In the above example the author only wants the hex output, while in other > situations, both hex & ASCII output is desirable. If you just want ASCII > output, the caller should just use a printk or one of it's wrappers. Hexdump will 'sanitis

Re: [PATCH 2/4] lib/hexdump.c: Optionally suppress lines of filler bytes

2019-04-16 Thread Petr Mladek
On Sat 2019-04-13 09:28:03, Alastair D'Silva wrote: > > -Original Message- > > From: Petr Mladek > > Sent: Saturday, 13 April 2019 12:04 AM > > To: Alastair D'Silva > > Cc: alast...@d-silva.org; Jani Nikula ; > Joonas > > Lahtinen ; Rodrigo Vivi > > ; David Airlie ; Daniel Vetter > > ; Ka

[PATCH v5 2/2] Input: add Apple SPI keyboard and trackpad driver.

2019-04-16 Thread Ronald Tschalär
The keyboard and trackpad on recent MacBook's (since 8,1) and MacBookPro's (13,* and 14,*) are attached to an SPI controller instead of USB, as previously. The higher level protocol is not publicly documented and hence has been reverse engineered. As a consequence there are still a number of unknow

Re: [PATCH 1/4] lib/hexdump.c: Allow 64 bytes per line

2019-04-16 Thread Petr Mladek
On Sat 2019-04-13 09:22:05, Alastair D'Silva wrote: > > -Original Message- > > From: Petr Mladek > > Sent: Friday, 12 April 2019 11:48 PM > > To: Alastair D'Silva > > Cc: alast...@d-silva.org; Jani Nikula ; > Joonas > > Lahtinen ; Rodrigo Vivi > > ; David Airlie ; Daniel Vetter > > ; Kars

Re: [PATCH v5 2/2] Input: add Apple SPI keyboard and trackpad driver.

2019-04-16 Thread Andy Shevchenko
On Mon, Apr 15, 2019 at 01:13:00AM -0700, Ronald Tschalär wrote: > The keyboard and trackpad on recent MacBook's (since 8,1) and > MacBookPro's (13,* and 14,*) are attached to an SPI controller instead > of USB, as previously. The higher level protocol is not publicly > documented and hence has bee

[PATCH v2 2/2] drm/ttm: Reset ttm_bo_glob when initialized

2019-04-16 Thread Brian Yip
Always initialize ttm_bo_glob from a pristine state when its use_count is 0. Persist use_count so that ttm_bo_glob can later be released. Signed-off-by: Brian Yip --- drivers/gpu/drm/ttm/ttm_bo.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.

RE: [PATCH 1/4] lib/hexdump.c: Allow 64 bytes per line

2019-04-16 Thread Alastair D'Silva
> > > On Wed 2019-04-10 13:17:17, Alastair D'Silva wrote: > > > > From: Alastair D'Silva > > > > > > > > With modern high resolution screens, we can display more data, > > > > which makes life a bit easier when debugging. > > > > > > I have quite some doubts about this feature. > > > > > > We are

RE: [PATCH 2/4] lib/hexdump.c: Optionally suppress lines of filler bytes

2019-04-16 Thread Alastair D'Silva
> > > On Wed 2019-04-10 13:17:18, Alastair D'Silva wrote: > > > > From: Alastair D'Silva > > > > > > > > Some buffers may only be partially filled with useful data, while > > > > the rest is padded (typically with 0x00 or 0xff). > > > > > > > > This patch introduces flags which allow lines of padd

[PATCH v3 2/3] dt-bindings: backlight: add lm3630a bindings

2019-04-16 Thread Brian Masney
Add new backlight bindings for the TI LM3630A dual-string white LED. Signed-off-by: Brian Masney --- Rob: Since the common bindings aren't converted to the new JSON schema yet, I'm not sure how to do led-sources here. I would expect that we'd have the uint32-array on the common binding once it ex

Re: [PATCH v2 3/3] drm/panfrost: Add initial panfrost driver

2019-04-16 Thread Steven Price
On 15/04/2019 10:18, Daniel Vetter wrote: > On Fri, Apr 05, 2019 at 05:42:33PM +0100, Steven Price wrote: >> On 05/04/2019 17:16, Alyssa Rosenzweig wrote: >>> acronym once ever and have it as a "??"), I'm not sure how to respond to >>> that... We don't know how to allocate memory for the GPU-intern

RE: [PATCH 3/4] lib/hexdump.c: Replace ascii bool in hex_dump_to_buffer with flags

2019-04-16 Thread Alastair D'Silva
> -Original Message- > From: David Laight > Sent: Monday, 15 April 2019 9:04 PM > To: 'Alastair D'Silva' ; 'Petr Mladek' > > Cc: 'Alastair D'Silva' ; 'Jani Nikula' > ; 'Joonas Lahtinen' > ; 'Rodrigo Vivi' ; > 'David Airlie' ; 'Daniel Vetter' ; 'Karsten > Keil' ; 'Jassi Brar' ; 'Tom > Lend

[PATCH v3 0/3] backlight: lm3630a: bug fix and fwnode support

2019-04-16 Thread Brian Masney
Here is a patch series that fixes a single bug and adds fwnode support to the lm3630a driver. This work was tested on a LG Nexus 5 (hammerhead) phone. My status page at https://masneyb.github.io/nexus-5-upstream/ describes what is working so far with the upstream kernel. See the individual patches

RE: [PATCH 1/4] lib/hexdump.c: Allow 64 bytes per line

2019-04-16 Thread Alastair D'Silva
> From: Alastair D'Silva > > Sent: 15 April 2019 11:29 > ... > > I do, and I believe the choice of the output length should be in the > > hands of the caller. > > > > On further thought, it would make more sense to remove the hardcoded > > list of sizes and just enforce a power of 2. The function s

Re: [PATCH v3 2/3] dt-bindings: backlight: add lm3630a bindings

2019-04-16 Thread Brian Masney
On Mon, Apr 15, 2019 at 07:10:04AM -0500, Dan Murphy wrote: > I noticed we are missing "label". It is defined as optional and it is hard > coded in the driver > but wondering if there is a need to add it. OK, I'll make it optional and have it fall back to the hardcoded values if it is missing.

Re: [PATCH v3 3/3] backlight: lm3630a: add firmware node support

2019-04-16 Thread Dan Murphy
On 4/15/19 2:29 AM, Brian Masney wrote: > Add fwnode support to the lm3630a driver and allow configuring > the initial and maximum LED brightness on both LED banks independently. > The two outputs can be controlled by bank A and B independently or > bank A can control both outputs. > > If the pl

RE: [PATCH 3/4] lib/hexdump.c: Replace ascii bool in hex_dump_to_buffer with flags

2019-04-16 Thread Alastair D'Silva
> -Original Message- > From: David Laight > Sent: Monday, 15 April 2019 8:21 PM > To: 'Alastair D'Silva' ; 'Petr Mladek' > > Cc: 'Alastair D'Silva' ; 'Jani Nikula' > ; 'Joonas Lahtinen' > ; 'Rodrigo Vivi' ; > 'David Airlie' ; 'Daniel Vetter' ; 'Karsten > Keil' ; 'Jassi Brar' ; 'Tom > Lend

Re: [PATCH v3 2/3] dt-bindings: backlight: add lm3630a bindings

2019-04-16 Thread Dan Murphy
Brian On 4/15/19 2:29 AM, Brian Masney wrote: > Add new backlight bindings for the TI LM3630A dual-string white LED. > > Signed-off-by: Brian Masney > --- > Rob: Since the common bindings aren't converted to the new JSON schema > yet, I'm not sure how to do led-sources here. I would expect that w

Re: [PATCH 1/2] include: linux: Regularise the use of FIELD_SIZEOF macro

2019-04-16 Thread William Kucharski
> On Apr 14, 2019, at 3:14 AM, Shyam Saini > wrote: > > Currently, there are 3 different macros, namely sizeof_field, SIZEOF_FIELD > and FIELD_SIZEOF which are used to calculate the size of a member of > structure, so to bring uniformity in entire kernel source tree lets use > FIELD_SIZEOF and

Re: [PATCH 3/3] drm/panel: simple: Add Evervision VGG804821 pannel support

2019-04-16 Thread Marco Felsch
Hi Thierry, gentle ping. On 19-01-14 11:28, Marco Felsch wrote: > Hi Sam, > > On 19-01-04 17:40, Sam Ravnborg wrote: > > Hi Marco. > > > > In $subject pannel => panel > > Thanks for covering that, Thierry can you fix this inline? Is that doable for you? Regards, Marco > Regards, >

RE: [PATCH 1/4] lib/hexdump.c: Allow 64 bytes per line

2019-04-16 Thread David Laight
From: Alastair D'Silva > Sent: 15 April 2019 11:29 ... > I do, and I believe the choice of the output length should be in the hands > of the caller. > > On further thought, it would make more sense to remove the hardcoded list of > sizes and just enforce a power of 2. The function shouldn't dictat

RE: [PATCH 3/4] lib/hexdump.c: Replace ascii bool in hex_dump_to_buffer with flags

2019-04-16 Thread David Laight
From: Alastair D'Silva > Sent: 15 April 2019 11:45 ... > > Although I think you'd want a 'no hex' flag to suppress the hex. > > > > Probably more useful flags are ones to suppress the address column. > > This is already supported by the prefix_type parameter - are you proposing > that we eliminat

Re: [PATCH 3/3] drm/panel: simple: Add Evervision VGG804821 pannel support

2019-04-16 Thread Marco Felsch
Hi Sam, thanks for your fast response =) On 19-04-15 18:10, Sam Ravnborg wrote: > Hi Marco > > On Mon, Apr 15, 2019 at 05:46:48PM +0200, Marco Felsch wrote: > > Hi Thierry, > > > > gentle ping. > > > > On 19-01-14 11:28, Marco Felsch wrote: > > > Hi Sam, > > > > > > On 19-01-04 17:40, Sam Rav

[PATCH v5 1/2] drm/bridge: sil_sii8620: make remote control optional.

2019-04-16 Thread Ronald Tschalär
commit d6abe6df706c (drm/bridge: sil_sii8620: do not have a dependency of RC_CORE) changed the driver to select both RC_CORE and INPUT. However, this causes problems with other drivers, in particular an input driver that depends on MFD_INTEL_LPSS_PCI (to be added in a separate commit): drivers/c

Re: [PATCH v5 2/2] Input: add Apple SPI keyboard and trackpad driver.

2019-04-16 Thread Life is hard, and then you die
Hi Andy, On Mon, Apr 15, 2019 at 12:03:46PM +0300, Andy Shevchenko wrote: > On Mon, Apr 15, 2019 at 01:13:00AM -0700, Ronald Tschalär wrote: > > The keyboard and trackpad on recent MacBook's (since 8,1) and > > MacBookPro's (13,* and 14,*) are attached to an SPI controller instead > > of USB, a

[PATCH v2 0/2] drm/ttm: Cleanup state in global ttm structures

2019-04-16 Thread Brian Yip
State in global ttm structures was not properly reset on cleanup. In the scenario where multiple drm drivers are loaded and the first one fails to initialize, there is an attempt to reset the global state in the ttm structures. However, there were some attributes which were not properly reset dur

[PATCH v3 1/3] backlight: lm3630a: return 0 on success in update_status functions

2019-04-16 Thread Brian Masney
lm3630a_bank_a_update_status() and lm3630a_bank_b_update_status() both return the brightness value if the brightness was successfully updated. Writing to these attributes via sysfs would cause a 'Bad address' error to be returned. These functions should return 0 on success, so let's change it to co

[PATCH v5 0/2] Add Apple SPI keyboard and trackpad driver

2019-04-16 Thread Ronald Tschalär
This changeset adds a driver for the SPI keyboard and trackpad on recent MacBook's and MacBook Pro's. The driver has seen a fair amount of use over the last 2 years (basically anybody running linux on these machines), with only relatively small changes in the last year or so. For those interested,

Re: [PATCH] drm: add DRM_PRIME_CAP_LOCAL

2019-04-16 Thread Daniel Vetter
On Wed, Apr 10, 2019 at 09:47:12AM +0200, Gerd Hoffmann wrote: > Some drivers (for example qxl) support neither import nor export of > dma-bufs. But you can still use dma-bufs to pass buffer references > from one process to another; drm_gem_prime_import() will figure the > dma-buf came from the sa

Re: [PATCH] drm: fix drm_fb_xrgb8888_to_rgb888_dstclip()

2019-04-16 Thread Daniel Vetter
On Thu, Apr 11, 2019 at 06:49:32AM +0200, Gerd Hoffmann wrote: > Oops, the __iomem annotation was added to the header file only. > Add it to the implementation (and documentation) too. > > Fixes: 5c5373b51bec ("drm: switch drm_fb_xrgb_to_rgb888_dstclip to accept > __iomem dst") > Signed-off-b

Re: [Intel-gfx] [v3 1/7] drm: Add gamma mode property

2019-04-16 Thread Daniel Vetter
On Fri, Apr 12, 2019 at 03:50:57PM +0530, Uma Shankar wrote: > From: Ville Syrjälä > > Add a gamma mode property to enable various kind of > gamma modes supported by platforms like: Interpolated, Split, > Multi Segmented etc. Userspace can get this property and > should be able to get the platfor

Re: [v2,1/2] drm: Add writeback_w,h properties

2019-04-16 Thread Daniel Vetter
On Mon, Apr 15, 2019 at 10:20:45AM +0100, Liviu Dudau wrote: > On Mon, Apr 15, 2019 at 08:59:30AM +0100, james qian wang (Arm Technology > China) wrote: > > On Fri, Apr 12, 2019 at 02:08:28PM +, Ben Davis wrote: > > > Add new properties to specify width and height for writeback. > > > > > > S

Re: [PATCH v1] drm: Do not allow to set NOFB for active primary plane

2019-04-16 Thread Daniel Vetter
On Mon, Apr 15, 2019 at 11:27:25AM +, Lisovskiy, Stanislav wrote: > On Mon, 2019-04-15 at 12:40 +0200, Maarten Lankhorst wrote: > > Op 15-04-2019 om 10:00 schreef Stanislav Lisovskiy: > > > There was an issue reported from end users, confirmed > > > also locally that when user executes xrandr -

Re: [PATCH v2 17/25] drm/mediatek: add background color input select function for ovl/ovl_2l

2019-04-16 Thread CK Hu
Hi, Yongqiang: On Wed, 2019-03-27 at 14:19 +0800, yongqiang@mediatek.com wrote: > From: Yongqiang Niu > > This patch add background color input select function for ovl/ovl_2l > > ovl include 4 DRAM layer and 1 background color layer > ovl_2l include 4 DRAM layer and 1 background color layer

Re: [PATCH] drm: Expose "FB_DAMAGE_CLIPS" property to atomic aware user-space only

2019-04-16 Thread Daniel Vetter
On Mon, Apr 15, 2019 at 05:28:05PM +, Deepak Singh Rawat wrote: > Plane property "FB_DAMAGE_CLIPS" can only be used by atomic aware > user-space, so no point exposing it otherwise. > > Signed-off-by: Deepak Rawat > Fixes: d3b21767821e ("drm: Add a new plane property to send damage during > p

Re: [PATCH] drm: turn syncobj timeline support off by default

2019-04-16 Thread Daniel Vetter
On Mon, Apr 15, 2019 at 08:48:25PM +0100, Lionel Landwerlin wrote: > Unfortunately userspace users of this API cannot be publicly disclosed > yet so disable this stuff by default until all is revealed. > > Signed-off-by: Lionel Landwerlin > --- > drivers/gpu/drm/Kconfig | 10 ++ >

Re: [PATCH v2 3/3] drm/panfrost: Add initial panfrost driver

2019-04-16 Thread Daniel Vetter
On Mon, Apr 15, 2019 at 10:30:14AM +0100, Steven Price wrote: > On 15/04/2019 10:18, Daniel Vetter wrote: > > On Fri, Apr 05, 2019 at 05:42:33PM +0100, Steven Price wrote: > >> On 05/04/2019 17:16, Alyssa Rosenzweig wrote: > >>> acronym once ever and have it as a "??"), I'm not sure how to respond

[RFC] MAINTAINERS: Add Sam as reviewer for drm/panel

2019-04-16 Thread Thierry Reding
From: Thierry Reding Sam has been helping out a lot with reviewing DRM panel patches. Add him as reviewer to help him do this important work. Signed-off-by: Thierry Reding --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index c227d2818c98..3d199592

Re: [PATCH v2 02/12] drm/fb-helper: Avoid race with DRM userspace

2019-04-16 Thread Daniel Vetter
On Sun, Apr 07, 2019 at 06:52:33PM +0200, Noralf Trønnes wrote: > drm_fb_helper_is_bound() is used to check if DRM userspace is in control. > This is done by looking at the fb on the primary plane. By the time > fb-helper gets around to committing, it's possible that the facts have > changed. > >

Re: [PATCH v2 18/25] drm/mediatek: add RDMA fifo size error handle

2019-04-16 Thread CK Hu
Hi, Yongqiang: On Wed, 2019-03-27 at 14:19 +0800, yongqiang@mediatek.com wrote: > From: Yongqiang Niu > > This patch add RDMA fifo size error handle > rdma fifo size will not always bigger than the calculated threshold > if that case happened, we need set fifo size as the threshold > > Sign

Re: [RFC] MAINTAINERS: Add Sam as reviewer for drm/panel

2019-04-16 Thread Jagan Teki
On Tue, Apr 16, 2019 at 1:29 PM Thierry Reding wrote: > > From: Thierry Reding > > Sam has been helping out a lot with reviewing DRM panel patches. Add him > as reviewer to help him do this important work. > > Signed-off-by: Thierry Reding > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertio

Re: [PATCH v2 20/25] drm/mediatek: add ovl0/ovl0_2l usecase

2019-04-16 Thread CK Hu
Hi, Yongqiang: On Wed, 2019-03-27 at 14:19 +0800, yongqiang@mediatek.com wrote: > From: Yongqiang Niu > > This patch add ovl0/ovl0_2l usecase > in ovl->ovl0_2l direct link usecase: > 1. the crtc support layer number will 4+2 > 2. ovl0_2l background color input select ovl0 when crtc init > an

Re: [PATCH v2 22/25] drm/mediatek: adjust ddp clock control flow

2019-04-16 Thread CK Hu
Hi, Yongqiang: On Wed, 2019-03-27 at 14:19 +0800, yongqiang@mediatek.com wrote: > From: Yongqiang Niu > > display hardware clock will not unprepare when > crtc is disable, until crtc is destroyed. > with this patch, hard clock will disable and unprepare > at the same time. Reviewed-by: CK H

Re: [PATCH v2 23/25] drm/mediatek: add vmap support for mediatek drm

2019-04-16 Thread CK Hu
Hi, Yongqiang: On Wed, 2019-03-27 at 14:19 +0800, yongqiang@mediatek.com wrote: > From: Yongqiang Niu > > This patch add add vmap support for mediatek drm I think the upstreamed patch 'drm/mediatek: Implement gem prime vmap/vunmap function' [1] has the same function of this patch. You could

Re: [PATCH v2 06/12] drm/fb-helper: Remove drm_fb_helper_crtc

2019-04-16 Thread Daniel Vetter
On Sun, Apr 07, 2019 at 06:52:37PM +0200, Noralf Trønnes wrote: > It now only contains the modeset so use that directly instead and attach > a modeset array to drm_client_dev. drm_fb_helper will use this array. > Code will later be moved to drm_client, so add code there in a new file > drm_client_m

Re: [PATCH v2 24/25] drm/mediatek: respect page offset for PRIME mmap calls

2019-04-16 Thread CK Hu
Hi, Yongqiang: On Wed, 2019-03-27 at 14:19 +0800, yongqiang@mediatek.com wrote: > From: Yongqiang Niu > > Respect page offset for PRIME mmap calls Reviewed-by: CK Hu > > Signed-off-by: Yongqiang Niu > --- > drivers/gpu/drm/mediatek/mtk_drm_gem.c | 7 ++- > 1 file changed, 6 inserti

Re: [PATCH v2 08/12] drm/fb-helper: Move out commit code

2019-04-16 Thread Daniel Vetter
On Sun, Apr 07, 2019 at 06:52:39PM +0200, Noralf Trønnes wrote: > Move the modeset commit code to drm_client_modeset. > No changes except exporting API. > > v2: Move to drm_client_modeset.c instead of drm_client.c > > Signed-off-by: Noralf Trønnes > --- > drivers/gpu/drm/drm_client_modeset.c |

Re: [PATCH v2 00/12] drm/fb-helper: Move modesetting code to drm_client

2019-04-16 Thread Daniel Vetter
On Sun, Apr 07, 2019 at 06:52:31PM +0200, Noralf Trønnes wrote: > This moves the modesetting code from drm_fb_helper to drm_client so it > can be shared by all internal clients. > > The main change this time is to attach the modeset array to > drm_client_dev and honour the drm_fb_helper MIT licens

Re: [PATCH v2 00/12] drm/fb-helper: Move modesetting code to drm_client

2019-04-16 Thread Daniel Vetter
On Tue, Apr 16, 2019 at 10:41:06AM +0200, Daniel Vetter wrote: > On Sun, Apr 07, 2019 at 06:52:31PM +0200, Noralf Trønnes wrote: > > This moves the modesetting code from drm_fb_helper to drm_client so it > > can be shared by all internal clients. > > > > The main change this time is to attach the

Re: [Intel-gfx] [v3 6/7] drm: Add Client Cap for advance gamma mode

2019-04-16 Thread Lankhorst, Maarten
mån 2019-04-15 klockan 15:43 +0300 skrev Ville Syrjälä: > On Mon, Apr 15, 2019 at 10:57:52AM +, Lankhorst, Maarten wrote: > > fre 2019-04-12 klockan 15:51 +0530 skrev Uma Shankar: > > > Introduced a client cap for advance cap mode > > > capability. Userspace should set this to get > > > to be a

[PATCH 2/2] arm64: dts: mt8183: add pwm0 node

2019-04-16 Thread Jitao Shi
Add pwm0 node to the mt8183 Signed-off-by: Jitao Shi --- arch/arm64/boot/dts/mediatek/mt8183.dtsi | 11 +++ 1 file changed, 11 insertions(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi index 80929a0e5a6f..2830008c4921 100644 --- a/ar

[PATCH 1/2] arm64: dts: mt8183: add dsi node

2019-04-16 Thread Jitao Shi
Add dsi and mipitx nodes to the mt8183 Signed-off-by: Jitao Shi --- arch/arm64/boot/dts/mediatek/mt8183.dtsi | 25 1 file changed, 25 insertions(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi index b36e37fcdfe3..8092

[PATCH 0/2] add dsi and pwm0 nodes to mt8183 device tree

2019-04-16 Thread Jitao Shi
This patch is based on v5.1-rc1 and these patches: http://lists.infradead.org/pipermail/linux-mediatek/2019-March/017963.html https://patchwork.kernel.org/patch/10856987/ https://patchwork.kernel.org/cover/10879001/ https://patchwork.kernel.org/cover/10846677/ https://patchwork.kernel.org/patch/108

Re: [PATCH v4 05/13] drivers: create binary sysfs for class

2019-04-16 Thread Greg Kroah-Hartman
On Mon, Apr 15, 2019 at 09:14:12PM +0200, Daniel Vetter wrote: > On Mon, Apr 15, 2019 at 8:01 PM Greg Kroah-Hartman > wrote: > > On Mon, Apr 15, 2019 at 10:44:12PM +0530, Ramalingam C wrote: > > > On 2019-04-15 at 16:47:16 +0200, Greg Kroah-Hartman wrote: > > > > On Mon, Apr 15, 2019 at 06:11:13PM

[PATCH] drm: add drm_format_helper.c to kerneldoc

2019-04-16 Thread Gerd Hoffmann
Also drop the dstclip parameter sphinx has warned about (leftolver from an earlier patch version). Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/drm_format_helper.c | 1 - Documentation/gpu/drm-kms-helpers.rst | 6 ++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers

Re: [PATCH 0/6] Fix crash after reloading a driver using ttm

2019-04-16 Thread Karol Herbst
On Tue, Apr 16, 2019 at 8:38 AM Christian König wrote: > > Am 16.04.19 um 02:35 schrieb Karol Herbst: > > Kobjects are supposed to be dynamically allocated, but with recent changes > > this rule was violated. Reverting those commits fixes crashes when a drm > > driver using TTM gets loaded again.

Re: [PATCH v2 01/12] drm/atomic: Move __drm_atomic_helper_disable_plane/set_config()

2019-04-16 Thread Maxime Ripard
On Sun, Apr 07, 2019 at 06:52:32PM +0200, Noralf Trønnes wrote: > Prepare for moving drm_fb_helper modesetting code to drm_client. > drm_client will be linked to drm.ko, so move > __drm_atomic_helper_disable_plane() and __drm_atomic_helper_set_config() > out of drm_kms_helper.ko. > > While at it, f

Re: [PATCH 0/6] Fix crash after reloading a driver using ttm

2019-04-16 Thread Koenig, Christian
Am 16.04.19 um 11:10 schrieb Karol Herbst: > On Tue, Apr 16, 2019 at 8:38 AM Christian König > wrote: >> Am 16.04.19 um 02:35 schrieb Karol Herbst: >>> Kobjects are supposed to be dynamically allocated, but with recent changes >>> this rule was violated. Reverting those commits fixes crashes when

Re: [v2,1/2] drm: Add writeback_w,h properties

2019-04-16 Thread Liviu Dudau
On Tue, Apr 16, 2019 at 09:34:20AM +0200, Daniel Vetter wrote: > On Mon, Apr 15, 2019 at 10:20:45AM +0100, Liviu Dudau wrote: > > On Mon, Apr 15, 2019 at 08:59:30AM +0100, james qian wang (Arm Technology > > China) wrote: > > > On Fri, Apr 12, 2019 at 02:08:28PM +, Ben Davis wrote: > > > > Add

Re: [PATCH v4 05/13] drivers: create binary sysfs for class

2019-04-16 Thread Daniel Vetter
On Tue, Apr 16, 2019 at 11:04 AM Greg Kroah-Hartman wrote: > On Mon, Apr 15, 2019 at 09:14:12PM +0200, Daniel Vetter wrote: > > On Mon, Apr 15, 2019 at 8:01 PM Greg Kroah-Hartman > > wrote: > > > On Mon, Apr 15, 2019 at 10:44:12PM +0530, Ramalingam C wrote: > > > > On 2019-04-15 at 16:47:16 +0200

Re: [PATCH v2 02/12] drm/fb-helper: Avoid race with DRM userspace

2019-04-16 Thread Maxime Ripard
On Sun, Apr 07, 2019 at 06:52:33PM +0200, Noralf Trønnes wrote: > drm_fb_helper_is_bound() is used to check if DRM userspace is in control. > This is done by looking at the fb on the primary plane. By the time > fb-helper gets around to committing, it's possible that the facts have > changed. > > A

Re: [PATCH v2 04/12] drm/fb-helper: No need to cache rotation and sw_rotations

2019-04-16 Thread Maxime Ripard
On Sun, Apr 07, 2019 at 06:52:35PM +0200, Noralf Trønnes wrote: > Getting rotation info is cheap so we can do it on demand. > > This is done in preparation for the removal of struct drm_fb_helper_crtc. > > Cc: Hans de Goede > Signed-off-by: Noralf Trønnes > Acked-by: Daniel Vetter Reviewed-by:

Re: [PATCH v2 05/12] drm/fb-helper: Remove drm_fb_helper_crtc->{x, y, desired_mode}

2019-04-16 Thread Maxime Ripard
On Sun, Apr 07, 2019 at 06:52:36PM +0200, Noralf Trønnes wrote: > The values are already present in the modeset. > > This is done in preparation for the removal of struct drm_fb_helper_crtc. > > Signed-off-by: Noralf Trønnes > Reviewed-by: Daniel Vetter Reviewed-by: Maxime Ripard Maxime -- Ma

Re: [PATCH v2 09/12] drm/fb-helper: Remove drm_fb_helper_connector

2019-04-16 Thread Maxime Ripard
Hi, On Sun, Apr 07, 2019 at 06:52:40PM +0200, Noralf Trønnes wrote: > All drivers add all their connectors so there's no need to keep around an > array of available connectors. > > Rename functions which signature is changed since they will be moved to > drm_client in a later patch. > > Signed-off

Re: [PATCH v2 11/12] drm/fb-helper: Move out modeset config code

2019-04-16 Thread Maxime Ripard
On Sun, Apr 07, 2019 at 06:52:42PM +0200, Noralf Trønnes wrote: > No functional changes, just moving code as-is and fixing includes. > > Signed-off-by: Noralf Trønnes Reviewed-by: Maxime Ripard Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com signatu

Re: [PATCH v2 10/12] drm/fb-helper: Prepare to move out modeset config code

2019-04-16 Thread Maxime Ripard
On Sun, Apr 07, 2019 at 06:52:41PM +0200, Noralf Trønnes wrote: > This prepares the modeset code so it can be moved out as-is in the next > patch. > > Signed-off-by: Noralf Trønnes Reviewed-by: Maxime Ripard Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin

Re: [PATCH v3 1/5] drm/scheduler: rework job destruction

2019-04-16 Thread Christian König
Am 15.04.19 um 23:17 schrieb Eric Anholt: Andrey Grodzovsky writes: From: Christian König We now destroy finished jobs from the worker thread to make sure that we never destroy a job currently in timeout processing. By this we avoid holding lock around ring mirror list in drm_sched_stop whic

Re: [PATCH] drm: turn syncobj timeline support off by default

2019-04-16 Thread Lionel Landwerlin
On 15/04/2019 21:23, Dave Airlie wrote: On Tue, 16 Apr 2019 at 06:05, Lionel Landwerlin wrote: On 15/04/2019 20:52, Dave Airlie wrote: On Tue, 16 Apr 2019 at 05:48, Lionel Landwerlin wrote: Unfortunately userspace users of this API cannot be publicly disclosed yet so disable this stuff by de

Re: [v2,1/2] drm: Add writeback_w,h properties

2019-04-16 Thread Daniel Vetter
On Tue, Apr 16, 2019 at 11:17 AM Liviu Dudau wrote: > > On Tue, Apr 16, 2019 at 09:34:20AM +0200, Daniel Vetter wrote: > > On Mon, Apr 15, 2019 at 10:20:45AM +0100, Liviu Dudau wrote: > > > On Mon, Apr 15, 2019 at 08:59:30AM +0100, james qian wang (Arm Technology > > > China) wrote: > > > > On Fr

Re: [PATCH 00/15] Share TTM code among framebuffer drivers

2019-04-16 Thread Koenig, Christian
Am 15.04.19 um 21:17 schrieb Daniel Vetter: > On Mon, Apr 15, 2019 at 6:21 PM Thomas Zimmermann wrote: >> Hi >> >> Am 15.04.19 um 17:54 schrieb Daniel Vetter: >>> On Tue, Apr 09, 2019 at 09:50:40AM +0200, Thomas Zimmermann wrote: Hi Am 09.04.19 um 09:12 schrieb kra...@redhat.com: >>

Re: [PATCH] drm: turn syncobj timeline support off by default

2019-04-16 Thread Daniel Vetter
On Tue, Apr 16, 2019 at 11:51 AM Lionel Landwerlin wrote: > > On 15/04/2019 21:23, Dave Airlie wrote: > > On Tue, 16 Apr 2019 at 06:05, Lionel Landwerlin > > wrote: > >> On 15/04/2019 20:52, Dave Airlie wrote: > >>> On Tue, 16 Apr 2019 at 05:48, Lionel Landwerlin > >>> wrote: > Unfortunatel

[PATCH 1/2] drm/ttm: fix re-init of global structures

2019-04-16 Thread Christian König
When a driver unloads without unloading TTM we don't correctly clear the global structures leading to errors on re-init. Next step should probably be to remove the global structures and kobjs all together, but this is tricky since we need to maintain backward compatibility. Signed-off-by: Christi

[PATCH 2/2] drm/ttm: remove pointers to globals

2019-04-16 Thread Christian König
As the name says global memory and bo accounting is global. So it doesn't make to much sense having pointers to global structures all around the code. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_gart.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 2 +- drivers/gp

Re: [PATCH 0/6] Fix crash after reloading a driver using ttm

2019-04-16 Thread Karol Herbst
On Tue, Apr 16, 2019 at 11:12 AM Koenig, Christian wrote: > > Am 16.04.19 um 11:10 schrieb Karol Herbst: > > On Tue, Apr 16, 2019 at 8:38 AM Christian König > > wrote: > >> Am 16.04.19 um 02:35 schrieb Karol Herbst: > >>> Kobjects are supposed to be dynamically allocated, but with recent changes

Re: [PATCH 00/15] Share TTM code among framebuffer drivers

2019-04-16 Thread Daniel Vetter
On Tue, Apr 16, 2019 at 12:05 PM Koenig, Christian wrote: > > Am 15.04.19 um 21:17 schrieb Daniel Vetter: > > On Mon, Apr 15, 2019 at 6:21 PM Thomas Zimmermann > > wrote: > >> Hi > >> > >> Am 15.04.19 um 17:54 schrieb Daniel Vetter: > >>> On Tue, Apr 09, 2019 at 09:50:40AM +0200, Thomas Zimmerma

Re: [PATCH 0/6] Fix crash after reloading a driver using ttm

2019-04-16 Thread Koenig, Christian
Am 16.04.19 um 12:54 schrieb Karol Herbst: > On Tue, Apr 16, 2019 at 11:12 AM Koenig, Christian > wrote: >> Am 16.04.19 um 11:10 schrieb Karol Herbst: >>> On Tue, Apr 16, 2019 at 8:38 AM Christian König >>> wrote: Am 16.04.19 um 02:35 schrieb Karol Herbst: > Kobjects are supposed to be d

Re: [PATCH 00/15] Share TTM code among framebuffer drivers

2019-04-16 Thread Koenig, Christian
Am 16.04.19 um 13:03 schrieb Daniel Vetter: > On Tue, Apr 16, 2019 at 12:05 PM Koenig, Christian > wrote: >> Am 15.04.19 um 21:17 schrieb Daniel Vetter: >>> On Mon, Apr 15, 2019 at 6:21 PM Thomas Zimmermann >>> wrote: Hi Am 15.04.19 um 17:54 schrieb Daniel Vetter: > On Tue, Ap

Re: [PATCH 0/6] Fix crash after reloading a driver using ttm

2019-04-16 Thread Karol Herbst
On Tue, Apr 16, 2019 at 1:07 PM Koenig, Christian wrote: > > Am 16.04.19 um 12:54 schrieb Karol Herbst: > > On Tue, Apr 16, 2019 at 11:12 AM Koenig, Christian > > wrote: > >> Am 16.04.19 um 11:10 schrieb Karol Herbst: > >>> On Tue, Apr 16, 2019 at 8:38 AM Christian König > >>> wrote: > Am 1

Re: [PATCH -next] drm/meson: Make some functions static

2019-04-16 Thread Neil Armstrong
Le 13/04/2019 16:14, Yue Haibing a écrit : > From: YueHaibing > > Fix sparse warnings: > > drivers/gpu/drm/meson/meson_viu.c:93:6: warning: symbol > 'meson_viu_set_g12a_osd1_matrix' was not declared. Should it be static? > drivers/gpu/drm/meson/meson_viu.c:121:6: warning: symbol > 'meson_viu

Re: [PATCH 0/6] Fix crash after reloading a driver using ttm

2019-04-16 Thread Christian König
Am 16.04.19 um 13:20 schrieb Karol Herbst: On Tue, Apr 16, 2019 at 1:07 PM Koenig, Christian wrote: Am 16.04.19 um 12:54 schrieb Karol Herbst: On Tue, Apr 16, 2019 at 11:12 AM Koenig, Christian wrote: Am 16.04.19 um 11:10 schrieb Karol Herbst: On Tue, Apr 16, 2019 at 8:38 AM Christian König

Re: [PATCH 1/2] drm/ttm: fix re-init of global structures

2019-04-16 Thread Karol Herbst
On Tue, Apr 16, 2019 at 12:53 PM Christian König wrote: > > When a driver unloads without unloading TTM we don't correctly > clear the global structures leading to errors on re-init. > > Next step should probably be to remove the global structures and > kobjs all together, but this is tricky since

Re: [PATCH v2 18/25] drm/mediatek: add RDMA fifo size error handle

2019-04-16 Thread YT Shen
On Tue, 2019-04-16 at 16:37 +0800, Yongqiang Niu wrote: > On Tue, 2019-04-16 at 16:00 +0800, CK Hu wrote: > > Hi, Yongqiang: > > > > On Wed, 2019-03-27 at 14:19 +0800, yongqiang@mediatek.com wrote: > > > From: Yongqiang Niu > > > > > > This patch add RDMA fifo size error handle > > > rdma fi

[PATCH] drm/gma500/cdv: Check vbt config bits when detecting lvds panels

2019-04-16 Thread Patrik Jakobsson
Some machines have an lvds child device in vbt even though a panel is not attached. To make detection more reliable we now also check the lvds config bits available in the vbt. Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1665766 Signed-off-by: Patrik Jakobsson Cc: Hans de Goede Cc: Vil

[PATCH] drm/amdgpu: fix spelling mistake "gateing" -> "gating"

2019-04-16 Thread Colin King
From: Colin Ian King There is a spelling mistake in a DRM_INFO message. Fix it. Signed-off-by: Colin Ian King --- drivers/gpu/drm/amd/amdgpu/vce_v2_0.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/vce_v2_0.c b/drivers/gpu/drm/amd/amdgpu/vce_v2

Re: [PATCH 0/6] Fix crash after reloading a driver using ttm

2019-04-16 Thread Daniel Vetter
On Tue, Apr 16, 2019 at 11:06:54AM +, Koenig, Christian wrote: > Am 16.04.19 um 12:54 schrieb Karol Herbst: > > On Tue, Apr 16, 2019 at 11:12 AM Koenig, Christian > > wrote: > >> Am 16.04.19 um 11:10 schrieb Karol Herbst: > >>> On Tue, Apr 16, 2019 at 8:38 AM Christian König > >>> wrote: > >>

Re: [PATCH] drm: add drm_format_helper.c to kerneldoc

2019-04-16 Thread Daniel Vetter
On Tue, Apr 16, 2019 at 11:05:33AM +0200, Gerd Hoffmann wrote: > Also drop the dstclip parameter sphinx has warned about (leftolver from > an earlier patch version). > > Signed-off-by: Gerd Hoffmann Assuming it all builds cleanly and all the links work and no warnings from sphinx: Acked-by: Dan

Re: [PATCH 0/6] Fix crash after reloading a driver using ttm

2019-04-16 Thread Koenig, Christian
Am 16.04.19 um 14:18 schrieb Daniel Vetter: > On Tue, Apr 16, 2019 at 11:06:54AM +, Koenig, Christian wrote: >> Am 16.04.19 um 12:54 schrieb Karol Herbst: >>> On Tue, Apr 16, 2019 at 11:12 AM Koenig, Christian >>> wrote: Am 16.04.19 um 11:10 schrieb Karol Herbst: > On Tue, Apr 16, 201

[PATCH 2/2] drm: introduce a capability flag for syncobj timeline support

2019-04-16 Thread Lionel Landwerlin
Unfortunately userspace users of this API cannot be publicly disclosed yet. This commit effectively disables timeline syncobj ioctls for all drivers. Each driver wishing to support this feature will need to expose DRIVER_SYNCOBJ_TIMELINE. Signed-off-by: Lionel Landwerlin Cc: Dave Airlie Cc: Dan

[PATCH 1/2] drm: report consistent errors when checking syncobj capibility

2019-04-16 Thread Lionel Landwerlin
We've been somewhat inconsistent when adding the new ioctl and returned ENODEV instead of EOPNOTSUPPORTED upon failing the syncobj capibility. Signed-off-by: Lionel Landwerlin Fixes: ea569910cbab98 ("drm/syncobj: add transition iotcls between binary and timeline v2") Fixes: 01d6c357837918 ("drm/

Re: [PATCH 1/2] drm: report consistent errors when checking syncobj capibility

2019-04-16 Thread Christian König
Am 16.04.19 um 14:30 schrieb Lionel Landwerlin: We've been somewhat inconsistent when adding the new ioctl and returned ENODEV instead of EOPNOTSUPPORTED upon failing the syncobj capibility. Signed-off-by: Lionel Landwerlin Fixes: ea569910cbab98 ("drm/syncobj: add transition iotcls between bina

Re: [PATCH 1/2] drm: report consistent errors when checking syncobj capibility

2019-04-16 Thread Daniel Vetter
On Tue, Apr 16, 2019 at 02:40:37PM +0200, Christian König wrote: > Am 16.04.19 um 14:30 schrieb Lionel Landwerlin: > > We've been somewhat inconsistent when adding the new ioctl and > > returned ENODEV instead of EOPNOTSUPPORTED upon failing the syncobj > > capibility. > > > > Signed-off-by: Lione

Re: [v2,1/2] drm: Add writeback_w,h properties

2019-04-16 Thread Liviu Dudau
On Tue, Apr 16, 2019 at 11:55:34AM +0200, Daniel Vetter wrote: > On Tue, Apr 16, 2019 at 11:17 AM Liviu Dudau wrote: > > > > On Tue, Apr 16, 2019 at 09:34:20AM +0200, Daniel Vetter wrote: > > > On Mon, Apr 15, 2019 at 10:20:45AM +0100, Liviu Dudau wrote: > > > > On Mon, Apr 15, 2019 at 08:59:30AM

Re: [PATCH 1/2] drm: report consistent errors when checking syncobj capibility

2019-04-16 Thread Lionel Landwerlin
On 16/04/2019 13:40, Christian König wrote: Am 16.04.19 um 14:30 schrieb Lionel Landwerlin: We've been somewhat inconsistent when adding the new ioctl and returned ENODEV instead of EOPNOTSUPPORTED upon failing the syncobj capibility. Signed-off-by: Lionel Landwerlin Fixes: ea569910cbab98 ("dr

Re: [PATCH 1/2] drm: report consistent errors when checking syncobj capibility

2019-04-16 Thread Koenig, Christian
Am 16.04.19 um 14:43 schrieb Daniel Vetter: > On Tue, Apr 16, 2019 at 02:40:37PM +0200, Christian König wrote: >> Am 16.04.19 um 14:30 schrieb Lionel Landwerlin: >>> We've been somewhat inconsistent when adding the new ioctl and >>> returned ENODEV instead of EOPNOTSUPPORTED upon failing the syncob

  1   2   >