Re: [PATCH v12 24/38] misc/mei/hdcp: Initiate Wired HDCP2.2 Tx Session

2019-02-10 Thread C, Ramalingam
On 2/9/2019 9:39 PM, Winkler, Tomas wrote: Request ME FW to start the HDCP2.2 session for an intel port. Prepares payloads for command WIRED_INITIATE_HDCP2_SESSION and sends to ME FW. On Success, ME FW will start a HDCP2.2 session for the port and provides the content for HDCP2.2 AKE_Init mess

RE: [PATCH v12 24/38] misc/mei/hdcp: Initiate Wired HDCP2.2 Tx Session

2019-02-10 Thread Winkler, Tomas
> > On 2/9/2019 9:39 PM, Winkler, Tomas wrote: > >> Request ME FW to start the HDCP2.2 session for an intel port. > >> Prepares payloads for command WIRED_INITIATE_HDCP2_SESSION and > sends > >> to ME FW. > >> > >> On Success, ME FW will start a HDCP2.2 session for the port and > >> provides the c

Re: [PATCH v12 24/38] misc/mei/hdcp: Initiate Wired HDCP2.2 Tx Session

2019-02-10 Thread C, Ramalingam
On 2/10/2019 1:55 PM, Winkler, Tomas wrote: On 2/9/2019 9:39 PM, Winkler, Tomas wrote: Request ME FW to start the HDCP2.2 session for an intel port. Prepares payloads for command WIRED_INITIATE_HDCP2_SESSION and sends to ME FW. On Success, ME FW will start a HDCP2.2 session for the port and

[PATCH] drm/amd/display: Fix reference counting for struct dc_sink.

2019-02-10 Thread Mathias . Froehlich
From: Mathias Fröhlich Reference counting in amdgpu_dm_connector for amdgpu_dm_connector::dc_sink and amdgpu_dm_connector::dc_em_sink as well as in dc_link::local_sink seems to be out of shape. Thus make reference counting consistent for these members and just plain increment the reference count

Re: [PATCH V2] drm/vkms: Fix license inconsistent

2019-02-10 Thread Rodrigo Siqueira
On 02/06, Daniel Vetter wrote: > On Wed, Feb 06, 2019 at 12:01:16PM -0200, Rodrigo Siqueira wrote: > > Fixes license inconsistent related to the VKMS driver and remove the > > redundant boilerplate comment. > > > > Fixes: 854502fa0a38 ("drm/vkms: Add basic CRTC initialization") > > > > Cc: sta...

Re: [PATCH] drm/vkms: WARN when hrtimer_forward_now fails

2019-02-10 Thread Rodrigo Siqueira
On 02/06, Shayenne Moura wrote: > Make the variable have the same type of function hrtimer_forward_now > return. Hi, First of all, thanks for your patch. Applied to the drm-misc-misc branch of drm-misc.git. P.s.: I made a tiny change in the commit message. Best Regards > Add a warn to verify

[PATCH v2 06/12] drm/tinydrm: Remove tinydrm_shutdown()

2019-02-10 Thread Noralf Trønnes
It's just a wrapper around drm_atomic_helper_shutdown() now. Also store drm_device in the drvdata field, since that's what's used. Signed-off-by: Noralf Trønnes Reviewed-by: Sam Ravnborg --- drivers/gpu/drm/tinydrm/core/tinydrm-core.c | 14 -- drivers/gpu/drm/tinydrm/hx8357d.c

[PATCH v2 01/12] drm/drv: Hold ref on parent device during drm_device lifetime

2019-02-10 Thread Noralf Trønnes
This makes it safe to access drm_device->dev after the parent device has been removed/unplugged. Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/drm_drv.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c index b049821

[PATCH v2 07/12] drm/tinydrm/mipi-dbi: Add drm_to_mipi_dbi()

2019-02-10 Thread Noralf Trønnes
Add a function to derive mipi_dbi from drm_device now that tinydrm_device is going away. Signed-off-by: Noralf Trønnes Reviewed-by: Sam Ravnborg --- drivers/gpu/drm/tinydrm/hx8357d.c | 3 +-- drivers/gpu/drm/tinydrm/ili9225.c | 11 --- drivers/gpu/drm/tinydrm/ili9341.c | 3 +-- dri

[PATCH v2 00/12] drm/tinydrm: Remove tinydrm_device

2019-02-10 Thread Noralf Trønnes
This patchset is part of the effort to remove tinydrm.ko. It removes struct tinydrm_device and tinydrm.h. Main changes in this version: Take a ref on the parent device for the drm_device lifetime. Drop devm_drm_dev_register() and add driver remove callbacks. The reason is that drm_atomic_helper_

[PATCH v2 08/12] drm/tinydrm/repaper: Drop using tinydrm_device

2019-02-10 Thread Noralf Trønnes
Use devm_drm_dev_init() and drop using tinydrm_device. v2: devm_drm_dev_register() was dropped so add a driver release callback. Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/tinydrm/repaper.c | 84 ++- 1 file changed, 61 insertions(+), 23 deletions(-) diff --gi

[PATCH v2 03/12] drm/drv: DOC: Add driver example code

2019-02-10 Thread Noralf Trønnes
Add driver example that shows how devm_drm_dev_init() can be used. Signed-off-by: Noralf Trønnes --- I'm not sure how detailed such an example such be and a description of some kind is also required. Help is needed :-) Noralf. drivers/gpu/drm/drm_drv.c | 118 +

[PATCH v2 04/12] drm/modes: Add DRM_SIMPLE_MODE()

2019-02-10 Thread Noralf Trønnes
This adds a helper macro to specify modes that only contain info about resolution. v2: Actually set the width and height (Ilia Mirkin) Cc: Ilia Mirkin Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/tinydrm/hx8357d.c | 2 +- drivers/gpu/drm/tinydrm/ili9225.c | 2 +- drivers/gpu/drm/tinyd

[PATCH v2 02/12] drm: Add devm_drm_dev_init()

2019-02-10 Thread Noralf Trønnes
This adds a resource managed (devres) version of drm_dev_init(). v2: Remove devm_drm_dev_register() since we can't touch hw in devm release functions and drivers want to disable hw on driver module unload (Daniel Vetter, Greg KH) Cc: Daniel Vetter Cc: Greg KH Signed-off-by: Noralf Trønn

[PATCH v2 09/12] drm/tinydrm: Drop using tinydrm_device

2019-02-10 Thread Noralf Trønnes
Use devm_drm_dev_init() and drop using tinydrm_device. v2: devm_drm_dev_register() was dropped so add driver release callbacks. Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/tinydrm/hx8357d.c | 40 +-- drivers/gpu/drm/tinydrm/ili9225.c | 40 +-- drivers/gpu/drm/tinydrm/i

[PATCH v2 05/12] drm/tinydrm: tinydrm_display_pipe_init() don't use tinydrm_device

2019-02-10 Thread Noralf Trønnes
Rework function signature so tinydrm_device can be avoided. Move definition to tinydrm-helpers.h so tinydrm.h can be deleted in a later patch. Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/tinydrm/core/tinydrm-pipe.c | 24 ++--- drivers/gpu/drm/tinydrm/mipi-dbi.c |

[PATCH v2 10/12] drm/tinydrm: Remove tinydrm_device

2019-02-10 Thread Noralf Trønnes
No more users left so it can go alongside its helpers. Update the tinydrm docs description and remove todo entry. Signed-off-by: Noralf Trønnes Reviewed-by: Sam Ravnborg Acked-by: Daniel Vetter --- Documentation/gpu/tinydrm.rst | 32 ++-- Documentation/gpu/todo.rst

[PATCH v2 12/12] drm/fb-helper: generic: Don't take module ref for fbcon

2019-02-10 Thread Noralf Trønnes
It's now safe to let fbcon unbind automatically on fbdev unregister. The crash problem was fixed in commit 2122b40580dd ("fbdev: fbcon: Fix unregister crash when more than one framebuffer") Signed-off-by: Noralf Trønnes Reviewed-by: Daniel Vetter --- drivers/gpu/drm/drm_fb_helper.c | 6 --

[PATCH v2 11/12] drm/tinydrm: Use drm_dev_enter/exit()

2019-02-10 Thread Noralf Trønnes
This protects device resources from use after device removal. There are 3 ways for driver-device unbinding to happen: - The driver module is unloaded causing the driver to be unregistered. This can't happen as long as there are open file handles because a reference is taken on the module. - Th

[Bug 109539] System freezing

2019-02-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109539 --- Comment #7 from jon --- >Do you still see the issue occur when amdgpu.dc=1 if you disable DP1.2 >support in your monitor's OSD? I will let you know. After 7+ days of uptime without a single crash with amdgpu.dc=0 I updated from kernel 4.2

[Bug 109466] Frozen display with Radeon RX 580 and Open Source Drivers under GNU/Linux Debian Sid

2019-02-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109466 --- Comment #5 from Yann Kervran --- Hello, I have made a system upgrade today and it seems that it doesn’t freeze my whole system anymore. Anyway, I have -- You are receiving this mail because: You are the assignee for the bug.___

[Bug 109466] Frozen display with Radeon RX 580 and Open Source Drivers under GNU/Linux Debian Sid

2019-02-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109466 --- Comment #6 from Yann Kervran --- Anyway, I have strange visual artifacts in a game (Planet Nomads) and when I launch Blender 2.80, it finally freeze. But just Blender. Here is my corresponding dmesg : [ 7448.526101] amdgpu :02:00.0: GPU

[Bug 109550] [regression][amd tahiti xt][vm fault] Rise of the Tomb Raider hangs the system

2019-02-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109550 --- Comment #4 from Sylvain BERTRAND --- linux(amd-staging-drm-next), drm, llvm, mesa (gl and vulkan), xserver, xf86-video-amdgpu from today git, still broken -- You are receiving this mail because: You are the assignee for the bug.___

RE: [PATCH v12 24/38] misc/mei/hdcp: Initiate Wired HDCP2.2 Tx Session

2019-02-10 Thread Winkler, Tomas
> > > > On 2/10/2019 1:55 PM, Winkler, Tomas wrote: > >> On 2/9/2019 9:39 PM, Winkler, Tomas wrote: > Request ME FW to start the HDCP2.2 session for an intel port. > Prepares payloads for command WIRED_INITIATE_HDCP2_SESSION and > >> sends > to ME FW. > > On Success, M

[Bug 109466] Frozen display with Radeon RX 580 and Open Source Drivers under GNU/Linux Debian Sid

2019-02-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109466 --- Comment #7 from Yann Kervran --- OK, the situation has changed, but not so much. The display still completely freeze after a while if I use 3D. It just takes longer. I enclose a new_full_dmesg with all the details. I have used Blender, then

[Bug 109466] Frozen display with Radeon RX 580 and Open Source Drivers under GNU/Linux Debian Sid

2019-02-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109466 --- Comment #8 from Yann Kervran --- Created attachment 143356 --> https://bugs.freedesktop.org/attachment.cgi?id=143356&action=edit New full dmesg with new drivers 10/02/2018 -- You are receiving this mail because: You are the assignee for

Re: [PATCH v2 03/12] drm/drv: DOC: Add driver example code

2019-02-10 Thread Sam Ravnborg
Hi Noralf On Sun, Feb 10, 2019 at 02:10:30PM +0100, Noralf Trønnes wrote: > Add driver example that shows how devm_drm_dev_init() can be used. > > Signed-off-by: Noralf Trønnes Always good with examples! > --- > > I'm not sure how detailed such an example such be and a description of > some

Re: [PATCH v2 04/12] drm/modes: Add DRM_SIMPLE_MODE()

2019-02-10 Thread Sam Ravnborg
On Sun, Feb 10, 2019 at 02:10:31PM +0100, Noralf Trønnes wrote: > This adds a helper macro to specify modes that only contain info about > resolution. > > v2: Actually set the width and height (Ilia Mirkin) > > Cc: Ilia Mirkin > Signed-off-by: Noralf Trønnes Reviewed-by: Sam Ravnborg _

Re: [PATCH v2 05/12] drm/tinydrm: tinydrm_display_pipe_init() don't use tinydrm_device

2019-02-10 Thread Sam Ravnborg
On Sun, Feb 10, 2019 at 02:10:32PM +0100, Noralf Trønnes wrote: > Rework function signature so tinydrm_device can be avoided. > > Move definition to tinydrm-helpers.h so tinydrm.h can be deleted in a > later patch. > > Signed-off-by: Noralf Trønnes Reviewed-by: Sam Ravnborg

Re: [PATCH v2 08/12] drm/tinydrm/repaper: Drop using tinydrm_device

2019-02-10 Thread Sam Ravnborg
Hi Noralf. One detail below. When addressed you can add my: Reviewed-by: Sam Ravnborg Sam On Sun, Feb 10, 2019 at 02:10:35PM +0100, Noralf Trønnes wrote: > Use devm_drm_dev_init() and drop using tinydrm_device. > > v2: devm_drm_dev_register() was dropped so add a driver release callbac

Re: [PATCH v2 09/12] drm/tinydrm: Drop using tinydrm_device

2019-02-10 Thread Sam Ravnborg
Hi Noralf. On Sun, Feb 10, 2019 at 02:10:36PM +0100, Noralf Trønnes wrote: > Use devm_drm_dev_init() and drop using tinydrm_device. > > v2: devm_drm_dev_register() was dropped so add driver release callbacks. > > Signed-off-by: Noralf Trønnes > --- > drivers/gpu/drm/tinydrm/hx8357d.c | 40 ++

Re: [PATCH v1 1/1] drm/komeda: fix build with drm_modeset_helper.h update

2019-02-10 Thread Stephen Rothwell
Hi Sam, On Fri, 8 Feb 2019 23:13:24 +0100 Sam Ravnborg wrote: > > With drmP.h removed from drm_modeset_helper.h the build of > komeda filed as reported by linux-next > > Add missing include files to fix build. > For the files touched group include files and sort them. > > The fix was tested on

[PATCHv11 1/3] ARM:dt-bindings:display Intel FPGA Video and Image Processing Suite

2019-02-10 Thread Hean-Loong, Ong
From: Ong, Hean Loong Device tree binding for Intel FPGA Video and Image Processing Suite. The binding involved would be generated from the Altera (Intel) Qsys system. The bindings would set the max width, max height, buts per pixel and memory port width. The device tree binding only supports

[PATCHv11 2/3] ARM:socfpga-defconfig Intel FPGA Video and Image Processing Suite

2019-02-10 Thread Hean-Loong, Ong
From: Ong Hean Loong Intel FPGA Video and Image Processing Suite Frame Buffer II driver config for Arria 10 devkit and its variants Signed-off-by: Ong, Hean Loong --- arch/arm/configs/socfpga_defconfig |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/arch/arm/config

[PATCHv11 0/3] Intel FPGA Video and Image Processing Suite

2019-02-10 Thread Hean-Loong, Ong
From: Ong, Hean Loong The FPGA FrameBuffer Soft IP could be seen as the GPU and the DRM driver patch here is allocating memory for information to be streamed from the ARM/Linux to the display port. Basically the driver just wraps the information such as the pixels to be drawn by the FPGA Fr

[PATCHv11 3/3] ARM:drm ivip Intel FPGA Video and Image Processing Suite

2019-02-10 Thread Hean-Loong, Ong
From: Ong, Hean Loong Signed-off-by: Ong, Hean Loong --- drivers/gpu/drm/ivip/Kconfig | 14 +++ drivers/gpu/drm/ivip/Makefile |7 ++ drivers/gpu/drm/ivip/intel_vip_conn.c | 91 drivers/gpu/drm/ivip/intel_vip_core.c | 189 +++

[PATCH 2/3] drm: Add basic helper to allow precise pageflip timestamps in vrr.

2019-02-10 Thread Mario Kleiner
The pageflip completion timestamps transmitted to userspace via pageflip completion events are supposed to describe the time at which the first pixel of the new post-pageflip scanout buffer leaves the video output of the gpu. This time is identical to end of vblank, when active scanout starts. For

Some VRR vblank/pageflip timestamping fixes.

2019-02-10 Thread Mario Kleiner
These fix the currently broken vblank timestamping in VRR mode and broken pageflip timestamping in VRR mode. The unfixed implementation can provide timestamps that are off by dozens of milliseconds and thereby make VRR unusable for any application that needs at least millisecond precision in timing

[PATCH 3/3] drm/amd/display: Provide more accurate pageflip timestamps in vrr mode.

2019-02-10 Thread Mario Kleiner
This implements more accurate pageflip completion timestamps for crtc's running in variable refresh rate mode. In vrr mode, the pageflip completion interrupt handler takes a ktime_get() timestamp of pageflip completion as a at least roughly correct lower estimate of when the vblank of flip complet

[PATCH 1/3] drm/amdgpu: Fix get_crtc_scanoutpos behavior in vrr when vpos >= vtotal.

2019-02-10 Thread Mario Kleiner
This reverts commit 520f08df45fbe300ed650da786a74093d658b7e1 ("drm/amdgpu: Correct get_crtc_scanoutpos behavior when vpos >= vtotal") While the explanation in that commit is correct wrt. the hardware counter sometimes returning a position >= vtotal in vrr mode if the query happens while we are ins

[PATCH] drm/mediatek: add mt8183 dpi support

2019-02-10 Thread Jitao Shi
MT8183 sample on rising and falling edge. It can reduce half data io. Signed-off-by: Jitao Shi --- drivers/gpu/drm/mediatek/mtk_dpi.c | 29 + 1 file changed, 29 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c b/drivers/gpu/drm/mediatek/mtk_dpi.c index

[PATCH v13 24/38] misc/mei/hdcp: Initiate Wired HDCP2.2 Tx Session

2019-02-10 Thread Ramalingam C
Request ME FW to start the HDCP2.2 session for an intel port. Prepares payloads for command WIRED_INITIATE_HDCP2_SESSION and sends to ME FW. On Success, ME FW will start a HDCP2.2 session for the port and provides the content for HDCP2.2 AKE_Init message. v2: Rebased. v3: cldev is add as a sepa

[Bug 108340] Ambient Occlusion in Two Point Hospital shows black spot artifacts

2019-02-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108340 --- Comment #4 from Thomas R. --- Parkitect has the same issue, it seems to be a general Unity thing. -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailing li

[PATCHv12 1/3] ARM:dt-bindings:display Intel FPGA Video and Image Processing Suite

2019-02-10 Thread Hean-Loong, Ong
From: Ong, Hean Loong Device tree binding for Intel FPGA Video and Image Processing Suite. The bindings would set the max width, max height, bits per pixel and memory port width. The device tree binding only supports the Intel Arria10 devkit and its variants. Vendor name retained as altr. V12

[PATCHv12 0/3] Intel FPGA Video and Image Processing Suite

2019-02-10 Thread Hean-Loong, Ong
From: Ong, Hean Loong The FPGA FrameBuffer Soft IP could be seen as the GPU and the DRM driver patch here is allocating memory for information to be streamed from the ARM/Linux to the display port. Basically the driver just wraps the information such as the pixels to be drawn by the Sodt

[PATCHv12 2/3] ARM:socfpga-defconfig Intel FPGA Video and Image Processing Suite

2019-02-10 Thread Hean-Loong, Ong
From: Ong Hean Loong Intel FPGA Video and Image Processing Suite Frame Buffer II driver config for Arria 10 devkit and its variants Signed-off-by: Ong, Hean Loong --- arch/arm/configs/socfpga_defconfig |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/arch/arm/config

[PATCHv12 3/3] ARM:drm ivip Intel FPGA Video and Image Processing Suite

2019-02-10 Thread Hean-Loong, Ong
From: Ong, Hean Loong Signed-off-by: Ong, Hean Loong --- drivers/gpu/drm/Kconfig |2 + drivers/gpu/drm/Makefile |1 + drivers/gpu/drm/ivip/Kconfig | 14 +++ drivers/gpu/drm/ivip/Makefile |7 ++ drivers/gpu/drm/ivip/intel_vip_conn.c | 9

Re: [PATCHv12 3/3] ARM:drm ivip Intel FPGA Video and Image Processing Suite

2019-02-10 Thread Sam Ravnborg
Hi Hean-Loong, Ong Patch looks good to me, but there is a few trivial things I spotted while browsing the code. See below. Sam > +++ b/drivers/gpu/drm/ivip/Makefile > @@ -0,0 +1,7 @@ > +# > +# Makefile for the drm device driver. This driver provides support for the > +# Direct Rendering

Re: [PATCH 0/6] omapdrm: drm_bridge and drm_panel support

2019-02-10 Thread Laurent Pinchart
Hi Sebastian, On Sat, Feb 09, 2019 at 01:05:14PM +0100, Sebastian Reichel wrote: > On Fri, Jan 11, 2019 at 03:34:19AM +0200, Laurent Pinchart wrote: > > On Thursday, 20 December 2018 14:17:27 EET Sebastian Reichel wrote: > >> On Mon, Dec 10, 2018 at 03:06:17AM +0200, Laurent Pinchart wrote: > >>>

[PATCH v2.1 45/49] drm/omap: Add support for drm_bridge

2019-02-10 Thread Laurent Pinchart
Hook up drm_bridge support in the omapdrm driver. Despite the recent extensive preparation work, this is a rather intrusive change, as the management of outputs needs to be adapted through the driver to handle both omap_dss_device and drm_bridge. Connector creation is skipped when using a drm_brid