fix DMA ops layering violations in vmwgfx

Hi Thomas, vmwgfx has been doing some odd checks based on DMA ops which rely on deep DMA mapping layer internals, and I think the changes in Linux 4.21 finally broke most of these implicit assumptions. The real fix is in patch 3, but I think the others are important to make it clear what is actua

[PATCH 3/4] drm/vmwgfx: fix the check when to use dma_alloc_coherent

Since Linux 4.21 we merged the swiotlb ops into the DMA direct ops, so they would always have a the sync_single methods. But late in the cicle we also removed the direct ops entirely, so we'd see NULL DMA ops. Switch vmw_dma_select_mode to only detect swiotlb presence using swiotlb_nr_tbl() inste

[PATCH 4/4] drm/vmwgfx: unwind spaghetti code in vmw_dma_select_mode

Just use a simple if/else chain to select the DMA mode. Signed-off-by: Christoph Hellwig --- drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 25 ++--- 1 file changed, 6 insertions(+), 19 deletions(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c b/drivers/gpu/drm/vmwgfx/vmwgfx_drv

[PATCH 1/4] drm/vmwgfx: remove CONFIG_X86 ifdefs

The driver depends on CONFIG_X86 so these are dead code. Signed-off-by: Christoph Hellwig --- drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c index 25afb1d594e3..69e325b2d954 1

[PATCH 2/4] drm/vmwgfx: remove CONFIG_INTEL_IOMMU ifdefs

intel_iommu_enabled is defined as always false for !CONFIG_INTEL_IOMMU, so remove the ifdefs around it. Signed-off-by: Christoph Hellwig --- drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 18 -- 1 file changed, 18 deletions(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c b/drivers/g

[PATCH v6 03/11] vga-switcheroo: make PCI dependency explicit

This driver depends on the PCI infrastructure but the dependency has not been explicitly called out. Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set") Signed-off-by: Sinan Kaya Reviewed-by: Lukas Wunner Acked-by: Daniel Vetter --- drivers/gpu/vga/Kconfig | 1 + 1

[Bug 109229] glLinkProgram locks up for ~30 seconds

https://bugs.freedesktop.org/show_bug.cgi?id=109229 Bug ID: 109229 Summary: glLinkProgram locks up for ~30 seconds Product: Mesa Version: 18.3 Hardware: Other OS: All Status: NEW Severity: normal

[Bug 108781] 4.19 Regression - Hawaii (R9 390) boot failure - Invalid PCC GPIO / invalid powerlevel state / Fatal error during GPU init

https://bugs.freedesktop.org/show_bug.cgi?id=108781 --- Comment #38 from danglingpointerexcept...@gmail.com --- (In reply to Alex Deucher from comment #37) > (In reply to DanglingPointerException from comment #36) > > [drm:gmc_v7_0_sw_init [amdgpu]] *ERROR* Failed to load mc firmware! > > [drm:amd

[Bug 201539] AMDGPU R9 390 automatic fan speed control in Linux 4.19/4.20

https://bugzilla.kernel.org/show_bug.cgi?id=201539 --- Comment #11 from danglingpointerexcept...@gmail.com (danglingpointerexcept...@gmail.com) --- I found a solution for my problem and detailed it in the previous link. My R9-290X now fully functions on 4.20.0 -- You are receiving this mail bec

[Bug 109001] Freezes when waking up after screen goes blank.

https://bugs.freedesktop.org/show_bug.cgi?id=109001 --- Comment #14 from Alex Deucher --- (In reply to Matt Garman from comment #13) > If I set amdgpu.dc=0 on my Ryzen 5 2400g, the system hard-locks as soon as X > starts (i.e. hard reset via physical power button required). There is no non-DC co

[Bug 107668] Blank screen (Cannot find any crtc or sizes) since Kernel 4.17 (AMDGPU.DC) on Amd Radeon RX460 on HDMI LG Ultrawidescreen Monitor

https://bugs.freedesktop.org/show_bug.cgi?id=107668 --- Comment #4 from Naheem Zaffar --- Created attachment 142982 --> https://bugs.freedesktop.org/attachment.cgi?id=142982&action=edit Dmesg outut with latest build from Kernel 4.21 pre-release series The same error occurs with kernel 4.21 aft

[PATCH] drm/fb-helper: generic: Fix setup error path

If register_framebuffer() fails during fbdev setup we will leak the framebuffer, the GEM buffer and the shadow buffer for defio. This is because drm_fb_helper_fbdev_setup() just calls drm_fb_helper_fini() on error not taking into account that register_framebuffer() can fail. Since the generic emul

Re: [PATCH] drm/fb-helper: fix leaks in error path of drm_fb_helper_fbdev_setup

Den 24.12.2018 16.03, skrev Peter Wu: On Mon, Dec 24, 2018 at 03:52:55PM +0100, Noralf Trønnes wrote: Den 24.12.2018 00.10, skrev Peter Wu: On Sun, Dec 23, 2018 at 02:55:52PM +0100, Noralf Trønnes wrote: Den 23.12.2018 01.55, skrev Peter Wu: After drm_fb_helper_fbdev_setup calls drm_fb_

[Bug 201273] Fatal error during GPU init amdgpu RX560

https://bugzilla.kernel.org/show_bug.cgi?id=201273 --- Comment #28 from quirin.blae...@freenet.de --- Bug is still alive. amd-staging-drm-next d004289b58fe5ddc71c86411c53f52db2327b3fb Firmware: 0f22c8527439eaaf5c3fcf87b31c89445b6fa84d git://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-f

Re: [GIT PULL] fbdev changes for v4.21

The pull request you sent on Fri, 4 Jan 2019 13:09:05 +0100: > https://github.com/bzolnier/linux.git tags/fbdev-v4.21 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/a8a6b1186b1a209647483c2ff81e0d59c43dbdd3 Thank you! -- Deet-doot-dot, I am a bot. https://korg.wiki.k

Re: [git pull] drm next fixes for rc1

The pull request you sent on Sat, 5 Jan 2019 05:10:22 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-next-2019-01-05 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/0fe4e2d5cd931ad2ff99d61cfdd5c6dc0c3ec60b Thank you! -- Deet-doot-dot, I am a bot. https://kor