Re: [Intel-gfx] [PATCH 2/2] drm/i915: Validate userspace-provided color management LUT's

2018-12-12 Thread kbuild test robot
-ci/linux/commits/Matt-Roper/drm-Add-color-management-LUT-validation-helpers/20181212-130519 base: git://anongit.freedesktop.org/drm-intel for-linux-next config: i386-randconfig-x011-201849 (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the attached .config

Re: [PATCH] drm/amd/display: Pass app_tf by value rather than by reference

2018-12-12 Thread Nathan Chancellor
On Tue, Dec 11, 2018 at 01:25:00PM -0800, Nick Desaulniers wrote: > On Mon, Dec 10, 2018 at 3:42 PM Nathan Chancellor > wrote: > > > > Clang warns when an expression that equals zero is used as a null > > pointer constant (in lieu of NULL): > > > > drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/a

Re: [PATCH 3/5] clk: meson: meson8b: add the GPU clock tree

2018-12-12 Thread Martin Blumenstingl
Hi Neil, On Tue, Dec 11, 2018 at 10:21 AM Neil Armstrong wrote: > > On 08/12/2018 18:12, Martin Blumenstingl wrote: > > Add the GPU clock tree on Meson8, Meson8b and Meson8m2. > > > > The GPU clock tree on Meson8b and Meson8m2 is almost identical to the > > one one GXBB: > > - there's a glitch-fr

Re: [PATCH] drm/amd/display: Pass app_tf by value rather than by reference

2018-12-12 Thread Nick Desaulniers
On Mon, Dec 10, 2018 at 3:42 PM Nathan Chancellor wrote: > > Clang warns when an expression that equals zero is used as a null > pointer constant (in lieu of NULL): > > drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:4435:3: > warning: expression which evaluates to zero treated as a nu

Re: [PATCH] drm/amd/display: Pass app_tf by value rather than by reference

2018-12-12 Thread Nick Desaulniers
On Tue, Dec 11, 2018 at 1:42 PM Nathan Chancellor wrote: > > On Tue, Dec 11, 2018 at 01:25:00PM -0800, Nick Desaulniers wrote: > > On Mon, Dec 10, 2018 at 3:42 PM Nathan Chancellor > > wrote: > > > > > > Clang warns when an expression that equals zero is used as a null > > > pointer constant (in

Re: [PATCH] drm/amd/display: Pass app_tf by value rather than by reference

2018-12-12 Thread Nathan Chancellor
On Tue, Dec 11, 2018 at 02:07:31PM -0800, Nick Desaulniers wrote: > On Tue, Dec 11, 2018 at 1:42 PM Nathan Chancellor > wrote: > > > > On Tue, Dec 11, 2018 at 01:25:00PM -0800, Nick Desaulniers wrote: > > > On Mon, Dec 10, 2018 at 3:42 PM Nathan Chancellor > > > wrote: > > > > > > > > Clang warns

Re: [PATCH 0/3] drm/exynos: add support for dynamic zpos in DECON and FIMD

2018-12-12 Thread Andrzej Hajda
On 12.12.2018 00:48, Inki Dae wrote: > > 18. 12. 11. 오후 10:20에 Andrzej Hajda 이(가) 쓴 글: >> Hi again, >> >> It seems I have missed two questions: >> >> On 11.12.2018 09:36, Andrzej Hajda wrote: >>> On 11.12.2018 09:01, Inki Dae wrote: 18. 12. 11. 오후 4:49에 Andrzej Hajda 이(가) 쓴 글: > On 11.12.2

[drm-intel:for-linux-next-fixes 5/5] drivers/gpu//drm/i915/intel_ringbuffer.c:89:11: error: implicit declaration of function 'i915_scratch_offset'; did you mean 'i915_ggtt_offset'?

2018-12-12 Thread kbuild test robot
tree: git://anongit.freedesktop.org/drm-intel for-linux-next-fixes head: eeb139ca4b24d515265ad75f668333431896b1aa commit: eeb139ca4b24d515265ad75f668333431896b1aa [5/5] drm/i915: Flush GPU relocs harder for gen3 config: i386-randconfig-x073-201849 (attached as .config) compiler: gcc-7 (Debian

[Bug 109033] Dell Computer customer support

2018-12-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109033 Bug ID: 109033 Summary: Dell Computer customer support Product: Mesa Version: 18.3 Hardware: Other OS: All Status: NEW Severity: normal Priorit

[Bug 109033] Dell Computer customer support

2018-12-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109033 Chris Evans changed: What|Removed |Added Keywords||bisect_pending URL|

Re: [PATCH 0/3] drm/exynos: add support for dynamic zpos in DECON and FIMD

2018-12-12 Thread Andrzej Hajda
On 12.12.2018 00:26, Inki Dae wrote: > > 18. 12. 11. 오후 5:36에 Andrzej Hajda 이(가) 쓴 글: >> On 11.12.2018 09:01, Inki Dae wrote: >>> 18. 12. 11. 오후 4:49에 Andrzej Hajda 이(가) 쓴 글: On 11.12.2018 00:45, Inki Dae wrote: > Hi Andrzej, > > 18. 12. 10. 오후 4:35에 Andrzej Hajda 이(가) 쓴 글: >>

Re: [PATCH v8 05/35] drm/i915: MEI interface definition

2018-12-12 Thread C, Ramalingam
On 12/7/2018 7:59 PM, Daniel Vetter wrote: On Fri, Dec 07, 2018 at 11:22:44AM +0530, C, Ramalingam wrote: On 12/6/2018 3:53 PM, Daniel Vetter wrote: On Tue, Nov 27, 2018 at 04:13:03PM +0530, Ramalingam C wrote: Defining the mei-i915 interface functions and initialization of the interface. Si

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Validate userspace-provided color management LUT's

2018-12-12 Thread kbuild test robot
://github.com/0day-ci/linux/commits/Matt-Roper/drm-Add-color-management-LUT-validation-helpers/20181212-130519 base: git://anongit.freedesktop.org/drm-intel for-linux-next config: i386-randconfig-x006-201849 (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the attached

Re: [PATCH v8 08/35] drm/i915: Implement HDCP2.2 repeater authentication

2018-12-12 Thread C, Ramalingam
On 12/6/2018 4:15 PM, Daniel Vetter wrote: On Tue, Nov 27, 2018 at 04:13:06PM +0530, Ramalingam C wrote: Implements the HDCP2.2 repeaters authentication steps such as verifying the downstream topology and sending stream management information. v2: Rebased. v3: No Changes. v4: -EINVAL i

Re: [PATCH 1/2] dt-bindings: gpu: mali-midgard: Add resets property

2018-12-12 Thread Neil Armstrong
On 11/12/2018 17:58, Rob Herring wrote: > On Mon, Dec 10, 2018 at 7:22 AM Neil Armstrong > wrote: >> >> The Amlogic ARM Mali Midgard requires reset controls to power on and >> software reset the GPU, adds these as optional in the bindings. >> >> Signed-off-by: Neil Armstrong >> --- >> Documenta

Re: [PATCH RESEND] drm/meson: remove firmware framebuffers

2018-12-12 Thread Neil Armstrong
Hi Maxime, On 10/12/2018 10:28, Maxime Jourdan wrote: > In case we are using simplefb or another conflicting framebuffer, make > the call to drm_fb_helper_remove_conflicting_framebuffers() > > Signed-off-by: Maxime Jourdan > --- > drivers/gpu/drm/meson/meson_drv.c | 20 > 1

Re: [Intel-gfx] [PATCH 1/2] drm: Add color management LUT validation helpers

2018-12-12 Thread Brian Starkey
Hi Matt, On Tue, Dec 11, 2018 at 05:05:50PM -0800, Matt Roper wrote: > Some hardware may place additional restrictions on the gamma/degamma > curves described by our LUT properties. E.g., that a gamma curve never > decreases or that the red/green/blue channels of a LUT's entries must be > equal.

Re: [PATCH] [RFC] MAINTAINERS: Daniel for drm co-maintainer

2018-12-12 Thread Daniel Vetter
On Tue, Dec 11, 2018 at 11:17:54AM +, Liviu Dudau wrote: > Hi Daniel, > > On Mon, Dec 10, 2018 at 11:30:01AM +0100, Daniel Vetter wrote: > > lkml and Linus gained a CoC, and it's serious this time. Which means > > my no 1 reason for declining to officially step up as drm maintainer > > is gone

Re: [PATCH 2/4] kernel.h: Add non_block_start/end()

2018-12-12 Thread Daniel Vetter
On Mon, Dec 10, 2018 at 05:30:09PM +0100, Peter Zijlstra wrote: > On Mon, Dec 10, 2018 at 05:20:10PM +0100, Michal Hocko wrote: > > > OK, no real objections to the thing. Just so long we're all on the same > > > page as to what it does and doesn't do ;-) > > > > I am not really sure whether there

Re: [Intel-gfx] [PATCH 3/5] drm/dp: Implement I2C_M_STOP for i2c-over-aux

2018-12-12 Thread Daniel Vetter
On Mon, Dec 10, 2018 at 06:47:00PM -0800, Dhinakaran Pandiyan wrote: > On Fri, 2018-09-28 at 21:04 +0300, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Consult the I2C_M_STOP flag to determine whether to set the MOT bit > > or > > not. Makes it possible to send multiple messages in one go

Re: [PATCH v8 05/35] drm/i915: MEI interface definition

2018-12-12 Thread Daniel Vetter
On Wed, Dec 12, 2018 at 02:28:29PM +0530, C, Ramalingam wrote: > On 12/7/2018 7:59 PM, Daniel Vetter wrote: > > On Fri, Dec 07, 2018 at 11:22:44AM +0530, C, Ramalingam wrote: > > > On 12/6/2018 3:53 PM, Daniel Vetter wrote: > > > > On Tue, Nov 27, 2018 at 04:13:03PM +0530, Ramalingam C wrote: > > >

Re: [Intel-gfx] [PATCH 03/10] drm/syncobj: add new drm_syncobj_add_point interface v2

2018-12-12 Thread Daniel Vetter
On Fri, Dec 07, 2018 at 11:54:15PM +0800, Chunming Zhou wrote: > From: Christian König > > Use the dma_fence_chain object to create a timeline of fence objects > instead of just replacing the existing fence. > > v2: rebase and cleanup > > Signed-off-by: Christian König Somewhat jumping back i

Re: [PATCH 7/7] drm: Split out drm_probe_helper.h

2018-12-12 Thread Daniel Vetter
On Mon, Dec 10, 2018 at 02:40:25PM +0100, Benjamin Gaignard wrote: > Le lun. 10 déc. 2018 à 12:10, Benjamin Gaignard > a écrit : > > > > Le lun. 10 déc. 2018 à 11:24, Thierry Reding > > a écrit : > > > > > > On Mon, Dec 10, 2018 at 11:11:33AM +0100, Daniel Vetter wrote: > > > > Having the probe h

Re: [Intel-gfx] [PATCH 1/7] drm/ch7006: Stop using drm_crtc_force_disable

2018-12-12 Thread Daniel Vetter
On Mon, Dec 10, 2018 at 06:20:41PM +0200, Ville Syrjälä wrote: > On Mon, Dec 10, 2018 at 11:03:53AM +0100, Daniel Vetter wrote: > > The correct way for legacy drivers to update properties that need to > > do a full modeset, is to do a full modeset. > > > > Note that we don't need to call the drm_m

Re: [PATCH 6/7] drm/xen: Don't set the dpms hook

2018-12-12 Thread Daniel Vetter
On Mon, Dec 10, 2018 at 12:12:05PM +0200, Oleksandr Andrushchenko wrote: > On 12/10/18 12:03 PM, Daniel Vetter wrote: > > Doesn't do anything for atomic. > > > > Signed-off-by: Daniel Vetter > > Cc: Oleksandr Andrushchenko > > Cc: xen-de...@lists.xen.org > > --- > > drivers/gpu/drm/xen/xen_drm

Re: [PATCH v8 05/35] drm/i915: MEI interface definition

2018-12-12 Thread C, Ramalingam
On 12/12/2018 4:08 PM, Daniel Vetter wrote: On Wed, Dec 12, 2018 at 02:28:29PM +0530, C, Ramalingam wrote: On 12/7/2018 7:59 PM, Daniel Vetter wrote: On Fri, Dec 07, 2018 at 11:22:44AM +0530, C, Ramalingam wrote: On 12/6/2018 3:53 PM, Daniel Vetter wrote: On Tue, Nov 27, 2018 at 04:13:03PM +

Re: [PATCH] fbdev: fbcon: Fix unregister crash when more than one framebuffer

2018-12-12 Thread Daniel Vetter
On Mon, Dec 10, 2018 at 08:02:55PM +0100, Noralf Trønnes wrote: > When unregistering fbdev using unregister_framebuffer(), any bound > console will unbind automatically. This is working fine if this is the > only framebuffer, resulting in a switch to the dummy console. However if > there is a fb0 a

[PATCH -fixes] drm/vmwgfx: Protect from excessive execbuf kernel memory allocations

2018-12-12 Thread Thomas Hellstrom
With the new validation code, a malicious user-space app could potentially submit command streams with enough buffer-object and resource references in them to have the resulting allocated validion nodes and relocations make the kernel run out of GFP_KERNEL memory. Protect from this by having the v

Re: [Intel-gfx] [PATCH 03/10] drm/syncobj: add new drm_syncobj_add_point interface v2

2018-12-12 Thread Koenig, Christian
Am 12.12.18 um 11:49 schrieb Daniel Vetter: > On Fri, Dec 07, 2018 at 11:54:15PM +0800, Chunming Zhou wrote: >> From: Christian König >> >> Use the dma_fence_chain object to create a timeline of fence objects >> instead of just replacing the existing fence. >> >> v2: rebase and cleanup >> >> Signe

Re: [PATCH] drivers/base: use a worker for sysfs unbind

2018-12-12 Thread Daniel Vetter
On Mon, Dec 10, 2018 at 11:20:58AM +0100, Daniel Vetter wrote: > On Mon, Dec 10, 2018 at 11:18:32AM +0100, Daniel Vetter wrote: > > On Mon, Dec 10, 2018 at 11:06:34AM +0100, Greg Kroah-Hartman wrote: > > > On Mon, Dec 10, 2018 at 09:46:53AM +0100, Daniel Vetter wrote: > > > > Drivers might want to

Re: [Intel-gfx] [PATCH 03/10] drm/syncobj: add new drm_syncobj_add_point interface v2

2018-12-12 Thread Daniel Vetter
On Wed, Dec 12, 2018 at 12:08 PM Koenig, Christian wrote: > > Am 12.12.18 um 11:49 schrieb Daniel Vetter: > > On Fri, Dec 07, 2018 at 11:54:15PM +0800, Chunming Zhou wrote: > >> From: Christian König > >> > >> Use the dma_fence_chain object to create a timeline of fence objects > >> instead of ju

Re: [PATCH] drivers/base: use a worker for sysfs unbind

2018-12-12 Thread Greg Kroah-Hartman
On Wed, Dec 12, 2018 at 12:08:40PM +0100, Daniel Vetter wrote: > On Mon, Dec 10, 2018 at 11:20:58AM +0100, Daniel Vetter wrote: > > On Mon, Dec 10, 2018 at 11:18:32AM +0100, Daniel Vetter wrote: > > > On Mon, Dec 10, 2018 at 11:06:34AM +0100, Greg Kroah-Hartman wrote: > > > > On Mon, Dec 10, 2018 a

Re: [PATCH -fixes] drm/vmwgfx: Protect from excessive execbuf kernel memory allocations

2018-12-12 Thread Thomas Hellstrom
On 12/12/18 12:06 PM, Thomas Hellstrom wrote: With the new validation code, a malicious user-space app could potentially submit command streams with enough buffer-object and resource references in them to have the resulting allocated validion nodes and relocations make the kernel run out of GFP_K

[Bug 109017] The drop in resolution with AMD Kaveri

2018-12-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109017 Michel Dänzer changed: What|Removed |Added Product|xorg|DRI Component|Driver/AMDgpu

[Bug 109017] The drop in resolution with AMD Kaveri

2018-12-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109017 --- Comment #5 from Dmitry --- Not do. On this version of the kernel, it is by default dc=1 -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailing list dri-dev

[Bug 109021] Kaveri no fix perfomance

2018-12-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109021 Michel Dänzer changed: What|Removed |Added QA Contact||mesa-dev@lists.freedesktop.

[Bug 109017] The drop in resolution with AMD Kaveri

2018-12-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109017 --- Comment #6 from Michel Dänzer --- Please try it anyway. The attached dmesg shows DC being disabled. -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailing

RE: [Intel-gfx] [PATCH 03/10] drm/syncobj: add new drm_syncobj_add_point interface v2

2018-12-12 Thread Zhou, David(ChunMing)
+ Daniel Rakos and Jason Ekstrand. Below is the background, which is from Daniel R should be able to explain that's why: " ISVs, especially those coming from D3D12, are unsatisfied with the behavior of the Vulkan semaphores as they are unhappy with the fact that for every single dependency t

Re: [PATCH] [RFC] MAINTAINERS: Daniel for drm co-maintainer

2018-12-12 Thread Neil Armstrong
On 10/12/2018 11:30, Daniel Vetter wrote: > lkml and Linus gained a CoC, and it's serious this time. Which means > my no 1 reason for declining to officially step up as drm maintainer > is gone, and I didn't find any new good excuse. > > I chatted with a few people in private already, and the bigg

Re: [Intel-gfx] [PATCH 03/10] drm/syncobj: add new drm_syncobj_add_point interface v2

2018-12-12 Thread Koenig, Christian
> Key point is that our Vulcan guys came back and said that this > wouldn't be sufficient, but I honestly don't fully understand why. > Hm, sounds like we really need those testscases (vk cts on top of mesa, igt) > so we can talk about the exact corner cases we care about and why. Yes, that's why I

Re: [Intel-gfx] [PATCH 3/5] drm/dp: Implement I2C_M_STOP for i2c-over-aux

2018-12-12 Thread Ville Syrjälä
On Wed, Dec 12, 2018 at 11:30:30AM +0100, Daniel Vetter wrote: > On Mon, Dec 10, 2018 at 06:47:00PM -0800, Dhinakaran Pandiyan wrote: > > On Fri, 2018-09-28 at 21:04 +0300, Ville Syrjala wrote: > > > From: Ville Syrjälä > > > > > > Consult the I2C_M_STOP flag to determine whether to set the MOT b

[Bug 109017] The drop in resolution with AMD Kaveri

2018-12-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109017 --- Comment #7 from Dmitry --- With the option DC=1 in the black screen. accordingly, dmesg can't do -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailing lis

Re: [Intel-gfx] [PATCH 03/10] drm/syncobj: add new drm_syncobj_add_point interface v2

2018-12-12 Thread Daniel Vetter
On Wed, Dec 12, 2018 at 1:00 PM Koenig, Christian wrote: > > > Key point is that our Vulcan guys came back and said that this > > wouldn't be sufficient, but I honestly don't fully understand why. > > Hm, sounds like we really need those testscases (vk cts on top of mesa, igt) > > so we can talk a

Re: [Intel-gfx] [PATCH 03/10] drm/syncobj: add new drm_syncobj_add_point interface v2

2018-12-12 Thread Daniel Vetter
On Wed, Dec 12, 2018 at 12:40 PM Zhou, David(ChunMing) wrote: > > + Daniel Rakos and Jason Ekstrand. > > Below is the background, which is from Daniel R should be able to explain > that's why: > " ISVs, especially those coming from D3D12, are unsatisfied with the behavior > of the Vulkan semap

Re: [PATCH RESEND] drm/meson: remove firmware framebuffers

2018-12-12 Thread Neil Armstrong
On 12/12/2018 13:22, Maxime Jourdan wrote: > Hi Neil, > On Wed, Dec 12, 2018 at 10:55 AM Neil Armstrong > wrote: >> >> Hi Maxime, >> >> On 10/12/2018 10:28, Maxime Jourdan wrote: >>> In case we are using simplefb or another conflicting framebuffer, make >>> the call to drm_fb_helper_remove_confli

Re: [PATCH] drivers/base: use a worker for sysfs unbind

2018-12-12 Thread Daniel Vetter
On Wed, Dec 12, 2018 at 12:19 PM Greg Kroah-Hartman wrote: > > On Wed, Dec 12, 2018 at 12:08:40PM +0100, Daniel Vetter wrote: > > On Mon, Dec 10, 2018 at 11:20:58AM +0100, Daniel Vetter wrote: > > > On Mon, Dec 10, 2018 at 11:18:32AM +0100, Daniel Vetter wrote: > > > > On Mon, Dec 10, 2018 at 11:0

Re: [PATCH -fixes] drm/vmwgfx: Protect from excessive execbuf kernel memory allocations

2018-12-12 Thread Daniel Vetter
On Wed, Dec 12, 2018 at 12:26 PM Thomas Hellstrom wrote: > > On 12/12/18 12:06 PM, Thomas Hellstrom wrote: > > With the new validation code, a malicious user-space app could > > potentially submit command streams with enough buffer-object and resource > > references in them to have the resulting a

Re: [Intel-gfx] [PATCH 03/10] drm/syncobj: add new drm_syncobj_add_point interface v2

2018-12-12 Thread Chunming Zhou
在 2018/12/12 20:24, Daniel Vetter 写道: > On Wed, Dec 12, 2018 at 12:40 PM Zhou, David(ChunMing) > wrote: >> + Daniel Rakos and Jason Ekstrand. >> >> Below is the background, which is from Daniel R should be able to explain >> that's why: >> " ISVs, especially those coming from D3D12, are unsat

Re: [PATCH v3 2/2] drm/sched: Rework HW fence processing.

2018-12-12 Thread Grodzovsky, Andrey
BTW, the problem I pointed out with drm_sched_entity_kill_jobs_cb is not an issue with this patch set since it removes the cb from s_fence->finished in general so we only free the job once - directly from drm_sched_entity_kill_jobs_cb. Andrey On 12/11/2018 11:20 AM, Christian König wrote: > Y

[PATCH v2 03/18] drm/qxl: simplify slot management

2018-12-12 Thread Gerd Hoffmann
Drop pointless indirection, remove the mem_slots array and index variables, drop dynamic allocation. Store memslots in qxl_device instead. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/qxl/qxl_drv.h | 15 + drivers/gpu/drm/qxl/qxl_kms.c | 72 +-

[PATCH v2 06/18] drm/qxl: use separate offset spaces for the two slots / ttm memory types.

2018-12-12 Thread Gerd Hoffmann
Without that ttm offsets are not unique, they can refer to objects in both VRAM and PRIV memory (aka main and surfaces slot). One of those "why things didn't blow up without this" moments. Probably offset conflicts are rare enough by pure luck. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/q

[PATCH v2 05/18] drm/qxl: drop unused fields from struct qxl_device

2018-12-12 Thread Gerd Hoffmann
slot_id_bits and slot_gen_bits can be read directly from qxlrom instead. va_slot_mask is never used anywhere. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/qxl/qxl_drv.h | 3 --- drivers/gpu/drm/qxl/qxl_kms.c | 10 ++ 2 files changed, 2 insertions(+), 11 deletions(-) diff --git a/dr

[PATCH v2 11/18] drm/qxl: drop unused offset parameter from qxl_io_create_primary()

2018-12-12 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/qxl/qxl_drv.h | 1 - drivers/gpu/drm/qxl/qxl_cmd.c | 7 +++ drivers/gpu/drm/qxl/qxl_display.c | 2 +- 3 files changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/qxl/qxl_drv.h b/drivers/gpu/drm/qxl/qxl_drv.h index 27e

[PATCH v2 18/18] drm/qxl: remove dead qxl fbdev emulation code

2018-12-12 Thread Gerd Hoffmann
Lovely diffstat, thanks to the new generic fbdev emulation. drm/qxl/Makefile |2 drm/qxl/qxl_draw.c | 232 drm/qxl/qxl_drv.h | 21 --- drm/qxl/qxl_fb.c | 300 - Signed-off-by: Gerd Hoffmann

[PATCH v2 07/18] drm/qxl: allow both PRIV and VRAM placement for QXL_GEM_DOMAIN_SURFACE

2018-12-12 Thread Gerd Hoffmann
qxl surfaces (used for framebuffers and gem objects) can live in both VRAM and PRIV ttm domains. Update placement setup to include both. Put PRIV first in the list so it is preferred, so VRAM will have more room for objects which must be allocated there. Signed-off-by: Gerd Hoffmann --- drivers

[PATCH v2 01/18] drm/qxl: drop ttm_mem_reg arg from qxl_hw_surface_alloc()

2018-12-12 Thread Gerd Hoffmann
Not used, is always NULL. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/qxl/qxl_drv.h| 3 +-- drivers/gpu/drm/qxl/qxl_cmd.c| 14 ++ drivers/gpu/drm/qxl/qxl_object.c | 2 +- 3 files changed, 4 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/qxl/qxl_drv.h b/dr

[PATCH v2 10/18] drm/qxl: move qxl_primary_apply_cursor to correct place

2018-12-12 Thread Gerd Hoffmann
The cursor must be set again after creating the primary surface. Also drop the error message. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/qxl/qxl_display.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/qxl/qxl_display.c b/drivers/gpu/drm/qxl

[PATCH v2 08/18] drm/qxl: use QXL_GEM_DOMAIN_SURFACE for shadow bo.

2018-12-12 Thread Gerd Hoffmann
The shadow bo is used as qxl surface, so allocate it as QXL_GEM_DOMAIN_SURFACE. Should usually be allocated in PRIV ttm domain then, so this reduces VRAM memory pressure. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/qxl/qxl_display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) di

[PATCH v2 16/18] drm/qxl: implement prime kmap/kunmap

2018-12-12 Thread Gerd Hoffmann
Generic fbdev emulation needs this. Also: We must keep track of the number of mappings now, so we don't unmap early in case two users want a kmap of the same bo. Add a sanity check to destroy callback to make sure kmap/kunmap is balanced. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/qxl/qx

[PATCH v2 12/18] drm/qxl: track primary bo

2018-12-12 Thread Gerd Hoffmann
Track which bo is used as primary surface. With that in place we don't need the primary_created flag any more, we can just check the primary bo pointer instead. Also verify we don't already have a primary surface in qxl_io_create_primary(). Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/qxl/

[PATCH v2 13/18] drm/qxl: use shadow bo directly

2018-12-12 Thread Gerd Hoffmann
Pass the shadow bo to qxl_io_create_primary() instead of expecting qxl_io_create_primary to check bo->shadow. Set is_primary flag on the shadow bo. Move the is_primary tracking into qxl_io_create_primary() and qxl_io_destroy_primary() functions. That simplifies primary surface tracking and the w

[PATCH v2 14/18] drm/qxl: cover all crtcs in shadow bo.

2018-12-12 Thread Gerd Hoffmann
The qxl device supports only a single active framebuffer ("primary surface" in spice terminology). In multihead configurations are handled by defining rectangles within the primary surface for each head/crtc. Userspace which uses the qxl ioctl interface (xorg qxl driver) is aware of this limitati

[PATCH v2 09/18] drm/qxl: use QXL_GEM_DOMAIN_SURFACE for dumb gem objects

2018-12-12 Thread Gerd Hoffmann
dumb buffers are used as qxl surfaces, so allocate them as QXL_GEM_DOMAIN_SURFACE. Should usually be allocated in PRIV ttm domain then, so this reduces VRAM memory pressure. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/qxl/qxl_dumb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) di

[PATCH v2 00/18] drm/qxl: ttm fixes, cleanups, allocation tweaks, multihead, fbdev

2018-12-12 Thread Gerd Hoffmann
So, here is the all-in-one package of all my qxl changes. Some of these changes have been on the list before, some not. Summary: (1) A collection of misc ttm bugfixes and cleanups. (2) Move some allocations from VRAM to PRIV domain, to reduce VRAM memory pressure. Should help especially

[PATCH v2 04/18] drm/qxl: change the way slot is detected

2018-12-12 Thread Gerd Hoffmann
From: Frediano Ziglio Instead of relaying on surface type use the actual placement. This allow to have different placement for a single type of surface. Signed-off-by: Frediano Ziglio [ kraxel: rebased, adapted to upstream changes ] Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/qxl/qxl_d

[PATCH v2 02/18] drm/qxl: drop unused qxl_fb_virtual_address

2018-12-12 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/qxl/qxl_drv.h | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/gpu/drm/qxl/qxl_drv.h b/drivers/gpu/drm/qxl/qxl_drv.h index 38c5a8b1df..7eabf4a9ed 100644 --- a/drivers/gpu/drm/qxl/qxl_drv.h +++ b/drivers/gpu/drm/qxl/qxl_drv.h @@ -30

[PATCH v2 15/18] drm/qxl: use qxl_num_crtc directly

2018-12-12 Thread Gerd Hoffmann
qdev->monitors_config->max_allowed is effectively set by the qxl.num_heads module parameter, stored in the qxl_num_crtc variable. Lets get rid of the indirection and use the variable qxl_num_crtc directly. The kernel doesn't need to dereference pointers each time it needs the value, and when readi

Re: [PATCH] [RFC] MAINTAINERS: Daniel for drm co-maintainer

2018-12-12 Thread Thierry Reding
On Mon, Dec 10, 2018 at 11:30:01AM +0100, Daniel Vetter wrote: > lkml and Linus gained a CoC, and it's serious this time. Which means > my no 1 reason for declining to officially step up as drm maintainer > is gone, and I didn't find any new good excuse. > > I chatted with a few people in private

[PATCH v2 17/18] drm/qxl: use generic fbdev emulation

2018-12-12 Thread Gerd Hoffmann
Switch qxl over to the new generic fbdev emulation. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/qxl/qxl_display.c | 7 --- drivers/gpu/drm/qxl/qxl_drv.c | 2 ++ 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/qxl/qxl_display.c b/drivers/gpu/drm/qxl/qx

[PULL] drm-intel-fixes

2018-12-12 Thread Joonas Lahtinen
Hi Dave, Here's two more GPU hang fixes on top of last week's PR. This also includes stuff from last week that I sent bit late, and was not pulled by you. This is still on top of -rc5 because it includes the GVT merge. Regards, Joonas *** drm-intel-fixes-2018-12-12-1: - Two fixes to avoid GPU

Re: [drm-intel:for-linux-next-fixes 5/5] drivers/gpu//drm/i915/intel_ringbuffer.c:89:11: error: implicit declaration of function 'i915_scratch_offset'; did you mean 'i915_ggtt_offset'?

2018-12-12 Thread Joonas Lahtinen
Should be fixed already with an updated -fixes. Regards, Joonas Quoting kbuild test robot (2018-12-12 10:31:58) > tree: git://anongit.freedesktop.org/drm-intel for-linux-next-fixes > head: eeb139ca4b24d515265ad75f668333431896b1aa > commit: eeb139ca4b24d515265ad75f668333431896b1aa [5/5] drm/i9

Re: [PATCH -fixes] drm/vmwgfx: Protect from excessive execbuf kernel memory allocations

2018-12-12 Thread Thomas Hellstrom
Hi, Daniel, On 12/12/18 1:56 PM, Daniel Vetter wrote: On Wed, Dec 12, 2018 at 12:26 PM Thomas Hellstrom wrote: On 12/12/18 12:06 PM, Thomas Hellstrom wrote: With the new validation code, a malicious user-space app could potentially submit command streams with enough buffer-object and resource

Re: [PATCH v2 2/3] ACPI / PMIC: Implement exec_mipi_pmic_seq_element for CHT Whiskey Cove PMIC

2018-12-12 Thread Hans de Goede
Hi, On 07-12-18 12:40, Mika Westerberg wrote: On Thu, Dec 06, 2018 at 02:47:04PM +0100, Hans de Goede wrote: Implement the exec_mipi_pmic_seq_element callback for the CHT Whiskey Cove PMIC. On some CHT devices this fixes the LCD panel not lighting up when it was not initialized by the GOP, bec

Re: [PATCH v2 1/3] ACPI / PMIC: Add support for executing PMIC MIPI sequence elements

2018-12-12 Thread Hans de Goede
Hi, On 07-12-18 12:39, Mika Westerberg wrote: On Thu, Dec 06, 2018 at 02:47:03PM +0100, Hans de Goede wrote: DSI LCD panels describe an initialization sequence in the Video BIOS Tables using so called MIPI sequences. One possible element in these sequences is a PMIC specific element of 15 bytes

Re: [PATCH v2 3/3] drm/i915/intel_dsi_vbt: Add support for PMIC mipi sequences

2018-12-12 Thread Hans de Goede
Hi, On 07-12-18 18:17, Ville Syrjälä wrote: On Thu, Dec 06, 2018 at 02:47:05PM +0100, Hans de Goede wrote: Add support for PMIC mipi sequences using the new intel_soc_pmic_exec_mipi_pmic_seq_element function. Please document somewhere which machines you've found to need this (commit msg shoul

Re: [PATCH] [RFC] MAINTAINERS: Daniel for drm co-maintainer

2018-12-12 Thread Thomas Hellstrom
On 12/10/18 11:30 AM, Daniel Vetter wrote: lkml and Linus gained a CoC, and it's serious this time. Which means my no 1 reason for declining to officially step up as drm maintainer is gone, and I didn't find any new good excuse. I chatted with a few people in private already, and the biggest con

Re: [PATCH] fbdev: fbcon: Fix unregister crash when more than one framebuffer

2018-12-12 Thread Noralf Trønnes
Den 12.12.2018 12.05, skrev Daniel Vetter: On Mon, Dec 10, 2018 at 08:02:55PM +0100, Noralf Trønnes wrote: When unregistering fbdev using unregister_framebuffer(), any bound console will unbind automatically. This is working fine if this is the only framebuffer, resulting in a switch to the dum

[PATCH -fixes] drm/vmwgfx: Protect from excessive execbuf kernel memory allocations v2

2018-12-12 Thread Thomas Hellstrom
With the new validation code, a malicious user-space app could potentially submit command streams with enough buffer-object and resource references in them to have the resulting allocated validion nodes and relocations make the kernel run out of GFP_KERNEL memory. Protect from this by having the v

Re: [PATCH] drm/rockchip: Add implicit fencing support for planes

2018-12-12 Thread Neil Armstrong
On 30/11/2018 11:24, Heiko Stuebner wrote: > Render like lima will attach a fence to the framebuffer dma_buf, > so the display driver should wait for it to finish before showing > the framebufferto prevent tearing. > > Generally tested on rk3188, rk3288, rk3328 and rk3399 and > together with an ac

Re: [PATCH] [RFC] MAINTAINERS: Daniel for drm co-maintainer

2018-12-12 Thread Sean Paul
On Mon, Dec 10, 2018 at 11:30:01AM +0100, Daniel Vetter wrote: > lkml and Linus gained a CoC, and it's serious this time. Which means > my no 1 reason for declining to officially step up as drm maintainer > is gone, and I didn't find any new good excuse. > > I chatted with a few people in private

[Bug 109001] Freezes when waking up after screen goes blank.

2018-12-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109001 --- Comment #7 from Julio --- (In reply to fin4478 from comment #6) > Comment on attachment 142770 [details] > Xorg Log > > Disable the Xfce compositor, vsync feature in that causes it tainted. That > might not help. Use the display port, deve

Re: [PATCH 1/5] drm/msm/dpu: Remove unused format tables.

2018-12-12 Thread Sean Paul
On Tue, Dec 11, 2018 at 10:42:20AM -0800, Fritz Koenig wrote: > Signed-off-by: Fritz Koenig In future, can you please cc freedr...@lists.freedesktop.org and linux-arm-...@vger.kernel.org on msm patches? Reviewed-by: Sean Paul > --- > .../drm/msm/disp/dpu1/dpu_hw_catalog_format.h | 73 --

Re: [PATCH 2/5] drm/msm/dpu: Use simple list for plane format init

2018-12-12 Thread Sean Paul
On Tue, Dec 11, 2018 at 10:42:21AM -0800, Fritz Koenig wrote: > Simplify the initilization of a list of formats > by passing the list in directly instead of copying > it from one structure to another. I have notes on at least a few other instances of passing a struct of parameters instead of just

Re: [PATCH] drm/rockchip: Add implicit fencing support for planes

2018-12-12 Thread Heiko Stuebner
Am Freitag, 30. November 2018, 11:24:49 CET schrieb Heiko Stuebner: > Render like lima will attach a fence to the framebuffer dma_buf, > so the display driver should wait for it to finish before showing > the framebufferto prevent tearing. > > Generally tested on rk3188, rk3288, rk3328 and rk3399

Re: [PATCH 3/5] drm/msm/dpu: Plane helper for modifiers

2018-12-12 Thread Sean Paul
On Tue, Dec 11, 2018 at 10:42:22AM -0800, Fritz Koenig wrote: > Filter planes based on the supported modifiers > > Signed-off-by: Fritz Koenig Reviewed-by: Sean Paul > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 18 ++ > 1 file changed, 18 insertions(+) > > diff --git a

[Bug 109001] Freezes when waking up after screen goes blank.

2018-12-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109001 --- Comment #8 from Michel Dänzer --- I suspect disabling V-Sync in xfwm4 just avoids the problem, i.e. it's a workaround, not a fix. Unless you're using rotation or other RandR transforms, leaving V-Sync enabled and leaving TearFree at the defa

Re: [PATCH 4/5] drm/msm/dpu: Initialize supported modifiers

2018-12-12 Thread Sean Paul
On Tue, Dec 11, 2018 at 10:42:23AM -0800, Fritz Koenig wrote: > Pass list of supported modifiers to plane init. > > Signed-off-by: Fritz Koenig > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/msm/d

Re: [PATCH 5/5] drm/msm/dpu: Correct initialization of modifiers

2018-12-12 Thread Sean Paul
On Tue, Dec 11, 2018 at 10:42:24AM -0800, Fritz Koenig wrote: > allow_fb_modifiers needs to be set before drm_universal_plane_init > is called. > > Signed-off-by: Fritz Koenig Reviewed-by: Sean Paul > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 20 ++-- > 1 file changed, 1

[Bug 199319] Flickering screen on AMDGPU and DC with Linux 4.16-2

2018-12-12 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=199319 siyia (eutychio...@gmail.com) changed: What|Removed |Added CC||eutychio...@gmail.com ---

[Bug 199319] Flickering screen on AMDGPU and DC with Linux 4.16-2

2018-12-12 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=199319 --- Comment #22 from siyia (eutychio...@gmail.com) --- Tested both kernels 4.19.x and 4.20rc6 -- You are receiving this mail because: You are watching the assignee of the bug. ___ dri-devel mailing lis

[PATCH v5 1/2] dt-bindings: Document,qcom,adreno-gmu

2018-12-12 Thread Jordan Crouse
Document the device tree bindings for the Adreno GMU device available on Adreno a6xx targets. Reviewed-by: Rob Herring Signed-off-by: Jordan Crouse --- .../devicetree/bindings/display/msm/gmu.txt | 54 +++ .../devicetree/bindings/display/msm/gpu.txt | 2 + 2 files changed,

[PATCH v5 2/2] arm64: dts: sdm845: Add gpu and gmu device nodes

2018-12-12 Thread Jordan Crouse
Add the nodes to describe the Adreno GPU and GMU devices. Signed-off-by: Jordan Crouse --- arch/arm64/boot/dts/qcom/sdm845.dtsi | 123 +++ 1 file changed, 123 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi index c2

[PATCH v5 0/2] arm64: dts: Add sdm845 GPU/GMU and SMMU

2018-12-12 Thread Jordan Crouse
Now that more of the dependent bindings are headed upstream this a refresh of of https://patchwork.freedesktop.org/series/39308/ to add bindings and nodes for the GPU/GMU and GPU SMMU for sdm845. This change requires the following dependencies: gpucc: git://git.kernel.org/pub/scm/linux/kernel/gi

Re: [PATCH] drm/nouveau: Fix memory leak in nv50_mstm_del()

2018-12-12 Thread Lyude Paul
v4.19.8, it's ok to skip v4.14 for this On Wed, 2018-12-12 at 05:46 +, Sasha Levin wrote: > Hi, > > [This is an automated email] > > This commit has been processed because it contains a "Fixes:" tag, > fixing commit: f479c0ba4a17 drm/nouveau/kms/nv50: initial support for DP 1.2 > multi-strea

Re: [PATCH -fixes] drm/vmwgfx: Protect from excessive execbuf kernel memory allocations v2

2018-12-12 Thread Deepak Singh Rawat
On Wed, 2018-12-12 at 15:35 +0100, Thomas Hellstrom wrote: > With the new validation code, a malicious user-space app could > potentially submit command streams with enough buffer-object and > resource > references in them to have the resulting allocated validion nodes and > relocations make the ke

Re: [PATCH 4/5] drm/msm/dpu: Initialize supported modifiers

2018-12-12 Thread Fritz Koenig
On Wed, Dec 12, 2018 at 8:12 AM Sean Paul wrote: > > On Tue, Dec 11, 2018 at 10:42:23AM -0800, Fritz Koenig wrote: > > Pass list of supported modifiers to plane init. > > > > Signed-off-by: Fritz Koenig > > --- > > drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 8 +++- > > 1 file changed, 7 ins

Re: [PATCH -fixes] drm/vmwgfx: Protect from excessive execbuf kernel memory allocations v2

2018-12-12 Thread Thomas Hellstrom
Hi, Deepak, On Wed, 2018-12-12 at 10:00 -0800, Deepak Singh Rawat wrote: > On Wed, 2018-12-12 at 15:35 +0100, Thomas Hellstrom wrote: > > With the new validation code, a malicious user-space app could > > potentially submit command streams with enough buffer-object and > > resource > > references

Re: [PATCH -fixes] drm/vmwgfx: Protect from excessive execbuf kernel memory allocations v2

2018-12-12 Thread Deepak Singh Rawat
Reviewed-by: Deepak Rawat On Wed, 2018-12-12 at 10:38 -0800, Thomas Hellstrom wrote: > Hi, Deepak, > > On Wed, 2018-12-12 at 10:00 -0800, Deepak Singh Rawat wrote: > > On Wed, 2018-12-12 at 15:35 +0100, Thomas Hellstrom wrote: > > > With the new validation code, a malicious user-space app could

Re: [PATCH v5 2/2] arm64: dts: sdm845: Add gpu and gmu device nodes

2018-12-12 Thread Doug Anderson
Hi, On Wed, Dec 12, 2018 at 9:31 AM Jordan Crouse wrote: > > Add the nodes to describe the Adreno GPU and GMU devices. > > Signed-off-by: Jordan Crouse > --- > arch/arm64/boot/dts/qcom/sdm845.dtsi | 123 +++ > 1 file changed, 123 insertions(+) > > diff --git a/arch/arm64

Re: [PATCH v5 1/2] dt-bindings: Document,qcom,adreno-gmu

2018-12-12 Thread Doug Anderson
Hi, On Wed, Dec 12, 2018 at 9:31 AM Jordan Crouse wrote: > > Document the device tree bindings for the Adreno GMU device > available on Adreno a6xx targets. > > Reviewed-by: Rob Herring > Signed-off-by: Jordan Crouse > --- > .../devicetree/bindings/display/msm/gmu.txt | 54 ++

  1   2   >