Re: [RFC] mm: Replace all open encodings for NUMA_NO_NODE

2018-11-12 Thread Hans Verkuil
On 11/12/2018 03:41 AM, Anshuman Khandual wrote: > At present there are multiple places where invalid node number is encoded > as -1. Even though implicitly understood it is always better to have macros > in there. Replace these open encodings for an invalid node number with the > global macro NUMA

[Bug 201439] Amdgpu: system freeze when waking up from monitor blanking

2018-11-12 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=201439 fin4...@hotmail.com changed: What|Removed |Added Summary|Amdgpu: system freeze when |Amdgpu: system freeze when

[PATCH] backlight: pwm_bl: fix devicetree parsing with auto-generated brightness tables

2018-11-12 Thread Heiko Stuebner
From: Heiko Stuebner Commit 88ba95bedb79 ("backlight: pwm_bl: Compute brightness of LED linearly to human eye") made the parse-dt function return early when using an auto- generated brightness-table, but didn't take into account that some more settings were handled below the brightness handling,

Re: [PATCH v4 3/4] drm/virtio: add in/out fence support for explicit synchronization

2018-11-12 Thread Gerd Hoffmann
On Fri, Nov 09, 2018 at 06:13:52PM +0100, Robert Foss wrote: > Hey Gerd, > > On 2018-11-09 11:13, Gerd Hoffmann wrote: > > On Mon, Nov 05, 2018 at 05:25:05PM +, Emil Velikov wrote: > > > On Mon, 5 Nov 2018 at 11:42, Robert Foss > > > wrote: > > > > > > > > When the execbuf call receives an

Re: [PATCH v3 0/4] omapdrm: Fix runtime PM issues at module load and unload time

2018-11-12 Thread Tomi Valkeinen
On 10/11/18 13:16, Laurent Pinchart wrote: > Hello, > > This series fixes crashes in the omapdss driver at both load and unload > time, due to runtime PM problems related to probe deferral. The bugs got > introduced in v4.20-rc, this should thus be considered as v4.20 fixes. > > At the core of th

Re: [PATCH 0/5] drm/gem: Add drm_gem_object_funcs

2018-11-12 Thread Koenig, Christian
Am 10.11.18 um 15:56 schrieb Noralf Trønnes: > This patchset adds a GEM object function table and makes use of it in > the CMA helper. > > This was originally part of a shmem helper series[1] that didn't make > it. Daniel and Christian showed interest in the vtable part so I have > hooked it up to

Re: [PATCH] drm/omap: dsi: Fix missing of_platform_depopulate()

2018-11-12 Thread Tomi Valkeinen
On 06/11/18 17:28, Tony Lindgren wrote: > We're missing a call to of_platform_depopulate() on errors for dsi. > Looks like dss is already doing this. > > Signed-off-by: Tony Lindgren > --- > drivers/gpu/drm/omapdrm/dss/dsi.c | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > di

Re: [PATCH 2/2] drm: Revert syncobj timeline changes.

2018-11-12 Thread Christian König
Am 09.11.18 um 23:26 schrieb Eric Anholt: Eric Anholt writes: [ Unknown signature status ] zhoucm1 writes: On 2018年11月09日 00:52, Christian König wrote: Am 08.11.18 um 17:07 schrieb Koenig, Christian: Am 08.11.18 um 17:04 schrieb Eric Anholt: Daniel suggested I submit this, since we're st

Re: [PATCH 2/3] drm/vc4: Force ->x_scaling[1] should never be set to VC4_SCALING_NONE

2018-11-12 Thread Boris Brezillon
On Mon, 12 Nov 2018 10:20:35 + Dave Stevenson wrote: > Hi Boris & Eric. > > On Thu, 8 Nov 2018 at 15:12, Eric Anholt wrote: > > > > Boris Brezillon writes: > > > > > On Thu, 08 Nov 2018 06:52:44 -0800 > > > Eric Anholt wrote: > > > > > >> Boris Brezillon writes: > > >> > > >> > For

Re: [PATCH 2/3] drm/vc4: Force ->x_scaling[1] should never be set to VC4_SCALING_NONE

2018-11-12 Thread Dave Stevenson
Hi Boris & Eric. On Thu, 8 Nov 2018 at 15:12, Eric Anholt wrote: > > Boris Brezillon writes: > > > On Thu, 08 Nov 2018 06:52:44 -0800 > > Eric Anholt wrote: > > > >> Boris Brezillon writes: > >> > >> > For the YUV conversion to work properly, ->x_scaling[0,1] should never > >> > be set to VC4_

Re: [PATCH 2/2] drm: Revert syncobj timeline changes.

2018-11-12 Thread zhoucm1
On 2018年11月12日 18:16, Christian König wrote: Am 09.11.18 um 23:26 schrieb Eric Anholt: Eric Anholt writes: [ Unknown signature status ] zhoucm1 writes: On 2018年11月09日 00:52, Christian König wrote: Am 08.11.18 um 17:07 schrieb Koenig, Christian: Am 08.11.18 um 17:04 schrieb Eric Anholt:

Re: [PATCH v4 3/4] drm/virtio: add in/out fence support for explicit synchronization

2018-11-12 Thread Robert Foss
Hey Gerd On 2018-11-12 10:10, Gerd Hoffmann wrote: On Fri, Nov 09, 2018 at 06:13:52PM +0100, Robert Foss wrote: Hey Gerd, On 2018-11-09 11:13, Gerd Hoffmann wrote: On Mon, Nov 05, 2018 at 05:25:05PM +, Emil Velikov wrote: On Mon, 5 Nov 2018 at 11:42, Robert Foss wrote: When the execbu

Re: [PATCH 2/2] drm: Revert syncobj timeline changes.

2018-11-12 Thread Chris Wilson
Quoting Christian König (2018-11-12 10:16:01) > Am 09.11.18 um 23:26 schrieb Eric Anholt: > > Eric Anholt writes: > > > [ Unknown signature status ] > zhoucm1 writes: > > > On 2018年11月09日 00:52, Christian König wrote: > > Am 08.11.18 um 17:07

Re: [PATCH v4 3/4] drm/virtio: add in/out fence support for explicit synchronization

2018-11-12 Thread Gerd Hoffmann
On Mon, Nov 12, 2018 at 11:30:57AM +0100, Robert Foss wrote: > Hey Gerd > > On 2018-11-12 10:10, Gerd Hoffmann wrote: > > On Fri, Nov 09, 2018 at 06:13:52PM +0100, Robert Foss wrote: > > > Hey Gerd, > > > > > > On 2018-11-09 11:13, Gerd Hoffmann wrote: > > > > On Mon, Nov 05, 2018 at 05:25:05PM +

[PATCH] drm/etnaviv: remove unnecessary local irq state save/restore

2018-11-12 Thread Lucas Stach
etnaviv_gpu_recover_hang() and event_alloc() are never called from a context where local irqs would be disabled, so we can reduce the overhead by using the spinlock variants that don't remember the irq state. Signed-off-by: Lucas Stach --- drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 11 +--

Re: [PATCH 2/2] drm: Revert syncobj timeline changes.

2018-11-12 Thread Koenig, Christian
Am 12.11.18 um 11:48 schrieb Chris Wilson: > Quoting Christian König (2018-11-12 10:16:01) >> Am 09.11.18 um 23:26 schrieb Eric Anholt: >> >> Eric Anholt writes: >> >> >> [ Unknown signature status ] >> zhoucm1 writes: >> >> >> On 2018年11月09日 00:52, Christian K

Re: [PATCH v4 3/4] drm/virtio: add in/out fence support for explicit synchronization

2018-11-12 Thread Robert Foss
On 2018-11-12 12:11, Gerd Hoffmann wrote: On Mon, Nov 12, 2018 at 11:30:57AM +0100, Robert Foss wrote: Hey Gerd On 2018-11-12 10:10, Gerd Hoffmann wrote: On Fri, Nov 09, 2018 at 06:13:52PM +0100, Robert Foss wrote: Hey Gerd, On 2018-11-09 11:13, Gerd Hoffmann wrote: On Mon, Nov 05, 2018 a

[Bug 108680] [CI][BAT] igt@kms_chamelium may need to wait a little bit for the network to come back up before connecting to chamelium

2018-11-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108680 Lakshmi changed: What|Removed |Added Assignee|dri-devel@lists.freedesktop |petri.latv...@intel.com |.o

[PATCH 3/3 v6] ARM: defconfig: Enable the PL111 DRM driver on vexpress

2018-11-12 Thread Linus Walleij
This updates the Versatile defconfig to use the new P111 DRM driver that is merged in the DRM subsystem. We deactivate the old CLCD driver and activate the Pl111 DRM driver and the SiI9022 HDMI bridge. We activate DMA memory allocation using CMA so that the special graphics memory for the on-boar

[PATCH 0/3 v6] Switch Versatile Express to DRM

2018-11-12 Thread Linus Walleij
This should finally (famous last words) switch the Versatile Express to use the new PL111 DRM driver. These changes depend on patches queued in the DRM tree, so it should resolve nicely in -next, also you can probably test them easiest by simply applying them on -next. The DTS and defconfig chang

[PATCH 2/3 v6] ARM: defconfig: Update the vexpress defconfig

2018-11-12 Thread Linus Walleij
Update the Versatile Express defconfig to match the Kconfig changes in the kernel. Cc: Sudeep Holla Cc: Lorenzo Pieralisi Signed-off-by: Linus Walleij --- ChangeLog v5->v6: - Resending ChangeLog v4->v5: - Resending ChangeLog v3->v4: - Resending ChangeLog v1->v3: - Rebased --- arch/arm/configs/

[PATCH 1/3 v6] ARM: dts: Modernize the Vexpress PL111 integration

2018-11-12 Thread Linus Walleij
The Versatile Express was submitted with the actual display bridges unconnected (but defined in the device tree) and mock "panels" encoded in the device tree node of the PL111 controller. This doesn't even remotely describe the actual Versatile Express hardware. Exploit the SiI9022 bridge by conne

Re: [PATCH] drm/arm/malidp: Consider rotation memory requirement in case of AFBC framebuffer

2018-11-12 Thread Alexandru-Cosmin Gheorghe
Hi Ayan, On Fri, Nov 09, 2018 at 10:37:19AM +, Ayan Halder wrote: > Rotation memory for layers is shared with AFBC decoder block. Thus one needs > to > calculate rotation memory requirement in case of AFBC framebuffer. This is > used later to verify if it can be sufficed by the hardware rotat

Re: [PATCH v4 3/4] drm/virtio: add in/out fence support for explicit synchronization

2018-11-12 Thread Gerd Hoffmann
Hi, > > > I had a look into this and how other drivers are doing it. > > > msm[1] and etnaviv[2] seem to use the same dual-use variable. > > > > Ok, lets do it the same way then. > > What is the status of the userspace side of this? > > The patch is hosted here[1], but is as of yet unmerged. >

Re: [kbuild-all] [PATCH] fbcon: Silence fbcon logo on 'quiet' boots

2018-11-12 Thread Prarit Bhargava
On 11/11/2018 10:18 PM, Rong Chen wrote: > > > On 10/29/2018 11:15 PM, Prarit Bhargava wrote: >> >> On 10/29/2018 09:56 AM, kbuild test robot wrote: >>> Hi Prarit, >>> >>> Thank you for the patch! Yet something to improve: >>> >>> [auto build test ERROR on sof-driver-fuweitax/master] >>> [also

[Bug 108270] [proton] Wolfenstein: The New Order (frame rate issue)

2018-11-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108270 --- Comment #1 from Adam Lyall --- I can confirm the same experience using a Radeon R9 285 with the Mesa 18.2.* series. The game for the most part runs really smooth but as soon as I reached the bunker shown on James B's Youtube video the framer

Re: [PATCH] udlfb: fix NULL pointer dereference in dlfb_usb_probe()

2018-11-12 Thread Mikulas Patocka
On Fri, 9 Nov 2018, Alexey Khoroshilov wrote: > If memory allocation for dlfb fails, error handling code > unconditionally dereference NULL pointer. > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Alexey Khoroshilov > Fixes: 68a958a915ca ("udlfb: handle u

Re: Performance regression in ast drm driver

2018-11-12 Thread Takashi Iwai
On Mon, 12 Nov 2018 15:36:07 +0100, Jean Delvare wrote: > > Hi David, > > On Fri, 2018-11-09 at 10:04 +1000, David Airlie wrote: > > On Thu, Nov 8, 2018 at 10:05 PM Jean Delvare wrote: > > > > > > On Thu, 1 Nov 2018 16:27:07 +0100, Jean Delvare wrote: > > > > Hi David, > > > > > > > > The foll

[Bug 99923] HITMAN (2016) having lighting and artefacting, and overly light room.

2018-11-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99923 --- Comment #44 from Alex Smith --- We released a game update last week, which includes a workaround for the out of bounds array access in a shader that was triggering this issue (thanks to Nicolai for giving us the details). That should fix the

[PATCH 1/2] drm/vc4: Fix memory leak during gpu reset.

2018-11-12 Thread Maarten Lankhorst
__drm_atomic_helper_crtc_destroy_state does not free memory, it only cleans it up. Fix this by calling the functions own destroy function. Fixes: 6d6e50039187 ("drm/vc4: Allocate the right amount of space for boot-time CRTC state.") Cc: Eric Anholt Cc: # v4.6+ Signed-off-by: Maarten Lankhorst

[PATCH 2/2] drm/atomic: Create and use __drm_atomic_helper_crtc_reset() everywhere

2018-11-12 Thread Maarten Lankhorst
We already have __drm_atomic_helper_connector_reset() and __drm_atomic_helper_plane_reset(), extend this to crtc as well. Most drivers already have a gpu reset hook, correct it. Nouveau already implemented its own __drm_atomic_helper_crtc_reset(), convert it to the common one. Signed-off-by: Maar

Re: [RFC] mm: Replace all open encodings for NUMA_NO_NODE

2018-11-12 Thread Anshuman Khandual
On 11/12/2018 02:13 PM, Hans Verkuil wrote: > On 11/12/2018 03:41 AM, Anshuman Khandual wrote: >> At present there are multiple places where invalid node number is encoded >> as -1. Even though implicitly understood it is always better to have macros >> in there. Replace these open encodings for

Re: [PATCH v2 8/9] phy: Add Cadence D-PHY support

2018-11-12 Thread Kishon Vijay Abraham I
Hi Maxime, On 06/11/18 8:24 PM, Maxime Ripard wrote: > Cadence has designed a D-PHY that can be used by the, currently in tree, > DSI bridge (DRM), CSI Transceiver and CSI Receiver (v4l2) drivers. > > Only the DSI driver has an ad-hoc driver for that phy at the moment, while > the v4l2 drivers ar

Re: [RFC] mm: Replace all open encodings for NUMA_NO_NODE

2018-11-12 Thread Anshuman Khandual
On 11/12/2018 09:27 AM, Joseph Qi wrote: > For ocfs2 part, node means host in the cluster, not NUMA node. > Does not -1 indicate an invalid node which can never be present ? ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.free

[RFC] mm: Replace all open encodings for NUMA_NO_NODE

2018-11-12 Thread Anshuman Khandual
At present there are multiple places where invalid node number is encoded as -1. Even though implicitly understood it is always better to have macros in there. Replace these open encodings for an invalid node number with the global macro NUMA_NO_NODE. This helps remove NUMA related assumptions like

[PATCH -next] drm/qxl: remove set but not used variables 'driver, qbo'

2018-11-12 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning: drivers/gpu/drm/qxl/qxl_release.c: In function 'qxl_release_fence_buffer_objects': drivers/gpu/drm/qxl/qxl_release.c:431:17: warning: variable 'qbo' set but not used [-Wunused-but-set-variable] drivers/gpu/drm/qxl/qxl_release.c:430:24: warning: va

Re: Performance regression in ast drm driver

2018-11-12 Thread Jean Delvare
Hi David, On Fri, 2018-11-09 at 10:04 +1000, David Airlie wrote: > On Thu, Nov 8, 2018 at 10:05 PM Jean Delvare wrote: > > > > On Thu, 1 Nov 2018 16:27:07 +0100, Jean Delvare wrote: > > > Hi David, > > > > > > The following commit: > > > > > > commit 7cf321d118a825c1541b43ca45294126fd474efa >

Re: [RFC] mm: Replace all open encodings for NUMA_NO_NODE

2018-11-12 Thread Anshuman Khandual
On 11/12/2018 09:40 AM, Anshuman Khandual wrote: > > > On 11/12/2018 09:27 AM, Joseph Qi wrote: >> For ocfs2 part, node means host in the cluster, not NUMA node. >> > > Does not -1 indicate an invalid node which can never be present ? > My bad, got it wrong. Seems like this is nothing to do

Re: [RFC] mm: Replace all open encodings for NUMA_NO_NODE

2018-11-12 Thread Joseph Qi
For ocfs2 part, node means host in the cluster, not NUMA node. Thanks, Joseph On 18/11/12 10:41, Anshuman Khandual wrote: > At present there are multiple places where invalid node number is encoded > as -1. Even though implicitly understood it is always better to have macros > in there. Replace t

Re: [PATCH v2 2/9] phy: Add configuration interface

2018-11-12 Thread Kishon Vijay Abraham I
Hi Maxime, On 06/11/18 8:24 PM, Maxime Ripard wrote: > The phy framework is only allowing to configure the power state of the PHY > using the init and power_on hooks, and their power_off and exit > counterparts. > > While it works for most, simple, PHYs supported so far, some more advanced > PHYs

Re: [PATCH 2/2] drm/atomic: Create and use __drm_atomic_helper_crtc_reset() everywhere

2018-11-12 Thread Boris Brezillon
On Mon, 12 Nov 2018 16:01:14 +0100 Maarten Lankhorst wrote: > We already have __drm_atomic_helper_connector_reset() and > __drm_atomic_helper_plane_reset(), extend this to crtc as well. > > Most drivers already have a gpu reset hook, correct it. > Nouveau already implemented its own __drm_atomic

[PATCH] drm/syncobj: Fix compilation following partial revert

2018-11-12 Thread Chris Wilson
We need to include the revert of commit 783195ec1cad ("drm/syncobj: disable the timeline UAPI for now v2") along with undoing the change to drm/i915. Fixes: 131280a162e7 ("drm: Revert syncobj timeline changes.") Signed-off-by: Chris Wilson Cc: Christian König Cc: Daniel Vetter --- drivers/gpu/

Re: [PATCH] drm/syncobj: Fix compilation following partial revert

2018-11-12 Thread Christian König
Am 12.11.18 um 16:21 schrieb Chris Wilson: We need to include the revert of commit 783195ec1cad ("drm/syncobj: disable the timeline UAPI for now v2") along with undoing the change to drm/i915. Fixes: 131280a162e7 ("drm: Revert syncobj timeline changes.") Signed-off-by: Chris Wilson Cc: Christia

Re: [PATCH 2/2] drm/atomic: Create and use __drm_atomic_helper_crtc_reset() everywhere

2018-11-12 Thread Li, Sun peng (Leo)
On 2018-11-12 10:01 AM, Maarten Lankhorst wrote: > We already have __drm_atomic_helper_connector_reset() and > __drm_atomic_helper_plane_reset(), extend this to crtc as well. > > Most drivers already have a gpu reset hook, correct it. > Nouveau already implemented its own __drm_atomic_helper_crt

[Bug 108704] 4.19 amdgpu Tonga powerplay regressions

2018-11-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108704 --- Comment #1 from Alex Deucher --- Does this patch fix the issue? https://patchwork.freedesktop.org/patch/259364/ -- You are receiving this mail because: You are the assignee for the bug.___ dri-de

[Bug 108704] 4.19 amdgpu Tonga powerplay regressions

2018-11-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108704 --- Comment #2 from Alex Deucher --- If not, can you bisect? -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailing list dri-devel@lists.freedesktop.org https:

Re: [PATCH 2/2] drm/atomic: Create and use __drm_atomic_helper_crtc_reset() everywhere

2018-11-12 Thread Heiko Stuebner
Am Montag, 12. November 2018, 16:01:14 CET schrieb Maarten Lankhorst: > We already have __drm_atomic_helper_connector_reset() and > __drm_atomic_helper_plane_reset(), extend this to crtc as well. > > Most drivers already have a gpu reset hook, correct it. > Nouveau already implemented its own __dr

Re: [PATCH 2/2] drm/atomic: Create and use __drm_atomic_helper_crtc_reset() everywhere

2018-11-12 Thread Thierry Reding
On Mon, Nov 12, 2018 at 04:01:14PM +0100, Maarten Lankhorst wrote: > We already have __drm_atomic_helper_connector_reset() and > __drm_atomic_helper_plane_reset(), extend this to crtc as well. > > Most drivers already have a gpu reset hook, correct it. > Nouveau already implemented its own __drm_a

[PATCH] drm: Fix compilation failure

2018-11-12 Thread Sean Paul
From: Sean Paul We had competing reverts/disable commits go in that caused issues with each other. Christian committed 783195ec1cad ("drm/syncobj: disable the timeline UAPI for now v2"), which moved the CREATE_TYPE_TIMELINE #define internally and added a check in drm_syncobj.c. When Eric reverte

Re: [PATCH] drm: Fix compilation failure

2018-11-12 Thread Sean Paul
On Mon, Nov 12, 2018 at 10:54 AM Sean Paul wrote: > > From: Sean Paul > Just saw Chris posted a fix to the list, please disregard this. Sean > We had competing reverts/disable commits go in that caused issues with > each other. > > Christian committed 783195ec1cad ("drm/syncobj: disable the ti

Re: [PATCH] drm/syncobj: Fix compilation following partial revert

2018-11-12 Thread Sean Paul
On Mon, Nov 12, 2018 at 03:21:30PM +, Chris Wilson wrote: > We need to include the revert of commit 783195ec1cad ("drm/syncobj: > disable the timeline UAPI for now v2") along with undoing the change to > drm/i915. > > Fixes: 131280a162e7 ("drm: Revert syncobj timeline changes.") > Signed-off-b

Re: [PATCH 2/2] drm/atomic: Create and use __drm_atomic_helper_crtc_reset() everywhere

2018-11-12 Thread Wentland, Harry
On 2018-11-12 10:01 a.m., Maarten Lankhorst wrote: > We already have __drm_atomic_helper_connector_reset() and > __drm_atomic_helper_plane_reset(), extend this to crtc as well. > > Most drivers already have a gpu reset hook, correct it. > Nouveau already implemented its own __drm_atomic_helper_c

Re: [PATCH 2/2] drm/atomic: Create and use __drm_atomic_helper_crtc_reset() everywhere

2018-11-12 Thread Sean Paul
On Mon, Nov 12, 2018 at 04:01:14PM +0100, Maarten Lankhorst wrote: > We already have __drm_atomic_helper_connector_reset() and > __drm_atomic_helper_plane_reset(), extend this to crtc as well. > > Most drivers already have a gpu reset hook, correct it. > Nouveau already implemented its own __drm_a

Re: [PATCH v7 3/5] drm: Document variable refresh properties

2018-11-12 Thread Wentland, Harry
On 2018-11-08 9:43 a.m., Nicholas Kazlauskas wrote: > These include the drm_connector 'vrr_capable' and the drm_crtc > 'vrr_enabled' properties. > > Signed-off-by: Nicholas Kazlauskas > Cc: Harry Wentland > Cc: Manasi Navare > Cc: Pekka Paalanen > Cc: Ville Syrjälä > Cc: Michel Dänzer Looks

[PATCH v5 2/4] drm/virtio: add uapi for in and out explicit fences

2018-11-12 Thread Robert Foss
Add a new field called fence_fd that will be used by userspace to send in-fences to the kernel and receive out-fences created by the kernel. This uapi enables virtio to take advantage of explicit synchronization of dma-bufs. There are two new flags: * VIRTGPU_EXECBUF_FENCE_FD_IN to be used when

[PATCH v5 4/4] drm/virtio: bump driver version after explicit synchronization addition

2018-11-12 Thread Robert Foss
From: Gustavo Padovan To reflect the (backward compatible) changes in the uabi we are bumping the driver's version. Signed-off-by: Gustavo Padovan Signed-off-by: Robert Foss Reviewed-by: Emil Velikov --- Changes since v3: - Emil: Added r-b drivers/gpu/drm/virtio/virtgpu_drv.h | 4 ++-- 1

[PATCH v5 1/4] drm/virtio: add virtio_gpu_alloc_fence()

2018-11-12 Thread Robert Foss
Refactor fence creation, add fences to relevant GPU operations and add cursor helper functions. This removes the potential for allocation failures from the cmd_submit and atomic_commit paths. Now a fence will be allocated first and only after that will we proceed with the rest of the execution. S

[PATCH v5 0/4] virgl: fence fd support

2018-11-12 Thread Robert Foss
This series implements fence support for drm/virtio and has been tested using qemu, kmscube and the below branches. Rob Herring solved a reference counting issue and suggested a context check for the execbuf ioctl, his changes have been included in the below commits to keep the tree working at al

[PATCH v5 3/4] drm/virtio: add in/out fence support for explicit synchronization

2018-11-12 Thread Robert Foss
When the execbuf call receives an in-fence it will get the dma_fence related to that fence fd and wait on it before submitting the draw call. On the out-fence side we get fence returned by the submitted draw call and attach it to a sync_file and send the sync_file fd to userspace. On error -1 is r

[PATCH 01/15] drm/vblank: Allow dynamic per-crtc max_vblank_count

2018-11-12 Thread Ville Syrjala
From: Ville Syrjälä On i965gm we need to adjust max_vblank_count dynamically depending on whether the TV encoder is used or not. To that end add a per-crtc max_vblank_count that takes precedence over its device wide counterpart. The driver can now call drm_crtc_set_max_vblank_count() to configure

[PATCH 00/15] drm/i915: Fix TV encoder support

2018-11-12 Thread Ville Syrjala
From: Ville Syrjälä Our TV encoder support isn't in the best shape. This series fixes it up quite a bit. The most important part is fixing the issues resulting from the lack of frame counter on i965gm which causes nasty flip_done timeouts when we attempt to do anything with the TV encoder (incl

[PATCH 02/15] drm/i915: Don't try to use the hardware frame counter with i965gm TV output

2018-11-12 Thread Ville Syrjala
From: Ville Syrjälä On i965gm the hardware frame counter does not work when the TV encoder is active. So let's not try to consult the hardware frame counter in that case. Instead we'll fall back to the timestamp based guesstimation method used on gen2. Note that the pipe timings generated by the

[PATCH 03/15] drm/i915/tv: Fix interlaced ysize calculation

2018-11-12 Thread Ville Syrjala
From: Ville Syrjälä Fix the calculation of the vertical active period for interlaced TV modes. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_tv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_tv.c b/drivers/gpu/drm/i915/intel_tv.c

[PATCH 06/15] drm/i915/tv: Use bools where appropriate

2018-11-12 Thread Ville Syrjala
From: Ville Syrjälä 'component_only' is a bool. Initialize it like a bool. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_tv.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_tv.c b/drivers/gpu/drm/i915/inte

[PATCH 07/15] drm/i915/tv: Nuke silly 0 initialzation of xpos/ypos

2018-11-12 Thread Ville Syrjala
From: Ville Syrjälä Just assign the margin values directly to xpos/ypos instead of first initializing to zero and then adding the values. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_tv.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i

[PATCH 04/15] drm/i915/tv: Fix tv mode clocks

2018-11-12 Thread Ville Syrjala
From: Ville Syrjälä The oversample clock is always supposed to be either 108 MHz or 148.5 MHz. Make it so. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_tv.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_tv.c b/drive

[PATCH 05/15] drm/i915/tv: Store the TV oversampling factor in the TV mode

2018-11-12 Thread Ville Syrjala
From: Ville Syrjälä Store the oversampling factor as a number in the TV modes. We shall want to arithmetic with this which is easier if it's a number we can use directly. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_tv.c | 42 ++--- 1 file changed, 28

[PATCH 11/15] drm/i915/tv: Nuke reported_modes[]

2018-11-12 Thread Ville Syrjala
From: Ville Syrjälä Remove the silly reported_modes[] array. I suppse once upon a time this actually had something to do with modes we reported to userspace. Now it is just the placeholder for the mode we use for load detection. We don't need it even for that, and instead we can just rely on the

[PATCH 07/15] drm/i915/tv: Nuke silly 0 inittialization of xpos/ypos

2018-11-12 Thread Ville Syrjala
From: Ville Syrjälä Just assign the margin values directly to xpos/ypos instead of first initializing to zero and then adding the values. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_tv.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i

[PATCH 09/15] drm/i915/tv: Use drm_mode_set_name() to name TV modes

2018-11-12 Thread Ville Syrjala
From: Ville Syrjälä No point in storing the mode names in the array. drm_mode_set_name() will give us the same names without wasting space for these string constants. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_tv.c | 21 +++-- 1 file changed, 11 insertions(+),

Re: [PATCH v2 0/7] tda998x: allow use with bridge based devices

2018-11-12 Thread Russell King - ARM Linux
On Mon, Nov 12, 2018 at 04:50:37PM +, Peter Rosin wrote: > On 2018-08-02 08:06, Peter Rosin wrote: > > On 2018-08-01 11:35, Russell King - ARM Linux wrote: > >> On Wed, Aug 01, 2018 at 11:01:12AM +0200, Peter Rosin wrote: > >>> I don't think it's a problem with the atmel I2C driver. IIRC, the >

[PATCH 08/15] drm/i915/tv: Deobfuscate preferred mode selection

2018-11-12 Thread Ville Syrjala
From: Ville Syrjälä Rewrite the preferred mode selection to just check whether the TV modes is HD or SD. For SD TV modes we favor 480 line modes, for 720p we prefer 720 line modes, and for 1080i/p we prefer 1080 line modes. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_tv.c | 50

[PATCH 12/15] drm/i915/tv: Add 1080p30/50/60 TV modes

2018-11-12 Thread Ville Syrjala
From: Ville Syrjälä Add the missing 1080p TV modes. On gen4 all of them work just fine, whereas on gen3 only the 30Hz mode actually works correctly. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_tv.c | 90 +++-- 1 file changed, 86 insertions(+), 4 dele

[PATCH 15/15] drm/i915/tv: Filter out >1024 wide modes that would need vertical scaling on gen3

2018-11-12 Thread Ville Syrjala
From: Ville Syrjälä Since gen3 can't handle >1024 wide sources with vertical scaling let's not advertize such modes in the mode list. Less tempetation to the user to try out things that won't work. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_tv.c | 6 ++ 1 file changed, 6 i

[PATCH 10/15] drm/i915/tv: Make TV mode autoselection actually useable

2018-11-12 Thread Ville Syrjala
From: Ville Syrjälä The current code insists on picking a new TV mode when switching between component and non-component cables. That's super annoying. Let's just keep the current TV mode unless the new cable type actually disagrees with it. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i91

[PATCH 14/15] drm/i915/tv: Fix >1024 modes on gen3

2018-11-12 Thread Ville Syrjala
From: Ville Syrjälä On gen3 we must disable the TV encoder vertical filter for >1024 pixel wide sources. Once that's done all we can is try to center the image on the screen. Naturally the TV mode vertical resolution must be equal or larger than the user mode vertical resolution or else we'd have

[PATCH 13/15] drm/i915/tv: Generate better pipe timings for TV encoder

2018-11-12 Thread Ville Syrjala
From: Ville Syrjälä To make vblank timestamps work better with the TV encoder let's scale the pipe timings such that the relationship between the TV active and TV blanking periods is mirrored in the corresponding pipe timings. Note that in reality the pipe runs at a faster speed during the TV vb

Re: [PATCH v7 3/5] drm: Document variable refresh properties

2018-11-12 Thread Kazlauskas, Nicholas
On 11/12/18 11:12 AM, Wentland, Harry wrote: > On 2018-11-08 9:43 a.m., Nicholas Kazlauskas wrote: >> These include the drm_connector 'vrr_capable' and the drm_crtc >> 'vrr_enabled' properties. >> >> Signed-off-by: Nicholas Kazlauskas >> Cc: Harry Wentland >> Cc: Manasi Navare >> Cc: Pekka Paala

Re: [PATCH 2/2] drm/atomic: Create and use __drm_atomic_helper_crtc_reset() everywhere

2018-11-12 Thread Maarten Lankhorst
Op 12-11-18 om 17:11 schreef Sean Paul: > On Mon, Nov 12, 2018 at 04:01:14PM +0100, Maarten Lankhorst wrote: >> We already have __drm_atomic_helper_connector_reset() and >> __drm_atomic_helper_plane_reset(), extend this to crtc as well. >> >> Most drivers already have a gpu reset hook, correct it.

[PATCH] drm/panel: simple: fix AUO g185han01 horizontal blanking

2018-11-12 Thread Lucas Stach
The horizontal blanking periods are too short, as the values are specified for a single LVDS channel. Since this panel is dual LVDS they need to be doubled. With this change the panel reaches its nominal vrefresh rate of 60Fps, instead of the 64Fps with the current wrong blanking. Signed-off-by: L

Re: [Intel-gfx] [PATCH 2/2] drm/atomic: Create and use __drm_atomic_helper_crtc_reset() everywhere

2018-11-12 Thread Ville Syrjälä
On Mon, Nov 12, 2018 at 04:01:14PM +0100, Maarten Lankhorst wrote: > We already have __drm_atomic_helper_connector_reset() and > __drm_atomic_helper_plane_reset(), extend this to crtc as well. > > Most drivers already have a gpu reset hook, correct it. > Nouveau already implemented its own __drm_a

[Bug 99923] HITMAN (2016) having lighting and artefacting, and overly light room.

2018-11-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99923 --- Comment #45 from Gregor Münch --- Thats very good news. Thx for the effort! I just checked that with Vulkan the game works but standard opengl crash on start. Will contact support. -- You are receiving this mail because: You are the assigne

Re: Performance regression in ast drm driver

2018-11-12 Thread Thomas Zimmermann
Hi Jean Am 12.11.18 um 15:36 schrieb Jean Delvare: > Hi David, > > On Fri, 2018-11-09 at 10:04 +1000, David Airlie wrote: >> On Thu, Nov 8, 2018 at 10:05 PM Jean Delvare wrote: >>> >>> On Thu, 1 Nov 2018 16:27:07 +0100, Jean Delvare wrote: Hi David, The following commit:

[PATCH 00/12] drm/msm: dpu: Clean up runtime power handling

2018-11-12 Thread Sean Paul
From: Sean Paul I started pulling a thread last week when looking at dpu locking. It led me into the power_handle code and eventually runtime suspend/resume. This set removes the power_handle stuff entirely. I'm sure it's more useful when there are multiple clients/handles/events, but for our ca

[PATCH 02/12] drm/msm: dpu: Remove unused trace_dpu_perf_update_bus()

2018-11-12 Thread Sean Paul
From: Sean Paul Signed-off-by: Sean Paul --- drivers/gpu/drm/msm/disp/dpu1/dpu_trace.h | 21 - 1 file changed, 21 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_trace.h b/drivers/gpu/drm/msm/disp/dpu1/dpu_trace.h index 0c122e173892..7ab0ba8224f6 100644 --- a/d

[PATCH 01/12] drm/msm: dpu: Remove dpu_power_handle_get_dbus_name()

2018-11-12 Thread Sean Paul
From: Sean Paul It's only used for debugfs, so just output the enum value instead. Signed-off-by: Sean Paul --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 6 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_power_handle.c | 14 -- drivers/gpu/drm/msm/disp/dpu1/dpu_power_handle.h |

[PATCH 03/12] drm/msm: dpu: Remove dpu_power_client

2018-11-12 Thread Sean Paul
From: Sean Paul There's only one client -- core, and it's only used for runtime pm which is already refcounted. Signed-off-by: Sean Paul --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 22 + drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h | 1 - .../gpu/drm/msm/disp/dpu1/dpu_power_handl

[PATCH 04/12] drm/msm: dpu: Don't use power_event for vbif_init_memtypes

2018-11-12 Thread Sean Paul
From: Sean Paul power_events are only used for pm_runtime, and that's all handled in dpu_kms. So just call vbif_init_memtypes at the correct times. Signed-off-by: Sean Paul --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 21 +++-- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h | 1 - 2

[PATCH 05/12] drm/msm: dpu: Handle crtc pm_runtime_resume() directly

2018-11-12 Thread Sean Paul
From: Sean Paul Instead of registering through dpu_power_handle just to get a call on runtime_resume, call the crtc function directly. Signed-off-by: Sean Paul --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 23 ++- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h | 10 ++

[PATCH 06/12] drm/msm: dpu: Remove power_handle from core_perf

2018-11-12 Thread Sean Paul
From: Sean Paul It's unused Signed-off-by: Sean Paul --- drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 3 --- drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.h | 5 - drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 1 - 3 files changed, 9 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/d

[PATCH 07/12] drm/msm: dpu: Include dpu_io_util.h directly in dpu_kms.h

2018-11-12 Thread Sean Paul
From: Sean Paul It's needed for struct dss_module_power, and is currently being pulled in by dpu_power_handle.h Signed-off-by: Sean Paul --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h b/drivers/gpu/drm/ms

[PATCH 08/12] drm/msm: dpu: Move DPU_POWER_HANDLE_DBUS_ID to core_perf

2018-11-12 Thread Sean Paul
From: Sean Paul It's only used in core_perf, so stick it there (and change the name to reflect that). Signed-off-by: Sean Paul --- drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 34 +-- drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.h | 17 -- drivers/gpu/drm/msm/disp/dpu

[PATCH 09/12] drm/msm: dpu: Remove dpu_power_handle

2018-11-12 Thread Sean Paul
From: Sean Paul Now that we don't have any event handlers, remove dpu_power_handle! Signed-off-by: Sean Paul --- drivers/gpu/drm/msm/Makefile | 1 - drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 11 -- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h | 3 - .../gpu/drm/msm

[PATCH 10/12] drm/msm: dpu: Fix typo in dpu_encoder

2018-11-12 Thread Sean Paul
From: Sean Paul enc_spinlock instead of enc_spin_lock. Signed-off-by: Sean Paul --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c index 8

[PATCH 11/12] drm/msm: dpu: Add ->enabled to dpu_encoder_virt

2018-11-12 Thread Sean Paul
From: Sean Paul Add a bool to dpu_encoder_virt to track whether the encoder is enabled or not. Repurpose the enc_lock mutex to ensure that it is consistent with the hw state. Signed-off-by: Sean Paul --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 27 + 1 file changed, 22

[PATCH 12/12] drm/msm: dpu: Move crtc runtime resume to encoder

2018-11-12 Thread Sean Paul
From: Sean Paul The crtc runtime resume doesn't actually operate on the crtc, but rather its encoders. The problem with this is that we need to inspect the crtc state to get the currently connected encoders. Since runtime resume isn't guaranteed to be called while holding the modeset locks (altho

Re: [PATCH 2/2] drm/atomic: Create and use __drm_atomic_helper_crtc_reset() everywhere

2018-11-12 Thread Liviu Dudau
On Mon, Nov 12, 2018 at 04:01:14PM +0100, Maarten Lankhorst wrote: > We already have __drm_atomic_helper_connector_reset() and > __drm_atomic_helper_plane_reset(), extend this to crtc as well. > > Most drivers already have a gpu reset hook, correct it. > Nouveau already implemented its own __drm_a

[PATCH 1/3] drm/msm: dpu: Grab the modeset locks in frame_event

2018-11-12 Thread Sean Paul
From: Sean Paul This patch wraps dpu_core_perf_crtc_release_bw() with modeset locks since it digs into the state objects. Signed-off-by: Sean Paul --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c b/driv

[PATCH 3/3] drm/msm: dpu: Add modeset lock checks where applicable

2018-11-12 Thread Sean Paul
From: Sean Paul Add modeset lock checks to functions that could be called outside the core atomic stack. Signed-off-by: Sean Paul --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 2 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 1 + 2 files changed, 3 insertions(+) diff --git a/drivers/gpu/drm/

[PATCH 2/3] drm/msm: dpu: Stop using encoder->crtc pointer

2018-11-12 Thread Sean Paul
From: Sean Paul It's for legacy drivers, for atomic drivers crtc->state->encoder_mask should be used to map encoder to crtc. Signed-off-by: Sean Paul --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 46 drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 19 +++--- 2 files ch

  1   2   >